date:20141104

[Powerdevil] [Bug 339427] Screen goes off when watching video using VLC or YouTube.

2014-11-04 Thread Phil Schaf

https://bugs.kde.org/show_bug.cgi?id=339427

Phil Schaf  changed:

   What|Removed |Added

 CC||flying-sh...@web.de
 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 340652] New: Regression: Activity-specific settings gone

2014-11-04 Thread Phil Schaf

https://bugs.kde.org/show_bug.cgi?id=340652

Bug ID: 340652
   Summary: Regression: Activity-specific settings gone
   Product: Powerdevil
   Version: 5.1.0
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: flying-sh...@web.de

Since KDE can’t figure out that a) something is fullscreen and b) my gamepad is
used, i need to keep my screen from turning black by switching to a “gaming”
activity that has screen dimming & blackening turned off.

The necessary settings are missing in plasma 5 / KF5.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120997: Add timestamp to notification history

2014-11-04 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120997/
---

(Updated Nov. 4, 2014, 9:33 nachm.)

Review request for Plasma, KDE Usability and Martin Klapetek.

Changes
---

Show relative timestamp (Just now, 10s ago, 30s ago, 1min ago, 2min ago, …,
59min ago, 13:37)

It is updated when you open the plasmoid since we cannot connect to anything
anyway and it's not worth wasting CPU cycles by using eg. a Timer.

Repository: plasma-workspace

Description
---

This simple patch shows the time when a notification was added to the history.

Of course would be fancy to have "1min ago", "5min ago" etc but that's much
more complicated since we cannot listen to changes of a Date() object but would
need to pull in the dataengine and then we get timezone sync issues and what
not. So this just stores a Date() object and displays it as hours.

Diffs (updated)
-

applets/notifications/package/contents/ui/Notifications.qml 47a475a
applets/notifications/package/contents/ui/NotificationDelegate.qml 75bcfd5
applets/notifications/package/contents/ui/NotificationItem.qml 724cc13

Diff: https://git.reviewboard.kde.org/r/120997/diff/

Testing
---

Pretty nifty! The looks could be improved a bit I guess.

File Attachments (updated)

Notification history with timestamp

https://git.reviewboard.kde.org/media/uploaded/files/2014/11/04/20f3c850-0f64-4807-bbde-064bf730d830__notificationtimestamp.png
Multiple notifications with relative time

https://git.reviewboard.kde.org/media/uploaded/files/2014/11/04/f4979255-2971-4458-bf2c-ec05819591e5__notificationtimestamp1.png

Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 120997: Add timestamp to notification history

2014-11-04 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120997/
---

Review request for Plasma, KDE Usability and Martin Klapetek.


Repository: plasma-workspace


Description
---

This simple patch shows the time when a notification was added to the history.

Of course would be fancy to have "1min ago", "5min ago" etc but that's much 
more complicated since we cannot listen to changes of a Date() object but would 
need to pull in the dataengine and then we get timezone sync issues and what 
not. So this just stores a Date() object and displays it as hours.


Diffs
-

  applets/notifications/package/contents/ui/NotificationDelegate.qml 75bcfd5 
  applets/notifications/package/contents/ui/NotificationItem.qml 724cc13 
  applets/notifications/package/contents/ui/Notifications.qml 47a475a 

Diff: https://git.reviewboard.kde.org/r/120997/diff/


Testing
---

Pretty nifty! The looks could be improved a bit I guess.


File Attachments


Notification history with timestamp
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/04/20f3c850-0f64-4807-bbde-064bf730d830__notificationtimestamp.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 120993: Cleanup Notifications.qml

2014-11-04 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120993/
---

Review request for Plasma and Martin Klapetek.


Repository: plasma-workspace


Description
---

This cleans up the code in Notifications.qml a bit
 - Some minor code style stuff
 - new Array() ? []
 - Pass the notification object we get from the data engine to addNotification 
directly to avoid this ugly function with dozen parameters and creating the 
object ourselves which we alredy almost get for free already
 - Push actions into array directly instead of creating a new Object, settings 
its properties and then pushing it


Diffs
-

  applets/notifications/package/contents/ui/Notifications.qml 47a475a 

Diff: https://git.reviewboard.kde.org/r/120993/diff/


Testing
---

Didn't notice anything unusual after running knotificationsdbustest


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120943: Move duplicated code from NotificationDelegate and NotificationPopup into a new NotificationItem

2014-11-04 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120943/
---

(Updated Nov. 4, 2014, 7:36 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Martin Klapetek.


Repository: plasma-workspace


Description
---

This moves duplicate code (notification icon, heading, text, action buttons) 
into a separate NotificationItem {} component used by both the notification 
popup as well as the notification list delegate.

If we ever were to provide richer notifications for specific usecases (you can 
provide custom hints in notifications after all) this would ease this and less 
duplication is always good :)

I also cleaned up a bit of commented/unused code and changed complicated 
anchoring to QtQuick Layouts where applicable.


Diffs
-

  applets/notifications/package/contents/ui/NotificationDelegate.qml 88f6cd2 
  applets/notifications/package/contents/ui/NotificationItem.qml PRE-CREATION 
  applets/notifications/package/contents/ui/NotificationPopup.qml 26c7ed2 

Diff: https://git.reviewboard.kde.org/r/120943/diff/


Testing
---

Ran knotificationdbustest and didn't notice anything unusual, visually the 
thing should look and behave exactly like it did before. Additional testing is 
welcomed, however.


File Attachments


New popup
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/02/9b20416e-a4c6-4694-aff3-bdad26cf3206__newnotificationpopup.png
New history
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/03/e7efdf8f-09de-4eaf-a7a2-d37979bad28b__newnotificationhistory.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 340617] Breeze dark theme has bright breeze dialog background

2014-11-04 Thread Martin Klapetek

https://bugs.kde.org/show_bug.cgi?id=340617

Martin Klapetek  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |DUPLICATE

--- Comment #3 from Martin Klapetek  ---


*** This bug has been marked as a duplicate of bug 340086 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 340617] Breeze dark theme has bright breeze dialog background

2014-11-04 Thread a.pronobis

https://bugs.kde.org/show_bug.cgi?id=340617

--- Comment #2 from a.prono...@gmail.com ---
It's in the URL above. Also here:
https://dl.dropboxusercontent.com/u/3454148/breeze_dark.png

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120352: Remove keyboard click volume setting

2014-11-04 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120352/
---

(Updated Nov. 4, 2014, 5:12 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Frederik Gladhorn.


Repository: plasma-desktop


Description
---

They keyboard daemon had a weird option for making your system make a
short beep whenever you pressed a key.

This doesn't work and doesn't seem particularly useful.


Diffs
-

  kcms/keyboard/kcmmisc.h 411bdd2 
  kcms/keyboard/kcmmisc.cpp c63d06b 
  kcms/keyboard/kcmmiscwidget.ui 37fbaf4 
  kcms/keyboard/keyboard_hardware.cpp df5f417 

Diff: https://git.reviewboard.kde.org/r/120352/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120980: Proper API for "Play all" function

2014-11-04 Thread Bhushan Shah


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120980/
---

(Updated Nov. 4, 2014, 4:54 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and 
Sujith Haridasan.


Repository: plasma-mediacenter


Description
---

- AbstractBrowsingBackend::allMedia() returns all media in QStringList
- PlaylistModel::addAllToPlaylist() to add QStringList in current playlist
- This all is handled by mediabrowser and playlist.qml


Diffs
-

  browsingbackends/metadatamusicbackend/metadatamusicbackend.h 
c9f10a77753f7427f669da9cb5e46cf66994f57d 
  browsingbackends/metadatamusicbackend/metadatamusicbackend.cpp 
f4f908047586694188a354bc69ecc49824f15fe7 
  libs/mediacenter/abstractbrowsingbackend.h 
910272a93ec047418ad1a4c6534592bb20fcba60 
  libs/mediacenter/abstractbrowsingbackend.cpp 
c24d5178d91a09b4e9f8b5b74d7a88616a8b9756 
  libs/mediacenter/playlistmodel.h d45611c1eaddb657ce3ed97731e9e70990b7a060 
  libs/mediacenter/playlistmodel.cpp 501e501888d53fd0fdd6574a72988408307b3f7b 
  mediaelements/mediabrowser/MediaBrowser.qml 
97942881d08c12539675ba08d7fc6a8b28206fb5 
  mediaelements/playlist/Playlist.qml f39be2a8a695499fc05d69cd0c13d70e18356142 
  shells/next/contents/views/Desktop.qml 
8ed3d1e2e013cbfd0aac9d0fca099901fac3f237 

Diff: https://git.reviewboard.kde.org/r/120980/diff/


Testing
---

works fine


Thanks,

Bhushan Shah

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120980: Proper API for "Play all" function

2014-11-04 Thread Shantanu Tushar


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120980/#review69831
---

Ship it!


Looks good, some minor fixes and this can go in.


browsingbackends/metadatamusicbackend/metadatamusicbackend.cpp


pull m_musicFilteredModel->index(i, 0) into a variable



browsingbackends/metadatamusicbackend/metadatamusicbackend.cpp


use auto



libs/mediacenter/abstractbrowsingbackend.cpp


return QStringList();


- Shantanu Tushar


On Nov. 4, 2014, 1:44 p.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120980/
> ---
> 
> (Updated Nov. 4, 2014, 1:44 p.m.)
> 
> 
> Review request for Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> - AbstractBrowsingBackend::allMedia() returns all media in QStringList
> - PlaylistModel::addAllToPlaylist() to add QStringList in current playlist
> - This all is handled by mediabrowser and playlist.qml
> 
> 
> Diffs
> -
> 
>   browsingbackends/metadatamusicbackend/metadatamusicbackend.h 
> c9f10a77753f7427f669da9cb5e46cf66994f57d 
>   browsingbackends/metadatamusicbackend/metadatamusicbackend.cpp 
> f4f908047586694188a354bc69ecc49824f15fe7 
>   libs/mediacenter/abstractbrowsingbackend.h 
> 910272a93ec047418ad1a4c6534592bb20fcba60 
>   libs/mediacenter/abstractbrowsingbackend.cpp 
> c24d5178d91a09b4e9f8b5b74d7a88616a8b9756 
>   libs/mediacenter/playlistmodel.h d45611c1eaddb657ce3ed97731e9e70990b7a060 
>   libs/mediacenter/playlistmodel.cpp 501e501888d53fd0fdd6574a72988408307b3f7b 
>   mediaelements/mediabrowser/MediaBrowser.qml 
> 97942881d08c12539675ba08d7fc6a8b28206fb5 
>   mediaelements/playlist/Playlist.qml 
> f39be2a8a695499fc05d69cd0c13d70e18356142 
>   shells/next/contents/views/Desktop.qml 
> 8ed3d1e2e013cbfd0aac9d0fca099901fac3f237 
> 
> Diff: https://git.reviewboard.kde.org/r/120980/diff/
> 
> 
> Testing
> ---
> 
> works fine
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120949: Add imageprovider to fifteenpuzzle.

2014-11-04 Thread Marco Martin



> On Nov. 3, 2014, 9:51 a.m., Marco Martin wrote:
> > looks a bit overkill?
> 
> Jeremy Whiting wrote:
> Marco,
> 
> Can you be more specific? which bit is overkill?

having an imageprovider for the pieces.. but i cannot think about other 
solutions less complicated (like a custom painted item that is worse)
so i think is fine


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120949/#review69718
---


On Nov. 2, 2014, 10:09 p.m., Jeremy Whiting wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120949/
> ---
> 
> (Updated Nov. 2, 2014, 10:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> ImageProvider plugin start, pieceWidth and pieceHeight are both 30 for now,
> but need to come from the qml. This is a first attempt posting to get
> feedback about the approach etc.
> 
> 
> Diffs
> -
> 
>   applets/fifteenPuzzle/package/contents/config/main.xml 
> 0dd804a12ddb0c7c2daaced1b92582f0deff494f 
>   applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml 
> bf9581bd78c1c7690fc16f01e440adad0fc98766 
>   applets/fifteenPuzzle/package/contents/ui/Piece.qml 
> c386570aebdf4323e3132aa05445b38383149dea 
>   applets/fifteenPuzzle/package/contents/ui/configAppearance.qml 
> d78c91b6e4182a2e461c1ee355b6ad30b63fbc68 
>   applets/fifteenPuzzle/package/contents/ui/main.qml 
> c76eaeb4d936fe917d99375722905c2f002c33e6 
>   applets/fifteenPuzzle/plugin/fifteenimageprovider.h PRE-CREATION 
>   applets/fifteenPuzzle/plugin/fifteenimageprovider.cpp PRE-CREATION 
>   applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.h PRE-CREATION 
>   applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.cpp PRE-CREATION 
>   applets/fifteenPuzzle/plugin/qmldir PRE-CREATION 
>   applets/fifteenPuzzle/CMakeLists.txt 
> c7e6a718a6211e0cde1121609ed28ec0fe8448f7 
> 
> Diff: https://git.reviewboard.kde.org/r/120949/diff/
> 
> 
> Testing
> ---
> 
> It builds and runs, currently doesn't shuffle, to test the result image works 
> and appears.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120949: Add imageprovider to fifteenpuzzle.

2014-11-04 Thread Jeremy Whiting



> On Nov. 3, 2014, 2:51 a.m., Marco Martin wrote:
> > looks a bit overkill?

Marco,

Can you be more specific? which bit is overkill?


- Jeremy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120949/#review69718
---


On Nov. 2, 2014, 3:09 p.m., Jeremy Whiting wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120949/
> ---
> 
> (Updated Nov. 2, 2014, 3:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> ImageProvider plugin start, pieceWidth and pieceHeight are both 30 for now,
> but need to come from the qml. This is a first attempt posting to get
> feedback about the approach etc.
> 
> 
> Diffs
> -
> 
>   applets/fifteenPuzzle/package/contents/config/main.xml 
> 0dd804a12ddb0c7c2daaced1b92582f0deff494f 
>   applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml 
> bf9581bd78c1c7690fc16f01e440adad0fc98766 
>   applets/fifteenPuzzle/package/contents/ui/Piece.qml 
> c386570aebdf4323e3132aa05445b38383149dea 
>   applets/fifteenPuzzle/package/contents/ui/configAppearance.qml 
> d78c91b6e4182a2e461c1ee355b6ad30b63fbc68 
>   applets/fifteenPuzzle/package/contents/ui/main.qml 
> c76eaeb4d936fe917d99375722905c2f002c33e6 
>   applets/fifteenPuzzle/plugin/fifteenimageprovider.h PRE-CREATION 
>   applets/fifteenPuzzle/plugin/fifteenimageprovider.cpp PRE-CREATION 
>   applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.h PRE-CREATION 
>   applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.cpp PRE-CREATION 
>   applets/fifteenPuzzle/plugin/qmldir PRE-CREATION 
>   applets/fifteenPuzzle/CMakeLists.txt 
> c7e6a718a6211e0cde1121609ed28ec0fe8448f7 
> 
> Diff: https://git.reviewboard.kde.org/r/120949/diff/
> 
> 
> Testing
> ---
> 
> It builds and runs, currently doesn't shuffle, to test the result image works 
> and appears.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [plasma-devel] Re: Release Schedule adjustments

2014-11-04 Thread Jonathan Riddell

On Tue, Nov 04, 2014 at 04:45:04PM +0100, Sebastian Kügler wrote:
> Tagging on Thursday means release on Tuesday, 27th January, right? Should I 
> add it to the schedule?

That's right but it is already part of the table on the wiki and the e-mail in 
this thread.

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Release Schedule adjustments

2014-11-04 Thread Sebastian Kügler

On Tuesday, November 04, 2014 16:22:22 Jonathan Riddell wrote:
> I've updated the release schedule with the dates discussed at the meeting
> yesterday
> 
> https://techbase.kde.org/Schedules/Plasma_5
> 
> 5.1.95BetaThu 2015-01-08  Tue 2015-01-13  Message, feature and 
artwork
> freeze 5.2.0  Release Thu 2015-01-22  Tue 2015-01-27  Final tag, only 
urgent
> fixes approved by release dude, Plasma/5.2 branch made
> 
> these are delayed by a couple of weeks so they can use KF 5.6.  It also
> means the Beta isn't over the new year holidays.

Thanks!

I think we should also add the actual release date, right now, it ends with 
the tagging (which is the relevant point for developers), but people who might 
expect a "real release date" might end up confused.

Tagging on Thursday means release on Tuesday, 27th January, right? Should I 
add it to the schedule?

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Release Schedule adjustments

2014-11-04 Thread Jonathan Riddell

I've updated the release schedule with the dates discussed at the meeting
yesterday

https://techbase.kde.org/Schedules/Plasma_5

5.1.95 Beta Thu 2015-01-08 Tue 2015-01-13 Message, feature and artwork
freeze 5.2.0 Release Thu 2015-01-22 Tue 2015-01-27 Final tag, only urgent
fixes approved by release dude, Plasma/5.2 branch made
these are delayed by a couple of weeks so they can use KF 5.6.  It also
means the Beta isn't over the new year holidays.

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120957: Oxygen: Sync advanced settings to KDE4

2014-11-04 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120957/
---

(Updated Nov. 4, 2014, 3:11 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Hugo Pereira Da Costa.


Repository: oxygen


Description
---

Sync advanced settings to KDE4


Diffs
-

  kstyle/config/oxygenstyleconfig.cpp 8185910 

Diff: https://git.reviewboard.kde.org/r/120957/diff/


Testing
---

Copies data correctly.

Oxygen KDE4 apps update after reload. 
They don't update immediately but that bug is unrelated as that isn't happening 
when running "kcmshell4 style"


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to stable : plasma-workspace_master_qt5 #1022

2014-11-04 Thread KDE CI System

See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Change in plasma-framework[master]: workaround on textarea input breaking

2014-11-04 Thread Marco Martin (Code Review)

Marco Martin has uploaded a new change for review.

  https://gerrit.vesnicky.cesnet.cz/r/145

Change subject: workaround on textarea input breaking
..

workaround on textarea input breaking

this makes sure if there is an item with focus in the applet,
it and all its parent are removed the focus when the applet is deleted.
otherwise when there is an item with focus that loses its qquickwindow,
it will never be able to gain it again
it's a workaround but i'm not sure how should be fixed in qquickitem,
or if is even appropriate

Change-Id: I72c8f01d4557003604c4261ca5a9ab49dd136b02
---
M src/scriptengines/qml/plasmoid/appletinterface.cpp
M src/scriptengines/qml/plasmoid/appletinterface.h
2 files changed, 35 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework 
refs/changes/45/145/1
-- 
To view, visit https://gerrit.vesnicky.cesnet.cz/r/145
To unsubscribe, visit https://gerrit.vesnicky.cesnet.cz/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I72c8f01d4557003604c4261ca5a9ab49dd136b02
Gerrit-PatchSet: 1
Gerrit-Project: plasma-framework
Gerrit-Branch: master
Gerrit-Owner: Marco Martin 
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120980: Proper API for "Play all" function

2014-11-04 Thread Bhushan Shah


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120980/
---

(Updated Nov. 4, 2014, 7:14 p.m.)


Review request for Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and 
Sujith Haridasan.


Repository: plasma-mediacenter


Description
---

- AbstractBrowsingBackend::allMedia() returns all media in QStringList
- PlaylistModel::addAllToPlaylist() to add QStringList in current playlist
- This all is handled by mediabrowser and playlist.qml


Diffs (updated)
-

  browsingbackends/metadatamusicbackend/metadatamusicbackend.h 
c9f10a77753f7427f669da9cb5e46cf66994f57d 
  browsingbackends/metadatamusicbackend/metadatamusicbackend.cpp 
f4f908047586694188a354bc69ecc49824f15fe7 
  libs/mediacenter/abstractbrowsingbackend.h 
910272a93ec047418ad1a4c6534592bb20fcba60 
  libs/mediacenter/abstractbrowsingbackend.cpp 
c24d5178d91a09b4e9f8b5b74d7a88616a8b9756 
  libs/mediacenter/playlistmodel.h d45611c1eaddb657ce3ed97731e9e70990b7a060 
  libs/mediacenter/playlistmodel.cpp 501e501888d53fd0fdd6574a72988408307b3f7b 
  mediaelements/mediabrowser/MediaBrowser.qml 
97942881d08c12539675ba08d7fc6a8b28206fb5 
  mediaelements/playlist/Playlist.qml f39be2a8a695499fc05d69cd0c13d70e18356142 
  shells/next/contents/views/Desktop.qml 
8ed3d1e2e013cbfd0aac9d0fca099901fac3f237 

Diff: https://git.reviewboard.kde.org/r/120980/diff/


Testing
---

works fine


Thanks,

Bhushan Shah

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 120980: Proper API for "Play all" function

2014-11-04 Thread Bhushan Shah


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120980/
---

Review request for Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and 
Sujith Haridasan.


Repository: plasma-mediacenter


Description
---

- AbstractBrowsingBackend::allMedia() returns all media in QStringList
- PlaylistModel::addAllToPlaylist() to add QStringList in current playlist
- This all is handled by mediabrowser and playlist.qml


Diffs
-

  browsingbackends/metadatamusicbackend/metadatamusicbackend.h 
c9f10a77753f7427f669da9cb5e46cf66994f57d 
  browsingbackends/metadatamusicbackend/metadatamusicbackend.cpp 
f4f908047586694188a354bc69ecc49824f15fe7 
  libs/mediacenter/abstractbrowsingbackend.h 
910272a93ec047418ad1a4c6534592bb20fcba60 
  libs/mediacenter/abstractbrowsingbackend.cpp 
c24d5178d91a09b4e9f8b5b74d7a88616a8b9756 
  libs/mediacenter/playlistmodel.h d45611c1eaddb657ce3ed97731e9e70990b7a060 
  libs/mediacenter/playlistmodel.cpp 501e501888d53fd0fdd6574a72988408307b3f7b 
  mediaelements/mediabrowser/MediaBrowser.qml 
97942881d08c12539675ba08d7fc6a8b28206fb5 
  mediaelements/playlist/Playlist.qml f39be2a8a695499fc05d69cd0c13d70e18356142 
  shells/next/contents/views/Desktop.qml 
8ed3d1e2e013cbfd0aac9d0fca099901fac3f237 

Diff: https://git.reviewboard.kde.org/r/120980/diff/


Testing
---

works fine


Thanks,

Bhushan Shah

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120957: Oxygen: Sync advanced settings to KDE4

2014-11-04 Thread Hugo Pereira Da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120957/#review69805
---

Ship it!


no objection then !

- Hugo Pereira Da Costa


On Nov. 3, 2014, 2:24 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120957/
> ---
> 
> (Updated Nov. 3, 2014, 2:24 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: oxygen
> 
> 
> Description
> ---
> 
> Sync advanced settings to KDE4
> 
> 
> Diffs
> -
> 
>   kstyle/config/oxygenstyleconfig.cpp 8185910 
> 
> Diff: https://git.reviewboard.kde.org/r/120957/diff/
> 
> 
> Testing
> ---
> 
> Copies data correctly.
> 
> Oxygen KDE4 apps update after reload. 
> They don't update immediately but that bug is unrelated as that isn't 
> happening when running "kcmshell4 style"
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120957: Oxygen: Sync advanced settings to KDE4

2014-11-04 Thread David Edmundson



> On Nov. 4, 2014, 12:21 p.m., Hugo Pereira Da Costa wrote:
> > what about dependencies ? Are we happy with oxygen KF5 style always 
> > depending on Kdelibs4Migration ? (I don't know which framework it belongs 
> > to).
> > Since the diff has no change in CMakeLists, I guess it must already be in 
> > the (at least indirect) dependencies. Any idea wherefrom ? And finally, 
> > should we try make this dependency 'optional' at compile time ?

> (I don't know which framework it belongs to).

Rather suprisingly it's in KCoreAddons.

I can't imagine we'll be getting rid of that soon :)


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120957/#review69802
---


On Nov. 3, 2014, 2:24 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120957/
> ---
> 
> (Updated Nov. 3, 2014, 2:24 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: oxygen
> 
> 
> Description
> ---
> 
> Sync advanced settings to KDE4
> 
> 
> Diffs
> -
> 
>   kstyle/config/oxygenstyleconfig.cpp 8185910 
> 
> Diff: https://git.reviewboard.kde.org/r/120957/diff/
> 
> 
> Testing
> ---
> 
> Copies data correctly.
> 
> Oxygen KDE4 apps update after reload. 
> They don't update immediately but that bug is unrelated as that isn't 
> happening when running "kcmshell4 style"
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120957: Oxygen: Sync advanced settings to KDE4

2014-11-04 Thread Hugo Pereira Da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120957/#review69802
---


what about dependencies ? Are we happy with oxygen KF5 style always depending 
on Kdelibs4Migration ? (I don't know which framework it belongs to).
Since the diff has no change in CMakeLists, I guess it must already be in the 
(at least indirect) dependencies. Any idea wherefrom ? And finally, should we 
try make this dependency 'optional' at compile time ?

- Hugo Pereira Da Costa


On Nov. 3, 2014, 2:24 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120957/
> ---
> 
> (Updated Nov. 3, 2014, 2:24 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: oxygen
> 
> 
> Description
> ---
> 
> Sync advanced settings to KDE4
> 
> 
> Diffs
> -
> 
>   kstyle/config/oxygenstyleconfig.cpp 8185910 
> 
> Diff: https://git.reviewboard.kde.org/r/120957/diff/
> 
> 
> Testing
> ---
> 
> Copies data correctly.
> 
> Oxygen KDE4 apps update after reload. 
> They don't update immediately but that bug is unrelated as that isn't 
> happening when running "kcmshell4 style"
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120970: Remove combo "Graphical Effects"

2014-11-04 Thread Martin Gräßlin



> On Nov. 4, 2014, 11:59 a.m., Kai Uwe Broulik wrote:
> > Who's responsible for setting the dedicated replacement 
> > QStyle::styleHint(SH_Widget_Animate)?
> > Is it now up to the style then, ie. animations turned on/off in 
> > Oxygen/Breeze?
> 
> David Edmundson wrote:
> Turns out that was a very good question.
> 
> frameworkintegration/src/kstyle/kstyle.cpp
> case SH_Widget_Animate: {
> KConfigGroup g(KSharedConfig::openConfig(), "KDE-Global GUI 
> Settings");
> return g.readEntry("GraphicEffectsLevel", true);
> }
> 
> So we were using this config entry, but writing it as an integer and 
> reading it as a boolean. So it was animated for everything, except: "Low 
> display resolution and Low CPU"
> 
> Martin Gräßlin wrote:
> Personal opinion: this shouldn't be on any config option at all. If at 
> all the animation setting should get derived from the hardware. If a style 
> wants to expose an option that's fine, but it should be in the style specific 
> config..
> 
> Kai Uwe Broulik wrote:
> Deduced from the hardware (and "is remote session") is certainly nice but 
> difficult, no?
> Also, what about Plasma's animations? We do use 
> units.{long,short}Duration everywhere but can this be disabled somewhere or 
> what settings does that follow?
> 
> Martin Klapetek wrote:
> > We do use units.{long,short}Duration everywhere but can this be 
> disabled somewhere or what settings does that follow?
> 
> Look&Feel package, iirc.
> 
> Lukáš Tinkl wrote:
> Not only that, you can also enable/disable the individual effects using 
> QApplication::setEffectEnabled(Qt::UIEffect effect, bool enable = true), see 
> http://qt-project.org/doc/qt-5/qt.html#UIEffect-enum

> Also, what about Plasma's animations?

completely orthogonal. For a widget style the CPU/RAM combination is important. 
For Plasma the GPU is important. E.g. if we run on llvmpipe we should disable 
all animations even if it's a 16 core CPU with 32 GB of RAM.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120970/#review69791
---


On Nov. 4, 2014, 11:55 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120970/
> ---
> 
> (Updated Nov. 4, 2014, 11:55 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Remove combo "Graphical Effects"
> 
> It set a config value which was exposed in
> KGlobalSettings::graphicEffectsLevel that is now deprecated.
> 
> 
> Diffs
> -
> 
>   kcms/style/finetuning.ui 3abb692 
>   kcms/style/kcmstyle.cpp 6585ee6 
> 
> Diff: https://git.reviewboard.kde.org/r/120970/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Starting KWin in Plasma startup process

2014-11-04 Thread Martin Gräßlin

On Tuesday 04 November 2014 08:44:48 Àlex Fiestas wrote:
> Hi there
> 
> I have been working in KSMServer, mostly doing some refactoring in order to
> split the X11 code (session management) into its own process.
> 
> The part I am splitting out right now (startup.cpp, startup.h) has a lot of
> specific code for "Launching the Window Management" and that is the reason
> of this email.
> 
> Right now KSMServer executes the WM before anything else, once the WM is
> started (process is executed), other things are done (Autostart0).

the better question is why it cannot be in parallel? Why would the other 
stages have a problem with no window manager being around?

> 
> My idea for KWin is for it to handle startup by itself, and idea of how to
> do that:
> 
> -Leverage systemd when available.
> -startkde.sh
> 
> For this to happen we need to make sure that KWin does not talk
> synchronously to any component that might or might not be there when KWin
> starts (kded, klauncher...).
> 
> What do you think?

Feel free to check the source base for where KWin talks to other components. 
I'm not of any direct usage, but we are using frameworks (e.g. lots of 
KServiceTypeTrader, KPluginTrader) and we have plugins which might do it (e.g. 
Oxygen window decoration might do things, etc. etc.).

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120970: Remove combo "Graphical Effects"

2014-11-04 Thread Lukáš Tinkl



> On Lis. 4, 2014, 11:59 dop., Kai Uwe Broulik wrote:
> > Who's responsible for setting the dedicated replacement 
> > QStyle::styleHint(SH_Widget_Animate)?
> > Is it now up to the style then, ie. animations turned on/off in 
> > Oxygen/Breeze?
> 
> David Edmundson wrote:
> Turns out that was a very good question.
> 
> frameworkintegration/src/kstyle/kstyle.cpp
> case SH_Widget_Animate: {
> KConfigGroup g(KSharedConfig::openConfig(), "KDE-Global GUI 
> Settings");
> return g.readEntry("GraphicEffectsLevel", true);
> }
> 
> So we were using this config entry, but writing it as an integer and 
> reading it as a boolean. So it was animated for everything, except: "Low 
> display resolution and Low CPU"
> 
> Martin Gräßlin wrote:
> Personal opinion: this shouldn't be on any config option at all. If at 
> all the animation setting should get derived from the hardware. If a style 
> wants to expose an option that's fine, but it should be in the style specific 
> config..
> 
> Kai Uwe Broulik wrote:
> Deduced from the hardware (and "is remote session") is certainly nice but 
> difficult, no?
> Also, what about Plasma's animations? We do use 
> units.{long,short}Duration everywhere but can this be disabled somewhere or 
> what settings does that follow?
> 
> Martin Klapetek wrote:
> > We do use units.{long,short}Duration everywhere but can this be 
> disabled somewhere or what settings does that follow?
> 
> Look&Feel package, iirc.

Not only that, you can also enable/disable the individual effects using 
QApplication::setEffectEnabled(Qt::UIEffect effect, bool enable = true), see 
http://qt-project.org/doc/qt-5/qt.html#UIEffect-enum


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120970/#review69791
---


On Lis. 4, 2014, 11:55 dop., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120970/
> ---
> 
> (Updated Lis. 4, 2014, 11:55 dop.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Remove combo "Graphical Effects"
> 
> It set a config value which was exposed in
> KGlobalSettings::graphicEffectsLevel that is now deprecated.
> 
> 
> Diffs
> -
> 
>   kcms/style/finetuning.ui 3abb692 
>   kcms/style/kcmstyle.cpp 6585ee6 
> 
> Diff: https://git.reviewboard.kde.org/r/120970/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120970: Remove combo "Graphical Effects"

2014-11-04 Thread Martin Klapetek



> On Nov. 4, 2014, 11:59 a.m., Kai Uwe Broulik wrote:
> > Who's responsible for setting the dedicated replacement 
> > QStyle::styleHint(SH_Widget_Animate)?
> > Is it now up to the style then, ie. animations turned on/off in 
> > Oxygen/Breeze?
> 
> David Edmundson wrote:
> Turns out that was a very good question.
> 
> frameworkintegration/src/kstyle/kstyle.cpp
> case SH_Widget_Animate: {
> KConfigGroup g(KSharedConfig::openConfig(), "KDE-Global GUI 
> Settings");
> return g.readEntry("GraphicEffectsLevel", true);
> }
> 
> So we were using this config entry, but writing it as an integer and 
> reading it as a boolean. So it was animated for everything, except: "Low 
> display resolution and Low CPU"
> 
> Martin Gräßlin wrote:
> Personal opinion: this shouldn't be on any config option at all. If at 
> all the animation setting should get derived from the hardware. If a style 
> wants to expose an option that's fine, but it should be in the style specific 
> config..
> 
> Kai Uwe Broulik wrote:
> Deduced from the hardware (and "is remote session") is certainly nice but 
> difficult, no?
> Also, what about Plasma's animations? We do use 
> units.{long,short}Duration everywhere but can this be disabled somewhere or 
> what settings does that follow?

> We do use units.{long,short}Duration everywhere but can this be disabled 
> somewhere or what settings does that follow?

Look&Feel package, iirc.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120970/#review69791
---


On Nov. 4, 2014, 11:55 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120970/
> ---
> 
> (Updated Nov. 4, 2014, 11:55 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Remove combo "Graphical Effects"
> 
> It set a config value which was exposed in
> KGlobalSettings::graphicEffectsLevel that is now deprecated.
> 
> 
> Diffs
> -
> 
>   kcms/style/finetuning.ui 3abb692 
>   kcms/style/kcmstyle.cpp 6585ee6 
> 
> Diff: https://git.reviewboard.kde.org/r/120970/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120970: Remove combo "Graphical Effects"

2014-11-04 Thread Kai Uwe Broulik



> On Nov. 4, 2014, 10:59 vorm., Kai Uwe Broulik wrote:
> > Who's responsible for setting the dedicated replacement 
> > QStyle::styleHint(SH_Widget_Animate)?
> > Is it now up to the style then, ie. animations turned on/off in 
> > Oxygen/Breeze?
> 
> David Edmundson wrote:
> Turns out that was a very good question.
> 
> frameworkintegration/src/kstyle/kstyle.cpp
> case SH_Widget_Animate: {
> KConfigGroup g(KSharedConfig::openConfig(), "KDE-Global GUI 
> Settings");
> return g.readEntry("GraphicEffectsLevel", true);
> }
> 
> So we were using this config entry, but writing it as an integer and 
> reading it as a boolean. So it was animated for everything, except: "Low 
> display resolution and Low CPU"
> 
> Martin Gräßlin wrote:
> Personal opinion: this shouldn't be on any config option at all. If at 
> all the animation setting should get derived from the hardware. If a style 
> wants to expose an option that's fine, but it should be in the style specific 
> config..

Deduced from the hardware (and "is remote session") is certainly nice but 
difficult, no?
Also, what about Plasma's animations? We do use units.{long,short}Duration 
everywhere but can this be disabled somewhere or what settings does that follow?


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120970/#review69791
---


On Nov. 4, 2014, 10:55 vorm., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120970/
> ---
> 
> (Updated Nov. 4, 2014, 10:55 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Remove combo "Graphical Effects"
> 
> It set a config value which was exposed in
> KGlobalSettings::graphicEffectsLevel that is now deprecated.
> 
> 
> Diffs
> -
> 
>   kcms/style/finetuning.ui 3abb692 
>   kcms/style/kcmstyle.cpp 6585ee6 
> 
> Diff: https://git.reviewboard.kde.org/r/120970/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Starting KWin in Plasma startup process

2014-11-04 Thread Àlex Fiestas

Hi there

I have been working in KSMServer, mostly doing some refactoring in order to 
split the X11 code (session management) into its own process.

The part I am splitting out right now (startup.cpp, startup.h) has a lot of 
specific code for "Launching the Window Management" and that is the reason of 
this email.

Right now KSMServer executes the WM before anything else, once the WM is 
started (process is executed), other things are done (Autostart0).

My idea for KWin is for it to handle startup by itself, and idea of how to do 
that:

-Leverage systemd when available.
-startkde.sh

For this to happen we need to make sure that KWin does not talk synchronously 
to any component that might or might not be there when KWin starts (kded, 
klauncher...).

What do you think?

Cheers!

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120970: Remove combo "Graphical Effects"

2014-11-04 Thread Martin Gräßlin



> On Nov. 4, 2014, 11:59 a.m., Kai Uwe Broulik wrote:
> > Who's responsible for setting the dedicated replacement 
> > QStyle::styleHint(SH_Widget_Animate)?
> > Is it now up to the style then, ie. animations turned on/off in 
> > Oxygen/Breeze?
> 
> David Edmundson wrote:
> Turns out that was a very good question.
> 
> frameworkintegration/src/kstyle/kstyle.cpp
> case SH_Widget_Animate: {
> KConfigGroup g(KSharedConfig::openConfig(), "KDE-Global GUI 
> Settings");
> return g.readEntry("GraphicEffectsLevel", true);
> }
> 
> So we were using this config entry, but writing it as an integer and 
> reading it as a boolean. So it was animated for everything, except: "Low 
> display resolution and Low CPU"

Personal opinion: this shouldn't be on any config option at all. If at all the 
animation setting should get derived from the hardware. If a style wants to 
expose an option that's fine, but it should be in the style specific config..


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120970/#review69791
---


On Nov. 4, 2014, 11:55 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120970/
> ---
> 
> (Updated Nov. 4, 2014, 11:55 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Remove combo "Graphical Effects"
> 
> It set a config value which was exposed in
> KGlobalSettings::graphicEffectsLevel that is now deprecated.
> 
> 
> Diffs
> -
> 
>   kcms/style/finetuning.ui 3abb692 
>   kcms/style/kcmstyle.cpp 6585ee6 
> 
> Diff: https://git.reviewboard.kde.org/r/120970/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120970: Remove combo "Graphical Effects"

2014-11-04 Thread David Edmundson



> On Nov. 4, 2014, 10:59 a.m., Kai Uwe Broulik wrote:
> > Who's responsible for setting the dedicated replacement 
> > QStyle::styleHint(SH_Widget_Animate)?
> > Is it now up to the style then, ie. animations turned on/off in 
> > Oxygen/Breeze?

Turns out that was a very good question.

frameworkintegration/src/kstyle/kstyle.cpp
case SH_Widget_Animate: {
KConfigGroup g(KSharedConfig::openConfig(), "KDE-Global GUI Settings");
return g.readEntry("GraphicEffectsLevel", true);
}

So we were using this config entry, but writing it as an integer and reading it 
as a boolean. So it was animated for everything, except: "Low display 
resolution and Low CPU"


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120970/#review69791
---


On Nov. 4, 2014, 10:55 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120970/
> ---
> 
> (Updated Nov. 4, 2014, 10:55 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Remove combo "Graphical Effects"
> 
> It set a config value which was exposed in
> KGlobalSettings::graphicEffectsLevel that is now deprecated.
> 
> 
> Diffs
> -
> 
>   kcms/style/finetuning.ui 3abb692 
>   kcms/style/kcmstyle.cpp 6585ee6 
> 
> Diff: https://git.reviewboard.kde.org/r/120970/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120970: Remove combo "Graphical Effects"

2014-11-04 Thread Martin Gräßlin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120970/#review69790
---


+1

- Martin Gräßlin


On Nov. 4, 2014, 11:55 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120970/
> ---
> 
> (Updated Nov. 4, 2014, 11:55 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Remove combo "Graphical Effects"
> 
> It set a config value which was exposed in
> KGlobalSettings::graphicEffectsLevel that is now deprecated.
> 
> 
> Diffs
> -
> 
>   kcms/style/finetuning.ui 3abb692 
>   kcms/style/kcmstyle.cpp 6585ee6 
> 
> Diff: https://git.reviewboard.kde.org/r/120970/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120970: Remove combo "Graphical Effects"

2014-11-04 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120970/#review69791
---


Who's responsible for setting the dedicated replacement 
QStyle::styleHint(SH_Widget_Animate)?
Is it now up to the style then, ie. animations turned on/off in Oxygen/Breeze?

- Kai Uwe Broulik


On Nov. 4, 2014, 10:55 vorm., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120970/
> ---
> 
> (Updated Nov. 4, 2014, 10:55 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Remove combo "Graphical Effects"
> 
> It set a config value which was exposed in
> KGlobalSettings::graphicEffectsLevel that is now deprecated.
> 
> 
> Diffs
> -
> 
>   kcms/style/finetuning.ui 3abb692 
>   kcms/style/kcmstyle.cpp 6585ee6 
> 
> Diff: https://git.reviewboard.kde.org/r/120970/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Splash KCM

2014-11-04 Thread David Edmundson

All done.

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 120970: Remove combo "Graphical Effects"

2014-11-04 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120970/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

Remove combo "Graphical Effects"

It set a config value which was exposed in
KGlobalSettings::graphicEffectsLevel that is now deprecated.


Diffs
-

  kcms/style/finetuning.ui 3abb692 
  kcms/style/kcmstyle.cpp 6585ee6 

Diff: https://git.reviewboard.kde.org/r/120970/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Splash KCM

2014-11-04 Thread David Edmundson

On Tue, Nov 4, 2014 at 11:35 AM, Marco Martin  wrote:

> On Tuesday 04 November 2014, David Edmundson wrote:
> > There is a kcms folder in plasma-workspace that contains only the splash
> > KCM.
> >
> > plasma-desktop contains every other KCM it also contains a folder titled
> > "ksplash" with code in it that is not being compiled.
> >
> > At the very least the one should be removed.
> >
> > Personally I'd say the one in plasma-workspace is the odd one out and
> > should move to plasma-desktop.
>
> it was put in plasma-workspace because it used the private static library
> packageaccess.
> now that thing has been killed, so it can be freely moved around
>
> Ah! Good to know the reason.

I'll move it.

David




>
> --
> Marco Martin
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Splash KCM

2014-11-04 Thread Marco Martin

On Tuesday 04 November 2014, David Edmundson wrote:
> There is a kcms folder in plasma-workspace that contains only the splash
> KCM.
> 
> plasma-desktop contains every other KCM it also contains a folder titled
> "ksplash" with code in it that is not being compiled.
> 
> At the very least the one should be removed.
> 
> Personally I'd say the one in plasma-workspace is the odd one out and
> should move to plasma-desktop.

it was put in plasma-workspace because it used the private static library 
packageaccess.
now that thing has been killed, so it can be freely moved around


-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Splash KCM

2014-11-04 Thread Martin Gräßlin

On Tuesday 04 November 2014 11:27:58 David Edmundson wrote:
> There is a kcms folder in plasma-workspace that contains only the splash
> KCM.
> 
> plasma-desktop contains every other KCM it also contains a folder titled
> "ksplash" with code in it that is not being compiled.
> 
> At the very least the one should be removed.
> 
> Personally I'd say the one in plasma-workspace is the odd one out and
> should move to plasma-desktop.

+1

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Splash KCM

2014-11-04 Thread David Edmundson

There is a kcms folder in plasma-workspace that contains only the splash
KCM.

plasma-desktop contains every other KCM it also contains a folder titled
"ksplash" with code in it that is not being compiled.

At the very least the one should be removed.

Personally I'd say the one in plasma-workspace is the odd one out and
should move to plasma-desktop.

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Breeze bugs default assignee

2014-11-04 Thread Martin Gräßlin

On Tuesday 04 November 2014 11:16:10 David Edmundson wrote:
> Currently all bugs for Breeze - General are defaulting to being assigned to
> this mailing list which is why we are seeing so many here.
> 
> bugs assigned to the qstyle component go directly to Hugo, which makes
> sense.
> 
> bugs on the mailing list tend to drown other discussion, especially given
> that the VDG who maintain a lot of the breeze world tend to not be mailing
> list people anyway.
> 
> Can I assign the bugzilla product somewhere else? Any suggestions where?

I agree that it should be reassigned, but I fear it turns into a black hole. 
If it's a real bug we have devs working on it. But most bugs go more in the 
direction of "I don't like breeze" which is a bug tracker very unsuited for 
and doesn't reach the correct people. If we reassign my fear is that those 
bugs will just accumulate. Obviously leaving them on plasma-devel is no 
solution either.

Suggestion: we develop a reply template to point to the VDG and close the bug 
and have a dedicated user for those bugs and have a few people following it 
using the template to simply close all "don't like design". Other bugs should 
get reassigned.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Breeze bugs default assignee

2014-11-04 Thread David Edmundson

Currently all bugs for Breeze - General are defaulting to being assigned to
this mailing list which is why we are seeing so many here.

bugs assigned to the qstyle component go directly to Hugo, which makes
sense.

bugs on the mailing list tend to drown other discussion, especially given
that the VDG who maintain a lot of the breeze world tend to not be mailing
list people anyway.

Can I assign the bugzilla product somewhere else? Any suggestions where?

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 340623] Breeze Widget style is very boxy and spacious. Takes too much space.

2014-11-04 Thread donniezazen

https://bugs.kde.org/show_bug.cgi?id=340623

--- Comment #2 from donniezazen  ---
I like the design very much but it's taking way too much space compared to
Oxygen while showing the same amount of information making scrollbars to kick
in all 4 directions. If you want to make things clean by spacing them out that
would also mean you have to get rid of some UI elements. Otherwise you are
scrolling with all your 10 fingers.

I was told to file a bug report so I did. I will talk to VDG too. Thanks
Martin.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120943: Move duplicated code from NotificationDelegate and NotificationPopup into a new NotificationItem

2014-11-04 Thread Martin Klapetek


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120943/#review69788
---

Ship it!


Nice work!

- Martin Klapetek


On Nov. 3, 2014, 9:26 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120943/
> ---
> 
> (Updated Nov. 3, 2014, 9:26 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This moves duplicate code (notification icon, heading, text, action buttons) 
> into a separate NotificationItem {} component used by both the notification 
> popup as well as the notification list delegate.
> 
> If we ever were to provide richer notifications for specific usecases (you 
> can provide custom hints in notifications after all) this would ease this and 
> less duplication is always good :)
> 
> I also cleaned up a bit of commented/unused code and changed complicated 
> anchoring to QtQuick Layouts where applicable.
> 
> 
> Diffs
> -
> 
>   applets/notifications/package/contents/ui/NotificationDelegate.qml 88f6cd2 
>   applets/notifications/package/contents/ui/NotificationItem.qml PRE-CREATION 
>   applets/notifications/package/contents/ui/NotificationPopup.qml 26c7ed2 
> 
> Diff: https://git.reviewboard.kde.org/r/120943/diff/
> 
> 
> Testing
> ---
> 
> Ran knotificationdbustest and didn't notice anything unusual, visually the 
> thing should look and behave exactly like it did before. Additional testing 
> is welcomed, however.
> 
> 
> File Attachments
> 
> 
> New popup
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/11/02/9b20416e-a4c6-4694-aff3-bdad26cf3206__newnotificationpopup.png
> New history
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/11/03/e7efdf8f-09de-4eaf-a7a2-d37979bad28b__newnotificationhistory.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 340623] Breeze Widget style is very boxy and spacious. Takes too much space.

2014-11-04 Thread Martin Gräßlin

https://bugs.kde.org/show_bug.cgi?id=340623

Martin Gräßlin  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Martin Gräßlin  ---
The breeze design is developed as a community effort which happens in the
"Visual Design Group" forum on forum.kde.org. Feel free to participate there.

Concerning this bug report I'm sorry to say that this is a WONTFIX. Currently
this is the *intended* design and the perspective of a design is always
subjective. It's totally fine that you don't like the design as it's obviously
not possible to have a design which suits all users. Luckily you can switch the
design and switch to e.g. Oxygen.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 340623] New: Breeze Widget style is very boxy and spacious. Takes too much space.

2014-11-04 Thread donniezazen

https://bugs.kde.org/show_bug.cgi?id=340623

Bug ID: 340623
   Summary: Breeze Widget style is very boxy and spacious. Takes
too much space.
   Product: Breeze
   Version: 5.1.0
  Platform: Fedora RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: sud...@sudhirkhanger.com

Breeze Widget sytle is very boxy and takes too much space to accomodate small
amount of text. Plasma 5.1 introduced Breeze widget style which makes KMail now
take at least 50% more space to accomodate the same number of lines that Oxygen
was accomodating. I have 30 enteries in KMail's folder window which were fully
accomodated at 22x22 in Oxygen widget style without any scrollbar. With Breeze
even at 16x16 7-8 folder lines are hidden and with 22x22 11 folder names are
hidden which have to be regularly accessed by scrolling down.

Reproducible: Always

Steps to Reproduce:
1. Use Breeze widget style in Plasma 5.
2.
3.

Actual Results:  
Breeze style makes same information occupy more space

Expected Results:  
Space should be proportionally applied.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 340617] Breeze dark theme has bright breeze dialog background

2014-11-04 Thread Martin Klapetek

https://bugs.kde.org/show_bug.cgi?id=340617

Martin Klapetek  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 Resolution|--- |WAITINGFORINFO
 CC||mklape...@kde.org

--- Comment #1 from Martin Klapetek  ---
Can you include a screenshot please?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120965: Base panelcontroller and more settings menu on button sizes

2014-11-04 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120965/#review69784
---



desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml


Should probably also take these headings into account


- Kai Uwe Broulik


On Nov. 3, 2014, 10:44 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120965/
> ---
> 
> (Updated Nov. 3, 2014, 10:44 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Not every language has short fancy expressions for things and thus stuff 
> breaks when using it in German, for example the "Windows can cover" or "Add 
> spacer" button were cut off. This fixes this by accounting the button widths 
> in the minimum width.
> 
> 
> Diffs
> -
> 
>   
> desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml 
> 2ab662c 
>   desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml 
> 7cf567e 
> 
> Diff: https://git.reviewboard.kde.org/r/120965/diff/
> 
> 
> Testing
> ---
> 
> No more cut off buttons, but it seems there's an issue with re-layouting when 
> dragging a horizontal to a side.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 340580] KDE Apps' toolbars and dialog options don't have icons just empty spaces.

2014-11-04 Thread donniezazen

https://bugs.kde.org/show_bug.cgi?id=340580

donniezazen  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |WORKSFORME
 Status|NEEDSINFO   |RESOLVED

--- Comment #3 from donniezazen  ---
Dolphin froze on my system which I had to kill and when I started it again I
had all icons back in all KDE4 apps.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel