[Breeze] [Bug 340917] Titlebar buttons and actions not responding right after changing focus by clicking titlebar
https://bugs.kde.org/show_bug.cgi?id=340917 Martin Gräßlin mgraess...@kde.org changed: What|Removed |Added URL||https://codereview.qt-proje ||ct.org/#/c/99587/4 --- Comment #4 from Martin Gräßlin mgraess...@kde.org --- The problem might be address with Qt code review: https://codereview.qt-project.org/#/c/99587/4 -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 340917] Titlebar buttons and actions not responding right after changing focus by clicking titlebar
https://bugs.kde.org/show_bug.cgi?id=340917 --- Comment #5 from Stephen Kim stephen...@gmail.com --- (In reply to Martin Gräßlin from comment #4) The problem might be address with Qt code review: https://codereview.qt-project.org/#/c/99587/4 Thank you for further informations, Graesslin! I've read your blog post. Does this mean it is an internal bug in Qt or its XCB binding? -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Polkit-kde-agent-1 in Plasma5
Hey, It seems we have never made a release of the Qt5 version of the KDE polkit agent. Kubuntu are shipping the kdelibs4 version, which is fine for now, but not really where we want to be long term. 1) Can we talk about moving it into Plasma from extragear? It's a rather essential part of the modern desktop. 2) Is there anything blocking making a KF5 release? David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Polkit-kde-agent-1 in Plasma5
Dne 14.11.2014 v 12:43 David Edmundson napsal(a): Hey, It seems we have never made a release of the Qt5 version of the KDE polkit agent. Kubuntu are shipping the kdelibs4 version, which is fine for now, but not really where we want to be long term. 1) Can we talk about moving it into Plasma from extragear? It's a rather essential part of the modern desktop. 2) Is there anything blocking making a KF5 release? David You're reading my mind, I was about to suggest the same :) +1 from my side definitely -- Lukáš Tinkl lti...@redhat.com Senior Software Engineer - KDE desktop team, Brno KDE developer lu...@kde.org Red Hat Inc. http://cz.redhat.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Polkit-kde-agent-1 in Plasma5
On Fri, Nov 14, 2014 at 12:54:04PM +0100, Lukáš Tinkl wrote: Dne 14.11.2014 v 12:43 David Edmundson napsal(a): Hey, It seems we have never made a release of the Qt5 version of the KDE polkit agent. Kubuntu are shipping the kdelibs4 version, which is fine for now, but not really where we want to be long term. 1) Can we talk about moving it into Plasma from extragear? It's a rather essential part of the modern desktop. 2) Is there anything blocking making a KF5 release? David You're reading my mind, I was about to suggest the same :) +1 from my side definitely this is polkit-kde-agent-1 ? What's the status of polkit-qt-1 ? Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Polkit-kde-agent-1 in Plasma5
On Friday 14 November 2014 12:43:44 David Edmundson wrote: 1) Can we talk about moving it into Plasma from extragear? It's a rather essential part of the modern desktop. may make sense, but more than that, it just needs a release, regardless is in extragear or in workspace -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/#review70364 --- hm, i don't really like it. is it working around a problem in particular? if i try the patch, the difference during startup (or just duringopening a popup on the first time) is pretty noticeable like, the wallpaper appearing several *seconds* later. This way, i think it's not using the incubator at all, and i don't think it's really acceptable. In QML itself, QQuickView does internally use an incubator as well, even tough in a slightly different manner it seems. - Marco Martin On Nov. 13, 2014, 6:24 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/ --- (Updated Nov. 13, 2014, 6:24 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- We had a while loop which processed all application events whilst we were in the middle of creating objects. This leads to weird bugs, and workarounds in ShellCorona. Qt's methods forceCompletion does not seem to have the same problems and works just as well. Diffs - src/kdeclarative/qmlobject.cpp 029edaf Diff: https://git.reviewboard.kde.org/r/121113/diff/ Testing --- Ran plasmashell with many panels filled with applets Added debug on void ShellCorona::createWaitingPanels() to make sure it was never called with m_loading true. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121119: add possibility for lf package to have layouts
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121119/ --- Review request for Plasma. Repository: plasma-workspace Description --- if the lf package has a default layout script, make it win over the one of the shell. this should be used for distributions to customize. since there can be one lf package with multiple shells, a layout is specific for a particular shell package, so search the files as layouts/shellName-layout.js, like layouts/org.kde.plasma.shell-layout.js Diffs - shell/shellcorona.cpp 1ea0c90 Diff: https://git.reviewboard.kde.org/r/121119/diff/ Testing --- File Attachments bah.diff https://git.reviewboard.kde.org/media/uploaded/files/2014/11/14/8b4c5430-dda2-42ca-9cd8-d06fdff09210__bah.diff Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121119: add possibility for lf package to have layouts
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121119/#review70365 --- is bah.diff part of this review? - Bhushan Shah On Nov. 14, 2014, 8:13 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121119/ --- (Updated Nov. 14, 2014, 8:13 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- if the lf package has a default layout script, make it win over the one of the shell. this should be used for distributions to customize. since there can be one lf package with multiple shells, a layout is specific for a particular shell package, so search the files as layouts/shellName-layout.js, like layouts/org.kde.plasma.shell-layout.js Diffs - shell/shellcorona.cpp 1ea0c90 Diff: https://git.reviewboard.kde.org/r/121119/diff/ Testing --- File Attachments bah.diff https://git.reviewboard.kde.org/media/uploaded/files/2014/11/14/8b4c5430-dda2-42ca-9cd8-d06fdff09210__bah.diff Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121119: add possibility for lf package to have layouts
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121119/ --- (Updated Nov. 14, 2014, 2:53 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- if the lf package has a default layout script, make it win over the one of the shell. this should be used for distributions to customize. since there can be one lf package with multiple shells, a layout is specific for a particular shell package, so search the files as layouts/shellName-layout.js, like layouts/org.kde.plasma.shell-layout.js Diffs - shell/shellcorona.cpp 1ea0c90 Diff: https://git.reviewboard.kde.org/r/121119/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121119: add possibility for lf package to have layouts
On Nov. 14, 2014, 2:48 p.m., Bhushan Shah wrote: is bah.diff part of this review? eew, sorry, it isn't ;) - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121119/#review70365 --- On Nov. 14, 2014, 2:53 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121119/ --- (Updated Nov. 14, 2014, 2:53 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- if the lf package has a default layout script, make it win over the one of the shell. this should be used for distributions to customize. since there can be one lf package with multiple shells, a layout is specific for a particular shell package, so search the files as layouts/shellName-layout.js, like layouts/org.kde.plasma.shell-layout.js Diffs - shell/shellcorona.cpp 1ea0c90 Diff: https://git.reviewboard.kde.org/r/121119/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 340917] Titlebar buttons and actions not responding right after changing focus by clicking titlebar
https://bugs.kde.org/show_bug.cgi?id=340917 --- Comment #6 from Martin Gräßlin mgraess...@kde.org --- Does this mean it is an internal bug in Qt or its XCB binding? The bug is most likely inside Qt. Given the code-review and the description it would explain the bug and would indicate it's inside the XCB plugin. I haven't tested whether the change would fix it, but KDecoration2 will. In any case the next release of Plasma will probably have addressed this issue. I'm currently using KDecoration2 and this problem is clearly not present ;-) -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [Breeze] [Bug 340917] Titlebar buttons and actions not responding right after changing focus by clicking titlebar
Does this mean it is an internal bug in Qt or its XCB binding? The bug is most likely inside Qt. Given the code-review and the description it would explain the bug and would indicate it's inside the XCB plugin. I haven't tested whether the change would fix it, but KDecoration2 will. In any case the next release of Plasma will probably have addressed this issue. I'm currently using KDecoration2 and this problem is clearly not present ;-) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
ISO for 2014-11-14
Having skipped last week's ISO due to technical difficulty, this week's ISO is now available \o/ http://files.kde.org/snapshots/unstable-i386-latest.iso.mirrorlist #changes - gwenview port integrated - kate port integrated - konsole port available through sudo apt install konsole5 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121121: Remove all kdelibs4support from polkit-agent
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121121/#review70375 --- +1, looks good, maintainers will know best. - Aleix Pol Gonzalez On Nov. 14, 2014, 5:08 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121121/ --- (Updated Nov. 14, 2014, 5:08 p.m.) Review request for Plasma, Jaroslav Řezník and Lukáš Tinkl. Repository: polkit-kde-agent-1 Description --- Remove all kdelibs4support from polkit-agent Diffs - AuthDialog.h eaebbd2 AuthDialog.cpp b76d91e AuthDialog.ui e4da0f9 CMakeLists.txt 482fc57 main.cpp f8f97b8 policykitkde.h 85ce6b2 policykitkde.cpp a25cb4f policykitlistener.h 538381f policykitlistener.cpp bab7fdf Diff: https://git.reviewboard.kde.org/r/121121/diff/ Testing --- Using pkexec tested using the correct password the wrong password viewing details and tested trying to open two agents at once. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121121: Remove all kdelibs4support from polkit-agent
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121121/#review70376 --- AuthDialog.cpp https://git.reviewboard.kde.org/r/121121/#comment49204 Shouldn't this be one i18n(Details ) to avoid string puzzles? Would require another Details though, but that's necessary for RTL languages anyway (no?) - Martin Klapetek On Nov. 14, 2014, 6:08 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121121/ --- (Updated Nov. 14, 2014, 6:08 p.m.) Review request for Plasma, Jaroslav Řezník and Lukáš Tinkl. Repository: polkit-kde-agent-1 Description --- Remove all kdelibs4support from polkit-agent Diffs - AuthDialog.h eaebbd2 AuthDialog.cpp b76d91e AuthDialog.ui e4da0f9 CMakeLists.txt 482fc57 main.cpp f8f97b8 policykitkde.h 85ce6b2 policykitkde.cpp a25cb4f policykitlistener.h 538381f policykitlistener.cpp bab7fdf Diff: https://git.reviewboard.kde.org/r/121121/diff/ Testing --- Using pkexec tested using the correct password the wrong password viewing details and tested trying to open two agents at once. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121121: Remove all kdelibs4support from polkit-agent
On Nov. 14, 2014, 5:27 p.m., Martin Klapetek wrote: AuthDialog.cpp, lines 75-76 https://git.reviewboard.kde.org/r/121121/diff/1/?file=328465#file328465line75 Shouldn't this be one i18n(Details ) to avoid string puzzles? Would require another Details though, but that's necessary for RTL languages anyway (no?) KDialog does it this way. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121121/#review70376 --- On Nov. 14, 2014, 5:08 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121121/ --- (Updated Nov. 14, 2014, 5:08 p.m.) Review request for Plasma, Jaroslav Řezník and Lukáš Tinkl. Repository: polkit-kde-agent-1 Description --- Remove all kdelibs4support from polkit-agent Diffs - AuthDialog.h eaebbd2 AuthDialog.cpp b76d91e AuthDialog.ui e4da0f9 CMakeLists.txt 482fc57 main.cpp f8f97b8 policykitkde.h 85ce6b2 policykitkde.cpp a25cb4f policykitlistener.h 538381f policykitlistener.cpp bab7fdf Diff: https://git.reviewboard.kde.org/r/121121/diff/ Testing --- Using pkexec tested using the correct password the wrong password viewing details and tested trying to open two agents at once. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121121: Remove all kdelibs4support from polkit-agent
On Nov. 14, 2014, 6:27 p.m., Martin Klapetek wrote: AuthDialog.cpp, lines 75-76 https://git.reviewboard.kde.org/r/121121/diff/1/?file=328465#file328465line75 Shouldn't this be one i18n(Details ) to avoid string puzzles? Would require another Details though, but that's necessary for RTL languages anyway (no?) David Edmundson wrote: KDialog does it this way. That doesn't make it correct. http://api.kde.org/frameworks-api/frameworks5-apidocs/ki18n/html/prg_guide.html#good_text - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121121/#review70376 --- On Nov. 14, 2014, 6:08 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121121/ --- (Updated Nov. 14, 2014, 6:08 p.m.) Review request for Plasma, Jaroslav Řezník and Lukáš Tinkl. Repository: polkit-kde-agent-1 Description --- Remove all kdelibs4support from polkit-agent Diffs - AuthDialog.h eaebbd2 AuthDialog.cpp b76d91e AuthDialog.ui e4da0f9 CMakeLists.txt 482fc57 main.cpp f8f97b8 policykitkde.h 85ce6b2 policykitkde.cpp a25cb4f policykitlistener.h 538381f policykitlistener.cpp bab7fdf Diff: https://git.reviewboard.kde.org/r/121121/diff/ Testing --- Using pkexec tested using the correct password the wrong password viewing details and tested trying to open two agents at once. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 340964] New: System misreporting battery status and won't hibernate at 5% default battery value
https://bugs.kde.org/show_bug.cgi?id=340964 Bug ID: 340964 Summary: System misreporting battery status and won't hibernate at 5% default battery value Product: Powerdevil Version: 5.1.1 Platform: Other OS: Linux Status: UNCONFIRMED Severity: critical Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: sud...@sudhirkhanger.com 1. System is suppose to hibernate at 5%. Currently battery level is going down below 5% and then system would flicker and shutdown. 2. Battery status is being misreported. When discharging it tell time to discharge 1:52:25 and when charging it tells 1:52:25. As far as I can correct battery percentage is being reported. See the screenshot http://imgur.com/UqRcyCl and http://i.imgur.com/D7Yj6wA.png Device: /org/freedesktop/UPower/devices/battery_BAT0 native-path: BAT0 vendor: SANYO model:42T4799 serial: 14409 power supply: yes updated: Fri 14 Nov 2014 11:21:33 PM IST (78 seconds ago) has history: yes has statistics: yes battery present: yes rechargeable:yes state: charging warning-level: none energy: 4.65 Wh energy-empty:0 Wh energy-full: 34.17 Wh energy-full-design: 93.24 Wh energy-rate: 27.167 W voltage: 11.71 V time to full:1.1 hours percentage: 13% capacity:36.6474% technology: lithium-ion icon-name: 'battery-low-charging-symbolic' History (charge): 1415987493 13.000 charging History (rate): 1415987493 27.167 charging Reproducible: Always Steps to Reproduce: 1. check battery monitor and upower -d values while charging and discharging 2. 3. Actual Results: Battery level goes below 5% and system shuts down. Misreporting battery level Expected Results: System should hibernate at value set in system settings. Should report accurate battery level. Fedora 21 Plasma 5.1.x -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 340964] System misreporting battery status and won't hibernate at 5% default battery value
https://bugs.kde.org/show_bug.cgi?id=340964 donniezazen sud...@sudhirkhanger.com changed: What|Removed |Added CC||sud...@sudhirkhanger.com --- Comment #1 from donniezazen sud...@sudhirkhanger.com --- Created attachment 89585 -- https://bugs.kde.org/attachment.cgi?id=89585action=edit upower -d and battery monitor screenshot showing battery time disparity -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121122: Allow loading KPluginMetaData from a .desktop file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121122/ --- Review request for KDE Frameworks, Plasma, Alexander Richardson, David Faure, and Marco Martin. Repository: kcoreaddons Description --- This set of patches moves the code to decode and json-serialize from desktoptojson into its own class, used by the KPluginMetaData(QString file) constructor. These functions are not exported, desktoptojson directly includes this class. I've done it this way to avoid littering the API, yet removing as much duplicated code from desktoptojson as possible. These functions have gone into their own class, and made static, since they don't carry state, anyway. The purpose of this patch is to allow the package indexer in kpackage (the split-out framework containing Plasma::Package) to create a correct, KPlugin-compatible cache file from package metadata. This patch allows us to just feed a .desktop file into KPluginMetaData and get back correct deserialized KPluginMetaData objects. It allows us to cut out the KService dependency in KPackage. In particular, this is split up into the following patches (you can find it in git kcoreaddons[sebas/kpluginmetadata] as well): Remove now-duplicated code in desktoptojson Use escapeValue, deserializeList and convertToJson from desktopfileparser. Move the bits to parse .desktop files into its own class This encapsulates the desktop file parseing logic into its own class. It's fairly self-contained, all static code. This also makes it easier to share this code with the desktoptojson binary. Allow to read KPluginMetaData from .desktop files Move the logic to create a KPluginMetaData object from desktoptojson into KPluginMetaData. This allows to load metadata from a .desktop file, making it possible to load desktop files without going through KPluginInfo (and thus KService). This is useful for conversion to json data, which will be used to index packages in the KPackage framework for faster lookups, similar to the index proof-of-concept for KPluginTrader. Add an autotest for loading KPluginMetaData from a .desktop file Diffs - autotests/data/fakeplugin.desktop PRE-CREATION autotests/kpluginmetadatatest.cpp a1aaf80c8a5e25c2ae031a80fd1f8f96fa5924a0 src/desktoptojson/CMakeLists.txt c2d2b8780ab6cb34686bc7a43a3b6d4eaeb12b1e src/desktoptojson/desktoptojson.cpp 3f0cfb129730cf7ba8adbf9c331d967f8a04d4e8 src/lib/CMakeLists.txt 1dc56270ab5157af706b7745cfa88ae11e16184a src/lib/plugin/desktopfileparser.h PRE-CREATION src/lib/plugin/desktopfileparser.cpp PRE-CREATION src/lib/plugin/kpluginmetadata.h 67b68a50225e8ac82706caa849fb330567cee1d2 src/lib/plugin/kpluginmetadata.cpp f3e68c927370ad9212e8dfc07677ec17c52fdbdd Diff: https://git.reviewboard.kde.org/r/121122/diff/ Testing --- Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121122: Allow loading KPluginMetaData from a .desktop file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121122/ --- (Updated Nov. 14, 2014, 6:08 p.m.) Review request for KDE Frameworks, Plasma, Alexander Richardson, David Faure, and Marco Martin. Changes --- Described testing Repository: kcoreaddons Description --- This set of patches moves the code to decode and json-serialize from desktoptojson into its own class, used by the KPluginMetaData(QString file) constructor. These functions are not exported, desktoptojson directly includes this class. I've done it this way to avoid littering the API, yet removing as much duplicated code from desktoptojson as possible. These functions have gone into their own class, and made static, since they don't carry state, anyway. The purpose of this patch is to allow the package indexer in kpackage (the split-out framework containing Plasma::Package) to create a correct, KPlugin-compatible cache file from package metadata. This patch allows us to just feed a .desktop file into KPluginMetaData and get back correct deserialized KPluginMetaData objects. It allows us to cut out the KService dependency in KPackage. In particular, this is split up into the following patches (you can find it in git kcoreaddons[sebas/kpluginmetadata] as well): Remove now-duplicated code in desktoptojson Use escapeValue, deserializeList and convertToJson from desktopfileparser. Move the bits to parse .desktop files into its own class This encapsulates the desktop file parseing logic into its own class. It's fairly self-contained, all static code. This also makes it easier to share this code with the desktoptojson binary. Allow to read KPluginMetaData from .desktop files Move the logic to create a KPluginMetaData object from desktoptojson into KPluginMetaData. This allows to load metadata from a .desktop file, making it possible to load desktop files without going through KPluginInfo (and thus KService). This is useful for conversion to json data, which will be used to index packages in the KPackage framework for faster lookups, similar to the index proof-of-concept for KPluginTrader. Add an autotest for loading KPluginMetaData from a .desktop file Diffs - autotests/data/fakeplugin.desktop PRE-CREATION autotests/kpluginmetadatatest.cpp a1aaf80c8a5e25c2ae031a80fd1f8f96fa5924a0 src/desktoptojson/CMakeLists.txt c2d2b8780ab6cb34686bc7a43a3b6d4eaeb12b1e src/desktoptojson/desktoptojson.cpp 3f0cfb129730cf7ba8adbf9c331d967f8a04d4e8 src/lib/CMakeLists.txt 1dc56270ab5157af706b7745cfa88ae11e16184a src/lib/plugin/desktopfileparser.h PRE-CREATION src/lib/plugin/desktopfileparser.cpp PRE-CREATION src/lib/plugin/kpluginmetadata.h 67b68a50225e8ac82706caa849fb330567cee1d2 src/lib/plugin/kpluginmetadata.cpp f3e68c927370ad9212e8dfc07677ec17c52fdbdd Diff: https://git.reviewboard.kde.org/r/121122/diff/ Testing (updated) --- Added an autotest which compares a KPluginMetaData object created from a desktop file. Also used this code from kpackage. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121122: Allow loading KPluginMetaData from a .desktop file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121122/#review70381 --- src/lib/plugin/desktopfileparser.h https://git.reviewboard.kde.org/r/121122/#comment49207 Doesn't seem to be used given it's only passed as reference - Kai Uwe Broulik On Nov. 14, 2014, 6:08 nachm., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121122/ --- (Updated Nov. 14, 2014, 6:08 nachm.) Review request for KDE Frameworks, Plasma, Alexander Richardson, David Faure, and Marco Martin. Repository: kcoreaddons Description --- This set of patches moves the code to decode and json-serialize from desktoptojson into its own class, used by the KPluginMetaData(QString file) constructor. These functions are not exported, desktoptojson directly includes this class. I've done it this way to avoid littering the API, yet removing as much duplicated code from desktoptojson as possible. These functions have gone into their own class, and made static, since they don't carry state, anyway. The purpose of this patch is to allow the package indexer in kpackage (the split-out framework containing Plasma::Package) to create a correct, KPlugin-compatible cache file from package metadata. This patch allows us to just feed a .desktop file into KPluginMetaData and get back correct deserialized KPluginMetaData objects. It allows us to cut out the KService dependency in KPackage. In particular, this is split up into the following patches (you can find it in git kcoreaddons[sebas/kpluginmetadata] as well): Remove now-duplicated code in desktoptojson Use escapeValue, deserializeList and convertToJson from desktopfileparser. Move the bits to parse .desktop files into its own class This encapsulates the desktop file parseing logic into its own class. It's fairly self-contained, all static code. This also makes it easier to share this code with the desktoptojson binary. Allow to read KPluginMetaData from .desktop files Move the logic to create a KPluginMetaData object from desktoptojson into KPluginMetaData. This allows to load metadata from a .desktop file, making it possible to load desktop files without going through KPluginInfo (and thus KService). This is useful for conversion to json data, which will be used to index packages in the KPackage framework for faster lookups, similar to the index proof-of-concept for KPluginTrader. Add an autotest for loading KPluginMetaData from a .desktop file Diffs - autotests/data/fakeplugin.desktop PRE-CREATION autotests/kpluginmetadatatest.cpp a1aaf80c8a5e25c2ae031a80fd1f8f96fa5924a0 src/desktoptojson/CMakeLists.txt c2d2b8780ab6cb34686bc7a43a3b6d4eaeb12b1e src/desktoptojson/desktoptojson.cpp 3f0cfb129730cf7ba8adbf9c331d967f8a04d4e8 src/lib/CMakeLists.txt 1dc56270ab5157af706b7745cfa88ae11e16184a src/lib/plugin/desktopfileparser.h PRE-CREATION src/lib/plugin/desktopfileparser.cpp PRE-CREATION src/lib/plugin/kpluginmetadata.h 67b68a50225e8ac82706caa849fb330567cee1d2 src/lib/plugin/kpluginmetadata.cpp f3e68c927370ad9212e8dfc07677ec17c52fdbdd Diff: https://git.reviewboard.kde.org/r/121122/diff/ Testing --- Added an autotest which compares a KPluginMetaData object created from a desktop file. Also used this code from kpackage. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120876: Forward-port Fix and future-proof Dr Konqi security methods on Bugzilla from kde-runtime
On Nov. 11, 2014, 10:43 p.m., Hrvoje Senjan wrote: 5.1.1 out. should 5(.1.x) be targeted at all? Thomas Lübking wrote: As this is now a straightforward port of what there is in KDE SC 4 and DrKonqui is atm. useless and crashreports for KF/5 currently suck in 80% of all cases (not the users fault - they say crash and post the shell output ;-) I clearly vote for pushing it into 5.1 Findings on whether a certain method can be hardcoded and other improvements then would point 5.2 or whatever else. I'm however not sure whether we should abandon the bugzilla version check + depending security stuff so easily. Once because as Ian mentioned there might be interest in extending KCrash to allow different bugzilla servers (evtl. even move it to Tier1). And also because one cannot be sure that bugzilla does not jump onto yet another security bandwagon with the release after the next one. Hrvoje Senjan wrote: thanks. unless then someone yells not to push, will commit in a few hours. Thanks very much for your help, Hrvoje. - Ian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120876/#review70263 --- On Nov. 12, 2014, 6:57 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120876/ --- (Updated Nov. 12, 2014, 6:57 p.m.) Review request for Plasma, Ben Cooksley, Ian Wadham, and Thomas Lübking. Bugs: 337742 https://bugs.kde.org/show_bug.cgi?id=337742 Repository: plasma-workspace Description --- discussion was in https://git.reviewboard.kde.org/r/120431/ removed the version checks, as we know we have kdelibs = 4.5 ;-) Diffs - drkonqi/bugzillaintegration/bugzillalib.h 570169b drkonqi/bugzillaintegration/bugzillalib.cpp 8fd8399 drkonqi/bugzillaintegration/reportassistantpages_bugzilla.h 50cf05f drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp 5a6096f Diff: https://git.reviewboard.kde.org/r/120876/diff/ Testing --- builds, succesfully reported bug via patched DrKonqi, wasn't able to do so before. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 340964] System misreporting battery status and won't hibernate at 5% default battery value
https://bugs.kde.org/show_bug.cgi?id=340964 Christoph Feck christ...@maxiom.de changed: What|Removed |Added Severity|critical|normal -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
