Re: PageStack and StackView

2014-12-01 Thread Marco Martin
On Saturday 29 November 2014, Kai Uwe Broulik wrote:
 I migrated the essential parts of PageStack to StackView but now System
 Tray is completely broken. Switching to different applets leaves the old
 ones there.
 
 According to documentation By default […] StackView will destroy items
 pushed as components or URLs. Items not destroyed will be re-parented back
 to the original parents they had before being pushed onto the stack and
 hidden. but since the taskItemExpanded is a QQuickItem* member of Task it

could it be done by hand when changing the page?
otherwise other things that pop to mind are using an item somewhere where one 
reparents all the plasmoids fullrepresentations as soon as created or using a 
TabView instead

 cannot really re-parent it and just dumps it somewhere where it stays
 visible :/ DestroyOnPop did not work either and is probably not desirable

should never destroy pieces of plasmoids

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


FOSDEM talk

2014-12-01 Thread Jonathan Riddell

Anyone want to do a Plasma 5 talk at FOSDEM? Deadline is this weekend.

 https://lists.fosdem.org/pipermail/fosdem/2014-October/002057.html

Also as said in meeting please sign up here if you're coming for helping on 
stall and sat meal.

 https://community.kde.org/Promo/Events/FOSDEM/2015

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Minutes Monday Plasma Hangout

2014-12-01 Thread Sebastian Kügler
Minutes Plasma Hangout, 1-12-2014

Present: Aleix, David, Harald, Jens, Jonathan, Kai Uwe, Marco, Martin G., 
Vishesh, Sebastian


Aleix:
- worked on KTP, frameworks branch should work, please test
- worked on kamoso, frameworks branch should work like 4.x version, modulo
- sharing of pictures (could be shared with quickshare plasmoid)
- will email more information

David:
- has been working on Qt DBus props merging
- added tasks for Code-In to port away from kdelibs4support

Harald:
- nothing to report (will add KTP to the ISO)

Jens:
- worked on application design

Jonathan:
- Please sign up for FOSDEM: 
https://community.kde.org/Promo/Events/FOSDEM/2015
- Frameworks 5.5 due at the end of the week
- Plasma 5 is in Kubuntu Development version
- icon mapping breeze icons for libreoffice 
https://community.kde.org/KDE_Visual_Design_Group/LibreOffice_Breeze

Kai Uwe:
- Improvements to wallpaper loading ( 
https://git.reviewboard.kde.org/r/121294/ )
- Introducing OSD window type to KWindowSystem ( 
https://git.reviewboard.kde.org/r/121299/ )
- Working on improving our PageStack components (see ML)

Marco:
- worked on kpackage indexing
- would like to move kpackage to review
- Completed a style (see mart/completeQtQuickStyle ), please review
- There are patches for Qt to use statusnotifiers: 
https://codereview.qt-project.org/#/c/100878/ 
https://codereview.qt-project.org/#/c/98744/ 
https://codereview.qt-project.org/#/c/100879/

Martin G:
- worked on fixing multiscreen in KWin
- KWayland::Server bits are now installed and 3rd-party-usable
- some more work on KDecoration, all comments addressed, moving to 
kde/workspace
- some minor things on KDecoration and screen handling planned

Vishesh:
- Baloo optimizations implemented
- Will close all Nepomuk bugs as unmaintainted

Sebastian:
- worked on settings synching (see scratch/sebas/plasma-sync repo)
- some porting work
- will attempt at merging KPluginMetaData ctor for .desktop files


-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 121122: Allow loading KPluginMetaData from a .desktop file

2014-12-01 Thread Alexander Richardson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121122/#review71165
---

Ship it!


Looks good to me once the open issues have be solved.

- Alexander Richardson


On Nov. 14, 2014, 6:08 nachm., Sebastian Kügler wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121122/
 ---
 
 (Updated Nov. 14, 2014, 6:08 nachm.)
 
 
 Review request for KDE Frameworks, Plasma, Alexander Richardson, David Faure, 
 and Marco Martin.
 
 
 Repository: kcoreaddons
 
 
 Description
 ---
 
 This set of patches moves the code to decode and json-serialize from 
 desktoptojson into its own class, used by the KPluginMetaData(QString file) 
 constructor.
 
 These functions are not exported, desktoptojson directly includes this class. 
 I've done it this way to avoid littering the API, yet removing as much 
 duplicated code from desktoptojson as possible. These functions have gone 
 into their own class, and made static, since they don't carry state, anyway.
 
 The purpose of this patch is to allow the package indexer in kpackage (the 
 split-out framework containing Plasma::Package) to create a correct, 
 KPlugin-compatible cache file from package metadata. This patch allows us to 
 just feed a .desktop file into KPluginMetaData and get back correct 
 deserialized KPluginMetaData objects. It allows us to cut out the KService 
 dependency in KPackage.
 
 In particular, this is split up into the following patches (you can find it 
 in git kcoreaddons[sebas/kpluginmetadata] as well):
 
 
 Remove now-duplicated code in desktoptojson
 
 Use escapeValue, deserializeList and convertToJson from
 desktopfileparser.
 
 Move the bits to parse .desktop files into its own class
 
 This encapsulates the desktop file parseing logic into its own class.
 It's fairly self-contained, all static code. This also makes it easier
 to share this code with the desktoptojson binary.
 
 Allow to read KPluginMetaData from .desktop files
 
 Move the logic to create a KPluginMetaData object from desktoptojson
 into KPluginMetaData.
 
 This allows to load metadata from a .desktop file, making it possible to
 load desktop files without going through KPluginInfo (and thus
 KService). This is useful for conversion to json data, which will be
 used to index packages in the KPackage framework for faster lookups,
 similar to the index proof-of-concept for KPluginTrader.
 
 Add an autotest for loading KPluginMetaData from a .desktop file
 
 
 Diffs
 -
 
   autotests/data/fakeplugin.desktop PRE-CREATION 
   autotests/kpluginmetadatatest.cpp a1aaf80c8a5e25c2ae031a80fd1f8f96fa5924a0 
   src/desktoptojson/CMakeLists.txt c2d2b8780ab6cb34686bc7a43a3b6d4eaeb12b1e 
   src/desktoptojson/desktoptojson.cpp 
 3f0cfb129730cf7ba8adbf9c331d967f8a04d4e8 
   src/lib/CMakeLists.txt 1dc56270ab5157af706b7745cfa88ae11e16184a 
   src/lib/plugin/desktopfileparser.h PRE-CREATION 
   src/lib/plugin/desktopfileparser.cpp PRE-CREATION 
   src/lib/plugin/kpluginmetadata.h 67b68a50225e8ac82706caa849fb330567cee1d2 
   src/lib/plugin/kpluginmetadata.cpp f3e68c927370ad9212e8dfc07677ec17c52fdbdd 
 
 Diff: https://git.reviewboard.kde.org/r/121122/diff/
 
 
 Testing
 ---
 
 Added an autotest which compares a KPluginMetaData object created from a 
 desktop file. Also used this code from kpackage.
 
 
 Thanks,
 
 Sebastian Kügler
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 121294: Improve wallpaper sourceSize handling

2014-12-01 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121294/#review71167
---


fine event compressing the update of sourcesize.

as for the wrong size at startup, that should be solved on the plasmashell 
side, to avoid those resizes, rather than at wallpaper plugin side, that should 
just assumeit's view is always the correct one

- Marco Martin


On Nov. 30, 2014, 2:48 p.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121294/
 ---
 
 (Updated Nov. 30, 2014, 2:48 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 Do not bind the image's sourceSize to the root item's size since that will 
 reload the image whenever the size changes. This is especially noticeable in 
 plasmoidviewer where resizing the window causes the background to go black 
 momentarily.
 
 This makes it wait 1s before actually changing the source size, preventing 
 continuous reloading when resizing the window but should also improve 
 resolution changes. Also, it waits for the size to become non-zero before 
 loading the image. Setting a sourceSize of (0,0) is equivalent to not setting 
 it at all, causing it to load the full image, just to reload it in the proper 
 size afterwards.
 
 There's still an issue that the view starts up with a size of 1024x768, loads 
 the wallpaper, and then resizes itself to the screen geometry, causing a 
 delayed reload of the image which was previously not visible but together 
 with me waiting for the size to become available you can see that on 
 plasmashell startup, when using eg. the tiled fill mode.
 
 Unrelated:
  - Move the swap image stuff into a separate function
  - Use my animate binding trick for fillMode change too, now these are 
 lag-free also
 
 
 Diffs
 -
 
   wallpapers/image/imagepackage/contents/ui/main.qml 17683c0 
 
 Diff: https://git.reviewboard.kde.org/r/121294/diff/
 
 
 Testing
 ---
 
 Plasmoidviewer is much prettier to use now, no flickering, Plasmashell 
 startup is a bit more nasty imho (especially when using a wallpaper 
 background color) but should be concealed by ksplash. Switching between 
 wallpapers and fillmodes is smooth, it fades from black when changing a 
 wallpaper and fillmode at the same time but afaics that has been the case 
 previously, too.
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 121122: Allow loading KPluginMetaData from a .desktop file

2014-12-01 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121122/#review71169
---

Ship it!


Ship It!

- Marco Martin


On Nov. 14, 2014, 6:08 p.m., Sebastian Kügler wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121122/
 ---
 
 (Updated Nov. 14, 2014, 6:08 p.m.)
 
 
 Review request for KDE Frameworks, Plasma, Alexander Richardson, David Faure, 
 and Marco Martin.
 
 
 Repository: kcoreaddons
 
 
 Description
 ---
 
 This set of patches moves the code to decode and json-serialize from 
 desktoptojson into its own class, used by the KPluginMetaData(QString file) 
 constructor.
 
 These functions are not exported, desktoptojson directly includes this class. 
 I've done it this way to avoid littering the API, yet removing as much 
 duplicated code from desktoptojson as possible. These functions have gone 
 into their own class, and made static, since they don't carry state, anyway.
 
 The purpose of this patch is to allow the package indexer in kpackage (the 
 split-out framework containing Plasma::Package) to create a correct, 
 KPlugin-compatible cache file from package metadata. This patch allows us to 
 just feed a .desktop file into KPluginMetaData and get back correct 
 deserialized KPluginMetaData objects. It allows us to cut out the KService 
 dependency in KPackage.
 
 In particular, this is split up into the following patches (you can find it 
 in git kcoreaddons[sebas/kpluginmetadata] as well):
 
 
 Remove now-duplicated code in desktoptojson
 
 Use escapeValue, deserializeList and convertToJson from
 desktopfileparser.
 
 Move the bits to parse .desktop files into its own class
 
 This encapsulates the desktop file parseing logic into its own class.
 It's fairly self-contained, all static code. This also makes it easier
 to share this code with the desktoptojson binary.
 
 Allow to read KPluginMetaData from .desktop files
 
 Move the logic to create a KPluginMetaData object from desktoptojson
 into KPluginMetaData.
 
 This allows to load metadata from a .desktop file, making it possible to
 load desktop files without going through KPluginInfo (and thus
 KService). This is useful for conversion to json data, which will be
 used to index packages in the KPackage framework for faster lookups,
 similar to the index proof-of-concept for KPluginTrader.
 
 Add an autotest for loading KPluginMetaData from a .desktop file
 
 
 Diffs
 -
 
   autotests/data/fakeplugin.desktop PRE-CREATION 
   autotests/kpluginmetadatatest.cpp a1aaf80c8a5e25c2ae031a80fd1f8f96fa5924a0 
   src/desktoptojson/CMakeLists.txt c2d2b8780ab6cb34686bc7a43a3b6d4eaeb12b1e 
   src/desktoptojson/desktoptojson.cpp 
 3f0cfb129730cf7ba8adbf9c331d967f8a04d4e8 
   src/lib/CMakeLists.txt 1dc56270ab5157af706b7745cfa88ae11e16184a 
   src/lib/plugin/desktopfileparser.h PRE-CREATION 
   src/lib/plugin/desktopfileparser.cpp PRE-CREATION 
   src/lib/plugin/kpluginmetadata.h 67b68a50225e8ac82706caa849fb330567cee1d2 
   src/lib/plugin/kpluginmetadata.cpp f3e68c927370ad9212e8dfc07677ec17c52fdbdd 
 
 Diff: https://git.reviewboard.kde.org/r/121122/diff/
 
 
 Testing
 ---
 
 Added an autotest which compares a KPluginMetaData object created from a 
 desktop file. Also used this code from kpackage.
 
 
 Thanks,
 
 Sebastian Kügler
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Minutes Monday Plasma Hangout

2014-12-01 Thread Thomas Pfeiffer

On 01.12.2014 13:05, Sebastian Kügler wrote:

Aleix:
[...]
- worked on kamoso, frameworks branch should work like 4.x version, modulo
- sharing of pictures (could be shared with quickshare plasmoid)


What about Share/Like/Connect? Is that completely dead by now? Will it 
come back at a later point?


And there are also Friedrich Kossebau's (CC'ed) plans for a new context 
plugin framework which would also allow sharing (he talked to the 
usability group about them at Akademy). Could we use that when it's done?


Sharing is more and more important and should be accessible as easily as 
possible, without having to add additional Plasmoids manually.
It's okay to get this at a later point, but our sharing story is still 
too weak in general and has to be improved.


Cheers,
Thomas


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Minutes Monday Plasma Hangout

2014-12-01 Thread Marco Martin
On Monday 01 December 2014, Thomas Pfeiffer wrote:
 On 01.12.2014 13:05, Sebastian Kügler wrote:
  Aleix:
  [...]
  - worked on kamoso, frameworks branch should work like 4.x version,
  modulo - sharing of pictures (could be shared with quickshare plasmoid)
 
 What about Share/Like/Connect? Is that completely dead by now? Will it
 come back at a later point?

as soon there is some library to share stuff, for instance the mentioned one, 
having it used by share/like connect becomes trivial (also more applications 
starting to report their current open file).
i didn't really try to port so far becasue what was still missing was
a) the share library
b) integrated with kaccounts for authentication

that or *anything* else would solve the problem

 And there are also Friedrich Kossebau's (CC'ed) plans for a new context
 plugin framework which would also allow sharing (he talked to the
 usability group about them at Akademy). Could we use that when it's done?

ah, didn't know those.. where there is more info?

 Sharing is more and more important and should be accessible as easily as
 possible, without having to add additional Plasmoids manually.

one thing i would like is the share icon also automatically activated and 
added in the systray by default when the current application is exporting some 
url

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Minutes Monday Plasma Hangout

2014-12-01 Thread Aleix Pol
On Mon, Dec 1, 2014 at 2:39 PM, Thomas Pfeiffer thomas.pfeif...@kde.org
wrote:

 On 01.12.2014 13:05, Sebastian Kügler wrote:

 Aleix:
 [...]
 - worked on kamoso, frameworks branch should work like 4.x version, modulo
 - sharing of pictures (could be shared with quickshare plasmoid)


 What about Share/Like/Connect? Is that completely dead by now? Will it
 come back at a later point?

Well, it should be usable for the Share part, I guess. Yes.



 And there are also Friedrich Kossebau's (CC'ed) plans for a new context
 plugin framework which would also allow sharing (he talked to the usability
 group about them at Akademy). Could we use that when it's done?

I wasn't there, I can be filled-in.



 Sharing is more and more important and should be accessible as easily as
 possible, without having to add additional Plasmoids manually.

First iteration should be to integrate it into Kamoso like Kamoso-kde4 used
to do. No plasmoids, involved.


 It's okay to get this at a later point, but our sharing story is still too
 weak in general and has to be improved.

+1

Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Minutes Monday Plasma Hangout

2014-12-01 Thread Mario Fux
Am Montag, 01. Dezember 2014, 14.49:09 schrieb Marco Martin:

Morning

 On Monday 01 December 2014, Thomas Pfeiffer wrote:
  On 01.12.2014 13:05, Sebastian Kügler wrote:
   Aleix:
   [...]
   - worked on kamoso, frameworks branch should work like 4.x version,
   modulo - sharing of pictures (could be shared with quickshare plasmoid)
  
  What about Share/Like/Connect? Is that completely dead by now? Will it
  come back at a later point?
 
 as soon there is some library to share stuff, for instance the mentioned
 one, having it used by share/like connect becomes trivial (also more
 applications starting to report their current open file).
 i didn't really try to port so far becasue what was still missing was
 a) the share library

Was there a kdelibs4 version or was it missing back then too?

 b) integrated with kaccounts for authentication
 
 that or *anything* else would solve the problem
 
  And there are also Friedrich Kossebau's (CC'ed) plans for a new context
  plugin framework which would also allow sharing (he talked to the
  usability group about them at Akademy). Could we use that when it's done?
 
 ah, didn't know those.. where there is more info?

https://frinring.wordpress.com/

  Sharing is more and more important and should be accessible as easily as
  possible, without having to add additional Plasmoids manually.
 
 one thing i would like is the share icon also automatically activated and
 added in the systray by default when the current application is exporting
 some url

griits
Mario
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Minutes Monday Plasma Hangout

2014-12-01 Thread Marco Martin
On Monday 01 December 2014, Mario Fux wrote:
  as soon there is some library to share stuff, for instance the mentioned
  one, having it used by share/like connect becomes trivial (also more
  applications starting to report their current open file).
  i didn't really try to port so far becasue what was still missing was
  a) the share library
 
 Was there a kdelibs4 version or was it missing back then too?

nope, that's the reason why sadly in kde4 share like connect could just send 
email attachments and that was pretty much it :/

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 121311: Remove mnemonic underlines when alt-tabbing

2014-12-01 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121311/
---

Review request for Plasma and Hugo Pereira Da Costa.


Repository: breeze


Description
---

Remove mnemonic underlines when alt-tabbing

Alt+tab messes with the nmemonics.
In Qt5 we get a keyPressEvent, then we lose focus and don't receive a
keyReleaseEvent

This means the application keeps showing the mnemonic helpers even when
we switch back to the application.

BUG: 341006


Diffs
-

  kstyle/breezemnemonics.cpp 9395ea9 

Diff: https://git.reviewboard.kde.org/r/121311/diff/


Testing
---

Ran dolphin, pressed alt+tab a lot. Even with multiple windows it seems OK.


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[kwin] [Bug 341117] Breeze/Plastik (Not Oxygen) themes: First titlebar click ignored.

2014-12-01 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=341117

Hugo Pereira Da Costa hugo.pere...@free.fr changed:

   What|Removed |Added

Product|Breeze  |kwin
   Target Milestone|--- |5
 CC||hugo.pere...@free.fr
  Component|general |aurorae

--- Comment #1 from Hugo Pereira Da Costa hugo.pere...@free.fr ---
Reassigning to kwin
This is likely an aurorae bug

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 121311: Remove mnemonic underlines when alt-tabbing

2014-12-01 Thread Hugo Pereira Da Costa

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121311/#review71184
---

Ship it!


Thanks for looking into this
Please add (and close) bug 341006 to the review

- Hugo Pereira Da Costa


On Dec. 1, 2014, 2:33 p.m., David Edmundson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121311/
 ---
 
 (Updated Dec. 1, 2014, 2:33 p.m.)
 
 
 Review request for Plasma and Hugo Pereira Da Costa.
 
 
 Repository: breeze
 
 
 Description
 ---
 
 Remove mnemonic underlines when alt-tabbing
 
 Alt+tab messes with the nmemonics.
 In Qt5 we get a keyPressEvent, then we lose focus and don't receive a
 keyReleaseEvent
 
 This means the application keeps showing the mnemonic helpers even when
 we switch back to the application.
 
 BUG: 341006
 
 
 Diffs
 -
 
   kstyle/breezemnemonics.cpp 9395ea9 
 
 Diff: https://git.reviewboard.kde.org/r/121311/diff/
 
 
 Testing
 ---
 
 Ran dolphin, pressed alt+tab a lot. Even with multiple windows it seems OK.
 
 
 Thanks,
 
 David Edmundson
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Breeze] [Bug 340343] Open/Save File dialog - Highlight problem on headers

2014-12-01 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=340343

Hugo Pereira Da Costa hugo.pere...@free.fr changed:

   What|Removed |Added

 CC||hugo.pere...@free.fr

--- Comment #2 from Hugo Pereira Da Costa hugo.pere...@free.fr ---
... Can reproduce. Will investigate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 121311: Remove mnemonic underlines when alt-tabbing

2014-12-01 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121311/
---

(Updated Dec. 1, 2014, 2:42 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Hugo Pereira Da Costa.


Repository: breeze


Description
---

Remove mnemonic underlines when alt-tabbing

Alt+tab messes with the nmemonics.
In Qt5 we get a keyPressEvent, then we lose focus and don't receive a
keyReleaseEvent

This means the application keeps showing the mnemonic helpers even when
we switch back to the application.

BUG: 341006


Diffs
-

  kstyle/breezemnemonics.cpp 9395ea9 

Diff: https://git.reviewboard.kde.org/r/121311/diff/


Testing
---

Ran dolphin, pressed alt+tab a lot. Even with multiple windows it seems OK.


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 121311: Remove mnemonic underlines when alt-tabbing

2014-12-01 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121311/#review71189
---


this is not a sufficient solution (I fear). Scnario:
1. go to application and press Alt
2. move mouse to trigger Present Windows effect
3. release alt key
4. activate same application again

= will still be underlined as the application state never changed, but the 
application never got the key release event.

The root problem here is not that the active application changes, but that 
another process grabs the X11 keyboard. What would be needed is to detect that 
the keyboard is grabbed. Otherwise it will fail with any such setups where a 
keyboard grab is involved.

- Martin Gräßlin


On Dec. 1, 2014, 3:42 p.m., David Edmundson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121311/
 ---
 
 (Updated Dec. 1, 2014, 3:42 p.m.)
 
 
 Review request for Plasma and Hugo Pereira Da Costa.
 
 
 Repository: breeze
 
 
 Description
 ---
 
 Remove mnemonic underlines when alt-tabbing
 
 Alt+tab messes with the nmemonics.
 In Qt5 we get a keyPressEvent, then we lose focus and don't receive a
 keyReleaseEvent
 
 This means the application keeps showing the mnemonic helpers even when
 we switch back to the application.
 
 BUG: 341006
 
 
 Diffs
 -
 
   kstyle/breezemnemonics.cpp 9395ea9 
 
 Diff: https://git.reviewboard.kde.org/r/121311/diff/
 
 
 Testing
 ---
 
 Ran dolphin, pressed alt+tab a lot. Even with multiple windows it seems OK.
 
 
 Thanks,
 
 David Edmundson
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 121122: Allow loading KPluginMetaData from a .desktop file

2014-12-01 Thread Sebastian Kügler

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121122/
---

(Updated Dec. 1, 2014, 2:57 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma, Alexander Richardson, David Faure, 
and Marco Martin.


Repository: kcoreaddons


Description
---

This set of patches moves the code to decode and json-serialize from 
desktoptojson into its own class, used by the KPluginMetaData(QString file) 
constructor.

These functions are not exported, desktoptojson directly includes this class. 
I've done it this way to avoid littering the API, yet removing as much 
duplicated code from desktoptojson as possible. These functions have gone into 
their own class, and made static, since they don't carry state, anyway.

The purpose of this patch is to allow the package indexer in kpackage (the 
split-out framework containing Plasma::Package) to create a correct, 
KPlugin-compatible cache file from package metadata. This patch allows us to 
just feed a .desktop file into KPluginMetaData and get back correct 
deserialized KPluginMetaData objects. It allows us to cut out the KService 
dependency in KPackage.

In particular, this is split up into the following patches (you can find it in 
git kcoreaddons[sebas/kpluginmetadata] as well):


Remove now-duplicated code in desktoptojson

Use escapeValue, deserializeList and convertToJson from
desktopfileparser.

Move the bits to parse .desktop files into its own class

This encapsulates the desktop file parseing logic into its own class.
It's fairly self-contained, all static code. This also makes it easier
to share this code with the desktoptojson binary.

Allow to read KPluginMetaData from .desktop files

Move the logic to create a KPluginMetaData object from desktoptojson
into KPluginMetaData.

This allows to load metadata from a .desktop file, making it possible to
load desktop files without going through KPluginInfo (and thus
KService). This is useful for conversion to json data, which will be
used to index packages in the KPackage framework for faster lookups,
similar to the index proof-of-concept for KPluginTrader.

Add an autotest for loading KPluginMetaData from a .desktop file


Diffs
-

  autotests/data/fakeplugin.desktop PRE-CREATION 
  autotests/kpluginmetadatatest.cpp a1aaf80c8a5e25c2ae031a80fd1f8f96fa5924a0 
  src/desktoptojson/CMakeLists.txt c2d2b8780ab6cb34686bc7a43a3b6d4eaeb12b1e 
  src/desktoptojson/desktoptojson.cpp 3f0cfb129730cf7ba8adbf9c331d967f8a04d4e8 
  src/lib/CMakeLists.txt 1dc56270ab5157af706b7745cfa88ae11e16184a 
  src/lib/plugin/desktopfileparser.h PRE-CREATION 
  src/lib/plugin/desktopfileparser.cpp PRE-CREATION 
  src/lib/plugin/kpluginmetadata.h 67b68a50225e8ac82706caa849fb330567cee1d2 
  src/lib/plugin/kpluginmetadata.cpp f3e68c927370ad9212e8dfc07677ec17c52fdbdd 

Diff: https://git.reviewboard.kde.org/r/121122/diff/


Testing
---

Added an autotest which compares a KPluginMetaData object created from a 
desktop file. Also used this code from kpackage.


Thanks,

Sebastian Kügler

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Minutes Monday Plasma Hangout

2014-12-01 Thread Thomas Pfeiffer

On 01.12.2014 15:10, Mario Fux wrote:

ah, didn't know those.. where there is more info?


https://frinring.wordpress.com/


Yes, that's the one I meant (the most recent post). Direct link to the 
relevant post for future reference:

https://frinring.wordpress.com/2014/09/05/workspace-wide-services-on-non-file-objects/

I don't know what the current status is on that, and it's meant to do 
much much more than SLC in the end, but there is definitely an overlap. 
I hope Friedrich will tell us more.


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Breeze] [Bug 340343] Open/Save File dialog - Highlight problem on headers

2014-12-01 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=340343

Hugo Pereira Da Costa hugo.pere...@free.fr changed:

   What|Removed |Added

  Component|general |QStyle

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Breeze] [Bug 340343] Open/Save File dialog - Highlight problem on headers

2014-12-01 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=340343

Hugo Pereira Da Costa hugo.pere...@free.fr changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/bree
   ||ze/f852c0f76e0b7ab5f0258b1a
   ||426ec6e6e3ed447a
 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from Hugo Pereira Da Costa hugo.pere...@free.fr ---
Git commit f852c0f76e0b7ab5f0258b1a426ec6e6e3ed447a by Hugo Pereira Da Costa.
Committed on 01/12/2014 at 16:22.
Pushed by hpereiradacosta into branch 'Plasma/5.1'.

Manually calculate viewport update rect on header hover change

M  +27   -3kstyle/animations/breezeheaderviewdata.cpp
M  +1-15   kstyle/animations/breezeheaderviewdata.h

http://commits.kde.org/breeze/f852c0f76e0b7ab5f0258b1a426ec6e6e3ed447a

-- 
You are receiving this mail because:
You are the assignee for the bug.


Make the world a better place. Donate to our year end fundraiser 
https://www.kde.org/fundraisers/yearend2014/
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Breeze] [Bug 340343] Open/Save File dialog - Highlight problem on headers

2014-12-01 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=340343

Hugo Pereira Da Costa hugo.pere...@free.fr changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/bree |http://commits.kde.org/bree
   |ze/f852c0f76e0b7ab5f0258b1a |ze/59a34fe4e44f1ad23242d2c3
   |426ec6e6e3ed447a|ba6c35ecbaa70629

--- Comment #4 from Hugo Pereira Da Costa hugo.pere...@free.fr ---
Git commit 59a34fe4e44f1ad23242d2c3ba6c35ecbaa70629 by Hugo Pereira Da Costa.
Committed on 01/12/2014 at 16:22.
Pushed by hpereiradacosta into branch 'master'.

Manually calculate viewport update rect on header hover change

M  +27   -3kstyle/animations/breezeheaderviewdata.cpp
M  +1-15   kstyle/animations/breezeheaderviewdata.h

http://commits.kde.org/breeze/59a34fe4e44f1ad23242d2c3ba6c35ecbaa70629

-- 
You are receiving this mail because:
You are the assignee for the bug.


Make the world a better place. Donate to our year end fundraiser 
https://www.kde.org/fundraisers/yearend2014/
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Breeze icon theme structure

2014-12-01 Thread Andrew Lake
If there are no objections, I'll change the icons directory to match the
upstream repo directly later today.

Thanks,
Andrew

On Sun Nov 30 2014 at 9:01:42 AM Kai Uwe Broulik k...@privat.broulik.de
wrote:

 Given the index.theme has to specify what is where anway, I think the
 folder
 structure doesn't really matter?

 At least I've been running the Nitrux SA plasma-next-icons repository
 directly
 as main icon theme for a couple of days without a problem.

 Cheers,
 Kai Uwe

 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Build failed in Jenkins: plasma-desktop_stable_qt5 #17

2014-12-01 Thread KDE CI System
See http://build.kde.org/job/plasma-desktop_stable_qt5/17/changes

Changes:

[hein] Fix vertical aligment.

--
[...truncated 2753 lines...]
http://build.kde.org/job/plasma-desktop_stable_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:149:26:
 warning: ‘KIO::Job* KIO::pasteClipboard(const QUrl, QWidget*, bool)’ is 
deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kio/inst/include/KF5/KIOWidgets/kio/paste.h:46)
 [-Wdeprecated-declarations]
 KIO::Job *job = KIO::pasteClipboard(destUrl, parent, move);
  ^
http://build.kde.org/job/plasma-desktop_stable_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:149:62:
 warning: ‘KIO::Job* KIO::pasteClipboard(const QUrl, QWidget*, bool)’ is 
deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kio/inst/include/KF5/KIOWidgets/kio/paste.h:46)
 [-Wdeprecated-declarations]
 KIO::Job *job = KIO::pasteClipboard(destUrl, parent, move);
  ^
http://build.kde.org/job/plasma-desktop_stable_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:
 At global scope:
http://build.kde.org/job/plasma-desktop_stable_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:173:117:
 warning: ‘List’ is deprecated [-Wdeprecated-declarations]
 void KonqOperations::copy( QWidget * parent, Operation method, const 
KUrl::List  selectedUrls, const KUrl destUrl )

 ^
http://build.kde.org/job/plasma-desktop_stable_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:173:117:
 warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations]
http://build.kde.org/job/plasma-desktop_stable_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:206:110:
 warning: ‘List’ is deprecated [-Wdeprecated-declarations]
 void KonqOperations::_del( Operation method, const KUrl::List  _selectedUrls, 
ConfirmationType confirmation )

  ^
http://build.kde.org/job/plasma-desktop_stable_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:
 In member function ‘void KonqOperations::_del(KonqOperations::Operation, const 
KUrl::List, KonqOperations::ConfirmationType)’:
http://build.kde.org/job/plasma-desktop_stable_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:208:16:
 warning: ‘List’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:143)
 [-Wdeprecated-declarations]
 KUrl::List selectedUrls;
^
http://build.kde.org/job/plasma-desktop_stable_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:
 At global scope:
http://build.kde.org/job/plasma-desktop_stable_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:256:67:
 warning: ‘List’ is deprecated [-Wdeprecated-declarations]
 void KonqOperations::_restoreTrashedItems( const KUrl::List urls )
   ^
http://build.kde.org/job/plasma-desktop_stable_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:266:137:
 warning: ‘List’ is deprecated [-Wdeprecated-declarations]
 bool KonqOperations::askDeleteConfirmation( const KUrl::List  selectedUrls, 
int method, ConfirmationType confirmation, QWidget* widget )

 ^
http://build.kde.org/job/plasma-desktop_stable_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:287:111:
 warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations]
 void KonqOperations::doDrop( const KFileItem  destItem, const KUrl  dest, 
QDropEvent * ev, QWidget * parent )

   ^
http://build.kde.org/job/plasma-desktop_stable_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:293:78:
 warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations]
 const QListQAction*  userActions  )
  ^
http://build.kde.org/job/plasma-desktop_stable_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:
 In static member function ‘static KonqOperations* KonqOperations::doDrop(const 
KFileItem, const KUrl, QDropEvent*, QWidget*, const QListQAction*)’:
http://build.kde.org/job/plasma-desktop_stable_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:298:22:
 warning: ‘List’ is 

Jenkins build is back to normal : plasma-desktop_stable_qt5 #18

2014-12-01 Thread KDE CI System
See http://build.kde.org/job/plasma-desktop_stable_qt5/18/changes

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Breeze icon theme structure

2014-12-01 Thread Aleix Pol
On Mon, Dec 1, 2014 at 6:03 PM, Andrew Lake jamboar...@gmail.com wrote:

 If there are no objections, I'll change the icons directory to match the
 upstream repo directly later today.

 Thanks,
 Andrew

 On Sun Nov 30 2014 at 9:01:42 AM Kai Uwe Broulik k...@privat.broulik.de
 wrote:

 Given the index.theme has to specify what is where anway, I think the
 folder
 structure doesn't really matter?

 At least I've been running the Nitrux SA plasma-next-icons repository
 directly
 as main icon theme for a couple of days without a problem.


I think it's good, whatever makes your life easier, if it's not possible to
get Nitrux to join git.kde.org, anyway.

Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[KDE Bugtracking System] REMINDER: current Plasma regressions

2014-12-01 Thread bugzilla_noreply
Please find below a list of the current regressions reported for Plasma. This 
is a weekly reminder.

  This search was scheduled by myr...@kde.org.


Plasma regressions (1 bugs)
--
Bug 301424:
  https://bugs.kde.org/show_bug.cgi?id=301424
Severity: normal
Priority: NOR
  Status: REOPENED
  Resolution: 
 Product: plasma
Keywords: regression
   Component: widget-systemtray
 Version: 4.9.90 Beta2
 Summary: Cannot open battery monitor applet if set to hidden in systray

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel