Re: Review Request 121554: Simple network systemmonitor plasmoid rewrite

[Bhushan Shah]

> On Dec. 23, 2014, 8:45 a.m., David Edmundson wrote:
> > applets/systemmonitor/contents/ui/configGeneral.qml, line 2
> > 
> >
> > no it isn't?

someone evil is putting my name everywhere.. xD


- Bhushan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121554/#review72446
---


On Dec. 16, 2014, 7:09 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121554/
> ---
> 
> (Updated Dec. 16, 2014, 7:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> a simple rewrite of the "network" systemmonitor plasmoid, using the new 
> "plotter" component from extracomponents
> 
> 
> Diffs
> -
> 
>   applets/systemmonitor/metadata.desktop PRE-CREATION 
>   applets/systemmonitor/contents/config/main.xml PRE-CREATION 
>   applets/systemmonitor/contents/ui/configGeneral.qml PRE-CREATION 
>   applets/systemmonitor/contents/ui/net.qml PRE-CREATION 
>   applets/systemmonitor/contents/config/config.qml PRE-CREATION 
>   applets/CMakeLists.txt c4d40ac 
>   applets/systemmonitor/Messages.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121554/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> sysmon.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/12/16/4b5ba6d2-bc5e-4369-9f1e-ce80d510c894__sysmon.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121554: Simple network systemmonitor plasmoid rewrite

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121554/#review72446
---



applets/systemmonitor/contents/ui/configGeneral.qml


no it isn't?



applets/systemmonitor/contents/ui/configGeneral.qml


as arrays don't signal the apply button surely isn't going to work?


If this is the only thing that is going to be using the plotter, I really don't 
think it's worth rushing it if it isn't ready by 5.6

- David Edmundson


On Dec. 16, 2014, 1:39 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121554/
> ---
> 
> (Updated Dec. 16, 2014, 1:39 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> a simple rewrite of the "network" systemmonitor plasmoid, using the new 
> "plotter" component from extracomponents
> 
> 
> Diffs
> -
> 
>   applets/systemmonitor/metadata.desktop PRE-CREATION 
>   applets/systemmonitor/contents/config/main.xml PRE-CREATION 
>   applets/systemmonitor/contents/ui/configGeneral.qml PRE-CREATION 
>   applets/systemmonitor/contents/ui/net.qml PRE-CREATION 
>   applets/systemmonitor/contents/config/config.qml PRE-CREATION 
>   applets/CMakeLists.txt c4d40ac 
>   applets/systemmonitor/Messages.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121554/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> sysmon.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/12/16/4b5ba6d2-bc5e-4369-9f1e-ce80d510c894__sysmon.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121507: Add "silent" parameter to PM dataengine brightness jobs

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121507/
---

(Updated Dec. 22, 2014, 3:02 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

This adds a "silent" argument to the setBrightness jobs in the PM dataengine 
allowing the caller to suppress the OSD. I will use this in the battery monitor 
to not show the OSD when the user is actively dragging the slider since 
confirming an action he/she just did is redundant. It will show it when mouse 
wheeling the icon, however, to provide feedback there.


Diffs
-

  dataengines/powermanagement/powermanagementjob.h 8dd1731 
  dataengines/powermanagement/powermanagementjob.cpp 24ef2db 
  dataengines/powermanagement/powermanagementservice.operations c9abbf9 

Diff: https://git.reviewboard.kde.org/r/121507/diff/


Testing
---

Works as expected. Also it seems to be backwards compatible so clients not 
explicitly setting the "silent" property won't break but just default to false.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: KPackage framework

[David Edmundson]

No objections from me
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma Sprint Q1 2015

[David Edmundson]

> What do these sprints usually entail?
>

A good question.

Typically we solve all the difficult questions that would otherwise result
in months of to and fro on mailing lists. Either super hard technical
discussions or maybe airy-fairy direction discussions and presenting some
new ideas.

We will spend some time doing some pair programming  and doing some
focussed polishing where group critique and brainstorming help.

Whilst everyone is busy doing that, I will spend my time quietly thinking
about lunch.

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121507: Add "silent" parameter to PM dataengine brightness jobs

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121507/#review72428
---

Ship it!


Ship It!

- Lukáš Tinkl


On Pro. 14, 2014, 2:05 odp., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121507/
> ---
> 
> (Updated Pro. 14, 2014, 2:05 odp.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a "silent" argument to the setBrightness jobs in the PM dataengine 
> allowing the caller to suppress the OSD. I will use this in the battery 
> monitor to not show the OSD when the user is actively dragging the slider 
> since confirming an action he/she just did is redundant. It will show it when 
> mouse wheeling the icon, however, to provide feedback there.
> 
> 
> Diffs
> -
> 
>   dataengines/powermanagement/powermanagementjob.h 8dd1731 
>   dataengines/powermanagement/powermanagementjob.cpp 24ef2db 
>   dataengines/powermanagement/powermanagementservice.operations c9abbf9 
> 
> Diff: https://git.reviewboard.kde.org/r/121507/diff/
> 
> 
> Testing
> ---
> 
> Works as expected. Also it seems to be backwards compatible so clients not 
> explicitly setting the "silent" property won't break but just default to 
> false.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121507: Add "silent" parameter to PM dataengine brightness jobs

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121507/#review72427
---


Ping

The required PowerDevil changes have been committed

- Kai Uwe Broulik


On Dez. 14, 2014, 1:05 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121507/
> ---
> 
> (Updated Dez. 14, 2014, 1:05 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a "silent" argument to the setBrightness jobs in the PM dataengine 
> allowing the caller to suppress the OSD. I will use this in the battery 
> monitor to not show the OSD when the user is actively dragging the slider 
> since confirming an action he/she just did is redundant. It will show it when 
> mouse wheeling the icon, however, to provide feedback there.
> 
> 
> Diffs
> -
> 
>   dataengines/powermanagement/powermanagementjob.h 8dd1731 
>   dataengines/powermanagement/powermanagementjob.cpp 24ef2db 
>   dataengines/powermanagement/powermanagementservice.operations c9abbf9 
> 
> Diff: https://git.reviewboard.kde.org/r/121507/diff/
> 
> 
> Testing
> ---
> 
> Works as expected. Also it seems to be backwards compatible so clients not 
> explicitly setting the "silent" property won't break but just default to 
> false.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: KPackage framework

[Marco Martin]

On Monday 10 November 2014, Marco Martin wrote:
> Hi all,
> since at akademy there seemed the interest in it,
> I have been working on some classes i extracted from libplasma to be on
> their own, those related to Plasma::Package, since several applications
> have the interest of having scriptable or anyways non-binary content
> shippable over ghns.
> you can find them in the kpackage repository.

Since we are around ~2 weeks, I would like to move it, possibly to be released 
with next framework (since we would need it for Plasma (workspace) 5.2 would 
have to go in this frameworks release)

any objections?

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121429: Use out-of-band communication between ksld and greeter

[Àlex Fiestas]

> On des. 15, 2014, 10:45 p.m., Àlex Fiestas wrote:
> > Code looks good. 
> > 
> > Could you perhaps add an integration test for this? Since we are 
> > "abstracted" by the socket it should be possible. If it is too much work 
> > feel free to push it.
> 
> Martin Gräßlin wrote:
> what do you want the integration test to test? I certainly can start the 
> daemon but I'm not sure what it would give us as the only way to return from 
> it requires a password. And that's what the test application in tests already 
> does.
> 
> Àlex Fiestas wrote:
> Well, this patch adds a lot of new logic that can be tested, since it 
> does not have unit test (and doing them in ksmserver migh prove difficult) we 
> can test the code with an integraiton test.
> 
> I see lots of socket logic
> I see logic in addAllowedWindow
> And also the biggest method setKsldSocket which has 2 lambdas that 
> (afaik) can't be tested in any other way.
> 
> Martin Gräßlin wrote:
> The point is I don't see how to do an integration test for it. If we pull 
> up everything the screen is locked, like locked. It needs a damn password to 
> be entered to get unlocked. I just don't see how this could be integration 
> tested.
> 
> If you see how to integration test it please provide the code for it.

As I said, if it is too much work just push it :p.


- Àlex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121429/#review72103
---


On des. 15, 2014, 9:29 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121429/
> ---
> 
> (Updated des. 15, 2014, 9:29 a.m.)
> 
> 
> Review request for Plasma, Àlex Fiestas and David Edmundson.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The screenlocker_greet needs to tell the parent ksld process which
> windows it created. Ksld sends input events to these windows. So
> far this was based on an X property on the window. Unfortunately
> ksld didn't validate whether the windows tagged with this property
> belong to the screenlocker_greet process it started.
> 
> With this change the communication for announcing windows is moved
> away from the X11 protocol and instead a custom Wayland protocol is
> used.
> 
> Ksld starts a KWaylandServer when the greet process gets started. It
> creates anonymous unix sockets for the connection and passes one
> filedescriptor to the started greeter process.
> 
> The check for the X property is removed in ksld and instead only
> windows ids passed through the Wayland socket connection are
> accepted.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/ksldapp.cpp 22698ce37e9d4be17126111b3ded8133f7c3baa6 
>   ksmserver/screenlocker/lockwindow.h 
> 9938d201269c89a24c9c0bd6275aa5f731bb5535 
>   ksmserver/screenlocker/lockwindow.cpp 
> 3aa963a59e21636862f5ca59e220bbea3bd41ff9 
>   ksmserver/screenlocker/protocols/ksld.xml PRE-CREATION 
>   ksmserver/screenlocker/waylandserver.h PRE-CREATION 
>   ksmserver/screenlocker/waylandserver.cpp PRE-CREATION 
>   ksmserver/screenlocker/greeter/greeterapp.h 
> b92b13b63365a9026dba5d71b772dcd8c9ee3d3b 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> 30d1821bdba38028959f3457e900a1b32e628192 
>   ksmserver/screenlocker/greeter/main.cpp 
> 12e570107d0cba851b8978131d730b27924529bb 
>   ksmserver/screenlocker/ksldapp.h 095424c9845c134aa156917aeb6c8ddf31e8d25a 
>   CMakeLists.txt c6d89c14b05f5639937aee5692d305fa2faed974 
>   ksmserver/screenlocker/CMakeLists.txt 
> 5378a10df2be70cee95b5612c23046eae639f610 
>   ksmserver/screenlocker/greeter/CMakeLists.txt 
> 10c473488f08354096f68784b9240392a444af5f 
> 
> Diff: https://git.reviewboard.kde.org/r/121429/diff/
> 
> 
> Testing
> ---
> 
> Running ksmserver with the patch. Lock/unlock working, my exploit is failing.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121581: Plotter in kdeclarative

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121581/
---

(Updated Dec. 22, 2014, 12:27 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
---

on kquickcontrolsaddons plugin in order to not depend from kxmlgui
findepoxy is local for now, before making it work under window too (and move it 
to ECM)


Repository: kdeclarative


Description
---

This is an alternative, mutually exclusive to
https://gerrit.vesnicky.cesnet.cz/r/#/c/244
and dependent from
https://git.reviewboard.kde.org/r/121575/

since the plotter component doesn't depend from libplasma, it may be useful to 
have it outside of libplasma, so any applciation that wants it may use it.
Any opinion whether this should go here or in libplasma is welcome.


Diffs (updated)
-

  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 786aaa5 
  src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp 0e2eb2f 
  src/qmlcontrols/kquickcontrolsaddons/plotter.h PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/plotter.cpp PRE-CREATION 
  CMakeLists.txt 233ccce 
  cmake/Findepoxy.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121581/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.2 bits for kdereview

[Vishesh Handa]

On Fri, Dec 19, 2014 at 6:46 PM, Luigi Toscano 
wrote:

> >
> > User-manager frameworks port (it overlaps a little with account details
> kcm
> > but is mostly an admin tool)
> >  https://projects.kde.org/projects/playground/base/user-manager
> kuser replacement?


This one is problematic. We cannot just ship both.

They both overall to a large extent however the and user-manager doesn't
actually write to the kde config files for setting the full name + email.
We use that for bugzilla reports, kdevelop templates and a few other cases.

Also there is that hold one-bullet/vs-three/vs-none of password dialogs.
I'm fairly certain that is broken, but I need to test it out.


-- 
Vishesh Handa
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Minutes Monday Plasma Hangout

[Marco Martin]

Minutes Plasma Hangout, 22-12-2014

last one for 2014

David:
- bugs good progress
- investigate KScreen bug
- 

Harald:
- going to release QCA/Qt5
- going to work on tarball generation from CI

Jens:
- going to do a bit of management on the forums
- some applications design with Andrew

Martin:
- kaccounts/ktp
- going to do some work in notification positioning

Vishesh:
- worked on koko
- going to work more on that

Marco:
- work on plotter component
- will in next days merge plotter and KPackage, hopefully before frameworks 
release

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: KPackage framework

[David Faure]

On Monday 22 December 2014 10:21:21 Marco Martin wrote:
> On Saturday 20 December 2014, David Faure wrote:
> > > in the branch mart/kpluginmetadata there is an experiment in porting
> > > away
> > > from kservice, tough if i go all the way it should have a complete own
> > > copy of the plugin indexing (and indexing tool) since if it doesn't
> > > depend from kservice it should be completely independent from it
> > 
> > Sounds like depending on kcoreaddons (if the plugin indexing can go there)
> > would be better than duplicating the whole thing.
> 
> the biggest part is there, that is the KPluginMetadata constructor that
> takes a desktop file as argument.
> I'm not sure about writing/reading the cache file (wether is shareable with
> the one of KService library plugins)
> 
> maybe two statics for KPluginMetadata..
> QList KPluginMetadata::fromIndex(indexPath)
> void KPluginMetadata::createIndex(QList, indexPath)
> 
> they would just save few lines tough, the rest is different bewteen indexing
> of libraries and packages.

Ah well, if it's mostly different then forget what I said.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: KPackage framework

[Marco Martin]

On Saturday 20 December 2014, David Faure wrote:
> > in the branch mart/kpluginmetadata there is an experiment in porting away
> > from kservice, tough if i go all the way it should have a complete own
> > copy of the plugin indexing (and indexing tool) since if it doesn't
> > depend from kservice it should be completely independent from it
> 
> Sounds like depending on kcoreaddons (if the plugin indexing can go there)
> would be better than duplicating the whole thing.

the biggest part is there, that is the KPluginMetadata constructor that takes 
a desktop file as argument.
I'm not sure about writing/reading the cache file (wether is shareable with 
the one of KService library plugins)

maybe two statics for KPluginMetadata..
QList KPluginMetadata::fromIndex(indexPath)
void KPluginMetadata::createIndex(QList, indexPath)

they would just save few lines tough, the rest is different bewteen indexing 
of libraries and packages.

One thing tough: since this wouldn't affect the API and if possible we would 
kinda need this framework in the next workspace release, could this go in, 
then moving parts afterwards?

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma Sprint Q1 2015

[Scarlett Clark]

On Friday, December 19, 2014 11:51:34 PM David Edmundson wrote:
> ​You know the drill: https://sprints.kde.org/sprint/260
> 
> Any questions, ping me.
Oh oh! I wanna go! But the question is would it be useful for me to go. I need 
to convince people to pay my way lol. What do these sprints usually entail?
Scarlett

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel