Re: Review Request 121806: Allow desktop shell to force a window active

2015-01-03 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121806/
---

(Updated Jan. 3, 2015, 3:07 nachm.)


Review request for Plasma and Martin Gräßlin.


Repository: plasma-workspace


Description
---

This way the Desktop containment can eventually force the widget explorer and 
activity explorer active so they always accept keyboard input. Currently often 
you end up with a visibly focussed (ie. blinking cursor) panel but you cannot 
enter anything.
It is in the desktopview and not in some global import to minimize misuse 
outside the workspace scope.


Diffs
-

  shell/desktopview.h ea9e555 
  shell/desktopview.cpp bbe16f2 

Diff: https://git.reviewboard.kde.org/r/121806/diff/


Testing
---

In conjunction with a patch plasma-desktop, pressing Meta+Q at any given time 
causes the activity manager to open and it accepts keyboard events, entering a 
new activity name, etc works.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Breeze Window Decoration status

2015-01-03 Thread Andrew Lake
On Sat Jan 03 2015 at 10:46:37 AM Kai Uwe Broulik wrote:

 Hi Andrew,

  - No window shadows.

 I do have shadows and they're quite gorgeous. Most likely compositing isn't
 enabled in your VM.


Ahh that must be it. Sounds like we need a window edge definition solution
for when compositing is not enabled, since right now overlapping windows
blend into each other. If folks have ideas please share. I'll chat with
other VDG folks as well.



 The only thing that I wonder is that the borders are hardly rounded now.
 They
 used to be rounder.


Hmm, the corner radii seem to match the original reference design, at least
in the compositing-disabled visuals I'm seeing. Send me a screenshot when
you get a chance.

If anyone else sees something that might be worth tweaking before the
artwork freeze, holler. :-)

Thanks much Kai!
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Plasma naming scheme

2015-01-03 Thread Thomas Pfeiffer
Hi everyone,
while writing up a vision for Plasma interaction, the VDG noticed that it was 
unclear exactly what terms to use when referring to Plasma Desktop 
specifically, so we thought it would make sense to clarify this.

Therefore, we went ahead and drafted some communication guidelines I'd like to 
present for discussion:

- When talking about the the Plasma technology generically, use only Plasma, 
omitting the 5 as that is just an iteration of Plasma.

- When talking about a particular version of the technology, but not a 
specific shell, use Plasma [version] e.g. Plasma 5.1.

- When talking about the a specific shell but not about a specific version, 
use Plasma [shell], e.g. Plasma Desktop

- When talking about a specific shell in a particular version, use  Plasma 
[version] [shell] e.g. Plasma 5.2 Desktop, Plasma 5.4 Active

For example in release announcement we'd talk about the Plasma 5.2 release and 
when there are shell specific changes we could write Plasma Desktop now has 
addition X

Does that make sense to everyone? And if so: Where should we publish it and 
where should we announce it?

Cheers,
Thomas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Pyqt5 system tray menu problem in plasma5

2015-01-03 Thread Dimitrios Glentadakis
Hi, i wanted to ask about a problem with the system tray integration in plasma5.
I have this application :
https://github.com/dglent/meteo-qt/issues/34

and it works ok in the lxqt with qt5 but in pladma5 there is a problem with the 
context menu.
Initialy the context menu didn't appear at all because the application doesn't 
listen the right click event. Instead, it receives the middle click as a right 
click (in plasma5 only)

Adding the setContextMenu i have the context menu with right click but the 
context menu has a submenu which doesn't expand when i hover the mouse on.

The application is in python 3 and qt5 so it shouldn't have différences between 
qt5 enviroments.

What you suggest me to do in order to solve this?

Thanks very much in advance and happy new year.

Dimitrios Glentadakis

-- 
Envoyé depuis mon Jolla
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Breeze Window Decoration status

2015-01-03 Thread Andrew Lake
I'm super excited that we have the C++ Breeze windec now available! I
running kubuntu-ci live in a vm and I wasn't sure if what I'm seeing
reflects the most current state of the windec. The two main things I
noticed are:
- No window shadows.
- The titlebar doesn't have the (subtle) gradient of the reference design.
- The button symbols are implemented _really_ nicely.

The first one is probably the most important to help define the window
boundary. Sorry if I'm bringing up stuff folks are already aware of and are
working on. If there's anything we can provide from the VDG side to help,
let us know.

Thanks again!
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: [plasma-workspace] shell: Check for errors when the GetConfigOperation returns

2015-01-03 Thread Aleix Pol
On Sat, Jan 3, 2015 at 12:35 AM, David Edmundson
da...@davidedmundson.co.uk wrote:
 The handler is:

 void noMessageOutput(QtMsgType type, const char *msg)
 {
  Q_UNUSED(type);
  Q_UNUSED(msg);
 }

 that's going to block warnings too.

Then let's change it to:
QLoggingCategory::setFilterRules(QStringLiteral(*.debug=false\ndefault.debug=true\n));

Can anybody do it? if not I'll do it next week (sorry).

Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Breeze Window Decoration status

2015-01-03 Thread Kai Uwe Broulik
Hi Andrew,

 - No window shadows.

I do have shadows and they're quite gorgeous. Most likely compositing isn't 
enabled in your VM.

The only thing that I wonder is that the borders are hardly rounded now. They 
used to be rounder.

Cheers,
Kai Uwe
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins build is back to normal : plasma-workspace_master_qt5 #1177

2015-01-03 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/1177/changes

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 121772: Fade panels when dashboard is shown

2015-01-03 Thread Thomas Pfeiffer


 On Dez. 31, 2014, 11:29 vorm., Thomas Pfeiffer wrote:
  The more we (the VDG) think and learn about this, the more we realize that 
  we haven't really thought it through yet.
  It looks like it's back to the drawing board here, as we don't want to 
  make a change that makes as many users unhappy as it makes users happy.
  
  The whole concept of the dashboard definitely needs to be improved, but 
  just changing one thing while leaving the rest as it is won't help, so 
  we'll get back to you guys when we have a real, thought-through plan.
 
 Aleix Pol Gonzalez wrote:
 Yes, I had a conversation about that yesterday as well. I think it would 
 be very healthy if the usability/vdg thought about the dashboard and plasma 
 interaction in general.
 
 Thomas Pfeiffer wrote:
 Yes, it would, and we're on it. Stay tuned for an official announcement 
 once we've figured out our approach to this (I expect this to be a rather big 
 effort if we're going to do it right).
 
 Aleix Pol Gonzalez wrote:
 Shameless plug. Plasma sprint coming up, great place to discuss rather 
 big efforts: https://sprints.kde.org/sprint/260
 
 David Edmundson wrote:
 Thomas, Kai: asking a subtly different question:
 
 Any redesign is not going to get into Plamsa before 5.3. Do we want to 
 have this in for the next 3 months or leave it like it currently is.
 
 Kai Uwe Broulik wrote:
 I think we shouldn't do any half-baked sort of thing, so rather leave it 
 as is and then we can come up with something awesome™ later.

Agreed: Let's leave things the way they are for the moment and plan the future 
post-5.3.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121772/#review72832
---


On Dez. 31, 2014, 10:01 vorm., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121772/
 ---
 
 (Updated Dez. 31, 2014, 10:01 vorm.)
 
 
 Review request for Plasma and KDE Usability.
 
 
 Bugs: 342123
 https://bugs.kde.org/show_bug.cgi?id=342123
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 As suggested by the VDG.
 
 
 Diffs
 -
 
   desktoppackage/contents/views/Panel.qml 04a8e0b 
 
 Diff: https://git.reviewboard.kde.org/r/121772/diff/
 
 
 Testing
 ---
 
 Dashboard there, Panel faded; Dashboard gone, Panel there
 
 
 File Attachments
 
 
 Dashboard with dim panel
   
 https://git.reviewboard.kde.org/media/uploaded/files/2014/12/31/957bad71-2bfc-4451-b1dd-479d747f1a19__dashboardpanel2.jpg
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 121806: Allow desktop shell to force a window active

2015-01-03 Thread Kai Uwe Broulik


 On Jan. 3, 2015, 2:49 nachm., David Edmundson wrote:
  Adding a method to one class (DesktopView) to manipulate another an 
  instance of another class (Dialog) whilst using nothing from DesktopView to 
  me seems like poor API.
  
  I'd consider
  Q_INVOKABLE forceActiveFocus() on Plasma::Dialog

I know it's not pretty but I don't want to put that in such a prominent 
position right in Dialog. We already have the gentle requestActivate which 
KWin's focus stealing prevention will cancel if it would interrupt you.

Sure, everyone (like I just did or like Kicker does) could write a 
KWindowSystem wrapper import but we shouldn't encourage forcing activation, 
it's fine for the shell but not for everyone.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121806/#review73024
---


On Jan. 3, 2015, 2:35 nachm., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121806/
 ---
 
 (Updated Jan. 3, 2015, 2:35 nachm.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This way the Desktop containment can eventually force the widget explorer and 
 activity explorer active so they always accept keyboard input. Currently 
 often you end up with a visibly focussed (ie. blinking cursor) panel but you 
 cannot enter anything.
 It is in the desktopview and not in some global import to minimize misuse 
 outside the workspace scope.
 
 
 Diffs
 -
 
   shell/desktopview.h ea9e555 
   shell/desktopview.cpp bbe16f2 
 
 Diff: https://git.reviewboard.kde.org/r/121806/diff/
 
 
 Testing
 ---
 
 In conjunction with a patch plasma-desktop, pressing Meta+Q at any given time 
 causes the activity manager to open and it accepts keyboard events, entering 
 a new activity name, etc works.
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 121806: Allow desktop shell to force a window active

2015-01-03 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121806/#review73024
---


Adding a method to one class (DesktopView) to manipulate another an instance of 
another class (Dialog) whilst using nothing from DesktopView to me seems like 
poor API.

I'd consider
Q_INVOKABLE forceActiveFocus() on Plasma::Dialog

- David Edmundson


On Jan. 3, 2015, 2:35 p.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121806/
 ---
 
 (Updated Jan. 3, 2015, 2:35 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This way the Desktop containment can eventually force the widget explorer and 
 activity explorer active so they always accept keyboard input. Currently 
 often you end up with a visibly focussed (ie. blinking cursor) panel but you 
 cannot enter anything.
 It is in the desktopview and not in some global import to minimize misuse 
 outside the workspace scope.
 
 
 Diffs
 -
 
   shell/desktopview.h ea9e555 
   shell/desktopview.cpp bbe16f2 
 
 Diff: https://git.reviewboard.kde.org/r/121806/diff/
 
 
 Testing
 ---
 
 In conjunction with a patch plasma-desktop, pressing Meta+Q at any given time 
 causes the activity manager to open and it accepts keyboard events, entering 
 a new activity name, etc works.
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 121806: Allow desktop shell to force a window active

2015-01-03 Thread Lukáš Tinkl

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121806/#review73020
---

Ship it!


Ship It!

- Lukáš Tinkl


On Led. 3, 2015, 3:35 odp., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121806/
 ---
 
 (Updated Led. 3, 2015, 3:35 odp.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This way the Desktop containment can eventually force the widget explorer and 
 activity explorer active so they always accept keyboard input. Currently 
 often you end up with a visibly focussed (ie. blinking cursor) panel but you 
 cannot enter anything.
 It is in the desktopview and not in some global import to minimize misuse 
 outside the workspace scope.
 
 
 Diffs
 -
 
   shell/desktopview.h ea9e555 
   shell/desktopview.cpp bbe16f2 
 
 Diff: https://git.reviewboard.kde.org/r/121806/diff/
 
 
 Testing
 ---
 
 In conjunction with a patch plasma-desktop, pressing Meta+Q at any given time 
 causes the activity manager to open and it accepts keyboard events, entering 
 a new activity name, etc works.
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 121804: Fix wallpapers not showing in activity explorer due to change in plasma

2015-01-03 Thread Lukáš Tinkl

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121804/#review73021
---

Ship it!


Ship It!

- Lukáš Tinkl


On Led. 3, 2015, 2:13 odp., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121804/
 ---
 
 (Updated Led. 3, 2015, 2:13 odp.)
 
 
 Review request for Plasma and Ivan Čukić.
 
 
 Repository: kactivities
 
 
 Description
 ---
 
 Plasma stores its wallpaper configuration per configuration now [1]. This 
 adjusts kactivities to look for the config in the right place.
 
 [1] 
 http://quickgit.kde.org/?p=plasma-framework.gita=commith=c73085f66a83aa8a9fd4307900c0e5aa31358453
 
 
 Diffs
 -
 
   src/imports/activitymodel.cpp d7946ed 
 
 Diff: https://git.reviewboard.kde.org/r/121804/diff/
 
 
 Testing
 ---
 
 Wallpaper and background color in activity manager restored.
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 121804: Fix wallpapers not showing in activity explorer due to change in plasma

2015-01-03 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121804/
---

(Updated Jan. 3, 2015, 2:49 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Ivan Čukić.


Repository: kactivities


Description
---

Plasma stores its wallpaper configuration per configuration now [1]. This 
adjusts kactivities to look for the config in the right place.

[1] 
http://quickgit.kde.org/?p=plasma-framework.gita=commith=c73085f66a83aa8a9fd4307900c0e5aa31358453


Diffs
-

  src/imports/activitymodel.cpp d7946ed 

Diff: https://git.reviewboard.kde.org/r/121804/diff/


Testing
---

Wallpaper and background color in activity manager restored.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 121807: Call forceActiveWindow on the sidePanel

2015-01-03 Thread Lukáš Tinkl

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121807/#review73019
---

Ship it!


Ship It!

- Lukáš Tinkl


On Led. 3, 2015, 3:39 odp., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121807/
 ---
 
 (Updated Led. 3, 2015, 3:39 odp.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 See Review 121806
 
 
 Diffs
 -
 
   desktoppackage/contents/views/Desktop.qml c2da3b8 
 
 Diff: https://git.reviewboard.kde.org/r/121807/diff/
 
 
 Testing
 ---
 
 Works
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 121807: Call forceActiveWindow on the sidePanel

2015-01-03 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121807/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

See Review 121806


Diffs
-

  desktoppackage/contents/views/Desktop.qml c2da3b8 

Diff: https://git.reviewboard.kde.org/r/121807/diff/


Testing
---

Works


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins build is back to normal : plasma-desktop_master_qt5 #899

2015-01-03 Thread KDE CI System
See http://build.kde.org/job/plasma-desktop_master_qt5/899/changes

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 121806: Allow desktop shell to force a window active

2015-01-03 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121806/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

This way the Desktop containment can eventually force the widget explorer and 
activity explorer active so they always accept keyboard input. Currently often 
you end up with a visibly focussed (ie. blinking cursor) panel but you cannot 
enter anything.
It is in the desktopview and not in some global import to minimize misuse 
outside the workspace scope.


Diffs
-

  shell/desktopview.h ea9e555 
  shell/desktopview.cpp bbe16f2 

Diff: https://git.reviewboard.kde.org/r/121806/diff/


Testing
---

In conjunction with a patch plasma-desktop, pressing Meta+Q at any given time 
causes the activity manager to open and it accepts keyboard events, entering a 
new activity name, etc works.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 121804: Fix wallpapers not showing in activity explorer due to change in plasma

2015-01-03 Thread Luca Beltrame

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121804/#review73006
---


+1 from me, this fixes a small but long-standing annoying bug (tested, and 
works).

- Luca Beltrame


On Gen. 3, 2015, 1:13 p.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121804/
 ---
 
 (Updated Gen. 3, 2015, 1:13 p.m.)
 
 
 Review request for Plasma and Ivan Čukić.
 
 
 Repository: kactivities
 
 
 Description
 ---
 
 Plasma stores its wallpaper configuration per configuration now [1]. This 
 adjusts kactivities to look for the config in the right place.
 
 [1] 
 http://quickgit.kde.org/?p=plasma-framework.gita=commith=c73085f66a83aa8a9fd4307900c0e5aa31358453
 
 
 Diffs
 -
 
   src/imports/activitymodel.cpp d7946ed 
 
 Diff: https://git.reviewboard.kde.org/r/121804/diff/
 
 
 Testing
 ---
 
 Wallpaper and background color in activity manager restored.
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 121804: Fix wallpapers not showing in activity explorer due to change in plasma

2015-01-03 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121804/
---

Review request for Plasma and Ivan Čukić.


Repository: kactivities


Description
---

Plasma stores its wallpaper configuration per configuration now [1]. This 
adjusts kactivities to look for the config in the right place.

[1] 
http://quickgit.kde.org/?p=plasma-framework.gita=commith=c73085f66a83aa8a9fd4307900c0e5aa31358453


Diffs
-

  src/imports/activitymodel.cpp d7946ed 

Diff: https://git.reviewboard.kde.org/r/121804/diff/


Testing
---

Wallpaper and background color in activity manager restored.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Widget Explorer / Activity Manager Dock type

2015-01-03 Thread Kai Uwe Broulik
Hi,

I just tried calling 
KWindowSystem::forceActiveWindow(window-winId());
KWindowSystem::raiseWindow(window-winId());
on the Plasma::Dialog that contains the widget explorer/activity manager after 
it opened. Did not help either.

Just removing type: PlasmaCore.Dialog.Dock makes it work just fine. :/

The way to reproduce this is if any non-Plasma window has focus and then 
pressing Meta+Q the activity manager does not get focus. If you click the 
desktop prior to that, it works. That's probably also related why sometimes 
clicking task manager doesn't work if Plasma did not have focus.

Cheers,
Kai Uwe


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Widget Explorer / Activity Manager Dock type

2015-01-03 Thread Kai Uwe Broulik
Ok, nevermind, it didn't work because the mainItem wasn't loaded yet. Works 
now.

 I just tried calling
 KWindowSystem::forceActiveWindow(window-winId());
 KWindowSystem::raiseWindow(window-winId());
 on the Plasma::Dialog that contains the widget explorer/activity manager
 after it opened. Did not help either.

Cheers,
Kai Uwe

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Black Screen on Login

2015-01-03 Thread David Edmundson
I have a branch in kscreen, david/fixedit in which I fix it for sure,
maybe.

Can people test that please.

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 121360: Rework Plasma's notification positioning code

2015-01-03 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121360/#review73046
---


Overall the notification appearance is much cleaner, they don't overlap anymore 
and when they're updated they don't just flicker re-appear but fade out and 
fade in again.
However, the vertical positioning is completely off with the notifications 
dancing around the entire height of the screen from which it never recovers 
when you had multiple notifications appearing in quick succession.


applets/notifications/plugin/notificationshelper.cpp
https://git.reviewboard.kde.org/r/121360/#comment50826

Use QScopedPointer



applets/notifications/plugin/notificationshelper.cpp
https://git.reviewboard.kde.org/r/121360/#comment50823

New style connect?



applets/notifications/plugin/notificationshelper.cpp
https://git.reviewboard.kde.org/r/121360/#comment50824

Heh.


- Kai Uwe Broulik


On Jan. 3, 2015, 12:26 vorm., Martin Klapetek wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121360/
 ---
 
 (Updated Jan. 3, 2015, 12:26 vorm.)
 
 
 Review request for Plasma and Kai Uwe Broulik.
 
 
 Bugs: 339732
 https://bugs.kde.org/show_bug.cgi?id=339732
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 There can easily be situations where the popups could overlap one another or 
 result in strange animations. This patch rewrites the notifications so that 
 all actions such as show/reposition/hide are handled from a one single place 
 and every action is properly queued and protected around, which makes it more 
 robust, more predictive and less chaotic. There's also a slight delay between 
 every action so it's also visually much more cleaner and easier to see what's 
 going on. 
 
 
 Diffs
 -
 
   applets/notifications/package/contents/ui/NotificationPopup.qml 4491230 
   applets/notifications/plugin/notificationshelper.h af8f6fa 
   applets/notifications/plugin/notificationshelper.cpp 425f0d6 
 
 Diff: https://git.reviewboard.kde.org/r/121360/diff/
 
 
 Testing
 ---
 
 Tested whole day plus stress-tested with something like for i in {1..200}; do 
 notify-send $i - $RANDOM $RANDOM sdf sdf sdfwefhsdjfnskdfbkwefnos igodsfgn 
 sodifgj asodfgnsdlfgdf g; done executed from 4 terminals at once, all works 
 fine and as expected.
 
 
 Thanks,
 
 Martin Klapetek
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 121818: Slide in panel config

2015-01-03 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121818/
---

Review request for Plasma and Martin Gräßlin.


Repository: plasma-workspace


Description
---

Like it used to in the 4.x times.
It also makes the slow initialization of the panelcontroller a bit less painful.


Diffs
-

  shell/panelconfigview.h 3c6efad 
  shell/panelconfigview.cpp f039ee5 

Diff: https://git.reviewboard.kde.org/r/121818/diff/


Testing
---

Works. However there's a little graphical glidge (a 5px high white strip) 
during the transition. I have no idea where that comes from. There has been a 
similar glitch in the 4.x version ever since the shadows were moved over to 
KWin.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 121819: Don't mess with the mouse if the dialog isn't visible

2015-01-03 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121819/
---

Review request for Plasma.


Bugs: 342444
http://bugs.kde.org/show_bug.cgi?id=342444


Repository: plasma-framework


Description
---

As a workaround for Bug 342444 the dialog should not mess with the mouse if it 
is not visible. This patch makes sense even outside of that context imho.


Diffs
-

  src/plasmaquick/dialog.cpp 74c68a6 

Diff: https://git.reviewboard.kde.org/r/121819/diff/


Testing
---

No more crash when switching between activities and moving my mouse, see test 
case in the linked bug report.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Breeze Window Decoration status

2015-01-03 Thread Andrew Lake
On Sat Jan 03 2015 at 11:11:50 AM Andrew Lakewrote:

 On Sat Jan 03 2015 at 10:46:37 AM Kai Uwe Broulik wrote:

 Hi Andrew,

  - No window shadows.

 I do have shadows and they're quite gorgeous. Most likely compositing
 isn't
 enabled in your VM.


 Ahh that must be it. Sounds like we need a window edge definition solution
 for when compositing is not enabled, since right now overlapping windows
 blend into each other. If folks have ideas please share. I'll chat with
 other VDG folks as well.


After chatting with VDG folks here is a proposal for the edge of the
non-composite windows:
https://share.kde.org/public.php?service=filest=a0f8355a04acaa346e9a015d96e28846


Hope this helps and please let us know if there are any questions,
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel