Re: Review Request 122331: Add libinput support to kcm-touchpad

[Rajeesh K Nambiar]

> On Feb. 12, 2015, 12:39 a.m., David Edmundson wrote:
> > Built my X with libinput support.
> > 
> > Without this patch I get an erro, with this I get at least some options, 
> > though quite a few seemed disabled as they're just not available in 
> > libinput.

Indeed, many options are disabled because they are simply not available/exposed 
by libinput. See the discussion and bug listed here: 
https://lists.fedoraproject.org/pipermail/devel/2015-January/206918.html
To test, just install the libinput Xorg driver (xorg-x11-drv-libinput package 
in Fedora), it will be preferred over synaptics driver.


- Rajeesh


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122331/#review75896
---


On Jan. 30, 2015, 7:41 p.m., Rajeesh K Nambiar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122331/
> ---
> 
> (Updated Jan. 30, 2015, 7:41 p.m.)
> 
> 
> Review request for Plasma, Alexander Mezin and Martin Gräßlin.
> 
> 
> Repository: kcm-touchpad
> 
> 
> Description
> ---
> 
> ibinput is a library to handle input devices in Wayland compositors and to 
> provide a generic X.Org input driver. Add libinput support to kcm-touchpad.
> Patch authored by Peter Hutterer.
> 
> 
> Diffs
> -
> 
>   src/kcm/touchpad.kcfg 2afe642 
>   src/kcm/ui/tap.ui 8e081ad 
>   src/touchpadbackend.cpp 93e3dc2 
>   src/backends/x11.cmake f208281 
>   src/backends/x11/libinputproperties.c PRE-CREATION 
>   src/backends/x11/synclientproperties.h 5b32b9f 
>   src/backends/x11/xlibbackend.h 3692a60 
>   src/backends/x11/xlibbackend.cpp 3b5e5be 
>   src/kcm/customconfigdialogmanager.cpp 75b03ab 
> 
> Diff: https://git.reviewboard.kde.org/r/122331/diff/
> 
> 
> Testing
> ---
> 
> Fedora 21 RPM built and tested with Plasma 5.2.
> RPMs available here for testing: 
> https://copr-be.cloud.fedoraproject.org/results/rajeeshknambiar/kf5-kde-apps/fedora-21-x86_64/kf5-kcm_touchpad-5.1.96-1.fc21/
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #1308

[KDE CI System]

See 

Changes:

[scripty] SVN_SILENT made messages (.desktop file)

--
[...truncated 2597 lines...]
[ 73%] [ 73%] Generating notificationsadaptor.moc
Building CXX object 
dataengines/packagekit/CMakeFiles/plasma_engine_packagekit.dir/packagekitjob.cpp.o
[ 73%] Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/multiplexer.cpp.o
Scanning dependencies of target plasma_engine_notifications
[ 73%] Building CXX object 
dataengines/notifications/CMakeFiles/plasma_engine_notifications.dir/notificationsengine.cpp.o
:
 In member function ‘void SystemTray::PlasmoidProtocol::restorePlasmoids()’:
:129:121:
 warning: ‘static KPluginInfo::List KPluginInfo::fromServices(const List&, 
const KConfigGroup&)’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:193)
 [-Wdeprecated-declarations]
 KPluginInfo::List applets = 
KPluginInfo::fromServices(KServiceTypeTrader::self()->query("Plasma/Applet", 
constraint));

 ^
[ 73%] Building CXX object 
dataengines/notifications/CMakeFiles/plasma_engine_notifications.dir/notificationservice.cpp.o
Linking CXX shared module plasma_engine_hotplug.so
[ 73%] Building CXX object 
dataengines/packagekit/CMakeFiles/plasma_engine_packagekit.dir/packagekitengine.cpp.o
Linking CXX shared module plasma_engine_keystate.so
[ 73%] Built target plasma_engine_hotplug
[ 73%] Built target plasma_engine_keystate
Linking CXX shared library libsystemtrayplugin.so
[ 73%] Built target systemtrayplugin
[ 73%] Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/multiplexedservice.cpp.o
[ 73%] Building CXX object 
dataengines/packagekit/CMakeFiles/plasma_engine_packagekit.dir/plasma_engine_packagekit_automoc.cpp.o
[ 73%] Building CXX object 
dataengines/notifications/CMakeFiles/plasma_engine_notifications.dir/plasma_engine_notifications_automoc.cpp.o
[ 73%] [ 73%] Building CXX object 
dataengines/packagekit/CMakeFiles/plasma_engine_packagekit.dir/packagekitservice.cpp.o
Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/playercontrol.cpp.o
[ 73%] Building CXX object 
dataengines/notifications/CMakeFiles/plasma_engine_notifications.dir/notificationsadaptor.cpp.o
Linking CXX shared module plasma_engine_packagekit.so
[ 73%] Built target plasma_engine_packagekit
[ 73%] Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/playeractionjob.cpp.o
[ 73%] Generating statusnotifieritem_interface.cpp, 
statusnotifieritem_interface.h
[ 74%] Generating statusnotifierwatcher_interface.cpp, 
statusnotifierwatcher_interface.h
Scanning dependencies of target weather_ion
[ 74%] [ 74%] Generating statusnotifierwatcher_interface.cpp, 
statusnotifierwatcher_interface.h
Building CXX object 
dataengines/weather/ions/CMakeFiles/weather_ion.dir/ion.cpp.o
[ 74%] Generating statusnotifieritem_interface.moc
[ 74%] Generating statusnotifierwatcher_interface.moc
[ 74%] [ 75%] Building CXX object 
dataengines/notifications/CMakeFiles/plasma_engine_notifications.dir/notificationaction.cpp.o
Building CXX object 
dataengines/weather/ions/CMakeFiles/weather_ion.dir/weather_ion_automoc.cpp.o
Scanning dependencies of target plasma_engine_statusnotifieritem
[ 75%] Building CXX object 
dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritem_engine.cpp.o
Scanning dependencies of target plasma_engine_soliddevice
Scanning dependencies of target plasma_engine_time
[ 75%] Building CXX object 
dataengines/soliddevice/CMakeFiles/plasma_engine_soliddevice.dir/soliddeviceengine.cpp.o
[ 75%] Building CXX object 
dataengines/time/CMakeFiles/plasma_engine_time.dir/timeengine.cpp.o
[ 75%] Building CXX object 
dataengines/time/CMakeFiles/plasma_engine_time.dir/timesource.cpp.o
Linking CXX shared library libweather_ion.so
Linking CXX shared module plasma_engine_notifications.so
[ 75%] [ 75%] Built target weather_ion
Generating krunner_interface.cpp, krunner_interface.h
[ 75%] [ 75%] Generating krunner_interface.cpp, krunner_interface.h
Building CXX object 
dataengines/time/CMakeFiles/plasma_engine_time.dir/solarsystem.cpp.o
[ 75%] Generating krunner_interface.moc
Scanning dependencies of target plasma_engine_places
[ 75%] [ 75%] Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/playercontainer.cpp.o
Building CXX object 
dataengines/places/CMakeFiles/plasma_engine_places.dir/placesengine.cpp.o
[ 75%] Built target plasma_engine_notifications
[ 75%] Scannin

Re: Review Request 122383: Remove internal copy of KXmlRpcClient

[Daniel Vrátil]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122383/#review75906
---

Ship it!


KXmlRpcClient is a framework now!

- Daniel Vrátil


On Feb. 2, 2015, 4:37 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122383/
> ---
> 
> (Updated Feb. 2, 2015, 4:37 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Rohan Garg.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The internal copy isn't needed as soon as KXmlRpcClient becomes a framework.
> 
> 
> Diffs
> -
> 
>   drkonqi/internalkxmlrpcclient/KF5XmlRpcClientPrivateConfig.cmake.in 8f99a29 
>   drkonqi/internalkxmlrpcclient/README d8b6cd2 
>   drkonqi/internalkxmlrpcclient/autotests/CMakeLists.txt f737d14 
>   drkonqi/internalkxmlrpcclient/autotests/testclient.h e4897a3 
>   drkonqi/internalkxmlrpcclient/autotests/testclient.cpp f10b20a 
>   drkonqi/internalkxmlrpcclient/autotests/testquery.h 7957af6 
>   drkonqi/internalkxmlrpcclient/autotests/testquery.cpp f43a7ff 
>   drkonqi/internalkxmlrpcclient/src/CMakeLists.txt 884599e 
>   drkonqi/internalkxmlrpcclient/src/Messages.sh 059f34d 
>   drkonqi/internalkxmlrpcclient/src/client.h 60866da 
>   drkonqi/internalkxmlrpcclient/src/client.cpp 779a01a 
>   drkonqi/internalkxmlrpcclient/src/query.h cd6b786 
>   drkonqi/internalkxmlrpcclient/src/query.cpp ff18e24 
>   drkonqi/tests/bugzillalibtest/bugzillalibtest.cpp 83d299a 
>   CMakeLists.txt e4d2b2d 
>   drkonqi/CMakeLists.txt d851d84 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp 12d9626 
>   drkonqi/internalkxmlrpcclient/CMakeLists.txt 276aeaa 
>   drkonqi/internalkxmlrpcclient/COPYING.BSD cca2a5c 
> 
> Diff: https://git.reviewboard.kde.org/r/122383/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122331: Add libinput support to kcm-touchpad

[David Edmundson]

> On Feb. 12, 2015, 12:39 a.m., David Edmundson wrote:
> > Built my X with libinput support.
> > 
> > Without this patch I get an erro, with this I get at least some options, 
> > though quite a few seemed disabled as they're just not available in 
> > libinput.
> 
> Rajeesh K Nambiar wrote:
> Indeed, many options are disabled because they are simply not 
> available/exposed by libinput. See the discussion and bug listed here: 
> https://lists.fedoraproject.org/pipermail/devel/2015-January/206918.html
> To test, just install the libinput Xorg driver (xorg-x11-drv-libinput 
> package in Fedora), it will be preferred over synaptics driver.

Yeah, not a lot we can do about that for now.

Do you have commit access?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122331/#review75896
---


On Jan. 30, 2015, 7:41 p.m., Rajeesh K Nambiar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122331/
> ---
> 
> (Updated Jan. 30, 2015, 7:41 p.m.)
> 
> 
> Review request for Plasma, Alexander Mezin and Martin Gräßlin.
> 
> 
> Repository: kcm-touchpad
> 
> 
> Description
> ---
> 
> ibinput is a library to handle input devices in Wayland compositors and to 
> provide a generic X.Org input driver. Add libinput support to kcm-touchpad.
> Patch authored by Peter Hutterer.
> 
> 
> Diffs
> -
> 
>   src/kcm/touchpad.kcfg 2afe642 
>   src/kcm/ui/tap.ui 8e081ad 
>   src/touchpadbackend.cpp 93e3dc2 
>   src/backends/x11.cmake f208281 
>   src/backends/x11/libinputproperties.c PRE-CREATION 
>   src/backends/x11/synclientproperties.h 5b32b9f 
>   src/backends/x11/xlibbackend.h 3692a60 
>   src/backends/x11/xlibbackend.cpp 3b5e5be 
>   src/kcm/customconfigdialogmanager.cpp 75b03ab 
> 
> Diff: https://git.reviewboard.kde.org/r/122331/diff/
> 
> 
> Testing
> ---
> 
> Fedora 21 RPM built and tested with Plasma 5.2.
> RPMs available here for testing: 
> https://copr-be.cloud.fedoraproject.org/results/rajeeshknambiar/kf5-kde-apps/fedora-21-x86_64/kf5-kcm_touchpad-5.1.96-1.fc21/
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122383: Remove internal copy of KXmlRpcClient

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122383/
---

(Updated Feb. 12, 2015, 11:55 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma and Rohan Garg.


Repository: plasma-workspace


Description
---

The internal copy isn't needed as soon as KXmlRpcClient becomes a framework.


Diffs
-

  drkonqi/internalkxmlrpcclient/KF5XmlRpcClientPrivateConfig.cmake.in 8f99a29 
  drkonqi/internalkxmlrpcclient/README d8b6cd2 
  drkonqi/internalkxmlrpcclient/autotests/CMakeLists.txt f737d14 
  drkonqi/internalkxmlrpcclient/autotests/testclient.h e4897a3 
  drkonqi/internalkxmlrpcclient/autotests/testclient.cpp f10b20a 
  drkonqi/internalkxmlrpcclient/autotests/testquery.h 7957af6 
  drkonqi/internalkxmlrpcclient/autotests/testquery.cpp f43a7ff 
  drkonqi/internalkxmlrpcclient/src/CMakeLists.txt 884599e 
  drkonqi/internalkxmlrpcclient/src/Messages.sh 059f34d 
  drkonqi/internalkxmlrpcclient/src/client.h 60866da 
  drkonqi/internalkxmlrpcclient/src/client.cpp 779a01a 
  drkonqi/internalkxmlrpcclient/src/query.h cd6b786 
  drkonqi/internalkxmlrpcclient/src/query.cpp ff18e24 
  drkonqi/tests/bugzillalibtest/bugzillalibtest.cpp 83d299a 
  CMakeLists.txt e4d2b2d 
  drkonqi/CMakeLists.txt d851d84 
  drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp 12d9626 
  drkonqi/internalkxmlrpcclient/CMakeLists.txt 276aeaa 
  drkonqi/internalkxmlrpcclient/COPYING.BSD cca2a5c 

Diff: https://git.reviewboard.kde.org/r/122383/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122331: Add libinput support to kcm-touchpad

[Rajeesh K Nambiar]

> On Feb. 12, 2015, 12:39 a.m., David Edmundson wrote:
> > Built my X with libinput support.
> > 
> > Without this patch I get an erro, with this I get at least some options, 
> > though quite a few seemed disabled as they're just not available in 
> > libinput.
> 
> Rajeesh K Nambiar wrote:
> Indeed, many options are disabled because they are simply not 
> available/exposed by libinput. See the discussion and bug listed here: 
> https://lists.fedoraproject.org/pipermail/devel/2015-January/206918.html
> To test, just install the libinput Xorg driver (xorg-x11-drv-libinput 
> package in Fedora), it will be preferred over synaptics driver.
> 
> David Edmundson wrote:
> Yeah, not a lot we can do about that for now.
> 
> Do you have commit access?

I now have the developer account (yay).
Will check commit access in the evening once I have access to my system.


- Rajeesh


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122331/#review75896
---


On Jan. 30, 2015, 7:41 p.m., Rajeesh K Nambiar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122331/
> ---
> 
> (Updated Jan. 30, 2015, 7:41 p.m.)
> 
> 
> Review request for Plasma, Alexander Mezin and Martin Gräßlin.
> 
> 
> Repository: kcm-touchpad
> 
> 
> Description
> ---
> 
> ibinput is a library to handle input devices in Wayland compositors and to 
> provide a generic X.Org input driver. Add libinput support to kcm-touchpad.
> Patch authored by Peter Hutterer.
> 
> 
> Diffs
> -
> 
>   src/kcm/touchpad.kcfg 2afe642 
>   src/kcm/ui/tap.ui 8e081ad 
>   src/touchpadbackend.cpp 93e3dc2 
>   src/backends/x11.cmake f208281 
>   src/backends/x11/libinputproperties.c PRE-CREATION 
>   src/backends/x11/synclientproperties.h 5b32b9f 
>   src/backends/x11/xlibbackend.h 3692a60 
>   src/backends/x11/xlibbackend.cpp 3b5e5be 
>   src/kcm/customconfigdialogmanager.cpp 75b03ab 
> 
> Diff: https://git.reviewboard.kde.org/r/122331/diff/
> 
> 
> Testing
> ---
> 
> Fedora 21 RPM built and tested with Plasma 5.2.
> RPMs available here for testing: 
> https://copr-be.cloud.fedoraproject.org/results/rajeeshknambiar/kf5-kde-apps/fedora-21-x86_64/kf5-kcm_touchpad-5.1.96-1.fc21/
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #1309

[KDE CI System]

See 

Changes:

[aleixpol] Remove the internal kxmlrpcclient copy

--
[...truncated 2577 lines...]
[ 70%] Building CXX object 
dataengines/weather/ions/CMakeFiles/weather_ion.dir/ion.cpp.o
[ 70%] Building CXX object 
dataengines/weather/ions/CMakeFiles/weather_ion.dir/weather_ion_automoc.cpp.o
[ 70%] Generating statusnotifieritem_interface.cpp, 
statusnotifieritem_interface.h
[ 70%] Generating statusnotifierwatcher_interface.cpp, 
statusnotifierwatcher_interface.h
[ 70%] Generating statusnotifierwatcher_interface.cpp, 
statusnotifierwatcher_interface.h
[ 70%] Generating statusnotifieritem_interface.moc
[ 70%] Generating statusnotifierwatcher_interface.moc
Scanning dependencies of target plasma_engine_soliddevice
[ 70%] Scanning dependencies of target plasma_engine_time
[ 70%] Generating krunner_interface.cpp, krunner_interface.h
[ 70%] Building CXX object 
dataengines/soliddevice/CMakeFiles/plasma_engine_soliddevice.dir/soliddeviceengine.cpp.o
Building CXX object 
dataengines/time/CMakeFiles/plasma_engine_time.dir/timeengine.cpp.o
[ 70%] Generating krunner_interface.cpp, krunner_interface.h
[ 70%] Generating krunner_interface.moc
Scanning dependencies of target plasma_engine_places
[ 70%] Scanning dependencies of target plasma_engine_statusnotifieritem
Building CXX object 
dataengines/places/CMakeFiles/plasma_engine_places.dir/placesengine.cpp.o
[ 70%] Building CXX object 
dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritem_engine.cpp.o
Scanning dependencies of target plasma_engine_powermanagement
[ 70%] Building CXX object 
dataengines/powermanagement/CMakeFiles/plasma_engine_powermanagement.dir/powermanagementengine.cpp.o
Linking CXX shared library libweather_ion.so
[ 70%] [ 70%] Built target weather_ion
[ 70%] Generating notificationsadaptor.cpp, notificationsadaptor.h
Building CXX object 
dataengines/time/CMakeFiles/plasma_engine_time.dir/timesource.cpp.o
[ 70%] Generating mprisroot.cpp, mprisroot.h
Warning: deprecated annotation 'com.trolltech.QtDBus.QtTypeName.In6' found; 
suggest updating to 'org.qtproject.QtDBus.QtTypeName.In6'
Warning: deprecated annotation 'com.trolltech.QtDBus.QtTypeName.In6' found; 
suggest updating to 'org.qtproject.QtDBus.QtTypeName.In6'
Scanning dependencies of target plasma_engine_packagekit
[ 70%] Generating notificationsadaptor.cpp, notificationsadaptor.h
[ 71%] [ 72%] Generating dbusproperties.cpp, dbusproperties.h
Building CXX object 
dataengines/packagekit/CMakeFiles/plasma_engine_packagekit.dir/packagekitjob.cpp.o
Warning: deprecated annotation 'com.trolltech.QtDBus.QtTypeName.In6' found; 
suggest updating to 'org.qtproject.QtDBus.QtTypeName.In6'
Warning: deprecated annotation 'com.trolltech.QtDBus.QtTypeName.In6' found; 
suggest updating to 'org.qtproject.QtDBus.QtTypeName.In6'
[ 72%] Generating dbusproperties.cpp, dbusproperties.h
[ 73%] [ 73%] Generating mprisplayer.cpp, mprisplayer.h
Generating notificationsadaptor.moc
[ 73%] Generating mprisplayer.cpp, mprisplayer.h
[ 73%] Scanning dependencies of target plasma_engine_notifications
Generating mprisroot.moc
[ 73%] Building CXX object 
dataengines/notifications/CMakeFiles/plasma_engine_notifications.dir/notificationsengine.cpp.o
[ 73%] Generating dbusproperties.moc
:
 In member function ‘void TimeEngine::init()’:
:62:38:
 warning: ‘Solid::PowerManagement::Notifier* 
Solid::PowerManagement::notifier()’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/solid/powermanagement.h:154)
 [-Wdeprecated-declarations]
 connect( Solid::PowerManagement::notifier(), 
SIGNAL(resumingFromSuspend()), this , SLOT(clockSkewed()) );
  ^
:62:47:
 warning: ‘Solid::PowerManagement::Notifier* 
Solid::PowerManagement::notifier()’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/solid/powermanagement.h:154)
 [-Wdeprecated-declarations]
 connect( Solid::PowerManagement::notifier(), 
SIGNAL(resumingFromSuspend()), this , SLOT(clockSkewed()) );
   ^
[ 73%] Generating mprisplayer.moc
:
 In member function ‘virtual bool 
PowermanagementEngine::sourceRequestEvent(const QString&)’:
:209:41:
 warning: ‘Solid::PowerManagement::Notifier* 
Solid::PowerManagement::notifi

Re: Review Request 122540: Add screen reader to Accessibility KCM

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122540/#review75911
---


+1 in general.


kcms/access/kaccess.cpp


if we want this to appear in
systemsettings->global keyboard shortcuts 

we need to give the action an i18n'n name.

Otherwise it seems this becomes unconfigurable.


- David Edmundson


On Feb. 11, 2015, 11:23 p.m., Frederik Gladhorn wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122540/
> ---
> 
> (Updated Feb. 11, 2015, 11:23 p.m.)
> 
> 
> Review request for Plasma, Jonathan Riddell, Sebastian Sauer, and Jeremy 
> Whiting.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This patch adds a simple check box to the KCM which enables the screen
> reader.
> It additionally sets up the default shortcut - Meta-Alt-S which is the
> same as in Gnome. Using the same shortcut is of course extremely
> important, since blind users rely on an easy way to activeate the screen
> reader.
> 
> For now the whole process is hard-coded to Orca since there are no real
> alternatives for Linux screen readers at the moment.
> 
> The gconfig call which disables the screen reader will make Orca exit.
> It still needs to be launched manually.
> 
> I don't have much time for cleaning up the KCM, so help would be very much 
> appreciated.
> There are a lot of low hanging fruits for cleanup there. Also the port to 
> kf5, away from deprecated stuff is by far not complete.
> 
> 
> Diffs
> -
> 
>   kcms/access/CMakeLists.txt 55990d2 
>   kcms/access/accessibility.ui 2e0db83 
>   kcms/access/kaccess.h e101de4 
>   kcms/access/kaccess.cpp 2419efb 
>   kcms/access/kcmaccess.cpp 7e0217d 
> 
> Diff: https://git.reviewboard.kde.org/r/122540/diff/
> 
> 
> Testing
> ---
> 
> This allows me to start and stop Orca using meta-alt-s or the kcm.
> 
> 
> Thanks,
> 
> Frederik Gladhorn
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_stable_qt5 #63

[KDE CI System]

See 

Changes:

[lukas] properly propagate info and error messages from kcheckpass and PAM

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[plasma-workspace_stable_qt5] $ /bin/sh -xe /tmp/hudson5798462347600615589.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-workspace
   c8f650f..34d96b8  Plasma/5.2 -> origin/Plasma/5.2
   f8510cb..01b55c5  mart/KPackage -> origin/mart/KPackage
   3b23b76..d18b597  master -> origin/master
Branch jenkins set up to track remote branch Plasma/5.2 from origin.

== Cleaning Source Tree

HEAD is now at c8f650f manage applet destruction
Removing build/
Removing local-inst/
Success build forhudson.tasks.Shell@5d58609e
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/plasma-workspace # 
 > timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > git://anongit.kde.org/plasma-workspace +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 34d96b849963f4019755aca7dbacbd3ac2403c35 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 34d96b849963f4019755aca7dbacbd3ac2403c35
 > git rev-list c8f650f2767c1bccb46d1aaf7ac25b73fe4968a5 # timeout=10
 > git tag -a -f -m Jenkins Build #63 jenkins-plasma-workspace_stable_qt5-63 # 
 > timeout=10
[plasma-workspace_stable_qt5] $ /bin/sh -xe /tmp/hudson3889601151394098496.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch Plasma/5.2
== Build Dependencies:
 kbookmarks - Branch master
 libdbusmenu-qt - Branch master
 kcodecs - Branch master
 kpackage - Branch master
 breeze - Branch Plasma/5.2
 solid - Branch master
 kdoctools - Branch master
 knotifications - Branch master
 ktextwidgets - Branch master
 krunner - Branch master
 baloo - Branch Plasma/5.2
 milou - Branch Plasma/5.2
 kservice - Branch master
 kiconthemes - Branch master
 kdbusaddons - Branch master
 kwidgetsaddons - Branch master
 kdnssd - Branch master
 kdeclarative - Branch master
 khelpcenter - Branch Plasma/5.2
 libgit2 - Branch master
 kactivities - Branch master
 kjobwidgets - Branch master
 kidletime - Branch master
 kjs - Branch master
 libkscreen - Branch Plasma/5.2
 kitemmodels - Branch master
 kpty - Branch master
 kjsembed - Branch master
 sonnet - Branch master
 kde-cli-tools - Branch Plasma/5.2
 attica - Branch master
 kxmlrpcclient - Branch master
 karchive - Branch master
 threadweaver - Branch master
 kplotting - Branch master
 extra-cmake-modules - Branch master
 kitemviews - Branch master
 cmake - Branch master
 kdecoration - Branch Plasma/5.2
 kfilemetadata - Branch Plasma/5.2
 kio - Branch master
 kwin - Branch Plasma/5.2
 khtml - Branch master
 frameworkintegration - Branch master
 libksysguard - Branch Plasma/5.2
 kwindowsystem - Branch master
 knotifyconfig - Branch master
 kinit - Branch master
 knewstuff - Branch master
 qt5 - Branch 5.3.2
 kauth - Branch master
 kconfig - Branch master
 kio-extras - Branch Plasma/5.2
 kwallet - Branch master
 phonon - Branch master
 kdelibs4support - Branch master
 kdewebkit - Branch master
 kdesu - Branch master
 kunitconversion - Branch master
 kcrash - Branch master
 kdesignerplugin - Branch master
 kguiaddons - Branch master
 kcompletion - Branch master
 kconfigwidgets - Branch master
 kcoreaddons - Branch master
 dogtail - Branch master
 kded - Branch master
 kemoticons - Branch master
 kparts - Branch master
 kxmlgui - Branch master
 ktexteditor - Branch master
 kwayland - Branch Plasma/5.2
 kglobalaccel - Branch master
 kross - Branch master
 polkit-qt-1 - Branch master
 kcmutils - Branch master
 libssh - Branch master
 plasma-framework - Branch master
 kdesupport-svn - Branch master
 ki18n - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/kxmlrpcclient/in

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

[David Edmundson]

> On Feb. 10, 2015, 1:29 p.m., David Edmundson wrote:
> > I'm not convinced this is right.
> > 
> > From the doc you linked: 
> >  This is necessary for the system to implement auto-suspend when all 
> > sessions are idle.
> >  
> > When we lock the screen, powerdevil is still running, no?
> > 
> > Powerdevil has an inhibition blocking logind suspending, so I think overall 
> > this will just do nothing.
> 
> Martin Gräßlin wrote:
> The linked bug report gives another use case: cross-desktop check to see 
> whether the session is idle.
> 
> > Powerdevil has an inhibition blocking logind suspending, so I think 
> overall this will just do nothing.
> 
> Why is powerdevil holding an inhibition lock?
> 
> David Edmundson wrote:
> So we can implement auto suspend / key handling based on the user's KDE 
> configs, not based on some global configs.
> 
> Kai Uwe Broulik wrote:
> PowerDevil inhibits the following: 
> ["handle-power-key:handle-suspend-key:handle-hibernate-key:handle-lid-switch",
>  "PowerDevil", "KDE handles power events", "block"]
> Also, "IdleAction" is "ignore" here.
> 
> Martin Gräßlin wrote:
> If I understand that correctly David's concern doesn't hold?

I still want a question answered.

Why do we want logind to do it's idle action when we are showing a lock screen 
when we're managing auto suspend ourselves?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122510/#review75777
---


On Feb. 10, 2015, 1:21 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122510/
> ---
> 
> (Updated Feb. 10, 2015, 1:21 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 271731
> https://bugs.kde.org/show_bug.cgi?id=271731
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> See the idle recommendations on [1]. Binding it to the lock screen does
> not exactly match the recommendation, but it has some advantages:
> * we know it's idle when it's locked
> * it kicks in after the user's configured idle timeout
> * if the user unlocks we know it's no longer idle
> 
> FEATURE: 271731
> FIXED-IN: 5.3.0
> 
> [1] 
> http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 
>   ksmserver/screenlocker/logind.h 99836734923740a1f0b23144f9effd815f104b74 
>   ksmserver/screenlocker/logind.cpp 5335b150bce8f38aee75ad30055bc0e248ed1bf1 
> 
> Diff: https://git.reviewboard.kde.org/r/122510/diff/
> 
> 
> Testing
> ---
> 
> Run the test application and verified using loginctl from tty1 while the 
> screen was locked and after unlocked.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #1310

[KDE CI System]

See 

Changes:

[notmart] use <> includes

--
[...truncated 2577 lines...]
Linking CXX shared library libplasma-geolocation-interface.so
Scanning dependencies of target plasma_engine_mpris2
[ 72%] Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/mpris2engine.cpp.o
[ 72%] Built target systemtrayplugin
[ 72%] Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/multiplexer.cpp.o
[ 72%] Built target plasma_engine_filebrowser
[ 72%] Scanning dependencies of target plasma_engine_keystate
Built target plasma-geolocation-interface
[ 72%] [ 72%] Building CXX object 
dataengines/notifications/CMakeFiles/plasma_engine_notifications.dir/notificationservice.cpp.o
Building CXX object 
dataengines/keystate/CMakeFiles/plasma_engine_keystate.dir/keystate.cpp.o
Linking CXX shared module plasma_engine_favicons.so
[ 72%] Built target plasma_engine_favicons
[ 72%] Building CXX object 
dataengines/keystate/CMakeFiles/plasma_engine_keystate.dir/keyservice.cpp.o
[ 72%] Building CXX object 
dataengines/notifications/CMakeFiles/plasma_engine_notifications.dir/notificationaction.cpp.o
[ 72%] Building CXX object 
dataengines/hotplug/CMakeFiles/plasma_engine_hotplug.dir/hotplugjob.cpp.o
[ 72%] [ 72%] Building CXX object 
dataengines/hotplug/CMakeFiles/plasma_engine_hotplug.dir/plasma_engine_hotplug_automoc.cpp.o
Building CXX object 
dataengines/notifications/CMakeFiles/plasma_engine_notifications.dir/notificationsadaptor.cpp.o
Scanning dependencies of target plasma_engine_packagekit
[ 73%] Building CXX object 
dataengines/packagekit/CMakeFiles/plasma_engine_packagekit.dir/packagekitjob.cpp.o
[ 73%] Building CXX object 
dataengines/keystate/CMakeFiles/plasma_engine_keystate.dir/plasma_engine_keystate_automoc.cpp.o
[ 73%] Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/multiplexedservice.cpp.o
[ 73%] [ 73%] Building CXX object 
dataengines/notifications/CMakeFiles/plasma_engine_notifications.dir/plasma_engine_notifications_automoc.cpp.o
Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/playercontrol.cpp.o
[ 73%] Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/playercontainer.cpp.o
[ 73%] Building CXX object 
dataengines/packagekit/CMakeFiles/plasma_engine_packagekit.dir/packagekitengine.cpp.o
Linking CXX shared module plasma_engine_hotplug.so
[ 73%] Built target plasma_engine_hotplug
Linking CXX shared module plasma_engine_keystate.so
[ 73%] Built target plasma_engine_keystate
Scanning dependencies of target plasma_engine_places
[ 73%] [ 73%] Generating krunner_interface.cpp, krunner_interface.h
Building CXX object 
dataengines/places/CMakeFiles/plasma_engine_places.dir/placesengine.cpp.o
[ 73%] Generating krunner_interface.cpp, krunner_interface.h
[ 73%] Generating krunner_interface.moc
[ 73%] [ 74%] [ 74%] Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/playeractionjob.cpp.o
Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/dbusproperties.cpp.o
Building CXX object 
dataengines/packagekit/CMakeFiles/plasma_engine_packagekit.dir/packagekitservice.cpp.o
Linking CXX shared module plasma_engine_notifications.so
Scanning dependencies of target plasma_engine_powermanagement
[ 74%] Building CXX object 
dataengines/powermanagement/CMakeFiles/plasma_engine_powermanagement.dir/powermanagementengine.cpp.o
[ 74%] Built target plasma_engine_notifications
[ 74%] Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/mprisplayer.cpp.o
Scanning dependencies of target plasma_engine_soliddevice
[ 74%] Building CXX object 
dataengines/soliddevice/CMakeFiles/plasma_engine_soliddevice.dir/soliddeviceengine.cpp.o
[ 74%] Building CXX object 
dataengines/soliddevice/CMakeFiles/plasma_engine_soliddevice.dir/devicesignalmapper.cpp.o
[ 74%] Building CXX object 
dataengines/packagekit/CMakeFiles/plasma_engine_packagekit.dir/plasma_engine_packagekit_automoc.cpp.o
[ 74%] Building CXX object 
dataengines/soliddevice/CMakeFiles/plasma_engine_soliddevice.dir/devicesignalmapmanager.cpp.o
:
 In member function ‘virtual bool 
PowermanagementEngine::sourceRequestEvent(const QString&)’:
:209:41:
 warning: ‘Solid::PowerManagement::Notifier* 
Solid::PowerManagement::notifier()’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/solid/powermanagement.h:154)
 [-Wdeprecated-declarations]
 connect(Solid::PowerManagement::notifier(), 
SIGNAL(appShouldConserveResourcesChanged(bool)),
 ^

Build failed in Jenkins: plasma-workspace_master_qt5 #1311

[KDE CI System]

See 

Changes:

[lukas] properly propagate info and error messages from kcheckpass and PAM

--
[...truncated 2580 lines...]
[ 71%] Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/multiplexer.cpp.o
Linking CXX shared library libplasma-geolocation-interface.so
[ 71%] Built target plasma-geolocation-interface
Linking CXX shared module plasma_engine_favicons.so
[ 71%] Generating notificationsadaptor.cpp, notificationsadaptor.h
Warning: deprecated annotation 'com.trolltech.QtDBus.QtTypeName.In6' found; 
suggest updating to 'org.qtproject.QtDBus.QtTypeName.In6'
Warning: deprecated annotation 'com.trolltech.QtDBus.QtTypeName.In6' found; 
suggest updating to 'org.qtproject.QtDBus.QtTypeName.In6'
[ 71%] Generating notificationsadaptor.cpp, notificationsadaptor.h
Warning: deprecated annotation 'com.trolltech.QtDBus.QtTypeName.In6' found; 
suggest updating to 'org.qtproject.QtDBus.QtTypeName.In6'
Warning: deprecated annotation 'com.trolltech.QtDBus.QtTypeName.In6' found; 
suggest updating to 'org.qtproject.QtDBus.QtTypeName.In6'
Scanning dependencies of target plasma_engine_packagekit
[ 72%] [ 73%] Generating notificationsadaptor.moc
Building CXX object 
dataengines/packagekit/CMakeFiles/plasma_engine_packagekit.dir/packagekitjob.cpp.o
[ 73%] Built target plasma_engine_favicons
Scanning dependencies of target plasma_engine_notifications
[ 73%] Building CXX object 
dataengines/notifications/CMakeFiles/plasma_engine_notifications.dir/notificationsengine.cpp.o
Linking CXX shared module plasma_engine_hotplug.so
[ 73%] Built target plasma_engine_hotplug
[ 73%] Building CXX object 
dataengines/notifications/CMakeFiles/plasma_engine_notifications.dir/notificationservice.cpp.o
Linking CXX shared module plasma_engine_keystate.so
[ 74%] Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/playeractionjob.cpp.o
[ 74%] Built target plasma_engine_keystate
[ 74%] Building CXX object 
dataengines/packagekit/CMakeFiles/plasma_engine_packagekit.dir/packagekitengine.cpp.o
[ 74%] Building CXX object 
dataengines/notifications/CMakeFiles/plasma_engine_notifications.dir/notificationaction.cpp.o
[ 74%] Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/playercontainer.cpp.o
[ 74%] [ 74%] Building CXX object 
dataengines/notifications/CMakeFiles/plasma_engine_notifications.dir/notificationsadaptor.cpp.o
Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/playercontrol.cpp.o
[ 74%] Building CXX object 
dataengines/packagekit/CMakeFiles/plasma_engine_packagekit.dir/packagekitservice.cpp.o
[ 74%] Building CXX object 
dataengines/packagekit/CMakeFiles/plasma_engine_packagekit.dir/plasma_engine_packagekit_automoc.cpp.o
[ 74%] Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/dbusproperties.cpp.o
[ 74%] Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/multiplexedservice.cpp.o
[ 74%] Building CXX object 
dataengines/notifications/CMakeFiles/plasma_engine_notifications.dir/plasma_engine_notifications_automoc.cpp.o
Scanning dependencies of target plasma_engine_places
[ 74%] Building CXX object 
dataengines/places/CMakeFiles/plasma_engine_places.dir/placesengine.cpp.o
[ 74%] Generating krunner_interface.cpp, krunner_interface.h
[ 74%] Generating krunner_interface.cpp, krunner_interface.h
[ 74%] Generating krunner_interface.moc
[ 74%] Building CXX object 
dataengines/places/CMakeFiles/plasma_engine_places.dir/placeservice.cpp.o
Scanning dependencies of target plasma_engine_powermanagement
[ 74%] Building CXX object 
dataengines/powermanagement/CMakeFiles/plasma_engine_powermanagement.dir/powermanagementengine.cpp.o
Linking CXX shared module plasma_engine_packagekit.so
[ 75%] Building CXX object 
dataengines/powermanagement/CMakeFiles/plasma_engine_powermanagement.dir/powermanagementjob.cpp.o
[ 75%] Built target plasma_engine_packagekit
[ 75%] Building CXX object 
dataengines/places/CMakeFiles/plasma_engine_places.dir/setupdevicejob.cpp.o
Linking CXX shared module plasma_engine_notifications.so
[ 75%] Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/mprisplayer.cpp.o
[ 76%] Building CXX object 
dataengines/places/CMakeFiles/plasma_engine_places.dir/placesproxymodel.cpp.o
[ 76%] Built target plasma_engine_notifications
Scanning dependencies of target plasma_engine_soliddevice
[ 76%] Building CXX object 
dataengines/soliddevice/CMakeFiles/plasma_engine_soliddevice.dir/soliddeviceengine.cpp.o
[ 76%] Building CXX object 
dataengines/powermanagement/CMakeFiles/plasma_engine_powermanagement.dir/powermanagementservice.cpp.o
:
 In member function ‘virtual bool 
PowermanagementEngine::sourceRequestEvent(const QString&)’:

Re: Review Request 122331: Add libinput support to kcm-touchpad

[Sebastian Kügler]

> On Feb. 12, 2015, 12:39 a.m., David Edmundson wrote:
> > Built my X with libinput support.
> > 
> > Without this patch I get an erro, with this I get at least some options, 
> > though quite a few seemed disabled as they're just not available in 
> > libinput.
> 
> Rajeesh K Nambiar wrote:
> Indeed, many options are disabled because they are simply not 
> available/exposed by libinput. See the discussion and bug listed here: 
> https://lists.fedoraproject.org/pipermail/devel/2015-January/206918.html
> To test, just install the libinput Xorg driver (xorg-x11-drv-libinput 
> package in Fedora), it will be preferred over synaptics driver.
> 
> David Edmundson wrote:
> Yeah, not a lot we can do about that for now.
> 
> Do you have commit access?
> 
> Rajeesh K Nambiar wrote:
> I now have the developer account (yay).
> Will check commit access in the evening once I have access to my system.

Why will the libinput driver be prefferred over synaptics if synaptics provides 
more features and is more mature? Is that a packaging-specific thing, do we 
have any control over it? From the point of a user, this is going to cause 
regressions.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122331/#review75896
---


On Jan. 30, 2015, 7:41 p.m., Rajeesh K Nambiar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122331/
> ---
> 
> (Updated Jan. 30, 2015, 7:41 p.m.)
> 
> 
> Review request for Plasma, Alexander Mezin and Martin Gräßlin.
> 
> 
> Repository: kcm-touchpad
> 
> 
> Description
> ---
> 
> ibinput is a library to handle input devices in Wayland compositors and to 
> provide a generic X.Org input driver. Add libinput support to kcm-touchpad.
> Patch authored by Peter Hutterer.
> 
> 
> Diffs
> -
> 
>   src/kcm/touchpad.kcfg 2afe642 
>   src/kcm/ui/tap.ui 8e081ad 
>   src/touchpadbackend.cpp 93e3dc2 
>   src/backends/x11.cmake f208281 
>   src/backends/x11/libinputproperties.c PRE-CREATION 
>   src/backends/x11/synclientproperties.h 5b32b9f 
>   src/backends/x11/xlibbackend.h 3692a60 
>   src/backends/x11/xlibbackend.cpp 3b5e5be 
>   src/kcm/customconfigdialogmanager.cpp 75b03ab 
> 
> Diff: https://git.reviewboard.kde.org/r/122331/diff/
> 
> 
> Testing
> ---
> 
> Fedora 21 RPM built and tested with Plasma 5.2.
> RPMs available here for testing: 
> https://copr-be.cloud.fedoraproject.org/results/rajeeshknambiar/kf5-kde-apps/fedora-21-x86_64/kf5-kcm_touchpad-5.1.96-1.fc21/
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122331: Add libinput support to kcm-touchpad

[David Edmundson]

> On Feb. 12, 2015, 12:39 a.m., David Edmundson wrote:
> > Built my X with libinput support.
> > 
> > Without this patch I get an erro, with this I get at least some options, 
> > though quite a few seemed disabled as they're just not available in 
> > libinput.
> 
> Rajeesh K Nambiar wrote:
> Indeed, many options are disabled because they are simply not 
> available/exposed by libinput. See the discussion and bug listed here: 
> https://lists.fedoraproject.org/pipermail/devel/2015-January/206918.html
> To test, just install the libinput Xorg driver (xorg-x11-drv-libinput 
> package in Fedora), it will be preferred over synaptics driver.
> 
> David Edmundson wrote:
> Yeah, not a lot we can do about that for now.
> 
> Do you have commit access?
> 
> Rajeesh K Nambiar wrote:
> I now have the developer account (yay).
> Will check commit access in the evening once I have access to my system.
> 
> Sebastian Kügler wrote:
> Why will the libinput driver be prefferred over synaptics if synaptics 
> provides more features and is more mature? Is that a packaging-specific 
> thing, do we have any control over it? From the point of a user, this is 
> going to cause regressions.

it's a distro/X thing.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122331/#review75896
---


On Jan. 30, 2015, 7:41 p.m., Rajeesh K Nambiar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122331/
> ---
> 
> (Updated Jan. 30, 2015, 7:41 p.m.)
> 
> 
> Review request for Plasma, Alexander Mezin and Martin Gräßlin.
> 
> 
> Repository: kcm-touchpad
> 
> 
> Description
> ---
> 
> ibinput is a library to handle input devices in Wayland compositors and to 
> provide a generic X.Org input driver. Add libinput support to kcm-touchpad.
> Patch authored by Peter Hutterer.
> 
> 
> Diffs
> -
> 
>   src/kcm/touchpad.kcfg 2afe642 
>   src/kcm/ui/tap.ui 8e081ad 
>   src/touchpadbackend.cpp 93e3dc2 
>   src/backends/x11.cmake f208281 
>   src/backends/x11/libinputproperties.c PRE-CREATION 
>   src/backends/x11/synclientproperties.h 5b32b9f 
>   src/backends/x11/xlibbackend.h 3692a60 
>   src/backends/x11/xlibbackend.cpp 3b5e5be 
>   src/kcm/customconfigdialogmanager.cpp 75b03ab 
> 
> Diff: https://git.reviewboard.kde.org/r/122331/diff/
> 
> 
> Testing
> ---
> 
> Fedora 21 RPM built and tested with Plasma 5.2.
> RPMs available here for testing: 
> https://copr-be.cloud.fedoraproject.org/results/rajeeshknambiar/kf5-kde-apps/fedora-21-x86_64/kf5-kcm_touchpad-5.1.96-1.fc21/
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122331: Add libinput support to kcm-touchpad

[Rajeesh K Nambiar]

> On Feb. 12, 2015, 12:39 a.m., David Edmundson wrote:
> > Built my X with libinput support.
> > 
> > Without this patch I get an erro, with this I get at least some options, 
> > though quite a few seemed disabled as they're just not available in 
> > libinput.
> 
> Rajeesh K Nambiar wrote:
> Indeed, many options are disabled because they are simply not 
> available/exposed by libinput. See the discussion and bug listed here: 
> https://lists.fedoraproject.org/pipermail/devel/2015-January/206918.html
> To test, just install the libinput Xorg driver (xorg-x11-drv-libinput 
> package in Fedora), it will be preferred over synaptics driver.
> 
> David Edmundson wrote:
> Yeah, not a lot we can do about that for now.
> 
> Do you have commit access?
> 
> Rajeesh K Nambiar wrote:
> I now have the developer account (yay).
> Will check commit access in the evening once I have access to my system.
> 
> Sebastian Kügler wrote:
> Why will the libinput driver be prefferred over synaptics if synaptics 
> provides more features and is more mature? Is that a packaging-specific 
> thing, do we have any control over it? From the point of a user, this is 
> going to cause regressions.
> 
> David Edmundson wrote:
> it's a distro/X thing.

X automatically choses libinput driver over synaptics if installed. Users still 
have the choice to opt out by not installing libinput X driver.
Libinput is the common input stack for Wayland and X, and distros (like Fedora) 
are going to switch to it in next versions. Please also see the rationale at 
[1] and [2].
[1] 
http://who-t.blogspot.com/2014/09/libinput-common-input-stack-for-wayland.html
[2] 
http://blog.martin-graesslin.com/blog/2014/10/libinput-integration-in-kwinwayland/


- Rajeesh


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122331/#review75896
---


On Jan. 30, 2015, 7:41 p.m., Rajeesh K Nambiar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122331/
> ---
> 
> (Updated Jan. 30, 2015, 7:41 p.m.)
> 
> 
> Review request for Plasma, Alexander Mezin and Martin Gräßlin.
> 
> 
> Repository: kcm-touchpad
> 
> 
> Description
> ---
> 
> ibinput is a library to handle input devices in Wayland compositors and to 
> provide a generic X.Org input driver. Add libinput support to kcm-touchpad.
> Patch authored by Peter Hutterer.
> 
> 
> Diffs
> -
> 
>   src/kcm/touchpad.kcfg 2afe642 
>   src/kcm/ui/tap.ui 8e081ad 
>   src/touchpadbackend.cpp 93e3dc2 
>   src/backends/x11.cmake f208281 
>   src/backends/x11/libinputproperties.c PRE-CREATION 
>   src/backends/x11/synclientproperties.h 5b32b9f 
>   src/backends/x11/xlibbackend.h 3692a60 
>   src/backends/x11/xlibbackend.cpp 3b5e5be 
>   src/kcm/customconfigdialogmanager.cpp 75b03ab 
> 
> Diff: https://git.reviewboard.kde.org/r/122331/diff/
> 
> 
> Testing
> ---
> 
> Fedora 21 RPM built and tested with Plasma 5.2.
> RPMs available here for testing: 
> https://copr-be.cloud.fedoraproject.org/results/rajeeshknambiar/kf5-kde-apps/fedora-21-x86_64/kf5-kcm_touchpad-5.1.96-1.fc21/
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122533: Port accessibility kcm somewhat to xcb xkb

[Frederik Gladhorn]

> On Feb. 12, 2015, 6:53 a.m., Martin Gräßlin wrote:
> > kcms/access/kaccess.cpp, lines 379-385
> > 
> >
> > Is there no event type defined in xkb?

I looked and finally checked how Qt does it, if you can find one, I'd be happy 
to use it.


- Frederik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122533/#review75900
---


On Feb. 11, 2015, 9:25 p.m., Frederik Gladhorn wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122533/
> ---
> 
> (Updated Feb. 11, 2015, 9:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I don't really speak xcb, so I'd appreciate if someone could look over this 
> for sanity's sake. The patch seems relatively straight forward to me though. 
> I wonder how broken the old code was, it seems to have been rotting for a 
> while.
> 
> 
> Diffs
> -
> 
>   kcms/access/kaccess.h e101de4 
>   kcms/access/kaccess.cpp 2419efb 
> 
> Diff: https://git.reviewboard.kde.org/r/122533/diff/
> 
> 
> Testing
> ---
> 
> After this change sticky keys and some of the other features seem to work 
> again.
> 
> 
> Thanks,
> 
> Frederik Gladhorn
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122533: Port accessibility kcm somewhat to xcb xkb

[Frederik Gladhorn]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122533/
---

(Updated Feb. 12, 2015, 4:50 p.m.)


Review request for Plasma.


Repository: plasma-desktop


Description
---

I don't really speak xcb, so I'd appreciate if someone could look over this for 
sanity's sake. The patch seems relatively straight forward to me though. I 
wonder how broken the old code was, it seems to have been rotting for a while.


Diffs (updated)
-

  kcms/access/kaccess.h e101de4 
  kcms/access/kaccess.cpp 2419efb 

Diff: https://git.reviewboard.kde.org/r/122533/diff/


Testing
---

After this change sticky keys and some of the other features seem to work again.


Thanks,

Frederik Gladhorn

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122540: Add screen reader to Accessibility KCM

[Frederik Gladhorn]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122540/
---

(Updated Feb. 12, 2015, 5:01 p.m.)


Review request for Plasma, Jonathan Riddell, Sebastian Sauer, and Jeremy 
Whiting.


Changes
---

i18n added


Repository: plasma-desktop


Description
---

This patch adds a simple check box to the KCM which enables the screen
reader.
It additionally sets up the default shortcut - Meta-Alt-S which is the
same as in Gnome. Using the same shortcut is of course extremely
important, since blind users rely on an easy way to activeate the screen
reader.

For now the whole process is hard-coded to Orca since there are no real
alternatives for Linux screen readers at the moment.

The gconfig call which disables the screen reader will make Orca exit.
It still needs to be launched manually.

I don't have much time for cleaning up the KCM, so help would be very much 
appreciated.
There are a lot of low hanging fruits for cleanup there. Also the port to kf5, 
away from deprecated stuff is by far not complete.


Diffs (updated)
-

  kcms/access/CMakeLists.txt 55990d2 
  kcms/access/accessibility.ui 2e0db83 
  kcms/access/kaccess.h e101de4 
  kcms/access/kaccess.cpp 2419efb 
  kcms/access/kcmaccess.cpp 7e0217d 

Diff: https://git.reviewboard.kde.org/r/122540/diff/


Testing
---

This allows me to start and stop Orca using meta-alt-s or the kcm.


Thanks,

Frederik Gladhorn

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122540: Add screen reader to Accessibility KCM

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122540/#review75930
---



kcms/access/kaccess.cpp


Sorry I wasn't clear.

Not here. 
This needs to remain a unique ID.

I meant action->setText(i18n())


- David Edmundson


On Feb. 12, 2015, 5:01 p.m., Frederik Gladhorn wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122540/
> ---
> 
> (Updated Feb. 12, 2015, 5:01 p.m.)
> 
> 
> Review request for Plasma, Jonathan Riddell, Sebastian Sauer, and Jeremy 
> Whiting.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This patch adds a simple check box to the KCM which enables the screen
> reader.
> It additionally sets up the default shortcut - Meta-Alt-S which is the
> same as in Gnome. Using the same shortcut is of course extremely
> important, since blind users rely on an easy way to activeate the screen
> reader.
> 
> For now the whole process is hard-coded to Orca since there are no real
> alternatives for Linux screen readers at the moment.
> 
> The gconfig call which disables the screen reader will make Orca exit.
> It still needs to be launched manually.
> 
> I don't have much time for cleaning up the KCM, so help would be very much 
> appreciated.
> There are a lot of low hanging fruits for cleanup there. Also the port to 
> kf5, away from deprecated stuff is by far not complete.
> 
> 
> Diffs
> -
> 
>   kcms/access/CMakeLists.txt 55990d2 
>   kcms/access/accessibility.ui 2e0db83 
>   kcms/access/kaccess.h e101de4 
>   kcms/access/kaccess.cpp 2419efb 
>   kcms/access/kcmaccess.cpp 7e0217d 
> 
> Diff: https://git.reviewboard.kde.org/r/122540/diff/
> 
> 
> Testing
> ---
> 
> This allows me to start and stop Orca using meta-alt-s or the kcm.
> 
> 
> Thanks,
> 
> Frederik Gladhorn
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Change in plasma-framework[master]: support for C++ applets

[Marco Martin (Code Review)]

Marco Martin has uploaded a new change for review.

  https://gerrit.vesnicky.cesnet.cz/r/374

Change subject: support for C++ applets
..

support for C++ applets

make possible for an applet to be implemented in c++ but still
have the qml package with the usual api, this was supposed to
be supported from the beginning.

if a c++ applet has been loaded, make available the property
plasmoid.nativeInterface to the qml part, exposing the subclasses
Applet instance with all eventual extra propertiels/slots.

if no c++ plugin is present, appletInterface will be dummy/not available

this (besides limiting a bit the qml import rabbit procreation)
makes available some things not available to normal private imports:
* access to applet config() to save more complex things compared to what 
kconfigxt allows
  or save/load stuff from the c++ part
* access to containment()/corona(), may be useful for containment 
implementations
* easier port for old very big applets such as comics/weather

Change-Id: I65117660043de3a60ad58c77b086f686683d4d8c
---
M src/plasma/pluginloader.cpp
M src/scriptengines/qml/plasmoid/appletinterface.cpp
M src/scriptengines/qml/plasmoid/appletinterface.h
3 files changed, 26 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework 
refs/changes/74/374/1

diff --git a/src/plasma/pluginloader.cpp b/src/plasma/pluginloader.cpp
index 48cd46c..7ecdd15 100644
--- a/src/plasma/pluginloader.cpp
+++ b/src/plasma/pluginloader.cpp
@@ -201,8 +201,8 @@
 
 QVariantList allArgs;
 allArgs << offer->storageId() << appletId << args;
-
-if (!offer->property("X-Plasma-API").toString().isEmpty()) {
+if (!offer->property("X-Plasma-API").toString().isEmpty() &&
+offer->property("Library").toString().isEmpty()) {
 #ifndef NDEBUG
 // qDebug() << "we have a script using the"
 // << offer->property("X-Plasma-API").toString() << "API";
diff --git a/src/scriptengines/qml/plasmoid/appletinterface.cpp 
b/src/scriptengines/qml/plasmoid/appletinterface.cpp
index 0ec2c34..ab8056b 100644
--- a/src/scriptengines/qml/plasmoid/appletinterface.cpp
+++ b/src/scriptengines/qml/plasmoid/appletinterface.cpp
@@ -63,6 +63,7 @@
   m_busy(false),
   m_hideOnDeactivate(true),
   m_oldKeyboardShortcut(0),
+  m_dummyNativeInterface(0),
   m_positionBeforeRemoval(QPointF(-1, -1))
 {
 qmlRegisterType();
@@ -118,7 +119,8 @@
   m_appletScriptEngine(0),
   m_backgroundHints(Plasma::Types::StandardBackground),
   m_busy(false),
-  m_hideOnDeactivate(true)
+  m_hideOnDeactivate(true),
+  m_dummyNativeInterface(0)
 {
 qmlRegisterType();
 
@@ -585,6 +587,19 @@
 applet()->setGlobalShortcut(sequence);
 }
 
+QObject *AppletInterface::nativeInterface()
+{
+if (applet()->metaObject()->className() != "Plasma::Applet") {
+return applet();
+} else {
+//This being CONSTANT is guaranteed to be called only once
+if (!m_dummyNativeInterface) {
+m_dummyNativeInterface = new QObject(this);
+}
+return m_dummyNativeInterface;
+}
+}
+
 QString AppletInterface::downloadPath(const QString &file)
 {
 const QString downloadDir = 
QStandardPaths::writableLocation(QStandardPaths::DownloadLocation) + "/Plasma/" 
+ applet()->pluginInfo().pluginName() + '/';
diff --git a/src/scriptengines/qml/plasmoid/appletinterface.h 
b/src/scriptengines/qml/plasmoid/appletinterface.h
index 457f5df..32a72ee 100644
--- a/src/scriptengines/qml/plasmoid/appletinterface.h
+++ b/src/scriptengines/qml/plasmoid/appletinterface.h
@@ -192,6 +192,11 @@
  */
 Q_PROPERTY(QKeySequence globalShortcut READ globalShortcut WRITE 
setGlobalShortcut NOTIFY globalShortcutChanged)
 
+/**
+ * An interface to the native C++ plasmoid, if implemented
+ */
+Q_PROPERTY(QObject *nativeInterface READ nativeInterface CONSTANT)
+
 public:
 AppletInterface(DeclarativeAppletScript *script, const QVariantList &args 
= QVariantList(), QQuickItem *parent = 0);
 AppletInterface(Plasma::Applet *applet, const QVariantList &args = 
QVariantList(), QQuickItem *parent = 0);
@@ -318,6 +323,8 @@
 QKeySequence globalShortcut() const;
 void setGlobalShortcut(const QKeySequence &keySequence);
 
+QObject *nativeInterface();
+
 Q_SIGNALS:
 /**
  * somebody else, usually the containment sent some data to the applet
@@ -390,6 +397,7 @@
 bool m_hideOnDeactivate : 1;
 //this is used to build an emacs style shortcut
 int m_oldKeyboardShortcut;
+QObject *m_dummyNativeInterface;
 
 friend class ContainmentInterface;
 //This is used by ContainmentInterface

-- 
To view, visit https://gerrit.vesnicky.cesnet.cz/r/374
To unsubscribe, visit https://gerrit.vesnicky.cesnet.cz/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I65117660043de3a60ad58c77b086f686683d4d8c
Gerrit-PatchSet: 1
Gerrit-Proj

Re: Review Request 122540: Add screen reader to Accessibility KCM

[Frederik Gladhorn]

> On Feb. 12, 2015, 5:16 p.m., David Edmundson wrote:
> > kcms/access/kaccess.cpp, line 347
> > 
> >
> > Sorry I wasn't clear.
> > 
> > Not here. 
> > This needs to remain a unique ID.
> > 
> > I meant action->setText(i18n())

ah, I was wondering how that would survive language changes... thanks!


- Frederik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122540/#review75930
---


On Feb. 12, 2015, 5:01 p.m., Frederik Gladhorn wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122540/
> ---
> 
> (Updated Feb. 12, 2015, 5:01 p.m.)
> 
> 
> Review request for Plasma, Jonathan Riddell, Sebastian Sauer, and Jeremy 
> Whiting.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This patch adds a simple check box to the KCM which enables the screen
> reader.
> It additionally sets up the default shortcut - Meta-Alt-S which is the
> same as in Gnome. Using the same shortcut is of course extremely
> important, since blind users rely on an easy way to activeate the screen
> reader.
> 
> For now the whole process is hard-coded to Orca since there are no real
> alternatives for Linux screen readers at the moment.
> 
> The gconfig call which disables the screen reader will make Orca exit.
> It still needs to be launched manually.
> 
> I don't have much time for cleaning up the KCM, so help would be very much 
> appreciated.
> There are a lot of low hanging fruits for cleanup there. Also the port to 
> kf5, away from deprecated stuff is by far not complete.
> 
> 
> Diffs
> -
> 
>   kcms/access/CMakeLists.txt 55990d2 
>   kcms/access/accessibility.ui 2e0db83 
>   kcms/access/kaccess.h e101de4 
>   kcms/access/kaccess.cpp 2419efb 
>   kcms/access/kcmaccess.cpp 7e0217d 
> 
> Diff: https://git.reviewboard.kde.org/r/122540/diff/
> 
> 
> Testing
> ---
> 
> This allows me to start and stop Orca using meta-alt-s or the kcm.
> 
> 
> Thanks,
> 
> Frederik Gladhorn
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122540: Add screen reader to Accessibility KCM

[Frederik Gladhorn]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122540/
---

(Updated Feb. 12, 2015, 6:12 p.m.)


Review request for Plasma, Jonathan Riddell, Sebastian Sauer, and Jeremy 
Whiting.


Repository: plasma-desktop


Description
---

This patch adds a simple check box to the KCM which enables the screen
reader.
It additionally sets up the default shortcut - Meta-Alt-S which is the
same as in Gnome. Using the same shortcut is of course extremely
important, since blind users rely on an easy way to activeate the screen
reader.

For now the whole process is hard-coded to Orca since there are no real
alternatives for Linux screen readers at the moment.

The gconfig call which disables the screen reader will make Orca exit.
It still needs to be launched manually.

I don't have much time for cleaning up the KCM, so help would be very much 
appreciated.
There are a lot of low hanging fruits for cleanup there. Also the port to kf5, 
away from deprecated stuff is by far not complete.


Diffs (updated)
-

  kcms/access/kaccess.cpp 2419efb 
  kcms/access/kcmaccess.cpp 7e0217d 
  kcms/access/CMakeLists.txt 55990d2 
  kcms/access/accessibility.ui 2e0db83 
  kcms/access/kaccess.h e101de4 

Diff: https://git.reviewboard.kde.org/r/122540/diff/


Testing
---

This allows me to start and stop Orca using meta-alt-s or the kcm.


Thanks,

Frederik Gladhorn

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122540: Add screen reader to Accessibility KCM

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122540/#review75937
---

Ship it!


Ship It!

- David Edmundson


On Feb. 12, 2015, 6:12 p.m., Frederik Gladhorn wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122540/
> ---
> 
> (Updated Feb. 12, 2015, 6:12 p.m.)
> 
> 
> Review request for Plasma, Jonathan Riddell, Sebastian Sauer, and Jeremy 
> Whiting.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This patch adds a simple check box to the KCM which enables the screen
> reader.
> It additionally sets up the default shortcut - Meta-Alt-S which is the
> same as in Gnome. Using the same shortcut is of course extremely
> important, since blind users rely on an easy way to activeate the screen
> reader.
> 
> For now the whole process is hard-coded to Orca since there are no real
> alternatives for Linux screen readers at the moment.
> 
> The gconfig call which disables the screen reader will make Orca exit.
> It still needs to be launched manually.
> 
> I don't have much time for cleaning up the KCM, so help would be very much 
> appreciated.
> There are a lot of low hanging fruits for cleanup there. Also the port to 
> kf5, away from deprecated stuff is by far not complete.
> 
> 
> Diffs
> -
> 
>   kcms/access/kaccess.cpp 2419efb 
>   kcms/access/kcmaccess.cpp 7e0217d 
>   kcms/access/CMakeLists.txt 55990d2 
>   kcms/access/accessibility.ui 2e0db83 
>   kcms/access/kaccess.h e101de4 
> 
> Diff: https://git.reviewboard.kde.org/r/122540/diff/
> 
> 
> Testing
> ---
> 
> This allows me to start and stop Orca using meta-alt-s or the kcm.
> 
> 
> Thanks,
> 
> Frederik Gladhorn
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122331: Add libinput support to kcm-touchpad

[Rajeesh K Nambiar]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122331/
---

(Updated Feb. 12, 2015, 6:34 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Alexander Mezin and Martin Gräßlin.


Repository: kcm-touchpad


Description
---

ibinput is a library to handle input devices in Wayland compositors and to 
provide a generic X.Org input driver. Add libinput support to kcm-touchpad.
Patch authored by Peter Hutterer.


Diffs
-

  src/kcm/touchpad.kcfg 2afe642 
  src/kcm/ui/tap.ui 8e081ad 
  src/touchpadbackend.cpp 93e3dc2 
  src/backends/x11.cmake f208281 
  src/backends/x11/libinputproperties.c PRE-CREATION 
  src/backends/x11/synclientproperties.h 5b32b9f 
  src/backends/x11/xlibbackend.h 3692a60 
  src/backends/x11/xlibbackend.cpp 3b5e5be 
  src/kcm/customconfigdialogmanager.cpp 75b03ab 

Diff: https://git.reviewboard.kde.org/r/122331/diff/


Testing
---

Fedora 21 RPM built and tested with Plasma 5.2.
RPMs available here for testing: 
https://copr-be.cloud.fedoraproject.org/results/rajeeshknambiar/kf5-kde-apps/fedora-21-x86_64/kf5-kcm_touchpad-5.1.96-1.fc21/


Thanks,

Rajeesh K Nambiar

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122331: Add libinput support to kcm-touchpad

[Rex Dieter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122331/#review75939
---


The commit seems to have missed backends/x11/libinputproperties.c, it now fails 
to build for me:
CMake Error at src/CMakeLists.txt:48 (add_library):
  Cannot find source file:

backends/x11/libinputproperties.c

- Rex Dieter


On Feb. 12, 2015, 6:34 p.m., Rajeesh K Nambiar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122331/
> ---
> 
> (Updated Feb. 12, 2015, 6:34 p.m.)
> 
> 
> Review request for Plasma, Alexander Mezin and Martin Gräßlin.
> 
> 
> Repository: kcm-touchpad
> 
> 
> Description
> ---
> 
> ibinput is a library to handle input devices in Wayland compositors and to 
> provide a generic X.Org input driver. Add libinput support to kcm-touchpad.
> Patch authored by Peter Hutterer.
> 
> 
> Diffs
> -
> 
>   src/kcm/touchpad.kcfg 2afe642 
>   src/kcm/ui/tap.ui 8e081ad 
>   src/touchpadbackend.cpp 93e3dc2 
>   src/backends/x11.cmake f208281 
>   src/backends/x11/libinputproperties.c PRE-CREATION 
>   src/backends/x11/synclientproperties.h 5b32b9f 
>   src/backends/x11/xlibbackend.h 3692a60 
>   src/backends/x11/xlibbackend.cpp 3b5e5be 
>   src/kcm/customconfigdialogmanager.cpp 75b03ab 
> 
> Diff: https://git.reviewboard.kde.org/r/122331/diff/
> 
> 
> Testing
> ---
> 
> Fedora 21 RPM built and tested with Plasma 5.2.
> RPMs available here for testing: 
> https://copr-be.cloud.fedoraproject.org/results/rajeeshknambiar/kf5-kde-apps/fedora-21-x86_64/kf5-kcm_touchpad-5.1.96-1.fc21/
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122331: Add libinput support to kcm-touchpad

[Rex Dieter]

> On Feb. 12, 2015, 7:22 p.m., Rex Dieter wrote:
> > The commit seems to have missed backends/x11/libinputproperties.c, it now 
> > fails to build for me:
> > CMake Error at src/CMakeLists.txt:48 (add_library):
> >   Cannot find source file:
> > 
> > backends/x11/libinputproperties.c

Extracted from review request, and pushed separately in commit 
e267c5fd548198b4cbc064168191c13777ea54d0


- Rex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122331/#review75939
---


On Feb. 12, 2015, 6:34 p.m., Rajeesh K Nambiar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122331/
> ---
> 
> (Updated Feb. 12, 2015, 6:34 p.m.)
> 
> 
> Review request for Plasma, Alexander Mezin and Martin Gräßlin.
> 
> 
> Repository: kcm-touchpad
> 
> 
> Description
> ---
> 
> ibinput is a library to handle input devices in Wayland compositors and to 
> provide a generic X.Org input driver. Add libinput support to kcm-touchpad.
> Patch authored by Peter Hutterer.
> 
> 
> Diffs
> -
> 
>   src/kcm/touchpad.kcfg 2afe642 
>   src/kcm/ui/tap.ui 8e081ad 
>   src/touchpadbackend.cpp 93e3dc2 
>   src/backends/x11.cmake f208281 
>   src/backends/x11/libinputproperties.c PRE-CREATION 
>   src/backends/x11/synclientproperties.h 5b32b9f 
>   src/backends/x11/xlibbackend.h 3692a60 
>   src/backends/x11/xlibbackend.cpp 3b5e5be 
>   src/kcm/customconfigdialogmanager.cpp 75b03ab 
> 
> Diff: https://git.reviewboard.kde.org/r/122331/diff/
> 
> 
> Testing
> ---
> 
> Fedora 21 RPM built and tested with Plasma 5.2.
> RPMs available here for testing: 
> https://copr-be.cloud.fedoraproject.org/results/rajeeshknambiar/kf5-kde-apps/fedora-21-x86_64/kf5-kcm_touchpad-5.1.96-1.fc21/
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Merging KCM Touchpad

[David Edmundson]

I'm super happy with the touchpad KCM, I'd like to merge it soon to
maximise testing before the 5.3 release.

Any objections to me merging into plasma-desktop with the other KCMs? I
don't think there's a reason to keep it in a separate repo now it's ready
for usage.

I'll filter branch to keep the history.

ktouchpadenabler will then be dropped as this provides the same feature
only more configurable and with future proofed with libinput support.

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122331: Add libinput support to kcm-touchpad

[Rajeesh K Nambiar]

> On Feb. 12, 2015, 7:22 p.m., Rex Dieter wrote:
> > The commit seems to have missed backends/x11/libinputproperties.c, it now 
> > fails to build for me:
> > CMake Error at src/CMakeLists.txt:48 (add_library):
> >   Cannot find source file:
> > 
> > backends/x11/libinputproperties.c
> 
> Rex Dieter wrote:
> Extracted from review request, and pushed separately in commit 
> e267c5fd548198b4cbc064168191c13777ea54d0

Thanks!
I've no clue how that file got missed. My usual testing (build rpm) did 
succeed...


- Rajeesh


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122331/#review75939
---


On Feb. 12, 2015, 6:34 p.m., Rajeesh K Nambiar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122331/
> ---
> 
> (Updated Feb. 12, 2015, 6:34 p.m.)
> 
> 
> Review request for Plasma, Alexander Mezin and Martin Gräßlin.
> 
> 
> Repository: kcm-touchpad
> 
> 
> Description
> ---
> 
> ibinput is a library to handle input devices in Wayland compositors and to 
> provide a generic X.Org input driver. Add libinput support to kcm-touchpad.
> Patch authored by Peter Hutterer.
> 
> 
> Diffs
> -
> 
>   src/kcm/touchpad.kcfg 2afe642 
>   src/kcm/ui/tap.ui 8e081ad 
>   src/touchpadbackend.cpp 93e3dc2 
>   src/backends/x11.cmake f208281 
>   src/backends/x11/libinputproperties.c PRE-CREATION 
>   src/backends/x11/synclientproperties.h 5b32b9f 
>   src/backends/x11/xlibbackend.h 3692a60 
>   src/backends/x11/xlibbackend.cpp 3b5e5be 
>   src/kcm/customconfigdialogmanager.cpp 75b03ab 
> 
> Diff: https://git.reviewboard.kde.org/r/122331/diff/
> 
> 
> Testing
> ---
> 
> Fedora 21 RPM built and tested with Plasma 5.2.
> RPMs available here for testing: 
> https://copr-be.cloud.fedoraproject.org/results/rajeeshknambiar/kf5-kde-apps/fedora-21-x86_64/kf5-kcm_touchpad-5.1.96-1.fc21/
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122505: Warn about brightness getting too low

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122505/
---

(Updated Feb. 12, 2015, 9:29 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Repository: plasma-workspace


Description
---

Some graphics drivers, notably Intel, turn off the backlight completely when 
brightness reached zero, which is also in the spec (0 = off, 1 = very dim) but 
imho that's unexpected. To prevent the user from accidentally turnign the 
screen off, especially when keyboard brightness controls don't work, which 
sadly still happens quite often, the slider breaks free from the user's drag 
(by becoming disable for two (perhaps 1 is enough?) seconds, so we also catch 
the mouse wheel case) and displays a warning (which stays there until screen 
brightness is dialed up again).


Diffs
-

  applets/batterymonitor/package/contents/ui/BrightnessItem.qml 546ab58 
  applets/batterymonitor/package/contents/ui/PopupDialog.qml a2acf31 

Diff: https://git.reviewboard.kde.org/r/122505/diff/


Testing
---

Works pretty well, I just realized I forgot the mousewheel-on-trayicon case. 
Also, I'm open to wording suggestions since it sounds more like "we suck, sorry 
about that". (Note in the screenshot I used the mouse wheel, hence the 
displayed 4% rather than 5)


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/09/8b585088-e33e-4862-9c46-207d06f566f1__dimwarning.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #1312

[KDE CI System]

See 

Changes:

[kde] Don't let the brightness sliders turn off the screen

--
[...truncated 2588 lines...]
[ 73%] Building CXX object 
dataengines/hotplug/CMakeFiles/plasma_engine_hotplug.dir/hotplugservice.cpp.o
Scanning dependencies of target plasma_engine_favicons
[ 73%] [ 73%] Building CXX object 
dataengines/executable/CMakeFiles/plasma_engine_executable.dir/executable.cpp.o
Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/multiplexedservice.cpp.o
[ 73%] Building CXX object 
dataengines/favicons/CMakeFiles/plasma_engine_favicons.dir/favicons.cpp.o
:
 In member function ‘void FileBrowserEngine::updateData(const QString&, 
FileBrowserEngine::EventType)’:
:129:28:
 warning: ‘KFileMetaInfo’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kfilemetainfo.h:58)
 [-Wdeprecated-declarations]
 KFileMetaInfo kfmi(path, QString(), KFileMetaInfo::Everything);
^
:137:38:
 warning: ‘KFileMetaInfoItem’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kfilemetainfoitem.h:33)
 [-Wdeprecated-declarations]
 for (QHash< QString, KFileMetaInfoItem >::const_iterator i = 
kfmi.items().constBegin(); i != kfmi.items().constEnd(); ++i) {
  ^
[ 73%] Building CXX object 
dataengines/geolocation/CMakeFiles/plasma-geolocation-interface.dir/plasma-geolocation-interface_automoc.cpp.o
[ 73%] Building CXX object 
dataengines/keystate/CMakeFiles/plasma_engine_keystate.dir/plasma_engine_keystate_automoc.cpp.o
[ 73%] Building CXX object 
dataengines/favicons/CMakeFiles/plasma_engine_favicons.dir/faviconprovider.cpp.o
Linking CXX shared module plasma_engine_packagekit.so
[ 73%] Building CXX object 
dataengines/hotplug/CMakeFiles/plasma_engine_hotplug.dir/hotplugjob.cpp.o
[ 74%] Building CXX object 
dataengines/executable/CMakeFiles/plasma_engine_executable.dir/plasma_engine_executable_automoc.cpp.o
[ 74%] Built target plasma_engine_packagekit
[ 74%] Building CXX object 
dataengines/hotplug/CMakeFiles/plasma_engine_hotplug.dir/plasma_engine_hotplug_automoc.cpp.o
Linking CXX shared module plasma_engine_filebrowser.so
[ 74%] [ 74%] Building CXX object 
dataengines/favicons/CMakeFiles/plasma_engine_favicons.dir/plasma_engine_favicons_automoc.cpp.o
Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/playercontrol.cpp.o
Linking CXX shared module plasma_engine_keystate.so
Linking CXX shared library libplasma-geolocation-interface.so
[ 74%] Built target plasma_engine_filebrowser
[ 74%] Built target plasma_engine_keystate
[ 74%] Generating krunner_interface.cpp, krunner_interface.h
Scanning dependencies of target plasma_engine_places
[ 74%] Generating krunner_interface.cpp, krunner_interface.h
[ 74%] [ 74%] Building CXX object 
dataengines/places/CMakeFiles/plasma_engine_places.dir/placesengine.cpp.o
Generating krunner_interface.moc
[ 74%] Built target plasma-geolocation-interface
[ 74%] Building CXX object 
dataengines/places/CMakeFiles/plasma_engine_places.dir/placeservice.cpp.o
Scanning dependencies of target plasma_engine_powermanagement
[ 74%] Building CXX object 
dataengines/powermanagement/CMakeFiles/plasma_engine_powermanagement.dir/powermanagementengine.cpp.o
Linking CXX shared module plasma_engine_executable.so
[ 75%] Building CXX object 
dataengines/powermanagement/CMakeFiles/plasma_engine_powermanagement.dir/powermanagementjob.cpp.o
Linking CXX shared module plasma_engine_favicons.so
[ 75%] Linking CXX shared module plasma_engine_hotplug.so
[ 75%] Building CXX object 
dataengines/powermanagement/CMakeFiles/plasma_engine_powermanagement.dir/powermanagementservice.cpp.o
Built target plasma_engine_executable
[ 76%] Building CXX object 
dataengines/places/CMakeFiles/plasma_engine_places.dir/placesproxymodel.cpp.o
[ 76%] Built target plasma_engine_favicons
[ 76%] Building CXX object 
dataengines/places/CMakeFiles/plasma_engine_places.dir/setupdevicejob.cpp.o
[ 76%] Built target plasma_engine_hotplug
[ 77%] Building CXX object 
dataengines/mpris2/CMakeFiles/plasma_engine_mpris2.dir/playeractionjob.cpp.o
:
 In member function ‘virtual bool 
PowermanagementEngine::sourceRequestEvent(const QString&)’:
:209:41:
 warn

Build failed in Jenkins: plasma-workspace_master_qt5 #1313

[KDE CI System]

See 

Changes:

[kde] Cleanup anchoring mess in battery monitor

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson4574871692294294852.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-workspace
   d18b597..e679c81  master -> origin/master
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at d18b597 properly propagate info and error messages from 
kcheckpass and PAM
Removing build/
Success build forhudson.tasks.Shell@102d30ab
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/plasma-workspace # 
 > timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > git://anongit.kde.org/plasma-workspace +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision e679c81d0c8469f7452b304e2c68bf5c0605bfef 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f e679c81d0c8469f7452b304e2c68bf5c0605bfef
 > git rev-list 92d694006746504083d9bf5f335efba3eab1bb87 # timeout=10
 > git tag -a -f -m Jenkins Build #1313 
 > jenkins-plasma-workspace_master_qt5-1313 # timeout=10
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson4470177136773527743.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
 kbookmarks - Branch master
 kxmlgui - Branch master
 kactivities - Branch master
 kemoticons - Branch master
 libgit2 - Branch master
 kjobwidgets - Branch master
 khtml - Branch master
 kdnssd - Branch master
 kdoctools - Branch master
 knotifications - Branch master
 ktextwidgets - Branch master
 krunner - Branch master
 kdesignerplugin - Branch master
 libdbusmenu-qt - Branch master
 kwallet - Branch master
 kpackage - Branch master
 kdbusaddons - Branch master
 kdecoration - Branch master
 kde-cli-tools - Branch master
 kdesupport-svn - Branch master
 frameworkintegration - Branch master
 attica - Branch master
 cmake - Branch master
 kwindowsystem - Branch master
 milou - Branch master
 kidletime - Branch master
 baloo - Branch master
 kjs - Branch master
 dogtail - Branch master
 kitemmodels - Branch master
 kguiaddons - Branch master
 qt5 - Branch 5.4.1
 kjsembed - Branch master
 poppler - Branch master
 kwidgetsaddons - Branch master
 kitemviews - Branch master
 karchive - Branch master
 threadweaver - Branch master
 ktexteditor - Branch master
 extra-cmake-modules - Branch master
 kconfig - Branch master
 sonnet - Branch master
 libssh - Branch master
 kio - Branch master
 libkscreen - Branch master
 khelpcenter - Branch master
 kxmlrpcclient - Branch master
 kparts - Branch master
 kcompletion - Branch master
 libksysguard - Branch master
 knotifyconfig - Branch master
 kinit - Branch master
 knewstuff - Branch master
 kservice - Branch master
 kwayland - Branch master
 kplotting - Branch master
 polkit-qt-1 - Branch master
 kdeclarative - Branch master
 kglobalaccel - Branch master
 kdelibs4support - Branch master
 kdewebkit - Branch master
 kdesu - Branch master
 kcrash - Branch master
 kcoreaddons - Branch master
 phonon - Branch master
 kconfigwidgets - Branch master
 solid - Branch master
 plasma-framework - Branch master
 kded - Branch master
 kauth - Branch master
 breeze - Branch master
 kfilemetadata - Branch master
 kross - Branch master
 kiconthemes - Branch master
 kio-extras - Branch master
 kunitconversion - Branch master
 kcodecs - Branch master
 kpty - Branch master
 ki18n - Branch master
 kcmutils - Branch master
 kwin - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

Connection closed by 5.9.19.111
rsync: connection unexpectedly closed (0 bytes received so far) [Receiver]
rsync error: unexplained error (code 255) at io.c(605) [Receiver=3.0.9]
Syncing dependencies from master server for project plasma-wo

Re: Merging KCM Touchpad

[Marco Martin]

On Thursday 12 February 2015, David Edmundson wrote:
> I'm super happy with the touchpad KCM, I'd like to merge it soon to
> maximise testing before the 5.3 release.
> 
> Any objections to me merging into plasma-desktop with the other KCMs? I
> don't think there's a reason to keep it in a separate repo now it's ready
> for usage.
> 
> I'll filter branch to keep the history.
> 
> ktouchpadenabler will then be dropped as this provides the same feature
> only more configurable and with future proofed with libinput support.

if it's only a kcm without other stuff like daemons, +1 from here

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118155: adapt to ecm_add_tests so that tests can be found

[Patrick Spendrin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118155/
---

(Updated feb. 12, 2015, 10:58 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks, kdewin and Plasma.


Repository: plasma-framework


Description
---

adapt to ecm_add_tests so that tests can be found


Diffs
-

  autotests/CMakeLists.txt dcee37f0771753d3e381e9d77f351cff16531e93 

Diff: https://git.reviewboard.kde.org/r/118155/diff/


Testing
---

mingw


Thanks,

Patrick Spendrin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Merging KCM Touchpad

[Aleix Pol]

On Thu, Feb 12, 2015 at 8:51 PM, David Edmundson
 wrote:
> I'm super happy with the touchpad KCM, I'd like to merge it soon to maximise
> testing before the 5.3 release.
>
> Any objections to me merging into plasma-desktop with the other KCMs? I
> don't think there's a reason to keep it in a separate repo now it's ready
> for usage.
>
> I'll filter branch to keep the history.
>
> ktouchpadenabler will then be dropped as this provides the same feature only
> more configurable and with future proofed with libinput support.

+1

CC'ing Albert, who is the ktouchpadenabler maintainer, IIRC.

Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Merging KCM Touchpad

[Lukáš Tinkl]

Dne 12.2.2015 v 23:07 Marco Martin napsal(a):

On Thursday 12 February 2015, David Edmundson wrote:

I'm super happy with the touchpad KCM, I'd like to merge it soon to
maximise testing before the 5.3 release.

Any objections to me merging into plasma-desktop with the other KCMs? I
don't think there's a reason to keep it in a separate repo now it's ready
for usage.

I'll filter branch to keep the history.

ktouchpadenabler will then be dropped as this provides the same feature
only more configurable and with future proofed with libinput support.


if it's only a kcm without other stuff like daemons, +1 from here



It also has a kded module which is surprisingly linked together with the kcm

--
Lukáš Tinkl 
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Merging KCM Touchpad

[David Edmundson]

On Fri, Feb 13, 2015 at 12:19 AM, Lukáš Tinkl  wrote:

> Dne 12.2.2015 v 23:07 Marco Martin napsal(a):
>
>> On Thursday 12 February 2015, David Edmundson wrote:
>>
>>> I'm super happy with the touchpad KCM, I'd like to merge it soon to
>>> maximise testing before the 5.3 release.
>>>
>>> Any objections to me merging into plasma-desktop with the other KCMs? I
>>> don't think there's a reason to keep it in a separate repo now it's ready
>>> for usage.
>>>
>>> I'll filter branch to keep the history.
>>>
>>> ktouchpadenabler will then be dropped as this provides the same feature
>>> only more configurable and with future proofed with libinput support.
>>>
>>
>> if it's only a kcm without other stuff like daemons, +1 from here
>>
>>
> It also has a kded module which is surprisingly linked together with the
> kcm


Currently so does the keyboard KCM, so it's not super weird.

Mouse also has something that runs on startup.

>
>
> --
> Lukáš Tinkl 
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Alternative desktop applet interaction

[Eike Hein]

Hi,

yesterday I added a new "Experimental" page to the config dialog
of the Folder View desktop containment in master. It offers two
options that enable a different way of interacting with widgets
on the desktop:

- Pressing and holding for $platform_delay to engage a 'move' mode
  where as long as the press is kept, the applet moves with the
  pointer.

- Optionally, reveal the handle on press-and-hold as well. This
  is of course technically necessary (without the handle you can't
  resize or rotate), but I intentionally made it a separate option
  because the current handle design is not the only possibility
  once you go modal like this, and this allows getting a feel for
  how things are without the handle bar we're used to.

I encourage you to enable this mode (both with and without the
optional handle reveal) and play with it for a day or so.

My original assumption was that press-and-hold would be unintuitive
and cumbersome (although platforms like Android use it as well), but
in practice I find it makes the desktop feel simpler and less hyper-
active. A separate concern is that "you need to hold" interaction
patterns are usually an accessibility concern - but this is the case
for drag-by-handle, too, and a modal design would make it easier to
add keyboard controls to move applets or other a11n approaches.

Additionally, the implementation currently intentionally ignores
whether widgets are locked or not. With no handles flying in on
hover, and move/edit mode being hard to enable accidentally, the
lock itself becomes much less necessary - maybe altogether super-
fluous even, allowing for further simplification.

Some implementation notes:

* Engaging move/edit mode by press-and-hold asks everything in the
  applet to abort mouse interaction and ungrab. This can be caught
  in applet code via the onCanceled handlers in MouseArea and
  (also new as of yesterday, added by me) and MouseEventListener -
  most applet code actually needs no changes, but e.g. Folder View
  itself (when used as widget) needs to do things like potentially
  cancel rubber band selection mode, similar as if a release event
  were to happen.

* A press-and-hold will only engage move/edit mode if the cursor
  stays within the drag distance. That means if you press-and-hold
  and move around more than a few px - say to do rubber band
  selection or use a pen tool - that won't be interfered with. This
  coarse check seems to work well in practice; even taking a long
  time to select individual letters in note widgets is no problem
  here.

Known issues:

* The placeholder (common to Desktop and FV) sizing with handle
  reveal disabled is wrong by the handle width.

* This impl is a prototype, don't expect polish.

I'm not really sure what all of this means yet (although Netrunner
intends to ship some form of this eventually), but it's food for
thought.


Cheers,
Eike
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

[Martin Gräßlin]

> On Feb. 10, 2015, 2:29 p.m., David Edmundson wrote:
> > I'm not convinced this is right.
> > 
> > From the doc you linked: 
> >  This is necessary for the system to implement auto-suspend when all 
> > sessions are idle.
> >  
> > When we lock the screen, powerdevil is still running, no?
> > 
> > Powerdevil has an inhibition blocking logind suspending, so I think overall 
> > this will just do nothing.
> 
> Martin Gräßlin wrote:
> The linked bug report gives another use case: cross-desktop check to see 
> whether the session is idle.
> 
> > Powerdevil has an inhibition blocking logind suspending, so I think 
> overall this will just do nothing.
> 
> Why is powerdevil holding an inhibition lock?
> 
> David Edmundson wrote:
> So we can implement auto suspend / key handling based on the user's KDE 
> configs, not based on some global configs.
> 
> Kai Uwe Broulik wrote:
> PowerDevil inhibits the following: 
> ["handle-power-key:handle-suspend-key:handle-hibernate-key:handle-lid-switch",
>  "PowerDevil", "KDE handles power events", "block"]
> Also, "IdleAction" is "ignore" here.
> 
> Martin Gräßlin wrote:
> If I understand that correctly David's concern doesn't hold?
> 
> David Edmundson wrote:
> I still want a question answered.
> 
> Why do we want logind to do it's idle action when we are showing a lock 
> screen when we're managing auto suspend ourselves?

to properly handle idle in a multi-user setup?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122510/#review75777
---


On Feb. 10, 2015, 2:21 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122510/
> ---
> 
> (Updated Feb. 10, 2015, 2:21 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 271731
> https://bugs.kde.org/show_bug.cgi?id=271731
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> See the idle recommendations on [1]. Binding it to the lock screen does
> not exactly match the recommendation, but it has some advantages:
> * we know it's idle when it's locked
> * it kicks in after the user's configured idle timeout
> * if the user unlocks we know it's no longer idle
> 
> FEATURE: 271731
> FIXED-IN: 5.3.0
> 
> [1] 
> http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 
>   ksmserver/screenlocker/logind.h 99836734923740a1f0b23144f9effd815f104b74 
>   ksmserver/screenlocker/logind.cpp 5335b150bce8f38aee75ad30055bc0e248ed1bf1 
> 
> Diff: https://git.reviewboard.kde.org/r/122510/diff/
> 
> 
> Testing
> ---
> 
> Run the test application and verified using loginctl from tty1 while the 
> screen was locked and after unlocked.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122533: Port accessibility kcm somewhat to xcb xkb

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122533/#review75965
---

Ship it!


Ship It!

- Martin Gräßlin


On Feb. 12, 2015, 5:50 p.m., Frederik Gladhorn wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122533/
> ---
> 
> (Updated Feb. 12, 2015, 5:50 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I don't really speak xcb, so I'd appreciate if someone could look over this 
> for sanity's sake. The patch seems relatively straight forward to me though. 
> I wonder how broken the old code was, it seems to have been rotting for a 
> while.
> 
> 
> Diffs
> -
> 
>   kcms/access/kaccess.h e101de4 
>   kcms/access/kaccess.cpp 2419efb 
> 
> Diff: https://git.reviewboard.kde.org/r/122533/diff/
> 
> 
> Testing
> ---
> 
> After this change sticky keys and some of the other features seem to work 
> again.
> 
> 
> Thanks,
> 
> Frederik Gladhorn
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122331: Add libinput support to kcm-touchpad

[Martin Gräßlin]

> On Feb. 12, 2015, 1:39 a.m., David Edmundson wrote:
> > Built my X with libinput support.
> > 
> > Without this patch I get an erro, with this I get at least some options, 
> > though quite a few seemed disabled as they're just not available in 
> > libinput.
> 
> Rajeesh K Nambiar wrote:
> Indeed, many options are disabled because they are simply not 
> available/exposed by libinput. See the discussion and bug listed here: 
> https://lists.fedoraproject.org/pipermail/devel/2015-January/206918.html
> To test, just install the libinput Xorg driver (xorg-x11-drv-libinput 
> package in Fedora), it will be preferred over synaptics driver.
> 
> David Edmundson wrote:
> Yeah, not a lot we can do about that for now.
> 
> Do you have commit access?
> 
> Rajeesh K Nambiar wrote:
> I now have the developer account (yay).
> Will check commit access in the evening once I have access to my system.
> 
> Sebastian Kügler wrote:
> Why will the libinput driver be prefferred over synaptics if synaptics 
> provides more features and is more mature? Is that a packaging-specific 
> thing, do we have any control over it? From the point of a user, this is 
> going to cause regressions.
> 
> David Edmundson wrote:
> it's a distro/X thing.
> 
> Rajeesh K Nambiar wrote:
> X automatically choses libinput driver over synaptics if installed. Users 
> still have the choice to opt out by not installing libinput X driver.
> Libinput is the common input stack for Wayland and X, and distros (like 
> Fedora) are going to switch to it in next versions. Please also see the 
> rationale at [1] and [2].
> [1] 
> http://who-t.blogspot.com/2014/09/libinput-common-input-stack-for-wayland.html
> [2] 
> http://blog.martin-graesslin.com/blog/2014/10/libinput-integration-in-kwinwayland/

> Why will the libinput driver be prefferred over synaptics if synaptics 
> provides more features and is more mature?

because most options provided by the synaptics driver are ridiculous and are 
not tested at all. Libinput follows the approach of only exposing those options 
which are non-stupid.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122331/#review75896
---


On Feb. 12, 2015, 7:34 p.m., Rajeesh K Nambiar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122331/
> ---
> 
> (Updated Feb. 12, 2015, 7:34 p.m.)
> 
> 
> Review request for Plasma, Alexander Mezin and Martin Gräßlin.
> 
> 
> Repository: kcm-touchpad
> 
> 
> Description
> ---
> 
> ibinput is a library to handle input devices in Wayland compositors and to 
> provide a generic X.Org input driver. Add libinput support to kcm-touchpad.
> Patch authored by Peter Hutterer.
> 
> 
> Diffs
> -
> 
>   src/kcm/touchpad.kcfg 2afe642 
>   src/kcm/ui/tap.ui 8e081ad 
>   src/touchpadbackend.cpp 93e3dc2 
>   src/backends/x11.cmake f208281 
>   src/backends/x11/libinputproperties.c PRE-CREATION 
>   src/backends/x11/synclientproperties.h 5b32b9f 
>   src/backends/x11/xlibbackend.h 3692a60 
>   src/backends/x11/xlibbackend.cpp 3b5e5be 
>   src/kcm/customconfigdialogmanager.cpp 75b03ab 
> 
> Diff: https://git.reviewboard.kde.org/r/122331/diff/
> 
> 
> Testing
> ---
> 
> Fedora 21 RPM built and tested with Plasma 5.2.
> RPMs available here for testing: 
> https://copr-be.cloud.fedoraproject.org/results/rajeeshknambiar/kf5-kde-apps/fedora-21-x86_64/kf5-kcm_touchpad-5.1.96-1.fc21/
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122540: Add screen reader to Accessibility KCM

[Frederik Gladhorn]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122540/
---

(Updated Feb. 13, 2015, 7:18 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Jonathan Riddell, Sebastian Sauer, and Jeremy 
Whiting.


Repository: plasma-desktop


Description
---

This patch adds a simple check box to the KCM which enables the screen
reader.
It additionally sets up the default shortcut - Meta-Alt-S which is the
same as in Gnome. Using the same shortcut is of course extremely
important, since blind users rely on an easy way to activeate the screen
reader.

For now the whole process is hard-coded to Orca since there are no real
alternatives for Linux screen readers at the moment.

The gconfig call which disables the screen reader will make Orca exit.
It still needs to be launched manually.

I don't have much time for cleaning up the KCM, so help would be very much 
appreciated.
There are a lot of low hanging fruits for cleanup there. Also the port to kf5, 
away from deprecated stuff is by far not complete.


Diffs
-

  kcms/access/kaccess.cpp 2419efb 
  kcms/access/kcmaccess.cpp 7e0217d 
  kcms/access/CMakeLists.txt 55990d2 
  kcms/access/accessibility.ui 2e0db83 
  kcms/access/kaccess.h e101de4 

Diff: https://git.reviewboard.kde.org/r/122540/diff/


Testing
---

This allows me to start and stop Orca using meta-alt-s or the kcm.


Thanks,

Frederik Gladhorn

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122533: Port accessibility kcm somewhat to xcb xkb

[Frederik Gladhorn]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122533/
---

(Updated Feb. 13, 2015, 7:18 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-desktop


Description
---

I don't really speak xcb, so I'd appreciate if someone could look over this for 
sanity's sake. The patch seems relatively straight forward to me though. I 
wonder how broken the old code was, it seems to have been rotting for a while.


Diffs
-

  kcms/access/kaccess.h e101de4 
  kcms/access/kaccess.cpp 2419efb 

Diff: https://git.reviewboard.kde.org/r/122533/diff/


Testing
---

After this change sticky keys and some of the other features seem to work again.


Thanks,

Frederik Gladhorn

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122522: [lookandfeel] Include hostname in InfoPane of LockScreen

[Martin Gräßlin]

> On Feb. 11, 2015, 5:14 p.m., Andrew Lake wrote:
> > It might be worth investigating the use-case a bit further to try to 
> > understand if this is the best way to solve this. Is it useful? Yes. But 
> > there are potentiall negative impacts that should be balanced against the 
> > relative increase in utility.
> > 
> > We also need to belly up to identifying primary and secondary target 
> > personas and scenarios for Plasma (maybe a thing for the upcomign sprint). 
> > At best, I'd suggest that exposing the host name here would target a 
> > secondary persona and any associated scenarios. 
> > 
> > While I can't argue that the scenario in the bug report isn't legitimate, 
> > I'm not sure it warrants adding information to the lock-screen that is of 
> > little-to-no value to primary target personas and scenarios. The cost we're 
> > trying to mitigate in the bug report is that the user logs in/unlocks to 
> > identify the computer versus knowing it one interaction step earlier. 
> > 
> > For the lab/shared computers, the scenario requires that more than one 
> > computer is shared (probably in relative proximity to each other) and some 
> > particular need that requires knowing the computer identity *before* 
> > logging in/unlocking. Even in corporate environments that seems like quite 
> > a marginal scenario.
> > 
> > So for me, I'm struggling to see how the potentially negative impact of 
> > added information noise for what I think are the primary target personas 
> > and scenarios balances what is, I think, a marginal increase in utility for 
> > a marginal scenario for a secondary target persona.
> > 
> > Hope this helps!
> 
> Martin Gräßlin wrote:
> Thanks for your feedback. I'm wondering whether we could make the 
> information easily available without adding noise in general. I really think 
> it's worth to invest the effort to provide this data as it's important in the 
> situations when it's needed (e.g. labs).
> 
> Aleix Pol Gonzalez wrote:
> Would it be possible to use something like Kiosk to decide what 
> information to show?
> Such deployments usually mingle with Kiosk.
> 
> Marco Martin wrote:
> yeah, didn't chime in on this one so far but i agree with Andrew
> could be enabled as aleix says with kiosk (that would mean pretty much an 
> hidden config option, which poses the problem that will make it bitrot.
> or could be just supposed for deployers to customize the look and feel 
> package.. will ask them to maintain qml code that's a bit nasty as well

An idea: Kickoff alternates the User Name and host information. Could that be a 
solution?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122522/#review75870
---


On Feb. 11, 2015, 2:59 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122522/
> ---
> 
> (Updated Feb. 11, 2015, 2:59 p.m.)
> 
> 
> Review request for Plasma and Andrew Lake.
> 
> 
> Bugs: 294778
> https://bugs.kde.org/show_bug.cgi?id=294778
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> FEATURE: 294778
> FIXED-IN: 5.3.0
> 
> 
> Diffs
> -
> 
>   lookandfeel/contents/components/InfoPane.qml 
> 18739ad96724f520ce8467ba5d4c9595e8a9e9ed 
> 
> Diff: https://git.reviewboard.kde.org/r/122522/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot of LockScreen with new info
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/11/771f0a24-aaa1-4bc4-afe8-53c44fe68d71__snapshot_TJ8703.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel