Re: Review Request 122382: [klipper] Sync history to disk after each change

[Filip Wieladek]

> On Feb. 3, 2015, 7:36 a.m., Martin Gräßlin wrote:
> > David E. just pointed out that this could become quite heavy for the system 
> > as the history size can be large (up to 2048 items).
> 
> Martin Gräßlin wrote:
> Unfortunately I couldn't find out why we support up to 2048 items. Commit 
> message is just:
> 
> commit da8394ce42a24726392265436c3808f1ac9389aa
> Author: Esben Mose Hansen 
> Date:   Fri Nov 19 22:28:55 2004 +
> 
> Introduced support for large clipboard histories up to 2048 items.
> 
> svn path=/trunk/kdebase/klipper/; revision=364353
> 
> Martin Klapetek wrote:
> I think 2048 is insane. Can we make it like 32 by default and have it 
> configurable with big fat warning when you choose more than say 100? 
> 
> Btw. does klipper store things encrypted or something? There's also a 
> security concern, especially if your klipper contains passwords, that saving 
> those to disk unecrypted after each copy is insecure (all you need is a 
> watcher on the history file).
> 
> Martin Gräßlin wrote:
> > I think 2048 is insane. Can we make it like 32 by default and have it 
> configurable with big fat warning when you choose more than say 100? 
> 
> The default is 7. Adding a warning is certainly possible.
> 
> > Btw. does klipper store things encrypted or something? There's also a 
> security concern, especially if your klipper contains passwords, that saving 
> those to disk unecrypted after each copy is insecure (all you need is a 
> watcher on the history file).
> 
> If you are able to watch the file you are also able to connect to the X11 
> Display and just do a passive keyboard grab. So caring about that probably 
> doesn't matter (on Wayland this might get more important - maybe we can skip 
> passwords). But setting the file to 600 is certainly a good idea.
> 
> Martin Gräßlin wrote:
> > But setting the file to 600 is certainly a good idea.
> 
> this seems already to be the case (though I don't find the code for it)
> 
> Filip Wieladek wrote:
> FYI: I happened to see cross this. I only use Klipper at 2048. With such 
> a size of the data, it means that I usually have my most frequently used 
> items always available.
> 
> Martin Gräßlin wrote:
> I'm still unsure what to do about this one. If we go for syncing to disk 
> we probably break workflows like Filip's. Maybe we need to add an additional 
> option to automatically sync and show a warning if the history size gets 
> larger than e.g. 20?

I don't know how much work it would be, but would it be possible to separate 
the klipper history engine into a seperate daemon process and communicate with 
it over the DBUS? In this case the daemon would be much less likely to crash 
(due to plasma) and would not have to rely on frequent disk access.

If that is not possible, or too much work, why dont we simply take a snapshot, 
convert the history into a QList (that should be fast) and queue up for a save? 
The save process could then be independent and save a bit later (it could also 
debounce the save's).

However, there might be one more problem. If the plasmashell crashing is really 
an issue, what happens if plasmashell crashes during a save operation? Now it 
has the potential to corrupt the data losing all the history instead of the 
latest entries. That means, that his approach would need to use at least 2 
files, to write in a rotation, so that there is at least one good file to read 
from.


- Filip


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122382/#review75264
---


On Feb. 2, 2015, 3:12 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122382/
> ---
> 
> (Updated Feb. 2, 2015, 3:12 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Bugs: 34
> https://bugs.kde.org/show_bug.cgi?id=34
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> By invoking saveHistory after each change we ensure that the clipboard
> doesn't lose data in case klipper (or in dataengine mode plasmashell)
> crashes.
> 
> To not cause stalls, the saving is performed in a thread using
> QtConcurrentRun. As klipper itself is not thread save a Mutex is
> used to lock changes in the HistoryModel.
> 
> BUG: 34
> FIXED-IN: 5.3.0
> 
> 
> Diffs
> -
> 
>   klipper/klipper.cpp d49c165759f8171931167687c3b36b3a9d7dee07 
>   klipper/CMakeLists.txt a08f062480b15f32f049e2d0d0e311dbe2964c02 
>   klipper/historymodel.h 78f955f0ec4b8f27dbca0573b68691be6a30e3be 
>   klipper/historymodel.cpp 51860f6c3aca1022a2b721c27c859fc721915353 
> 
> Diff: https://git.reviewboard

Re: Review Request 122392: Fix Klipper Performance issues

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122392/#review76103
---


sorry for the delay. I was basically without Internet all of last week.

I haven't done a full review yet as it's really large with lots of changes. 
First a general comment: please check the coding style. We use kdelibs coding 
style (https://techbase.kde.org/Policies/Kdelibs_Coding_Style) and I have a 
hard time reviewing code if it's not following the style.


klipper/filterresult.h


nitpick: whitespaces in the empty lines of the GPL header



klipper/filterresult.h


suggestion: const & the QList



klipper/filterresult.cpp


with C++11 it could also be written as:
FilterResult::~FilterResult() = default;



klipper/filterresult.cpp


nitpick: the placing of the opening braces is wrong, please see 
https://techbase.kde.org/Policies/Kdelibs_Coding_Style#Braces



klipper/filterresult.cpp


suggestion: make it an inline method



klipper/historyfilter.h


I do not really understand why a QThreadPool is used at all if it's only 
used with one thread. It somehow looks strange to me.



klipper/historyfilter.cpp


maybe move it to a header?



klipper/historyfilter.cpp


no need to pass the ", 0", it's the default argument of QThreadPool::start



klipper/historyfilter.cpp


why do you delete the threadPool? Both QThreadPool and HistoryFilter are 
QObjects, and you pass HistoryFilter as parent to threadPool, so it will get 
deleted automatically.


- Martin Gräßlin


On Feb. 8, 2015, 6:08 p.m., Filip Wieladek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122392/
> ---
> 
> (Updated Feb. 8, 2015, 6:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This patch fixes multiple klipper issues:
> 
> * Moves filtering logic into a background task. This makes Klipper responsive 
> while the clipboard is being filtered.
>   Previously, Klipper would "hang" while it was filtering the results. This 
> was worse when there were no matches as
>   Klipper had to go through the entire history. THe computation is immediate 
> on small history sets, but significant
>   on larger sets with larger strings in the clipboard
> * Provides a progress bar at the top to indicate the filtering process.
> * Simplifies the code significantly, by:
>* Moving filtering in a separate class file
>* Cleaning up Popup proxy to build the menu directly using a QList
>* Removing the "index" magic in KlipperPopup. Now we maintain a list of 
> history actions which can be easily cleared.
>* Removed explicit deletion of the "more" submenus, as these are owned by 
> the parent menus and should be removed
>  automatically
> * Avoids flickering of Klipper while removing and inserting actions by 
> forcing the height and width during the update.
> * Fixes a potential memory leak. The QActions for the KlipperPopup were only 
> removed, but never deleted. The API used
>   to add actions addAction(QAction*) was not taking ownership of the action. 
> This is fixed by deleting the actions
>   manually when clearing.
> * Fixes a performance issue during menu rendering when truncating large 
> strings. The method call elidedText() can be
>   slow on large pieces of text. This is worked around by creating a much 
> smaller string of the prefix and suffix of the
>   string. We use the average character width to compute the approximate 
> amount of characters which can be displayed
>   and use twice as much. (this is because in corner cases, such as  we 
> might end up with a string which is not
>   long enough).
>   
> This also fixes the bug https://bugs.kde.org/show_bug.cgi?id=238084
> 
> 
> Diffs
> -
> 
>   klipper/popupproxy.h f33f62c117a08ddbe6b761da4c2e28e51b985044 
>   klipper/popupproxy.cpp 12dd3dd637d0ff9d134fb71237d6f0d3bcc5bd77 
>   klipper/CMakeLists.txt a08f062480b15f32f049e2d0d0e311dbe2964c02 
>   klipper/filterresult.h PRE-CREATION 
>   klipper/filterresult.cpp PRE-CREATION 
>   klipper/history.h 1bfd0424714ff79d93206a74cb7e4214a6c8c652 
>   klipper/history.cpp 9640c23b0cf06dd0135ca573aea0819e2788b852 
>   klipp

Re: Review Request 122382: [klipper] Sync history to disk after each change

[Martin Gräßlin]

> On Feb. 3, 2015, 8:36 a.m., Martin Gräßlin wrote:
> > David E. just pointed out that this could become quite heavy for the system 
> > as the history size can be large (up to 2048 items).
> 
> Martin Gräßlin wrote:
> Unfortunately I couldn't find out why we support up to 2048 items. Commit 
> message is just:
> 
> commit da8394ce42a24726392265436c3808f1ac9389aa
> Author: Esben Mose Hansen 
> Date:   Fri Nov 19 22:28:55 2004 +
> 
> Introduced support for large clipboard histories up to 2048 items.
> 
> svn path=/trunk/kdebase/klipper/; revision=364353
> 
> Martin Klapetek wrote:
> I think 2048 is insane. Can we make it like 32 by default and have it 
> configurable with big fat warning when you choose more than say 100? 
> 
> Btw. does klipper store things encrypted or something? There's also a 
> security concern, especially if your klipper contains passwords, that saving 
> those to disk unecrypted after each copy is insecure (all you need is a 
> watcher on the history file).
> 
> Martin Gräßlin wrote:
> > I think 2048 is insane. Can we make it like 32 by default and have it 
> configurable with big fat warning when you choose more than say 100? 
> 
> The default is 7. Adding a warning is certainly possible.
> 
> > Btw. does klipper store things encrypted or something? There's also a 
> security concern, especially if your klipper contains passwords, that saving 
> those to disk unecrypted after each copy is insecure (all you need is a 
> watcher on the history file).
> 
> If you are able to watch the file you are also able to connect to the X11 
> Display and just do a passive keyboard grab. So caring about that probably 
> doesn't matter (on Wayland this might get more important - maybe we can skip 
> passwords). But setting the file to 600 is certainly a good idea.
> 
> Martin Gräßlin wrote:
> > But setting the file to 600 is certainly a good idea.
> 
> this seems already to be the case (though I don't find the code for it)
> 
> Filip Wieladek wrote:
> FYI: I happened to see cross this. I only use Klipper at 2048. With such 
> a size of the data, it means that I usually have my most frequently used 
> items always available.
> 
> Martin Gräßlin wrote:
> I'm still unsure what to do about this one. If we go for syncing to disk 
> we probably break workflows like Filip's. Maybe we need to add an additional 
> option to automatically sync and show a warning if the history size gets 
> larger than e.g. 20?
> 
> Filip Wieladek wrote:
> I don't know how much work it would be, but would it be possible to 
> separate the klipper history engine into a seperate daemon process and 
> communicate with it over the DBUS? In this case the daemon would be much less 
> likely to crash (due to plasma) and would not have to rely on frequent disk 
> access.
> 
> If that is not possible, or too much work, why dont we simply take a 
> snapshot, convert the history into a QList (that should be fast) and queue up 
> for a save? The save process could then be independent and save a bit later 
> (it could also debounce the save's).
> 
> However, there might be one more problem. If the plasmashell crashing is 
> really an issue, what happens if plasmashell crashes during a save operation? 
> Now it has the potential to corrupt the data losing all the history instead 
> of the latest entries. That means, that his approach would need to use at 
> least 2 files, to write in a rotation, so that there is at least one good 
> file to read from.

> I don't know how much work it would be, but would it be possible to separate 
> the klipper history engine into a seperate daemon process and communicate 
> with it over the DBUS?

I think it's too much work, especially to keep everything race free (changing 
clipboard could happen from multiple places in async way) and up to date.

> If that is not possible, or too much work, why dont we simply take a 
> snapshot, convert the history into a QList (that should be fast) and queue up 
> for a save? The save process could then be independent and save a bit later 
> (it could also debounce the save's).

A throttling could also be implemented directly without the need to add a 
separate process.

> Now it has the potential to corrupt the data losing all the history instead 
> of the latest entries. That means, that his approach would need to use at 
> least 2 files, to write in a rotation, so that there is at least one good 
> file to read from.

That should not be an issue as QSaveFile is used.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122382/#review75264
---


On Feb. 2, 2015, 4:12 p.m., Martin Gräßlin wrote:
> 
> ---
> This is 

Re: Review Request 122382: [klipper] Sync history to disk after each change

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122382/
---

(Updated Feb. 16, 2015, 10:12 a.m.)


Review request for Plasma and Eike Hein.


Changes
---

To not overload the system the save operations are delayed and queued.
Each save is delayed by five seconds since the last clipboard change.
So if the clipboard is changed multiple times in a short interval it
doesn't get synced to the disk till the interaction has settled.


Bugs: 34
https://bugs.kde.org/show_bug.cgi?id=34


Repository: plasma-workspace


Description
---

By invoking saveHistory after each change we ensure that the clipboard
doesn't lose data in case klipper (or in dataengine mode plasmashell)
crashes.

To not cause stalls, the saving is performed in a thread using
QtConcurrentRun. As klipper itself is not thread save a Mutex is
used to lock changes in the HistoryModel.

BUG: 34
FIXED-IN: 5.3.0


Diffs (updated)
-

  klipper/klipper.h 8bb4286f39bb9855602dbe093be90e7a128c7c24 
  klipper/klipper.cpp 6b6d610f2ea4eda962530e2024b1b0a4da06cf7f 
  klipper/CMakeLists.txt 099cb712774c78faf61029e2b1c5706320010ddd 
  klipper/historymodel.h 78f955f0ec4b8f27dbca0573b68691be6a30e3be 
  klipper/historymodel.cpp 51860f6c3aca1022a2b721c27c859fc721915353 

Diff: https://git.reviewboard.kde.org/r/122382/diff/


Testing
---

looked at ~/.local/share/klipper/history2.lst in Okteta, changed clipboard and 
pressed F5 in Okteta. Repeated these steps multiple times.


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122580: Fixed visibility of play/pause button

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122580/#review76106
---


Sorry but I already fixed this one earlier. same patch 
http://quickgit.kde.org/?p=plasma-mediacenter.git&a=commit&h=6678f8183e58821dd007061ffa284edf45985eec

- Bhushan Shah


On Feb. 16, 2015, 1:23 a.m., Abhimanyu Tak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122580/
> ---
> 
> (Updated Feb. 16, 2015, 1:23 a.m.)
> 
> 
> Review request for Plasma and Bhushan Shah.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> The play/pause and stop button in MediaController is now visible and is 
> functioning properly.
> 
> 
> Diffs
> -
> 
>   mediaelements/mediacontroller/MediaController.qml 5947a68 
> 
> Diff: https://git.reviewboard.kde.org/r/122580/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Abhimanyu Tak
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122583: Prevent heading from expanding

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122583/
---

(Updated Feb. 16, 2015, 10:22 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Bugs: 344207
https://bugs.kde.org/show_bug.cgi?id=344207


Repository: plasma-workspace


Description
---

Just put the heading outside the ColumnLayout to prevent it from ever expanding


Diffs
-

  applets/systemmonitor/common/contents/ui/Applet.qml 6feda2d 

Diff: https://git.reviewboard.kde.org/r/122583/diff/


Testing
---

Works, see screenshots


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: kcm_screensaver bugs

[Christoph Feck]

On Monday 16 February 2015 08:01:28 Martin Gräßlin wrote:
> On Sunday 15 February 2015 17:31:37 Christoph Feck wrote:
> > Hi,
> > 
> > thank you very much for the recents efforts to triage
> > "systemsettings" and "kscreensaver" bugs.
> > 
> > I just noticed that "systemsettings/kcm_screensaver" is still
> > open for new bug reports. Should this get renamed to
> > "kcm_lockscreen" or disabled for new tickets?
> 
> My suggestion is to just close it for bug reports and have new bugs
> go to ksmserver/lockscreen. That would be similar to how we handle
> the kcms in kwin: the bug reports go to the same category as the
> kcm configures.

Done. It still has 20 open reports, though.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122588: [dataengines/mpris2] Use a dedicated component for the media control shortcuts

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122588/
---

Review request for Plasma and Kai Uwe Broulik.


Repository: plasma-workspace


Description
---

Instead of having the media control shortcuts being grouped under
"plasmashell" a dedicated component "Media Controller" is added and all
shortcuts are assigned to it.

This solves the problem if multiple processes include the dataengine, the
shortcuts would be registered in each application.


Diffs
-

  dataengines/mpris2/CMakeLists.txt 3ca83589470b8851e7d51b1f3d2bb3ca3ee436c3 
  dataengines/mpris2/multiplexer.cpp ab7927d902dfa55b1afaa978e01e5a00f9fca127 

Diff: https://git.reviewboard.kde.org/r/122588/diff/


Testing
---


File Attachments


component in global shortcuts configuration
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/51fe906f-58ee-485d-a861-24e886459498__missing-tasks-applet1.png


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122589: [dataengine/mpris2] Drop workaround for VLC

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122589/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

If there was a vlc engine it got skipped due to a bug in VLC. This
bug seems to be fixed as of VLC 2.1.5 which contains the following
item in the changelog:
"dbus: Upgrade to an mpris2 compliant interface"

Given that the workaround breaks with the fixed VLC (no media control
at all), it's better to drop it and brake VLC installations which
haven't updated for more than half a year.


Diffs
-

  dataengines/mpris2/mpris2engine.cpp 42ca565d06b240712fbc75cfdaf7b1cc03404796 

Diff: https://git.reviewboard.kde.org/r/122589/diff/


Testing
---

media controller created if VLC is running when restarting plasmashell.


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122589: [dataengine/mpris2] Drop workaround for VLC

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122589/#review76112
---

Ship it!


Ship It!

- Kai Uwe Broulik


On Feb. 16, 2015, 10:46 vorm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122589/
> ---
> 
> (Updated Feb. 16, 2015, 10:46 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> If there was a vlc engine it got skipped due to a bug in VLC. This
> bug seems to be fixed as of VLC 2.1.5 which contains the following
> item in the changelog:
> "dbus: Upgrade to an mpris2 compliant interface"
> 
> Given that the workaround breaks with the fixed VLC (no media control
> at all), it's better to drop it and brake VLC installations which
> haven't updated for more than half a year.
> 
> 
> Diffs
> -
> 
>   dataengines/mpris2/mpris2engine.cpp 
> 42ca565d06b240712fbc75cfdaf7b1cc03404796 
> 
> Diff: https://git.reviewboard.kde.org/r/122589/diff/
> 
> 
> Testing
> ---
> 
> media controller created if VLC is running when restarting plasmashell.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120500: Remove VLC workaround

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120500/
---

(Updated Feb. 16, 2015, 10:51 vorm.)


Status
--

This change has been discarded.


Review request for Plasma, Bhushan Shah and Martin Klapetek.


Bugs: 332584
https://bugs.kde.org/show_bug.cgi?id=332584


Repository: plasma-workspace


Description
---

commit a998595ff7fa0751c894987e2a046ef685169ef5
Author: Kai Uwe Broulik 
Date:   Sun Oct 5 15:03:56 2014 +0200

Revert "Fix mediacontroller showing twice for VLC"

VLC no longer seems to be exposing multiple mpris interfaces, and also the
media controller should only be shown once regardless of this.
This fixes mediacontroller not working when Plasma starts after VLC (crash 
recovery)

CCBUG: 332584

This reverts commit f18ef02d27a060e5db37f99ce359796f4d61.


Diffs
-

  dataengines/mpris2/mpris2engine.cpp 42ca565 

Diff: https://git.reviewboard.kde.org/r/120500/diff/


Testing
---


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122588: [dataengines/mpris2] Use a dedicated component for the media control shortcuts

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122588/#review76113
---

Ship it!


Ship It!

- Kai Uwe Broulik


On Feb. 16, 2015, 10:34 vorm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122588/
> ---
> 
> (Updated Feb. 16, 2015, 10:34 vorm.)
> 
> 
> Review request for Plasma and Kai Uwe Broulik.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Instead of having the media control shortcuts being grouped under
> "plasmashell" a dedicated component "Media Controller" is added and all
> shortcuts are assigned to it.
> 
> This solves the problem if multiple processes include the dataengine, the
> shortcuts would be registered in each application.
> 
> 
> Diffs
> -
> 
>   dataengines/mpris2/CMakeLists.txt 3ca83589470b8851e7d51b1f3d2bb3ca3ee436c3 
>   dataengines/mpris2/multiplexer.cpp ab7927d902dfa55b1afaa978e01e5a00f9fca127 
> 
> Diff: https://git.reviewboard.kde.org/r/122588/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> component in global shortcuts configuration
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/51fe906f-58ee-485d-a861-24e886459498__missing-tasks-applet1.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122562: Add method for converting from QVariant to base64

[Vishesh Handa]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122562/#review76118
---



src/qmlcontrols/kquickcontrolsaddons/clipboard.cpp


Coding style



src/qmlcontrols/kquickcontrolsaddons/clipboard.cpp


huh?

The `case QVariant::String` does not matter.


- Vishesh Handa


On Feb. 13, 2015, 6:16 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122562/
> ---
> 
> (Updated Feb. 13, 2015, 6:16 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> I need some method like that over at the QuickShare plasmoid.
> 
> I'm unsure where to put it, anybody knows of a good place?
> Otherwise I guess it works fine with the clipboard, that returns QVariant.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kquickcontrolsaddons/clipboard.cpp 23ce29b 
>   src/qmlcontrols/kquickcontrolsaddons/clipboard.h ac89b9d 
> 
> Diff: https://git.reviewboard.kde.org/r/122562/diff/
> 
> 
> Testing
> ---
> 
> Adopted locally in my QuickShare plasmoid implementation
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122589: [dataengine/mpris2] Drop workaround for VLC

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122589/#review76119
---

Ship it!


Somehow it seems to work with 2.1.4. And I agree that this is an old version 
(and I personally don't use VLC at all).

- Martin Klapetek


On Feb. 16, 2015, 11:54 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122589/
> ---
> 
> (Updated Feb. 16, 2015, 11:54 a.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> If there was a vlc engine it got skipped due to a bug in VLC. This
> bug seems to be fixed as of VLC 2.1.5 which contains the following
> item in the changelog:
> "dbus: Upgrade to an mpris2 compliant interface"
> 
> Given that the workaround breaks with the fixed VLC (no media control
> at all), it's better to drop it and brake VLC installations which
> haven't updated for more than half a year.
> 
> 
> Diffs
> -
> 
>   dataengines/mpris2/mpris2engine.cpp 
> 42ca565d06b240712fbc75cfdaf7b1cc03404796 
> 
> Diff: https://git.reviewboard.kde.org/r/122589/diff/
> 
> 
> Testing
> ---
> 
> media controller created if VLC is running when restarting plasmashell.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122562: Add method for converting from QVariant to base64

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122562/
---

(Updated Feb. 16, 2015, 1:22 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and Plasma.


Repository: kdeclarative


Description
---

I need some method like that over at the QuickShare plasmoid.

I'm unsure where to put it, anybody knows of a good place?
Otherwise I guess it works fine with the clipboard, that returns QVariant.


Diffs
-

  src/qmlcontrols/kquickcontrolsaddons/clipboard.cpp 23ce29b 
  src/qmlcontrols/kquickcontrolsaddons/clipboard.h ac89b9d 

Diff: https://git.reviewboard.kde.org/r/122562/diff/


Testing
---

Adopted locally in my QuickShare plasmoid implementation


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 323754] When "Dim Screen" enabled, wrong brightness is applied when returned to AC

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=323754

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de
Product|solid   |Powerdevil
   Assignee|d...@kde.org |plasma-devel@kde.org
  Component|powermanagement |general
Version|4.11.0  |5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 328336] System does not hibernate when another user is logged in

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=328336

Kai Uwe Broulik  changed:

   What|Removed |Added

Product|solid   |Powerdevil
 CC||k...@privat.broulik.de
 Status|UNCONFIRMED |CONFIRMED
Version|4.11.3  |5.2.0
  Component|powermanagement |general
   Assignee|d...@kde.org |plasma-devel@kde.org
 Ever confirmed|0   |1

--- Comment #3 from Kai Uwe Broulik  ---
PowerDevil should release inhibitions when the session becomes inactive

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=304696

Kai Uwe Broulik  changed:

   What|Removed |Added

  Component|powermanagement |general
Version|4.9.0   |5.2.0
   Assignee|d...@kde.org |plasma-devel@kde.org
 Status|REOPENED|CONFIRMED
Product|solid   |Powerdevil

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122382: [klipper] Sync history to disk after each change

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122382/#review76125
---


This came about partly due to my loud complaining that I was losing clipboard 
data when plasmashell died. I too think that Klipper should not be running 
in-process with plasmashell ideally - in my view the primary mission of Klipper 
is to persist clipboard state so it remains available when other things go 
away, and I think it's best-equipped to accomplish that mission if it's as 
stand-alone as possible, extending its coverage from "the app goes away" to 
"the shell goes away".

But that said, Klipper saving its history quickly is orthogonal to that, since 
it could also be argued for even in a standalone design. This does seem like a 
step into the right direction, that as a bonus also mitigates the fallout from 
being bundled with plasmashell

- Eike Hein


On Feb. 16, 2015, 9:12 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122382/
> ---
> 
> (Updated Feb. 16, 2015, 9:12 a.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Bugs: 34
> https://bugs.kde.org/show_bug.cgi?id=34
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> By invoking saveHistory after each change we ensure that the clipboard
> doesn't lose data in case klipper (or in dataengine mode plasmashell)
> crashes.
> 
> To not cause stalls, the saving is performed in a thread using
> QtConcurrentRun. As klipper itself is not thread save a Mutex is
> used to lock changes in the HistoryModel.
> 
> BUG: 34
> FIXED-IN: 5.3.0
> 
> 
> Diffs
> -
> 
>   klipper/klipper.h 8bb4286f39bb9855602dbe093be90e7a128c7c24 
>   klipper/klipper.cpp 6b6d610f2ea4eda962530e2024b1b0a4da06cf7f 
>   klipper/CMakeLists.txt 099cb712774c78faf61029e2b1c5706320010ddd 
>   klipper/historymodel.h 78f955f0ec4b8f27dbca0573b68691be6a30e3be 
>   klipper/historymodel.cpp 51860f6c3aca1022a2b721c27c859fc721915353 
> 
> Diff: https://git.reviewboard.kde.org/r/122382/diff/
> 
> 
> Testing
> ---
> 
> looked at ~/.local/share/klipper/history2.lst in Okteta, changed clipboard 
> and pressed F5 in Okteta. Repeated these steps multiple times.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122470: Optimize DataSource

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122470/
---

(Updated Feb. 16, 2015, 1:57 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-framework


Description
---

This optimizes the DataSource Item.

- Use QQmlParserStatus to provide event compression for the setupData() method 
so it is only called once all the bindings have been setup, it used to be 
called repeatedly a lot
- Split setting up the binding outside of setupData, so connections like 
"connectedSources: sources" work with this new approach (that consumer thing 
looks like it leaks)
- Re-introduce interval alignment, this allows the clock to use a 60s interval 
for polling and align to the minute, need to use int since we cannot pass an 
enum defined in a different class
- Cache sources() and emit change signal only when it has actually changed


Diffs
-

  src/declarativeimports/core/datasource.h 3aaa2bb 
  src/declarativeimports/core/datasource.cpp 759e5f4 

Diff: https://git.reviewboard.kde.org/r/122470/diff/


Testing
---

Battery monitor, which does crazy things to the data source works, media 
controller works, and the clock is able to align to the minute. Could 
potentially speed up applet initialization a little.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122592: Align digital clock to full minutes

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/
---

Review request for Plasma and Martin Klapetek.


Bugs: 343872
https://bugs.kde.org/show_bug.cgi?id=343872


Repository: plasma-workspace


Description
---

This aligns the digital clock to full minutes so it's no longer off by up to 30 
seconds, and it allows us to increase the polling interval to 60s.


Diffs
-

  applets/digital-clock/package/contents/ui/main.qml 4cc83e8 

Diff: https://git.reviewboard.kde.org/r/122592/diff/


Testing
---

Compared with xclock, plasmoid is now within 1/2 seconds of the full minute

This patch would require us to bump the plasma-framework dependency to 5.8


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 328336] System does not hibernate when another user is logged in

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=328336

Kai Uwe Broulik  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|CONFIRMED   |RESOLVED

--- Comment #4 from Kai Uwe Broulik  ---


*** This bug has been marked as a duplicate of bug 340427 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 340427] PowerDevil should only inhibit systemd on active sessions

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=340427

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||primejyo...@engineer.com

--- Comment #1 from Kai Uwe Broulik  ---
*** Bug 328336 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122592: Align digital clock to full minutes

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/#review76128
---


Does this still work as intended even when seconds are shown?

- Lukáš Tinkl


On Úno. 16, 2015, 3:24 odp., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122592/
> ---
> 
> (Updated Úno. 16, 2015, 3:24 odp.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 343872
> https://bugs.kde.org/show_bug.cgi?id=343872
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This aligns the digital clock to full minutes so it's no longer off by up to 
> 30 seconds, and it allows us to increase the polling interval to 60s.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/main.qml 4cc83e8 
> 
> Diff: https://git.reviewboard.kde.org/r/122592/diff/
> 
> 
> Testing
> ---
> 
> Compared with xclock, plasmoid is now within 1/2 seconds of the full minute
> 
> This patch would require us to bump the plasma-framework dependency to 5.8
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 323754] When "Dim Screen" enabled, wrong brightness is applied when returned to AC

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=323754

Kai Uwe Broulik  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Kai Uwe Broulik  ---
I cannot reproduce this. If the screen dims, I plug in the AC, the screen turns
to the configured brightness for AC.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122592: Align digital clock to full minutes

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/#review76131
---


All I'm getting with this patch is "Error loading QML file: 
file:///opt/kde5/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/main.qml:57:9:
 Cannot assign to non-existent property "intervalAlignment" "

And I've just rebuilt things. Am I missing anything else?

- Martin Klapetek


On Feb. 16, 2015, 3:24 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122592/
> ---
> 
> (Updated Feb. 16, 2015, 3:24 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 343872
> https://bugs.kde.org/show_bug.cgi?id=343872
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This aligns the digital clock to full minutes so it's no longer off by up to 
> 30 seconds, and it allows us to increase the polling interval to 60s.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/main.qml 4cc83e8 
> 
> Diff: https://git.reviewboard.kde.org/r/122592/diff/
> 
> 
> Testing
> ---
> 
> Compared with xclock, plasmoid is now within 1/2 seconds of the full minute
> 
> This patch would require us to bump the plasma-framework dependency to 5.8
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122592: Align digital clock to full minutes

[Bhushan Shah]

> On Feb. 16, 2015, 8:36 p.m., Martin Klapetek wrote:
> > All I'm getting with this patch is "Error loading QML file: 
> > file:///opt/kde5/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/main.qml:57:9:
> >  Cannot assign to non-existent property "intervalAlignment" "
> > 
> > And I've just rebuilt things. Am I missing anything else?

plasma-framework?


- Bhushan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/#review76131
---


On Feb. 16, 2015, 7:54 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122592/
> ---
> 
> (Updated Feb. 16, 2015, 7:54 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 343872
> https://bugs.kde.org/show_bug.cgi?id=343872
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This aligns the digital clock to full minutes so it's no longer off by up to 
> 30 seconds, and it allows us to increase the polling interval to 60s.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/main.qml 4cc83e8 
> 
> Diff: https://git.reviewboard.kde.org/r/122592/diff/
> 
> 
> Testing
> ---
> 
> Compared with xclock, plasmoid is now within 1/2 seconds of the full minute
> 
> This patch would require us to bump the plasma-framework dependency to 5.8
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122592: Align digital clock to full minutes

[Martin Klapetek]

> On Feb. 16, 2015, 4:06 p.m., Martin Klapetek wrote:
> > All I'm getting with this patch is "Error loading QML file: 
> > file:///opt/kde5/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/main.qml:57:9:
> >  Cannot assign to non-existent property "intervalAlignment" "
> > 
> > And I've just rebuilt things. Am I missing anything else?
> 
> Bhushan Shah wrote:
> plasma-framework?

"I've just rebuilt things" included plasma-framework too. But apparently I've 
rebuilt about 20 minutes before that patch was pushed (I believed it's already 
in for days) -.-

Nevertheless, with showSeconds the seconds now won't update at all ^_^


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/#review76131
---


On Feb. 16, 2015, 3:24 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122592/
> ---
> 
> (Updated Feb. 16, 2015, 3:24 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 343872
> https://bugs.kde.org/show_bug.cgi?id=343872
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This aligns the digital clock to full minutes so it's no longer off by up to 
> 30 seconds, and it allows us to increase the polling interval to 60s.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/main.qml 4cc83e8 
> 
> Diff: https://git.reviewboard.kde.org/r/122592/diff/
> 
> 
> Testing
> ---
> 
> Compared with xclock, plasmoid is now within 1/2 seconds of the full minute
> 
> This patch would require us to bump the plasma-framework dependency to 5.8
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122470: Optimize DataSource

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122470/#review76137
---

Ship it!


arriving late but that's nice :)

- Marco Martin


On Feb. 16, 2015, 1:57 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122470/
> ---
> 
> (Updated Feb. 16, 2015, 1:57 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This optimizes the DataSource Item.
> 
> - Use QQmlParserStatus to provide event compression for the setupData() 
> method so it is only called once all the bindings have been setup, it used to 
> be called repeatedly a lot
> - Split setting up the binding outside of setupData, so connections like 
> "connectedSources: sources" work with this new approach (that consumer thing 
> looks like it leaks)
> - Re-introduce interval alignment, this allows the clock to use a 60s 
> interval for polling and align to the minute, need to use int since we cannot 
> pass an enum defined in a different class
> - Cache sources() and emit change signal only when it has actually changed
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/datasource.h 3aaa2bb 
>   src/declarativeimports/core/datasource.cpp 759e5f4 
> 
> Diff: https://git.reviewboard.kde.org/r/122470/diff/
> 
> 
> Testing
> ---
> 
> Battery monitor, which does crazy things to the data source works, media 
> controller works, and the clock is able to align to the minute. Could 
> potentially speed up applet initialization a little.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122592: Align digital clock to full minutes

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/#review76138
---



applets/digital-clock/package/contents/ui/main.qml


perhaps should be noalignment when showing seconds? (however is very weird 
that it's not working when the interval is a secons?)


- Marco Martin


On Feb. 16, 2015, 2:24 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122592/
> ---
> 
> (Updated Feb. 16, 2015, 2:24 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 343872
> https://bugs.kde.org/show_bug.cgi?id=343872
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This aligns the digital clock to full minutes so it's no longer off by up to 
> 30 seconds, and it allows us to increase the polling interval to 60s.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/main.qml 4cc83e8 
> 
> Diff: https://git.reviewboard.kde.org/r/122592/diff/
> 
> 
> Testing
> ---
> 
> Compared with xclock, plasmoid is now within 1/2 seconds of the full minute
> 
> This patch would require us to bump the plasma-framework dependency to 5.8
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122592: Align digital clock to full minutes

[Kai Uwe Broulik]

> On Feb. 16, 2015, 3:53 nachm., Marco Martin wrote:
> > applets/digital-clock/package/contents/ui/main.qml, line 57
> > 
> >
> > perhaps should be noalignment when showing seconds? (however is very 
> > weird that it's not working when the interval is a secons?)

That it doesn't work with seconds is understandable since it aligns it to 
minutes always.
On the other hand it doesn't work when I change it at runtime since the 
datasource says "already connected to a relay of the same interval"


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/#review76138
---


On Feb. 16, 2015, 2:24 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122592/
> ---
> 
> (Updated Feb. 16, 2015, 2:24 nachm.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 343872
> https://bugs.kde.org/show_bug.cgi?id=343872
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This aligns the digital clock to full minutes so it's no longer off by up to 
> 30 seconds, and it allows us to increase the polling interval to 60s.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/main.qml 4cc83e8 
> 
> Diff: https://git.reviewboard.kde.org/r/122592/diff/
> 
> 
> Testing
> ---
> 
> Compared with xclock, plasmoid is now within 1/2 seconds of the full minute
> 
> This patch would require us to bump the plasma-framework dependency to 5.8
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122592: Align digital clock to full minutes

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/
---

(Updated Feb. 16, 2015, 4:04 nachm.)


Review request for Plasma and Martin Klapetek.


Changes
---

Don't align when seconds are shown

It doesn't catch it up at runtime though


Bugs: 343872
https://bugs.kde.org/show_bug.cgi?id=343872


Repository: plasma-workspace


Description
---

This aligns the digital clock to full minutes so it's no longer off by up to 30 
seconds, and it allows us to increase the polling interval to 60s.


Diffs (updated)
-

  applets/digital-clock/package/contents/ui/main.qml 4cc83e8 

Diff: https://git.reviewboard.kde.org/r/122592/diff/


Testing
---

Compared with xclock, plasmoid is now within 1/2 seconds of the full minute

This patch would require us to bump the plasma-framework dependency to 5.8


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122592: Align digital clock to full minutes

[Marco Martin]

> On Feb. 16, 2015, 3:53 p.m., Marco Martin wrote:
> > applets/digital-clock/package/contents/ui/main.qml, line 57
> > 
> >
> > perhaps should be noalignment when showing seconds? (however is very 
> > weird that it's not working when the interval is a secons?)
> 
> Kai Uwe Broulik wrote:
> That it doesn't work with seconds is understandable since it aligns it to 
> minutes always.
> On the other hand it doesn't work when I change it at runtime since the 
> datasource says "already connected to a relay of the same interval"

that could use a little change in datasource (libplasma side), making it 
distinguish not only by time interval but also alignment.
Or, it can just be made to disconnect then reconnect when changing alignment 
(qml binding side)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/#review76138
---


On Feb. 16, 2015, 4:04 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122592/
> ---
> 
> (Updated Feb. 16, 2015, 4:04 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 343872
> https://bugs.kde.org/show_bug.cgi?id=343872
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This aligns the digital clock to full minutes so it's no longer off by up to 
> 30 seconds, and it allows us to increase the polling interval to 60s.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/main.qml 4cc83e8 
> 
> Diff: https://git.reviewboard.kde.org/r/122592/diff/
> 
> 
> Testing
> ---
> 
> Compared with xclock, plasmoid is now within 1/2 seconds of the full minute
> 
> This patch would require us to bump the plasma-framework dependency to 5.8
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 337674] kded5 is eating CPU

[Jürgen Scholz]

https://bugs.kde.org/show_bug.cgi?id=337674

--- Comment #68 from Jürgen Scholz  ---
I updated to new versions of kded5 and plasma-desktop/plasma-framework a few
days ago. The versions are now:
  kded (5.7.0-0ubuntu1) vivid; urgency=medium
  plasma-desktop (4:5.2.0-0ubuntu1) vivid; urgency=medium
  plasma-framework (5.7.0-0ubuntu1) vivid; urgency=medium

Turning off power saving of the monitors seems to be an effective work-around.

If I turn energy management back on, kded5 is starting to use one cpu core
again.

I will attach another gdb stack trace.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 337674] kded5 is eating CPU

[Jürgen Scholz]

https://bugs.kde.org/show_bug.cgi?id=337674

--- Comment #69 from Jürgen Scholz  ---
Oh, please excuse my oversidght. ubuntu still uses 5.2.0 and *not* 5.2.1. I
will check their bugtracker to either fix this as a backport or to switch to
5.2.1.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 337674] kded5 is eating CPU

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=337674

--- Comment #70 from Christoph Feck  ---
This bug was fixed for 5.2.1, so there is no need to attach log files from
5.2.0.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122593: Distinguish relays by both interval and alignment

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122593/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

...


Diffs
-

  src/plasma/datacontainer.cpp 5e5d2cc 

Diff: https://git.reviewboard.kde.org/r/122593/diff/


Testing
---

Changing seconds setting in Review 122592 works now


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122592: Align digital clock to full minutes

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/#review76143
---

Ship it!


Ship It!

- Marco Martin


On Feb. 16, 2015, 4:04 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122592/
> ---
> 
> (Updated Feb. 16, 2015, 4:04 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 343872
> https://bugs.kde.org/show_bug.cgi?id=343872
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This aligns the digital clock to full minutes so it's no longer off by up to 
> 30 seconds, and it allows us to increase the polling interval to 60s.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/main.qml 4cc83e8 
> 
> Diff: https://git.reviewboard.kde.org/r/122592/diff/
> 
> 
> Testing
> ---
> 
> Compared with xclock, plasmoid is now within 1/2 seconds of the full minute
> 
> This patch would require us to bump the plasma-framework dependency to 5.8
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122593: Distinguish relays by both interval and alignment

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122593/#review76142
---

Ship it!


Ship It!

- Marco Martin


On Feb. 16, 2015, 4:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122593/
> ---
> 
> (Updated Feb. 16, 2015, 4:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> ...
> 
> 
> Diffs
> -
> 
>   src/plasma/datacontainer.cpp 5e5d2cc 
> 
> Diff: https://git.reviewboard.kde.org/r/122593/diff/
> 
> 
> Testing
> ---
> 
> Changing seconds setting in Review 122592 works now
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122593: Distinguish relays by both interval and alignment

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122593/
---

(Updated Feb. 16, 2015, 5:48 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-framework


Description
---

...


Diffs
-

  src/plasma/datacontainer.cpp 5e5d2cc 

Diff: https://git.reviewboard.kde.org/r/122593/diff/


Testing
---

Changing seconds setting in Review 122592 works now


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122592: Align digital clock to full minutes

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/
---

(Updated Feb. 16, 2015, 5:48 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Martin Klapetek.


Bugs: 343872
https://bugs.kde.org/show_bug.cgi?id=343872


Repository: plasma-workspace


Description
---

This aligns the digital clock to full minutes so it's no longer off by up to 30 
seconds, and it allows us to increase the polling interval to 60s.


Diffs
-

  applets/digital-clock/package/contents/ui/main.qml 4cc83e8 

Diff: https://git.reviewboard.kde.org/r/122592/diff/


Testing
---

Compared with xclock, plasmoid is now within 1/2 seconds of the full minute

This patch would require us to bump the plasma-framework dependency to 5.8


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122594: Turn desktop toolbox into a dialog

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122594/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

This changes the desktop toolbox to use a Dialog and also cleans up the code a 
little and makes it dpi-aware (using units)


Diffs
-

  toolboxes/desktoptoolbox/contents/ui/ActionDelegate.qml 3c26265 
  toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml 561eb47 
  toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml da153b6 
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml 26bc262 

Diff: https://git.reviewboard.kde.org/r/122594/diff/


Testing
---

Positioning of the dialog is off sometimes but it just uses visualParent, so 
Dialog most likely needs fixing. Also the dialog cannot be toggled because when 
clicking outside it closes and then opens again on releasing. I don't know what 
magic the applet does to work around this.


File Attachments


Toolbox in action
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/b84deea4-3b2f-48b6-a88c-0f3a65ae9e12__toolboxdialog.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #1325

[KDE CI System]

See 

Changes:

[kde] Bump framework version requirement to 5.8.0

[kde] Align digital clock to full minutes

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson977159871814260952.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-workspace
   c7e5e27..7de7fb5  master -> origin/master
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at c7e5e27 package -> kPackage
Removing build/
Removing local-inst/
Success build forhudson.tasks.Shell@102d30ab
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/plasma-workspace # 
 > timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > git://anongit.kde.org/plasma-workspace +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 7de7fb53b0b779e197c893a5da3a8f510dd09d6d 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 7de7fb53b0b779e197c893a5da3a8f510dd09d6d
 > git rev-list c7e5e273939faab5c6700f2e0113925cfa01581b # timeout=10
 > git tag -a -f -m Jenkins Build #1325 
 > jenkins-plasma-workspace_master_qt5-1325 # timeout=10
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson8573934927530987155.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
 kguiaddons - Branch master
 kwallet - Branch master
 kross - Branch master
 libgit2 - Branch master
 kio-extras - Branch master
 ki18n - Branch master
 kdecoration - Branch master
 kactivities - Branch master
 kjs - Branch master
 karchive - Branch master
 baloo - Branch master
 kinit - Branch master
 kcompletion - Branch master
 knotifications - Branch master
 kwidgetsaddons - Branch master
 kjsembed - Branch master
 kunitconversion - Branch master
 kemoticons - Branch master
 kidletime - Branch master
 kpackage - Branch master
 kcmutils - Branch master
 kconfig - Branch master
 kxmlgui - Branch master
 libksysguard - Branch master
 kdelibs4support - Branch master
 phonon - Branch master
 sonnet - Branch master
 ktextwidgets - Branch master
 threadweaver - Branch master
 kfilemetadata - Branch master
 qt5 - Branch 5.4.1
 kde-cli-tools - Branch master
 kiconthemes - Branch master
 kbookmarks - Branch master
 libssh - Branch master
 kitemviews - Branch master
 kwindowsystem - Branch master
 extra-cmake-modules - Branch master
 kdbusaddons - Branch master
 kwin - Branch master
 milou - Branch master
 frameworkintegration - Branch master
 breeze - Branch master
 kdesu - Branch master
 kdewebkit - Branch master
 kitemmodels - Branch master
 kwayland - Branch master
 attica - Branch master
 knotifyconfig - Branch master
 kcrash - Branch master
 kded - Branch master
 polkit-qt-1 - Branch master
 kdnssd - Branch master
 knewstuff - Branch master
 kio - Branch master
 libkscreen - Branch master
 kcoreaddons - Branch master
 kxmlrpcclient - Branch master
 cmake - Branch master
 solid - Branch master
 kpty - Branch master
 krunner - Branch master
 kplotting - Branch master
 kglobalaccel - Branch master
 ktexteditor - Branch master
 dogtail - Branch master
 poppler - Branch master
 plasma-framework - Branch master
 kdeclarative - Branch master
 libdbusmenu-qt - Branch master
 kjobwidgets - Branch master
 kdoctools - Branch master
 kparts - Branch master
 khtml - Branch master
 kdesupport-svn - Branch master
 kservice - Branch master
 kauth - Branch master
 kconfigwidgets - Branch master
 khelpcenter - Branch master
 kcodecs - Branch master
 kdesignerplugin - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/c

Review Request 122595: Make it possible to let plasmoids to load scripts outside the plasma package

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122595/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

Adds a boolean X-Plasma-Requires-ExternalScripts property for the plasmoid 
metadata files that will request this feature.


Diffs
-

  src/plasma/data/servicetypes/plasma-applet.desktop 3b696d9 
  src/plasmaquick/packageurlinterceptor.cpp 128254d 

Diff: https://git.reviewboard.kde.org/r/122595/diff/


Testing
---

Created a plasmoid that uses it.


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122595: Make it possible to let plasmoids to load scripts outside the plasma package

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122595/#review76149
---

Ship it!


+1, could you just add a short paragraph about this in this page?
https://techbase.kde.org/Development/Tutorials/Plasma2/QML2/API

- Marco Martin


On Feb. 16, 2015, 6:14 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122595/
> ---
> 
> (Updated Feb. 16, 2015, 6:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Adds a boolean X-Plasma-Requires-ExternalScripts property for the plasmoid 
> metadata files that will request this feature.
> 
> 
> Diffs
> -
> 
>   src/plasma/data/servicetypes/plasma-applet.desktop 3b696d9 
>   src/plasmaquick/packageurlinterceptor.cpp 128254d 
> 
> Diff: https://git.reviewboard.kde.org/r/122595/diff/
> 
> 
> Testing
> ---
> 
> Created a plasmoid that uses it.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122595: Make it possible to let plasmoids to load scripts outside the plasma package

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122595/#review76152
---


Can't we resurrect, for instance, the X-Plasma-RequiredExtensions thing or so? 
I don't want to end up with dozens of X-Plasma-Requires-Internet, 
X-Plasma-Requires-This-and-that

- Kai Uwe Broulik


On Feb. 16, 2015, 6:14 nachm., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122595/
> ---
> 
> (Updated Feb. 16, 2015, 6:14 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Adds a boolean X-Plasma-Requires-ExternalScripts property for the plasmoid 
> metadata files that will request this feature.
> 
> 
> Diffs
> -
> 
>   src/plasma/data/servicetypes/plasma-applet.desktop 3b696d9 
>   src/plasmaquick/packageurlinterceptor.cpp 128254d 
> 
> Diff: https://git.reviewboard.kde.org/r/122595/diff/
> 
> 
> Testing
> ---
> 
> Created a plasmoid that uses it.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122596: Kill lock logout checkLayout() function

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122596/
---

Review request for Plasma.


Bugs: 337318 and 339435
https://bugs.kde.org/show_bug.cgi?id=337318
https://bugs.kde.org/show_bug.cgi?id=339435


Repository: plasma-workspace


Description
---

This replaces size and orientation handling by bindings and also uses units for 
the minimum size.


Diffs
-

  applets/lock_logout/contents/ui/lockout.qml d5d6a04 

Diff: https://git.reviewboard.kde.org/r/122596/diff/


Testing
---

I now get reasonably sized buttons and spacing in my panel


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122595: Make it possible to let plasmoids to load scripts outside the plasma package

[Marco Martin]

> On Feb. 16, 2015, 6:38 p.m., Kai Uwe Broulik wrote:
> > Can't we resurrect, for instance, the X-Plasma-RequiredExtensions thing or 
> > so? I don't want to end up with dozens of X-Plasma-Requires-Internet, 
> > X-Plasma-Requires-This-and-that

+1,
it can be X-Plasma-RequiredExtensions=ExternalScripts


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122595/#review76152
---


On Feb. 16, 2015, 6:14 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122595/
> ---
> 
> (Updated Feb. 16, 2015, 6:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Adds a boolean X-Plasma-Requires-ExternalScripts property for the plasmoid 
> metadata files that will request this feature.
> 
> 
> Diffs
> -
> 
>   src/plasma/data/servicetypes/plasma-applet.desktop 3b696d9 
>   src/plasmaquick/packageurlinterceptor.cpp 128254d 
> 
> Diff: https://git.reviewboard.kde.org/r/122595/diff/
> 
> 
> Testing
> ---
> 
> Created a plasmoid that uses it.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122594: Turn desktop toolbox into a dialog

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122594/#review76154
---

Ship it!


Ship It!

- Marco Martin


On Feb. 16, 2015, 5:53 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122594/
> ---
> 
> (Updated Feb. 16, 2015, 5:53 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This changes the desktop toolbox to use a Dialog and also cleans up the code 
> a little and makes it dpi-aware (using units)
> 
> 
> Diffs
> -
> 
>   toolboxes/desktoptoolbox/contents/ui/ActionDelegate.qml 3c26265 
>   toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml 561eb47 
>   toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml da153b6 
>   toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml 26bc262 
> 
> Diff: https://git.reviewboard.kde.org/r/122594/diff/
> 
> 
> Testing
> ---
> 
> Positioning of the dialog is off sometimes but it just uses visualParent, so 
> Dialog most likely needs fixing. Also the dialog cannot be toggled because 
> when clicking outside it closes and then opens again on releasing. I don't 
> know what magic the applet does to work around this.
> 
> 
> File Attachments
> 
> 
> Toolbox in action
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/b84deea4-3b2f-48b6-a88c-0f3a65ae9e12__toolboxdialog.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122594: Turn desktop toolbox into a dialog

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122594/
---

(Updated Feb. 16, 2015, 6:53 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-desktop


Description
---

This changes the desktop toolbox to use a Dialog and also cleans up the code a 
little and makes it dpi-aware (using units)


Diffs
-

  toolboxes/desktoptoolbox/contents/ui/ActionDelegate.qml 3c26265 
  toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml 561eb47 
  toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml da153b6 
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml 26bc262 

Diff: https://git.reviewboard.kde.org/r/122594/diff/


Testing
---

Positioning of the dialog is off sometimes but it just uses visualParent, so 
Dialog most likely needs fixing. Also the dialog cannot be toggled because when 
clicking outside it closes and then opens again on releasing. I don't know what 
magic the applet does to work around this.


File Attachments


Toolbox in action
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/b84deea4-3b2f-48b6-a88c-0f3a65ae9e12__toolboxdialog.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122598: Add separate checkbox for automatically lock screen

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122598/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

This improves usability over setting the timeout to 0.
Defaults behaviour is unchanged

BUG: 342596


Diffs
-

  ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg d5a82b7 
  ksmserver/screenlocker/kcm/kcm.ui 71d2cb0 
  ksmserver/screenlocker/ksldapp.cpp e23b50f 

Diff: https://git.reviewboard.kde.org/r/122598/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122598: Add separate checkbox for automatically lock screen

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122598/
---

(Updated Feb. 16, 2015, 7:29 p.m.)


Review request for Plasma.


Changes
---

add pic


Repository: plasma-workspace


Description
---

This improves usability over setting the timeout to 0.
Defaults behaviour is unchanged

BUG: 342596


Diffs
-

  ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg d5a82b7 
  ksmserver/screenlocker/kcm/kcm.ui 71d2cb0 
  ksmserver/screenlocker/ksldapp.cpp e23b50f 

Diff: https://git.reviewboard.kde.org/r/122598/diff/


Testing
---


File Attachments (updated)


a.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/858a9415-352d-48c5-bb1c-e2b60b23ab06__a.png


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #1326

[KDE CI System]

See 

Changes:

[kde] Make configure context menu entry consistent with the other plasmoids

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson846664572177983187.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-workspace
   7de7fb5..0d73cf9  master -> origin/master
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 7de7fb5 Align digital clock to full minutes
Removing build/
Success build forhudson.tasks.Shell@102d30ab
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/plasma-workspace # 
 > timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > git://anongit.kde.org/plasma-workspace +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 0d73cf97c0ded5535e79833ee3679d80bcfa2ede 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 0d73cf97c0ded5535e79833ee3679d80bcfa2ede
 > git rev-list 7de7fb53b0b779e197c893a5da3a8f510dd09d6d # timeout=10
 > git tag -a -f -m Jenkins Build #1326 
 > jenkins-plasma-workspace_master_qt5-1326 # timeout=10
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson3241468894478254045.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
 kwallet - Branch master
 kross - Branch master
 ktextwidgets - Branch master
 kio-extras - Branch master
 ki18n - Branch master
 kdbusaddons - Branch master
 kdecoration - Branch master
 kactivities - Branch master
 kjs - Branch master
 karchive - Branch master
 baloo - Branch master
 kinit - Branch master
 kcompletion - Branch master
 knotifications - Branch master
 kwidgetsaddons - Branch master
 kjsembed - Branch master
 kemoticons - Branch master
 kidletime - Branch master
 libgit2 - Branch master
 kcmutils - Branch master
 kconfig - Branch master
 kxmlrpcclient - Branch master
 kiconthemes - Branch master
 kdelibs4support - Branch master
 kded - Branch master
 phonon - Branch master
 sonnet - Branch master
 libssh - Branch master
 kservice - Branch master
 threadweaver - Branch master
 kfilemetadata - Branch master
 qt5 - Branch 5.4.1
 kde-cli-tools - Branch master
 solid - Branch master
 kbookmarks - Branch master
 kpackage - Branch master
 kitemviews - Branch master
 kwindowsystem - Branch master
 milou - Branch master
 poppler - Branch master
 kdesupport-svn - Branch master
 kwin - Branch master
 frameworkintegration - Branch master
 breeze - Branch master
 kdesu - Branch master
 kdewebkit - Branch master
 attica - Branch master
 kwayland - Branch master
 kitemmodels - Branch master
 knotifyconfig - Branch master
 kcrash - Branch master
 polkit-qt-1 - Branch master
 knewstuff - Branch master
 kjobwidgets - Branch master
 kio - Branch master
 libkscreen - Branch master
 kcoreaddons - Branch master
 extra-cmake-modules - Branch master
 cmake - Branch master
 kpty - Branch master
 kdnssd - Branch master
 krunner - Branch master
 kplotting - Branch master
 kglobalaccel - Branch master
 ktexteditor - Branch master
 dogtail - Branch master
 kunitconversion - Branch master
 plasma-framework - Branch master
 kdeclarative - Branch master
 libdbusmenu-qt - Branch master
 kxmlgui - Branch master
 kdoctools - Branch master
 kparts - Branch master
 khtml - Branch master
 libksysguard - Branch master
 kguiaddons - Branch master
 kauth - Branch master
 kconfigwidgets - Branch master
 khelpcenter - Branch master
 kcodecs - Branch master
 kdesignerplugin - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detectin

Re: Review Request 122598: Add separate checkbox for automatically lock screen

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122598/
---

(Updated Feb. 16, 2015, 7:38 p.m.)


Review request for Plasma.


Changes
---

Aleix suggests the following.


Repository: plasma-workspace


Description
---

This improves usability over setting the timeout to 0.
Defaults behaviour is unchanged

BUG: 342596


Diffs
-

  ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg d5a82b7 
  ksmserver/screenlocker/kcm/kcm.ui 71d2cb0 
  ksmserver/screenlocker/ksldapp.cpp e23b50f 

Diff: https://git.reviewboard.kde.org/r/122598/diff/


Testing
---


File Attachments (updated)


a.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/858a9415-352d-48c5-bb1c-e2b60b23ab06__a.png
aleix suggests doing this...thoughts?
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/4d9fbaed-dca8-4000-913e-c352696a975f__a1.png


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #1327

[KDE CI System]

See 

Changes:

[kde] Only show empty hint when the filter box is empty

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson5920511789110964111.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-workspace
   0d73cf9..736e013  master -> origin/master
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 0d73cf9 Make configure context menu entry consistent with the 
other plasmoids
Removing build/
Success build forhudson.tasks.Shell@102d30ab
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/plasma-workspace # 
 > timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > git://anongit.kde.org/plasma-workspace +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 736e0136e1bd75227f214fc630475526188807c5 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 736e0136e1bd75227f214fc630475526188807c5
 > git rev-list 0d73cf97c0ded5535e79833ee3679d80bcfa2ede # timeout=10
 > git tag -a -f -m Jenkins Build #1327 
 > jenkins-plasma-workspace_master_qt5-1327 # timeout=10
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson5861888175462215485.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
 kpackage - Branch master
 kwallet - Branch master
 ktexteditor - Branch master
 ktextwidgets - Branch master
 kio-extras - Branch master
 polkit-qt-1 - Branch master
 kactivities - Branch master
 kdecoration - Branch master
 attica - Branch master
 baloo - Branch master
 knotifications - Branch master
 kfilemetadata - Branch master
 kwidgetsaddons - Branch master
 kjsembed - Branch master
 milou - Branch master
 frameworkintegration - Branch master
 kidletime - Branch master
 libgit2 - Branch master
 kauth - Branch master
 kconfig - Branch master
 ki18n - Branch master
 kplotting - Branch master
 knotifyconfig - Branch master
 phonon - Branch master
 sonnet - Branch master
 solid - Branch master
 libdbusmenu-qt - Branch master
 kxmlgui - Branch master
 threadweaver - Branch master
 qt5 - Branch 5.4.1
 kde-cli-tools - Branch master
 kbookmarks - Branch master
 kitemviews - Branch master
 kwindowsystem - Branch master
 kpty - Branch master
 extra-cmake-modules - Branch master
 kdbusaddons - Branch master
 kwin - Branch master
 breeze - Branch master
 kio - Branch master
 libksysguard - Branch master
 kdewebkit - Branch master
 kinit - Branch master
 kdnssd - Branch master
 kwayland - Branch master
 kparts - Branch master
 kcmutils - Branch master
 kcrash - Branch master
 kemoticons - Branch master
 knewstuff - Branch master
 kunitconversion - Branch master
 kconfigwidgets - Branch master
 kservice - Branch master
 libkscreen - Branch master
 kdesignerplugin - Branch master
 kiconthemes - Branch master
 kcoreaddons - Branch master
 kross - Branch master
 kxmlrpcclient - Branch master
 cmake - Branch master
 kdesu - Branch master
 krunner - Branch master
 kjs - Branch master
 kitemmodels - Branch master
 karchive - Branch master
 kglobalaccel - Branch master
 poppler - Branch master
 kcompletion - Branch master
 dogtail - Branch master
 libssh - Branch master
 plasma-framework - Branch master
 kdeclarative - Branch master
 kdoctools - Branch master
 khtml - Branch master
 kdesupport-svn - Branch master
 kded - Branch master
 kjobwidgets - Branch master
 kguiaddons - Branch master
 khelpcenter - Branch master
 kcodecs - Branch master
 kdelibs4support - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- w

[ksystraycmd] [Bug 344168] there is no ksystray for plasma5

[Bhushan Shah]

https://bugs.kde.org/show_bug.cgi?id=344168

Bhushan Shah  changed:

   What|Removed |Added

 CC||sit...@kde.org

--- Comment #17 from Bhushan Shah  ---
*** Bug 337304 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122598: Add separate checkbox for automatically lock screen

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122598/#review76156
---



File Attachment: aleix suggests doing this...thoughts? - a1.png


I suggest you make the "After:" the label of the chekbox, so its hit area 
gets larger


- Kai Uwe Broulik


On Feb. 16, 2015, 7:42 nachm., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122598/
> ---
> 
> (Updated Feb. 16, 2015, 7:42 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This improves usability over setting the timeout to 0.
> Defaults behaviour is unchanged
> 
> BUG: 342596
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg d5a82b7 
>   ksmserver/screenlocker/kcm/kcm.ui 71d2cb0 
>   ksmserver/screenlocker/ksldapp.cpp e23b50f 
> 
> Diff: https://git.reviewboard.kde.org/r/122598/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> a.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/858a9415-352d-48c5-bb1c-e2b60b23ab06__a.png
> aleix suggests doing this...thoughts?
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/4d9fbaed-dca8-4000-913e-c352696a975f__a1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #1328

[KDE CI System]

See 

Changes:

[lukas] properly propagate info and error messages from kcheckpass and PAM

[scripty] SVN_SILENT made messages (.desktop file)

[kde] Offer editing only for text entries

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson886154907022165088.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-workspace
   5629da4..3b4bc68  Plasma/5.2 -> origin/Plasma/5.2
   736e013..411a746  master -> origin/master
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 736e013 Only show empty hint when the filter box is empty
Removing build/
Success build forhudson.tasks.Shell@102d30ab
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/plasma-workspace # 
 > timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > git://anongit.kde.org/plasma-workspace +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 411a746d73aaae3e736e0dffc5e07ca5cb5245b0 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 411a746d73aaae3e736e0dffc5e07ca5cb5245b0
 > git rev-list 736e0136e1bd75227f214fc630475526188807c5 # timeout=10
 > git tag -a -f -m Jenkins Build #1328 
 > jenkins-plasma-workspace_master_qt5-1328 # timeout=10
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson4891150135144246024.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
 kwallet - Branch master
 ktextwidgets - Branch master
 kio-extras - Branch master
 kxmlrpcclient - Branch master
 ktexteditor - Branch master
 kpty - Branch master
 kactivities - Branch master
 attica - Branch master
 baloo - Branch master
 kiconthemes - Branch master
 knotifications - Branch master
 kwidgetsaddons - Branch master
 kjsembed - Branch master
 kinit - Branch master
 plasma-framework - Branch master
 kidletime - Branch master
 kauth - Branch master
 kconfig - Branch master
 kemoticons - Branch master
 kdelibs4support - Branch master
 kconfigwidgets - Branch master
 phonon - Branch master
 sonnet - Branch master
 frameworkintegration - Branch master
 libksysguard - Branch master
 threadweaver - Branch master
 kjobwidgets - Branch master
 qt5 - Branch 5.4.1
 kde-cli-tools - Branch master
 kfilemetadata - Branch master
 kplotting - Branch master
 kbookmarks - Branch master
 kitemmodels - Branch master
 karchive - Branch master
 kwindowsystem - Branch master
 libgit2 - Branch master
 kxmlgui - Branch master
 extra-cmake-modules - Branch master
 kitemviews - Branch master
 kdbusaddons - Branch master
 kwin - Branch master
 kded - Branch master
 breeze - Branch master
 kdesupport-svn - Branch master
 kdewebkit - Branch master
 kunitconversion - Branch master
 kwayland - Branch master
 knotifyconfig - Branch master
 kcrash - Branch master
 kguiaddons - Branch master
 libdbusmenu-qt - Branch master
 kio - Branch master
 libkscreen - Branch master
 polkit-qt-1 - Branch master
 kdnssd - Branch master
 kcoreaddons - Branch master
 poppler - Branch master
 kparts - Branch master
 milou - Branch master
 cmake - Branch master
 krunner - Branch master
 kcmutils - Branch master
 kglobalaccel - Branch master
 kdesignerplugin - Branch master
 dogtail - Branch master
 knewstuff - Branch master
 kdeclarative - Branch master
 ki18n - Branch master
 kservice - Branch master
 kdecoration - Branch master
 kdoctools - Branch master
 kross - Branch master
 khtml - Branch master
 kdesu - Branch master
 solid - Branch master
 kcompletion - Branch master
 kpackage - Branch master
 kjs - Branch master
 libssh - Branch master
 khelpcenter - Branch master
 kcodecs - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.8.2
-- The CXX comp

Re: Review Request 122598: Add separate checkbox for automatically lock screen

[Thomas Pfeiffer]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122598/#review76163
---


This is fine from an interaction perspective, however layout-wise the first 
checkbox should be left-aligned (the next two elements are dependent on it 
anyway). The "After" indeed be put in the same line.
"Lock Screen on resume" should also be left aligned, it can be put on the 
bottom to not break overall alignment.

- Thomas Pfeiffer


On Feb. 16, 2015, 7:42 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122598/
> ---
> 
> (Updated Feb. 16, 2015, 7:42 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This improves usability over setting the timeout to 0.
> Defaults behaviour is unchanged
> 
> BUG: 342596
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg d5a82b7 
>   ksmserver/screenlocker/kcm/kcm.ui 71d2cb0 
>   ksmserver/screenlocker/ksldapp.cpp e23b50f 
> 
> Diff: https://git.reviewboard.kde.org/r/122598/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> a.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/858a9415-352d-48c5-bb1c-e2b60b23ab06__a.png
> aleix suggests doing this...thoughts?
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/4d9fbaed-dca8-4000-913e-c352696a975f__a1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122598: Add separate checkbox for automatically lock screen

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122598/#review76168
---


Personally I think a is better.

- Martin Gräßlin


On Feb. 16, 2015, 8:42 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122598/
> ---
> 
> (Updated Feb. 16, 2015, 8:42 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This improves usability over setting the timeout to 0.
> Defaults behaviour is unchanged
> 
> BUG: 342596
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg d5a82b7 
>   ksmserver/screenlocker/kcm/kcm.ui 71d2cb0 
>   ksmserver/screenlocker/ksldapp.cpp e23b50f 
> 
> Diff: https://git.reviewboard.kde.org/r/122598/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> a.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/858a9415-352d-48c5-bb1c-e2b60b23ab06__a.png
> aleix suggests doing this...thoughts?
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/4d9fbaed-dca8-4000-913e-c352696a975f__a1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel