Re: Review Request 121856: KWindowSystem import for KDeclarative

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121856/#review76323
---


Could you please add some documentation including example usage and maybe a 
test qml file?


src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h


I'm against a setter for currentDesktopName


- Martin Gräßlin


On Feb. 19, 2015, 6:25 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121856/
> ---
> 
> (Updated Feb. 19, 2015, 6:25 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a thin proxy around KWindowSystem exposing most of its methods to qml 
> via KWindowSystem item in an org.kde.kwindowsystem import.
> 
> It uses QWindow instead of WId parameters so you can just pass a qml Item, 
> such as a Plasma Dialog as parameter for ease of use (and so you cannot mess 
> with others windows without effort, also I don't know what "WId" would 
> translate to anyway). It omits all those methods that return WId/QWindow as I 
> don't know how expensive QWindow::fromWinId is or who takes ownership of it. 
> We need to decide which methods make sense in this import.
> 
> Methods that have signals and don't take parameters are turned into 
> full-fledged properties (like currentDesktop, numberOfDesktops, etc) and the 
> rest stays Q_INVOKABLE.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/CMakeLists.txt 39c39a5 
>   src/qmlcontrols/kwindowsystemplugin/CMakeLists.txt PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.h PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.cpp PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121856/diff/
> 
> 
> Testing
> ---
> 
> The properties work and change accordingly (compositing active signal doesn't 
> seem to be emitted by KWindowSystem in the first place, at least 
> Ctrl+Shift+F12 doesn't make it change), the forceActivateWindow method works 
> for Review 121807
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122619: [KPluginMetaData] Add support for Hidden key

[Alex Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122619/#review76322
---

Ship it!


Now that there is a use case for it, it makes sense to add it.

- Alex Richardson


On Feb. 18, 2015, 9:44 a.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122619/
> ---
> 
> (Updated Feb. 18, 2015, 9:44 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma, Alex Richardson, David Faure, and 
> Marco Martin.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Add support for Hidden key
> 
> This key does not make a lot of sense for binary plugins (those loaded
> from .so files which retrieve their metadata from the json-embedded
> data), but is useful for plugins loaded from .desktop files.
> This allows us to override the visibility of installed plugins by the
> user.
> 
> I'm only considering the Hidden key here. I am not sure how the
> NoDisplay key (which seems to be used here and there), so maybe we
> should also consider NoDisplay. This is the most basic patch we can
> achieve the desired results with, however.
> 
> 
> Diffs
> -
> 
>   autotests/data/hiddenplugin.desktop PRE-CREATION 
>   autotests/kpluginmetadatatest.cpp 8a14f57dd0a8650f41185290da966f036cb66fb6 
>   src/lib/plugin/desktopfileparser.cpp 
> b1b5440b48e4fd412932a7d7e794d641b1406699 
>   src/lib/plugin/kpluginmetadata.h 7ca6747c766d92be828fa3350d088a2f8b1b12f4 
>   src/lib/plugin/kpluginmetadata.cpp cf90ebc204186f26a3199753fb8c97922a278bd1 
> 
> Diff: https://git.reviewboard.kde.org/r/122619/diff/
> 
> 
> Testing
> ---
> 
> * Added autotest to make sure both cases work
> * Tried to hide a KPackage by adding a Hidden=true to the metadata.desktop 
> file
> 
> Both work as expected with this patch.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121856: KWindowSystem import for KDeclarative

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121856/
---

(Updated Feb. 19, 2015, 5:25 nachm.)


Review request for kwin and Plasma.


Changes
---

- Remove C++11 features not allowed in frameworks
- Make functions non-static
- Remove redundant methods available in QtQuick Window
- Added "currentDesktopName" property to allow for a more declarative access to 
that


Repository: kdeclarative


Description
---

This is a thin proxy around KWindowSystem exposing most of its methods to qml 
via KWindowSystem item in an org.kde.kwindowsystem import.

It uses QWindow instead of WId parameters so you can just pass a qml Item, such 
as a Plasma Dialog as parameter for ease of use (and so you cannot mess with 
others windows without effort, also I don't know what "WId" would translate to 
anyway). It omits all those methods that return WId/QWindow as I don't know how 
expensive QWindow::fromWinId is or who takes ownership of it. We need to decide 
which methods make sense in this import.

Methods that have signals and don't take parameters are turned into 
full-fledged properties (like currentDesktop, numberOfDesktops, etc) and the 
rest stays Q_INVOKABLE.


Diffs (updated)
-

  src/qmlcontrols/CMakeLists.txt 39c39a5 
  src/qmlcontrols/kwindowsystemplugin/CMakeLists.txt PRE-CREATION 
  src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.h PRE-CREATION 
  src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.cpp PRE-CREATION 
  src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h PRE-CREATION 
  src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp PRE-CREATION 
  src/qmlcontrols/kwindowsystemplugin/qmldir PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121856/diff/


Testing
---

The properties work and change accordingly (compositing active signal doesn't 
seem to be emitted by KWindowSystem in the first place, at least Ctrl+Shift+F12 
doesn't make it change), the forceActivateWindow method works for Review 121807


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121807: Call forceActiveWindow on the sidePanel

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121807/
---

(Updated Feb. 19, 2015, 5:21 nachm.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-desktop


Description
---

See Review 121806


Diffs
-

  desktoppackage/contents/views/Desktop.qml c2da3b8 

Diff: https://git.reviewboard.kde.org/r/121807/diff/


Testing
---

Works


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

5.2.1 tars for packagers

[Jonathan Riddell]

5.2.1 tars are up on depot for packagers

http://starsky.19inch.net/~jr/tmp/5.2.1-release-data

Harald has been lovely and done a lot of work on releaseme which makes the 
tars, please check over for regressions.

Release is due on Tuesday

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[kio-extras] [Bug 344355] Commit a5d223221e802b057833e780cdca7cca65c06b52 broke thumbnails generation

[Lukáš Tinkl]

https://bugs.kde.org/show_bug.cgi?id=344355

Lukáš Tinkl  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
 CC||lu...@kde.org

--- Comment #1 from Lukáš Tinkl  ---
Confirmed, noticed the same recently

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[kio-extras] [Bug 344355] Commit a5d223221e802b057833e780cdca7cca65c06b52 broke thumbnails generation

[Eugene Shalygin]

https://bugs.kde.org/show_bug.cgi?id=344355

Eugene Shalygin  changed:

   What|Removed |Added

   Platform|Other   |Gentoo Packages

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[kio-extras] [Bug 344355] New: Commit a5d223221e802b057833e780cdca7cca65c06b52 broke thumbnails generation

[Eugene Shalygin]

https://bugs.kde.org/show_bug.cgi?id=344355

Bug ID: 344355
   Summary: Commit a5d223221e802b057833e780cdca7cca65c06b52  broke
thumbnails generation
   Product: kio-extras
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: default
  Assignee: plasma-devel@kde.org
  Reporter: eugene.shalygin+bugzilla@gmail.com

After the given commit generation of new thumbnails does not happen.
PreviewJobPrivate::createThumbnail tries to execute thumbnail generation job,
but it returns no data. Is it supposed to work with the current generators? The
linked review request  does not say anything about this.

Reproducible: Always

Steps to Reproduce:
Use dolphin or previewtest test app from kio 

Actual Results:  
No thumbnails for new files in Dolphin or "Failed" message in previewtest app


Reverting this commit brings back thumbnails generation

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to normal : plasma-workspace_stable_qt5 #72

[KDE CI System]

See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to normal : plasma-workspace_master_qt5 #1348

[KDE CI System]

See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to normal : khotkeys_stable_qt5 #11

[KDE CI System]

See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to normal : khotkeys_master_qt5 #63

[KDE CI System]

See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_stable_qt5 #71

[KDE CI System]

See 

Changes:

[jr] use ecm_optional_add_subdirectory instead of add_subdirectory for docs, 
the translations may be incomplete

--
[...truncated 39 lines...]
== Build Dependencies:
 kdesignerplugin - Branch master
 kwidgetsaddons - Branch master
 kplotting - Branch master
 kwallet - Branch master
 karchive - Branch master
 kguiaddons - Branch master
 ktextwidgets - Branch master
 kitemviews - Branch master
 khelpcenter - Branch Plasma/5.2
 kjobwidgets - Branch master
 kfilemetadata - Branch Plasma/5.2
 khtml - Branch master
 kdesupport-svn - Branch master
 kjsembed - Branch master
 dogtail - Branch master
 kiconthemes - Branch master
 kauth - Branch master
 kactivities - Branch master
 ktexteditor - Branch master
 kcompletion - Branch master
 kitemmodels - Branch master
 kde-cli-tools - Branch Plasma/5.2
 baloo - Branch Plasma/5.2
 kded - Branch master
 breeze - Branch Plasma/5.2
 kconfig - Branch master
 kidletime - Branch master
 libdbusmenu-qt - Branch master
 libssh - Branch master
 kdbusaddons - Branch master
 knotifyconfig - Branch master
 kunitconversion - Branch master
 extra-cmake-modules - Branch master
 libgit2 - Branch master
 kross - Branch master
 threadweaver - Branch master
 kdecoration - Branch Plasma/5.2
 kdeclarative - Branch master
 kdelibs4support - Branch master
 kdewebkit - Branch master
 solid - Branch master
 kxmlgui - Branch master
 kpackage - Branch master
 kcoreaddons - Branch master
 kio - Branch master
 kcrash - Branch master
 sonnet - Branch master
 polkit-qt-1 - Branch master
 milou - Branch Plasma/5.2
 qt5 - Branch 5.3.2
 kwin - Branch Plasma/5.2
 ki18n - Branch master
 kpty - Branch master
 kglobalaccel - Branch master
 kwindowsystem - Branch master
 kjs - Branch master
 kconfigwidgets - Branch master
 libksysguard - Branch Plasma/5.2
 kparts - Branch master
 kwayland - Branch Plasma/5.2
 krunner - Branch master
 kinit - Branch master
 plasma-framework - Branch master
 kdnssd - Branch master
 kdesu - Branch master
 kbookmarks - Branch master
 knewstuff - Branch master
 cmake - Branch master
 kemoticons - Branch master
 phonon - Branch master
 kdoctools - Branch master
 libkscreen - Branch Plasma/5.2
 kcmutils - Branch master
 frameworkintegration - Branch master
 kservice - Branch master
 attica - Branch master
 kio-extras - Branch Plasma/5.2
 kcodecs - Branch master
 knotifications - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found KF5Plasma: 
/srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/plasma-framework/inst/lib64/cmake/KF5Plasma/KF5PlasmaConfig.cmake
 (found version "5.8.0") 
-- Found KF5DocTools: 
/srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kdoctools/inst/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake
 (found version "5.8.0") 
-- Found KF5Runner: 
/srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/krunner/inst/lib64/cmake/KF5Runner/KF5RunnerConfig.cmake
 (found version "5.8.0") 
-- Found Gettext: /usr/bin/msgmerge (found version "0.18.1") 
-- Found PythonInterp: /usr/bin/python (found version "2.7.3") 
-- Found KF5JsEmbed: 
/srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kjsembed/inst/lib64/cmake/KF5JsEmbed/KF5JsEmbedConfig.cmake
 (found version "5.8.0") 
-- Found KF5NotifyConfig: 
/srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/knotifyconfig/inst/lib64/cmake/KF5NotifyConfig/KF5NotifyConfigConfig.cmake
 (found version "5.8.0") 
-- Found KF5Su: 
/srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kdesu/inst/lib64/cmake/KF5Su/KF5SuConfig.cmake
 (found version "5.8.0") 
-- Found KF5NewStuff: 
/srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/knewstuff/inst/lib64/cmake/KF5NewStuff/KF5NewStuffConfig.cmake
 (found version "5.8.0") 
-- Found KF5Wallet: 
/srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kwallet/inst/lib64/cmake/KF5Walle

Build failed in Jenkins: khotkeys_master_qt5 #62

[KDE CI System]

See 

Changes:

[jr] use ecm_optional_add_subdirectory instead of add_subdirectory for docs, 
the translations may be incomplete

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[khotkeys_master_qt5] $ /bin/sh -xe /tmp/hudson4554177123437553147.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at f780ed5 use ecm_optional_add_subdirectory instead of 
add_subdirectory for docs, the translations may be incomplete
Success build forhudson.tasks.Shell@4edae317
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/khotkeys # timeout=10
Fetching upstream changes from git://anongit.kde.org/khotkeys
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > git://anongit.kde.org/khotkeys +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision f780ed5fd9673eb0b02c7f027c1a72628a9c3198 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f f780ed5fd9673eb0b02c7f027c1a72628a9c3198
 > git rev-list 8f4a3f415d2779cc65a9cfc84337b16593a2ee0c # timeout=10
 > git tag -a -f -m Jenkins Build #62 jenkins-khotkeys_master_qt5-62 # 
 > timeout=10
[khotkeys_master_qt5] $ /bin/sh -xe /tmp/hudson5039884530844034490.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: khotkeys - Branch master
== Build Dependencies:
 knotifications - Branch master
 kwallet - Branch master
 kwin - Branch master
 kwayland - Branch master
 libgit2 - Branch master
 ktexteditor - Branch master
 libssh - Branch master
 krunner - Branch master
 kactivities - Branch master
 kjsembed - Branch master
 kio - Branch master
 kdesignerplugin - Branch master
 frameworkintegration - Branch master
 kio-extras - Branch master
 dogtail - Branch master
 kwidgetsaddons - Branch master
 ktextwidgets - Branch master
 khtml - Branch master
 kdesu - Branch master
 kdesupport-svn - Branch master
 kitemmodels - Branch master
 kcoreaddons - Branch master
 kconfig - Branch master
 kded - Branch master
 ki18n - Branch master
 kconfigwidgets - Branch master
 kauth - Branch master
 kinit - Branch master
 polkit-qt-1 - Branch master
 attica - Branch master
 kdeclarative - Branch master
 plasma-workspace - Branch master
 karchive - Branch master
 kdoctools - Branch master
 kwindowsystem - Branch master
 qt5 - Branch 5.4.1
 kcrash - Branch master
 baloo - Branch master
 kpackage - Branch master
 kidletime - Branch master
 solid - Branch master
 kparts - Branch master
 knotifyconfig - Branch master
 kservice - Branch master
 extra-cmake-modules - Branch master
 kdewebkit - Branch master
 kdbusaddons - Branch master
 kdelibs4support - Branch master
 kde-cli-tools - Branch master
 knewstuff - Branch master
 threadweaver - Branch master
 libkscreen - Branch master
 libdbusmenu-qt - Branch master
 kross - Branch master
 kbookmarks - Branch master
 kxmlgui - Branch master
 kjs - Branch master
 poppler - Branch master
 kxmlrpcclient - Branch master
 kitemviews - Branch master
 breeze - Branch master
 kcmutils - Branch master
 kdecoration - Branch master
 kemoticons - Branch master
 kplotting - Branch master
 kglobalaccel - Branch master
 libksysguard - Branch master
 kiconthemes - Branch master
 khelpcenter - Branch master
 sonnet - Branch master
 kguiaddons - Branch master
 phonon - Branch master
 kcompletion - Branch master
 kunitconversion - Branch master
 kfilemetadata - Branch master
 kpty - Branch master
 cmake - Branch master
 kdnssd - Branch master
 kjobwidgets - Branch master
 milou - Branch master
 kcodecs - Branch master
 plasma-framework - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
--

Build failed in Jenkins: plasma-workspace_master_qt5 #1347

[KDE CI System]

See 

Changes:

[jr] use ecm_optional_add_subdirectory instead of add_subdirectory for docs, 
the translations may be incomplete

--
[...truncated 43 lines...]
 kwallet - Branch master
 kio-extras - Branch master
 ktextwidgets - Branch master
 kbookmarks - Branch master
 breeze - Branch master
 baloo - Branch master
 libssh - Branch master
 attica - Branch master
 kdesupport-svn - Branch master
 kjsembed - Branch master
 frameworkintegration - Branch master
 kcoreaddons - Branch master
 dogtail - Branch master
 kauth - Branch master
 kjobwidgets - Branch master
 kglobalaccel - Branch master
 kcompletion - Branch master
 kitemmodels - Branch master
 kconfig - Branch master
 karchive - Branch master
 knotifications - Branch master
 poppler - Branch master
 kguiaddons - Branch master
 kdecoration - Branch master
 khelpcenter - Branch master
 kitemviews - Branch master
 qt5 - Branch 5.4.1
 kidletime - Branch master
 phonon - Branch master
 libdbusmenu-qt - Branch master
 kde-cli-tools - Branch master
 kpackage - Branch master
 knotifyconfig - Branch master
 kcrash - Branch master
 kio - Branch master
 extra-cmake-modules - Branch master
 kiconthemes - Branch master
 kross - Branch master
 threadweaver - Branch master
 kded - Branch master
 libksysguard - Branch master
 kdeclarative - Branch master
 kdelibs4support - Branch master
 kdewebkit - Branch master
 kwayland - Branch master
 kfilemetadata - Branch master
 kactivities - Branch master
 kxmlrpcclient - Branch master
 plasma-framework - Branch master
 libgit2 - Branch master
 kwidgetsaddons - Branch master
 kjs - Branch master
 libkscreen - Branch master
 kemoticons - Branch master
 kunitconversion - Branch master
 milou - Branch master
 khtml - Branch master
 solid - Branch master
 kdnssd - Branch master
 sonnet - Branch master
 kpty - Branch master
 kdesu - Branch master
 ki18n - Branch master
 knewstuff - Branch master
 cmake - Branch master
 kconfigwidgets - Branch master
 polkit-qt-1 - Branch master
 kdoctools - Branch master
 kwin - Branch master
 krunner - Branch master
 kcmutils - Branch master
 kdbusaddons - Branch master
 ktexteditor - Branch master
 kwindowsystem - Branch master
 kplotting - Branch master
 kservice - Branch master
 kcodecs - Branch master
 kinit - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found KF5Plasma: 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/plasma-framework/inst/lib64/cmake/KF5Plasma/KF5PlasmaConfig.cmake
 (found version "5.8.0") 
-- Found KF5DocTools: 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdoctools/inst/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake
 (found version "5.8.0") 
-- Found KF5Runner: 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/krunner/inst/lib64/cmake/KF5Runner/KF5RunnerConfig.cmake
 (found version "5.8.0") 
-- Found Gettext: /usr/bin/msgmerge (found version "0.18.1") 
-- Found PythonInterp: /usr/bin/python (found version "2.7.3") 
-- Found KF5JsEmbed: 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kjsembed/inst/lib64/cmake/KF5JsEmbed/KF5JsEmbedConfig.cmake
 (found version "5.8.0") 
-- Found KF5NotifyConfig: 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/knotifyconfig/inst/lib64/cmake/KF5NotifyConfig/KF5NotifyConfigConfig.cmake
 (found version "5.8.0") 
-- Found KF5Su: 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdesu/inst/lib64/cmake/KF5Su/KF5SuConfig.cmake
 (found version "5.8.0") 
-- Found KF5NewStuff: 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/knewstuff/inst/lib64/cmake/KF5NewStuff/KF5NewStuffConfig.cmake
 (found version "5.8.0") 
-- Found KF5Wallet: 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kwallet/inst/lib64/cmake/KF5Wallet/KF5WalletConfig.cmake
 (found version "5.8.0") 
-- Found KF5KCMUtils: 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kcmutils/inst/lib64/cmake

Build failed in Jenkins: khotkeys_stable_qt5 #10

[KDE CI System]

See 

Changes:

[jr] use ecm_optional_add_subdirectory instead of add_subdirectory for docs, 
the translations may be incomplete

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[khotkeys_stable_qt5] $ /bin/sh -xe /tmp/hudson7529016512199118600.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

From git://anongit.kde.org/khotkeys
   e7078c2..84a7611  Plasma/5.2 -> origin/Plasma/5.2
   8f4a3f4..f780ed5  master -> origin/master
 * [new tag] v5.2.0 -> v5.2.0
Branch jenkins set up to track remote branch Plasma/5.2 from origin.

== Cleaning Source Tree

HEAD is now at e7078c2 Update version number for 5.2.0
Removing build/
Removing local-inst/
Success build forhudson.tasks.Shell@6aa23f14
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/khotkeys # timeout=10
Fetching upstream changes from git://anongit.kde.org/khotkeys
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > git://anongit.kde.org/khotkeys +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 84a76110c781926b6c9b108cefeeadd33dd5a2ae 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 84a76110c781926b6c9b108cefeeadd33dd5a2ae
 > git rev-list 1d8932550167bf73b56e39f826421dd3507bbfc1 # timeout=10
 > git tag -a -f -m Jenkins Build #10 jenkins-khotkeys_stable_qt5-10 # 
 > timeout=10
[khotkeys_stable_qt5] $ /bin/sh -xe /tmp/hudson4499597759543376494.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: khotkeys - Branch Plasma/5.2
== Build Dependencies:
 kwallet - Branch master
 kitemmodels - Branch master
 kross - Branch master
 breeze - Branch Plasma/5.2
 kcompletion - Branch master
 kactivities - Branch master
 kidletime - Branch master
 kjsembed - Branch master
 kio - Branch master
 knotifications - Branch master
 kunitconversion - Branch master
 kwidgetsaddons - Branch master
 ktextwidgets - Branch master
 kdesupport-svn - Branch master
 kpty - Branch master
 kxmlgui - Branch master
 kconfig - Branch master
 kio-extras - Branch Plasma/5.2
 ki18n - Branch master
 kconfigwidgets - Branch master
 dogtail - Branch master
 kemoticons - Branch master
 kdnssd - Branch master
 kinit - Branch master
 knotifyconfig - Branch master
 phonon - Branch master
 kdesignerplugin - Branch master
 qt5 - Branch 5.3.2
 kbookmarks - Branch master
 khtml - Branch master
 kdoctools - Branch master
 kwindowsystem - Branch master
 frameworkintegration - Branch master
 kcrash - Branch master
 knewstuff - Branch master
 kpackage - Branch master
 ktexteditor - Branch master
 kwin - Branch Plasma/5.2
 libgit2 - Branch master
 kparts - Branch master
 polkit-qt-1 - Branch master
 cmake - Branch master
 kdesu - Branch master
 extra-cmake-modules - Branch master
 solid - Branch master
 krunner - Branch master
 kdbusaddons - Branch master
 libdbusmenu-qt - Branch master
 kdelibs4support - Branch master
 plasma-workspace - Branch Plasma/5.2
 kdewebkit - Branch master
 baloo - Branch Plasma/5.2
 libssh - Branch master
 kfilemetadata - Branch Plasma/5.2
 khelpcenter - Branch Plasma/5.2
 kdecoration - Branch Plasma/5.2
 kauth - Branch master
 kcoreaddons - Branch master
 threadweaver - Branch master
 kjs - Branch master
 kitemviews - Branch master
 attica - Branch master
 milou - Branch Plasma/5.2
 kcmutils - Branch master
 kplotting - Branch master
 kglobalaccel - Branch master
 kded - Branch master
 kiconthemes - Branch master
 sonnet - Branch master
 kguiaddons - Branch master
 kde-cli-tools - Branch Plasma/5.2
 karchive - Branch master
 libkscreen - Branch Plasma/5.2
 kwayland - Branch Plasma/5.2
 kservice - Branch master
 libksysguard - Branch Plasma/5.2
 kjobwidgets - Branch master
 kcodecs - Branch master
 plasma-framework - Branch master
 kdeclarative - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /h

Re: Review Request 121856: KWindowSystem import for KDeclarative

[Kai Uwe Broulik]

> On Feb. 19, 2015, 2:11 nachm., Thomas Lübking wrote:
> > I'd say that the window related functions that are not already supported 
> > (raise, lower, desktop, ...) should be added to the QML Window type 
> > (oo-style + declarative) and only the actual WindowSystem / WindowManager 
> > related stuff (current desktop, compositing state, ...) should be done in 
> > an extra component (to query the WM state)

Ok. The main reason behind this is the forceActiveWindow


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121856/#review76295
---


On Jan. 5, 2015, 10:49 vorm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121856/
> ---
> 
> (Updated Jan. 5, 2015, 10:49 vorm.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a thin proxy around KWindowSystem exposing most of its methods to qml 
> via KWindowSystem item in an org.kde.kwindowsystem import.
> 
> It uses QWindow instead of WId parameters so you can just pass a qml Item, 
> such as a Plasma Dialog as parameter for ease of use (and so you cannot mess 
> with others windows without effort, also I don't know what "WId" would 
> translate to anyway). It omits all those methods that return WId/QWindow as I 
> don't know how expensive QWindow::fromWinId is or who takes ownership of it. 
> We need to decide which methods make sense in this import.
> 
> Methods that have signals and don't take parameters are turned into 
> full-fledged properties (like currentDesktop, numberOfDesktops, etc) and the 
> rest stays Q_INVOKABLE.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kwindowsystemplugin/qmldir PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp PRE-CREATION 
>   src/qmlcontrols/CMakeLists.txt 39c39a5 
>   src/qmlcontrols/kwindowsystemplugin/CMakeLists.txt PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.h PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.cpp PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121856/diff/
> 
> 
> Testing
> ---
> 
> The properties work and change accordingly (compositing active signal doesn't 
> seem to be emitted by KWindowSystem in the first place, at least 
> Ctrl+Shift+F12 doesn't make it change), the forceActivateWindow method works 
> for Review 121807
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

plasma-mediacenter in kdereview from extragear

[Bhushan Shah]

Hello,

We want to move plasma-mediacenter to kde/workspace for releasing it
with Plasma 5.x release cycle, Plasma media center is living room
solution of plasma workspaces, it is integrated as shell package for
PMC.

Current code depends upon KDE Frameworks 5 (free of kdelibs4support),
kfilemetadata, baloo, taglib and mockcpp (for tests, optional
dependancy), you can build it from master branch or you can try it out
from binary packages provided by different distributions like
kubuntu-ci, KDE:Unstable:Extra repo from opensuse, or
plasma-mediacenter-git package from AUR for archlinux.

Looking forward to review from community

Thanks!

-- 
Bhushan Shah

http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: plasma-mediacenter in kdereview from extragear

[Bhushan Shah]

On Thu, Feb 19, 2015 at 8:22 PM, Bhushan Shah  wrote:
> Looking forward to review from community

Just for record : This mail is sent to both plasma-devel and
kde-core-devel, reply to kde-core-devel


-- 
Bhushan Shah

http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121856: KWindowSystem import for KDeclarative

[Thomas Lübking]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121856/#review76295
---


I'd say that the window related functions that are not already supported 
(raise, lower, desktop, ...) should be added to the QML Window type (oo-style + 
declarative) and only the actual WindowSystem / WindowManager related stuff 
(current desktop, compositing state, ...) should be done in an extra component 
(to query the WM state)


src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h


Window.alert?



src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h


Window.visibililty?



src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h


windowFromId reasoning applies here as well


- Thomas Lübking


On Jan. 5, 2015, 10:49 vorm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121856/
> ---
> 
> (Updated Jan. 5, 2015, 10:49 vorm.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a thin proxy around KWindowSystem exposing most of its methods to qml 
> via KWindowSystem item in an org.kde.kwindowsystem import.
> 
> It uses QWindow instead of WId parameters so you can just pass a qml Item, 
> such as a Plasma Dialog as parameter for ease of use (and so you cannot mess 
> with others windows without effort, also I don't know what "WId" would 
> translate to anyway). It omits all those methods that return WId/QWindow as I 
> don't know how expensive QWindow::fromWinId is or who takes ownership of it. 
> We need to decide which methods make sense in this import.
> 
> Methods that have signals and don't take parameters are turned into 
> full-fledged properties (like currentDesktop, numberOfDesktops, etc) and the 
> rest stays Q_INVOKABLE.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kwindowsystemplugin/qmldir PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp PRE-CREATION 
>   src/qmlcontrols/CMakeLists.txt 39c39a5 
>   src/qmlcontrols/kwindowsystemplugin/CMakeLists.txt PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.h PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.cpp PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121856/diff/
> 
> 
> Testing
> ---
> 
> The properties work and change accordingly (compositing active signal doesn't 
> seem to be emitted by KWindowSystem in the first place, at least 
> Ctrl+Shift+F12 doesn't make it change), the forceActivateWindow method works 
> for Review 121807
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122619: [KPluginMetaData] Add support for Hidden key

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122619/#review76291
---


+1 from here

- Marco Martin


On Feb. 18, 2015, 9:44 a.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122619/
> ---
> 
> (Updated Feb. 18, 2015, 9:44 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma, Alex Richardson, David Faure, and 
> Marco Martin.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Add support for Hidden key
> 
> This key does not make a lot of sense for binary plugins (those loaded
> from .so files which retrieve their metadata from the json-embedded
> data), but is useful for plugins loaded from .desktop files.
> This allows us to override the visibility of installed plugins by the
> user.
> 
> I'm only considering the Hidden key here. I am not sure how the
> NoDisplay key (which seems to be used here and there), so maybe we
> should also consider NoDisplay. This is the most basic patch we can
> achieve the desired results with, however.
> 
> 
> Diffs
> -
> 
>   autotests/data/hiddenplugin.desktop PRE-CREATION 
>   autotests/kpluginmetadatatest.cpp 8a14f57dd0a8650f41185290da966f036cb66fb6 
>   src/lib/plugin/desktopfileparser.cpp 
> b1b5440b48e4fd412932a7d7e794d641b1406699 
>   src/lib/plugin/kpluginmetadata.h 7ca6747c766d92be828fa3350d088a2f8b1b12f4 
>   src/lib/plugin/kpluginmetadata.cpp cf90ebc204186f26a3199753fb8c97922a278bd1 
> 
> Diff: https://git.reviewboard.kde.org/r/122619/diff/
> 
> 
> Testing
> ---
> 
> * Added autotest to make sure both cases work
> * Tried to hide a KPackage by adding a Hidden=true to the metadata.desktop 
> file
> 
> Both work as expected with this patch.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122512: [screenlocker] Add a KKeySequenceWidget to configuration interface

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122512/
---

(Updated Feb. 19, 2015, 1:15 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Bugs: 325622
https://bugs.kde.org/show_bug.cgi?id=325622


Repository: plasma-workspace


Description
---

Allows to configure the global shortcut for locking the screen.

FEATURE: 325622
FIXED-IN: 5.3.0


Diffs
-

  ksmserver/screenlocker/kcm/CMakeLists.txt 
557e59ad8bf4ece0c6eac4dd98b7dbb985f106cf 
  ksmserver/screenlocker/kcm/kcm.h 6741e47f81da4d92b9f43587f8372b05949433e4 
  ksmserver/screenlocker/kcm/kcm.cpp 28f5e35076aedf9c278c11c193895e2535c6c786 
  ksmserver/screenlocker/kcm/kcm.ui 71d2cb0a9c707d7da178d96cc64dfff4ed7fc9a3 

Diff: https://git.reviewboard.kde.org/r/122512/diff/


Testing
---


File Attachments


KCM with new item
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/10/e5030d5e-2662-4458-8bc2-97ed95b43794__missing-tasks-applet1.png


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122558: [screenlocker] Also grab XInput2 devices

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122558/
---

(Updated Feb. 19, 2015, 1:10 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Bugs: 341469
https://bugs.kde.org/show_bug.cgi?id=341469


Repository: plasma-workspace


Description
---

With XInput2 it's possible that multiple pairs of keyboard and pointers
are connected. As the lock screen only grabbed keyboard and pointer using
the core protocol any additional input devices were still reporting
input events to non-lockscreen windows creating the risk of interaction
with the system and accidentially typing a password where it doesn't
belong.

This change ensures that all additional master devices are also grabbed.
Unfortunately there are no xcb bindings for xinput2 (considered
experimental and thus not build on at least all debian based distros)
and because of that the XLib library is used. This brings some problems
as we cannot process the events (for that we would need xcb bindings,
to get the events). To still be able to get any keyboard and mouse events
we grab using the core protocol as it used to be and then ignore the
"Virtual core" devices and don't grab them with XInput2. Input events
from additional devices are grabbed and ignored, but definately no longer
delivered to other windows.

BUG: 341469
FIXED-IN: 5.3.0


Diffs
-

  ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 
  ksmserver/screenlocker/ksldapp.h 7a32fb11486ecd97fc022a2ce97e820b90f31394 
  CMakeLists.txt dc5e7a050b47cbf61f654f2a28e265c69cb53c26 
  config-X11.h.cmake ee5183a6329aac3120675766ff8a336055c07e9b 
  ksmserver/screenlocker/CMakeLists.txt 
12c1603a89af25182cde771775f5dec35494a7e5 

Diff: https://git.reviewboard.kde.org/r/122558/diff/


Testing
---

Use "xinput create-master foo" and "xinput reattach" to create a second pair of 
input devices. Test that without the change the second keyboard prints to a 
konsole while the screen is locked, verified with the change that the input 
events are no longer going to the konsole


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122382: [klipper] Sync history to disk after each change

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122382/
---

(Updated Feb. 19, 2015, 1:09 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Eike Hein.


Bugs: 34
https://bugs.kde.org/show_bug.cgi?id=34


Repository: plasma-workspace


Description
---

By invoking saveHistory after each change we ensure that the clipboard
doesn't lose data in case klipper (or in dataengine mode plasmashell)
crashes.

To not cause stalls, the saving is performed in a thread using
QtConcurrentRun. As klipper itself is not thread save a Mutex is
used to lock changes in the HistoryModel.

BUG: 34
FIXED-IN: 5.3.0


Diffs
-

  klipper/klipper.h 8bb4286f39bb9855602dbe093be90e7a128c7c24 
  klipper/klipper.cpp 6b6d610f2ea4eda962530e2024b1b0a4da06cf7f 
  klipper/CMakeLists.txt 099cb712774c78faf61029e2b1c5706320010ddd 
  klipper/historymodel.h 78f955f0ec4b8f27dbca0573b68691be6a30e3be 
  klipper/historymodel.cpp 51860f6c3aca1022a2b721c27c859fc721915353 

Diff: https://git.reviewboard.kde.org/r/122382/diff/


Testing
---

looked at ~/.local/share/klipper/history2.lst in Okteta, changed clipboard and 
pressed F5 in Okteta. Repeated these steps multiple times.


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121856: KWindowSystem import for KDeclarative

[Martin Gräßlin]

> On Feb. 19, 2015, 8:13 a.m., Martin Gräßlin wrote:
> > src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp, line 152
> > 
> >
> > why is a method needed which wraps QWindow::fromWinId?
> 
> Kai Uwe Broulik wrote:
> So the import is just using QWindow everywhere rather than WId since it 
> has properties and is easier to use from QtQuick imho.
> 
> Martin Gräßlin wrote:
> but why does this need to be exposed here? Why isn't it provided by 
> QWindow itself?
> 
> Kai Uwe Broulik wrote:
> I don't think it's invokable or a slot

is that a reason to workaround Qt's shortcomings in our software? ;-)


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121856/#review76265
---


On Jan. 5, 2015, 11:49 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121856/
> ---
> 
> (Updated Jan. 5, 2015, 11:49 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a thin proxy around KWindowSystem exposing most of its methods to qml 
> via KWindowSystem item in an org.kde.kwindowsystem import.
> 
> It uses QWindow instead of WId parameters so you can just pass a qml Item, 
> such as a Plasma Dialog as parameter for ease of use (and so you cannot mess 
> with others windows without effort, also I don't know what "WId" would 
> translate to anyway). It omits all those methods that return WId/QWindow as I 
> don't know how expensive QWindow::fromWinId is or who takes ownership of it. 
> We need to decide which methods make sense in this import.
> 
> Methods that have signals and don't take parameters are turned into 
> full-fledged properties (like currentDesktop, numberOfDesktops, etc) and the 
> rest stays Q_INVOKABLE.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kwindowsystemplugin/qmldir PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp PRE-CREATION 
>   src/qmlcontrols/CMakeLists.txt 39c39a5 
>   src/qmlcontrols/kwindowsystemplugin/CMakeLists.txt PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.h PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.cpp PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121856/diff/
> 
> 
> Testing
> ---
> 
> The properties work and change accordingly (compositing active signal doesn't 
> seem to be emitted by KWindowSystem in the first place, at least 
> Ctrl+Shift+F12 doesn't make it change), the forceActivateWindow method works 
> for Review 121807
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121856: KWindowSystem import for KDeclarative

[Kai Uwe Broulik]

> On Feb. 19, 2015, 7:13 vorm., Martin Gräßlin wrote:
> > src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp, line 152
> > 
> >
> > why is a method needed which wraps QWindow::fromWinId?
> 
> Kai Uwe Broulik wrote:
> So the import is just using QWindow everywhere rather than WId since it 
> has properties and is easier to use from QtQuick imho.
> 
> Martin Gräßlin wrote:
> but why does this need to be exposed here? Why isn't it provided by 
> QWindow itself?

I don't think it's invokable or a slot


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121856/#review76265
---


On Jan. 5, 2015, 10:49 vorm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121856/
> ---
> 
> (Updated Jan. 5, 2015, 10:49 vorm.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a thin proxy around KWindowSystem exposing most of its methods to qml 
> via KWindowSystem item in an org.kde.kwindowsystem import.
> 
> It uses QWindow instead of WId parameters so you can just pass a qml Item, 
> such as a Plasma Dialog as parameter for ease of use (and so you cannot mess 
> with others windows without effort, also I don't know what "WId" would 
> translate to anyway). It omits all those methods that return WId/QWindow as I 
> don't know how expensive QWindow::fromWinId is or who takes ownership of it. 
> We need to decide which methods make sense in this import.
> 
> Methods that have signals and don't take parameters are turned into 
> full-fledged properties (like currentDesktop, numberOfDesktops, etc) and the 
> rest stays Q_INVOKABLE.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kwindowsystemplugin/qmldir PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp PRE-CREATION 
>   src/qmlcontrols/CMakeLists.txt 39c39a5 
>   src/qmlcontrols/kwindowsystemplugin/CMakeLists.txt PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.h PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.cpp PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121856/diff/
> 
> 
> Testing
> ---
> 
> The properties work and change accordingly (compositing active signal doesn't 
> seem to be emitted by KWindowSystem in the first place, at least 
> Ctrl+Shift+F12 doesn't make it change), the forceActivateWindow method works 
> for Review 121807
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122628: [dataengine/geolocation] Switch to datalocation service provided by Mozilla

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122628/#review76280
---

Ship it!


Others have pointed out some code issues, I haven't found any more.

As to the approach: +2. If memory serves me well, I implemented the hostip 
approach lacking a Free solution at that time. I'm happy that Free service now 
exists, and I'm all for migrating to it. (More so since it's -- again -- 
broken.)

Thanks for looking into it!

- Sebastian Kügler


On Feb. 18, 2015, 2:37 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122628/
> ---
> 
> (Updated Feb. 18, 2015, 2:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The service used so far is broken (doesn't resolve latitude and
> longitude). Which means we need to switch the service to unbreak.
> 
> This change implements support for the Mozilla Location Service [1].
> Advantages are:
> * free
> * open
> * supports wifi based locationing
> * provided by our FLOSS friends
> 
> [1] https://location.services.mozilla.com/
> 
> 
> Diffs
> -
> 
>   dataengines/geolocation/location_ip.h 
> 0a7780c1344c0f48416e524249be6fdada6b9bfd 
>   dataengines/geolocation/location_ip.cpp 
> 1be2acd9478fceafa83896c552e7a3177368b194 
> 
> Diff: https://git.reviewboard.kde.org/r/122628/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121856: KWindowSystem import for KDeclarative

[Martin Gräßlin]

> On Feb. 19, 2015, 8:13 a.m., Martin Gräßlin wrote:
> > src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp, line 152
> > 
> >
> > why is a method needed which wraps QWindow::fromWinId?
> 
> Kai Uwe Broulik wrote:
> So the import is just using QWindow everywhere rather than WId since it 
> has properties and is easier to use from QtQuick imho.

but why does this need to be exposed here? Why isn't it provided by QWindow 
itself?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121856/#review76265
---


On Jan. 5, 2015, 11:49 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121856/
> ---
> 
> (Updated Jan. 5, 2015, 11:49 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a thin proxy around KWindowSystem exposing most of its methods to qml 
> via KWindowSystem item in an org.kde.kwindowsystem import.
> 
> It uses QWindow instead of WId parameters so you can just pass a qml Item, 
> such as a Plasma Dialog as parameter for ease of use (and so you cannot mess 
> with others windows without effort, also I don't know what "WId" would 
> translate to anyway). It omits all those methods that return WId/QWindow as I 
> don't know how expensive QWindow::fromWinId is or who takes ownership of it. 
> We need to decide which methods make sense in this import.
> 
> Methods that have signals and don't take parameters are turned into 
> full-fledged properties (like currentDesktop, numberOfDesktops, etc) and the 
> rest stays Q_INVOKABLE.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kwindowsystemplugin/qmldir PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp PRE-CREATION 
>   src/qmlcontrols/CMakeLists.txt 39c39a5 
>   src/qmlcontrols/kwindowsystemplugin/CMakeLists.txt PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.h PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.cpp PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121856/diff/
> 
> 
> Testing
> ---
> 
> The properties work and change accordingly (compositing active signal doesn't 
> seem to be emitted by KWindowSystem in the first place, at least 
> Ctrl+Shift+F12 doesn't make it change), the forceActivateWindow method works 
> for Review 121807
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121856: KWindowSystem import for KDeclarative

[Kai Uwe Broulik]

> On Feb. 19, 2015, 7:13 vorm., Martin Gräßlin wrote:
> > src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp, line 152
> > 
> >
> > why is a method needed which wraps QWindow::fromWinId?

So the import is just using QWindow everywhere rather than WId since it has 
properties and is easier to use from QtQuick imho.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121856/#review76265
---


On Jan. 5, 2015, 10:49 vorm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121856/
> ---
> 
> (Updated Jan. 5, 2015, 10:49 vorm.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a thin proxy around KWindowSystem exposing most of its methods to qml 
> via KWindowSystem item in an org.kde.kwindowsystem import.
> 
> It uses QWindow instead of WId parameters so you can just pass a qml Item, 
> such as a Plasma Dialog as parameter for ease of use (and so you cannot mess 
> with others windows without effort, also I don't know what "WId" would 
> translate to anyway). It omits all those methods that return WId/QWindow as I 
> don't know how expensive QWindow::fromWinId is or who takes ownership of it. 
> We need to decide which methods make sense in this import.
> 
> Methods that have signals and don't take parameters are turned into 
> full-fledged properties (like currentDesktop, numberOfDesktops, etc) and the 
> rest stays Q_INVOKABLE.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kwindowsystemplugin/qmldir PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp PRE-CREATION 
>   src/qmlcontrols/CMakeLists.txt 39c39a5 
>   src/qmlcontrols/kwindowsystemplugin/CMakeLists.txt PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.h PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.cpp PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121856/diff/
> 
> 
> Testing
> ---
> 
> The properties work and change accordingly (compositing active signal doesn't 
> seem to be emitted by KWindowSystem in the first place, at least 
> Ctrl+Shift+F12 doesn't make it change), the forceActivateWindow method works 
> for Review 121807
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122617: Require Qt 5.4

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122617/
---

(Updated Feb. 19, 2015, 9:57 a.m.)


Status
--

This change has been marked as submitted.


Review request for kwin and Plasma.


Repository: kwin


Description
---

Require Qt 5.4


Diffs
-

  CMakeLists.txt 6dbfcc961fe573c5621670a8cdc08a09ac7a01d9 
  clients/aurorae/src/aurorae.h f6ef39ba2d4b510d3d452dba5b37e34f8a18217e 
  clients/aurorae/src/aurorae.cpp e24687d9cd7ca690d887aba0cd7569db54cbf6cb 
  glxbackend.cpp c97fbee4743f3af239a8d640827113fcd8d04ed5 
  libkwineffects/kwingltexture.cpp ab38883d88045a239daea0d8c7dd1a1ec76ec476 
  workspace.cpp dcf4479f588355635be61bf6dc6957945dd7de3f 

Diff: https://git.reviewboard.kde.org/r/122617/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel