Review Request 122914: Take Shown and Hidden status in account when showing sidebar

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122914/
---

Review request for Plasma.


Bugs: 344795
https://bugs.kde.org/show_bug.cgi?id=344795


Repository: plasma-workspace


Description
---

- if clicked on arrow show sidebar
- if clicked on always hidden applet show sidebar
- if clicked on always shown applet hide sidebar
- in case of passive applet show sidebar


Diffs
-

  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml 0b9f96f 

Diff: https://git.reviewboard.kde.org/r/122914/diff/


Testing
---

Checked all cases


Thanks,

Bhushan Shah

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [plasma-devel] Re: [Kde-hardware-devel] solid bugzilla product marked obsolete

[Jonathan Riddell]

On Thu, Mar 12, 2015 at 12:39:30AM +0100, David Edmundson wrote:
>On Thu, Mar 12, 2015 at 12:37 AM, Lamarque Souza  wrote:
> 
>  Hi all,A 
>  Following the obsolete action, could someone mark "Network Management"
>  product as obsolete too? It is related to old Plasma NM 0.9.0.x series,
>  which is now unmaintained.
> 
>I've removed "open for bugs" option on that product.

Ah you beat me to it :)

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: solid bugzilla product marked obsolete

[Jonathan Riddell]

"Network Management" product is already closed for new bugs and the description 
points to "plasma-nm" product.

Jonathan


On Wed, Mar 11, 2015 at 08:37:50PM -0300, Lamarque Souza wrote:
>Hi all,A 
>Following the obsolete action, could someone mark "Network Management"
>product as obsolete too? It is related to old Plasma NM 0.9.0.x series,
>which is now unmaintained.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [Kde-hardware-devel] solid bugzilla product marked obsolete

[David Edmundson]

On Thu, Mar 12, 2015 at 12:37 AM, Lamarque Souza  wrote:

> Hi all,
>
> Following the obsolete action, could someone mark "Network Management"
> product as obsolete too? It is related to old Plasma NM 0.9.0.x series,
> which is now unmaintained.
>
> I've removed "open for bugs" option on that product.

Thanks



> Lamarque V. Souza
>
> KDE's Network Management maintainer
>
> http://planetkde.org/pt-br
>
> On Wed, Mar 11, 2015 at 7:57 PM, Albert Astals Cid  wrote:
>
>> El Dimecres, 11 de març de 2015, a les 20:24:00, Jonathan Riddell va
>> escriure:
>> > I've labelled the solid bugzilla product as obsolete and added a
>> comment to
>> > any bugs that it's for kdelibs4 code which is now in maintenance mode.
>> > Replacement products are bluedevil, powerdevil, plasma-nm and
>> > frameworks-solid.
>>
>> You forgot to email kde-hardware-de...@kde.org
>>
>> >
>> > Jonathan
>>
>> ___
>> Kde-hardware-devel mailing list
>> kde-hardware-de...@kde.org
>> https://mail.kde.org/mailman/listinfo/kde-hardware-devel
>>
>
>
> ___
> Kde-frameworks-devel mailing list
> kde-frameworks-de...@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [Kde-hardware-devel] solid bugzilla product marked obsolete

[Lamarque Souza]

Hi all,

Following the obsolete action, could someone mark "Network Management"
product as obsolete too? It is related to old Plasma NM 0.9.0.x series,
which is now unmaintained.

Lamarque V. Souza

KDE's Network Management maintainer

http://planetkde.org/pt-br

On Wed, Mar 11, 2015 at 7:57 PM, Albert Astals Cid  wrote:

> El Dimecres, 11 de març de 2015, a les 20:24:00, Jonathan Riddell va
> escriure:
> > I've labelled the solid bugzilla product as obsolete and added a comment
> to
> > any bugs that it's for kdelibs4 code which is now in maintenance mode.
> > Replacement products are bluedevil, powerdevil, plasma-nm and
> > frameworks-solid.
>
> You forgot to email kde-hardware-de...@kde.org
>
> >
> > Jonathan
>
> ___
> Kde-hardware-devel mailing list
> kde-hardware-de...@kde.org
> https://mail.kde.org/mailman/listinfo/kde-hardware-devel
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: solid bugzilla product marked obsolete

[Albert Astals Cid]

El Dimecres, 11 de març de 2015, a les 20:24:00, Jonathan Riddell va escriure:
> I've labelled the solid bugzilla product as obsolete and added a comment to
> any bugs that it's for kdelibs4 code which is now in maintenance mode.
> Replacement products are bluedevil, powerdevil, plasma-nm and
> frameworks-solid.

You forgot to email kde-hardware-de...@kde.org

> 
> Jonathan

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122332: KQuickControls IconDialog

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122332/
---

(Updated März 11, 2015, 10:46 nachm.)


Review request for Plasma and Daniel Vrátil.


Changes
---

Call winId() to ensure the windowHandle is there. WindowModality works properly 
now.


Repository: kdeclarative


Description
---

This patch adds KQuickControls wrapper around KIconDialog similar to how the 
ColorDialog and other QtQuick Dialogs work. This can be used, for instance, in 
Kickoff's config UI to provide a picker for a custom item.

It is an initial draft and lacks for example window modality as I couldn't 
figure out how QtQuick Dialogs do that (some PlatformDialogHelper magic inside) 
and I'm also not sure about the lifecycle/ownership of the dialog, I've seen a 
lot of fixes for issues in that area on Review Board.


Diffs (updated)
-

  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt d5713a0 
  src/qmlcontrols/kquickcontrolsaddons/icondialog.h PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp cee2360 

Diff: https://git.reviewboard.kde.org/r/122332/diff/


Testing
---

For testing I added a button to Kickoff that allows to open the dialog and the 
button icon source is bound to the dialog's iconName property. Didn't test the 
icon source/user/custom path stuff.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

solid bugzilla product marked obsolete

[Jonathan Riddell]

I've labelled the solid bugzilla product as obsolete and added a comment to
any bugs that it's for kdelibs4 code which is now in maintenance mode.
Replacement products are bluedevil, powerdevil, plasma-nm and
frameworks-solid.

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122842: Allow selecting notifications position on screen

[Kai Uwe Broulik]

> On März 11, 2015, 6:46 nachm., Kai Uwe Broulik wrote:
> > applets/notifications/package/contents/ui/ScreenPositionSelector.qml, line 
> > 37
> > 
> >
> > Default init it to [] in case somebody forgets to assign to it

For the case it becomes a shared component :)


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/#review77312
---


On März 11, 2015, 6:09 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122842/
> ---
> 
> (Updated März 11, 2015, 6:09 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 344841
> https://bugs.kde.org/show_bug.cgi?id=344841
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Allows to select each corner and top or bottom edges of the screen.
> 
> The radio selection thing is currently a bit ugly and I'd like to ask for 
> suggestions on it (I originally wanted to add VDG here but there's no vdg 
> group (?) so I'll post in the forums).
> 
> 
> Diffs
> -
> 
>   applets/notifications/package/contents/config/main.xml 6e55fe8 
>   applets/notifications/package/contents/ui/Notifications.qml 4312774 
>   applets/notifications/package/contents/ui/ScreenPositionSelector.qml 
> PRE-CREATION 
>   applets/notifications/package/contents/ui/configNotifications.qml cda9ac9 
>   applets/notifications/plugin/notificationshelper.h ca0b63b 
>   applets/notifications/plugin/notificationshelper.cpp e7c4e29 
> 
> Diff: https://git.reviewboard.kde.org/r/122842/diff/
> 
> 
> Testing
> ---
> 
> All positions work
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/06/f80f9345-3d5f-49b4-83d7-16ecbfbc607a__notification_pos.png
> New Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/11/e1fd3405-b008-4d6e-90c7-2000ab011008__notifications_config.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122842: Allow selecting notifications position on screen

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/#review77312
---



applets/notifications/package/contents/ui/ScreenPositionSelector.qml


Default init it to [] in case somebody forgets to assign to it



applets/notifications/package/contents/ui/ScreenPositionSelector.qml


Hardcoded pixel value, here and in other places



applets/notifications/package/contents/ui/ScreenPositionSelector.qml


You could just use binding



applets/notifications/package/contents/ui/ScreenPositionSelector.qml


readonly property?


- Kai Uwe Broulik


On März 11, 2015, 6:09 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122842/
> ---
> 
> (Updated März 11, 2015, 6:09 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 344841
> https://bugs.kde.org/show_bug.cgi?id=344841
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Allows to select each corner and top or bottom edges of the screen.
> 
> The radio selection thing is currently a bit ugly and I'd like to ask for 
> suggestions on it (I originally wanted to add VDG here but there's no vdg 
> group (?) so I'll post in the forums).
> 
> 
> Diffs
> -
> 
>   applets/notifications/package/contents/config/main.xml 6e55fe8 
>   applets/notifications/package/contents/ui/Notifications.qml 4312774 
>   applets/notifications/package/contents/ui/ScreenPositionSelector.qml 
> PRE-CREATION 
>   applets/notifications/package/contents/ui/configNotifications.qml cda9ac9 
>   applets/notifications/plugin/notificationshelper.h ca0b63b 
>   applets/notifications/plugin/notificationshelper.cpp e7c4e29 
> 
> Diff: https://git.reviewboard.kde.org/r/122842/diff/
> 
> 
> Testing
> ---
> 
> All positions work
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/06/f80f9345-3d5f-49b4-83d7-16ecbfbc607a__notification_pos.png
> New Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/11/e1fd3405-b008-4d6e-90c7-2000ab011008__notifications_config.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122842: Allow selecting notifications position on screen

[Martin Klapetek]

> On March 11, 2015, 7:06 p.m., Kai Uwe Broulik wrote:
> > PlasmaExtra components maybe? I'm still unsure about the notifications on a 
> > per-applet basis :/

We could make them share the config?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/#review77310
---


On March 11, 2015, 7:09 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122842/
> ---
> 
> (Updated March 11, 2015, 7:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 344841
> https://bugs.kde.org/show_bug.cgi?id=344841
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Allows to select each corner and top or bottom edges of the screen.
> 
> The radio selection thing is currently a bit ugly and I'd like to ask for 
> suggestions on it (I originally wanted to add VDG here but there's no vdg 
> group (?) so I'll post in the forums).
> 
> 
> Diffs
> -
> 
>   applets/notifications/package/contents/config/main.xml 6e55fe8 
>   applets/notifications/package/contents/ui/Notifications.qml 4312774 
>   applets/notifications/package/contents/ui/ScreenPositionSelector.qml 
> PRE-CREATION 
>   applets/notifications/package/contents/ui/configNotifications.qml cda9ac9 
>   applets/notifications/plugin/notificationshelper.h ca0b63b 
>   applets/notifications/plugin/notificationshelper.cpp e7c4e29 
> 
> Diff: https://git.reviewboard.kde.org/r/122842/diff/
> 
> 
> Testing
> ---
> 
> All positions work
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/06/f80f9345-3d5f-49b4-83d7-16ecbfbc607a__notification_pos.png
> New Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/11/e1fd3405-b008-4d6e-90c7-2000ab011008__notifications_config.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122842: Allow selecting notifications position on screen

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/#review77310
---


PlasmaExtra components maybe? I'm still unsure about the notifications on a 
per-applet basis :/

- Kai Uwe Broulik


On März 11, 2015, 5:55 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122842/
> ---
> 
> (Updated März 11, 2015, 5:55 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 344841
> https://bugs.kde.org/show_bug.cgi?id=344841
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Allows to select each corner and top or bottom edges of the screen.
> 
> The radio selection thing is currently a bit ugly and I'd like to ask for 
> suggestions on it (I originally wanted to add VDG here but there's no vdg 
> group (?) so I'll post in the forums).
> 
> 
> Diffs
> -
> 
>   applets/notifications/package/contents/config/main.xml 6e55fe8 
>   applets/notifications/package/contents/ui/Notifications.qml 4312774 
>   applets/notifications/package/contents/ui/configNotifications.qml cda9ac9 
>   applets/notifications/plugin/notificationshelper.h ca0b63b 
>   applets/notifications/plugin/notificationshelper.cpp e7c4e29 
> 
> Diff: https://git.reviewboard.kde.org/r/122842/diff/
> 
> 
> Testing
> ---
> 
> All positions work
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/06/f80f9345-3d5f-49b4-83d7-16ecbfbc607a__notification_pos.png
> New Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/11/e1fd3405-b008-4d6e-90c7-2000ab011008__notifications_config.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122842: Allow selecting notifications position on screen

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/
---

(Updated March 11, 2015, 6:55 p.m.)


Review request for Plasma.


Changes
---

Changes:
 * standalone component
 * uses the same graphics that screen edges effect uses (as suggested by Martin 
G)

Question:
 I'd like the enum to put somewhere in Plasma so that the component can be 
shared properly, suggestions?


Bugs: 344841
https://bugs.kde.org/show_bug.cgi?id=344841


Repository: plasma-workspace


Description
---

Allows to select each corner and top or bottom edges of the screen.

The radio selection thing is currently a bit ugly and I'd like to ask for 
suggestions on it (I originally wanted to add VDG here but there's no vdg group 
(?) so I'll post in the forums).


Diffs (updated)
-

  applets/notifications/package/contents/config/main.xml 6e55fe8 
  applets/notifications/package/contents/ui/Notifications.qml 4312774 
  applets/notifications/package/contents/ui/configNotifications.qml cda9ac9 
  applets/notifications/plugin/notificationshelper.h ca0b63b 
  applets/notifications/plugin/notificationshelper.cpp e7c4e29 

Diff: https://git.reviewboard.kde.org/r/122842/diff/


Testing
---

All positions work


File Attachments (updated)


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/06/f80f9345-3d5f-49b4-83d7-16ecbfbc607a__notification_pos.png
New Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/11/e1fd3405-b008-4d6e-90c7-2000ab011008__notifications_config.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Change in plasma-framework[master]: Fix segfault in KWin when all screens disappear

[Code Review]

Jan Kundrát has uploaded a new change for review.

  https://gerrit.vesnicky.cesnet.cz/r/415

Change subject: Fix segfault in KWin when all screens disappear
..

Fix segfault in KWin when all screens disappear

This is due to changes in Qt 5.5; they now attempt to gracefully handle
a situation where all screens disappear, e.g., when user disables all
outputs via xrandr. Without this patch (and with [1] and [2] in place),
here's how KWin ended up:

 #0  xcb_send_request (c=0x0, flags=flags@entry=0, 
vector=vector@entry=0x7ffce7a537d0, req=req@entry=0x7f3d1c55bb60 )
 at 
/var/tmp/portage/x11-libs/libxcb-1.11-r1/work/libxcb-1.11/src/xcb_out.c:187
 #1  0x7f3d1c54f29f in xcb_list_properties_unchecked (c=, 
window=) at xproto.c:2650
 #2  0x7f3d1a18285d in Plasma::EffectWatcher::isEffectActive 
(this=this@entry=0x7f3d1f1be290)
 at 
/var/tmp/portage/kde-frameworks/plasma-5.7.0/work/plasma-framework-5.7.0/src/plasma/private/effectwatcher.cpp:91
 #3  0x7f3d1a1829a9 in isEffectActive (this=0x7f3d1f1be290) at 
/var/tmp/portage/kde-frameworks/plasma-5.7.0/work/plasma-framework-5.7.0/src/plasma/private/effectwatcher.cpp:79
 #4  Plasma::EffectWatcher::nativeEventFilter (this=0x7f3d1f1be290, 
eventType=..., message=0x7f3d04005160, result=)
 at 
/var/tmp/portage/kde-frameworks/plasma-5.7.0/work/plasma-framework-5.7.0/src/plasma/private/effectwatcher.cpp:76
 #5  0x7f3d1ca3aa8a in QAbstractEventDispatcher::filterNativeEvent 
(this=, eventType=..., message=message@entry=0x7f3d04005160, 
result=result@entry=0x7ffce7a538e8)
 at 
/var/tmp/portage/dev-qt/qtcore-5.5./work/qtcore-5.5./src/corelib/kernel/qabstracteventdispatcher.cpp:460
 #6  0x7f3d0c6d6951 in QXcbConnection::handleXcbEvent 
(this=this@entry=0x7f3d1f13c5a0, event=event@entry=0x7f3d04005160)
 at 
/var/tmp/portage/dev-qt/qtgui-5.5./work/qtgui-5.5./src/plugins/platforms/xcb/qxcbconnection.cpp:971
 #7  0x7f3d0c6d89b3 in QXcbConnection::processXcbEvents 
(this=0x7f3d1f13c5a0) at 
/var/tmp/portage/dev-qt/qtgui-5.5./work/qtgui-5.5./src/plugins/platforms/xcb/qxcbconnection.cpp:1376
 #8  0x7f3d1ca77c86 in QObject::event (this=0x7f3d1f13c5a0, e=) at 
/var/tmp/portage/dev-qt/qtcore-5.5./work/qtcore-5.5./src/corelib/kernel/qobject.cpp:1246
 #9  0x7f3d1d391ddc in QApplicationPrivate::notify_helper 
(this=this@entry=0x7f3d1f135000, receiver=receiver@entry=0x7f3d1f13c5a0, 
e=e@entry=0x7f3d040051d0)
 at 
/var/tmp/portage/dev-qt/qtwidgets-5.5./work/qtwidgets-5.5./src/widgets/kernel/qapplication.cpp:3716
 #10 0x7f3d1d3977ba in QApplication::notify (this=0x7ffce7a540b0, 
receiver=0x7f3d1f13c5a0, e=0x7f3d040051d0)
 at 
/var/tmp/portage/dev-qt/qtwidgets-5.5./work/qtwidgets-5.5./src/widgets/kernel/qapplication.cpp:3499
 #11 0x7f3d1ca3e9cd in QCoreApplication::notifyInternal 
(this=0x7ffce7a540b0, receiver=0x7f3d1f13c5a0, event=event@entry=0x7f3d040051d0)
 at 
/var/tmp/portage/dev-qt/qtcore-5.5./work/qtcore-5.5./src/corelib/kernel/qcoreapplication.cpp:963
 #12 0x7f3d1ca4142b in sendEvent (event=0x7f3d040051d0, receiver=) at 
/var/tmp/portage/dev-qt/qtcore-5.5./work/qtcore-5.5./src/corelib/kernel/qcoreapplication.h:228
 #13 QCoreApplicationPrivate::sendPostedEvents (receiver=receiver@entry=0x0, 
event_type=event_type@entry=0, data=0x7f3d1f126340)
 at 
/var/tmp/portage/dev-qt/qtcore-5.5./work/qtcore-5.5./src/corelib/kernel/qcoreapplication.cpp:1580
 #14 0x7f3d1caa343a in QEventDispatcherUNIX::processEvents 
(this=0x7f3d1f15ea90, flags=flags@entry=...)
 at 
/var/tmp/portage/dev-qt/qtcore-5.5./work/qtcore-5.5./src/corelib/kernel/qeventdispatcher_unix.cpp:579
 #15 0x7f3d0c7160a0 in QUnixEventDispatcherQPA::processEvents 
(this=, flags=...)
 at 
/var/tmp/portage/dev-qt/qtgui-5.5./work/qtgui-5.5./src/platformsupport/eventdispatchers/qunixeventdispatcher.cpp:62
 #16 0x7f3d1ca3be4b in QEventLoop::exec (this=this@entry=0x7ffce7a53fa0, 
flags=..., flags@entry=...)
 at 
/var/tmp/portage/dev-qt/qtcore-5.5./work/qtcore-5.5./src/corelib/kernel/qeventloop.cpp:204
 #17 0x7f3d1ca4521e in QCoreApplication::exec () at 
/var/tmp/portage/dev-qt/qtcore-5.5./work/qtcore-5.5./src/corelib/kernel/qcoreapplication.cpp:1216
 #18 0x7f3d1cd90a0a in QGuiApplication::exec () at 
/var/tmp/portage/dev-qt/qtgui-5.5./work/qtgui-5.5./src/gui/kernel/qguiapplication.cpp:1522
 #19 0x7f3d1d38db8b in QApplication::exec () at 
/var/tmp/portage/dev-qt/qtwidgets-5.5./work/qtwidgets-5.5./src/widgets/kernel/qapplication.cpp:2976
 #20 0x7f3d1e5c4bcf in kdemain (argc=2, argv=0x7ffce7a54208) at 
/var/tmp/portage/kde-plasma/kwin-5.2./work/kwin-5.2./main_x11.cpp:294
 #21 0x7f3d1e23f9f5 in __libc_start_main (main=0x7f3d1e9eb9a0 , argc=2, argv=0x7ffce7a54208, init=, fini=, rtld_fini=,
 stack_end=0x7ffce7a541f8) at libc-start.

Re: Review Request 122886: QML-only KCM base

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/
---

(Updated March 11, 2015, 5:05 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: kdeclarative


Description
---

This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
more declarative friendly.
it loads a qml file that then will be able to access its instance as "kcm" or 
as the "KCM" attached property, like what happens in plasmoids (for how 
attached proeprties work, unfortunately only properties of the base class will 
be accessible).
They will be loaded in systemsettings by review 122887


Diffs (updated)
-

  src/quickaddons/CMakeLists.txt 3c7a34b 
  src/quickaddons/configmodule.h PRE-CREATION 
  src/quickaddons/configmodule.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122886/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma Bugs

[David Rosca]

Hi Jonathan,

On Wed, Mar 11, 2015 at 3:29 PM, Jonathan Riddell  wrote:
>
>
> solid is a strange product in bugzilla which covers everything that
> has ever been solid (bluetooth, libsolid, networkmanager, powerdevil).
> Everything has newer products, should I kill it closing all the bugs
> and create a new product for bluedevil?

+1 from me. I think it will also be easier for users when reporting bugs
from site, so they don't need to look under solid.

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122886: QML-only KCM base

[Hrvoje Senjan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77309
---



src/quickaddons/CMakeLists.txt


you need also KF5::Auth as public, the new public header has a kauthaction 
include


- Hrvoje Senjan


On March 10, 2015, 12:28 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122886/
> ---
> 
> (Updated March 10, 2015, 12:28 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
> more declarative friendly.
> it loads a qml file that then will be able to access its instance as "kcm" or 
> as the "KCM" attached property, like what happens in plasmoids (for how 
> attached proeprties work, unfortunately only properties of the base class 
> will be accessible).
> They will be loaded in systemsettings by review 122887
> 
> 
> Diffs
> -
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b 
>   src/quickaddons/configmodule.h PRE-CREATION 
>   src/quickaddons/configmodule.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122886/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122886: QML-only KCM base

[David Edmundson]

> On March 11, 2015, 2:07 p.m., David Edmundson wrote:
> > src/quickaddons/configmodule.cpp, line 102
> > 
> >
> > when combined with your other KCModule patch you have a crash.
> > 
> > From KCModule docs:
> > This sets the KAboutData returned by aboutData() The about data is now 
> > owned by KCModule.
> > 
> > So this will result in a double delete.
> > Same for the delete in setAboutData.
> 
> Marco Martin wrote:
> hmm, would work actually creating a copy of this about data in the 
> wrapper class?
> 
> David Edmundson wrote:
> Yeah, I think that would work.
> 
> Marco Martin wrote:
> thinking about it i'm not sure about the double delete (i don't get a 
> crash after all) since KCModuleQml never gets an aboutdata by its own but 
> just returns this class instance in the reimplementation of virtual 
> aboutData() (so the KCModule instance never gets a valid d->_aboutData), 
> opposed to do a setAboutData(d->configModule->aboutData()) in which would 
> definitely crash

oh, you're right. I got confused as we were signally and proxying everything 
else.
You can close this.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77304
---


On March 10, 2015, 11:28 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122886/
> ---
> 
> (Updated March 10, 2015, 11:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
> more declarative friendly.
> it loads a qml file that then will be able to access its instance as "kcm" or 
> as the "KCM" attached property, like what happens in plasmoids (for how 
> attached proeprties work, unfortunately only properties of the base class 
> will be accessible).
> They will be loaded in systemsettings by review 122887
> 
> 
> Diffs
> -
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b 
>   src/quickaddons/configmodule.h PRE-CREATION 
>   src/quickaddons/configmodule.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122886/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122886: QML-only KCM base

[Marco Martin]

> On March 11, 2015, 2:07 p.m., David Edmundson wrote:
> > src/quickaddons/configmodule.cpp, line 102
> > 
> >
> > when combined with your other KCModule patch you have a crash.
> > 
> > From KCModule docs:
> > This sets the KAboutData returned by aboutData() The about data is now 
> > owned by KCModule.
> > 
> > So this will result in a double delete.
> > Same for the delete in setAboutData.
> 
> Marco Martin wrote:
> hmm, would work actually creating a copy of this about data in the 
> wrapper class?
> 
> David Edmundson wrote:
> Yeah, I think that would work.

thinking about it i'm not sure about the double delete (i don't get a crash 
after all) since KCModuleQml never gets an aboutdata by its own but just 
returns this class instance in the reimplementation of virtual aboutData() (so 
the KCModule instance never gets a valid d->_aboutData), opposed to do a 
setAboutData(d->configModule->aboutData()) in which would definitely crash


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77304
---


On March 10, 2015, 11:28 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122886/
> ---
> 
> (Updated March 10, 2015, 11:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
> more declarative friendly.
> it loads a qml file that then will be able to access its instance as "kcm" or 
> as the "KCM" attached property, like what happens in plasmoids (for how 
> attached proeprties work, unfortunately only properties of the base class 
> will be accessible).
> They will be loaded in systemsettings by review 122887
> 
> 
> Diffs
> -
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b 
>   src/quickaddons/configmodule.h PRE-CREATION 
>   src/quickaddons/configmodule.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122886/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122886: QML-only KCM base

[David Edmundson]

> On March 11, 2015, 2:07 p.m., David Edmundson wrote:
> > src/quickaddons/configmodule.cpp, line 102
> > 
> >
> > when combined with your other KCModule patch you have a crash.
> > 
> > From KCModule docs:
> > This sets the KAboutData returned by aboutData() The about data is now 
> > owned by KCModule.
> > 
> > So this will result in a double delete.
> > Same for the delete in setAboutData.
> 
> Marco Martin wrote:
> hmm, would work actually creating a copy of this about data in the 
> wrapper class?

Yeah, I think that would work.


> On March 11, 2015, 2:07 p.m., David Edmundson wrote:
> > src/quickaddons/configmodule.h, line 338
> > 
> >
> > This documentation tells me nothing, and I'm not sure what this does 
> > from the method name.
> 
> Marco Martin wrote:
> eh, I have no idea about this method as well :/
> it's a thing exported by KCModule, so here just wrapping it.
> it's presumably used for some reason, somewhere, but even from the code 
> it's not understandable.
> on lxr, seems the only place where is used is KInfoCenter
> 
> http://lxr.kde.org/source/kde/workspace/kinfocenter/infocenter.cpp?v=kf5-qt5
> 
> (may be worth even just dumping it...)

++ for killing it here. 
Then it becomes not our problem :D


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77304
---


On March 10, 2015, 11:28 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122886/
> ---
> 
> (Updated March 10, 2015, 11:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
> more declarative friendly.
> it loads a qml file that then will be able to access its instance as "kcm" or 
> as the "KCM" attached property, like what happens in plasmoids (for how 
> attached proeprties work, unfortunately only properties of the base class 
> will be accessible).
> They will be loaded in systemsettings by review 122887
> 
> 
> Diffs
> -
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b 
>   src/quickaddons/configmodule.h PRE-CREATION 
>   src/quickaddons/configmodule.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122886/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122886: QML-only KCM base

[David Edmundson]

> On March 10, 2015, 11:33 a.m., Marco Martin wrote:
> > src/quickaddons/configmodule.cpp, line 167
> > 
> >
> > I didn't test things that need authentication yet (if some good soul 
> > ports a module that uses it would be great)
> > but seems there may be a problem here due to KAuth assuming QWidgets

This is for a custom KDE extension to polkit setWIdForAction that tells the KDE 
polkit agent which window is about to trigger an action so that the window 
manager can do something sensible wrt to focus. So it's not super criticial.

It's also fixable, KAuth only uses it for a window ID, so we can add a QWindow/

Right now it's not a problem, as when used via KCModuleQml, it will call 
KCModule::setAuthAction which changes the parent widget anyway.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77248
---


On March 10, 2015, 11:28 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122886/
> ---
> 
> (Updated March 10, 2015, 11:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
> more declarative friendly.
> it loads a qml file that then will be able to access its instance as "kcm" or 
> as the "KCM" attached property, like what happens in plasmoids (for how 
> attached proeprties work, unfortunately only properties of the base class 
> will be accessible).
> They will be loaded in systemsettings by review 122887
> 
> 
> Diffs
> -
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b 
>   src/quickaddons/configmodule.h PRE-CREATION 
>   src/quickaddons/configmodule.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122886/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122887: Load and wrap the QML-only version of kcms if possible

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122887/
---

(Updated March 11, 2015, 1:46 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: kcmutils


Description
---

This makes KCMLoader try to load the qobject-only, qml based kcms as well, if 
it succeeds it wraps them in the KCModuleQML KCModule subclass and returns it 
as loaded module (the class itself is not exported, so no new symbols).
This makes systemsettings, kcmshell and any config dialog that loads kcms 
transparently load those config modules not based upon KCModule


Diffs (updated)
-

  CMakeLists.txt cb4ae5d 
  src/CMakeLists.txt f7b869f 
  src/kcmoduleloader.cpp 5ccf236 
  src/kcmoduleqml.cpp PRE-CREATION 
  src/kcmoduleqml_p.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122887/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122887: Load and wrap the QML-only version of kcms if possible

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122887/#review77299
---


+1 looks good to me.


src/kcmoduleqml.cpp


could you add a comment that
QWidget::createWindowContainer takes ownership of the window



src/kcmoduleqml_p.h


Q_DECL_OVERRIDE *4


- David Edmundson


On March 10, 2015, 11:28 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122887/
> ---
> 
> (Updated March 10, 2015, 11:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kcmutils
> 
> 
> Description
> ---
> 
> This makes KCMLoader try to load the qobject-only, qml based kcms as well, if 
> it succeeds it wraps them in the KCModuleQML KCModule subclass and returns it 
> as loaded module (the class itself is not exported, so no new symbols).
> This makes systemsettings, kcmshell and any config dialog that loads kcms 
> transparently load those config modules not based upon KCModule
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt cb4ae5d 
>   src/CMakeLists.txt f7b869f 
>   src/kcmoduleloader.cpp 5ccf236 
>   src/kcmoduleqml.cpp PRE-CREATION 
>   src/kcmoduleqml_p.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122887/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Plasma Bugs

[David Edmundson]

All plasmashell bugs are now set up to CC plasma-bugs as discussed at the
sprint as some maintainers weren't doing a very good job of keeping on top
of things.

You can subscribe here.
https://mail.kde.org/mailman/listinfo/plasma-bugs

You can also choose to follow the plasma-bugs bugzilla user by going to
bugs.kde.org -> preferences -> email -> user watching which has the same
effect.

This reduces duplicates if you are in the CC list for a bug anyway.

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122899: Set directory mimetype for smb protocol

[Rajeesh K Nambiar]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122899/
---

(Updated March 11, 2015, 10:32 a.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: kio-extras


Description
---

Browsing samba shares using Dolphin doesn't show directory icons properly. This 
is due to missing mimetype in UDSEntry. Set the mimetype "inode/directory" for 
directories.


Diffs
-

  smb/kio_smb_browse.cpp 67e2fa0 

Diff: https://git.reviewboard.kde.org/r/122899/diff/


Testing
---

Tested with kio-extras 5.2.1. See attached before and after screenshots of 
Dolphin.


File Attachments


samba folder before
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/3ae0a08d-d247-4686-a44b-73b6043cbb57__smb-folder-before.png
samba folder after
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/a446c555-e947-42a9-80c0-b5ec18a2ba61__smb-folder-after.png


Thanks,

Rajeesh K Nambiar

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122899: Set directory mimetype for smb protocol

[Rajeesh K Nambiar]

> On March 11, 2015, 9:35 a.m., Emmanuel Pescosta wrote:
> > -1 from my side
> > 
> > This problem should be fixed by https://git.reviewboard.kde.org/r/121447/, 
> > please test it with the latest KIO release.

It is certainly better to have this functionality added in KIO core. Discarding 
this review in favour of review 121447.


- Rajeesh


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122899/#review77289
---


On March 10, 2015, 10:18 p.m., Rajeesh K Nambiar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122899/
> ---
> 
> (Updated March 10, 2015, 10:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> Browsing samba shares using Dolphin doesn't show directory icons properly. 
> This is due to missing mimetype in UDSEntry. Set the mimetype 
> "inode/directory" for directories.
> 
> 
> Diffs
> -
> 
>   smb/kio_smb_browse.cpp 67e2fa0 
> 
> Diff: https://git.reviewboard.kde.org/r/122899/diff/
> 
> 
> Testing
> ---
> 
> Tested with kio-extras 5.2.1. See attached before and after screenshots of 
> Dolphin.
> 
> 
> File Attachments
> 
> 
> samba folder before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/3ae0a08d-d247-4686-a44b-73b6043cbb57__smb-folder-before.png
> samba folder after
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/a446c555-e947-42a9-80c0-b5ec18a2ba61__smb-folder-after.png
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

plasma wallpapers

[kainz.a]

Hi plasma developers,

I'm part of the VDG and do some artwork for the Breeze icon set.

Plasma 5.1 and 5.2 has a new wallpaper but only one. I would like to see
some nice wallpapers for 5.3 in other areas.

There was a nice weather wallpaper app in kde 4, I think it wasn't ported
but for this there were never realy usefull wallpapers. In addition there
should be also wallpapers for more categories.

I ask the digikam developers cause they are the picture guys for help and
they say ask on Google+ than you will find enough contributors, we will
also support you.

My question was:
- Can I start a Wallpaper contest for the plasma team to have additional
standard wallpapers in plasma 5.3.


I will make an plog post,  You can select the best images for your
wallpaper package.

Cheers
Andreas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122899: Set directory mimetype for smb protocol

[Emmanuel Pescosta]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122899/#review77289
---


-1 from my side

This problem should be fixed by https://git.reviewboard.kde.org/r/121447/, 
please test it with the latest KIO release.

- Emmanuel Pescosta


On March 10, 2015, 11:18 p.m., Rajeesh K Nambiar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122899/
> ---
> 
> (Updated March 10, 2015, 11:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> Browsing samba shares using Dolphin doesn't show directory icons properly. 
> This is due to missing mimetype in UDSEntry. Set the mimetype 
> "inode/directory" for directories.
> 
> 
> Diffs
> -
> 
>   smb/kio_smb_browse.cpp 67e2fa0 
> 
> Diff: https://git.reviewboard.kde.org/r/122899/diff/
> 
> 
> Testing
> ---
> 
> Tested with kio-extras 5.2.1. See attached before and after screenshots of 
> Dolphin.
> 
> 
> File Attachments
> 
> 
> samba folder before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/3ae0a08d-d247-4686-a44b-73b6043cbb57__smb-folder-before.png
> samba folder after
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/a446c555-e947-42a9-80c0-b5ec18a2ba61__smb-folder-after.png
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122885: Adapt to KDecoration API changes

[Mika Allan Rauhala]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122885/
---

(Updated maalis 11, 2015, 9:38 ap)


Status
--

This change has been discarded.


Review request for kwin and Plasma.


Repository: oxygen


Description
---

Adapt to API changes proposed by /r/122882.


Diffs
-

  kdecoration/oxygenbutton.cpp 943b6f7ba1c162ad0fb13674911daf0f12c40966 
  kdecoration/oxygendecoration.cpp c8f3bfc7a378a672101e9e7fe8f08ac98ea2a363 
  kdecoration/oxygensizegrip.cpp 4fbc149efabf8bf2d4821b485fcde5e6c660fd1d 

Diff: https://git.reviewboard.kde.org/r/122885/diff/


Testing
---


Thanks,

Mika Allan Rauhala

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122884: Adapt to KDecoration API changes

[Mika Allan Rauhala]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122884/
---

(Updated maalis 11, 2015, 9:37 ap)


Review request for Plasma.


Changes
---

DecorationColorSettings is now DecorationPalette and inherits from QPalette.


Repository: breeze


Description
---

Adapt to API changes proposed by /r/122882. Breeze::ColorSettings is moved to 
KDecoration. This allows per window color schemes with custom titlebar colors 
to work.


Diffs (updated)
-

  kdecoration/CMakeLists.txt 88b2fc17a55257df1a79434f8f639f360d6325d2 
  kdecoration/breezecolorsettings.h 40e04fb871f552bf31112d02cad86d286aa416c0 
  kdecoration/breezecolorsettings.cpp c52bfbe624fc79842f504a586cee20724b176be4 
  kdecoration/breezedecoration.h ccdc6a67c65aad4a17e083b3f3360fc3cb57ddbc 
  kdecoration/breezedecoration.cpp 5ed41d8e338a8128cf4a5698dcdc2aee2ff01259 

Diff: https://git.reviewboard.kde.org/r/122884/diff/


Testing
---


Thanks,

Mika Allan Rauhala

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel