Build failed in Jenkins: plasma-desktop_master_qt5 #1116
See http://build.kde.org/job/plasma-desktop_master_qt5/1116/changes Changes: [notmart] Port the look and feel KCM to the qml only version -- [...truncated 1707 lines...] [ 49%] Built target folderplugin [ 49%] [ 49%] Building CXX object kcms/autostart/CMakeFiles/kcm_autostart.dir/autostart.cpp.o Building CXX object kcms/ksplash/CMakeFiles/kcm_splashscreen.dir/kcm_splashscreen_automoc.cpp.o Linking CXX executable kcmdatetimehelper [ 49%] Building CXX object kcms/autostart/CMakeFiles/kcm_autostart.dir/kcm_autostart_automoc.cpp.o [ 49%] Building CXX object kcms/input/CMakeFiles/kcm_cursortheme.dir/xcursor/itemdelegate.cpp.o [ 50%] [ 50%] Building CXX object kcms/input/CMakeFiles/kcm_cursortheme.dir/xcursor/sortproxymodel.cpp.o Built target kcmdatetimehelper [ 50%] [ 50%] Generating kwin_interface.cpp, kwin_interface.h Building CXX object kcms/input/CMakeFiles/kcm_cursortheme.dir/__/krdb/krdb.cpp.o [ 50%] Generating kwin_interface.moc Scanning dependencies of target kcm_launch [ 50%] Building CXX object kcms/launch/CMakeFiles/kcm_launch.dir/kcmlaunch.cpp.o http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/autostart/autostart.cpp: In member function ‘void Autostart::slotEditCMD(QTreeWidgetItem*)’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/autostart/autostart.cpp:361:121: warning: ‘KFileItem::KFileItem(mode_t, mode_t, const QUrl, bool)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kio/inst/include/KF5/KIOCore/kfileitem.h:104) [-Wdeprecated-declarations] const KFileItem kfi = KFileItem( KFileItem::Unknown, KFileItem::Unknown, QUrl( desktopEntry-fileName() ), true ); ^ Linking CXX shared module kcm_clock.so [ 50%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/kickerplugin_automoc.cpp.o [ 50%] Generating ui_setpreview.h [ 51%] Generating klauncher_iface.cpp, klauncher_iface.h [ 51%] Built target kcm_clock [ 51%] Generating ui_colorsettings.h [ 51%] Building CXX object kcms/input/CMakeFiles/kcm_cursortheme.dir/klauncher_iface.cpp.o http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/krdb/krdb.cpp:92:13: warning: unused parameter ‘active’ [-Wunused-parameter] static void applyGtkStyles(bool active, int version) ^ [ 51%] Generating ui_preview.h [ 51%] Generating klauncher_iface.moc Linking CXX shared module kcm_splashscreen.so [ 51%] Building CXX object kcms/launch/CMakeFiles/kcm_launch.dir/kwin_interface.cpp.o Linking CXX shared module kcm_autostart.so [ 52%] Building CXX object kcms/launch/CMakeFiles/kcm_launch.dir/kcm_launch_automoc.cpp.o [ 52%] Built target kcm_splashscreen Scanning dependencies of target kcm_colors [ 52%] [ 52%] Building CXX object kcms/colors/CMakeFiles/kcm_colors.dir/__/krdb/krdb.cpp.o Built target kcm_autostart Scanning dependencies of target krdb_clearlibrarypath [ 53%] [ 53%] Building CXX object kcms/krdb/CMakeFiles/krdb_clearlibrarypath.dir/krdb_clearlibrarypath.cpp.o Generating ui_finetuning.h [ 53%] Generating klauncher_iface.cpp, klauncher_iface.h [ 53%] [ 53%] Building CXX object kcms/krdb/CMakeFiles/krdb_clearlibrarypath.dir/krdb_clearlibrarypath_automoc.cpp.o Generating ui_stylepreview.h [ 53%] Building CXX object kcms/input/CMakeFiles/kcm_cursortheme.dir/kcm_cursortheme_automoc.cpp.o [ 54%] http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/style/stylepreview.ui: Warning: The name 'tab' (QWidget) is already in use, defaulting to 'tab1'. Generating ui_DesktopThemeDetails.h http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/desktoptheme/DesktopThemeDetails.ui: Warning: The name 'hlayout1' (QHBoxLayout) is already in use, defaulting to 'hlayout11'. http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/desktoptheme/DesktopThemeDetails.ui: Warning: The name 'hlayout1' (QHBoxLayout) is already in use, defaulting to 'hlayout12'. [ 54%] Generating klauncher_iface.moc [ 54%] Generating ui_DesktopTheme.h Scanning dependencies of target kcm_style [ 54%] Building CXX object kcms/style/CMakeFiles/kcm_style.dir/__/krdb/krdb.cpp.o Scanning dependencies of target kcm_desktoptheme [ 54%] Building CXX object kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/kcmdesktoptheme.cpp.o [ 54%] Building CXX object kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/desktopthemedetails.cpp.o http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/krdb/krdb_clearlibrarypath.cpp: In function ‘int main(int, char**)’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/krdb/krdb_clearlibrarypath.cpp:46:23: warning: ‘KComponentData’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kcomponentdata.h:51) [-Wdeprecated-declarations] KComponentData kcd(krdb libraryPath fix); ^
Re: Review Request 122887: Load and wrap the QML-only version of kcms if possible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122887/ --- (Updated March 23, 2015, 12:43 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 85ab5f968bce4a8b78ac1f2603d442f851ae1368 by Marco Martin to branch master. Repository: kcmutils Description --- This makes KCMLoader try to load the qobject-only, qml based kcms as well, if it succeeds it wraps them in the KCModuleQML KCModule subclass and returns it as loaded module (the class itself is not exported, so no new symbols). This makes systemsettings, kcmshell and any config dialog that loads kcms transparently load those config modules not based upon KCModule Diffs - CMakeLists.txt cb4ae5d src/CMakeLists.txt f7b869f src/kcmoduleloader.cpp 5ccf236 src/kcmoduleqml.cpp PRE-CREATION src/kcmoduleqml_p.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122887/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122888: Port the look and feel KCM to the qml only version
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122888/ --- (Updated March 23, 2015, 12:47 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 4f39066b46e2babf2f0979531534dacc1773ff27 by Marco Martin to branch master. Repository: plasma-desktop Description --- this ports the lf kcm to KDeclarative::ConfigModule showing an example on how should be used Diffs - CMakeLists.txt 7c6284c kcms/lookandfeel/CMakeLists.txt 2cde16f kcms/lookandfeel/autotests/CMakeLists.txt 1f01310 kcms/lookandfeel/kcm.h c082cd3 kcms/lookandfeel/kcm.cpp d930b45 kcms/lookandfeel/package/contents/ui/main.qml 9ff3df3 Diff: https://git.reviewboard.kde.org/r/122888/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to normal : plasma-desktop_master_qt5 #1117
See http://build.kde.org/job/plasma-desktop_master_qt5/1117/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122886: QML-only KCM base
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 23, 2015, 12:04 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 119510b653a3c02c758d055db2c10db73461b905 by Marco Martin to branch master. Repository: kdeclarative Description --- This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly. it loads a qml file that then will be able to access its instance as kcm or as the KCM attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible). They will be loaded in systemsettings by review 122887 Diffs - src/quickaddons/CMakeLists.txt 3c7a34b src/quickaddons/configmodule.h PRE-CREATION src/quickaddons/configmodule.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122886/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122886: QML-only KCM base
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77964 --- Ship it! Ship It! - David Edmundson On March 13, 2015, 12:04 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 13, 2015, 12:04 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly. it loads a qml file that then will be able to access its instance as kcm or as the KCM attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible). They will be loaded in systemsettings by review 122887 Diffs - src/quickaddons/CMakeLists.txt 3c7a34b src/quickaddons/configmodule.h PRE-CREATION src/quickaddons/configmodule.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122886/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123091: [plasma-workspace/dataengines/geolocation] Fix build with NM 1.0.0
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123091/ --- (Updated March 23, 2015, 11:01 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, Martin Gräßlin and Jan Grulich. Changes --- Submitted with commit 17a144bc8c210eae0893bac327e836b0d546e215 by Hrvoje Senjan to branch master. Repository: plasma-workspace Description --- Fix build by adding QT_NO_KEYWORDS definition. Also adjusted the surrounding files to make them build with this. It is needed to avoid symbol collision with gtk/gio. (I have no idea what changed in NM 1.0.0 that is exposes the failure, it builds fine with older versions - but would like to know if there's a better solution ;-) Diffs - dataengines/geolocation/CMakeLists.txt 7a477c1 dataengines/geolocation/geolocation.cpp 678f25f dataengines/geolocation/geolocationprovider.cpp 6db8026 Diff: https://git.reviewboard.kde.org/r/123091/diff/ Testing --- The error was: ``` In file included from /usr/include/qt5/QtCore/qobject.h:40:0, from /usr/include/qt5/QtCore/qtimer.h:42, from /usr/include/qt5/QtCore/QTimer:1, from ../dataengines/geolocation/geolocation.h:21, from ../dataengines/geolocation/geolocation.cpp:18: /usr/include/glib-2.0/gio/gdbusintrospection.h:155:25: error: expected unqualified-id before ‘public’ GDBusSignalInfo **signals; ^ In file included from /usr/include/glib-2.0/gio/gio.h:53:0, from /usr/include/libnm/nm-types.h:24, from /usr/include/libnm/nm-object.h:29, from /usr/include/libnm/nm-access-point.h:29, from /usr/include/libnm/NetworkManager.h:26, from /usr/include/KF5/NetworkManagerQt/ipconfig.h:34, from /usr/include/KF5/NetworkManagerQt/device.h:33, from /usr/include/KF5/NetworkManagerQt/manager.h:31, from /usr/include/KF5/NetworkManagerQt/Manager:1, from ../dataengines/geolocation/geolocation.cpp:25: /usr/include/glib-2.0/gio/gdbusintrospection.h:155:24: error: expected ‘;’ at end of member declaration GDBusSignalInfo **signals; ^ /usr/include/glib-2.0/gio/gdbusintrospection.h:155:32: error: expected ‘:’ before ‘;’ token GDBusSignalInfo **signals; ``` With the attached patch it builds fine. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123098: Don't show notification popup for persistent notifications when applet is expanded
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123098/#review77959 --- This assumes that your systray is at the same position as the notification popup is, which is the default, true, but I'm a bit worried about cases where your systray is in a different position (and I do have that patch that allows you to select different popups position). Then it might be confusing if suddenly you don't see the popup (especially on bigger screens)? - Martin Klapetek On March 22, 2015, 1:25 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123098/ --- (Updated March 22, 2015, 1:25 p.m.) Review request for Plasma and Martin Klapetek. Repository: plasma-workspace Description --- Persistent notifications are stored in the history. When you have currently opened the plasmoid, you would see the notification right away, but it is then covered by the popup of exactly the same notification. I tend to keep my tray opened when copying lots of files and when the job finishes, I get this odd behavior. Diffs - applets/notifications/package/contents/ui/Notifications.qml 4312774 Diff: https://git.reviewboard.kde.org/r/123098/diff/ Testing --- - knotificationdbustest with plasmoid closed yields 3+1 popups - knotificationdbustest with plasmoid opened yields no popups but the history fills accordingly - notify-send results in a popup either way Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 5.2.2 candidate tars
kwin update to catch commit e26a3db03090abeb719d0b7e30c2c58c054ddafa Author: Thomas Lübking thomas.luebk...@gmail.com Date: Fri Mar 20 22:34:42 2015 +0100 Fix closeview hiding: move it outside rootgeometry The closeview is not hidden because that causes invalid textures (apparently QML related) and deleting/recreating causes massive I/O overhead on effect invocation. As last resort, the window is hidden by moving it out of the root window geometry. Jonathan, please RESPIN kwin - sorry for the trouble ... again. BUG: 345159 REVIEW: 123035 CC: ridd...@gmail.com tda href= http://download.kde.org/stable/plasma/5.2.2/kwin-5.2.2.tar.xz;kwin-5.2.2/a/td td align=right3.6MB/td - tdttd398f2dbd573e545f198b5d4824b881f16a4f5f585ed18d754811138cc219ed0/tt/td + tdttccf66a4b914b2ec38f834907e610b2776c617f2725bec453d7d5faf3d2b2e8c0/tt/td On 19 March 2015 at 17:52, Jonathan Riddell j...@jriddell.org wrote: 5.2.2 tars are up on depot, happy packaging These tars add documentation translations, looks like the Brazilians have been hard at work. Please check over info and announcement pages and let me know of any improvements or changes https://www.kde.org/info/plasma-5.2.2.php https://www.kde.org/announcements/plasma-5.2.2.php Martin G said a fix for KWin was needed, I'm not sure if that got in or not, so we may need to update that tar. Devs please check the errata is still accurate https://community.kde.org/Plasma/5.2_Errata Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123098: Don't show notification popup for persistent notifications when applet is expanded
On March 23, 2015, 11:13 a.m., Martin Klapetek wrote: This assumes that your systray is at the same position as the notification popup is, which is the default, true, but I'm a bit worried about cases where your systray is in a different position (and I do have that patch that allows you to select different popups position). Then it might be confusing if suddenly you don't see the popup (especially on bigger screens)? also plasmaoid.expanded may not be enough, since if the applet is in the systray, some other systray applet may be open and cover it anyways i have half an idea about hackishly going to search for the actual window and move the popups windows if they'll intersect it (or maybe it could even try to intersect the notification rect with all of the visible non desktop application qwindows...) - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123098/#review77959 --- On March 22, 2015, 12:25 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123098/ --- (Updated March 22, 2015, 12:25 p.m.) Review request for Plasma and Martin Klapetek. Repository: plasma-workspace Description --- Persistent notifications are stored in the history. When you have currently opened the plasmoid, you would see the notification right away, but it is then covered by the popup of exactly the same notification. I tend to keep my tray opened when copying lots of files and when the job finishes, I get this odd behavior. Diffs - applets/notifications/package/contents/ui/Notifications.qml 4312774 Diff: https://git.reviewboard.kde.org/r/123098/diff/ Testing --- - knotificationdbustest with plasmoid closed yields 3+1 popups - knotificationdbustest with plasmoid opened yields no popups but the history fills accordingly - notify-send results in a popup either way Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 345208] OSD not updating when keeping brightness keys pressed.
https://bugs.kde.org/show_bug.cgi?id=345208 --- Comment #4 from Martin Klapetek mklape...@kde.org --- That is a different bug, please report separately. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 345439] New: Option: Ignore lid close events when external display is attached
https://bugs.kde.org/show_bug.cgi?id=345439 Bug ID: 345439 Summary: Option: Ignore lid close events when external display is attached Product: Powerdevil Version: unspecified Platform: openSUSE RPMs OS: Linux Status: UNCONFIRMED Severity: wishlist Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: d.h.j.tak...@xs4all.nl In most situations it makes no sense to respond to lid close events when external displays are attached. Reproducible: Always Steps to Reproduce: 1. Configure laptop to lock the screen when the lid is closed (on AC power) 2. Place laptop on docking station with external display attached, lid still opened. 3. Close the lid of the laptop Actual Results: The screen is locked Expected Results: Lid close event is ignored, because an external display is attached -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122887: Load and wrap the QML-only version of kcms if possible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122887/#review77960 --- Ship it! Ship It! - David Edmundson On March 12, 2015, 7:01 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122887/ --- (Updated March 12, 2015, 7:01 p.m.) Review request for KDE Frameworks and Plasma. Repository: kcmutils Description --- This makes KCMLoader try to load the qobject-only, qml based kcms as well, if it succeeds it wraps them in the KCModuleQML KCModule subclass and returns it as loaded module (the class itself is not exported, so no new symbols). This makes systemsettings, kcmshell and any config dialog that loads kcms transparently load those config modules not based upon KCModule Diffs - CMakeLists.txt cb4ae5d src/CMakeLists.txt f7b869f src/kcmoduleloader.cpp 5ccf236 src/kcmoduleqml.cpp PRE-CREATION src/kcmoduleqml_p.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122887/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Minutes Monday Plasma Hangout
Notes for monday hangout of 23 March 2015 David: - will restore highdpi work with dolphin Jonathan: - tars for 5.2.2 - improved release script - Kai Uwe: - IconDialog for KDeclarative - few Animators here and there to improve smoothness due to our shorter animations Martin - Wayland work - merged rootles xwayland - windowed mode in kwin wayland (possible to start it in W11 without weston) - will try to have qtwayland to render to framebuffer - will try to work on touchevent with the wetab if the hardware can Clemens: - Testing live images to make sure what comes out of kci is ready for release Marco - mostly bugfixes - finished branches for QML-only kcms, will merge this week -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122939: Immediately hide tooltip on ToolTipArea destruction or when it becomes empty
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122939/ --- (Updated März 23, 2015, 7:06 nachm.) Review request for Plasma. Changes --- Keep track who has opened the dialog last and only let that one hide the dialog on destruction/text change Repository: plasma-framework Description --- When the tooltip is empty (no text and no subtext and no mainitem) it will not show. However, when it becomes empty while it is shown, it stays there as a small rectangle. This patch hides the tooltip immediately (so KWin's fadeout animation still has the proper content rather than the empty tooltip) when the area has been destroyed or its content becomes empty. It access s_dialog directly not to unneccessarily create a tooltipInstance just for a call in the destructor or that wouldn't have effect without a tooltip anyway. Diffs (updated) - src/declarativeimports/core/tooltip.h 7a58826 src/declarativeimports/core/tooltip.cpp 40e0af5 src/declarativeimports/core/tooltipdialog.h d81dadb src/declarativeimports/core/tooltipdialog.cpp 6c5675e Diff: https://git.reviewboard.kde.org/r/122939/diff/ Testing --- Hovered KMail tray icon, closed KMail using Ctrl+Q while still hovering the icon. Previously the tooltip would change into an empty rectangle, staying there until the tooltip times out, now it hides nicely. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123098: Don't show notification popup for persistent notifications when applet is expanded
On March 23, 2015, 11:13 a.m., Martin Klapetek wrote: This assumes that your systray is at the same position as the notification popup is, which is the default, true, but I'm a bit worried about cases where your systray is in a different position (and I do have that patch that allows you to select different popups position). Then it might be confusing if suddenly you don't see the popup (especially on bigger screens)? Marco Martin wrote: also plasmaoid.expanded may not be enough, since if the applet is in the systray, some other systray applet may be open and cover it anyways i have half an idea about hackishly going to search for the actual window and move the popups windows if they'll intersect it (or maybe it could even try to intersect the notification rect with all of the visible non desktop application qwindows...) Kai Uwe Broulik wrote: Hmm, is plasmoid.expanded really true when the systray popup is opened but the plasmoid isn't the current? That would be weird, but I don't know... Intersecting with any window would lead to it randomly change position, also on a laptop 95% of my windows are maximized anyway. But yeah, we can do better :) no, when the systray popup is open and the notification plasmoid isn't the current expanded is false. that would be the problem no? btw, with all windows i was only referring to plasmashell's windows, so pretty much just open popups, not other application's windows - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123098/#review77959 --- On March 22, 2015, 12:25 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123098/ --- (Updated March 22, 2015, 12:25 p.m.) Review request for Plasma and Martin Klapetek. Repository: plasma-workspace Description --- Persistent notifications are stored in the history. When you have currently opened the plasmoid, you would see the notification right away, but it is then covered by the popup of exactly the same notification. I tend to keep my tray opened when copying lots of files and when the job finishes, I get this odd behavior. Diffs - applets/notifications/package/contents/ui/Notifications.qml 4312774 Diff: https://git.reviewboard.kde.org/r/123098/diff/ Testing --- - knotificationdbustest with plasmoid closed yields 3+1 popups - knotificationdbustest with plasmoid opened yields no popups but the history fills accordingly - notify-send results in a popup either way Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to normal : plasma-workspace_stable_qt5 #98
See http://build.kde.org/job/plasma-workspace_stable_qt5/98/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122939: Immediately hide tooltip on ToolTipArea destruction or when it becomes empty
On March 22, 2015, 9:28 p.m., David Edmundson wrote: src/declarativeimports/core/tooltip.cpp, line 63 https://git.reviewboard.kde.org/r/122939/diff/1/?file=354909#file354909line63 I'm not sure about this, doesn't this mean if I'm hovering over the clock and kmail closes my tooltip will vanish? yeah, this should happen only when the tooltip verifies it's the temporary owner of the dialog - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122939/#review77931 --- On March 14, 2015, 12:40 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122939/ --- (Updated March 14, 2015, 12:40 p.m.) Review request for Plasma. Repository: plasma-framework Description --- When the tooltip is empty (no text and no subtext and no mainitem) it will not show. However, when it becomes empty while it is shown, it stays there as a small rectangle. This patch hides the tooltip immediately (so KWin's fadeout animation still has the proper content rather than the empty tooltip) when the area has been destroyed or its content becomes empty. It access s_dialog directly not to unneccessarily create a tooltipInstance just for a call in the destructor or that wouldn't have effect without a tooltip anyway. Diffs - src/declarativeimports/core/tooltip.h 7a58826 src/declarativeimports/core/tooltip.cpp 40e0af5 Diff: https://git.reviewboard.kde.org/r/122939/diff/ Testing --- Hovered KMail tray icon, closed KMail using Ctrl+Q while still hovering the icon. Previously the tooltip would change into an empty rectangle, staying there until the tooltip times out, now it hides nicely. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123091: [plasma-workspace/dataengines/geolocation] Fix build with NM 1.0.0
On Bře. 21, 2015, 4:16 odp., Aleix Pol Gonzalez wrote: +1 I also had this error, thanks a lot for the investigation!! I wonder how it worked for whoever pushed this... Martin Gräßlin wrote: I wonder how it worked for whoever pushed this... Debian testing only having NM 0.9 +1 We also had to fix plasma-nm due to the same error introduced with NM 1.0.0. If you compile networkmanager-qt against NM 1.0.0, it uses headers from a different location than before and one of them includes /usr/include/glib-2.0/gio/gdbusintrospection.h where it uses signals as a name which is a keyword reserved by moc. - Jan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123091/#review77887 --- On Bře. 21, 2015, 1:16 dop., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123091/ --- (Updated Bře. 21, 2015, 1:16 dop.) Review request for Plasma, Martin Gräßlin and Jan Grulich. Repository: plasma-workspace Description --- Fix build by adding QT_NO_KEYWORDS definition. Also adjusted the surrounding files to make them build with this. It is needed to avoid symbol collision with gtk/gio. (I have no idea what changed in NM 1.0.0 that is exposes the failure, it builds fine with older versions - but would like to know if there's a better solution ;-) Diffs - dataengines/geolocation/CMakeLists.txt 7a477c1 dataengines/geolocation/geolocation.cpp 678f25f dataengines/geolocation/geolocationprovider.cpp 6db8026 Diff: https://git.reviewboard.kde.org/r/123091/diff/ Testing --- The error was: ``` In file included from /usr/include/qt5/QtCore/qobject.h:40:0, from /usr/include/qt5/QtCore/qtimer.h:42, from /usr/include/qt5/QtCore/QTimer:1, from ../dataengines/geolocation/geolocation.h:21, from ../dataengines/geolocation/geolocation.cpp:18: /usr/include/glib-2.0/gio/gdbusintrospection.h:155:25: error: expected unqualified-id before ‘public’ GDBusSignalInfo **signals; ^ In file included from /usr/include/glib-2.0/gio/gio.h:53:0, from /usr/include/libnm/nm-types.h:24, from /usr/include/libnm/nm-object.h:29, from /usr/include/libnm/nm-access-point.h:29, from /usr/include/libnm/NetworkManager.h:26, from /usr/include/KF5/NetworkManagerQt/ipconfig.h:34, from /usr/include/KF5/NetworkManagerQt/device.h:33, from /usr/include/KF5/NetworkManagerQt/manager.h:31, from /usr/include/KF5/NetworkManagerQt/Manager:1, from ../dataengines/geolocation/geolocation.cpp:25: /usr/include/glib-2.0/gio/gdbusintrospection.h:155:24: error: expected ‘;’ at end of member declaration GDBusSignalInfo **signals; ^ /usr/include/glib-2.0/gio/gdbusintrospection.h:155:32: error: expected ‘:’ before ‘;’ token GDBusSignalInfo **signals; ``` With the attached patch it builds fine. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123091: [plasma-workspace/dataengines/geolocation] Fix build with NM 1.0.0
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123091/#review77951 --- Ship it! Ship It! - Martin Gräßlin On March 21, 2015, 2:16 a.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123091/ --- (Updated March 21, 2015, 2:16 a.m.) Review request for Plasma, Martin Gräßlin and Jan Grulich. Repository: plasma-workspace Description --- Fix build by adding QT_NO_KEYWORDS definition. Also adjusted the surrounding files to make them build with this. It is needed to avoid symbol collision with gtk/gio. (I have no idea what changed in NM 1.0.0 that is exposes the failure, it builds fine with older versions - but would like to know if there's a better solution ;-) Diffs - dataengines/geolocation/CMakeLists.txt 7a477c1 dataengines/geolocation/geolocation.cpp 678f25f dataengines/geolocation/geolocationprovider.cpp 6db8026 Diff: https://git.reviewboard.kde.org/r/123091/diff/ Testing --- The error was: ``` In file included from /usr/include/qt5/QtCore/qobject.h:40:0, from /usr/include/qt5/QtCore/qtimer.h:42, from /usr/include/qt5/QtCore/QTimer:1, from ../dataengines/geolocation/geolocation.h:21, from ../dataengines/geolocation/geolocation.cpp:18: /usr/include/glib-2.0/gio/gdbusintrospection.h:155:25: error: expected unqualified-id before ‘public’ GDBusSignalInfo **signals; ^ In file included from /usr/include/glib-2.0/gio/gio.h:53:0, from /usr/include/libnm/nm-types.h:24, from /usr/include/libnm/nm-object.h:29, from /usr/include/libnm/nm-access-point.h:29, from /usr/include/libnm/NetworkManager.h:26, from /usr/include/KF5/NetworkManagerQt/ipconfig.h:34, from /usr/include/KF5/NetworkManagerQt/device.h:33, from /usr/include/KF5/NetworkManagerQt/manager.h:31, from /usr/include/KF5/NetworkManagerQt/Manager:1, from ../dataengines/geolocation/geolocation.cpp:25: /usr/include/glib-2.0/gio/gdbusintrospection.h:155:24: error: expected ‘;’ at end of member declaration GDBusSignalInfo **signals; ^ /usr/include/glib-2.0/gio/gdbusintrospection.h:155:32: error: expected ‘:’ before ‘;’ token GDBusSignalInfo **signals; ``` With the attached patch it builds fine. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[kio-extras] [Bug 345440] SFTP: Internal Error on deleting a folder without having permissions and wich is also mounted
https://bugs.kde.org/show_bug.cgi?id=345440 Emmanuel Pescosta emmanuelpescosta...@gmail.com changed: What|Removed |Added Version|4.13.3 |unspecified Product|dolphin |kio-extras Component|general |default CC||emmanuelpescosta099@gmail.c ||om Assignee|dolphin-bugs-n...@kde.org |plasma-devel@kde.org --- Comment #2 from Emmanuel Pescosta emmanuelpescosta...@gmail.com --- Thanks for the bug report! I'll reassign it to KIO-extras. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122332: KQuickControls IconDialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122332/ --- (Updated März 23, 2015, 6:53 nachm.) Review request for Plasma and Daniel Vrátil. Changes --- Use eventFilter on the dialog to track its visibility Repository: kdeclarative Description --- This patch adds KQuickControls wrapper around KIconDialog similar to how the ColorDialog and other QtQuick Dialogs work. This can be used, for instance, in Kickoff's config UI to provide a picker for a custom item. It is an initial draft and lacks for example window modality as I couldn't figure out how QtQuick Dialogs do that (some PlatformDialogHelper magic inside) and I'm also not sure about the lifecycle/ownership of the dialog, I've seen a lot of fixes for issues in that area on Review Board. Diffs (updated) - src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt d5713a0 src/qmlcontrols/kquickcontrolsaddons/icondialog.h PRE-CREATION src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp PRE-CREATION src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp cee2360 Diff: https://git.reviewboard.kde.org/r/122332/diff/ Testing --- For testing I added a button to Kickoff that allows to open the dialog and the button icon source is bound to the dialog's iconName property. Didn't test the icon source/user/custom path stuff. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123098: Don't show notification popup for persistent notifications when applet is expanded
On März 23, 2015, 11:13 vorm., Martin Klapetek wrote: This assumes that your systray is at the same position as the notification popup is, which is the default, true, but I'm a bit worried about cases where your systray is in a different position (and I do have that patch that allows you to select different popups position). Then it might be confusing if suddenly you don't see the popup (especially on bigger screens)? Marco Martin wrote: also plasmaoid.expanded may not be enough, since if the applet is in the systray, some other systray applet may be open and cover it anyways i have half an idea about hackishly going to search for the actual window and move the popups windows if they'll intersect it (or maybe it could even try to intersect the notification rect with all of the visible non desktop application qwindows...) Hmm, is plasmoid.expanded really true when the systray popup is opened but the plasmoid isn't the current? That would be weird, but I don't know... Intersecting with any window would lead to it randomly change position, also on a laptop 95% of my windows are maximized anyway. But yeah, we can do better :) - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123098/#review77959 --- On März 22, 2015, 12:25 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123098/ --- (Updated März 22, 2015, 12:25 nachm.) Review request for Plasma and Martin Klapetek. Repository: plasma-workspace Description --- Persistent notifications are stored in the history. When you have currently opened the plasmoid, you would see the notification right away, but it is then covered by the popup of exactly the same notification. I tend to keep my tray opened when copying lots of files and when the job finishes, I get this odd behavior. Diffs - applets/notifications/package/contents/ui/Notifications.qml 4312774 Diff: https://git.reviewboard.kde.org/r/123098/diff/ Testing --- - knotificationdbustest with plasmoid closed yields 3+1 popups - knotificationdbustest with plasmoid opened yields no popups but the history fills accordingly - notify-send results in a popup either way Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
