Re: timing of KDE5 panel in login

2015-03-27 Thread Luigi Toscano
On Friday 27 of March 2015 19:21:35 Takao Fujiwara wrote:
 I'd like to run a custom panel at bottom right in KDE5 for
 ibus(propertypanel.vala): https://github.com/ibus/ibus/tree/master/ui/gtk3

Hi, this is a Plasma 5 related question, try to ask on the plasma-devel list 
(now in CC, I don't remember if it requires a subscription). Question quoted 
below (I'm just the messenger):

 
 Since KDE5 allocates the owned panel at bottom, I try to get the desktop
 height using _NET_CURRENT_DESKTOP atom. My custom panel runs at login time
 and tries to get the desktop height using _NET_CURRENT_DESKTOP atom but
 KDE5 panel still is not launched. How can I get when the KDE5 panel is
 launched at login time?
 
 Actually I use both the custom panel and KNotifications icon.
 When I get the callback of org.kde.StatusNotifierWatcher of The
 KNotifications icon, KDE5 panel still is not allocated. I also checked the
 atoms with xlsatoms command but I have no idea to get KDE panel.

Ciao
-- 
Luigi
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 123147: do not install so link if the headers are not being installed

2015-03-27 Thread Harald Sitter

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123147/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

in the no-install-header mode it keeps the library entirely private by
not installing the symlink, whereas when installing the headers the so
link is also being installed.


Diffs
-

  lib/kactivities-stats/src/lib/stats/CMakeLists.txt 
f58aa5d9bd200b3c037a5e7e5a7ad893bbae956e 

Diff: https://git.reviewboard.kde.org/r/123147/diff/


Testing
---

make -j9; make install DESTDIR=. -- doesn't install .so

change experimental header install variable to true -- installs .so


Thanks,

Harald Sitter

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


ISO for 2015-03-27

2015-03-27 Thread Harald Sitter
http://files.kde.org/snapshots/unstable-amd64-latest.iso.mirrorlist

# changes
- kio CI repaired
- kdeconnect CI repaired
- muon CI repaired
- kwin shouldn't crash anymore when entering the live session
- kde telepathy requires installation of signon-plugin-password so it
works as expected (your's truly forgot to push the fix for that, fixed
for next week)
- dolphin now correctly pulls in the konsole kpart4
- cantor is being integrated correctly (sudo apt install cantor)
- the previous graphics glitches in virtual machines should be gone entirely now

# errata
- screenlocker still starting after 1 minute, fix applied and should
be in next week's ISO
- mouse cursor still bugs out on parts of the desktop (under
investigation still)

# long standing errata
- all issues affecting Kubuntu 15.04, nothing major known right now
- the ISO is rolled using the CI landing PPA due to stabilization
blockage from missing bluez5. this in turn means that upgrades
potentially won't work or break half way through as the underlying PPA
breaks ever so often.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 123149: execute xrdb in kapplymousetheme

2015-03-27 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123149/
---

Review request for Plasma and Martin Gräßlin.


Repository: plasma-desktop


Description
---

try to fix the cursors at startup bug


Diffs
-

  kcms/input/CMakeLists.txt 8031295 
  kcms/input/kapplymousetheme.cpp ad3db05 

Diff: https://git.reviewboard.kde.org/r/123149/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 123136: Fix one pixel gap between screenedge and right placed vertical panel

2015-03-27 Thread Bhushan Shah

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123136/
---

(Updated March 27, 2015, 12:22 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Martin Gräßlin and Marco Martin.


Changes
---

Submitted with commit 975e5009c176eb378daa5c8f74cd4cffb64ff459 by Bhushan Shah 
to branch master.


Bugs: 339323 and 340549
https://bugs.kde.org/show_bug.cgi?id=339323
https://bugs.kde.org/show_bug.cgi?id=340549


Repository: plasma-workspace


Description
---

Appearantly right() / bottomRight() / topRight() returns values with 1
pixel x off for historical reasons and hence 1px gap. This causes the
autohide panel not hiding automatically.


Diffs
-

  shell/panelview.cpp 3435736 

Diff: https://git.reviewboard.kde.org/r/123136/diff/


Testing
---

added right aligned panel and tested various combinations


Thanks,

Bhushan Shah

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: timing of KDE5 panel in login

2015-03-27 Thread Takao Fujiwara

Thank you for forwarding the e-mail.

I try to get the desktop size from _NET_WORKAREA and _NET_CURRENT_DESKTOP.

After KDE panel runs, the height of root window != the height of _NET_WORKAREA 
because KDE5 panel is allocated.
I wish to move my panel to (the width of root window, the height of 
_NET_WORKAREA)
But When I try to get the the height of _NET_WORKAREA during the login, the height of root window == the height of _NET_WORKAREA because KDE5 panel is 
not allocated yet. So the position of my panel and one of the KDE panel is duplicated.


This is the expected result.

+--- plasma-desktop 5 -+
|  |
| +---+|
| | my panel  ||
| +---+|
|++|
||  KDE5 panel||
|++|
+--+

But actual result at login time is duplicated because KDE5 panel is not 
allocated:

++---+
|  KDE5 panel| My panel  |
++---+

After KDE5 panel runs, my panel gets the right position because the height of 
_NET_WORKAREA returns the right value.

I'm finding how to listen the changes in the property.
But I don't have to listen the change in GNOME and XFCE. I can get the right 
value of _NET_WORKAREA at login.
I guess KDE5 panel might be slow to be launched.

Probably I can use notify::size signal for GtkStatusIcon to listen the panel 
size.
But I don't know how to get the change of the panel size in KNotifications.
I migrated GtkStatusIcon to KNotifications recently since KDE5 does not enable 
notification area by default.
I use both the custom panel and panel icon of KNotifications now.

On 03/27/15 20:28, Luigi Toscano-san wrote:

On Friday 27 of March 2015 19:21:35 Takao Fujiwara wrote:

I'd like to run a custom panel at bottom right in KDE5 for
ibus(propertypanel.vala): https://github.com/ibus/ibus/tree/master/ui/gtk3


Hi, this is a Plasma 5 related question, try to ask on the plasma-devel list
(now in CC, I don't remember if it requires a subscription). Question quoted
below (I'm just the messenger):



Since KDE5 allocates the owned panel at bottom, I try to get the desktop
height using _NET_CURRENT_DESKTOP atom. My custom panel runs at login time
and tries to get the desktop height using _NET_CURRENT_DESKTOP atom but
KDE5 panel still is not launched. How can I get when the KDE5 panel is
launched at login time?

Actually I use both the custom panel and KNotifications icon.
When I get the callback of org.kde.StatusNotifierWatcher of The
KNotifications icon, KDE5 panel still is not allocated. I also checked the
atoms with xlsatoms command but I have no idea to get KDE panel.


Ciao



___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 123136: Fix one pixel gap between screenedge and right placed vertical panel

2015-03-27 Thread David Edmundson


 On March 26, 2015, 4:59 p.m., David Edmundson wrote:
  shell/panelview.cpp, line 443
  https://git.reviewboard.kde.org/r/123136/diff/1/?file=356709#file356709line443
 
  and here?
 
 Bhushan Shah wrote:
 bottomLeft is fine, in general anythingLeft is fine.

bottomLeft's bottom will be wrong still though?

Returns the position of the rectangle's bottom-left corner. Note that for 
historical reasons this function returns QPoint(left(), top() + height() - 1).


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123136/#review78069
---


On March 27, 2015, 12:03 p.m., Bhushan Shah wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123136/
 ---
 
 (Updated March 27, 2015, 12:03 p.m.)
 
 
 Review request for Plasma, Martin Gräßlin and Marco Martin.
 
 
 Bugs: 339323 and 340549
 https://bugs.kde.org/show_bug.cgi?id=339323
 https://bugs.kde.org/show_bug.cgi?id=340549
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 Appearantly right() / bottomRight() / topRight() returns values with 1
 pixel x off for historical reasons and hence 1px gap. This causes the
 autohide panel not hiding automatically.
 
 
 Diffs
 -
 
   shell/panelview.cpp 3435736 
 
 Diff: https://git.reviewboard.kde.org/r/123136/diff/
 
 
 Testing
 ---
 
 added right aligned panel and tested various combinations
 
 
 Thanks,
 
 Bhushan Shah
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 123149: execute xrdb in kapplymousetheme

2015-03-27 Thread Marco Martin


 On March 27, 2015, 12:20 p.m., Lukáš Tinkl wrote:
  Doesn't running krdb fix this as well?

would that need the same configuration file generation as xrdb or just running 
krdb would be magic enough?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123149/#review78115
---


On March 27, 2015, 11:55 a.m., Marco Martin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123149/
 ---
 
 (Updated March 27, 2015, 11:55 a.m.)
 
 
 Review request for Plasma and Martin Gräßlin.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 try to fix the cursors at startup bug
 
 
 Diffs
 -
 
   kcms/input/CMakeLists.txt 8031295 
   kcms/input/kapplymousetheme.cpp ad3db05 
 
 Diff: https://git.reviewboard.kde.org/r/123149/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Marco Martin
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 123136: Fix one pixel gap between screenedge and right placed vertical panel

2015-03-27 Thread Bhushan Shah


 On March 26, 2015, 10:29 p.m., David Edmundson wrote:
  shell/panelview.cpp, line 433
  https://git.reviewboard.kde.org/r/123136/diff/1/?file=356709#file356709line433
 
  and here.

topLeft is fine.. it is not affected


 On March 26, 2015, 10:29 p.m., David Edmundson wrote:
  shell/panelview.cpp, line 443
  https://git.reviewboard.kde.org/r/123136/diff/1/?file=356709#file356709line443
 
  and here?

bottomLeft is fine, in general anythingLeft is fine.


- Bhushan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123136/#review78069
---


On March 26, 2015, 10:11 p.m., Bhushan Shah wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123136/
 ---
 
 (Updated March 26, 2015, 10:11 p.m.)
 
 
 Review request for Plasma, Martin Gräßlin and Marco Martin.
 
 
 Bugs: 339323 and 340549
 https://bugs.kde.org/show_bug.cgi?id=339323
 https://bugs.kde.org/show_bug.cgi?id=340549
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 Appearantly right() / bottomRight() / topRight() returns values with 1
 pixel x off for historical reasons and hence 1px gap. This causes the
 autohide panel not hiding automatically.
 
 
 Diffs
 -
 
   shell/panelview.cpp 3435736 
 
 Diff: https://git.reviewboard.kde.org/r/123136/diff/
 
 
 Testing
 ---
 
 added right aligned panel and tested various combinations
 
 
 Thanks,
 
 Bhushan Shah
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 123136: Fix one pixel gap between screenedge and right placed vertical panel

2015-03-27 Thread Bhushan Shah

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123136/
---

(Updated March 27, 2015, 5:33 p.m.)


Review request for Plasma, Martin Gräßlin and Marco Martin.


Bugs: 339323 and 340549
https://bugs.kde.org/show_bug.cgi?id=339323
https://bugs.kde.org/show_bug.cgi?id=340549


Repository: plasma-workspace


Description
---

Appearantly right() / bottomRight() / topRight() returns values with 1
pixel x off for historical reasons and hence 1px gap. This causes the
autohide panel not hiding automatically.


Diffs (updated)
-

  shell/panelview.cpp 3435736 

Diff: https://git.reviewboard.kde.org/r/123136/diff/


Testing
---

added right aligned panel and tested various combinations


Thanks,

Bhushan Shah

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 123136: Fix one pixel gap between screenedge and right placed vertical panel

2015-03-27 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123136/#review78113
---

Ship it!


Ship It!

- David Edmundson


On March 26, 2015, 4:41 p.m., Bhushan Shah wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123136/
 ---
 
 (Updated March 26, 2015, 4:41 p.m.)
 
 
 Review request for Plasma, Martin Gräßlin and Marco Martin.
 
 
 Bugs: 339323 and 340549
 https://bugs.kde.org/show_bug.cgi?id=339323
 https://bugs.kde.org/show_bug.cgi?id=340549
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 Appearantly right() / bottomRight() / topRight() returns values with 1
 pixel x off for historical reasons and hence 1px gap. This causes the
 autohide panel not hiding automatically.
 
 
 Diffs
 -
 
   shell/panelview.cpp 3435736 
 
 Diff: https://git.reviewboard.kde.org/r/123136/diff/
 
 
 Testing
 ---
 
 added right aligned panel and tested various combinations
 
 
 Thanks,
 
 Bhushan Shah
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 123149: execute xrdb in kapplymousetheme

2015-03-27 Thread Lukáš Tinkl

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123149/#review78115
---


Doesn't running krdb fix this as well?

- Lukáš Tinkl


On Bře. 27, 2015, 12:55 odp., Marco Martin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123149/
 ---
 
 (Updated Bře. 27, 2015, 12:55 odp.)
 
 
 Review request for Plasma and Martin Gräßlin.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 try to fix the cursors at startup bug
 
 
 Diffs
 -
 
   kcms/input/CMakeLists.txt 8031295 
   kcms/input/kapplymousetheme.cpp ad3db05 
 
 Diff: https://git.reviewboard.kde.org/r/123149/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Marco Martin
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Powerdevil] [Bug 345533] Crash on resume from suspend

2015-03-27 Thread Lukáš Tinkl
https://bugs.kde.org/show_bug.cgi?id=345533

Lukáš Tinkl lu...@kde.org changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|UNCONFIRMED |NEEDSINFO
 CC||lu...@kde.org

--- Comment #1 from Lukáš Tinkl lu...@kde.org ---
Can you please install debug symbols to get a more meaningful backtrace?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 123142: Fixes plasma-desktop compilation with boost 1.57

2015-03-27 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123142/#review78121
---


is this redundant now?

- David Edmundson


On March 26, 2015, 7:47 p.m., Tomaz  Canabrava wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123142/
 ---
 
 (Updated March 26, 2015, 7:47 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 Plasma-desktop uses Boost::optional on a few places, but it stored the value 
 as boolean ( bool thisValid  = currentValue; for instance ), the issue is 
 that boost::optional conversion to bool must be explicit, thus a static_cast 
 is needed.
 
 
 Diffs
 -
 
   lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp 664b399 
 
 Diff: https://git.reviewboard.kde.org/r/123142/diff/
 
 
 Testing
 ---
 
 compiles.
 
 
 Thanks,
 
 Tomaz  Canabrava
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: timing of KDE5 panel in login

2015-03-27 Thread Eike Hein


Just a side note: KDE ships an ibus/fcitx/scim GUI frontend
in kdeplasma-addons that's implemented as a panel widget (+
popups).



Cheers,
Eike
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 123142: Fixes plasma-desktop compilation with boost 1.57

2015-03-27 Thread Ivan Čukić


 On March 27, 2015, 2:20 p.m., David Edmundson wrote:
  is this redundant now?

Yes, Tomaz said he'll close it.


- Ivan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123142/#review78121
---


On March 26, 2015, 7:47 p.m., Tomaz  Canabrava wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123142/
 ---
 
 (Updated March 26, 2015, 7:47 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 Plasma-desktop uses Boost::optional on a few places, but it stored the value 
 as boolean ( bool thisValid  = currentValue; for instance ), the issue is 
 that boost::optional conversion to bool must be explicit, thus a static_cast 
 is needed.
 
 
 Diffs
 -
 
   lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp 664b399 
 
 Diff: https://git.reviewboard.kde.org/r/123142/diff/
 
 
 Testing
 ---
 
 compiles.
 
 
 Thanks,
 
 Tomaz  Canabrava
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: BluezQt in kdereview

2015-03-27 Thread David Rosca
It's been 2 weeks and I'd like to make it in time for Plasma 5.3,
so if there are no objections, I will file a ticket for move to kde/workspace.

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 123149: execute xrdb in kapplymousetheme

2015-03-27 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123149/
---

(Updated March 27, 2015, 3:25 p.m.)


Status
--

This change has been discarded.


Review request for Plasma and Martin Gräßlin.


Repository: plasma-desktop


Description
---

try to fix the cursors at startup bug


Diffs
-

  kcms/input/CMakeLists.txt 8031295 
  kcms/input/kapplymousetheme.cpp ad3db05 

Diff: https://git.reviewboard.kde.org/r/123149/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 123142: Fixes plasma-desktop compilation with boost 1.57

2015-03-27 Thread Tomaz Canabrava

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123142/
---

(Updated March 27, 2015, 3:20 p.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-desktop


Description
---

Plasma-desktop uses Boost::optional on a few places, but it stored the value as 
boolean ( bool thisValid  = currentValue; for instance ), the issue is that 
boost::optional conversion to bool must be explicit, thus a static_cast is 
needed.


Diffs
-

  lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp 664b399 

Diff: https://git.reviewboard.kde.org/r/123142/diff/


Testing
---

compiles.


Thanks,

Tomaz  Canabrava

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 123142: Fixes plasma-desktop compilation with boost 1.57

2015-03-27 Thread David Edmundson


 On March 27, 2015, 2:20 p.m., David Edmundson wrote:
  is this redundant now?
 
 Ivan Čukić wrote:
 Yes, Tomaz said he'll close it.

/me abuses his super admin powers.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123142/#review78121
---


On March 27, 2015, 3:20 p.m., Tomaz  Canabrava wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123142/
 ---
 
 (Updated March 27, 2015, 3:20 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 Plasma-desktop uses Boost::optional on a few places, but it stored the value 
 as boolean ( bool thisValid  = currentValue; for instance ), the issue is 
 that boost::optional conversion to bool must be explicit, thus a static_cast 
 is needed.
 
 
 Diffs
 -
 
   lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp 664b399 
 
 Diff: https://git.reviewboard.kde.org/r/123142/diff/
 
 
 Testing
 ---
 
 compiles.
 
 
 Thanks,
 
 Tomaz  Canabrava
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: BluezQt in kdereview

2015-03-27 Thread Marco Martin
On Friday 27 March 2015 18:57:20 David Rosca wrote:
 It's been 2 weeks and I'd like to make it in time for Plasma 5.3,
 so if there are no objections, I will file a ticket for move to
 kde/workspace.
 
+1 from here

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 123161: Add copy and paste support for calculator widget

2015-03-27 Thread Bernhard Friedreich

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123161/
---

Review request for Plasma.


Bugs: 318221
http://bugs.kde.org/show_bug.cgi?id=318221


Repository: kdeplasma-addons


Description
---

The current displayed value from the textfield can be copied.
Content from the clipboard can be pasted but only if the content
is a valid number

BUG: 318221


Diffs
-

  applets/calculator/package/contents/ui/calculator.qml 
23f74bd1ac7de6b7f4519677bd96aa351a91cff1 

Diff: https://git.reviewboard.kde.org/r/123161/diff/


Testing
---

Copying:
*) Tried copying entered numbers and results - works for me :)

Pasting:
*) Pasting asdf leads to nothing being pasted - correct
*) Pasting 5 pasts 5 - replaces the currently entered text with the pasted 
content (this could be worked around - should it append?)
*) Pasting = 5 + 3 passes through validation - no idea why yet - this should 
be possible I guess?

Comments welcome :) This is my second patch so hopefully my work isn't complete 
garbage :P


Thanks,

Bernhard Friedreich

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 123161: Add copy and paste support for calculator widget

2015-03-27 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123161/#review78129
---



applets/calculator/package/contents/ui/calculator.qml (line 95)
https://git.reviewboard.kde.org/r/123161/#comment53528

avoid guessing what the shortcut is.

Otherwise if someone maps it to alt in their settings it won't work. Or if 
someone has a dvorak layout it won't be c and v.

Use

if event.matches(StandardKey.Copy)
http://doc.qt.io/qt-5/qml-qtquick-keyevent.html#matches-method

internally this will ask our QPT plugin which loads things from a KDE 
config file.



applets/calculator/package/contents/ui/calculator.qml (line 220)
https://git.reviewboard.kde.org/r/123161/#comment53531

I'm not convinced this is going to work.

You'll update the display, but all the handling of storing what number is 
entered handles in the key press events.

Can you try pasting 5 then typing '+' and '1'
and see what happens.

I think it will then show 1, not 6.


- David Edmundson


On March 27, 2015, 11:21 p.m., Bernhard Friedreich wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123161/
 ---
 
 (Updated March 27, 2015, 11:21 p.m.)
 
 
 Review request for Plasma.
 
 
 Bugs: 318221
 http://bugs.kde.org/show_bug.cgi?id=318221
 
 
 Repository: kdeplasma-addons
 
 
 Description
 ---
 
 The current displayed value from the textfield can be copied.
 Content from the clipboard can be pasted but only if the content
 is a valid number
 
 BUG: 318221
 
 
 Diffs
 -
 
   applets/calculator/package/contents/ui/calculator.qml 
 23f74bd1ac7de6b7f4519677bd96aa351a91cff1 
 
 Diff: https://git.reviewboard.kde.org/r/123161/diff/
 
 
 Testing
 ---
 
 Copying:
 *) Tried copying entered numbers and results - works for me :)
 
 Pasting:
 *) Pasting asdf leads to nothing being pasted - correct
 *) Pasting 5 pasts 5 - replaces the currently entered text with the pasted 
 content (this could be worked around - should it append?)
 *) Pasting = 5 + 3 passes through validation - no idea why yet - this 
 should be possible I guess?
 
 Comments welcome :) This is my second patch so hopefully my work isn't 
 complete garbage :P
 
 
 Thanks,
 
 Bernhard Friedreich
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel