Re: System Settings app design freshening

[Andrew Lake]

On Mon, Mar 30, 2015 at 1:47 AM Marco Martin wrote:

> what would the left sidebar do in the first mockup where everything is
> shown?
>
>
>
Those are links to modules in which recent changes were made. Selecting one
would take the user directly to that module.

Hope this helps,
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 123190: CMakeLists.txt: Install sddm theme to KDE_INSTALL_DATADIR

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123190/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

This allows installing the sddm theme to a datadir which is outside of the 
prefix, for example on a multiarch layout where arch specific stuff goes to 
/usr/${host}/blah but arch independent stuff still to /usr/share.


Diffs
-

  CMakeLists.txt 40350b2 

Diff: https://git.reviewboard.kde.org/r/123190/diff/


Testing
---

Built and installed to the configured location.


Thanks,

Heiko Becker

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122679: Show Desktop feature: refurbished

[Thomas Pfeiffer]

> On March 22, 2015, 8:28 p.m., Kai Uwe Broulik wrote:
> > Sorry for being late to the party:
> > 
> > UX issues I have with that implementation:
> > - No transition, the windows just disappear (would be cool to have them 
> > slide out of the screen or have them stay at the edges of the screen like 
> > OSX does it, but that's visuals)
> > - Cannot access plasmoid or containment config windows (or GHNS in widget 
> > explorer) - they don't appear in that mode, nor do they exit it
> > - KRunner exits this mode, imho KRunner should be usable from there 
> > (usability?)
> > - Panels inaccessible (though usability even proposed hiding them in 
> > Dashboard mode, so..)
> > 
> > Other than that this would 100% replace my Dashboard usecase, so +1 for the 
> > overall idea.
> > 
> > Usability team, ping?
> 
> Thomas Lübking wrote:
> - No transition
> Definitively, but another patch (we'll have to wire up a showingDesktop 
> signal and then script something nicely ;-)
> 
> - Cannot access plasmoid or containment config windows
> We'll have to require them to either be transient for the desktop or set 
> the keepAbove flag (and interpret that in layers.cpp) to still keep "normal" 
> docks (panels) hidden
> 
> - KRunner exits this mode
> Afaics that's a general (re-occurring ;-) "problem" w/ krunner, unrelated 
> to this patch.
> Non-dock type windows that are not in the desktop group break the mode. 
> This applies because krunner is another process than plasmashell (afair the 
> KDE3 runner was part of kdesktop)
>  => KRunner must either become a dock-type (and keepabove or transient) 
> or move itself into the desktops window group (be transient for it or have 
> the same WM_CLIENT_LEADER)
>  
> However, I put "problem" in quotation marks, because that rather seems 
> the minimize-all (aka. "you wanted to switch the VD" ;-) case of cleaning up 
> the workspace (for the very next action will break the mode anyway when you 
> run a new application)??
> 
> - Panels inaccessible
> See above - we can either make dock-type windows (mostly panels) 
> unconditionally visible or require them to setup a special condition 
> (transient for desktop or keep above)
> 
> The question on what to do here is also the question mostly asked by this 
> RR =)
> The global behavior (as long as we don't require transiency/keepabove 
> hints from "some" panels) is very easy to adjust, though.
> 
> @Usability team, please also see my very first comment for more 
> information on layer control.
> 
> kdeuser 56 wrote:
> My use case for the dashboard was mainly, when I had a lot of windows and 
> I wanted to customize plasma: Simply trigger dashboard and cutsomize the 
> Desktop, othwerwise, you would have to use "Show Desktop" or change to an 
> empty workspace. I really liked what we had in plasma5 till now, because the 
> panels were accessible, why wouldn't they be? What speaks against the panels? 
> They are accesible all the time, why wouldn't that be in dashboard mode too? 
> When the panels are inacessible, I have to treat cutsomization (my main use 
> case), seperately for widgets and panels, something I find an unnecessary 
> barrier. If my opinion is worth anything here, I would vote for accessible 
> panels, dimmed or not.
> On another note: even when you do not customize stuff, you use the 
> dashboard/show desktop for accessing information on the workspace. Now I 
> trigger dashboard, but want to have a look at a notificaiton too, while I am 
> for example reading my plasma notes. Now I would have to exit the dashboard 
> and reenter it, because the panels are not accessible. I don't think the 
> panels ever distract that much, they should be made inaccessible.

Sorry for keeping you waiting for so long. I was very busy recently, and 
apparently I'm the only one who is currently active on the usability list. So 
here goes:

* Transition: We all agree that we need a transition, but since Thomas said it 
will be another patch, we won't discuss it here further (just keep it in mind)
* Config windows: I'm still for a separate "workspace configuration mode" 
(Andrew and I have talked about our plans for that to some Plasma devs, but we 
yet have to properly introduce our ideas) which would make it unnecessary to 
show config dialogs on the dashboard (and if we do have a separate mode, I'd 
indeed vote for _not_ showing them in the dashboard). However, as long as there 
is no separate config mode, I agree with kdeuser56 that the dashboard is 
probably the best place available to configure the workspace and therefore 
config dialogs should be visible there. Just please don't put too much effort 
into this as it might become obsolete later.
* Panels: I'm a bit torn here. The thing is that we have not defined what the 
dashboard is supposed to be used for. If it is only for glancing at or quickly 
interacting with desktop widgets, then panels wou

Re: Review Request 122679: Show Desktop feature: refurbished

[Thomas Lübking]

> On März 30, 2015, 7:12 nachm., Thomas Pfeiffer wrote:
> > Was adding the usability group more meant as a heads-up to inform us that 
> > things are happening on this front, or are you expecting an actual 
> > usability review?
> > In the latter case, we'd need some kind of visualization or at least 
> > detailed description of what is happening on the UI side, since we can't 
> > read code all that well ;)

The main (only) question for the usability team right now is "what do we do 
with panels":
Should the hide or show when showing the desktop (having in mind this to be a 
dashboard "replacement")

Related question: what about windows that are marked to keep above?

Hybrids (w/ eg. Kais and kdeuser56's comments in mind) are possible as well, 
ie. we could only show "special" docks/panels/windows (which however need to 
indicate relation by marking themselves transient for the desktop or 
"keepabove" - techincal detail, though ;-)

Also see my very first comment on this.

---

Aside this, you may want to comment on the effects, but they're scripts and can 
easily be adjusted and tried w/o compilation once the usability / visual design 
folks have the beta installed or so.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/#review78245
---


On März 30, 2015, 9:06 nachm., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122679/
> ---
> 
> (Updated März 30, 2015, 9:06 nachm.)
> 
> 
> Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco 
> Martin.
> 
> 
> Bugs: 344083
> https://bugs.kde.org/show_bug.cgi?id=344083
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> commit b4e3a736c3643179b5b4ea73f7706918a03483fe
> Author: Thomas Lübking
> Date:   Mon Mar 30 11:38:54 2015 +0200
> 
> add eyeOnScreen effect
> 
> commit 4aaeeda8fbebded0e915b39a54092c586de179ce
> Author: Thomas Lübking
> Date:   Mon Mar 30 11:38:38 2015 +0200
> 
> support gaussian curve and animationEnded signal in ScriptedEffect
> 
> 
> commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:15:57 2015 +0100
>   
>  
>   
> Add effect to move windows to corners on showing the desktop  
>   
>  
> commit d92c46e96fe9fb13403b859c5e334b618d45d268   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:15:22 2015 +0100
> 
> 
> Remove AnimationData wrapper around metadata. Allow to set metadata 
> directly in animation objects 
>   
>   
> commit ed38cf37b26aa15d77c5b73734581055be234233   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:13:41 2015 +0100
>   
>  
> 
> make window elevation scriptable  
>   
>  
> commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d   
>   
>  
> Author: Thomas Lübking  

Re: Review Request 122679: Show Desktop feature: refurbished

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/#review78252
---


Really nice, I love the badbadwindows effect!

Is it intended that the windows stay subtly visible a centimeter at the corner 
of the screen? Imho they should be either completely hidden or stick out 
further, and less transparent, potentially allowing to click them to exit the 
effect (don't know whether that's possible easily). The eyeonwindows enter 
animation is pretty neat actually but the exit animation seems to cause 
seizures ;)

The only issue I've seen so far is when I minimize all windows, then open 
widget settings or containment settings, the dialog does not appear. When then 
exiting the badbadwindows effect, the window suddenly appears (probably wasn't 
registered by the effect) but my panel no longer flies in (should probably stay 
there anyway since eg. widget explorer still reserve space for it?) until I 
restart compositing.

- Kai Uwe Broulik


On März 30, 2015, 9:06 nachm., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122679/
> ---
> 
> (Updated März 30, 2015, 9:06 nachm.)
> 
> 
> Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco 
> Martin.
> 
> 
> Bugs: 344083
> https://bugs.kde.org/show_bug.cgi?id=344083
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> commit b4e3a736c3643179b5b4ea73f7706918a03483fe
> Author: Thomas Lübking
> Date:   Mon Mar 30 11:38:54 2015 +0200
> 
> add eyeOnScreen effect
> 
> commit 4aaeeda8fbebded0e915b39a54092c586de179ce
> Author: Thomas Lübking
> Date:   Mon Mar 30 11:38:38 2015 +0200
> 
> support gaussian curve and animationEnded signal in ScriptedEffect
> 
> 
> commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:15:57 2015 +0100
>   
>  
>   
> Add effect to move windows to corners on showing the desktop  
>   
>  
> commit d92c46e96fe9fb13403b859c5e334b618d45d268   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:15:22 2015 +0100
> 
> 
> Remove AnimationData wrapper around metadata. Allow to set metadata 
> directly in animation objects 
>   
>   
> commit ed38cf37b26aa15d77c5b73734581055be234233   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:13:41 2015 +0100
>   
>  
> 
> make window elevation scriptable  
>   
>  
> commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:12:21 2015 +0100
>   
>  
>  

Re: Review Request 122679: Show Desktop feature: refurbished

[Thomas Lübking]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/
---

(Updated März 30, 2015, 9:06 nachm.)


Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco 
Martin.


Changes
---

* Add one more (alternative) effect (to select from here or later or whatever)
* Therefore support gaussian curves and forward animationEnded


Bugs: 344083
https://bugs.kde.org/show_bug.cgi?id=344083


Repository: kwin


Description (updated)
---

commit b4e3a736c3643179b5b4ea73f7706918a03483fe
Author: Thomas Lübking
Date:   Mon Mar 30 11:38:54 2015 +0200

add eyeOnScreen effect

commit 4aaeeda8fbebded0e915b39a54092c586de179ce
Author: Thomas Lübking
Date:   Mon Mar 30 11:38:38 2015 +0200

support gaussian curve and animationEnded signal in ScriptedEffect


commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 

 
Author: Thomas Lübking  
 
Date:   Sun Mar 29 00:15:57 2015 +0100  

 
  
Add effect to move windows to corners on showing the desktop

 
commit d92c46e96fe9fb13403b859c5e334b618d45d268 

 
Author: Thomas Lübking  
 
Date:   Sun Mar 29 00:15:22 2015 +0100  
  

Remove AnimationData wrapper around metadata. Allow to set metadata 
directly in animation objects   

  
commit ed38cf37b26aa15d77c5b73734581055be234233 

 
Author: Thomas Lübking  
 
Date:   Sun Mar 29 00:13:41 2015 +0100  

 

make window elevation scriptable

 
commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d 

 
Author: Thomas Lübking  
 
Date:   Sun Mar 29 00:12:21 2015 +0100  

 

forward showingDesktop signal to effects

 
commit 570a92331f3691c1fb2affa4f853c75d6062f7e3 

 
Author: Thomas Lübking  
 
Date:   Sun Mar 29 00:08:32 2015 +0100  
  

emit signal when showingDesktop changes   


commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5
Author: Thomas Lübking
Date:   Sun Feb 22 16:41:45 2015 +0100

add "MinimizeAll" script

to compensate withdrawn core feature (which
though has been hidden so far)

commit 983efb916e282d2263b4abcc92f714c06b3bfcc1
Author: Thomas Lübking
Date:   Wed Feb 18 02:09:00 2015 +0100

break showingDesktop w/ tabbox/PW/DG

This is now crucial, because while before (the 

Re: Plasma 5 is awesome...and some help required with build instructions

[David Edmundson]

>
> Any ideas? (attached the output/bt I got from gdb)
>
>
it's an assert in "could not find any theme"

At a guess you XDG_DATA_DIRS are wrong.

cat /proc/PIDOFPLASMASHELL/env will tell you the most



> Thanks :)
>
> Bye,
> Bernhard Friedreich
>
>
>
>
> 2015-03-28 19:23 GMT+01:00 Siddhartha :
>
>> Hi David,
>>
>> Thanks a lot for your comments!
>>
>> On 28 March 2015 at 20:23, David Edmundson 
>> wrote:
>> > I don't think we should tell people to download's  David Faure's
>> > kdesrc-buildrc file. It has "/d" hardcoded a lot.
>> >
>> > If we make our own we don't need people to change it and can have the
>> same
>> > directories you use for the rest of this.
>>
>> Good point. I took this section from Frameworks/Building, didn't think
>> too much :P
>> Maybe we should update that page too?
>>
>> > That's installing to /opt/kde5 but we need to create those directories
>> first
>> > (as root and change permissions)
>>
>> Instructions already present :)
>>
>> > If this is about plasma change:
>> >
>> > include extragear/utils/kdesrc-build/kf5-qt5-build-include
>> >
>> > to
>> > include extragear/utils/kdesrc-build/kf5-frameworks-build-include
>> > include extragear/utils/kdesrc-build/kf5-workspace-build-include
>> >
>> > this way you won't build apps and pim
>>
>> Cool. Changed the whole section.
>>
>> > export XDG_CACHE_HOME=/home/user/.kde5/cache
>> >
>> > only works if you happen to be called user.
>> > I'm pretty sure you can do export XDG_CACHE_HOME=$HOME/.whatever
>>
>> Ah right, fixed.
>>
>> > Personally I wouldn't change the paths, you lose your firefox settings,
>> and
>> > with the .xinitrc hack later you're only going to be loading this
>> session
>> > from now on anyway.
>>
>> Hmm. I preferred having clean Plasma 5 config paths. These lines are
>> now commented out by default.
>>
>> > The setup is a bit broken, if you do the login manager way.
>> > yet if you log into your distro session and then start anything dbus
>> > activated it will load from /opt/kde/install which is at best a bit
>> weird.
>>
>> Ah right. But logging in to a Plasma 4 seemed to work fine. Ideally
>> one should remove the dbus config before starting the distro session,
>> yes.
>>
>> > you need to say login manager way and the .xinit way are mutually
>> exclusive
>> > (well you can do both, but it'd be weird)
>>
>> Done.
>>
>> > add a line saying to log out and back in.
>>
>> Done
>>
>> Cheers!
>> ___
>> Plasma-devel mailing list
>> Plasma-devel@kde.org
>> https://mail.kde.org/mailman/listinfo/plasma-devel
>>
>
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5 is awesome...and some help required with build instructions

[Siddhartha]

Hey Martin,

Thanks for all the comments :)

On 30 March 2015 at 16:11, Martin Klapetek  wrote:
>> sudo chown -R user:group /opt/kde
>
> I think this should either use $USER or `whoami` rather than "user" ?

Hmm good point. Also I learned that leaving the group empty after a
colon automatically sets it to the primary user group. Nice!

>> Uncomment the last two lines if you also want to build the Applications
>> and PIM suite.
>
> This should probably be inside the kdesrc-buildrc itself. Maybe
> it could also have a comment inside about the "make-options -j4"
> needing adjusting and possibly should be mentioned outside too.

Done.

> There's also the "ignore-kde-structure" option, should this perhaps
> be set to true by default? I honestly see a little point having that
> structure mirrored on your disk, it's just confusing and takes time
> to find anything.

I'm a bit torn over this. While you make a good usability point,
having the kde structure groups and separates the modules, thus feels
'cleaner' as compared to everything in a single folder.

However, navigating the whole structure for eg. to import a module
into kdevelop is truly time taking. Enabling it in my local config and
here too :)

> Should that be the default, then I'd also suggest to skip the
> "mkdir -p extragear/utils" in the first steps and just clone directly
> to the sources dir. It's also a bit cumbersome having to go to
> /opt/kde/sources/extragear/utils/kdesrc-build each time you want
> to rebuild things (yeah tab helps but it's still annoying).

Done

> Maybe the kdesrc-build could/should be linked to
> /opt/kde/install/bin (which is added to $PATH)?  Then
> the kdesrc-buildrc would have to be in ~/.kdesrc-buildrc I think.

Hmm. The default config also builds kdesrc-build, so its already in $PATH.
But here we first update kdesrc-build git source and then use it. Bit
better I feel. Anyways, changed the config path to ~/.kdesrc-buildrc,
so either can be used.

> Overall I feel the kdesrc-buildrc could be a bit better documented.

Now its a bit better documented. Please add anything else you feel missing :)

>> #install-session-driver true
>
> This should be removed altogether or documented why is it there.

I never used this. As we already have manual instructions, removing this.
I'll test this sometime and add it back if successful.

>> export QTDIR=/usr/lib/qt
>
> As the kdesrc-buildrc mentions that the path should be changed
> if custom qt is being build, probably it could use a comment here
> as well ("Running Plasma" section).

Done

>> You may try going back to a previous code version (git skills required),
>> or wait sometime for the developers to fix the code.
>
> "...or try helping with fixing it"? ;)

Haha. Of course :)

> Otherwise, thanks for doing that! It rocks.

Cheers!
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5 is awesome...and some help required with build instructions

[Bernhard Friedreich]

Hi,

At first: thanks for the guide :) It's a nice addition to
https://community.kde.org/Frameworks/Building

I've got the following problems:
1.) on my fedora 23 (rawhide) I had to set selinux to permissive mode for
the custom dbus files to be read (otherwise it wouldn't let dbus access
them, maybe it is because I changed paths from /opt to /products?) (yeah I
know decreasing selinux security isn't a solution)
2.) I can start the session from sddm but plasmashell and krunner crash
instantly..

Any ideas? (attached the output/bt I got from gdb)

Thanks :)

Bye,
Bernhard Friedreich




2015-03-28 19:23 GMT+01:00 Siddhartha :

> Hi David,
>
> Thanks a lot for your comments!
>
> On 28 March 2015 at 20:23, David Edmundson 
> wrote:
> > I don't think we should tell people to download's  David Faure's
> > kdesrc-buildrc file. It has "/d" hardcoded a lot.
> >
> > If we make our own we don't need people to change it and can have the
> same
> > directories you use for the rest of this.
>
> Good point. I took this section from Frameworks/Building, didn't think
> too much :P
> Maybe we should update that page too?
>
> > That's installing to /opt/kde5 but we need to create those directories
> first
> > (as root and change permissions)
>
> Instructions already present :)
>
> > If this is about plasma change:
> >
> > include extragear/utils/kdesrc-build/kf5-qt5-build-include
> >
> > to
> > include extragear/utils/kdesrc-build/kf5-frameworks-build-include
> > include extragear/utils/kdesrc-build/kf5-workspace-build-include
> >
> > this way you won't build apps and pim
>
> Cool. Changed the whole section.
>
> > export XDG_CACHE_HOME=/home/user/.kde5/cache
> >
> > only works if you happen to be called user.
> > I'm pretty sure you can do export XDG_CACHE_HOME=$HOME/.whatever
>
> Ah right, fixed.
>
> > Personally I wouldn't change the paths, you lose your firefox settings,
> and
> > with the .xinitrc hack later you're only going to be loading this session
> > from now on anyway.
>
> Hmm. I preferred having clean Plasma 5 config paths. These lines are
> now commented out by default.
>
> > The setup is a bit broken, if you do the login manager way.
> > yet if you log into your distro session and then start anything dbus
> > activated it will load from /opt/kde/install which is at best a bit
> weird.
>
> Ah right. But logging in to a Plasma 4 seemed to work fine. Ideally
> one should remove the dbus config before starting the distro session,
> yes.
>
> > you need to say login manager way and the .xinit way are mutually
> exclusive
> > (well you can do both, but it'd be weird)
>
> Done.
>
> > add a line saying to log out and back in.
>
> Done
>
> Cheers!
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
(gdb) bt
#0  0x76674520 in QQmlComponent::status() const ()
at /lib64/libQt5Qml.so.5
#1  0x7723f832 in 
KDeclarative::QmlObject::completeInitialization(QHash 
const&) (this=0xba4640, initialProperties=...)
at 
/products/kde/sources/frameworks/kdeclarative/src/kdeclarative/qmlobject.cpp:264
#2  0x0040cfc5 in View::View(QWindow*) (this=0x7fffde50)
at /products/kde/sources/kde/workspace/plasma-workspace/krunner/view.cpp:93
#3  0x0040bb58 in main(int, char**) (argc=1, argv=0x7fffe0c8)
at /products/kde/sources/kde/workspace/plasma-workspace/krunner/main.cpp:66

Starting program: /products/kde/install/bin/plasmashell 
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
kf5.kiconthemes: "Theme tree: (Breeze)"
kf5.kservice.sycoca: Trying to open ksycoca from 
"/home/friedreb/.cache/ksycoca5"
populateAddPanelsMenu 1
Failed to load the OSD script file from ""
[New Thread 0x7fffd26bf700 (LWP 2216)]
"" has no desktop group, cannot construct a KPluginInfo object from it.
Detaching after fork from child process 2218.
kscreen: launcherDataAvailable: "org.kde.KScreen.Backend.XRandR"
kscreen: Launcher finished with exit code 1 , status 0
kscreen: Service for requested backend already running
kscreen: Primary output changed from KScreen::Output(Id: 118 , Name: "LVDS1" ) 
( "LVDS1" ) to KScreen::Output(Id: 118 , Name: "LVDS1" ) ( "LVDS1" )
Error loading plugin "plasma_applet_timer" "Die dynamische Bibliothek konnte 
nicht gefunden werden." 
Plugin search paths are ("/usr/lib64/qt5/plugins", "/products/kde/install/bin") 
The environment variable QT_PLUGIN_PATH might be not correctly set
unversioned plugin detected, may result in instability
Error loading plugin "plasma_applet_timer" "Die dynamische Bibliothek konnte 
nicht gefunden werden." 
Plugin search paths are ("/usr/lib64/qt5/plugins", "/products/kde/install/bin") 
The environment variable QT_PLUGIN_PATH might be not correctly set
Could not load applet "org.kde.plasma.timer" ! reason given: "Die dynamische 
Bibliothek konnte nicht gefunden werden." Falling back to an empty one
Con

Re: Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4

[David Edmundson]

> On March 30, 2015, 6:06 p.m., Hugo Pereira Da Costa wrote:
> > in principle, ship it. The approach is sound. (indeed KDE4 oxygen and hence 
> > breeze moved away from KStyle at some point in the past because it was 
> > bringing more issues than solving. Copied the said code from kstyle to 
> > these back then. Then with kf5, kstyle got cleaned up *a lot*, so it could 
> > be re-used, the duplicated code was thus removed, leaving the hole that you 
> > are now filling again)
> > 
> > Thanks ! 
> > 
> > However, please check what's the thing with breezegenericdata in the diff. 
> > As is I could not apply the patch (there are some rejs) and this generic 
> > data stuff should be quite unrelated. Do you have another patch around ? 
> > 
> > Hugo
> 
> David Edmundson wrote:
> OK, two things.
> 1) my patch was super old. I have a repo in my kde4 folder and my kde5 
> source folder, and I didn't git pull. Rebased and reuploading
> 2) I have no idea what that thing about breezegenericdata is about, it's 
> not in my patch. I think it might be RB trying to be clever
> 
> David Edmundson wrote:
> still shows it, if it's a problem I can just push into a branch.
> 
> Hugo Pereira Da Costa wrote:
> funny. The patch itself includes:
> 
> diff --git a/kstyle/animations/breezegenericdata.cpp 
> b/kstyle/kstylekde4compat.h
> similarity index 67%
> copy from kstyle/animations/breezegenericdata.cpp
> copy to kstyle/kstylekde4compat.h
> 
> why would that be ? Is for some reason the file breezegenericdata gone 
> from your local dir ?

reviewboard must be mangling it. I've checked in git show, and in qgit which 
lists the files changes and it's all fine.


Pushed to davidedmundson/kde4stylehints if you wanted to see it.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123188/#review78237
---


On March 30, 2015, 6:22 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123188/
> ---
> 
> (Updated March 30, 2015, 6:22 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Some important style hints are supplied by the KStyle class, mostly
> importantly whether listviews activate folders on single or double
> click.
> 
> For frameworks this now exists in KStyle, so code was not included in
> Breeze and latest Oxygen. However for KDE4 builds we still need this
> code.
> 
> There is a KDE4 kstyle class, but this behvaiour is very different and
> causes conflicts and a lot of other problems. Re-implementing the part
> we need seems the easier approach
> 
> 
> Diffs
> -
> 
>   kstyle/CMakeLists.txt e13a13d 
>   kstyle/animations/breezegenericdata.cpp aa7c154 
>   kstyle/breezestyle.h f9df1e8 
>   kstyle/kstylekde4compat.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123188/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122679: Show Desktop feature: refurbished

[Thomas Pfeiffer]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/#review78245
---


Was adding the usability group more meant as a heads-up to inform us that 
things are happening on this front, or are you expecting an actual usability 
review?
In the latter case, we'd need some kind of visualization or at least detailed 
description of what is happening on the UI side, since we can't read code all 
that well ;)

- Thomas Pfeiffer


On March 28, 2015, 11:24 p.m., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122679/
> ---
> 
> (Updated March 28, 2015, 11:24 p.m.)
> 
> 
> Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco 
> Martin.
> 
> 
> Bugs: 344083
> https://bugs.kde.org/show_bug.cgi?id=344083
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:15:57 2015 +0100
>   
>  
>   
> Add effect to move windows to corners on showing the desktop  
>   
>  
> commit d92c46e96fe9fb13403b859c5e334b618d45d268   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:15:22 2015 +0100
> 
> 
> Remove AnimationData wrapper around metadata. Allow to set metadata 
> directly in animation objects 
>   
>   
> commit ed38cf37b26aa15d77c5b73734581055be234233   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:13:41 2015 +0100
>   
>  
> 
> make window elevation scriptable  
>   
>  
> commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:12:21 2015 +0100
>   
>  
> 
> forward showingDesktop signal to effects  
>   
>  
> commit 570a92331f3691c1fb2affa4f853c75d6062f7e3   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:08:32 2015 +0100
> 
> 
> emit signal when showingDesktop changes   
> 
> 
> commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5
> Author: Thomas Lübking
> Date:   Sun Feb 22 16:41:45 2015 +0100
> 
>

Re: Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4

[Hugo Pereira Da Costa]

> On March 30, 2015, 6:06 p.m., Hugo Pereira Da Costa wrote:
> > in principle, ship it. The approach is sound. (indeed KDE4 oxygen and hence 
> > breeze moved away from KStyle at some point in the past because it was 
> > bringing more issues than solving. Copied the said code from kstyle to 
> > these back then. Then with kf5, kstyle got cleaned up *a lot*, so it could 
> > be re-used, the duplicated code was thus removed, leaving the hole that you 
> > are now filling again)
> > 
> > Thanks ! 
> > 
> > However, please check what's the thing with breezegenericdata in the diff. 
> > As is I could not apply the patch (there are some rejs) and this generic 
> > data stuff should be quite unrelated. Do you have another patch around ? 
> > 
> > Hugo
> 
> David Edmundson wrote:
> OK, two things.
> 1) my patch was super old. I have a repo in my kde4 folder and my kde5 
> source folder, and I didn't git pull. Rebased and reuploading
> 2) I have no idea what that thing about breezegenericdata is about, it's 
> not in my patch. I think it might be RB trying to be clever
> 
> David Edmundson wrote:
> still shows it, if it's a problem I can just push into a branch.

funny. The patch itself includes:

diff --git a/kstyle/animations/breezegenericdata.cpp b/kstyle/kstylekde4compat.h
similarity index 67%
copy from kstyle/animations/breezegenericdata.cpp
copy to kstyle/kstylekde4compat.h

why would that be ? Is for some reason the file breezegenericdata gone from 
your local dir ?


- Hugo


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123188/#review78237
---


On March 30, 2015, 6:22 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123188/
> ---
> 
> (Updated March 30, 2015, 6:22 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Some important style hints are supplied by the KStyle class, mostly
> importantly whether listviews activate folders on single or double
> click.
> 
> For frameworks this now exists in KStyle, so code was not included in
> Breeze and latest Oxygen. However for KDE4 builds we still need this
> code.
> 
> There is a KDE4 kstyle class, but this behvaiour is very different and
> causes conflicts and a lot of other problems. Re-implementing the part
> we need seems the easier approach
> 
> 
> Diffs
> -
> 
>   kstyle/CMakeLists.txt e13a13d 
>   kstyle/animations/breezegenericdata.cpp aa7c154 
>   kstyle/breezestyle.h f9df1e8 
>   kstyle/kstylekde4compat.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123188/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4

[David Edmundson]

> On March 30, 2015, 6:06 p.m., Hugo Pereira Da Costa wrote:
> > in principle, ship it. The approach is sound. (indeed KDE4 oxygen and hence 
> > breeze moved away from KStyle at some point in the past because it was 
> > bringing more issues than solving. Copied the said code from kstyle to 
> > these back then. Then with kf5, kstyle got cleaned up *a lot*, so it could 
> > be re-used, the duplicated code was thus removed, leaving the hole that you 
> > are now filling again)
> > 
> > Thanks ! 
> > 
> > However, please check what's the thing with breezegenericdata in the diff. 
> > As is I could not apply the patch (there are some rejs) and this generic 
> > data stuff should be quite unrelated. Do you have another patch around ? 
> > 
> > Hugo
> 
> David Edmundson wrote:
> OK, two things.
> 1) my patch was super old. I have a repo in my kde4 folder and my kde5 
> source folder, and I didn't git pull. Rebased and reuploading
> 2) I have no idea what that thing about breezegenericdata is about, it's 
> not in my patch. I think it might be RB trying to be clever

still shows it, if it's a problem I can just push into a branch.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123188/#review78237
---


On March 30, 2015, 6:22 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123188/
> ---
> 
> (Updated March 30, 2015, 6:22 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Some important style hints are supplied by the KStyle class, mostly
> importantly whether listviews activate folders on single or double
> click.
> 
> For frameworks this now exists in KStyle, so code was not included in
> Breeze and latest Oxygen. However for KDE4 builds we still need this
> code.
> 
> There is a KDE4 kstyle class, but this behvaiour is very different and
> causes conflicts and a lot of other problems. Re-implementing the part
> we need seems the easier approach
> 
> 
> Diffs
> -
> 
>   kstyle/CMakeLists.txt e13a13d 
>   kstyle/animations/breezegenericdata.cpp aa7c154 
>   kstyle/breezestyle.h f9df1e8 
>   kstyle/kstylekde4compat.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123188/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4

[David Edmundson]

> On March 30, 2015, 6:06 p.m., Hugo Pereira Da Costa wrote:
> > in principle, ship it. The approach is sound. (indeed KDE4 oxygen and hence 
> > breeze moved away from KStyle at some point in the past because it was 
> > bringing more issues than solving. Copied the said code from kstyle to 
> > these back then. Then with kf5, kstyle got cleaned up *a lot*, so it could 
> > be re-used, the duplicated code was thus removed, leaving the hole that you 
> > are now filling again)
> > 
> > Thanks ! 
> > 
> > However, please check what's the thing with breezegenericdata in the diff. 
> > As is I could not apply the patch (there are some rejs) and this generic 
> > data stuff should be quite unrelated. Do you have another patch around ? 
> > 
> > Hugo

OK, two things.
1) my patch was super old. I have a repo in my kde4 folder and my kde5 source 
folder, and I didn't git pull. Rebased and reuploading
2) I have no idea what that thing about breezegenericdata is about, it's not in 
my patch. I think it might be RB trying to be clever


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123188/#review78237
---


On March 30, 2015, 4:36 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123188/
> ---
> 
> (Updated March 30, 2015, 4:36 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Some important style hints are supplied by the KStyle class, mostly
> importantly whether listviews activate folders on single or double
> click.
> 
> For frameworks this now exists in KStyle, so code was not included in
> Breeze and latest Oxygen. However for KDE4 builds we still need this
> code.
> 
> There is a KDE4 kstyle class, but this behvaiour is very different and
> causes conflicts and a lot of other problems. Re-implementing the part
> we need seems the easier approach
> 
> 
> Diffs
> -
> 
>   kstyle/CMakeLists.txt 04d646b 
>   kstyle/animations/breezegenericdata.cpp 4add8bc 
>   kstyle/breezestyle.h 54192c3 
>   kstyle/kstylekde4compat.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123188/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123188/
---

(Updated March 30, 2015, 6:22 p.m.)


Review request for Plasma and Hugo Pereira Da Costa.


Repository: breeze


Description
---

Some important style hints are supplied by the KStyle class, mostly
importantly whether listviews activate folders on single or double
click.

For frameworks this now exists in KStyle, so code was not included in
Breeze and latest Oxygen. However for KDE4 builds we still need this
code.

There is a KDE4 kstyle class, but this behvaiour is very different and
causes conflicts and a lot of other problems. Re-implementing the part
we need seems the easier approach


Diffs (updated)
-

  kstyle/CMakeLists.txt e13a13d 
  kstyle/animations/breezegenericdata.cpp aa7c154 
  kstyle/breezestyle.h f9df1e8 
  kstyle/kstylekde4compat.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/123188/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4

[Hugo Pereira Da Costa]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123188/#review78237
---


in principle, ship it. The approach is sound. (indeed KDE4 oxygen and hence 
breeze moved away from KStyle at some point in the past because it was bringing 
more issues than solving. Copied the said code from kstyle to these back then. 
Then with kf5, kstyle got cleaned up *a lot*, so it could be re-used, the 
duplicated code was thus removed, leaving the hole that you are now filling 
again)

Thanks ! 

However, please check what's the thing with breezegenericdata in the diff. As 
is I could not apply the patch (there are some rejs) and this generic data 
stuff should be quite unrelated. Do you have another patch around ? 

Hugo

- Hugo Pereira Da Costa


On March 30, 2015, 4:36 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123188/
> ---
> 
> (Updated March 30, 2015, 4:36 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Some important style hints are supplied by the KStyle class, mostly
> importantly whether listviews activate folders on single or double
> click.
> 
> For frameworks this now exists in KStyle, so code was not included in
> Breeze and latest Oxygen. However for KDE4 builds we still need this
> code.
> 
> There is a KDE4 kstyle class, but this behvaiour is very different and
> causes conflicts and a lot of other problems. Re-implementing the part
> we need seems the easier approach
> 
> 
> Diffs
> -
> 
>   kstyle/CMakeLists.txt 04d646b 
>   kstyle/animations/breezegenericdata.cpp 4add8bc 
>   kstyle/breezestyle.h 54192c3 
>   kstyle/kstylekde4compat.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123188/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123188/
---

Review request for Plasma and Hugo Pereira Da Costa.


Repository: breeze


Description
---

Some important style hints are supplied by the KStyle class, mostly
importantly whether listviews activate folders on single or double
click.

For frameworks this now exists in KStyle, so code was not included in
Breeze and latest Oxygen. However for KDE4 builds we still need this
code.

There is a KDE4 kstyle class, but this behvaiour is very different and
causes conflicts and a lot of other problems. Re-implementing the part
we need seems the easier approach


Diffs
-

  kstyle/CMakeLists.txt 04d646b 
  kstyle/animations/breezegenericdata.cpp 4add8bc 
  kstyle/breezestyle.h 54192c3 
  kstyle/kstylekde4compat.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/123188/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123164: Add new Bluetooth applet

[Xuetian Weng]

> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > File Attachment: snapshot5.png - snapshot5.png
> > 
> >
> > I wouldn't show the ID right at a glance. That's super geeky. Hide that 
> > in the details section.
> 
> David Rosca wrote:
> Hmm, you are right. But what to show there instead?
> 
> Kai Uwe Broulik wrote:
> Nothing? :)
> 
> David Rosca wrote:
> Maybe type of the device (Phone, Mouse, ...), but that can already be 
> seen from the icon.
> I don't know .. it looks empty without it.

What about what kinds of profile are being used?


- Xuetian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/#review78179
---


On March 29, 2015, 8:13 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123164/
> ---
> 
> (Updated March 29, 2015, 8:13 p.m.)
> 
> 
> Review request for Bluedevil and Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> This is a replacement for bluedevil-monolithic.
> The code is based on network management plasmoid and it does basically the 
> same but for Bluetooth devices.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 94b56fb 
>   src/CMakeLists.txt b804f2b 
>   src/applet/CMakeLists.txt PRE-CREATION 
>   src/applet/Messages.sh PRE-CREATION 
>   src/applet/package/contents/code/logic.js PRE-CREATION 
>   src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
>   src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
>   src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/Header.qml PRE-CREATION 
>   src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
>   src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
>   src/applet/package/metadata.desktop PRE-CREATION 
>   src/applet/plugin/CMakeLists.txt PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.h PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.h PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
>   src/applet/plugin/launchapp.h PRE-CREATION 
>   src/applet/plugin/launchapp.cpp PRE-CREATION 
>   src/applet/plugin/notify.h PRE-CREATION 
>   src/applet/plugin/notify.cpp PRE-CREATION 
>   src/applet/plugin/qmldir PRE-CREATION 
>   src/bluedevil.notifyrc 72257ed 
> 
> Diff: https://git.reviewboard.kde.org/r/123164/diff/
> 
> 
> Testing
> ---
> 
> I've been running it for some time already and it works fine.
> 
> 
> File Attachments
> 
> 
> snapshot4.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
> snapshot5.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Release Dates for August

[Jonathan Riddell]

Plasma 5.4 release schedule needs writing and keeping to our 3 months
would release in July.  That puts the release during Akademy so it
needs shifting.

Baloo wants to move from Plasma to Frameworks.  At the same time it
will get a shiny new database which makes it incompatible with baloo
for kdelibs4 so Dolphin will stop working until the Qt 5 version of
Dolphin comes out.

So here's a proposal to move Plasma to August when Applications is
presumably due to release.  Aligning the schedules will allow the
move/incompatible nature of the Baloo changes to be all done together.

See dates with question mark on August on this calendar.

https://www.google.com/calendar/embed?src=031gkgqg1hjf8lcmj0em1d2sj8%40group.calendar.google.com&ctz=Europe/Madrid

Comments?

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Plasma 5 Bugs Saved Searches

[Jonathan Riddell]

I've made some searches for Plasma 5 bugs which you can find if you
log in and go to

https://bugs.kde.org/userprefs.cgi?tab=saved-searches

Plasma5-All has all open bugs in products that are part of the Plasma releases.
  
https://bugs.kde.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=Plasma5-All&sharer_id=13271

2588 open bugs(!)

Plasma5-All-Critical has open bugs that are marked critical, I'll
check these before each release to make sure it's ok to release with
them so if you have release blockers do mark them as critical.
  
https://bugs.kde.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=Plasma5-All-Critical&sharer_id=13271

7 critical open bugs

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Minutes Monday Plasma Hangout

[Bhushan Shah]

On Mon, Mar 30, 2015 at 4:40 PM, Marco Martin  wrote:
> minutes of hangout from 30 march 2015:

Bhushan Shah:

- Bug fixes
 > Lockscreen password field focus fix.
 > 1 pixel gap between right aligned panel and screen edge
- VDG thread for TV optimized dashboard support in PMC
https://forum.kde.org/viewtopic.php?f=285&t=125594
- Planned more bugfixes

-- 
Bhushan Shah

http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Next Plasma Hangout

[Marco Martin]

Hi all,
since next monday is a public holiday in most of europe, the next plasma 
hangout will be 
Tuesday 7 April
at 12:00 as usual

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Minutes Monday Plasma Hangout

[Marco Martin]

minutes of hangout from 30 march 2015:

Antonis:
- will work on bug fixing

David:
- highdpi stuff
- merged highdpi branches in frameworks and dolphin (dolphin5 will be in 
August release)
- ported kgamma to Kf5

Harald:
- https://git.reviewboard.kde.org/r/123147/ is blocking kubuntu ci
- mixer applet will be hopefully in 5.3

Jonathan:
- released Plasma 5.2.2
- freeze for 5.3 in qo days! get fixes and features soon
- will help testing modemmanager and bluetooth stuff moving to frameworks
- will contact systemd kcm maintainer to eventually merge

Vishesh:
- baloo will be a framework: will break dolphin4, needs qt5 dolphin, synced 
release
- needs other ideas how to manage the migration to the new db
- will RFC packagers mailinglist
- worked on some krunner bugs
- working on koko

Kai Uwe:
- postpone mediacontrols on lockscreen since needs privacy settings
- merged icondialog QML component
- either Kai or David will merge the energy kinfocenter module

Martin G:
- Wayland week: touch support both in client and server libs
- forwards events to the proper client
- forum thread for global touch gestures
- started framebuffer device for kwin wayland, can render with qpainter 
backend without weston (will try to integrate in 5.3)
- needs support for ctrl+alt+F1 etc
- looking in virtual terminal integration

Clemens:
- experimenting with Plasma on Raspberry Pi 2
- kde4.14.2 working already
- plasma5 not starting, probably due to opengl problems
- beta testing of Kubuntu KCI, reporting most serious issues

Marco:
- merged QML kcms stuff, blogged at 
http://notmart.org/blog/2015/03/writing-qml-based-apps-the-kde-way/
- lookandfeel and splashscreen are ported
- did some bugfixes, most important a crash that always happened with framesvg 
when high DPI
- next week will do more bugfix: especially on on the fly change for plasma 
themes

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5 is awesome...and some help required with build instructions

[Martin Klapetek]

Good stuff!

Here are my comments:

> sudo chown -R user:group /opt/kde

I think this should either use $USER or `whoami` rather than "user" ?


> Uncomment the last two lines if you also want to build the Applications
and PIM suite.

This should probably be inside the kdesrc-buildrc itself. Maybe
it could also have a comment inside about the "make-options -j4"
needing adjusting and possibly should be mentioned outside too.

There's also the "ignore-kde-structure" option, should this perhaps
be set to true by default? I honestly see a little point having that
structure mirrored on your disk, it's just confusing and takes time
to find anything.

Should that be the default, then I'd also suggest to skip the
"mkdir -p extragear/utils" in the first steps and just clone directly
to the sources dir. It's also a bit cumbersome having to go to
/opt/kde/sources/extragear/utils/kdesrc-build each time you want
to rebuild things (yeah tab helps but it's still annoying).

Maybe the kdesrc-build could/should be linked to
/opt/kde/install/bin (which is added to $PATH)?  Then
the kdesrc-buildrc would have to be in ~/.kdesrc-buildrc I think.

Overall I feel the kdesrc-buildrc could be a bit better documented.


> #install-session-driver true

This should be removed altogether or documented why is it there.


> export QTDIR=/usr/lib/qt

As the kdesrc-buildrc mentions that the path should be changed
if custom qt is being build, probably it could use a comment here
as well ("Running Plasma" section).


> You may try going back to a previous code version (git skills required),
> or wait sometime for the developers to fix the code.

"...or try helping with fixing it"? ;)

Otherwise, thanks for doing that! It rocks.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123147: do not install so link if the headers are not being installed

[Harald Sitter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123147/
---

(Updated March 30, 2015, 10:28 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit e1b142a8970d44090592a7573c55f6b4e76995c9 by Harald Sitter 
to branch master.


Repository: plasma-desktop


Description
---

in the no-install-header mode it keeps the library entirely private by
not installing the symlink, whereas when installing the headers the so
link is also being installed.


Diffs
-

  lib/kactivities-stats/src/lib/stats/CMakeLists.txt 
f58aa5d9bd200b3c037a5e7e5a7ad893bbae956e 

Diff: https://git.reviewboard.kde.org/r/123147/diff/


Testing
---

make -j9; make install DESTDIR=. --> doesn't install .so

change experimental header install variable to true --> installs .so


Thanks,

Harald Sitter

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123147: do not install so link if the headers are not being installed

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123147/#review78210
---

Ship it!


Ship It!

- David Edmundson


On March 27, 2015, 8:31 a.m., Harald Sitter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123147/
> ---
> 
> (Updated March 27, 2015, 8:31 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> in the no-install-header mode it keeps the library entirely private by
> not installing the symlink, whereas when installing the headers the so
> link is also being installed.
> 
> 
> Diffs
> -
> 
>   lib/kactivities-stats/src/lib/stats/CMakeLists.txt 
> f58aa5d9bd200b3c037a5e7e5a7ad893bbae956e 
> 
> Diff: https://git.reviewboard.kde.org/r/123147/diff/
> 
> 
> Testing
> ---
> 
> make -j9; make install DESTDIR=. --> doesn't install .so
> 
> change experimental header install variable to true --> installs .so
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123164: Add new Bluetooth applet

[David Rosca]

> On March 30, 2015, 8:42 a.m., Emmanuel Pescosta wrote:
> > src/applet/package/contents/code/logic.js, line 34
> > 
> >
> > array.filter() maybe?

Nope, doesn't work:

TypeError: Property 'filter' of object [object Object] is not a function

probably because it is a QQmlListProperty and not a javascript array.


> On March 30, 2015, 8:42 a.m., Emmanuel Pescosta wrote:
> > src/applet/package/contents/code/logic.js, line 52
> > 
> >
> > array.forEach() maybe?

Same as above


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/#review78206
---


On March 29, 2015, 8:13 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123164/
> ---
> 
> (Updated March 29, 2015, 8:13 p.m.)
> 
> 
> Review request for Bluedevil and Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> This is a replacement for bluedevil-monolithic.
> The code is based on network management plasmoid and it does basically the 
> same but for Bluetooth devices.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 94b56fb 
>   src/CMakeLists.txt b804f2b 
>   src/applet/CMakeLists.txt PRE-CREATION 
>   src/applet/Messages.sh PRE-CREATION 
>   src/applet/package/contents/code/logic.js PRE-CREATION 
>   src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
>   src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
>   src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/Header.qml PRE-CREATION 
>   src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
>   src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
>   src/applet/package/metadata.desktop PRE-CREATION 
>   src/applet/plugin/CMakeLists.txt PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.h PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.h PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
>   src/applet/plugin/launchapp.h PRE-CREATION 
>   src/applet/plugin/launchapp.cpp PRE-CREATION 
>   src/applet/plugin/notify.h PRE-CREATION 
>   src/applet/plugin/notify.cpp PRE-CREATION 
>   src/applet/plugin/qmldir PRE-CREATION 
>   src/bluedevil.notifyrc 72257ed 
> 
> Diff: https://git.reviewboard.kde.org/r/123164/diff/
> 
> 
> Testing
> ---
> 
> I've been running it for some time already and it works fine.
> 
> 
> File Attachments
> 
> 
> snapshot4.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
> snapshot5.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: System Settings app design freshening

[Marco Martin]

On Sunday 29 March 2015, Andrew Lake wrote:
> As noted on that page, this is *not* a proposal for the kcm designs; just
> the system settings application. So ignore the kcm mockups and focus on the
> system settings stuff. As always, we can tweak the proposal, as necessary,
> to adjust to implementation challenges.

what would the left sidebar do in the first mockup where everything is shown?

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123164: Add new Bluetooth applet

[Emmanuel Pescosta]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/#review78206
---



src/applet/package/contents/code/logic.js (line 34)


array.filter() maybe?



src/applet/package/contents/code/logic.js (line 52)


array.forEach() maybe?


- Emmanuel Pescosta


On March 29, 2015, 10:13 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123164/
> ---
> 
> (Updated March 29, 2015, 10:13 p.m.)
> 
> 
> Review request for Bluedevil and Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> This is a replacement for bluedevil-monolithic.
> The code is based on network management plasmoid and it does basically the 
> same but for Bluetooth devices.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 94b56fb 
>   src/CMakeLists.txt b804f2b 
>   src/applet/CMakeLists.txt PRE-CREATION 
>   src/applet/Messages.sh PRE-CREATION 
>   src/applet/package/contents/code/logic.js PRE-CREATION 
>   src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
>   src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
>   src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/Header.qml PRE-CREATION 
>   src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
>   src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
>   src/applet/package/metadata.desktop PRE-CREATION 
>   src/applet/plugin/CMakeLists.txt PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.h PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.h PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
>   src/applet/plugin/launchapp.h PRE-CREATION 
>   src/applet/plugin/launchapp.cpp PRE-CREATION 
>   src/applet/plugin/notify.h PRE-CREATION 
>   src/applet/plugin/notify.cpp PRE-CREATION 
>   src/applet/plugin/qmldir PRE-CREATION 
>   src/bluedevil.notifyrc 72257ed 
> 
> Diff: https://git.reviewboard.kde.org/r/123164/diff/
> 
> 
> Testing
> ---
> 
> I've been running it for some time already and it works fine.
> 
> 
> File Attachments
> 
> 
> snapshot4.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
> snapshot5.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122679: Show Desktop feature: refurbished

[Thomas Lübking]

> On März 30, 2015, 6:02 vorm., Martin Gräßlin wrote:
> > effects/CMakeLists.txt, line 133
> > 
> >
> > the name looks a little bit "mhhh" ;-)
> 
> Thomas Lübking wrote:
> When thinking about a name that does not sound like a description ("Show 
> Desktop by moving windows to corners"...) I got a "Bad Window" request and 
> had a flash on bad children and corners. Maybe the new konqui images had a 
> play in this as well... :-P
> 
> We could rename is "Windows to corners" or something - less striking, 
> though ;-)
> 
> Martin Gräßlin wrote:
> Maybe something like "showingdesktophelper"?

I'll read that as a joke? =)

"Window Aperture"?

Everybody else: feel free to suggest a nice, striking or stupid name.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/#review78192
---


On März 28, 2015, 11:24 nachm., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122679/
> ---
> 
> (Updated März 28, 2015, 11:24 nachm.)
> 
> 
> Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco 
> Martin.
> 
> 
> Bugs: 344083
> https://bugs.kde.org/show_bug.cgi?id=344083
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:15:57 2015 +0100
>   
>  
>   
> Add effect to move windows to corners on showing the desktop  
>   
>  
> commit d92c46e96fe9fb13403b859c5e334b618d45d268   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:15:22 2015 +0100
> 
> 
> Remove AnimationData wrapper around metadata. Allow to set metadata 
> directly in animation objects 
>   
>   
> commit ed38cf37b26aa15d77c5b73734581055be234233   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:13:41 2015 +0100
>   
>  
> 
> make window elevation scriptable  
>   
>  
> commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:12:21 2015 +0100
>   
>  
> 
> forward showingDesktop signal to effects  
>   
>  
> commit 570a92331f3691c1fb2affa4f853c75d6062f7e3   
>   
> 

Re: Review Request 122679: Show Desktop feature: refurbished

[Thomas Lübking]

> On März 30, 2015, 7:55 vorm., Martin Gräßlin wrote:
> > effects/badbadwindows/package/contents/code/main.js, line 5
> > 
> >
> > isn't it yours?

Yes, had seen that (and fixed it, but didn't finish the eye On Screen patch 
yesterday)
Surprise: I just copy existing effects to generate the filestructure ;-)


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/#review78200
---


On März 28, 2015, 11:24 nachm., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122679/
> ---
> 
> (Updated März 28, 2015, 11:24 nachm.)
> 
> 
> Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco 
> Martin.
> 
> 
> Bugs: 344083
> https://bugs.kde.org/show_bug.cgi?id=344083
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:15:57 2015 +0100
>   
>  
>   
> Add effect to move windows to corners on showing the desktop  
>   
>  
> commit d92c46e96fe9fb13403b859c5e334b618d45d268   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:15:22 2015 +0100
> 
> 
> Remove AnimationData wrapper around metadata. Allow to set metadata 
> directly in animation objects 
>   
>   
> commit ed38cf37b26aa15d77c5b73734581055be234233   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:13:41 2015 +0100
>   
>  
> 
> make window elevation scriptable  
>   
>  
> commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:12:21 2015 +0100
>   
>  
> 
> forward showingDesktop signal to effects  
>   
>  
> commit 570a92331f3691c1fb2affa4f853c75d6062f7e3   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:08:32 2015 +0100
> 
> 
> emit signal when showingDesktop changes   
> 
> 
> commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5
> Author: Thomas

Re: Review Request 122679: Show Desktop feature: refurbished

[Martin Gräßlin]

> On March 30, 2015, 8:02 a.m., Martin Gräßlin wrote:
> > effects/CMakeLists.txt, line 133
> > 
> >
> > the name looks a little bit "mhhh" ;-)
> 
> Thomas Lübking wrote:
> When thinking about a name that does not sound like a description ("Show 
> Desktop by moving windows to corners"...) I got a "Bad Window" request and 
> had a flash on bad children and corners. Maybe the new konqui images had a 
> play in this as well... :-P
> 
> We could rename is "Windows to corners" or something - less striking, 
> though ;-)

Maybe something like "showingdesktophelper"?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/#review78192
---


On March 29, 2015, 12:24 a.m., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122679/
> ---
> 
> (Updated March 29, 2015, 12:24 a.m.)
> 
> 
> Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco 
> Martin.
> 
> 
> Bugs: 344083
> https://bugs.kde.org/show_bug.cgi?id=344083
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:15:57 2015 +0100
>   
>  
>   
> Add effect to move windows to corners on showing the desktop  
>   
>  
> commit d92c46e96fe9fb13403b859c5e334b618d45d268   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:15:22 2015 +0100
> 
> 
> Remove AnimationData wrapper around metadata. Allow to set metadata 
> directly in animation objects 
>   
>   
> commit ed38cf37b26aa15d77c5b73734581055be234233   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:13:41 2015 +0100
>   
>  
> 
> make window elevation scriptable  
>   
>  
> commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:12:21 2015 +0100
>   
>  
> 
> forward showingDesktop signal to effects  
>   
>  
> commit 570a92331f3691c1fb2affa4f853c75d6062f7e3   
>   
>  
> Author: Thomas Lübking
>   

Re: Review Request 122679: Show Desktop feature: refurbished

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/#review78200
---



effects/badbadwindows/package/contents/code/main.js (line 5)


isn't it yours?


- Martin Gräßlin


On March 29, 2015, 12:24 a.m., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122679/
> ---
> 
> (Updated March 29, 2015, 12:24 a.m.)
> 
> 
> Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco 
> Martin.
> 
> 
> Bugs: 344083
> https://bugs.kde.org/show_bug.cgi?id=344083
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:15:57 2015 +0100
>   
>  
>   
> Add effect to move windows to corners on showing the desktop  
>   
>  
> commit d92c46e96fe9fb13403b859c5e334b618d45d268   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:15:22 2015 +0100
> 
> 
> Remove AnimationData wrapper around metadata. Allow to set metadata 
> directly in animation objects 
>   
>   
> commit ed38cf37b26aa15d77c5b73734581055be234233   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:13:41 2015 +0100
>   
>  
> 
> make window elevation scriptable  
>   
>  
> commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:12:21 2015 +0100
>   
>  
> 
> forward showingDesktop signal to effects  
>   
>  
> commit 570a92331f3691c1fb2affa4f853c75d6062f7e3   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:08:32 2015 +0100
> 
> 
> emit signal when showingDesktop changes   
> 
> 
> commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5
> Author: Thomas Lübking
> Date:   Sun Feb 22 16:41:45 2015 +0100
> 
> add "MinimizeAll" script
> 
> to compensate withdrawn core feature (which
> though has been hidden so far)
> 
> commit 983efb916e282d2263b4abcc92f714c06b3bfcc1
> Author: Thoma

Re: Review Request 122679: Show Desktop feature: refurbished

[Thomas Lübking]

> On März 30, 2015, 6:02 vorm., Martin Gräßlin wrote:
> > Can we be sure that the change reguarding AnimationData in the 
> > ScriptedEffects doesn't break the existing effects?

See scriptedeffect.cpp lines 251,  280.
The AnimationData pointer was hardcoded to nullptr, metaFromData thus NOOP.
There may be scripts creating AnimationData objects, but they won't work ;-)


> On März 30, 2015, 6:02 vorm., Martin Gräßlin wrote:
> > effects/CMakeLists.txt, line 133
> > 
> >
> > the name looks a little bit "mhhh" ;-)

When thinking about a name that does not sound like a description ("Show 
Desktop by moving windows to corners"...) I got a "Bad Window" request and had 
a flash on bad children and corners. Maybe the new konqui images had a play in 
this as well... :-P

We could rename is "Windows to corners" or something - less striking, though ;-)


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/#review78192
---


On März 28, 2015, 11:24 nachm., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122679/
> ---
> 
> (Updated März 28, 2015, 11:24 nachm.)
> 
> 
> Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco 
> Martin.
> 
> 
> Bugs: 344083
> https://bugs.kde.org/show_bug.cgi?id=344083
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:15:57 2015 +0100
>   
>  
>   
> Add effect to move windows to corners on showing the desktop  
>   
>  
> commit d92c46e96fe9fb13403b859c5e334b618d45d268   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:15:22 2015 +0100
> 
> 
> Remove AnimationData wrapper around metadata. Allow to set metadata 
> directly in animation objects 
>   
>   
> commit ed38cf37b26aa15d77c5b73734581055be234233   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:13:41 2015 +0100
>   
>  
> 
> make window elevation scriptable  
>   
>  
> commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d   
>   
>  
> Author: Thomas Lübking
>
> Date:   Sun Mar 29 00:12:21 2015 +0100
>   
>  
> 
> forward showingDesktop signal to effects  
>   
>  
> commit 570a92331f3691c1fb2affa4f853c75d6062f