Re: ISO for 2015-04-03
On Fri, Apr 3, 2015 at 10:11 AM, Martin Gräßlin mgraess...@kde.org wrote: On Friday 03 April 2015 09:34:45 Harald Sitter wrote: http://files.kde.org/snapshots/unstable-amd64-latest.iso.mirrorlist # changes - screenlocker is disabled in the live session - mouse cursor should use the breeze theme everywhere now - plasma-nm has been migrated from libmm-qt to modemmanager-qt (now a framework). please note that the stable PPAs continue to use libmm-qt until plasma 5.3 is branched (has no impact on the ISO though) # errata - kwayland had an interface ABI break without soversion bump which blocked builds of kwayland and kwin today, they are using a version from yesterday please note that the ABI break was for a symbol only introduced in 5.3, that is never been part of any release. An soversion bump is because of that not required. Aye, my bad, sorry about that. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
ISO for 2015-04-03
http://files.kde.org/snapshots/unstable-amd64-latest.iso.mirrorlist # changes - screenlocker is disabled in the live session - mouse cursor should use the breeze theme everywhere now - plasma-nm has been migrated from libmm-qt to modemmanager-qt (now a framework). please note that the stable PPAs continue to use libmm-qt until plasma 5.3 is branched (has no impact on the ISO though) # errata - kwayland had an interface ABI break without soversion bump which blocked builds of kwayland and kwin today, they are using a version from yesterday - libkscreen is also the version from yesterday since a symbol retraction was not whitelisted before the ISO spun (should be fine next week) # random PPA errata - due to a rather hastily migration from LXC to docker for build containment, utopic snapshotting for daily and weekly PPAs is presently not working # long standing errata - all issues affecting Kubuntu 15.04, nothing major known right now - the ISO is rolled using the CI landing PPA due to stabilization blockage from missing bluez5. this in turn means that upgrades potentially won't work or break half way through as the underlying PPA breaks ever so often. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: ISO for 2015-04-03
On Friday 03 April 2015 09:34:45 Harald Sitter wrote: http://files.kde.org/snapshots/unstable-amd64-latest.iso.mirrorlist # changes - screenlocker is disabled in the live session - mouse cursor should use the breeze theme everywhere now - plasma-nm has been migrated from libmm-qt to modemmanager-qt (now a framework). please note that the stable PPAs continue to use libmm-qt until plasma 5.3 is branched (has no impact on the ISO though) # errata - kwayland had an interface ABI break without soversion bump which blocked builds of kwayland and kwin today, they are using a version from yesterday please note that the ABI break was for a symbol only introduced in 5.3, that is never been part of any release. An soversion bump is because of that not required. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: about-distro in plasma
On Fri, Apr 3, 2015 at 12:46 PM, Jonathan Riddell j...@jriddell.org wrote: About Distro is still in Playground but it would be a useful kcm to have included as default. +1 Can we move it into plasma-desktop? Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to normal : plasma-workspace_master_qt5 #1434
See http://build.kde.org/job/plasma-workspace_master_qt5/1434/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
about-distro in plasma
About Distro is still in Playground but it would be a useful kcm to have included as default. Can we move it into plasma-desktop? Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: about-distro in plasma
On Friday 03 April 2015 13:04:08 David Edmundson wrote: Gah, GMail pressed send too early. +1 for moving in general. I'd like it to be part of our restore kinfocenter project. It's not a configuration thing as it doesn't configure anything. I'm not convinced about doing it for 5.3 as it's less than a week before freeze and it won't work in some of the more lamer distros. yes, let's merge it after 5.3 is branched and make it a kinfocenter module -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: about-distro in plasma
On Fri, Apr 03, 2015 at 04:19:56AM -0700, Marco Martin wrote: On Friday 03 April 2015 13:04:08 David Edmundson wrote: Gah, GMail pressed send too early. +1 for moving in general. I'd like it to be part of our restore kinfocenter project. It's not a configuration thing as it doesn't configure anything. I'm not convinced about doing it for 5.3 as it's less than a week before freeze and it won't work in some of the more lamer distros. yes, let's merge it after 5.3 is branched and make it a kinfocenter module It is a kinfocenter module Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: about-distro in plasma
It does already appear in kinfocenter so if you think it's not appropriate for system settings that's just a trivial change in the .desktop file. It uses os-release which should be supported by even lame distros (not my terminology!) but it's easy enough to add a configure check to not build it if that doesn't exist. Jonathan On 3 April 2015 at 13:04, David Edmundson da...@davidedmundson.co.uk wrote: Gah, GMail pressed send too early. +1 for moving in general. I'd like it to be part of our restore kinfocenter project. It's not a configuration thing as it doesn't configure anything. I'm not convinced about doing it for 5.3 as it's less than a week before freeze and it won't work in some of the more lamer distros. David On Fri, Apr 3, 2015 at 1:02 PM, David Edmundson da...@davidedmundson.co.uk wrote: On Fri, Apr 3, 2015 at 12:46 PM, Jonathan Riddell j...@jriddell.org wrote: About Distro is still in Playground but it would be a useful kcm to have included as default. +1 Can we move it into plasma-desktop? Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: about-distro in plasma
On Friday 03 April 2015 13:20:00 Jonathan Riddell wrote: It does already appear in kinfocenter so if you think it's not appropriate for system settings that's just a trivial change in the .desktop file. It uses os-release which should be supported by even lame distros (not my terminology!) but it's easy enough to add a configure check to not build it if that doesn't exist. ok, so let's make it appear only in kinfocenter and release it already in 5.3? -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: about-distro in plasma
It duplicates some parts of Summary which I don't like. We could merge and drop the summary page. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: kinfocenter_master_qt5 #91
See http://build.kde.org/job/kinfocenter_master_qt5/91/changes Changes: [lueck] update to kf5 -- [...truncated 114 lines...] == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Detecting C compile features -- Detecting C compile features - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done -- Looking for __GLIBC__ -- Looking for __GLIBC__ - found -- Performing Test _OFFT_IS_64BIT -- Performing Test _OFFT_IS_64BIT - Success -- Found KF5Completion: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kcompletion/inst/lib64/cmake/KF5Completion/KF5CompletionConfig.cmake (found version 5.8.0) -- Found KF5Config: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kconfig/inst/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version 5.8.0) -- Found KF5ConfigWidgets: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kconfigwidgets/inst/lib64/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version 5.8.0) -- Found KF5CoreAddons: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kcoreaddons/inst/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version 5.8.0) -- Found KF5DBusAddons: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdbusaddons/inst/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version 5.8.0) -- Found KF5DocTools: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdoctools/inst/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version 5.8.0) -- Found Gettext: /usr/bin/msgmerge (found version 0.18.1) -- Found PythonInterp: /usr/bin/python (found version 2.7.3) -- Found KF5I18n: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/ki18n/inst/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version 5.8.0) -- Found KF5IconThemes: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kiconthemes/inst/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version 5.8.0) -- Found KF5KCMUtils: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kcmutils/inst/lib64/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version 5.8.0) -- Found KF5KDELibs4Support: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/lib64/cmake/KF5KDELibs4Support/KF5KDELibs4SupportConfig.cmake (found version 5.8.0) -- Found KF5KIO: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kio/inst/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version 5.8.0) -- Found KF5Service: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version 5.8.0) -- Found KF5Solid: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/solid/inst/lib64/cmake/KF5Solid/KF5SolidConfig.cmake (found version 5.8.0) -- Found KF5WidgetsAddons: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kwidgetsaddons/inst/lib64/cmake/KF5WidgetsAddons/KF5WidgetsAddonsConfig.cmake (found version 5.8.0) -- Found KF5XmlGui: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kxmlgui/inst/lib64/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version 5.8.0) -- Found KF5: success (found version 5.8.0) found components: Completion Config ConfigWidgets CoreAddons DBusAddons DocTools I18n IconThemes KCMUtils KDELibs4Support KIO Service Solid WidgetsAddons XmlGui -- Found OpenGL: /usr/lib64/libGL.so -- Found PkgConfig: /usr/bin/pkg-config (found version 0.27.1) -- Found EGL: /usr/lib64/libEGL.so (found version 1.4) -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found -- Looking for gethostbyname -- Looking for gethostbyname - found -- Looking for connect -- Looking for connect - found -- Looking for remove -- Looking for remove - found -- Looking for shmat -- Looking for shmat - found -- Looking for IceConnectionNumber in ICE -- Looking for IceConnectionNumber in ICE - found -- Found X11: /usr/lib64/libX11.so -- Looking for include file devinfo.h -- Looking for include file devinfo.h - not found -- Looking for include file sys/sockio.h -- Looking for include file sys/sockio.h - not found -- Looking for getnameinfo -- Looking for getnameinfo - found -- Performing Test HAVE_STRUCT_SOCKADDR_SA_LEN -- Performing Test HAVE_STRUCT_SOCKADDR_SA_LEN - Failed -- Looking for getifaddrs -- Looking for getifaddrs - found -- Found PCIUTILS: /usr/lib64/libpci.so;/usr/lib64/libresolv.so -- Enabling PCI module based on
Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.
On April 2, 2015, 4:44 p.m., Marco Martin wrote: wallpapers/image/backgroundlistmodel.h, line 93 https://git.reviewboard.kde.org/r/123211/diff/2/?file=359798#file359798line93 this function is not clear what it actually does looks like a verb but returns a list? i tought it was actually *doing* the deletion, maybe either this could directly call removewallpaper or be renamed to something else like wallpapersAwaitingDeletion() or deletionCandidates() yes, the name of that function was a bit off. So i rename it to wallpapersAwaitingDeletion(). - Antonis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/#review78416 --- On April 3, 2015, 3:06 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/ --- (Updated April 3, 2015, 3:06 p.m.) Review request for Plasma. Bugs: 338729 https://bugs.kde.org/show_bug.cgi?id=338729 Repository: plasma-workspace Description --- This patch is adding a confirmation dialog which is being called before we remove a wallpaper. Diffs - wallpapers/image/backgroundlistmodel.h 01b528d wallpapers/image/backgroundlistmodel.cpp d062650 wallpapers/image/image.h a00e431 wallpapers/image/image.cpp f0c672a wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml aee2d3f wallpapers/image/imagepackage/contents/ui/config.qml 2108082 Diff: https://git.reviewboard.kde.org/r/123211/diff/ Testing --- File Attachments dialog https://git.reviewboard.kde.org/media/uploaded/files/2015/04/01/5bfd2d7c-8baa-4b80-ad20-0844aafdb3a9__deletion_dialog.png wallpaper remove https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/8acc3dab-4c2a-4cc2-9ba3-9893e42c32d3__wallpaper_undo.png wallpaper restore https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/4b23e100-194a-4557-926c-d7af252f15d7__wallpaper_undo3.png Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/#review78440 --- Ship it! Ship It! - Marco Martin On April 3, 2015, 3:06 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/ --- (Updated April 3, 2015, 3:06 p.m.) Review request for Plasma. Bugs: 338729 https://bugs.kde.org/show_bug.cgi?id=338729 Repository: plasma-workspace Description --- This patch is adding a confirmation dialog which is being called before we remove a wallpaper. Diffs - wallpapers/image/backgroundlistmodel.h 01b528d wallpapers/image/backgroundlistmodel.cpp d062650 wallpapers/image/image.h a00e431 wallpapers/image/image.cpp f0c672a wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml aee2d3f wallpapers/image/imagepackage/contents/ui/config.qml 2108082 Diff: https://git.reviewboard.kde.org/r/123211/diff/ Testing --- File Attachments dialog https://git.reviewboard.kde.org/media/uploaded/files/2015/04/01/5bfd2d7c-8baa-4b80-ad20-0844aafdb3a9__deletion_dialog.png wallpaper remove https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/8acc3dab-4c2a-4cc2-9ba3-9893e42c32d3__wallpaper_undo.png wallpaper restore https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/4b23e100-194a-4557-926c-d7af252f15d7__wallpaper_undo3.png Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/#review78441 --- It's great that you've implemented the undo function, awesome! What I cannot really tell from the screenshots is how a wallpaper which is marked to be removed is visualized. Can you maybe add a screenshot where the distinction between those which are marked for removal and those which are not becomes clear? Thanks! - Thomas Pfeiffer On April 3, 2015, 3:06 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/ --- (Updated April 3, 2015, 3:06 p.m.) Review request for Plasma. Bugs: 338729 https://bugs.kde.org/show_bug.cgi?id=338729 Repository: plasma-workspace Description --- This patch is adding a confirmation dialog which is being called before we remove a wallpaper. Diffs - wallpapers/image/backgroundlistmodel.h 01b528d wallpapers/image/backgroundlistmodel.cpp d062650 wallpapers/image/image.h a00e431 wallpapers/image/image.cpp f0c672a wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml aee2d3f wallpapers/image/imagepackage/contents/ui/config.qml 2108082 Diff: https://git.reviewboard.kde.org/r/123211/diff/ Testing --- File Attachments dialog https://git.reviewboard.kde.org/media/uploaded/files/2015/04/01/5bfd2d7c-8baa-4b80-ad20-0844aafdb3a9__deletion_dialog.png wallpaper remove https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/8acc3dab-4c2a-4cc2-9ba3-9893e42c32d3__wallpaper_undo.png wallpaper restore https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/4b23e100-194a-4557-926c-d7af252f15d7__wallpaper_undo3.png Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: about-distro in plasma
Gah, GMail pressed send too early. +1 for moving in general. I'd like it to be part of our restore kinfocenter project. It's not a configuration thing as it doesn't configure anything. I'm not convinced about doing it for 5.3 as it's less than a week before freeze and it won't work in some of the more lamer distros. David On Fri, Apr 3, 2015 at 1:02 PM, David Edmundson da...@davidedmundson.co.uk wrote: On Fri, Apr 3, 2015 at 12:46 PM, Jonathan Riddell j...@jriddell.org wrote: About Distro is still in Playground but it would be a useful kcm to have included as default. +1 Can we move it into plasma-desktop? Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123241: Plasmate Repo: Change the application versions in order to match the version of Plasma's and disable Plasmate build by default.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123241/ --- (Updated April 3, 2015, 4:44 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit b0a377eb37b726d6e67c6e9cde91108a4aaf1636 by Antonis Tsiapaliokas to branch frameworks. Repository: plasmate Description --- This patch is changing the version of the following applications to 5.2.90, which is the current version of the Plasma. And from now on these will have the same version as it has been mentioned in the Plasma-devel Ml. * plasmoidviewer * plasmaengineexplorer * plasmathemeexplorer * cuttlefish * plasmate Futhermore Plasmate's build is currently being dissable by default. Also there are some changes in the minimum requirements of the Qt5/KF5 versions. Diffs - CMakeLists.txt edf3938 cuttlefish/src/main.cpp fa5b08a engineexplorer/main.cpp 32b0ee1 plasmate/app/main.cpp 37e415d plasmoidviewer/main.cpp 324b53c themeexplorer/src/main.cpp c4c9ce0 Diff: https://git.reviewboard.kde.org/r/123241/diff/ Testing --- File Attachments plasmate_disable_build https://git.reviewboard.kde.org/media/uploaded/files/2015/04/03/e34096b9-0b9f-48d8-b2be-ddbdc562849f__plasmate_disable_build.png Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123246: Plasmate repo: Use the PROJECT_VERSION variable in order to define the version of the applications
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123246/#review78453 --- Ship it! Ship It! - Jonathan Riddell On April 3, 2015, 5:34 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123246/ --- (Updated April 3, 2015, 5:34 p.m.) Review request for Plasma. Repository: plasmate Description --- The Plasmate repo should use the PROJECT_VERSION variable which is being created by the cmake in order to define the version of the applications. Diffs - engineexplorer/main.cpp f01816c plasmate/app/CMakeLists.txt d353290 engineexplorer/CMakeLists.txt 93670c3 cuttlefish/src/main.cpp 398a894 CMakeLists.txt 106cbb4 cuttlefish/src/CMakeLists.txt 8ee86ac plasmate/app/main.cpp f1b41a9 plasmoidviewer/CMakeLists.txt 6ad061b plasmoidviewer/main.cpp 7332a9f themeexplorer/src/CMakeLists.txt 432113d themeexplorer/src/main.cpp 4d74cf0 Diff: https://git.reviewboard.kde.org/r/123246/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Proposal regarding plasmate's release
On Friday 03 April 2015 20:41:47 David Edmundson wrote: I don't have a problem with it depending on stuff in extragear as we depend on many external items. As long as that stuff we depend on in extragear doesn't depend on stuff in plasma. What happens when kdevplatform releases an update with an API break? You'll want to release a new Plasmate. It being optional doesn't change that. yeah, exactly, the problem is not about being external or not, the problem is abput stable abi guarantee. so would be better release this in extragear too for now :/ -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.
On April 3, 2015, 3:13 p.m., Thomas Pfeiffer wrote: It's great that you've implemented the undo function, awesome! What I cannot really tell from the screenshots is how a wallpaper which is marked to be removed is visualized. Can you maybe add a screenshot where the distinction between those which are marked for removal and those which are not becomes clear? Thanks! I have add a new screenshot. The wallpaper with the kde forums is currenty being marked for deletion, while the one with the bugzilla it is not being marked for deletion. The basic difference between the deleted and the non deleted is that i add opacity. So the one which is going to be deleted is shown up as faded out.. I am pushing this patch as is for now. If you have any better ideas, about how we could archive a better distinction between these two, let me know. - Antonis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/#review78441 --- On April 3, 2015, 3:58 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/ --- (Updated April 3, 2015, 3:58 p.m.) Review request for Plasma. Bugs: 338729 https://bugs.kde.org/show_bug.cgi?id=338729 Repository: plasma-workspace Description --- This patch is adding a confirmation dialog which is being called before we remove a wallpaper. Diffs - wallpapers/image/backgroundlistmodel.h 01b528d wallpapers/image/backgroundlistmodel.cpp d062650 wallpapers/image/image.h a00e431 wallpapers/image/image.cpp f0c672a wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml aee2d3f wallpapers/image/imagepackage/contents/ui/config.qml 2108082 Diff: https://git.reviewboard.kde.org/r/123211/diff/ Testing --- File Attachments dialog https://git.reviewboard.kde.org/media/uploaded/files/2015/04/01/5bfd2d7c-8baa-4b80-ad20-0844aafdb3a9__deletion_dialog.png wallpaper remove https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/8acc3dab-4c2a-4cc2-9ba3-9893e42c32d3__wallpaper_undo.png wallpaper restore https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/4b23e100-194a-4557-926c-d7af252f15d7__wallpaper_undo3.png 1st_is_removed_2nd_isnt https://git.reviewboard.kde.org/media/uploaded/files/2015/04/03/84e524f9-7875-42b2-ad8c-3083b7e0bd22__1st_wallapper_is_removed_the_2nd_isnt.png Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123244: Plasmate repo should no longer depend on kde4.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123244/ --- Review request for Plasma. Repository: plasmate Description --- The Plasmate repo shouldn't depend on kde4. The only application inside from this repo which still requires the kdelibs4support is the remoteinstaller which is currently part of the Plasmate (application) which is being disable by default. So we should strip away the kde4 depedency from the entire repo and place it into the Plasmate(the application). Diffs - CMakeLists.txt 106cbb4 plasmate/CMakeLists.txt 6e07b30 plasmoidviewer/CMakeLists.txt 6ad061b Diff: https://git.reviewboard.kde.org/r/123244/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Proposal regarding plasmate's release
On Fri, Apr 3, 2015 at 8:10 PM, Jonathan Riddell j...@jriddell.org wrote: On Fri, Apr 03, 2015 at 08:52:09PM +0300, Antonis Tsiapaliokas wrote: On Fri, Apr 03, 2015 at 06:08:52PM +0200, David Edmundson wrote: Can it go under kde/workspace if in future it will depend on something in extragear? I still support doing the rest, and making / release.. I'm just not sure we can do the move and release it with plasma. At the moment the only application inside from the Plasmate repo which depends on extragear is Plasmate (the application), and it depends on the Kdevplatform. The rest of the applications doesn't depend on extragear. Plasmate (the application) is currently being disabled from building by default. So the Plasmate repo doesn't need something from extragear in order to build. In the feature Plasmate (the application) will be build as an optional depedency only if the Kdevplatform is being present. So kde/workspace is building first from the kdesrc-build, so if we move the Plasmate repo there, Plasmate (the application) it will never get build. It will require a rebuild. I don't have a problem with it depending on stuff in extragear as we depend on many external items. As long as that stuff we depend on in extragear doesn't depend on stuff in plasma. What happens when kdevplatform releases an update with an API break? You'll want to release a new Plasmate. It being optional doesn't change that. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Proposal regarding plasmate's release
On Friday 03 April 2015 18:53:28 Antonis Tsiapaliokas wrote: 4. make the PLASMATE_BUILD_WITH_KDEVPLATFORM off(false) by default and add a message that will inform the user that the plasmate application isn't ready yet for production. I will create a patch for this one too. So any objections/suggestions? no, go for it, patch by patch :) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123241: Plasmate Repo: Change the application versions in order to match the version of Plasma's and disable Plasmate build by default.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123241/ --- Review request for Plasma. Repository: plasmate Description --- This patch is changing the version of the following applications to 5.2.90, which is the current version of the Plasma. And from now on these will have the same version as it has been mentioned in the Plasma-devel Ml. * plasmoidviewer * plasmaengineexplorer * plasmathemeexplorer * cuttlefish * plasmate Futhermore Plasmate's build is currently being dissable by default. Also there are some changes in the minimum requirements of the Qt5/KF5 versions. Diffs - CMakeLists.txt edf3938 cuttlefish/src/main.cpp fa5b08a engineexplorer/main.cpp 32b0ee1 plasmate/app/main.cpp 37e415d plasmoidviewer/main.cpp 324b53c themeexplorer/src/main.cpp c4c9ce0 Diff: https://git.reviewboard.kde.org/r/123241/diff/ Testing --- File Attachments plasmate_disable_build https://git.reviewboard.kde.org/media/uploaded/files/2015/04/03/e34096b9-0b9f-48d8-b2be-ddbdc562849f__plasmate_disable_build.png Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123244: Plasmate repo should no longer depend on kde4.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123244/#review78451 --- Ship it! - David Edmundson On April 3, 2015, 4:59 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123244/ --- (Updated April 3, 2015, 4:59 p.m.) Review request for Plasma. Repository: plasmate Description --- The Plasmate repo shouldn't depend on kde4. The only application inside from this repo which still requires the kdelibs4support is the remoteinstaller which is currently part of the Plasmate (application) which is being disable by default. So we should strip away the kde4 depedency from the entire repo and place it into the Plasmate(the application). Diffs - CMakeLists.txt 106cbb4 plasmate/CMakeLists.txt 6e07b30 plasmoidviewer/CMakeLists.txt 6ad061b Diff: https://git.reviewboard.kde.org/r/123244/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123244: Plasmate repo should no longer depend on kde4.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123244/ --- (Updated April 3, 2015, 5:32 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 85f1b36d8fef10d905457e02f782ec9ca826f74f by Antonis Tsiapaliokas to branch frameworks. Repository: plasmate Description --- The Plasmate repo shouldn't depend on kde4. The only application inside from this repo which still requires the kdelibs4support is the remoteinstaller which is currently part of the Plasmate (application) which is being disable by default. So we should strip away the kde4 depedency from the entire repo and place it into the Plasmate(the application). Diffs - CMakeLists.txt 106cbb4 plasmate/CMakeLists.txt 6e07b30 plasmoidviewer/CMakeLists.txt 6ad061b Diff: https://git.reviewboard.kde.org/r/123244/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123247: Fix multiple documents and applications lists in Recently used tab
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123247/#review78456 --- Ship it! Ship It! - Marco Martin On April 3, 2015, 5:52 p.m., Anthony Vital wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123247/ --- (Updated April 3, 2015, 5:52 p.m.) Review request for Plasma. Bugs: 342127 https://bugs.kde.org/show_bug.cgi?id=342127 Repository: plasma-desktop Description --- Always insert the documents after the applications. Diffs - applets/kickoff/core/recentlyusedmodel.cpp 890d0959ba44d76ecb9cf07bcd9fabe332d6da8f Diff: https://git.reviewboard.kde.org/r/123247/diff/ Testing --- Alternatively opened a file, then an application, etc... nothing weird happens. Thanks, Anthony Vital ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/ --- (Updated April 3, 2015, 4:05 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 50942e2618f3ed26f8eac8f264656617bb113ec6 by Antonis Tsiapaliokas to branch master. Bugs: 338729 https://bugs.kde.org/show_bug.cgi?id=338729 Repository: plasma-workspace Description --- This patch is adding a confirmation dialog which is being called before we remove a wallpaper. Diffs - wallpapers/image/backgroundlistmodel.h 01b528d wallpapers/image/backgroundlistmodel.cpp d062650 wallpapers/image/image.h a00e431 wallpapers/image/image.cpp f0c672a wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml aee2d3f wallpapers/image/imagepackage/contents/ui/config.qml 2108082 Diff: https://git.reviewboard.kde.org/r/123211/diff/ Testing --- File Attachments dialog https://git.reviewboard.kde.org/media/uploaded/files/2015/04/01/5bfd2d7c-8baa-4b80-ad20-0844aafdb3a9__deletion_dialog.png wallpaper remove https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/8acc3dab-4c2a-4cc2-9ba3-9893e42c32d3__wallpaper_undo.png wallpaper restore https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/4b23e100-194a-4557-926c-d7af252f15d7__wallpaper_undo3.png 1st_is_removed_2nd_isnt https://git.reviewboard.kde.org/media/uploaded/files/2015/04/03/84e524f9-7875-42b2-ad8c-3083b7e0bd22__1st_wallapper_is_removed_the_2nd_isnt.png Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/#review78450 --- wallpapers/image/backgroundlistmodel.h (line 93) https://git.reviewboard.kde.org/r/123211/#comment53671 This should be: QStringList wallpapersAwaitingDeletion() const; wallpapers/image/image.cpp (line 802) https://git.reviewboard.kde.org/r/123211/#comment53672 This should be a const reference: const QString wallpaperCandidate - Lukáš Tinkl On Dub. 3, 2015, 6:05 odp., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/ --- (Updated Dub. 3, 2015, 6:05 odp.) Review request for Plasma. Bugs: 338729 https://bugs.kde.org/show_bug.cgi?id=338729 Repository: plasma-workspace Description --- This patch is adding a confirmation dialog which is being called before we remove a wallpaper. Diffs - wallpapers/image/backgroundlistmodel.h 01b528d wallpapers/image/backgroundlistmodel.cpp d062650 wallpapers/image/image.h a00e431 wallpapers/image/image.cpp f0c672a wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml aee2d3f wallpapers/image/imagepackage/contents/ui/config.qml 2108082 Diff: https://git.reviewboard.kde.org/r/123211/diff/ Testing --- File Attachments dialog https://git.reviewboard.kde.org/media/uploaded/files/2015/04/01/5bfd2d7c-8baa-4b80-ad20-0844aafdb3a9__deletion_dialog.png wallpaper remove https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/8acc3dab-4c2a-4cc2-9ba3-9893e42c32d3__wallpaper_undo.png wallpaper restore https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/4b23e100-194a-4557-926c-d7af252f15d7__wallpaper_undo3.png 1st_is_removed_2nd_isnt https://git.reviewboard.kde.org/media/uploaded/files/2015/04/03/84e524f9-7875-42b2-ad8c-3083b7e0bd22__1st_wallapper_is_removed_the_2nd_isnt.png Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123246: Plasmate repo: Use the PROJECT_VERSION variable in order to define the version of the applications
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123246/ --- Review request for Plasma. Repository: plasmate Description --- The Plasmate repo should use the PROJECT_VERSION variable which is being created by the cmake in order to define the version of the applications. Diffs - engineexplorer/main.cpp f01816c plasmate/app/CMakeLists.txt d353290 engineexplorer/CMakeLists.txt 93670c3 cuttlefish/src/main.cpp 398a894 CMakeLists.txt 106cbb4 cuttlefish/src/CMakeLists.txt 8ee86ac plasmate/app/main.cpp f1b41a9 plasmoidviewer/CMakeLists.txt 6ad061b plasmoidviewer/main.cpp 7332a9f themeexplorer/src/CMakeLists.txt 432113d themeexplorer/src/main.cpp 4d74cf0 Diff: https://git.reviewboard.kde.org/r/123246/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/ --- (Updated April 3, 2015, 3:58 p.m.) Review request for Plasma. Bugs: 338729 https://bugs.kde.org/show_bug.cgi?id=338729 Repository: plasma-workspace Description --- This patch is adding a confirmation dialog which is being called before we remove a wallpaper. Diffs - wallpapers/image/backgroundlistmodel.h 01b528d wallpapers/image/backgroundlistmodel.cpp d062650 wallpapers/image/image.h a00e431 wallpapers/image/image.cpp f0c672a wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml aee2d3f wallpapers/image/imagepackage/contents/ui/config.qml 2108082 Diff: https://git.reviewboard.kde.org/r/123211/diff/ Testing --- File Attachments (updated) dialog https://git.reviewboard.kde.org/media/uploaded/files/2015/04/01/5bfd2d7c-8baa-4b80-ad20-0844aafdb3a9__deletion_dialog.png wallpaper remove https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/8acc3dab-4c2a-4cc2-9ba3-9893e42c32d3__wallpaper_undo.png wallpaper restore https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/4b23e100-194a-4557-926c-d7af252f15d7__wallpaper_undo3.png 1st_is_removed_2nd_isnt https://git.reviewboard.kde.org/media/uploaded/files/2015/04/03/84e524f9-7875-42b2-ad8c-3083b7e0bd22__1st_wallapper_is_removed_the_2nd_isnt.png Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123242: Fix recent applications list not being updated
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123242/ --- Review request for Plasma. Bugs: 342084 https://bugs.kde.org/show_bug.cgi?id=342084 Repository: plasma-desktop Description --- The handler for the desktop files was never registered. Diffs - applets/kickoff/core/applicationmodel.cpp 95f57128e85d4067f9edb459416704415c0c2958 Diff: https://git.reviewboard.kde.org/r/123242/diff/ Testing --- Launched applications from the applications menu and the favourites menu, the items are now added to the recent applications list. Thanks, Anthony Vital ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Proposal regarding plasmate's release
On Fri, Apr 03, 2015 at 06:08:52PM +0200, David Edmundson wrote: Can it go under kde/workspace if in future it will depend on something in extragear? I still support doing the rest, and making / release.. I'm just not sure we can do the move and release it with plasma. At the moment the only application inside from the Plasmate repo which depends on extragear is Plasmate (the application), and it depends on the Kdevplatform. The rest of the applications doesn't depend on extragear. Plasmate (the application) is currently being disabled from building by default. So the Plasmate repo doesn't need something from extragear in order to build. In the feature Plasmate (the application) will be build as an optional depedency only if the Kdevplatform is being present. So kde/workspace is building first from the kdesrc-build, so if we move the Plasmate repo there, Plasmate (the application) it will never get build. It will require a rebuild. -- Antonis Tsiapaliokas kokeroulis.gr ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Proposal regarding plasmate's release
On Fri, Apr 03, 2015 at 08:52:09PM +0300, Antonis Tsiapaliokas wrote: On Fri, Apr 03, 2015 at 06:08:52PM +0200, David Edmundson wrote: Can it go under kde/workspace if in future it will depend on something in extragear? I still support doing the rest, and making / release.. I'm just not sure we can do the move and release it with plasma. At the moment the only application inside from the Plasmate repo which depends on extragear is Plasmate (the application), and it depends on the Kdevplatform. The rest of the applications doesn't depend on extragear. Plasmate (the application) is currently being disabled from building by default. So the Plasmate repo doesn't need something from extragear in order to build. In the feature Plasmate (the application) will be build as an optional depedency only if the Kdevplatform is being present. So kde/workspace is building first from the kdesrc-build, so if we move the Plasmate repo there, Plasmate (the application) it will never get build. It will require a rebuild. I don't have a problem with it depending on stuff in extragear as we depend on many external items. As long as that stuff we depend on in extragear doesn't depend on stuff in plasma. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Proposal regarding plasmate's release
On Fri, Apr 03, 2015 at 06:53:28PM +0300, Antonis Tsiapaliokas wrote: As it has been mentioned in previous email, we must first mail the kde-core-devel. As a new name i suggess the plasma-sdk and it will be under the kde/workspace. Please do so :) I'll include it in the beta tars next week from playground. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123247: Fix multiple documents and applications lists in Recently used tab
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123247/ --- Review request for Plasma. Bugs: 342127 https://bugs.kde.org/show_bug.cgi?id=342127 Repository: plasma-desktop Description --- Always insert the documents after the applications. Diffs - applets/kickoff/core/recentlyusedmodel.cpp 890d0959ba44d76ecb9cf07bcd9fabe332d6da8f Diff: https://git.reviewboard.kde.org/r/123247/diff/ Testing --- Alternatively opened a file, then an application, etc... nothing weird happens. Thanks, Anthony Vital ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Proposal regarding plasmate's release
On Fri, Apr 3, 2015 at 5:53 PM, Antonis Tsiapaliokas antonis.tsiapalio...@kde.org wrote: On Wed, Apr 01, 2015 at 01:51:02PM +0200, Marco Martin wrote: Any news on this? besides plasmate, the repository has other utilities (plasmoidviewer, plasmaengineexplorer, plasmathemeexplorer, cuttlefish) that really NEED to be released Yes, I am sorry for the delay. So lets summarize a bit. On Thursday 29 January 2015, Giorgos Tsiapaliokas wrote: 1. move the plasmate repo away from extragear As it has been mentioned in previous email, we must first mail the kde-core-devel. As a new name i suggess the plasma-sdk and it will be under the kde/workspace. Can it go under kde/workspace if in future it will depend on something in extragear? I still support doing the rest, and making / release.. I'm just not sure we can do the move and release it with plasma. 2. release the plasmate repo together with plasma and all the applications in it will follow plasma's version number. So there won't be plasmoidviewer 2.0 but plasmoidviewer 5.x So i will prepare a patch which will change the versions of plasmoidviewer, plasmaengineexplorer, plasmathemeexplorer, cuttlefish and plasmate. The version will be the same as Plasma's(5.2.90). And this repo will be released together with the Plasma's repo. 3. merge the frameworks branch into master and delete the frameworks branch So as it has been suggested we should tag the master branch, and after that we should merge the frameworks into the master, and delete the frameworks. Also in the previous mails, we said that we should the merge(frameworks into master) and then rename the repo in order to avoid changing the metadata twice. 4. make the PLASMATE_BUILD_WITH_KDEVPLATFORM off(false) by default and add a message that will inform the user that the plasmate application isn't ready yet for production. I will create a patch for this one too. So any objections/suggestions? -- Antonis Tsiapaliokas kokeroulis.gr ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123247: Fix multiple documents and applications lists in Recently used tab
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123247/ --- (Updated April 3, 2015, 6:06 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 30a1b4a44d715891eb2811a89093ed28bac5be15 by Anthony Vital to branch master. Bugs: 342127 https://bugs.kde.org/show_bug.cgi?id=342127 Repository: plasma-desktop Description --- Always insert the documents after the applications. Diffs - applets/kickoff/core/recentlyusedmodel.cpp 890d0959ba44d76ecb9cf07bcd9fabe332d6da8f Diff: https://git.reviewboard.kde.org/r/123247/diff/ Testing --- Alternatively opened a file, then an application, etc... nothing weird happens. Thanks, Anthony Vital ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123242: Fix recent applications list not being updated
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123242/ --- (Updated April 3, 2015, 6:06 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 9ad674395a28cf4cd7862aefadc8f95498449249 by Anthony Vital to branch master. Bugs: 342084 https://bugs.kde.org/show_bug.cgi?id=342084 Repository: plasma-desktop Description --- The handler for the desktop files was never registered. Diffs - applets/kickoff/core/applicationmodel.cpp 95f57128e85d4067f9edb459416704415c0c2958 Diff: https://git.reviewboard.kde.org/r/123242/diff/ Testing --- Launched applications from the applications menu and the favourites menu, the items are now added to the recent applications list. Thanks, Anthony Vital ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123241: Plasmate Repo: Change the application versions in order to match the version of Plasma's and disable Plasmate build by default.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123241/#review78449 --- Ship it! - David Edmundson On April 3, 2015, 4:15 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123241/ --- (Updated April 3, 2015, 4:15 p.m.) Review request for Plasma. Repository: plasmate Description --- This patch is changing the version of the following applications to 5.2.90, which is the current version of the Plasma. And from now on these will have the same version as it has been mentioned in the Plasma-devel Ml. * plasmoidviewer * plasmaengineexplorer * plasmathemeexplorer * cuttlefish * plasmate Futhermore Plasmate's build is currently being dissable by default. Also there are some changes in the minimum requirements of the Qt5/KF5 versions. Diffs - CMakeLists.txt edf3938 cuttlefish/src/main.cpp fa5b08a engineexplorer/main.cpp 32b0ee1 plasmate/app/main.cpp 37e415d plasmoidviewer/main.cpp 324b53c themeexplorer/src/main.cpp c4c9ce0 Diff: https://git.reviewboard.kde.org/r/123241/diff/ Testing --- File Attachments plasmate_disable_build https://git.reviewboard.kde.org/media/uploaded/files/2015/04/03/e34096b9-0b9f-48d8-b2be-ddbdc562849f__plasmate_disable_build.png Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123242: Fix recent applications list not being updated
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123242/#review78454 --- Ship it! Ship It! - David Edmundson On April 3, 2015, 5:44 p.m., Anthony Vital wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123242/ --- (Updated April 3, 2015, 5:44 p.m.) Review request for Plasma. Bugs: 342084 https://bugs.kde.org/show_bug.cgi?id=342084 Repository: plasma-desktop Description --- The handler for the desktop files was never registered. Diffs - applets/kickoff/core/applicationmodel.cpp 95f57128e85d4067f9edb459416704415c0c2958 Diff: https://git.reviewboard.kde.org/r/123242/diff/ Testing --- Launched applications from the applications menu and the favourites menu, the items are now added to the recent applications list. Thanks, Anthony Vital ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123246: Plasmate repo: Use the PROJECT_VERSION variable in order to define the version of the applications
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123246/ --- (Updated April 3, 2015, 5:58 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit d5d8ad2259a92908d7762afbbb87697de090224c by Antonis Tsiapaliokas to branch frameworks. Repository: plasmate Description --- The Plasmate repo should use the PROJECT_VERSION variable which is being created by the cmake in order to define the version of the applications. Diffs - engineexplorer/main.cpp f01816c plasmate/app/CMakeLists.txt d353290 engineexplorer/CMakeLists.txt 93670c3 cuttlefish/src/main.cpp 398a894 CMakeLists.txt 106cbb4 cuttlefish/src/CMakeLists.txt 8ee86ac plasmate/app/main.cpp f1b41a9 plasmoidviewer/CMakeLists.txt 6ad061b plasmoidviewer/main.cpp 7332a9f themeexplorer/src/CMakeLists.txt 432113d themeexplorer/src/main.cpp 4d74cf0 Diff: https://git.reviewboard.kde.org/r/123246/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121097: Add a FileDialog to choose the image for fifteenpuzzle.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121097/ --- (Updated April 3, 2015, 1:35 p.m.) Status -- This change has been discarded. Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin. Repository: kdeplasma-addons Description --- Somehow this doesn't show the FileDialog here, not sure if it's a local problem though. Diffs - applets/fifteenPuzzle/package/contents/ui/configAppearance.qml 5dfd2317bdc26849d1705e8826510bd05176b963 Diff: https://git.reviewboard.kde.org/r/121097/diff/ Testing --- Doesn't work here, but I'm hoping it's just a local problem. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120877: Convert switch statements to if/else due to MSVC limitation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120877/ --- (Updated April 3, 2015, 7:30 p.m.) Status -- This change has been marked as submitted. Review request for kdewin and Plasma. Changes --- Submitted with commit 99d968e1905cfd06bcd358b76177dba6c80f8dcb by Andrius da Costa Ribas to branch master. Repository: plasma-framework Description --- MSVC is unable to recognise e.g. FrameSvg::TopBorder | FrameSvg::LeftBorder as a compile-time const expression (error C2051: case expression not constant) Diffs - src/plasma/private/framesvg_helpers.h 5b96cd5 Diff: https://git.reviewboard.kde.org/r/120877/diff/ Testing --- Builds with MSVC 2013 64bit. framesvg related tests pass, other unrelated tests still fail. Test project V:/build/frameworks/plasma/work/msvc2013-RelWithDebInfo-master Start 1: plasma-dialogqmltest 1/10 Test #1: plasma-dialogqmltest ...***Failed1.15 sec Start 2: plasma-fallbackpackagetest 2/10 Test #2: plasma-fallbackpackagetest . Passed0.16 sec Start 3: plasma-packagestructuretest 3/10 Test #3: plasma-packagestructuretest ***Failed0.19 sec Start 4: plasma-packageurlinterceptortest 4/10 Test #4: plasma-packageurlinterceptortest ... Passed0.12 sec Start 5: plasma-pluginloadertest 5/10 Test #5: plasma-pluginloadertest Passed1.44 sec Start 6: plasma-framesvgtest 6/10 Test #6: plasma-framesvgtest Passed0.64 sec Start 7: coronatest 7/10 Test #7: coronatest .***Failed0.16 sec Start 8: plasma-storagetest 8/10 Test #8: plasma-storagetest .***Failed0.12 sec Start 9: plasma-sortfiltermodeltest 9/10 Test #9: plasma-sortfiltermodeltest . Passed0.14 sec Start 10: i18ndcheck Could not find executable SH-NOTFOUND Looked in the following places: SH-NOTFOUND SH-NOTFOUND.exe Release/SH-NOTFOUND Release/SH-NOTFOUND.exe Debug/SH-NOTFOUND Debug/SH-NOTFOUND.exe MinSizeRel/SH-NOTFOUND MinSizeRel/SH-NOTFOUND.exe RelWithDebInfo/SH-NOTFOUND RelWithDebInfo/SH-NOTFOUND.exe Deployment/SH-NOTFOUND Deployment/SH-NOTFOUND.exe Development/SH-NOTFOUND Development/SH-NOTFOUND.exe Unable to find executable: SH-NOTFOUND 10/10 Test #10: i18ndcheck .***Not Run 0.00 sec 50% tests passed, 5 tests failed out of 10 Thanks, Andrius da Costa Ribas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to normal : kinfocenter_master_qt5 #92
See http://build.kde.org/job/kinfocenter_master_qt5/92/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Proposal regarding plasmate's release
On Wed, Apr 01, 2015 at 01:51:02PM +0200, Marco Martin wrote: Any news on this? besides plasmate, the repository has other utilities (plasmoidviewer, plasmaengineexplorer, plasmathemeexplorer, cuttlefish) that really NEED to be released Yes, I am sorry for the delay. So lets summarize a bit. On Thursday 29 January 2015, Giorgos Tsiapaliokas wrote: 1. move the plasmate repo away from extragear As it has been mentioned in previous email, we must first mail the kde-core-devel. As a new name i suggess the plasma-sdk and it will be under the kde/workspace. 2. release the plasmate repo together with plasma and all the applications in it will follow plasma's version number. So there won't be plasmoidviewer 2.0 but plasmoidviewer 5.x So i will prepare a patch which will change the versions of plasmoidviewer, plasmaengineexplorer, plasmathemeexplorer, cuttlefish and plasmate. The version will be the same as Plasma's(5.2.90). And this repo will be released together with the Plasma's repo. 3. merge the frameworks branch into master and delete the frameworks branch So as it has been suggested we should tag the master branch, and after that we should merge the frameworks into the master, and delete the frameworks. Also in the previous mails, we said that we should the merge(frameworks into master) and then rename the repo in order to avoid changing the metadata twice. 4. make the PLASMATE_BUILD_WITH_KDEVPLATFORM off(false) by default and add a message that will inform the user that the plasmate application isn't ready yet for production. I will create a patch for this one too. So any objections/suggestions? -- Antonis Tsiapaliokas kokeroulis.gr ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
