Review Request 123444: [ksmserver] Do not try to start X11 window manager if Wayland env variables are set
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123444/ --- Review request for Plasma. Repository: plasma-workspace Description --- If ksmserver is started in a session with WAYLAND_DISPLAY and/or WAYLAND_SOCKET being exported we can assume that the Xserver is an Xwayland server. In that case the wayland compositor is also the window maager. Thus starting a window manager would either fail or create severe havoc in case it succeeds in replacing the running window manager. Diffs - ksmserver/startup.cpp d0071f2fe34bfed784112244199eadfa28c8a97c Diff: https://git.reviewboard.kde.org/r/123444/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: polkit-kde-agent-1_stable_qt5 #5
See http://build.kde.org/job/polkit-kde-agent-1_stable_qt5/5/changes
Changes:
[scripty] SVN_SILENT made messages (.desktop file)
[scripty] SVN_SILENT made messages (.desktop file)
[jr] Update version number for 5.2.90
[scripty] SVN_SILENT made messages (.desktop file)
[scripty] SVN_SILENT made messages (.desktop file)
[scripty] SVN_SILENT made messages (.desktop file)
[scripty] SVN_SILENT made messages (.desktop file)
[scripty] SVN_SILENT made messages (.desktop file)
[scripty] SVN_SILENT made messages (.desktop file)
[aleixpol] Remove duplicated entry
[scripty] SVN_SILENT made messages (.desktop file)
[hein] Bump minimum Qt version to 5.4.0.
[scripty] SVN_SILENT made messages (.desktop file)
[scripty] SVN_SILENT made messages (.desktop file)
[kde] enable high dpi pixmaps
[yurchor] Get rid of 'the the'
[scripty] SVN_SILENT made messages (.desktop file) - always resolve ours
[scripty] SVN_SILENT made messages (.desktop file) - always resolve ours
[scripty] SVN_SILENT made messages (.desktop file) - always resolve ours
[lasse.liehu] Enable UI translations
[jr] Update version number for 5.2.95
[scripty] SVN_SILENT made messages (.desktop file)
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/polkit-kde-agent-1_stable_qt5/ws/
Running Prebuild steps
[polkit-kde-agent-1_stable_qt5] $ /bin/sh -xe /tmp/hudson5837408497333180918.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/polkit-kde-agent-1
* [new branch] Plasma/5.3 - origin/Plasma/5.3
c255ec2..0a44553 kdelibs4 - origin/kdelibs4
115b737..01c560d master - origin/master
* [new tag] v5.2.2 - v5.2.2
From git://anongit.kde.org/polkit-kde-agent-1
* [new tag] v5.2.95- v5.2.95
Branch jenkins set up to track remote branch Plasma/5.3 from origin.
== Cleaning Source Tree
HEAD is now at 5ccf365 Update version number for 5.2.2
Removing build/
Removing local-inst/
Success build forhudson.tasks.Shell@46a9efaa
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/polkit-kde-agent-1 #
timeout=10
Fetching upstream changes from git://anongit.kde.org/polkit-kde-agent-1
git --version # timeout=10
git -c core.askpass=true fetch --tags --progress
git://anongit.kde.org/polkit-kde-agent-1 +refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 917daf00d4f554004ee0d82cf77f1b94a2092e95
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f 917daf00d4f554004ee0d82cf77f1b94a2092e95
git rev-list 5ccf36588005994f4a102ed94100fab4e679c8f2 # timeout=10
git tag -a -f -m Jenkins Build #5 jenkins-polkit-kde-agent-1_stable_qt5-5 #
timeout=10
[polkit-kde-agent-1_stable_qt5] $ /bin/sh -xe /tmp/hudson943572814596034751.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: polkit-kde-agent-1 - Branch Plasma/5.3
== Build Dependencies:
kemoticons - Branch master
kcmutils - Branch master
kidletime - Branch master
libgit2 - Branch master
plasma-framework - Branch master
kcrash - Branch master
kjs - Branch master
threadweaver - Branch master
kservice - Branch master
kitemmodels - Branch master
ktexteditor - Branch master
kbookmarks - Branch master
kross - Branch master
ktextwidgets - Branch master
kwindowsystem - Branch master
kdeclarative - Branch master
kdelibs4support - Branch master
ki18n - Branch master
kxmlgui - Branch master
kiconthemes - Branch master
kdnssd - Branch master
kcoreaddons - Branch master
kdbusaddons - Branch master
kdesignerplugin - Branch master
kunitconversion - Branch master
kpackage - Branch master
extra-cmake-modules - Branch master
kparts - Branch master
kitemviews - Branch master
kglobalaccel - Branch master
kconfigwidgets - Branch master
kxmlrpcclient - Branch master
knewstuff - Branch master
phonon - Branch master
kcompletion - Branch master
dogtail - Branch master
frameworkintegration - Branch master
karchive - Branch master
knotifications - Branch master
solid - Branch master
kjobwidgets - Branch master
kauth - Branch master
knotifyconfig - Branch master
kded - Branch master
kio - Branch master
kinit - Branch master
kdesupport-svn - Branch master
polkit-qt-1 - Branch master
cmake - Branch master
qt5 - Branch 5.4
Review Request 123448: Message dialog should be shown before we change a category in the Desktop Settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123448/ --- Review request for Plasma. Bugs: 346431 https://bugs.kde.org/show_bug.cgi?id=346431 Repository: plasma-desktop Description --- The Wallpaper and the Mouse Actions category should always show the message dialog if they have pending changes. Futhermore there is no need to check if there are pending changes, since we already know that because of the Apply Button. So we don't need the configurationHasChanged function anymore. Diffs - desktoppackage/contents/configuration/AppletConfiguration.qml 9e61cc0 desktoppackage/contents/configuration/ConfigCategoryDelegate.qml 68301ad Diff: https://git.reviewboard.kde.org/r/123448/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-workspace_stable_qt5 #113
See http://build.kde.org/job/plasma-workspace_stable_qt5/113/changes
Changes:
[lukas] [containmentactions] Verify that list returned from kglobalaccel is not
empty
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/plasma-workspace_stable_qt5/ws/
Running Prebuild steps
[plasma-workspace_stable_qt5] $ /bin/sh -xe /tmp/hudson851919104791584392.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/plasma-workspace
64a3416..cd134d7 Plasma/5.3 - origin/Plasma/5.3
435c511..45ab13f master - origin/master
Branch jenkins set up to track remote branch Plasma/5.3 from origin.
== Cleaning Source Tree
HEAD is now at 64a3416 Fix vertical alignment of entry names in system tray
configuration
Removing build/
Success build forhudson.tasks.Shell@7f72f66b
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/plasma-workspace #
timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
git --version # timeout=10
git -c core.askpass=true fetch --tags --progress
git://anongit.kde.org/plasma-workspace +refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision cd134d73266618c9a4ce800cbc1694421a47e838
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f cd134d73266618c9a4ce800cbc1694421a47e838
git rev-list 64a341612efe6c2e41c85d5c1a47e18647165566 # timeout=10
git tag -a -f -m Jenkins Build #113 jenkins-plasma-workspace_stable_qt5-113
# timeout=10
[plasma-workspace_stable_qt5] $ /bin/sh -xe /tmp/hudson2909750616001735804.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch Plasma/5.3
== Build Dependencies:
kauth - Branch master
kio-extras - Branch Plasma/5.3
threadweaver - Branch master
plasma-framework - Branch master
kdelibs4support - Branch master
kde-cli-tools - Branch Plasma/5.3
libdbusmenu-qt - Branch master
kdbusaddons - Branch master
kcodecs - Branch master
kplotting - Branch master
kxmlrpcclient - Branch master
kdewebkit - Branch master
kdesupport-svn - Branch master
kwin - Branch Plasma/5.3
kitemmodels - Branch master
ki18n - Branch master
kwallet - Branch master
baloo - Branch Plasma/5.3
kdecoration - Branch Plasma/5.3
kwayland - Branch Plasma/5.3
frameworkintegration - Branch master
extra-cmake-modules - Branch master
khtml - Branch master
kpackage - Branch master
kwindowsystem - Branch master
kbookmarks - Branch master
solid - Branch master
kxmlgui - Branch master
kdesignerplugin - Branch master
kcoreaddons - Branch master
kconfigwidgets - Branch master
libgit2 - Branch master
kunitconversion - Branch master
attica - Branch master
kservice - Branch master
kdnssd - Branch master
kpty - Branch master
kfilemetadata - Branch Plasma/5.3
kdesu - Branch master
kded - Branch master
kconfig - Branch master
kdeclarative - Branch master
kcmutils - Branch master
kwidgetsaddons - Branch master
kcrash - Branch master
kjsembed - Branch master
sonnet - Branch master
breeze - Branch Plasma/5.3
kjobwidgets - Branch master
kemoticons - Branch master
knewstuff - Branch master
kio - Branch master
libkscreen - Branch Plasma/5.3
polkit-qt-1 - Branch master
kcompletion - Branch master
libksysguard - Branch Plasma/5.3
kglobalaccel - Branch master
karchive - Branch master
khelpcenter - Branch Plasma/5.3
knotifyconfig - Branch master
dogtail - Branch master
cmake - Branch master
kjs - Branch master
milou - Branch Plasma/5.3
phonon - Branch master
kross - Branch master
knotifications - Branch master
kguiaddons - Branch master
krunner - Branch master
ktexteditor - Branch master
kinit - Branch master
libssh - Branch master
ktextwidgets - Branch master
kactivities - Branch master
kdoctools - Branch master
kparts - Branch master
kidletime - Branch master
kiconthemes - Branch master
kitemviews - Branch master
qt5 - Branch 5.4
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C
Re: Review Request 123448: Message dialog should be shown before we change a category in the Desktop Settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123448/#review79298 --- Note that currently if you press Apply in the applet's config dialogs, the Apply will not become disabled but will stay enabled forever. - Martin Klapetek On April 21, 2015, 5:04 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123448/ --- (Updated April 21, 2015, 5:04 p.m.) Review request for Plasma. Bugs: 346431 https://bugs.kde.org/show_bug.cgi?id=346431 Repository: plasma-desktop Description --- The Wallpaper and the Mouse Actions category should always show the message dialog if they have pending changes. Futhermore there is no need to check if there are pending changes, since we already know that because of the Apply Button. So we don't need the configurationHasChanged function anymore. Diffs - desktoppackage/contents/configuration/AppletConfiguration.qml 9e61cc0 desktoppackage/contents/configuration/ConfigCategoryDelegate.qml 68301ad Diff: https://git.reviewboard.kde.org/r/123448/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-desktop_stable_qt5 #122
See http://build.kde.org/job/plasma-desktop_stable_qt5/122/changes
Changes:
[lukas] unbreak Revert function
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/plasma-desktop_stable_qt5/ws/
Running Prebuild steps
[plasma-desktop_stable_qt5] $ /bin/sh -xe /tmp/hudson8846805270774067875.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/plasma-desktop
cc28f6b..a71e2d4 Plasma/5.3 - origin/Plasma/5.3
d51418f..d4a619a master - origin/master
Branch jenkins set up to track remote branch Plasma/5.3 from origin.
== Cleaning Source Tree
HEAD is now at cc28f6b revert d7578e55915b95c7849d3c348b75eaf4612f7694
Removing build/
Success build forhudson.tasks.Shell@1c38f0ce
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/plasma-desktop #
timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-desktop
git --version # timeout=10
git -c core.askpass=true fetch --tags --progress
git://anongit.kde.org/plasma-desktop +refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision a71e2d4d5156cc5264eb930d2da64ca42eb7e615
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f a71e2d4d5156cc5264eb930d2da64ca42eb7e615
git rev-list cc28f6bdbacb8f0cf8d98d2f218c5c470fa0cc88 # timeout=10
git tag -a -f -m Jenkins Build #122 jenkins-plasma-desktop_stable_qt5-122 #
timeout=10
[plasma-desktop_stable_qt5] $ /bin/sh -xe /tmp/hudson1511330879503885530.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: plasma-desktop - Branch Plasma/5.3
== Build Dependencies:
kio-extras - Branch Plasma/5.3
kdbusaddons - Branch master
plasma-framework - Branch master
kwidgetsaddons - Branch master
kio - Branch master
kdesignerplugin - Branch master
libssh - Branch master
kdesupport-svn - Branch master
threadweaver - Branch master
kemoticons - Branch master
kauth - Branch master
kguiaddons - Branch master
khtml - Branch master
kded - Branch master
knotifications - Branch master
kwin - Branch Plasma/5.3
kpty - Branch master
ki18n - Branch master
kglobalaccel - Branch master
dogtail - Branch master
attica - Branch master
baloo - Branch Plasma/5.3
khelpcenter - Branch Plasma/5.3
kdelibs4support - Branch master
kconfigwidgets - Branch master
extra-cmake-modules - Branch master
kde-cli-tools - Branch Plasma/5.3
kpackage - Branch master
kwindowsystem - Branch master
libksysguard - Branch Plasma/5.3
libdbusmenu-qt - Branch master
kxmlgui - Branch master
libgit2 - Branch master
kjsembed - Branch master
kwallet - Branch master
kplotting - Branch master
kdewebkit - Branch master
kitemmodels - Branch master
kross - Branch master
ksysguard - Branch Plasma/5.3
kdnssd - Branch master
kbookmarks - Branch master
kinit - Branch master
kfilemetadata - Branch Plasma/5.3
kdesu - Branch master
kdecoration - Branch Plasma/5.3
kcoreaddons - Branch master
kunitconversion - Branch master
breeze - Branch Plasma/5.3
kcmutils - Branch master
kiconthemes - Branch master
kcrash - Branch master
kparts - Branch master
kdeclarative - Branch master
oxygen - Branch Plasma/5.3
kservice - Branch master
systemsettings - Branch Plasma/5.3
knewstuff - Branch master
libkscreen - Branch Plasma/5.3
cmake - Branch master
powerdevil - Branch Plasma/5.3
kcodecs - Branch master
kwayland - Branch Plasma/5.3
polkit-qt-1 - Branch master
kactivities - Branch master
knotifyconfig - Branch master
plasma-workspace - Branch Plasma/5.3
kjs - Branch master
kjobwidgets - Branch master
kconfig - Branch master
milou - Branch Plasma/5.3
sonnet - Branch master
kcompletion - Branch master
phonon - Branch master
kxmlrpcclient - Branch master
krunner - Branch master
frameworkintegration - Branch master
ktextwidgets - Branch master
karchive - Branch master
kdoctools - Branch master
kidletime - Branch master
solid - Branch master
kitemviews - Branch master
qt5 - Branch 5.4
ktexteditor - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification
Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/ --- Review request for Plasma. Bugs: 346441 https://bugs.kde.org/show_bug.cgi?id=346441 Repository: plasma-workspace Description --- The battery information shouldn't be shown on systems which they don't have battery (desktops/laptop without battery). Diffs - lookandfeel/contents/components/InfoPane.qml 18739ad Diff: https://git.reviewboard.kde.org/r/123459/diff/ Testing --- File Attachments no battery after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/21/d3e0b27b-e695-46a2-b56a-dc60c9679309__no_battery_after.png no battery before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/21/884a20d3-852c-4b1d-a588-7bb47e725011__no_battery_before.png Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123457: Plasma-Workspace: we don't need QtWebkit as a depedency.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123457/#review79308 --- Ship it! Ship It! - David Edmundson On April 21, 2015, 8:25 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123457/ --- (Updated April 21, 2015, 8:25 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Plasma-Workspace doesn't need QtWebKit as a depedency anymore. Diffs - CMakeLists.txt 70cc52a Diff: https://git.reviewboard.kde.org/r/123457/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123448: Message dialog should be shown before we change a category in the Desktop Settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123448/#review79307 --- Ship it! Ship It! - Marco Martin On April 21, 2015, 3:04 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123448/ --- (Updated April 21, 2015, 3:04 p.m.) Review request for Plasma. Bugs: 346431 https://bugs.kde.org/show_bug.cgi?id=346431 Repository: plasma-desktop Description --- The Wallpaper and the Mouse Actions category should always show the message dialog if they have pending changes. Futhermore there is no need to check if there are pending changes, since we already know that because of the Apply Button. So we don't need the configurationHasChanged function anymore. Diffs - desktoppackage/contents/configuration/AppletConfiguration.qml 9e61cc0 desktoppackage/contents/configuration/ConfigCategoryDelegate.qml 68301ad Diff: https://git.reviewboard.kde.org/r/123448/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123455: Plasma-Desktop: Desktop Settings apply button should become disabled after it has been pressed.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123455/#review79306 --- Ship it! Ship It! - Marco Martin On April 21, 2015, 7:43 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123455/ --- (Updated April 21, 2015, 7:43 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- The apply button of the Desktop Settings should become disable after it has been pressed. Diffs - desktoppackage/contents/configuration/AppletConfiguration.qml 9e61cc0 Diff: https://git.reviewboard.kde.org/r/123455/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123455: Plasma-Desktop: Desktop Settings apply button should become disabled after it has been pressed.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123455/ --- (Updated April 21, 2015, 8:32 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 2d1ffb563abe97c30aacdc456d60b6a571874a28 by Antonis Tsiapaliokas to branch master. Repository: plasma-desktop Description --- The apply button of the Desktop Settings should become disable after it has been pressed. Diffs - desktoppackage/contents/configuration/AppletConfiguration.qml 9e61cc0 Diff: https://git.reviewboard.kde.org/r/123455/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123457: Plasma-Workspace: we don't need QtWebkit as a depedency.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123457/ --- Review request for Plasma. Repository: plasma-workspace Description --- Plasma-Workspace doesn't need QtWebKit as a depedency anymore. Diffs - CMakeLists.txt 70cc52a Diff: https://git.reviewboard.kde.org/r/123457/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123448: Message dialog should be shown before we change a category in the Desktop Settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123448/ --- (Updated April 21, 2015, 8:30 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 8d6a08416f95ce8b346d205fd4bdab3692ce24de by Antonis Tsiapaliokas to branch master. Bugs: 346431 https://bugs.kde.org/show_bug.cgi?id=346431 Repository: plasma-desktop Description --- The Wallpaper and the Mouse Actions category should always show the message dialog if they have pending changes. Futhermore there is no need to check if there are pending changes, since we already know that because of the Apply Button. So we don't need the configurationHasChanged function anymore. Diffs - desktoppackage/contents/configuration/AppletConfiguration.qml 9e61cc0 desktoppackage/contents/configuration/ConfigCategoryDelegate.qml 68301ad Diff: https://git.reviewboard.kde.org/r/123448/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123420/ --- (Updated April 21, 2015, 7:37 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 8f09567eae260a1241e65e2ec2a9e9ba28bbf0ad by Bernhard Friedreich to branch master. Repository: kdeplasma-addons Description --- Compact Mode: shows the name of the timer and the remaining seconds Using the tooltip it is possible to glance at the timer without opening the full representation by clicking Full Mode: shows information that you can use the scroll wheel to change the digits and choose from predefined timers using the context menu BUG: 259630 Added missing i18n for notifaction finished text Diffs - applets/timer/package/contents/ui/timer.qml 2f7af4f3815b3c8a43e4a7b32d6a020cf3dc0848 Diff: https://git.reviewboard.kde.org/r/123420/diff/ Testing --- File Attachments Compact mode running https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/9b90a460-8808-49bd-969f-cedcc9251f32__tooltip_compact_mode_running.png Compact mode https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/f548efea-0635-4647-b9a3-6d2d4c497bfa__tooltip_compact_mode.png Full mode running https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/c7370926-e497-43f1-a254-8448e4ffbdf0__tooltip_full_mode_running.png Full mode https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/e4068531-ced8-4487-8b2e-d95b339d7e53__tooltip_full_mode.png Compact mode with title and time already set https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/4d574a75-d469-4f65-acb7-6961fe567782__tooltip_compact_mode_title_set.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123411: Protect X11 calls in the Pager plasmoid to prevent plasmashell from crashing in Wayland
On April 18, 2015, 7:50 a.m., Martin Gräßlin wrote: applets/pager/plugin/pager.h, line 144 https://git.reviewboard.kde.org/r/123411/diff/1/?file=361959#file361959line144 m_rows seems not to be initialized if m_isX11 is false I tried to change this in patch revision #2. I hope I'm doing this correctly in ReviewBoard. - Nerdopolis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123411/#review79155 --- On April 22, 2015, 12:05 a.m., Nerdopolis Turfwalker wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123411/ --- (Updated April 22, 2015, 12:05 a.m.) Review request for Plasma. Repository: plasma-desktop Description --- Protect X11 calls in the Pager plasmoid to prevent plasmashell from crashing in Wayland Diffs - applets/pager/plugin/pager.h 78d461d2554e4885721da3d2eff82151c97f9305 applets/pager/plugin/pager.cpp 22c6ca2747f297dc3d37d02b46cb33196e64b1e0 Diff: https://git.reviewboard.kde.org/r/123411/diff/ Testing --- Ran plasmoidviewer -a org.kde.plasma.pager in with QT_QPA_PLATFORM=wayland got no crash from plasmoid viewer. Started an Xephyr session, set QT_QPA_PLATFORM=xcb and DISPLAY=:1, started kwin_x11, and then plasmoidviewer -a org.kde.plasma.pager and had full functionality. Thanks, Nerdopolis Turfwalker ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123411: Protect X11 calls in the Pager plasmoid to prevent plasmashell from crashing in Wayland
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123411/ --- (Updated April 22, 2015, 12:05 a.m.) Review request for Plasma. Changes --- give m_rows a default value of the lowest number of rows supported by the pager Repository: plasma-desktop Description --- Protect X11 calls in the Pager plasmoid to prevent plasmashell from crashing in Wayland Diffs (updated) - applets/pager/plugin/pager.h 78d461d2554e4885721da3d2eff82151c97f9305 applets/pager/plugin/pager.cpp 22c6ca2747f297dc3d37d02b46cb33196e64b1e0 Diff: https://git.reviewboard.kde.org/r/123411/diff/ Testing --- Ran plasmoidviewer -a org.kde.plasma.pager in with QT_QPA_PLATFORM=wayland got no crash from plasmoid viewer. Started an Xephyr session, set QT_QPA_PLATFORM=xcb and DISPLAY=:1, started kwin_x11, and then plasmoidviewer -a org.kde.plasma.pager and had full functionality. Thanks, Nerdopolis Turfwalker ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/#review79321 --- -1 that's what the visible: pmSource.data[Battery][Has Cumulative] is for. there just used to be a bug where that property wasn't created in the first place if no battery was present leading to an exception causing the item to remain visible. - Kai Uwe Broulik On April 21, 2015, 9:18 nachm., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/ --- (Updated April 21, 2015, 9:18 nachm.) Review request for Plasma. Bugs: 346441 https://bugs.kde.org/show_bug.cgi?id=346441 Repository: plasma-workspace Description --- The battery information shouldn't be shown on systems which they don't have battery (desktops/laptop without battery). Diffs - lookandfeel/contents/components/InfoPane.qml 18739ad Diff: https://git.reviewboard.kde.org/r/123459/diff/ Testing --- File Attachments no battery after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/21/d3e0b27b-e695-46a2-b56a-dc60c9679309__no_battery_after.png no battery before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/21/884a20d3-852c-4b1d-a588-7bb47e725011__no_battery_before.png Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 346456] New: When screen turn off automatically, it will turn black twice.
https://bugs.kde.org/show_bug.cgi?id=346456 Bug ID: 346456 Summary: When screen turn off automatically, it will turn black twice. Product: Powerdevil Version: 5.2.95 Platform: Chakra OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: wen...@gmail.com When set screen off automatically, the screen will turn black first, then turn on quickly and then turn black again. My graphic card is intel. I suspect this is caused by the new feature of powerdevil invoking kwin effect. Reproducible: Sometimes -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123444: [ksmserver] Do not try to start X11 window manager if Wayland env variables are set
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123444/ --- (Updated April 21, 2015, 10:58 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 3a7e17c997a8419ade1520768d28a4740387b4a1 by Martin Gräßlin to branch master. Repository: plasma-workspace Description --- If ksmserver is started in a session with WAYLAND_DISPLAY and/or WAYLAND_SOCKET being exported we can assume that the Xserver is an Xwayland server. In that case the wayland compositor is also the window maager. Thus starting a window manager would either fail or create severe havoc in case it succeeds in replacing the running window manager. Diffs - ksmserver/startup.cpp d0071f2fe34bfed784112244199eadfa28c8a97c Diff: https://git.reviewboard.kde.org/r/123444/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123444: [ksmserver] Do not try to start X11 window manager if Wayland env variables are set
On April 21, 2015, 12:45 p.m., David Edmundson wrote: related to this, on logout ksmserver kills kwin. If you're up first, I assume you also need to be down last? oh I wasn't aware the ksmserver kills kwin. I assumed it's the X connection going away that kills kwin. Will search for it and fix it, too. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123444/#review79278 --- On April 21, 2015, 10:33 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123444/ --- (Updated April 21, 2015, 10:33 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- If ksmserver is started in a session with WAYLAND_DISPLAY and/or WAYLAND_SOCKET being exported we can assume that the Xserver is an Xwayland server. In that case the wayland compositor is also the window maager. Thus starting a window manager would either fail or create severe havoc in case it succeeds in replacing the running window manager. Diffs - ksmserver/startup.cpp d0071f2fe34bfed784112244199eadfa28c8a97c Diff: https://git.reviewboard.kde.org/r/123444/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123444: [ksmserver] Do not try to start X11 window manager if Wayland env variables are set
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123444/#review79278 --- related to this, on logout ksmserver kills kwin. If you're up first, I assume you also need to be down last? - David Edmundson On April 21, 2015, 8:33 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123444/ --- (Updated April 21, 2015, 8:33 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- If ksmserver is started in a session with WAYLAND_DISPLAY and/or WAYLAND_SOCKET being exported we can assume that the Xserver is an Xwayland server. In that case the wayland compositor is also the window maager. Thus starting a window manager would either fail or create severe havoc in case it succeeds in replacing the running window manager. Diffs - ksmserver/startup.cpp d0071f2fe34bfed784112244199eadfa28c8a97c Diff: https://git.reviewboard.kde.org/r/123444/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123444: [ksmserver] Do not try to start X11 window manager if Wayland env variables are set
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123444/#review79279 --- Ship it! Ship It! - David Edmundson On April 21, 2015, 8:33 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123444/ --- (Updated April 21, 2015, 8:33 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- If ksmserver is started in a session with WAYLAND_DISPLAY and/or WAYLAND_SOCKET being exported we can assume that the Xserver is an Xwayland server. In that case the wayland compositor is also the window maager. Thus starting a window manager would either fail or create severe havoc in case it succeeds in replacing the running window manager. Diffs - ksmserver/startup.cpp d0071f2fe34bfed784112244199eadfa28c8a97c Diff: https://git.reviewboard.kde.org/r/123444/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Plasma Workspace Wallpapers] [Bug 346425] New: crash when you want to change the time of image sequences
https://bugs.kde.org/show_bug.cgi?id=346425 Bug ID: 346425 Summary: crash when you want to change the time of image sequences Product: Plasma Workspace Wallpapers Version: 5.2.95 Platform: openSUSE RPMs OS: Solaris Status: UNCONFIRMED Severity: crash Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: marcs...@web.de Application: plasmashell (5.2.95) Qt Version: 5.4.1 Operating System: Linux 3.19.3-1-desktop x86_64 Distribution: openSUSE 20150418 (Tumbleweed) (x86_64) -- Information about the crash: In detail, tell us what you were doing when the application crashed. -- Backtrace: Application: Plasma (plasmashell), signal: Segmentation fault Using host libthread_db library /lib64/libthread_db.so.1. [Current thread is 1 (Thread 0x7fd384903880 (LWP 6187))] Thread 27 (Thread 0x7fd36e37f700 (LWP 6189)): #0 0x7fd37e3964cd in poll () at /lib64/libc.so.6 #1 0x7fd3831eb322 in () at /usr/lib64/libxcb.so.1 #2 0x7fd3831ecdef in xcb_wait_for_event () at /usr/lib64/libxcb.so.1 #3 0x7fd3706fbc69 in () at /usr/lib64/qt5/plugins/platforms/libqxcb.so #4 0x7fd37ea0797f in () at /usr/lib64/libQt5Core.so.5 #5 0x7fd37d980484 in start_thread () at /lib64/libpthread.so.0 #6 0x7fd37e39ea4d in clone () at /lib64/libc.so.6 Thread 26 (Thread 0x7fd367c2f700 (LWP 6192)): #0 0x7fd37e3964cd in poll () at /lib64/libc.so.6 #1 0x7fd37a82be54 in () at /usr/lib64/libglib-2.0.so.0 #2 0x7fd37a82bf6c in g_main_context_iteration () at /usr/lib64/libglib-2.0.so.0 #3 0x7fd37ec392ab in QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () at /usr/lib64/libQt5Core.so.5 #4 0x7fd37ebdfe9b in QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) () at /usr/lib64/libQt5Core.so.5 #5 0x7fd37ea02d4a in QThread::exec() () at /usr/lib64/libQt5Core.so.5 #6 0x7fd381ca3f68 in () at /usr/lib64/libQt5Qml.so.5 #7 0x7fd37ea0797f in () at /usr/lib64/libQt5Core.so.5 #8 0x7fd37d980484 in start_thread () at /lib64/libpthread.so.0 #9 0x7fd37e39ea4d in clone () at /lib64/libc.so.6 Thread 25 (Thread 0x7fd35abdf700 (LWP 6267)): #0 0x7fd37d98491f in pthread_cond_wait@@GLIBC_2.3.2 () at /lib64/libpthread.so.0 #1 0x7fd3646b46a3 in () at /usr/lib64/dri/radeonsi_dri.so #2 0x7fd3646b3f57 in () at /usr/lib64/dri/radeonsi_dri.so #3 0x7fd37d980484 in start_thread () at /lib64/libpthread.so.0 #4 0x7fd37e39ea4d in clone () at /lib64/libc.so.6 Thread 24 (Thread 0x7fd354cc7700 (LWP 6340)): #0 0x7fd37a86dcb9 in g_mutex_lock () at /usr/lib64/libglib-2.0.so.0 #1 0x7fd37a82b4a9 in g_main_context_prepare () at /usr/lib64/libglib-2.0.so.0 #2 0x7fd37a82bd70 in () at /usr/lib64/libglib-2.0.so.0 #3 0x7fd37a82bf6c in g_main_context_iteration () at /usr/lib64/libglib-2.0.so.0 #4 0x7fd37ec392ab in QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () at /usr/lib64/libQt5Core.so.5 #5 0x7fd37ebdfe9b in QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) () at /usr/lib64/libQt5Core.so.5 #6 0x7fd37ea02d4a in QThread::exec() () at /usr/lib64/libQt5Core.so.5 #7 0x7fd381ca3f68 in () at /usr/lib64/libQt5Qml.so.5 #8 0x7fd37ea0797f in () at /usr/lib64/libQt5Core.so.5 #9 0x7fd37d980484 in start_thread () at /lib64/libpthread.so.0 #10 0x7fd37e39ea4d in clone () at /lib64/libc.so.6 Thread 23 (Thread 0x7fd34ebbf700 (LWP 6394)): #0 0x7fd37e39259d in read () at /lib64/libc.so.6 #1 0x7fd37a86cb20 in () at /usr/lib64/libglib-2.0.so.0 #2 0x7fd37a82b989 in g_main_context_check () at /usr/lib64/libglib-2.0.so.0 #3 0x7fd37a82bde8 in () at /usr/lib64/libglib-2.0.so.0 #4 0x7fd37a82bf6c in g_main_context_iteration () at /usr/lib64/libglib-2.0.so.0 #5 0x7fd37ec392ab in QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () at /usr/lib64/libQt5Core.so.5 #6 0x7fd37ebdfe9b in QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) () at /usr/lib64/libQt5Core.so.5 #7 0x7fd37ea02d4a in QThread::exec() () at /usr/lib64/libQt5Core.so.5 #8 0x7fd381ca3f68 in () at /usr/lib64/libQt5Qml.so.5 #9 0x7fd37ea0797f in () at /usr/lib64/libQt5Core.so.5 #10 0x7fd37d980484 in start_thread () at /lib64/libpthread.so.0 #11 0x7fd37e39ea4d in clone () at /lib64/libc.so.6 Thread 22 (Thread 0x7fd34db2e700 (LWP 6397)): #0 0x7fd37e3964cd in poll () at /lib64/libc.so.6 #1 0x7fd37a82be54 in () at /usr/lib64/libglib-2.0.so.0 #2 0x7fd37a82bf6c in g_main_context_iteration () at /usr/lib64/libglib-2.0.so.0 #3 0x7fd37ec392ab in QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () at /usr/lib64/libQt5Core.so.5 #4 0x7fd37ebdfe9b in QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) () at /usr/lib64/libQt5Core.so.5 #5
Re: Review Request 123448: Message dialog should be shown before we change a category in the Desktop Settings
On April 21, 2015, 3:31 p.m., Martin Klapetek wrote: Note that currently if you press Apply in the applet's config dialogs, the Apply will not become disabled but will stay enabled forever. Antonis Tsiapaliokas wrote: Oh, i see. Then i guess i can fix this one too. I will open another review for that one. Here is the patch for the above bug. https://git.reviewboard.kde.org/r/123455/ - Antonis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123448/#review79298 --- On April 21, 2015, 3:04 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123448/ --- (Updated April 21, 2015, 3:04 p.m.) Review request for Plasma. Bugs: 346431 https://bugs.kde.org/show_bug.cgi?id=346431 Repository: plasma-desktop Description --- The Wallpaper and the Mouse Actions category should always show the message dialog if they have pending changes. Futhermore there is no need to check if there are pending changes, since we already know that because of the Apply Button. So we don't need the configurationHasChanged function anymore. Diffs - desktoppackage/contents/configuration/AppletConfiguration.qml 9e61cc0 desktoppackage/contents/configuration/ConfigCategoryDelegate.qml 68301ad Diff: https://git.reviewboard.kde.org/r/123448/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123455: Plasma-Desktop: Desktop Settings apply button should become disabled after it has been pressed.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123455/ --- Review request for Plasma. Repository: plasma-desktop Description --- The apply button of the Desktop Settings should become disable after it has been pressed. Diffs - desktoppackage/contents/configuration/AppletConfiguration.qml 9e61cc0 Diff: https://git.reviewboard.kde.org/r/123455/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/#review79311 --- lookandfeel/contents/components/InfoPane.qml (line 47) https://git.reviewboard.kde.org/r/123459/#comment54152 there's a visible here. If your two lines are needed, this isn't. Or this should be changed to the battery.hasBattery instead. - David Edmundson On April 21, 2015, 9:18 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/ --- (Updated April 21, 2015, 9:18 p.m.) Review request for Plasma. Bugs: 346441 https://bugs.kde.org/show_bug.cgi?id=346441 Repository: plasma-workspace Description --- The battery information shouldn't be shown on systems which they don't have battery (desktops/laptop without battery). Diffs - lookandfeel/contents/components/InfoPane.qml 18739ad Diff: https://git.reviewboard.kde.org/r/123459/diff/ Testing --- File Attachments no battery after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/21/d3e0b27b-e695-46a2-b56a-dc60c9679309__no_battery_after.png no battery before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/21/884a20d3-852c-4b1d-a588-7bb47e725011__no_battery_before.png Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/#review79312 --- Ship it! Ship It! - Lukáš Tinkl On Dub. 21, 2015, 11:18 odp., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/ --- (Updated Dub. 21, 2015, 11:18 odp.) Review request for Plasma. Bugs: 346441 https://bugs.kde.org/show_bug.cgi?id=346441 Repository: plasma-workspace Description --- The battery information shouldn't be shown on systems which they don't have battery (desktops/laptop without battery). Diffs - lookandfeel/contents/components/InfoPane.qml 18739ad Diff: https://git.reviewboard.kde.org/r/123459/diff/ Testing --- File Attachments no battery after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/21/d3e0b27b-e695-46a2-b56a-dc60c9679309__no_battery_after.png no battery before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/21/884a20d3-852c-4b1d-a588-7bb47e725011__no_battery_before.png Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
