Re: Review Request 117635: Remember and restore isPowered for adapters

2015-07-11 Thread Daniel Schaal 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117635/
---

(Updated Juli 12, 2015, 6:37 vorm.)


Status
--

This change has been discarded.


Review request for Bluedevil, Plasma and Solid.


Repository: bluedevil


Description
---

Remember the isPowered value for adapters and restore it on restart as Bluez 5 
no longer does this for us.


Diffs
-

  src/monolithic/monolithic.cpp 016f930 

Diff: https://git.reviewboard.kde.org/r/117635/diff/


Testing
---

Setting isPowered to true or false and restarting bluedevil-monolithic


Thanks,

Daniel Schaal

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[ksystraycmd] [Bug 344168] there is no ksystray for plasma5

2015-07-11 Thread Bhushan Shah 
https://bugs.kde.org/show_bug.cgi?id=344168

--- Comment #18 from Bhushan Shah  ---
*** Bug 350136 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 73 - Still Failing!

2015-07-11 Thread no-reply 

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/73/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 12 Jul 2015 00:03:48 +
Build duration: 11 min

CHANGE SET
Revision febaa59d1ba0399a28ff3033130464ef1397d379 by kde: (Remove pragma 
library)
  change: edit containments/desktop/package/contents/code/LayoutManager.js
  change: edit containments/panel/contents/code/LayoutManager.js
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 72 - Failure!

2015-07-11 Thread no-reply 

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/72/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 11 Jul 2015 21:26:48 +
Build duration: 11 min

CHANGE SET
Revision 9f7570d69dc38d6f4ae68848f3006fa8a858265c by lueck: (load correct 
catalog for mouse cursor kcm)
  change: edit kcms/cursortheme/CMakeLists.txt
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 102983: Added support for rfkill

2015-07-11 Thread Lamarque Souza 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/102983/#review82364
---



bluedevil/bluedevilmanager.h (line 109)


We use camel case for enumerate's names too.



bluedevil/bluedevilmanager.h (line 136)


isRfkillSwitchSupported() const;



bluedevil/bluedevilmanager.cpp (line 41)


Is rfkill supported in BSD? If so then this dev path may be different in 
that platform.



bluedevil/bluedevilmanager.cpp (line 41)


Is rfkill supported in BSD? If so then this dev path may be different in 
that platform.



bluedevil/bluedevilmanager.cpp (line 41)


Is rfkill supported in BSD? If so then this dev path may be different in 
that platform.



bluedevil/bluedevilmanager.cpp (line 156)


bool isValid() const



bluedevil/bluedevilmanager.cpp (line 156)


bool isValid() const



bluedevil/bluedevilmanager.cpp (line 383)


Use normalized signal/slots [1]:

connect(d->m_rfkill.getFileSystemWatcher(), SIGNAL(fileChanged(QString)),
   this, SLOT(_k_rfkillChanged(QString)));

[1] http://doc.qt.io/qt-4.8/signalsandslots.html



bluedevil/test/bluedeviltest.cpp (line 103)


Please fix identation. I think the text should "RfkillSwitch supported! 
Status: "



bluedevil/test/bluedeviltest.cpp (line 119)


} else {



bluedevil/test/bluedeviltest.cpp (line 121)


"RfkillSwitch not supported in this platform"


- Lamarque Souza


On July 11, 2015, 8:43 p.m., Rüdiger Sonderfeld wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/102983/
> ---
> 
> (Updated July 11, 2015, 8:43 p.m.)
> 
> 
> Review request for Plasma and Solid.
> 
> 
> Repository: libbluedevil
> 
> 
> Description
> ---
> 
> rfkill is a subsystem of the Linux Kernel to disable radio transmitters 
> (including Bluetooth). This patch adds support for rfkill to libbluedevil. An 
> interface is added to the Manager class.
> 
> rfkill support is important because gnome uses rfkill to deactivate 
> bluetooth. Therefore if bluetooth is currently disabled in the 
> gnome-control-center it can not be used by kde. With this patch the proper 
> API to reenable bluetooth is provided.
> 
> Disabling bluetooth with rfkill has the advantage that some computers switch 
> off the bluetooth LED. Which does not happen (at least on my Thinkpad) if 
> it's just powered off (as kde does at the moment).
> 
> rfkill can also detect if bluetooth has been deactivated by a hardware switch.
> 
> btw. please mark https://gitorious.org/libbluedevil/libbluedevil as obsolete 
> and update http://projects.ufocoders.com/projects/libbluedevil/wiki. I used 
> the old gitorious code base at first.
> 
> 
> Diffs
> -
> 
>   bluedevil/bluedevilmanager.h 0386b8e 
>   bluedevil/bluedevilmanager.cpp 594d3bd 
>   bluedevil/test/bluedeviltest.cpp 2d3d0e2 
> 
> Diff: https://git.reviewboard.kde.org/r/102983/diff/
> 
> 
> Testing
> ---
> 
> I added a test to bluedeviltest and it works for me.
> 
> 
> Thanks,
> 
> Rüdiger Sonderfeld
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117635: Remember and restore isPowered for adapters

2015-07-11 Thread Daniel Schaal 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117635/
---

(Updated jul. 11, 2015, 8:47 p.m.)


Review request for Bluedevil, Plasma and Solid.


Repository: bluedevil


Description
---

Remember the isPowered value for adapters and restore it on restart as Bluez 5 
no longer does this for us.


Diffs
-

  src/monolithic/monolithic.cpp 016f930 

Diff: https://git.reviewboard.kde.org/r/117635/diff/


Testing
---

Setting isPowered to true or false and restarting bluedevil-monolithic


Thanks,

Daniel Schaal

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 102983: Added support for rfkill

2015-07-11 Thread Rüdiger Sonderfeld 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/102983/
---

(Updated jul. 11, 2015, 8:43 p.m.)


Review request for Plasma and Solid.


Repository: libbluedevil


Description
---

rfkill is a subsystem of the Linux Kernel to disable radio transmitters 
(including Bluetooth). This patch adds support for rfkill to libbluedevil. An 
interface is added to the Manager class.

rfkill support is important because gnome uses rfkill to deactivate bluetooth. 
Therefore if bluetooth is currently disabled in the gnome-control-center it can 
not be used by kde. With this patch the proper API to reenable bluetooth is 
provided.

Disabling bluetooth with rfkill has the advantage that some computers switch 
off the bluetooth LED. Which does not happen (at least on my Thinkpad) if it's 
just powered off (as kde does at the moment).

rfkill can also detect if bluetooth has been deactivated by a hardware switch.

btw. please mark https://gitorious.org/libbluedevil/libbluedevil as obsolete 
and update http://projects.ufocoders.com/projects/libbluedevil/wiki. I used the 
old gitorious code base at first.


Diffs
-

  bluedevil/bluedevilmanager.h 0386b8e 
  bluedevil/bluedevilmanager.cpp 594d3bd 
  bluedevil/test/bluedeviltest.cpp 2d3d0e2 

Diff: https://git.reviewboard.kde.org/r/102983/diff/


Testing
---

I added a test to bluedeviltest and it works for me.


Thanks,

Rüdiger Sonderfeld

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Qt High DPI scaling v2

2015-07-11 Thread David Edmundson 
Thanks for the heads up.
It's for 5.6, and from our POV it's just a variable rename.

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel