Re: Review Request 102983: Added support for rfkill
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102983/#review82377 --- Can you please discard this review? libbluedevil is not used in recent Plasma release (replaced with bluez-qt which have support for rfkill), and there won't be any more KDE4 nor Plasma 5.2.x releases. - David Rosca On July 11, 2015, 8:43 p.m., Rüdiger Sonderfeld wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102983/ --- (Updated July 11, 2015, 8:43 p.m.) Review request for Plasma and Solid. Repository: libbluedevil Description --- rfkill is a subsystem of the Linux Kernel to disable radio transmitters (including Bluetooth). This patch adds support for rfkill to libbluedevil. An interface is added to the Manager class. rfkill support is important because gnome uses rfkill to deactivate bluetooth. Therefore if bluetooth is currently disabled in the gnome-control-center it can not be used by kde. With this patch the proper API to reenable bluetooth is provided. Disabling bluetooth with rfkill has the advantage that some computers switch off the bluetooth LED. Which does not happen (at least on my Thinkpad) if it's just powered off (as kde does at the moment). rfkill can also detect if bluetooth has been deactivated by a hardware switch. btw. please mark https://gitorious.org/libbluedevil/libbluedevil as obsolete and update http://projects.ufocoders.com/projects/libbluedevil/wiki. I used the old gitorious code base at first. Diffs - bluedevil/bluedevilmanager.h 0386b8e bluedevil/bluedevilmanager.cpp 594d3bd bluedevil/test/bluedeviltest.cpp 2d3d0e2 Diff: https://git.reviewboard.kde.org/r/102983/diff/ Testing --- I added a test to bluedeviltest and it works for me. Thanks, Rüdiger Sonderfeld ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: on review process again.. phabricator?
One issue from 'many projects sharing the same phab' is that the main page gets populated with 'Unbreak now!' issues from other projects. Nothing really problematic, but it would be nice if these would be filtered on the projects a user is interested on. Cheers, Ivan On 8 July 2015 at 23:20, Ben Cooksley bcooks...@kde.org wrote: On Thu, Jul 9, 2015 at 2:18 AM, Boudewijn Rempt b...@valdyas.org wrote: On Wed, 8 Jul 2015, Marco Martin wrote: Some projects are trying out phabricator (looking at kactivities) how do they find it? Krita developers, testers and designers all feel Phabricator is pretty fab. Newbies take to it easiliy. It takes getting used to because it's more than a reviewboard replacement, it also has project management, task management and much more. The way different projects/repos share the website is a bit of a put-off at the moment. You don't get kactivities.phabricator.kde.org, but you find all repos in one website. Unfortunately there is little we can do about this - it, like most software out there, is designed for one project sharing a very closely related group of tasks, repositories, etc. KDE doesn't really fit that pattern anymore, but having multiple instances of it is totally infeasible. I'd like to know more about where this falls down though to see if it can be remedied to a certain extent. can it go more large scale? (more a sysadmin question) If it doesn't have big obvious problems I would like to try it on plasma-framework at least. To eventually have plasma-workspace et al too, but not yet (at least I would never want gerrit on those projects..) Boudewijn Cheers, Ben ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Cheerio, Ivan -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straight into the shining sun ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123828: Fix KF5 port regression in kcm_standard_actions
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123828/ --- (Updated July 12, 2015, 1:19 p.m.) Review request for Plasma, David Edmundson, Martin Gräßlin, and Michael Jansen. Changes --- Add plasma group as reviewer, hope to get more eyes on it that way... This is really quite a bad bug. Bugs: 343665 https://bugs.kde.org/show_bug.cgi?id=343665 Repository: plasma-desktop Description --- The KShortcutsEditor reads the property defaultShortcuts from the assigned QAction. Fill it in with default hardcoded shortcuts. Appending the defaults to the list of active shortcuts just creates shortcut lists that grow longer and longer every time user saves settings in this KCM. Still does not have a solution for upgrade of existing users' configuration. If the user has a messed up kdeglobals file now, after installing upgrade with this fix user will have to open up this KCM and hit Defaults button to reset settings. After that things should work ok. I don't have any idea for solution of automatically correcting broken config file after upgrade. Diffs - kcms/standard_actions/standard_actions_module.cpp d1c4ad3 Diff: https://git.reviewboard.kde.org/r/123828/diff/ Testing --- Basic testing to see how the config file kdeglobals look after saving some changed shortcuts, looks correct to me. Now only the shortcuts that are not default are saved, and they are saved correctly (verified that by closing kcm, opening it again and saw that my settings were still intact). Thanks, Simon Persson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 74 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/74/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 12 Jul 2015 14:51:45 + Build duration: 16 min CHANGE SET Revision 87d53433b511a0bab0f9ad2161e42546f356f70f by lueck: (Update kcmstyle docbook to Plasma 5 REVIEW:124283) change: edit doc/kcontrol/kcmstyle/index.docbook JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 7/7 (100%)FILES 36/38 (95%)CLASSES 36/38 (95%)LINE 2370/3410 (70%)CONDITIONAL 1784/3081 (58%) By packages kcms.cursortheme.xcursor FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 90/187 (48%)CONDITIONAL 18/34 (53%) kcms.keyboard FILES 20/22 (91%)CLASSES 20/22 (91%)LINE 800/1526 (52%)CONDITIONAL 771/1270 (61%) kcms.keyboard.preview FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 503/584 (86%)CONDITIONAL 511/994 (51%) kcms.keyboard.tests FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 251/253 (99%)CONDITIONAL 242/364 (66%) kcms.krdb FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 357/410 (87%)CONDITIONAL 108/178 (61%) kcms.lookandfeel FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 269/350 (77%)CONDITIONAL 82/137 (60%) kcms.lookandfeel.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 (100%)CONDITIONAL 52/104 (50%)___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124283: Update kcmstyle docbook to Plasma 5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124283/ --- (Updated July 12, 2015, 2:51 p.m.) Status -- This change has been marked as submitted. Review request for Documentation and Plasma. Changes --- Submitted with commit 87d53433b511a0bab0f9ad2161e42546f356f70f by Burkhard Lück to branch master. Repository: plasma-desktop Description --- see Summary appmenu commented in docbook, because it is not available in Plasma 5, is this correct? Diffs - doc/kcontrol/kcmstyle/index.docbook a0b456b Diff: https://git.reviewboard.kde.org/r/124283/diff/ Testing --- builds Thanks, Burkhard Lück ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
