Re: Review Request 124409: Begin fading the OSD immediately
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 21, 2015, 3:05 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and KDE Usability. Changes --- Submitted with commit ca33e8ee69eab68b024014509675d33f490b91a8 by Kai Uwe Broulik to branch master. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 350434] SDDM theme does not use Breeze user icons
https://bugs.kde.org/show_bug.cgi?id=350434 --- Comment #2 from David Edmundson k...@davidedmundson.co.uk --- Slightly tricky; SDDM decided to add code themselves into show a fallback icon they provide from /usr/share/sddm/faces This path overridable in sddm.conf So now instead of getting a file path, or nothing we always get something. From Breeze's POV we have no good idea if we're loading the user's face or a stock icon. Even if we did somehow add code in breeze, that would only break SDDM's config option. At /best/ breeze could supply the files into the same directory structure as /usr/share/sddm/faces and we tell distros to change that path. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124374: custom inline edit menu for plasma controls
On July 21, 2015, 4:20 p.m., Andrew Lake wrote: Very nice. A couple questions: 1. Are the inline selectiion handles grab-able? I assume yes. 2. Does this automatically appear when a selection is made or on right-click? I assume the former. It would eventually be nice to have this solution for main application controls as well (or at least QtQuick controls) Anyway, quite nice. It's purely for touchscreen interfaces, on a desktop system none of this would appear/have effect: the menu would be a normal qmenu and only appear on right click. so the blue things are draggable. The thing is supported by qtquickcontrols out of the box, but is style-dependent and the upstream qstyle based style doesn't support it - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124374/#review82771 --- On July 21, 2015, 9:35 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124374/ --- (Updated July 21, 2015, 9:35 a.m.) Review request for Plasma. Repository: plasma-framework Description --- This depends from https://codereview.qt-project.org/#/c/121659/ provides the needed elements for touch based text selection and inline (no separate window) menu for cut/copy/paste Diffs - src/declarativeimports/plasmastyle/CursorHandleStyle.qml PRE-CREATION src/declarativeimports/plasmastyle/EditMenuTouch.qml PRE-CREATION src/declarativeimports/plasmastyle/SelectionHandleStyle.qml PRE-CREATION src/declarativeimports/plasmastyle/TextAreaStyle.qml 114c322 src/declarativeimports/plasmastyle/TextFieldStyle.qml 635c938 Diff: https://git.reviewboard.kde.org/r/124374/diff/ Testing --- File Attachments snapshot1.png https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124374: custom inline edit menu for plasma controls
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124374/#review82771 --- Very nice. A couple questions: 1. Are the inline selectiion handles grab-able? I assume yes. 2. Does this automatically appear when a selection is made or on right-click? I assume the former. It would eventually be nice to have this solution for main application controls as well (or at least QtQuick controls) Anyway, quite nice. - Andrew Lake On July 21, 2015, 9:35 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124374/ --- (Updated July 21, 2015, 9:35 a.m.) Review request for Plasma. Repository: plasma-framework Description --- This depends from https://codereview.qt-project.org/#/c/121659/ provides the needed elements for touch based text selection and inline (no separate window) menu for cut/copy/paste Diffs - src/declarativeimports/plasmastyle/CursorHandleStyle.qml PRE-CREATION src/declarativeimports/plasmastyle/EditMenuTouch.qml PRE-CREATION src/declarativeimports/plasmastyle/SelectionHandleStyle.qml PRE-CREATION src/declarativeimports/plasmastyle/TextAreaStyle.qml 114c322 src/declarativeimports/plasmastyle/TextFieldStyle.qml 635c938 Diff: https://git.reviewboard.kde.org/r/124374/diff/ Testing --- File Attachments snapshot1.png https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124374: custom inline edit menu for plasma controls
On July 21, 2015, 4:20 p.m., Andrew Lake wrote: Very nice. A couple questions: 1. Are the inline selectiion handles grab-able? I assume yes. 2. Does this automatically appear when a selection is made or on right-click? I assume the former. It would eventually be nice to have this solution for main application controls as well (or at least QtQuick controls) Anyway, quite nice. Marco Martin wrote: It's purely for touchscreen interfaces, on a desktop system none of this would appear/have effect: the menu would be a normal qmenu and only appear on right click. so the blue things are draggable. The thing is supported by qtquickcontrols out of the box, but is style-dependent and the upstream qstyle based style doesn't support it Very cool, thanks. - Andrew --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124374/#review82771 --- On July 21, 2015, 9:35 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124374/ --- (Updated July 21, 2015, 9:35 a.m.) Review request for Plasma. Repository: plasma-framework Description --- This depends from https://codereview.qt-project.org/#/c/121659/ provides the needed elements for touch based text selection and inline (no separate window) menu for cut/copy/paste Diffs - src/declarativeimports/plasmastyle/CursorHandleStyle.qml PRE-CREATION src/declarativeimports/plasmastyle/EditMenuTouch.qml PRE-CREATION src/declarativeimports/plasmastyle/SelectionHandleStyle.qml PRE-CREATION src/declarativeimports/plasmastyle/TextAreaStyle.qml 114c322 src/declarativeimports/plasmastyle/TextFieldStyle.qml 635c938 Diff: https://git.reviewboard.kde.org/r/124374/diff/ Testing --- File Attachments snapshot1.png https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-desktop Plasma-5.3 stable-kf5-qt5 » Linux,gcc - Build # 5 - Still Failing!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.3%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/5/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Jul 2015 16:50:13 + Build duration: 7 min 9 sec CHANGE SET Revision 6706161541c147bc600cdde36c2404c7ce070ef7 by scripty: (SVN_SILENT made messages (.desktop file)) change: edit kcms/keyboard/kcm_keyboard.desktop ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 350434] SDDM theme does not use Breeze user icons
https://bugs.kde.org/show_bug.cgi?id=350434 --- Comment #3 from Markus S. kamika...@web.de --- (In reply to David Edmundson from comment #2) This path overridable in sddm.conf Why not then make the KCM change the path on theme change? Would this also fix displaying custom per-user icons set in System Settings? -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124415: Don't crash when OSD QML file is invalid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124415/ --- Review request for Plasma. Repository: plasma-workspace Description --- Added a syntax error to my osd.qml, Plasma would no longer crash, neither on startup, nor when the OSD should be shown. Diffs - shell/osd.cpp 3e8bd70 Diff: https://git.reviewboard.kde.org/r/124415/diff/ Testing --- Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124394: Timer: trying to fix missing translation in config file (not working)
On Juli 19, 2015, 4:51 nachm., Kai Uwe Broulik wrote: What about just leaving the default an empty string and then do a fallback on the QML side? Bernhard Friedreich wrote: that should be possible yes.. but shouldn't it also work like this? Martin Klapetek wrote: I think you are supposed to just add TranslationSystem=kde and TranslationDomain=your-translation-domain into the kcfgc file and the rest is automagic. Emphasizes on the think. Martin Klapetek wrote: ...and then you should use label.../label or text.../text. hm.. I couldn't find any examples on how to integrate a kcfgc file with a plasmoid - is this supposed to be done? Or shall I just fallback to the solution proposed by Kai? If you think this is the way to go I'll try of course :) - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124394/#review82655 --- On Juli 19, 2015, 2:25 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124394/ --- (Updated Juli 19, 2015, 2:25 nachm.) Review request for Plasma. Bugs: 347492 http://bugs.kde.org/show_bug.cgi?id=347492 Repository: kdeplasma-addons Description --- I'm trying to fix a missing translation in the timer applets config file (config.xml using kcfg) but I can't get it to work :( David Edmundson commented in the bug if this fixed it - I don't think so - or at least I don't understand what to do with it.. https://git.reviewboard.kde.org/r/123872/ Any suggestions? Diffs - applets/timer/package/contents/config/main.xml 833bf8f45df4f0e468301a426852bf01c94e1221 Diff: https://git.reviewboard.kde.org/r/124394/diff/ Testing --- Tried adding the applet - the full i18n String is used instead of a translation/the original string Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124394: Timer: trying to fix missing translation in config file (not working)
On July 19, 2015, 6:51 p.m., Kai Uwe Broulik wrote: What about just leaving the default an empty string and then do a fallback on the QML side? Bernhard Friedreich wrote: that should be possible yes.. but shouldn't it also work like this? Martin Klapetek wrote: I think you are supposed to just add TranslationSystem=kde and TranslationDomain=your-translation-domain into the kcfgc file and the rest is automagic. Emphasizes on the think. Martin Klapetek wrote: ...and then you should use label.../label or text.../text. Bernhard Friedreich wrote: hm.. I couldn't find any examples on how to integrate a kcfgc file with a plasmoid - is this supposed to be done? Or shall I just fallback to the solution proposed by Kai? If you think this is the way to go I'll try of course :) I'd say whatever works. I'm not entirely sure it works with qml and we use the fallback everywhere anyway. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124394/#review82655 --- On July 19, 2015, 4:25 p.m., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124394/ --- (Updated July 19, 2015, 4:25 p.m.) Review request for Plasma. Bugs: 347492 http://bugs.kde.org/show_bug.cgi?id=347492 Repository: kdeplasma-addons Description --- I'm trying to fix a missing translation in the timer applets config file (config.xml using kcfg) but I can't get it to work :( David Edmundson commented in the bug if this fixed it - I don't think so - or at least I don't understand what to do with it.. https://git.reviewboard.kde.org/r/123872/ Any suggestions? Diffs - applets/timer/package/contents/config/main.xml 833bf8f45df4f0e468301a426852bf01c94e1221 Diff: https://git.reviewboard.kde.org/r/124394/diff/ Testing --- Tried adding the applet - the full i18n String is used instead of a translation/the original string Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 87 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/87/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Jul 2015 21:20:14 + Build duration: 11 min CHANGE SET Revision 9e6dd77ecfc2286d3d4278e700a382cc94cc458d by hein: (Add toggle to use launcher vs. window icons.) change: edit applets/taskmanager/package/contents/ui/ConfigGeneral.qml change: edit applets/taskmanager/package/contents/config/main.xml change: edit applets/taskmanager/package/contents/ui/main.qml ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122488: Improved calendar navigation
On Mai 21, 2015, 5:24 nachm., Martin Klapetek wrote: Bump. Can we get this in for 5.4? Marco Martin wrote: ugh, i almost forgot about this... yes please Just tested the patch. Working beautifully for me from a user perspective :) - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review80706 --- On Juli 18, 2015, 8:28 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/ --- (Updated Juli 18, 2015, 8:28 nachm.) Review request for Plasma and KDE Usability. Repository: plasma-framework Description --- This improves the calendar navigation by providing a Year overview showing all 12 months in a grid, and a Decade overview showing the current decade in a grid. A lot of code has just been moved around. The overviews use a QML ListModel owing to laziness. See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that mouse click effect!) Diffs - src/declarativeimports/calendar/calendar.h 5dc3081 src/declarativeimports/calendar/calendar.cpp c462dbd src/declarativeimports/calendar/daydata.h 39ac086 src/declarativeimports/calendar/daysmodel.h e1285f6 src/declarativeimports/calendar/daysmodel.cpp 1a6f454 src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e src/declarativeimports/calendar/qml/DaysCalendar.qml ab3e750 src/declarativeimports/calendar/qml/MonthView.qml 601755f Diff: https://git.reviewboard.kde.org/r/122488/diff/ Testing --- I changed the selection to be persistent during navigation; other than that, should work as before, with the new overviews. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124415: Don't crash when OSD QML file is invalid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124415/#review82787 --- Ship it! shell/osd.cpp (lines 146 - 148) https://git.reviewboard.kde.org/r/124415/#comment57101 I think it might be useful to have a qWarning here too? You may miss it in the plasma startup output but then when actually triggering the osd it would print again (and again) so you'd actually get some feedback while testing the osd. - Martin Klapetek On July 21, 2015, 10:39 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124415/ --- (Updated July 21, 2015, 10:39 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Added a syntax error to my osd.qml, Plasma would no longer crash, neither on startup, nor when the OSD should be shown. Diffs - shell/osd.cpp 3e8bd70 Diff: https://git.reviewboard.kde.org/r/124415/diff/ Testing --- Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124408: Make PlasmaCore.Dialog opacity work
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124408/ --- (Updated July 21, 2015, 8:29 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 80940951e0700bf918c0342bdba56577a6f78d29 by Kai Uwe Broulik to branch master. Repository: plasma-framework Description --- Dialog inherits from QQuickWindow which inherits from QWindow which has an opacity property. Unfortunately, opacity has a REVISION 1 attached to it but there doesn't seem to be a way to tell it hey, inherit Foo but please revision 1 so it says opacity is not available in plasma.core 2.0. qmlRegisterType() which you can usually use to register internal stuff doesn't have a second template parameter... Diffs - src/declarativeimports/core/corebindingsplugin.cpp 7aaba35 Diff: https://git.reviewboard.kde.org/r/124408/diff/ Testing --- I can now adjust dialog opacity. Is there anybody that thoroughly understands the QML versioning stuff? Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On July 21, 2015, 1:36 a.m., Aleix Pol Gonzalez wrote: lookandfeel/contents/osd/Osd.qml, line 48 https://git.reviewboard.kde.org/r/124409/diff/1/?file=386441#file386441line48 This looks like a random wait time... Looking at the video, it seems like a slow animation. Is it intended? Yes. The idea is show and immediately start fading out which is perceived as it's hiding already (as opposed to showing for 2 seconds and doing nothing) but it's hiding slow enough to register the values/read the text. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82738 --- On July 20, 2015, 10:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 10:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On Juli 21, 2015, 7:03 vorm., Heiko Tietze wrote: Nice presentation, as always. But I'm not so sure that the realization of fading out quickly meets the needs from 'OSD is disturbing'. The second when the OSD is shown is still annoying (interaction during the fading might restart) and those who want to 'read' it need to reactivate the OSD. The issue could be solved by some kind of 'dismiss' or 'don't show again' interaction. Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues, a dialog (KCM) could help. And last but least please consider to bind this feature to activities. Martin Gräßlin wrote: Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues For technical reasons the OSD is not able to recognize any (global) key or mouse click events on Wayland and on X11 only with a huge amount of nasty code. Also I don't think that this is a solution to the annoying - if I watch a video and change the volume through kdeconnect I don't have a keyboard. Anyway I would dismiss the annoying argument all together. If I compare to the amount of OSDs my TV, audio receiver is putting on the screen this is a really good OSD. Martin Klapetek wrote: The second when the OSD is shown is still annoying and those who want to 'read' it need to reactivate the OSD I'm confused by that - does that say that the second it is on display is too much (annoying) but not enough to read it? Can you perhaps file a bug and specify exactly what is annoying and we can discuss over there? I tried to point out that we have two goals here: read information and don't disturb. In case of volume the feedback as position on the slider (or kind of progress bar) is perceived in milliseconds but when you got an email you might want to read sender and subject. And if the user is elder it might take more time to grasp what happens. - Heiko --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82745 --- On Juli 20, 2015, 8:19 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated Juli 20, 2015, 8:19 nachm.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On July 21, 2015, 8:28 a.m., Martin Gräßlin wrote: This needs quite a bit of testing in real world: how does it behave with changing content underneath (e.g. a video, scrolling web browser), heavy load on the system, heavy load on the compositor, etc. Looks like the upcoming beta is a good candidate for that? ;) - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82743 --- On July 20, 2015, 10:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 10:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On July 21, 2015, 9:03 a.m., Heiko Tietze wrote: Nice presentation, as always. But I'm not so sure that the realization of fading out quickly meets the needs from 'OSD is disturbing'. The second when the OSD is shown is still annoying (interaction during the fading might restart) and those who want to 'read' it need to reactivate the OSD. The issue could be solved by some kind of 'dismiss' or 'don't show again' interaction. Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues, a dialog (KCM) could help. And last but least please consider to bind this feature to activities. Martin Gräßlin wrote: Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues For technical reasons the OSD is not able to recognize any (global) key or mouse click events on Wayland and on X11 only with a huge amount of nasty code. Also I don't think that this is a solution to the annoying - if I watch a video and change the volume through kdeconnect I don't have a keyboard. Anyway I would dismiss the annoying argument all together. If I compare to the amount of OSDs my TV, audio receiver is putting on the screen this is a really good OSD. Martin Klapetek wrote: The second when the OSD is shown is still annoying and those who want to 'read' it need to reactivate the OSD I'm confused by that - does that say that the second it is on display is too much (annoying) but not enough to read it? Can you perhaps file a bug and specify exactly what is annoying and we can discuss over there? Heiko Tietze wrote: I tried to point out that we have two goals here: read information and don't disturb. In case of volume the feedback as position on the slider (or kind of progress bar) is perceived in milliseconds but when you got an email you might want to read sender and subject. And if the user is elder it might take more time to grasp what happens. Ah, you're getting confused OSD with notifications. This does not apply to notifications at all, this is only the volume/brigthness/etc changes. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82745 --- On July 20, 2015, 10:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 10:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On July 21, 2015, 9:03 a.m., Heiko Tietze wrote: Nice presentation, as always. But I'm not so sure that the realization of fading out quickly meets the needs from 'OSD is disturbing'. The second when the OSD is shown is still annoying (interaction during the fading might restart) and those who want to 'read' it need to reactivate the OSD. The issue could be solved by some kind of 'dismiss' or 'don't show again' interaction. Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues, a dialog (KCM) could help. And last but least please consider to bind this feature to activities. Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues For technical reasons the OSD is not able to recognize any (global) key or mouse click events on Wayland and on X11 only with a huge amount of nasty code. Also I don't think that this is a solution to the annoying - if I watch a video and change the volume through kdeconnect I don't have a keyboard. Anyway I would dismiss the annoying argument all together. If I compare to the amount of OSDs my TV, audio receiver is putting on the screen this is a really good OSD. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82745 --- On July 20, 2015, 10:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 10:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124347: Update desktopthemedetails kcm docbook to Plasma 5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124347/ --- (Updated July 21, 2015, 10:14 a.m.) Status -- This change has been marked as submitted. Review request for Documentation and Plasma. Changes --- Submitted with commit e14a0e6a80b4c9b8f0f129d411a2aefd8dcce73b by Burkhard Lück to branch master. Repository: plasma-desktop Description --- Updated docbook content and screenshot Diffs - doc/kcontrol/desktopthemedetails/clicking-apply.png f57723b doc/kcontrol/desktopthemedetails/customizing.png a16743f doc/kcontrol/desktopthemedetails/index.docbook 19882ed Diff: https://git.reviewboard.kde.org/r/124347/diff/ Testing --- builds File Attachments customizing.png https://git.reviewboard.kde.org/media/uploaded/files/2015/07/14/7f27c9f4-d283-4437-a52d-595f684fd68e__customizing.png Thanks, Burkhard Lück ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124351: Update kwindecoration kcm docbook to Plama 5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124351/ --- (Updated July 21, 2015, 9:57 a.m.) Status -- This change has been marked as submitted. Review request for Documentation, Plasma and Martin Gräßlin. Changes --- Submitted with commit 7aebca746130a77b1594eb1d8f9e299936b6ba36 by Burkhard Lück to branch master. Repository: kwin Description --- see summary Diffs - doc/kwindecoration/buttons.png 1c4fdf7 doc/kwindecoration/decoration.png 9fc84e5 doc/kwindecoration/index.docbook 58ae826 doc/kwindecoration/main.png 1946aa3 Diff: https://git.reviewboard.kde.org/r/124351/diff/ Testing --- builds Thanks, Burkhard Lück ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124352: Update kwinsceenedges to Plasma 5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124352/ --- (Updated July 21, 2015, 10:02 a.m.) Status -- This change has been marked as submitted. Review request for Documentation, Plasma and Martin Gräßlin. Changes --- Submitted with commit 4730812df89312f123f8506c480418ab883bec2c by Burkhard Lück to branch master. Repository: kwin Description --- Question: Do I need to enable the compositor to get that working? Diffs - doc/kwinscreenedges/index.docbook 671d60c Diff: https://git.reviewboard.kde.org/r/124352/diff/ Testing --- builds Thanks, Burkhard Lück ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On July 21, 2015, 9:03 a.m., Heiko Tietze wrote: Nice presentation, as always. But I'm not so sure that the realization of fading out quickly meets the needs from 'OSD is disturbing'. The second when the OSD is shown is still annoying (interaction during the fading might restart) and those who want to 'read' it need to reactivate the OSD. The issue could be solved by some kind of 'dismiss' or 'don't show again' interaction. Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues, a dialog (KCM) could help. And last but least please consider to bind this feature to activities. Martin Gräßlin wrote: Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues For technical reasons the OSD is not able to recognize any (global) key or mouse click events on Wayland and on X11 only with a huge amount of nasty code. Also I don't think that this is a solution to the annoying - if I watch a video and change the volume through kdeconnect I don't have a keyboard. Anyway I would dismiss the annoying argument all together. If I compare to the amount of OSDs my TV, audio receiver is putting on the screen this is a really good OSD. The second when the OSD is shown is still annoying and those who want to 'read' it need to reactivate the OSD I'm confused by that - does that say that the second it is on display is too much (annoying) but not enough to read it? Can you perhaps file a bug and specify exactly what is annoying and we can discuss over there? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82745 --- On July 20, 2015, 10:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 10:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On Juli 21, 2015, 8:46 vorm., Mark Gaiser wrote: lookandfeel/contents/osd/Osd.qml, line 44 https://git.reviewboard.kde.org/r/124409/diff/1/?file=386441#file386441line44 http://doc.qt.io/qt-5/qml-qtquick-opacityanimator.html perhaps? Animators only work within the SceneGraph. For a Window there's no way that could work. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82755 --- On Juli 20, 2015, 8:19 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated Juli 20, 2015, 8:19 nachm.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124408: Make PlasmaCore.Dialog opacity work
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124408/#review82754 --- +1 - Martin Klapetek On July 20, 2015, 9:40 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124408/ --- (Updated July 20, 2015, 9:40 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Dialog inherits from QQuickWindow which inherits from QWindow which has an opacity property. Unfortunately, opacity has a REVISION 1 attached to it but there doesn't seem to be a way to tell it hey, inherit Foo but please revision 1 so it says opacity is not available in plasma.core 2.0. qmlRegisterType() which you can usually use to register internal stuff doesn't have a second template parameter... Diffs - src/declarativeimports/core/corebindingsplugin.cpp 7aaba35 Diff: https://git.reviewboard.kde.org/r/124408/diff/ Testing --- I can now adjust dialog opacity. Is there anybody that thoroughly understands the QML versioning stuff? Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124374: custom inline edit menu for plasma controls
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124374/ --- (Updated July 21, 2015, 9:35 a.m.) Review request for Plasma. Repository: plasma-framework Description --- This depends from https://codereview.qt-project.org/#/c/121659/ provides the needed elements for touch based text selection and inline (no separate window) menu for cut/copy/paste Diffs (updated) - src/declarativeimports/plasmastyle/CursorHandleStyle.qml PRE-CREATION src/declarativeimports/plasmastyle/EditMenuTouch.qml PRE-CREATION src/declarativeimports/plasmastyle/SelectionHandleStyle.qml PRE-CREATION src/declarativeimports/plasmastyle/TextAreaStyle.qml 114c322 src/declarativeimports/plasmastyle/TextFieldStyle.qml 635c938 Diff: https://git.reviewboard.kde.org/r/124374/diff/ Testing --- File Attachments snapshot1.png https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82755 --- lookandfeel/contents/osd/Osd.qml (line 44) https://git.reviewboard.kde.org/r/124409/#comment57067 http://doc.qt.io/qt-5/qml-qtquick-opacityanimator.html perhaps? - Mark Gaiser On jul 20, 2015, 8:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated jul 20, 2015, 8:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On Juli 21, 2015, 7:03 vorm., Heiko Tietze wrote: Nice presentation, as always. But I'm not so sure that the realization of fading out quickly meets the needs from 'OSD is disturbing'. The second when the OSD is shown is still annoying (interaction during the fading might restart) and those who want to 'read' it need to reactivate the OSD. The issue could be solved by some kind of 'dismiss' or 'don't show again' interaction. Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues, a dialog (KCM) could help. And last but least please consider to bind this feature to activities. Martin Gräßlin wrote: Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues For technical reasons the OSD is not able to recognize any (global) key or mouse click events on Wayland and on X11 only with a huge amount of nasty code. Also I don't think that this is a solution to the annoying - if I watch a video and change the volume through kdeconnect I don't have a keyboard. Anyway I would dismiss the annoying argument all together. If I compare to the amount of OSDs my TV, audio receiver is putting on the screen this is a really good OSD. Martin Klapetek wrote: The second when the OSD is shown is still annoying and those who want to 'read' it need to reactivate the OSD I'm confused by that - does that say that the second it is on display is too much (annoying) but not enough to read it? Can you perhaps file a bug and specify exactly what is annoying and we can discuss over there? Heiko Tietze wrote: I tried to point out that we have two goals here: read information and don't disturb. In case of volume the feedback as position on the slider (or kind of progress bar) is perceived in milliseconds but when you got an email you might want to read sender and subject. And if the user is elder it might take more time to grasp what happens. Martin Klapetek wrote: Ah, you're getting confused OSD with notifications. This does not apply to notifications at all, this is only the volume/brigthness/etc changes. If you limit the scope to very simple notification the solution might be okay (personally I fully agree with the faster the better). But didn't Martin Graesslin blog about what kind of OSD should be shown on the lock screen including the idea of email like on Android? What's about the information of time left watching a video, perhaps after you forward a few seconds via KDEConnect? - Heiko --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82745 --- On Juli 20, 2015, 8:19 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated Juli 20, 2015, 8:19 nachm.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On July 21, 2015, 9:03 a.m., Heiko Tietze wrote: Nice presentation, as always. But I'm not so sure that the realization of fading out quickly meets the needs from 'OSD is disturbing'. The second when the OSD is shown is still annoying (interaction during the fading might restart) and those who want to 'read' it need to reactivate the OSD. The issue could be solved by some kind of 'dismiss' or 'don't show again' interaction. Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues, a dialog (KCM) could help. And last but least please consider to bind this feature to activities. Martin Gräßlin wrote: Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues For technical reasons the OSD is not able to recognize any (global) key or mouse click events on Wayland and on X11 only with a huge amount of nasty code. Also I don't think that this is a solution to the annoying - if I watch a video and change the volume through kdeconnect I don't have a keyboard. Anyway I would dismiss the annoying argument all together. If I compare to the amount of OSDs my TV, audio receiver is putting on the screen this is a really good OSD. Martin Klapetek wrote: The second when the OSD is shown is still annoying and those who want to 'read' it need to reactivate the OSD I'm confused by that - does that say that the second it is on display is too much (annoying) but not enough to read it? Can you perhaps file a bug and specify exactly what is annoying and we can discuss over there? Heiko Tietze wrote: I tried to point out that we have two goals here: read information and don't disturb. In case of volume the feedback as position on the slider (or kind of progress bar) is perceived in milliseconds but when you got an email you might want to read sender and subject. And if the user is elder it might take more time to grasp what happens. Martin Klapetek wrote: Ah, you're getting confused OSD with notifications. This does not apply to notifications at all, this is only the volume/brigthness/etc changes. Heiko Tietze wrote: If you limit the scope to very simple notification the solution might be okay (personally I fully agree with the faster the better). But didn't Martin Graesslin blog about what kind of OSD should be shown on the lock screen including the idea of email like on Android? What's about the information of time left watching a video, perhaps after you forward a few seconds via KDEConnect? This is not about lock screen. Email notification on a lock screen needs a completely different solution than OSD. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82745 --- On July 20, 2015, 10:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 10:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On July 21, 2015, 9:03 a.m., Heiko Tietze wrote: Nice presentation, as always. But I'm not so sure that the realization of fading out quickly meets the needs from 'OSD is disturbing'. The second when the OSD is shown is still annoying (interaction during the fading might restart) and those who want to 'read' it need to reactivate the OSD. The issue could be solved by some kind of 'dismiss' or 'don't show again' interaction. Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues, a dialog (KCM) could help. And last but least please consider to bind this feature to activities. Martin Gräßlin wrote: Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues For technical reasons the OSD is not able to recognize any (global) key or mouse click events on Wayland and on X11 only with a huge amount of nasty code. Also I don't think that this is a solution to the annoying - if I watch a video and change the volume through kdeconnect I don't have a keyboard. Anyway I would dismiss the annoying argument all together. If I compare to the amount of OSDs my TV, audio receiver is putting on the screen this is a really good OSD. Martin Klapetek wrote: The second when the OSD is shown is still annoying and those who want to 'read' it need to reactivate the OSD I'm confused by that - does that say that the second it is on display is too much (annoying) but not enough to read it? Can you perhaps file a bug and specify exactly what is annoying and we can discuss over there? Heiko Tietze wrote: I tried to point out that we have two goals here: read information and don't disturb. In case of volume the feedback as position on the slider (or kind of progress bar) is perceived in milliseconds but when you got an email you might want to read sender and subject. And if the user is elder it might take more time to grasp what happens. Martin Klapetek wrote: Ah, you're getting confused OSD with notifications. This does not apply to notifications at all, this is only the volume/brigthness/etc changes. Heiko Tietze wrote: If you limit the scope to very simple notification the solution might be okay (personally I fully agree with the faster the better). But didn't Martin Graesslin blog about what kind of OSD should be shown on the lock screen including the idea of email like on Android? What's about the information of time left watching a video, perhaps after you forward a few seconds via KDEConnect? Martin Gräßlin wrote: This is not about lock screen. Email notification on a lock screen needs a completely different solution than OSD. The OSD currently does four things and four things only - it shows up on volume change, screen brigthness change, keyboard brightness change and keyboard layout change. Everything else is a notification, which is the small bubble in bottom-left part of the screen and is different in every possible aspect than the OSD, which is what this patch adjusts. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82745 --- On July 20, 2015, 10:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 10:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124408: Make PlasmaCore.Dialog opacity work
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124408/#review82759 --- Ship it! Ship It! - Marco Martin On July 20, 2015, 7:40 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124408/ --- (Updated July 20, 2015, 7:40 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Dialog inherits from QQuickWindow which inherits from QWindow which has an opacity property. Unfortunately, opacity has a REVISION 1 attached to it but there doesn't seem to be a way to tell it hey, inherit Foo but please revision 1 so it says opacity is not available in plasma.core 2.0. qmlRegisterType() which you can usually use to register internal stuff doesn't have a second template parameter... Diffs - src/declarativeimports/core/corebindingsplugin.cpp 7aaba35 Diff: https://git.reviewboard.kde.org/r/124408/diff/ Testing --- I can now adjust dialog opacity. Is there anybody that thoroughly understands the QML versioning stuff? Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On Juli 21, 2015, 7:03 vorm., Heiko Tietze wrote: Nice presentation, as always. But I'm not so sure that the realization of fading out quickly meets the needs from 'OSD is disturbing'. The second when the OSD is shown is still annoying (interaction during the fading might restart) and those who want to 'read' it need to reactivate the OSD. The issue could be solved by some kind of 'dismiss' or 'don't show again' interaction. Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues, a dialog (KCM) could help. And last but least please consider to bind this feature to activities. Martin Gräßlin wrote: Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues For technical reasons the OSD is not able to recognize any (global) key or mouse click events on Wayland and on X11 only with a huge amount of nasty code. Also I don't think that this is a solution to the annoying - if I watch a video and change the volume through kdeconnect I don't have a keyboard. Anyway I would dismiss the annoying argument all together. If I compare to the amount of OSDs my TV, audio receiver is putting on the screen this is a really good OSD. Martin Klapetek wrote: The second when the OSD is shown is still annoying and those who want to 'read' it need to reactivate the OSD I'm confused by that - does that say that the second it is on display is too much (annoying) but not enough to read it? Can you perhaps file a bug and specify exactly what is annoying and we can discuss over there? Heiko Tietze wrote: I tried to point out that we have two goals here: read information and don't disturb. In case of volume the feedback as position on the slider (or kind of progress bar) is perceived in milliseconds but when you got an email you might want to read sender and subject. And if the user is elder it might take more time to grasp what happens. Martin Klapetek wrote: Ah, you're getting confused OSD with notifications. This does not apply to notifications at all, this is only the volume/brigthness/etc changes. Heiko Tietze wrote: If you limit the scope to very simple notification the solution might be okay (personally I fully agree with the faster the better). But didn't Martin Graesslin blog about what kind of OSD should be shown on the lock screen including the idea of email like on Android? What's about the information of time left watching a video, perhaps after you forward a few seconds via KDEConnect? Martin Gräßlin wrote: This is not about lock screen. Email notification on a lock screen needs a completely different solution than OSD. Martin Klapetek wrote: The OSD currently does four things and four things only - it shows up on volume change, screen brigthness change, keyboard brightness change and keyboard layout change. Everything else is a notification, which is the small bubble in bottom-left part of the screen and is different in every possible aspect than the OSD, which is what this patch adjusts. Okay, thanks for clarification. - Heiko --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82745 --- On Juli 20, 2015, 8:19 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated Juli 20, 2015, 8:19 nachm.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82751 --- Ship it! ...with my maintainer hat on. I would say let's gather feedback from beta and during akademy and if it's bad, we can revert for the release. - Martin Klapetek On July 20, 2015, 10:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 10:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On Tuesday, July 21, 2015 12:30:34 David Edmundson wrote: On July 21, 2015, 8:07 a.m., Martin Klapetek wrote: ...with my maintainer hat on. I would say let's gather feedback from beta and during akademy and if it's bad, we can revert for the release. +1 to that idea. +another1 -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On July 21, 2015, 8:07 a.m., Martin Klapetek wrote: ...with my maintainer hat on. I would say let's gather feedback from beta and during akademy and if it's bad, we can revert for the release. +1 to that idea. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82751 --- On July 20, 2015, 8:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 8:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
