Plasma Mobile Vision, intended personas meeting notes
PRESENT: Ivan, Sebas, Thomas and Jens MEETING GOAL: write up a vision statement for Plasma Mobile and talk about the early work of the Plasma Mobile HIG and design goals. The vision we ended with, after much debate of different wordings, what should and shouldn't be included in a vision statement was VISION STATEMENT: Plasma Mobile aims to become a complete software system for mobile devices. It is designed to give privacy-aware users back the full-control over their information and communication. Plasma Mobile takes a pragmatic approach and is inclusive to 3rd party software, allowing the user to choose which applications and services to use. It provides a seamless experience across multiple devices. Plasma Mobile implements open standards, and -- unlike Android -- it is developed in a transparent process that is open for the community to participate in. NOTES ON VISION STATEMENT: We wanted the vision statement to reflect not the projects current position but our future goals in full. A system for actual users with a focus on privacy, control of information and your own system and working in the open as a community using open source. We also included information about our pragmatism and how the phone intends to be easily adaptable to different apps from other eco-systems and also our intent to make it a pairing with desktops. PERSONAS: We also talked about future Personas that we want to work towards when creating user stories and scenarios and settled fairly quickly on Berna (the office worker) and Susan (the recreational user). (1) DESIGN NOTES: Further notes of interest during the meeting where a few bullet points concerning future design goals for individual apps which will reach the HIG in the end 1) All applications should be private by default - no sending data in the default configuration, must not phone home 2) Applications should try to include security and control of info. Should be apparent not hidden. This is not an excuse for geeky design. 3) Applications should always aim for integration between devices, for example using kdeconnect FUTURE COMMUNICATION: We also brainstormed on communication taglines for the project that will be narrowed down further as time goes by (and should probably be a case for the KDE Promo team) - centering mostly on user self control over his or her information and communication but also communication ideas concerning pragmatism. Pragmatic to the bone Think Similar This is your phone, no one elses Plasma's Satellite Your phone. Your stuff. Your Plasma Mobile. Plasma Mobile. Yours. Yours For your eyes only. Yours truly. All in all a very productive meeting. - 1) https://techbase.kde.org/Projects/Usability/Principles/KDE4_Personas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma Mobile Vision, intended personas meeting notes
Am Montag, 10. August 2015, 22.00:59 schrieb Jens Reuterberg: Morning visionary people Sounds like productive and good work. Liked to read it and like the overall vision. One thing I'd like to state for change (hopefully in a constructive manner) see below. PRESENT: Ivan, Sebas, Thomas and Jens MEETING GOAL: write up a vision statement for Plasma Mobile and talk about the early work of the Plasma Mobile HIG and design goals. The vision we ended with, after much debate of different wordings, what should and shouldn't be included in a vision statement was VISION STATEMENT: Plasma Mobile aims to become a complete software system for mobile devices. It is designed to give privacy-aware users back the full-control over their information and communication. Plasma Mobile takes a pragmatic approach and is inclusive to 3rd party software, allowing the user to choose which applications and services to use. It provides a seamless experience across multiple devices. Plasma Mobile implements open standards, and -- unlike Android -- it is developed in a transparent process that is open for the community to participate in. I'd definitely scratch -- unlike Android --. I think that's something for the case if somebody asks: But what about Android, isn't it open source. Then you can describe it. But not in a vision statement. Don't refer in there to another competitive product. Plasma Mobile can work and define itself on its own. You don't need to differentiate from others like this. Be self-confident. [snip] Nothing to add to the rest. Looking forward to see Plasma Mobile prosper. Thanks Mario ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma Mobile Vision, intended personas meeting notes
Thanks for writing that up, Jens! I agree that it was very productive indeed. These are all just our initial version of things, of course. Nothing is set in stone. This is a vision for the whole team, which can only effective if the whole team can identify with it. So please, comment away, suggestions welcome! Great vision, I'd keep exactly the way it is! would be fine, too, so we know people have read it and agree with it Once the discussion slows down and it appears we have come to an agreement, we'll officially publish it with all the bells and whistles it deserves. Looking forward to your thoughts, Thomas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma Mobile Vision, intended personas meeting notes
First thank you very much for summarising the hangout for all of us! Second are we going to use doodle next time as well for getting a hangout planned? On Mon, Aug 10, 2015 at 5:53 PM, Mario Fux kde...@unormal.org wrote: Am Montag, 10. August 2015, 22.00:59 schrieb Jens Reuterberg: Morning visionary people Sounds like productive and good work. Liked to read it and like the overall vision. One thing I'd like to state for change (hopefully in a constructive manner) see below. PRESENT: Ivan, Sebas, Thomas and Jens MEETING GOAL: write up a vision statement for Plasma Mobile and talk about the early work of the Plasma Mobile HIG and design goals. The vision we ended with, after much debate of different wordings, what should and shouldn't be included in a vision statement was VISION STATEMENT: Plasma Mobile aims to become a complete software system for mobile devices. It is designed to give privacy-aware users back the full-control over their information and communication. Plasma Mobile takes a pragmatic approach and is inclusive to 3rd party software, allowing the user to choose which applications and services to use. It provides a seamless experience across multiple devices. Plasma Mobile implements open standards, and -- unlike Android -- it is developed in a transparent process that is open for the community to participate in. I'd definitely scratch -- unlike Android --. I think that's something for the case if somebody asks: But what about Android, isn't it open source. Then you can describe it. But not in a vision statement. Don't refer in there to another competitive product. Plasma Mobile can work and define itself on its own. You don't need to differentiate from others like this. Be self-confident. [snip] Nothing to add to the rest. Looking forward to see Plasma Mobile prosper. Thanks Mario ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma Mobile Vision, intended personas meeting notes
Great work guys! I love the part about privacy and I can identify with the rest of the vision. Some minor things: It provides a seamless experience across multiple devices. I guess your primarily mean devices running other Plasma Experiences (Desktop / PMC / whatever the future brings) Or do you want to explicitly include more? Also the wording is not perfect. It sound like plasma mobile will be on multiple devices that provide a seamless experience when used together. Plasma Mobile implements open standards, and -- unlike Android -- it is developed in a transparent process that is open for the community to participate in. I am undecided on the unlike Android part. Could you share your reasoning for including it? PERSONAS: We also talked about future Personas that we want to work towards when creating user stories and scenarios and settled fairly quickly on Berna (the office worker) and Susan (the recreational user). Great choice. If it works for them it works for most. Cheers Michael ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124692: Add new entities for sebas and plasma-pa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124692/ --- Review request for Plasma and Luigi Toscano. Repository: kdoctools Description --- Add an entity fo me (sebas) and for plasma-pa. Diffs - src/customization/en/user.entities 6eaf9dc56af1e81bc6e2ee9b1f03e4100dfbae24 src/customization/entities/contributor.entities 3fafc4ad3a7903b00abee9468c691f36e19313fa Diff: https://git.reviewboard.kde.org/r/124692/diff/ Testing --- builds and is able to build my plasma-pa docbook. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context
On Aug. 10, 2015, 7:02 a.m., Martin Gräßlin wrote: Could you add a call to QCoreApplication::setAttribute(Qt::AA_ForceRasterWidgets); before showing the warning message - just to be sure that it doesn't try creating another GL context and dies on it. on it, thanks - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124576/#review83634 --- On Aug. 1, 2015, 12:08 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124576/ --- (Updated Aug. 1, 2015, 12:08 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Show a dialog if Plasma failed to create an OpenGL Context. remove that shutup option we had, it was a workaround for an issue with Qt5.1 spewing warnings constantly. Diffs - shell/main.cpp cec4a69c6276de61d776f323fb4b5cebe73f4c3f Diff: https://git.reviewboard.kde.org/r/124576/diff/ Testing --- Normal plasma is the same as before. I don't know how to break my openGL, but placing a random qFatal() with the same error message got my dialog perfectly. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124589: Add Disk Quota Plasmoid
On Aug. 6, 2015, 2:12 p.m., Lamarque Souza wrote: applets/diskquota/plugin/DiskQuota.cpp, line 158 https://git.reviewboard.kde.org/r/124589/diff/5/?file=389660#file389660line158 You should search for quota and filelight programs during startup only. You can send a notification if they are not found so the user knows they are not installed. Polling filesystem every two minutes is not extreme bad but it should be prevented if it is not really necessary. David Edmundson wrote: Can you think of a way we can tell if it's installed later? Lamarque Souza wrote: The plasmoid will search for them at every logon. Why is that not enough? You can also connect a slot to org.freedesktop.ScreenSaver.ActiveChanged(false) signal from ksmserver to check for them when the user unlocks the screen. The point is that current code searches for them even when they were detected two minutes before. That's overkill. If the intention is to be over precautions then I step down here. I still insist in sending a notification to warn the user if the programs are not installed. Dominik Haumann wrote: Ok, I would like to implement the following solution: - In the constructor, I check only once if quota exists. If it exists, all is good, and the applet runs as before. - In the constructor, if 'quota' does not exist, I will _not_ launch the timer and instead add a button with the text i18n(Check Again) under the text displayed of this: http://kate-editor.org/wp-content/uploads/2015/08/diskquota-missing.png - Clicking this button would look for 'quota' again, and on success starts the timer and the applet runs as before. Would you accept this solution? Kai Uwe Broulik wrote: What about checking when you open the plasmoid? I think the solution with the button is fine. Elegant, and exactly there where you'd expect it. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/#review83498 --- On Aug. 3, 2015, 5:34 p.m., Dominik Haumann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/ --- (Updated Aug. 3, 2015, 5:34 p.m.) Review request for Plasma, Kai Uwe Broulik and Sebastian Kügler. Repository: kdeplasma-addons Description --- The disk quota is usually used in enterprise installations where network shares are mounted locally. Typically, sysadmins want to avoid that users copy lots of data into their folders, and therefor set quotas (the quota limit has nothing to do with the physical size of a partition). Typically, once a user gets over the hard limit of the quota, the account is blocked and the user cannot login anymore. This happens from time to time, since the users are not really aware of the current quota limit and the already used disk space. Here is where the Disk Quota plasmoid helps: It continusouly monitors the disk quota and warns the quota apprpriately. A detailed description including screenshots can be found in this blog: http://kate-editor.org/?p=3591 (I had a KDE4 hack of this plasmoid running at university, and it proved very usable over the years, so it is probably a good idea to have it by default in plasma) Issues: - the panel icon is larger than the others (some wrong margin?) - an icon for the metadata.desktop is missing (the shipped quota.svg file is not available here, it seems). - the grid units probably need some more tuning Diffs - applets/CMakeLists.txt c60c350 applets/diskquota/CMakeLists.txt PRE-CREATION applets/diskquota/Messages.sh PRE-CREATION applets/diskquota/icons/quota.svg PRE-CREATION applets/diskquota/package/contents/ui/ListDelegateItem.qml PRE-CREATION applets/diskquota/package/contents/ui/main.qml PRE-CREATION applets/diskquota/package/metadata.desktop PRE-CREATION applets/diskquota/plugin/DiskQuota.h PRE-CREATION applets/diskquota/plugin/DiskQuota.cpp PRE-CREATION applets/diskquota/plugin/QuotaItem.h PRE-CREATION applets/diskquota/plugin/QuotaItem.cpp PRE-CREATION applets/diskquota/plugin/QuotaListModel.h PRE-CREATION applets/diskquota/plugin/QuotaListModel.cpp PRE-CREATION applets/diskquota/plugin/plugin.h PRE-CREATION applets/diskquota/plugin/plugin.cpp PRE-CREATION applets/diskquota/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124589/diff/ Testing --- Tested combinations: - no quota installed: A nice message is displayed telling the user that 'quota' is missing. - quota installed, but no quota restrictions set: The applet says No
Re: Review Request 124684: Cmake fail to parse proper taglib version - kdelibs4support
On Aug. 10, 2015, 9:44 a.m., Luca Beltrame wrote: As kdelibs4support is part of KDE Frameworks 5, this RR should point to the kdeframeworks group rather than Plasma. Ok fixed, thank you - Luca --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124684/#review83646 --- On Aug. 10, 2015, 9:39 a.m., Luca Sartorelli wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124684/ --- (Updated Aug. 10, 2015, 9:39 a.m.) Review request for Plasma. Repository: kdelibs4support Description --- Wrong string comparison of taglib version Diffs - cmake/modules/FindTaglib.cmake 5bbb8ee Diff: https://git.reviewboard.kde.org/r/124684/diff/ Testing --- Run cmake with kdesrc-build on debian strecth taglib version correctly found and parsed Thanks, Luca Sartorelli ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124682: Cmake fail to parse proper taglib version - extra-cmake-modules
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124682/ --- Review request for Plasma. Repository: extra-cmake-modules Description --- Wrong string compare of taglib version Diffs - attic/modules/FindTaglib.cmake 5bbb8ee Diff: https://git.reviewboard.kde.org/r/124682/diff/ Testing --- Run cmake with kdesrc-build on debian strecth taglib version correctly found and parsed Thanks, Luca Sartorelli ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124684: Cmake fail to parse proper taglib version - kdelibs4support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124684/ --- Review request for Plasma. Repository: kdelibs4support Description --- Wrong string comparison of taglib version Diffs - cmake/modules/FindTaglib.cmake 5bbb8ee Diff: https://git.reviewboard.kde.org/r/124684/diff/ Testing --- Run cmake with kdesrc-build on debian strecth taglib version correctly found and parsed Thanks, Luca Sartorelli ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124684: Cmake fail to parse proper taglib version - kdelibs4support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124684/#review83646 --- As kdelibs4support is part of KDE Frameworks 5, this RR should point to the kdeframeworks group rather than Plasma. - Luca Beltrame On Ago. 10, 2015, 9:39 a.m., Luca Sartorelli wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124684/ --- (Updated Ago. 10, 2015, 9:39 a.m.) Review request for Plasma. Repository: kdelibs4support Description --- Wrong string comparison of taglib version Diffs - cmake/modules/FindTaglib.cmake 5bbb8ee Diff: https://git.reviewboard.kde.org/r/124684/diff/ Testing --- Run cmake with kdesrc-build on debian strecth taglib version correctly found and parsed Thanks, Luca Sartorelli ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124682: Cmake fail to parse proper taglib version - extra-cmake-modules
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124682/ --- (Updated Aug. 10, 2015, 9:39 a.m.) Review request for Plasma. Repository: extra-cmake-modules Description (updated) --- Wrong string comparison of taglib version Diffs - attic/modules/FindTaglib.cmake 5bbb8ee Diff: https://git.reviewboard.kde.org/r/124682/diff/ Testing --- Run cmake with kdesrc-build on debian strecth taglib version correctly found and parsed Thanks, Luca Sartorelli ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124576/#review83634 --- Could you add a call to QCoreApplication::setAttribute(Qt::AA_ForceRasterWidgets); before showing the warning message - just to be sure that it doesn't try creating another GL context and dies on it. - Martin Gräßlin On Aug. 1, 2015, 2:08 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124576/ --- (Updated Aug. 1, 2015, 2:08 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Show a dialog if Plasma failed to create an OpenGL Context. remove that shutup option we had, it was a workaround for an issue with Qt5.1 spewing warnings constantly. Diffs - shell/main.cpp cec4a69c6276de61d776f323fb4b5cebe73f4c3f Diff: https://git.reviewboard.kde.org/r/124576/diff/ Testing --- Normal plasma is the same as before. I don't know how to break my openGL, but placing a random qFatal() with the same error message got my dialog perfectly. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124589: Add Disk Quota Plasmoid
On Aug. 6, 2015, 2:12 p.m., Lamarque Souza wrote: applets/diskquota/plugin/DiskQuota.cpp, line 158 https://git.reviewboard.kde.org/r/124589/diff/5/?file=389660#file389660line158 You should search for quota and filelight programs during startup only. You can send a notification if they are not found so the user knows they are not installed. Polling filesystem every two minutes is not extreme bad but it should be prevented if it is not really necessary. David Edmundson wrote: Can you think of a way we can tell if it's installed later? Lamarque Souza wrote: The plasmoid will search for them at every logon. Why is that not enough? You can also connect a slot to org.freedesktop.ScreenSaver.ActiveChanged(false) signal from ksmserver to check for them when the user unlocks the screen. The point is that current code searches for them even when they were detected two minutes before. That's overkill. If the intention is to be over precautions then I step down here. I still insist in sending a notification to warn the user if the programs are not installed. Dominik Haumann wrote: Ok, I would like to implement the following solution: - In the constructor, I check only once if quota exists. If it exists, all is good, and the applet runs as before. - In the constructor, if 'quota' does not exist, I will _not_ launch the timer and instead add a button with the text i18n(Check Again) under the text displayed of this: http://kate-editor.org/wp-content/uploads/2015/08/diskquota-missing.png - Clicking this button would look for 'quota' again, and on success starts the timer and the applet runs as before. Would you accept this solution? Kai Uwe Broulik wrote: What about checking when you open the plasmoid? Sebastian Kügler wrote: I think the solution with the button is fine. Elegant, and exactly there where you'd expect it. I like Kai's suggestion: if the programs were not found yet then search for then when user clicks on system tray icon. That is more automatic then using a button. - Lamarque --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/#review83498 --- On Aug. 3, 2015, 5:34 p.m., Dominik Haumann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/ --- (Updated Aug. 3, 2015, 5:34 p.m.) Review request for Plasma, Kai Uwe Broulik and Sebastian Kügler. Repository: kdeplasma-addons Description --- The disk quota is usually used in enterprise installations where network shares are mounted locally. Typically, sysadmins want to avoid that users copy lots of data into their folders, and therefor set quotas (the quota limit has nothing to do with the physical size of a partition). Typically, once a user gets over the hard limit of the quota, the account is blocked and the user cannot login anymore. This happens from time to time, since the users are not really aware of the current quota limit and the already used disk space. Here is where the Disk Quota plasmoid helps: It continusouly monitors the disk quota and warns the quota apprpriately. A detailed description including screenshots can be found in this blog: http://kate-editor.org/?p=3591 (I had a KDE4 hack of this plasmoid running at university, and it proved very usable over the years, so it is probably a good idea to have it by default in plasma) Issues: - the panel icon is larger than the others (some wrong margin?) - an icon for the metadata.desktop is missing (the shipped quota.svg file is not available here, it seems). - the grid units probably need some more tuning Diffs - applets/CMakeLists.txt c60c350 applets/diskquota/CMakeLists.txt PRE-CREATION applets/diskquota/Messages.sh PRE-CREATION applets/diskquota/icons/quota.svg PRE-CREATION applets/diskquota/package/contents/ui/ListDelegateItem.qml PRE-CREATION applets/diskquota/package/contents/ui/main.qml PRE-CREATION applets/diskquota/package/metadata.desktop PRE-CREATION applets/diskquota/plugin/DiskQuota.h PRE-CREATION applets/diskquota/plugin/DiskQuota.cpp PRE-CREATION applets/diskquota/plugin/QuotaItem.h PRE-CREATION applets/diskquota/plugin/QuotaItem.cpp PRE-CREATION applets/diskquota/plugin/QuotaListModel.h PRE-CREATION applets/diskquota/plugin/QuotaListModel.cpp PRE-CREATION applets/diskquota/plugin/plugin.h PRE-CREATION applets/diskquota/plugin/plugin.cpp PRE-CREATION applets/diskquota/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124589/diff/ Testing
Minutes Monday Plasma Hangout
Present: Bhushan, Jens, Jonathan, Martin G, Michael Bohlender, Ovidiu, starbuck, sebas Date: 10 August, 2015, 12:00 CEST Bhushan: - Worked on getting Plasma Mobile to work on MultiRom https://community.kde.org/Plasma/Mobile/MultiROM - patch to TWRP https://github.com/Tasssadar/Team-Win-Recovery-Project/pull/16/ Jens - started working in HIG, but needs vision first - went to GUADEC - new design of plasma-mobile.org landed Jonathan - rolled 5.4 beta tarballs - worked on announcement https://www.kde.org/announcements/plasma-5.3.95.php - will announce new mobile images on plasma list Martin G: - kwin QPA to become a high priority - Looked into modesettings (triggered by LWN article) - would like to require Linux 4.2 from Plasma 5.6 for DRM Michael Bohlender: - Has been working on Kmail Touch over the summer as GSoC - Will go to Randa and discuss more with Jens et al. there Ovidiu: - worked with apol on the SDK - has kdevelop working inside docker container - needs more work, but showing progress starbuck: - tested KCI this weekend - some issues related to lockscreen, etc., but doesn't seem directly plasma- related - will re-test next KCI update this week Sebastian: - Fixed i18n and hidpi in plasma-pa, will address more feedback if necessary - meeting about Plasma Mobile vision planning - closed active mailinglist - ran Plasma Mobile meeting (notes onthe plasma list) - redirecting Plasma Active pages - to set up TODO board in Phabricator - Looked into a few plasma mobile bugs -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124469: ConsoleKit2 support for screenlocker
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124469/
---
(Updated Aug. 10, 2015, 1:59 p.m.)
Review request for Plasma.
Changes
---
Moved the variable intialization to the class constructor where it belongs.
Rebased the diff on HEAD.
Repository: plasma-workspace
Description
---
ConsoleKit2 has the same API as systemd-logind for Lock, Unlock,
PrepareForSleep, and Inhibit. This patch adds the functionality
for ConsoleKit2 while attempting to minimize code duplication.
Diffs (updated)
-
ksmserver/screenlocker/logind.h 9983673
ksmserver/screenlocker/logind.cpp 5335b15
Diff: https://git.reviewboard.kde.org/r/124469/diff/
Testing
---
dbus-send --system --dest=org.freedesktop.ConsoleKit --type=method_call
--print-reply --reply-timeout=2000 /org/freedesktop/ConsoleKit/Manager
org.freedesktop.ConsoleKit.Manager.ListInhibitors
method return sender=:1.1 - dest=:1.80 reply_serial=2
array [
struct {
string suspend
string NetworkManager
string NetworkManager needs to turn off networks
string delay
uint32 0
uint32 3473
}
struct {
string
handle-power-key:handle-suspend-key:handle-hibernate-key:handle-lid-switch
string PowerDevil
string KDE handles power events
string block
uint32 1000
uint32 9587
}
struct {
string suspend
string Screen Locker
string Ensuring that the screen gets locked before going to sleep
string delay
uint32 1000
uint32 9508
}
]
Verified ConsoleKit2 does delay suspending until both delay locks are removed.
Thanks,
Eric Koegel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124469: ConsoleKit2 support for screenlocker
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124469/#review83659
---
Ship it!
Ship It!
- David Edmundson
On Aug. 10, 2015, 1:59 p.m., Eric Koegel wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124469/
---
(Updated Aug. 10, 2015, 1:59 p.m.)
Review request for Plasma.
Repository: plasma-workspace
Description
---
ConsoleKit2 has the same API as systemd-logind for Lock, Unlock,
PrepareForSleep, and Inhibit. This patch adds the functionality
for ConsoleKit2 while attempting to minimize code duplication.
Diffs
-
ksmserver/screenlocker/logind.h 9983673
ksmserver/screenlocker/logind.cpp 5335b15
Diff: https://git.reviewboard.kde.org/r/124469/diff/
Testing
---
dbus-send --system --dest=org.freedesktop.ConsoleKit --type=method_call
--print-reply --reply-timeout=2000 /org/freedesktop/ConsoleKit/Manager
org.freedesktop.ConsoleKit.Manager.ListInhibitors
method return sender=:1.1 - dest=:1.80 reply_serial=2
array [
struct {
string suspend
string NetworkManager
string NetworkManager needs to turn off networks
string delay
uint32 0
uint32 3473
}
struct {
string
handle-power-key:handle-suspend-key:handle-hibernate-key:handle-lid-switch
string PowerDevil
string KDE handles power events
string block
uint32 1000
uint32 9587
}
struct {
string suspend
string Screen Locker
string Ensuring that the screen gets locked before going to sleep
string delay
uint32 1000
uint32 9508
}
]
Verified ConsoleKit2 does delay suspending until both delay locks are removed.
Thanks,
Eric Koegel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
