Re: Review Request 126268: Move shutdown scripts into ksmserver cleanup

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126268/#review89204
---


explanation sounds reasonable to me

- Martin Gräßlin


On Dec. 7, 2015, 1:26 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126268/
> ---
> 
> (Updated Dec. 7, 2015, 1:26 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Shutdown scripts are done by startkde after ksmserver quits. Which never
> happens because we've told systemd to shutdown.
> 
> Old systems worked because they used to communicate with the display
> manager which then closed us before shutting down, this is no longer the
> case.
> 
> This moves handling the shutdown scripts into ksmserver (which already
> handles startup scripts) and runs them before asking logind to shutdown.
> 
> BUG: 356190
> 
> 
> Diffs
> -
> 
>   ksmserver/server.h 1a2f0810c53d508d7d721fb4be1c25f0585c0602 
>   ksmserver/server.cpp 9477e542399ad65f993e581fc4212883f282b70e 
>   startkde/startkde.cmake 41a8975cce1fb2a4e7a034e697ce6e2cc59d5b1e 
>   startkde/startplasma.cmake 8360a636d3f68c957a15158484360a611cfe3ff8 
> 
> Diff: https://git.reviewboard.kde.org/r/126268/diff/
> 
> 
> Testing
> ---
> 
> had a shutdown script to touch a file in my home, worked for shutdown and 
> logout.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

[Martin Gräßlin]

> On Dec. 4, 2015, 7:52 p.m., Martin Klapetek wrote:
> > I just found out that KHolidays is actually not a framework but part of KDE 
> > Applications. Will a dependency like that be ok?

if it is optional and doesn't introduce a dependency loop I think it's fine.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125862/#review89133
---


On Nov. 18, 2015, 1:33 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125862/
> ---
> 
> (Updated Nov. 18, 2015, 1:33 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is very simple for now as there is no configuration
> yet, so it just takes the default region (your locale)
> and shows holidays from that.
> 
> Obviously this needs a config to set up which regions
> you want to show in there, but this is a start.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 4783a78 
>   plasmacalendarintegration/CMakeLists.txt PRE-CREATION 
>   plasmacalendarintegration/HolidaysConfig.qml PRE-CREATION 
>   plasmacalendarintegration/holidayeventsplugin.json PRE-CREATION 
>   plasmacalendarintegration/holidaysevents.h PRE-CREATION 
>   plasmacalendarintegration/holidaysevents.cpp PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/CMakeLists.txt PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.h 
> PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp 
> PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125862/diff/
> 
> 
> Testing
> ---
> 
> Holidays are properly listed in calendar applet.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126234: Fix build with Qt 5.6

[Martin Gräßlin]

> On Dec. 4, 2015, 7:44 p.m., Hrvoje Senjan wrote:
> > Jan, Martin, i guess this can also go to 5.5 branch?

yes, sure.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126234/#review89132
---


On Dec. 4, 2015, 10:23 a.m., Jan Kundrát wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126234/
> ---
> 
> (Updated Dec. 4, 2015, 10:23 a.m.)
> 
> 
> Review request for Plasma, Martin Gräßlin and Hrvoje Senjan.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> Fix build with Qt 5.6
> 
> A recent change [1] led to Qt5PlatformSupport.pc not being installed
> anymore. Pkg-config was only used for finding the paths, and the actual
> include flags and library names were hardcoded in KWin's
> FindQt5PlatformSupport.cmake anyway, so let's just focus on finding
> Qt5Gui, the module which provides this Qt5PlatformSupport library, and
> work from there.
> 
> Thanks to Hrvoje Senjan (shumski) for pointing me towards the upstream
> Gerrit change.
> 
> [1] https://codereview.qt-project.org/140954/
> 
> REVIEW: 126234
> 
> 
> Diffs
> -
> 
>   cmake/modules/FindQt5PlatformSupport.cmake 
> 90a8438ac80e48b09463ba5f34a72b2d7567ea5d 
> 
> Diff: https://git.reviewboard.kde.org/r/126234/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Kundrát
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126268: Move shutdown scripts into ksmserver cleanup

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126268/
---

(Updated Dec. 7, 2015, 12:26 a.m.)


Review request for Plasma.


Repository: plasma-workspace


Description
---

Shutdown scripts are done by startkde after ksmserver quits. Which never
happens because we've told systemd to shutdown.

Old systems worked because they used to communicate with the display
manager which then closed us before shutting down, this is no longer the
case.

This moves handling the shutdown scripts into ksmserver (which already
handles startup scripts) and runs them before asking logind to shutdown.

BUG: 356190


Diffs (updated)
-

  ksmserver/server.h 1a2f0810c53d508d7d721fb4be1c25f0585c0602 
  ksmserver/server.cpp 9477e542399ad65f993e581fc4212883f282b70e 
  startkde/startkde.cmake 41a8975cce1fb2a4e7a034e697ce6e2cc59d5b1e 
  startkde/startplasma.cmake 8360a636d3f68c957a15158484360a611cfe3ff8 

Diff: https://git.reviewboard.kde.org/r/126268/diff/


Testing
---

had a shutdown script to touch a file in my home, worked for shutdown and 
logout.


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126268: Move shutdown scripts into ksmserver cleanup

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126268/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Shutdown scripts are done by startkde after ksmserver quits. Which never
happens because we've told systemd to shutdown.

Old systems worked because they used to communicate with the display
manager which then closed us before shutting down, this is no longer the
case.

This moves handling the shutdown scripts into ksmserver (which already
handles startup scripts) and runs them before asking logind to shutdown.

BUG: 356190


Diffs
-

  ksmserver/server.h 1a2f0810c53d508d7d721fb4be1c25f0585c0602 
  ksmserver/server.cpp 9477e542399ad65f993e581fc4212883f282b70e 
  startkde/startkde.cmake 41a8975cce1fb2a4e7a034e697ce6e2cc59d5b1e 
  startkde/startplasma.cmake 8360a636d3f68c957a15158484360a611cfe3ff8 

Diff: https://git.reviewboard.kde.org/r/126268/diff/


Testing
---

had a shutdown script to touch a file in my home, worked for shutdown and 
logout.


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126248: change icons in breeze plasma theme

[Hrvoje Senjan]

> On Dec. 5, 2015, 5:56 p.m., Hrvoje Senjan wrote:
> > Andreas, battery is almost invisible with breeze dark -> 
> > http://i.imgur.com/aY1igIu.jpg
> 
> andreas kainz wrote:
> you have right the problem is also the old one from master doesn't work 
> in breeze dark. maybe marco can have a look why the color change don't work.
> 
> Andreas ka wrote:
> should work now
> 
> http://commits.kde.org/plasma-framework/42952018ad26aa5b66cda74e7a2ea69a80187ffa

sorry, still the same. also for the amarok icon...


- Hrvoje


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126248/#review89151
---


On Dec. 6, 2015, 1:01 p.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126248/
> ---
> 
> (Updated Dec. 6, 2015, 1:01 p.m.)
> 
> 
> Review request for Plasma and Uri Herrera.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> - amarok icon now works
> - add missint nm icons (https://bugs.kde.org/show_bug.cgi?id=355412)
> - change the battery icon to be more full than now 
> https://bugs.kde.org/show_bug.cgi?id=355864
> - system icons are now available in monochrome for 22px size 
> (https://bugs.kde.org/show_bug.cgi?id=355664)
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/breeze/icons/amarok.svgz 1cafc36 
>   src/desktoptheme/breeze/icons/battery.svgz 0b90ff2 
>   src/desktoptheme/breeze/icons/network.svgz b7524f0 
>   src/desktoptheme/breeze/icons/system.svgz 8528bfe 
> 
> Diff: https://git.reviewboard.kde.org/r/126248/diff/
> 
> 
> Testing
> ---
> 
> use the plasma theme monochrome system icons look good for panel applet, user 
> switch screen, 
> 
> Please check the battery icons cause sometime they are looking to bold. it's 
> my first plasma theme change.
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

[Igor Poboiko]

> On Сен. 24, 2015, 11:50 п.п., Vishesh Handa wrote:
> > runners/baloo/baloosearchrunner.cpp, line 165
> > 
> >
> > Have a look at basicindexingjob.txt. We define that all Presentation 
> > and Spreadsheets are also Documents.
> > 
> > For text, we specifically don't do that, as then we get source code as 
> > Documents. Maybe we can make another category caleld "Source Code" or 
> > something. I'm not sure, but just combining the two doesn't seem correct.
> > 
> > Maybe others can chime in?
> 
> Igor Poboiko wrote:
> Dammit, my fault. Sorry for the noise. I just noticed that sometimes 
> KRunner don't look for presentations, so I thought the issue was here. And 
> when I fixed it, it worked.
> But it seems like the problem is with indexing; sometimes mimetype is not 
> determined correctly. And it's not always reproducible. But that's another 
> issue.
> 
> # balooctl index test.ppt
> Indexing /home/eol/test.ppt
>  -- indexing "/home/eol/test.ppt" mimetype "application/x-ole-storage"
> File(s) indexed
> # mimetype test.ppt
> application/vnd.ms-powerpoint
> 
> Regarding indexing of text files: I thought the issue was just due to 
> performance of indexing; but now it doesn't index large text-files.
> I mean, e.g. I have a lot of plain-text documents (which are not source 
> codes, but are proper documents): those are mostly LaTeX files or just .txt 
> files with some notes. I expected them to pop up during search.
> 
> Pinak Ahuja wrote:
> That would me mainly because we skip text files larger than 10 mb, have a 
> look at file/extractor/app.cpp
> Maybe we can experiment with a different limit. Mimetype issue is 
> something we should look into. I've seen audio files with .m4a extension 
> showing mimetype as video in the index.
> 
> Igor Poboiko wrote:
> No-no, that wasn't the case. My .tex-files are much smaller (several 
> KBs), and "balooshow -x" shows that they are indexed properly. They just 
> don't popup because of its type ("T8 Ttext" in index).
> 
> The limit solution looks perfectly fine for me. I mean, I don't write 
> files of size 10Mb+ by myself :) 
> They are 99.99% are not documents but just some machine-generated junk 
> (log-files, or something like that), and I don't want it to be indexed 
> anyways.
> But small text files might be useful for me. Especially if they are 
> already indexed :)
> 
> Talking about mimetypes: right, I had the same issue with mp4 audio-files 
> too. But it seems to be an upstream issue, mimetype handling is 
> shared-mime-database and Qt job...
> 
> Vishesh Handa wrote:
> Ping? Can this be closed.

It would be very useful for me if it would look for at least some of text files 
(.tex and .lyx files, to be more specific). At least under some new category 
("Plain text files", etc). But that's clearly another issue, this can indeed be 
closed.


- Igor


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125369/#review85905
---


On Сен. 24, 2015, 7:18 д.п., Igor Poboiko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125369/
> ---
> 
> (Updated Сен. 24, 2015, 7:18 д.п.)
> 
> 
> Review request for Baloo and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Small usability improvement: since presentations, spreadsheets and text files 
> are also documents (at least, that's what I expect :) ), search for them in 
> KRunner when "documents" category is checked.
> 
> 
> Diffs
> -
> 
>   runners/baloo/baloosearchrunner.cpp 0023a11 
> 
> Diff: https://git.reviewboard.kde.org/r/125369/diff/
> 
> 
> Testing
> ---
> 
> It just works: now I am able to find my LaTeX-files, various presentations, 
> etc with KRunner.
> 
> 
> Thanks,
> 
> Igor Poboiko
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

[Pinak Ahuja]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125129/
---

(Updated Dec. 6, 2015, 2:18 p.m.)


Review request for Plasma and Vishesh Handa.


Repository: plasma-desktop


Description (updated)
---

Also use the new Baloo::IndexerConfig::refresh()


Diffs (updated)
-

  kcms/baloo/kcm.cpp 8012a3b 

Diff: https://git.reviewboard.kde.org/r/125129/diff/


Testing
---


Thanks,

Pinak Ahuja

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

[Pinak Ahuja]

> On Sept. 15, 2015, 9:33 p.m., Vishesh Handa wrote:
> > Maybe we could just add this to our `IndexerConfig` class so that users of 
> > our API don't need to know about dbus interfaces? Specially since I'm not 
> > too keen on maintaining API comatibility in the dbus interface.
> 
> Pinak Ahuja wrote:
> You mean adding a public method in IndexerConfig to update config?
> updateConfig in mainhub also calls 
> FileWatch::updateIndexedFoldersWatches()
> 
> Vishesh Handa wrote:
> Yup. Add a method in `IndexerConfig`. Maybe refresh or reload?
> 
> Vishesh Handa wrote:
> Ping. I think we can now use the new APIs in IndexerConfig.
> 
> Pinak Ahuja wrote:
> how do we handle killing baloo without dbus? Do I add an API for that as 
> well in IndexerConfig?
> 
> Vishesh Handa wrote:
> well, we could just give it a signal to quit or use the 'quit' dbus 
> method directly on '/'. IndexerConfig does not seem like the best place for a 
> method to control the state of the indexer.

Wasn't,removing reliance of the kcm on D-bus interfaces the whole point of 
adding the refresh API to the IndexerConfig. If we still use the D-Bus quit 
method that sort of invalidates the change. The only other way to kill baloo 
that I can think of is calling kill using QProcess, but that would be ugly.
Seems like can't do away with the D-Bus reliance completely. I'll update the 
patch keeping the quit part same and use the IndexerConfig API for refresh.


- Pinak


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125129/#review85462
---


On Sept. 10, 2015, 5:56 a.m., Pinak Ahuja wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125129/
> ---
> 
> (Updated Sept. 10, 2015, 5:56 a.m.)
> 
> 
> Review request for Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Also generate interface from XML
> 
> 
> Diffs
> -
> 
>   kcms/baloo/CMakeLists.txt 7415289 
>   kcms/baloo/kcm.cpp d85f615 
> 
> Diff: https://git.reviewboard.kde.org/r/125129/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Pinak Ahuja
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126248: change icons in breeze plasma theme

[andreas kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126248/
---

(Updated Dec. 6, 2015, 12:01 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Uri Herrera.


Repository: plasma-framework


Description
---

- amarok icon now works
- add missint nm icons (https://bugs.kde.org/show_bug.cgi?id=355412)
- change the battery icon to be more full than now 
https://bugs.kde.org/show_bug.cgi?id=355864
- system icons are now available in monochrome for 22px size 
(https://bugs.kde.org/show_bug.cgi?id=355664)


Diffs
-

  src/desktoptheme/breeze/icons/amarok.svgz 1cafc36 
  src/desktoptheme/breeze/icons/battery.svgz 0b90ff2 
  src/desktoptheme/breeze/icons/network.svgz b7524f0 
  src/desktoptheme/breeze/icons/system.svgz 8528bfe 

Diff: https://git.reviewboard.kde.org/r/126248/diff/


Testing
---

use the plasma theme monochrome system icons look good for panel applet, user 
switch screen, 

Please check the battery icons cause sometime they are looking to bold. it's my 
first plasma theme change.


Thanks,

andreas kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

[Vishesh Handa]

> On Sept. 24, 2015, 11:50 p.m., Vishesh Handa wrote:
> > runners/baloo/baloosearchrunner.cpp, line 165
> > 
> >
> > Have a look at basicindexingjob.txt. We define that all Presentation 
> > and Spreadsheets are also Documents.
> > 
> > For text, we specifically don't do that, as then we get source code as 
> > Documents. Maybe we can make another category caleld "Source Code" or 
> > something. I'm not sure, but just combining the two doesn't seem correct.
> > 
> > Maybe others can chime in?
> 
> Igor Poboiko wrote:
> Dammit, my fault. Sorry for the noise. I just noticed that sometimes 
> KRunner don't look for presentations, so I thought the issue was here. And 
> when I fixed it, it worked.
> But it seems like the problem is with indexing; sometimes mimetype is not 
> determined correctly. And it's not always reproducible. But that's another 
> issue.
> 
> # balooctl index test.ppt
> Indexing /home/eol/test.ppt
>  -- indexing "/home/eol/test.ppt" mimetype "application/x-ole-storage"
> File(s) indexed
> # mimetype test.ppt
> application/vnd.ms-powerpoint
> 
> Regarding indexing of text files: I thought the issue was just due to 
> performance of indexing; but now it doesn't index large text-files.
> I mean, e.g. I have a lot of plain-text documents (which are not source 
> codes, but are proper documents): those are mostly LaTeX files or just .txt 
> files with some notes. I expected them to pop up during search.
> 
> Pinak Ahuja wrote:
> That would me mainly because we skip text files larger than 10 mb, have a 
> look at file/extractor/app.cpp
> Maybe we can experiment with a different limit. Mimetype issue is 
> something we should look into. I've seen audio files with .m4a extension 
> showing mimetype as video in the index.
> 
> Igor Poboiko wrote:
> No-no, that wasn't the case. My .tex-files are much smaller (several 
> KBs), and "balooshow -x" shows that they are indexed properly. They just 
> don't popup because of its type ("T8 Ttext" in index).
> 
> The limit solution looks perfectly fine for me. I mean, I don't write 
> files of size 10Mb+ by myself :) 
> They are 99.99% are not documents but just some machine-generated junk 
> (log-files, or something like that), and I don't want it to be indexed 
> anyways.
> But small text files might be useful for me. Especially if they are 
> already indexed :)
> 
> Talking about mimetypes: right, I had the same issue with mp4 audio-files 
> too. But it seems to be an upstream issue, mimetype handling is 
> shared-mime-database and Qt job...

Ping? Can this be closed.


- Vishesh


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125369/#review85905
---


On Sept. 24, 2015, 7:18 a.m., Igor Poboiko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125369/
> ---
> 
> (Updated Sept. 24, 2015, 7:18 a.m.)
> 
> 
> Review request for Baloo and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Small usability improvement: since presentations, spreadsheets and text files 
> are also documents (at least, that's what I expect :) ), search for them in 
> KRunner when "documents" category is checked.
> 
> 
> Diffs
> -
> 
>   runners/baloo/baloosearchrunner.cpp 0023a11 
> 
> Diff: https://git.reviewboard.kde.org/r/125369/diff/
> 
> 
> Testing
> ---
> 
> It just works: now I am able to find my LaTeX-files, various presentations, 
> etc with KRunner.
> 
> 
> Thanks,
> 
> Igor Poboiko
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

[Vishesh Handa]

> On Sept. 15, 2015, 9:33 p.m., Vishesh Handa wrote:
> > Maybe we could just add this to our `IndexerConfig` class so that users of 
> > our API don't need to know about dbus interfaces? Specially since I'm not 
> > too keen on maintaining API comatibility in the dbus interface.
> 
> Pinak Ahuja wrote:
> You mean adding a public method in IndexerConfig to update config?
> updateConfig in mainhub also calls 
> FileWatch::updateIndexedFoldersWatches()
> 
> Vishesh Handa wrote:
> Yup. Add a method in `IndexerConfig`. Maybe refresh or reload?
> 
> Vishesh Handa wrote:
> Ping. I think we can now use the new APIs in IndexerConfig.
> 
> Pinak Ahuja wrote:
> how do we handle killing baloo without dbus? Do I add an API for that as 
> well in IndexerConfig?

well, we could just give it a signal to quit or use the 'quit' dbus method 
directly on '/'. IndexerConfig does not seem like the best place for a method 
to control the state of the indexer.


- Vishesh


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125129/#review85462
---


On Sept. 10, 2015, 5:56 a.m., Pinak Ahuja wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125129/
> ---
> 
> (Updated Sept. 10, 2015, 5:56 a.m.)
> 
> 
> Review request for Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Also generate interface from XML
> 
> 
> Diffs
> -
> 
>   kcms/baloo/CMakeLists.txt 7415289 
>   kcms/baloo/kcm.cpp d85f615 
> 
> Diff: https://git.reviewboard.kde.org/r/125129/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Pinak Ahuja
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 337674] kded5 is eating CPU

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=337674

mif...@gmail.com changed:

   What|Removed |Added

 CC||mif...@gmail.com

--- Comment #72 from mif...@gmail.com ---
I have same issue (25% CPU usage of kded5) on my plasma 5.4.3.
kde-frameworks/kded 5.16.0
kde-plasma/plasma-desktop 5.4.3
kde-plasma/powerdevil 5.4.3

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel