[Differential] [Closed] D820: Improve setting global lock shortcut

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKSCREENLOCKER56133098976e: Improve setting global lock 
shortcut (authored by graesslin).

REPOSITORY
  rKSCREENLOCKER KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D820?vs=1960&id=1974

REVISION DETAIL
  https://phabricator.kde.org/D820

AFFECTED FILES
  CMakeLists.txt
  ksldapp.cpp
  ksldapp.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, bshah
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D821: Drop not needed KF5::Plasma dependency

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKSCREENLOCKERc07ef9389342: Drop not needed KF5::Plasma 
dependency (authored by graesslin).

REPOSITORY
  rKSCREENLOCKER KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D821?vs=1961&id=1975

REVISION DETAIL
  https://phabricator.kde.org/D821

AFFECTED FILES
  CMakeLists.txt
  kcm/CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, mart, Plasma, bshah
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D820: Improve setting global lock shortcut

[Martin Gräßlin]

graesslin added a comment.

On third thought: maybe we need to create a "Plasma Workspace" component where 
we group currently scattered shortcuts like lock screen, log out, etc.


REPOSITORY
  rKSCREENLOCKER KScreenLocker

BRANCH
  drop-action-collection

REVISION DETAIL
  https://phabricator.kde.org/D820

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, bshah
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D807: Fix for Bug 357684

[Martin Gräßlin]

graesslin added a comment.

ShipIt!


REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D807

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: danielsabo, graesslin, Plasma, davidedmundson
Cc: graesslin, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126752: Auto-add Input Method Panel widget to Default Panel when run with relevant language

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126752/#review91125
---




layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js (line 
45)


could we feed them in from a config file? So that also the user can easily 
add additional ones (does that make sense at all?)


- Martin Gräßlin


On Jan. 15, 2016, 3:14 a.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126752/
> ---
> 
> (Updated Jan. 15, 2016, 3:14 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Since the Input Method Panel (kimpanel) widget was recently moved to 
> plasma-desktop and is now guaranteed to be around, this patch will auto-add 
> it to the Default Panel when the shell is run in a relevant locale. The white 
> list of locale language id's is based on the list Fedora 23 uses to determine 
> whether or not to require installation of the ibus IME stack (one of 
> kimpanel's supported backends) at installation time.
> 
> This requires https://git.reviewboard.kde.org/r/126751/ to work.
> 
> 
> Diffs
> -
> 
>   layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js 
> 5ff228b 
> 
> Diff: https://git.reviewboard.kde.org/r/126752/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D820: Improve setting global lock shortcut

[Martin Gräßlin]

graesslin added a comment.

In https://phabricator.kde.org/D820#15811, @bshah wrote:

> On second thought, Actually maybe, we rename component to (k)screenlocker and 
> provide migration scripts?


Yes I want to do that, but as a second step. Migrating global shortcuts is 
always messy, so this is a little bit more work.


REPOSITORY
  rKSCREENLOCKER KScreenLocker

BRANCH
  drop-action-collection

REVISION DETAIL
  https://phabricator.kde.org/D820

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, bshah
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D821: Drop not needed KF5::Plasma dependency

[bshah (Bhushan Shah)]

bshah accepted this revision.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

BRANCH
  drop-plasma-dependency

REVISION DETAIL
  https://phabricator.kde.org/D821

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, mart, Plasma, bshah
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D820: Improve setting global lock shortcut

[bshah (Bhushan Shah)]

bshah added a comment.

On second thought, Actually maybe, we rename component to (k)screenlocker and 
provide migration scripts?


REPOSITORY
  rKSCREENLOCKER KScreenLocker

BRANCH
  drop-action-collection

REVISION DETAIL
  https://phabricator.kde.org/D820

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, bshah
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D820: Improve setting global lock shortcut

[bshah (Bhushan Shah)]

bshah accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

BRANCH
  drop-action-collection

REVISION DETAIL
  https://phabricator.kde.org/D820

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, bshah
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126752: Auto-add Input Method Panel widget to Default Panel when run with relevant language

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126752/
---

Review request for Plasma and Marco Martin.


Repository: plasma-desktop


Description
---

Since the Input Method Panel (kimpanel) widget was recently moved to 
plasma-desktop and is now guaranteed to be around, this patch will auto-add it 
to the Default Panel when the shell is run in a relevant locale. The white list 
of locale language id's is based on the list Fedora 23 uses to determine 
whether or not to require installation of the ibus IME stack (one of kimpanel's 
supported backends) at installation time.

This requires https://git.reviewboard.kde.org/r/126751/ to work.


Diffs
-

  layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js 
5ff228b 

Diff: https://git.reviewboard.kde.org/r/126752/diff/


Testing
---


Thanks,

Eike Hein

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126751: Expose BCP47 language id in shell scripting interface

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126751/
---

Review request for Plasma and Marco Martin.


Repository: plasma-workspace


Description
---

The existing 'language' property yields a human-readable string like "English". 
For scripting purposes it's more useful to operate on a BCP47 language id (e.g. 
'en') since it makes for shorter strings, and language lists in other parts of 
the system tend to use them, making comparisons and keeping things in sync 
easier.


Diffs
-

  shell/scripting/appinterface.h 93aa014 
  shell/scripting/appinterface.cpp 2c54f1e 

Diff: https://git.reviewboard.kde.org/r/126751/diff/


Testing
---


Thanks,

Eike Hein

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126742: Add clearActions() to remove every applet interface action.

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126742/#review91122
---

Ship it!


do you have commit access?

- David Edmundson


On Jan. 15, 2016, 1:52 a.m., James Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126742/
> ---
> 
> (Updated Jan. 15, 2016, 1:52 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Add clearActions() to remove every applet interface action. Is there an 
> equivalent way to do this in the plasmoid?
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h ad68499 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 8e4979a 
> 
> Diff: https://git.reviewboard.kde.org/r/126742/diff/
> 
> 
> Testing
> ---
> 
> Compile, runtime.
> 
> 
> Thanks,
> 
> James Smith
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126742: Add clearActions() to remove every applet interface action.

[James Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126742/
---

(Updated Jan. 15, 2016, 1:52 a.m.)


Review request for KDE Frameworks and Plasma.


Changes
---

removeAllActions() ->clearActions().


Summary (updated)
-

Add clearActions() to remove every applet interface action.


Repository: plasma-framework


Description (updated)
---

Add clearActions() to remove every applet interface action. Is there an 
equivalent way to do this in the plasmoid?


Diffs (updated)
-

  src/scriptengines/qml/plasmoid/appletinterface.h ad68499 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 8e4979a 

Diff: https://git.reviewboard.kde.org/r/126742/diff/


Testing
---

Compile, runtime.


Thanks,

James Smith

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 5 lines] D807: Fix for Bug 357684

[danielsabo (Daniel Sabo)]

danielsabo updated this revision to Diff 1971.
danielsabo added a comment.

const'd bool


REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D807?vs=1933&id=1971

REVISION DETAIL
  https://phabricator.kde.org/D807

AFFECTED FILES
  src/platformtheme/kdeplatformfiledialoghelper.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: danielsabo, graesslin, Plasma, davidedmundson
Cc: graesslin, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126749: change exec mimetype color from green to red

[Gregor Mi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126749/#review91117
---


I would like to note that Uri's comment here 
https://forum.kde.org/viewtopic.php?f=285&t=128846#p343970 implies that green 
is (or should be?) the color for executable files.

Though personally, I find red a good choice because there are far less 
executable files around than normal ones and executable files are potentially 
harmful.

- Gregor Mi


On Jan. 14, 2016, 10:24 p.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126749/
> ---
> 
> (Updated Jan. 14, 2016, 10:24 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> https://forum.kde.org/viewtopic.php?f=285&t=130558
> 
> 
> Diffs
> -
> 
>   icons-dark/mimetypes/16/application-x-executable-script.svg 3b80b05 
>   icons-dark/mimetypes/16/application-x-executable.svg 03d554c 
>   icons-dark/mimetypes/22/application-x-executable-script.svg c267213 
>   icons-dark/mimetypes/22/application-x-executable.svg b8e1a8c 
>   icons-dark/mimetypes/32/application-x-executable-script.svg ba195a5 
>   icons-dark/mimetypes/32/application-x-executable.svg 6a7baa1 
>   icons-dark/mimetypes/64/application-x-executable-script.svg ce07afd 
>   icons-dark/mimetypes/64/application-x-executable.svg da866d6 
>   icons/mimetypes/16/application-x-executable-script.svg 3b80b05 
>   icons/mimetypes/16/application-x-executable.svg 03d554c 
>   icons/mimetypes/22/application-x-executable-script.svg c267213 
>   icons/mimetypes/22/application-x-executable.svg b8e1a8c 
>   icons/mimetypes/32/application-x-executable-script.svg ba195a5 
>   icons/mimetypes/32/application-x-executable.svg 6a7baa1 
>   icons/mimetypes/64/application-x-executable-script.svg ce07afd 
>   icons/mimetypes/64/application-x-executable.svg da866d6 
> 
> Diff: https://git.reviewboard.kde.org/r/126749/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> left old right new
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/14/634c3a94-4ea9-4025-ba88-d63d6196efbb__exec.png
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126749: change exec mimetype color from green to red

[andreas kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126749/
---

(Updated Jan. 14, 2016, 10:24 p.m.)


Review request for Plasma.


Repository: breeze-icons


Description
---

https://forum.kde.org/viewtopic.php?f=285&t=130558


Diffs
-

  icons-dark/mimetypes/16/application-x-executable-script.svg 3b80b05 
  icons-dark/mimetypes/16/application-x-executable.svg 03d554c 
  icons-dark/mimetypes/22/application-x-executable-script.svg c267213 
  icons-dark/mimetypes/22/application-x-executable.svg b8e1a8c 
  icons-dark/mimetypes/32/application-x-executable-script.svg ba195a5 
  icons-dark/mimetypes/32/application-x-executable.svg 6a7baa1 
  icons-dark/mimetypes/64/application-x-executable-script.svg ce07afd 
  icons-dark/mimetypes/64/application-x-executable.svg da866d6 
  icons/mimetypes/16/application-x-executable-script.svg 3b80b05 
  icons/mimetypes/16/application-x-executable.svg 03d554c 
  icons/mimetypes/22/application-x-executable-script.svg c267213 
  icons/mimetypes/22/application-x-executable.svg b8e1a8c 
  icons/mimetypes/32/application-x-executable-script.svg ba195a5 
  icons/mimetypes/32/application-x-executable.svg 6a7baa1 
  icons/mimetypes/64/application-x-executable-script.svg ce07afd 
  icons/mimetypes/64/application-x-executable.svg da866d6 

Diff: https://git.reviewboard.kde.org/r/126749/diff/


Testing
---


File Attachments (updated)


left old right new
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/14/634c3a94-4ea9-4025-ba88-d63d6196efbb__exec.png


Thanks,

andreas kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126749: change exec mimetype color from green to red

[andreas kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126749/
---

Review request for Plasma.


Repository: breeze-icons


Description
---

https://forum.kde.org/viewtopic.php?f=285&t=130558


Diffs
-

  icons-dark/mimetypes/16/application-x-executable-script.svg 3b80b05 
  icons-dark/mimetypes/16/application-x-executable.svg 03d554c 
  icons-dark/mimetypes/22/application-x-executable-script.svg c267213 
  icons-dark/mimetypes/22/application-x-executable.svg b8e1a8c 
  icons-dark/mimetypes/32/application-x-executable-script.svg ba195a5 
  icons-dark/mimetypes/32/application-x-executable.svg 6a7baa1 
  icons-dark/mimetypes/64/application-x-executable-script.svg ce07afd 
  icons-dark/mimetypes/64/application-x-executable.svg da866d6 
  icons/mimetypes/16/application-x-executable-script.svg 3b80b05 
  icons/mimetypes/16/application-x-executable.svg 03d554c 
  icons/mimetypes/22/application-x-executable-script.svg c267213 
  icons/mimetypes/22/application-x-executable.svg b8e1a8c 
  icons/mimetypes/32/application-x-executable-script.svg ba195a5 
  icons/mimetypes/32/application-x-executable.svg 6a7baa1 
  icons/mimetypes/64/application-x-executable-script.svg ce07afd 
  icons/mimetypes/64/application-x-executable.svg da866d6 

Diff: https://git.reviewboard.kde.org/r/126749/diff/


Testing
---


Thanks,

andreas kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

[Kai Uwe Broulik]

> On Jan. 14, 2016, 6:22 nachm., Martin Klapetek wrote:
> > It should probably still show when you get disconnected and *not* 
> > reconnected (to any network) on resume?
> 
> Kai Uwe Broulik wrote:
> Doesn't it tell you that anyway? At least when I try to connect to 
> something and it fails I get like 3 notifications about different failures.
> 
> Martin Klapetek wrote:
> What I mean is when you suspend your laptop at home, connected to your 
> home network, you go out and resume your laptop say at your friend where you 
> didn't connect to the wifi before, so it's unknown and your laptop will not 
> connect to anything and will not even try. At that point, it should show a 
> "disconnected" notification, maybe?

Ah, I see. How should I do that? If it disconnected on suspend and didn't 
attempt to reconnect within 5 seconds show a notification that you're no longer 
connected?


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91107
---


On Jan. 14, 2016, 6:19 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Jan. 14, 2016, 6:19 nachm.)
> 
> 
> Review request for Plasma and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

[Martin Klapetek]

> On Jan. 14, 2016, 7:22 p.m., Martin Klapetek wrote:
> > It should probably still show when you get disconnected and *not* 
> > reconnected (to any network) on resume?
> 
> Kai Uwe Broulik wrote:
> Doesn't it tell you that anyway? At least when I try to connect to 
> something and it fails I get like 3 notifications about different failures.

What I mean is when you suspend your laptop at home, connected to your home 
network, you go out and resume your laptop say at your friend where you didn't 
connect to the wifi before, so it's unknown and your laptop will not connect to 
anything and will not even try. At that point, it should show a "disconnected" 
notification, maybe?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91107
---


On Jan. 14, 2016, 7:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Jan. 14, 2016, 7:19 p.m.)
> 
> 
> Review request for Plasma and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

[Kai Uwe Broulik]

> On Jan. 14, 2016, 6:22 nachm., Martin Klapetek wrote:
> > It should probably still show when you get disconnected and *not* 
> > reconnected (to any network) on resume?

Doesn't it tell you that anyway? At least when I try to connect to something 
and it fails I get like 3 notifications about different failures.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91107
---


On Jan. 14, 2016, 6:19 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Jan. 14, 2016, 6:19 nachm.)
> 
> 
> Review request for Plasma and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91107
---


It should probably still show when you get disconnected and *not* reconnected 
(to any network) on resume?

- Martin Klapetek


On Jan. 14, 2016, 7:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Jan. 14, 2016, 7:19 p.m.)
> 
> 
> Review request for Plasma and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/
---

Review request for Plasma and Jan Grulich.


Repository: plasma-nm


Description
---

It's quite natural that the connection goes away when we're about to suspend :) 
Watch for this and then don't emit the notification.


Diffs
-

  kded/notification.h 9b8b51a 
  kded/notification.cpp 231d69e 

Diff: https://git.reviewboard.kde.org/r/126748/diff/


Testing
---

While I still think Plasma-NM is waay too verbose about everything, at 
least it doesn't tell me that I just disconnected when I suspend.

I still get the notification when I turn off Wifi manually.
I also still get the notification that I'm connected again shortly after 
resuming.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126743: Fix shrinking panel on top/left/right edge

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126743/
---

(Updated Jan. 14, 2016, 5:57 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 2f07fdd5d34673f856b8f8401ab8447000254aaa by David Rosca 
to branch Plasma/5.5.


Bugs: 357835
https://bugs.kde.org/show_bug.cgi?id=357835


Repository: plasma-desktop


Description
---

Use the new computed value for configDialog position.

Fix regression from 8ba3633227


Diffs
-

  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml 
5e6185c 

Diff: https://git.reviewboard.kde.org/r/126743/diff/


Testing
---

Panels can be shrinked now


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126743: Fix shrinking panel on top/left/right edge

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126743/#review91097
---

Ship it!


Ship It!

- Eike Hein


On Jan. 14, 2016, 3:08 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126743/
> ---
> 
> (Updated Jan. 14, 2016, 3:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 357835
> https://bugs.kde.org/show_bug.cgi?id=357835
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Use the new computed value for configDialog position.
> 
> Fix regression from 8ba3633227
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml 
> 5e6185c 
> 
> Diff: https://git.reviewboard.kde.org/r/126743/diff/
> 
> 
> Testing
> ---
> 
> Panels can be shrinked now
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126742: Add removeAllActions() to remove every applet interface action.

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126742/#review91096
---



src/scriptengines/qml/plasmoid/appletinterface.cpp (line 504)


const QString & ?


- Kai Uwe Broulik


On Jan. 14, 2016, 12:42 nachm., James Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126742/
> ---
> 
> (Updated Jan. 14, 2016, 12:42 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Add removeAllActions() to remove every applet interface action. Is there an 
> equivalent way to do this in the plasmoid?
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 
> ad6849990789e0f960ff074e1a9db21ef64381ef 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 
> 8e4979ae9ec89da02f68e6438b5b0ab40a2495d0 
> 
> Diff: https://git.reviewboard.kde.org/r/126742/diff/
> 
> 
> Testing
> ---
> 
> Compile, runtime.
> 
> 
> Thanks,
> 
> James Smith
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D821: Drop not needed KF5::Plasma dependency

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

BRANCH
  drop-plasma-dependency

REVISION DETAIL
  https://phabricator.kde.org/D821

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, bshah, Plasma, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126742: Add removeAllActions() to remove every applet interface action.

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126742/#review91095
---

Ship it!



src/scriptengines/qml/plasmoid/appletinterface.h (line 245)


Agree with David, clearActions()


- Marco Martin


On Jan. 14, 2016, 12:42 p.m., James Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126742/
> ---
> 
> (Updated Jan. 14, 2016, 12:42 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Add removeAllActions() to remove every applet interface action. Is there an 
> equivalent way to do this in the plasmoid?
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 
> ad6849990789e0f960ff074e1a9db21ef64381ef 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 
> 8e4979ae9ec89da02f68e6438b5b0ab40a2495d0 
> 
> Diff: https://git.reviewboard.kde.org/r/126742/diff/
> 
> 
> Testing
> ---
> 
> Compile, runtime.
> 
> 
> Thanks,
> 
> James Smith
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126740: Add a script for optimizing svgs

[Aleix Pol Gonzalez]

> On Jan. 14, 2016, 1:22 p.m., andreas kainz wrote:
> > I have no problems to optimzie the svg files BUT my problem with the svg 
> > files is that they become more complex all the time last time the 
> > stylesheet, now optimization, 
> > 
> > I love scripts BUT it would be awesome for us to have this scripts before 
> > an distribution build there packages. In git keep it as simple as possible 
> > and when an distro will use the icons use therefore an script (check if the 
> > stylesheets fit, compress, make png files, )
> 
> Aleix Pol Gonzalez wrote:
> That's also the reason why I did it like this. This script doesn't need 
> to be run by the icon designer himself, it can be ran by the release manager 
> before creating the tarballs (or anyone else for that matter).
> 
> I don't think it's a problem having non-optimized svgs in git, but we 
> should provide users whatever is easier to execute when we release.
> 
> Sebastian Kügler wrote:
> If we run this only on releases, it means that typically no developer 
> uses the final result of the icons. (I run master all the time, it's usually 
> a pure coincidence if I run an actual release on my laptop. If the icons only 
> get compressed or optimized right before a release, that means that I've run 
> unoptimized svgs, different from what our users end up using, which may yield 
> different results.)
> 
> Aleix Pol Gonzalez wrote:
> Would you get something like scripty to run it?
> 
> Sebastian Kügler wrote:
> I've thought about it, I think it could work if it doesn't rewrite the 
> whole file every time it runs. (But only fixes 
> 'new problems', if introduced.)
> 
> Aleix Pol Gonzalez wrote:
> I'll investigate.

I just checked: optimizing an optimized files doesn't bear further changes.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/#review91064
---


On Jan. 14, 2016, 4 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126740/
> ---
> 
> (Updated Jan. 14, 2016, 4 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea 
> that right now we're serving right away the svg's from inkscape and there's 
> room for improvement, potentially.
> 
> This patch just introduces a script that optimizes the svg's using `svgo`.
> 
> More could be done, like using gzip files, we can look into that if anyone's 
> interested. In fact, we used to use svgz for the icons, I wonder why that 
> changed. 
> 
> This will change the files in-place rather than as a build step, which is 
> what I considered first. The process to run svgo on every file was about 30 
> minutes to 1h on my system, so I doubt it's really desirable.
> 
> A reduced file size is important because it will greatly reduce disk IO, 
> which is a bottle-neck we have.
> 
> 
> Diffs
> -
> 
>   optimize-svg.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126740/diff/
> 
> 
> Testing
> ---
> 
> ```
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 32M icons
> 32M icons-dark/
> 
> #run the script
> 
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 17M icons
> 17M icons-dark/
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126740: Add a script for optimizing svgs

[Aleix Pol Gonzalez]

> On Jan. 14, 2016, 11:27 a.m., Marco Martin wrote:
> > does the svg stuff still workk?
> > this script goes well together the others i have (only in plasma-framework 
> > atm) to remove the hardcoded colors inkscape likes to put even when an 
> > element is using the stylesheet and the one to replace hardcoded colors 
> > with classes of the stylesheet.
> > 
> > 
> > as for compressing: i was actually thinking of uncompressing the svgs in 
> > plasma-framework :p (mainly because git)
> > 
> > what needs to happen is probably the compression to svgz to be done at 
> > build time and have all simple svgs in the repository
> 
> Aleix Pol Gonzalez wrote:
> What do you mean with "because git"? Because we might have the exact same 
> problem with svgo then.
> 
> Sebastian Kügler wrote:
> I'm doing an educated guess here: Marco wants readable diffs to icons, so 
> it's easier to spot if the coloring / stylesheets are still correct.
> 
> Aleix Pol Gonzalez wrote:
> If so, optmized svgs wouldn't work either, because they are squeezed in 
> one line.
> 
> Maybe it would be better to use different tooling to see the differences 
> on those cases?

Regarding gzip, which I understand it's a bit out of topic, I did the research 
too:

```
$ cat ~/frameworks/plasma-framework/.gitattributes 
*.svgz diff=gzip
$ cat .gitconfig
#...
[diff "gzip"]
textconv = gunzip -S .svgz -c
```

This lets you compare svgz files in git diff/show.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/#review91055
---


On Jan. 14, 2016, 4 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126740/
> ---
> 
> (Updated Jan. 14, 2016, 4 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea 
> that right now we're serving right away the svg's from inkscape and there's 
> room for improvement, potentially.
> 
> This patch just introduces a script that optimizes the svg's using `svgo`.
> 
> More could be done, like using gzip files, we can look into that if anyone's 
> interested. In fact, we used to use svgz for the icons, I wonder why that 
> changed. 
> 
> This will change the files in-place rather than as a build step, which is 
> what I considered first. The process to run svgo on every file was about 30 
> minutes to 1h on my system, so I doubt it's really desirable.
> 
> A reduced file size is important because it will greatly reduce disk IO, 
> which is a bottle-neck we have.
> 
> 
> Diffs
> -
> 
>   optimize-svg.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126740/diff/
> 
> 
> Testing
> ---
> 
> ```
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 32M icons
> 32M icons-dark/
> 
> #run the script
> 
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 17M icons
> 17M icons-dark/
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126742: Add removeAllActions() to remove every applet interface action.

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126742/#review91089
---


+1 from me

though maybe clearActions fits Qt conventions a bit closer.

- David Edmundson


On Jan. 14, 2016, 12:42 p.m., James Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126742/
> ---
> 
> (Updated Jan. 14, 2016, 12:42 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Add removeAllActions() to remove every applet interface action. Is there an 
> equivalent way to do this in the plasmoid?
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 
> ad6849990789e0f960ff074e1a9db21ef64381ef 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 
> 8e4979ae9ec89da02f68e6438b5b0ab40a2495d0 
> 
> Diff: https://git.reviewboard.kde.org/r/126742/diff/
> 
> 
> Testing
> ---
> 
> Compile, runtime.
> 
> 
> Thanks,
> 
> James Smith
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126743: Fix shrinking panel on top/left/right edge

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126743/
---

Review request for Plasma.


Bugs: 357835
https://bugs.kde.org/show_bug.cgi?id=357835


Repository: plasma-desktop


Description
---

Use the new computed value for configDialog position.

Fix regression from 8ba3633227


Diffs
-

  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml 
5e6185c 

Diff: https://git.reviewboard.kde.org/r/126743/diff/


Testing
---

Panels can be shrinked now


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D821: Drop not needed KF5::Plasma dependency

[Martin Gräßlin]

graesslin added a reviewer: Plasma.
graesslin added a project: Plasma.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D821

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, bshah, Plasma
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 4 lines] D821: Drop not needed KF5::Plasma dependency

[Martin Gräßlin]

graesslin created this revision.
graesslin added a reviewer: bshah.
graesslin added a subscriber: plasma-devel.

REVISION SUMMARY
  Only used for installing package, that can be done through kpackage
  as well.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

BRANCH
  drop-plasma-dependency

REVISION DETAIL
  https://phabricator.kde.org/D821

AFFECTED FILES
  CMakeLists.txt
  kcm/CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, bshah
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 23 lines] D820: Improve setting global lock shortcut

[Martin Gräßlin]

graesslin created this revision.
graesslin added a reviewer: bshah.
graesslin added a subscriber: plasma-devel.

REVISION SUMMARY
  KSld is a library which means the componentName is set to the application
  name. This works fine for KSMServer, but in KWin the shortcut didn't
  work.
  
  This change manually sets the proper component name (ksmserver) on the
  QAction and at the same time removes the usage of the KActionCollection.
  
  Due to that we can also drop the dependency on XmlGui.

TEST PLAN
  Locking screen through configured shortcut works now in kwin_wayland.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

BRANCH
  drop-action-collection

REVISION DETAIL
  https://phabricator.kde.org/D820

AFFECTED FILES
  CMakeLists.txt
  ksldapp.cpp
  ksldapp.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, bshah
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D820: Improve setting global lock shortcut

[Martin Gräßlin]

graesslin added a reviewer: Plasma.
graesslin added a project: Plasma.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D820

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, bshah, Plasma
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D819: [shell] Listen for QEvent::PlatformSurface to perform Wayland integration

[Martin Gräßlin]

graesslin updated the test plan for this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D819

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, mart, Plasma
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126689: Change minimum Size of Calendar

[Martin Gräßlin]

> On Jan. 13, 2016, 10:06 p.m., Martin Klapetek wrote:
> > I'm not entirely sure why, but this change breaks the applet switching.
> > 
> > Marco?
> 
> andreas kainz wrote:
> maybe I should stop my work at the plasmoids.
> 
> I don't have luck
> 
> Sebastian Kügler wrote:
> Hell no! Development is at times frustrating, but trust me, it gets 
> easier over time. (And then you tackle harder problems, so yeah ... 
> frustration is part of the job. Upside: you get to whine at a really high 
> level! ;-)) Once in a while you look up from your desk and see what you've 
> achieved, and that's the rewarding part. Your work is very useful, in any 
> case, please keep it up.

What sebas said and as encouragement: 
https://pbs.twimg.com/media/B5l2AdVIUAAShBn.jpg


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126689/#review91032
---


On Jan. 11, 2016, 12:41 a.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126689/
> ---
> 
> (Updated Jan. 11, 2016, 12:41 a.m.)
> 
> 
> Review request for Plasma and Heiko Tietze.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> it's the minimum usefull size for the calendar applet on the desktop
> 
> https://git.reviewboard.kde.org/r/126356/
> 
> 
> Diffs
> -
> 
>   applets/calendar/contents/ui/main.qml f545e47 
> 
> Diff: https://git.reviewboard.kde.org/r/126689/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> calendar min
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/94ccc241-fc5d-4987-afd4-9139ab0d45d7__calendarMinimumSize.png
> calender size wi
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/d73ce900-fcad-498f-9570-34842483b60e__calenderSize.png
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126689: Change minimum Size of Calendar

[Sebastian Kügler]

> On Jan. 13, 2016, 9:06 p.m., Martin Klapetek wrote:
> > I'm not entirely sure why, but this change breaks the applet switching.
> > 
> > Marco?
> 
> andreas kainz wrote:
> maybe I should stop my work at the plasmoids.
> 
> I don't have luck

Hell no! Development is at times frustrating, but trust me, it gets easier over 
time. (And then you tackle harder problems, so yeah ... frustration is part of 
the job. Upside: you get to whine at a really high level! ;-)) Once in a while 
you look up from your desk and see what you've achieved, and that's the 
rewarding part. Your work is very useful, in any case, please keep it up.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126689/#review91032
---


On Jan. 10, 2016, 11:41 p.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126689/
> ---
> 
> (Updated Jan. 10, 2016, 11:41 p.m.)
> 
> 
> Review request for Plasma and Heiko Tietze.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> it's the minimum usefull size for the calendar applet on the desktop
> 
> https://git.reviewboard.kde.org/r/126356/
> 
> 
> Diffs
> -
> 
>   applets/calendar/contents/ui/main.qml f545e47 
> 
> Diff: https://git.reviewboard.kde.org/r/126689/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> calendar min
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/94ccc241-fc5d-4987-afd4-9139ab0d45d7__calendarMinimumSize.png
> calender size wi
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/d73ce900-fcad-498f-9570-34842483b60e__calenderSize.png
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126740: Add a script for optimizing svgs

[Aleix Pol Gonzalez]

> On Jan. 14, 2016, 1:22 p.m., andreas kainz wrote:
> > I have no problems to optimzie the svg files BUT my problem with the svg 
> > files is that they become more complex all the time last time the 
> > stylesheet, now optimization, 
> > 
> > I love scripts BUT it would be awesome for us to have this scripts before 
> > an distribution build there packages. In git keep it as simple as possible 
> > and when an distro will use the icons use therefore an script (check if the 
> > stylesheets fit, compress, make png files, )
> 
> Aleix Pol Gonzalez wrote:
> That's also the reason why I did it like this. This script doesn't need 
> to be run by the icon designer himself, it can be ran by the release manager 
> before creating the tarballs (or anyone else for that matter).
> 
> I don't think it's a problem having non-optimized svgs in git, but we 
> should provide users whatever is easier to execute when we release.
> 
> Sebastian Kügler wrote:
> If we run this only on releases, it means that typically no developer 
> uses the final result of the icons. (I run master all the time, it's usually 
> a pure coincidence if I run an actual release on my laptop. If the icons only 
> get compressed or optimized right before a release, that means that I've run 
> unoptimized svgs, different from what our users end up using, which may yield 
> different results.)
> 
> Aleix Pol Gonzalez wrote:
> Would you get something like scripty to run it?
> 
> Sebastian Kügler wrote:
> I've thought about it, I think it could work if it doesn't rewrite the 
> whole file every time it runs. (But only fixes 
> 'new problems', if introduced.)

I'll investigate.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/#review91064
---


On Jan. 14, 2016, 4 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126740/
> ---
> 
> (Updated Jan. 14, 2016, 4 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea 
> that right now we're serving right away the svg's from inkscape and there's 
> room for improvement, potentially.
> 
> This patch just introduces a script that optimizes the svg's using `svgo`.
> 
> More could be done, like using gzip files, we can look into that if anyone's 
> interested. In fact, we used to use svgz for the icons, I wonder why that 
> changed. 
> 
> This will change the files in-place rather than as a build step, which is 
> what I considered first. The process to run svgo on every file was about 30 
> minutes to 1h on my system, so I doubt it's really desirable.
> 
> A reduced file size is important because it will greatly reduce disk IO, 
> which is a bottle-neck we have.
> 
> 
> Diffs
> -
> 
>   optimize-svg.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126740/diff/
> 
> 
> Testing
> ---
> 
> ```
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 32M icons
> 32M icons-dark/
> 
> #run the script
> 
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 17M icons
> 17M icons-dark/
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D819: [shell] Listen for QEvent::PlatformSurface to perform Wayland integration

[Martin Gräßlin]

graesslin updated the test plan for this revision.
graesslin added a reviewer: Plasma.
graesslin added a project: Plasma.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D819

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, mart, Plasma
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 81 lines] D819: [shell] Listen for QEvent::PlatformSurface to perform Wayland integration

[Martin Gräßlin]

graesslin created this revision.
graesslin added a reviewer: mart.
graesslin added a subscriber: plasma-devel.

REVISION SUMMARY
  Since Qt 5.5 there is a dedicated event when a PlatformSurface gets
  created. This allows us to know when we need to setup the Wayland
  integration.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  wayland-platform-surface

REVISION DETAIL
  https://phabricator.kde.org/D819

AFFECTED FILES
  shell/desktopview.cpp
  shell/panelconfigview.cpp
  shell/panelconfigview.h
  shell/panelview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126740: Add a script for optimizing svgs

[Sebastian Kügler]

> On Jan. 14, 2016, 12:22 p.m., andreas kainz wrote:
> > I have no problems to optimzie the svg files BUT my problem with the svg 
> > files is that they become more complex all the time last time the 
> > stylesheet, now optimization, 
> > 
> > I love scripts BUT it would be awesome for us to have this scripts before 
> > an distribution build there packages. In git keep it as simple as possible 
> > and when an distro will use the icons use therefore an script (check if the 
> > stylesheets fit, compress, make png files, )
> 
> Aleix Pol Gonzalez wrote:
> That's also the reason why I did it like this. This script doesn't need 
> to be run by the icon designer himself, it can be ran by the release manager 
> before creating the tarballs (or anyone else for that matter).
> 
> I don't think it's a problem having non-optimized svgs in git, but we 
> should provide users whatever is easier to execute when we release.
> 
> Sebastian Kügler wrote:
> If we run this only on releases, it means that typically no developer 
> uses the final result of the icons. (I run master all the time, it's usually 
> a pure coincidence if I run an actual release on my laptop. If the icons only 
> get compressed or optimized right before a release, that means that I've run 
> unoptimized svgs, different from what our users end up using, which may yield 
> different results.)
> 
> Aleix Pol Gonzalez wrote:
> Would you get something like scripty to run it?

I've thought about it, I think it could work if it doesn't rewrite the whole 
file every time it runs. (But only fixes 
'new problems', if introduced.)


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/#review91064
---


On Jan. 14, 2016, 3 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126740/
> ---
> 
> (Updated Jan. 14, 2016, 3 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea 
> that right now we're serving right away the svg's from inkscape and there's 
> room for improvement, potentially.
> 
> This patch just introduces a script that optimizes the svg's using `svgo`.
> 
> More could be done, like using gzip files, we can look into that if anyone's 
> interested. In fact, we used to use svgz for the icons, I wonder why that 
> changed. 
> 
> This will change the files in-place rather than as a build step, which is 
> what I considered first. The process to run svgo on every file was about 30 
> minutes to 1h on my system, so I doubt it's really desirable.
> 
> A reduced file size is important because it will greatly reduce disk IO, 
> which is a bottle-neck we have.
> 
> 
> Diffs
> -
> 
>   optimize-svg.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126740/diff/
> 
> 
> Testing
> ---
> 
> ```
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 32M icons
> 32M icons-dark/
> 
> #run the script
> 
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 17M icons
> 17M icons-dark/
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126740: Add a script for optimizing svgs

[Aleix Pol Gonzalez]

> On Jan. 14, 2016, 1:22 p.m., andreas kainz wrote:
> > I have no problems to optimzie the svg files BUT my problem with the svg 
> > files is that they become more complex all the time last time the 
> > stylesheet, now optimization, 
> > 
> > I love scripts BUT it would be awesome for us to have this scripts before 
> > an distribution build there packages. In git keep it as simple as possible 
> > and when an distro will use the icons use therefore an script (check if the 
> > stylesheets fit, compress, make png files, )
> 
> Aleix Pol Gonzalez wrote:
> That's also the reason why I did it like this. This script doesn't need 
> to be run by the icon designer himself, it can be ran by the release manager 
> before creating the tarballs (or anyone else for that matter).
> 
> I don't think it's a problem having non-optimized svgs in git, but we 
> should provide users whatever is easier to execute when we release.
> 
> Sebastian Kügler wrote:
> If we run this only on releases, it means that typically no developer 
> uses the final result of the icons. (I run master all the time, it's usually 
> a pure coincidence if I run an actual release on my laptop. If the icons only 
> get compressed or optimized right before a release, that means that I've run 
> unoptimized svgs, different from what our users end up using, which may yield 
> different results.)

Would you get something like scripty to run it?


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/#review91064
---


On Jan. 14, 2016, 4 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126740/
> ---
> 
> (Updated Jan. 14, 2016, 4 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea 
> that right now we're serving right away the svg's from inkscape and there's 
> room for improvement, potentially.
> 
> This patch just introduces a script that optimizes the svg's using `svgo`.
> 
> More could be done, like using gzip files, we can look into that if anyone's 
> interested. In fact, we used to use svgz for the icons, I wonder why that 
> changed. 
> 
> This will change the files in-place rather than as a build step, which is 
> what I considered first. The process to run svgo on every file was about 30 
> minutes to 1h on my system, so I doubt it's really desirable.
> 
> A reduced file size is important because it will greatly reduce disk IO, 
> which is a bottle-neck we have.
> 
> 
> Diffs
> -
> 
>   optimize-svg.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126740/diff/
> 
> 
> Testing
> ---
> 
> ```
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 32M icons
> 32M icons-dark/
> 
> #run the script
> 
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 17M icons
> 17M icons-dark/
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126740: Add a script for optimizing svgs

[Aleix Pol Gonzalez]

> On Jan. 14, 2016, 11:27 a.m., Marco Martin wrote:
> > does the svg stuff still workk?
> > this script goes well together the others i have (only in plasma-framework 
> > atm) to remove the hardcoded colors inkscape likes to put even when an 
> > element is using the stylesheet and the one to replace hardcoded colors 
> > with classes of the stylesheet.
> > 
> > 
> > as for compressing: i was actually thinking of uncompressing the svgs in 
> > plasma-framework :p (mainly because git)
> > 
> > what needs to happen is probably the compression to svgz to be done at 
> > build time and have all simple svgs in the repository
> 
> Aleix Pol Gonzalez wrote:
> What do you mean with "because git"? Because we might have the exact same 
> problem with svgo then.
> 
> Sebastian Kügler wrote:
> I'm doing an educated guess here: Marco wants readable diffs to icons, so 
> it's easier to spot if the coloring / stylesheets are still correct.

If so, optmized svgs wouldn't work either, because they are squeezed in one 
line.

Maybe it would be better to use different tooling to see the differences on 
those cases?


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/#review91055
---


On Jan. 14, 2016, 4 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126740/
> ---
> 
> (Updated Jan. 14, 2016, 4 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea 
> that right now we're serving right away the svg's from inkscape and there's 
> room for improvement, potentially.
> 
> This patch just introduces a script that optimizes the svg's using `svgo`.
> 
> More could be done, like using gzip files, we can look into that if anyone's 
> interested. In fact, we used to use svgz for the icons, I wonder why that 
> changed. 
> 
> This will change the files in-place rather than as a build step, which is 
> what I considered first. The process to run svgo on every file was about 30 
> minutes to 1h on my system, so I doubt it's really desirable.
> 
> A reduced file size is important because it will greatly reduce disk IO, 
> which is a bottle-neck we have.
> 
> 
> Diffs
> -
> 
>   optimize-svg.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126740/diff/
> 
> 
> Testing
> ---
> 
> ```
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 32M icons
> 32M icons-dark/
> 
> #run the script
> 
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 17M icons
> 17M icons-dark/
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126740: Add a script for optimizing svgs

[Sebastian Kügler]

> On Jan. 14, 2016, 12:22 p.m., andreas kainz wrote:
> > I have no problems to optimzie the svg files BUT my problem with the svg 
> > files is that they become more complex all the time last time the 
> > stylesheet, now optimization, 
> > 
> > I love scripts BUT it would be awesome for us to have this scripts before 
> > an distribution build there packages. In git keep it as simple as possible 
> > and when an distro will use the icons use therefore an script (check if the 
> > stylesheets fit, compress, make png files, )
> 
> Aleix Pol Gonzalez wrote:
> That's also the reason why I did it like this. This script doesn't need 
> to be run by the icon designer himself, it can be ran by the release manager 
> before creating the tarballs (or anyone else for that matter).
> 
> I don't think it's a problem having non-optimized svgs in git, but we 
> should provide users whatever is easier to execute when we release.

If we run this only on releases, it means that typically no developer uses the 
final result of the icons. (I run master all the time, it's usually a pure 
coincidence if I run an actual release on my laptop. If the icons only get 
compressed or optimized right before a release, that means that I've run 
unoptimized svgs, different from what our users end up using, which may yield 
different results.)


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/#review91064
---


On Jan. 14, 2016, 3 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126740/
> ---
> 
> (Updated Jan. 14, 2016, 3 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea 
> that right now we're serving right away the svg's from inkscape and there's 
> room for improvement, potentially.
> 
> This patch just introduces a script that optimizes the svg's using `svgo`.
> 
> More could be done, like using gzip files, we can look into that if anyone's 
> interested. In fact, we used to use svgz for the icons, I wonder why that 
> changed. 
> 
> This will change the files in-place rather than as a build step, which is 
> what I considered first. The process to run svgo on every file was about 30 
> minutes to 1h on my system, so I doubt it's really desirable.
> 
> A reduced file size is important because it will greatly reduce disk IO, 
> which is a bottle-neck we have.
> 
> 
> Diffs
> -
> 
>   optimize-svg.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126740/diff/
> 
> 
> Testing
> ---
> 
> ```
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 32M icons
> 32M icons-dark/
> 
> #run the script
> 
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 17M icons
> 17M icons-dark/
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126740: Add a script for optimizing svgs

[Sebastian Kügler]

> On Jan. 14, 2016, 10:27 a.m., Marco Martin wrote:
> > does the svg stuff still workk?
> > this script goes well together the others i have (only in plasma-framework 
> > atm) to remove the hardcoded colors inkscape likes to put even when an 
> > element is using the stylesheet and the one to replace hardcoded colors 
> > with classes of the stylesheet.
> > 
> > 
> > as for compressing: i was actually thinking of uncompressing the svgs in 
> > plasma-framework :p (mainly because git)
> > 
> > what needs to happen is probably the compression to svgz to be done at 
> > build time and have all simple svgs in the repository
> 
> Aleix Pol Gonzalez wrote:
> What do you mean with "because git"? Because we might have the exact same 
> problem with svgo then.

I'm doing an educated guess here: Marco wants readable diffs to icons, so it's 
easier to spot if the coloring / stylesheets are still correct.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/#review91055
---


On Jan. 14, 2016, 3 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126740/
> ---
> 
> (Updated Jan. 14, 2016, 3 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea 
> that right now we're serving right away the svg's from inkscape and there's 
> room for improvement, potentially.
> 
> This patch just introduces a script that optimizes the svg's using `svgo`.
> 
> More could be done, like using gzip files, we can look into that if anyone's 
> interested. In fact, we used to use svgz for the icons, I wonder why that 
> changed. 
> 
> This will change the files in-place rather than as a build step, which is 
> what I considered first. The process to run svgo on every file was about 30 
> minutes to 1h on my system, so I doubt it's really desirable.
> 
> A reduced file size is important because it will greatly reduce disk IO, 
> which is a bottle-neck we have.
> 
> 
> Diffs
> -
> 
>   optimize-svg.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126740/diff/
> 
> 
> Testing
> ---
> 
> ```
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 32M icons
> 32M icons-dark/
> 
> #run the script
> 
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 17M icons
> 17M icons-dark/
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126742: Add removeAllActions() to remove every applet interface action.

[James Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126742/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Add removeAllActions() to remove every applet interface action. Is there an 
equivalent way to do this in the plasmoid?


Diffs
-

  src/scriptengines/qml/plasmoid/appletinterface.h 
ad6849990789e0f960ff074e1a9db21ef64381ef 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 
8e4979ae9ec89da02f68e6438b5b0ab40a2495d0 

Diff: https://git.reviewboard.kde.org/r/126742/diff/


Testing
---

Compile, runtime.


Thanks,

James Smith

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126740: Add a script for optimizing svgs

[Aleix Pol Gonzalez]

> On Jan. 14, 2016, 5:48 a.m., Dirk Hohndel wrote:
> > I think this is a good idea - but just a small side note, this does not 
> > solve the problem that my patch addressed; the external references to 
> > linearGradients are not removed by svgo
> > 
> > /D

Good to know! Maybe we should ask them to include it...


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/#review91046
---


On Jan. 14, 2016, 4 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126740/
> ---
> 
> (Updated Jan. 14, 2016, 4 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea 
> that right now we're serving right away the svg's from inkscape and there's 
> room for improvement, potentially.
> 
> This patch just introduces a script that optimizes the svg's using `svgo`.
> 
> More could be done, like using gzip files, we can look into that if anyone's 
> interested. In fact, we used to use svgz for the icons, I wonder why that 
> changed. 
> 
> This will change the files in-place rather than as a build step, which is 
> what I considered first. The process to run svgo on every file was about 30 
> minutes to 1h on my system, so I doubt it's really desirable.
> 
> A reduced file size is important because it will greatly reduce disk IO, 
> which is a bottle-neck we have.
> 
> 
> Diffs
> -
> 
>   optimize-svg.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126740/diff/
> 
> 
> Testing
> ---
> 
> ```
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 32M icons
> 32M icons-dark/
> 
> #run the script
> 
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 17M icons
> 17M icons-dark/
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126740: Add a script for optimizing svgs

[Aleix Pol Gonzalez]

> On Jan. 14, 2016, 1:22 p.m., andreas kainz wrote:
> > I have no problems to optimzie the svg files BUT my problem with the svg 
> > files is that they become more complex all the time last time the 
> > stylesheet, now optimization, 
> > 
> > I love scripts BUT it would be awesome for us to have this scripts before 
> > an distribution build there packages. In git keep it as simple as possible 
> > and when an distro will use the icons use therefore an script (check if the 
> > stylesheets fit, compress, make png files, )

That's also the reason why I did it like this. This script doesn't need to be 
run by the icon designer himself, it can be ran by the release manager before 
creating the tarballs (or anyone else for that matter).

I don't think it's a problem having non-optimized svgs in git, but we should 
provide users whatever is easier to execute when we release.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/#review91064
---


On Jan. 14, 2016, 4 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126740/
> ---
> 
> (Updated Jan. 14, 2016, 4 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea 
> that right now we're serving right away the svg's from inkscape and there's 
> room for improvement, potentially.
> 
> This patch just introduces a script that optimizes the svg's using `svgo`.
> 
> More could be done, like using gzip files, we can look into that if anyone's 
> interested. In fact, we used to use svgz for the icons, I wonder why that 
> changed. 
> 
> This will change the files in-place rather than as a build step, which is 
> what I considered first. The process to run svgo on every file was about 30 
> minutes to 1h on my system, so I doubt it's really desirable.
> 
> A reduced file size is important because it will greatly reduce disk IO, 
> which is a bottle-neck we have.
> 
> 
> Diffs
> -
> 
>   optimize-svg.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126740/diff/
> 
> 
> Testing
> ---
> 
> ```
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 32M icons
> 32M icons-dark/
> 
> #run the script
> 
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 17M icons
> 17M icons-dark/
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D784: Improve finding X11 dependencies

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAINTEGRATION3d773ee7c2e9: Improve finding X11 
dependencies (authored by graesslin).

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D784?vs=1868&id=1958

REVISION DETAIL
  https://phabricator.kde.org/D784

AFFECTED FILES
  src/platformtheme/CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: sebas, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D782: Require Qt 5.5

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAINTEGRATIONd78724790f81: Require Qt 5.5 (authored by 
graesslin).

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D782?vs=1866&id=1957

REVISION DETAIL
  https://phabricator.kde.org/D782

AFFECTED FILES
  CMakeLists.txt
  src/platformtheme/kdeplatformfiledialoghelper.cpp
  src/platformtheme/kdeplatformsystemtrayicon.cpp
  src/platformtheme/kdeplatformsystemtrayicon.h
  src/platformtheme/kdeplatformtheme.cpp
  src/platformtheme/kdeplatformtheme.h
  src/platformtheme/khintssettings.cpp
  src/platformtheme/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, mart
Cc: apol, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126740: Add a script for optimizing svgs

[andreas kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/#review91064
---


I have no problems to optimzie the svg files BUT my problem with the svg files 
is that they become more complex all the time last time the stylesheet, now 
optimization, 

I love scripts BUT it would be awesome for us to have this scripts before an 
distribution build there packages. In git keep it as simple as possible and 
when an distro will use the icons use therefore an script (check if the 
stylesheets fit, compress, make png files, )

- andreas kainz


On Jan. 14, 2016, 3 vorm., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126740/
> ---
> 
> (Updated Jan. 14, 2016, 3 vorm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea 
> that right now we're serving right away the svg's from inkscape and there's 
> room for improvement, potentially.
> 
> This patch just introduces a script that optimizes the svg's using `svgo`.
> 
> More could be done, like using gzip files, we can look into that if anyone's 
> interested. In fact, we used to use svgz for the icons, I wonder why that 
> changed. 
> 
> This will change the files in-place rather than as a build step, which is 
> what I considered first. The process to run svgo on every file was about 30 
> minutes to 1h on my system, so I doubt it's really desirable.
> 
> A reduced file size is important because it will greatly reduce disk IO, 
> which is a bottle-neck we have.
> 
> 
> Diffs
> -
> 
>   optimize-svg.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126740/diff/
> 
> 
> Testing
> ---
> 
> ```
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 32M icons
> 32M icons-dark/
> 
> #run the script
> 
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 17M icons
> 17M icons-dark/
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126740: Add a script for optimizing svgs

[Aleix Pol Gonzalez]

> On Jan. 14, 2016, 11:27 a.m., Marco Martin wrote:
> > does the svg stuff still workk?
> > this script goes well together the others i have (only in plasma-framework 
> > atm) to remove the hardcoded colors inkscape likes to put even when an 
> > element is using the stylesheet and the one to replace hardcoded colors 
> > with classes of the stylesheet.
> > 
> > 
> > as for compressing: i was actually thinking of uncompressing the svgs in 
> > plasma-framework :p (mainly because git)
> > 
> > what needs to happen is probably the compression to svgz to be done at 
> > build time and have all simple svgs in the repository

What do you mean with "because git"? Because we might have the exact same 
problem with svgo then.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/#review91055
---


On Jan. 14, 2016, 4 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126740/
> ---
> 
> (Updated Jan. 14, 2016, 4 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea 
> that right now we're serving right away the svg's from inkscape and there's 
> room for improvement, potentially.
> 
> This patch just introduces a script that optimizes the svg's using `svgo`.
> 
> More could be done, like using gzip files, we can look into that if anyone's 
> interested. In fact, we used to use svgz for the icons, I wonder why that 
> changed. 
> 
> This will change the files in-place rather than as a build step, which is 
> what I considered first. The process to run svgo on every file was about 30 
> minutes to 1h on my system, so I doubt it's really desirable.
> 
> A reduced file size is important because it will greatly reduce disk IO, 
> which is a bottle-neck we have.
> 
> 
> Diffs
> -
> 
>   optimize-svg.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126740/diff/
> 
> 
> Testing
> ---
> 
> ```
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 32M icons
> 32M icons-dark/
> 
> #run the script
> 
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 17M icons
> 17M icons-dark/
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Imgur API v1 and v2 Deprecation Notice

[Aleix Pol]

On Thu, Jan 14, 2016 at 11:40 AM, Marco Martin  wrote:
> note i let this message trough the moderation as to make sure we take
> this into account as (i think?) we still have an imgur plugin in the
> new purpose thing, if it's still there/used, should be updated
>
> On Thu, Jan 14, 2016 at 12:12 AM, Imgur API  wrote:
>> Hi Imgur API user!
>>
>> It looks like you’re using version 1 or 2 of the Imgur API. We’re reaching
>> out now to let you know that, starting on March 28, 2016, these versions
>> will no longer be supported.
>>
>> We encourage you to migrate your application to Imgur API version 3 before
>> this date. If you need some assistance with that, feel free to check out
>> api.imgur.com for documentation. If your application uses authorization, you
>> will also need to upgrade to oauth 2.0.
>>
>> If you have any questions, we’d be happy to help at api+deprec...@imgur.com.
>>
>> Best,
>> The Imgur API team

Yes, it looks like the imgur plugin will need porting in Purpose. At
the moment is a 1:1 port of the old pastebin plasmoid imgur plugin.
:/

Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126719: tasks.svgz: Add "progress" frame

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126719/#review91060
---

Ship it!


No objections either.

- Eike Hein


On Jan. 11, 2016, 5:29 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126719/
> ---
> 
> (Updated Jan. 11, 2016, 5:29 p.m.)
> 
> 
> Review request for Plasma, KDE Usability, andreas kainz, and Ken Vermette.
> 
> 
> Description
> ---
> 
> This will be used by the new launcher stuff in Review 126621
> 
> If no "progress" frame is provided by the theme, the "hover" frame will be 
> used as fallback.
> 
> 
> Diffs
> -
> 
> 
> Diff: https://git.reviewboard.kde.org/r/126719/diff/
> 
> 
> Testing
> ---
> 
> Contrast could be better but I'm no Inkscape expert, I was lucky I managed to 
> colorize all of them using the green color provided by the "2+" badge and 
> align them to the pixel grid.
> 
> So if you designers want color changes, please do them yourself after this 
> file has been pushed :)
> 
> 
> File Attachments
> 
> 
> tasks.svgz
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/306d0b10-774b-4ff6-b98d-0dea8abf6882__tasks.svgz
> Progress in Task Manager
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/6fb37430-8f64-4d93-aa80-bfee88512179__unitylauncherblog.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Imgur API v1 and v2 Deprecation Notice

[Marco Martin]

note i let this message trough the moderation as to make sure we take
this into account as (i think?) we still have an imgur plugin in the
new purpose thing, if it's still there/used, should be updated

On Thu, Jan 14, 2016 at 12:12 AM, Imgur API  wrote:
> Hi Imgur API user!
>
> It looks like you’re using version 1 or 2 of the Imgur API. We’re reaching
> out now to let you know that, starting on March 28, 2016, these versions
> will no longer be supported.
>
> We encourage you to migrate your application to Imgur API version 3 before
> this date. If you need some assistance with that, feel free to check out
> api.imgur.com for documentation. If your application uses authorization, you
> will also need to upgrade to oauth 2.0.
>
> If you have any questions, we’d be happy to help at api+deprec...@imgur.com.
>
> Best,
> The Imgur API team
>
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126719: tasks.svgz: Add "progress" frame

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126719/#review91057
---

Ship it!


+2, make sure to run tools/currentcolorfix.sh on it

- Marco Martin


On Jan. 11, 2016, 5:29 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126719/
> ---
> 
> (Updated Jan. 11, 2016, 5:29 p.m.)
> 
> 
> Review request for Plasma, KDE Usability, andreas kainz, and Ken Vermette.
> 
> 
> Description
> ---
> 
> This will be used by the new launcher stuff in Review 126621
> 
> If no "progress" frame is provided by the theme, the "hover" frame will be 
> used as fallback.
> 
> 
> Diffs
> -
> 
> 
> Diff: https://git.reviewboard.kde.org/r/126719/diff/
> 
> 
> Testing
> ---
> 
> Contrast could be better but I'm no Inkscape expert, I was lucky I managed to 
> colorize all of them using the green color provided by the "2+" badge and 
> align them to the pixel grid.
> 
> So if you designers want color changes, please do them yourself after this 
> file has been pushed :)
> 
> 
> File Attachments
> 
> 
> tasks.svgz
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/306d0b10-774b-4ff6-b98d-0dea8abf6882__tasks.svgz
> Progress in Task Manager
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/6fb37430-8f64-4d93-aa80-bfee88512179__unitylauncherblog.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Imgur API v1 and v2 Deprecation Notice

[Imgur API]

Hi Imgur API user!

It looks like you’re using version 1 or 2 of the Imgur API. We’re reaching out now to let you know that, starting on March 28, 2016, these versions will no longer be supported.

We encourage you to migrate your application to Imgur API version 3 before this date. If you need some assistance with that, feel free to check out api.imgur.com for documentation. If your application uses authorization, you will also need to upgrade to oauth 2.0.

If you have any questions, we’d be happy to help at api+deprec...@imgur.com.

Best,
The Imgur API team
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Imgur API v1 and v2 Deprecation Notice

[Imgur API]

Hi Imgur API user!

It looks like you’re using version 1 or 2 of the Imgur API. We’re reaching out now to let you know that, starting on March 28, 2016, these versions will no longer be supported.

We encourage you to migrate your application to Imgur API version 3 before this date. If you need some assistance with that, feel free to check out api.imgur.com for documentation. If your application uses authorization, you will also need to upgrade to oauth 2.0.

If you have any questions, we’d be happy to help at api+deprec...@imgur.com.

Best,
The Imgur API team
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: robots.txt in quickgit.kde.org

[Kevin Funk]

On Wednesday, January 06, 2016 10:30:52 AM Ben Cooksley wrote:
> On Wed, Jan 6, 2016 at 3:17 AM, Kevin Funk  wrote:
> > On Wednesday, December 30, 2015 12:57:23 PM Ben Cooksley wrote:
> >> On Tue, Dec 29, 2015 at 11:16 PM, Kevin Funk  wrote:
> >> > On Tuesday, December 29, 2015 10:39:01 PM Ben Cooksley wrote:
> >> >> On Tue, Dec 29, 2015 at 7:59 AM, Lydia Pintscher  
wrote:
> >> >> > On Sun, Dec 27, 2015 at 12:35 PM, Ben Cooksley 
> > 
> > wrote:
> >> >> >>> Is there some place where search engines can easily index our
> >> >> >>> source
> >> >> >>> code or are we shooting ourselves in the foot here?
> >> >> >> 
> >> >> >> We could probably make it available by publishing the source trees
> >> >> >> used by LXR / EBN.
> >> >> >> This would only have the main branches obviously rather than
> >> >> >> everything
> >> >> >> though.
> >> >> >> 
> >> >> >> I haven't checked, but LXR may already make it's copy of the code
> >> >> >> accessible...>
> >> >> > 
> >> >> > I think making our sourcecode available to search engines is pretty
> >> >> > important for the reasons already mentioned by others. Do you need
> >> >> > help for it? If you write down what's needed I can help find someone
> >> >> > to do it.
> >> >> 
> >> >> I've now provisioned https://sources.kde.org/
> >> > 
> >> > I'm not sure this is super useful, to be honest (as mentioned in #kde-
> >> > sysadmins already).
> >> > 
> >> > This is really just plain file serving, with no cross-references to
> >> > either
> >> > LXR (or apidocs). This is basically a dead-end when you follow a result
> >> > on Google.
> >> > 
> >> > Wouldn't it be possible to let robots index https://lxr.kde.org/source/
> >> > 
> >> >  instead? We have the infrastructure...
> >> 
> >> We'll give it a shot.
> > 
> > Just to stress again this would be *really* useful to have.
> 
> 

Ah, I see robots.txt on lxr.kde.org allows crawling source/ now.

Thanks!
 
> > I answered a post on SO:
> >   http://stackoverflow.com/a/34612692/592636
> > 
> > Tried to link kwallet's FindGpgpme.cmake into the answer; and there's *no*
> > easy way quickly get a link to KDE infrastructure serving the file via
> > Google (not even api.kde.org).
> > 
> > Try googling for "kwallet findgpgme.cmake" (very specific search after 
all):
> >   https://www.google.de/search?q=kwallet+findgpgme.cmake
> > 
> > -> First result: Github..., rest: mildly interesting
> > 
> > 
> > Different issue I just noticed: There's no way to get the plain-text (raw)
> > representation of a given file on LXR, is there? Would be useful as well.
> 
> There isn't a link in our templates, but my Google fu (and subsequent
> tests confirm) that adding the parameter "_raw=1" to a LXR source view
> URL will return the file without any HTML around it.
> 
> > Cheers,
> > Kevin
> 
> Regards,
> Ben
> 
> >> > Of course we need to blacklist all the pages allowing to actively
> >> > *search*
> >> > LXR for robots, in order to avoid abuse.
> >> 
> >> Note that despite robots.txt, many spiders (including Google, Yahoo
> >> and Bing) will actively disregard the instructions in there.
> >> While they may not return the results - or omit snippets of the page
> >> content - they have all been guilty (at least in the past) of
> >> disregarding our restrictions, resulting in downtime (which have in
> >> some cases necessitated full host reboots to fix) for numerous KDE.org
> >> subsites in the past.
> >> 
> >> This is why QuickGit and WebSVN have extremely restrictive robots.txt
> >> policies, in addition to blacklist rules within our web server
> >> configurations.
> >> 
> >> > Cheers,
> >> > Kevin
> >> 
> >> Regards,
> >> Ben
> >> 
> >> >> > Cheers
> >> >> > Lydia
> >> >> 
> >> >> Regards,
> >> >> Ben
> >> >> 
> >> >> > --
> >> >> > Lydia Pintscher - http://about.me/lydia.pintscher
> >> >> > KDE e.V. Board of Directors / KDE Community Working Group
> >> >> > http://kde.org - http://open-advice.org
> >> >> > 
> >> >> >>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> >> >> >>> unsubscribe <<>>
> >> >> >> 
> >> >> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> >> >> >> unsubscribe
> >> >> >> <<
> >> > 
> >> > --
> >> > Kevin Funk | kf...@kde.org | http://kfunk.org
> > 
> > --
> > Kevin Funk | kf...@kde.org | http://kfunk.org

-- 
Kevin Funk | kf...@kde.org | http://kfunk.org

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[PATCH] Mobile components: use back button to close global and context drawers

[Rick Walsh]

ApplicationWindow catches Qt.Key_Back. By using it to close the global and
context drawers ahead of stackView.pop(), we get expected behaviour in
Subsurface-mobile, similar to other apps.

Signed-off-by: Rick Walsh 
---

Sebastian,
You said you'd rather any changes to qt-mobile/qml/mobilecomponents/* are made 
upstream, so I'm sending this patch to you as well as the Subsurface list. I 
couldn't find a tidy way to make the drawers close with the back button without 
touching qt-mobile/qml/mobilecomponents/. Of course, you are much more familiar 
with the code than I am, and may know a better way to achieve the same goal.

Rick

qt-mobile/qml/mobilecomponents/ApplicationWindow.qml | 14 +++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/qt-mobile/qml/mobilecomponents/ApplicationWindow.qml 
b/qt-mobile/qml/mobilecomponents/ApplicationWindow.qml
index 0eaa81e..911f885 100644
--- a/qt-mobile/qml/mobilecomponents/ApplicationWindow.qml
+++ b/qt-mobile/qml/mobilecomponents/ApplicationWindow.qml
@@ -65,9 +65,17 @@ inputMethod.keyboardRectangle.y) : 0
 }
 focus: true
 Keys.onReleased: {
-if (event.key == Qt.Key_Back && stackView.depth > 1) {
-stackView.pop();
-event.accepted = true;
+if (event.key == Qt.Key_Back) {
+if (root.contextDrawer && root.contextDrawer.opened) {
+root.contextDrawer.close();
+event.accepted = true;
+} else if (root.globalDrawer && root.globalDrawer.opened) {
+root.globalDrawer.close();
+event.accepted = true;
+} else if (stackView.depth > 1) {
+stackView.pop();
+event.accepted = true;
+}
 }
 }
 }
-- 
2.5.0

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: robots.txt in quickgit.kde.org

[Kevin Funk]

On Tuesday, December 29, 2015 10:39:01 PM Ben Cooksley wrote:
> On Tue, Dec 29, 2015 at 7:59 AM, Lydia Pintscher  wrote:
> > On Sun, Dec 27, 2015 at 12:35 PM, Ben Cooksley  wrote:
> >>> Is there some place where search engines can easily index our source
> >>> code or are we shooting ourselves in the foot here?
> >> 
> >> We could probably make it available by publishing the source trees
> >> used by LXR / EBN.
> >> This would only have the main branches obviously rather than everything
> >> though.
> >> 
> >> I haven't checked, but LXR may already make it's copy of the code
> >> accessible...> 
> > I think making our sourcecode available to search engines is pretty
> > important for the reasons already mentioned by others. Do you need
> > help for it? If you write down what's needed I can help find someone
> > to do it.
> 
> I've now provisioned https://sources.kde.org/

I'm not sure this is super useful, to be honest (as mentioned in #kde-
sysadmins already).

This is really just plain file serving, with no cross-references to either LXR 
(or apidocs). This is basically a dead-end when you follow a result on Google.

Wouldn't it be possible to let robots index https://lxr.kde.org/source/
 instead? We have the infrastructure...

Of course we need to blacklist all the pages allowing to actively *search* LXR 
for robots, in order to avoid abuse.

Cheers,
Kevin

> > Cheers
> > Lydia
> 
> Regards,
> Ben
> 
> > --
> > Lydia Pintscher - http://about.me/lydia.pintscher
> > KDE e.V. Board of Directors / KDE Community Working Group
> > http://kde.org - http://open-advice.org
> > 
> >>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> >>> unsubscribe <<>> 
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
> >> <<

-- 
Kevin Funk | kf...@kde.org | http://kfunk.org

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: robots.txt in quickgit.kde.org

[Kevin Funk]

On Wednesday, December 30, 2015 12:57:23 PM Ben Cooksley wrote:
> On Tue, Dec 29, 2015 at 11:16 PM, Kevin Funk  wrote:
> > On Tuesday, December 29, 2015 10:39:01 PM Ben Cooksley wrote:
> >> On Tue, Dec 29, 2015 at 7:59 AM, Lydia Pintscher  wrote:
> >> > On Sun, Dec 27, 2015 at 12:35 PM, Ben Cooksley  
wrote:
> >> >>> Is there some place where search engines can easily index our source
> >> >>> code or are we shooting ourselves in the foot here?
> >> >> 
> >> >> We could probably make it available by publishing the source trees
> >> >> used by LXR / EBN.
> >> >> This would only have the main branches obviously rather than
> >> >> everything
> >> >> though.
> >> >> 
> >> >> I haven't checked, but LXR may already make it's copy of the code
> >> >> accessible...>
> >> > 
> >> > I think making our sourcecode available to search engines is pretty
> >> > important for the reasons already mentioned by others. Do you need
> >> > help for it? If you write down what's needed I can help find someone
> >> > to do it.
> >> 
> >> I've now provisioned https://sources.kde.org/
> > 
> > I'm not sure this is super useful, to be honest (as mentioned in #kde-
> > sysadmins already).
> > 
> > This is really just plain file serving, with no cross-references to either
> > LXR (or apidocs). This is basically a dead-end when you follow a result
> > on Google.
> > 
> > Wouldn't it be possible to let robots index https://lxr.kde.org/source/
> > 
> >  instead? We have the infrastructure...
> 
> We'll give it a shot.

Just to stress again this would be *really* useful to have.

I answered a post on SO:
  http://stackoverflow.com/a/34612692/592636

Tried to link kwallet's FindGpgpme.cmake into the answer; and there's *no* 
easy way quickly get a link to KDE infrastructure serving the file via Google 
(not even api.kde.org).

Try googling for "kwallet findgpgme.cmake" (very specific search after all):
  https://www.google.de/search?q=kwallet+findgpgme.cmake

-> First result: Github..., rest: mildly interesting


Different issue I just noticed: There's no way to get the plain-text (raw) 
representation of a given file on LXR, is there? Would be useful as well.

Cheers,
Kevin

> > Of course we need to blacklist all the pages allowing to actively *search*
> > LXR for robots, in order to avoid abuse.
> 
> Note that despite robots.txt, many spiders (including Google, Yahoo
> and Bing) will actively disregard the instructions in there.
> While they may not return the results - or omit snippets of the page
> content - they have all been guilty (at least in the past) of
> disregarding our restrictions, resulting in downtime (which have in
> some cases necessitated full host reboots to fix) for numerous KDE.org
> subsites in the past.
> 
> This is why QuickGit and WebSVN have extremely restrictive robots.txt
> policies, in addition to blacklist rules within our web server
> configurations.
> 
> > Cheers,
> > Kevin
> 
> Regards,
> Ben
> 
> >> > Cheers
> >> > Lydia
> >> 
> >> Regards,
> >> Ben
> >> 
> >> > --
> >> > Lydia Pintscher - http://about.me/lydia.pintscher
> >> > KDE e.V. Board of Directors / KDE Community Working Group
> >> > http://kde.org - http://open-advice.org
> >> > 
> >> >>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> >> >>> unsubscribe <<>>
> >> >> 
> >> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> >> >> unsubscribe
> >> >> <<
> > 
> > --
> > Kevin Funk | kf...@kde.org | http://kfunk.org

-- 
Kevin Funk | kf...@kde.org | http://kfunk.org

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126740: Add a script for optimizing svgs

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/#review91055
---


does the svg stuff still workk?
this script goes well together the others i have (only in plasma-framework atm) 
to remove the hardcoded colors inkscape likes to put even when an element is 
using the stylesheet and the one to replace hardcoded colors with classes of 
the stylesheet.


as for compressing: i was actually thinking of uncompressing the svgs in 
plasma-framework :p (mainly because git)

what needs to happen is probably the compression to svgz to be done at build 
time and have all simple svgs in the repository

- Marco Martin


On Jan. 14, 2016, 3 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126740/
> ---
> 
> (Updated Jan. 14, 2016, 3 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea 
> that right now we're serving right away the svg's from inkscape and there's 
> room for improvement, potentially.
> 
> This patch just introduces a script that optimizes the svg's using `svgo`.
> 
> More could be done, like using gzip files, we can look into that if anyone's 
> interested. In fact, we used to use svgz for the icons, I wonder why that 
> changed. 
> 
> This will change the files in-place rather than as a build step, which is 
> what I considered first. The process to run svgo on every file was about 30 
> minutes to 1h on my system, so I doubt it's really desirable.
> 
> A reduced file size is important because it will greatly reduce disk IO, 
> which is a bottle-neck we have.
> 
> 
> Diffs
> -
> 
>   optimize-svg.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126740/diff/
> 
> 
> Testing
> ---
> 
> ```
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 32M icons
> 32M icons-dark/
> 
> #run the script
> 
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 17M icons
> 17M icons-dark/
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel