Re: Review Request 126994: Drop usage of Qt4Support

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126994/#review92108
---




dataengines/CMakeLists.txt (line 30)


?



libtaskmanager/groupmanager.cpp (line 1043)


this could break if l->launcherUrl() contains an existing query.

Old code appended, new version replaces.



runners/bookmarks/tests/testchromebookmarks.cpp (line 76)


I know it's not your code, but .arg().arg() is generally wrong.


- David Edmundson


On Feb. 5, 2016, 8:16 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126994/
> ---
> 
> (Updated Feb. 5, 2016, 8:16 p.m.)
> 
> 
> Review request for Plasma and René J.V. Bertin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> As I saw in another RR, the simple fact of using KDELibs4Support in part of a 
> project makes the whole project rely on Qt4Support. That's bad especially in 
> cases where KDELibs4Support is optional, because it will lead to 
> unpredictable results.
> 
> 
> Diffs
> -
> 
>   applets/systemtray/plugin/host.cpp e529aeb 
>   components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels.cpp 
> cba87ec 
>   components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels_p.h 
> e9d7ef3 
>   components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp 8a5ba91 
>   components/shellprivate/widgetexplorer/plasmaappletitemmodel_p.h 20fb98e 
>   components/shellprivate/widgetexplorer/widgetexplorer.cpp 7816614 
>   dataengines/CMakeLists.txt 9ee93d8 
>   dataengines/dict/dictengine.cpp d851268 
>   dataengines/mpris2/mpris2engine.h ea49515 
>   dataengines/mpris2/multiplexedservice.h 2ab4e6b 
>   dataengines/mpris2/playercontainer.cpp 6c4c875 
>   dataengines/share/shareprovider.cpp ac66fd3 
>   dataengines/statusnotifieritem/statusnotifieritemsource.cpp 097f110 
>   drkonqi/bugzillaintegration/bugzillalib.cpp 802c5fb 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp e60fb14 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp 
> 4f8f4ea 
>   drkonqi/drkonqi.cpp b12c118 
>   libtaskmanager/abstractgroupableitem.cpp 9b86cf1 
>   libtaskmanager/groupmanager.cpp 12b18b0 
>   libtaskmanager/strategies/manualgroupingstrategy.cpp b37ac35 
>   libtaskmanager/strategies/programgroupingstrategy.cpp 6b91bfe 
>   libtaskmanager/taskactions.cpp d1ddf9c 
>   libtaskmanager/taskactions_p.h 535ea5f 
>   libtaskmanager/taskitem.cpp 3b2a418 
>   libtaskmanager/tasksmodel.h 8decf0b 
>   libtaskmanager/tasksmodel.cpp 0abdd93 
>   runners/bookmarks/faviconfromblob.cpp 540db9c 
>   runners/bookmarks/tests/testchromebookmarks.cpp 718e765 
>   shell/currentcontainmentactionsmodel.h 0c27a20 
>   shell/currentcontainmentactionsmodel.cpp d442985 
>   shell/kidenticongenerator.cpp 4e4b25a 
>   shell/panelview.cpp 0eaf553 
>   shell/scripting/backportglobal.h 988b14e 
>   shell/scripting/containment.cpp 5e42bee 
>   shell/scripting/widget.cpp 984e666 
>   wallpapers/image/backgroundlistmodel.h d639b03 
>   wallpapers/image/backgroundlistmodel.cpp b4f81da 
>   wallpapers/image/image.h 295ba22 
> 
> Diff: https://git.reviewboard.kde.org/r/126994/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126870/
---

(Updated Фев. 6, 2016, 9:19 преди обяд)


Status
--

This change has been discarded.


Review request for KDE Frameworks, Plasma and David Edmundson.


Bugs: 354353
http://bugs.kde.org/show_bug.cgi?id=354353


Repository: plasma-framework


Description
---

Continous usage, read as suspend/resume/use and so on, cause *cool* tooltip 
animation transition between item to decrease it permormance and looks quite 
ugly. If add new panel animation is *cool* as is. The perfermonce decrease can 
be cause due to swap use, or QPropertyAnimation issue, however we (you KDE defs 
and i *like a user*) wants plasmashell and it's components (like panel) to 
works *forever*


Diffs
-

  src/declarativeimports/core/tooltip.cpp a5e223b 
  src/declarativeimports/core/tooltipdialog.h 2ea8af9 
  src/declarativeimports/core/tooltipdialog.cpp 6c3712e 

Diff: https://git.reviewboard.kde.org/r/126870/diff/


Testing
---

Workaround is quite simple:
Animation is refreshed as is, pointer hasn't same lifetime as panel
+ Animation is disabled if compositing is not active


Thanks,

Anthony Fieroni

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126993: drkonqi : fix build errors and build nongui

[Martin Gräßlin]

> On Feb. 5, 2016, 3:57 p.m., Martin Gräßlin wrote:
> > drkonqi/drkonqi.cpp, lines 183-188
> > 
> >
> > yes this is possible and there is even a Krazy check for this. The 
> > QWeakPointer is the proper fix to this problem.
> > 
> > What exactly was the compile issue you run into with the QWeakPointer?
> > 
> > I assume that:
> >QWeakPointer dlg(new QFileDialog(parent, defname));
> > 
> > would solve your compile error.

found the explanation: 
https://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126993/#review92090
---


On Feb. 5, 2016, 3:13 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126993/
> ---
> 
> (Updated Feb. 5, 2016, 3:13 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> While looking to build DrKonqi for OS X/MacPorts I came across a few issues 
> that appear to be syntax/coding errors that, surprisingly, were never caught 
> before given that they also caused compile failures when I used the same 
> configure/build/packaging script on Linux.
> 
> The code uses methods that no longer exist in Qt 5.5+ : 
> `QString::fromAscii()`, `QHeaderView::setResizeMod()` (replaced with 
> `QHeaderView::setSectionResizeMode()` and `QInputDialog::getInteger()` 
> (instead of `QInputDialog::getInt()`). Those are the easy and straightforward 
> ones fixed by this patch.
> 
> The handling of file dialogs (in 2 locations) was more problematic. Both 
> Apple's clang "6.0.0" and gcc 5.3 (on Linux) refused statements like 
> `QWeakPointer dlg = new QFileDialog(parent,defname);` . My 
> initial attempt was to follow the documentation for QWeakPointer, and do 
> `QWeakPointer dlg = QSharedPointer(new 
> QFileDialog(parent,defname));` but that caused a crash as soon as I clicked 
> on the "save backtrace as" button - on both platforms.
> It turned out that `QSharedPointer()` returned a valid 
> (non-null) shared pointer, but after creating a QWeakPointer from it, 
> `dlg.data()` returned NULL -- immediately.
> 
> I had a look around in the 5.17.0 frameworks codebase, and could find no 
> relevant examples of using QWeakPointer; some expressions appear to be 
> equivalent to the original DrKonqi code, in other locations QWeakPointer 
> instances are indeed created "going through" a QSharedPointer. In the end I 
> tested using QFileDialog (and `QFileDialog::selectedUrls()` as kate5 does, 
> and that works (on OS X and Linux).
> 
> That's what the attached patch does: no QFileDialog pointer at all, just an 
> instance.
> This RR is intended to fuel a discussion on the subject, as suggested by 
> Aleix; therefore I left the comment about the possibility of 
> invalidating/deleting the file dialog e.g. through a DBus call. Is that 
> actually a possibility, and why wouldn't it be in Kate? Are there no other 
> ways to prevent it, or check for its occurrence?
> 
> This patch also marks drkonqi as a nongui executable, a requirement on OS X 
> and which shouldn't cause any regressions elsewhere AFAIK.
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt deb8c40 
>   drkonqi/bugzillaintegration/bugzillalib.cpp 802c5fb 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp e60fb14 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp 
> 4f8f4ea 
>   drkonqi/drkonqi.cpp b12c118 
> 
> Diff: https://git.reviewboard.kde.org/r/126993/diff/
> 
> 
> Testing
> ---
> 
> On OS X 10.9.1 and Kubuntu 14.04, both with Qt 5.5.1 and KF5 5.17.0 installed 
> into /opt/local
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126993: drkonqi : fix build errors and build nongui

[René J . V . Bertin]

> On Feb. 5, 2016, 3:57 p.m., Martin Gräßlin wrote:
> > drkonqi/drkonqi.cpp, lines 183-188
> > 
> >
> > yes this is possible and there is even a Krazy check for this. The 
> > QWeakPointer is the proper fix to this problem.
> > 
> > What exactly was the compile issue you run into with the QWeakPointer?
> > 
> > I assume that:
> >QWeakPointer dlg(new QFileDialog(parent, defname));
> > 
> > would solve your compile error.
> 
> Martin Gräßlin wrote:
> found the explanation: 
> https://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0

Ah, yes, I have already seen similar situations where the possibiity of using 
the Quit menu on OS X was clearly something that the application didn't 
foresee. I must admit I have been shrugging that off.

According to Frank's blog:

```
If was deleted during the exec(), exec() will return QDialog::Rejected.
```

Isn't that still the case? I was counting on it, and if it is true my 
modification should be fine (and have the advantage of being less complex). The 
code doesn't use `dlg` if `exec()` returned anything other than 
`QDialog::Accepted`.

Also: DrKonqi doesn't seem to register on the DBus at all. At least not under 
its own name (there's just a ToDo note about implementing a proper DBus 
interface, who knows how old).


- René J.V.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126993/#review92090
---


On Feb. 5, 2016, 3:13 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126993/
> ---
> 
> (Updated Feb. 5, 2016, 3:13 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> While looking to build DrKonqi for OS X/MacPorts I came across a few issues 
> that appear to be syntax/coding errors that, surprisingly, were never caught 
> before given that they also caused compile failures when I used the same 
> configure/build/packaging script on Linux.
> 
> The code uses methods that no longer exist in Qt 5.5+ : 
> `QString::fromAscii()`, `QHeaderView::setResizeMod()` (replaced with 
> `QHeaderView::setSectionResizeMode()` and `QInputDialog::getInteger()` 
> (instead of `QInputDialog::getInt()`). Those are the easy and straightforward 
> ones fixed by this patch.
> 
> The handling of file dialogs (in 2 locations) was more problematic. Both 
> Apple's clang "6.0.0" and gcc 5.3 (on Linux) refused statements like 
> `QWeakPointer dlg = new QFileDialog(parent,defname);` . My 
> initial attempt was to follow the documentation for QWeakPointer, and do 
> `QWeakPointer dlg = QSharedPointer(new 
> QFileDialog(parent,defname));` but that caused a crash as soon as I clicked 
> on the "save backtrace as" button - on both platforms.
> It turned out that `QSharedPointer()` returned a valid 
> (non-null) shared pointer, but after creating a QWeakPointer from it, 
> `dlg.data()` returned NULL -- immediately.
> 
> I had a look around in the 5.17.0 frameworks codebase, and could find no 
> relevant examples of using QWeakPointer; some expressions appear to be 
> equivalent to the original DrKonqi code, in other locations QWeakPointer 
> instances are indeed created "going through" a QSharedPointer. In the end I 
> tested using QFileDialog (and `QFileDialog::selectedUrls()` as kate5 does, 
> and that works (on OS X and Linux).
> 
> That's what the attached patch does: no QFileDialog pointer at all, just an 
> instance.
> This RR is intended to fuel a discussion on the subject, as suggested by 
> Aleix; therefore I left the comment about the possibility of 
> invalidating/deleting the file dialog e.g. through a DBus call. Is that 
> actually a possibility, and why wouldn't it be in Kate? Are there no other 
> ways to prevent it, or check for its occurrence?
> 
> This patch also marks drkonqi as a nongui executable, a requirement on OS X 
> and which shouldn't cause any regressions elsewhere AFAIK.
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt deb8c40 
>   drkonqi/bugzillaintegration/bugzillalib.cpp 802c5fb 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp e60fb14 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp 
> 4f8f4ea 
>   drkonqi/drkonqi.cpp b12c118 
> 
> Diff: https://git.reviewboard.kde.org/r/126993/diff/
> 
> 
> Testing
> ---
> 
> On OS X 10.9.1 and Kubuntu 14.04, both with Qt 5.5.1 and KF5 5.17.0 installed 
> into /opt/local
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

___
Plasma-devel 

Re: Review Request 126993: drkonqi : fix build errors and build nongui

[Aleix Pol Gonzalez]

> On Feb. 5, 2016, 3:57 p.m., Martin Gräßlin wrote:
> > drkonqi/drkonqi.cpp, lines 183-188
> > 
> >
> > yes this is possible and there is even a Krazy check for this. The 
> > QWeakPointer is the proper fix to this problem.
> > 
> > What exactly was the compile issue you run into with the QWeakPointer?
> > 
> > I assume that:
> >QWeakPointer dlg(new QFileDialog(parent, defname));
> > 
> > would solve your compile error.
> 
> Martin Gräßlin wrote:
> found the explanation: 
> https://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0
> 
> René J.V. Bertin wrote:
> Ah, yes, I have already seen similar situations where the possibiity of 
> using the Quit menu on OS X was clearly something that the application didn't 
> foresee. I must admit I have been shrugging that off.
> 
> According to Frank's blog:
> 
> ```
> If was deleted during the exec(), exec() will return QDialog::Rejected.
> ```
> 
> Isn't that still the case? I was counting on it, and if it is true my 
> modification should be fine (and have the advantage of being less complex). 
> The code doesn't use `dlg` if `exec()` returned anything other than 
> `QDialog::Accepted`.
> 
> Also: DrKonqi doesn't seem to register on the DBus at all. At least not 
> under its own name (there's just a ToDo note about implementing a proper DBus 
> interface, who knows how old).
> 
> René J.V. Bertin wrote:
> To answer the question: I don't have the exact error message anymore, but 
> it was about an impossible assignment because of a missing ctor.
> 
> As to your assumed fix: looks like it gives just about the same error as 
> the original code did:
> 
> ```
> cd $build.dir && /usr/bin/c++   -DKCOREADDONS_LIB 
> -DKDE_DEFAULT_DEBUG_AREA=1410 -DPROJECT_VERSION=\"5.5.4\" -DQT_CORE_LIB 
> -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_X11EXTRAS_LIB 
> -DQT_XML_LIB -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I -isystem 
> /opt/local/include/KF5/KI18n -isystem /opt/local/include/KF5 -isystem 
> /opt/local/include/qt5 -isystem /opt/local/include/qt5/QtCore -isystem 
> /opt/local/share/qt5/mkspecs/linux-g++-64 -isystem 
> /opt/local/include/KF5/KCoreAddons -isystem /opt/local/include/KF5/KService 
> -isystem /opt/local/include/KF5/KConfigCore -isystem 
> /opt/local/include/KF5/KConfigWidgets -isystem /opt/local/include/KF5/KCodecs 
> -isystem /opt/local/include/KF5/KWidgetsAddons -isystem 
> /opt/local/include/qt5/QtWidgets -isystem /opt/local/include/qt5/QtGui 
> -isystem /opt/local/include/KF5/KConfigGui -isystem 
> /opt/local/include/qt5/QtXml -isystem /opt/local/include/KF5/KAuth -isystem 
> /opt/local/include/KF5/KJobWidgets -isystem /opt/local/include/KF5/KI
 OCore -isystem /opt/local/include/KF5/KCrash -isystem 
/opt/local/include/KF5/KCompletion -isystem /opt/local/include/qt5/QtDBus 
-isystem /opt/local/include/KF5/KXmlRpcClient -isystem 
/opt/local/include/KF5/KXmlRpcClient/kxmlrpcclient -isystem 
/opt/local/include/KF5/KWallet -isystem /opt/local/include/qt5/QtX11Extras  -O3 
-march=native -g -DNDEBUG  -std=c++0x -fno-exceptions -Wall -Wextra 
-Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith 
-Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type   -fPIC -o 
CMakeFiles/drkonqi.dir/drkonqi.cpp.o -c 
/.../plasma-workspace-5.5.4/drkonqi/drkonqi.cpp
> /.../plasma-workspace-5.5.4/drkonqi/drkonqi.cpp:169:71: error: no 
> matching function for call to 
> ‘QWeakPointer::QWeakPointer(QFileDialog*)’
>  QWeakPointer dlg(new QFileDialog(parent, defname));
>^
> In file included from /opt/local/include/qt5/QtCore/qsharedpointer.h:42:0,
>  from /opt/local/include/qt5/QtCore/QWeakPointer:1,
>  from /.../plasma-workspace-5.5.4/drkonqi/drkonqi.cpp:44:
> /opt/local/include/qt5/QtCore/qsharedpointer_impl.h:696:12: note: 
> candidate: template QWeakPointer::QWeakPointer(X*, bool)
>  inline QWeakPointer(X *ptr, bool) : d(ptr ? Data::getAndRef(ptr) : 
> 0), value(ptr)
> 
> ```

Use QPointer.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126993/#review92090
---


On Feb. 5, 2016, 3:13 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126993/
> ---
> 
> (Updated Feb. 5, 2016, 3:13 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> 

Re: Review Request 126993: drkonqi : fix build errors and build nongui

[René J . V . Bertin]

> On Feb. 5, 2016, 3:57 p.m., Martin Gräßlin wrote:
> > drkonqi/drkonqi.cpp, lines 183-188
> > 
> >
> > yes this is possible and there is even a Krazy check for this. The 
> > QWeakPointer is the proper fix to this problem.
> > 
> > What exactly was the compile issue you run into with the QWeakPointer?
> > 
> > I assume that:
> >QWeakPointer dlg(new QFileDialog(parent, defname));
> > 
> > would solve your compile error.
> 
> Martin Gräßlin wrote:
> found the explanation: 
> https://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0
> 
> René J.V. Bertin wrote:
> Ah, yes, I have already seen similar situations where the possibiity of 
> using the Quit menu on OS X was clearly something that the application didn't 
> foresee. I must admit I have been shrugging that off.
> 
> According to Frank's blog:
> 
> ```
> If was deleted during the exec(), exec() will return QDialog::Rejected.
> ```
> 
> Isn't that still the case? I was counting on it, and if it is true my 
> modification should be fine (and have the advantage of being less complex). 
> The code doesn't use `dlg` if `exec()` returned anything other than 
> `QDialog::Accepted`.
> 
> Also: DrKonqi doesn't seem to register on the DBus at all. At least not 
> under its own name (there's just a ToDo note about implementing a proper DBus 
> interface, who knows how old).

To answer the question: I don't have the exact error message anymore, but it 
was about an impossible assignment because of a missing ctor.

As to your assumed fix: looks like it gives just about the same error as the 
original code did:

```
cd $build.dir && /usr/bin/c++   -DKCOREADDONS_LIB -DKDE_DEFAULT_DEBUG_AREA=1410 
-DPROJECT_VERSION=\"5.5.4\" -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB 
-DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_X11EXTRAS_LIB -DQT_XML_LIB -D_GNU_SOURCE 
-D_LARGEFILE64_SOURCE -I -isystem /opt/local/include/KF5/KI18n 
-isystem /opt/local/include/KF5 -isystem /opt/local/include/qt5 -isystem 
/opt/local/include/qt5/QtCore -isystem 
/opt/local/share/qt5/mkspecs/linux-g++-64 -isystem 
/opt/local/include/KF5/KCoreAddons -isystem /opt/local/include/KF5/KService 
-isystem /opt/local/include/KF5/KConfigCore -isystem 
/opt/local/include/KF5/KConfigWidgets -isystem /opt/local/include/KF5/KCodecs 
-isystem /opt/local/include/KF5/KWidgetsAddons -isystem 
/opt/local/include/qt5/QtWidgets -isystem /opt/local/include/qt5/QtGui -isystem 
/opt/local/include/KF5/KConfigGui -isystem /opt/local/include/qt5/QtXml 
-isystem /opt/local/include/KF5/KAuth -isystem 
/opt/local/include/KF5/KJobWidgets -isystem /opt/local/include/KF5/KIOCore 
 -isystem /opt/local/include/KF5/KCrash -isystem 
/opt/local/include/KF5/KCompletion -isystem /opt/local/include/qt5/QtDBus 
-isystem /opt/local/include/KF5/KXmlRpcClient -isystem 
/opt/local/include/KF5/KXmlRpcClient/kxmlrpcclient -isystem 
/opt/local/include/KF5/KWallet -isystem /opt/local/include/qt5/QtX11Extras  -O3 
-march=native -g -DNDEBUG  -std=c++0x -fno-exceptions -Wall -Wextra 
-Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith 
-Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type   -fPIC -o 
CMakeFiles/drkonqi.dir/drkonqi.cpp.o -c 
/.../plasma-workspace-5.5.4/drkonqi/drkonqi.cpp
/.../plasma-workspace-5.5.4/drkonqi/drkonqi.cpp:169:71: error: no matching 
function for call to ‘QWeakPointer::QWeakPointer(QFileDialog*)’
 QWeakPointer dlg(new QFileDialog(parent, defname));
   ^
In file included from /opt/local/include/qt5/QtCore/qsharedpointer.h:42:0,
 from /opt/local/include/qt5/QtCore/QWeakPointer:1,
 from /.../plasma-workspace-5.5.4/drkonqi/drkonqi.cpp:44:
/opt/local/include/qt5/QtCore/qsharedpointer_impl.h:696:12: note: candidate: 
template QWeakPointer::QWeakPointer(X*, bool)
 inline QWeakPointer(X *ptr, bool) : d(ptr ? Data::getAndRef(ptr) : 0), 
value(ptr)

```


- René J.V.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126993/#review92090
---


On Feb. 5, 2016, 3:13 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126993/
> ---
> 
> (Updated Feb. 5, 2016, 3:13 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> While looking to build DrKonqi for OS X/MacPorts I came across a few issues 
> that appear to be syntax/coding errors that, surprisingly, were never 

Re: Review Request 126993: drkonqi : fix build errors and build nongui

[René J . V . Bertin]

> On Feb. 5, 2016, 3:57 p.m., Martin Gräßlin wrote:
> > drkonqi/drkonqi.cpp, lines 183-188
> > 
> >
> > yes this is possible and there is even a Krazy check for this. The 
> > QWeakPointer is the proper fix to this problem.
> > 
> > What exactly was the compile issue you run into with the QWeakPointer?
> > 
> > I assume that:
> >QWeakPointer dlg(new QFileDialog(parent, defname));
> > 
> > would solve your compile error.
> 
> Martin Gräßlin wrote:
> found the explanation: 
> https://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0
> 
> René J.V. Bertin wrote:
> Ah, yes, I have already seen similar situations where the possibiity of 
> using the Quit menu on OS X was clearly something that the application didn't 
> foresee. I must admit I have been shrugging that off.
> 
> According to Frank's blog:
> 
> ```
> If was deleted during the exec(), exec() will return QDialog::Rejected.
> ```
> 
> Isn't that still the case? I was counting on it, and if it is true my 
> modification should be fine (and have the advantage of being less complex). 
> The code doesn't use `dlg` if `exec()` returned anything other than 
> `QDialog::Accepted`.
> 
> Also: DrKonqi doesn't seem to register on the DBus at all. At least not 
> under its own name (there's just a ToDo note about implementing a proper DBus 
> interface, who knows how old).
> 
> René J.V. Bertin wrote:
> To answer the question: I don't have the exact error message anymore, but 
> it was about an impossible assignment because of a missing ctor.
> 
> As to your assumed fix: looks like it gives just about the same error as 
> the original code did:
> 
> ```
> cd $build.dir && /usr/bin/c++   -DKCOREADDONS_LIB 
> -DKDE_DEFAULT_DEBUG_AREA=1410 -DPROJECT_VERSION=\"5.5.4\" -DQT_CORE_LIB 
> -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_X11EXTRAS_LIB 
> -DQT_XML_LIB -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I -isystem 
> /opt/local/include/KF5/KI18n -isystem /opt/local/include/KF5 -isystem 
> /opt/local/include/qt5 -isystem /opt/local/include/qt5/QtCore -isystem 
> /opt/local/share/qt5/mkspecs/linux-g++-64 -isystem 
> /opt/local/include/KF5/KCoreAddons -isystem /opt/local/include/KF5/KService 
> -isystem /opt/local/include/KF5/KConfigCore -isystem 
> /opt/local/include/KF5/KConfigWidgets -isystem /opt/local/include/KF5/KCodecs 
> -isystem /opt/local/include/KF5/KWidgetsAddons -isystem 
> /opt/local/include/qt5/QtWidgets -isystem /opt/local/include/qt5/QtGui 
> -isystem /opt/local/include/KF5/KConfigGui -isystem 
> /opt/local/include/qt5/QtXml -isystem /opt/local/include/KF5/KAuth -isystem 
> /opt/local/include/KF5/KJobWidgets -isystem /opt/local/include/KF5/KI
 OCore -isystem /opt/local/include/KF5/KCrash -isystem 
/opt/local/include/KF5/KCompletion -isystem /opt/local/include/qt5/QtDBus 
-isystem /opt/local/include/KF5/KXmlRpcClient -isystem 
/opt/local/include/KF5/KXmlRpcClient/kxmlrpcclient -isystem 
/opt/local/include/KF5/KWallet -isystem /opt/local/include/qt5/QtX11Extras  -O3 
-march=native -g -DNDEBUG  -std=c++0x -fno-exceptions -Wall -Wextra 
-Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith 
-Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type   -fPIC -o 
CMakeFiles/drkonqi.dir/drkonqi.cpp.o -c 
/.../plasma-workspace-5.5.4/drkonqi/drkonqi.cpp
> /.../plasma-workspace-5.5.4/drkonqi/drkonqi.cpp:169:71: error: no 
> matching function for call to 
> ‘QWeakPointer::QWeakPointer(QFileDialog*)’
>  QWeakPointer dlg(new QFileDialog(parent, defname));
>^
> In file included from /opt/local/include/qt5/QtCore/qsharedpointer.h:42:0,
>  from /opt/local/include/qt5/QtCore/QWeakPointer:1,
>  from /.../plasma-workspace-5.5.4/drkonqi/drkonqi.cpp:44:
> /opt/local/include/qt5/QtCore/qsharedpointer_impl.h:696:12: note: 
> candidate: template QWeakPointer::QWeakPointer(X*, bool)
>  inline QWeakPointer(X *ptr, bool) : d(ptr ? Data::getAndRef(ptr) : 
> 0), value(ptr)
> 
> ```
> 
> Aleix Pol Gonzalez wrote:
> Use QPointer.

QPointer . Yes, that seems to work.

Let's say that this code will be ready the day someone implements that 
org.kde.drkonqi service ...


- René J.V.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126993/#review92090
---


On Feb. 5, 2016, 3:13 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126993/
> 

Re: Review Request 126993: drkonqi : fix build errors and build nongui

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126993/#review92090
---




drkonqi/drkonqi.cpp (lines 179 - 184)


yes this is possible and there is even a Krazy check for this. The 
QWeakPointer is the proper fix to this problem.

What exactly was the compile issue you run into with the QWeakPointer?

I assume that:
   QWeakPointer dlg(new QFileDialog(parent, defname));

would solve your compile error.


- Martin Gräßlin


On Feb. 5, 2016, 3:13 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126993/
> ---
> 
> (Updated Feb. 5, 2016, 3:13 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> While looking to build DrKonqi for OS X/MacPorts I came across a few issues 
> that appear to be syntax/coding errors that, surprisingly, were never caught 
> before given that they also caused compile failures when I used the same 
> configure/build/packaging script on Linux.
> 
> The code uses methods that no longer exist in Qt 5.5+ : 
> `QString::fromAscii()`, `QHeaderView::setResizeMod()` (replaced with 
> `QHeaderView::setSectionResizeMode()` and `QInputDialog::getInteger()` 
> (instead of `QInputDialog::getInt()`). Those are the easy and straightforward 
> ones fixed by this patch.
> 
> The handling of file dialogs (in 2 locations) was more problematic. Both 
> Apple's clang "6.0.0" and gcc 5.3 (on Linux) refused statements like 
> `QWeakPointer dlg = new QFileDialog(parent,defname);` . My 
> initial attempt was to follow the documentation for QWeakPointer, and do 
> `QWeakPointer dlg = QSharedPointer(new 
> QFileDialog(parent,defname));` but that caused a crash as soon as I clicked 
> on the "save backtrace as" button - on both platforms.
> It turned out that `QSharedPointer()` returned a valid 
> (non-null) shared pointer, but after creating a QWeakPointer from it, 
> `dlg.data()` returned NULL -- immediately.
> 
> I had a look around in the 5.17.0 frameworks codebase, and could find no 
> relevant examples of using QWeakPointer; some expressions appear to be 
> equivalent to the original DrKonqi code, in other locations QWeakPointer 
> instances are indeed created "going through" a QSharedPointer. In the end I 
> tested using QFileDialog (and `QFileDialog::selectedUrls()` as kate5 does, 
> and that works (on OS X and Linux).
> 
> That's what the attached patch does: no QFileDialog pointer at all, just an 
> instance.
> This RR is intended to fuel a discussion on the subject, as suggested by 
> Aleix; therefore I left the comment about the possibility of 
> invalidating/deleting the file dialog e.g. through a DBus call. Is that 
> actually a possibility, and why wouldn't it be in Kate? Are there no other 
> ways to prevent it, or check for its occurrence?
> 
> This patch also marks drkonqi as a nongui executable, a requirement on OS X 
> and which shouldn't cause any regressions elsewhere AFAIK.
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt deb8c40 
>   drkonqi/bugzillaintegration/bugzillalib.cpp 802c5fb 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp e60fb14 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp 
> 4f8f4ea 
>   drkonqi/drkonqi.cpp b12c118 
> 
> Diff: https://git.reviewboard.kde.org/r/126993/diff/
> 
> 
> Testing
> ---
> 
> On OS X 10.9.1 and Kubuntu 14.04, both with Qt 5.5.1 and KF5 5.17.0 installed 
> into /opt/local
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Restoring weather applet in kdeplasma-addons

[Marco Martin]

On Friday 05 February 2016 16:23:38 Friedrich W. H. Kossebau wrote:
> Hi,
> 
> I am missing the weather applet in my Plasma5 workspace. I found the
> sources in kdeplasma-addons/applets/weather, but it seems not yet ported
> and is disabled from the build.
> 
> So I would see to port it over now myself.
> 
> A few questions I have:
> 
> Q1:
> Is anyone already looking into it?
> Any general plans with weather info display in Plasma5?

no, but as far i know the port of the weather dataengine in plasma-workspace 
was started

> Q2:
> I see plasma_applet_weather is using some libplasmaweather from
> kdeplasma-addons/libs/plasmaweather, which is also not yet ported and
> disabled from build. Looks it is for code sharing with the weatherstation
> applet (which is unported and disabled from build as well).

that was to have a common configuration window with the weatherstation applet, 
i don't think you need that anymore

> Does it make sense to keep the current structure with the shared lib and
> the applet, at least for the initial port of the weather applet?
> 
> Q3:
> Are there any Plasma5 applet tutorials, especially for porting?
> 
> techbase.kde.org/Development/Tutorials/Plasma5 seems about QQ2-only apps.
> So far I was planning to look for some reference e.g. at the comic applet
> and how it got ported.

the qml of theapplet should be very easy to port, you can ignore the shared 
library and have straight port of that qml + port of dataengines

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Restoring weather applet in kdeplasma-addons

[Marco Martin]

On Friday 05 February 2016 18:39:00 Friedrich W. H. Kossebau wrote:
> Hi Martin,
> 
> I see. And found it now, plasma-workspace/dataengines/weather. Seems it
> was started in 2014, but then lost focus of developers. Some "ions"
> library is installed, but the dataengine plugin itself is not even build.
> 
> Will look some more around and see where the loose ends to pick up are.

i'm finishing the port right now, seems easier then expected :)

so yeah, you would have to take the qml1 weather applet, port to qml2 
(wouldn't do anything at that point) then hook it up to the dataengine and 
give it a configuration dialog.
I can walk you trough the steps

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126993: drkonqi : fix build errors and build nongui

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126993/#review92098
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Feb. 5, 2016, 6:18 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126993/
> ---
> 
> (Updated Feb. 5, 2016, 6:18 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> While looking to build DrKonqi for OS X/MacPorts I came across a few issues 
> that appear to be syntax/coding errors that, surprisingly, were never caught 
> before given that they also caused compile failures when I used the same 
> configure/build/packaging script on Linux.
> 
> The code uses methods that no longer exist in Qt 5.5+ : 
> `QString::fromAscii()`, `QHeaderView::setResizeMod()` (replaced with 
> `QHeaderView::setSectionResizeMode()` and `QInputDialog::getInteger()` 
> (instead of `QInputDialog::getInt()`). Those are the easy and straightforward 
> ones fixed by this patch.
> 
> The handling of file dialogs (in 2 locations) was more problematic. Both 
> Apple's clang "6.0.0" and gcc 5.3 (on Linux) refused statements like 
> `QWeakPointer dlg = new QFileDialog(parent,defname);` . My 
> initial attempt was to follow the documentation for QWeakPointer, and do 
> `QWeakPointer dlg = QSharedPointer(new 
> QFileDialog(parent,defname));` but that caused a crash as soon as I clicked 
> on the "save backtrace as" button - on both platforms.
> It turned out that `QSharedPointer()` returned a valid 
> (non-null) shared pointer, but after creating a QWeakPointer from it, 
> `dlg.data()` returned NULL -- immediately.
> 
> I had a look around in the 5.17.0 frameworks codebase, and could find no 
> relevant examples of using QWeakPointer; some expressions appear to be 
> equivalent to the original DrKonqi code, in other locations QWeakPointer 
> instances are indeed created "going through" a QSharedPointer. In the end I 
> tested using QFileDialog (and `QFileDialog::selectedUrls()` as kate5 does, 
> and that works (on OS X and Linux).
> 
> That's what the attached patch does: no QFileDialog pointer at all, just an 
> instance.
> This RR is intended to fuel a discussion on the subject, as suggested by 
> Aleix; therefore I left the comment about the possibility of 
> invalidating/deleting the file dialog e.g. through a DBus call. Is that 
> actually a possibility, and why wouldn't it be in Kate? Are there no other 
> ways to prevent it, or check for its occurrence?
> 
> This patch also marks drkonqi as a nongui executable, a requirement on OS X 
> and which shouldn't cause any regressions elsewhere AFAIK.
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt deb8c40 
>   drkonqi/bugzillaintegration/bugzillalib.cpp 802c5fb 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp e60fb14 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp 
> 4f8f4ea 
>   drkonqi/drkonqi.cpp b12c118 
> 
> Diff: https://git.reviewboard.kde.org/r/126993/diff/
> 
> 
> Testing
> ---
> 
> On OS X 10.9.1 and Kubuntu 14.04, both with Qt 5.5.1 and KF5 5.17.0 installed 
> into /opt/local
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Restoring weather applet in kdeplasma-addons

[Friedrich W. H. Kossebau]

Hi Martin,

Am Freitag, 5. Februar 2016, 17:05:43 CET schrieb Marco Martin:
> On Friday 05 February 2016 16:23:38 Friedrich W. H. Kossebau wrote:
> > Hi,
> > 
> > I am missing the weather applet in my Plasma5 workspace. I found the
> > sources in kdeplasma-addons/applets/weather, but it seems not yet 
ported
> > and is disabled from the build.
> > 
> > So I would see to port it over now myself.
> > 
> > A few questions I have:
> > 
> > Q1:
> > Is anyone already looking into it?
> > Any general plans with weather info display in Plasma5?
> 
> no, but as far i know the port of the weather dataengine in plasma-
workspace
> was started

I see. And found it now, plasma-workspace/dataengines/weather. Seems it 
was started in 2014, but then lost focus of developers. Some "ions" 
library is installed, but the dataengine plugin itself is not even build.

Will look some more around and see where the loose ends to pick up are.

> > Q2:
> > I see plasma_applet_weather is using some libplasmaweather from
> > kdeplasma-addons/libs/plasmaweather, which is also not yet ported and
> > disabled from build. Looks it is for code sharing with the 
weatherstation
> > applet (which is unported and disabled from build as well).
> 
> that was to have a common configuration window with the weatherstation
> applet, i don't think you need that anymore

Okay, note taken.

> > Does it make sense to keep the current structure with the shared lib 
and
> > the applet, at least for the initial port of the weather applet?
> > 
> > Q3:
> > Are there any Plasma5 applet tutorials, especially for porting?
> > 
> > techbase.kde.org/Development/Tutorials/Plasma5 seems about QQ2-only 
apps.
> > So far I was planning to look for some reference e.g. at the comic 
applet
> > and how it got ported.
> 
> the qml of theapplet should be very easy to port, you can ignore the 
shared
> library and have straight port of that qml + port of dataengines

Good, so will see to walk that path then now.

Thanks
Friedrich
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126993: drkonqi : fix build errors and build nongui

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126993/#review92097
---



It's only on your system because for some reason you are probably not including 
KDELibs4Support.

It should be something like this, but it isn't: https://paste.kde.org/pv12ioe89

- Aleix Pol Gonzalez


On Feb. 5, 2016, 6:18 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126993/
> ---
> 
> (Updated Feb. 5, 2016, 6:18 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> While looking to build DrKonqi for OS X/MacPorts I came across a few issues 
> that appear to be syntax/coding errors that, surprisingly, were never caught 
> before given that they also caused compile failures when I used the same 
> configure/build/packaging script on Linux.
> 
> The code uses methods that no longer exist in Qt 5.5+ : 
> `QString::fromAscii()`, `QHeaderView::setResizeMod()` (replaced with 
> `QHeaderView::setSectionResizeMode()` and `QInputDialog::getInteger()` 
> (instead of `QInputDialog::getInt()`). Those are the easy and straightforward 
> ones fixed by this patch.
> 
> The handling of file dialogs (in 2 locations) was more problematic. Both 
> Apple's clang "6.0.0" and gcc 5.3 (on Linux) refused statements like 
> `QWeakPointer dlg = new QFileDialog(parent,defname);` . My 
> initial attempt was to follow the documentation for QWeakPointer, and do 
> `QWeakPointer dlg = QSharedPointer(new 
> QFileDialog(parent,defname));` but that caused a crash as soon as I clicked 
> on the "save backtrace as" button - on both platforms.
> It turned out that `QSharedPointer()` returned a valid 
> (non-null) shared pointer, but after creating a QWeakPointer from it, 
> `dlg.data()` returned NULL -- immediately.
> 
> I had a look around in the 5.17.0 frameworks codebase, and could find no 
> relevant examples of using QWeakPointer; some expressions appear to be 
> equivalent to the original DrKonqi code, in other locations QWeakPointer 
> instances are indeed created "going through" a QSharedPointer. In the end I 
> tested using QFileDialog (and `QFileDialog::selectedUrls()` as kate5 does, 
> and that works (on OS X and Linux).
> 
> That's what the attached patch does: no QFileDialog pointer at all, just an 
> instance.
> This RR is intended to fuel a discussion on the subject, as suggested by 
> Aleix; therefore I left the comment about the possibility of 
> invalidating/deleting the file dialog e.g. through a DBus call. Is that 
> actually a possibility, and why wouldn't it be in Kate? Are there no other 
> ways to prevent it, or check for its occurrence?
> 
> This patch also marks drkonqi as a nongui executable, a requirement on OS X 
> and which shouldn't cause any regressions elsewhere AFAIK.
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt deb8c40 
>   drkonqi/bugzillaintegration/bugzillalib.cpp 802c5fb 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp e60fb14 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp 
> 4f8f4ea 
>   drkonqi/drkonqi.cpp b12c118 
> 
> Diff: https://git.reviewboard.kde.org/r/126993/diff/
> 
> 
> Testing
> ---
> 
> On OS X 10.9.1 and Kubuntu 14.04, both with Qt 5.5.1 and KF5 5.17.0 installed 
> into /opt/local
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126993: drkonqi : fix build errors and build nongui

[René J . V . Bertin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126993/
---

(Updated Feb. 5, 2016, 6:18 p.m.)


Review request for KDE Software on Mac OS X and Plasma.


Changes
---

Version using QPointer.

I still don't understand why I am apparently the first person to encounter this 
issue...


Repository: plasma-workspace


Description
---

While looking to build DrKonqi for OS X/MacPorts I came across a few issues 
that appear to be syntax/coding errors that, surprisingly, were never caught 
before given that they also caused compile failures when I used the same 
configure/build/packaging script on Linux.

The code uses methods that no longer exist in Qt 5.5+ : `QString::fromAscii()`, 
`QHeaderView::setResizeMod()` (replaced with 
`QHeaderView::setSectionResizeMode()` and `QInputDialog::getInteger()` (instead 
of `QInputDialog::getInt()`). Those are the easy and straightforward ones fixed 
by this patch.

The handling of file dialogs (in 2 locations) was more problematic. Both 
Apple's clang "6.0.0" and gcc 5.3 (on Linux) refused statements like 
`QWeakPointer dlg = new QFileDialog(parent,defname);` . My initial 
attempt was to follow the documentation for QWeakPointer, and do 
`QWeakPointer dlg = QSharedPointer(new 
QFileDialog(parent,defname));` but that caused a crash as soon as I clicked on 
the "save backtrace as" button - on both platforms.
It turned out that `QSharedPointer()` returned a valid (non-null) 
shared pointer, but after creating a QWeakPointer from it, `dlg.data()` 
returned NULL -- immediately.

I had a look around in the 5.17.0 frameworks codebase, and could find no 
relevant examples of using QWeakPointer; some expressions appear to be 
equivalent to the original DrKonqi code, in other locations QWeakPointer 
instances are indeed created "going through" a QSharedPointer. In the end I 
tested using QFileDialog (and `QFileDialog::selectedUrls()` as kate5 does, and 
that works (on OS X and Linux).

That's what the attached patch does: no QFileDialog pointer at all, just an 
instance.
This RR is intended to fuel a discussion on the subject, as suggested by Aleix; 
therefore I left the comment about the possibility of invalidating/deleting the 
file dialog e.g. through a DBus call. Is that actually a possibility, and why 
wouldn't it be in Kate? Are there no other ways to prevent it, or check for its 
occurrence?

This patch also marks drkonqi as a nongui executable, a requirement on OS X and 
which shouldn't cause any regressions elsewhere AFAIK.


Diffs (updated)
-

  drkonqi/CMakeLists.txt deb8c40 
  drkonqi/bugzillaintegration/bugzillalib.cpp 802c5fb 
  drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp e60fb14 
  drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp 
4f8f4ea 
  drkonqi/drkonqi.cpp b12c118 

Diff: https://git.reviewboard.kde.org/r/126993/diff/


Testing
---

On OS X 10.9.1 and Kubuntu 14.04, both with Qt 5.5.1 and KF5 5.17.0 installed 
into /opt/local


Thanks,

René J.V. Bertin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Restoring weather applet in kdeplasma-addons

[Friedrich W. H. Kossebau]

Hi,

I am missing the weather applet in my Plasma5 workspace. I found the 
sources in kdeplasma-addons/applets/weather, but it seems not yet ported 
and is disabled from the build.

So I would see to port it over now myself.

A few questions I have:

Q1:
Is anyone already looking into it?
Any general plans with weather info display in Plasma5?

Q2: 
I see plasma_applet_weather is using some libplasmaweather from 
kdeplasma-addons/libs/plasmaweather, which is also not yet ported and 
disabled from build. Looks it is for code sharing with the weatherstation 
applet (which is unported and disabled from build as well).

Does it make sense to keep the current structure with the shared lib and 
the applet, at least for the initial port of the weather applet?

Q3:
Are there any Plasma5 applet tutorials, especially for porting?

techbase.kde.org/Development/Tutorials/Plasma5 seems about QQ2-only apps.
So far I was planning to look for some reference e.g. at the comic applet 
and how it got ported.

Cheers
Friedrich
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Restoring weather applet in kdeplasma-addons

[Marco Martin]

On Friday 05 February 2016 18:39:00 Friedrich W. H. Kossebau wrote:
> 
> I see. And found it now, plasma-workspace/dataengines/weather. Seems it
> was started in 2014, but then lost focus of developers. Some "ions"
> library is installed, but the dataengine plugin itself is not even build.
> 
> Will look some more around and see where the loose ends to pick up are.

ok, weather dataengine works now. only noaa and wettercom engines working, but 
wettercom is enough for having a basic working weather applet.

try to open it in plasmaengineexplorer and to query it like:
wettercom|validate||berlin

or
wettercom|weather|Turin, Piemont, IT|IT0PI0397;Turin


the qml applet knows already how to parse all the stuff that comes out of it.

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126993: drkonqi : fix build errors and build nongui

[René J . V . Bertin]

> On Feb. 5, 2016, 7:58 p.m., Aleix Pol Gonzalez wrote:
> > It's only on your system because for some reason you are probably not 
> > including KDELibs4Support.
> > 
> > It should be something like this, but it isn't: 
> > https://paste.kde.org/pv12ioe89

I indeed removed the reference to KDELibs4Support from `find_package(KF5` in 
the toplevel CMake file, but only because I saw the framework isn't used by 
DrKonqi. I was under the impression it shouldn't thus change anything for DrK, 
does it? 
Of what is that paste snippet a diff?


- René J.V.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126993/#review92097
---


On Feb. 5, 2016, 6:18 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126993/
> ---
> 
> (Updated Feb. 5, 2016, 6:18 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> While looking to build DrKonqi for OS X/MacPorts I came across a few issues 
> that appear to be syntax/coding errors that, surprisingly, were never caught 
> before given that they also caused compile failures when I used the same 
> configure/build/packaging script on Linux.
> 
> The code uses methods that no longer exist in Qt 5.5+ : 
> `QString::fromAscii()`, `QHeaderView::setResizeMod()` (replaced with 
> `QHeaderView::setSectionResizeMode()` and `QInputDialog::getInteger()` 
> (instead of `QInputDialog::getInt()`). Those are the easy and straightforward 
> ones fixed by this patch.
> 
> The handling of file dialogs (in 2 locations) was more problematic. Both 
> Apple's clang "6.0.0" and gcc 5.3 (on Linux) refused statements like 
> `QWeakPointer dlg = new QFileDialog(parent,defname);` . My 
> initial attempt was to follow the documentation for QWeakPointer, and do 
> `QWeakPointer dlg = QSharedPointer(new 
> QFileDialog(parent,defname));` but that caused a crash as soon as I clicked 
> on the "save backtrace as" button - on both platforms.
> It turned out that `QSharedPointer()` returned a valid 
> (non-null) shared pointer, but after creating a QWeakPointer from it, 
> `dlg.data()` returned NULL -- immediately.
> 
> I had a look around in the 5.17.0 frameworks codebase, and could find no 
> relevant examples of using QWeakPointer; some expressions appear to be 
> equivalent to the original DrKonqi code, in other locations QWeakPointer 
> instances are indeed created "going through" a QSharedPointer. In the end I 
> tested using QFileDialog (and `QFileDialog::selectedUrls()` as kate5 does, 
> and that works (on OS X and Linux).
> 
> That's what the attached patch does: no QFileDialog pointer at all, just an 
> instance.
> This RR is intended to fuel a discussion on the subject, as suggested by 
> Aleix; therefore I left the comment about the possibility of 
> invalidating/deleting the file dialog e.g. through a DBus call. Is that 
> actually a possibility, and why wouldn't it be in Kate? Are there no other 
> ways to prevent it, or check for its occurrence?
> 
> This patch also marks drkonqi as a nongui executable, a requirement on OS X 
> and which shouldn't cause any regressions elsewhere AFAIK.
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt deb8c40 
>   drkonqi/bugzillaintegration/bugzillalib.cpp 802c5fb 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp e60fb14 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp 
> 4f8f4ea 
>   drkonqi/drkonqi.cpp b12c118 
> 
> Diff: https://git.reviewboard.kde.org/r/126993/diff/
> 
> 
> Testing
> ---
> 
> On OS X 10.9.1 and Kubuntu 14.04, both with Qt 5.5.1 and KF5 5.17.0 installed 
> into /opt/local
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126994: Drop usage of Qt4Support

[René J . V . Bertin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126994/#review92105
---




drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp (lines 845 - 849)


I just pushed that other RR you mentioned, but shouldn't that be `dlg->foo` 
instead of `dlg.data()->foo`. I know it's equivalent, but also more readable, 
no?


- René J.V. Bertin


On Feb. 5, 2016, 9:16 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126994/
> ---
> 
> (Updated Feb. 5, 2016, 9:16 p.m.)
> 
> 
> Review request for Plasma and René J.V. Bertin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> As I saw in another RR, the simple fact of using KDELibs4Support in part of a 
> project makes the whole project rely on Qt4Support. That's bad especially in 
> cases where KDELibs4Support is optional, because it will lead to 
> unpredictable results.
> 
> 
> Diffs
> -
> 
>   applets/systemtray/plugin/host.cpp e529aeb 
>   components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels.cpp 
> cba87ec 
>   components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels_p.h 
> e9d7ef3 
>   components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp 8a5ba91 
>   components/shellprivate/widgetexplorer/plasmaappletitemmodel_p.h 20fb98e 
>   components/shellprivate/widgetexplorer/widgetexplorer.cpp 7816614 
>   dataengines/CMakeLists.txt 9ee93d8 
>   dataengines/dict/dictengine.cpp d851268 
>   dataengines/mpris2/mpris2engine.h ea49515 
>   dataengines/mpris2/multiplexedservice.h 2ab4e6b 
>   dataengines/mpris2/playercontainer.cpp 6c4c875 
>   dataengines/share/shareprovider.cpp ac66fd3 
>   dataengines/statusnotifieritem/statusnotifieritemsource.cpp 097f110 
>   drkonqi/bugzillaintegration/bugzillalib.cpp 802c5fb 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp e60fb14 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp 
> 4f8f4ea 
>   drkonqi/drkonqi.cpp b12c118 
>   libtaskmanager/abstractgroupableitem.cpp 9b86cf1 
>   libtaskmanager/groupmanager.cpp 12b18b0 
>   libtaskmanager/strategies/manualgroupingstrategy.cpp b37ac35 
>   libtaskmanager/strategies/programgroupingstrategy.cpp 6b91bfe 
>   libtaskmanager/taskactions.cpp d1ddf9c 
>   libtaskmanager/taskactions_p.h 535ea5f 
>   libtaskmanager/taskitem.cpp 3b2a418 
>   libtaskmanager/tasksmodel.h 8decf0b 
>   libtaskmanager/tasksmodel.cpp 0abdd93 
>   runners/bookmarks/faviconfromblob.cpp 540db9c 
>   runners/bookmarks/tests/testchromebookmarks.cpp 718e765 
>   shell/currentcontainmentactionsmodel.h 0c27a20 
>   shell/currentcontainmentactionsmodel.cpp d442985 
>   shell/kidenticongenerator.cpp 4e4b25a 
>   shell/panelview.cpp 0eaf553 
>   shell/scripting/backportglobal.h 988b14e 
>   shell/scripting/containment.cpp 5e42bee 
>   shell/scripting/widget.cpp 984e666 
>   wallpapers/image/backgroundlistmodel.h d639b03 
>   wallpapers/image/backgroundlistmodel.cpp b4f81da 
>   wallpapers/image/image.h 295ba22 
> 
> Diff: https://git.reviewboard.kde.org/r/126994/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 418 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/418/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 Feb 2016 20:36:13 +
Build duration: 5 min 4 sec

CHANGE SET
Revision efdb5e97d975a0f86e42b37e81d69339df5b0e64 by rjvbertin: (drkonqi : fix 
build errors and build nongui)
  change: edit drkonqi/drkonqi.cpp
  change: edit drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp
  change: edit drkonqi/CMakeLists.txt
  change: edit drkonqi/bugzillaintegration/bugzillalib.cpp
  change: edit 
drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[PATCH] ActionButton.qml: centre-align the clickable part of the button

[Rick Walsh]

ActionButton.qml: centre-align the clickable part of the button

buttonGraphics.x refers to the centre of the action button. For the click to
be within the central area of the button, mouse.x needs to be between:
buttonGraphics.x - buttonGraphics.width / 2, and
buttonGraphics.x + buttonGraphics.width / 2

Signed-off-by: Rick Walsh 
From 11d116fc0fa3945b7158da2bdd08bafb8009b0a1 Mon Sep 17 00:00:00 2001
From: Rick Walsh 
Date: Sat, 6 Feb 2016 09:53:53 +1100
Subject: [PATCH] ActionButton.qml: centre-align the clickable part of the
 button

buttonGraphics.x refers to the centre of the action button. For the click to
be within the central area of the button, mouse.x needs to be between:
	buttonGraphics.x - buttonGraphics.width / 2, and
	buttonGraphics.x + buttonGraphics.width / 2

Signed-off-by: Rick Walsh 
---
 components/mobilecomponents/qml/private/ActionButton.qml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/components/mobilecomponents/qml/private/ActionButton.qml b/components/mobilecomponents/qml/private/ActionButton.qml
index 3cdd13d..f65a3ed 100644
--- a/components/mobilecomponents/qml/private/ActionButton.qml
+++ b/components/mobilecomponents/qml/private/ActionButton.qml
@@ -84,7 +84,7 @@ MouseArea {
 }
 }
 onClicked: {
-if (mouse.x < buttonGraphics.x || mouse.x > buttonGraphics.x + buttonGraphics.width) {
+if (mouse.x < buttonGraphics.x - buttonGraphics.width / 2 || mouse.x > buttonGraphics.x + buttonGraphics.width / 2) {
 return;
 }
 if (checkable) {
-- 
2.5.0

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126996: Drop usage of Qt4Support

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126996/#review92109
---


Fix it, then Ship it!




One minor question


imports/activitymanager/switcherbackend.cpp (line 125)


this isn't identical.

old code would match alt+shift+tab, yours doesn't.

(tbh yours might be more right, but I want to check it's deliberate)


- David Edmundson


On Feb. 5, 2016, 8:49 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126996/
> ---
> 
> (Updated Feb. 5, 2016, 8:49 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> On non-kdelibs4support depending modules.
> 
> 
> Diffs
> -
> 
>   applets/kicker/plugin/runnermodel.h d447efc 
>   applets/kicker/plugin/runnermodel.cpp a3c193a 
>   applets/pager/plugin/model.h 9382247 
>   applets/pager/plugin/model.cpp 1b80baa 
>   applets/trash/plugin/dirmodel.h 9e7ad12 
>   applets/trash/plugin/dirmodel.cpp cc36e1a 
>   containments/desktop/plugins/folder/mimetypesmodel.h f3d701c 
>   containments/desktop/plugins/folder/mimetypesmodel.cpp 731414a 
>   containments/desktop/plugins/folder/placesmodel.h b7f9f70 
>   containments/desktop/plugins/folder/placesmodel.cpp 9ca3bec 
>   containments/desktop/plugins/folder/previewpluginsmodel.h d340eb5 
>   containments/desktop/plugins/folder/previewpluginsmodel.cpp 2b14551 
>   imports/activitymanager/switcherbackend.cpp 939575f 
>   kcms/keyboard/kcm_view_models.h 434bbe9 
>   kcms/keyboard/preview/keysymhelper.cpp 1479fb0 
>   kcms/keyboard/tests/keyboard_daemon_test.cpp 885f070 
>   kcms/phonon/audiosetup.cpp bd6fcb0 
>   kcms/phonon/testspeakerwidget.cpp 45572be 
>   kcms/solid_actions/ActionModel.cpp 36a55cf 
>   kcms/solid_actions/PredicateModel.cpp 7d3a9da 
>   kcms/solid_actions/SolidActions.cpp 9b607d9 
> 
> Diff: https://git.reviewboard.kde.org/r/126996/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126995: Drop usage of Qt4Support

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126995/#review92110
---


Ship it!




Ship It!

- David Edmundson


On Feb. 5, 2016, 8:25 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126995/
> ---
> 
> (Updated Feb. 5, 2016, 8:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> On non-kdelibs4support depending modules.
> 
> 
> Diffs
> -
> 
>   bookmarks/kio_bookmarks.cpp 7c7dd7a 
>   filenamesearch/kio_filenamesearch.cpp 7501e9c 
>   thumbnail/exrcreator.cpp de7ef4f 
> 
> Diff: https://git.reviewboard.kde.org/r/126995/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126993: drkonqi : fix build errors and build nongui

[René J . V . Bertin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126993/
---

(Updated Feb. 5, 2016, 9:35 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Software on Mac OS X and Plasma.


Changes
---

Submitted with commit efdb5e97d975a0f86e42b37e81d69339df5b0e64 by René J.V. 
Bertin to branch master.


Repository: plasma-workspace


Description
---

While looking to build DrKonqi for OS X/MacPorts I came across a few issues 
that appear to be syntax/coding errors that, surprisingly, were never caught 
before given that they also caused compile failures when I used the same 
configure/build/packaging script on Linux.

The code uses methods that no longer exist in Qt 5.5+ : `QString::fromAscii()`, 
`QHeaderView::setResizeMod()` (replaced with 
`QHeaderView::setSectionResizeMode()` and `QInputDialog::getInteger()` (instead 
of `QInputDialog::getInt()`). Those are the easy and straightforward ones fixed 
by this patch.

The handling of file dialogs (in 2 locations) was more problematic. Both 
Apple's clang "6.0.0" and gcc 5.3 (on Linux) refused statements like 
`QWeakPointer dlg = new QFileDialog(parent,defname);` . My initial 
attempt was to follow the documentation for QWeakPointer, and do 
`QWeakPointer dlg = QSharedPointer(new 
QFileDialog(parent,defname));` but that caused a crash as soon as I clicked on 
the "save backtrace as" button - on both platforms.
It turned out that `QSharedPointer()` returned a valid (non-null) 
shared pointer, but after creating a QWeakPointer from it, `dlg.data()` 
returned NULL -- immediately.

I had a look around in the 5.17.0 frameworks codebase, and could find no 
relevant examples of using QWeakPointer; some expressions appear to be 
equivalent to the original DrKonqi code, in other locations QWeakPointer 
instances are indeed created "going through" a QSharedPointer. In the end I 
tested using QFileDialog (and `QFileDialog::selectedUrls()` as kate5 does, and 
that works (on OS X and Linux).

That's what the attached patch does: no QFileDialog pointer at all, just an 
instance.
This RR is intended to fuel a discussion on the subject, as suggested by Aleix; 
therefore I left the comment about the possibility of invalidating/deleting the 
file dialog e.g. through a DBus call. Is that actually a possibility, and why 
wouldn't it be in Kate? Are there no other ways to prevent it, or check for its 
occurrence?

This patch also marks drkonqi as a nongui executable, a requirement on OS X and 
which shouldn't cause any regressions elsewhere AFAIK.


Diffs
-

  drkonqi/CMakeLists.txt deb8c40 
  drkonqi/bugzillaintegration/bugzillalib.cpp 802c5fb 
  drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp e60fb14 
  drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp 
4f8f4ea 
  drkonqi/drkonqi.cpp b12c118 

Diff: https://git.reviewboard.kde.org/r/126993/diff/


Testing
---

On OS X 10.9.1 and Kubuntu 14.04, both with Qt 5.5.1 and KF5 5.17.0 installed 
into /opt/local


Thanks,

René J.V. Bertin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126995: Drop usage of Qt4Support

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126995/#review92107
---



+1

- Marco Martin


On Feb. 5, 2016, 8:25 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126995/
> ---
> 
> (Updated Feb. 5, 2016, 8:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> On non-kdelibs4support depending modules.
> 
> 
> Diffs
> -
> 
>   bookmarks/kio_bookmarks.cpp 7c7dd7a 
>   filenamesearch/kio_filenamesearch.cpp 7501e9c 
>   thumbnail/exrcreator.cpp de7ef4f 
> 
> Diff: https://git.reviewboard.kde.org/r/126995/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126994: Drop usage of Qt4Support

[René J . V . Bertin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126994/#review92106
---



I suppose that getting rid of KDELibs4Support isn't a bad thing at all if it 
doesn't provide crucial/central functionality.

PS: you're welcome :)

- René J.V. Bertin


On Feb. 5, 2016, 9:16 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126994/
> ---
> 
> (Updated Feb. 5, 2016, 9:16 p.m.)
> 
> 
> Review request for Plasma and René J.V. Bertin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> As I saw in another RR, the simple fact of using KDELibs4Support in part of a 
> project makes the whole project rely on Qt4Support. That's bad especially in 
> cases where KDELibs4Support is optional, because it will lead to 
> unpredictable results.
> 
> 
> Diffs
> -
> 
>   applets/systemtray/plugin/host.cpp e529aeb 
>   components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels.cpp 
> cba87ec 
>   components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels_p.h 
> e9d7ef3 
>   components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp 8a5ba91 
>   components/shellprivate/widgetexplorer/plasmaappletitemmodel_p.h 20fb98e 
>   components/shellprivate/widgetexplorer/widgetexplorer.cpp 7816614 
>   dataengines/CMakeLists.txt 9ee93d8 
>   dataengines/dict/dictengine.cpp d851268 
>   dataengines/mpris2/mpris2engine.h ea49515 
>   dataengines/mpris2/multiplexedservice.h 2ab4e6b 
>   dataengines/mpris2/playercontainer.cpp 6c4c875 
>   dataengines/share/shareprovider.cpp ac66fd3 
>   dataengines/statusnotifieritem/statusnotifieritemsource.cpp 097f110 
>   drkonqi/bugzillaintegration/bugzillalib.cpp 802c5fb 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp e60fb14 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp 
> 4f8f4ea 
>   drkonqi/drkonqi.cpp b12c118 
>   libtaskmanager/abstractgroupableitem.cpp 9b86cf1 
>   libtaskmanager/groupmanager.cpp 12b18b0 
>   libtaskmanager/strategies/manualgroupingstrategy.cpp b37ac35 
>   libtaskmanager/strategies/programgroupingstrategy.cpp 6b91bfe 
>   libtaskmanager/taskactions.cpp d1ddf9c 
>   libtaskmanager/taskactions_p.h 535ea5f 
>   libtaskmanager/taskitem.cpp 3b2a418 
>   libtaskmanager/tasksmodel.h 8decf0b 
>   libtaskmanager/tasksmodel.cpp 0abdd93 
>   runners/bookmarks/faviconfromblob.cpp 540db9c 
>   runners/bookmarks/tests/testchromebookmarks.cpp 718e765 
>   shell/currentcontainmentactionsmodel.h 0c27a20 
>   shell/currentcontainmentactionsmodel.cpp d442985 
>   shell/kidenticongenerator.cpp 4e4b25a 
>   shell/panelview.cpp 0eaf553 
>   shell/scripting/backportglobal.h 988b14e 
>   shell/scripting/containment.cpp 5e42bee 
>   shell/scripting/widget.cpp 984e666 
>   wallpapers/image/backgroundlistmodel.h d639b03 
>   wallpapers/image/backgroundlistmodel.cpp b4f81da 
>   wallpapers/image/image.h 295ba22 
> 
> Diff: https://git.reviewboard.kde.org/r/126994/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126994: Drop usage of Qt4Support

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126994/
---

Review request for Plasma and René J.V. Bertin.


Repository: plasma-workspace


Description
---

As I saw in another RR, the simple fact of using KDELibs4Support in part of a 
project makes the whole project rely on Qt4Support. That's bad especially in 
cases where KDELibs4Support is optional, because it will lead to unpredictable 
results.


Diffs
-

  applets/systemtray/plugin/host.cpp e529aeb 
  components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels.cpp 
cba87ec 
  components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels_p.h 
e9d7ef3 
  components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp 8a5ba91 
  components/shellprivate/widgetexplorer/plasmaappletitemmodel_p.h 20fb98e 
  components/shellprivate/widgetexplorer/widgetexplorer.cpp 7816614 
  dataengines/CMakeLists.txt 9ee93d8 
  dataengines/dict/dictengine.cpp d851268 
  dataengines/mpris2/mpris2engine.h ea49515 
  dataengines/mpris2/multiplexedservice.h 2ab4e6b 
  dataengines/mpris2/playercontainer.cpp 6c4c875 
  dataengines/share/shareprovider.cpp ac66fd3 
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp 097f110 
  drkonqi/bugzillaintegration/bugzillalib.cpp 802c5fb 
  drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp e60fb14 
  drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp 
4f8f4ea 
  drkonqi/drkonqi.cpp b12c118 
  libtaskmanager/abstractgroupableitem.cpp 9b86cf1 
  libtaskmanager/groupmanager.cpp 12b18b0 
  libtaskmanager/strategies/manualgroupingstrategy.cpp b37ac35 
  libtaskmanager/strategies/programgroupingstrategy.cpp 6b91bfe 
  libtaskmanager/taskactions.cpp d1ddf9c 
  libtaskmanager/taskactions_p.h 535ea5f 
  libtaskmanager/taskitem.cpp 3b2a418 
  libtaskmanager/tasksmodel.h 8decf0b 
  libtaskmanager/tasksmodel.cpp 0abdd93 
  runners/bookmarks/faviconfromblob.cpp 540db9c 
  runners/bookmarks/tests/testchromebookmarks.cpp 718e765 
  shell/currentcontainmentactionsmodel.h 0c27a20 
  shell/currentcontainmentactionsmodel.cpp d442985 
  shell/kidenticongenerator.cpp 4e4b25a 
  shell/panelview.cpp 0eaf553 
  shell/scripting/backportglobal.h 988b14e 
  shell/scripting/containment.cpp 5e42bee 
  shell/scripting/widget.cpp 984e666 
  wallpapers/image/backgroundlistmodel.h d639b03 
  wallpapers/image/backgroundlistmodel.cpp b4f81da 
  wallpapers/image/image.h 295ba22 

Diff: https://git.reviewboard.kde.org/r/126994/diff/


Testing
---

Builds, tests pass.


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126995: Drop usage of Qt4Support

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126995/
---

Review request for Plasma.


Repository: kio-extras


Description
---

On non-kdelibs4support depending modules.


Diffs
-

  bookmarks/kio_bookmarks.cpp 7c7dd7a 
  filenamesearch/kio_filenamesearch.cpp 7501e9c 
  thumbnail/exrcreator.cpp de7ef4f 

Diff: https://git.reviewboard.kde.org/r/126995/diff/


Testing
---

Builds, tests pass.


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126996: Drop usage of Qt4Support

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126996/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

On non-kdelibs4support depending modules.


Diffs
-

  applets/kicker/plugin/runnermodel.h d447efc 
  applets/kicker/plugin/runnermodel.cpp a3c193a 
  applets/pager/plugin/model.h 9382247 
  applets/pager/plugin/model.cpp 1b80baa 
  applets/trash/plugin/dirmodel.h 9e7ad12 
  applets/trash/plugin/dirmodel.cpp cc36e1a 
  containments/desktop/plugins/folder/mimetypesmodel.h f3d701c 
  containments/desktop/plugins/folder/mimetypesmodel.cpp 731414a 
  containments/desktop/plugins/folder/placesmodel.h b7f9f70 
  containments/desktop/plugins/folder/placesmodel.cpp 9ca3bec 
  containments/desktop/plugins/folder/previewpluginsmodel.h d340eb5 
  containments/desktop/plugins/folder/previewpluginsmodel.cpp 2b14551 
  imports/activitymanager/switcherbackend.cpp 939575f 
  kcms/keyboard/kcm_view_models.h 434bbe9 
  kcms/keyboard/preview/keysymhelper.cpp 1479fb0 
  kcms/keyboard/tests/keyboard_daemon_test.cpp 885f070 
  kcms/phonon/audiosetup.cpp bd6fcb0 
  kcms/phonon/testspeakerwidget.cpp 45572be 
  kcms/solid_actions/ActionModel.cpp 36a55cf 
  kcms/solid_actions/PredicateModel.cpp 7d3a9da 
  kcms/solid_actions/SolidActions.cpp 9b607d9 

Diff: https://git.reviewboard.kde.org/r/126996/diff/


Testing
---

Builds, tests pass.


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 417 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/417/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 Feb 2016 19:35:18 +
Build duration: 6 min 40 sec

CHANGE SET
Revision 638897d0432f69db73f152d30f83b06c4ed9657c by Marco Martin: (restore 
weather dataengine)
  change: edit dataengines/weather/weatherengine.cpp
  change: edit dataengines/weather/ions/noaa/CMakeLists.txt
  change: edit dataengines/weather/weatherengine.h
  change: edit dataengines/weather/ions/wetter.com/CMakeLists.txt
  change: edit dataengines/weather/CMakeLists.txt
  change: edit dataengines/weather/ions/wetter.com/ion_wettercom.cpp
  change: edit dataengines/weather/ions/noaa/ion_noaa.cpp
  change: edit dataengines/weather/ions/wetter.com/ion_wettercom.h
  change: edit dataengines/weather/ions/CMakeLists.txt
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126993: drkonqi : fix build errors and build nongui

[Aleix Pol Gonzalez]

> On Feb. 5, 2016, 7:58 p.m., Aleix Pol Gonzalez wrote:
> > It's only on your system because for some reason you are probably not 
> > including KDELibs4Support.
> > 
> > It should be something like this, but it isn't: 
> > https://paste.kde.org/pv12ioe89
> 
> René J.V. Bertin wrote:
> I indeed removed the reference to KDELibs4Support from `find_package(KF5` 
> in the toplevel CMake file, but only because I saw the framework isn't used 
> by DrKonqi. I was under the impression it shouldn't thus change anything for 
> DrK, does it? 
> Of what is that paste snippet a diff?

It shouldn't, but it does.
The patch there is how it should have been, now it's quite impossible to apply 
it because half KDE would stop compiling.

We need to start dropping KDELibs4Support for real though... :/


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126993/#review92097
---


On Feb. 5, 2016, 9:35 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126993/
> ---
> 
> (Updated Feb. 5, 2016, 9:35 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> While looking to build DrKonqi for OS X/MacPorts I came across a few issues 
> that appear to be syntax/coding errors that, surprisingly, were never caught 
> before given that they also caused compile failures when I used the same 
> configure/build/packaging script on Linux.
> 
> The code uses methods that no longer exist in Qt 5.5+ : 
> `QString::fromAscii()`, `QHeaderView::setResizeMod()` (replaced with 
> `QHeaderView::setSectionResizeMode()` and `QInputDialog::getInteger()` 
> (instead of `QInputDialog::getInt()`). Those are the easy and straightforward 
> ones fixed by this patch.
> 
> The handling of file dialogs (in 2 locations) was more problematic. Both 
> Apple's clang "6.0.0" and gcc 5.3 (on Linux) refused statements like 
> `QWeakPointer dlg = new QFileDialog(parent,defname);` . My 
> initial attempt was to follow the documentation for QWeakPointer, and do 
> `QWeakPointer dlg = QSharedPointer(new 
> QFileDialog(parent,defname));` but that caused a crash as soon as I clicked 
> on the "save backtrace as" button - on both platforms.
> It turned out that `QSharedPointer()` returned a valid 
> (non-null) shared pointer, but after creating a QWeakPointer from it, 
> `dlg.data()` returned NULL -- immediately.
> 
> I had a look around in the 5.17.0 frameworks codebase, and could find no 
> relevant examples of using QWeakPointer; some expressions appear to be 
> equivalent to the original DrKonqi code, in other locations QWeakPointer 
> instances are indeed created "going through" a QSharedPointer. In the end I 
> tested using QFileDialog (and `QFileDialog::selectedUrls()` as kate5 does, 
> and that works (on OS X and Linux).
> 
> That's what the attached patch does: no QFileDialog pointer at all, just an 
> instance.
> This RR is intended to fuel a discussion on the subject, as suggested by 
> Aleix; therefore I left the comment about the possibility of 
> invalidating/deleting the file dialog e.g. through a DBus call. Is that 
> actually a possibility, and why wouldn't it be in Kate? Are there no other 
> ways to prevent it, or check for its occurrence?
> 
> This patch also marks drkonqi as a nongui executable, a requirement on OS X 
> and which shouldn't cause any regressions elsewhere AFAIK.
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt deb8c40 
>   drkonqi/bugzillaintegration/bugzillalib.cpp 802c5fb 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp e60fb14 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp 
> 4f8f4ea 
>   drkonqi/drkonqi.cpp b12c118 
> 
> Diff: https://git.reviewboard.kde.org/r/126993/diff/
> 
> 
> Testing
> ---
> 
> On OS X 10.9.1 and Kubuntu 14.04, both with Qt 5.5.1 and KF5 5.17.0 installed 
> into /opt/local
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Feature: remove application by dragging it over the trash icon

[Marcin Sągol]

Hi,

i have discussed this a bit with mck182 and Sho at #plasma IRC channel 
but i would also other developers to share their opinion abut this feature:


mac os allows their users to drag an app icon over the trash and than it 
gets removed/uninstall. It would be great to have similar functionality 
in Plasma, for example: imagine someone is using Application Dashboard 
(fullscreen launcher) where apps overview is pretty nice, he grabs than 
some app icon, moves it over trash icon (also located in application 
dashboard) and the app gets removed from system :)


I think it would be great feature that will help users to manage their 
apps and keep system cleaner (no need to run any application, center or 
package manager directly).


Thanks, and i hope someone could make it happen :)
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

[Marco Martin]

> On Feb. 2, 2016, 9:22 a.m., Marco Martin wrote:
> > hmm, i don't think i like the back/forward buttons both at the right, it 
> > looked more nicely symmetric before
> 
> Kai Uwe Broulik wrote:
> It also reduces mouse travel :) Placing the "Previous" button left of the 
> month name would look strange. Not a huge fan of having them where they 
> originally were; the ToolButtons wouldn't fit size- and style-wise.
> 
> Sebastian Kügler wrote:
> FWIW, I'm quite happy with it, visually. :)

btw, I'm happy with the explanations, +1 from me ;)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review91926
---


On Feb. 4, 2016, 11:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 4, 2016, 11:19 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> How about this?
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/d80b6161-3da3-4669-ba7c-19f62edbf542__Screenshot_20160205_001739.png
> How about this? #2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/73f2ada9-48cd-4b22-8ef2-5d37f2238442__Screenshot_20160205_001754.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QWeakPointer error in DrKonqi

[René J . V . Bertin]

Aleix Pol wrote:


> Maybe you can provide the fixes in the shape of a review request? I'm
> sure that if somebody found this they would have fixed it before.
> 
> I really have no idea why these issues didn't pop up on my set up but
> did on yours anyway.

That's weird indeed. I just tried to build on Linux without the fixes but with 
as 
much as possible the same configure/build/packaging scripts, and I get the same 
errors about QWeakPointer and QString::fromAscii().

This is clearly not related to using (Apple's) clang vs gcc (5.3 on my Linux 
rig).

Annoyingly there must be something wrong with my QWeakPointer "fix"; DrK 
crashes 
when I click on the "save" button to record a backtrace. According to the new 
DrK instance that then opens, the crash occurs in a QFileDialog method which 
somehow gets called with this==NULL.

Something else must be wrong with my Linux build, as DrK claims it doesn't know 
the reporting address where it has no such issues on OS X.

I'll look at this some more, but is a RR really the best way to get a 
discussion 
on this rolling if I'm not even 100% sure that my fixes are correct?

R

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126952: Set layout in kickoff config properly

[Marco Martin]

> On Feb. 2, 2016, 9:29 a.m., Marco Martin wrote:
> > applets/kickoff/package/contents/ui/ConfigGeneral.qml, line 39
> > 
> >
> > maybe look and feel package?
> 
> David Edmundson wrote:
> right, but all I'm changing here is the indentation so I don't want to 
> adjust that it in this patch.

sure:)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126952/#review91931
---


On Feb. 1, 2016, 11:20 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126952/
> ---
> 
> (Updated Feb. 1, 2016, 11:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Existing layout wasn't bound to anything so no labels would clip if they
> got too wide. We were just lucky all text was short.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/ui/ConfigGeneral.qml 
> aa345a508cc9da5c148b6237d4446627cd6656a1 
> 
> Diff: https://git.reviewboard.kde.org/r/126952/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review92078
---


Ship it!




Ship It!

- Andrew Lake


On Feb. 4, 2016, 11:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 4, 2016, 11:19 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> How about this?
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/d80b6161-3da3-4669-ba7c-19f62edbf542__Screenshot_20160205_001739.png
> How about this? #2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/73f2ada9-48cd-4b22-8ef2-5d37f2238442__Screenshot_20160205_001754.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

[Lars Pontoppidan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126793/
---

(Updated Feb. 5, 2016, 12:47 p.m.)


Review request for Plasma.


Changes
---

Added new diff


Repository: kdeplasma-addons


Description
---

KF5 version of the (Picture) Frame widget


Diffs (updated)
-

  applets/CMakeLists.txt ed938f8 
  applets/mediaframe/CMakeLists.txt PRE-CREATION 
  applets/mediaframe/Messages.sh PRE-CREATION 
  applets/mediaframe/package/contents/config/config.qml PRE-CREATION 
  applets/mediaframe/package/contents/config/main.xml PRE-CREATION 
  applets/mediaframe/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
  applets/mediaframe/package/contents/ui/ConfigPaths.qml PRE-CREATION 
  applets/mediaframe/package/contents/ui/main.qml PRE-CREATION 
  applets/mediaframe/package/metadata.desktop PRE-CREATION 
  applets/mediaframe/plugin/mediaframe.h PRE-CREATION 
  applets/mediaframe/plugin/mediaframe.cpp PRE-CREATION 
  applets/mediaframe/plugin/mediaframeplugin.h PRE-CREATION 
  applets/mediaframe/plugin/mediaframeplugin.cpp PRE-CREATION 
  applets/mediaframe/plugin/qmldir PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126793/diff/


Testing
---

kdeplasma-addons builds on Kubuntu 15.10.


Thanks,

Lars Pontoppidan

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

[Lars Pontoppidan]

> On Jan. 18, 2016, noon, Kai Uwe Broulik wrote:
> > Nice to see this applet coming back!
> > 
> > I was wondering if there could be more code shared between this applet and 
> > our image wallpaper, perhaps even "just" allow the image wallpaper to 
> > function also as an applet.
> > 
> > You have a lot of empty lines with whitespace in your code. Please check 
> > your editor settings.
> 
> Marco Martin wrote:
> let's have it back, then let's think about how to semplify it by loading 
> wallpaper plugins?
> 
> Lars Pontoppidan wrote:
> Cheers guys
> 
> I was missing this applet - so I thought I'd give it a shot.
> 
> It's my first contribution to KDE so I might have some questions down the 
> road :)
> 
> To start out with; I have no idea how to implement the mentioned 
> wallpaper plugins - heh

Please see the new diff. I'm having trouble using the StringList type as the 
plasmoidviewer keeps crashing on me.


- Lars


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126793/#review91257
---


On Feb. 5, 2016, 12:47 p.m., Lars Pontoppidan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126793/
> ---
> 
> (Updated Feb. 5, 2016, 12:47 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> KF5 version of the (Picture) Frame widget
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt ed938f8 
>   applets/mediaframe/CMakeLists.txt PRE-CREATION 
>   applets/mediaframe/Messages.sh PRE-CREATION 
>   applets/mediaframe/package/contents/config/config.qml PRE-CREATION 
>   applets/mediaframe/package/contents/config/main.xml PRE-CREATION 
>   applets/mediaframe/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/mediaframe/package/contents/ui/ConfigPaths.qml PRE-CREATION 
>   applets/mediaframe/package/contents/ui/main.qml PRE-CREATION 
>   applets/mediaframe/package/metadata.desktop PRE-CREATION 
>   applets/mediaframe/plugin/mediaframe.h PRE-CREATION 
>   applets/mediaframe/plugin/mediaframe.cpp PRE-CREATION 
>   applets/mediaframe/plugin/mediaframeplugin.h PRE-CREATION 
>   applets/mediaframe/plugin/mediaframeplugin.cpp PRE-CREATION 
>   applets/mediaframe/plugin/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126793/diff/
> 
> 
> Testing
> ---
> 
> kdeplasma-addons builds on Kubuntu 15.10.
> 
> 
> Thanks,
> 
> Lars Pontoppidan
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 56 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/56/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 Feb 2016 11:58:30 +
Build duration: 1 min 47 sec

CHANGE SET
Revision fe639d4e3f9f4d240d9f0f36410dc49e8c902a6b by scripty: (SVN_SILENT made 
messages (.desktop file))
  change: edit menu/desktop/kf5-utilities-desktop.directory
  change: edit freespacenotifier/freespacenotifier.notifyrc
  change: edit plasma-windowed/plasma-windowed.desktop
  change: edit systemmonitor/ksysguard.desktop
  change: edit menu/desktop/kf5-utilities-accessibility.directory
  change: edit applets/batterymonitor/package/metadata.desktop
  change: edit dataengines/packagekit/plasma-dataengine-packagekit.desktop
  change: edit lookandfeel/metadata.desktop
  change: edit klipper/plasma-dataengine-clipboard.desktop
  change: edit containmentactions/paste/plasma-containmentactions-paste.desktop
  change: edit menu/desktop/kf5-utilities-pim.directory
  change: edit dataengines/mouse/plasma-dataengine-mouse.desktop
  change: edit wallpapers/color/metadata.desktop
  change: edit ksmserver/themes/default/metadata.desktop
  change: edit applets/mediacontroller/metadata.desktop
  change: edit 
shell/packageplugins/shell/plasma-packagestructure-plasma-shell.desktop
  change: edit 
shell/packageplugins/lookandfeel/plasma-packagestructure-lookandfeel.desktop
  change: edit dataengines/tasks/plasma-dataengine-tasks.desktop
  change: edit applets/activitybar/metadata.desktop
  change: edit menu/desktop/kf5-utilities.directory
  change: edit applets/systemmonitor/cpu/metadata.desktop
  change: edit runners/recentdocuments/recentdocuments.desktop
  change: edit dataengines/keystate/plasma-dataengine-keystate.desktop
  change: edit runners/locations/plasma-runner-locations.desktop
  change: edit dataengines/share/backends/privatepaste/metadata.desktop
  change: edit dataengines/apps/plasma-dataengine-apps.desktop
  change: edit 
shell/packageplugins/wallpaperimages/plasma-packagestructure-wallpaperimages.desktop
  change: edit menu/desktop/kf5-education.directory
  change: edit plasma.desktop.cmake
  change: edit 
shell/packageplugins/layouttemplate/plasma-packagestructure-layouttemplate.desktop
  change: edit applets/systemtray/package/metadata.desktop
  change: edit dataengines/calendar/plasma-dataengine-calendar.desktop
  change: edit applets/systemmonitor/diskusage/metadata.desktop
  change: edit 
shell/packageplugins/qmlWallpaper/plasma-packagestructure-wallpaper.desktop
  change: edit 
containmentactions/switchdesktop/plasma-containmentactions-switchdesktop.desktop
  change: edit applets/systemmonitor/diskactivity/metadata.desktop
  change: edit menu/desktop/hidden.directory
  change: edit kioslave/desktop/desktopnotifier.desktop
  change: edit dataengines/geolocation/plasma-geolocation-gps.desktop
  change: edit dataengines/mpris2/plasma-dataengine-mpris2.desktop
  change: edit dataengines/akonadi/plasma-engine-akonadi.desktop
  change: edit shell/plasmashell.desktop
  change: edit runners/powerdevil/plasma-runner-powerdevil.desktop
  change: edit runners/webshortcuts/plasma-runner-webshortcuts.desktop
  change: edit dataengines/notifications/plasma-dataengine-notifications.desktop
  change: edit menu/desktop/kf5-utilities-xutils.directory
  change: edit dataengines/share/backends/pasteopensuseorg/metadata.desktop
  change: edit 
dataengines/devicenotifications/plasma-dataengine-devicenotifications.desktop
  change: edit applets/lock_logout/metadata.desktop
  change: edit dataengines/filebrowser/plasma-dataengine-filebrowser.desktop
  change: edit kioslave/desktop/Home.desktop
  change: edit runners/places/plasma-runner-places.desktop
  change: edit applets/systemmonitor/memory/metadata.desktop
  change: edit dataengines/dict/plasma-dataengine-dict.desktop
  change: edit runners/baloo/plasma-runner-baloosearch.desktop
  change: edit 
containmentactions/switchactivity/plasma-containmentactions-switchactivity.desktop
  change: edit dataengines/geolocation/plasma-geolocationprovider.desktop
  change: edit dataengines/share/backends/kde/metadata.desktop
  change: edit krunner/krunner.desktop
  change: edit dataengines/geolocation/plasma-geolocation-ip.desktop
  change: edit applets/systemmonitor/net/metadata.desktop
  change: edit dataengines/places/plasma-dataengine-places.desktop
  change: edit wallpapers/color/plasma-wallpaper-color.desktop
  change: edit phonon/platform_kde/phonon.notifyrc
  change: edit dataengines/favicons/plasma-dataengine-favicons.desktop
  change: edit dataengines/network/plasma-dataengine-network.desktop
  change: edit dataengines/soliddevice/plasma-dataengine-soliddevice.desktop
  change: edit kioslave/remote/kdedmodule/remotedirnotify.desktop
  change: edit appmenu/appmenu.desktop
  change: edit lookandfeel/contents/loginmanager/metadata.desktop
  change: edit 

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

[Lars Pontoppidan]

> On Jan. 18, 2016, noon, Kai Uwe Broulik wrote:
> > applets/mediaframe/package/contents/config/main.xml, line 9
> > 
> >
> > Where does this come from?

I've set that value based on what I found a resonable default for the slideshow 
interval - are there any KDE / global specifics on this?


> On Jan. 18, 2016, noon, Kai Uwe Broulik wrote:
> > applets/mediaframe/package/contents/config/config.qml, line 31
> > 
> >
> > This is an action icon and shouldn't be used for this prupose

Cool - using "folder" instead


> On Jan. 18, 2016, noon, Kai Uwe Broulik wrote:
> > applets/mediaframe/package/contents/ui/ConfigPaths.qml, line 35
> > 
> >
> > pathList should be a StringList which will result in a JS Array, then 
> > you don't need all of this JSON.parse stuff.

Good point. I will still need the JSON parse for the contents of the array 
though (objects `{ path: "/some/path", "type":"file/dir" }` ) - unless there's 
another way?


> On Jan. 18, 2016, noon, Kai Uwe Broulik wrote:
> > applets/mediaframe/package/contents/ui/main.qml, line 585
> > 
> >
> > I think there's a plasmoid.needsConfiguring property that does exactly 
> > that.

I can't find it - and using plasmoid.setConfigurationRequired(true,'Testing 1 2 
3') doesn't work for me?


> On Jan. 18, 2016, noon, Kai Uwe Broulik wrote:
> > applets/mediaframe/package/contents/ui/main.qml, lines 57-58
> > 
> >
> > Layout.minimumWidth / height ?

I'm using these instead now
```
width: units.gridUnit * 20
height: units.gridUnit * 13
```


> On Jan. 18, 2016, noon, Kai Uwe Broulik wrote:
> > applets/mediaframe/package/contents/ui/main.qml, line 299
> > 
> >
> > I would like to be able to configure this

Added a configuration option to change it


> On Jan. 18, 2016, noon, Kai Uwe Broulik wrote:
> > applets/mediaframe/package/contents/ui/main.qml, line 445
> > 
> >
> > I guess if you placed the MouseArea behind (ie. code-wise, above) the 
> > buttons, it would just work?

Not quite as hovering the buttons will then hide the overlay :(


> On Jan. 18, 2016, noon, Kai Uwe Broulik wrote:
> > applets/mediaframe/plugin/mediaframe.cpp, line 43
> > 
> >
> > Don't we have something re-usable elsewhere for this?

No clue?


> On Jan. 18, 2016, noon, Kai Uwe Broulik wrote:
> > applets/mediaframe/plugin/mediaframe.cpp, line 242
> > 
> >
> > We don't use the "callback" battern.

signals?


> On Jan. 18, 2016, noon, Kai Uwe Broulik wrote:
> > applets/mediaframe/plugin/mediaframe.cpp, line 98
> > 
> >
> > QString::fromLatin1 or so?

Which one? The str or the return value?


> On Jan. 18, 2016, noon, Kai Uwe Broulik wrote:
> > applets/mediaframe/plugin/mediaframe.cpp, line 108
> > 
> >
> > Is there no faster way than to create a list of files just to check if 
> > it's empty?
> > 
> > Also there's an .isEmpty() method

I don't know of any faster:
http://stackoverflow.com/a/16351957/1904615

I've used the .isEmpty()


> On Jan. 18, 2016, noon, Kai Uwe Broulik wrote:
> > applets/mediaframe/plugin/mediaframe.cpp, line 114
> > 
> >
> > Doesn't static QFile::exists() do that? I don't know if it returns true 
> > for folders, though.

I can't find anything in the documentation on what it does for folder :/


> On Jan. 18, 2016, noon, Kai Uwe Broulik wrote:
> > applets/mediaframe/plugin/mediaframe.cpp, lines 131-132
> > 
> >
> > You're creating an url just to make a local file from it again?

It's to make sure that the path/url can be read by QDir, QFile etc.
QDir and QFile doesn't work on my system when the protocol is present?

So this makes it easier to check for remote files via ftp:// or http:// etc.


> On Jan. 18, 2016, noon, Kai Uwe Broulik wrote:
> > applets/mediaframe/plugin/mediaframe.cpp, line 142
> > 
> >
> > I wonder if this should be done in another thread, have a look at 
> > 

Re: Review Request 126993: drkonqi : fix build errors and build nongui

[René J . V . Bertin]

> On Feb. 5, 2016, 2:29 p.m., Bhushan Shah wrote:
> > drkonqi/CMakeLists.txt, line 86
> > 
> >
> > Erm wait, drkonqi is gui program, no?

Yes, but:
- on Linux, that statement does nothing AFAIK (drkonqi continues to work just 
fine for me)
- on OS X, its only effect is that the executable is built as a traditional 
POSIX executable instead of as an "app bundle". There is no difference in 
functionality (IOW, app bundles make it easier to provide features that are 
irrelevant to drkonqi).

I can either drop this issue, or I can make the statement conditional 
(`if(APPLE) ...`). But note that in most if not all previous RRs I was told 
that there was no need to make this statement conditional.


- René J.V.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126993/#review92087
---


On Feb. 5, 2016, 2:21 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126993/
> ---
> 
> (Updated Feb. 5, 2016, 2:21 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> While looking to build DrKonqi for OS X/MacPorts I came across a few issues 
> that appear to be syntax/coding errors that, surprisingly, were never caught 
> before given that they also caused compile failures when I used the same 
> configure/build/packaging script on Linux.
> 
> The code uses methods that no longer exist in Qt 5.5+ : 
> `QString::fromAscii()`, `QHeaderView::setResizeMod()` (replaced with 
> `QHeaderView::setSectionResizeMode()` and `QInputDialog::getInteger()` 
> (instead of `QInputDialog::getInt()`). Those are the easy and straightforward 
> ones fixed by this patch.
> 
> The handling of file dialogs (in 2 locations) was more problematic. Both 
> Apple's clang "6.0.0" and gcc 5.3 (on Linux) refused statements like 
> `QWeakPointer dlg = new QFileDialog(parent,defname);` . My 
> initial attempt was to follow the documentation for QWeakPointer, and do 
> `QWeakPointer dlg = QSharedPointer(new 
> QFileDialog(parent,defname));` but that caused a crash as soon as I clicked 
> on the "save backtrace as" button - on both platforms.
> It turned out that `QSharedPointer()` returned a valid 
> (non-null) shared pointer, but after creating a QWeakPointer from it, 
> `dlg.data()` returned NULL -- immediately.
> 
> I had a look around in the 5.17.0 frameworks codebase, and could find no 
> relevant examples of using QWeakPointer; some expressions appear to be 
> equivalent to the original DrKonqi code, in other locations QWeakPointer 
> instances are indeed created "going through" a QSharedPointer. In the end I 
> tested using QFileDialog (and `QFileDialog::selectedUrls()` as kate5 does, 
> and that works (on OS X; haven't had the chance to test on Linux yet).
> 
> That's what the attached patch does: no QFileDialog pointer at all, just an 
> instance.
> This RR is intended to fuel a discussion on the subject, as suggested by 
> Aleix; therefore I left the comment about the possibility of 
> invalidating/deleting the file dialog e.g. through a DBus call. Is that 
> actually a possibility, and why wouldn't it be in Kate? Are there no other 
> ways to prevent it, or check for its occurrence?
> 
> This patch also marks drkonqi as a nongui executable, a requirement on OS X 
> and which shouldn't cause any regressions elsewhere AFAIK.
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt deb8c40 
>   drkonqi/bugzillaintegration/bugzillalib.cpp 802c5fb 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp e60fb14 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp 
> 4f8f4ea 
>   drkonqi/drkonqi.cpp b12c118 
> 
> Diff: https://git.reviewboard.kde.org/r/126993/diff/
> 
> 
> Testing
> ---
> 
> On OS X 10.9.1 and Kubuntu 14.04, both with Qt 5.5.1 and KF5 5.17.0 installed 
> into /opt/local
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126993: drkonqi : fix build errors and build nongui

[René J . V . Bertin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126993/
---

(Updated Feb. 5, 2016, 3:13 p.m.)


Review request for KDE Software on Mac OS X and Plasma.


Changes
---

QFileDialog patch now tested OK on Linux too.


Repository: plasma-workspace


Description (updated)
---

While looking to build DrKonqi for OS X/MacPorts I came across a few issues 
that appear to be syntax/coding errors that, surprisingly, were never caught 
before given that they also caused compile failures when I used the same 
configure/build/packaging script on Linux.

The code uses methods that no longer exist in Qt 5.5+ : `QString::fromAscii()`, 
`QHeaderView::setResizeMod()` (replaced with 
`QHeaderView::setSectionResizeMode()` and `QInputDialog::getInteger()` (instead 
of `QInputDialog::getInt()`). Those are the easy and straightforward ones fixed 
by this patch.

The handling of file dialogs (in 2 locations) was more problematic. Both 
Apple's clang "6.0.0" and gcc 5.3 (on Linux) refused statements like 
`QWeakPointer dlg = new QFileDialog(parent,defname);` . My initial 
attempt was to follow the documentation for QWeakPointer, and do 
`QWeakPointer dlg = QSharedPointer(new 
QFileDialog(parent,defname));` but that caused a crash as soon as I clicked on 
the "save backtrace as" button - on both platforms.
It turned out that `QSharedPointer()` returned a valid (non-null) 
shared pointer, but after creating a QWeakPointer from it, `dlg.data()` 
returned NULL -- immediately.

I had a look around in the 5.17.0 frameworks codebase, and could find no 
relevant examples of using QWeakPointer; some expressions appear to be 
equivalent to the original DrKonqi code, in other locations QWeakPointer 
instances are indeed created "going through" a QSharedPointer. In the end I 
tested using QFileDialog (and `QFileDialog::selectedUrls()` as kate5 does, and 
that works (on OS X and Linux).

That's what the attached patch does: no QFileDialog pointer at all, just an 
instance.
This RR is intended to fuel a discussion on the subject, as suggested by Aleix; 
therefore I left the comment about the possibility of invalidating/deleting the 
file dialog e.g. through a DBus call. Is that actually a possibility, and why 
wouldn't it be in Kate? Are there no other ways to prevent it, or check for its 
occurrence?

This patch also marks drkonqi as a nongui executable, a requirement on OS X and 
which shouldn't cause any regressions elsewhere AFAIK.


Diffs
-

  drkonqi/CMakeLists.txt deb8c40 
  drkonqi/bugzillaintegration/bugzillalib.cpp 802c5fb 
  drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp e60fb14 
  drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp 
4f8f4ea 
  drkonqi/drkonqi.cpp b12c118 

Diff: https://git.reviewboard.kde.org/r/126993/diff/


Testing
---

On OS X 10.9.1 and Kubuntu 14.04, both with Qt 5.5.1 and KF5 5.17.0 installed 
into /opt/local


Thanks,

René J.V. Bertin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126993: drkonqi : fix build errors and build nongui

[Bhushan Shah]

> On Feb. 5, 2016, 6:59 p.m., Bhushan Shah wrote:
> > drkonqi/CMakeLists.txt, line 86
> > 
> >
> > Erm wait, drkonqi is gui program, no?
> 
> René J.V. Bertin wrote:
> Yes, but:
> - on Linux, that statement does nothing AFAIK (drkonqi continues to work 
> just fine for me)
> - on OS X, its only effect is that the executable is built as a 
> traditional POSIX executable instead of as an "app bundle". There is no 
> difference in functionality (IOW, app bundles make it easier to provide 
> features that are irrelevant to drkonqi).
> 
> I can either drop this issue, or I can make the statement conditional 
> (`if(APPLE) ...`). But note that in most if not all previous RRs I was told 
> that there was no need to make this statement conditional.

Ah okay, I wasn't aware of that. Dropped issue and sorry for noise.


- Bhushan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126993/#review92087
---


On Feb. 5, 2016, 7:43 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126993/
> ---
> 
> (Updated Feb. 5, 2016, 7:43 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> While looking to build DrKonqi for OS X/MacPorts I came across a few issues 
> that appear to be syntax/coding errors that, surprisingly, were never caught 
> before given that they also caused compile failures when I used the same 
> configure/build/packaging script on Linux.
> 
> The code uses methods that no longer exist in Qt 5.5+ : 
> `QString::fromAscii()`, `QHeaderView::setResizeMod()` (replaced with 
> `QHeaderView::setSectionResizeMode()` and `QInputDialog::getInteger()` 
> (instead of `QInputDialog::getInt()`). Those are the easy and straightforward 
> ones fixed by this patch.
> 
> The handling of file dialogs (in 2 locations) was more problematic. Both 
> Apple's clang "6.0.0" and gcc 5.3 (on Linux) refused statements like 
> `QWeakPointer dlg = new QFileDialog(parent,defname);` . My 
> initial attempt was to follow the documentation for QWeakPointer, and do 
> `QWeakPointer dlg = QSharedPointer(new 
> QFileDialog(parent,defname));` but that caused a crash as soon as I clicked 
> on the "save backtrace as" button - on both platforms.
> It turned out that `QSharedPointer()` returned a valid 
> (non-null) shared pointer, but after creating a QWeakPointer from it, 
> `dlg.data()` returned NULL -- immediately.
> 
> I had a look around in the 5.17.0 frameworks codebase, and could find no 
> relevant examples of using QWeakPointer; some expressions appear to be 
> equivalent to the original DrKonqi code, in other locations QWeakPointer 
> instances are indeed created "going through" a QSharedPointer. In the end I 
> tested using QFileDialog (and `QFileDialog::selectedUrls()` as kate5 does, 
> and that works (on OS X and Linux).
> 
> That's what the attached patch does: no QFileDialog pointer at all, just an 
> instance.
> This RR is intended to fuel a discussion on the subject, as suggested by 
> Aleix; therefore I left the comment about the possibility of 
> invalidating/deleting the file dialog e.g. through a DBus call. Is that 
> actually a possibility, and why wouldn't it be in Kate? Are there no other 
> ways to prevent it, or check for its occurrence?
> 
> This patch also marks drkonqi as a nongui executable, a requirement on OS X 
> and which shouldn't cause any regressions elsewhere AFAIK.
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt deb8c40 
>   drkonqi/bugzillaintegration/bugzillalib.cpp 802c5fb 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp e60fb14 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp 
> 4f8f4ea 
>   drkonqi/drkonqi.cpp b12c118 
> 
> Diff: https://git.reviewboard.kde.org/r/126993/diff/
> 
> 
> Testing
> ---
> 
> On OS X 10.9.1 and Kubuntu 14.04, both with Qt 5.5.1 and KF5 5.17.0 installed 
> into /opt/local
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126993: drkonqi : fix build errors and build nongui

[René J . V . Bertin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126993/#review92084
---



Not sure if this is related, but when drkonqi is launched because drkonqi 
itself crashed, it claims there is no bug reporting address. Yet there is a 
KAboutData instance; how come?

- René J.V. Bertin


On Feb. 5, 2016, 2:21 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126993/
> ---
> 
> (Updated Feb. 5, 2016, 2:21 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> While looking to build DrKonqi for OS X/MacPorts I came across a few issues 
> that appear to be syntax/coding errors that, surprisingly, were never caught 
> before given that they also caused compile failures when I used the same 
> configure/build/packaging script on Linux.
> 
> The code uses methods that no longer exist in Qt 5.5+ : 
> `QString::fromAscii()`, `QHeaderView::setResizeMod()` (replaced with 
> `QHeaderView::setSectionResizeMode()` and `QInputDialog::getInteger()` 
> (instead of `QInputDialog::getInt()`). Those are the easy and straightforward 
> ones fixed by this patch.
> 
> The handling of file dialogs (in 2 locations) was more problematic. Both 
> Apple's clang "6.0.0" and gcc 5.3 (on Linux) refused statements like 
> `QWeakPointer dlg = new QFileDialog(parent,defname);` . My 
> initial attempt was to follow the documentation for QWeakPointer, and do 
> `QWeakPointer dlg = QSharedPointer(new 
> QFileDialog(parent,defname));` but that caused a crash as soon as I clicked 
> on the "save backtrace as" button - on both platforms.
> It turned out that `QSharedPointer()` returned a valid 
> (non-null) shared pointer, but after creating a QWeakPointer from it, 
> `dlg.data()` returned NULL -- immediately.
> 
> I had a look around in the 5.17.0 frameworks codebase, and could find no 
> relevant examples of using QWeakPointer; some expressions appear to be 
> equivalent to the original DrKonqi code, in other locations QWeakPointer 
> instances are indeed created "going through" a QSharedPointer. In the end I 
> tested using QFileDialog (and `QFileDialog::selectedUrls()` as kate5 does, 
> and that works (on OS X; haven't had the chance to test on Linux yet).
> 
> That's what the attached patch does: no QFileDialog pointer at all, just an 
> instance.
> This RR is intended to fuel a discussion on the subject, as suggested by 
> Aleix; therefore I left the comment about the possibility of 
> invalidating/deleting the file dialog e.g. through a DBus call. Is that 
> actually a possibility, and why wouldn't it be in Kate? Are there no other 
> ways to prevent it, or check for its occurrence?
> 
> This patch also marks drkonqi as a nongui executable, a requirement on OS X 
> and which shouldn't cause any regressions elsewhere AFAIK.
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt deb8c40 
>   drkonqi/bugzillaintegration/bugzillalib.cpp 802c5fb 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp e60fb14 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp 
> 4f8f4ea 
>   drkonqi/drkonqi.cpp b12c118 
> 
> Diff: https://git.reviewboard.kde.org/r/126993/diff/
> 
> 
> Testing
> ---
> 
> On OS X 10.9.1 and Kubuntu 14.04, both with Qt 5.5.1 and KF5 5.17.0 installed 
> into /opt/local
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D908: [Baloo Runner] Add mime data to matches

[vhanda (Vishesh Handa)]

vhanda accepted this revision.
vhanda added a comment.
This revision is now accepted and ready to land.


  I'm guessing this is for drag and drop.
  
  Seems fairly straightforward.

INLINE COMMENTS
  runners/baloo/baloosearchrunner.cpp:180 I don't think this is required.
  
  From the QMimeData documentation http://doc.qt.io/qt-5/qmimedata.html#setUrls 
-
  
  "Since Qt 5.0, setUrls also exports the urls as plain text, if setText was 
not called before, to make it possible to drop them into any lineedit and text 
editor."

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D908

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, vhanda
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126993: drkonqi : fix build errors and build nongui

[René J . V . Bertin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126993/
---

Review request for KDE Software on Mac OS X and Plasma.


Repository: plasma-workspace


Description
---

While looking to build DrKonqi for OS X/MacPorts I came across a few issues 
that appear to be syntax/coding errors that, surprisingly, were never caught 
before given that they also caused compile failures when I used the same 
configure/build/packaging script on Linux.

The code uses methods that no longer exist in Qt 5.5+ : `QString::fromAscii()`, 
`QHeaderView::setResizeMod()` (replaced with 
`QHeaderView::setSectionResizeMode()` and `QInputDialog::getInteger()` (instead 
of `QInputDialog::getInt()`). Those are the easy and straightforward ones fixed 
by this patch.

The handling of file dialogs (in 2 locations) was more problematic. Both 
Apple's clang "6.0.0" and gcc 5.3 (on Linux) refused statements like 
`QWeakPointer dlg = new QFileDialog(parent,defname);` . My initial 
attempt was to follow the documentation for QWeakPointer, and do 
`QWeakPointer dlg = QSharedPointer(new 
QFileDialog(parent,defname));` but that caused a crash as soon as I clicked on 
the "save backtrace as" button - on both platforms.
It turned out that `QSharedPointer()` returned a valid (non-null) 
shared pointer, but after creating a QWeakPointer from it, `dlg.data()` 
returned NULL -- immediately.

I had a look around in the 5.17.0 frameworks codebase, and could find no 
relevant examples of using QWeakPointer; some expressions appear to be 
equivalent to the original DrKonqi code, in other locations QWeakPointer 
instances are indeed created "going through" a QSharedPointer. In the end I 
tested using QFileDialog (and `QFileDialog::selectedUrls()` as kate5 does, and 
that works (on OS X; haven't had the chance to test on Linux yet).

That's what the attached patch does: no QFileDialog pointer at all, just an 
instance.
This RR is intended to fuel a discussion on the subject, as suggested by Aleix; 
therefore I left the comment about the possibility of invalidating/deleting the 
file dialog e.g. through a DBus call. Is that actually a possibility, and why 
wouldn't it be in Kate? Are there no other ways to prevent it, or check for its 
occurrence?

This patch also marks drkonqi as a nongui executable, a requirement on OS X and 
which shouldn't cause any regressions elsewhere AFAIK.


Diffs
-

  drkonqi/CMakeLists.txt deb8c40 
  drkonqi/bugzillaintegration/bugzillalib.cpp 802c5fb 
  drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp e60fb14 
  drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp 
4f8f4ea 
  drkonqi/drkonqi.cpp b12c118 

Diff: https://git.reviewboard.kde.org/r/126993/diff/


Testing
---

On OS X 10.9.1 and Kubuntu 14.04, both with Qt 5.5.1 and KF5 5.17.0 installed 
into /opt/local


Thanks,

René J.V. Bertin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126993: drkonqi : fix build errors and build nongui

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126993/#review92085
---



The QLatin1String changes look fine given fromAscii is deprecated.

Not sure about the QFileDialog stuff.

- Kai Uwe Broulik


On Feb. 5, 2016, 1:21 nachm., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126993/
> ---
> 
> (Updated Feb. 5, 2016, 1:21 nachm.)
> 
> 
> Review request for KDE Software on Mac OS X and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> While looking to build DrKonqi for OS X/MacPorts I came across a few issues 
> that appear to be syntax/coding errors that, surprisingly, were never caught 
> before given that they also caused compile failures when I used the same 
> configure/build/packaging script on Linux.
> 
> The code uses methods that no longer exist in Qt 5.5+ : 
> `QString::fromAscii()`, `QHeaderView::setResizeMod()` (replaced with 
> `QHeaderView::setSectionResizeMode()` and `QInputDialog::getInteger()` 
> (instead of `QInputDialog::getInt()`). Those are the easy and straightforward 
> ones fixed by this patch.
> 
> The handling of file dialogs (in 2 locations) was more problematic. Both 
> Apple's clang "6.0.0" and gcc 5.3 (on Linux) refused statements like 
> `QWeakPointer dlg = new QFileDialog(parent,defname);` . My 
> initial attempt was to follow the documentation for QWeakPointer, and do 
> `QWeakPointer dlg = QSharedPointer(new 
> QFileDialog(parent,defname));` but that caused a crash as soon as I clicked 
> on the "save backtrace as" button - on both platforms.
> It turned out that `QSharedPointer()` returned a valid 
> (non-null) shared pointer, but after creating a QWeakPointer from it, 
> `dlg.data()` returned NULL -- immediately.
> 
> I had a look around in the 5.17.0 frameworks codebase, and could find no 
> relevant examples of using QWeakPointer; some expressions appear to be 
> equivalent to the original DrKonqi code, in other locations QWeakPointer 
> instances are indeed created "going through" a QSharedPointer. In the end I 
> tested using QFileDialog (and `QFileDialog::selectedUrls()` as kate5 does, 
> and that works (on OS X; haven't had the chance to test on Linux yet).
> 
> That's what the attached patch does: no QFileDialog pointer at all, just an 
> instance.
> This RR is intended to fuel a discussion on the subject, as suggested by 
> Aleix; therefore I left the comment about the possibility of 
> invalidating/deleting the file dialog e.g. through a DBus call. Is that 
> actually a possibility, and why wouldn't it be in Kate? Are there no other 
> ways to prevent it, or check for its occurrence?
> 
> This patch also marks drkonqi as a nongui executable, a requirement on OS X 
> and which shouldn't cause any regressions elsewhere AFAIK.
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt deb8c40 
>   drkonqi/bugzillaintegration/bugzillalib.cpp 802c5fb 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp e60fb14 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp 
> 4f8f4ea 
>   drkonqi/drkonqi.cpp b12c118 
> 
> Diff: https://git.reviewboard.kde.org/r/126993/diff/
> 
> 
> Testing
> ---
> 
> On OS X 10.9.1 and Kubuntu 14.04, both with Qt 5.5.1 and KF5 5.17.0 installed 
> into /opt/local
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126993: drkonqi : fix build errors and build nongui

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126993/#review92087
---




drkonqi/CMakeLists.txt (line 86)


Erm wait, drkonqi is gui program, no?


- Bhushan Shah


On Feb. 5, 2016, 6:51 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126993/
> ---
> 
> (Updated Feb. 5, 2016, 6:51 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> While looking to build DrKonqi for OS X/MacPorts I came across a few issues 
> that appear to be syntax/coding errors that, surprisingly, were never caught 
> before given that they also caused compile failures when I used the same 
> configure/build/packaging script on Linux.
> 
> The code uses methods that no longer exist in Qt 5.5+ : 
> `QString::fromAscii()`, `QHeaderView::setResizeMod()` (replaced with 
> `QHeaderView::setSectionResizeMode()` and `QInputDialog::getInteger()` 
> (instead of `QInputDialog::getInt()`). Those are the easy and straightforward 
> ones fixed by this patch.
> 
> The handling of file dialogs (in 2 locations) was more problematic. Both 
> Apple's clang "6.0.0" and gcc 5.3 (on Linux) refused statements like 
> `QWeakPointer dlg = new QFileDialog(parent,defname);` . My 
> initial attempt was to follow the documentation for QWeakPointer, and do 
> `QWeakPointer dlg = QSharedPointer(new 
> QFileDialog(parent,defname));` but that caused a crash as soon as I clicked 
> on the "save backtrace as" button - on both platforms.
> It turned out that `QSharedPointer()` returned a valid 
> (non-null) shared pointer, but after creating a QWeakPointer from it, 
> `dlg.data()` returned NULL -- immediately.
> 
> I had a look around in the 5.17.0 frameworks codebase, and could find no 
> relevant examples of using QWeakPointer; some expressions appear to be 
> equivalent to the original DrKonqi code, in other locations QWeakPointer 
> instances are indeed created "going through" a QSharedPointer. In the end I 
> tested using QFileDialog (and `QFileDialog::selectedUrls()` as kate5 does, 
> and that works (on OS X; haven't had the chance to test on Linux yet).
> 
> That's what the attached patch does: no QFileDialog pointer at all, just an 
> instance.
> This RR is intended to fuel a discussion on the subject, as suggested by 
> Aleix; therefore I left the comment about the possibility of 
> invalidating/deleting the file dialog e.g. through a DBus call. Is that 
> actually a possibility, and why wouldn't it be in Kate? Are there no other 
> ways to prevent it, or check for its occurrence?
> 
> This patch also marks drkonqi as a nongui executable, a requirement on OS X 
> and which shouldn't cause any regressions elsewhere AFAIK.
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt deb8c40 
>   drkonqi/bugzillaintegration/bugzillalib.cpp 802c5fb 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp e60fb14 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp 
> 4f8f4ea 
>   drkonqi/drkonqi.cpp b12c118 
> 
> Diff: https://git.reviewboard.kde.org/r/126993/diff/
> 
> 
> Testing
> ---
> 
> On OS X 10.9.1 and Kubuntu 14.04, both with Qt 5.5.1 and KF5 5.17.0 installed 
> into /opt/local
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126811: Emit contextualAppletsAboutToShow in systemtray

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126811/
---

(Updated Feb. 6, 2016, 2 a.m.)


Review request for Plasma.


Changes
---

At least this one compiles... Still not really tested. Kai, what was the bug 
you reported this over?


Repository: plasma-workspace


Description
---

Normally done by the containment interface

BUG: 358119


Diffs (updated)
-

  applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp 
1afaf145bace331f39405d044590c6b0688146af 

Diff: https://git.reviewboard.kde.org/r/126811/diff/


Testing
---

Literally none. I assume Kai has something.


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel