[Differential] [Closed] D1726: Introduce a test server

[Martin Gräßlin]

graesslin closed this revision.
graesslin added a comment.


  pushed with 
https://phabricator.kde.org/rKWAYLAND37f7cb99535d8fdcfc16ad99c045bddb67798b45 - 
seems to not have been picked up as I added a changelog entry.

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1726

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, sebas, #plasma, bshah
Cc: sebas, bshah, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1742: Make udev seriously mandatory

[Martin Gräßlin]

graesslin added a comment.


  @broulik: why is udev mandatory? It's not supported by BSDs and in KWin it's 
optional due to that.

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D1742

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, broulik
Cc: graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 82 lines] D1742: Make udev seriously mandatory

[bshah (Bhushan Shah)]

bshah created this revision.
bshah added reviewers: Plasma, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  
https://phabricator.kde.org/rPOWERDEVIL73e13daef13d38948b1194d2d1103404fdd808b7 
done just half work of ripping of HAVE_UDEV in c++ code,
  this however didn't remove the UDEV_FOUND ifdefs from the cmake code, so
  this UDEV_FOUND ifs in cmake code makes very less sense.

TEST PLAN
  builds

REPOSITORY
  rPOWERDEVIL Powerdevil

BRANCH
  udev-mandatory

REVISION DETAIL
  https://phabricator.kde.org/D1742

AFFECTED FILES
  daemon/BackendConfig.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, broulik
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Changed Subscribers] D1735: Notify about low peripheral batteries (mouse, keyboard)

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> PowerDevilSettings.kcfg:35
> +
> +  10
> +

Given the experience with my trackball: I think I used it for another half year 
once it dropped below 10 %

> powerdevilcore.cpp:508
> +msg = i18n("The battery in your keyboard is low, and the 
> device may turn itself off at any time. "
> +   "Please replace or charge the battery as soon as 
> possible.");
> +icon = QStringLiteral("input-keyboard");

In English that's fine, but in e.g. a German translation it would be horrible 
to suggest to charge a battery. (For non German speakers: a "Batterie" is the 
non-rechargeable one, an "Akku" is the rechargeable one). Given that it needs 
i18nc

> GeneralPage.cpp:123
>  connect(criticalSpin, SIGNAL(valueChanged(int)), SLOT(changed()));
> +connect(lowPeripheralSpin, SIGNAL(valueChanged(int)), SLOT(changed()));
>  

new connect syntax?

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D1735

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 349411] Horizontal and vertical task buttons should have consistent margin sizes

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=349411

Eike Hein  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
 CC||h...@kde.org

--- Comment #9 from Eike Hein  ---
There are no changes planned to this at this time - that's just a theme that
needs fixing.

The Breeze theme bugs mentioned in comment #7 got fixed since, I forgot to
update the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1738: [startkde] Set QT_WAYLAND_FORCE_DPI from startplasmacompositor

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  force-dpi-startplasmacompositor

REVISION DETAIL
  https://phabricator.kde.org/D1738

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, sebas
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1732: [Kickoff] Use a single MouseArea for opening user manager

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1732

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, sebas
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1691: kfontinst: Port to Qt widget classes

[volkov (Alexander Volkov)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPd0ac79bae59a: kfontinst: Port to Qt widget 
classes (authored by volkov).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1691?vs=4011&id=4149

REVISION DETAIL
  https://phabricator.kde.org/D1691

AFFECTED FILES
  kcms/kfontinst/kcmfontinst/FontFilter.h
  kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
  kcms/kfontinst/kcmfontinst/KCmFontInst.h
  kcms/kfontinst/viewpart/FontViewPart.cpp
  kcms/kfontinst/viewpart/FontViewPart.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volkov, #plasma, graesslin
Cc: graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1692: kfontinst: Port away from Kdelibs4Support

[volkov (Alexander Volkov)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPc2944ed823ad: kfontinst: Port away from 
Kdelibs4Support (authored by volkov).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1692?vs=4012&id=4150

REVISION DETAIL
  https://phabricator.kde.org/D1692

AFFECTED FILES
  kcms/kfontinst/apps/CMakeLists.txt
  kcms/kfontinst/apps/CreateParent.h
  kcms/kfontinst/dbus/CMakeLists.txt
  kcms/kfontinst/dbus/Folder.cpp
  kcms/kfontinst/kcmfontinst/CMakeLists.txt
  kcms/kfontinst/kcmfontinst/DuplicatesDialog.cpp
  kcms/kfontinst/kcmfontinst/JobRunner.cpp
  kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
  kcms/kfontinst/kio/KioFonts.cpp
  kcms/kfontinst/lib/CMakeLists.txt
  kcms/kfontinst/lib/FcEngine.cpp
  kcms/kfontinst/lib/WritingSystems.cpp
  kcms/kfontinst/lib/kfontinst_export.h
  kcms/kfontinst/thumbnail/FontThumbnail.h
  kcms/kfontinst/viewpart/FontViewPart.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volkov, #plasma, davidedmundson
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 4 lines] D1738: [startkde] Set QT_WAYLAND_FORCE_DPI from startplasmacompositor

[Martin Gräßlin]

graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This change makes the force DPI combobox in fonts kcm work in a
  Wayland session for QtWayland applications and KWin.
  
  If the config value is set it's mapped into QT_WAYLAND_FORCE_DPI
  environment variable.

TEST PLAN
  Enabled the config, restarted my session and enjoyed
  properly sized Uis and fonts.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  force-dpi-startplasmacompositor

REVISION DETAIL
  https://phabricator.kde.org/D1738

AFFECTED FILES
  startkde/startplasmacompositor.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1691: kfontinst: Port to Qt widget classes

[volkov (Alexander Volkov)]

volkov added a comment.


  Thanks.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1691

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volkov, #plasma, graesslin
Cc: graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 10 lines] D1737: [Desktop Containment] Remove debug elements

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Some of them were even needlessly created.

TEST PLAN
  Are these still useful?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1737

AFFECTED FILES
  containments/desktop/package/contents/ui/ActionButton.qml
  containments/desktop/package/contents/ui/AppletAppearance.qml
  containments/desktop/package/contents/ui/AppletHandle.qml
  containments/desktop/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128074: [libkscreen] [Backend Manager] emitBackendReady() only after fetching the config finishes

[Sebastian Kügler]

> On June 1, 2016, 2:19 p.m., Sebastian Kügler wrote:
> > I've gone over the handlers for backendReady, and none of them is actually 
> > used to request a config then (that's encapsulated in backendmanager), so 
> > requesting a config before the backend is announced ready makes sense.
> 
> Kai Uwe Broulik wrote:
> 5.6 or better play safe and master?

I'm leaning towards master. 5.6.5 won't have follow-ups, so we have no way of 
correcting this. 5.7 will fix a bunch more multiscreen issues, and this one is 
a nice addition.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128074/#review96138
---


On June 1, 2016, 1:30 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128074/
> ---
> 
> (Updated June 1, 2016, 1:30 p.m.)
> 
> 
> Review request for Plasma, Daniel Vrátil and Sebastian Kügler.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> Without a valid config in the BackendManager, KScreen::Config::canBeApplied 
> always returns false causing KScreen to ignore any stored config on startup 
> sometimes. Wait until we have a config before telling that the backend is 
> ready.
> 
> 
> Diffs
> -
> 
>   src/backendmanager.cpp 570f575 
> 
> Diff: https://git.reviewboard.kde.org/r/128074/diff/
> 
> 
> Testing
> ---
> 
> I can now start kded5 from console without it falling back to an "ideal" 
> config.
> 
> Didn't do much testing, though. Might have unwanted side-effects.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1730: address race condition around setoperation

[Sebastian Kügler]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKSCREEN17199d32f292: address race condition around 
setoperation (authored by sebas).

REPOSITORY
  rKSCREEN KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1730?vs=4136&id=4137

REVISION DETAIL
  https://phabricator.kde.org/D1730

AFFECTED FILES
  kded/daemon.cpp
  kded/daemon.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, graesslin
Cc: plasma-devel, #plasma, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1736: Use QObject's parent to memory-manage the timers

[Sebastian Kügler]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKSCREEN13a03dc11bb0: Use QObject's parent to memory-manage 
the timers (authored by sebas).

REPOSITORY
  rKSCREEN KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1736?vs=4139&id=4140

REVISION DETAIL
  https://phabricator.kde.org/D1736

AFFECTED FILES
  kded/daemon.cpp
  kded/daemon.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, graesslin
Cc: plasma-devel, #plasma, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1727: Add a test case for KIdleTime

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLANDINTEGRATION3fa0d000a2a1: Add a test case for 
KIdleTime (authored by graesslin).

REPOSITORY
  rKWAYLANDINTEGRATION Frameworks integration plugin using KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1727?vs=4095&id=4141

REVISION DETAIL
  https://phabricator.kde.org/D1727

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/idletime/CMakeLists.txt
  autotests/idletime/idle_test.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, bshah
Cc: bshah, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1736: Use QObject's parent to memory-manage the timers

[Martin Gräßlin]

graesslin added a comment.


  As I cannot accept again: ShipIt

REPOSITORY
  rKSCREEN KScreen

BRANCH
  sebas/timer-parenting

REVISION DETAIL
  https://phabricator.kde.org/D1736

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, graesslin
Cc: plasma-devel, #plasma, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 16 lines] D1736: Use QObject's parent to memory-manage the timers

[Sebastian Kügler]

sebas updated this revision to Diff 4139.
sebas added a comment.


  - Use QScopedPointer for the elapsed timer

REPOSITORY
  rKSCREEN KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1736?vs=4138&id=4139

BRANCH
  sebas/timer-parenting

REVISION DETAIL
  https://phabricator.kde.org/D1736

AFFECTED FILES
  kded/daemon.cpp
  kded/daemon.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, graesslin
Cc: plasma-devel, #plasma, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 12 lines] D1736: Use QObject's parent to memory-manage the timers

[Sebastian Kügler]

sebas created this revision.
sebas added a reviewer: graesslin.
sebas added a subscriber: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Use QObject's memory management tricks by parenting the timers.

TEST PLAN
  kded5 still works

REPOSITORY
  rKSCREEN KScreen

BRANCH
  sebas/timer-parenting

REVISION DETAIL
  https://phabricator.kde.org/D1736

AFFECTED FILES
  kded/daemon.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, graesslin
Cc: plasma-devel, #plasma, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1736: Use QObject's parent to memory-manage the timers

[Martin Gräßlin]

graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rKSCREEN KScreen

BRANCH
  sebas/timer-parenting

REVISION DETAIL
  https://phabricator.kde.org/D1736

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, graesslin
Cc: plasma-devel, #plasma, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1730: address race condition around setoperation

[Martin Gräßlin]

graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rKSCREEN KScreen

BRANCH
  sebas/setop-race

REVISION DETAIL
  https://phabricator.kde.org/D1730

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, graesslin
Cc: plasma-devel, #plasma, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 15 lines] D1730: address race condition around setoperation

[Sebastian Kügler]

sebas updated this revision to Diff 4136.
sebas added a comment.


  - --debug and invalidate

REPOSITORY
  rKSCREEN KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1730?vs=4135&id=4136

BRANCH
  sebas/setop-race

REVISION DETAIL
  https://phabricator.kde.org/D1730

AFFECTED FILES
  kded/daemon.cpp
  kded/daemon.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, graesslin
Cc: plasma-devel, #plasma, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Requested Changes To] D1730: address race condition around setoperation

[Martin Gräßlin]

graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> daemon.cpp:190
>  {
> +qCDebug(KSCREEN_KDED) << "QET" << m_changeBlockTimer->isValid() << 
> m_changeBlockTimer->hasExpired(100) << m_changeBlockTimer->elapsed();
> +if (m_changeBlockTimer->isValid() && 
> !m_changeBlockTimer->hasExpired(100)) {

never call elapsed on a not valid timer! The behavior is undefined.

> daemon.cpp:195
> +return;
> +}
>  qCDebug(KSCREEN_KDED) << "Change detected";

I suggest to do the invalidate as I suggested as it frees up resources.

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D1730

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, graesslin
Cc: plasma-devel, #plasma, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 231 lines] D1735: Notify about low peripheral batteries (mouse, keyboard)When the battery in a non-power supply battery drops below 10% (configurable)a notification is shown t

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  ...Initial support for peripheral battery notifications
  
  When the battery in a non-power supply battery drops below 10% it emits a 
notification.
  
  Missing:
  
  - Don't notify when battery is not present (otherwise will have 0%)
  - Notify when new device is plugged in
  - Messages for other batteries than mouse and keyboard(?)
  
  It does not yet chec
  
  Initial support for peripheral battery notifications
  
  When the battery in a non-power supply battery drops below 10% it emits a 
notification.
  
  Missing:
  
  - Don't notify when battery is not present (otherwise will have 0%)
  - Notify when new device is plugged in
  - Messages for other batteries than mouse and keyboard(?)
  
  It does not yet chec
  
  [Profiles KCM] Add spinbox for changing the low peripheral battery threshold
  
  Notify about low peripheral devices on startup similar to what we do with the 
laptop battery
  
  Improve wording of notifications
  
  Always show the name of the device. It might by cryptic, so we'll have to
  monitor how that turns out. In any case the affected device type (mouse, 
keyboard, ...)
  is indicated by both the icon and the notification body text.
  
  Remove m_batteriesUdi QStringList
  
  We can just use the keys of m_batteriesPercent instead like
  we already do for peripheral devices
  
  Merge branch 'broulik/notifyPeripherals' of git://anongit.kde.org/powerdevil 
into broulik/notifyPeripherals
  
  Notify about low peripherals when plugging them in
  
  Unfortunately my mouse reports info only periodically, so when plugging
  it in it is always "not present" and 0%, so it doesn't show for me.
  Also, when the device is really empty (so won't work) it won't show
  anything either because it won't be "present". Oh, well...

TEST PLAN
  So far I have only tested this with my mouse on a desktop computer,
  starting kded5 brings the notification. Needs more testing with a laptop so it
  didn't break the default battery handling

REPOSITORY
  rPOWERDEVIL Powerdevil

BRANCH
  broulik/notifyPeripherals

REVISION DETAIL
  https://phabricator.kde.org/D1735

AFFECTED FILES
  PowerDevilSettings.kcfg
  daemon/powerdevilcore.cpp
  daemon/powerdevilcore.h
  kcmodule/global/GeneralPage.cpp
  kcmodule/global/generalPage.ui
  powerdevil.notifyrc

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 15 lines] D1730: address race condition around setoperation

[Sebastian Kügler]

sebas updated this revision to Diff 4135.
sebas added a comment.


  - Use QElapsedTimer instead of QTimer

REPOSITORY
  rKSCREEN KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1730?vs=4103&id=4135

BRANCH
  sebas/setop-race

REVISION DETAIL
  https://phabricator.kde.org/D1730

AFFECTED FILES
  kded/daemon.cpp
  kded/daemon.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, graesslin
Cc: plasma-devel, #plasma, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128074: [libkscreen] [Backend Manager] emitBackendReady() only after fetching the config finishes

[Kai Uwe Broulik]

> On Juni 1, 2016, 2:19 nachm., Sebastian Kügler wrote:
> > I've gone over the handlers for backendReady, and none of them is actually 
> > used to request a config then (that's encapsulated in backendmanager), so 
> > requesting a config before the backend is announced ready makes sense.

5.6 or better play safe and master?


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128074/#review96138
---


On Juni 1, 2016, 1:30 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128074/
> ---
> 
> (Updated Juni 1, 2016, 1:30 nachm.)
> 
> 
> Review request for Plasma, Daniel Vrátil and Sebastian Kügler.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> Without a valid config in the BackendManager, KScreen::Config::canBeApplied 
> always returns false causing KScreen to ignore any stored config on startup 
> sometimes. Wait until we have a config before telling that the backend is 
> ready.
> 
> 
> Diffs
> -
> 
>   src/backendmanager.cpp 570f575 
> 
> Diff: https://git.reviewboard.kde.org/r/128074/diff/
> 
> 
> Testing
> ---
> 
> I can now start kded5 from console without it falling back to an "ideal" 
> config.
> 
> Didn't do much testing, though. Might have unwanted side-effects.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1735: Notify about low peripheral batteries (mouse, keyboard)

[broulik (Kai Uwe Broulik)]

broulik updated the summary for this revision.

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D1735

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1735: Notify about low peripheral batteries (mouse, keyboard)

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  F139915: Screenshot_20160601_154635.png 
  
  F139917: Screenshot_20160601_155244.png 

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D1735

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128074: [libkscreen] [Backend Manager] emitBackendReady() only after fetching the config finishes

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128074/#review96138
---


Ship it!




I've gone over the handlers for backendReady, and none of them is actually used 
to request a config then (that's encapsulated in backendmanager), so requesting 
a config before the backend is announced ready makes sense.

- Sebastian Kügler


On June 1, 2016, 1:30 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128074/
> ---
> 
> (Updated June 1, 2016, 1:30 p.m.)
> 
> 
> Review request for Plasma, Daniel Vrátil and Sebastian Kügler.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> Without a valid config in the BackendManager, KScreen::Config::canBeApplied 
> always returns false causing KScreen to ignore any stored config on startup 
> sometimes. Wait until we have a config before telling that the backend is 
> ready.
> 
> 
> Diffs
> -
> 
>   src/backendmanager.cpp 570f575 
> 
> Diff: https://git.reviewboard.kde.org/r/128074/diff/
> 
> 
> Testing
> ---
> 
> I can now start kded5 from console without it falling back to an "ideal" 
> config.
> 
> Didn't do much testing, though. Might have unwanted side-effects.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1735: Notify about low peripheral batteries (mouse, keyboard)

[broulik (Kai Uwe Broulik)]

broulik retitled this revision from "Notify about low peripheral batteries 
(mouse, keyboard)

When the battery in a non-power supply battery drops below 10% (configurable)
a notification is shown to the user so he or she is not surprised when the
device suddenly stops working.

===..." to "Notify about low peripheral batteries (mouse, keyboard)".
broulik updated the summary for this revision.
broulik added a reviewer: Plasma: Design.

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D1735

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 349411] Horizontal and vertical task buttons should have consistent margin sizes

[apache via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=349411

--- Comment #8 from apache  ---
It's a long time since last comment - almost a year. Can we expect some changes
any time soon?

Icons on panel on task manager are ridiculously small in relation to panel
size. Not only in active task but in launchers as well.
http://i.imgur.com/4thkFmp.png

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1734: [server] Properly handle the case that a PlasmaWindow is unmapped before client bound it

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLANDb1bbb908114f: [server] Properly handle the case that 
a PlasmaWindow is unmapped before… (authored by graesslin).

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1734?vs=4132&id=4133

REVISION DETAIL
  https://phabricator.kde.org/D1734

AFFECTED FILES
  autotests/client/test_wayland_windowmanagement.cpp
  src/server/plasmawindowmanagement_interface.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, sebas
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1726: Introduce a test server

[Sebastian Kügler]

sebas added a comment.


  Changes look good.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  test-server

REVISION DETAIL
  https://phabricator.kde.org/D1726

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, sebas, #plasma, bshah
Cc: sebas, bshah, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1691: kfontinst: Port to Qt widget classes

[Martin Gräßlin]

graesslin accepted this revision.
graesslin added a reviewer: graesslin.
graesslin added a comment.
This revision is now accepted and ready to land.


  sorry that you had to ping. I guess nobody is really familiar with the code.
  
  The change looks good to me and makes sense, so I give you the ShipIt.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1691

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volkov, #plasma, graesslin
Cc: graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1734: [server] Properly handle the case that a PlasmaWindow is unmapped before client bound it

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  plasma-window-destroy

REVISION DETAIL
  https://phabricator.kde.org/D1734

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, sebas
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 42 lines] D1734: [server] Properly handle the case that a PlasmaWindow is unmapped before client bound it

[Martin Gräßlin]

graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  So far we directly destroyed the resource on the server side. But this
  causes a wayland error when the client tries to cleanup. This results in
  the client being destroyed. A problem which brings down plasmashell
  regularly when short living windows are shown. This happens e.g. in
  Dolphin with the adress auto complete.
  
  This change addresses the problem by creating a temporary
  PlasmaWindowInterface for the already unmapped window. It doesn't get
  added to the list of known windows and it's only purpose is to properly
  handle the unmap and the destroy of the just created resource.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  plasma-window-destroy

REVISION DETAIL
  https://phabricator.kde.org/D1734

AFFECTED FILES
  autotests/client/test_wayland_windowmanagement.cpp
  src/server/plasmawindowmanagement_interface.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 128074: [libkscreen] [Backend Manager] emitBackendReady() only after fetching the config finishes

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128074/
---

Review request for Plasma, Daniel Vrátil and Sebastian Kügler.


Repository: libkscreen


Description
---

Without a valid config in the BackendManager, KScreen::Config::canBeApplied 
always returns false causing KScreen to ignore any stored config on startup 
sometimes. Wait until we have a config before telling that the backend is ready.


Diffs
-

  src/backendmanager.cpp 570f575 

Diff: https://git.reviewboard.kde.org/r/128074/diff/


Testing
---

I can now start kded5 from console without it falling back to an "ideal" config.

Didn't do much testing, though. Might have unwanted side-effects.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1691: kfontinst: Port to Qt widget classes

[volkov (Alexander Volkov)]

volkov added a comment.


  ping

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1691

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volkov, #plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128073: Make Wayland optional

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128073/#review96137
---



Speaking with the maintainer's hat on: I don't want this.

Here are the reasons:
- We are short on manpower, adding a build option makes this worse as we now 
have to maintain different versions of the build
- It's not going to be autotested on KDE CI
- I don't have the time to tell users that they have to rebuild libkscreen with 
wayland enabled to fix their systems
- I can't guarantee that changes we make in the future won't require wayland, 
and I'm not willing to invest time into making sure it still builds in both 
configurations

I understand that for some, it's important to have no wayland deps (be these 
reasons valid or not), but for us it's causing more work and for the sake of 
our users, I'm making the call that we concentrate on bugs our users report, 
not on making our builds more complex, because that would achieve the opposite.

So, NAK.

- Sebastian Kügler


On June 1, 2016, 8:10 a.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128073/
> ---
> 
> (Updated June 1, 2016, 8:10 a.m.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, Martin Gräßlin, and 
> Sebastian Kügler.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> Look for KF5Wayland as optional package, not building all the Wayland-related 
> code (backend, additions to tests, DPMS support in kscreen-doctor) if it is 
> not available.
> 
> This allows libkscreen to build again on platforms without Wayland, such as 
> non-Linux or old Linux distros.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9c834d9500fa0b89764516464bd58e835671977b 
>   autotests/CMakeLists.txt 2c8ee3d2021b1222072d6a1faafaff1b336d27e3 
>   backends/CMakeLists.txt 3563e138454edcc0c874237745123b09077d067c 
>   src/doctor/CMakeLists.txt 7294d88af127a6604bc7e48e16342c93f152de8c 
>   src/doctor/doctor.cpp a156f006212e63c155a6f643929d0a5880275731 
>   tests/CMakeLists.txt 1489d21383e13cd1431a81d48b4a272c28302041 
> 
> Diff: https://git.reviewboard.kde.org/r/128073/diff/
> 
> 
> Testing
> ---
> 
> Builds fine.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1724: Import Task Manager widgets ports to the new library.

[hein (Eike Hein)]

hein added inline comments.

INLINE COMMENTS

> mart wrote in Task.qml:203
> maybe using an inline Component{} ?

Leaving that to Kai (this is not new code, and his)

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1724

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: mart, broulik, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Changed Subscribers] D1724: Import Task Manager widgets ports to the new library.

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> Task.qml:203
> +var smartLauncher = Qt.createQmlObject("
> +import org.kde.plasma.private.taskmanager 0.1 as TaskManagerApplet;
> +TaskManagerApplet.SmartLauncherItem { }", task);

maybe using an inline Component{} ?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1724

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: mart, broulik, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1732: [Kickoff] Use a single MouseArea for opening user manager

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  Probably better put that in 5.6.5 branch and then resolve the conflict by 
adding the new in 5.7
  
visible: KCMShell.authorize("user_manager.desktop").length > 0

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1732

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 25 lines] D1732: [Kickoff] Use a single MouseArea for opening user manager

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Avoid code duplication which has already lead to inconsistencies.
  
  BUG: 363528
  FIXED-IN: 5.7.0

TEST PLAN
  Chosed an avatar, click, worked
  Removed my avatar, click, worked

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1732

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128073: Make Wayland optional

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128073/#review96135
---



Just to be clear: by doing the review, I do not change my mind. This is just 
for the case that the maintainer decides differently.


backends/CMakeLists.txt (lines 11 - 16)


use feature_summary instead of messages



src/doctor/CMakeLists.txt (lines 1 - 3)


use a proper configure file instead of adding definitions as compile flags



src/doctor/doctor.cpp (line 115)


qCWarning instead of cerr



src/doctor/doctor.cpp (lines 122 - 141)


what's the point of having setDpms method around if the implementation is 
ifdefed?



src/doctor/doctor.cpp (lines 144 - 155)


same here - the method is pointless


- Martin Gräßlin


On June 1, 2016, 10:10 a.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128073/
> ---
> 
> (Updated June 1, 2016, 10:10 a.m.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, Martin Gräßlin, and 
> Sebastian Kügler.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> Look for KF5Wayland as optional package, not building all the Wayland-related 
> code (backend, additions to tests, DPMS support in kscreen-doctor) if it is 
> not available.
> 
> This allows libkscreen to build again on platforms without Wayland, such as 
> non-Linux or old Linux distros.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9c834d9500fa0b89764516464bd58e835671977b 
>   autotests/CMakeLists.txt 2c8ee3d2021b1222072d6a1faafaff1b336d27e3 
>   backends/CMakeLists.txt 3563e138454edcc0c874237745123b09077d067c 
>   src/doctor/CMakeLists.txt 7294d88af127a6604bc7e48e16342c93f152de8c 
>   src/doctor/doctor.cpp a156f006212e63c155a6f643929d0a5880275731 
>   tests/CMakeLists.txt 1489d21383e13cd1431a81d48b4a272c28302041 
> 
> Diff: https://git.reviewboard.kde.org/r/128073/diff/
> 
> 
> Testing
> ---
> 
> Builds fine.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128073: Make Wayland optional

[Martin Gräßlin]

> On June 1, 2016, 10:13 a.m., Martin Gräßlin wrote:
> > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation 
> > why we don't want this.
> 
> Pino Toscano wrote:
> Nowhere there is discussed (only briefly mentioned) about support with 
> non-Linux platforms; considering libkscreen is a library used by components 
> (and also external ones, like the display configuration in LxQt), then it 
> makes sense to me making it portable.
> 
> Making wayland mandatory in libkscreen (and also in other modules, like 
> plasma-integration, kwin, kscreenlocker) means killing outright any attempt 
> to make Plasma build on non-Linux platforms.  Please reconsider this, thanks.
> 
> Martin Gräßlin wrote:
> which non-Linux platforms which we care about don't have Wayland? Before 
> making KWayland a mandatory dependency in Plasma we did check with distro 
> packagers. Everyone was fine with it.
> 
> Pino Toscano wrote:
> At least to my reading of Wayland sources, to build the libraries you 
> need features like signalfd and timerfd, which are non-POSIX and available 
> only on Linux.
> 
> Can you please point me to the discussion you had with distro packagers?
> 
> Martin Gräßlin wrote:
> There are non-linux which have successfully run Weston on a DRM backend. 
> That was in the news a few weeks back, see e.g. 
> http://lists.dragonflybsd.org/pipermail/users/2016-May/249620.html
> 
> So let's go from "theoretically not possible" to "practically not 
> possible". Where is it not possible to have a Wayland dependency?
> 
> Concerning the discussion: a quick search showed me 
> https://mail.kde.org/pipermail/kde-distro-packagers/2015-July/76.html, 
> but there must be an older one already as we use it in plasma-workspace 
> (kscreenlocker) since Plasma 5.2 IIRC. This makes it difficult for me to 
> point you to the discussion as it's really a long time ago.
> 
> Bhushan Shah wrote:
> https://mail.kde.org/pipermail/release-team/2015-July/008725.html
> 
> Pino Toscano wrote:
> > 
> https://mail.kde.org/pipermail/kde-distro-packagers/2015-July/76.html
> > https://mail.kde.org/pipermail/release-team/2015-July/008725.html
> 
> The only party involved there is a Slackware packager, which is a Linux 
> distro (where the Wayland libraries can be built fine). I don't see anyone 
> mentioning non-Linux support.
> 
> > There are non-linux which have successfully run Weston on a DRM 
> backend. That was in the news a few weeks back, see e.g. 
> http://lists.dragonflybsd.org/pipermail/users/2016-May/249620.html
> 
> That's the second attempt at this I see (the first one was beginning of 
> 2013 IIRC), yet none of this code as been upstreamed yet.
> 
> Martin Gräßlin wrote:
> > I don't see anyone mentioning non-Linux support.
> 
> All we can do is ask, sorry.
> 
> > That's the second attempt at this I see (the first one was beginning of 
> 2013 IIRC), yet none of this code as been upstreamed yet.
> 
> Well I find it strange that I got code from BSD users for new KWin. If it 
> were impossible to build KWin anymore that wouldn't work ;-)
> 
> Pino Toscano wrote:
> > All we can do is ask, sorry.
> 
> Possibly not closing the door would help as well.
> 
> > Well I find it strange that I got code from BSD users for new KWin. If 
> it were impossible to build KWin anymore that wouldn't work ;-)
> 
> Well, I still see that kwin has kwayland and kscreenlocker as mandatory 
> build dependencies, and kscreenlocker has kwayland as mandatory build 
> dependency.  Hence they are using non-upstreamed patches, which is something 
> I don't want to rely on.
> 
> Do you have pointers to these contributions for BSD?

> Possibly not closing the door would help as well.

There's a time to discuss things. A year later it's sometimes too late. I can 
understand that this is a tricky situation, but it's also for us rather tricky 
if we would want to paddle back now. It also raises the question why we should 
ask at all. If I ask and don't get an answer, I have to interpret it as it 
won't cause problems.

> Well, I still see that kwin has kwayland and kscreenlocker as mandatory build 
> dependencies,

And in KWin we cannot go back anymore. KWin is a Wayland compositor which 
happened to be an X11 window manager in it's past. We can talk about making X11 
optional, but not Wayland.

> and kscreenlocker has kwayland as mandatory build dependency.

KScreenLocker uses kwayland as a private and secure communication channel 
between deamon and greeter. Removing it would break kscreenlocker, reverting 
that part would result in security vulnerabilities. In addition it has Wayland 
specific code for KWin on Wayland.

Sorry also like in the case of KWin: it's too late to go back.

> Do you have pointers to these contributions for BSD?

e.g. https://phabricator.kde.org/D1425 - but there were more

[Differential] [Accepted] D1723: Rename Task Manager applets out of the way of rewrites.

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.


  that should go in asap

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1723

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma, mart
Cc: mart, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128073: Make Wayland optional

[Pino Toscano]

> On June 1, 2016, 8:13 a.m., Martin Gräßlin wrote:
> > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation 
> > why we don't want this.
> 
> Pino Toscano wrote:
> Nowhere there is discussed (only briefly mentioned) about support with 
> non-Linux platforms; considering libkscreen is a library used by components 
> (and also external ones, like the display configuration in LxQt), then it 
> makes sense to me making it portable.
> 
> Making wayland mandatory in libkscreen (and also in other modules, like 
> plasma-integration, kwin, kscreenlocker) means killing outright any attempt 
> to make Plasma build on non-Linux platforms.  Please reconsider this, thanks.
> 
> Martin Gräßlin wrote:
> which non-Linux platforms which we care about don't have Wayland? Before 
> making KWayland a mandatory dependency in Plasma we did check with distro 
> packagers. Everyone was fine with it.
> 
> Pino Toscano wrote:
> At least to my reading of Wayland sources, to build the libraries you 
> need features like signalfd and timerfd, which are non-POSIX and available 
> only on Linux.
> 
> Can you please point me to the discussion you had with distro packagers?
> 
> Martin Gräßlin wrote:
> There are non-linux which have successfully run Weston on a DRM backend. 
> That was in the news a few weeks back, see e.g. 
> http://lists.dragonflybsd.org/pipermail/users/2016-May/249620.html
> 
> So let's go from "theoretically not possible" to "practically not 
> possible". Where is it not possible to have a Wayland dependency?
> 
> Concerning the discussion: a quick search showed me 
> https://mail.kde.org/pipermail/kde-distro-packagers/2015-July/76.html, 
> but there must be an older one already as we use it in plasma-workspace 
> (kscreenlocker) since Plasma 5.2 IIRC. This makes it difficult for me to 
> point you to the discussion as it's really a long time ago.
> 
> Bhushan Shah wrote:
> https://mail.kde.org/pipermail/release-team/2015-July/008725.html
> 
> Pino Toscano wrote:
> > 
> https://mail.kde.org/pipermail/kde-distro-packagers/2015-July/76.html
> > https://mail.kde.org/pipermail/release-team/2015-July/008725.html
> 
> The only party involved there is a Slackware packager, which is a Linux 
> distro (where the Wayland libraries can be built fine). I don't see anyone 
> mentioning non-Linux support.
> 
> > There are non-linux which have successfully run Weston on a DRM 
> backend. That was in the news a few weeks back, see e.g. 
> http://lists.dragonflybsd.org/pipermail/users/2016-May/249620.html
> 
> That's the second attempt at this I see (the first one was beginning of 
> 2013 IIRC), yet none of this code as been upstreamed yet.
> 
> Martin Gräßlin wrote:
> > I don't see anyone mentioning non-Linux support.
> 
> All we can do is ask, sorry.
> 
> > That's the second attempt at this I see (the first one was beginning of 
> 2013 IIRC), yet none of this code as been upstreamed yet.
> 
> Well I find it strange that I got code from BSD users for new KWin. If it 
> were impossible to build KWin anymore that wouldn't work ;-)

> All we can do is ask, sorry.

Possibly not closing the door would help as well.

> Well I find it strange that I got code from BSD users for new KWin. If it 
> were impossible to build KWin anymore that wouldn't work ;-)

Well, I still see that kwin has kwayland and kscreenlocker as mandatory build 
dependencies, and kscreenlocker has kwayland as mandatory build dependency.  
Hence they are using non-upstreamed patches, which is something I don't want to 
rely on.

Do you have pointers to these contributions for BSD?


- Pino


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128073/#review96120
---


On June 1, 2016, 8:10 a.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128073/
> ---
> 
> (Updated June 1, 2016, 8:10 a.m.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, Martin Gräßlin, and 
> Sebastian Kügler.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> Look for KF5Wayland as optional package, not building all the Wayland-related 
> code (backend, additions to tests, DPMS support in kscreen-doctor) if it is 
> not available.
> 
> This allows libkscreen to build again on platforms without Wayland, such as 
> non-Linux or old Linux distros.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9c834d9500fa0b89764516464bd58e835671977b 
>   autotests/CMakeLists.txt 2c8ee3d2021b1222072d6a1faafaff1b336d27e3 
>   backends/CMakeLists.txt 3563e138454edcc0c874237745123b09077d067c 
>   src/doctor/CMakeList

[Differential] [Commented On] D1706: [Switch Window Containment Action] Fix listing windows with just one virtual desktop

[mart (Marco Martin)]

mart added a comment.


  there was an inconsistency at some point between the applet counting from 0 
and x counting from 1 iirc, and nowdays *should* be possible to remove that if 
(KWindowSystem::numberOfDesktops() < 2) { code?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1706

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, hein, graesslin
Cc: mart, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126151/
---

(Updated June 1, 2016, 9:45 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, KDE Usability and Jonathan Riddell.


Changes
---

Submitted with commit 13d6d587c27a9ad8cc5463b1c1a3cac617bf5325 by Kai Uwe 
Broulik to branch master.


Bugs: 354001
http://bugs.kde.org/show_bug.cgi?id=354001


Repository: user-manager


Description
---

Including the avatars, that are no longer installed into /usr/share/kdm/icons 
but /usr/share/user-manager/avatars. I don't know if there's a FDO location for 
these.


Diffs
-

  src/CMakeLists.txt 7267d24 
  src/accountinfo.h c6e70b3 
  src/accountinfo.cpp 878f683 
  src/avatargallery.h PRE-CREATION 
  src/avatargallery.cpp PRE-CREATION 
  src/avatargallery.ui PRE-CREATION 
  src/pics/Ada Lovelace.png PRE-CREATION 
  src/pics/Alice in Wonderland.png PRE-CREATION 
  src/pics/Blackbox.png PRE-CREATION 
  src/pics/CMakeLists.txt PRE-CREATION 
  src/pics/Dragon.png PRE-CREATION 
  src/pics/Grace Hopper.png PRE-CREATION 
  src/pics/Green.png PRE-CREATION 
  src/pics/Happy.png PRE-CREATION 
  src/pics/Kati.png PRE-CREATION 
  src/pics/Konqui.png PRE-CREATION 
  src/pics/Leonardo da Vinci.png PRE-CREATION 
  src/pics/Listening.png PRE-CREATION 
  src/pics/Logger.png PRE-CREATION 
  src/pics/Mahatma Gandhi.png PRE-CREATION 
  src/pics/Mowgli jungle book.png PRE-CREATION 
  src/pics/Notme.png PRE-CREATION 
  src/pics/Parley.png PRE-CREATION 
  src/pics/Rekonqui.png PRE-CREATION 
  src/pics/TV.png PRE-CREATION 
  src/pics/User.png PRE-CREATION 
  src/pics/bomb.png PRE-CREATION 
  src/pics/sources/Ada Lovelace.svg PRE-CREATION 
  src/pics/sources/Alice in Wonderland.svg PRE-CREATION 
  src/pics/sources/Dragon.svg PRE-CREATION 
  src/pics/sources/Grace Hopper.svg PRE-CREATION 
  src/pics/sources/Kati.svg PRE-CREATION 
  src/pics/sources/Konqui.svg PRE-CREATION 
  src/pics/sources/Leonardo da Vinci.svg PRE-CREATION 
  src/pics/sources/Logger.svg PRE-CREATION 
  src/pics/sources/Mahatma Gandhi.svg PRE-CREATION 
  src/pics/sources/Mowgli jungle book.svg PRE-CREATION 
  src/pics/sources/Parley.svg PRE-CREATION 
  src/pics/sources/Rekonqui.svg PRE-CREATION 
  src/pics/sources/User.svg PRE-CREATION 
  src/pics/sources/blackbox.svgz PRE-CREATION 
  src/pics/sources/bomb.svgz PRE-CREATION 
  src/pics/sources/green.svgz PRE-CREATION 
  src/pics/sources/happy.svgz PRE-CREATION 
  src/pics/sources/listening.svgz PRE-CREATION 
  src/pics/sources/notme.svgz PRE-CREATION 
  src/pics/sources/tv.svgz PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126151/diff/


Testing
---

Opened user manager, clicked my icon, clicked "Choose from Gallery", chose an 
icon, OK. It prompted me three times for Polkit authentication for some reason 
but in the end it worked, Kickoff also immediately updated its icon.


File Attachments


New menu option
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/11/23/d91c818f-5051-4857-beb2-b2727614f187__usermanageravatar.png
Avatar gallery
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/11/23/2f16fa25-5eac-4e6a-b24d-7d47ff560ce4__usermanageravatar2.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128073: Make Wayland optional

[Martin Gräßlin]

> On June 1, 2016, 10:13 a.m., Martin Gräßlin wrote:
> > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation 
> > why we don't want this.
> 
> Pino Toscano wrote:
> Nowhere there is discussed (only briefly mentioned) about support with 
> non-Linux platforms; considering libkscreen is a library used by components 
> (and also external ones, like the display configuration in LxQt), then it 
> makes sense to me making it portable.
> 
> Making wayland mandatory in libkscreen (and also in other modules, like 
> plasma-integration, kwin, kscreenlocker) means killing outright any attempt 
> to make Plasma build on non-Linux platforms.  Please reconsider this, thanks.
> 
> Martin Gräßlin wrote:
> which non-Linux platforms which we care about don't have Wayland? Before 
> making KWayland a mandatory dependency in Plasma we did check with distro 
> packagers. Everyone was fine with it.
> 
> Pino Toscano wrote:
> At least to my reading of Wayland sources, to build the libraries you 
> need features like signalfd and timerfd, which are non-POSIX and available 
> only on Linux.
> 
> Can you please point me to the discussion you had with distro packagers?
> 
> Martin Gräßlin wrote:
> There are non-linux which have successfully run Weston on a DRM backend. 
> That was in the news a few weeks back, see e.g. 
> http://lists.dragonflybsd.org/pipermail/users/2016-May/249620.html
> 
> So let's go from "theoretically not possible" to "practically not 
> possible". Where is it not possible to have a Wayland dependency?
> 
> Concerning the discussion: a quick search showed me 
> https://mail.kde.org/pipermail/kde-distro-packagers/2015-July/76.html, 
> but there must be an older one already as we use it in plasma-workspace 
> (kscreenlocker) since Plasma 5.2 IIRC. This makes it difficult for me to 
> point you to the discussion as it's really a long time ago.
> 
> Bhushan Shah wrote:
> https://mail.kde.org/pipermail/release-team/2015-July/008725.html
> 
> Pino Toscano wrote:
> > 
> https://mail.kde.org/pipermail/kde-distro-packagers/2015-July/76.html
> > https://mail.kde.org/pipermail/release-team/2015-July/008725.html
> 
> The only party involved there is a Slackware packager, which is a Linux 
> distro (where the Wayland libraries can be built fine). I don't see anyone 
> mentioning non-Linux support.
> 
> > There are non-linux which have successfully run Weston on a DRM 
> backend. That was in the news a few weeks back, see e.g. 
> http://lists.dragonflybsd.org/pipermail/users/2016-May/249620.html
> 
> That's the second attempt at this I see (the first one was beginning of 
> 2013 IIRC), yet none of this code as been upstreamed yet.

> I don't see anyone mentioning non-Linux support.

All we can do is ask, sorry.

> That's the second attempt at this I see (the first one was beginning of 2013 
> IIRC), yet none of this code as been upstreamed yet.

Well I find it strange that I got code from BSD users for new KWin. If it were 
impossible to build KWin anymore that wouldn't work ;-)


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128073/#review96120
---


On June 1, 2016, 10:10 a.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128073/
> ---
> 
> (Updated June 1, 2016, 10:10 a.m.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, Martin Gräßlin, and 
> Sebastian Kügler.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> Look for KF5Wayland as optional package, not building all the Wayland-related 
> code (backend, additions to tests, DPMS support in kscreen-doctor) if it is 
> not available.
> 
> This allows libkscreen to build again on platforms without Wayland, such as 
> non-Linux or old Linux distros.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9c834d9500fa0b89764516464bd58e835671977b 
>   autotests/CMakeLists.txt 2c8ee3d2021b1222072d6a1faafaff1b336d27e3 
>   backends/CMakeLists.txt 3563e138454edcc0c874237745123b09077d067c 
>   src/doctor/CMakeLists.txt 7294d88af127a6604bc7e48e16342c93f152de8c 
>   src/doctor/doctor.cpp a156f006212e63c155a6f643929d0a5880275731 
>   tests/CMakeLists.txt 1489d21383e13cd1431a81d48b4a272c28302041 
> 
> Diff: https://git.reviewboard.kde.org/r/128073/diff/
> 
> 
> Testing
> ---
> 
> Builds fine.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128070: Update mouse kcm docbook to 5.6

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128070/#review96131
---



Looks good to me, but let's have others also a look on it.

Btw. I just checked git log to verify that logitech related code got deleted: 
gone with a029fb591ae6ddba5e23c5d5874afa7f2935fbd9

- Martin Gräßlin


On June 1, 2016, 11:22 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128070/
> ---
> 
> (Updated June 1, 2016, 11:22 a.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> bump date + releaseinfo
> single / double click setting was removed from dolphin / konqueror
> remove Change Pointer + Automatically select icons settings, no longer in the 
> code
> change kde -> plasma
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/mouse/index.docbook b09f8e7 
> 
> Diff: https://git.reviewboard.kde.org/r/128070/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126151/#review96130
---


Ship it!




Ship It!

- David Edmundson


On Nov. 23, 2015, 9:50 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126151/
> ---
> 
> (Updated Nov. 23, 2015, 9:50 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Jonathan Riddell.
> 
> 
> Bugs: 354001
> http://bugs.kde.org/show_bug.cgi?id=354001
> 
> 
> Repository: user-manager
> 
> 
> Description
> ---
> 
> Including the avatars, that are no longer installed into /usr/share/kdm/icons 
> but /usr/share/user-manager/avatars. I don't know if there's a FDO location 
> for these.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 7267d24 
>   src/accountinfo.h c6e70b3 
>   src/accountinfo.cpp 878f683 
>   src/avatargallery.h PRE-CREATION 
>   src/avatargallery.cpp PRE-CREATION 
>   src/avatargallery.ui PRE-CREATION 
>   src/pics/Ada Lovelace.png PRE-CREATION 
>   src/pics/Alice in Wonderland.png PRE-CREATION 
>   src/pics/Blackbox.png PRE-CREATION 
>   src/pics/CMakeLists.txt PRE-CREATION 
>   src/pics/Dragon.png PRE-CREATION 
>   src/pics/Grace Hopper.png PRE-CREATION 
>   src/pics/Green.png PRE-CREATION 
>   src/pics/Happy.png PRE-CREATION 
>   src/pics/Kati.png PRE-CREATION 
>   src/pics/Konqui.png PRE-CREATION 
>   src/pics/Leonardo da Vinci.png PRE-CREATION 
>   src/pics/Listening.png PRE-CREATION 
>   src/pics/Logger.png PRE-CREATION 
>   src/pics/Mahatma Gandhi.png PRE-CREATION 
>   src/pics/Mowgli jungle book.png PRE-CREATION 
>   src/pics/Notme.png PRE-CREATION 
>   src/pics/Parley.png PRE-CREATION 
>   src/pics/Rekonqui.png PRE-CREATION 
>   src/pics/TV.png PRE-CREATION 
>   src/pics/User.png PRE-CREATION 
>   src/pics/bomb.png PRE-CREATION 
>   src/pics/sources/Ada Lovelace.svg PRE-CREATION 
>   src/pics/sources/Alice in Wonderland.svg PRE-CREATION 
>   src/pics/sources/Dragon.svg PRE-CREATION 
>   src/pics/sources/Grace Hopper.svg PRE-CREATION 
>   src/pics/sources/Kati.svg PRE-CREATION 
>   src/pics/sources/Konqui.svg PRE-CREATION 
>   src/pics/sources/Leonardo da Vinci.svg PRE-CREATION 
>   src/pics/sources/Logger.svg PRE-CREATION 
>   src/pics/sources/Mahatma Gandhi.svg PRE-CREATION 
>   src/pics/sources/Mowgli jungle book.svg PRE-CREATION 
>   src/pics/sources/Parley.svg PRE-CREATION 
>   src/pics/sources/Rekonqui.svg PRE-CREATION 
>   src/pics/sources/User.svg PRE-CREATION 
>   src/pics/sources/blackbox.svgz PRE-CREATION 
>   src/pics/sources/bomb.svgz PRE-CREATION 
>   src/pics/sources/green.svgz PRE-CREATION 
>   src/pics/sources/happy.svgz PRE-CREATION 
>   src/pics/sources/listening.svgz PRE-CREATION 
>   src/pics/sources/notme.svgz PRE-CREATION 
>   src/pics/sources/tv.svgz PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126151/diff/
> 
> 
> Testing
> ---
> 
> Opened user manager, clicked my icon, clicked "Choose from Gallery", chose an 
> icon, OK. It prompted me three times for Polkit authentication for some 
> reason but in the end it worked, Kickoff also immediately updated its icon.
> 
> 
> File Attachments
> 
> 
> New menu option
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/23/d91c818f-5051-4857-beb2-b2727614f187__usermanageravatar.png
> Avatar gallery
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/23/2f16fa25-5eac-4e6a-b24d-7d47ff560ce4__usermanageravatar2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128073: Make Wayland optional

[Marco Martin]

On Wednesday 01 June 2016 09:08:48 Pino Toscano wrote:
> > Bhushan Shah wrote:
> > https://mail.kde.org/pipermail/release-team/2015-July/008725.html
> > 
> > https://mail.kde.org/pipermail/kde-distro-packagers/2015-July/76.html
> > https://mail.kde.org/pipermail/release-team/2015-July/008725.html
> 
> The only party involved there is a Slackware packager, which is a Linux
> distro (where the Wayland libraries can be built fine). I don't see anyone
> mentioning non-Linux support.

if no non linux packagers are involved in any way and ignore the kde-distro-
packagers, becomes a tad difficult to work with them in any form

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128070: Update mouse kcm docbook to 5.6

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128070/
---

(Updated Juni 1, 2016, 9:22 vorm.)


Review request for Documentation and Plasma.


Changes
---

remove plasma + sect logitech


Repository: plasma-desktop


Description
---

bump date + releaseinfo
single / double click setting was removed from dolphin / konqueror
remove Change Pointer + Automatically select icons settings, no longer in the 
code
change kde -> plasma


Diffs (updated)
-

  doc/kcontrol/mouse/index.docbook b09f8e7 

Diff: https://git.reviewboard.kde.org/r/128070/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128073: Make Wayland optional

[Pino Toscano]

> On June 1, 2016, 8:13 a.m., Martin Gräßlin wrote:
> > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation 
> > why we don't want this.
> 
> Pino Toscano wrote:
> Nowhere there is discussed (only briefly mentioned) about support with 
> non-Linux platforms; considering libkscreen is a library used by components 
> (and also external ones, like the display configuration in LxQt), then it 
> makes sense to me making it portable.
> 
> Making wayland mandatory in libkscreen (and also in other modules, like 
> plasma-integration, kwin, kscreenlocker) means killing outright any attempt 
> to make Plasma build on non-Linux platforms.  Please reconsider this, thanks.
> 
> Martin Gräßlin wrote:
> which non-Linux platforms which we care about don't have Wayland? Before 
> making KWayland a mandatory dependency in Plasma we did check with distro 
> packagers. Everyone was fine with it.
> 
> Pino Toscano wrote:
> At least to my reading of Wayland sources, to build the libraries you 
> need features like signalfd and timerfd, which are non-POSIX and available 
> only on Linux.
> 
> Can you please point me to the discussion you had with distro packagers?
> 
> Martin Gräßlin wrote:
> There are non-linux which have successfully run Weston on a DRM backend. 
> That was in the news a few weeks back, see e.g. 
> http://lists.dragonflybsd.org/pipermail/users/2016-May/249620.html
> 
> So let's go from "theoretically not possible" to "practically not 
> possible". Where is it not possible to have a Wayland dependency?
> 
> Concerning the discussion: a quick search showed me 
> https://mail.kde.org/pipermail/kde-distro-packagers/2015-July/76.html, 
> but there must be an older one already as we use it in plasma-workspace 
> (kscreenlocker) since Plasma 5.2 IIRC. This makes it difficult for me to 
> point you to the discussion as it's really a long time ago.
> 
> Bhushan Shah wrote:
> https://mail.kde.org/pipermail/release-team/2015-July/008725.html

> https://mail.kde.org/pipermail/kde-distro-packagers/2015-July/76.html
> https://mail.kde.org/pipermail/release-team/2015-July/008725.html

The only party involved there is a Slackware packager, which is a Linux distro 
(where the Wayland libraries can be built fine). I don't see anyone mentioning 
non-Linux support.

> There are non-linux which have successfully run Weston on a DRM backend. That 
> was in the news a few weeks back, see e.g. 
> http://lists.dragonflybsd.org/pipermail/users/2016-May/249620.html

That's the second attempt at this I see (the first one was beginning of 2013 
IIRC), yet none of this code as been upstreamed yet.


- Pino


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128073/#review96120
---


On June 1, 2016, 8:10 a.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128073/
> ---
> 
> (Updated June 1, 2016, 8:10 a.m.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, Martin Gräßlin, and 
> Sebastian Kügler.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> Look for KF5Wayland as optional package, not building all the Wayland-related 
> code (backend, additions to tests, DPMS support in kscreen-doctor) if it is 
> not available.
> 
> This allows libkscreen to build again on platforms without Wayland, such as 
> non-Linux or old Linux distros.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9c834d9500fa0b89764516464bd58e835671977b 
>   autotests/CMakeLists.txt 2c8ee3d2021b1222072d6a1faafaff1b336d27e3 
>   backends/CMakeLists.txt 3563e138454edcc0c874237745123b09077d067c 
>   src/doctor/CMakeLists.txt 7294d88af127a6604bc7e48e16342c93f152de8c 
>   src/doctor/doctor.cpp a156f006212e63c155a6f643929d0a5880275731 
>   tests/CMakeLists.txt 1489d21383e13cd1431a81d48b4a272c28302041 
> 
> Diff: https://git.reviewboard.kde.org/r/128073/diff/
> 
> 
> Testing
> ---
> 
> Builds fine.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1722: Import next-gen libtaskmanager.

[hein (Eike Hein)]

hein marked an inline comment as done.
hein added inline comments.

INLINE COMMENTS

> hein wrote in xwindowtasksmodel.cpp:756
> Actually not done -- I'll ask you later about this.

Done now.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: graesslin, broulik, davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 9,271 lines] D1722: Import next-gen libtaskmanager.

[hein (Eike Hein)]

hein updated this revision to Diff 4128.
hein added a comment.


  Make QByteArray snippet shorter.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1722?vs=4123&id=4128

BRANCH
  importlibtmng

REVISION DETAIL
  https://phabricator.kde.org/D1722

AFFECTED FILES
  CMakeLists.txt
  libtaskmanager/CMakeLists.txt
  libtaskmanager/LibTaskManagerConfig.cmake.in
  libtaskmanager/TODO.txt
  libtaskmanager/abstracttasksmodel.cpp
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/abstracttasksmodeliface.h
  libtaskmanager/activityinfo.cpp
  libtaskmanager/activityinfo.h
  libtaskmanager/autotests/CMakeLists.txt
  libtaskmanager/autotests/launchertasksmodeltest.cpp
  libtaskmanager/autotests/tasktoolstest.cpp
  libtaskmanager/concatenatetasksproxymodel.cpp
  libtaskmanager/concatenatetasksproxymodel.h
  libtaskmanager/declarative/CMakeLists.txt
  libtaskmanager/declarative/qmldir
  libtaskmanager/declarative/taskmanagerplugin.cpp
  libtaskmanager/declarative/taskmanagerplugin.h
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/launchertasksmodel.h
  libtaskmanager/startuptasksmodel.cpp
  libtaskmanager/startuptasksmodel.h
  libtaskmanager/taskfilterproxymodel.cpp
  libtaskmanager/taskfilterproxymodel.h
  libtaskmanager/taskgroupingproxymodel.cpp
  libtaskmanager/taskgroupingproxymodel.h
  libtaskmanager/taskmanagerrulesrc
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h
  libtaskmanager/tasktools.cpp
  libtaskmanager/tasktools.h
  libtaskmanager/virtualdesktopinfo.cpp
  libtaskmanager/virtualdesktopinfo.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/waylandtasksmodel.h
  libtaskmanager/xwindowtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: graesslin, broulik, davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128073: Make Wayland optional

[Bhushan Shah]

> On June 1, 2016, 1:43 p.m., Martin Gräßlin wrote:
> > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation 
> > why we don't want this.
> 
> Pino Toscano wrote:
> Nowhere there is discussed (only briefly mentioned) about support with 
> non-Linux platforms; considering libkscreen is a library used by components 
> (and also external ones, like the display configuration in LxQt), then it 
> makes sense to me making it portable.
> 
> Making wayland mandatory in libkscreen (and also in other modules, like 
> plasma-integration, kwin, kscreenlocker) means killing outright any attempt 
> to make Plasma build on non-Linux platforms.  Please reconsider this, thanks.
> 
> Martin Gräßlin wrote:
> which non-Linux platforms which we care about don't have Wayland? Before 
> making KWayland a mandatory dependency in Plasma we did check with distro 
> packagers. Everyone was fine with it.
> 
> Pino Toscano wrote:
> At least to my reading of Wayland sources, to build the libraries you 
> need features like signalfd and timerfd, which are non-POSIX and available 
> only on Linux.
> 
> Can you please point me to the discussion you had with distro packagers?
> 
> Martin Gräßlin wrote:
> There are non-linux which have successfully run Weston on a DRM backend. 
> That was in the news a few weeks back, see e.g. 
> http://lists.dragonflybsd.org/pipermail/users/2016-May/249620.html
> 
> So let's go from "theoretically not possible" to "practically not 
> possible". Where is it not possible to have a Wayland dependency?
> 
> Concerning the discussion: a quick search showed me 
> https://mail.kde.org/pipermail/kde-distro-packagers/2015-July/76.html, 
> but there must be an older one already as we use it in plasma-workspace 
> (kscreenlocker) since Plasma 5.2 IIRC. This makes it difficult for me to 
> point you to the discussion as it's really a long time ago.

https://mail.kde.org/pipermail/release-team/2015-July/008725.html


- Bhushan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128073/#review96120
---


On June 1, 2016, 1:40 p.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128073/
> ---
> 
> (Updated June 1, 2016, 1:40 p.m.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, Martin Gräßlin, and 
> Sebastian Kügler.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> Look for KF5Wayland as optional package, not building all the Wayland-related 
> code (backend, additions to tests, DPMS support in kscreen-doctor) if it is 
> not available.
> 
> This allows libkscreen to build again on platforms without Wayland, such as 
> non-Linux or old Linux distros.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9c834d9500fa0b89764516464bd58e835671977b 
>   autotests/CMakeLists.txt 2c8ee3d2021b1222072d6a1faafaff1b336d27e3 
>   backends/CMakeLists.txt 3563e138454edcc0c874237745123b09077d067c 
>   src/doctor/CMakeLists.txt 7294d88af127a6604bc7e48e16342c93f152de8c 
>   src/doctor/doctor.cpp a156f006212e63c155a6f643929d0a5880275731 
>   tests/CMakeLists.txt 1489d21383e13cd1431a81d48b4a272c28302041 
> 
> Diff: https://git.reviewboard.kde.org/r/128073/diff/
> 
> 
> Testing
> ---
> 
> Builds fine.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128073: Make Wayland optional

[Martin Gräßlin]

> On June 1, 2016, 10:13 a.m., Martin Gräßlin wrote:
> > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation 
> > why we don't want this.
> 
> Pino Toscano wrote:
> Nowhere there is discussed (only briefly mentioned) about support with 
> non-Linux platforms; considering libkscreen is a library used by components 
> (and also external ones, like the display configuration in LxQt), then it 
> makes sense to me making it portable.
> 
> Making wayland mandatory in libkscreen (and also in other modules, like 
> plasma-integration, kwin, kscreenlocker) means killing outright any attempt 
> to make Plasma build on non-Linux platforms.  Please reconsider this, thanks.
> 
> Martin Gräßlin wrote:
> which non-Linux platforms which we care about don't have Wayland? Before 
> making KWayland a mandatory dependency in Plasma we did check with distro 
> packagers. Everyone was fine with it.
> 
> Pino Toscano wrote:
> At least to my reading of Wayland sources, to build the libraries you 
> need features like signalfd and timerfd, which are non-POSIX and available 
> only on Linux.
> 
> Can you please point me to the discussion you had with distro packagers?

There are non-linux which have successfully run Weston on a DRM backend. That 
was in the news a few weeks back, see e.g. 
http://lists.dragonflybsd.org/pipermail/users/2016-May/249620.html

So let's go from "theoretically not possible" to "practically not possible". 
Where is it not possible to have a Wayland dependency?

Concerning the discussion: a quick search showed me 
https://mail.kde.org/pipermail/kde-distro-packagers/2015-July/76.html, but 
there must be an older one already as we use it in plasma-workspace 
(kscreenlocker) since Plasma 5.2 IIRC. This makes it difficult for me to point 
you to the discussion as it's really a long time ago.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128073/#review96120
---


On June 1, 2016, 10:10 a.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128073/
> ---
> 
> (Updated June 1, 2016, 10:10 a.m.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, Martin Gräßlin, and 
> Sebastian Kügler.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> Look for KF5Wayland as optional package, not building all the Wayland-related 
> code (backend, additions to tests, DPMS support in kscreen-doctor) if it is 
> not available.
> 
> This allows libkscreen to build again on platforms without Wayland, such as 
> non-Linux or old Linux distros.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9c834d9500fa0b89764516464bd58e835671977b 
>   autotests/CMakeLists.txt 2c8ee3d2021b1222072d6a1faafaff1b336d27e3 
>   backends/CMakeLists.txt 3563e138454edcc0c874237745123b09077d067c 
>   src/doctor/CMakeLists.txt 7294d88af127a6604bc7e48e16342c93f152de8c 
>   src/doctor/doctor.cpp a156f006212e63c155a6f643929d0a5880275731 
>   tests/CMakeLists.txt 1489d21383e13cd1431a81d48b4a272c28302041 
> 
> Diff: https://git.reviewboard.kde.org/r/128073/diff/
> 
> 
> Testing
> ---
> 
> Builds fine.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128073: Make Wayland optional

[Pino Toscano]

> On June 1, 2016, 8:13 a.m., Martin Gräßlin wrote:
> > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation 
> > why we don't want this.
> 
> Pino Toscano wrote:
> Nowhere there is discussed (only briefly mentioned) about support with 
> non-Linux platforms; considering libkscreen is a library used by components 
> (and also external ones, like the display configuration in LxQt), then it 
> makes sense to me making it portable.
> 
> Making wayland mandatory in libkscreen (and also in other modules, like 
> plasma-integration, kwin, kscreenlocker) means killing outright any attempt 
> to make Plasma build on non-Linux platforms.  Please reconsider this, thanks.
> 
> Martin Gräßlin wrote:
> which non-Linux platforms which we care about don't have Wayland? Before 
> making KWayland a mandatory dependency in Plasma we did check with distro 
> packagers. Everyone was fine with it.

At least to my reading of Wayland sources, to build the libraries you need 
features like signalfd and timerfd, which are non-POSIX and available only on 
Linux.

Can you please point me to the discussion you had with distro packagers?


- Pino


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128073/#review96120
---


On June 1, 2016, 8:10 a.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128073/
> ---
> 
> (Updated June 1, 2016, 8:10 a.m.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, Martin Gräßlin, and 
> Sebastian Kügler.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> Look for KF5Wayland as optional package, not building all the Wayland-related 
> code (backend, additions to tests, DPMS support in kscreen-doctor) if it is 
> not available.
> 
> This allows libkscreen to build again on platforms without Wayland, such as 
> non-Linux or old Linux distros.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9c834d9500fa0b89764516464bd58e835671977b 
>   autotests/CMakeLists.txt 2c8ee3d2021b1222072d6a1faafaff1b336d27e3 
>   backends/CMakeLists.txt 3563e138454edcc0c874237745123b09077d067c 
>   src/doctor/CMakeLists.txt 7294d88af127a6604bc7e48e16342c93f152de8c 
>   src/doctor/doctor.cpp a156f006212e63c155a6f643929d0a5880275731 
>   tests/CMakeLists.txt 1489d21383e13cd1431a81d48b4a272c28302041 
> 
> Diff: https://git.reviewboard.kde.org/r/128073/diff/
> 
> 
> Testing
> ---
> 
> Builds fine.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128073: Make Wayland optional

[Martin Gräßlin]

> On June 1, 2016, 10:13 a.m., Martin Gräßlin wrote:
> > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation 
> > why we don't want this.
> 
> Pino Toscano wrote:
> Nowhere there is discussed (only briefly mentioned) about support with 
> non-Linux platforms; considering libkscreen is a library used by components 
> (and also external ones, like the display configuration in LxQt), then it 
> makes sense to me making it portable.
> 
> Making wayland mandatory in libkscreen (and also in other modules, like 
> plasma-integration, kwin, kscreenlocker) means killing outright any attempt 
> to make Plasma build on non-Linux platforms.  Please reconsider this, thanks.

which non-Linux platforms which we care about don't have Wayland? Before making 
KWayland a mandatory dependency in Plasma we did check with distro packagers. 
Everyone was fine with it.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128073/#review96120
---


On June 1, 2016, 10:10 a.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128073/
> ---
> 
> (Updated June 1, 2016, 10:10 a.m.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, Martin Gräßlin, and 
> Sebastian Kügler.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> Look for KF5Wayland as optional package, not building all the Wayland-related 
> code (backend, additions to tests, DPMS support in kscreen-doctor) if it is 
> not available.
> 
> This allows libkscreen to build again on platforms without Wayland, such as 
> non-Linux or old Linux distros.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9c834d9500fa0b89764516464bd58e835671977b 
>   autotests/CMakeLists.txt 2c8ee3d2021b1222072d6a1faafaff1b336d27e3 
>   backends/CMakeLists.txt 3563e138454edcc0c874237745123b09077d067c 
>   src/doctor/CMakeLists.txt 7294d88af127a6604bc7e48e16342c93f152de8c 
>   src/doctor/doctor.cpp a156f006212e63c155a6f643929d0a5880275731 
>   tests/CMakeLists.txt 1489d21383e13cd1431a81d48b4a272c28302041 
> 
> Diff: https://git.reviewboard.kde.org/r/128073/diff/
> 
> 
> Testing
> ---
> 
> Builds fine.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128073: Make Wayland optional

[Pino Toscano]

> On June 1, 2016, 8:13 a.m., Martin Gräßlin wrote:
> > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation 
> > why we don't want this.

Nowhere there is discussed (only briefly mentioned) about support with 
non-Linux platforms; considering libkscreen is a library used by components 
(and also external ones, like the display configuration in LxQt), then it makes 
sense to me making it portable.

Making wayland mandatory in libkscreen (and also in other modules, like 
plasma-integration, kwin, kscreenlocker) means killing outright any attempt to 
make Plasma build on non-Linux platforms.  Please reconsider this, thanks.


- Pino


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128073/#review96120
---


On June 1, 2016, 8:10 a.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128073/
> ---
> 
> (Updated June 1, 2016, 8:10 a.m.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, Martin Gräßlin, and 
> Sebastian Kügler.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> Look for KF5Wayland as optional package, not building all the Wayland-related 
> code (backend, additions to tests, DPMS support in kscreen-doctor) if it is 
> not available.
> 
> This allows libkscreen to build again on platforms without Wayland, such as 
> non-Linux or old Linux distros.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9c834d9500fa0b89764516464bd58e835671977b 
>   autotests/CMakeLists.txt 2c8ee3d2021b1222072d6a1faafaff1b336d27e3 
>   backends/CMakeLists.txt 3563e138454edcc0c874237745123b09077d067c 
>   src/doctor/CMakeLists.txt 7294d88af127a6604bc7e48e16342c93f152de8c 
>   src/doctor/doctor.cpp a156f006212e63c155a6f643929d0a5880275731 
>   tests/CMakeLists.txt 1489d21383e13cd1431a81d48b4a272c28302041 
> 
> Diff: https://git.reviewboard.kde.org/r/128073/diff/
> 
> 
> Testing
> ---
> 
> Builds fine.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128073: Make Wayland optional

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128073/#review96120
---



-2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation why we 
don't want this.

- Martin Gräßlin


On June 1, 2016, 10:10 a.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128073/
> ---
> 
> (Updated June 1, 2016, 10:10 a.m.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, Martin Gräßlin, and 
> Sebastian Kügler.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> Look for KF5Wayland as optional package, not building all the Wayland-related 
> code (backend, additions to tests, DPMS support in kscreen-doctor) if it is 
> not available.
> 
> This allows libkscreen to build again on platforms without Wayland, such as 
> non-Linux or old Linux distros.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9c834d9500fa0b89764516464bd58e835671977b 
>   autotests/CMakeLists.txt 2c8ee3d2021b1222072d6a1faafaff1b336d27e3 
>   backends/CMakeLists.txt 3563e138454edcc0c874237745123b09077d067c 
>   src/doctor/CMakeLists.txt 7294d88af127a6604bc7e48e16342c93f152de8c 
>   src/doctor/doctor.cpp a156f006212e63c155a6f643929d0a5880275731 
>   tests/CMakeLists.txt 1489d21383e13cd1431a81d48b4a272c28302041 
> 
> Diff: https://git.reviewboard.kde.org/r/128073/diff/
> 
> 
> Testing
> ---
> 
> Builds fine.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 128073: Make Wayland optional

[Pino Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128073/
---

Review request for Plasma, Solid, Daniel Vrátil, Martin Gräßlin, and Sebastian 
Kügler.


Repository: libkscreen


Description
---

Look for KF5Wayland as optional package, not building all the Wayland-related 
code (backend, additions to tests, DPMS support in kscreen-doctor) if it is not 
available.

This allows libkscreen to build again on platforms without Wayland, such as 
non-Linux or old Linux distros.


Diffs
-

  CMakeLists.txt 9c834d9500fa0b89764516464bd58e835671977b 
  autotests/CMakeLists.txt 2c8ee3d2021b1222072d6a1faafaff1b336d27e3 
  backends/CMakeLists.txt 3563e138454edcc0c874237745123b09077d067c 
  src/doctor/CMakeLists.txt 7294d88af127a6604bc7e48e16342c93f152de8c 
  src/doctor/doctor.cpp a156f006212e63c155a6f643929d0a5880275731 
  tests/CMakeLists.txt 1489d21383e13cd1431a81d48b4a272c28302041 

Diff: https://git.reviewboard.kde.org/r/128073/diff/


Testing
---

Builds fine.


Thanks,

Pino Toscano

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128070: Update mouse kcm docbook to 5.6

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128070/#review96118
---




doc/kcontrol/mouse/index.docbook (lines 152 - 157)


Hmm I'm not overly happy with this documentation. It's actually not Plasma 
(neither was it KDE). It's a setting which gets passed to applications. The 
setting should work for all Qt applications and on X11 for all GTK applications 
and whatever else is there and listens to the signal.

So overall I think it would be better to say it's for applications. Plasma 
has nothing to do with it.



doc/kcontrol/mouse/index.docbook (line 176)


Similar concern to above point: it's not Plasma which has anything to do 
with it. It's a setting for applications.



doc/kcontrol/mouse/index.docbook (lines 263 - 270)


isn't the logitech stuff killed from the KCM?


- Martin Gräßlin


On June 1, 2016, 6:35 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128070/
> ---
> 
> (Updated June 1, 2016, 6:35 a.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> bump date + releaseinfo
> single / double click setting was removed from dolphin / konqueror
> remove Change Pointer + Automatically select icons settings, no longer in the 
> code
> change kde -> plasma
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/mouse/index.docbook b09f8e7 
> 
> Diff: https://git.reviewboard.kde.org/r/128070/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> broulik wrote in main_wayland.cpp:449
> That dialog is a separate binary kwin_rules_dialog. Except for the virtual 
> keyboard and wayland debug console I don't think there are any user-facing 
> kwin-internal windows (that are real windows, not counting stuff like close 
> buttons on present windows and so on)

It's as Kai-Uwe says: KWin has no own windows. Everything are external programs 
launched by KWin with a cleaned up environment.

The only input field where KWin accepts input is the dialog for setting a 
shortcut for a window. As KGlobalAccel doesn't support input methods it's not a 
problem either.

REPOSITORY
  rKWIN KWin

BRANCH
  virtual-keyboard

REVISION DETAIL
  https://phabricator.kde.org/D1638

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: xuetianweng, sebas, mart, broulik, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Requested Changes To] D1730: address race condition around setoperation

[Martin Gräßlin]

graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.


  Given that you don't connect to the timer at all, I think the usage of QTimer 
is wrong here. QElapsedTimer seems like the better choice here.
  
  The main change would be in configChanged where it would become:
  
if (m_changedBlockTimer->isValid() && 
!m_changedBlockTimer->hasExpired(100)) {
// still active
   m_changedBlockTimer->start();
} else {
// stop the timer
   m_changedBlockTimer->invalidate();
}

INLINE COMMENTS

> daemon.cpp:86
>  delete m_lidClosedTimer;
> +delete m_changeBlockTimer;
>  

why delete manually? Either pass this on construction or use a QScopedPointer.

I see that it's already done like that for the other cases, but I don't think 
it's a good idea to copy bad practice in new code.

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D1730

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, graesslin
Cc: plasma-devel, Plasma, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Requested Changes To] D1231: Add Krfb interface to KWayland

[Martin Gräßlin]

graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.


  Overall I would also like to see autotests for it similar to the tests for 
other interfaces.

INLINE COMMENTS

> remote_access_interface.cpp:146-149
> +if (bound) {
> +wl_client_post_no_memory(client);
> +return;
> +}

if really only one client should be allowed (why?) it would be better to send a 
dedicated error state to inform it instead of "abusing" no memory.

> remote_access_interface.cpp:158
> +wl_resource_set_implementation(resource, &s_interface, this, unbind);
> +m_resource = resource;
> +bound = true;

this allows to have only one client bind it. As soon as a second client binds 
the protocol it will get overwritten and breaks the existing one.

I think you need a QVector here.

> remote_access_interface.h:43
> + **/
> +struct GbmBuffer
> +{

for ABI compatibility we cannot have structs defined in the header. See 
https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B#The_Do.27s_and_Don.27ts
 for explanation. Especially the last point of the Donts is relevant as it 
means we are never able to change this again.

Thus I think the proper way has to be:

  class Buffer
  {
  public:
  void setFd(int qint32);
  void setSize(const QSize &size);
  void setStride(qint32 stride);
  enum class Format {
  Format1,
  Format2
  };
  void setFormat(Format format);
  
  private:
  class Private;
  QScopedPointer d;
  };

and then in the Implementation have the Private class which holds the data 
members.

> remote_access_interface.h:94-112
> +class KWAYLANDSERVER_EXPORT RemoteBufferInterface : public Resource
> +{
> +Q_OBJECT
> +public:
> +virtual ~RemoteBufferInterface() = default;
> +
> +/**

I don't see this class exposed in any way in the API. So a user of the library 
cannot have access to it.

Thus I suggest to move it into a private header and remove the 
KWAYLANDSERVER_EXPORT. It's a private class to the library then, which makes 
life easier.

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: Kanedias, graesslin
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel