date:20160607

graesslin created this revision.
graesslin added a reviewer: Plasma on Wayland.
Restricted Application added a project: Plasma on Wayland.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  As we have the request nowadays in PlasmaWindow we can expose it.

REPOSITORY
  rKWAYLANDINTEGRATION Frameworks integration plugin using KWayland

BRANCH
  minimize-kwindowsystem

REVISION DETAIL
  https://phabricator.kde.org/D1795

AFFECTED FILES
  src/windowsystem/windowsystem.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: status of kde/plasma kiosk framework in kf5

2016-06-07 Thread Bhushan Shah

On Wed, Jun 8, 2016 at 3:03 AM, Kai Uwe Broulik  wrote:
> as far as I know a new KIOSK tool is even being worked on right now.
>
> Might have been part of GSOC or so, I'm not involved in that, though, Thomas 
> Pfeiffer should know more I think.

It was part of Season of KDE 2015, https://quickgit.kde.org/?p=confine.git

Thanks
-- 
Bhushan Shah

http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [plasma-workspace] /: Give a screen to systray applets

2016-06-07 Thread Bhushan Shah

On Tue, Jun 7, 2016 at 11:50 PM, Marco Martin  wrote:
> +setContainmentType(Plasma::Types::CustomEmbeddedContainment);
>  }

You can not use this in Plasma/5.7 or master currently unless you ask
to respin plasma-framework 5.23 tarball with
http://commits.kde.org/plasma-framework/84c29fa3d09

Thanks

-- 
Bhushan Shah

http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128070: Update mouse kcm docbook to 5.6

2016-06-07 Thread Burkhard Lück


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128070/
---

(Updated June 7, 2016, 8:35 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation and Plasma.


Changes
---

Submitted with commit ceefda516985ed3c455ddab086bd3b3b937445d3 by Burkhard Lück 
to branch master.


Repository: plasma-desktop


Description
---

bump date + releaseinfo
single / double click setting was removed from dolphin / konqueror
remove Change Pointer + Automatically select icons settings, no longer in the 
code
change kde -> plasma


Diffs
-

  doc/kcontrol/mouse/index.docbook b09f8e7 

Diff: https://git.reviewboard.kde.org/r/128070/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128108: update weather applet ui

2016-06-07 Thread Friedrich W. H. Kossebau


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128108/#review96287
---



Pretty good for your first QML patch :)

But there are a few issues that need to be fixed first and some which should be 
improved.
See the list of "Issues" below the screenshots at the "Reviews" page (which is 
the default view of this review request at 
https://git.reviewboard.kde.org/r/128108/)


applets/weather/package/contents/ui/TopPanel.qml (line 35)


This change is not needed, and might be slightly more expensive, at least 
breaks the code pattern I saw in Plasma, so please revert it.

Binding "width" to "height" of the same object is fine. And "height" is 
bound to "parent.height", so the code already should behave as you want it. If 
not, there would be a bug elsewhere, please report.



applets/weather/package/contents/ui/WeatherListView.qml (line 39)


Instead of making the rectangle transparent, turn it into a normal undrawn 
Item, by removing the properties "radius" and "color" and changing the type to 
"Item" instead of "Rectangle", like:
```
Item {
id: rect
height: root.rowHeight
width: root.width
Loader {
[...]
```



applets/weather/package/contents/ui/main.qml (line 117)


There is still "units.Spacing" set for the bottomMargin, which will yield 
0. So if you want to set 0 here for both margins, best set that explicitely 
(not sure what the default is):
```
topMargin: 0
bottomMargin: 0
```

Hm, having both top and bottom margin 0 now looks a little bit dense to me. 
But well, if you prefer that, okay.



applets/weather/package/contents/ui/main.qml (line 154)


No need to change this, "color" is already bound to "theme.textColor" due 
to this being a PlasmaComponents.Label



applets/weather/package/contents/ui/main.qml (line 155)


Please do not delete "textFormat: Text.StyledText", just add "opacity: 0.6".


- Friedrich W. H. Kossebau


On June 7, 2016, 11:46 a.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128108/
> ---
> 
> (Updated June 7, 2016, 11:46 a.m.)
> 
> 
> Review request for Plasma and Friedrich W. H. Kossebau.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> the scaling work now better and the pading between the single lines can be 
> smaler (If you make the applet higher you can also have the old line spacing)
> 
> it's my first qml change, so ...
> 
> on my todo, I'd like to change the powerd by weather.com text color so a 
> secondary gray (bring it a bit more to the background), but I don't know how.
> 
> 
> Diffs
> -
> 
>   applets/weather/package/contents/ui/TopPanel.qml 1821f16 
>   applets/weather/package/contents/ui/WeatherListView.qml c7b331e 
>   applets/weather/package/contents/ui/main.qml d490728 
> 
> Diff: https://git.reviewboard.kde.org/r/128108/diff/
> 
> 
> Testing
> ---
> 
> with breeze and breeze dark color scheme on two different pc's. the icons are 
> breeze weather icons (master)
> 
> 
> File Attachments
> 
> 
> screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/350136df-37c8-4fef-bddb-d4b609df2fb1__weather.png
> I hope I had fixed all open issues. I now have only one open issue I could 
> change the linkColor but I can't change the color when there is no link like 
> in noaa
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/3ef83b18-d8e3-4a73-a8da-a069c56a560a__weather.png
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: status of kde/plasma kiosk framework in kf5

2016-06-07 Thread Kai Uwe Broulik

Hi,

as far as I know a new KIOSK tool is even being worked on right now.

Might have been part of GSOC or so, I'm not involved in that, though, Thomas 
Pfeiffer should know more I think.

Cheers, 
Kai Uwe 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1670: New login screen

2016-06-07 Thread andreask (Andreas Kainz)

andreask added a comment.


  In https://phabricator.kde.org/D1670#33378, @broulik wrote:
  
  > Go go go before our VDG guys get even more impatient ;)
  
  
  It's not the VDG it's me Andreas Kainz.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  login

REVISION DETAIL
  https://phabricator.kde.org/D1670

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, broulik, #plasma
Cc: andreask, mart, broulik, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1670: New login screen

broulik added a comment.


  That last one was a "Fix it, then Ship it!" comment
  
  Go go go before our VDG guys get even more impatient ;)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  login

REVISION DETAIL
  https://phabricator.kde.org/D1670

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, broulik, #plasma
Cc: andreask, mart, broulik, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

ksplash unified login

2016-06-07 Thread kainz.a

Hi David,

is the new sddm theme already in master?

about the ksplash theme, the idea was descriped already here
https://community.kde.org/KDE_Visual_Design_Group/Unified_Login

ksplash
---
1. movie https://share.kde.org/index.php/s/xxVtPVAEllFaTLd
2. you start with the sddm background and your user avatar. the animation
starts in ksplash so sddm is already finished (the plasma start is not that
fast)
3. show some fancy animation until 50 %
4. than you fade out the background and see only the animation for the last
50 %
5. so it feels faster than it is and the user can see there happens
something (the desktop with the panels will be loaded)

we are also working on the logout and user switch dialogue
https://share.kde.org/index.php/s/S3wIqd1EqW7YBKK

I'll hope we can release the unified login stuff including ksplasm with
plasma 5.7. I don't think we can make the logout and user switch stuff for
5.7 but we will see.

cheers
Andreas K
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128070: Update mouse kcm docbook to 5.6


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128070/#review96265
---


Ship it!




Ship It!

- Sebastian Kügler


On June 1, 2016, 9:22 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128070/
> ---
> 
> (Updated June 1, 2016, 9:22 a.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> bump date + releaseinfo
> single / double click setting was removed from dolphin / konqueror
> remove Change Pointer + Automatically select icons settings, no longer in the 
> code
> change kde -> plasma
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/mouse/index.docbook b09f8e7 
> 
> Diff: https://git.reviewboard.kde.org/r/128070/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128070: Update mouse kcm docbook to 5.6

2016-06-07 Thread Burkhard Lück


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128070/#review96264
---



ping?

- Burkhard Lück


On Juni 1, 2016, 9:22 vorm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128070/
> ---
> 
> (Updated Juni 1, 2016, 9:22 vorm.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> bump date + releaseinfo
> single / double click setting was removed from dolphin / konqueror
> remove Change Pointer + Automatically select icons settings, no longer in the 
> code
> change kde -> plasma
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/mouse/index.docbook b09f8e7 
> 
> Diff: https://git.reviewboard.kde.org/r/128070/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 51 lines] D1793: [Device Notifier] Be more declarative

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Instead of having a bunch of handlers in various places messing with various 
settings, try to use declarative bindings where possible.
  
  - Remove separate passive timer, instead re-use the pendingDelegateRemoval 
property which has its own timer. This way, when a device is unmounted, device 
notifier stays active until the notification has cleared, however, when the 
device is yanked out manually, it disappears right away
  - Don't break binding on Plasmoid.active to ensure its state is always proper 
depending on whether a device or not is present (the linked bug)
  - Create tooltip declaratively rather than imperatively
  
  BUG: 362992
  FIXED-IN: 5.7.0

TEST PLAN
  - Started plasma with no usb stick - initially passive
  - Start plasma with - immediately active
  
  - Plugged in usb stick - got popup with active state
  - Plugged it out - immediately got passive
  - Plugged back in - got popup with active state
  - Mounted and then unmounted - got popup with notification, stayed active 
until notification cleared

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1793

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/devicenotifier/package/contents/ui/devicenotifier.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 130 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/130/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Jun 2016 19:32:17 +
Build duration: 9 min 19 sec

CHANGE SET
Revision 9c2f167b6cafe2c8bb3521193d27bd881383e3b3 by kde: ([Device Notifier] 
Add option to disable popup on new device)
  change: edit applets/devicenotifier/package/contents/ui/configGeneral.qml
  change: edit applets/devicenotifier/package/contents/ui/devicenotifier.qml
  change: edit applets/devicenotifier/package/contents/config/main.xml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5012 
(39%)CONDITIONAL 1381/5062 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2738 (5%)CONDITIONAL 
87/2789 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 129 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/129/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Jun 2016 19:14:24 +
Build duration: 17 min

CHANGE SET
Revision 97269b5aa9c210aba7ba7a219041dfa118c999ce by kde: ([PanelView] Expose 
enabled borders as property and also forward it to)
  change: edit shell/panelview.cpp
  change: edit shell/panelview.h
  change: edit shell/panelshadows.cpp
  change: edit shell/panelshadows_p.h
Revision 66688af5c3a167d43b10a192b1ccdd8ad4e97cfd by kde: ([PanelConfigView] 
Set enabled borders on PanelShadow)
  change: edit shell/panelconfigview.cpp
  change: edit shell/panelconfigview.h


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5012 
(39%)CONDITIONAL 1381/5062 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2738 (5%)CONDITIONAL 
87/2789 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1592: [Device Notifier] Add option to disable popup on new device

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE9c2f167b6caf: [Device Notifier] Add option to 
disable popup on new device (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D1592?vs=3770&id=4284#toc

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1592?vs=3770&id=4284

REVISION DETAIL
  https://phabricator.kde.org/D1592

AFFECTED FILES
  applets/devicenotifier/package/contents/config/main.xml
  applets/devicenotifier/package/contents/ui/configGeneral.qml
  applets/devicenotifier/package/contents/ui/devicenotifier.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mart
Cc: mart, colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1756: [PanelView] Expose enabled borders as property and also forward it to PanelShadows

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE97269b5aa9c2: [PanelView] Expose enabled 
borders as property and also forward it to… (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D1756?vs=4188&id=4282#toc

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1756?vs=4188&id=4282

REVISION DETAIL
  https://phabricator.kde.org/D1756

AFFECTED FILES
  shell/panelshadows.cpp
  shell/panelshadows_p.h
  shell/panelview.cpp
  shell/panelview.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1778: [PanelConfigView] Set enabled borders on PanelShadow

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE66688af5c3a1: [PanelConfigView] Set enabled 
borders on PanelShadow (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1778?vs=4243&id=4283

REVISION DETAIL
  https://phabricator.kde.org/D1778

AFFECTED FILES
  shell/panelconfigview.cpp
  shell/panelconfigview.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1757: [Panel] Reduce duplicate enabled borders calculation

broulik added a comment.


  Ping

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1757

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, mart, davidedmundson, #plasma
Cc: mart, davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 128 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/128/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Jun 2016 18:39:07 +
Build duration: 11 min

CHANGE SET
Revision 95d0631a439eb082fe460fc1228b56c1183dbdb5 by David Edmundson: (Fix 
compilation for Plasma 5.7 release depending on frameworks 5.23)
  change: edit applets/systemtray/systemtray.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5012 
(39%)CONDITIONAL 1381/5062 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2738 (5%)CONDITIONAL 
87/2789 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Plasma 5.7 Dependencies

2016-06-07 Thread David Edmundson

Quick reminder that Plasma 5.7 will depend on Frameworks 5.23. (the last
release).

New API in frameworks master cannot be used in the next Plasma release.

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 127 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/127/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Jun 2016 18:20:21 +
Build duration: 9 min 27 sec

CHANGE SET
Revision de8d99079e4a984ed007a31b46c388bfd5776274 by Marco Martin: (Give a 
screen to systray applets)
  change: edit applets/systemtray/systemtray.cpp
  change: edit shell/shellcorona.cpp
  change: edit applets/systemtray/container/systemtraycontainer.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5012 
(39%)CONDITIONAL 1381/5062 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2738 (5%)CONDITIONAL 
87/2789 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1791: Give a screen to systray applets

mart closed this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1791

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson
Cc: davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128118: new containment type for the systray

2016-06-07 Thread Marco Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128118/
---

(Updated June 7, 2016, 6:18 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and David Edmundson.


Changes
---

Submitted with commit 84c29fa3d091a173d6e2e201262d61ac34dc6169 by Marco Martin 
to branch master.


Repository: plasma-framework


Description
---

add a new containment type for use in the systray: this way it will be able to 
have a screen number without actually creating a panel from its own


Diffs
-

  src/plasma/plasma.h 9ec4470 

Diff: https://git.reviewboard.kde.org/r/128118/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 364067] Automatic suspend when inhibitor is set

2016-06-07 Thread Ralph Scharpf via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=364067

--- Comment #2 from Ralph Scharpf  ---
Thx for the fast reply. Unfortunately this is only usable by processes that run
in the same session. For a daemon running with another user in an own session
context the solution should automatically recognize all sessions by using
directly system dbus. Also the authentication will be bad using session bus
from a daemon.

I will try to workaround and give the call of the freedesktop inhibition a try.
Perhaps I am able to create a gateway service.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 364067] Automatic suspend when inhibitor is set

2016-06-07 Thread Kai Uwe Broulik via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=364067

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@davidedmudnson.co.uk,
   ||k...@privat.broulik.de
 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Kai Uwe Broulik  ---
PowerDevil currently doesn't handle Logind inhibitions at all unfortunately.
This is on my agenda at somwhere but I'm not really into changing all of this
yet again. At least for idle and sleep inhibitions PowerDevil might get support
at some point. CC'ing David who recently looked into Logind and PowerDevil.

At the moment the only truly supported inhibition is to call freedesktop
inhibition on the currently active session.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 364067] New: Automatic suspend when inhibitor is set

2016-06-07 Thread Ralph Scharpf via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=364067

Bug ID: 364067
   Summary: Automatic suspend when inhibitor is set
   Product: Powerdevil
   Version: 5.5.5
  Platform: Ubuntu Packages
   URL: http://www.vdr-portal.de/board17-developer/board21-vdr
-plugins/129134-softhddevice-und-vdr-shutdown/
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: rscha...@onlinehome.de

A discussion came up with VDR experts (hey, these guys are also very
experienced) when I was trying to configure my Video Disk Recorder PC also to
be useable as a Desktop PC using KDE.  The idea is to have the PC being
controlled by VDR and the user. To avoid that the PCs gets shut down by the
desktop when a recording is active by VDR, the VDR process should set an
inhibitor that is avoiding the shutdown and the Desktop is recognizing this,
not requesting a shutdown. Logind / system-dbus provide the needed
infrastructure with inhibitors for that.  The todays behaviour is, that the
user will be prompted for a password in both cases. While this is ok when the
shutdown was triggered by the user, an inactivity timeout should not open a
popup. There I would expect that the desktop waits until the inhibitor has been
closed.


Reproducible: Always

Steps to Reproduce:
1. Set an inhibitor from another user. I used the added python program for
that.
2. Wait until the the desktop wants to suspend due to inactivity. Configure
PowerDevil accordingly. 


Actual Results:  
A dialog pops up asking for confirmation even that there is likely no user as
the session timed out and a suspend is triggered.

Expected Results:  
Power Devil should wait until the inhibitor has been removed. Then a shutdown
should beeing triggered. As an alternative there should be an timeout for the
password prompt a retry to suspend after some time.

This is the program I used to set the inhibitor. Run it from another user and
then try to suspend the machine from the session user. In any case the sleep
will be rejected.  

#!/usr/bin/python3

import dbus
import logging
import time

bus = dbus.SystemBus()

def inhibit(what='sleep', who='First Base',
why="left field", mode="block"):
try:
a = bus.get_object('org.freedesktop.login1',
'/org/freedesktop/login1')
interface = 'org.freedesktop.login1.Manager'
print("Inhibitor opened: what = {}, mode = {}".format(what, mode))
fd = a.Inhibit(what, who, why, mode, dbus_interface=interface)
return fd
except Exception as error:
logging.exception(error)
logging.warning("could not set inhibitor lock")

if __name__ == '__main__':
my_inhibitor_fd = inhibit()
#input('press any key to exit inhibitor')
inhibitTime = 1200
print("Suspend inhibitor will be active for {}
seconds".format(inhibitTime))
time.sleep(inhibitTime)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

PSA: libkscreen dependency bumped to Qt 5.4

Quick announcement: We bumped the required Qt version of libkscreen today to 
Qt 5.4 (it was 5.2). The reason is a regression in Qt which caused a crash on 
teardown of the QScreen backend. We fixed it by using API which was new in Qt 
5.4.

I don't expect this to be a problem, as the dependency for Plasma has already 
been bumped to 5.6 recently, but I thought a heads-up wouldn't hurt, still.

Cheers,
-- 
sebas

Sebastian Kügler•http://vizZzion.org•http://www.kde.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1788: [Pager] Don't update models when not visible

broulik added a comment.


  What could cause this root.visible problem?
  
  The container is invisible and removing the explicit applet.visible = true 
call in the Panel doesn't help either. I tried everything, yet still initially 
it thinks it's visible.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1788

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1768: Pass screen ID to systray applets

2016-06-07 Thread davidedmundson (David Edmundson)

davidedmundson closed this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1768

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1791: Give a screen to systray applets

2016-06-07 Thread davidedmundson (David Edmundson)

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  much neater ++

INLINE COMMENTS

> shellcorona.cpp:345
>  foreach(Plasma::Containment *containment, containments()) {
> -if (containment->formFactor() == Plasma::Types::Horizontal ||
> -containment->formFactor() == Plasma::Types::Vertical) {
> +if (containment->containmentType() != 
> Plasma::Types::CustomEmbeddedContainment && (containment->formFactor() == 
> Plasma::Types::Horizontal ||
> +containment->formFactor() == Plasma::Types::Vertical)) {

given the code beneath searches in m_panels and m_desktop white listing would 
match better.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1791

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson
Cc: davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1792: Fix calculation of the shadow size in the OpenGL compositor

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN2cc47004c305: Fix calculation of the shadow size in the 
OpenGL compositor (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1792?vs=4278&id=4281

REVISION DETAIL
  https://phabricator.kde.org/D1792

AFFECTED FILES
  scene_opengl.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: plasma-devel, kwin, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1792: Fix calculation of the shadow size in the OpenGL compositor

sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  shadow-opengl-size-fix

REVISION DETAIL
  https://phabricator.kde.org/D1792

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: plasma-devel, kwin, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1792: Fix calculation of the shadow size in the OpenGL compositor

graesslin added a dependency: D1790: Verify that the Shadow has a valid size 
before trying to create it.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1792

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 14 lines] D1791: Give a screen to systray applets

mart updated this revision to Diff 4279.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1791?vs=4277&id=4279

REVISION DETAIL
  https://phabricator.kde.org/D1791

AFFECTED FILES
  applets/systemtray/container/systemtraycontainer.cpp
  applets/systemtray/systemtray.cpp
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 19 lines] D1792: Fix calculation of the shadow size in the OpenGL compositor

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  This change addresses the problem of the incorrectly rendered shadows
  when opening a window (e.g. Kickoff) a second time. In case of e.g.
  Kickoff not all elements are set, thus e.g. left might be 0, but right
  has a value. So for calculating the height the maximum of the values
  must be used.

TEST PLAN
  Opened Kickoff and systray a few times

REPOSITORY
  rKWIN KWin

BRANCH
  shadow-opengl-size-fix

REVISION DETAIL
  https://phabricator.kde.org/D1792

AFFECTED FILES
  scene_opengl.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 12 lines] D1791: Give a screen to systray applets

mart updated this revision to Diff 4277.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1791?vs=4276&id=4277

REVISION DETAIL
  https://phabricator.kde.org/D1791

AFFECTED FILES
  applets/systemtray/container/systemtraycontainer.cpp
  applets/systemtray/systemtray.cpp
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 13 lines] D1791: Give a screen to systray applets

mart created this revision.
mart set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  don't hardcode -a as the internal systray screen anymore.
  give it the new customembeddedcontainment containment type, and ignore those 
in panel creation.
  the old systray logic in containmentforscreen gets reused.

TEST PLAN
  tried to move the panel from one screen to another, notifications screen went 
from 0 to 1

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1791

AFFECTED FILES
  applets/systemtray/container/systemtraycontainer.cpp
  applets/systemtray/systemtray.cpp
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

2016-06-07 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/
---

(Updated June 7, 2016, 1:23 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma and David Rosca.


Changes
---

Submitted with commit 9575b8c009d5500126cc0edb1a384ab39fd0a641 by Aleix Pol to 
branch master.


Bugs: 60777
http://bugs.kde.org/show_bug.cgi?id=60777


Repository: plasma-framework


Description
---

Iteration of: https://git.reviewboard.kde.org/r/127848/

We either load the existing layout or we load a default one.

With this, it could be removed from ShellCorona.


Diffs
-

  src/plasma/corona.h d8f829a 
  src/plasma/corona.cpp 1784516 

Diff: https://git.reviewboard.kde.org/r/127850/diff/


Testing
---

Tests pass.
PlasmaShell prints completed once both with and without configuration.


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128089: [Quick Chat] Add context menu for copying text and links

2016-06-07 Thread Thomas Pfeiffer


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128089/#review96258
---



Akthough of course I'd prefer being able to actually select text, this is a 
very helpful workaround for the fact that we cannot have that.

Why do links have the option to open the link in the context menu? That's what 
left-clicking already does, isn't it?

- Thomas Pfeiffer


On June 7, 2016, 12:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128089/
> ---
> 
> (Updated June 7, 2016, 12:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> ---
> 
> This allows to copy links by right clicking them and copying individual text 
> snippets to the clipboard.
> 
> 
> Diffs
> -
> 
>   chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml 1485c4c 
>   chat/org.kde.ktp-chat/contents/ui/TextDelegate.qml ab686a6 
>   chat/qmlplugin/CMakeLists.txt 52e79a0 
>   chat/qmlplugin/htmlhelper.h PRE-CREATION 
>   chat/qmlplugin/htmlhelper.cpp PRE-CREATION 
>   chat/qmlplugin/qmlplugin.cpp 71a6495 
> 
> Diff: https://git.reviewboard.kde.org/r/128089/diff/
> 
> 
> Testing
> ---
> 
> Unfortunately QtQuick has no proper text selection and you can only copy one 
> message at a time, not an entire paragraph from a user, although it looks 
> that way because they're grouped. Better than nothing I suppose.
> 
> 
> File Attachments
> 
> 
> Copy link
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/03/15b0f08e-9a54-46c3-9d87-e817a7dfbef1__Screenshot_20160603_161915.png
> Copy text
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/03/e431324f-de43-4d17-9f65-9f16f5af2f92__Screenshot_20160603_161931.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 128118: new containment type for the systray

2016-06-07 Thread Marco Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128118/
---

Review request for Plasma and David Edmundson.


Repository: plasma-framework


Description
---

add a new containment type for use in the systray: this way it will be able to 
have a screen number without actually creating a panel from its own


Diffs
-

  src/plasma/plasma.h 9ec4470 

Diff: https://git.reviewboard.kde.org/r/128118/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128089: [Quick Chat] Add context menu for copying text and links

2016-06-07 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128089/
---

(Updated Juni 7, 2016, 12:52 nachm.)


Review request for Plasma and KDE Usability.


Changes
---

* Remove HTML tags and decode HTML entities for copied text


Repository: ktp-desktop-applets


Description
---

This allows to copy links by right clicking them and copying individual text 
snippets to the clipboard.


Diffs (updated)
-

  chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml 1485c4c 
  chat/org.kde.ktp-chat/contents/ui/TextDelegate.qml ab686a6 
  chat/qmlplugin/CMakeLists.txt 52e79a0 
  chat/qmlplugin/htmlhelper.h PRE-CREATION 
  chat/qmlplugin/htmlhelper.cpp PRE-CREATION 
  chat/qmlplugin/qmlplugin.cpp 71a6495 

Diff: https://git.reviewboard.kde.org/r/128089/diff/


Testing (updated)
---

Unfortunately QtQuick has no proper text selection and you can only copy one 
message at a time, not an entire paragraph from a user, although it looks that 
way because they're grouped. Better than nothing I suppose.


File Attachments


Copy link
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/03/15b0f08e-9a54-46c3-9d87-e817a7dfbef1__Screenshot_20160603_161915.png
Copy text
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/03/e431324f-de43-4d17-9f65-9f16f5af2f92__Screenshot_20160603_161931.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1757: [Panel] Reduce duplicate enabled borders calculation

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in Panel.qml:29
> In PanelView::themeChanged
> 
> call positionPanel()
> Will acheive the same thing.
> 
> and then we can get rid of this.

ok

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1757

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, mart, davidedmundson, #plasma
Cc: mart, davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1778: [PanelConfigView] Set enabled borders on PanelShadow

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1778

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128108: update weather applet ui

2016-06-07 Thread Andreas Kainz

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128108/
---

(Updated June 7, 2016, 11:46 a.m.)

Review request for Plasma and Friedrich W. H. Kossebau.

Changes
---

from the design point of view I'm finished.

I hope I could also fixed the dev issues.

Repository: kdeplasma-addons

Description
---

the scaling work now better and the pading between the single lines can be
smaler (If you make the applet higher you can also have the old line spacing)

it's my first qml change, so ...

on my todo, I'd like to change the powerd by weather.com text color so a
secondary gray (bring it a bit more to the background), but I don't know how.

Diffs (updated)
-

applets/weather/package/contents/ui/TopPanel.qml 1821f16
applets/weather/package/contents/ui/WeatherListView.qml c7b331e
applets/weather/package/contents/ui/main.qml d490728

Diff: https://git.reviewboard.kde.org/r/128108/diff/

Testing
---

with breeze and breeze dark color scheme on two different pc's. the icons are
breeze weather icons (master)

File Attachments

screenshot

https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/350136df-37c8-4fef-bddb-d4b609df2fb1__weather.png
I hope I had fixed all open issues. I now have only one open issue I could
change the linkColor but I can't change the color when there is no link like in
noaa

https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/3ef83b18-d8e3-4a73-a8da-a069c56a560a__weather.png

Thanks,

Andreas Kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1788: [Pager] Don't update models when not visible

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1788

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1770: [OSD] Allow disabling OSD through config file

mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.


  ah, ok fine then ;)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1770

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: mart, graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128108: update weather applet ui

2016-06-07 Thread Marco Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128108/#review96254
---



almost good to go, still a couple of issues


applets/weather/package/contents/ui/TopPanel.qml (line 35)


this change has no effect



applets/weather/package/contents/ui/main.qml (line 117)


we have units.gridUnit, units,largeSpacing, units.smallSpacing but not 
units.Spacing, this is equivalent to say bottomMargin: 0


- Marco Martin


On June 6, 2016, 8:41 p.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128108/
> ---
> 
> (Updated June 6, 2016, 8:41 p.m.)
> 
> 
> Review request for Plasma and Friedrich W. H. Kossebau.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> the scaling work now better and the pading between the single lines can be 
> smaler (If you make the applet higher you can also have the old line spacing)
> 
> it's my first qml change, so ...
> 
> on my todo, I'd like to change the powerd by weather.com text color so a 
> secondary gray (bring it a bit more to the background), but I don't know how.
> 
> 
> Diffs
> -
> 
>   applets/weather/package/contents/ui/TopPanel.qml 1821f16 
>   applets/weather/package/contents/ui/WeatherListView.qml c7b331e 
>   applets/weather/package/contents/ui/main.qml d490728 
> 
> Diff: https://git.reviewboard.kde.org/r/128108/diff/
> 
> 
> Testing
> ---
> 
> with breeze and breeze dark color scheme on two different pc's. the icons are 
> breeze weather icons (master)
> 
> 
> File Attachments
> 
> 
> screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/350136df-37c8-4fef-bddb-d4b609df2fb1__weather.png
> I hope I had fixed all open issues. I now have only one open issue I could 
> change the linkColor but I can't change the color when there is no link like 
> in noaa
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/3ef83b18-d8e3-4a73-a8da-a069c56a560a__weather.png
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128108: update weather applet ui

2016-06-07 Thread Andreas Kainz



> On Juni 6, 2016, 7:39 vorm., Sebastian Kügler wrote:
> > applets/weather/package/contents/ui/TopPanel.qml, line 34
> > 
> >
> > add a spacer Item instead of putting in magical numbers
> 
> Andreas Kainz wrote:
> what's a spacer item?

I used parent.height for the icon width cause the icons is squared. scales good 
and I think it's a good idea.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128108/#review96217
---


On Juni 6, 2016, 8:41 nachm., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128108/
> ---
> 
> (Updated Juni 6, 2016, 8:41 nachm.)
> 
> 
> Review request for Plasma and Friedrich W. H. Kossebau.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> the scaling work now better and the pading between the single lines can be 
> smaler (If you make the applet higher you can also have the old line spacing)
> 
> it's my first qml change, so ...
> 
> on my todo, I'd like to change the powerd by weather.com text color so a 
> secondary gray (bring it a bit more to the background), but I don't know how.
> 
> 
> Diffs
> -
> 
>   applets/weather/package/contents/ui/TopPanel.qml 1821f16 
>   applets/weather/package/contents/ui/WeatherListView.qml c7b331e 
>   applets/weather/package/contents/ui/main.qml d490728 
> 
> Diff: https://git.reviewboard.kde.org/r/128108/diff/
> 
> 
> Testing
> ---
> 
> with breeze and breeze dark color scheme on two different pc's. the icons are 
> breeze weather icons (master)
> 
> 
> File Attachments
> 
> 
> screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/350136df-37c8-4fef-bddb-d4b609df2fb1__weather.png
> I hope I had fixed all open issues. I now have only one open issue I could 
> change the linkColor but I can't change the color when there is no link like 
> in noaa
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/3ef83b18-d8e3-4a73-a8da-a069c56a560a__weather.png
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1789: Add destructor request to org_kde_kwin_shadow and org_kde_kwin_shadow_manager

graesslin added a project: Plasma on Wayland.

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1789

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 46 lines] D1789: Add destructor request to org_kde_kwin_shadow and org_kde_kwin_shadow_manager

graesslin created this revision.
graesslin added a reviewer: Plasma on Wayland.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This improves the cleanup of a shadow from client side. The server now
  notices when the client destroyed the shadow.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  shadow-destructor

REVISION DETAIL
  https://phabricator.kde.org/D1789

AFFECTED FILES
  autotests/client/test_shadow.cpp
  src/client/protocols/shadow.xml
  src/client/registry.cpp
  src/server/shadow_interface.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 126 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/126/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Jun 2016 10:48:50 +
Build duration: 9 min 54 sec

CHANGE SET
Revision 9714e81254dfbe0fc39795acd4619796acd7b685 by sitter: (install to 
correct directory)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5012 
(39%)CONDITIONAL 1381/5062 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2738 (5%)CONDITIONAL 
87/2789 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 125 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/125/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Jun 2016 10:31:42 +
Build duration: 17 min

CHANGE SET
Revision 1a39a51e2e36576ca97f5b88af0969687796e7b4 by sitter: (install 
config-X11 as it is used in task.h)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5012 
(39%)CONDITIONAL 1381/5062 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2738 (5%)CONDITIONAL 
87/2789 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1784: Ensure that WaylandServer::shellClientAdded only gets emitted once

graesslin marked 3 inline comments as done.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1784

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: sebas, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 236 lines] D1784: Ensure that WaylandServer::shellClientAdded only gets emitted once

graesslin updated this revision to Diff 4272.
graesslin added a comment.


  Adressed sebas comments

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1784?vs=4265&id=4272

BRANCH
  shell-client-no-multiple-add

REVISION DETAIL
  https://phabricator.kde.org/D1784

AFFECTED FILES
  autotests/wayland/CMakeLists.txt
  autotests/wayland/shell_client_test.cpp
  wayland_server.cpp
  wayland_server.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: sebas, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 124 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/124/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Jun 2016 10:21:57 +
Build duration: 9 min 28 sec

CHANGE SET
Revision 467ab9f30063301b514165c271b14632b5f26b90 by sitter: (libtaskmanager: 
bump soversion from 5 to 6)
  change: edit libtaskmanager/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5012 
(39%)CONDITIONAL 1381/5062 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2738 (5%)CONDITIONAL 
87/2789 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1787: install config-X11 as it is used in task.h

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE1a39a51e2e36: install config-X11 as it is used 
in task.h (authored by Debian/Kubuntu Qt/KDE Maintainers 
, committed by sitter).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1787?vs=4270&id=4271

REVISION DETAIL
  https://phabricator.kde.org/D1787

AFFECTED FILES
  CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, hein
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1784: Ensure that WaylandServer::shellClientAdded only gets emitted once

graesslin added inline comments.

INLINE COMMENTS

> sebas wrote in shell_client_test.cpp:129
> aren't you going overboard here? I don't think this makes the backtrace a lot 
> easier to read...

backtraces here? This is an autotest. If that code crashes at that place we 
have a bigger problem than the readability. It's also a pattern I started to 
use in many tests as some tests showed to do the cleanup in a wrong way.

> sebas wrote in shell_client_test.cpp:180
> I wonder if this should be the default arg in the API. What do you think?

> What do you think?

Not ABI compatible to change. And no, it should not. The idea is to limit the 
rendering of a client with a frame callback. That can only work if we set the 
frame callback. So the default should be with a frame callback.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1784

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: sebas, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 5 lines] D1787: install config-X11 as it is used in task.h

sitter created this revision.
sitter added a reviewer: hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1787

AFFECTED FILES
  CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, hein
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1787: install config-X11 as it is used in task.h

2016-06-07 Thread hein (Eike Hein)

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1787

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, hein
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 25 lines] D1788: [Pager] Don't update models when not visible

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When there is only one virtual desktop, the pager becomes invisible. It makes 
no sense to update the models in this case.

TEST PLAN
  Unfortunately root.visible evaluates true initially until I open and close 
the panelcontroller (the applet will be shown while configuring the panel) :( I 
have no clue why that happens. Other than that:
  
  - No update when the pager is hidden
  - When opening panelcontroller immediately updates and stays live until the 
panelcontroller is closed again
  - Always updates when there's two or more desktops
  
  It's pretty terrible that the pager resets the models on every change, eg. 
even focus changes, causing all the window Rectangles to be destroyed and 
re-created, contributing to lags when opening popups. Until the thing is 
rewritten to use the new tasks model, this at least serves the default setup 
(where the pager will be added but just one virtual desktop).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1788

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml
  applets/pager/plugin/pager.cpp
  applets/pager/plugin/pager.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1785: libtaskmanager: bump soversion from 5 to 6

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE467ab9f30063: libtaskmanager: bump soversion 
from 5 to 6 (authored by sitter).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1785?vs=4267&id=4269

REVISION DETAIL
  https://phabricator.kde.org/D1785

AFFECTED FILES
  libtaskmanager/CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, hein, jriddell
Cc: jriddell, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1785: libtaskmanager: bump soversion from 5 to 6

2016-06-07 Thread jriddell (Jonathan Riddell)

jriddell accepted this revision.
jriddell added a reviewer: jriddell.
jriddell added a comment.
This revision is now accepted and ready to land.


  I assume there's been an ABI change, in which case ship it

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1785

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, hein, jriddell
Cc: jriddell, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 2 lines] D1785: libtaskmanager: bump soversion from 5 to 6

sitter created this revision.
sitter added a reviewer: hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  new library features new ABI

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1785

AFFECTED FILES
  libtaskmanager/CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, hein
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1784: Ensure that WaylandServer::shellClientAdded only gets emitted once

sebas added a comment.


  a few questions and suggestions, feedback welcome...

INLINE COMMENTS

> shell_client_test.cpp:129
> +{
> +#define CLEANUP(name) \
> +if (name) { \

aren't you going overboard here? I don't think this makes the backtrace a lot 
easier to read...

> shell_client_test.cpp:180
> +surface->attachBuffer(Buffer::Ptr());
> +surface->commit(Surface::CommitFlag::None);
> +QVERIFY(hiddenSpy.wait());

I wonder if this should be the default arg in the API. What do you think?

> shell_client_test.cpp:190
> +QCOMPARE(clientAddedSpy.count(), 1);
> +QVERIFY(windowShownSpy.wait());
> +QCOMPARE(clientAddedSpy.count(), 1);

Also check windowShownSpy.count()?

> shell_client_test.cpp:202
> +surface.reset();
> +QVERIFY(windowClosedSpy.wait());
> +}

Check count here?

> wayland_server.cpp:251
> +ShellClient *c = dynamic_cast(t);
> +if (!c) {
> +return;

worth warning here, or is this a valid case? (Looks like an application bug if 
this return is hit)

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1784

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: sebas, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1784: Ensure that WaylandServer::shellClientAdded only gets emitted once

graesslin added a subscriber: plasma-devel.
graesslin added projects: KWin, Plasma on Wayland.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1784

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 123 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/123/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Jun 2016 08:26:30 +
Build duration: 17 min

CHANGE SET
Revision 5a760823581e0fa248a110b10c9bb3da05439692 by hein: (Cleanup and guard 
against empty URLs where necessary to avoid false)
  change: edit libtaskmanager/tasktools.cpp
  change: edit libtaskmanager/tasksmodel.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5012 
(39%)CONDITIONAL 1381/5062 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2738 (5%)CONDITIONAL 
87/2789 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 179 lines] D1779: Add a parent_window event to Plasma Window interface

graesslin updated this revision to Diff 4264.
graesslin added a comment.


  Frameworks version is now 5.24. This means we also need to increase the
  interface version

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1779?vs=4244&id=4264

BRANCH
  parent-window

REVISION DETAIL
  https://phabricator.kde.org/D1779

AFFECTED FILES
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/protocols/plasma-window-management.xml
  src/client/registry.cpp
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, hein
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Planned Changes To] D1780: Expose the transientFor relationship to PlasmaWindowInterface