Re: SDDM Theme update

[kainz.a]

Am 15.06.2016 00:43 schrieb "David Edmundson" :
>
>
>
> On Wed, Jun 15, 2016 at 12:30 AM, David Edmundson <
da...@davidedmundson.co.uk> wrote:
>>
>> On Fri, Jun 10, 2016 at 10:53 PM, kainz.a  wrote:
>>>
>>> Hi David,
>>>
>>> kde neon dev ship the new breeze sddm theme (thanks jonathan). It look
really good, but I have also some remarks:
>>
>>
>>>
>>> 1. the avatar icon is to small (not the same size than the plymount
icon)
>>
>>
>> I dont' know how big plymouth is.
>> I've made it bigger anyhow.
>>
>>>
>>> 2. can we use the ? and generic avatar I prepare for you
>>
>>
>> Apparently not. Plasma icon hates that icon. It finds the file, loads
it... then doesn't display it.
>> It loads everything else except that. I've spent an hour on this. I'm
rage quitting now.
>>
> Found what's wrong.
>
> Those icons are corrupt.
>
> They'll render in inkscape (with warnings) but not Qt's SVG renderer.
>
> If I open one, change something and undo it, then save again. Things work.
>
> Shall I submit those fixes, for frameworks 5.24?
> But we need to work out what we do for Plasma now. I could copy it
locally so we can ship something.
>

Yes give them in the local repo and in 5.8 we switch to use them from the
icon set.

>>
>> Also why did you put those icons in applets?
>> That doesn't make any sense. It's not an applet.
>>
>>>
>>> 3. the search for user avatar is higher than the user avatar
>>
>>
>> Done
>>
>>> 4. can we align center the button text like the user name (cause the
theme is also center align)
>>
>>
>> If you mean placeholder text. No.
>>
>>>
>>> 5. you see the breeze cursor only when you hover the avatar or the
bottons (not the wallpaper) it is possible to see also the breeze cursors
when you are at the wallpaper
>>
>>
>> if you change sddm.conf to set the cursor theme to breeze that should
fix itself?
>> Hopefully all packagers have.
>>
>>>
>>> 6. the drop down indicators (session and keyboard layout) look to smal
>>> 7. can the drop down text have a bigger size
>>
>>
>>
>>> 8. it look like there is a problem with the restart icon (I will check
this)
>>
>>
>>
>>>
>>> 9. when you use the tab key to switch between the bottons you see a
light blue frame around the botton can it switch to the same layout as you
see when you hover the botton with the mouse
>>>
>>
>> Plasma has two frames in the SVG
>>  "hover" and "focus"
>>
>> Switching with the tab key changes shows "focus"
>>
>> Text fields have a big glow on hover, buttons don't.
>>
>> If the theme needs changing, the theme should be changed.
>>
>> maybe we can just copy and paste from the textfield?
>>
>> >10. is it possible to have the focus on the input pasword box, so when
the login manager was shown you can input the password with the keyboard
without go to the input box with the mouse.
>>
>> Fixed. Thanks.
>>
>>
>>> thank you very much david that you work on the theme.
>>> Andreas Kainz
>>>
>>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1874: [XWindowTasksModel] Ignore when client is transient for itself

[Martin Gräßlin]

graesslin added a comment.


  now I have a headache after reading the explanation.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1874

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, hein, #plasma
Cc: graesslin, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 36 lines] D1882: Expose inline grouping mode.

[hein (Eike Hein)]

hein created this revision.
hein added a reviewer: davidedmundson.
hein added a subscriber: plasma-devel.
hein added a dependency: D1881: Add an inline grouping mode..
Restricted Application added a project: Plasma.

REVISION SUMMARY
  In inline grouping mode, task buttons are smaller by default (as
  in EITM).
  
  Depends on https://phabricator.kde.org/D1881.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  blblblbl

REVISION DETAIL
  https://phabricator.kde.org/D1882

AFFECTED FILES
  applets/taskmanager/package/contents/code/layout.js
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 724 lines] D1881: Add an inline grouping mode.

[hein (Eike Hein)]

hein created this revision.
hein added a reviewer: davidedmundson.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  When grouping inline, the group subtrees are flattened out into
  the top-level list, parents removed, and move() treats groups as
  singular entities.
  
  This functionality was previously found in Netrunner's Expanding
  Icons Task Manager fork.
  
  This is the first half of the EITM functionality merge.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1881

AFFECTED FILES
  libtaskmanager/CMakeLists.txt
  libtaskmanager/flattentaskgroupsproxymodel.cpp
  libtaskmanager/flattentaskgroupsproxymodel.h
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 167 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/167/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 22:47:41 +
Build duration: 24 min

CHANGE SET
Revision 78db2802b6c09c1a6d789dbf5af2cccbc913c9bc by kde: ([BreezeBlock] Use 
QtRendering for time label)
  change: edit lookandfeel/contents/components/InfoPane.qml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5042 
(39%)CONDITIONAL 1381/5124 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2768 (5%)CONDITIONAL 
87/2851 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 166 - Still Unstable!

[David Edmundson]

​Aleix, it is failing in plasmoid tests.
Can you look into it?

FWIW, ctest passes locally here - so it is a problem purely with the CI
rather than the code itself.
But having something broken for a month and a half isn't really on.

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 166 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/166/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 22:34:58 +
Build duration: 9 min 48 sec

CHANGE SET
Revision af6075e397b12c06b2ffda433f75298cd103f33a by kde: ([Login Screen] Add 
large clock)
  change: edit lookandfeel/contents/loginmanager/Login.qml
  change: edit lookandfeel/contents/loginmanager/Main.qml
Revision 8f41705a9651810e9d33b40e6e09e71f2ff86e68 by David Edmundson: (Correct 
margin for user search)
  change: edit lookandfeel/contents/loginmanager/UserDelegate.qml
Revision 3bd5ebcf82fe27a5877a92a0f3715b6978e45f86 by David Edmundson: (Make 
faces size bigger)
  change: edit lookandfeel/contents/loginmanager/UserList.qml
  change: edit lookandfeel/contents/loginmanager/UserDelegate.qml
Revision 49baf67e86a0404dda43c321f06b2d91dbf14575 by kde: ([Splash Screen] 
Change design to match new login screen)
  change: edit lookandfeel/contents/splash/Splash.qml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5042 
(39%)CONDITIONAL 1381/5124 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2768 (5%)CONDITIONAL 
87/2851 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: SDDM Theme update

[David Edmundson]

On Wed, Jun 15, 2016 at 12:30 AM, David Edmundson <
da...@davidedmundson.co.uk> wrote:

> On Fri, Jun 10, 2016 at 10:53 PM, kainz.a  wrote:
>
>> Hi David,
>>
>> kde neon dev ship the new breeze sddm theme (thanks jonathan). It look
>> really good, but I have also some remarks:
>>
>
>
>> 1. the avatar icon is to small (not the same size than the plymount icon)
>>
>
> I dont' know how big plymouth is.
> I've made it bigger anyhow.
>
>
>> 2. can we use the ? and generic avatar I prepare for you
>>
>
> Apparently not. Plasma icon hates that icon. It finds the file, loads
> it... then doesn't display it.
> It loads everything else except that. I've spent an hour on this. I'm rage
> quitting now.
>
> Found what's wrong.

Those icons are corrupt.

They'll render in inkscape (with warnings) but not Qt's SVG renderer.

If I open one, change something and undo it, then save again. Things work.

Shall I submit those fixes, for frameworks 5.24?
But we need to work out what we do for Plasma now. I could copy it locally
so we can ship something.



> Also why did you put those icons in applets?
> That doesn't make any sense. It's not an applet.
>
>
>> 3. the search for user avatar is higher than the user avatar
>>
>
> Done
>
> 4. can we align center the button text like the user name (cause the theme
>> is also center align)
>>
>
> If you mean placeholder text. No.
>
>
>> 5. you see the breeze cursor only when you hover the avatar or the
>> bottons (not the wallpaper) it is possible to see also the breeze cursors
>> when you are at the wallpaper
>>
>
> if you change sddm.conf to set the cursor theme to breeze that should fix
> itself?
> Hopefully all packagers have.
>
>
>> 6. the drop down indicators (session and keyboard layout) look to smal
>> 7. can the drop down text have a bigger size
>>
>
>
> 8. it look like there is a problem with the restart icon (I will check
>> this)
>>
>
>
>
>> 9. when you use the tab key to switch between the bottons you see a light
>> blue frame around the botton can it switch to the same layout as you see
>> when you hover the botton with the mouse
>>
>>
> Plasma has two frames in the SVG
>  "hover" and "focus"
>
> Switching with the tab key changes shows "focus"
>
> Text fields have a big glow on hover, buttons don't.
>
> If the theme needs changing, the theme should be changed.
>
> maybe we can just copy and paste from the textfield?
>
> >10. is it possible to have the focus on the input pasword box, so when
> the login manager was shown you can input the password with the keyboard
> without go to the input box with the mouse.
>
> Fixed. Thanks.
>
>
> thank you very much david that you work on the theme.
>> Andreas Kainz
>>
>>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 165 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/165/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 22:24:41 +
Build duration: 9 min 58 sec

CHANGE SET
Revision b5a5c1584bea4aa04fbc4c8371f4bc9f738bb178 by Friedrich W. H. Kossebau: 
([Weather] --deprecated call)
  change: edit dataengines/weather/weatherengine.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5042 
(39%)CONDITIONAL 1381/5124 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2768 (5%)CONDITIONAL 
87/2851 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128108: update weather applet ui

[Friedrich W. H. Kossebau]

> On June 14, 2016, 5:45 a.m., Andreas Kainz wrote:
> > can I get a ship it to get it in plasma 5.7, or any feedback what I have to 
> > improve.

Ah, pardon, missed that your last comment actually came with an update to the 
patch. Looks good codewise, besides that one issue which I just reopened. 
Please catch me on irc tomorrow during the day, if you need help there and in 
any case, would like to help to get this in for 5.7.


- Friedrich W. H.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128108/#review96450
---


On June 10, 2016, 10:37 p.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128108/
> ---
> 
> (Updated June 10, 2016, 10:37 p.m.)
> 
> 
> Review request for Plasma and Friedrich W. H. Kossebau.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> the scaling work now better and the pading between the single lines can be 
> smaler (If you make the applet higher you can also have the old line spacing)
> 
> it's my first qml change, so ...
> 
> on my todo, I'd like to change the powerd by weather.com text color so a 
> secondary gray (bring it a bit more to the background), but I don't know how.
> 
> 
> Diffs
> -
> 
>   applets/weather/package/contents/ui/TopPanel.qml 1821f16 
>   applets/weather/package/contents/ui/WeatherListView.qml c7b331e 
>   applets/weather/package/contents/ui/main.qml d490728 
> 
> Diff: https://git.reviewboard.kde.org/r/128108/diff/
> 
> 
> Testing
> ---
> 
> with breeze and breeze dark color scheme on two different pc's. the icons are 
> breeze weather icons (master)
> 
> 
> File Attachments
> 
> 
> screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/350136df-37c8-4fef-bddb-d4b609df2fb1__weather.png
> I hope I had fixed all open issues. I now have only one open issue I could 
> change the linkColor but I can't change the color when there is no link like 
> in noaa
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/3ef83b18-d8e3-4a73-a8da-a069c56a560a__weather.png
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 164 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/164/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 21:19:36 +
Build duration: 17 min

CHANGE SET
Revision a543be48d486f335abaead0b1e33ff4ee65e7530 by kde: ([Login Screen] Avoid 
binding source to visible)
  change: edit lookandfeel/contents/loginmanager/UserDelegate.qml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5042 
(39%)CONDITIONAL 1381/5124 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2768 (5%)CONDITIONAL 
87/2851 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 163 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/163/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 20:43:14 +
Build duration: 18 min

CHANGE SET
Revision 8205d34657d2e83c28714c9568b87717f575dc8e by David Edmundson: (Keep 
forceActiveFocus hack from old SDDM theme to new theme)
  change: edit lookandfeel/contents/loginmanager/Login.qml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5042 
(39%)CONDITIONAL 1381/5124 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2768 (5%)CONDITIONAL 
87/2851 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1867: [Calendar Applet] Show day or week number in icon

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  That icon has been shipped, but never used, with the calendar applet for so 
long I don't even find a trace of it being added in git log.
  
  It's 
plasma-workspace/applets/calendar/package/contents/images/mini-calendar.svgz

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1867

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 162 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/162/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 20:24:00 +
Build duration: 19 min

CHANGE SET
Revision d845889d2c5fb1f400f954ec262928a81088f46f by kde: ([Lock Screen] Use 
generic Plasma blue background)
  change: edit lookandfeel/contents/lockscreen/LockScreen.qml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5042 
(39%)CONDITIONAL 1381/5124 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2768 (5%)CONDITIONAL 
87/2851 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1865: TasksModel: cache launcherCount().

[dfaure (David Faure)]

dfaure closed this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1865

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dfaure, hein
Cc: broulik, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 161 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/161/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 19:31:20 +
Build duration: 19 min

CHANGE SET
Revision 58ea81b94ba306e2a4039daf536ab9683034d788 by kde: ([XWindowTasksModel] 
Ignore when client is transient for itself)
  change: edit libtaskmanager/xwindowtasksmodel.cpp
Revision 6e72674af56024daee86fe16048aff1eb595e4a7 by David Faure: (TasksModel: 
cache launcherCount().)
  change: edit libtaskmanager/tasksmodel.cpp
  change: edit libtaskmanager/tasksmodel.h


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5042 
(39%)CONDITIONAL 1381/5124 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2768 (5%)CONDITIONAL 
87/2851 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 364313] Umbrello crash

[Ralf Habacker via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364313

Ralf Habacker  changed:

   What|Removed |Added

Product|umbrello|Breeze
   Assignee|umbrello-de...@kde.org  |plasma-devel@kde.org
  Component|general |general

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1860: make kirigamiplugin also directly linkable

[bearsh (Martin)]

bearsh closed this revision.

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D1860

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bearsh, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1865: TasksModel: cache launcherCount().

[hein (Eike Hein)]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  Since I'm only asking for comment changes I'm accepting it code-wise :)

INLINE COMMENTS

> tasksmodel.cpp:744
>  if (!filterIndex.data(AbstractTasksModel::IsLauncher).toBool()) {
> +// TODO: it would be much faster if we didn't ask for a URL with 
> serialized PNG data in it, just to discard it a few lines below
>  const QUrl &launcherUrl = 
> filterIndex.data(AbstractTasksModel::LauncherUrl).toUrl();

(Very) pedantic: "It" should be uppercase and the sentence end in a period.

> tasksmodel.cpp:1324
>  filteredIndex.data(AbstractTasksModel::LauncherUrl).toUrl(), 
> IgnoreQueryItems))) {
> -emit launcherCountChanged();
> +// Not sure why this is here. We're filtering, not handling 
> a change.
> +QMetaObject::invokeMethod(const_cast(this), 
> "updateLauncherCount", Qt::QueuedConnection);

If filterAcceptsRow() decides to filter out a launcher task, the count might 
have changed. Of course it would also be possible to do this outside of 
filtering, but ... can you drop this comment for now?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1865

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dfaure, hein
Cc: broulik, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1874: [XWindowTasksModel] Ignore when client is transient for itself

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE58ea81b94ba3: [XWindowTasksModel] Ignore when 
client is transient for itself (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1874?vs=4467&id=4468

REVISION DETAIL
  https://phabricator.kde.org/D1874

AFFECTED FILES
  libtaskmanager/xwindowtasksmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, hein, #plasma
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1874: [XWindowTasksModel] Ignore when client is transient for itself

[hein (Eike Hein)]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1874

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, hein, #plasma
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 2 lines] D1874: [XWindowTasksModel] Ignore when client is transient for itself

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  Now I get Android Studio windows in task bar. Client bug but that's the X 
world...

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1874

AFFECTED FILES
  libtaskmanager/xwindowtasksmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 41 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/41/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 14:26:55 +
Build duration: 13 min

CHANGE SET
Revision 521b257894b88b307b4fa0ce713658e4f4bada76 by Jonathan Riddell: 
([PanelView] Fix build...)
  change: edit shell/panelview.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 43/49 (88%)CLASSES 43/49 (88%)LINE 1683/2124 
(79%)CONDITIONAL 1209/2103 (57%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 41 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/41/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 14:26:55 +
Build duration: 13 min

CHANGE SET
Revision 521b257894b88b307b4fa0ce713658e4f4bada76 by Jonathan Riddell: 
([PanelView] Fix build...)
  change: edit shell/panelview.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 43/49 (88%)CLASSES 43/49 (88%)LINE 1683/2124 
(79%)CONDITIONAL 1209/2103 (57%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128181: Remove a lot of duplication between both AppletInterface constructors

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128181/#review96484
---



> connect(applet(), &Plasma::Applet::contextualActionsAboutToShow,
>this, &AppletInterface::contextualActionsAboutToShow);
>
>connect(applet(), &Plasma::Applet::activated,
>this, &AppletInterface::activated);

This should work with both applet types, though?

> connect(applet(), &Plasma::Applet::configurationRequiredChanged,
>this, [this](bool needsConfig, const QString &reason) {
>emit configurationRequiredChanged();
>emit configurationRequiredReasonChanged();
>});

So, that's where the configuration required thing comes into play but this 
doesn't fix the property access which tries to read from appletInterface() 
which is null becuase it never sets/creates one and the thing in applet() is 
protected.

Also, can we just use delegating constructors instead? (Not sure we can in 
frameworks, though)

- Kai Uwe Broulik


On Juni 14, 2016, 9:03 vorm., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128181/
> ---
> 
> (Updated Juni 14, 2016, 9:03 vorm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Also the two were slightly out of sync leading to some connections not
> being in each constructor.
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 
> 6a64594cd53cecfbc99ad7562706e1a78d60c138 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 
> df2d642445bdcc81d7fed463cb38c337380ea25b 
> 
> Diff: https://git.reviewboard.kde.org/r/128181/diff/
> 
> 
> Testing
> ---
> 
> previous code.
> 
> 
> FIRST CTOR ONLY  (normal mode)
> connect(applet(), &Plasma::Applet::contextualActionsAboutToShow,
> this, &AppletInterface::contextualActionsAboutToShow);
> 
> connect(applet(), &Plasma::Applet::activated,
> this, &AppletInterface::activated);
> 
> 
> connect(this, &AppletInterface::expandedChanged, [=](bool expanded) {
> //if both compactRepresentationItem and fullRepresentationItem exist,
> //the applet is in a popup
> if (expanded) {
> if (compactRepresentationItem() && fullRepresentationItem() &&
> fullRepresentationItem()->window() && 
> compactRepresentationItem()->window() &&
> fullRepresentationItem()->window() != 
> compactRepresentationItem()->window() &&
> fullRepresentationItem()->parentItem()) {
> 
> fullRepresentationItem()->parentItem()->installEventFilter(this);
> } else if (fullRepresentationItem() && 
> fullRepresentationItem()->parentItem()) {
> 
> fullRepresentationItem()->parentItem()->removeEventFilter(this);
> }
> }
> });
> }
> 
> SECOND CTOR ONLY (special comic applet path)
> 
> connect(applet(), &Plasma::Applet::configurationRequiredChanged,
> this, [this](bool needsConfig, const QString &reason) {
> emit configurationRequiredChanged();
> emit configurationRequiredReasonChanged();
> });
> 
> }
> 
> DUPLICATED:
> qmlRegisterType();
> 
> connect(this, &AppletInterface::configNeedsSaving,
> applet(), &Plasma::Applet::configNeedsSaving);
> connect(applet(), &Plasma::Applet::immutabilityChanged,
> this, &AppletInterface::immutabilityChanged);
> 
> connect(applet(), &Plasma::Applet::userConfiguringChanged,
> this, &AppletInterface::userConfiguringChanged);
> 
> connect(applet(), &Plasma::Applet::statusChanged,
> this, &AppletInterface::statusChanged);
> 
> connect(applet(), &Plasma::Applet::destroyedChanged,
> this, &AppletInterface::destroyedChanged);
> 
> 
> connect(applet(), &Plasma::Applet::titleChanged,
> this, &AppletInterface::titleChanged);
> 
> connect(applet(), &Plasma::Applet::iconChanged,
> this, &AppletInterface::iconChanged);
> 
> connect(applet(), &Plasma::Applet::busyChanged,
> this, &AppletInterface::busyChanged);
> 
> connect(appletScript(), &DeclarativeAppletScript::formFactorChanged,
> this, &AppletInterface::formFactorChanged);
> connect(appletScript(), &DeclarativeAppletScript::locationChanged,
> this, &AppletInterface::locationChanged);
> connect(appletScript(), &DeclarativeAppletScript::contextChanged,
> this, &AppletInterface::contextChanged);
> 
> if (applet()->containment()) {
> connect(applet()->containment(), &Plasma::Containment::screenChanged,

Re:Plasma 5.6.5

[Jonathan Riddell]

On Tue, Jun 14, 2016 at 04:17:30PM +0200, Antonio Rojas wrote:
> Jonathan Riddell  Wrote in message:
> > Plasma 5.6.5 is out, the last of the current series
> > 
> > https://www.kde.org/announcements/plasma-5.6.5.php
> > 
> > The tars come with nifty new .sig files which are PGP signatures so
> > you can verify they are made by the same person who put up the
> > announce on the website and match the signature on the tars in Git.
> > 
> > Jonathan
> 
> plasma-workspace doesn't build, commit 767aa57 needs to be backported

Well spotted, my fault for not checking build.kde properly. 

Plasma Workspace tar updated

http://download.kde.org/stable/plasma/5.6.5/plasma-workspace-5.6.5.tar.xz";>plasma-workspace-5.6.5
6.6MB
-   
7e317e9e7235f9f6cb62ab201a249e82a9cdd1461d801a212ab43ca1b447f476
+   
459e7d361551437007620fd4d05cc7252cbc85e039fa824899832ebcb7ad1495

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128181: Remove a lot of duplication between both AppletInterface constructors

[David Edmundson]

> On June 14, 2016, 10:59 a.m., Anthony Fieroni wrote:
> > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 67
> > 
> >
> > So, this connect and below must be removed? Same connections in newly 
> > setupConnections

erm yeah..that was the entire point of the patch!

I've got something messed up.

Thanks


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128181/#review96467
---


On June 14, 2016, 9:03 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128181/
> ---
> 
> (Updated June 14, 2016, 9:03 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Also the two were slightly out of sync leading to some connections not
> being in each constructor.
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 
> 6a64594cd53cecfbc99ad7562706e1a78d60c138 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 
> df2d642445bdcc81d7fed463cb38c337380ea25b 
> 
> Diff: https://git.reviewboard.kde.org/r/128181/diff/
> 
> 
> Testing
> ---
> 
> previous code.
> 
> 
> FIRST CTOR ONLY  (normal mode)
> connect(applet(), &Plasma::Applet::contextualActionsAboutToShow,
> this, &AppletInterface::contextualActionsAboutToShow);
> 
> connect(applet(), &Plasma::Applet::activated,
> this, &AppletInterface::activated);
> 
> 
> connect(this, &AppletInterface::expandedChanged, [=](bool expanded) {
> //if both compactRepresentationItem and fullRepresentationItem exist,
> //the applet is in a popup
> if (expanded) {
> if (compactRepresentationItem() && fullRepresentationItem() &&
> fullRepresentationItem()->window() && 
> compactRepresentationItem()->window() &&
> fullRepresentationItem()->window() != 
> compactRepresentationItem()->window() &&
> fullRepresentationItem()->parentItem()) {
> 
> fullRepresentationItem()->parentItem()->installEventFilter(this);
> } else if (fullRepresentationItem() && 
> fullRepresentationItem()->parentItem()) {
> 
> fullRepresentationItem()->parentItem()->removeEventFilter(this);
> }
> }
> });
> }
> 
> SECOND CTOR ONLY (special comic applet path)
> 
> connect(applet(), &Plasma::Applet::configurationRequiredChanged,
> this, [this](bool needsConfig, const QString &reason) {
> emit configurationRequiredChanged();
> emit configurationRequiredReasonChanged();
> });
> 
> }
> 
> DUPLICATED:
> qmlRegisterType();
> 
> connect(this, &AppletInterface::configNeedsSaving,
> applet(), &Plasma::Applet::configNeedsSaving);
> connect(applet(), &Plasma::Applet::immutabilityChanged,
> this, &AppletInterface::immutabilityChanged);
> 
> connect(applet(), &Plasma::Applet::userConfiguringChanged,
> this, &AppletInterface::userConfiguringChanged);
> 
> connect(applet(), &Plasma::Applet::statusChanged,
> this, &AppletInterface::statusChanged);
> 
> connect(applet(), &Plasma::Applet::destroyedChanged,
> this, &AppletInterface::destroyedChanged);
> 
> 
> connect(applet(), &Plasma::Applet::titleChanged,
> this, &AppletInterface::titleChanged);
> 
> connect(applet(), &Plasma::Applet::iconChanged,
> this, &AppletInterface::iconChanged);
> 
> connect(applet(), &Plasma::Applet::busyChanged,
> this, &AppletInterface::busyChanged);
> 
> connect(appletScript(), &DeclarativeAppletScript::formFactorChanged,
> this, &AppletInterface::formFactorChanged);
> connect(appletScript(), &DeclarativeAppletScript::locationChanged,
> this, &AppletInterface::locationChanged);
> connect(appletScript(), &DeclarativeAppletScript::contextChanged,
> this, &AppletInterface::contextChanged);
> 
> if (applet()->containment()) {
> connect(applet()->containment(), &Plasma::Containment::screenChanged,
> this, &ContainmentInterface::screenChanged);
> }
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.6.5

[Kai Uwe Broulik]

Yes, because there has been a:
* unreviewed
* not even compiled 
* one day before release 
Commit that broke it. People, this must not be ... 

I fixed it in master but didn't notice (and didn't expect) such a change in 5.6.

Cheers, 
Kai Uwe 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1858: [platforms/drm] Apply new global position on DrmOutput for a changeset

[Sebastian Kügler]

sebas accepted this revision.
sebas added a comment.
This revision is now accepted and ready to land.


  Cool!

REPOSITORY
  rKWIN KWin

BRANCH
  drm-apply-output-position-change

REVISION DETAIL
  https://phabricator.kde.org/D1858

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, sebas, #plasma_on_wayland
Cc: plasma-devel, kwin, hardening, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re:Plasma 5.6.5

[Antonio Rojas]

Jonathan Riddell  Wrote in message:
> Plasma 5.6.5 is out, the last of the current series
> 
> https://www.kde.org/announcements/plasma-5.6.5.php
> 
> The tars come with nifty new .sig files which are PGP signatures so
> you can verify they are made by the same person who put up the
> announce on the website and match the signature on the tars in Git.
> 
> Jonathan

plasma-workspace doesn't build, commit 767aa57 needs to be backported

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1858: [platforms/drm] Apply new global position on DrmOutput for a changeset

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINf5b83d18b892: [platforms/drm] Apply new global position 
on DrmOutput for a changeset (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1858?vs=4436&id=4463

REVISION DETAIL
  https://phabricator.kde.org/D1858

AFFECTED FILES
  plugins/platforms/drm/drm_backend.cpp
  plugins/platforms/drm/drm_output.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, sebas, #plasma_on_wayland
Cc: plasma-devel, kwin, hardening, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Plasma 5.6.5

[Jonathan Riddell]

Plasma 5.6.5 is out, the last of the current series

https://www.kde.org/announcements/plasma-5.6.5.php

The tars come with nifty new .sig files which are PGP signatures so
you can verify they are made by the same person who put up the
announce on the website and match the signature on the tars in Git.

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1868: [server] Introduce a Resource::unbound signal emitted from unbind handler

[bshah (Bhushan Shah)]

bshah accepted this revision.
bshah added a reviewer: bshah.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  resource-unbound

REVISION DETAIL
  https://phabricator.kde.org/D1868

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, sebas, bshah
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1866: Use QVector and QLatin1String, and range-based for

[Sebastian Kügler]

This revision was automatically updated to reflect the committed changes.
Closed by commit rLIBKSCREEN2792f55ff5c2: Use QVector and QLatin1String, and 
range-based for (authored by sebas).

REPOSITORY
  rLIBKSCREEN KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1866?vs=4453&id=4460

REVISION DETAIL
  https://phabricator.kde.org/D1866

AFFECTED FILES
  backends/xrandr/xrandroutput.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, graesslin
Cc: apol, broulik, graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1866: Use QVector and QLatin1String, and range-based for

[Martin Gräßlin]

graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.

REPOSITORY
  rLIBKSCREEN KScreen Library

BRANCH
  sebas/xrandrtyperangefor

REVISION DETAIL
  https://phabricator.kde.org/D1866

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, graesslin
Cc: apol, broulik, graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 29 lines] D1865: TasksModel: cache launcherCount().

[dfaure (David Faure)]

dfaure updated this revision to Diff 4458.
dfaure added a comment.


  Set the new value before emitting the change signal, indeed.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1865?vs=4451&id=4458

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1865

AFFECTED FILES
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dfaure, hein
Cc: broulik, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Changed Subscribers] D1865: TasksModel: cache launcherCount().

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> tasksmodel.cpp:763
> +
> +d->launcherCount = launchers.count();
> +}

Better set the new value before emitting the change signal

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1865

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dfaure, hein
Cc: broulik, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 8 lines] D1869: [Containment Actions] Offer "Remove this panel" option only when panel is being edited

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We only show the "Remove this applet" option when the panel controller is 
opened to prevent the user from accidentally messing up his setup.
  
  However, the "Remove this panel" option, albeit in a submenu, was always 
there and is even more destructive.

TEST PLAN
  Works.
  
  As suggested by the VDG

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1869

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1867: [Calendar Applet] Show day or week number in icon

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Where did you take that icon from?
  We have apps/office-calendar and org.kde.plasma.calendar, both of which look 
quite different from this one.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1867

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Changed Subscribers] D1866: Use QVector and QLatin1String, and range-based for

[apol (Aleix Pol Gonzalez)]

apol added inline comments.

INLINE COMMENTS

> xrandroutput.cpp:258
>  
> -Q_FOREACH(const QString &pre, embedded) {
> +for (const QLatin1String &pre : embedded) {
>  if (name.toUpper().startsWith(pre)) {

This one is fine, but I wouldn't change from `foreach -> for` as a norm, as it 
can easily backfire.

REPOSITORY
  rLIBKSCREEN KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D1866

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: apol, broulik, graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1868: [server] Introduce a Resource::unbound signal emitted from unbind handler

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  resource-unbound

REVISION DETAIL
  https://phabricator.kde.org/D1868

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, sebas
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 35 lines] D1868: [server] Introduce a Resource::unbound signal emitted from unbind handler

[Martin Gräßlin]

graesslin created this revision.
graesslin added a reviewer: Plasma on Wayland.
Restricted Application added a subscriber: plasma-devel.
Restricted Application added a project: Plasma on Wayland.

REVISION SUMMARY
  So far for internal cleanup we mostly listen to QObject::destroyed.
  When a Resource gets unbind the wl_resource is set to null and the
  Resource gets deleteLater. This creates a short time frame when the
  Resource is still there, but the wl_resource is null. For most internal
  usages the Resource is completely useless at that point and should no
  longer be considered. So far it was still considered and could hit
  crashers, if a code path did not nullptr check. Unfortunately
  libwayland-server is not nullptr safe: if called with a null value it
  tends to crash.
  
  So this check introduces a new signal unbound which can be listend to
  in addition to the destroyed signal. It's used in SeatInterface for
  DataDeviceInterface, where we experienced a crash related to that.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  resource-unbound

REVISION DETAIL
  https://phabricator.kde.org/D1868

AFFECTED FILES
  src/server/resource.cpp
  src/server/resource.h
  src/server/seat_interface.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1867: [Calendar Applet] Show day or week number in icon

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  Might need a new icon though
  
  F149458: Screenshot_20160614_144210.png 
  
  F149459: Screenshot_20160614_144217.png 
  
  F149460: Screenshot_20160614_144303.png 
  
  F149461: Screenshot_20160614_144252.png 

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1867

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 810 lines] D1867: [Calendar Applet] Show day or week number in icon

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Rather than showing the generic calendar icon the day number is shown there 
instead.
  There is also an option to have it show the week number instead.
  
  FIXED-IN: 5.7.0
  BUG: 343467

TEST PLAN
  All this effort with the singleton type just because JS Date is stupid and 
doesn't have a weeknumber property.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1867

AFFECTED FILES
  applets/CMakeLists.txt
  applets/calendar/CMakeLists.txt
  applets/calendar/contents/config/config.qml
  applets/calendar/contents/config/main.xml
  applets/calendar/contents/images/mini-calendar.svgz
  applets/calendar/contents/ui/configAgenda.qml
  applets/calendar/contents/ui/configGeneral.qml
  applets/calendar/contents/ui/main.qml
  applets/calendar/metadata.desktop
  applets/calendar/package/contents/config/config.qml
  applets/calendar/package/contents/config/main.xml
  applets/calendar/package/contents/images/mini-calendar.svgz
  applets/calendar/package/contents/ui/configAgenda.qml
  applets/calendar/package/contents/ui/configGeneral.qml
  applets/calendar/package/contents/ui/main.qml
  applets/calendar/package/metadata.desktop
  applets/calendar/plugin/CMakeLists.txt
  applets/calendar/plugin/calendarplugin.cpp
  applets/calendar/plugin/calendarplugin.h
  applets/calendar/plugin/qmldir

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1856: more creative output type detection in xrandr backend

[Sebastian Kügler]

sebas added a comment.


  https://phabricator.kde.org/D1866 there.

REPOSITORY
  rLIBKSCREEN KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D1856

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, dvratil
Cc: broulik, graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 10 lines] D1866: Use QVector and QLatin1String, and range-based for

[Sebastian Kügler]

sebas created this revision.
sebas added a reviewer: Plasma.
sebas added subscribers: graesslin, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This moves the code to the right string types and uses the C++11
  toolbox, instead of Qt macros.

REPOSITORY
  rLIBKSCREEN KScreen Library

BRANCH
  sebas/xrandrtyperangefor

REVISION DETAIL
  https://phabricator.kde.org/D1866

AFFECTED FILES
  backends/xrandr/xrandroutput.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: broulik, graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1856: more creative output type detection in xrandr backend

[Sebastian Kügler]

This revision was automatically updated to reflect the committed changes.
Closed by commit rLIBKSCREEN54ec74901a0f: more creative output type detection 
in xrandr backend (authored by sebas).

REPOSITORY
  rLIBKSCREEN KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1856?vs=4427&id=4452

REVISION DETAIL
  https://phabricator.kde.org/D1856

AFFECTED FILES
  backends/xrandr/xrandroutput.cpp
  backends/xrandr/xrandroutput.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, dvratil
Cc: broulik, graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1856: more creative output type detection in xrandr backend

[Sebastian Kügler]

sebas added inline comments.

INLINE COMMENTS

> graesslin wrote in xrandroutput.cpp:253
> sure you want to use a QStringList? It looks to me like you wanted to have 
> them as QLatin1Strings for the startsWith check. But that doesn't work when 
> converted to QString. So maybe QVector?

This code is copied, I left it as-is, just moved it around.

I'll fix the issues with the existing code separately.

REPOSITORY
  rLIBKSCREEN KScreen Library

BRANCH
  sebas/xrandrtype

REVISION DETAIL
  https://phabricator.kde.org/D1856

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, dvratil
Cc: broulik, graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 30 lines] D1865: TasksModel: cache launcherCount().

[dfaure (David Faure)]

dfaure created this revision.
dfaure added a reviewer: hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This also allows to only emit launcherCountChanged() when it actually changed.
  
  The emit from TasksModel::filterAcceptsRow() is weird though.

TEST PLAN
  adding one launcher for dolphin, shows up. Running dolphin,
  the launcher disappears. Switching desktops, it reappears. Coming back, it
  disappears. Closing dolphin, the launcher reappears.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1865

AFFECTED FILES
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dfaure, hein
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 160 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/160/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 11:52:58 +
Build duration: 11 min

CHANGE SET
Revision f117addb616a13eb49add43d4f0d6324d9887bc9 by kde: ([System Tray 
AbstractItem] Hide tooltip when clicking item)
  change: edit applets/systemtray/package/contents/ui/items/AbstractItem.qml
  change: edit applets/systemtray/package/contents/applet/CompactApplet.qml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5037 
(39%)CONDITIONAL 1381/5120 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2763 (5%)CONDITIONAL 
87/2847 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1860: make kirigamiplugin also directly linkable

[mart (Marco Martin)]

mart added a comment.


  ok, you can send me a patch with git format-patch, o with git am i can push 
it with you as author.
  for future ones, you gan do:
  https://identity.kde.org/index.php?r=developerApplication

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D1860

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bearsh, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1847: [System Tray AbstractItem] Hide tooltip when clicking item

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEf117addb616a: [System Tray AbstractItem] Hide 
tooltip when clicking item (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1847?vs=4414&id=4450

REVISION DETAIL
  https://phabricator.kde.org/D1847

AFFECTED FILES
  applets/systemtray/package/contents/applet/CompactApplet.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1864: Handle ShellClient::windowShown in Workspace

[bshah (Bhushan Shah)]

bshah accepted this revision.
bshah added a reviewer: bshah.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  handle-window-shown

REVISION DETAIL
  https://phabricator.kde.org/D1864

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin, bshah
Cc: plasma-devel, kwin, hardening, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 15 lines] D1864: Handle ShellClient::windowShown in Workspace

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  When a ShellClient gets unmapped and mapped again the signal windowShown
  gets emitted. We need to handle this in Workspace to ensure the window
  is in the proper layer and gets focus.
  
  This fixes applications like KRunner/Yakuake not having focus on a
  second show. Unfortunately it also brings back the problem that
  notifiations steal focus (this needs to be fixed by passing a proper
  window type to a notification).

REPOSITORY
  rKWIN KWin

BRANCH
  handle-window-shown

REVISION DETAIL
  https://phabricator.kde.org/D1864

AFFECTED FILES
  autotests/wayland/shell_client_test.cpp
  workspace.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, hardening, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1857: Move the loadTexture for X11 pixmap functionality to the EglOnXBackend

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN2b196bfa291a: Move the loadTexture for X11 pixmap 
functionality to the EglOnXBackend (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1857?vs=4435&id=4448

REVISION DETAIL
  https://phabricator.kde.org/D1857

AFFECTED FILES
  abstract_egl_backend.cpp
  abstract_egl_backend.h
  plugins/platforms/x11/common/eglonxbackend.cpp
  plugins/platforms/x11/common/eglonxbackend.h
  plugins/platforms/x11/windowed/egl_x11_backend.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin, bshah
Cc: bshah, plasma-devel, kwin, hardening, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1857: Move the loadTexture for X11 pixmap functionality to the EglOnXBackend

[bshah (Bhushan Shah)]

bshah accepted this revision.
bshah added a reviewer: bshah.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  texture-from-pixmap-x11-only

REVISION DETAIL
  https://phabricator.kde.org/D1857

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin, bshah
Cc: bshah, plasma-devel, kwin, hardening, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1860: make kirigamiplugin also directly linkable

[bearsh (Martin)]

bearsh added a comment.


  In https://phabricator.kde.org/D1860#34489, @mart wrote:
  
  > do you have permissions to push on git?
  
  
  no but I can get send-email it to you...

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D1860

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bearsh, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 108 lines] D1860: make kirigamiplugin also directly linkable

[bearsh (Martin)]

bearsh updated this revision to Diff 4447.
bearsh added a comment.


  rename toFile{Path,Url} to resolveFile{Path,Url} and fixed code style

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1860?vs=4439&id=4447

REVISION DETAIL
  https://phabricator.kde.org/D1860

AFFECTED FILES
  kirigami.pri
  src/kirigamiplugin.cpp
  src/kirigamiplugin.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bearsh, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128181: Remove a lot of duplication between both AppletInterface constructors

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128181/#review96467
---




src/scriptengines/qml/plasmoid/appletinterface.cpp (line 67)


So, this connect and below must be removed? Same connections in newly 
setupConnections


- Anthony Fieroni


On Юни 14, 2016, 12:03 след обяд, David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128181/
> ---
> 
> (Updated Юни 14, 2016, 12:03 след обяд)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Also the two were slightly out of sync leading to some connections not
> being in each constructor.
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 
> 6a64594cd53cecfbc99ad7562706e1a78d60c138 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 
> df2d642445bdcc81d7fed463cb38c337380ea25b 
> 
> Diff: https://git.reviewboard.kde.org/r/128181/diff/
> 
> 
> Testing
> ---
> 
> previous code.
> 
> 
> FIRST CTOR ONLY  (normal mode)
> connect(applet(), &Plasma::Applet::contextualActionsAboutToShow,
> this, &AppletInterface::contextualActionsAboutToShow);
> 
> connect(applet(), &Plasma::Applet::activated,
> this, &AppletInterface::activated);
> 
> 
> connect(this, &AppletInterface::expandedChanged, [=](bool expanded) {
> //if both compactRepresentationItem and fullRepresentationItem exist,
> //the applet is in a popup
> if (expanded) {
> if (compactRepresentationItem() && fullRepresentationItem() &&
> fullRepresentationItem()->window() && 
> compactRepresentationItem()->window() &&
> fullRepresentationItem()->window() != 
> compactRepresentationItem()->window() &&
> fullRepresentationItem()->parentItem()) {
> 
> fullRepresentationItem()->parentItem()->installEventFilter(this);
> } else if (fullRepresentationItem() && 
> fullRepresentationItem()->parentItem()) {
> 
> fullRepresentationItem()->parentItem()->removeEventFilter(this);
> }
> }
> });
> }
> 
> SECOND CTOR ONLY (special comic applet path)
> 
> connect(applet(), &Plasma::Applet::configurationRequiredChanged,
> this, [this](bool needsConfig, const QString &reason) {
> emit configurationRequiredChanged();
> emit configurationRequiredReasonChanged();
> });
> 
> }
> 
> DUPLICATED:
> qmlRegisterType();
> 
> connect(this, &AppletInterface::configNeedsSaving,
> applet(), &Plasma::Applet::configNeedsSaving);
> connect(applet(), &Plasma::Applet::immutabilityChanged,
> this, &AppletInterface::immutabilityChanged);
> 
> connect(applet(), &Plasma::Applet::userConfiguringChanged,
> this, &AppletInterface::userConfiguringChanged);
> 
> connect(applet(), &Plasma::Applet::statusChanged,
> this, &AppletInterface::statusChanged);
> 
> connect(applet(), &Plasma::Applet::destroyedChanged,
> this, &AppletInterface::destroyedChanged);
> 
> 
> connect(applet(), &Plasma::Applet::titleChanged,
> this, &AppletInterface::titleChanged);
> 
> connect(applet(), &Plasma::Applet::iconChanged,
> this, &AppletInterface::iconChanged);
> 
> connect(applet(), &Plasma::Applet::busyChanged,
> this, &AppletInterface::busyChanged);
> 
> connect(appletScript(), &DeclarativeAppletScript::formFactorChanged,
> this, &AppletInterface::formFactorChanged);
> connect(appletScript(), &DeclarativeAppletScript::locationChanged,
> this, &AppletInterface::locationChanged);
> connect(appletScript(), &DeclarativeAppletScript::contextChanged,
> this, &AppletInterface::contextChanged);
> 
> if (applet()->containment()) {
> connect(applet()->containment(), &Plasma::Containment::screenChanged,
> this, &ContainmentInterface::screenChanged);
> }
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 364275] sleep and hibernate gone after update

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364275

--- Comment #7 from d958x7...@mail.com ---
(In reply to Christoph Feck from comment #3)
> What packages did you update? From which version to which version? I
> strongly suggest to report this on the bug tracker of your distribution,
> because these hardware related issues are mostly distribution-related.

I tried to report to Kubuntu; anything KDE-related heads right here to this
site.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 364275] sleep and hibernate gone after update

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364275

--- Comment #6 from d958x7...@mail.com ---
(In reply to Christoph Feck from comment #3)
> What packages did you update? From which version to which version? I
> strongly suggest to report this on the bug tracker of your distribution,
> because these hardware related issues are mostly distribution-related.

I tried to report to Kubuntu; anything KDE-related heads right here to this
site.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 159 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/159/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 10:40:33 +
Build duration: 13 min

CHANGE SET
Revision 17597ee16fe0a48bb9ab4eb686d40678246144bd by kde: ([DrKonqi] Add config 
to directly show backtrace)
  change: edit drkonqi/drkonqidialog.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5037 
(39%)CONDITIONAL 1381/5120 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2763 (5%)CONDITIONAL 
87/2847 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 40 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/40/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 10:39:34 +
Build duration: 2 min 17 sec

CHANGE SET
Revision 9ffcb3178cea8b06fdf964fd05cf28319d1ffc8b by Marco Martin: (force focus 
to the panel on AcceptingInputStatus)
  change: edit shell/panelview.cpp
Revision 26c3fe19e3502d2e2cdd718865fdec996b853a2c by Jonathan Riddell: (Update 
version number for 5.6.5 GIT_SILENT)
  change: edit CMakeLists.txt
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1832: [DrKonqi] Add config to directly show backtrace

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE17597ee16fe0: [DrKonqi] Add config to directly 
show backtrace (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1832?vs=4363&id=4442

REVISION DETAIL
  https://phabricator.kde.org/D1832

AFFECTED FILES
  drkonqi/drkonqidialog.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, brauch
Cc: brauch, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1860: make kirigamiplugin also directly linkable

[mart (Marco Martin)]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  apart minor cosmetic issues is good to go.
  
  do you have permissions to push on git?

INLINE COMMENTS

> kirigamiplugin.h:69
> +QUrl componentPath(const QString &fileName) const;
> +QString toFilePath(const QString &path) const {
> +return QLatin1Char(':') + path;

i would call them resolveFilePath/resolveFileUrl
also, implementation in the cpp with the { in new line

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D1860

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bearsh, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128180: device notifier applet size

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128180/
---

(Updated June 14, 2016, 10:24 a.m.)


Review request for Plasma.


Repository: plasma-workspace


Description
---

fix bug 360886


Diffs (updated)
-

  applets/devicenotifier/package/contents/ui/FullRepresentation.qml df1d95e 
  applets/devicenotifier/package/contents/ui/devicenotifier.qml 657825e 

Diff: https://git.reviewboard.kde.org/r/128180/diff/


Testing
---


Thanks,

Andreas Kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128180: device notifier applet size

[Andreas Kainz]

> On Juni 14, 2016, 10:09 vorm., Anthony Fieroni wrote:
> > applets/devicenotifier/package/contents/ui/FullRepresentation.qml, line 113
> > 
> >
> > This count looks mistaken, what you want to do?

oh that's not good it look like this was changed in the past. one moment will 
update the review. sorry.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128180/#review96463
---


On Juni 14, 2016, 7:35 vorm., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128180/
> ---
> 
> (Updated Juni 14, 2016, 7:35 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> fix bug 360886
> 
> 
> Diffs
> -
> 
>   applets/devicenotifier/package/contents/ui/FullRepresentation.qml df1d95e 
>   applets/devicenotifier/package/contents/ui/devicenotifier.qml 657825e 
> 
> Diff: https://git.reviewboard.kde.org/r/128180/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128180: device notifier applet size

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128180/#review96465
---




applets/devicenotifier/package/contents/ui/devicenotifier.qml (line 74)


When you see hardcoded size, correct it.


- Anthony Fieroni


On Юни 14, 2016, 10:35 преди обяд, Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128180/
> ---
> 
> (Updated Юни 14, 2016, 10:35 преди обяд)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> fix bug 360886
> 
> 
> Diffs
> -
> 
>   applets/devicenotifier/package/contents/ui/FullRepresentation.qml df1d95e 
>   applets/devicenotifier/package/contents/ui/devicenotifier.qml 657825e 
> 
> Diff: https://git.reviewboard.kde.org/r/128180/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128180: device notifier applet size

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128180/#review96463
---




applets/devicenotifier/package/contents/ui/FullRepresentation.qml (line 113)


This count looks mistaken, what you want to do?


- Anthony Fieroni


On Юни 14, 2016, 10:35 преди обяд, Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128180/
> ---
> 
> (Updated Юни 14, 2016, 10:35 преди обяд)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> fix bug 360886
> 
> 
> Diffs
> -
> 
>   applets/devicenotifier/package/contents/ui/FullRepresentation.qml df1d95e 
>   applets/devicenotifier/package/contents/ui/devicenotifier.qml 657825e 
> 
> Diff: https://git.reviewboard.kde.org/r/128180/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 39 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/39/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 09:56:06 +
Build duration: 5 min 59 sec

CHANGE SET
Revision 26c3fe19e3502d2e2cdd718865fdec996b853a2c by Jonathan Riddell: (Update 
version number for 5.6.5 GIT_SILENT)
  change: edit CMakeLists.txt
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 44 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/44/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 09:54:57 +
Build duration: 2 min 48 sec

CHANGE SET
Revision fd43f1f0d272e403d7acdbab1a68b05e3cf39b72 by Jonathan Riddell: (Update 
version number for 5.6.5 GIT_SILENT)
  change: edit CMakeLists.txt
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 158 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/158/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 09:37:17 +
Build duration: 17 min

CHANGE SET
Revision c8cae6bf142f3741819a8bd15100bc912d5997c2 by David Edmundson: (Similar 
ksplash change for wayland)
  change: edit startkde/startplasma.cmake


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5037 
(39%)CONDITIONAL 1381/5120 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2763 (5%)CONDITIONAL 
87/2847 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 157 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/157/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 09:23:06 +
Build duration: 10 min

CHANGE SET
Revision b6058a09aed209f752f96159283da0c8259a971f by David Edmundson: (Prepare 
KSplash for KDED dropping KSplash support)
  change: edit startkde/startkde.cmake
  change: edit ksplash/ksplashqml/splashapp.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5037 
(39%)CONDITIONAL 1381/5120 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2763 (5%)CONDITIONAL 
87/2847 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128179: add switch size for kate applet

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128179/
---

(Updated June 14, 2016, 12:34 p.m.)


Status
--

This change has been marked as submitted.


Review request for Kate and Plasma.


Changes
---

Submitted with commit 29290a0b59845ac0387c846ac803f4adbb03a1a1 by andreas kainz 
to branch master.


Repository: kate


Description
---

useful for large panels (sidebars)

fix bug 360987


Diffs
-

  addons/sessionapplet/applet/contents/ui/katesessions.qml 61e6c49 

Diff: https://git.reviewboard.kde.org/r/128179/diff/


Testing
---


Thanks,

Andreas Kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Reopened] D1859: Prepare KSplash for KDED dropping KSplash support

[Martin Gräßlin]

graesslin reopened this revision.
graesslin added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> startkde.cmake:354
>  LD_BIND_NOW=true @CMAKE_INSTALL_FULL_LIBEXECDIR_KF5@/start_kdeinit_wrapper 
> --kded +kcminit_startup
> +qdbus org.kde.KSplash /KSplash org.kde.KSplash.setStage kinit
>  if test $? -ne 0; then

don't forget to do the same in startplasmacompositor

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1859

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, dfaure
Cc: graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128178: scaling konsole profile

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128178/
---

(Updated June 14, 2016, 9:31 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit f7a3b7b42783ae5b812338f5f0b164689580a4cf by andreas kainz 
to branch master.


Repository: kdeplasma-addons


Description
---

fix bug 360988


Diffs
-

  applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml ce980af 

Diff: https://git.reviewboard.kde.org/r/128178/diff/


Testing
---


File Attachments


konsole profile
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/9fa940e2-a940-4018-8f58-17355a29fad2__Screenshot_20160614_083302.png


Thanks,

Andreas Kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1859: Prepare KSplash for KDED dropping KSplash support

[davidedmundson (David Edmundson)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEb6058a09aed2: Prepare KSplash for KDED 
dropping KSplash support (authored by davidedmundson).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1859?vs=4438&id=4440

REVISION DETAIL
  https://phabricator.kde.org/D1859

AFFECTED FILES
  ksplash/ksplashqml/splashapp.cpp
  startkde/startkde.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, dfaure
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 102 lines] D1860: make kirigamiplugin also directly linkable

[bearsh (Martin)]

bearsh created this revision.
bearsh added a reviewer: mart.
bearsh set the repository for this revision to rKIRIGAMI Kirigami.
bearsh added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  this makes it possible to simply put kirigami in a subfolder and include the 
.pri file in the parent project. everything get linked together.
  this patch applies on mart/runtimeTheme

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D1860

AFFECTED FILES
  kirigami.pri
  src/kirigamiplugin.cpp
  src/kirigamiplugin.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bearsh, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1859: Prepare KSplash for KDED dropping KSplash support

[dfaure (David Faure)]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks!

INLINE COMMENTS

> splashapp.cpp:106
>  {
> +//filter out startup events from KDED as they will be removed in a 
> future release
> +if (stage == QLatin1String("kded") || stage == 
> QLatin1String("confupdate")) {

At some point this comment will be outdated ;-)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1859

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, dfaure
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1859: Prepare KSplash for KDED dropping KSplash support

[davidedmundson (David Edmundson)]

davidedmundson added a reviewer: dfaure.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1859

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, dfaure
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 13 lines] D1859: Prepare KSplash for KDED dropping KSplash support

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We want to drop workspace code from KDED as it doesn't make much sense
  semantically.
  
  This patch ignores the messages from kded, so that they can be dropped
  in a future frameworks release and introduces a new signal sent from
  startkde.
  
  This puts all workspace related code in workspace.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1859

AFFECTED FILES
  ksplash/ksplashqml/splashapp.cpp
  startkde/startkde.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Changed Subscribers] D1856: more creative output type detection in xrandr backend

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> xrandroutput.cpp:258
> +
> +Q_FOREACH(const QString &pre, embedded) {
> +if (name.toUpper().startsWith(pre)) {

range for, embedded is const

REPOSITORY
  rLIBKSCREEN KScreen Library

BRANCH
  sebas/xrandrtype

REVISION DETAIL
  https://phabricator.kde.org/D1856

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, dvratil
Cc: broulik, graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 128181: Remove a lot of duplication between both AppletInterface constructors

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128181/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Also the two were slightly out of sync leading to some connections not
being in each constructor.


Diffs
-

  src/scriptengines/qml/plasmoid/appletinterface.h 
6a64594cd53cecfbc99ad7562706e1a78d60c138 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 
df2d642445bdcc81d7fed463cb38c337380ea25b 

Diff: https://git.reviewboard.kde.org/r/128181/diff/


Testing
---

previous code.


FIRST CTOR ONLY  (normal mode)
connect(applet(), &Plasma::Applet::contextualActionsAboutToShow,
this, &AppletInterface::contextualActionsAboutToShow);

connect(applet(), &Plasma::Applet::activated,
this, &AppletInterface::activated);


connect(this, &AppletInterface::expandedChanged, [=](bool expanded) {
//if both compactRepresentationItem and fullRepresentationItem exist,
//the applet is in a popup
if (expanded) {
if (compactRepresentationItem() && fullRepresentationItem() &&
fullRepresentationItem()->window() && 
compactRepresentationItem()->window() &&
fullRepresentationItem()->window() != 
compactRepresentationItem()->window() &&
fullRepresentationItem()->parentItem()) {

fullRepresentationItem()->parentItem()->installEventFilter(this);
} else if (fullRepresentationItem() && 
fullRepresentationItem()->parentItem()) {
fullRepresentationItem()->parentItem()->removeEventFilter(this);
}
}
});
}

SECOND CTOR ONLY (special comic applet path)

connect(applet(), &Plasma::Applet::configurationRequiredChanged,
this, [this](bool needsConfig, const QString &reason) {
emit configurationRequiredChanged();
emit configurationRequiredReasonChanged();
});

}

DUPLICATED:
qmlRegisterType();

connect(this, &AppletInterface::configNeedsSaving,
applet(), &Plasma::Applet::configNeedsSaving);
connect(applet(), &Plasma::Applet::immutabilityChanged,
this, &AppletInterface::immutabilityChanged);

connect(applet(), &Plasma::Applet::userConfiguringChanged,
this, &AppletInterface::userConfiguringChanged);

connect(applet(), &Plasma::Applet::statusChanged,
this, &AppletInterface::statusChanged);

connect(applet(), &Plasma::Applet::destroyedChanged,
this, &AppletInterface::destroyedChanged);


connect(applet(), &Plasma::Applet::titleChanged,
this, &AppletInterface::titleChanged);

connect(applet(), &Plasma::Applet::iconChanged,
this, &AppletInterface::iconChanged);

connect(applet(), &Plasma::Applet::busyChanged,
this, &AppletInterface::busyChanged);

connect(appletScript(), &DeclarativeAppletScript::formFactorChanged,
this, &AppletInterface::formFactorChanged);
connect(appletScript(), &DeclarativeAppletScript::locationChanged,
this, &AppletInterface::locationChanged);
connect(appletScript(), &DeclarativeAppletScript::contextChanged,
this, &AppletInterface::contextChanged);

if (applet()->containment()) {
connect(applet()->containment(), &Plasma::Containment::screenChanged,
this, &ContainmentInterface::screenChanged);
}


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 2 lines] D1858: [platforms/drm] Apply new global position on DrmOutput for a changeset

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland, sebas.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  When we get a configuration request, we also need to update the global
  position on the DrmOutput, otherwise Wayland will know about the new
  position, but KWin internally does not.
  
  In addition we also need to trigger the changed signal on KWin::Screens,
  so that internally code can react on the change.
  
  With this change configuring layout of connected screens in KScreen
  does work also in KWin.

REPOSITORY
  rKWIN KWin

BRANCH
  drm-apply-output-position-change

REVISION DETAIL
  https://phabricator.kde.org/D1858

AFFECTED FILES
  plugins/platforms/drm/drm_backend.cpp
  plugins/platforms/drm/drm_output.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: plasma-devel, kwin, hardening, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128178: scaling konsole profile

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128178/#review96458
---


Ship it!




Ship It!

- Marco Martin


On June 14, 2016, 7:25 a.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128178/
> ---
> 
> (Updated June 14, 2016, 7:25 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> fix bug 360988
> 
> 
> Diffs
> -
> 
>   applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml ce980af 
> 
> Diff: https://git.reviewboard.kde.org/r/128178/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> konsole profile
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/9fa940e2-a940-4018-8f58-17355a29fad2__Screenshot_20160614_083302.png
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128179: add switch size for kate applet

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128179/#review96457
---


Ship it!




yep, remove the trailing spaces and ship it

- Marco Martin


On June 14, 2016, 7:20 a.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128179/
> ---
> 
> (Updated June 14, 2016, 7:20 a.m.)
> 
> 
> Review request for Kate and Plasma.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> useful for large panels (sidebars)
> 
> fix bug 360987
> 
> 
> Diffs
> -
> 
>   addons/sessionapplet/applet/contents/ui/katesessions.qml 61e6c49 
> 
> Diff: https://git.reviewboard.kde.org/r/128179/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1857: Move the loadTexture for X11 pixmap functionality to the EglOnXBackend

[bshah (Bhushan Shah)]

bshah added a comment.


  +1, This patch definitely improved situation then earlier where kwin_wayland 
used to crash with this backtrace : https://ptpb.pw/Y_W1.txt

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1857

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: bshah, plasma-devel, kwin, hardening, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 128180: device notifier applet size

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128180/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

fix bug 360886


Diffs
-

  applets/devicenotifier/package/contents/ui/FullRepresentation.qml df1d95e 
  applets/devicenotifier/package/contents/ui/devicenotifier.qml 657825e 

Diff: https://git.reviewboard.kde.org/r/128180/diff/


Testing
---


Thanks,

Andreas Kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128178: scaling konsole profile

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128178/
---

(Updated June 14, 2016, 7:25 a.m.)


Review request for Plasma.


Changes
---

removed the hardcoded size


Repository: kdeplasma-addons


Description
---

fix bug 360988


Diffs (updated)
-

  applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml ce980af 

Diff: https://git.reviewboard.kde.org/r/128178/diff/


Testing
---


File Attachments


konsole profile
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/9fa940e2-a940-4018-8f58-17355a29fad2__Screenshot_20160614_083302.png


Thanks,

Andreas Kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128179: add switch size for kate applet

[Andreas Kainz]

> On Juni 14, 2016, 7:17 vorm., Dominik Haumann wrote:
> > addons/sessionapplet/applet/contents/ui/katesessions.qml, line 37
> > 
> >
> > please remove the trailing white spaces

removed.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128179/#review96454
---


On Juni 14, 2016, 7:20 vorm., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128179/
> ---
> 
> (Updated Juni 14, 2016, 7:20 vorm.)
> 
> 
> Review request for Kate and Plasma.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> useful for large panels (sidebars)
> 
> fix bug 360987
> 
> 
> Diffs
> -
> 
>   addons/sessionapplet/applet/contents/ui/katesessions.qml 61e6c49 
> 
> Diff: https://git.reviewboard.kde.org/r/128179/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128179: add switch size for kate applet

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128179/
---

(Updated Juni 14, 2016, 7:20 vorm.)


Review request for Kate and Plasma.


Repository: kate


Description
---

useful for large panels (sidebars)

fix bug 360987


Diffs
-

  addons/sessionapplet/applet/contents/ui/katesessions.qml 61e6c49 

Diff: https://git.reviewboard.kde.org/r/128179/diff/


Testing
---


Thanks,

Andreas Kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 99 lines] D1857: Move the loadTexture for X11 pixmap functionality to the EglOnXBackend

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  To use eglCreateImageKhr for an X11 pixmap we need an EGLDisplay created
  for the same XDisplay as the X11 pixmap. This means if we created an
  EGLDisplay for a GBM device, we are not allowed to load a texture from
  the X11 pixmap and can result in a crash in the driver.
  
  Similar in the nested X11 setup the EGLDisplay is created for the
  rendering window, but the X11 pixmaps are from the Xwayland server KWin
  started. They don't belong to the same windowing system.
  
  This change addresses this problem by moving the loading of X11 pixmaps
  from AbstractEglTexture to EglTexture of the EglOnX11Backend. Thus for
  any usage on a non X11 platform we cannot hit the code path any more.
  In addition the nested X11 platform can indicate that it doesn't support
  it and thus also doesn't go through the code path.

TEST PLAN
  Tested standalone and nested X11 platform

REPOSITORY
  rKWIN KWin

BRANCH
  texture-from-pixmap-x11-only

REVISION DETAIL
  https://phabricator.kde.org/D1857

AFFECTED FILES
  abstract_egl_backend.cpp
  abstract_egl_backend.h
  plugins/platforms/x11/common/eglonxbackend.cpp
  plugins/platforms/x11/common/eglonxbackend.h
  plugins/platforms/x11/windowed/egl_x11_backend.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, hardening, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1856: more creative output type detection in xrandr backend

[Daniel Vrátil]

dvratil accepted this revision.
dvratil added a comment.
This revision is now accepted and ready to land.


  Good idea with the fallback.

REPOSITORY
  rLIBKSCREEN KScreen Library

BRANCH
  sebas/xrandrtype

REVISION DETAIL
  https://phabricator.kde.org/D1856

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, dvratil
Cc: graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel