date:20160615

graesslin added a comment.


  Just as a note: KWin uses a DBusServiceWatcher to monitor the Screenlocker 
interface. See effects.cpp.

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D1901

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: graesslin, colomar, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 116 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/116/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 16 Jun 2016 02:56:58 +
Build duration: 7 min 52 sec

CHANGE SET
Revision 2cde28f09b8eab2c0ba47c69ff62203693f53223 by Bhushan Shah: (Different 
try to fix dependency issue while building in parallel)
  change: edit kcms/lookandfeel/autotests/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2289/3359 
(68%)CONDITIONAL 1556/3766 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 624/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 251/342 (73%)CONDITIONAL 
82/187 (44%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 116 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/116/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 16 Jun 2016 02:56:58 +
Build duration: 7 min 52 sec

CHANGE SET
Revision 2cde28f09b8eab2c0ba47c69ff62203693f53223 by Bhushan Shah: (Different 
try to fix dependency issue while building in parallel)
  change: edit kcms/lookandfeel/autotests/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2289/3359 
(68%)CONDITIONAL 1556/3766 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 624/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 251/342 (73%)CONDITIONAL 
82/187 (44%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 128203: Avoid lots of useless po/*/messages.mo files in released tarballs

2016-06-15 Thread Friedrich W. H. Kossebau


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128203/
---

Review request for Plasma, Albert Astals Cid, Jonathan Riddell, Luigi Toscano, 
and Harald Sitter.


Repository: releaseme


Description
---

Currently all projects which use releaseme for creating the source tarballs 
have in all the po/*/ dirs a file messages.mo. Seems this file is an artifact 
when running `LC_ALL=C LANG=C msgfmt --statistics #{file} > /dev/stdout 2>&1` 
to get statistics about the number of translated strings per language. Only 
problem is that this also results in msgfmt creating the output file named 
`messages.po` per default in the very sources, once per language.

Just piping the output to /dev/null seemed simplest to me, no idea if this 
works on all platforms releaseme targets. Could also be solved by simply 
cleaning up and removing the created file afterwards, if that will work in more 
places.


Diffs
-

  lib/l10nstatistics.rb d76f531 

Diff: https://git.reviewboard.kde.org/r/128203/diff/


Testing
---

Only tested `LC_ALL=C LANG=C msgfmt --statistics somefile.po -o /dev/null> 
2>&1` on the commandline, worked as expected, no file created.


Thanks,

Friedrich W. H. Kossebau

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 182 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/182/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 15 Jun 2016 22:05:29 +
Build duration: 10 min

CHANGE SET
Revision ba601b5d339085b781a5b9710a476e2be0a65bc0 by David Edmundson: (Use 
correct icon for user select)
  change: edit lookandfeel/contents/loginmanager/UserDelegate.qml
  change: add lookandfeel/contents/loginmanager/user-none.svg


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1976/5249 
(38%)CONDITIONAL 1382/5378 (26%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 143/2975 (5%)CONDITIONAL 
88/3105 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 181 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/181/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 15 Jun 2016 21:50:43 +
Build duration: 12 min

CHANGE SET
Revision 5db6949a8146ead43e58874363287c4698cc3ca9 by kde: ([Login Screen] Add 
hint about active caps lock)
  change: edit lookandfeel/contents/loginmanager/Login.qml
  change: edit applets/systemtray/package/contents/ui/main.qml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1976/5249 
(38%)CONDITIONAL 1382/5378 (26%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 143/2975 (5%)CONDITIONAL 
88/3105 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 9 lines] D1907: [System Tray] Hide popup when user configuring

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This matches what the other plasmoids are doing but we didn't get for free as 
we don't use the ordinary applet popup logic in system tray.

TEST PLAN
  Opened popup, right clicked, chose "configure system tray", popup closed

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1907

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128144: Windecoration KCM theme color


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128144/
---

(Updated June 15, 2016, 9:29 p.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: kwin


Description
---

change the button area of the windowdecoration kcm to use the theme colors.


Diffs
-

  kcmkwin/kwindecoration/qml/Buttons.qml 2e64873 

Diff: https://git.reviewboard.kde.org/r/128144/diff/


Testing
---

system settings -> Window Decoration -> Buttons tab used breeze dark color 
scheme.


File Attachments


dark theme bug
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/09/e0dd4fae-2a84-4b1e-a37d-f0ad75899050__bug.png


Thanks,

Andreas Kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128131: biger output field


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128131/
---

(Updated June 15, 2016, 9:26 p.m.)


Review request for Plasma.


Changes
---

done waiting for a ship it.

works propper on desktop, panel and in a sidebar.


Repository: kdeplasma-addons


Description
---

change the output field of the calculator


Diffs (updated)
-

  applets/calculator/package/contents/ui/calculator.qml 2db968a 

Diff: https://git.reviewboard.kde.org/r/128131/diff/


Testing
---

on the desktop and in the panel.

where can I find the Layout.minimumWidth and Layout.minimumHeight? or how can I 
change the size of the applet when it pop-up in the panel (it's to big)


Thanks,

Andreas Kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 180 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/180/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 15 Jun 2016 20:22:43 +
Build duration: 14 min

CHANGE SET
Revision d50f9508b7812a586ce05373763f9b741a160978 by hein: (Finish 
implementation of mode in which launchers are not kept separate.)
  change: edit libtaskmanager/tasksmodel.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1976/5249 
(38%)CONDITIONAL 1382/5378 (26%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 143/2975 (5%)CONDITIONAL 
88/3105 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 115 - Failure!


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/115/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 15 Jun 2016 20:23:27 +
Build duration: 2 min 58 sec

CHANGE SET
Revision 4fe4acfd8c88c2fdabf38d26515821c5ee7aeb8c by hein: (Expose 
separate-launchers toggle in config.)
  change: edit applets/taskmanager/package/contents/ui/MouseHandler.qml
  change: edit applets/taskmanager/package/contents/config/main.xml
  change: edit applets/taskmanager/package/contents/ui/Task.qml
  change: edit applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  change: edit applets/taskmanager/package/contents/code/layout.js
  change: edit applets/taskmanager/package/contents/ui/main.qml
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1896: Expose separate-launchers toggle in config.

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP4fe4acfd8c88: Expose separate-launchers toggle 
in config. (authored by hein).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1896?vs=4527=4532

REVISION DETAIL
  https://phabricator.kde.org/D1896

AFFECTED FILES
  applets/taskmanager/package/contents/code/layout.js
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/MouseHandler.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, mart, davidedmundson
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1895: Finish implementation of mode in which launchers are not kept separate.

This revision was automatically updated to reflect the committed changes.
hein marked an inline comment as done.
Closed by commit rPLASMAWORKSPACEd50f9508b781: Finish implementation of mode in 
which launchers are not kept separate. (authored by hein).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1895?vs=4530=4531

REVISION DETAIL
  https://phabricator.kde.org/D1895

AFFECTED FILES
  libtaskmanager/tasksmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, mart, davidedmundson
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1895: Finish implementation of mode in which launchers are not kept separate.

davidedmundson accepted this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  blblblbl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D1895

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, mart, davidedmundson
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1895: Finish implementation of mode in which launchers are not kept separate.

hein marked an inline comment as done.
hein added inline comments.

INLINE COMMENTS

> davidedmundson wrote in tasksmodel.cpp:544
> Sure this logic is the right way round?
> 
> (I'm not convinced it's wrong either, I'm just confused)
> 
> at the start of the function:
> 
> insertPos is the right most launcher
> we iterate i from 0 to size getting from concatProxy
> if we find a window we move it to be next to the launcher, potentially
> 
> 1. Should that not be  if (i > insertPos) ++insertPos
> 2. we don't want to increment i if we've moved something to be below i, as 
> we'd miss an item.
> 
> Might be better to iterate i backwards like hte other loop.

Was broken, should be good now!

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  blblblbl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D1895

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, mart
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 213 lines] D1895: Finish implementation of mode in which launchers are not kept separate.

hein updated this revision to Diff 4530.
hein added a comment.


  Fix logic bug found by David (mad props).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1895?vs=4518=4530

BRANCH
  blblblbl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D1895

AFFECTED FILES
  libtaskmanager/tasksmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, mart
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 179 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/179/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 15 Jun 2016 19:27:12 +
Build duration: 13 min

CHANGE SET
Revision c58e9e1c4656fe69a66e00e74b52e222ac21ce0d by hein: (Fix transaction 
parameters for moves over flattened-out groups.)
  change: edit libtaskmanager/tasksmodel.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1976/5186 
(38%)CONDITIONAL 1382/5292 (26%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 143/2912 (5%)CONDITIONAL 
88/3019 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1898: [Kicker] Use KRun::runService instead of new KRun

2016-06-15 Thread dfaure (David Faure)

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Yes, but please add a comment about porting to KRun::runApplication once 
https://phabricator.kde.org/D1902 is merged in and you can rely on KF 5.24 :-)

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1898

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein, dfaure
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1895: Finish implementation of mode in which launchers are not kept separate.

davidedmundson added inline comments.

INLINE COMMENTS

> tasksmodel.cpp:544
> +
> + if (i < insertPos) {
> + --insertPos;

Sure this logic is the right way round?

(I'm not convinced it's wrong either, I'm just confused)

at the start of the function:

insertPos is the right most launcher
we iterate i from 0 to size getting from concatProxy
if we find a window we move it to be next to the launcher, potentially

1. Should that not be  if (i > insertPos) ++insertPos
2. we don't want to increment i if we've moved something to be below i, as we'd 
miss an item.

Might be better to iterate i backwards like hte other loop.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1895

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, mart
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 76 lines] D1896: Expose separate-launchers toggle in config.

hein updated this revision to Diff 4527.
hein marked an inline comment as done.
hein added a comment.


  Fix merge conflict with Kai's patch.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1896?vs=4522=4527

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1896

AFFECTED FILES
  applets/taskmanager/package/contents/code/layout.js
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/MouseHandler.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, mart, davidedmundson
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1896: Expose separate-launchers toggle in config.

hein marked an inline comment as done.
hein added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.xml:63
> why?

Merge conflict with Kai's patch, fixing.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1896

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, mart, davidedmundson
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1901: [PolicyAgent] Ignore "Keep screen on" request while screen is locked

2016-06-15 Thread colomar (Thomas Pfeiffer)

colomar added a comment.


  Makes sense!

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D1901

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1850: Write out scaling in QT_SCREEN_SCALE_FACTORS format

davidedmundson closed this revision.
davidedmundson added a comment.


  submitted, just didn't autoclose for some reason.

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D1850

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1859: Prepare KSplash for KDED dropping KSplash support

davidedmundson closed this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1859

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, dfaure
Cc: graesslin, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 84 lines] D1901: [PolicyAgent] Ignore "Keep screen on" request while screen is locked

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to rPOWERDEVIL Powerdevil.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When an application is blocking power management, such as a video player, the 
screen will stay on and will not automatically lock, which is good.
  
  However, if the screen is manually locked it will stay on indefinitely (until 
the inhibition is released) which is pointless as you cannot see the video 
anymore either and you can't do anything with the computer anmyore. When the 
screen is unlocked, the original policy comes into effect again.

TEST PLAN
  I'm listening to music all day here and when I leave my laptop I lock it 
manually but the screen stays on forever because of the music playback.

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D1901

AFFECTED FILES
  daemon/CMakeLists.txt
  daemon/org.freedesktop.ScreenSaver.xml
  daemon/powerdevilpolicyagent.cpp
  daemon/powerdevilpolicyagent.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1896: Expose separate-launchers toggle in config.

davidedmundson accepted this revision.
davidedmundson added inline comments.

INLINE COMMENTS

> main.xml:63
>  
> -
>

why?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1896

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, mart, davidedmundson
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 178 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/178/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 15 Jun 2016 17:50:39 +
Build duration: 24 min

CHANGE SET
Revision 259e67c39baa2bf05cb523c878d75412c2591c7b by kde: ([Service Runner] Use 
KRun::runService with tempFile argument)
  change: edit runners/services/servicerunner.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1976/5182 
(38%)CONDITIONAL 1382/5292 (26%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 143/2908 (5%)CONDITIONAL 
88/3019 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 77 lines] D1896: Expose separate-launchers toggle in config.

hein updated this revision to Diff 4522.
hein added a comment.


  Fix inverted logic.
  
  Argh, after all this I can't get one bool right the first try :-)

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1896?vs=4521=4522

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1896

AFFECTED FILES
  applets/taskmanager/package/contents/code/layout.js
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/MouseHandler.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, mart
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 77 lines] D1896: Expose separate-launchers toggle in config.

hein updated this revision to Diff 4521.
hein added a comment.


  Fix reference error.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1896?vs=4520=4521

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1896

AFFECTED FILES
  applets/taskmanager/package/contents/code/layout.js
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/MouseHandler.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, mart
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 76 lines] D1896: Expose separate-launchers toggle in config.

hein updated this revision to Diff 4520.
hein added a comment.


  Now that the backend no longer enforces is, follow the UI design and
  only turn separate launchers on when the sort mode is manual.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1896?vs=4516=4520

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1896

AFFECTED FILES
  applets/taskmanager/package/contents/code/layout.js
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/MouseHandler.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, mart
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 214 lines] D1895: Finish implementation of mode in which launchers are not kept separate.

hein updated this revision to Diff 4518.
hein added a comment.


  Conceptually allow turning off launcher separation also in non-manual sort 
modes.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1895?vs=4514=4518

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1895

AFFECTED FILES
  libtaskmanager/tasksmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, mart
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 6 lines] D1898: [Kicker] Use KRun::runService instead of new KRun

broulik created this revision.
broulik added reviewers: Plasma, hein, dfaure.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  "new KRun" is only meant to run absolute file paths and so breaks when we get 
a 
  service with relative entryPath() like when finding a KCModule.
  
  The tempFile argument causes this call to be asynchronous as to not block the 
UI

TEST PLAN
  The tempFile hack has David Faure's blessing as new KRun is only meant for 
when opening files and the like. KRun::runService normally blocks but doesn't 
when we do the tempFiles thing. This fixes opening eg KCMs (search for eg 
"Splash" and add it to favorites).
  
  - Opening apps in favorites still works
  - Opening apps in recent docs still works
  - OPening docs in recent docs still works
  - Opening apps in apps still works
  - Opening KCMs in favorites now works
  - Opening KCMs in recent docs now works

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1898

AFFECTED FILES
  applets/kicker/plugin/appentry.cpp
  applets/kicker/plugin/recentusagemodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein, dfaure
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 364275] sleep and hibernate gone after update

2016-06-15 Thread via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=364275

--- Comment #10 from d958x7...@mail.com ---
(In reply to d958x7lku from comment #9)
> Two more things:
> 1. I noticed that I can log out, and there still exists a "suspend"
> button on the bottom right when I click on which it acts as if it were
> suspending, yet, after opening the lid, I got it actually shut down.
> 
>2. I installed a fresh PC-BSD with KDE desktop on my other laptop. It
> has KDE 4 too, and it neither has any sleep or hibernate button, nor is able
> to in any way, though the hardware absolutely supports these options.

Funny that both my laptops are different models of Dell Vostro. Just thought
might help.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 364275] sleep and hibernate gone after update

2016-06-15 Thread via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=364275

--- Comment #9 from d958x7...@mail.com ---
Two more things:
1. I noticed that I can log out, and there still exists a "suspend"
button on the bottom right when I click on which it acts as if it were
suspending, yet, after opening the lid, I got it actually shut down.

   2. I installed a fresh PC-BSD with KDE desktop on my other laptop. It
has KDE 4 too, and it neither has any sleep or hibernate button, nor is able to
in any way, though the hardware absolutely supports these options.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 364275] sleep and hibernate gone after update

2016-06-15 Thread via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=364275

--- Comment #8 from d958x7...@mail.com ---
Two more things:

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 76 lines] D1896: Expose separate-launchers toggle in config.

hein updated this revision to Diff 4516.
hein added a comment.


  In multi-stripe layouts don't get cute with launcher widths when
  separate launchers are off.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1896?vs=4515=4516

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1896

AFFECTED FILES
  applets/taskmanager/package/contents/code/layout.js
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/MouseHandler.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, mart
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1896: Expose separate-launchers toggle in config.

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1896

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, mart
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1895: Finish implementation of mode in which launchers are not kept separate.

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1895

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, mart
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 74 lines] D1896: Expose separate-launchers toggle in config.

hein created this revision.
hein added a reviewer: davidedmundson.
hein added a subscriber: plasma-devel.
hein added a dependency: D1895: Finish implementation of mode in which 
launchers are not kept separate..
Restricted Application added a project: Plasma.

REVISION SUMMARY
  This changes some of the assumptions of when a re-layout is needed.
  
  Depends on https://phabricator.kde.org/D1895.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1896

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/MouseHandler.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1895: Finish implementation of mode in which launchers are not kept separate.

hein added a dependent revision: D1896: Expose separate-launchers toggle in 
config..

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1895

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 161 lines] D1895: Finish implementation of mode in which launchers are not kept separate.

hein created this revision.
hein added a reviewer: davidedmundson.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  Second half of the merge of the functionality found in Netrunner's EITM fork.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1895

AFFECTED FILES
  libtaskmanager/tasksmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 113 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/113/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 15 Jun 2016 15:29:39 +
Build duration: 5 min 32 sec

CHANGE SET
Revision e81c298dc972aad76a0c3b48eb8f8fbab0a02a93 by Jonathan Riddell: (fix 
file to install)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2289/3359 
(68%)CONDITIONAL 1556/3766 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 624/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 251/342 (73%)CONDITIONAL 
82/187 (44%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 113 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/113/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 15 Jun 2016 15:29:39 +
Build duration: 5 min 32 sec

CHANGE SET
Revision e81c298dc972aad76a0c3b48eb8f8fbab0a02a93 by Jonathan Riddell: (fix 
file to install)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2289/3359 
(68%)CONDITIONAL 1556/3766 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 624/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 251/342 (73%)CONDITIONAL 
82/187 (44%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1813: Fix selected name filter with multiple mimetypes

2016-06-15 Thread elvisangelaccio (Elvis Angelaccio)

elvisangelaccio added a comment.


  In https://phabricator.kde.org/D1813#33780, @elvisangelaccio wrote:
  
  > kde2QtFilter() is now more readable and we loop over the filter list only 
once.
  
  
  Ping?

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D1813

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, #plasma
Cc: mart, plasma-devel, #plasma, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 112 - Still Failing!


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/112/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 15 Jun 2016 14:36:36 +
Build duration: 12 min

CHANGE SET
Revision 68348477cb46a9a55071f0f48042df218aa8ef20 by Jonathan Riddell: (fix 
file name)
  change: edit CMakeLists.txt
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1893: [Panel Config Overlay] Make spacer size handles narrower

broulik added a comment.


  F150552: Screenshot_20160615_164042.png 

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1893

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1891: [Holiday Events] Handle holidays spanning multiple days

graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.


  looks good to me, but maybe wait for @mck182 to comment.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1891

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, mck182, graesslin, #plasma
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 111 - Still Failing!


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/111/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 15 Jun 2016 14:13:25 +
Build duration: 4 min 54 sec

CHANGE SET
Revision 081f79df8f12a2ce5fde74ce41ec92d7a83b53b6 by Jonathan Riddell: (fix 
install path)
  change: edit CMakeLists.txt
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1891: [Holiday Events] Handle holidays spanning multiple days

broulik updated the summary for this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1891

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, graesslin, mck182
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1891: [Holiday Events] Handle holidays spanning multiple days

broulik added a comment.


  F150532: Screenshot_20160615_160623.png  
Easter Monday shown

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1891

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, graesslin, mck182
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 5 lines] D1891: [Holiday Events] Handle holidays spanning multiple days

broulik created this revision.
broulik added reviewers: Plasma, graesslin, mck182.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We are told the start and end date but we didn't actually add the event to 
the other days.

TEST PLAN
  Doesn't look too right to me but works :)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1891

AFFECTED FILES
  plasmacalendarintegration/holidaysevents.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, graesslin, mck182
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 177 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/177/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 15 Jun 2016 13:51:30 +
Build duration: 9 min 29 sec

CHANGE SET
Revision 99a7f367fc4f2e5ad50a43068f44db1ee72cbb40 by David Faure: (Fix 
crash/assert due to empty list, this method is only to be called if)
  change: edit libtaskmanager/tasksmodel.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1976/5182 
(38%)CONDITIONAL 1382/5292 (26%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 143/2908 (5%)CONDITIONAL 
88/3019 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running

2016-06-15 Thread Ian Turner via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=358957

--- Comment #9 from Ian Turner  ---
I would vote for adding "both" to the dropdown selections rather than just a
checkbox -- users might want to choose hybrid suspend when suspending on a
critical battery, but just regular suspend when suspending on a lid close, for
example.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 110 - Failure!


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/110/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 15 Jun 2016 13:36:20 +
Build duration: 7 min 4 sec

CHANGE SET
Revision 4c07484a8637856230a84e5c9f6168ee4891c753 by Jonathan Riddell: (Add 
Appinfo metadata file)
  change: add org.kde.plasmashell.metainfo.xml
  change: edit CMakeLists.txt
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1844: Add Appinfo metadata file

2016-06-15 Thread jriddell (Jonathan Riddell)

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP4c07484a8637: Add Appinfo metadata file 
(authored by jriddell).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1844?vs=4397=4507

REVISION DETAIL
  https://phabricator.kde.org/D1844

AFFECTED FILES
  CMakeLists.txt
  org.kde.plasmashell.metainfo.xml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jriddell, #wikitolearn_visual_design_and_promo, mak, #plasma, sebas
Cc: bshah, sebas, plasma-devel, jensreuterberg
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 176 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/176/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 15 Jun 2016 13:16:19 +
Build duration: 15 min

CHANGE SET
Revision bf85b2fe7f44f9f4b5727e37d31a09ab132a6c54 by David Edmundson: (Fix 
crash on kquitapp/logout)
  change: edit shell/shellcorona.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1976/5181 
(38%)CONDITIONAL 1382/5290 (26%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 143/2907 (5%)CONDITIONAL 
88/3017 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 175 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/175/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 15 Jun 2016 12:59:08 +
Build duration: 17 min

CHANGE SET
Revision 857c0680f5c801f98f182a209f3aef02255dda83 by kde: ([Calendar Applet] 
Show day or week number in icon)
  change: add applets/calendar/package/contents/ui/configGeneral.qml
  change: add applets/calendar/calendarapplet.cpp
  change: delete applets/calendar/contents/config/config.qml
  change: delete applets/calendar/contents/ui/main.qml
  change: add applets/calendar/package/contents/ui/main.qml
  change: delete applets/calendar/contents/ui/configAgenda.qml
  change: delete applets/calendar/contents/images/mini-calendar.svgz
  change: add applets/calendar/package/contents/images/mini-calendar.svgz
  change: add applets/calendar/CMakeLists.txt
  change: add applets/calendar/package/metadata.desktop
  change: delete applets/calendar/contents/config/main.xml
  change: add applets/calendar/calendarapplet.h
  change: edit applets/CMakeLists.txt
  change: add applets/calendar/package/contents/ui/configAgenda.qml
  change: delete applets/calendar/contents/ui/configGeneral.qml
  change: add applets/calendar/package/contents/config/main.xml
  change: delete applets/calendar/metadata.desktop
  change: add applets/calendar/package/contents/config/config.qml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1976/5181 
(38%)CONDITIONAL 1382/5290 (26%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 143/2907 (5%)CONDITIONAL 
88/3017 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1890: Fix crash on kquitapp/logout

broulik accepted this revision.
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D1890

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1890: Fix crash on kquitapp/logout

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEbf85b2fe7f44: Fix crash on kquitapp/logout 
(authored by davidedmundson).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1890?vs=4505=4506

REVISION DETAIL
  https://phabricator.kde.org/D1890

AFFECTED FILES
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1890: Fix crash on kquitapp/logout

davidedmundson added a comment.


  FWIW, longer term I believe the correct fix is to remove all of this.
  
  Corona::~Corona will delete containments anyway (as the parent) and we 
already delete a view if a containment gets deleted. (or at least should) but 
I'm not going to make a change that big this close to release.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1890

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 5 lines] D1890: Fix crash on kquitapp/logout

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  qDeleteAll will iterate through containments() however this is
  dynamically changing the list we're iterating through.
  
  Particularly bad is deleting the panel might delete the system tray
  containment, leading to a double delete on a now dangly pointer.

TEST PLAN
  kquitapp5 plasmashell. No crash

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D1890

AFFECTED FILES
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1867: [Calendar Applet] Show day or week number in icon

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE857c0680f5c8: [Calendar Applet] Show day or 
week number in icon (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D1867?vs=4503=4504#toc

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1867?vs=4503=4504

REVISION DETAIL
  https://phabricator.kde.org/D1867

AFFECTED FILES
  applets/CMakeLists.txt
  applets/calendar/CMakeLists.txt
  applets/calendar/calendarapplet.cpp
  applets/calendar/calendarapplet.h
  applets/calendar/contents/config/config.qml
  applets/calendar/contents/config/main.xml
  applets/calendar/contents/images/mini-calendar.svgz
  applets/calendar/contents/ui/configAgenda.qml
  applets/calendar/contents/ui/configGeneral.qml
  applets/calendar/contents/ui/main.qml
  applets/calendar/metadata.desktop
  applets/calendar/package/contents/config/config.qml
  applets/calendar/package/contents/config/main.xml
  applets/calendar/package/contents/images/mini-calendar.svgz
  applets/calendar/package/contents/ui/configAgenda.qml
  applets/calendar/package/contents/ui/configGeneral.qml
  applets/calendar/package/contents/ui/main.qml
  applets/calendar/package/metadata.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mart
Cc: mart, colomar, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 795 lines] D1867: [Calendar Applet] Show day or week number in icon

broulik updated this revision to Diff 4503.
broulik added a comment.


  Fix cmake to include calendar subdir instead of installing

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1867?vs=4501=4503

REVISION DETAIL
  https://phabricator.kde.org/D1867

AFFECTED FILES
  applets/CMakeLists.txt
  applets/calendar/CMakeLists.txt
  applets/calendar/calendarapplet.cpp
  applets/calendar/calendarapplet.h
  applets/calendar/contents/config/config.qml
  applets/calendar/contents/config/main.xml
  applets/calendar/contents/images/mini-calendar.svgz
  applets/calendar/contents/ui/configAgenda.qml
  applets/calendar/contents/ui/configGeneral.qml
  applets/calendar/contents/ui/main.qml
  applets/calendar/metadata.desktop
  applets/calendar/package/contents/config/config.qml
  applets/calendar/package/contents/config/main.xml
  applets/calendar/package/contents/images/mini-calendar.svgz
  applets/calendar/package/contents/ui/configAgenda.qml
  applets/calendar/package/contents/ui/configGeneral.qml
  applets/calendar/package/contents/ui/main.qml
  applets/calendar/package/metadata.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mart
Cc: mart, colomar, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1744: Fix the ignore struts multi-screen handling

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINe5fe3137b8a1: Fix the ignore struts multi-screen handling 
(authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1744?vs=4165=4502

REVISION DETAIL
  https://phabricator.kde.org/D1744

AFFECTED FILES
  autotests/wayland/struts_test.cpp
  geometry.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, lbeltrame, apol
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 793 lines] D1867: [Calendar Applet] Show day or week number in icon

broulik updated this revision to Diff 4501.
broulik added a comment.


  Use a C++ applet instead of a private import

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1867?vs=4454=4501

REVISION DETAIL
  https://phabricator.kde.org/D1867

AFFECTED FILES
  applets/calendar/CMakeLists.txt
  applets/calendar/calendarapplet.cpp
  applets/calendar/calendarapplet.h
  applets/calendar/contents/config/config.qml
  applets/calendar/contents/config/main.xml
  applets/calendar/contents/images/mini-calendar.svgz
  applets/calendar/contents/ui/configAgenda.qml
  applets/calendar/contents/ui/configGeneral.qml
  applets/calendar/contents/ui/main.qml
  applets/calendar/metadata.desktop
  applets/calendar/package/contents/config/config.qml
  applets/calendar/package/contents/config/main.xml
  applets/calendar/package/contents/images/mini-calendar.svgz
  applets/calendar/package/contents/ui/configAgenda.qml
  applets/calendar/package/contents/ui/configGeneral.qml
  applets/calendar/package/contents/ui/main.qml
  applets/calendar/package/metadata.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mart
Cc: mart, colomar, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 174 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/174/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 15 Jun 2016 12:21:30 +
Build duration: 11 min

CHANGE SET
Revision cec700fba9bb18ed5ac491fb82f002e10a28e72a by kde: ([Media Controller] 
Set sourceSize)
  change: edit applets/mediacontroller/contents/ui/ExpandedRepresentation.qml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1976/5181 
(38%)CONDITIONAL 1382/5290 (26%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 143/2907 (5%)CONDITIONAL 
88/3017 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 173 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/173/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 15 Jun 2016 11:39:24 +
Build duration: 11 min

CHANGE SET
Revision ae383e465020cb4ba5fbf223d8e5662d5c2b7e8f by kainz.a: (device notifier 
applet size BUG: 360886 REVIEW: 128180)
  change: edit applets/devicenotifier/package/contents/ui/devicenotifier.qml
  change: edit applets/devicenotifier/package/contents/ui/FullRepresentation.qml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1976/5181 
(38%)CONDITIONAL 1382/5290 (26%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 143/2907 (5%)CONDITIONAL 
88/3017 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128180: device notifier applet size


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128180/
---

(Updated June 15, 2016, 11:39 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit ae383e465020cb4ba5fbf223d8e5662d5c2b7e8f by andreas kainz 
to branch master.


Repository: plasma-workspace


Description
---

fix bug 360886


Diffs
-

  applets/devicenotifier/package/contents/ui/FullRepresentation.qml df1d95e 
  applets/devicenotifier/package/contents/ui/devicenotifier.qml 657825e 

Diff: https://git.reviewboard.kde.org/r/128180/diff/


Testing
---


Thanks,

Andreas Kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 172 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/172/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 15 Jun 2016 11:16:14 +
Build duration: 15 min

CHANGE SET
Revision da93453e88f5014e48102d9906818ee29200f867 by Martin Gräßlin: ([shell] 
Properly position DesktopView on Wayland)
  change: edit shell/desktopview.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1976/5181 
(38%)CONDITIONAL 1382/5290 (26%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 143/2907 (5%)CONDITIONAL 
88/3017 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1889: [shell] Properly position DesktopView on Wayland

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEda93453e88f5: [shell] Properly position 
DesktopView on Wayland (authored by graesslin).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1889?vs=4499=4500

REVISION DETAIL
  https://phabricator.kde.org/D1889

AFFECTED FILES
  shell/desktopview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, mart
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 171 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/171/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 15 Jun 2016 11:01:51 +
Build duration: 11 min

CHANGE SET
Revision 1f0ca818a8fc29423b35ced6be7fa53ca10242d1 by hein: (Add an inline 
grouping mode.)
  change: edit libtaskmanager/tasksmodel.cpp
  change: edit libtaskmanager/tasksmodel.h
  change: add libtaskmanager/flattentaskgroupsproxymodel.h
  change: add libtaskmanager/flattentaskgroupsproxymodel.cpp
  change: edit libtaskmanager/launchertasksmodel.cpp
  change: edit libtaskmanager/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1976/5181 
(38%)CONDITIONAL 1382/5290 (26%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 143/2907 (5%)CONDITIONAL 
88/3017 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1889: [shell] Properly position DesktopView on Wayland

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  desktopview-set-position

REVISION DETAIL
  https://phabricator.kde.org/D1889

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, mart
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 4 lines] D1889: [shell] Properly position DesktopView on Wayland

graesslin created this revision.
graesslin added a reviewer: Plasma on Wayland.
Restricted Application added a project: Plasma on Wayland.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  On Wayland we need special glue code to make KWin aware of the position
  the DesktopView wants to be. This change ensures that DesktopView calls
  setPosition on the PlasmaShellSurface on creation and whenever the screen
  geometry changes.
  
  With this change DesktopViews are properly positioned in a multi-screen
  setup on Wayland.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  desktopview-set-position

REVISION DETAIL
  https://phabricator.kde.org/D1889

AFFECTED FILES
  shell/desktopview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1882: Expose inline grouping mode.

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPb2f53dc81e51: Expose inline grouping mode. 
(authored by hein).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1882?vs=4482=4497

REVISION DETAIL
  https://phabricator.kde.org/D1882

AFFECTED FILES
  applets/taskmanager/package/contents/code/layout.js
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, mart
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128136: alignement for systemmonitoring applets



> On Juni 15, 2016, 9:16 vorm., Burkhard Lück wrote:
> > applets/systemmonitor/cpu/contents/ui/cpu.qml, line 43
> > 
> >
> > please add context and explain what %1 and %2 are

I really don't know.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128136/#review96515
---


On Juni 9, 2016, 11:58 vorm., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128136/
> ---
> 
> (Updated Juni 9, 2016, 11:58 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> 1. change the minimum size and the min width in the panel
> 2. speedLabels are now right align to the label cause you show the number 
> which is drown on the right part of the diagramm 
> 3. round to 14 % instead of 14,14 % for cpu load
> 
> still missing:
> a. hide the heading if the desktop widget has to less space for the rows
> b. better friendlyName for ram, network
> c. remove the gray line from the chart (0-line) at least when the applet was 
> shown on the panel
> d. don't show 0 KB/s or 0 B, ...
> 
> shedule
> thanks for your review
> if you know how I can fix one of the missing things, let me know
> tiny improvements when missing stuff is finished.
> 
> 
> Diffs
> -
> 
>   applets/systemmonitor/common/contents/ui/Applet.qml fffd8e0 
>   applets/systemmonitor/common/contents/ui/DoublePlotter.qml 738ffbc 
>   applets/systemmonitor/common/contents/ui/SinglePlotter.qml 987fd2c 
>   applets/systemmonitor/cpu/contents/ui/cpu.qml 4ebbf92 
> 
> Diff: https://git.reviewboard.kde.org/r/128136/diff/
> 
> 
> Testing
> ---
> 
> on the desktop and the panel
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 170 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/170/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 15 Jun 2016 10:47:46 +
Build duration: 13 min

CHANGE SET
Revision a5b728b27fdd364ada6c55fdebcc2c28d964fabd by kde: ([Containment 
Actions] Offer quot;Remove this panelquot; option only when panel)
  change: edit containmentactions/contextmenu/menu.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5042 
(39%)CONDITIONAL 1381/5124 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2768 (5%)CONDITIONAL 
87/2851 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1881: Add an inline grouping mode.

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE1f0ca818a8fc: Add an inline grouping mode. 
(authored by hein).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1881?vs=4481=4496

REVISION DETAIL
  https://phabricator.kde.org/D1881

AFFECTED FILES
  libtaskmanager/CMakeLists.txt
  libtaskmanager/flattentaskgroupsproxymodel.cpp
  libtaskmanager/flattentaskgroupsproxymodel.h
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, mart
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128108: update weather applet ui

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128108/
---

(Updated June 15, 2016, 10:47 a.m.)

Status
--

This change has been marked as submitted.

Review request for Plasma and Friedrich W. H. Kossebau.

Changes
---

Submitted with commit 73eed8423f4f05d275fcb75e15015036e785e5b6 by andreas kainz
to branch master.

Repository: kdeplasma-addons

Description
---

the scaling work now better and the pading between the single lines can be
smaler (If you make the applet higher you can also have the old line spacing)

it's my first qml change, so ...

on my todo, I'd like to change the powerd by weather.com text color so a
secondary gray (bring it a bit more to the background), but I don't know how.

Diffs
-

applets/weather/package/contents/ui/TopPanel.qml 1821f16
applets/weather/package/contents/ui/WeatherListView.qml c7b331e
applets/weather/package/contents/ui/main.qml d490728

Diff: https://git.reviewboard.kde.org/r/128108/diff/

Testing
---

with breeze and breeze dark color scheme on two different pc's. the icons are
breeze weather icons (master)

File Attachments

screenshot

https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/350136df-37c8-4fef-bddb-d4b609df2fb1__weather.png
I hope I had fixed all open issues. I now have only one open issue I could
change the linkColor but I can't change the color when there is no link like in
noaa

https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/3ef83b18-d8e3-4a73-a8da-a069c56a560a__weather.png

Thanks,

Andreas Kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1869: [Containment Actions] Offer "Remove this panel" option only when panel is being edited

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEa5b728b27fdd: [Containment Actions] Offer 
"Remove this panel" option only when panel is… (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1869?vs=4457=4495

REVISION DETAIL
  https://phabricator.kde.org/D1869

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mart
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128108: update weather applet ui



> On Juni 8, 2016, 12:11 vorm., Friedrich W. H. Kossebau wrote:
> > applets/weather/package/contents/ui/WeatherListView.qml, line 39
> > 
> >
> > Instead of making the rectangle transparent, turn it into a normal 
> > undrawn Item, by removing the properties "radius" and "color" and changing 
> > the type to "Item" instead of "Rectangle", like:
> > ```
> > Item {
> > id: rect
> > height: root.rowHeight
> > width: root.width
> > Loader {
> > [...]
> > ```

work like a charm


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128108/#review96287
---


On Juni 10, 2016, 10:37 nachm., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128108/
> ---
> 
> (Updated Juni 10, 2016, 10:37 nachm.)
> 
> 
> Review request for Plasma and Friedrich W. H. Kossebau.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> the scaling work now better and the pading between the single lines can be 
> smaler (If you make the applet higher you can also have the old line spacing)
> 
> it's my first qml change, so ...
> 
> on my todo, I'd like to change the powerd by weather.com text color so a 
> secondary gray (bring it a bit more to the background), but I don't know how.
> 
> 
> Diffs
> -
> 
>   applets/weather/package/contents/ui/TopPanel.qml 1821f16 
>   applets/weather/package/contents/ui/WeatherListView.qml c7b331e 
>   applets/weather/package/contents/ui/main.qml d490728 
> 
> Diff: https://git.reviewboard.kde.org/r/128108/diff/
> 
> 
> Testing
> ---
> 
> with breeze and breeze dark color scheme on two different pc's. the icons are 
> breeze weather icons (master)
> 
> 
> File Attachments
> 
> 
> screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/350136df-37c8-4fef-bddb-d4b609df2fb1__weather.png
> I hope I had fixed all open issues. I now have only one open issue I could 
> change the linkColor but I can't change the color when there is no link like 
> in noaa
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/3ef83b18-d8e3-4a73-a8da-a069c56a560a__weather.png
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1867: [Calendar Applet] Show day or week number in icon

mart accepted this revision.
mart added a reviewer: mart.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> calendarplugin.h:37
> +
> +class CalendarPlugin : public QQmlExtensionPlugin
> +{

i would prefer to have a c++ calendar applet instead of having more private qml 
imports, that i would like to completely get rid of eventually.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1867

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mart
Cc: mart, colomar, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1869: [Containment Actions] Offer "Remove this panel" option only when panel is being edited

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1869

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mart
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 169 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/169/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 15 Jun 2016 09:34:47 +
Build duration: 16 min

CHANGE SET
Revision 3955e784f179aa8be8be1530c72024edc214699d by kde: ([startkde] Call 
KSplash dbus after checking for kinit)
  change: edit startkde/startplasma.cmake
  change: edit startkde/startkde.cmake


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5042 
(39%)CONDITIONAL 1381/5124 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2768 (5%)CONDITIONAL 
87/2851 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-06-15 Thread Anthony Fieroni


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/
---

(Updated Юни 15, 2016, 12:49 след обяд)


Status
--

This change has been discarded.


Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.


Bugs: 361548
https://bugs.kde.org/show_bug.cgi?id=361548


Repository: plasma-workspace


Description
---

I can't reproduce this tons of bug reports and i event can't undertaind how 
containment can be nullptr, when i see corona.cpp 
http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447


Diffs
-

  shell/shellcorona.cpp 2a78ca9 

Diff: https://git.reviewboard.kde.org/r/128040/diff/


Testing
---

To stop crash ?!


Thanks,

Anthony Fieroni

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

5.7 Errata

2016-06-15 Thread Jonathan Riddell

Are there important bugs or missing issues in Plasma 5.7?

Please add them to the 5.7 errata page
https://community.kde.org/Plasma/5.7_Errata

And while you're there review what's already on that page and make
sure it's well written and still relevant.

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 363866] No Hibernate option avaiable

2016-06-15 Thread Jonathan Riddell via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=363866

Jonathan Riddell  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 CC||j...@jriddell.org
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Jonathan Riddell  ---
deliberate decision of Ubuntu, just suspend

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1888: [startkde] Call KSplash dbus after checking for kinit

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE3955e784f179: [startkde] Call KSplash dbus 
after checking for kinit (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1888?vs=4491=4492

REVISION DETAIL
  https://phabricator.kde.org/D1888

AFFECTED FILES
  startkde/startkde.cmake
  startkde/startplasma.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1881: Add an inline grouping mode.

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1881

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, mart
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1882: Expose inline grouping mode.

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  blblblbl

REVISION DETAIL
  https://phabricator.kde.org/D1882

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, mart
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1888: [startkde] Call KSplash dbus after checking for kinit

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  +

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1888

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 6 lines] D1888: [startkde] Call KSplash dbus after checking for kinit

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The check was supposed to check whether kinit would start and exit otherwise.
  By badding the qdbus call inbetween, it would check for that one and if no 
ksplash was running the exit code would be non zero aborting startup.

TEST PLAN
  Literally none.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1888

AFFECTED FILES
  startkde/startkde.cmake
  startkde/startplasma.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128136: alignement for systemmonitoring applets

2016-06-15 Thread Burkhard Lück


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128136/#review96515
---




applets/systemmonitor/cpu/contents/ui/cpu.qml (line 43)


please add context and explain what %1 and %2 are


- Burkhard Lück


On Juni 9, 2016, 11:58 vorm., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128136/
> ---
> 
> (Updated Juni 9, 2016, 11:58 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> 1. change the minimum size and the min width in the panel
> 2. speedLabels are now right align to the label cause you show the number 
> which is drown on the right part of the diagramm 
> 3. round to 14 % instead of 14,14 % for cpu load
> 
> still missing:
> a. hide the heading if the desktop widget has to less space for the rows
> b. better friendlyName for ram, network
> c. remove the gray line from the chart (0-line) at least when the applet was 
> shown on the panel
> d. don't show 0 KB/s or 0 B, ...
> 
> shedule
> thanks for your review
> if you know how I can fix one of the missing things, let me know
> tiny improvements when missing stuff is finished.
> 
> 
> Diffs
> -
> 
>   applets/systemmonitor/common/contents/ui/Applet.qml fffd8e0 
>   applets/systemmonitor/common/contents/ui/DoublePlotter.qml 738ffbc 
>   applets/systemmonitor/common/contents/ui/SinglePlotter.qml 987fd2c 
>   applets/systemmonitor/cpu/contents/ui/cpu.qml 4ebbf92 
> 
> Diff: https://git.reviewboard.kde.org/r/128136/diff/
> 
> 
> Testing
> ---
> 
> on the desktop and the panel
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128040: [shellcorona] Containment can be nullptr



> On May 30, 2016, 11:32 a.m., Aleix Pol Gonzalez wrote:
> > Could you look a bit into why is the containment null?
> 
> Anthony Fieroni wrote:
> So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i 
> can't reproduce crash, KScreen is not finish recognazing, which i write 
> above, corona.cpp:211 if (screen >= 0 && screen < numScreens()) is not 
> satisfied for some reason and returning containment is nullptr. I can't 
> figure out any other possible way.
> 
> Aleix Pol Gonzalez wrote:
> But `createContainmentForActivity` should return a containment 
> nevertheless, it's not related to KScreen after all.
> 
> Marco Martin wrote:
> so may the issue go away with the port to qscreen?
> 
> Anthony Fieroni wrote:
> createContainmentForActivity calls containmentForScreen() from corona 
> which use numScreen() overridden in shellCorona and depend on KScreen 
> configuration. So for me is KScreen related.
> 
> David Edmundson wrote:
> >so may the issue go away with the port to qscreen?
> 
> It should do.
> 
> It's a continuation of https://bugs.kde.org/show_bug.cgi?id=351777 
> 
> there I list the events which cause the crash:
> 
> >Corona.cpp checks we are requesting a containment for a valid screen if 
> (screen >= 0 && screen < numScreens()) {
> 
> >This fails as numScreens() is Qt API based, whereas the signal we're 
> adding the output for is ShellCorona::addOutput
> 
> If Qt proceses the DBus event before we get the X event. You're out of 
> sync.
> (note they weren't in Plasma 5.0,it changed in ~5.2 when the XCB backend 
> for kscreen was split into a separate process)
> 
> I fixed the case of them being out of sync at startup which was the main 
> time we got the crash, but it still apparently happens on unplugging/plugging 
> in a monitor.
> 
> As for this patch; sure you'll stop a crash, but you'll leave those 
> setups that would have crashed with a blank screen on the monitor they've 
> just plugged in.
> 
> Anthony Fieroni wrote:
> *but you'll leave those setups that would have crashed with a blank 
> screen*
> 
> Are you sure about that? So i'm not, still think KScreen has a false 
> positive signals, i.e. he will be done with screen recognazing
> 
> David Edmundson wrote:
> doesn't really matter: https://git.reviewboard.kde.org/r/125451/ is 
> submitted and fixes the root cause.

this should be discarded then


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/#review96027
---


On May 30, 2016, 4:33 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128040/
> ---
> 
> (Updated May 30, 2016, 4:33 a.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Bugs: 361548
> https://bugs.kde.org/show_bug.cgi?id=361548
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I can't reproduce this tons of bug reports and i event can't undertaind how 
> containment can be nullptr, when i see corona.cpp 
> http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447
> 
> 
> Diffs
> -
> 
>   shell/shellcorona.cpp 2a78ca9 
> 
> Diff: https://git.reviewboard.kde.org/r/128040/diff/
> 
> 
> Testing
> ---
> 
> To stop crash ?!
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128131: biger output field



> On June 9, 2016, 8:34 a.m., Marco Martin wrote:
> > to change the size of the popup you change 
> > Layout.minimumWidth/Layout.minimumHeight of the root element of the popup, 
> > inthis case applet root element
> 
> Andreas Kainz wrote:
> I play with 
> 
> id: main;
> 
> Plasmoid.switchWidth: Layout.minimumWidth
> Plasmoid.switchHeight: Layout.minimumHeight
> Layout.minimumWidth: mainLayout.Layout.minimumWidth + 8
> Layout.minimumHeight: mainLayout.Layout.minimumHeight + 8
> 
> but I can't change anything. sorry.

maybe mainLayout.Layout.minimumWidth is not an useful size.
try mainLayout.implicitWidth and implicitHeight


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128131/#review96306
---


On June 9, 2016, 12:14 a.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128131/
> ---
> 
> (Updated June 9, 2016, 12:14 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> change the output field of the calculator
> 
> 
> Diffs
> -
> 
>   applets/calculator/package/contents/ui/calculator.qml 2db968a 
> 
> Diff: https://git.reviewboard.kde.org/r/128131/diff/
> 
> 
> Testing
> ---
> 
> on the desktop and in the panel.
> 
> where can I find the Layout.minimumWidth and Layout.minimumHeight? or how can 
> I change the size of the applet when it pop-up in the panel (it's to big)
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128136: alignement for systemmonitoring applets


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128136/#review96512
---


Fix it, then Ship it!




nice, but still a problem in a label


applets/systemmonitor/common/contents/ui/DoublePlotter.qml (line 83)


this way if the text is too long, it will not wrap.

if you want it right aligned, you should still have anchors.fill:parent and 
have
horizontalAlignment: Text.AlignRight


- Marco Martin


On June 9, 2016, 11:58 a.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128136/
> ---
> 
> (Updated June 9, 2016, 11:58 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> 1. change the minimum size and the min width in the panel
> 2. speedLabels are now right align to the label cause you show the number 
> which is drown on the right part of the diagramm 
> 3. round to 14 % instead of 14,14 % for cpu load
> 
> still missing:
> a. hide the heading if the desktop widget has to less space for the rows
> b. better friendlyName for ram, network
> c. remove the gray line from the chart (0-line) at least when the applet was 
> shown on the panel
> d. don't show 0 KB/s or 0 B, ...
> 
> shedule
> thanks for your review
> if you know how I can fix one of the missing things, let me know
> tiny improvements when missing stuff is finished.
> 
> 
> Diffs
> -
> 
>   applets/systemmonitor/common/contents/ui/Applet.qml fffd8e0 
>   applets/systemmonitor/common/contents/ui/DoublePlotter.qml 738ffbc 
>   applets/systemmonitor/common/contents/ui/SinglePlotter.qml 987fd2c 
>   applets/systemmonitor/cpu/contents/ui/cpu.qml 4ebbf92 
> 
> Diff: https://git.reviewboard.kde.org/r/128136/diff/
> 
> 
> Testing
> ---
> 
> on the desktop and the panel
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 168 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/168/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 15 Jun 2016 08:50:34 +
Build duration: 9 min 26 sec

CHANGE SET
Revision af3927ae2a61a4eef9c2332cabcf0544190c1a6c by kde: ([Splash Screen] Take 
into account device pixel ratio)
  change: edit lookandfeel/contents/splash/Splash.qml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/66 (76%)CLASSES 50/66 (76%)LINE 1975/5042 
(39%)CONDITIONAL 1381/5124 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/15 (33%)CLASSES 5/15 (33%)LINE 142/2768 (5%)CONDITIONAL 
87/2851 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128180: device notifier applet size


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128180/#review96511
---


Ship it!




Ship It!

- Marco Martin


On June 14, 2016, 10:24 a.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128180/
> ---
> 
> (Updated June 14, 2016, 10:24 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> fix bug 360886
> 
> 
> Diffs
> -
> 
>   applets/devicenotifier/package/contents/ui/FullRepresentation.qml df1d95e 
>   applets/devicenotifier/package/contents/ui/devicenotifier.qml 657825e 
> 
> Diff: https://git.reviewboard.kde.org/r/128180/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Abandoned] D1884: Set differential sticky-accept to false

2016-06-15 Thread bshah (Bhushan Shah)

bshah abandoned this revision.

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1884

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, graesslin
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 3 lines] D1884: Set differential sticky-accept to false

2016-06-15 Thread bshah (Bhushan Shah)

bshah updated this revision to Diff 4487.
bshah added a comment.


  set it to actually false

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1884?vs=4486=4487

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1884

AFFECTED FILES
  .arcconfig

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, graesslin
Cc: plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1884: Set differential sticky-accept to false