[Differential] [Request, 277 lines] D2052: [autotests/integration] Simplify the cmake for creating a test
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY A dedicated cmake function is added to create a test case. It takes a NAME, the SRCS and additional LIBS. Thus it's integrationTest(NAME myTestCase SRCS test.cpp) to create a standard integration test. In addition kwin_wayland_test.cpp is compiled into a static library to decrease the compile time a little bit. REPOSITORY rKWIN KWin BRANCH autotests-cmake REVISION DETAIL https://phabricator.kde.org/D2052 AFFECTED FILES autotests/integration/CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: plasma-devel, kwin, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D2051: [Panel Containment] Fix containment size for right-to-left-layout
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2051 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Abandoned] D2047: [KDE Platform Theme] Set application layoutDirection based on locale
broulik abandoned this revision. broulik added a comment. User also reported that installing this package fixed the issue. It's Arch so probably expected that you need to install everything manually :P but on my Neon setup it should also work out of the box. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D2047 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, #plasma, davidedmundson Cc: sitter, davidedmundson, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 2 lines] D2051: [Panel Containment] Fix containment size for right-to-left-layout
broulik updated the summary for this revision. broulik updated the test plan for this revision. broulik updated this revision to Diff 4864. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2051?vs=4863&id=4864 REVISION DETAIL https://phabricator.kde.org/D2051 AFFECTED FILES containments/panel/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 4 lines] D2051: [Panel Containment] Fix containment size for right-to-left-layout
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The X offset was already adjusted when in right-to-left mode, the width wasn't decreased by the same amound, however, pushing applets out the right side of the screen when widgets are locked. TEST PLAN left-to-right, unlocked: works left-to-right, locked: works right-to-left, unlocked: works right-to-left, locked: works now, did not work before Also subtracting the Y value from the height to make the code look consistent REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2051 AFFECTED FILES containments/panel/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 128327: [Calendar] Flip arrow buttons on right-to-left languages
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128327/#review96967 --- Ship it! Ship It! - Marco Martin On June 29, 2016, 8:34 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128327/ > --- > > (Updated June 29, 2016, 8:34 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > This ensures the arrows always point outward, away from the centre button. > > > Diffs > - > > src/declarativeimports/calendar/qml/DaysCalendar.qml 0e119d9 > > Diff: https://git.reviewboard.kde.org/r/128327/diff/ > > > Testing > --- > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D2048: [System Tray] Adjust layout for right-to-left languages
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2048 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Changed Subscribers] D2047: [KDE Platform Theme] Set application layoutDirection based on locale
broulik added a subscriber: sitter. broulik added a comment. @sitter I have installed qttranslations5-l10n but it's version 5.5.1 so probably not from neon packages? Or is this because I'm on neon dev ed? REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D2047 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, #plasma, davidedmundson Cc: sitter, davidedmundson, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D2047: [KDE Platform Theme] Set application layoutDirection based on locale
davidedmundson added a comment. *built and installed REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D2047 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D2047: [KDE Platform Theme] Set application layoutDirection based on locale
davidedmundson added a comment. We don't have a bug. Make sure you have qttranslations build and installed. If you're using distro packages and they're not installing that, please tell them. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D2047 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Requested Changes To] D2047: [KDE Platform Theme] Set application layoutDirection based on locale
davidedmundson requested changes to this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision now requires changes to proceed. Looking at QGuiApplication.cpp this is all manner of wrong. You are right we have a bug, but this really isn't the fix: I'll take a look. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D2047 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 128327: [Calendar] Flip arrow buttons on right-to-left languages
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128327/ --- Review request for Plasma. Repository: plasma-framework Description --- This ensures the arrows always point outward, away from the centre button. Diffs - src/declarativeimports/calendar/qml/DaysCalendar.qml 0e119d9 Diff: https://git.reviewboard.kde.org/r/128327/diff/ Testing --- Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 12 lines] D2048: [System Tray] Adjust layout for right-to-left languages
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This ensures stuff in the popup gets mirrored and the sidebar is moved to the right and applets don't overlap it. The expander arrow is not (yet) adjusted as this is more complicated. TEST PLAN Seems to work. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2048 AFFECTED FILES applets/systemtray/package/contents/ui/items/AbstractItem.qml applets/systemtray/package/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 7 lines] D2049: [Desktop Package] Adjust layout for right-to-left languages
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This ensures content of applet popups and applet config dialogs is correctly mirrored. TEST PLAN Works surprisingly well. The Layout combo in wallpaper dialog is misaligned but other than that kickoff, even the calendar works. I was wondering if we can perhaps have LayoutMirroring childrenInherit propagate to dialogs as well? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2049 AFFECTED FILES desktoppackage/contents/applet/CompactApplet.qml desktoppackage/contents/configuration/AppletConfiguration.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 3 lines] D2047: [KDE Platform Theme] Set application layoutDirection based on locale
broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAINTEGRATION Integration for Qt applications in Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This ensures that when starting the application with eg. Hebrew locale, the application is mirrored. Qt does not seem to do this automatically but instead apparently wants you to include a QT_LAYOUT_DIRECTION string translated as either rtl or ltr in your app. TEST PLAN LC_ALL=ar dolphin ← dolphin was reversed, before it was not LC_ALL=he dolphin ← dolphin was reversed, before it was not dolphin ← dolphin not reversed Not sure if this is the right approach though, or if there's a latent Qt bug. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D2047 AFFECTED FILES src/platformtheme/kdeplatformtheme.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 147 lines] D2046: [autotests] Add a new test case which can verify the rendering of QPainter Scene
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY The idea behind this autotest is inspired by bug 356328 which produced incorrect rendering results. Also it's inspired by openQA which performs image reference comparisons. This test case tries to go further. It creates reference images which must match the rendering result exactly. So far the test case verifies the start condition - kwin started and one frame is rendered with default cursor in the middle of the screen. And it verifies the moving of the cursor without any windows shown. Whenever the cursor moves a repaint should be triggered and the old and new area should be properly repainted. To support this the test needs some minor changes in KWin: - Scene provides a frameRendered signal - needed for waiting on frame - Scene and SceneQPainter are exported - SceneQPainter provides access to it's Backend, so that we get to the backbuffer - ScriptedEffectLoader is exported for getting a list of all scripted effects - (we don't want fade to manipulate the rendering) REPOSITORY rKWIN KWin BRANCH autotest-qpainter-rendering REVISION DETAIL https://phabricator.kde.org/D2046 AFFECTED FILES autotests/integration/CMakeLists.txt autotests/integration/scene_qpainter_test.cpp effectloader.h scene.h scene_qpainter.cpp scene_qpainter.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: plasma-devel, kwin, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 4 lines] D2045: [Task Manager] Fix collapsing tooltip preview area for launchers
broulik created this revision. broulik added reviewers: Plasma, hein, bshah. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 364900 FIXED-IN: 5.7.0 TEST PLAN - Regular windows still have window thumbs - Groups have multiple window thumbs - Regular launchers have no thumbnail area whatsoever (compact tooltip) - Launchers of players still get album art REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2045 AFFECTED FILES applets/taskmanager/package/contents/ui/ToolTipDelegate.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, hein, bshah Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D2044: WIP: [KSMServer] Load logout dialog after startup rather than on-demand
broulik added a comment. Harald, weren't you even looking into offline updates? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2044 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, sitter Cc: graesslin, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D2044: WIP: [KSMServer] Load logout dialog after startup rather than on-demand
graesslin added a comment. I'm not sure whether that's the correct approach to the problem. It's a workaround and we have probably a bazillion other places where it breaks as well. IMHO the updates should be installed offline and AFAIU packagekit supports that. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2044 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, sitter Cc: graesslin, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 186 lines] D2044: WIP: [KSMServer] Load logout dialog after startup rather than on-demand
broulik created this revision. broulik added reviewers: Plasma, sitter. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This ensures the logout dialog is kept in memory and continues to work even after a Qt or other library update. BUG: 364897 TEST PLAN Mostly works. I logged in and then screwed up my logout dialog QML file and still got a shutdown dialog. We need to adjust the logout dialog QML though so it stops the timer when not visible (my root.visible approach didn't work) and resets the timeout. Also it doesn't seem to properly update the selected shutdown type, ie. if I select Logout and then select Shutdown it doesn't notice. Ideally, we'll just do that when we're re-designing the logout dialog anyway. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2044 AFFECTED FILES ksmserver/shutdown.cpp ksmserver/shutdowndlg.cpp ksmserver/shutdowndlg.h ksmserver/startup.cpp ksmserver/tests/test.cpp lookandfeel/contents/components/LogoutScreen.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, sitter Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 354250] "Switch User" sometimes sends computer to Standby
https://bugs.kde.org/show_bug.cgi?id=354250 --- Comment #29 from Fabian Köster --- Please note that I do not use Fedora but Gentoo Linux which still executes X as root. "ps aux | grep /usr/bin/X" confirms that: root 2229 2.2 0.5 407300 89944 tty1 Ssl+ 15:39 1:32 /usr/bin/X -nolisten tcp -auth /var/run/sddm/{c31eee08-f7e1-45f3-974b-14c6c8998aad} -background none -noreset -displayfd 18 vt1 -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 354250] "Switch User" sometimes sends computer to Standby
https://bugs.kde.org/show_bug.cgi?id=354250 --- Comment #28 from Oliver Henshaw --- Note that this wasn't a problem on F21, so this is a regression somewhere, not necessarily a misdesign feature. Could be an X regression, could be a kde 4 -> 5 regression, could be a qt 4 -> 5 regression. Note that I see a similar backtrace for Xorg for the session I'm actually in - that might just be business as usual. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Long term support release for Plasma?
Good idea. El mié., 29 de jun. de 2016 11:29 AM, Martin Gräßlin escribió: > Am 2016-06-29 15:34, schrieb Philip Muskovac: > >> * how long should a LTS be supported? > > I would be happy with your proposal, but it would be nice if security > > issues could be evaluated for the previous LTS as well. Doesn't need a > > release, a note in the advisory would be sufficient. > > Just as a note: we hit one sever security issue in 5.x so far and that > got backported to all releases (including 5.0). So yeah that certainly > sounds doable and is also something I expect our security team to ask > for. > > >> > >> Related to that: > >> * what to do with frameworks? > >> * Would you freeze the frameworks version or continue to backport > >> newer > >> framework versions to your distribution? > >> * Would you want an LTS branch for frameworks as well? > >> * What would you expect that to look like? > > For frameworks I'm clueless, really. To be able to use a frameworks > > release in Kubuntu as an "update" it would have to... > > - not cause any regressions [Not in plasma, not in any other software > > that uses it] (Hi behavior change when closing applications) > > - not have any new or updated dependencies ("new" as in: we would need > > to add/update a 3rd party package) > > - not have any component or pieces of a component removed (counts as > > "regression" [not frameworks, but hi kdepim for once removing unused > > public libs in a "bugfix" update]) > > - not have any components added (ok, that could probably be handled if > > really necessary) > > > > That's why we and other distributions were asking for bugfix releases > > for frameworks 2 years ago. Did something change in the meantime that > > I missed? > > I'm not aware of any changes. > > >> > >> Looking forward to your input on this rather important topic. > >> > >> Cheers > >> Martin > > > > Here you have it and thanks for the idea ;) > > Thanks for the feedback, very appreciated. > > Cheers > Martin > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 354250] "Switch User" sometimes sends computer to Standby
https://bugs.kde.org/show_bug.cgi?id=354250 --- Comment #27 from Martin Gräßlin --- both threads are waiting (X can do multi-threading, that's like wow I'm impressed). Though the one is a graphics thread and is somewhere in radeon. That could be an indication for being blocked and waiting for something to happen when resumed. But overall I'm not familiar enough with the code to make a guess. So I just assume that non-root X is not doing anything when the session is switched away. AFAIU their architecture is very similar to what kwin_wayland does for that situation. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Long term support release for Plasma?
Am 2016-06-29 15:34, schrieb Philip Muskovac: * how long should a LTS be supported? I would be happy with your proposal, but it would be nice if security issues could be evaluated for the previous LTS as well. Doesn't need a release, a note in the advisory would be sufficient. Just as a note: we hit one sever security issue in 5.x so far and that got backported to all releases (including 5.0). So yeah that certainly sounds doable and is also something I expect our security team to ask for. Related to that: * what to do with frameworks? * Would you freeze the frameworks version or continue to backport newer framework versions to your distribution? * Would you want an LTS branch for frameworks as well? * What would you expect that to look like? For frameworks I'm clueless, really. To be able to use a frameworks release in Kubuntu as an "update" it would have to... - not cause any regressions [Not in plasma, not in any other software that uses it] (Hi behavior change when closing applications) - not have any new or updated dependencies ("new" as in: we would need to add/update a 3rd party package) - not have any component or pieces of a component removed (counts as "regression" [not frameworks, but hi kdepim for once removing unused public libs in a "bugfix" update]) - not have any components added (ok, that could probably be handled if really necessary) That's why we and other distributions were asking for bugfix releases for frameworks 2 years ago. Did something change in the meantime that I missed? I'm not aware of any changes. Looking forward to your input on this rather important topic. Cheers Martin Here you have it and thanks for the idea ;) Thanks for the feedback, very appreciated. Cheers Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 354250] "Switch User" sometimes sends computer to Standby
https://bugs.kde.org/show_bug.cgi?id=354250 --- Comment #26 from Oliver Henshaw --- (In reply to Martin Gräßlin from comment #24) > From comment @18 it looks like X freezes while being on the inactive > session. As Fedora is mentioned I assume it's an X not run as root? If X > freezes all xcb requests are going to block. From client side there is > nothing which can be done about that. There is no timeout and no way to > cancel. Yep, it's xorg-x11-server-Xorg-1.17.4-1.fc22.x86_64 with the server running as non-root. > > I would be interested in seeing a backtrace of X at that time as I assume > it's also frozen. # pstack 19966 Thread 2 (Thread 0x7f133d647700 (LWP 19995)): #0 pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185 #1 0x7f13401db6da in cnd_wait (mtx=0x27ce4b0, cond=0x27ce4d8) at ../../../../../include/c11/threads_posix.h:154 #2 pipe_semaphore_wait (sema=0x27ce4b0) at ../../../../../src/gallium/auxiliary/os/os_thread.h:259 #3 radeon_drm_cs_emit_ioctl (param=param@entry=0x27ce180) at radeon_drm_winsys.c:636 #4 0x7f13401dae37 in impl_thrd_routine (p=) at ../../../../../include/c11/threads_posix.h:87 #5 0x7f134963d555 in start_thread (arg=0x7f133d647700) at pthread_create.c:333 #6 0x7f1349955ded in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109 Thread 1 (Thread 0x7f134be499c0 (LWP 19966)): #0 0x7f134994c2e3 in select () at ../sysdeps/unix/syscall-template.S:81 #1 0x005935af in WaitForSomething (pClientsReady=pClientsReady@entry=0x2aa4530) at WaitFor.c:227 #2 0x0043a3e1 in Dispatch () at dispatch.c:358 #3 0x0043e6eb in dix_main (argc=14, argv=0x7fff89842b38, envp=) at main.c:298 #4 0x7f1349873700 in __libc_start_main (main=0x428ae0 , argc=14, argv=0x7fff89842b38, init=, fini=, rtld_fini=, stack_end=0x7fff89842b28) at libc-start.c:289 #5 0x00428b19 in _start () -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 128316: Make use of QQuickItem::setSize instead of width and height indpedently.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128316/#review96954 --- Ship it! Ship It! - Marco Martin On June 29, 2016, 10:40 a.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128316/ > --- > > (Updated June 29, 2016, 10:40 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Even though QQuickItem only has a width and height accessor there is a > usable public setSize method. > > This gets rid of a lot of potential pointless re-evaluation as internal > geometry > is updated before widthChanged is emitted. > > > Diffs > - > > src/plasmaquick/appletquickitem.cpp > a9d044b1b50eace5d20441700eba3733c14b1ffd > src/plasmaquick/configview.cpp 5c2920bdc97643a353d47d6698a56f5d898b82e7 > src/scriptengines/qml/plasmoid/wallpaperinterface.cpp > adacbe19c3f306cf442850d45fed2933e48e6b4b > > Diff: https://git.reviewboard.kde.org/r/128316/diff/ > > > Testing > --- > > Restarted Plasma, everything seems normal > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 128316: Make use of QQuickItem::setSize instead of width and height indpedently.
> On jun 29, 2016, 11:05 a.m., Mark Gaiser wrote: > > I think you found an undocumented feature. > > The docs don't mention it, not even in the list of all members + inherited > > ones: http://doc.qt.io/qt-5/qquickitem-members.html > > > > But if i add a QQuickItem in my project and look up the setSize member, it > > just exists. It's part of QQuickItem.h > > > > So looks OK to me and a nice improvement as well! > > I will report a bug against Qt notifying them about this missing function > > in the documentation. > > Kai Uwe Broulik wrote: > It's documented as \internal in the source code which is why it doesn't > show up in the docs. A public internal. That's funny :) I wonder if they just forgot to remove the \internal or if it really should be a internal function. Anyway, reported now: https://bugreports.qt.io/browse/QTBUG-54440 - Mark --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128316/#review96951 --- On jun 29, 2016, 10:40 a.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128316/ > --- > > (Updated jun 29, 2016, 10:40 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Even though QQuickItem only has a width and height accessor there is a > usable public setSize method. > > This gets rid of a lot of potential pointless re-evaluation as internal > geometry > is updated before widthChanged is emitted. > > > Diffs > - > > src/plasmaquick/appletquickitem.cpp > a9d044b1b50eace5d20441700eba3733c14b1ffd > src/plasmaquick/configview.cpp 5c2920bdc97643a353d47d6698a56f5d898b82e7 > src/scriptengines/qml/plasmoid/wallpaperinterface.cpp > adacbe19c3f306cf442850d45fed2933e48e6b4b > > Diff: https://git.reviewboard.kde.org/r/128316/diff/ > > > Testing > --- > > Restarted Plasma, everything seems normal > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 16 - Still Failing!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 29 Jun 2016 11:01:18 + Build duration: 7 min 15 sec CHANGE SET Revision df230872204f1457192bb048808f7f593210a0cf by scripty: (SVN_SILENT made messages (after extraction)) change: edit org.kde.plasmashell.metainfo.xml ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 128316: Make use of QQuickItem::setSize instead of width and height indpedently.
> On Juni 29, 2016, 11:05 vorm., Mark Gaiser wrote: > > I think you found an undocumented feature. > > The docs don't mention it, not even in the list of all members + inherited > > ones: http://doc.qt.io/qt-5/qquickitem-members.html > > > > But if i add a QQuickItem in my project and look up the setSize member, it > > just exists. It's part of QQuickItem.h > > > > So looks OK to me and a nice improvement as well! > > I will report a bug against Qt notifying them about this missing function > > in the documentation. It's documented as \internal in the source code which is why it doesn't show up in the docs. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128316/#review96951 --- On Juni 29, 2016, 10:40 vorm., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128316/ > --- > > (Updated Juni 29, 2016, 10:40 vorm.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Even though QQuickItem only has a width and height accessor there is a > usable public setSize method. > > This gets rid of a lot of potential pointless re-evaluation as internal > geometry > is updated before widthChanged is emitted. > > > Diffs > - > > src/plasmaquick/appletquickitem.cpp > a9d044b1b50eace5d20441700eba3733c14b1ffd > src/plasmaquick/configview.cpp 5c2920bdc97643a353d47d6698a56f5d898b82e7 > src/scriptengines/qml/plasmoid/wallpaperinterface.cpp > adacbe19c3f306cf442850d45fed2933e48e6b4b > > Diff: https://git.reviewboard.kde.org/r/128316/diff/ > > > Testing > --- > > Restarted Plasma, everything seems normal > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 128316: Make use of QQuickItem::setSize instead of width and height indpedently.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128316/#review96951 --- Ship it! I think you found an undocumented feature. The docs don't mention it, not even in the list of all members + inherited ones: http://doc.qt.io/qt-5/qquickitem-members.html But if i add a QQuickItem in my project and look up the setSize member, it just exists. It's part of QQuickItem.h So looks OK to me and a nice improvement as well! I will report a bug against Qt notifying them about this missing function in the documentation. - Mark Gaiser On jun 29, 2016, 10:40 a.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128316/ > --- > > (Updated jun 29, 2016, 10:40 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Even though QQuickItem only has a width and height accessor there is a > usable public setSize method. > > This gets rid of a lot of potential pointless re-evaluation as internal > geometry > is updated before widthChanged is emitted. > > > Diffs > - > > src/plasmaquick/appletquickitem.cpp > a9d044b1b50eace5d20441700eba3733c14b1ffd > src/plasmaquick/configview.cpp 5c2920bdc97643a353d47d6698a56f5d898b82e7 > src/scriptengines/qml/plasmoid/wallpaperinterface.cpp > adacbe19c3f306cf442850d45fed2933e48e6b4b > > Diff: https://git.reviewboard.kde.org/r/128316/diff/ > > > Testing > --- > > Restarted Plasma, everything seems normal > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 225 lines] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve updated this revision to Diff 4848. bdhruve added a comment. Fixed copyright header. REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1989?vs=4847&id=4848 BRANCH kwinqml REVISION DETAIL https://phabricator.kde.org/D1989 AFFECTED FILES config-kwin.h.cmake plugins/CMakeLists.txt plugins/qml/CMakeLists.txt plugins/qml/kwinqml/CMakeLists.txt plugins/qml/kwinqml/kwinplugin.cpp plugins/qml/kwinqml/kwinplugin.h plugins/qml/kwinqml/kwinqml.cpp plugins/qml/kwinqml/kwinqml.h plugins/qml/kwinqml/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, #plasma_on_wayland, bshah Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 128316: Make use of QQuickItem::setSize instead of wight and height indpedently.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128316/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Even though QQuickItem only has a width and height accessor there is a usable public setSize method. This gets rid of a lot of potential pointless re-evaluation as internal geometry is updated before widthChanged is emitted. Diffs - src/plasmaquick/appletquickitem.cpp a9d044b1b50eace5d20441700eba3733c14b1ffd src/plasmaquick/configview.cpp 5c2920bdc97643a353d47d6698a56f5d898b82e7 src/scriptengines/qml/plasmoid/wallpaperinterface.cpp adacbe19c3f306cf442850d45fed2933e48e6b4b Diff: https://git.reviewboard.kde.org/r/128316/diff/ Testing --- Restarted Plasma, everything seems normal Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 225 lines] D1989: Introduce QQuickItem to nest kwin_wayland
bdhruve updated this revision to Diff 4847. bdhruve added a comment. Fixed issues mentioned by @bshah REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1989?vs=4797&id=4847 BRANCH kwinqml REVISION DETAIL https://phabricator.kde.org/D1989 AFFECTED FILES config-kwin.h.cmake plugins/CMakeLists.txt plugins/qml/CMakeLists.txt plugins/qml/kwinqml/CMakeLists.txt plugins/qml/kwinqml/kwinplugin.cpp plugins/qml/kwinqml/kwinplugin.h plugins/qml/kwinqml/kwinqml.cpp plugins/qml/kwinqml/kwinqml.h plugins/qml/kwinqml/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, #plasma_on_wayland Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Requested Changes To] D1989: Introduce QQuickItem to nest kwin_wayland
bshah requested changes to this revision. bshah added a reviewer: bshah. This revision now requires changes to proceed. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1989 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, #plasma_on_wayland, bshah Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland
bshah added a comment. Some minor issues I noticed.. INLINE COMMENTS > CMakeLists.txt:13 > + Qt5::Quick > + KF5::WaylandClient > + KF5::WaylandServer Not required, you just use WaylandServer API. > kwinplugin.h:1 > +#ifndef KWINPLUGIN_H > +#define KWINPLUGIN_H This and all other header and C++ files are missing license headers, See: https://community.kde.org/Policies/Licensing_Policy > kwinqml.cpp:29-31 > +if (!m_socketName.isNull() && !m_socketName.isEmpty()) { > +m_display->setSocketName(m_socketName); > +} Coding style. > kwinqml.h:1 > +#include > +#include You are missing include guard in this header file. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1989 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, #plasma_on_wayland Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 16 - Still Failing!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 29 Jun 2016 09:23:58 + Build duration: 53 sec CHANGE SET Revision 7efc1c05d60de588a7504715b56b529eb4b20065 by David Edmundson: (Set system tray applet to RequiresInput when a popup is showing) change: edit applets/systemtray/package/contents/ui/main.qml ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1779: Add a parent_window event to Plasma Window interface
hein added a comment. Just for the record: Martin's reply convinced me, so +1 after the fact. Sorry for this slipping through the cracks. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1779 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, hein, #plasma_on_wayland, sebas Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D2034: Set system tray applet to RequiresInput when a popup is showing
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE7efc1c05d60d: Set system tray applet to RequiresInput when a popup is showing (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2034?vs=4823&id=4846 REVISION DETAIL https://phabricator.kde.org/D2034 AFFECTED FILES applets/systemtray/package/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, broulik Cc: broulik, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 364275] sleep and hibernate gone after update
https://bugs.kde.org/show_bug.cgi?id=364275 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de Status|UNCONFIRMED |RESOLVED Resolution|--- |DOWNSTREAM --- Comment #12 from Kai Uwe Broulik --- I've seen this issue on Kubuntu and looks like a packaging issue, I had kded5 crash with a symbol lookup error after updates that could only be resolved by rebuilding PowerDevil manually. Please contact your distribution and make them aware of this issue. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 364275] sleep and hibernate gone after update
https://bugs.kde.org/show_bug.cgi?id=364275 dominikdanel...@gmail.com changed: What|Removed |Added CC||dominikdanel...@gmail.com --- Comment #11 from dominikdanel...@gmail.com --- I can confirm this bug. It has also occurred on my computer (Debian testing). After an update/upgrade I've lost sleep and hibernate from the launcher, after a few minutes without an action of a user or a push of a power button etc. the computer goes to the lock screen instead of going to sleep and after I log in I see the clean workplace, so if I don't save everything before, it's gone. I can't access the energy management menu because the EnergyDevil service isn't running, but when I try to run it, I get a message "Message recipient disconnected from message bus without replying" and after confirming it kded5 error occurs (kded5 PID: 12482 Sygnał: Segmentation fault (11)). As a result I can't find the way to change the screen brightness (Fn+F5/F6 doesn't help). I also have a few more bugs which have probably occurred after that update, but before I have to check if they can be related to this bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D1780: Expose the transientFor relationship to PlasmaWindowInterface
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINaa215e12ccdc: Expose the transientFor relationship to PlasmaWindowInterface (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1780?vs=4245&id=4845 REVISION DETAIL https://phabricator.kde.org/D1780 AFFECTED FILES abstract_client.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, hein, #plasma_on_wayland, sebas Cc: plasma-devel, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D2032: Add support for ToolTip Role on PlasmaSurface
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINc9984094dec2: Add support for ToolTip Role on PlasmaSurface (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2032?vs=4798&id=4843 REVISION DETAIL https://phabricator.kde.org/D2032 AFFECTED FILES autotests/wayland/plasma_surface_test.cpp shell_client.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, sebas Cc: plasma-devel, kwin, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D2031: [kwindowsystem] Add support for NET::Tooltip
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDINTEGRATIONc671900d9d24: [kwindowsystem] Add support for NET::Tooltip (authored by graesslin). REPOSITORY rKWAYLANDINTEGRATION Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2031?vs=4796&id=4844 REVISION DETAIL https://phabricator.kde.org/D2031 AFFECTED FILES src/windowsystem/windowsystem.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, sebas Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D1973: Support for syncing the clipboard from X11 to Wayland and vice versa
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN3493e9765504: Support for syncing the clipboard from X11 to Wayland and vice versa (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1973?vs=4737&id=4842#toc REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1973?vs=4737&id=4842 REVISION DETAIL https://phabricator.kde.org/D1973 AFFECTED FILES CMakeLists.txt autotests/wayland/CMakeLists.txt autotests/wayland/helper/CMakeLists.txt autotests/wayland/helper/copy.cpp autotests/wayland/helper/paste.cpp autotests/wayland/xclipboardsync_test.cpp config-kwin.h.cmake helpers/CMakeLists.txt helpers/xclipboardsync/CMakeLists.txt helpers/xclipboardsync/main.cpp helpers/xclipboardsync/waylandclipboard.cpp helpers/xclipboardsync/waylandclipboard.h keyboard_input.cpp wayland_server.cpp wayland_server.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, sebas Cc: plasma-devel, kwin, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D2010: On Wayland never try to create a WindowPixmap from an X11 pixmap
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINf79c3f244d57: On Wayland never try to create a WindowPixmap from an X11 pixmap (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2010?vs=4739&id=4841 REVISION DETAIL https://phabricator.kde.org/D2010 AFFECTED FILES scene.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, sebas Cc: plasma-devel, kwin, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel