Re: Review Request 128454: Kickoff query for CJK support

2016-07-26 Thread Leslie Zhai


> On 七月 15, 2016, 7:23 a.m., Eike Hein wrote:
> > Being able to find ??/?? with just wy is cool, but I'm concerned about this 
> > being a sort of very narrow hack. It's only in a specific KRunner plugin, 
> > so it won't work in any other thing finding apps by name using lower-level 
> > APIs. And it only works for Chinese. Littering high-level frontend code 
> > with language-specific stuff seems wrong. Is there a more central place we 
> > could put this, and maybe a more extensible way to do it? Like, a framework 
> > like Ki18n could have a matchInput(haystack, needle) that can do this sort 
> > of language-specific expansion/transform for haystack to match needle.
> 
> Eike Hein wrote:
> Also, more broadly ... why do you need to find Chinese text by pinyin or 
> pinyin initials in the first place? Why isn't using your IME to convert 
> pinyin to Chinese good enough? I assume the better IMEs are also smart enough 
> to suggest ?? for wy anyway?
> 
> Leslie Zhai wrote:
> > It's only in a specific KRunner plugin
> 
> Yes, it is better to develop such plugin for KRunner, and I learned how 
> to write one ;-P https://github.com/xiangzhai/krunner-helloworld
> 
> > And it only works for Chinese
> 
> Yes, the segmentation algroithm is complex 
> http://nlp.stanford.edu/software/segmenter.shtml and I have no idea how to 
> Machine Learning without Japanese and Korean dictionaries.
> 
> > Is there a more central place we could put this
> 
> I will pay more attention about ki18n framework.
> 
> > why do you need to find Chinese text by pinyin or pinyin initials
> 
> oh, people might choose English IME by default, so they need to press 
> Ctrl+Space to switch input method, but directly input Chinese, Japanese or 
> Korean pinyin is more comvinoent.
> 
> Eike Hein wrote:
> > oh, people might choose English IME by default, so they need to press 
> Ctrl+Space to switch input method, but directly input Chinese, Japanese or 
> Korean pinyin is more comvinoent
> 
> I'm against littering frontend code with "this Latin text entered might 
> actually be romanized Chinese, let's check" tests. That just makes no 
> engineering sense. A framework API used transparently in places where it 
> makes sense, and extensible to other languages: Maybe. But really the general 
> place where pinyin to Chinese conversion happens is IME. If you want an 
> automagic IME, that should maybe implemented at the Qt input handling level 
> somehow.
> 
> I understand why you want it and why it's nice for a specific user, but 
> it's not a maintainable approach. Should we add code for every language that 
> is frequently entered in a romanized from to servicerunner and every other 
> place, so in the end we copy 1000 lines of code to lots of codebases?
> 
> Leslie Zhai wrote:
> Hi Eike,
> 
> As you suggested I will develop a KRunner plugin for KJieba 
> https://github.com/isoft-linux/kjieba instead of M.O.D plasma ;-)
> 
> For Latin, it is comvinoent to just input letters for querying, but for 
> Asian Languages () there is a convertion, just like what you mentioned, 
> between letters and characters, and we often use Pinyin (does not need IME) 
> to input letters.
> 
> Regards,
> Leslie Zhai
> 
> Eike Hein wrote:
> > For Latin, it is comvinoent to just input letters for querying, but for 
> Asian Languages () there is a convertion, just like what you mentioned, 
> between letters and characters, and we often use Pinyin (does not need IME) 
> to input letters.
> 
> Sure pinyin needs an IME :P
> 
> FWIW: I live in Seoul.
> 
> Leslie Zhai wrote:
> I live in Beijing, and welcome to Beijing, I can show you around ;-)

KJieba krunner plugin screenshot shown as 
https://pbs.twimg.com/media/CoVyg6SUIAEFlln.jpg 
https://pbs.twimg.com/media/CoVyiSnUIAAeWJE.jpg


- Leslie


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128454/#review97418
---


On 七月 16, 2016, 7:19 a.m., Leslie Zhai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128454/
> ---
> 
> (Updated 七月 16, 2016, 7:19 a.m.)
> 
> 
> Review request for Plasma and Xuetian Weng.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Not like English, each word is seperated by a blank, for example, Hello 
> World, but in Chinese, , it needs to segment Chinese words.
> 
> And Kickoff once supported querying for CJK based on Chinese words 
> segmentation algroithm, but about last year after KF5, the feature was 
> dropped,  so I added an OPTIONAL requirement for KJieba - libcppjieba Chinese 
> word se

[Differential] [Updated, 417 lines] D2295: improve logging for kscreen

2016-07-26 Thread Sebastian Kügler
sebas updated this revision to Diff 5514.
sebas added a comment.


  - Fix copyright

REPOSITORY
  rLIBKSCREEN KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2295?vs=5513&id=5514

BRANCH
  sebas/log

REVISION DETAIL
  https://phabricator.kde.org/D2295

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/testbackendloader.cpp
  autotests/testconfigmonitor.cpp
  autotests/testinprocess.cpp
  autotests/testkwaylandbackend.cpp
  autotests/testkwaylandconfig.cpp
  autotests/testlog.cpp
  autotests/testqscreenbackend.cpp
  autotests/testscreenconfig.cpp
  src/CMakeLists.txt
  src/backendlauncher/main.cpp
  src/backendmanager.cpp
  src/getconfigoperation.cpp
  src/log.cpp
  src/log.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Request, 417 lines] D2295: improve logging for kscreen

2016-07-26 Thread Sebastian Kügler
sebas created this revision.
sebas added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Debugging kscreen is generally really hard since it's spread across different 
  processes, not all of which are easy to look into.
  
  With this change, we collect all of kscreen's debug output (from kcm, kded 
  and backendlauncher) and write them to a log file.
  
  This means that we can look into one log file, and see exactly what's going 
  on, and in which component. It makes collecting debug info much easier.
  
  This is implemented in the form of a QMessageHandler, hooking into the 
  qCDebug calls. This is a pretty neat solution, since:
  
  - we can make use of the stream operators from qDebug
  - we don't need to rewrite all the debug statements
  - normal debug is otherwise still working
  
  The general idea is that we cache file names and initialization from the
  env vars on first creation, allow subsequent context changes. The log file 
  is opened and closed right away, since other processes may want to also 
  write to it.
  
  We don't do any file-locking to keep things simple. The logging isn't
  mission-critical, but rather a debugging tool for users. If we end up
  with corrupt logs, that's bad luck (but can happen due to multi-process
  race conditions). More advanced multi-process locking and delayed
  writing is just going to give us headaches, so we avoid that at the
  price of logs not being 100% reliably formatted.
  
  Also:
  
  - disable logging for most autotests
  - all messages are then passed to the previously installed messagehandler.

TEST PLAN
  new code comes with autotests

REPOSITORY
  rLIBKSCREEN KScreen Library

BRANCH
  sebas/log

REVISION DETAIL
  https://phabricator.kde.org/D2295

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/testbackendloader.cpp
  autotests/testconfigmonitor.cpp
  autotests/testinprocess.cpp
  autotests/testkwaylandbackend.cpp
  autotests/testkwaylandconfig.cpp
  autotests/testlog.cpp
  autotests/testqscreenbackend.cpp
  autotests/testscreenconfig.cpp
  src/CMakeLists.txt
  src/backendlauncher/main.cpp
  src/backendmanager.cpp
  src/getconfigoperation.cpp
  src/log.cpp
  src/log.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Request, 68 lines] D2294: categorized logging for kscreen kcm

2016-07-26 Thread Sebastian Kügler
sebas created this revision.
sebas added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  - add category kscreen.kcm
  - switch all debug statements in kcm to categorized logging

TEST PLAN
  tested manually, works as expected

REPOSITORY
  rKSCREEN KScreen

BRANCH
  sebas/kcmcatlogging

REVISION DETAIL
  https://phabricator.kde.org/D2294

AFFECTED FILES
  kcm/src/CMakeLists.txt
  kcm/src/controlpanel.cpp
  kcm/src/debug.cpp
  kcm/src/debug.h
  kcm/src/kcm_kscreen.cpp
  kcm/src/outputconfig.cpp
  kcm/src/unifiedoutputconfig.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: multiscreen logging

2016-07-26 Thread Martin Klapetek
On Tue, Jul 26, 2016 at 8:03 AM, Sebastian Kügler  wrote:

> Hey,
>
> [Please keep both lists addressed.]
>
> Debugging multiscreen issues is a nightmare:
>
> - there are at least 4 different processes involved (kded, kcmshell /
>   systemsettings, kscreen_backend_launcher and plasmashell)
> - some are critical during log in
> - they IPC with each other
> - especially the backend launcher's debug is really hard to get at
>
> This means that:
> - it's hard (almost impossible) for users to get us good and useful logs
> - it's hard for ourselves to debug and find out what's exactly going on,
> especially when multiple components need to play in tune
>
> Yesternight, after debugging the so-many-th issue, it occurred to me that
> we
> need to make this way easier to debug. Q(C)Debug falls short in that we get
> logs of individual components, if we're lucky. If we're really lucky, we
> get
> timestamps, so we can get a rough idea of what is going down when.
>
> All of these problems can be solved with a relatively simple, shared log
> file.
>
> So I'd like to switch most of (lib)kscreen's debug output to logging to a
> file. The files has then logs from multiple processes and will be much
> easier
> to go through.
>

Wouldn't this create a possible concurrency issues when multiple processes
write to the same file?


> What do you think? If you like the idea, I'll polish up my branch and will
> post it for review, so we can discuss the actual implementation.
>

I think a possible better way could be to log each component into each own
file (in the same dir) with timestamps and function stamps and process
stamps
and everything and then merge those files using some automation and sort by
timestamp. Unless Qt on Linux actually handles concurrent write access just
fine
and in the correct order (I know it didn't on Windows last time I looked).

Cheers
-- 
Martin Klapetek
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Commented On] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

2016-07-26 Thread abondrov (Andrey Bondrov)
abondrov added a comment.


  @ivan, @mart
  
  I confirm, this way it seems to work.
  
  1. plasma-workspace: 
https://abf.rosalinux.ru/abondrov/plasma5-workspace/tree/rosa2014.1
  2. plasma-config: 
https://abf.rosalinux.ru/abondrov/plasma5-config-fresh/tree/rosa2014.1
  3. plasma-lnf: 
https://abf.rosalinux.ru/abondrov/plasma5-look-and-feel-rosa-fresh/tree/rosa2014.1
  
  ISO used for testing: 
https://abf.rosalinux.ru/platforms/rosa2014.1/products/137/product_build_lists/15748
  
  Boot logic from .xsession-errors:
  
  
  
  !!! setShell (init):  "org.kde.plasma.desktop"
  !!! setShell (theme name):  "rosa-fresh"
  !!! unload (init, m_shell) "org.kde.plasma.desktop"
  !!! load (init, m_shell):  "org.kde.plasma.desktop"
  !!! loadDefaultLayout (script) 
"/usr/share/plasma/shells/org.kde.plasma.desktop/contents/layout.js"
  !!! ShellCorona screenForContainment:  Plasma::Containment(0x8d1fb88)  Last 
screen is  -1
  !!! ShellCorona screenForContainment:  Plasma::Containment(0x8d1fb88)  Last 
screen is  -1
  !!! ShellCorona screenForContainment:  Plasma::Containment(0x8d1fb88)  Last 
screen is  -1
  !!! createContainmentForActivity (activity) 
"786d68ca-8b1b-41ae-a8a4-0ad378afed9d"
  !!! createContainmentForActivity (screenNum) 0
  !!! createContainmentForActivity (plugin) "org.kde.plasma.folder"
  !!! ShellCorona screenForContainment:  Plasma::Containment(0x8d1fb88)  Last 
screen is  -1
  !!! ShellCorona screenForContainment:  Plasma::Containment(0x8d1fb88)  Last 
screen is  -1
  !!! insertContainment (containment):  Plasma::Containment(0x8b6c8b0)
  !!! insertContainment (activity):  "786d68ca-8b1b-41ae-a8a4-0ad378afed9d"
  !!! insertContainment (screenNum):  0
  !!! ShellCorona screenForContainment:  Plasma::Containment(0x8d1fb88)  Last 
screen is  -1
  !!! ShellCorona screenForContainment:  Plasma::Containment(0x8d1fb88)  Last 
screen is  -1
  !!! ShellCorona screenForContainment:  Plasma::Containment(0x8d1fb88)  Last 
screen is  -1
  !!! ShellCorona screenForContainment:  Plasma::Containment(0x8d1fb88)  Last 
screen is  -1
  !!! ShellCorona screenForContainment:  Plasma::Containment(0x8b6c8b0)  Last 
screen is  -1
  !!! ShellCorona screenForContainment:  Plasma::Containment(0x8b6c8b0)  Last 
screen is  -1
  !!! checkActivities (status) 2
  !!! checkActivities (id) "786d68ca-8b1b-41ae-a8a4-0ad378afed9d"
  !!! load (containments are NOT empty, m_shell) "org.kde.plasma.desktop"
  !!! load (containmentType == panel)
  !!! load (containmentType == desktop)
  !!! createContainmentForActivity (activity) 
"786d68ca-8b1b-41ae-a8a4-0ad378afed9d"
  
  !!! createContainmentForActivity (screenNum) 0
  --
  
  I'll ask our QA engineer to give it more testing and let you know if we find 
anything interesting related to this issue.
  
  BTW, there's another containments-related Plasma crash which is easy to 
reproduce. Download the ISO, install it (or boot in live mode) and try to add 
second panel. Plasma will crash, then restart with second panel added and crash 
BT info provided. Bug report: https://bugs.kde.org/show_bug.cgi?id=366146

REVISION DETAIL
  https://phabricator.kde.org/D2283

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: ivan, abondrov, davidedmundson, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 220 - Fixed!

2016-07-26 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/220/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Jul 2016 17:31:51 +
Build duration: 15 min

CHANGE SET
Revision ddc3df8f0fd580586cfa2ffd8ee4d2ed13abe8e3 by kde: ([Kicker DragHelper] 
Ungrab mouse for drag)
  change: edit applets/kicker/plugin/draghelper.cpp
Revision e9769b99448eb4826ea75c4b4bac1353323b1f89 by kde: ([Kickoff] Sort 
Favorites in-view)
  change: edit applets/kickoff/package/contents/ui/Kickoff.qml
  change: edit applets/kickoff/package/contents/ui/FavoritesView.qml
  change: edit applets/kickoff/package/contents/ui/KickoffItem.qml


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2290/3367 
(68%)CONDITIONAL 1536/3727 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 605/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 252/350 (72%)CONDITIONAL 
82/189 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 220 - Fixed!

2016-07-26 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/220/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Jul 2016 17:31:51 +
Build duration: 15 min

CHANGE SET
Revision ddc3df8f0fd580586cfa2ffd8ee4d2ed13abe8e3 by kde: ([Kicker DragHelper] 
Ungrab mouse for drag)
  change: edit applets/kicker/plugin/draghelper.cpp
Revision e9769b99448eb4826ea75c4b4bac1353323b1f89 by kde: ([Kickoff] Sort 
Favorites in-view)
  change: edit applets/kickoff/package/contents/ui/Kickoff.qml
  change: edit applets/kickoff/package/contents/ui/FavoritesView.qml
  change: edit applets/kickoff/package/contents/ui/KickoffItem.qml


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2290/3367 
(68%)CONDITIONAL 1536/3727 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 605/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 252/350 (72%)CONDITIONAL 
82/189 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Closed] D2090: [Kickoff] Sort Favorites in-view

2016-07-26 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPe9769b99448e: [Kickoff] Sort Favorites in-view 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2090?vs=4951&id=5507#toc

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2090?vs=4951&id=5507

REVISION DETAIL
  https://phabricator.kde.org/D2090

AFFECTED FILES
  applets/kickoff/package/contents/ui/FavoritesView.qml
  applets/kickoff/package/contents/ui/Kickoff.qml
  applets/kickoff/package/contents/ui/KickoffItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, hein, #plasma, davidedmundson
Cc: colomar, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 283 - Still Unstable!

2016-07-26 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/283/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Jul 2016 16:49:56 +
Build duration: 5 min 15 sec

CHANGE SET
Revision 4b3e5cd21178ec075312d5ae42ff8b1cabef3697 by ivan.cukic: (Properly 
registering existing activities before loading layout.js)
  change: edit shell/shellcorona.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 
test(s)Failed: TestSuite.screenpooltest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1973/5346 
(37%)CONDITIONAL 1382/5482 (25%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 113/168 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/3071 (5%)CONDITIONAL 
88/3209 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Selecting a Plasma logo

2016-07-26 Thread Philipp Stefan
After some consideration I think I would pick anditosan's proposal. With 
my second being Kver's fourth icon.

My reasoning is the following:
- It's so simple a child could draw it
- It's easily recognizable without being noisy
- It's simplicity allows both flexibility and works well at different sizes

All of the above fits Ken's 4th too. Now since I implicitly rejected the 
others I want to give some feedback on them too, as I sadly didn't have 
time to do so on the forum.


Quiralta's proposal is simple and uses a metaphor potential users are 
very familiar with. However, it appears noisy. That mostly stems from 3 
things:

- there are overlaps
- the overlaps have different sizes
- it shows a line of action
Now one can argue the first two point for anditosan's proposal too, 
however, in combination these really stand out. For anyone who wants to 
draw comics/mangas/anything involving moving objects one will eventually 
find the "line of action" technique¹. Basically, we are able to infer 
that objects/persons in picture/drawing have a motion to them because 
one can draw an imaginary line through the object around which the 
object[s] are structured. The more the line is bent, the more dramatic 
the movement is.


AlexL's proposal probably fits best to the KDE logo and it is simply and 
easily recognizable. However, it also suffers from the same problems as 
the K-logo. The details of the gear are lost on smaller sizes, and width 
at the base of the teeth is much bigger than the line connecting the 
actual teeth with each other. Which especially at smaller sizes looks 
muddled.
Then there's also the problem that the cog icon, while abstract, is not 
abstract enough. It's an often use metaphor or settings/mechanism etc. 
Combining the arrow with the cog does not manage to separate it from the 
settings metaphor. So the unknowing will most likely search for meaning 
in the cog metaphor first before exploring other possibilities when 
trying to interpret the icon. Which leads to it looking strange, as on 
the one hand it has a clear metaphor, while inducing ambiguity about its 
actual meaning. Contrast that with anditosan's icon, which is abstract 
enough to not immediately associate it with a common metaphor, while not 
being completely foreign.
And last but not least the cog is quite harsh. It's associated with 
industry, manual labour, and – more abstract – thinking, analysis and 
work. While the round shapes for anditosan's proposal are more 
humanizing, soft and overall more inviting and friendlier.


With all that being said: I would caution against on choosing the one™ 
solution too quickly. I think Ken has shown nicely that anditosan's 
proposal is worthy of further investigation. We ought to flash out its 
usage in different scenarios (think different styles, sizes, contrasts 
etc.), so I would propose to hold a second round, so to speak where we 
investigate the concept further to finalize it.


[1] An example from a carton visualizing the concept 
http://photos1.blogger.com/blogger/1250/2135/1600/LofA.jpg

One can apply the same for real world situations.

Am 25.07.2016 um 20:54 schrieb Thomas Pfeiffer:

Dear Plasma development team, dear VDG,
the official deadline for the Plasma logo contest has passed yesterday.
We have five entries into the contest, with one actually consisting of 
five different mash-ups and modifications of the other entries, and 
one being Plasma's current logo.

You can find all the proposals here:
https://forum.kde.org/viewtopic.php?f=285&t=133836
I think we have quite a good selection here, and hope that we can find 
something here which we can agree on.
In the contest thread, I promised a jury consisting of VDG members and 
Plasma team members.
Now I've decided that since the whole Plasma team has to be able to 
identify themselves with the logo, and all VDG members should have the 
possibility to chip in as well, everyone who participates in the 
discussion is part of the jury.
There won't be a voting process. Either we can agree on a logo, or 
everything stays like it is (the official Plasma logo still being what 
we have now, and the K logo being used for the launchers).
I'd give us a discussion period until Sunday, unless a clear agreement 
can be reached before that.
Please refer to the logo proposals by the creator's forum name 
(remember that our current logo is Uri's, not mine ;) ), and for Ken's 
just say e.g. "Ken's fourth logo".
Happy discussions, here is to us finding a logo we can all (at least 
more or less) identify with!


Thomas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Selecting a Plasma logo

2016-07-26 Thread Ivan Čukić
On Tue, Jul 26, 2016 at 4:01 PM, Dan Leinir Turthra Jensen
 wrote:
> On Tuesday, 26 July 2016 15:52:41 BST Sebastian Kügler wrote:
>> > bridge to the current logo.
>>
>> I quite like that one indeed.
>
> Quite keen on that one, yes :)

It is one of my other favs, behind alex-kver-v2.

But I don't give it a +1 on the 'bridge to the current logo' since
/that/ Plasma logo is largely unknown (I'd give it +0.5 on that note -
while v2 gets both +0.5 because of the recognizable KDE logo, and +0.5
for the current plasma 5 logo). :)

Cheers,
Ivan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Selecting a Plasma logo

2016-07-26 Thread Dan Leinir Turthra Jensen
On Tuesday, 26 July 2016 15:52:41 BST Sebastian Kügler wrote:
> On Tuesday, July 26, 2016 2:54:26 PM CEST Thomas Pfeiffer wrote:
> > On 26.07.2016 14:03, Marco Martin wrote:
> > > On Tuesday 26 July 2016 12:57:04 kainz.a wrote:
> > >> I'm a fan of anditosan circle logo,
> > >> 
> > >> cause it fit's in small size as an icon the breeze icon theme (thin 1px
> > >> elements) AND it fit's as a logo in larger size like anditosan show
> > >> with
> > >> the logo on different background.
> > >> 
> > >> from the semantic point of view the circle logo show best what the word
> > >> plasma mean.
> > > 
> > > I kind of like it as is more smoother than the harsh usual gear.
> > > however, I'm quite concerned that it looks very, very generic, not
> > > really
> > > much recognizable
> > 
> > How about Ken's fourth suggestion (Anditosan's plus the > )?
> > That already makes it much more recognizable to me, and it would be a nice
> > bridge to the current logo.
> 
> I quite like that one indeed.

  Quite keen on that one, yes :)

-- 
..dan / leinir..
http://leinir.dk/
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Selecting a Plasma logo

2016-07-26 Thread Sebastian Kügler
On Tuesday, July 26, 2016 2:54:26 PM CEST Thomas Pfeiffer wrote:
> On 26.07.2016 14:03, Marco Martin wrote:
> > On Tuesday 26 July 2016 12:57:04 kainz.a wrote:
> >> I'm a fan of anditosan circle logo,
> >> 
> >> cause it fit's in small size as an icon the breeze icon theme (thin 1px
> >> elements) AND it fit's as a logo in larger size like anditosan show with
> >> the logo on different background.
> >> 
> >> from the semantic point of view the circle logo show best what the word
> >> plasma mean.
> > 
> > I kind of like it as is more smoother than the harsh usual gear.
> > however, I'm quite concerned that it looks very, very generic, not really
> > much recognizable
> 
> How about Ken's fourth suggestion (Anditosan's plus the > )?
> That already makes it much more recognizable to me, and it would be a nice 
> bridge to the current logo.

I quite like that one indeed.
-- 
sebas

http://www.kde.org | http://vizZzion.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Selecting a Plasma logo

2016-07-26 Thread Marco Martin
On Tuesday 26 July 2016 15:35:28 Ivan Čukić wrote:
> The one that stands out for me is one of the Kver's mesh-ups. The one
> with a part of the current plasma logo '>' inside two pieces of a
> gear.
> 
> The reason I find that one interesting is that we could use a part of
> it for the launcher icon if we wanted - just the '>'.
> 
yeah, all in all i agree that one seems the best one of the alternatives (not 
just on the prettyness side, but also how functional is in)
-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Selecting a Plasma logo

2016-07-26 Thread Ivan Čukić
> I kind of like it as is more smoother than the harsh usual gear.
> however, I'm quite concerned that it looks very, very generic, not really much
> recognizable

This is my problem with it as well.

The one that stands out for me is one of the Kver's mesh-ups. The one
with a part of the current plasma logo '>' inside two pieces of a
gear.

The reason I find that one interesting is that we could use a part of
it for the launcher icon if we wanted - just the '>'.

We could include the gear part, or two. It is open to modification.
The first thing that came to me was that we could easily make t-shirts
for a conference where the 'bumps' on the top gear would be
recognizable buildings of the city we are in.

Cheers,
Ivan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 219 - Failure!

2016-07-26 Thread no-reply

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/219/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Jul 2016 12:52:56 +
Build duration: 1 min 45 sec

CHANGE SET
Revision eedd0d49e192f835ecdcca4c6f19c6e3a18ab422 by Marco Martin: (adapt to 
panel.screenToFollow)
  change: edit 
desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml
  change: edit 
desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: multiscreen logging

2016-07-26 Thread Mark Gaiser
On Tue, Jul 26, 2016 at 2:03 PM, Sebastian Kügler  wrote:

> Hey,
>
> [Please keep both lists addressed.]
>
> Debugging multiscreen issues is a nightmare:
>
> - there are at least 4 different processes involved (kded, kcmshell /
>   systemsettings, kscreen_backend_launcher and plasmashell)
> - some are critical during log in
> - they IPC with each other
> - especially the backend launcher's debug is really hard to get at
>
> This means that:
> - it's hard (almost impossible) for users to get us good and useful logs
> - it's hard for ourselves to debug and find out what's exactly going on,
> especially when multiple components need to play in tune
>
> Yesternight, after debugging the so-many-th issue, it occurred to me that
> we
> need to make this way easier to debug. Q(C)Debug falls short in that we get
> logs of individual components, if we're lucky. If we're really lucky, we
> get
> timestamps, so we can get a rough idea of what is going down when.
>
> All of these problems can be solved with a relatively simple, shared log
> file.
>
> So I'd like to switch most of (lib)kscreen's debug output to logging to a
> file. The files has then logs from multiple processes and will be much
> easier
> to go through.
>
> API-wise, my main thing is having log messages and a bit of context, so
> it'd
> look like this:
>
> Log::instance()->setContext("handling resume event");
> // ...
> Log::log("Enabled output" + output->name());
>
> In the log, we'd then get
>
> [TIMESTAMP] (kded: handling resume event) Enabled output eDP-1
>
>
> The key here is that we get a mostly correct sequence of things, that all
> the
> info is there right away, and that it's easier for the user to annotate the
> log ("Now plugging in my external display as HDMI-2").
>
> The file is simple enough that even plasmashell could log to the file (at
> least until we've fixed the interaction between screen handling and
> plasmashell), so we get the full picture.
>
> libkscreen[sebas/log] has a basic implementation. It's incomplete in the
> sense
> that it needs a bit of autotesting (just haven't gotten to it yet), review
> and
> then switching over the code-base. (For now it's on by default, but can be
> disabled using a env var.)
>
> I hope that this makes it much more straight-forward for us (and even
> users)
> to figure out where their multiscreen headaches are coming from, and that
> it
> gives us a one-stop shop (pretty much) to tell users what info we need to
> fix
> their bugs. ("Just send me the logfile in ~/.local/share/kscreen.log").
>
> What do you think? If you like the idea, I'll polish up my branch and will
> post it for review, so we can discuss the actual implementation.
>
> Cheers,
> --
> sebas
>
> http://www.kde.org | http://vizZzion.org
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>

Hi,

Just a quick idea that might help you.

I'm not sure if the logging of those applications is already visible in
journalctl, but if it is then you can do something like this:
journalctl -u  -u  -u  -u  -f

-u would be the "units". Like plasmashell i guess.
-f means following the log (new entries appear on your screen).

Lastly, i would suggest to use a second pc independent of the one that
you're debugging. On that second machine just ssh into the one you're
debugging and execute the logging command from above.

This all obviously only works if you everything is already visible in
journalctl.

Good luck!
I hope this makes logging and debugging easier for you.

Cheers,
Mark
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Closed] D2288: Properly registering existing activities before loading layout.js

2016-07-26 Thread Ivan Čukić
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE475bed737314: Properly registering existing 
activities before loading layout.js (authored by ivan).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2288?vs=5499&id=5503

REVISION DETAIL
  https://phabricator.kde.org/D2288

AFFECTED FILES
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, mart, davidedmundson
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Selecting a Plasma logo

2016-07-26 Thread Thomas Pfeiffer

On 26.07.2016 14:03, Marco Martin wrote:

On Tuesday 26 July 2016 12:57:04 kainz.a wrote:

I'm a fan of anditosan circle logo,

cause it fit's in small size as an icon the breeze icon theme (thin 1px
elements) AND it fit's as a logo in larger size like anditosan show with
the logo on different background.

from the semantic point of view the circle logo show best what the word
plasma mean.


I kind of like it as is more smoother than the harsh usual gear.
however, I'm quite concerned that it looks very, very generic, not really much
recognizable


How about Ken's fourth suggestion (Anditosan's plus the > )?
That already makes it much more recognizable to me, and it would be a nice 
bridge to the current logo.

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Commented On] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

2016-07-26 Thread abondrov (Andrey Bondrov)
abondrov added a comment.


  @ivan, @mart
  
  > Since you are really helpful and active, I have a couple of things for you 
to test :) (please do not kill me)
  
  I'll test it tomorrow. It takes some time to build patched plasma-workspace 
package and then build ISO with it.
  
  Thanx for working on this issue :-)

REVISION DETAIL
  https://phabricator.kde.org/D2283

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: ivan, abondrov, davidedmundson, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Commented On] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

2016-07-26 Thread mart (Marco Martin)
mart added a comment.


  so, the patch is in, you can have a defaults file in the rosa lnf that has 
the following:
  
  [Desktop][org.kde.plasma.desktop]
  Containment=org.kde.plasma.folder

REVISION DETAIL
  https://phabricator.kde.org/D2283

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: ivan, abondrov, davidedmundson, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: "Software not found" Runner

2016-07-26 Thread Aleix Pol
On Tue, Jul 26, 2016 at 1:10 PM, Marco Martin  wrote:
> On Tuesday 26 July 2016 13:01:10 Aleix Pol wrote:
>> Hi,
>> Last week I put together this runner, thought it might be useful, so
>> if you type in krunner an application but it's not installed, it will
>> offer to open Discover to install it (any software center in fact).
>>
>> Do we want to push this for the next plasma release?
>> If so, do we want it enabled by default?
>>
>> You can look and test here:
>> https://quickgit.kde.org/?p=scratch%2Fapol%2Fappstreamrunner.git
>
> looks like a good idea.
> maybe kdeplasma-addons?
> i would be fine with having it enabled by default

I guess it would make sense in plasma-workspace if we want to enable
it in kickoff.

Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: "Software not found" Runner

2016-07-26 Thread Aleix Pol
On Tue, Jul 26, 2016 at 1:49 PM, Sebastian Kügler  wrote:
> On Tuesday, July 26, 2016 1:16:41 PM CEST Harald Sitter wrote:
>> On Tue, Jul 26, 2016 at 1:10 PM, Marco Martin  wrote:
>> > On Tuesday 26 July 2016 13:01:10 Aleix Pol wrote:
>> >> Hi,
>> >> Last week I put together this runner, thought it might be useful, so
>> >> if you type in krunner an application but it's not installed, it will
>> >> offer to open Discover to install it (any software center in fact).
>> >>
>> >> Do we want to push this for the next plasma release?
>> >> If so, do we want it enabled by default?
>> >>
>> >> You can look and test here:
>> >> https://quickgit.kde.org/?p=scratch%2Fapol%2Fappstreamrunner.git
>> >
>> > looks like a good idea.
>> > maybe kdeplasma-addons?
>> > i would be fine with having it enabled by default
>>
>> Should be in desktop or workspace or discover (<- order of preference)
>> if we want it by default IMO. Not all distros install addons by
>> default.
>
> If it's tied to discover, discover.git could have it. If it's "just"
> packagekit, it could be plasma-workspace or kdeplasma-addons (I personally
> don't care much, just wanted to comment that it doesn't have to be in
> kdeplasma-addons or plasma-workspace).

It doesn't use PackageKit, it uses Appstream for listing and when
triggered it opens the software center of choice.
There's no Discover dependency.

Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Accepted] D2242: [ksplash] Better support for Wayland with multiple screens

2016-07-26 Thread Sebastian Kügler
sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision is now accepted and ready to land.


  The wayland portions look good, so as soon as you guys are happy, I am.
  
  I guess the platform name stuff can happen async?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  splash-wayland

REVISION DETAIL
  https://phabricator.kde.org/D2242

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, sebas
Cc: sebas, ivan, plasma-devel, jensreuterberg, abetts
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 128493: [Button Styles] Horizontally center in icon-only mode

2016-07-26 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128493/
---

(Updated July 26, 2016, 2:09 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 16f825706887ef77751ebf38cf177ce01f786bd7 by Kai Uwe 
Broulik to branch master.


Bugs: 365947
http://bugs.kde.org/show_bug.cgi?id=365947


Repository: plasma-framework


Description
---

QtQuick.Layouts by default left aligns content and because the Layout is 
anchors.fill'd the icon would show off-center in a button when no text has been 
set. This fixes this.


Diffs
-

  src/declarativeimports/plasmastyle/ButtonStyle.qml a962512 
  src/declarativeimports/plasmastyle/ToolButtonStyle.qml 1562590 

Diff: https://git.reviewboard.kde.org/r/128493/diff/


Testing
---

* Close button icon in present window is no longer misaligned
* Close button icon in notification is no longer misaligned
* Button icons in panel controller (German locale where text is so long it 
hides the labels) are no longer misaligned
* Panel controller more menu buttons are fine (both the ones with and without 
label)
* Ran tests/components/button.qml all looked fine


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


multiscreen logging

2016-07-26 Thread Sebastian Kügler
Hey,

[Please keep both lists addressed.]

Debugging multiscreen issues is a nightmare:

- there are at least 4 different processes involved (kded, kcmshell / 
  systemsettings, kscreen_backend_launcher and plasmashell)
- some are critical during log in
- they IPC with each other
- especially the backend launcher's debug is really hard to get at

This means that:
- it's hard (almost impossible) for users to get us good and useful logs
- it's hard for ourselves to debug and find out what's exactly going on, 
especially when multiple components need to play in tune

Yesternight, after debugging the so-many-th issue, it occurred to me that we 
need to make this way easier to debug. Q(C)Debug falls short in that we get 
logs of individual components, if we're lucky. If we're really lucky, we get 
timestamps, so we can get a rough idea of what is going down when.

All of these problems can be solved with a relatively simple, shared log file.

So I'd like to switch most of (lib)kscreen's debug output to logging to a 
file. The files has then logs from multiple processes and will be much easier 
to go through.

API-wise, my main thing is having log messages and a bit of context, so it'd 
look like this:

Log::instance()->setContext("handling resume event");
// ...
Log::log("Enabled output" + output->name());

In the log, we'd then get

[TIMESTAMP] (kded: handling resume event) Enabled output eDP-1


The key here is that we get a mostly correct sequence of things, that all the 
info is there right away, and that it's easier for the user to annotate the 
log ("Now plugging in my external display as HDMI-2").

The file is simple enough that even plasmashell could log to the file (at 
least until we've fixed the interaction between screen handling and 
plasmashell), so we get the full picture.

libkscreen[sebas/log] has a basic implementation. It's incomplete in the sense 
that it needs a bit of autotesting (just haven't gotten to it yet), review and 
then switching over the code-base. (For now it's on by default, but can be 
disabled using a env var.)

I hope that this makes it much more straight-forward for us (and even users) 
to figure out where their multiscreen headaches are coming from, and that it 
gives us a one-stop shop (pretty much) to tell users what info we need to fix 
their bugs. ("Just send me the logfile in ~/.local/share/kscreen.log").

What do you think? If you like the idea, I'll polish up my branch and will 
post it for review, so we can discuss the actual implementation.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 128493: [Button Styles] Horizontally center in icon-only mode

2016-07-26 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128493/#review97852
---


Ship it!




Ship It!

- Marco Martin


On July 21, 2016, 2:45 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128493/
> ---
> 
> (Updated July 21, 2016, 2:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 365947
> http://bugs.kde.org/show_bug.cgi?id=365947
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> QtQuick.Layouts by default left aligns content and because the Layout is 
> anchors.fill'd the icon would show off-center in a button when no text has 
> been set. This fixes this.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmastyle/ButtonStyle.qml a962512 
>   src/declarativeimports/plasmastyle/ToolButtonStyle.qml 1562590 
> 
> Diff: https://git.reviewboard.kde.org/r/128493/diff/
> 
> 
> Testing
> ---
> 
> * Close button icon in present window is no longer misaligned
> * Close button icon in notification is no longer misaligned
> * Button icons in panel controller (German locale where text is so long it 
> hides the labels) are no longer misaligned
> * Panel controller more menu buttons are fine (both the ones with and without 
> label)
> * Ran tests/components/button.qml all looked fine
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Selecting a Plasma logo

2016-07-26 Thread Marco Martin
On Tuesday 26 July 2016 12:57:04 kainz.a wrote:
> I'm a fan of anditosan circle logo,
> 
> cause it fit's in small size as an icon the breeze icon theme (thin 1px
> elements) AND it fit's as a logo in larger size like anditosan show with
> the logo on different background.
> 
> from the semantic point of view the circle logo show best what the word
> plasma mean.

I kind of like it as is more smoother than the harsh usual gear.
however, I'm quite concerned that it looks very, very generic, not really much 
recognizable

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: "Software not found" Runner

2016-07-26 Thread Sebastian Kügler
On Tuesday, July 26, 2016 1:16:41 PM CEST Harald Sitter wrote:
> On Tue, Jul 26, 2016 at 1:10 PM, Marco Martin  wrote:
> > On Tuesday 26 July 2016 13:01:10 Aleix Pol wrote:
> >> Hi,
> >> Last week I put together this runner, thought it might be useful, so
> >> if you type in krunner an application but it's not installed, it will
> >> offer to open Discover to install it (any software center in fact).
> >> 
> >> Do we want to push this for the next plasma release?
> >> If so, do we want it enabled by default?
> >> 
> >> You can look and test here:
> >> https://quickgit.kde.org/?p=scratch%2Fapol%2Fappstreamrunner.git
> > 
> > looks like a good idea.
> > maybe kdeplasma-addons?
> > i would be fine with having it enabled by default
> 
> Should be in desktop or workspace or discover (<- order of preference)
> if we want it by default IMO. Not all distros install addons by
> default.

If it's tied to discover, discover.git could have it. If it's "just" 
packagekit, it could be plasma-workspace or kdeplasma-addons (I personally 
don't care much, just wanted to comment that it doesn't have to be in 
kdeplasma-addons or plasma-workspace).

-- 
sebas

http://www.kde.org | http://vizZzion.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 282 - Still Unstable!

2016-07-26 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/282/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Jul 2016 11:33:12 +
Build duration: 11 min

CHANGE SET
Revision b02217a3091582e19dcbdb58554e347fefee0463 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit 
shell/packageplugins/lookandfeel/plasma-packagestructure-lookandfeel.desktop
Revision b15d7a494e3d22e5e361e2ac3330fa4141bb33e5 by Marco Martin: (allow lnf 
package to specify a default cont)
  change: edit shell/scripting/scriptengine.cpp
  change: edit shell/shellcorona.h
  change: edit shell/shellcorona.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 
test(s)Failed: TestSuite.screenpooltest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1973/5346 
(37%)CONDITIONAL 1382/5482 (25%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 113/168 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/3071 (5%)CONDITIONAL 
88/3209 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Closed] D2286: allow lnf package to specify a default cont

2016-07-26 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEb15d7a494e3d: allow lnf package to specify a 
default cont (authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2286?vs=5500&id=5501#toc

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2286?vs=5500&id=5501

REVISION DETAIL
  https://phabricator.kde.org/D2286

AFFECTED FILES
  shell/scripting/scriptengine.cpp
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, ivan, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: "Software not found" Runner

2016-07-26 Thread Harald Sitter
On Tue, Jul 26, 2016 at 1:01 PM, Aleix Pol  wrote:
> https://quickgit.kde.org/?p=scratch%2Fapol%2Fappstreamrunner.git

testing deb for neon
https://share.kde.org/index.php/s/gfVwE9qgetyZ3Nu

Do note that you might have to manually enable the runner via
krunner's settings (listed as 'Software Center')

HS
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: "Software not found" Runner

2016-07-26 Thread Harald Sitter
On Tue, Jul 26, 2016 at 1:10 PM, Marco Martin  wrote:
> On Tuesday 26 July 2016 13:01:10 Aleix Pol wrote:
>> Hi,
>> Last week I put together this runner, thought it might be useful, so
>> if you type in krunner an application but it's not installed, it will
>> offer to open Discover to install it (any software center in fact).
>>
>> Do we want to push this for the next plasma release?
>> If so, do we want it enabled by default?
>>
>> You can look and test here:
>> https://quickgit.kde.org/?p=scratch%2Fapol%2Fappstreamrunner.git
>
> looks like a good idea.
> maybe kdeplasma-addons?
> i would be fine with having it enabled by default

Should be in desktop or workspace or discover (<- order of preference)
if we want it by default IMO. Not all distros install addons by
default.

HS
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Accepted] D2286: allow lnf package to specify a default cont

2016-07-26 Thread Ivan Čukić
ivan accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  arcpatch-D2286

REVISION DETAIL
  https://phabricator.kde.org/D2286

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, ivan, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Commented On] D2286: allow lnf package to specify a default cont

2016-07-26 Thread Ivan Čukić
ivan added a comment.


  Otherwise, seems ok. Does it work as well as it looks? :)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2286

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, ivan
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Commented On] D2286: allow lnf package to specify a default cont

2016-07-26 Thread Ivan Čukić
ivan added a comment.


  Otherwise, seems ok. Does it work as well as it looks? :)

INLINE COMMENTS

> plasma-packagestructure-lookandfeel.desktop:19
>  Name[gl]=Aparencia e comportamento
> -Name[he]=מראה והרגשה
> +Name[he]=מראה ותחושה
>  Name[hu]=Megjelenés

You should probably skip this :)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2286

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, ivan
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Selecting a Plasma logo

2016-07-26 Thread Thomas Pfeiffer

On 26.07.2016 12:57, kainz.a wrote:


The idea behind Quiralta logo is nice but in our HIG's is written the color
can't be the only difference.


As he has shown, that logo works in monochrome, too, so this would be no 
problem. The colors are just additional styling, they are not necessary to 
recognize the logo/icon.

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: "Software not found" Runner

2016-07-26 Thread Marco Martin
On Tuesday 26 July 2016 13:01:10 Aleix Pol wrote:
> Hi,
> Last week I put together this runner, thought it might be useful, so
> if you type in krunner an application but it's not installed, it will
> offer to open Discover to install it (any software center in fact).
> 
> Do we want to push this for the next plasma release?
> If so, do we want it enabled by default?
> 
> You can look and test here:
> https://quickgit.kde.org/?p=scratch%2Fapol%2Fappstreamrunner.git

looks like a good idea.
maybe kdeplasma-addons?
i would be fine with having it enabled by default

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Generating QtScript bindings for Qt5

2016-07-26 Thread R.Harish Navnit
On Tue, Jul 26, 2016 at 3:36 AM, Aleix Pol  wrote:
>
> Hi Harish,
> What are you trying to do? What do you need it for?
Oh sorry, I should have mentioned it earlier. I'm trying to work on
porting plasma's publictransport applet to plasma5. The dataengine
downloads documents(serviceProviders) and parses them using a script.

>
> I'd recommend against adopting anything using QtScript, as it's deprecated.
Yeah. I have a fixed timeline though and for now, I'd like to get to
rewriting the Ui for some simple cases at least. So for now, I'm
looking more for a workaround. We can eventually port it away from
QtScript once we establish there are no other major regressions with
the KF5/Qt5 port.

Cheers,
Harish
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: "Software not found" Runner

2016-07-26 Thread Harald Sitter
On Tue, Jul 26, 2016 at 1:01 PM, Aleix Pol  wrote:
> Hi,
> Last week I put together this runner, thought it might be useful, so
> if you type in krunner an application but it's not installed, it will
> offer to open Discover to install it (any software center in fact).
>
> Do we want to push this for the next plasma release?
> If so, do we want it enabled by default?
>
> You can look and test here:
> https://quickgit.kde.org/?p=scratch%2Fapol%2Fappstreamrunner.git

Weeh! awesome!

FWIW use cases:
- user wants to listen to music -> goes to kickoff and searches for
'music player' -> gets offered to install vlc or something
- user gets told about konversation by a friend -> wants to try it ->
opens kickoff and searches for 'konversation' -> gets offered to
install since it's not installed

HS
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


"Software not found" Runner

2016-07-26 Thread Aleix Pol
Hi,
Last week I put together this runner, thought it might be useful, so
if you type in krunner an application but it's not installed, it will
offer to open Discover to install it (any software center in fact).

Do we want to push this for the next plasma release?
If so, do we want it enabled by default?

You can look and test here:
https://quickgit.kde.org/?p=scratch%2Fapol%2Fappstreamrunner.git

Cheers!
Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Selecting a Plasma logo

2016-07-26 Thread kainz.a
I'm a fan of anditosan circle logo,

cause it fit's in small size as an icon the breeze icon theme (thin 1px
elements) AND it fit's as a logo in larger size like anditosan show with
the logo on different background.

from the semantic point of view the circle logo show best what the word
plasma mean.

My second vote would be the logo/icon from Uri cause I like it to and it
work also as logo and icon.

The idea behind Quiralta logo is nice but in our HIG's is written the color
can't be the only difference.

+1 for anditosan

2016-07-25 20:54 GMT+02:00 Thomas Pfeiffer :

> Dear Plasma development team, dear VDG,
> the official deadline for the Plasma logo contest has passed yesterday.
> We have five entries into the contest, with one actually consisting of
> five different mash-ups and modifications of the other entries, and one
> being Plasma's current logo.
> You can find all the proposals here:
> https://forum.kde.org/viewtopic.php?f=285&t=133836
> I think we have quite a good selection here, and hope that we can find
> something here which we can agree on.
> In the contest thread, I promised a jury consisting of VDG members and
> Plasma team members.
> Now I've decided that since the whole Plasma team has to be able to
> identify themselves with the logo, and all VDG members should have the
> possibility to chip in as well, everyone who participates in the discussion
> is part of the jury.
> There won't be a voting process. Either we can agree on a logo, or
> everything stays like it is (the official Plasma logo still being what we
> have now, and the K logo being used for the launchers).
> I'd give us a discussion period until Sunday, unless a clear agreement can
> be reached before that.
> Please refer to the logo proposals by the creator's forum name (remember
> that our current logo is Uri's, not mine ;) ), and for Ken's just say e.g.
> "Ken's fourth logo".
> Happy discussions, here is to us finding a logo we can all (at least more
> or less) identify with!
>
> Thomas
> ___
> Visual-design mailing list
> visual-des...@kde.org
> https://mail.kde.org/mailman/listinfo/visual-design
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Updated, 35 lines] D2286: allow lnf package to specify a default cont

2016-07-26 Thread mart (Marco Martin)
mart updated this revision to Diff 5500.
mart added a comment.


  - manage the 2 cases of shellcorona vs applicationcorona

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2286?vs=5496&id=5500

BRANCH
  arcpatch-D2286

REVISION DETAIL
  https://phabricator.kde.org/D2286

AFFECTED FILES
  shell/packageplugins/lookandfeel/plasma-packagestructure-lookandfeel.desktop
  shell/scripting/scriptengine.cpp
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, ivan
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Commented On] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

2016-07-26 Thread Ivan Čukić
ivan added a comment.


  p.s. The step `4` will be made a bit different with Marco's upcoming patch, 
but it is the only way ATM to set the default containment plugin.

REVISION DETAIL
  https://phabricator.kde.org/D2283

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: ivan, abondrov, davidedmundson, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Commented On] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

2016-07-26 Thread Ivan Čukić
ivan added a comment.


  @abondrov
  
  Yes, it is a backport of a patch that will be reverted once we deal with 5.7 
stuff. We didn't put it in 5.7 branch because it is not really a good patch - 
it was supposed to cover the cases when kactivitymanagerd is not installed, but 
we need kactivitymanagerd in 5.7 - that is why I mentioned it needs to be a 
hard requirement now.
  
  We will see for master whether we will go for keeping the patch, and changing 
the way kactivities report the status of the service, or reverting the patch 
and making kamd a hard-requirement for all future plasma releases.

REVISION DETAIL
  https://phabricator.kde.org/D2283

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: ivan, abondrov, davidedmundson, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Updated] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

2016-07-26 Thread Ivan Čukić
ivan added a comment.


  @abondrov
  
  Since you are really helpful and active, I have a couple of things for you to 
test :) (please do not kill me)
  
  1. Remove david's patch backported from master (the one that checks against 
kamd status being Unknown - 
`plasma-workspace-5.7.2-layout-initialization-2.patch`)
  2. Remove all patches similar to this one, except for Marco's which checks 
`m_activityController->serviceStatus() == KActivities::Controller::Running`
  3. Can you add https://phabricator.kde.org/D2288 
(https://phabricator.kde.org/D2288)
  4. Modify `plasma/shells/org.kde.plasma.desktop/contents/defaults` and set 
`Containment=org.kde.plasma.folder` - this should change the default 
containment type without the need to create activities from layout.js
  5. Modify layout.js to this:
  
  
  
loadTemplate("org.kde.plasma.desktop.defaultPanel");

var desktopsArray = desktopsForActivity(currentActivity());

print(desktopsArray.length);

for (var j = 0; j < desktopsArray.length; j++) {
desktopsArray[j].wallpaperPlugin = 'org.kde.image';
desktopsArray[j].currentConfigGroup = ["General"]
desktopsArray[j].writeConfig("showToolbox", "false")
}

REVISION DETAIL
  https://phabricator.kde.org/D2283

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: ivan, abondrov, davidedmundson, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Commented On] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

2016-07-26 Thread abondrov (Andrey Bondrov)
abondrov added a comment.


  In https://phabricator.kde.org/D2283#42598, @ivan wrote:
  
  > This one needs to go away, along with making kactivitymanagerd a hard 
runtime requirement:
  >
  > > 
https://abf.rosalinux.ru/import/plasma5-workspace/blob/rosa2014.1/plasma-workspace-5.7.2-layout-initialization-2.patch
  
  
  It's a backport of recently commited patch: 
https://quickgit.kde.org/?p=plasma-workspace.git&a=commit&h=d4b8143d552ccd8adf196afccac32985ea4bb7cb
  
  Likely it needs to be reverted then.

REVISION DETAIL
  https://phabricator.kde.org/D2283

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: ivan, abondrov, davidedmundson, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: From Grub to Shutdown project update

2016-07-26 Thread Harald Sitter
On Mon, Jul 25, 2016 at 12:24 PM, Jens Reuterberg  wrote:
> GRUB MENU

done in 'redesign' branch on git.
- spacing needs recalculating as the theme now won't fit on < 700px height
- also switched from noto to unifont as discussed previously as the
lack of AA is making most fonts look incredibly bad
- we haven't managed to figure out how to do translations for this yet :/

> PLYMOUTH

done in 'redesign' branch on git.
- do we animate anything on shutdown?
- busy indication is probably needed for long boots. for now, I
removed the spinner we had previously
- text theme still needs updating, but that's only default colors
since we haven't done any theming there anyway

video that doesn't reflect the changes very well. it looks incredibly
gorgeous on highres, try it!
https://share.kde.org/index.php/s/4YVmkd9iRfnVWK2

HS
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 128526: Make BINARY_ICONS_RESOURCE ON by default

2016-07-26 Thread Jarosław Staniek

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128526/
---

Review request for Plasma and Andreas Kainz.


Repository: breeze-icons


Description
---

Make BINARY_ICONS_RESOURCE ON by default. Otherwise packagers will not create 
packages with breeze-icons.rcc. Let them possible create split packages - 1 
with icon files and 1 with the rcc file.

Also our Jenkins fails to create the file, apps have no way to add dependency 
on breeze-icons "with rcc", there's just breeze-icons that we can depend on.
Example failure: 
https://build.kde.org/job/kexi%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/lastFailedBuild/console


Diffs
-

  CMakeLists.txt c0623ca 

Diff: https://git.reviewboard.kde.org/r/128526/diff/


Testing
---

breeze-icons now installs the .rcc file.


Thanks,

Jarosław Staniek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 281 - Unstable!

2016-07-26 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/281/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Jul 2016 09:18:51 +
Build duration: 5 min 59 sec

CHANGE SET
Revision c79cfed9b7620e01255937f0af60dda8446b310f by Marco Martin: (Consider 
the primary screen as default screen)
  change: add shell/screenpool.cpp
  change: edit shell/CMakeLists.txt
  change: edit shell/shellcorona.cpp
  change: add shell/screenpool.h
  change: add shell/autotests/screenpooltest.cpp
  change: add shell/autotests/desktopview.cpp
  change: add shell/autotests/desktopview.h
  change: edit shell/scripting/scriptengine.cpp
  change: edit shell/panelview.cpp
  change: edit shell/desktopview.cpp
  change: add shell/autotests/CMakeLists.txt
  change: edit shell/shellcorona.h
  change: edit shell/desktopview.h
  change: edit shell/panelview.h


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 
test(s)Failed: TestSuite.screenpooltest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1973/5346 
(37%)CONDITIONAL 1382/5482 (25%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 113/168 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/3071 (5%)CONDITIONAL 
88/3209 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Closed] D2218: New logic for screen numbers in plasmashell

2016-07-26 Thread mart (Marco Martin)
mart closed this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2218

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: lbeltrame, davidedmundson, rwooninck, graesslin, plasma-devel, 
jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Differential] [Commented On] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

2016-07-26 Thread Ivan Čukić
ivan added a comment.


  @abondrov
  
  Thanks.
  
  This one needs to go away, along with making kactivitymanagerd a hard runtime 
requirement:
  
  > 
https://abf.rosalinux.ru/import/plasma5-workspace/blob/rosa2014.1/plasma-workspace-5.7.2-layout-initialization-2.patch
  
  The load-order one is not a proper fix, so it will need to go as well when we 
figure out what the exact problem is.
  
  I'll try to copy your setup to replicate the issues you are having.
  
  @mart
  
  Here is the patch that should fix the scripting part of the issue 
https://phabricator.kde.org/D2288

REVISION DETAIL
  https://phabricator.kde.org/D2283

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: ivan, abondrov, davidedmundson, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 47 - Fixed!

2016-07-26 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/47/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Jul 2016 07:15:11 +
Build duration: 13 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2289/3359 
(68%)CONDITIONAL 1556/3766 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 624/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 251/342 (73%)CONDITIONAL 
82/187 (44%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 47 - Fixed!

2016-07-26 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/47/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Jul 2016 07:15:11 +
Build duration: 13 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2289/3359 
(68%)CONDITIONAL 1556/3766 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 624/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 251/342 (73%)CONDITIONAL 
82/187 (44%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 16 - Fixed!

2016-07-26 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/16/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Jul 2016 07:15:07 +
Build duration: 8 min 35 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 16 - Fixed!

2016-07-26 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/16/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Jul 2016 07:15:07 +
Build duration: 8 min 35 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel