[Differential] [Request, 15 lines] D3195: Make task manager ignore events it can't handle
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Currently if I drag an item from widget explorer onto the panel and hover over most applets the applet will shift showing me a drop indicator when I can add the applet. However if I move over the task manager this doesn't work. This patch makes the taskmanager not intercept drop events that are not related to the task manager, URLs or internal drops, so that adding applets works correctly. TEST PLAN Dropped a file on kate, still opened Set ordering to manual, still could shuffle things Dragged an item from widget explorer over the task manager, it showed a drop indicator either side and appeared there when dropped. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3195 AFFECTED FILES applets/taskmanager/package/contents/ui/MouseHandler.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: macro_bool_to_01 macro in plasma-workspace/ConfigureChecks.cmake
On Friday October 28 2016 20:24:10 Martin Gräßlin wrote: >Am 2016-10-28 19:25, schrieb René J.V. Bertin: >Sorry, I think there was a misunderstanding. I checked all the variables >set by macro_bool_to_01 in ConfigureChecks.cmake. In other files it's >not used. Indeed, and no, that wasn't what I meant :) Cheers, René
Re: macro_bool_to_01 macro in plasma-workspace/ConfigureChecks.cmake
Am 2016-10-28 19:25, schrieb René J.V. Bertin:
On Friday October 28 2016 14:00:54 Martin Graesslin wrote:
Hi,
I wouldn't exclude the possibility that this is old and
dead/non-functional
code. I just did a git grep for every of the CMake variables se
through the
macro_bool_to_01 and only found:
dataengines/mouse/CMakeLists.txt:if (X11_Xfixes_FOUND)
dataengines/mouse/CMakeLists.txt:if (X11_Xfixes_FOUND)
dataengines/mouse/CMakeLists.txt:
target_link_libraries(plasma_engine_mouse ${X11_Xfixes_LIB})
And in ConfigureChecks.cmake, which is the file generating the error
for me in 5.8.2 . It didn't before, which made me think that somehow
cmake picked up the definition elsewhere, in code that has now been
modernised.
Sorry, I think there was a misunderstanding. I checked all the variables
set by macro_bool_to_01 in ConfigureChecks.cmake. In other files it's
not used.
Cheers
Martin
Re: Breakout: 10 minute test
What for me is also now confuse is that most config stuff is in syse but some not. E.g. network manager, desktop wallpaper I know there are technical reasons, but I didn't understand that when I don't use activities (one function that is nowhere described what it is used for, and hidden by default) I can't config the desktop in syse. And when I use activities why I can't have one tab for each desktop setting activity. When there is a single place for setting the config should be there. I played a lot of nights with syse but I didn't understand it after this long time. Volume control is available Andreas
Re: Breakout: 10 minute test
On the other hand when we give the user some stuff to do. Most user will start with the windows way and say it doesn`t work cause its not the same than in win. I for example want switch to win10 cause it will fail the 10min test. So we have to shaw also in the first 10 min why kde is awesome too. I think one issue should be remove not working stuff from the default installation. Also stuff where the benefit isn`t clear for beginners should be only available if the user want to install it by themself. Example: kio is awesome but it is very hidden in your file manager, but in system settings there are several entries only for kio. If it's an unique selling point show it everywhere, if is hidden in dolphin it should be hidden in syse too. Andreas
Review Request 129276: Make sure we're looking both for json and desktop metadata
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129276/ --- Review request for Plasma. Repository: plasma-workspace Description --- We shouldn't assume metadata is in metadata.desktop Diffs - shell/containmentconfigview.cpp 4c9d146 shell/scripting/scriptengine_v1.cpp 23cb839 wallpapers/image/backgroundlistmodel.cpp b30d86d wallpapers/image/image.cpp 0a65b7d Diff: https://git.reviewboard.kde.org/r/129276/diff/ Testing --- Tests pass, all plasma desktop loads properly, even if I remove `.config/plasma-org.kde.plasma.desktop-appletsrc` Thanks, Aleix Pol Gonzalez
Review Request 129278: Don't reparse the metadata file if it's already loaded
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129278/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- By doing so, we don't tie ourselves to the desktop format as well as we leverage cached data. Diffs - src/plasma/package.h 6687ed0 src/plasma/package.cpp ada6a80 src/plasma/packagestructure/packages.cpp a138dd9 src/scriptengines/qml/plasmoid/wallpaperinterface.cpp 9ef2d03 Diff: https://git.reviewboard.kde.org/r/129278/diff/ Testing --- Tests pass, all plasma desktop loads properly, even if I remove `.config/plasma-org.kde.plasma.desktop-appletsrc` Thanks, Aleix Pol Gonzalez
Review Request 129279: Make sure we're looking both for json and desktop metadata
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129279/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Description --- We shouldn't assume metadata is in metadata.desktop Diffs - src/kpackage/package.cpp 274185d Diff: https://git.reviewboard.kde.org/r/129279/diff/ Testing --- Tests pass, all plasma desktop loads properly, even if I remove `.config/plasma-org.kde.plasma.desktop-appletsrc` Thanks, Aleix Pol Gonzalez
Re: macro_bool_to_01 macro in plasma-workspace/ConfigureChecks.cmake
On Friday October 28 2016 14:00:54 Martin Graesslin wrote:
Hi,
>>I wouldn't exclude the possibility that this is old and dead/non-functional
>code. I just did a git grep for every of the CMake variables se through the
>macro_bool_to_01 and only found:
>dataengines/mouse/CMakeLists.txt:if (X11_Xfixes_FOUND)
>dataengines/mouse/CMakeLists.txt:if (X11_Xfixes_FOUND)
>dataengines/mouse/CMakeLists.txt:
>target_link_libraries(plasma_engine_mouse ${X11_Xfixes_LIB})
And in ConfigureChecks.cmake, which is the file generating the error for me in
5.8.2 . It didn't before, which made me think that somehow cmake picked up the
definition elsewhere, in code that has now been modernised.
Cheers,
René
[Differential] [Updated] D3188: Modified distance function to keep aspect ratio as close as possible
antlarr marked 3 inline comments as done. antlarr added a comment. Converted the test to use QTest REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3188 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Accepted] D3131: Show full scrollbar only on mouse over
hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Ship it ! thanks REPOSITORY rBREEZE Breeze BRANCH arcpatch-D3131 REVISION DETAIL https://phabricator.kde.org/D3131 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, #breeze, #vdg, hpereiradacosta Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas
[Differential] [Updated, 173 lines] D3188: Modified distance function to keep aspect ratio as close as possible
antlarr updated this revision to Diff 7737. antlarr added a comment. - Converted the test to use QTest REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3188?vs=7719&id=7737 BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D3188 AFFECTED FILES wallpapers/image/CMakeLists.txt wallpapers/image/image.cpp wallpapers/image/image.h wallpapers/image/testfindpreferredimage.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: Breakout: UI and user vision for cloud services
On Fri, Oct 28, 2016 at 5:00 AM, Martin Klapetek wrote: > On Wed, Oct 19, 2016 at 4:54 AM, Elvis Angelaccio > wrote: >> >> >> Hi Martin, >> I'm planning to integrate KAccounts with kio-gdrive, so your email is >> very much appreciated. >> What exactly is "Kaccounts" in the first place? Are we talking about >> the kaccounts-integration repo? > > > KAccounts is basically just the KDE UI for the Accounts-SSO system. > It's a collection of KCM, which allows you to manage those accounts > and also KDED daemon which allows to load custom plugins that > react on those account changes and/or service changes (each account > has a set of services). > > So for example, in the KCM you add a Google account and then the > KDED module is notified of this and it will pass this info to all its loaded > plugins. The plugins would then check if the account is of interest and if > yes, then do something, like set up the calendar integration, for example. > > The KDED module also watches for services change, so eg. if in the > KCM you disable the calendar service, the Google plugin would disable > the calendar (but not remove). At least that's the idea. > > In the case of the kio-gdrive, I'm not sure if you'd need such plugin at > all. > I mean, if you don't need to configure anything, then you won't. You can > just query the credentials data from KAccounts directly from the kio. Thanks for the detailed reply. Yes, the slave just needs an account name + tokens for the OAuth thing. It looks like GetCredentialsJob (thanks @Aleix!) might be exactly what kio-gdrive needs. Cheers, Elvis > >> >> A tutorial would be great, but maybe is enough to look at the KDE >> Telepathy usage. Could you share more details about this? > > > KDE Telepathy is a bit special case. It builds a lot on the existing > upstream > code, which is basically a Mission Control plugin that does exactly what the > KDED is doing. Ie. there is no KTp KDED plugin, this is all handled by > Telepathy > itself. > > I'd recommend looking at the kaccounts-mobile repo, which has some code > for ownCloud stuff, like importing CardDAV contacts iirc. > > Cheers > -- > Martin Klapetek
[Differential] [Updated, 162 lines] D3131: Show full scrollbar only on mouse over
mart updated this revision to Diff 7736. mart added a comment. - adress comments REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3131?vs=7725&id=7736 BRANCH arcpatch-D3131 REVISION DETAIL https://phabricator.kde.org/D3131 AFFECTED FILES kstyle/animations/breezescrollbardata.cpp kstyle/animations/breezescrollbardata.h kstyle/breeze.kcfg kstyle/breezestyle.cpp kstyle/config/breezestyleconfig.cpp kstyle/config/ui/breezestyleconfig.ui EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, #breeze, #vdg, hpereiradacosta Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas
[Differential] [Updated] D3192: The combobox needs to be 2 pixels wider for contents to fit
antlarr added a reviewer: Plasma: Design. antlarr added a project: Plasma: Design. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3192 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #plasma, #plasma:_design Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, htietze, sebas
[Differential] [Commented On] D3191: guard against dataengine missing
davidedmundson added a comment. So why is PluginLoader::loadDataEngine returning something? REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3191 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 3 lines] D3192: The combobox needs to be 2 pixels wider for contents to fit
antlarr created this revision. antlarr added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When the size of the combo box adjusts to its contents, the dropdown listbox isn't large enough to fit the contents and a vertical scrollbar so instead of using Metrics::MenuButton_IndicatorWidth. I defined a new Metrics::ComboBox_IndicatorWidth which is two pixels larger than Metrics::MenuButton_IndicatorWidth. To test this I used "kcmshell5 kcm_kscreen -style breeze" and opened the resolutions QComboBox (If there are less than 15 possible resolutions, a slider will appear instead of a QComboBox, so in that case it's possible to use a virtual machine with QXL video that for me shows plenty of possible resolutions). Before this patch, most of the larger resolutions are shortened to something like "192...200" or "160...200" and can't be read (in the dropdown listbox, when selected they can be read correctly in the closed combobox), after applying this patch, all the contents of the listbox can be read correctly. REPOSITORY rBREEZE Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D3192 AFFECTED FILES kstyle/breeze.h kstyle/breezestyle.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3188: Modified distance function to keep aspect ratio as close as possible
antlarr added inline comments. INLINE COMMENTS > mart wrote in image.cpp:196 > dead code The commented out qDebug a couple of lines below shows that variable (when uncommented). Should I remove it from the qDebug line below? or just keep both? (the same for the case above) > mart wrote in testfindpreferredimage.cpp:90 > good that a test has been added! > but instead of doing all of this manually, couldn't it use qt autotest stuff, > qcompare, qtest etc? I never used QTest before and I thought about that but preferred to do it as fast as possible. I guess I'll have to write it anyway :) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3188 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 46 lines] D3191: guard against dataengine missing
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY this should never happen, but weird distribution packaging policies can make this happen. At least don't crash the whole sesison CCBUG:371779 TEST PLAN with dataengine present still works, with dataengine plugin delteted it still load without crashing, even if broken REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH phab/checkengine REVISION DETAIL https://phabricator.kde.org/D3191 AFFECTED FILES applets/comic/comic.cpp applets/comic/comicmodel.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3131: Show full scrollbar only on mouse over
hpereiradacosta added a comment.
Just added a couple of comments inline.
Also, (and somewhat out of topic), playing with the scrollbar width is rather
easy: just change
ScrollBar_Extend,
ScrollBar_SliderWidth,
ScrollBar_MinSliderHeight
In breeze.h
I experienced with using 14, 6 and 6 for these dimensions, and the result is
quite pleasing I think (6 is the progressbar groove width).
Feel free to commit this in a separate post if vdg is happy about it.
Now making this configurable is a complete different story, and in fact it is
in "todo list" because ultimately, I think we want a slim (or compact) mode for
breeze, to please people who complain about it wasting too much space.
(but this is completely out of topic :))
INLINE COMMENTS
> breezescrollbardata.h:109
> addLineAnimation().data()->setDuration( duration );
> subLineAnimation().data()->setDuration( duration );
> }
Here you miss a grooveAnimation().data()->setDuration( duration );
This makes sure that the groove animation is also updated "on fly" when
animation durations is changed (otherwise the change is only taken into account
for newly created scrollbars)
> breezestyle.cpp:4964
> const qreal opacity( _animations->scrollBarEngine().opacity( widget,
> SC_ScrollBarSlider ) );
> +QColor color = _helper->scrollBarHandleColor( palette, mouseOver,
> hasFocus, opacity, mode );
>
can be made a const again, right ?
> breezestyle.cpp:4966
>
> -const QColor color( _helper->scrollBarHandleColor( palette,
> mouseOver, hasFocus, opacity, mode ) );
> -_helper->renderScrollBarHandle( painter, handleRect, color );
> +if( StyleConfigData::scrollBarShowOnMouseOver() ) {
> +// finally, global opacity when ScrollBarShowOnMouseOver
this entire block can go, right ?
In fact my compiler complains about unused variable
> breezestyle.cpp:6374
> +
> +if (opacity == -1) opacity = 1;
>
you could use AnimationData::OpacityInvalid instead of -1
REPOSITORY
rBREEZE Breeze
REVISION DETAIL
https://phabricator.kde.org/D3131
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas
[Differential] [Commented On] D3131: Show full scrollbar only on mouse over
hpereiradacosta added a comment. In https://phabricator.kde.org/D3131#59314, @hpereiradacosta wrote: > Just added a couple of comments inline. > Also, (and somewhat out of topic), playing with the scrollbar width is rather easy: just change > > ScrollBar_Extend, > ScrollBar_SliderWidth, > ScrollBar_MinSliderHeight > > In breeze.h > I experienced with using 14, 6 and 6 for these dimensions, and the result is quite pleasing I think (6 is the progressbar groove width). In fact, 16, 6, 12 is better. A 6x6 handle is pretty hard to hit otherwise. And 16 for the width feels more confortable. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3131 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, #breeze, #vdg, hpereiradacosta Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas
[Differential] [Updated, 381 lines] D3089: Restore global menu support
broulik retitled this revision from "WIP: Restore global menu support" to "Restore global menu support". broulik updated this revision to Diff 7732. broulik added a comment. Restricted Application edited projects, added KWin; removed Plasma. - Rebase to QtPlatformSupport cmake changes - cannot test with Qt 5.8 - Ship a copy of kappmenu.xml REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3089?vs=7730&id=7732 REVISION DETAIL https://phabricator.kde.org/D3089 AFFECTED FILES CMakeLists.txt abstract_client.cpp abstract_client.h appmenu.cpp appmenu.h atoms.cpp atoms.h client.cpp client.h decorations/decoratedclient.cpp decorations/decoratedclient.h events.cpp kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp kcmkwin/kwindecoration/declarative-plugin/previewclient.h manage.cpp org.kde.kappmenu.xml shell_client.cpp shell_client.h useractions.cpp workspace.cpp workspace.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Closed] D3190: [effects/translucency] Cancel existing animations before starting new
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN94c5704af74d: [effects/translucency] Cancel existing animations before starting new (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3190?vs=7724&id=7731 REVISION DETAIL https://phabricator.kde.org/D3190 AFFECTED FILES autotests/integration/effects/translucency_test.cpp effects/translucency/package/contents/code/main.js EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Accepted] D3120: [kwineffects] Add hide/show cursor to EffectsHandler
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH effects-show-hide-cursor REVISION DETAIL https://phabricator.kde.org/D3120 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, mart Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Accepted] D3168: Use microphone volume icon for capture devices/streams in applet
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D3168 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, #plasma:_design, mart Cc: andreaska, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Requested Changes To] D3188: Modified distance function to keep aspect ratio as close as possible
mart requested changes to this revision. mart added a reviewer: mart. This revision now requires changes to proceed. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3188 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Changed Subscribers] D3188: Modified distance function to keep aspect ratio as close as possible
mart added inline comments. INLINE COMMENTS > image.cpp:186 > > -//qDebug() << "wanted" << m_targetSize << "options" << images; > - > -// choose the nearest resolution, always preferring images with the same > aspect ratio > +//float targetAspectRatio = (m_targetSize.height() > 0 ) ? > m_targetSize.width() / (float)m_targetSize.height() : 0; > +//qDebug() << "wanted" << m_targetSize << "options" << images << "aspect > ratio" << targetAspectRatio; remove dead code > image.cpp:196 > } > -float candidateAspectRatio = > candidate.width()/(float)candidate.height(); > +//float candidateAspectRatio = (candidate.height() > 0 ) ? > candidate.width() / (float)candidate.height() : FLT_MAX; > dead code > testfindpreferredimage.cpp:90 > + total++; > + if (preferred != expected) failed++; > + std::cout << "For a screen size of " << > qPrintable(formatResolution(resolution)) good that a test has been added! but instead of doing all of this manually, couldn't it use qt autotest stuff, qcompare, qtest etc? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3188 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #plasma Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Changed Subscribers] D3086: RFC: Clean up KAppMenu
graesslin added inline comments.
INLINE COMMENTS
> appmenu.cpp:88-89
> +auto setWindowProperty = [c](WId id, const QByteArray &name, const
> QByteArray &value) {
> +const xcb_intern_atom_cookie_t cookie = xcb_intern_atom(c,
> false, name.length(), name.constData());
> +QScopedPointer QScopedPointerPodDeleter> reply(xcb_intern_atom_reply(c, cookie, Q_NULLPTR));
> +if (!reply.isNull()) {
This causes a roundtrip every time it gets invoked. I suggest to cache the
returned atom. You can just do something like:
xcb_atom_t myAtom = XCB_ATOM_NONE;
if(myAtom == XCB_ATOM_NONE) {
// cookie-reply-dance
myAtom = reply->atom;
}
if (myAtom == XCB_ATOM_NONE) {
// whoops something failed with fetching the atom
return;
}
xcb_change_property()
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3086
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, mart
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas
[Differential] [Commented On] D3085: RFC: Use DBusMenu if available
graesslin added inline comments.
INLINE COMMENTS
> CMakeLists.txt:10-13
> + find_package(XCB COMPONENTS XCB)
> + set_package_properties(XCB PROPERTIES DESCRIPTION "Required for exposing
> the global menu on X11"
> + TYPE REQUIRED
> +)
HAVE_X11 is just trying to find XLib. There is no need to bind find XCB to find
XLib. You can just move it out of the if.
Also the HAVE_X11 is I think wrong, but that's unrelated ;-)
> CMakeLists.txt:62
> if(HAVE_X11)
> - target_link_libraries(KDEPlasmaPlatformTheme PRIVATE Qt5::X11Extras
> ${X11_Xcursor_LIB})
> + target_link_libraries(KDEPlasmaPlatformTheme PRIVATE Qt5::X11Extras
> ${X11_Xcursor_LIB} ${XCB_XCB_LIBRARY})
> endif()
XCB::XCB
> kdeplatformtheme.cpp:115
> +case QEvent::ApplicationStateChange:
> +// FIXME isn't actually triggered when engaging Alt+left-click
> window moving
> +m_timer->stop();
Maybe FocusOut delivers it?
> x11integration.cpp:59-60
> +
> +const xcb_intern_atom_cookie_t cookie = xcb_intern_atom(c, false,
> name.length(), name.constData());
> +QScopedPointer
> reply(xcb_intern_atom_reply(c, cookie, Q_NULLPTR));
> +if (!reply.isNull()) {
can we cache the atom? That's causing a roundtrip every time it's invoked.
REPOSITORY
rPLASMAINTEGRATION Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D3085
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas
[Differential] [Updated, 483 lines] D3089: WIP: Restore global menu support
broulik updated the test plan for this revision. broulik updated this revision to Diff 7730. broulik added a comment. Restricted Application edited projects, added Plasma; removed KWin. - Cleanup a bit - Listen to menuShown signal rather than assuming a showMenu call will be successful - Listen to showRequest signal when an application wants the menu to show - Implement Wayland support REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3089?vs=7664&id=7730 REVISION DETAIL https://phabricator.kde.org/D3089 AFFECTED FILES CMakeLists.txt abstract_client.cpp abstract_client.h appmenu.cpp appmenu.h atoms.cpp atoms.h client.cpp client.h cmake/modules/FindQt5PlatformSupport.cmake decorations/decoratedclient.cpp decorations/decoratedclient.h events.cpp kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp kcmkwin/kwindecoration/declarative-plugin/previewclient.h manage.cpp plugins/qpa/CMakeLists.txt shell_client.cpp shell_client.h useractions.cpp workspace.cpp workspace.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3166: make sure containment actions config is up to date
mart added a comment. In https://phabricator.kde.org/D3166#59071, @davidedmundson wrote: > It's still a bodge round broken user code. it is, but the thing is, that's the way is supported by the api right now, and there are users for it, so it has to work, regardless if it's quite ugly. i can't really see much other ways, either that or put a watcher on the config update... REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3166 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D3151: Trigger resize of input window when deco size changes
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN2e3c6c92e94e: Trigger resize of input window when deco size changes (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3151?vs=7634&id=7728 REVISION DETAIL https://phabricator.kde.org/D3151 AFFECTED FILES client.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma, mart Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Closed] D3186: Ensure the complete decoration texture gets repainted on recreation
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN37067f538ec0: Ensure the complete decoration texture gets repainted on recreation (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3186?vs=7716&id=7729 REVISION DETAIL https://phabricator.kde.org/D3186 AFFECTED FILES scene_opengl.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Updated, 2,660 lines] D3086: RFC: Clean up KAppMenu
broulik updated the summary for this revision. broulik updated this revision to Diff 7727. broulik added a comment. - Remove GtkIcons, it's not like GTK applications support this stuff anymore... - Introduce showMenu signal so KWin can reliably know whether the menu actually showed (sometimes when the menu doesn't show up for reasons, KWin would get stuck thinking it's open, so we explicitly emit a signal when we popup'd the menu) - Listen to ItemActivationRequested signal we emit in Plasma-Integration, when called with 0,0 arguments we emit a generic "show menu" request - Re-introduce Unity about to show hack but it doesn't actually fix the situation with Firefox for me :/ REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3086?vs=7572&id=7727 REVISION DETAIL https://phabricator.kde.org/D3086 AFFECTED FILES appmenu/CMakeLists.txt appmenu/appmenu.cpp appmenu/appmenu.h appmenu/appmenu_dbus.cpp appmenu/appmenu_dbus.h appmenu/glowbar.cpp appmenu/glowbar.h appmenu/gtkicons.h appmenu/kdbusimporter.h appmenu/menubar.cpp appmenu/menubar.h appmenu/menubutton.cpp appmenu/menubutton.h appmenu/menuimporter.cpp appmenu/menuimporter.h appmenu/menuwidget.cpp appmenu/menuwidget.h appmenu/org.kde.kappmenu.xml appmenu/shadows.cpp appmenu/shadows.h appmenu/topmenubar.cpp appmenu/topmenubar.h appmenu/verticalmenu.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Accepted] D3151: Trigger resize of input window when deco size changes
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH input-window-maximize-5.8 REVISION DETAIL https://phabricator.kde.org/D3151 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma, mart Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Updated] D3085: RFC: Use DBusMenu if available
graesslin added a comment. you will need the change from https://phabricator.kde.org/rKWIN052fa2e4ee329810f62c29e546254fb45bf8a375 as well I fear. Otherwise it won't compile with Qt 5.8. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D3085 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated, 1,679 lines] D3085: RFC: Use DBusMenu if available
broulik updated the summary for this revision. broulik updated the test plan for this revision. broulik updated this revision to Diff 7726. broulik added a comment. - Move setWindowProperty to x11/wayland integration to unclutter the code a bit - Adds an Alt key listener which, on long-pressing Alt, will activate the menu of the active window. This only works in QApplications with a QMainWindow, I'm open to suggestions how to improve this. Also, Alt+left-click for moving around the window still causes the timer to fire REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3085?vs=7652&id=7726 REVISION DETAIL https://phabricator.kde.org/D3085 AFFECTED FILES CMakeLists.txt COPYING.LGPL-2 COPYING.LGPL-3 COPYING.LIB autotests/CMakeLists.txt src/platformtheme/CMakeLists.txt src/platformtheme/kdeplatformtheme.cpp src/platformtheme/kdeplatformtheme.h src/platformtheme/kwaylandintegration.cpp src/platformtheme/kwaylandintegration.h src/platformtheme/qdbusmenubar.cpp src/platformtheme/qdbusmenubar_p.h src/platformtheme/x11integration.cpp src/platformtheme/x11integration.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated, 168 lines] D3131: Show full scrollbar only on mouse over
mart updated this revision to Diff 7725. mart added a comment. - try harder to figure out the widget is under mouse when drawing the arrow we can't know if the widget is under mouse by the style option, and we can't access the widget when using the qstyle over QML, so check either the widget if is there or a property in the styleObject in the case of QML. this also fixes arrows visibility when animations are disabled REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3131?vs=7720&id=7725 BRANCH arcpatch-D3131 REVISION DETAIL https://phabricator.kde.org/D3131 AFFECTED FILES kstyle/animations/breezescrollbardata.cpp kstyle/animations/breezescrollbardata.h kstyle/breeze.kcfg kstyle/breezestyle.cpp kstyle/config/breezestyleconfig.cpp kstyle/config/ui/breezestyleconfig.ui EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, #breeze, #vdg, hpereiradacosta Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas
[Differential] [Accepted] D3190: [effects/translucency] Cancel existing animations before starting new
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH effects-translucency-cancel-animations-5.8 REVISION DETAIL https://phabricator.kde.org/D3190 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3131: Show full scrollbar only on mouse over
mart added a comment. In https://phabricator.kde.org/D3131#59229, @hpereiradacosta wrote: > > also should be minimized since iirc their intention is also to make the scrollbar a bit slimmer by default (painted around as wide as progressbars, maybe still with wider blank working mouse area but overall smaller > > Just for my curiosity, where do these VDG discussions take place these days ? IRC ? mostly Telegram https://telegram.me/vdgmainroom relayed on irc too on #kde-vdg channel REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3131 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, #breeze, #vdg, hpereiradacosta Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas
[Differential] [Request, 6 lines] D3190: [effects/translucency] Cancel existing animations before starting new
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY It can happen that startAnimation is invoked multiple times for a window. In case it was invoked a second time the previous animation was not cancelled. This resulted in the set-animation to never end. When closing a window, it would stay around as a translucent, non-interactive window zombie. This change ensures that existing animations get cancelled. BUG: 342716 FIXED-IN: 5.8.3 TEST PLAN Tested through autotest and manually. REPOSITORY rKWIN KWin BRANCH effects-translucency-cancel-animations-5.8 REVISION DETAIL https://phabricator.kde.org/D3190 AFFECTED FILES autotests/integration/effects/translucency_test.cpp effects/translucency/package/contents/code/main.js EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3131: Show full scrollbar only on mouse over
hpereiradacosta added a comment. > also should be minimized since iirc their intention is also to make the scrollbar a bit slimmer by default (painted around as wide as progressbars, maybe still with wider blank working mouse area but overall smaller Just for my curiosity, where do these VDG discussions take place these days ? IRC ? REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3131 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, #breeze, #vdg, hpereiradacosta Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas
[Differential] [Commented On] D3131: Show full scrollbar only on mouse over
mart added a comment. In https://phabricator.kde.org/D3131#59205, @mart wrote: > In https://phabricator.kde.org/D3131#59202, @hpereiradacosta wrote: > > > 3/ I agree that the animation looks good on views like dolphin and systemsettings. However for views with a header, or when you have both vertical and horizontal bars it looks stranger . But this is a matter of taste > > > yeah, asked about this concern back them to vdg, they say basically that yeah, it's not that pretty, but better than nothing also should be minimized since iirc their intention is also to make the scrollbar a bit slimmer by default (painted around as wide as progressbars, maybe still with wider blank working mouse area but overall smaller REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3131 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, #breeze, #vdg, hpereiradacosta Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas
[Differential] [Commented On] D3131: Show full scrollbar only on mouse over
hpereiradacosta added a comment. Awesome ! I just need some more time to look at the code, but as far as the visual aspect is concerned, I think its pretty cool. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3131 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, #breeze, #vdg, hpereiradacosta Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas
[Differential] [Commented On] D3131: Show full scrollbar only on mouse over
mart added a comment. In https://phabricator.kde.org/D3131#59202, @hpereiradacosta wrote: > Hi Marco, > > Couple of comments on the look of it > > 1/ if you set the animation time to somehting long (500ms), then hover on a scrollbar, in the groove, and not on the handle, while making sure that the view in which you hove does not have focus, in order to make sure that the handle is painted grey, not blue (either focus blue or hover blue), there is a glitch at the end of the animation where a somewhat too dark grey jumps to a lighter one. Must be some problem with transparency. Can you confirm, double check ? I 'think' this is also the case when you mouse-over the handle but this is less clear. that was because while animating the handle was drawn 2 times one on top of each other (as in the beginning the non mouse over was slimmer), now it just paints the same one, so it also has the proper color (blue on focus) REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3131 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, #breeze, #vdg, hpereiradacosta Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas
Re: macro_bool_to_01 macro in plasma-workspace/ConfigureChecks.cmake
On Friday, October 28, 2016 11:24:35 AM CEST René J.V. Bertin wrote:
> Hi,
>
> Where exactly is plasma-workspace's build system supposed to find the
> macro_bool_to_01 macro? Apparently it's been obsolete for quite some time
> and it doesn't seem to be provided by any of the listed dependencies (= I
> get a not-found error).
I wouldn't exclude the possibility that this is old and dead/non-functional
code. I just did a git grep for every of the CMake variables se through the
macro_bool_to_01 and only found:
dataengines/mouse/CMakeLists.txt:if (X11_Xfixes_FOUND)
dataengines/mouse/CMakeLists.txt:if (X11_Xfixes_FOUND)
dataengines/mouse/CMakeLists.txt:
target_link_libraries(plasma_engine_mouse ${X11_Xfixes_LIB})
and that code while having it in the CMakeLists being used uses in the code
#ifdef HAVE_XFIXES
(which is wrong, should be #if HAVE_XFIXES)
So overall looks rather dead to me.
Cheers
Martin
signature.asc
Description: This is a digitally signed message part.
[Differential] [Updated, 162 lines] D3131: Show full scrollbar only on mouse over
mart updated this revision to Diff 7720. mart added a comment. - don't draw the handle separatedly REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3131?vs=7701&id=7720 BRANCH arcpatch-D3131 REVISION DETAIL https://phabricator.kde.org/D3131 AFFECTED FILES kstyle/animations/breezescrollbardata.cpp kstyle/animations/breezescrollbardata.h kstyle/breeze.kcfg kstyle/breezestyle.cpp kstyle/config/breezestyleconfig.cpp kstyle/config/ui/breezestyleconfig.ui EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, #breeze, #vdg, hpereiradacosta Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas
[Differential] [Commented On] D3188: Modified distance function to keep aspect ratio as close as possible
antlarr added inline comments. INLINE COMMENTS > testfindpreferredimage.cpp:91 > + if (preferred != expected) failed++; > + std::cout << "For a screen size of " << > qPrintable(formatResolution(resolution)) > + << " the " << qPrintable(formatResolution(preferred)) << " > wallpaper was preferred: " I'll fix indentation around all the file in the next commit. But I'll wait to see if there's any other change to make REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3188 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 172 lines] D3188: Modified distance function to keep aspect ratio as close as possible
antlarr created this revision. antlarr added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This new version of the distance function simplifies the findPreferredImageInPackage method by using the aspect ratio in the calculation. Now, it won't only search for a wallpaper with the same aspect ratio, but will also choose one with the closest possible aspect ratio when a perfect match is not found. Also, I separated the method that chooses the preferred image to not use KPackage in order to use it from a test application that tests the distance algorithm with all possible resolutions. Test application that tests the Image::findPreferredImage method The test initializes a list of available wallpaper image sizes, then a list of screen resolutions, and then executes Image::findPreferredImage to find out which is the preferred image in each case. TEST PLAN I tested with different screen resolutions on a virtual machine with openSUSE Leap 42.2 RC1 and also included a commit that adds a test application (not built by default) that tests all possible resolutions. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D3188 AFFECTED FILES wallpapers/image/CMakeLists.txt wallpapers/image/image.cpp wallpapers/image/image.h wallpapers/image/testfindpreferredimage.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3131: Show full scrollbar only on mouse over
mart added a comment. In https://phabricator.kde.org/D3131#59202, @hpereiradacosta wrote: > Hi Marco, > > Couple of comments on the look of it > > 1/ if you set the animation time to somehting long (500ms), then hover on a scrollbar, in the groove, and not on the handle, while making sure that the view in which you hove does not have focus, in order to make sure that the handle is painted grey, not blue (either focus blue or hover blue), there is a glitch at the end of the animation where a somewhat too dark grey jumps to a lighter one. Must be some problem with transparency. Can you confirm, double check ? I 'think' this is also the case when you mouse-over the handle but this is less clear. yes, can reproduce, looking into that > 2/ I wonder whether the unhovered scrollbar of a focused view should use the focus blue for the handle (as it is now, without your change), instead of light grey. I at least was using is somewhat strong blue to easily catch the view that have focus, instead of the much more subtle blue outline. What do you think ? for me either way is fine, would like also vdg opinion on it > 3/ I agree that the animation looks good on views like dolphin and systemsettings. However for views with a header, or when you have both vertical and horizontal bars it looks stranger . But this is a matter of taste yeah, asked about this concern back them to vdg, they say basically that yeah, it's not that pretty, but better than nothing > 4/ finally, I had this crazy idea :) > What if ... instead of making the groove "fade-in" on hover, we would make it "expand" vertically, from around the handle ? as if it would appear from under the handle and grow to ocupy the full height of the view ? Do you think it could look cool ? may be cool.. (or also look a bit too jumpy) one thing, since i'm writing a qstyle-based theme for QtQuickControls2, this would make it harder to replicateon that weird qml/qstyle hybrid REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3131 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, #breeze, #vdg, hpereiradacosta Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas
[Differential] [Commented On] D3131: Show full scrollbar only on mouse over
hpereiradacosta added a comment. Hi Marco, Couple of comments on the look of it 1/ if you set the animation time to somehting long (500ms), then hover on a scrollbar, in the groove, and not on the handle, while making sure that the view in which you hove does not have focus, in order to make sure that the handle is painted grey, not blue (either focus blue or hover blue), there is a glitch at the end of the animation where a somewhat too dark grey jumps to a lighter one. Must be some problem with transparency. Can you confirm, double check ? I 'think' this is also the case when you mouse-over the handle but this is less clear. 2/ I wonder whether the unhovered scrollbar of a focused view should use the focus blue for the handle (as it is now, without your change), instead of light grey. I at least was using is somewhat strong blue to easily catch the view that have focus, instead of the much more subtle blue outline. What do you think ? 3/ I agree that the animation looks good on views like dolphin and systemsettings. However for views with a header, or when you have both vertical and horizontal bars it looks stranger . But this is a matter of taste 4/ finally, I had this crazy idea :) What if ... instead of making the groove "fade-in" on hover, we would make it "expand" vertically, from around the handle ? as if it would appear from under the handle and grow to ocupy the full height of the view ? Do you think it could look cool ? REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3131 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, #breeze, #vdg, hpereiradacosta Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas
Re: Breakout: 10 minute test
On 10/28/2016 07:16 PM, Aleix Pol wrote: > Most issues we'd find are possibly already reported somewhere. There's a disconnect between "reported" and "developers are aware of it, and moreover its impact". > Aleix Cheers, Eike
Re: Breakout: 10 minute test
On Fri, Oct 28, 2016 at 10:35 AM, Marco Martin wrote: > On Friday 28 October 2016 03:01:47 Aleix Pol wrote: >> What do you have in mind? >> Are these things reported? >> Are the things all these people try the same things? >> >> It doesn't sound like a very stable metric to me. > > for this i fear the only good way is real life user testing, which > historically has been very hard to do for us (because it needs a pretty big > sample, so asking mom to use plasma for 10 minutes isn't that significative ;) > > i wonder how many people we can get to get filmed, maybe during pubic shows > where KDE has a booth using plasma (even preferably if is for the first time) > for 10 minutes? I'd say it's perfectly doable, the question is who is going to fix the issues that we found if at all. Most issues we'd find are possibly already reported somewhere. Aleix
Re: Breakout: UI and user vision for cloud services
On Wed, Oct 19, 2016 at 10:54 AM, Elvis Angelaccio wrote: > On Wed, Oct 19, 2016 at 5:17 AM, Martin Klapetek > wrote: >> On Mon, Oct 17, 2016 at 12:54 PM, Jonathan Riddell wrote: >>> >>> * Services integration - I see more and more users who have >>> data locked up in clouds (GDrive, etc.) and rely on accessing it >>> Gnome has GDrive integration, we need to do more on getting >>> cloud filesystems into our software too, but we dropped the ball on >>> KAccounts etc. for now >> >> >> As the former KAccounts maintainer, I'd like to share some insights on this. >> >> The tech is there. It's proven by real world usage in Ubuntu (incl. Phone), >> Meego before that (iirc) and to some extent also Gnome, which has its own >> fork of the same thing (I guess they just really don't like Qt anywhere). >> Also >> Elementary is using one of these, but I don't remember which. And if I'm >> not mistaken, also Jolla in their phones. >> >> So we have the tech, but what we're missing are two things, really. >> >> 1) Things actually using it. We've had KAccounts for a while but there was >> nothing taking advantage of it, except KDE Telepathy, which migrated fully >> to it. So it sort of became a synonym for KTp accounts config. On the other >> hand, there was nothing much else that would actually need it. There was >> an OwnCloud lib or Plasma thingy at some point where I pleaded to have the >> account setup done through (K)Accounts to boost the adoption, but it never >> happened. Related to that is... >> >> 2) Buy in from PIM. I mean, let's face it, the real accounts user in the >> system >> is PIM, with all the emails and calendars and contacts and what not. This >> obviously requires quite some large effort to actually migrate everything to >> it and sadly the PIM team is long time understaffed. Now with the new Sink >> thing, this could have been a chance, but, again, after asking couple times >> about the accounts plan, (K)Accounts was never in the picture. And that's >> a problem. >> >> And so now we have this system that nobody in/around KDE wants to use. >> My take on it is that people (devs) don't really understand how that system >> works and how to take advantage of it, which is partly my fault. It is >> fairly >> complex system on the inside with lots of points of possible breakages, but >> also allows for great flexibility all around. >> >> So, imho, in order to successfully follow literally every other desktop >> these >> days, it needs a proper full integration in all things using accounts. And >> it really >> shouldn't be just an afterthought. It needs to be put right at the core of >> those >> things and workflows should be redesigned to take that into account (heh). >> It >> needs to be a conscious community-wide effort, like Frameworks was. >> Otherwise >> KAccounts will stay exactly where it is now - a promising (egg-)shell that >> has no >> real use. >> >> Unfortunately if the past two years are any indication, especially with >> Sink, >> the road ahead is not very bright. >> >> I'm happy to try my best to answer any possible future questions about the >> system >> you might have. Friedrich Kossebau was also writing a tutorial about it at >> some >> point, but I'm not sure where it ended up (if at all; I also failed to >> follow up on that). > > > Hi Martin, > I'm planning to integrate KAccounts with kio-gdrive, so your email is > very much appreciated. > What exactly is "Kaccounts" in the first place? Are we talking about > the kaccounts-integration repo? > A tutorial would be great, but maybe is enough to look at the KDE > Telepathy usage. Could you share more details about this? Purpose Youtube integration is using it [1]. You can easily use the GetCredentialsJob for these things, or directly use AccountsSSO for less dependencies. Aleix [1] https://quickgit.kde.org/?p=purpose.git&a=blob&h=b0d08c489965a330dd140590856a7d802f5efaea&hb=a7be97ffd5610a27360eedf2938efc8be04ff5f4&f=src%2Fplugins%2Fyoutube%2Fyoutubejobcomposite.cpp
[Differential] [Accepted] D3186: Ensure the complete decoration texture gets repainted on recreation
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH fix-decoration-repaint-opengl-5.8 REVISION DETAIL https://phabricator.kde.org/D3186 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Request, 5 lines] D3186: Ensure the complete decoration texture gets repainted on recreation
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY When the decoration size changes the textures get recreated and need to be properly filled. So far KWin used the scheduled repaint geometry in this situation. If the decoration didn't schedule the complete geometry for repain there will be an empty area in the decoration texture. This change ensures that the complete texture gets repainted when they are recreated. Thus the decoration rendering is more fault tolerant towards potential bugs in the decoration. With no-compositing and XRender compositing this problem was not reproducable and already fault tolerant, so OpenGL just catches up with the other modes. BUG: 371735 FIXED-IN: 5.8.3 REPOSITORY rKWIN KWin BRANCH fix-decoration-repaint-opengl-5.8 REVISION DETAIL https://phabricator.kde.org/D3186 AFFECTED FILES scene_opengl.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
macro_bool_to_01 macro in plasma-workspace/ConfigureChecks.cmake
Hi, Where exactly is plasma-workspace's build system supposed to find the macro_bool_to_01 macro? Apparently it's been obsolete for quite some time and it doesn't seem to be provided by any of the listed dependencies (= I get a not-found error). Thanks, René
[Differential] [Updated] D3183: Port potd (picture of the day) dataengine to KF5.
mart added a comment.
code looks good.
I tested the urls, annotated inline those that work and those that don't.
Unfortunately there are still two that don't, in flickr, where a no longer
valid api key is used and the wikipedia one.
INLINE COMMENTS
> apodprovider.cpp:83
> {
> -KUrl url( QLatin1String( "http://antwrp.gsfc.nasa.gov/apod/"; ) );
> +QUrl url( QLatin1String( "http://antwrp.gsfc.nasa.gov/apod/"; ) );
> KIO::StoredTransferJob *job = KIO::storedGet( url, KIO::NoReload,
> KIO::HideProgressInfo );
works, +1
> epodprovider.cpp:82
> {
> -KUrl url( QLatin1String( "http://epod.usra.edu/blog/"; ) );
> +QUrl url( QLatin1String( "http://epod.usra.edu/blog/"; ) );
> KIO::StoredTransferJob *job = KIO::storedGet( url, KIO::NoReload,
> KIO::HideProgressInfo );
this works, +1
> flickrprovider.cpp:81
>
> -KUrl url( QLatin1String(
> "http://api.flickr.com/services/rest/?api_key=a902f4e74cf1e7bce231742d8ffb46b4&method=flickr.interestingness.getList&date=";
> ) + mActualDate.toString( Qt::ISODate) );
> +QUrl url( QLatin1String(
> "https://api.flickr.com/services/rest/?api_key=11829a470557ad8e10b02e80afacb3af&method=flickr.interestingness.getList&date=";
> ) + mActualDate.toString( Qt::ISODate) );
> KIO::StoredTransferJob *pageJob =
> KIO::storedGet(url, KIO::NoReload, KIO::HideProgressInfo);
this one is valid, same api key should be used in the other queries
> flickrprovider.cpp:129
> +QUrl url(QLatin1String(
> +
> "https://api.flickr.com/services/rest/?api_key=a902f4e74cf1e7bce231742d8ffb46b4&method=flickr.interestingness.getList&date=";
> ) + date().toString( Qt::ISODate ) );
says "key has expired",
should have 11829a470557ad8e10b02e80afacb3af instead?
> natgeoprovider.cpp:96
> {
> -const QUrl url( QLatin1String(
> "http://photography.nationalgeographic.com/photography/photo-of-the-day"; ) );
> +const QUrl url( QLatin1String(
> "https://www.nationalgeographic.com/photography/photo-of-the-day"; ) );
> connect( d->mPage, SIGNAL(loadFinished(bool)), this,
> SLOT(pageRequestFinished(bool)) );
works, +1
> noaaprovider.cpp:95
> {
> -const QUrl url( QLatin1String(
> "http://photography.nationalgeographic.com/photography/photo-of-the-day"; ) );
> +QUrl url( QLatin1String( "http://www.nnvl.noaa.gov/imageoftheday.php"; )
> );
> connect( d->mPage, SIGNAL(loadFinished(bool)), this,
> SLOT(pageRequestFinished(bool)) );
this one works, +1
> wcpotdprovider.cpp:54
>
> -KUrl picUrl( QLatin1String(
> "http://tools.wikimedia.de/~daniel/potd/potd.php/commons/800x600"; ) );
> KIO::StoredTransferJob *imageJob = KIO::storedGet( picUrl, KIO::NoReload,
> KIO::HideProgressInfo );
> +QUrl picUrl( QLatin1String(
> "http://tools.wikimedia.de/~daniel/potd/potd.php/commons/800x600"; ) );
> KIO::StoredTransferJob *imageJob = KIO::storedGet( picUrl, KIO::NoReload,
> KIO::HideProgressInfo );
> mParent->connect( imageJob, SIGNAL(finished(KJob*)),
> SLOT(imageRequestFinished(KJob*)) );
other copy of invalid url
> wcpotdprovider.cpp:73
> {
> -KUrl url( QLatin1String(
> "http://tools.wikimedia.de/~daniel/potd/potd.php/commons/800x600"; ));
> +QUrl url( QLatin1String(
> "http://tools.wikimedia.de/~daniel/potd/potd.php/commons/800x600"; ));
>
this url doesn't seem to be valid anymore
maybe should web-scrape
https://en.wikipedia.org/wiki/Wikipedia:Wikimedia_Commons/POTD ?
(don't know if there is a way to obtain directly the image)
REPOSITORY
rKDEPLASMAADDONS Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D3183
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: xuetianweng, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Accepted] D3184: Bring potd wallpaper back to life.
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D3184 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: Breakout: 10 minute test
On Friday, 28 October 2016 10:35:43 BST Marco Martin wrote: > On Friday 28 October 2016 03:01:47 Aleix Pol wrote: > > What do you have in mind? > > Are these things reported? > > Are the things all these people try the same things? > > > > It doesn't sound like a very stable metric to me. > > for this i fear the only good way is real life user testing, which > historically has been very hard to do for us (because it needs a pretty big > sample, so asking mom to use plasma for 10 minutes isn't that significative > ;) While the sample size might be small, any amount of testing like that would still show things that we, quite simply, don't run into... The age-old issue of us simply having gotten used to those weird little things that happen, and us just working around them without thinking about it. Tests like this would very effectively show that :) > i wonder how many people we can get to get filmed, maybe during pubic shows > where KDE has a booth using plasma (even preferably if is for the first > time) for 10 minutes? This is a really great idea... Even at places like QtCon, i could see something like this being very useful. Perhaps fosdem as well... If a test setup could be made which fits in a backpack or similar, this could be something that... really could work well. Analysing the data would take effort as well, of course, but definitely this is something that would be worth it! -- ..dan / leinir.. http://leinir.dk/
Re: Breakout: 10 minute test
On Friday 28 October 2016 03:01:47 Aleix Pol wrote: > What do you have in mind? > Are these things reported? > Are the things all these people try the same things? > > It doesn't sound like a very stable metric to me. for this i fear the only good way is real life user testing, which historically has been very hard to do for us (because it needs a pretty big sample, so asking mom to use plasma for 10 minutes isn't that significative ;) i wonder how many people we can get to get filmed, maybe during pubic shows where KDE has a booth using plasma (even preferably if is for the first time) for 10 minutes? -- Marco Martin
