[Differential] [Closed] D3542: Remove outdated script for handling translations

[ltoscano (Luigi Toscano)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3cf44a9101e0: Remove outdated script for handling 
translations (authored by ltoscano).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3542?vs=8614&id=8616

REVISION DETAIL
  https://phabricator.kde.org/D3542

AFFECTED FILES
  kcms/touchpad/CMakeLists.txt
  kcms/touchpad/README.md
  kcms/touchpad/cmake/l10n-download.cmake
  kcms/touchpad/cmake/l10n.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ltoscano, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3538: Drop resize animation when adding pages

[jensreuterberg (Jens Reuterberg)]

jensreuterberg added a comment.


  Lovelly! <3
  
  The animations remaining feel way cleaner

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D3538

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: jensreuterberg, colomar, plasma-devel, apol

[Differential] [Accepted] D3542: Remove outdated script for handling translations

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3542

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ltoscano, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 91 lines] D3542: Remove outdated script for handling translations

[ltoscano (Luigi Toscano)]

ltoscano created this revision.
ltoscano added a reviewer: Plasma.
ltoscano added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  The files were relevant when the modules lived in its own repository.
  Translations are now included in the plasma-desktop tarball by the
  release scripts.
  
  The README.md contains some other outdated informations, but they are
  out of scope for this change.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3542

AFFECTED FILES
  kcms/touchpad/CMakeLists.txt
  kcms/touchpad/README.md
  kcms/touchpad/cmake/l10n-download.cmake
  kcms/touchpad/cmake/l10n.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ltoscano, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 107 lines] D3541: Introduce a first test for PageRow

[apol (Aleix Pol Gonzalez)]

apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Passes
  Makes sure that basic push and pop usage works.
  Makes sure that pressing the go back button has the desired effect

REPOSITORY
  R169 Kirigami

BRANCH
  mart/Kirigami2

REVISION DETAIL
  https://phabricator.kde.org/D3541

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/tst_pagerow.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

Re: [Technical Question] - How to trigger the applets actions menu from a second window of a Panel? (e.g. Now Dock 0.5)

[Michail Vourlakos]

   Plasma::Applet *applet = 0;
foreach (QObject *appletObject, m_appletInterfaces) {
if (AppletInterface *ai = qobject_cast*>(appletObject)) {
if (ai->isVisible() && ai->contains(ai->mapFromItem(this, 
event->posF( {

applet = ai->applet();
break;
} else {
ai = 0;
}
}
}

---

for the m_appletsInterfaces I can use the plasmoid.applets variable to 
get them but AppletInterface is not exposed in plasma library and I 
need it in order to get its applet()   ///Plasma::Applet





no worries about that, I solved this by accessing the 
PlasmaQuick::AppletQuickItem's ...

[Differential] [Commented On] D3538: Drop resize animation when adding pages

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  +1, definitely looks better to me (and Jens will love any killed animation, 
anyway ;) )

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D3538

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: colomar, plasma-devel, apol

[Differential] [Commented On] D3539: [Notifications] Show interactive thumbnails on notifications

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Really nice!
  The single thumbnail might be a bit too large, as having large notification 
windows pop up could be irritating. Maybe half the size would be big enough?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3539

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Technical Question] - How to trigger the applets actions menu from a second window of a Panel? (e.g. Now Dock 0.5)

[Michail Vourlakos]

Hello everyone,


A couple of days ago, in a discussion with plasma developers it was 
decided that Now Dock should better support window masking (for 
animations etc.) in a separate window than the main panel one. What is 
doing in the following 0.5 version is a technique based on a plasma 
mobile technique in which all the presentation of the plasmoids for the 
panel are done in a secondary window except on widgets unlocked state 
for which a reparenting is taken into place and the plasmoids are moved 
to original panel window in order for the user to be able to add, 
remove, move plasmoids etc... This has worked flawlessly and the 
animations and masking (transparent areas are allowing the mouse events 
to go to underneath windows) are working great.



But one small problem arose with this approach. The plasmoids when they 
are in the secondary window (in locked widgets state that is) do not 
show their menu with right-click. As it appears, I should provide that 
functionality from my c++ code but I have a problem, the code which is 
doing its magic is from containmentinterface.cpp:




   Plasma::Applet *applet = 0;
foreach (QObject *appletObject, m_appletInterfaces) {
if (AppletInterface *ai = qobject_cast*>(appletObject)) {
if (ai->isVisible() && ai->contains(ai->mapFromItem(this, 
event->posF( {

applet = ai->applet();
break;
} else {
ai = 0;
}
}
}

---

for the m_appletsInterfaces I can use the plasmoid.applets variable to 
get them but AppletInterface is not exposed in plasma library and I need 
it in order to get its applet()   ///Plasma::Applet



any ideas ???


regards,

michail

[Differential] [Updated] D3539: [Notifications] Show interactive thumbnails on notifications

[broulik (Kai Uwe Broulik)]

broulik updated the test plan for this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3539

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 328 lines] D3539: [Notifications] Show interactive thumbnails on notifications

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When a notification contains URLs, they will be shown as a large preview (in 
case of one thumbnail) or multiple in a strip (similar to what Klipper does).
  
  The previews can be clicked to open the file and can be dragged anywhere 
(e.g. to a webbrowser or chat window).

TEST PLAN
  F555195: Screenshot_20161129_173221.png 
  Spectacle can take advantage of this (the cursor actually changes to the open 
hand cursor to indicate it's a draggable surface but this cannot be seen in the 
screenshot)
  F555196: Screenshot_20161129_173311.png 
  Regular image passed as argument
  F555197: Screenshot_20161129_173410.png 
  Multiple files that fit in the notification
  F555198: Screenshot_20161129_173431.png 
  Too many files, overflow
  F555199: Screenshot_20161129_173215.png 
  Single file without thumbnail - ideally it would then fall back to the small 
square representation but that is difficult to achieve
  
  Clicking the thumbnails currently doesn't work because the MEL eats the click 
away. Also, right-click does nothing - would be neat to have the regular KIO 
file context menu there.
  It also doesn't properly work with grouping, ie. when two notifications are 
grouped together, the thumbnail shown is the one from the last notification.
  
  Needs https://git.reviewboard.kde.org/r/129586/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3539

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/plugin/CMakeLists.txt
  applets/notifications/plugin/notificationshelperplugin.cpp
  applets/notifications/plugin/thumbnailer.cpp
  applets/notifications/plugin/thumbnailer.h
  dataengines/notifications/notificationsengine.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Review Request 129586: [KNotification] Allow annotating notifications with URLs

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129586/
---

Review request for KDE Frameworks and Plasma.


Repository: knotifications


Description
---

This will allow the notification server to show thumbnails or provide 
additional options (like Sharing or drag and drop) for the given URLs, for 
example when a screenshot was taken or a file was received from a contact.


Diffs
-

  src/knotification.h 649b233 
  src/knotification.cpp b14fa44 
  src/notifybypopup.cpp fe948ce 

Diff: https://git.reviewboard.kde.org/r/129586/diff/


Testing
---


File Attachments


Screenshot_20161129_173410.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/29/0c01d85e-cae3-4abc-9c79-fb95ee067de5__Screenshot_20161129_173410.png


Thanks,

Kai Uwe Broulik

[Differential] [Updated, 16 lines] D3501: Scale surface damage events

[davidedmundson (David Edmundson)]

davidedmundson updated this revision to Diff 8607.
davidedmundson retitled this revision from "Scale surface damage events

Damage events come in global compositor space, not relative to the surface.
For a glTex2D we need the events relatvie to the surface, so they need scaling 
up" to "Scale surface damage events".
davidedmundson updated the summary for this revision.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  Cleanup whitespace

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3501?vs=8509&id=8607

REVISION DETAIL
  https://phabricator.kde.org/D3501

AFFECTED FILES
  abstract_egl_backend.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 2 lines] D3499: drm cursor scaling

[davidedmundson (David Edmundson)]

davidedmundson updated this revision to Diff 8605.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  Update line

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3499?vs=8507&id=8605

REVISION DETAIL
  https://phabricator.kde.org/D3499

AFFECTED FILES
  plugins/platforms/drm/drm_output.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, graesslin, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Request, 18 lines] D3538: Drop resize animation when adding pages

[apol (Aleix Pol Gonzalez)]

apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  It's a bit glitchy and looks a bit odd

TEST PLAN
  Current: https://youtu.be/pUjmqis9E-w
  NoAnimations: https://youtu.be/iqQfkOhObBE

REPOSITORY
  R169 Kirigami

BRANCH
  mart/Kirigami2

REVISION DETAIL
  https://phabricator.kde.org/D3538

AFFECTED FILES
  src/controls/templates/private/PageRow.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 68 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/68/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 29 Nov 2016 14:56:07 +
Build duration: 6 min 7 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2276/3392 
(67%)CONDITIONAL 1552/3778 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 257/375 (69%)CONDITIONAL 
83/199 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 68 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/68/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 29 Nov 2016 14:56:07 +
Build duration: 6 min 7 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2276/3392 
(67%)CONDITIONAL 1552/3778 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 257/375 (69%)CONDITIONAL 
83/199 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 67 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/67/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 29 Nov 2016 14:42:33 +
Build duration: 8 min 53 sec

CHANGE SET
Revision d9d52a37c6ba267f7da936c0436b254788f7cb87 by Marco Martin: (Select 
correct index without timer)
  change: edit kcms/desktoptheme/kcm.cpp
  change: edit kcms/desktoptheme/package/contents/ui/main.qml
  change: edit kcms/desktoptheme/kcm.h

[Differential] [Closed] D3533: Select correct index without timer

[mart (Marco Martin)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d9d52a37c6ba: Select correct index without timer 
(authored by mart).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3533?vs=8575&id=8602

REVISION DETAIL
  https://phabricator.kde.org/D3533

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3532: Select correct index without timer

[mart (Marco Martin)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5434e4bc0141: Select correct index without timer 
(authored by mart).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3532?vs=8574&id=8601

REVISION DETAIL
  https://phabricator.kde.org/D3532

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.cpp
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/platformcontents/phone/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/platformcontents/phone/ui/config.qml
  wallpapers/image/imagepackage/platformcontents/touch/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/platformcontents/touch/ui/config.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3533: Select correct index without timer

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  phab/selectindex

REVISION DETAIL
  https://phabricator.kde.org/D3533

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 20 lines] D3496: Scale input on windowed backend so input co-ordinate system matches host

[davidedmundson (David Edmundson)]

davidedmundson updated this revision to Diff 8600.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  Updated line

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3496?vs=8504&id=8600

REVISION DETAIL
  https://phabricator.kde.org/D3496

AFFECTED FILES
  plugins/platforms/x11/windowed/x11windowed_backend.cpp
  plugins/platforms/x11/windowed/x11windowed_backend.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, graesslin, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3532: Select correct index without timer

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/wallpselectedindex

REVISION DETAIL
  https://phabricator.kde.org/D3532

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3425: If we get a notification with no body, treat the subject line as the body

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3425

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, broulik, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D3508: Implement borderlessMaximizedWindows for Wayland windows

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:f32e6550311f: Implement borderlessMaximizedWindows for 
Wayland windows (authored by graesslin).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D3508?vs=8522&id=8598#toc

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3508?vs=8522&id=8598

REVISION DETAIL
  https://phabricator.kde.org/D3508

AFFECTED FILES
  autotests/integration/maximize_test.cpp
  shell_client.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, eliasp, sebas

[Differential] [Closed] D3507: Properly implement maximize of ShellClient

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:9934f5b57537: Properly implement maximize of ShellClient 
(authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3507?vs=8521&id=8597

REVISION DETAIL
  https://phabricator.kde.org/D3507

AFFECTED FILES
  autotests/integration/quick_tiling_test.cpp
  geometry.cpp
  shell_client.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, eliasp, sebas

[Differential] [Accepted] D3508: Implement borderlessMaximizedWindows for Wayland windows

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  shell-client-borderless-maximized-windows

REVISION DETAIL
  https://phabricator.kde.org/D3508

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, eliasp, sebas

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3530#65867, @dfaure wrote:
  
  > But desktop:/ and applications:/ make no sense in other workspaces (I'm 
surprised we even still have applications:/, it's kind of a toy, isn't it?).
  >
  > (ok applications:/ might make sense in gnome, but definitely not on 
Windows/OSX)
  
  
  desktop:/ should be probably conditionally built only on Linux(but in there 
is quite core), while, may make sense to actually kill applications:/ 
altogether??

REVISION DETAIL
  https://phabricator.kde.org/D3530

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, #frameworks, #plasma, dfaure
Cc: mart, aacid, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3531: Drop kioslave folder, will be in KIO 5.30

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio added inline comments.

INLINE COMMENTS

> bshah wrote in CMakeLists.txt:8
> You can't do this, framework version is bumped by release script 
> automatically, so when you push this there is no 5.30.0 version of KIO. Which 
> will make it fail, you need to bump version once frameworks 5.30 is relased.

Yep, this will be pushed only after 5.30 gets released

REPOSITORY
  R120 Plasma Workspace

BRANCH
  drop-slaves

REVISION DETAIL
  https://phabricator.kde.org/D3531

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, davidedmundson, #plasma
Cc: bshah, lbeltrame, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D3531: Drop kioslave folder, will be in KIO 5.30

[bshah (Bhushan Shah)]

bshah added inline comments.

INLINE COMMENTS

> CMakeLists.txt:8
>  set(QT_MIN_VERSION "5.6.1")
> -set(KF5_MIN_VERSION "5.26.0")
> +set(KF5_MIN_VERSION "5.30.0")
>  set(INSTALL_SDDM_THEME TRUE)

You can't do this, framework version is bumped by release script automatically, 
so when you push this there is no 5.30.0 version of KIO. Which will make it 
fail, you need to bump version once frameworks 5.30 is relased.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  drop-slaves

REVISION DETAIL
  https://phabricator.kde.org/D3531

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, davidedmundson, #plasma
Cc: bshah, lbeltrame, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Requested Changes To] D3472: API for window tabbing

[Martin Gräßlin]

graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.


  Overall looks quite good. Please watch the coding style a little bit. That 
created a few comments.
  
  There are two conceptional things I don't get. One is why you have the 
tabCount in DecoratedClient, I would assume that is only relevant to the 
DecorationTabGroup or the Decoration.
  
  The other is all these "Op" things. I don't understand why it would be needed 
in KDecoration at all and why it's exposed through the DecoratedClient. If you 
need to know whether a mouse button should start the drag, use the settings.

INLINE COMMENTS

> decoratedclient.h:205-211
> +//Begin Window Tabbing
> +int tabCount() const; // tab count
> +void activateClient(); // activates the tab
> +QList> clients() const; // get list of clients 
> in the client group
> +bool isTabDragOp(Qt::MouseButtons btn) const;
> +bool isOperationsOp(Qt::MouseButtons btn) const;
> +//End Window Tabbing

you can turn your comments into documentation. The begin window tabbing and end 
window tabbing could for example be doxygen sections.

> decoratedclient.h:206
> +//Begin Window Tabbing
> +int tabCount() const; // tab count
> +void activateClient(); // activates the tab

What is tabCount in the context of a DecoratedClient?

> decoratedclient.h:207
> +int tabCount() const; // tab count
> +void activateClient(); // activates the tab
> +QList> clients() const; // get list of clients 
> in the client group

The method name and the comment do not match. Either it's activating a client 
or the tab. In general I wouldn't call a method activateFoo if it's in a Foo 
class. So just activate would be enough.

> decoratedclient.h:209
> +QList> clients() const; // get list of clients 
> in the client group
> +bool isTabDragOp(Qt::MouseButtons btn) const;
> +bool isOperationsOp(Qt::MouseButtons btn) const;

what's an "Op"?

> decoratedclient.h:259
> +//for window tabbing
> +void updateTabGroup(); //emitted when a client is tabbed/untabbed
> +

that doesn't sound like a signal, but more like a method to invoke. Maybe 
tabGroupChanged?

> decoration_p.h:68
>  QVector buttons;
> +DecorationTabGroup *tabGroup;
>  QSharedPointer shadow;

I don't see where it's initialized. It's neither set to null nor to a proper 
value on construction. Please initialize.

> decorationtab.cpp:1
> +#include "decoratedclient.h"
> +#include "decorationtab.h"

please add copyright header

> decorationtab.cpp:8-11
> +:QObject(parent)
> +,m_client(client)
> +,m_geometry(QRectF())
> +,active(client->isActive())

nitpick on coding style: add a space between : and QObject and , and the 
variables

> decorationtab.cpp:39
> +{
> +return active;
> +}

Once the DecorationTab got activated this method is returning an incorrect 
value. It caches the active state of the client, but never updates again.

> decorationtab.h:1
> +#ifndef KDECORATION2_DECORATIONTAB_H
> +#define KDECORATION2_DECORATIONTAB_H

please add a copyright header

> decorationtab.h:35
> +bool isActive() const;
> +void setActive();
> +

with the name setActive I would assume a bool argument. Given that it's about 
activation, call it "activate"

> decorationtab.h:46
> +QRectF m_geometry;
> +bool active;
> +};

naming style: m_active

> decorationtabgroup.cpp:1
> +#include "decoration.h"
> +#include "decoration_p.h"

Please add copyright header

> decorationtabgroup.cpp:14-18
> +:decoration(decoration)
> +,needTabs(false)
> +,mouseButtonPressed(false)
> +,tab(NULL)
> +,q(parent)

coding style: white spaces

> decorationtabgroup.cpp:26-27
> +DecorationTabGroup::DecorationTabGroup(Decoration *parent)
> +:QObject(parent)
> +,d(new Private(parent,this))
> +{

coding style: white spaces

> decorationtabgroup.cpp:32-33
> +connect(c, &DecoratedClient::updateTabGroup, this,
> +[this](){
> + setNeedTabs(tabCount()!=0);
> +});

coding style: add whitespaces

> decorationtabgroup.cpp:82-83
> +{
> +auto c = decoration()->client().data();
> +return c->tabCount();
> +}

why do you go through the DecoratedClient? You have the d->windowTabs you can 
derive the number from?

> decorationtabgroup.cpp:90
> +
> +if(!d->windowTabs.isEmpty()) {
> +qDeleteAll(d->windowTabs);

missing white space

> decorationtabgroup.cpp:95-96
> +
> +if (!needTabs())
> +return;
> +

please use {}

> decorationtabgroup.cpp:109-110
> +int i = 0;
> +QSizeF size = geometry().size();
> +int tabWidth = size.width()/tabCount();
> +auto it = d->windowTabs.begin();

const

> decorationtabgroup.cpp:111-112
> +int tabWidth = size.width()/tabCount();
> +auto it = d->windowTabs.begin();
> +while (it != d->windowTabs.end()) {
> +QRectF tabGeom(geometry().x() + i*tabWidth,0,tabWidth,size.height());

constBegin

[Differential] [Updated] D3531: Drop kioslave folder, will be in KIO 5.30

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio updated the summary for this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  drop-slaves

REVISION DETAIL
  https://phabricator.kde.org/D3531

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, davidedmundson, #plasma
Cc: lbeltrame, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated] D3530: Import plasma-workspace kioslaves

[dfaure (David Faure)]

dfaure added a comment.


  remote:/ sounds very workspace-independent indeed, it sounds useful to have 
in kio.
  
  But desktop:/ and applications:/ make no sense in other workspaces (I'm 
surprised we even still have applications:/, it's kind of a toy, isn't it?).
  
  (ok applications:/ might make sense in gnome, but definitely not on 
Windows/OSX)

REVISION DETAIL
  https://phabricator.kde.org/D3530

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, #frameworks, #plasma, dfaure
Cc: aacid, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas