Re: Review Request 129872: [lookandfeel] Support changing window decoration

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129872/#review102237
---



I don't understand. We already have support for this in 5.9?!?

- Martin Gräßlin


On Jan. 24, 2017, 9 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129872/
> ---
> 
> (Updated Jan. 24, 2017, 9 p.m.)
> 
> 
> Review request for Plasma, Kai Uwe Broulik, Hugo Pereira Da Costa, and Marco 
> Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   kcms/lookandfeel/autotests/kcmtest.cpp 29d6ec0f 
>   kcms/lookandfeel/autotests/lookandfeel/contents/defaults ef3165de 
>   kcms/lookandfeel/kcm.h c27b7f3d 
>   kcms/lookandfeel/kcm.cpp 6ea3d050 
> 
> Diff: https://git.reviewboard.kde.org/r/129872/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

[Differential] [Commented On] D4241: Support modifier-only-shortcuts when capslock is on

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in modifier_only_shortcut_test.cpp:281
> I don't get this change:
> 
> This is the " // this test verifies that Capslock does not trigger the shift 
> shortcut" part of the test.
> 
> Shift has been released on line 276, so triggeredSpy shouldn't be going up.

No, it is the capslock key which got released in 276. So at that point here 
capslock is on, typing an a would result in A.

So far when that was the case pressing shift did not trigger the modifier only 
shortcut, now it does.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4241

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: davidedmundson, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D4220: Add a basic SNI for keyboard layout

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in keyboard_layout.cpp:142
> You only want this in ::reconfigure() before resetLayout and not here.
> 
> You're calling this method from reconfigure and in processKeymapChange, from 
> keyboard_input - that won't affect whether you're showing or hiding it.

> that won't affect whether you're showing or hiding it.

Yes it does. processKeymapChange is called when a parent Wayland server informs 
this nested Wayland server about a new keymap. This means we have a new number 
of keyboard layouts and that can affect whether the notifier is shown or not.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4220

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: davidedmundson, luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, eliasp, sebas

[Differential] [Accepted] D4241: Support modifier-only-shortcuts when capslock is on

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  Plasma-5.8-fix-capslock-mod-only-shortcuts

REVISION DETAIL
  https://phabricator.kde.org/D4241

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D4220: Add a basic SNI for keyboard layout

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  keyboard-layout-sni

REVISION DETAIL
  https://phabricator.kde.org/D4220

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, eliasp, sebas

[Differential] [Closed] D4269: VolumeSlider: Ignore all value changes until Component is completed

[David Rosca]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:1c9f50c88e96: VolumeSlider: Ignore all value changes 
until Component is completed (authored by drosca).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4269?vs=10494&id=10520

REVISION DETAIL
  https://phabricator.kde.org/D4269

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/kcm/package/contents/ui/VolumeSlider.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D4215#78915, @apol wrote:
  
  > In https://phabricator.kde.org/D4215#78913, @mck182 wrote:
  >
  > > -1, I don't want to keep thinking "am I now going to close the 
notification or execute an action" everytime I'm about to click the 
notification popup.
  > >
  > > I want my workspace to have predictable behavior that doesn't get in my 
way.
  >
  >
  > If you just want to close then you have the big X, no?
  >
  > Actually, up until this patch, I never expected that clicking would close 
the notification.
  
  
  the x is not that big and is significantly more difficult to aim at than the 
whole notification, with the added penalty that if you miss it, you will 
trigger the action, without wanting it.
  in 99% of the cases, the only interaction one wants to have with a 
notification, is to get it out of the way.
  also -1 on this

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4215

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: albertvaka, #plasma, colomar
Cc: mart, broulik, apol, mck182, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[Marco Martin]

mart added a comment.


  can this be splitted in multiple reviews/commits?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D4223: Remove local copy of dialog.h

[Marco Martin]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4223

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4224: [Color Picker] Add border around color if contrast to surrounding view is too little

[Marco Martin]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D4224

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4246: update khotkeys kcm docbook

[Marco Martin]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R101 KHotKeys

REVISION DETAIL
  https://phabricator.kde.org/D4246

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: lueck, #plasma, #documentation, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D4229: Overhaul group popup dialog

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> GroupDialog.qml:91
>  
> -TaskList {
> -id: taskList
> +Timer {
> +id: focusActiveTaskTimer

is this timer working around some bug? should have at least some comments 
explaining why this needs to be delayed

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4229

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: mart, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[Konstantin Shtepa]

konstantinshtepa added a comment.


  In https://phabricator.kde.org/D4204#80106, @mart wrote:
  
  > can this be splitted in multiple reviews/commits?
  
  
  It can be splitted into multiple commits inside one branch so you can view 
what exactly fix what. But multiple reviews based on master? I don't think so. 
All patches have intersections and patch of Bug 375308 heavily depends on patch 
of Bug 375307.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[Konstantin Shtepa]

konstantinshtepa updated the summary for this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Request, 44 lines] D4276: Add workaround for QMenuBar::setVisible bug in 5.7.0

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  QMenuBar::setVisible() only checks isNativeMenuBar on OS X
  leading to both the normal in-appmenu and the platform menu both being
  visible - especially as KXmlGui explicitly has a setVisible call.
  
  This only affects Qt 5.7.0.
  For Qt < 5.7.0 we don't have any DBusMenu support.
  For Qt >= 5.7.1 the problem is fixed.
  
  This patch adds a (horrible) event filter on any QMenuBar's and blocks
  any setVisible calls.
  
  Qt 5.7.0
  void QMenuBar::setVisible(bool visible)
  {
  
if (isNativeMenuBar()) {
if (!visible)
QWidget::setVisible(false);
return;
}
QWidget::setVisible(visible);
  
  }
  
  Qt 5.7.1
  void QMenuBar::setVisible(bool visible)
  {
  
if (isNativeMenuBar()) {
if (!visible)
QWidget::setVisible(false);
return;
}
QWidget::setVisible(visible);
  
  }

TEST PLAN
  Ran on a system with Qt 5.7.0
  No longer get double menus

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4276

AFFECTED FILES
  src/platformtheme/qdbusmenubar.cpp
  src/platformtheme/qdbusmenubar_p.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: KDE_INSTALL_LOCALEDIR - where should point?

[Aleix Pol]

On Tue, Jan 24, 2017 at 8:45 PM, Michail Vourlakos  wrote:
> I have the following situation and I would like you to clarify it in order
> to open a bug in the distro that should fix this...
>
> KDE_INSTALL_LOCALEDIR  for CMAKE
>
> in openSUSE
>
> points to /usr/share/locale but the translations are in
> /usr/share/locale/kf5
>
>
> and in Arch
>
> points to /usr/share/locale and the translations are in /usr/share/locale
>
>
> 1) the question is for Plasma 5 where should the translations should be
> placed? (for example the plasmashell.mo and for the plasmoids)
>
> 2) where should KDE_INSTALL_LOCALEDIR point?
>
>
> thanks a lot !!!
>
> regards,
>
> michail

Looks like distributions are actively changing it, I'd say that it
should go wherever KDE_INSTALL_LOCALEDIR indicates and let the
packagers in every distribution wherever they please.

Note that you might find people who can help you in kde-distro-packag...@kde.org

Aleix

PS: Please fix your e-mail client, you're sending e-mails in large and
weird fonts

[Differential] [Accepted] D4276: Add workaround for QMenuBar::setVisible bug in 5.7.0

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a reviewer: broulik.
broulik added a comment.
This revision is now accepted and ready to land.


  Works for me. Cool.
  
  I asked Dmitry (who did the Qt menu stuff) and he's fine with it. Let's go 
with it, thanks.
  
  You can close Bug 375498 then

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4276

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Closed] D4276: Add workaround for QMenuBar::setVisible bug in 5.7.0

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:bac5a39f01a8: Add workaround for QMenuBar::setVisible bug 
in 5.7.0 (authored by davidedmundson).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4276?vs=10531&id=10532

REVISION DETAIL
  https://phabricator.kde.org/D4276

AFFECTED FILES
  src/platformtheme/qdbusmenubar.cpp
  src/platformtheme/qdbusmenubar_p.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> dfaure wrote in iconapplet.cpp:108
> Not convinced that KIO::encodeFileName would be better than a MD5 filename, 
> then?

Ah, that's what you meant with that. I got confused as to where and why I 
should use this … so, will work for when there's no fileName? Then I can just 
use that indeed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4157

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D4204#80123, @konstantinshtepa wrote:
  
  > In https://phabricator.kde.org/D4204#80106, @mart wrote:
  >
  > > can this be splitted in multiple reviews/commits?
  >
  >
  > It can be splitted into multiple commits inside one branch so you can view 
what exactly fix what. But multiple reviews based on master? I don't think so. 
All patches have intersections and patch of Bug 375308 heavily depends on patch 
of Bug 375307.
  
  
  what i would like to have logically splitted is the management of the 
floating property (and having positionItem()/releasePosition used around)
  
  and on the other hand the signal handlers of minimumWidthChanged/widthChanged 
etc in Appletappearance, that's the biggest part

INLINE COMMENTS

> AppletAppearance.qml:50
> +property alias innerHeight: mouseListener.height
> +property alias innerWidth: mouseListener.width
> +

mouseListener just has a simple anchors.fill:parent to this, so makes 
innerWidth/innerHeight redundant as they are the same as the parent?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D4241: Support modifier-only-shortcuts when capslock is on

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:5a87fa3f92cf: Support modifier-only-shortcuts when 
capslock is on (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4241?vs=10426&id=10533

REVISION DETAIL
  https://phabricator.kde.org/D4241

AFFECTED FILES
  autotests/integration/modifier_only_shortcut_test.cpp
  keyboard_input.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 166 lines] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

[Kai Uwe Broulik]

broulik updated this revision to Diff 10534.
broulik added a comment.


  - Use KIO::encodeFileName instead of QCryptoGraphicHash

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4157?vs=10348&id=10534

REVISION DETAIL
  https://phabricator.kde.org/D4157

AFFECTED FILES
  applets/icon/iconapplet.cpp
  applets/icon/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 166 lines] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

[Kai Uwe Broulik]

broulik updated this revision to Diff 10535.
broulik added a comment.


  - Reflect in comment that we no longer hash

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4157?vs=10534&id=10535

REVISION DETAIL
  https://phabricator.kde.org/D4157

AFFECTED FILES
  applets/icon/iconapplet.cpp
  applets/icon/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 9 lines] D4277: [Image Wallpaper] Provide fallback for thumbnail size of no "plasmoid" around

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, graesslin.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This fixes wallpaper thumbnails in Lock Screen KCM

TEST PLAN
  Ideally the lock screen KCM exposed a fake "plasmoid" to ensure compatibility 
with how plasma wallpapers work but for 5.9 let's at least fix the size of the 
thumbnails

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4277

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4277: [Image Wallpaper] Provide fallback for thumbnail size of no "plasmoid" around

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4277

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, graesslin, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> mart wrote in AppletAppearance.qml:50
> mouseListener just has a simple anchors.fill:parent to this, so makes 
> innerWidth/innerHeight redundant as they are the same as the parent?

It did. It doesn't after this patch.

It's detached so that appletItem can store the final width/height and this 
container then animates to that position.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D4074: Add workaround for touch input offset for decorated windows

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:7e89c518237b: Add workaround for touch input offset for 
decorated windows (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4074?vs=10004&id=10538

REVISION DETAIL
  https://phabricator.kde.org/D4074

AFFECTED FILES
  autotests/integration/touch_input_test.cpp
  touch_input.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin, davidedmundson
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, eliasp, sebas

[Differential] [Closed] D4091: Add support for skip close animation to OnScreenMessage

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:d38bce776fa2: Add support for skip close animation to 
OnScreenMessage (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4091?vs=10069&id=10537

REVISION DETAIL
  https://phabricator.kde.org/D4091

AFFECTED FILES
  autotests/mock_effectshandler.h
  effects.cpp
  effects.h
  effects/screenshot/screenshot.cpp
  effects/screenshot/screenshot.h
  libkwineffects/kwineffects.h
  onscreennotification.cpp
  onscreennotification.h
  osd.cpp
  osd.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, davidedmundson
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, eliasp, sebas

[Differential] [Closed] D4220: Add a basic SNI for keyboard layout

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:fe561c5c7def: Add a basic SNI for keyboard layout 
(authored by graesslin).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D4220?vs=10427&id=10539#toc

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4220?vs=10427&id=10539

REVISION DETAIL
  https://phabricator.kde.org/D4220

AFFECTED FILES
  keyboard_input.cpp
  keyboard_input.h
  keyboard_layout.cpp
  keyboard_layout.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, eliasp, sebas

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> AppletAppearance.qml:101
> +if (minimumWidth > maximumWidth)
> +maximumWidth = minimumWidth;
> +if (width < minimumWidth) {

this is broken.

if I'm an applet and do:
Plasmoid.Layout.maximumWidth = 50

this appletItem.maximumWidth  == 58 (assuming 4px margins)
which is correct

Now if I do:

Plasmoid.Layout.minimumWidth = 60

this appletItem.maximumWidth == 68
which is also fine, we've set it to the minimum + margins

But, now if I do:

Plasmoid.Layout.maximumWidth = 70
this appletItem.maximumWidth == 68

because we've broken the binding.

We're going to need to move the

if (minimumWidth > maximumWidth)
maximumWidth = minimumWidth;

logic somewhere lower. 
Either into appletContainer or even AppletQuickItem where it does the proxying.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Re: [plasma-devel] Re: Proposed Plasma 5.10 Kickoff meeting at Affenfels

[Sebastian Kügler]

On maandag 23 januari 2017 17:42:20 CET Jonathan Riddell wrote:
> okay, how's 7th at 14:00UTC, 15:00CET?

Would work for me.

-- 
sebas

http://www.kde.org | http://vizZzion.org

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> AppletAppearance.qml:445
> +
>  property int minimumWidth: minimumSize.width;
>  property int minimumHeight: minimumSize.height;

Edit, maybe it won't - that's why you have the separate Binding.

However changing this to:
minimumWidth: Math.min(minimumSize.width, maximumSize.width);

for all 4

would still be a bit cleaner as then appletItem can trust these values are 
correct

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[Konstantin Shtepa]

konstantinshtepa added inline comments.

INLINE COMMENTS

> davidedmundson wrote in AppletAppearance.qml:101
> this is broken.
> 
> if I'm an applet and do:
> Plasmoid.Layout.maximumWidth = 50
> 
> this appletItem.maximumWidth  == 58 (assuming 4px margins)
> which is correct
> 
> Now if I do:
> 
> Plasmoid.Layout.minimumWidth = 60
> 
> this appletItem.maximumWidth == 68
> which is also fine, we've set it to the minimum + margins
> 
> But, now if I do:
> 
> Plasmoid.Layout.maximumWidth = 70
> this appletItem.maximumWidth == 68
> 
> because we've broken the binding.
> 
> We're going to need to move the
> 
> if (minimumWidth > maximumWidth)
> maximumWidth = minimumWidth;
> 
> logic somewhere lower. 
> Either into appletContainer or even AppletQuickItem where it does the 
> proxying.

That's strange. I didn't expirienced any of this when testing. 
Binding on level appletItem.maximumWidth shouldn't be broken because they based 
on external Binding QML element.
I will look into this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[Konstantin Shtepa]

konstantinshtepa added inline comments.

INLINE COMMENTS

> davidedmundson wrote in AppletAppearance.qml:445
> Edit, maybe it won't - that's why you have the separate Binding.
> 
> However changing this to:
> minimumWidth: Math.min(minimumSize.width, maximumSize.width);
> 
> for all 4
> 
> would still be a bit cleaner as then appletItem can trust these values are 
> correct

Ok. I didn't think about this possibility. Maybe you are right and it would be 
better. If so then I can remove separate bindings. I will test it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D4277: [Image Wallpaper] Provide fallback for thumbnail size of no "plasmoid" around

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:656fa842a691: [Image Wallpaper] Provide fallback for 
thumbnail size of no "plasmoid" around (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4277?vs=10536&id=10541

REVISION DETAIL
  https://phabricator.kde.org/D4277

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, graesslin, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D4170: [KRDB] Fix wording in comment at the top of "gtkrc"

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:85754b3ddcb1: [KRDB] Fix wording in comment at the top of 
"gtkrc" (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4170?vs=10279&id=10543

REVISION DETAIL
  https://phabricator.kde.org/D4170

AFFECTED FILES
  kcms/krdb/krdb.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 27 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/27/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 Jan 2017 13:32:57 +
Build duration: 34 min

CHANGE SET
Revision 656fa842a69198028e2e8c93910f327b87c34f35 by kde: ([Image Wallpaper] 
Provide fallback for thumbnail size of no "plasmoid")
  change: edit wallpapers/image/imagepackage/contents/ui/config.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5946 
(39%)CONDITIONAL 1597/5892 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3297 (6%)CONDITIONAL 
119/3233 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 
93/204 (46%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 
40/74 (54%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 568 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/568/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 Jan 2017 13:38:37 +
Build duration: 29 min

CHANGE SET
Revision 85754b3ddcb1df479031d680fabc53363cb87d30 by kde: ([KRDB] Fix wording 
in comment at the top of "gtkrc")
  change: edit kcms/krdb/krdb.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2274/3415 
(67%)CONDITIONAL 1528/3757 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 275/398 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

[Differential] [Commented On] D4229: Overhaul group popup dialog

[Eike Hein]

hein added a comment.


  There's extensive comments explaining it in the patch actually ...?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4229

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: mart, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 703 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/703/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 Jan 2017 13:33:22 +
Build duration: 33 min

CHANGE SET
Revision ad66dc81817ea7b7d4bf98dd772ddf99107a4202 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit wallpapers/image/wallpaper.knsrc
  change: edit applets/appmenu/package/metadata.desktop
  change: edit components/shellprivate/widgetexplorer/plasmoids.knsrc
Revision 656fa842a69198028e2e8c93910f327b87c34f35 by kde: ([Image Wallpaper] 
Provide fallback for thumbnail size of no "plasmoid")
  change: edit wallpapers/image/imagepackage/contents/ui/config.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5946 
(39%)CONDITIONAL 1597/5892 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3297 (6%)CONDITIONAL 
119/3233 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 
93/204 (46%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 
40/74 (54%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Request, 26 lines] D4279: proofread/update systemsettings docbook

[Burkhard Lück]

lueck created this revision.
lueck added reviewers: Plasma, Documentation.
lueck set the repository for this revision to R124 System Settings.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  bump date + releaseinfo
  accessibility moved to Personalization
  new networks settings kcm
  correct Module names

TEST PLAN
  checkXML5

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D4279

AFFECTED FILES
  doc/index.docbook

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: lueck, #plasma, #documentation
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D4246: update khotkeys kcm docbook

[Burkhard Lück]

This revision was automatically updated to reflect the committed changes.
Closed by commit R101:d5b63b4132e0: update khotkeys kcm docbook (authored by 
lueck).

REPOSITORY
  R101 KHotKeys

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4246?vs=10433&id=10547

REVISION DETAIL
  https://phabricator.kde.org/D4246

AFFECTED FILES
  doc/kcm/document-open.png
  doc/kcm/groups-comment.png
  doc/kcm/index.docbook
  doc/kcm/manage-export.png
  doc/kcm/settings.png
  doc/kcm/shortcuts-action-command.png
  doc/kcm/shortcuts-action-dbus.png
  doc/kcm/shortcuts-action-keyboard.png
  doc/kcm/shortcuts-trigger-keyboard.png
  doc/kcm/shortcuts-trigger-mouse.png

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: lueck, #plasma, #documentation, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 306 lines] D4103: Support spring-loading on drag hover and drops into preview popups.

[Eike Hein]

hein updated this revision to Diff 10548.
hein added a comment.


  Fix internal DND in listview mode when changing URL mid-drag.
  
  It crashed, and also wouldn't work even without the crash.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4103?vs=10275&id=10548

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4103

AFFECTED FILES
  applets/kicker/plugin/containmentinterface.cpp
  containments/desktop/package/contents/ui/BackButtonItem.qml
  containments/desktop/package/contents/ui/CompactRepresentation.qml
  containments/desktop/package/contents/ui/FolderItemDelegate.qml
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/FolderViewDialog.qml
  containments/desktop/package/contents/ui/FolderViewDropArea.qml
  containments/desktop/package/contents/ui/main.qml
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h
  kcms/ksplash/kcm.cpp
  kcms/lookandfeel/kcm.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, broulik, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 312 lines] D4103: Support spring-loading on drag hover and drops into preview popups.

[Eike Hein]

hein updated this revision to Diff 10549.
hein added a comment.


  Rebase patch to drop unrelated change from diff shown in Phab.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4103?vs=10548&id=10549

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4103

AFFECTED FILES
  containments/desktop/package/contents/ui/BackButtonItem.qml
  containments/desktop/package/contents/ui/CompactRepresentation.qml
  containments/desktop/package/contents/ui/FolderItemDelegate.qml
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/FolderViewDialog.qml
  containments/desktop/package/contents/ui/FolderViewDropArea.qml
  containments/desktop/package/contents/ui/main.qml
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, broulik, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: KDE_INSTALL_LOCALEDIR - where should point?

[šumski]

On utorak, 24. siječnja 2017. 20:45:24 CET Michail Vourlakos wrote:
> I have the following situation and I would like you to clarify it in
> order to open a bug in the distro that should fix this...
> 
> KDE_INSTALL_LOCALEDIR  for CMAKE
> 
> in openSUSE
> 
> points to /usr/share/locale but the translations are in
> /usr/share/locale/kf5
> 

They point there as we wanted to avoid conflicts with kdelibs4-based workspace 
translations. Unless you have something like this[1] in ki18n package, 
translations will be found only in $prefix/share/locale...

Cheers,
Hrvoje 
> regards,
> 
> michail


[1] https://build.opensuse.org/package/view_file/KDE:Frameworks5/ki18n/
fallbackLang.diff?expand=1


signature.asc
Description: This is a digitally signed message part.

[Differential] [Updated, 314 lines] D4103: Support spring-loading on drag hover and drops into preview popups.

[Eike Hein]

hein updated this revision to Diff 10551.
hein added a comment.


  Don't forget to null hoveredItem.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4103?vs=10549&id=10551

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4103

AFFECTED FILES
  containments/desktop/package/contents/ui/BackButtonItem.qml
  containments/desktop/package/contents/ui/CompactRepresentation.qml
  containments/desktop/package/contents/ui/FolderItemDelegate.qml
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/FolderViewDialog.qml
  containments/desktop/package/contents/ui/FolderViewDropArea.qml
  containments/desktop/package/contents/ui/main.qml
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, broulik, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4103: Support spring-loading on drag hover and drops into preview popups.

[Kai Uwe Broulik]

broulik accepted this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4103

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: KDE_INSTALL_LOCALEDIR - where should point?

[šumski]

On srijeda, 25. siječnja 2017. 16:56:04 CET Michail Vourlakos wrote:
> On 25/01/2017 05:44 μμ, šumski wrote:
> > On utorak, 24. siječnja 2017. 20:45:24 CET Michail Vourlakos wrote:
> >> I have the following situation and I would like you to clarify it in
> >> order to open a bug in the distro that should fix this...
> >> 
> >> KDE_INSTALL_LOCALEDIR  for CMAKE
> >> 
> >> in openSUSE
> >> 
> >> points to /usr/share/locale but the translations are in
> >> /usr/share/locale/kf5
> > 
> > They point there as we wanted to avoid conflicts with kdelibs4-based
> > workspace translations.
> 
> in that case, it isnt a good idea to have something like:
> KF5_INSTALL_LOCALEDIR to avoid the confusion?

It is. But we're already looking to drop manual passing of -
DCMAKE_INSTALL_LOCALEDIR=

 
> > Unless you have something like this[1] in ki18n package,
> > translations will be found only in $prefix/share/locale...
> 
> the mentioned package is just a plasma5 plasmoid that should install its
> translations at /usr/share/locale/kf5 (according to openSUSE directory
> tree). In order to achieve this in openSUSE at its cmake main file we use:
> 
> KDE_INSTALL_LOCALEDIR/kf5
> 
> but this from distro to distro creates breakage. This is why I am asking if
> aKF5_INSTALL_LOCALEDIR would be a good idea. regards, michail

The standard location is still read/searched, just after share/locale/kf5.


Cheers,
Hrvoje

signature.asc
Description: This is a digitally signed message part.

Re: KDE_INSTALL_LOCALEDIR - where should point?

[Michail Vourlakos]

On 25/01/2017 05:44 μμ, šumski wrote:

On utorak, 24. siječnja 2017. 20:45:24 CET Michail Vourlakos wrote:

I have the following situation and I would like you to clarify it in
order to open a bug in the distro that should fix this...

KDE_INSTALL_LOCALEDIR  for CMAKE

in openSUSE

points to /usr/share/locale but the translations are in
/usr/share/locale/kf5


They point there as we wanted to avoid conflicts with kdelibs4-based workspace
translations.

in that case, it isnt a good idea to have something like:
KF5_INSTALL_LOCALEDIR to avoid the confusion?


Unless you have something like this[1] in ki18n package,
translations will be found only in $prefix/share/locale...
the mentioned package is just a plasma5 plasmoid that should install its 
translations at /usr/share/locale/kf5 (according to openSUSE directory 
tree). In order to achieve this in openSUSE at its cmake main file we use:


KDE_INSTALL_LOCALEDIR/kf5

but this from distro to distro creates breakage. This is why I am asking if 
aKF5_INSTALL_LOCALEDIR would be a good idea. regards, michail

[Differential] [Updated, 159 lines] D4229: Overhaul group popup dialog

[Eike Hein]

hein updated this revision to Diff 10552.
hein added a comment.


  Collect active task on hover but invalidate when child count changes.
  
  This should be reasonably safe-ish with regard to the stored task
  index still being valid at click time.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4229?vs=10468&id=10552

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4229

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  applets/taskmanager/package/contents/ui/GroupDialog.qml
  applets/taskmanager/package/contents/ui/MouseHandler.qml
  applets/taskmanager/package/contents/ui/Task.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: mart, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: KDE_INSTALL_LOCALEDIR - where should point?

[Michail Vourlakos]

On 25/01/2017 06:02 μμ, šumski wrote:



Unless you have something like this[1] in ki18n package,
translations will be found only in $prefix/share/locale...

the mentioned package is just a plasma5 plasmoid that should install its
translations at /usr/share/locale/kf5 (according to openSUSE directory
tree). In order to achieve this in openSUSE at its cmake main file we use:

KDE_INSTALL_LOCALEDIR/kf5

but this from distro to distro creates breakage. This is why I am asking if
aKF5_INSTALL_LOCALEDIR would be a good idea. regards, michail

The standard location is still read/searched, just after share/locale/kf5.


I am sorry but I didnt understand the solution from your comments.
So, what (is) / (will be) the preferred way to install translations for 
Plasma 5 plasmoids in openSUSE?


How /usr/share/locale/kf5 is going to be reached through CMake ?


regards,
michail

[Differential] [Commented On] D4229: Overhaul group popup dialog

[Eike Hein]

hein added a comment.


  Also added a more localized comment on Marco's request.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4229

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: mart, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: KDE_INSTALL_LOCALEDIR - where should point?

[šumski]

On srijeda, 25. siječnja 2017. 17:08:49 CET Michail Vourlakos wrote:
> On 25/01/2017 06:02 μμ, šumski wrote:
> >>> Unless you have something like this[1] in ki18n package,
> >>> translations will be found only in $prefix/share/locale...
> >> 
> >> the mentioned package is just a plasma5 plasmoid that should install its
> >> translations at /usr/share/locale/kf5 (according to openSUSE directory
> >> tree). In order to achieve this in openSUSE at its cmake main file we
> >> use:
> >> 
> >> KDE_INSTALL_LOCALEDIR/kf5
> >> 
> >> but this from distro to distro creates breakage. This is why I am asking
> >> if
> >> aKF5_INSTALL_LOCALEDIR would be a good idea. regards, michail
> > 
> > The standard location is still read/searched, just after share/locale/kf5.
> 
> I am sorry but I didnt understand the solution from your comments.
> So, what (is) / (will be) the preferred way to install translations for
> Plasma 5 plasmoids in openSUSE?

The upstream way. We only added the kf5 sufix for the packages we know 
conflicted with kde4 workspace. The need to have this is now gone, as most 
kdelibs4 packages are dead.

> How /usr/share/locale/kf5 is going to be reached through CMake ?

We're passing -DCMAKE_INSTALL_LOCALEDIR=/usr/share/locale/kf5 in plasma5-
workspace spec.


Cheers,
Hrvoje

> 
> regards,
> michail

[Differential] [Request, 6 lines] D4280: [Task Manager] Hide group dialog when opening applets settings

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When moving focus from one Plasma window to another (e.g. in this case 
opening the applet config dialog), Plasma Dialog stays open even with 
hideOnWindowDeactivate.
  
  Since changing task manager settings might affect grouping and triggers 
unintentional behavior when the model is used in a GroupDialog without grouping 
/ fildering, just hide the popup in this case.

TEST PLAN
  This also makes it consistent with Plasma which explicitly collapses applets 
prior to showing their config interface. System tray does the same.
  
  Opened group dialog, clicked "configure task manager", group dialog closed.
  
  Before that I could open the group dialog, then disable grouping in popups 
and ended up with a huge dialog of all windows that I couldn't get rid of 
without restarting plasma.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4280

AFFECTED FILES
  applets/taskmanager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4280: [Task Manager] Hide group dialog when opening applets settings

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  Should be in 5.8 and up.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4280

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, hein, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D4280: [Task Manager] Hide group dialog when opening applets settings

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:38fca064a1d0: [Task Manager] Hide group dialog when 
opening applets settings (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4280?vs=10553&id=10554

REVISION DETAIL
  https://phabricator.kde.org/D4280

AFFECTED FILES
  applets/taskmanager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, hein, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 169 lines] D4229: Overhaul group popup dialog

[Eike Hein]

hein updated this revision to Diff 10555.
hein added a comment.


  Bite the bullet and do the active task collection the brute force way.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4229?vs=10552&id=10555

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4229

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  applets/taskmanager/package/contents/ui/GroupDialog.qml
  applets/taskmanager/package/contents/ui/MouseHandler.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: mart, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D4257: [PlasmaComponents Menu] Add maximumWidth property

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:ceeb57d17fed: [PlasmaComponents Menu] Add maximumWidth 
property (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4257?vs=10470&id=10556

REVISION DETAIL
  https://phabricator.kde.org/D4257

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qmenu.cpp
  src/declarativeimports/plasmacomponents/qmenu.h
  tests/components/menu.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, hpereiradacosta, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 25 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/25/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 Jan 2017 16:47:00 +
Build duration: 25 min

CHANGE SET
Revision 38fca064a1d0d4ec94543805e948f7771bc021a1 by kde: ([Task Manager] Hide 
group dialog when opening applets settings)
  change: edit applets/taskmanager/package/contents/ui/main.qml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2274/3415 
(67%)CONDITIONAL 1548/3798 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 275/398 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

[Differential] [Request, 7 lines] D4281: [Task Manager] Limit context menu width

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Having opened a file with a long file name would result in a huge context 
menu.
  
  The number is a guesstimation based on the task maximum width in normal 
panels but admittedly quite random.

TEST PLAN
  Uses new API in https://phabricator.kde.org/D4257
  
  Unfortunately here it just blatantly cuts off the contents (also with Fusion 
theme) and the menu is still placed as though it was as wide without the 
restrictions :/ Can someone with newer Qt (than 5.7.0) try if this is still an 
issue there?
  
  F2166494: Screenshot_20170125_181140.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4281

AFFECTED FILES
  applets/taskmanager/package/contents/code/layout.js
  applets/taskmanager/package/contents/ui/ContextMenu.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 569 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/569/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 Jan 2017 16:48:15 +
Build duration: 24 min

CHANGE SET
Revision af36a54e947f32974a83c4ff1669081899672f96 by kde: ([Style KCM] Make 
sure to enable kappmenu kded module)
  change: edit kcms/style/kcmstyle.cpp
Revision 01a7be1d73bc81ef77bb947a94be08322d530d88 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/cursortheme/xcursor/xcursor.knsrc
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop
  change: edit kcms/desktoptheme/plasma-themes.knsrc
  change: edit kcms/colors/colorschemes.knsrc
  change: edit kcms/lookandfeel/lookandfeel.knsrc
Revision 061a4600444515f8420a1b4ecf2d170c5ce4370f by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/desktoptheme/plasma-themes.knsrc
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop
  change: edit kcms/colors/colorschemes.knsrc
  change: edit kcms/lookandfeel/lookandfeel.knsrc
  change: edit kcms/cursortheme/xcursor/xcursor.knsrc
Revision b65fabd6582212fa5a28ed6de456da0e41ec880b by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop
  change: edit kcms/lookandfeel/lookandfeel.knsrc
  change: edit kcms/colors/colorschemes.knsrc
  change: edit kcms/desktoptheme/plasma-themes.knsrc
  change: edit kcms/cursortheme/xcursor/xcursor.knsrc
Revision 276d805b039292c18f4e523186b46e82008f5917 by aleixpol: (Add missing 
descriptions on the trashcan and appmenubar plasmoids)
  change: edit applets/trash/package/metadata.desktop
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop
Revision cd361efff2fb4eaf456a9f1186d795a869f45d51 by hein: (Use the systray 
applet's icon sizing logic to size audio indicators.)
  change: edit applets/taskmanager/package/contents/ui/Task.qml
Revision 1cddd0f28845057e6b6713bb97f4f618b7a056a2 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/cursortheme/xcursor/xcursor.knsrc
  change: edit kcms/desktoptheme/plasma-themes.knsrc
  change: edit kcms/lookandfeel/lookandfeel.knsrc
  change: edit kcms/colors/colorschemes.knsrc
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop
Revision d4a25ca56d46cfd962b52e96ed56757c299188fa by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop
  change: edit applets/icontasks/metadata.desktop
  change: edit applets/trash/package/metadata.desktop
Revision 38fca064a1d0d4ec94543805e948f7771bc021a1 by kde: ([Task Manager] Hide 
group dialog when opening applets settings)
  change: edit applets/taskmanager/package/contents/ui/main.qml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2274/3415 
(67%)CONDITIONAL 1528/3757 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 275/398 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[Konstantin Shtepa]

konstantinshtepa added inline comments.

INLINE COMMENTS

> davidedmundson wrote in AppletAppearance.qml:445
> Edit, maybe it won't - that's why you have the separate Binding.
> 
> However changing this to:
> minimumWidth: Math.min(minimumSize.width, maximumSize.width);
> 
> for all 4
> 
> would still be a bit cleaner as then appletItem can trust these values are 
> correct

It wouldn't work.
For example:
plasmoid.Layout.minimumHeight = 150
plasmoid.Layout.maximumHeight = 200
plasmoid.Layout.maximumHeight = 130
On third step it would think that maximumHeight = 150 and minimumHeight = 130, 
when it should think that maximumHeight = minimumHeight = 130.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Request, 3 lines] D4282: Dialog: Hide when focus changes to ConfigView with hideOnWindowDeactivate

[David Rosca]

drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

TEST PLAN
  Expand applet in systray -> open config -> applet popup gets closed

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4282

AFFECTED FILES
  src/plasmaquick/dialog.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D4280: [Task Manager] Hide group dialog when opening applets settings

[David Rosca]

drosca added a comment.


  Shouldn't this be fixed in plasma-framework instead? 
https://phabricator.kde.org/D4282

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4280

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, hein, #plasma
Cc: drosca, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4282: Dialog: Hide when focus changes to ConfigView with hideOnWindowDeactivate

[Kai Uwe Broulik]

broulik added a comment.


  Cool! +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4282

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: broulik, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D4229: Overhaul group popup dialog

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4229

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, broulik
Cc: mart, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[Konstantin Shtepa]

konstantinshtepa added a comment.


  In https://phabricator.kde.org/D4204#80142, @mart wrote:
  
  > what i would like to have logically splitted is the management of the 
floating property (and having positionItem()/releasePosition used around)
  >
  > and on the other hand the signal handlers of 
minimumWidthChanged/widthChanged etc in Appletappearance, that's the biggest 
part
  
  
  Sorry, I don't understand what you would like me to do. Do you like me to 
split code to add additional commit where would be introduced managment of 
floating property? But why? it's useless without others bug 375307(fixes of 
work with layoutManager) fixes. And to split bug 375307 fixes from bug 
375308(maximumSize handlers) is big work for me, because all my work centered 
over bug 375308. Other bugs were founded when debugging bug 375308 fixes. 
Because of that bug 375307 fixes is never were intended by me as standalone, 
they currently included only as additional bug fixing to bug 375308 fixes.
  
  I can compress some code in handlers by adding function like
  
function setSizePropertyAndReposition(sizeProperty, newSizeProperty) {
releasePosition();
sizeProperty = newSizeProperty;
positionItem();
if (showAppletHandle && !handleMerged)
appletHandle.positionHandle();
}
  
  Should I do it?
  
  P.S. I understand that this code is not well. But in first place it couldn't 
be well because current state of plasmoid background code is in mess and it 
need to be rewritten. What I propose in this diff is temporary solution which 
fixes bugs until I or somebody else would rewrite plasmoid background to normal 
code.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D4229: Overhaul group popup dialog

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:f6b30cb08d4c: Overhaul group popup dialog (authored by 
hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4229?vs=10555&id=10562

REVISION DETAIL
  https://phabricator.kde.org/D4229

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  applets/taskmanager/package/contents/ui/GroupDialog.qml
  applets/taskmanager/package/contents/ui/MouseHandler.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, broulik
Cc: mart, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D4103: Support spring-loading on drag hover and drops into preview popups.

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:383cf19d0a91: Support spring-loading on drag hover and 
drops into preview popups. (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4103?vs=10551&id=10561

REVISION DETAIL
  https://phabricator.kde.org/D4103

AFFECTED FILES
  containments/desktop/package/contents/ui/BackButtonItem.qml
  containments/desktop/package/contents/ui/CompactRepresentation.qml
  containments/desktop/package/contents/ui/FolderItemDelegate.qml
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/FolderViewDialog.qml
  containments/desktop/package/contents/ui/FolderViewDropArea.qml
  containments/desktop/package/contents/ui/main.qml
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4282: Dialog: Hide when focus changes to ConfigView with hideOnWindowDeactivate

[Eike Hein]

hein added a comment.


  This is what I suggested in IRC, but Kai had some concerns that it wasn't 
always desired.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4282

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: hein, broulik, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D4282: Dialog: Hide when focus changes to ConfigView with hideOnWindowDeactivate

[Kai Uwe Broulik]

broulik added a comment.


  I was under the impression that opening a plasma config dialog would keep the 
popup opened but then I found that it doesn't (at least not the default popup 
impl) after I already submitted the patch.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4282

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: hein, broulik, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Request, 4 lines] D4284: Fix group parents not appearing when disabling inline grouping.

[Eike Hein]

hein created this revision.
hein added reviewers: Plasma, broulik.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D4284

AFFECTED FILES
  libtaskmanager/tasksmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 570 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/570/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 Jan 2017 18:01:18 +
Build duration: 18 min

CHANGE SET
Revision 383cf19d0a911bdd121decbab9a647fdc7eed104 by hein: (Support 
spring-loading on drag hover and drops into preview popups.)
  change: edit containments/desktop/package/contents/ui/FolderItemDelegate.qml
  change: edit containments/desktop/plugins/folder/foldermodel.h
  change: edit containments/desktop/plugins/folder/foldermodel.cpp
  change: edit containments/desktop/package/contents/ui/BackButtonItem.qml
  change: edit containments/desktop/package/contents/ui/FolderView.qml
  change: edit containments/desktop/package/contents/ui/FolderViewDialog.qml
  change: edit containments/desktop/package/contents/ui/main.qml
  change: add containments/desktop/package/contents/ui/FolderViewDropArea.qml
  change: edit 
containments/desktop/package/contents/ui/CompactRepresentation.qml
Revision f6b30cb08d4cf2b45f1e1315b1b1bd681a0073a8 by hein: (Overhaul group 
popup dialog)
  change: edit applets/taskmanager/package/contents/ui/main.qml
  change: edit applets/taskmanager/package/contents/ui/Task.qml
  change: edit applets/taskmanager/package/contents/ui/ContextMenu.qml
  change: edit applets/taskmanager/package/contents/ui/MouseHandler.qml
  change: edit applets/taskmanager/package/contents/ui/GroupDialog.qml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2274/3415 
(67%)CONDITIONAL 1528/3757 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 275/398 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 26 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/26/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 Jan 2017 18:24:38 +
Build duration: 6 min 24 sec

CHANGE SET
Revision 3e7e1c07161666912c971d9417ebd326b531a1c4 by hein: (More like systray.)
  change: edit applets/taskmanager/package/contents/ui/Task.qml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2274/3415 
(67%)CONDITIONAL 1548/3798 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 275/398 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

[Differential] [Updated, 3 lines] D4284: Fix group parents not appearing when disabling inline grouping.

[Eike Hein]

hein updated this revision to Diff 10565.
hein added a comment.


  Do it properly and fix the filter instead.
  
  Really asleep at the wheel today ...

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4284?vs=10564&id=10565

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D4284

AFFECTED FILES
  libtaskmanager/tasksmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4284: Fix group parents not appearing when disabling inline grouping.

[David Edmundson]

davidedmundson added a comment.


  you have 
   flattenGroupsProxyModel = nullptr;
  
  after q->setSourceModel()
  
  so does this actually work when automatic sorting is on?
  
  (which doesn't go through forceResort())

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4284

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, broulik
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[kio-extras] [Bug 375552] Search in files does not show results when search string ends with parenthese

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=375552

Elvis Angelaccio  changed:

   What|Removed |Added

   Assignee|dolphin-bugs-n...@kde.org   |plasma-devel@kde.org
Product|dolphin |kio-extras
Version|16.08.2 |5.8.5
 Ever confirmed|0   |1
  Component|general |default
 Status|UNCONFIRMED |CONFIRMED
 CC||elvis.angelac...@kde.org

--- Comment #1 from Elvis Angelaccio  ---
That's because the filenamesearch ioslave uses regular expressions.
If you type "filter\(" (without quotes) you will see the expected list of
files.

This is not user-friendly, indeed. We could add an additional query item to the
filenamesearch URL that tells the ioslave whether the user wants to use
regexes.

Re-assigning to kio-extras for now, even though we'll also need a "Use regex"
checkbox or toolbutton on the Dolphin side.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Accepted] D4284: Fix group parents not appearing when disabling inline grouping.

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D4284

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D4284: Fix group parents not appearing when disabling inline grouping.

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f5bf988c5bd5: Fix group parents not appearing when 
disabling inline grouping. (authored by hein).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4284?vs=10565&id=10566

REVISION DETAIL
  https://phabricator.kde.org/D4284

AFFECTED FILES
  libtaskmanager/tasksmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 571 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/571/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 Jan 2017 18:25:53 +
Build duration: 16 min

CHANGE SET
Revision 3e7e1c07161666912c971d9417ebd326b531a1c4 by hein: (More like systray.)
  change: edit applets/taskmanager/package/contents/ui/Task.qml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2274/3415 
(67%)CONDITIONAL 1528/3757 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 275/398 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 28 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/28/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 Jan 2017 18:42:08 +
Build duration: 16 min

CHANGE SET
Revision e47a5c96783453d974404f80853dccea9bd10389 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit templates/ion-dataengine/ion-dataengine.kdevtemplate
Revision f5bf988c5bd50ec0d39e4ca4ad19ea3b25a4fbf5 by hein: (Fix group parents 
not appearing when disabling inline grouping.)
  change: edit libtaskmanager/tasksmodel.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5947 
(39%)CONDITIONAL 1597/5894 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 
93/204 (46%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 
40/74 (54%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Re: Review Request 129872: [lookandfeel] Support changing window decoration

[Anthony Fieroni]

> On Ян. 25, 2017, 11:30 преди обяд, Martin Gräßlin wrote:
> > I don't understand. We already have support for this in 5.9?!?

I made in same approach like other roles and i commit defaults (in blocks)


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129872/#review102237
---


On Ян. 24, 2017, 10 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129872/
> ---
> 
> (Updated Ян. 24, 2017, 10 след обяд)
> 
> 
> Review request for Plasma, Kai Uwe Broulik, Hugo Pereira Da Costa, and Marco 
> Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   kcms/lookandfeel/autotests/kcmtest.cpp 29d6ec0f 
>   kcms/lookandfeel/autotests/lookandfeel/contents/defaults ef3165de 
>   kcms/lookandfeel/kcm.h c27b7f3d 
>   kcms/lookandfeel/kcm.cpp 6ea3d050 
> 
> Diff: https://git.reviewboard.kde.org/r/129872/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

[Differential] [Request, 4 lines] D4285: When swapping Wallpapers, save the config to file, not just to propertymap

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  ContainmentConfigView has a special code path for wallpaper configs
  where, if you change wallpaper type, it will create a temporary config
  ConfigPropertyMap, then copy it over to the real config when the
  containment actually changes.
  
  ConfigPropertyMap does not call valueChanged() on insertion (See
  QQmlPropertyMap), and we only write the value into the actual
  KConfigSkeleton on valueChange.
  
  BUG: 375532

TEST PLAN
  Start plasma with image wallpaper
  Set to colour wallpaper and save colour
  Hit apply
  
  Close plasma
  Start plasma
  
  Before the correct colour wouldn't be loaded. Now it is.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4285

AFFECTED FILES
  shell/containmentconfigview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 572 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/572/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 26 Jan 2017 04:58:03 +
Build duration: 9 min 6 sec

CHANGE SET
Revision 74ac222ad43505c7f924929c23f6832d1adaab1f by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit applets/trash/package/metadata.desktop
  change: edit applets/icontasks/metadata.desktop

Re: Review Request 129835: [IconDialog] Set proper icons group

[Anthony Fieroni]

> On Ян. 21, 2017, 7:24 преди обяд, Anthony Fieroni wrote:
> > All IconDialogs from QML are with small and hard to visible icons e.g. 
> > Kicker (right click -> change icon -> small icons)

Ping


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129835/#review102153
---


On Ян. 15, 2017, 12:27 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129835/
> ---
> 
> (Updated Ян. 15, 2017, 12:27 след обяд)
> 
> 
> Review request for Plasma, Christoph Feck and Marco Martin.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> Follow the comment in IconThemes: 
> https://api.kde.org/frameworks/kiconthemes/html/kicondialog_8cpp_source.html#l00500
> iconSize == 0 && group == KIconLoader::NoGroup
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp be54174 
> 
> Diff: https://git.reviewboard.kde.org/r/129835/diff/
> 
> 
> Testing
> ---
> 
> Change group to Desktop, explicit size will override it.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 29 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/29/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 26 Jan 2017 06:36:46 +
Build duration: 5 min 53 sec

CHANGE SET
Revision 3b44f2e50a36ab57da296703ea342faf22163d45 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit templates/ion-dataengine/ion-dataengine.kdevtemplate


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5947 
(39%)CONDITIONAL 1597/5894 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 
93/204 (46%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 
40/74 (54%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 27 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/27/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 26 Jan 2017 06:36:26 +
Build duration: 30 min

CHANGE SET
Revision e018318f670a7526c0f28d4eaaf2a7fa10a49393 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit applets/trash/package/metadata.desktop
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2274/3415 
(67%)CONDITIONAL 1548/3798 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 275/398 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)