[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

[David Rosca]

drosca added inline comments.

INLINE COMMENTS

> ListItemBase.qml:135
> +
> +PlasmaCore.IconItem {
> +source: "application-menu"

As @Zren pointed out, please change it to ToolButton. This is actually a 
button, so there is no reason to make it IconItem + MouseArea. Also as it is 
now, it breaks accessibility.

> Zren wrote in ListItemBase.qml:283
> I prefer `if (Ports.length > 0)` since that's how you'd read it in English. 
> You wouldn't ask "is 0 less than the number of ports".

Also, at least in plasma code, `(var > 2)` is used everywhere, so please change 
it.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4751

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma, drosca, Zren
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Request, 21 lines] D4755: Fix binding loops from previous commit

[David Rosca]

drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  no binding loops, width of content is correct on first show

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  fix-bindloop (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4755

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/Devices.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, subdiff
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Commented On] D4749: Fix another regression with rearranging launchers in an activities world.

[Kai Uwe Broulik]

broulik added a comment.


  With the typo fixed, I can now re-arrange launchers and it sticks when I 
launch the app.

INLINE COMMENTS

> launchertasksmodel.cpp:453
> +if (newLaunchersOrder != d->launchersOrder
> +|| newActivitiesForLauncher != d->activitiesForLauncher)) {
>  // Common case optimization: If the list changed but its size

Superfluous parenthesis, doesn't compile.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4749

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson, mart
Cc: broulik, fvogt, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Request, 36 lines] D4756: Fix some code and style issues

[David Rosca]

drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  misc-fixes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4756

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/Header.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Accepted] D4746: Ignore drag move events if an item doesn't allow drop.

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4746

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Requested Changes] D4749: Fix another regression with rearranging launchers in an activities world.

[Marco Martin]

mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  +1 after the fix

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4749

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson, mart
Cc: broulik, fvogt, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Accepted] D4753: [kcheckpass] Drop the throttle handling code

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  is the setuid non pam case still supported/buildable at all? (i guess 
slackware/bsd?)

REPOSITORY
  R133 KScreenLocker

BRANCH
  kcheckpass-no-throttle

REVISION DETAIL
  https://phabricator.kde.org/D4753

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, mart
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Accepted] D4754: [kcheckpass] Drop the ACCEPT_ENV compatibility define

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  also, influencing kcheckpass by environment variable may be a potential 
security issue

REPOSITORY
  R133 KScreenLocker

BRANCH
  kcheckpass-drop-accept-env

REVISION DETAIL
  https://phabricator.kde.org/D4754

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, mart
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Accepted] D4755: Fix binding loops from previous commit

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  fix-bindloop (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4755

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, subdiff, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Accepted] D4756: Fix some code and style issues

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  misc-fixes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4756

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

[Roman Gilg]

subdiff added inline comments.

INLINE COMMENTS

> drosca wrote in ListItemBase.qml:135
> As @Zren pointed out, please change it to ToolButton. This is actually a 
> button, so there is no reason to make it IconItem + MouseArea. Also as it is 
> now, it breaks accessibility.

How does it break accessibility?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4751

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma, drosca, Zren
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

[David Rosca]

drosca added inline comments.

INLINE COMMENTS

> subdiff wrote in ListItemBase.qml:135
> How does it break accessibility?

You would need to manually set Accessible.role to Accessible.Button and other 
properties, but that's not really the main issue I have with that. This is 
clickable button, so it should be (and look like) button Item, for the 
consistency sake.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4751

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma, drosca, Zren
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Accepted] D4744: ReceiveFileJob: Don't cancel the request right after accepting it

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R97 Bluedevil

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D4744

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, mart
Cc: marten, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Closed] D4744: ReceiveFileJob: Don't cancel the request right after accepting it

[David Rosca]

This revision was automatically updated to reflect the committed changes.
Closed by commit R97:def41978a633: ReceiveFileJob: Don't cancel the request 
right after accepting it (authored by drosca).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4744?vs=11721&id=11750

REVISION DETAIL
  https://phabricator.kde.org/D4744

AFFECTED FILES
  src/kded/receivefilejob.cpp
  src/kded/receivefilejob.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, mart
Cc: marten, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Accepted] D4491: Let make taskmanager tooltip readable again

[Roman Gilg]

subdiff accepted this revision.
subdiff added inline comments.

INLINE COMMENTS

> ToolTipInstance.qml:108
>  height: undefined
> +maximumLineCount: 2
>  elide: Text.ElideRight

Because of this the tooltips aren't the same height when one of them has a too 
long window title. On the other hand @broulik noted that sometimes for him 
important informations were lost when the window title was shortened to only 
one line. So the 2 still makes sense.

Another option would be to use 1 and Text.ElideMiddle, so you are potentially 
presented different informations about the window title than in the taskmanager 
itself.

Because I was very keen on having same dimensions for every tooltip when 
redesigning them, I would favor the second option. But it's up to you.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4491

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, #plasma:_design, #plasma, hein, subdiff
Cc: markg, broulik, subdiff, hein, plasma-devel, davidedmundson, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4711: Ungrab mouse on menu close

[Marco Martin]

mart added a comment.


  this on released Qt 5.8? on 5.8 branch?
  i can't reproduce with my 5.8 build here.
  anyways, that beahvior change would be a Qt bug (one of the many the terrible 
5.8 release had) and should be fixed upstream
  the indicated if (!enter || !QWidget::mouseGrabber()) { code was added in 
2012, so can't be the responsible of the change

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4711

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, #plasma, broulik, mart
Cc: mvourlakos, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4711: Ungrab mouse on menu close

[Michail Vourlakos]

mvourlakos added a comment.


  In https://phabricator.kde.org/D4711#89334, @mart wrote:
  
  > this on released Qt 5.8? on 5.8 branch?
  >  i can't reproduce with my 5.8 build here.
  >  anyways, that beahvior change would be a Qt bug (one of the many the 
terrible 5.8 release had) and should be fixed upstream
  >  the indicated if (!enter || !QWidget::mouseGrabber()) { code was added in 
2012, so can't be the responsible of the change
  
  
  I am using Qt 5.8 from 
http://download.opensuse.org/repositories/KDE:/Qt5/openSUSE_Leap_42.2/
  I think this is the released version...
  
  in my system I am doing the folowing:
  
  1. open a qtcreator
  2. notice the hovering works at the menu bar
  3. activate any menu from the top menu bar
  4. deactivate this menu by clicking on the desktop
  5. going the mouse above the qt creator's menu bar then hovering is not 
working, the user must click into the qtcreator in order for hovering to work 
again

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4711

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, #plasma, broulik, mart
Cc: mvourlakos, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Closed] D4679: [ConfigView] Honor KIOSK Control Module restrictions

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1934475e48fb: [ConfigView] Honor KIOSK Control Module 
restrictions (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4679?vs=11526&id=11751

REVISION DETAIL
  https://phabricator.kde.org/D4679

AFFECTED FILES
  src/plasmaquick/configview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Changed Subscribers] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> subdiff wrote in ListItemBase.qml:135
> How does it break accessibility?

- Missing `Accessible`
- Cannot be tabbed to
- Doesn't have a proper hover effect
- Has no tooltip

etc etc

> ListItemBase.qml:145
> +onClicked: contextMenu.show(parent.x, parent.y + 
> parent.height)
> +onEntered: parent.opacity = 0.8
> +onExited: parent.opacity = 1

Don't mess with the opacity, use the `active` property on `IconItem` which will 
have `KIconLoader` use the correct hover state (you could have configured it to 
tint the icon instead etc)

> ListItemBase.qml:273
> +var menuItem = newMenuItem();
> +menuItem.text = i18n("Default");
> +menuItem.checkable = true;

Please add some context for translators

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4751

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma, drosca, Zren
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Closed] D4753: [kcheckpass] Drop the throttle handling code

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R133:bff1b22b375c: [kcheckpass] Drop the throttle handling 
code (authored by graesslin).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4753?vs=11737&id=11757

REVISION DETAIL
  https://phabricator.kde.org/D4753

AFFECTED FILES
  kcheckpass/kcheckpass.c

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, mart
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Closed] D4754: [kcheckpass] Drop the ACCEPT_ENV compatibility define

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R133:3f999c5b86cd: [kcheckpass] Drop the ACCEPT_ENV 
compatibility define (authored by graesslin).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D4754?vs=11738&id=11758#toc

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4754?vs=11738&id=11758

REVISION DETAIL
  https://phabricator.kde.org/D4754

AFFECTED FILES
  greeter/autotests/fakekcheckpass.c
  kcheckpass/kcheckpass.c

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, mart
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Request, 11 lines] D4757: Avoid capturing MenuItem instead determine checked state from toggled signal

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Due to JS lambdas menuItem is being captured by reference, and as such
  the call to menuItem.checked returns the checked state of the last item
  in the for loop. Instead of adding to the capture this patch uses the
  supplied boolean from the QMenuItem::toggled signal.
  
  Also unlike Array.concat Array.splice alters the current array, we don't
  want to create a new var.
  
  BUG: 376826

TEST PLAN
  Debug of menuItem.text showed we were capturing the wrong thing
  Clicked window into multiple activities and unticked them. All worked as 
intended

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4757

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Request, 2 lines] D4758: Connect all connections to action in QMenuItem::setAction

[David Edmundson]

davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Otherwise if anyone used setAction it would be missing a very important
  connect.

TEST PLAN
  Compiled

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4758

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qmenuitem.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4753: [kcheckpass] Drop the throttle handling code

[Martin Gräßlin]

graesslin added a comment.


  > is the setuid non pam case still supported/buildable at all?
  
  I assume it still works, otherwise we would hopefully have got reports about 
it not working.
  
  Nevertheless as I am cleaning up that old code I will ask on distro mailing 
list which backends are still used and remove everything nobody yells I need it 
in a month or so.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D4753

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, mart
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Request, 34 lines] D4759: [kcheckpass] Drop command line option for username

[Martin Gräßlin]

graesslin created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  kscreenlocker does only invoke kcheckpass for the current user. There
  is no need to support checking the password for another user in
  kcheckpass.

REPOSITORY
  R133 KScreenLocker

BRANCH
  no-username-option

REVISION DETAIL
  https://phabricator.kde.org/D4759

AFFECTED FILES
  greeter/autotests/fakekcheckpass.c
  kcheckpass/kcheckpass.c

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Accepted] D4757: Avoid capturing MenuItem instead determine checked state from toggled signal

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  > Also unlike Array.concat Array.splice alters the current array, we don't 
want to create a new var.
  
  The return value of splice is btw the items that were removed.

INLINE COMMENTS

> ContextMenu.qml:382
>  };
>  })(activityId));
>  }

You could have passed the correct menuItem in here just like it's already done 
correctly with activityId

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4757

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Accepted] D4758: Connect all connections to action in QMenuItem::setAction

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4758

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Closed] D4758: Connect all connections to action in QMenuItem::setAction

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:07d8df77a1de: Connect all connections to action in 
QMenuItem::setAction (authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4758?vs=11760&id=11763

REVISION DETAIL
  https://phabricator.kde.org/D4758

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qmenuitem.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Closed] D4757: Avoid capturing MenuItem instead determine checked state from toggled signal

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e5df3ded85c9: Avoid capturing MenuItem instead determine 
checked state from toggled signal (authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4757?vs=11759&id=11764

REVISION DETAIL
  https://phabricator.kde.org/D4757

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Updated, 3 lines] D4749: Fix another regression with rearranging launchers in an activities world.

[Eike Hein]

hein updated this revision to Diff 11766.
hein added a comment.


  Fix typo that happened when recreating the commit after a git accident ...

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4749?vs=11715&id=11766

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4749

AFFECTED FILES
  libtaskmanager/launchertasksmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson, mart
Cc: broulik, fvogt, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Accepted] D4749: Fix another regression with rearranging launchers in an activities world.

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4749

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson, mart
Cc: broulik, fvogt, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Accepted] D4703: move the view at the correct index at startup

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  arcpatch-D4703_1

REVISION DETAIL
  https://phabricator.kde.org/D4703

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, #kwin, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol

[Differential] [Closed] D4749: Fix another regression with rearranging launchers in an activities world.

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:16680da7ab0e: Fix another regression with rearranging 
launchers in an activities world. (authored by hein).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4749?vs=11766&id=11768

REVISION DETAIL
  https://phabricator.kde.org/D4749

AFFECTED FILES
  libtaskmanager/launchertasksmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson, mart
Cc: broulik, fvogt, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Updated] D4718: support for auto-hidden windows to resize

[Marco Martin]

mart added a reviewer: graesslin.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4718

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, graesslin
Cc: luebking, plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Request, 2 lines] D4761: [Task Manager] Don't delay appearance of audio stream in popup

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Ensures the audio stream icon is shown immediately when the group popup is 
opened.

TEST PLAN
  Since the popup is not something that is always visible, it shouldn't cause 
distraction if it briefly shows up
  
  - Started audio stream for grouped app, indicator appeared after 2 seconds
  - Opened the popup and the icon was there right away

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4761

AFFECTED FILES
  applets/taskmanager/package/contents/ui/AudioStream.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Closed] D4703: move the view at the correct index at startup

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:299d23230cf2: move the view at the correct index at 
startup (authored by mart).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4703?vs=11700&id=11769

REVISION DETAIL
  https://phabricator.kde.org/D4703

AFFECTED FILES
  kcmkwin/kwindecoration/kcm.cpp
  kcmkwin/kwindecoration/kcm.h
  kcmkwin/kwindecoration/qml/Previews.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, #kwin, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol

[Differential] [Changed Subscribers] D4707: move setImagePath logic into updateFrameData()

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> framesvg.cpp:804
>  const QLatin1Char s('_');
> -return QString::number(frame->enabledBorders) % s % 
> QString::number(size.width()) % s % QString::number(size.height()) % s % 
> QString::number(q->scaleFactor()) % s % 
> QString::number(q->devicePixelRatio()) % s % prefixToSave % s % 
> q->imagePath();
> +return QString::number(frame->enabledBorders) % s % 
> QString::number(size.width()) % s % QString::number(size.height()) % s % 
> QString::number(q->scaleFactor()) % s % 
> QString::number(q->devicePixelRatio()) % s % prefixToSave % s % 
> frame->imagePath;
>  }

I don't understand this and the FrameData part of this change.

q->imagePath() will still always be correct as before, you still set that in 
setImagePath() regardless of whether we are blocking updates or not.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4707

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 634 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/634/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 24 Feb 2017 14:30:01 +
Build duration: 26 min

CHANGE SET
Revision 897e5ae838b1587ab2ffd6ee59c5b72ddc8fa634 by Jonathan Riddell: (Update 
version number for 5.8.6 GIT_SILENT)
  change: edit CMakeLists.txt
Revision a96f503bcbb711d1043bcee9e81645b6d4e02dac by Marco Martin: (Revert 
"use KPluginMetaData::readStringList")
  change: edit applets/kicker/plugin/containmentinterface.cpp
Revision 3e28ed5f65269169b0509c29b90c9534f62fd06a by Marco Martin: (Revert 
"Revert "use 
KPluginMetaData::readStringList"")
  change: edit applets/kicker/plugin/containmentinterface.cpp
Revision 2695842c02bb2ca8e3af9bcdc0916dc1d6d108cb by hein: (Set root.dragging 
to false during reset.)
  change: edit applets/pager/package/contents/ui/main.qml
Revision 8041c7d64f48407cb6fa5a2a5b75b4664589d705 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/desktoptheme/plasma-themes.knsrc
  change: edit applets/trash/package/metadata.desktop
  change: edit kcms/cursortheme/xcursor/xcursor.knsrc
  change: edit kcms/colors/colorschemes.knsrc
  change: edit kcms/baloo/kcm_baloofile.desktop
  change: edit kcms/runners/kcm_plasmasearch.desktop
  change: edit applets/kicker/package/metadata.desktop
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop
Revision 755993315b6a362c5b782b1770c812f84c99b313 by David Edmundson: (Fix 
potential crash in KCmFontInst on invalid index)
  change: edit kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
Revision cc5720494a01022be80788b8b62029896de80324 by jjm: (Fonts KCM: Fix 
layout of hinting settings, port away from KDE4)
  change: edit kcms/fonts/fonts.h
  change: edit kcms/fonts/fonts.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 79 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/79/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 24 Feb 2017 14:30:01 +
Build duration: 28 min

CHANGE SET
Revision 897e5ae838b1587ab2ffd6ee59c5b72ddc8fa634 by Jonathan Riddell: (Update 
version number for 5.8.6 GIT_SILENT)
  change: edit CMakeLists.txt
Revision a96f503bcbb711d1043bcee9e81645b6d4e02dac by Marco Martin: (Revert 
"use KPluginMetaData::readStringList")
  change: edit applets/kicker/plugin/containmentinterface.cpp
Revision 3e28ed5f65269169b0509c29b90c9534f62fd06a by Marco Martin: (Revert 
"Revert "use 
KPluginMetaData::readStringList"")
  change: edit applets/kicker/plugin/containmentinterface.cpp
Revision 2695842c02bb2ca8e3af9bcdc0916dc1d6d108cb by hein: (Set root.dragging 
to false during reset.)
  change: edit applets/pager/package/contents/ui/main.qml
Revision 49dea014cf4107b45f3a3659d8bd3f872d56260f by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/cursortheme/xcursor/xcursor.knsrc
  change: edit kcms/colors/colorschemes.knsrc
  change: edit kcms/runners/kcm_plasmasearch.desktop
  change: edit applets/trash/package/metadata.desktop
  change: edit kcms/desktoptheme/plasma-themes.knsrc
  change: edit applets/kicker/package/metadata.desktop
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop
  change: edit kcms/baloo/kcm_baloofile.desktop
Revision e5df3ded85c94f0a33afe12b18e6afad96f12639 by David Edmundson: (Avoid 
capturing MenuItem instead determine checked state from toggled)
  change: edit applets/taskmanager/package/contents/ui/ContextMenu.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1566/3802 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

[Differential] [Closed] D4755: Fix binding loops from previous commit

[David Rosca]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:3eda4c89cd12: Fix binding loops from daeafed202 (authored 
by drosca).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4755?vs=11741&id=11771

REVISION DETAIL
  https://phabricator.kde.org/D4755

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/Devices.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, subdiff, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Closed] D4736: Port: Expose port availability to QML

[David Rosca]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:fc4ee177396e: Port: Expose port availability to QML 
(authored by drosca).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4736?vs=11669&id=11770

REVISION DETAIL
  https://phabricator.kde.org/D4736

AFFECTED FILES
  src/port.cpp
  src/port.h
  src/qml/plugin.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, subdiff
Cc: subdiff, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Closed] D4756: Fix some code and style issues

[David Rosca]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:b3668638c048: Fix some code and style issues (authored by 
drosca).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D4756?vs=11748&id=11772#toc

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4756?vs=11748&id=11772

REVISION DETAIL
  https://phabricator.kde.org/D4756

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/Header.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Request, 20 lines] D4763: [Notifications] Keep popup opened during drag

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When dragging a file from a notification and it times out, it closes and 
crashes. This keeps the dialog open during drag.

TEST PLAN
  Notification stays open during drag.
  After drag finishes, the timeout timer restarts and notification will 
eventually go away.
  
  (once during testing I had it not close afterwards but the auto-close thing 
is flaky anyway because of MouseArea and hover and what not..)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4763

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/package/contents/ui/ThumbnailStrip.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Request, 11 lines] D4762: [SliderStyle] Allow providing a "hint-handle-size" element

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  This hints the actual size of the handle, excluding any padding and shadows 
and allows for the handle to touch the outermost border of the rail underneath.

TEST PLAN
  When slider.svgz doesn't have this element (compat), it looks the same. When 
I add an item, it takes it into account.
  
  No more gap.
  F2593760: Screenshot_20170224_163205.png 

  Element in slider.svgz
  F2593763: Screenshot_20170224_163224.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4762

AFFECTED FILES
  src/declarativeimports/plasmastyle/SliderStyle.qml
  src/desktoptheme/breeze/widgets/slider.svgz

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #vdg
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Request, 50 lines] D4764: KCM: Switch tabs with mouse wheel

[David Rosca]

drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  In QtWidgets tabbar it is possible to switch tabs with mouse wheel,
  but in QtQuickControls not so implement it manually.

TEST PLAN
  Behaves like QtWidgets tabbar now

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  kcm-wheel-tabswitch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4764

AFFECTED FILES
  src/kcm/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

[Chris Holland]

Zren added a comment.


  I'm using the default DPI of 96. `PlasmaExtras.Heading { level: 5 }` is 
what's controlling the RowLayout height.
  Level 5 is just the `theme.defaultFont.pointSize` 
https://github.com/KDE/plasma-framework/blob/master/src/declarativeimports/plasmaextracomponents/qml/Heading.qml#L64
  Which is pointSize=10 for me `qml: onPointSizeChanged 10`
  Which is calculated as pixelSize=13 `qml: onPixelSizeChanged 13` at 96 dpi
  In practice, the IconItem ends up 15px tall, since you use 
`Layout.maximumHeight: parent.height * 0.85`
  `PlasmaCore.IconItem.onMaximumHeightChanged 
Layout.maximumHeight=15.299 height=15.649`
  
  Using 100% height gives an 18px tall icon
  
  F2593761: 2017-02-24___10-31-56.png 
  
  Using ToolButton like so had a height of 30px, which causes a lot of 
whitespace.
  
PlasmaComponents.ToolButton {
iconName: "application-menu"
onClicked: contextMenu.show(x, y + height)
onHeightChanged: console.log('onHeightChanged', height)
}
  
  F2593753: 2017-02-24___10-30-35.png 
  
  Using `Layout.maximumHeight: parent.height` on the ToolButton will make it 
18px tall, but will also make the icon tiny by default (because it keeps the 
padding). We can bypass this by anchoring a child IconItem.
  
  We should probably look at ToolButtonStyle.qml 

 to make sure we apply all the right effects to the icon. All I see is that we 
need to set `action: parent.hovered` and the colorGroup.
  
PlasmaComponents.ToolButton {
Layout.maximumHeight: parent.height
onClicked: contextMenu.show(x, y + height)

PlasmaCore.IconItem {
anchors.fill: parent
source: "application-menu"

// From ToolButtonStyle.qml
active: parent.hovered
colorGroup: parent.hovered || !parent.flat ? 
PlasmaCore.Theme.ButtonColorGroup : PlasmaCore.ColorScope.colorGroup
}
}
  
  F2593808: 2017-02-24___10-47-29.png 

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4751

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma, drosca, Zren
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Commented On] D4563: Replace warps-slider checkbox with radio buttons

[Aleix Pol Gonzalez]

apol added a comment.


  thanks

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D4563

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, broulik, colomar, mart
Cc: apol, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Request, 136 lines] D4765: Make DesktopIcon aware of iamgeproviders and embedded ressources

[Benjamin Sonnemann]

bsonnemann created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Kirigami Icon on desktop environments now behave more like the qml version 
and respect custom image providers as well as embedded resources

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D4765

AFFECTED FILES
  src/desktopicon.cpp
  src/desktopicon.h
  src/kirigamiplugin.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bsonnemann
Cc: plasma-devel, apol

[Differential] [Commented On] D4764: KCM: Switch tabs with mouse wheel

[Kai Uwe Broulik]

broulik added a comment.


  +1 Yay QtQuick Controls…
  
  who is it that eats the wheel events inside the pages, which is a good thing 
but still wondering?

INLINE COMMENTS

> main.qml:60
> +anchors.fill: parent
> +z: tabView.z - 1
> +acceptedButtons: Qt.NoButton

Could you just make the root Item a MouseArea instead?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4764

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Updated, 44 lines] D4764: KCM: Switch tabs with mouse wheel

[David Rosca]

drosca updated this revision to Diff 11777.
drosca added a comment.


  Make MouseArea root item

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4764?vs=11776&id=11777

BRANCH
  kcm-wheel-tabswitch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4764

AFFECTED FILES
  src/kcm/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Accepted] D4764: KCM: Switch tabs with mouse wheel

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  kcm-wheel-tabswitch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4764

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, broulik
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Commented On] D4764: KCM: Switch tabs with mouse wheel

[David Rosca]

drosca added a comment.


  > who is it that eats the wheel events inside the pages, which is a good 
thing but still wondering?
  
  No idea, honestly. It must be the contentItem of TabView.
  
  But now I noticed that scrolling works also on 1px frame around the TabView.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  kcm-wheel-tabswitch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4764

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, broulik
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Closed] D4764: KCM: Switch tabs with mouse wheel

[David Rosca]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:87df4c77cb69: KCM: Switch tabs with mouse wheel (authored 
by drosca).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4764?vs=11777&id=11778

REVISION DETAIL
  https://phabricator.kde.org/D4764

AFFECTED FILES
  src/kcm/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, broulik
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Request, 2 lines] D4766: Start looking for the parent from the view itself

[Aleix Pol Gonzalez]

apol created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The page will be wherever the view is in
  Removes warnings in Discover:
  ...lib64/qml/org/kde/kirigami.2/ItemViewHeader.qml:64:29: Unable to assign 
ItemViewHeader_QMLTYPE_120 to Page_QMLTYPE_102

TEST PLAN
  no warning anymore

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4766

AFFECTED FILES
  src/controls/ItemViewHeader.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

Please fill GSoC ideas

[Marco Martin]

Hi all,
At the sprint there was a discussion about gsoc ideas
https://notes.kde.org/p/plasma_affenfels

To everybody, please add the ones you wish to mentor to the page
https://community.kde.org/GSoC/2017/Ideas

together with a description

-- 
Marco Martin

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 82 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/82/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 24 Feb 2017 14:47:19 +
Build duration: 27 min

CHANGE SET
Revision 16680da7ab0e06c67753c2dbd5229180c5013ee8 by hein: (Fix another 
regression with rearranging launchers in an activities)
  change: edit libtaskmanager/launchertasksmodel.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2333/5964 
(39%)CONDITIONAL 1634/5920 (28%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 196/3298 (6%)CONDITIONAL 
122/3243 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Re: Working on improvements to QuickShare

[Aleix Pol]

On Fri, Feb 24, 2017 at 7:57 AM, Yuen Hoe Lim  wrote:
>> FWIW, I have a bit of a todo list here, we can discuss things WRT the
>> plasmoid if you want.
>
> Sounds great! I'm all ears :)

The most important request is a Nextcloud share plugin. If you could
work on that it would be brilliant.

Improving the KDE Connect integration would be brilliant as well. The
biggest problem in this one is the UI I did for choosing device, I
wasn't inspired that day!

Another very interesting thing, would be to get some kind of handle
from applications' window with the URL they're holding, so we could
easily drop into the plugin. Thinking of applications like libreoffice
or okular. For most applications this information is available, we
need to expose it to the user in a meaningful way.

>> How about implementing smarter sorting and keyboard support?
>> I'm not fond of "Remember" options because they add complexity and
>> make it hard to get back to the original state.
>
> Hmm, perhaps could try and see how it feels. I just miss being able to
> drag+drop -> paste url. Also, at least for now, I feel like the other
> purpose options are not very useful in the sense that, for stuff like send
> to and save as, chances are one won't normally think to use the QuickShare
> plasmoid, and if the primary purpose in their mind for the plasmoid is
> pastebin/imagebin-ing, then the other options may come across as clutter if
> one has to see and handle them over and over. At least that's what I think.

Drag&Drop + Enter Press would be essentially the same, but with
control that you didn't mess anything up.

The main purpose isn't pastebin/imagebin, but to be able to share what
we're working on with our colleagues and friends efficiently. Pastebin
helps there, but only for a very limited set of use-cases.

>> That's already implemented.
>> Note there's a "Remember" option in the last step.
>
>
> Ah, you're right, now that I've tested it again it works. Not sure why it
> seemed not to work the first time. Maybe it makes sense to just make this
> the default behavior? Since I can't think of a use case where someone would
> not copy the result url.

Why would that be the default behavior?
If the user checks it he knows that the next time the plasmoid will be
overwritting his clipboard contents with a url. It's fair that it's
his decision.

Aleix

[Differential] [Request, 59 lines] D4767: Applet: Fix binding loop on ListItem height

[David Rosca]

drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Set only one item as child of ListItem and move DropArea and MouseArea into 
it.

TEST PLAN
  No more binding loop, looks same as before

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  applet-bindingloop (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4767

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Request, 4 lines] D4768: Require PAM by default and provide an option to not require it

[Martin Gräßlin]

graesslin created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The default should be what most distros and most users/devs use.
  On most distros kcheckpass would be broken without PAM. Thus not
  require it is a severe issue. We have had many bug reports due to
  PAM missing during build and users not able to unlock.
  
  Slackware still requires a setup without PAM, thus a cmake option
  is added to not require PAM.
  
  Do:
  cmake -DPAM_REQUIRED=OFF /path/to/kscreenlocker/src
  
  to compile kscreenlocker without PAM support.

TEST PLAN
  Tested cmake with and without that option

REPOSITORY
  R133 KScreenLocker

BRANCH
  require-pam-default

REVISION DETAIL
  https://phabricator.kde.org/D4768

AFFECTED FILES
  CMakeLists.txt
  ConfigureChecks.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Updated] D4768: Require PAM by default and provide an option to not require it

[Martin Gräßlin]

graesslin added a reviewer: erichameleers.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D4768

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, erichameleers
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 635 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/635/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 24 Feb 2017 15:11:57 +
Build duration: 18 min

CHANGE SET
Revision 49dea014cf4107b45f3a3659d8bd3f872d56260f by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit applets/kicker/package/metadata.desktop
  change: edit kcms/desktoptheme/plasma-themes.knsrc
  change: edit kcms/runners/kcm_plasmasearch.desktop
  change: edit kcms/colors/colorschemes.knsrc
  change: edit applets/trash/package/metadata.desktop
  change: edit kcms/cursortheme/xcursor/xcursor.knsrc
  change: edit kcms/baloo/kcm_baloofile.desktop
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop
Revision e5df3ded85c94f0a33afe12b18e6afad96f12639 by David Edmundson: (Avoid 
capturing MenuItem instead determine checked state from toggled)
  change: edit applets/taskmanager/package/contents/ui/ContextMenu.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

[Differential] [Request, 4 lines] D4770: KCM: Only scroll when mouse is over tabbar

[David Rosca]

drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  MouseArea fills the entire TabView and while TabView accepts all wheel events
  at the contentItem, it doesn't for wheel events at the frame.
  Make sure we switch tab only when scrolling over tabbar.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  kcm-scroll2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4770

AFFECTED FILES
  src/kcm/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Re: Working on improvements to QuickShare

[Yuen Hoe Lim]

> The main purpose isn't pastebin/imagebin, but to be able to share what
> we're working on with our colleagues and friends efficiently. Pastebin
> helps there, but only for a very limited set of use-cases.
>

Alright understood. I'll try to do keyboard support then and see how it
goes.


> If the user checks it he knows that the next time the plasmoid will be
> overwritting his clipboard contents with a url. It's fair that it's
> his decision.
>

Hmm ok, got it. At least the UI/strings could probably be improved though,
I think. Probably something like "automatically copy to clipboard" would be
less confusing than "don't show this popup window"?

Not sure what you meant about the application handle thing, but I think
I'll start with the above first. Nextcloud share does also sound like
something useful so I'll plan to try to do that as well later on :)


Lim Yuen Hoe, Jason (moofang)
http://yuenhoe.com/

[kio-extras] [Bug 376867] sftp connect issue "Failed to resolve hostname = (Name or service not known)"

[Alex Bikadorov]

https://bugs.kde.org/show_bug.cgi?id=376867

Alex Bikadorov  changed:

   What|Removed |Added

 CC||alex.bikado...@kdemail.net
   Assignee|m...@fork.pl  |plasma-devel@kde.org
  Component|net-connection  |default
Version|2.4.0-beta3 "Single Step"   |unspecified
Product|krusader|kio-extras

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Updated] D4759: [kcheckpass] Drop command line option for username

[Martin Gräßlin]

graesslin added a dependent revision: D4773: [kcheckpass] Drop the caller 
command line option.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D4759

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Updated] D4773: [kcheckpass] Drop the caller command line option

[Martin Gräßlin]

graesslin added a dependency: D4759: [kcheckpass] Drop command line option for 
username.

REVISION DETAIL
  https://phabricator.kde.org/D4773

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Request, 36 lines] D4773: [kcheckpass] Drop the caller command line option

[Martin Gräßlin]

graesslin created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This was used to the specify calling application, effectively the
  PAM service basename. As the greeter doesn't set it, it is unused
  and unknown whether that would work at all.
  
  By dropping the option we can significantly reduce the ifdef mess
  by having the same argument count for all auth backends again.

BRANCH
  drop-caller

REVISION DETAIL
  https://phabricator.kde.org/D4773

AFFECTED FILES
  greeter/autotests/fakekcheckpass.c
  kcheckpass/checkpass_pam.c
  kcheckpass/kcheckpass.c
  kcheckpass/kcheckpass.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

We don't install PAM services anymore

[Martin Gräßlin]

Hi,

I just noticed that since we did the kde-workspace repo split we no 
longer install the PAM service files.


This used to be done by: 
https://cgit.kde.org/kde-workspace.git/tree/mkpamserv?h=KDE/4.11 and the 
pam service file is 
https://cgit.kde.org/kde-workspace.git/tree/kde.pamd?h=KDE/4.11


kcheckpass still references this, but the pam service file does not 
exist.


Given that this has been broken now for several years and nobody 
complained or noticed, I think we don't need to fix it.


Opinions?

Cheers
Martin

[Differential] [Request, 2 lines] D4775: Suggestion - newline ending after password to output

[Martin Kostolný]

martinkostolny created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This is meant more as a question rather then actual code fix intention:
  
  I have a problem with `sudoedit` cmd line tool only accepting password from 
`ksshaskpass` if it is provided with newline in the end. Specifically in 
current state - calling:
  
EDITOR=kate SUDO_ASKPASS=/usr/bin/ksshaskpass sudoedit -A /etc/hosts
  
  ...will result in a Ksshaskpass dialog and after entering the password the 
command just ends. But after applying this patch it starts working and kate is 
opened.
  
  I tried other graphical askpass programs, namely ssh-askpass, 
qt4-ssh-askpass, lxqt-ssh-askpass and gnome-ssh-askpass2 (gtk2). They all work 
nicely with sudoedit.
  
  My question is: Is it intentional that the password is not returned with 
newline? Should I ask sudoedit guys instead? Or is the problem elswhere, e.g. 
in KPasswordDialog (KF5 kwidgetaddons)? Thanks!
  
  PS: Please add reviewers as needed, I don't know the proper flow here, sorry 
:).

TEST PLAN
  Tested on sudoedit as well as git connecting to github with username and 
password.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D4775

AFFECTED FILES
  src/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: martinkostolny, cfeck
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Re: We don't install PAM services anymore

[Michael Palimaka]

Hi Martin,

On 25/02/17 07:02, Martin Gräßlin wrote:
> Hi,
> 
> I just noticed that since we did the kde-workspace repo split we no
> longer install the PAM service files.
> 
> This used to be done by:
> https://cgit.kde.org/kde-workspace.git/tree/mkpamserv?h=KDE/4.11 and the
> pam service file is
> https://cgit.kde.org/kde-workspace.git/tree/kde.pamd?h=KDE/4.11
> 
> kcheckpass still references this, but the pam service file does not exist.
> 
> Given that this has been broken now for several years and nobody
> complained or noticed, I think we don't need to fix it.
> 
> Opinions?

I know several distributions install their own kde pam files, however I
don't know enough about pam to confirm if they're trying to do the same
thing as what kde-workspace used to install.

Kind regards,

Michael

[Differential] [Updated] D4759: [kcheckpass] Drop command line option for username

[Martin Gräßlin]

graesslin added a dependent revision: D4780: [kcheckpass] Drop the conv_legacy 
support.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D4759

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Request, 69 lines] D4780: [kcheckpass] Drop the conv_legacy support

[Martin Gräßlin]

graesslin created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The greeter only interacts through the binary protocol with kcheckpass.
  There is no need to keep a not used "legacy" support around.

TEST PLAN
  Kcheckpass gives error when called without -S argument.

BRANCH
  drop-conv-legacy

REVISION DETAIL
  https://phabricator.kde.org/D4780

AFFECTED FILES
  kcheckpass/kcheckpass.c

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Updated] D4773: [kcheckpass] Drop the caller command line option

[Martin Gräßlin]

graesslin added a dependent revision: D4780: [kcheckpass] Drop the conv_legacy 
support.

REVISION DETAIL
  https://phabricator.kde.org/D4773

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Updated] D4780: [kcheckpass] Drop the conv_legacy support

[Martin Gräßlin]

graesslin added dependencies: D4773: [kcheckpass] Drop the caller command line 
option, D4759: [kcheckpass] Drop command line option for username.

REVISION DETAIL
  https://phabricator.kde.org/D4780

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol