D5382: Improve password dialogs

[Jan Grulich]

jgrulich added a comment.


  In https://phabricator.kde.org/D5382#101074, @broulik wrote:
  
  > I like!
  >
  > Not sure about the "Authenticate %1" naming. Also, "For accessing the *VPN* 
connection" (ie. capital). Also, add a colon at the end "password below:"
  
  
  Any suggestion what to use instead?
  
  > (Is there a way to get rid of the "KDE Daemon" caption and replace it by 
something more meaningful?)
  
  None I would be aware of, even just removing the app name "KDE Daemon" would 
be sufficient, but given kded5 is the process where the dialog is instantiated 
then you get this .

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D5382

To: jgrulich, #plasma, #vdg
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5346: DigitalClock: Use correct language for month and day names

[Martin Klapetek]

mck182 accepted this revision.
mck182 added a comment.
This revision is now accepted and ready to land.


  Same as the other diff, if safe, good to go.
  
  EDIT: I feel like we could wrap the `Qt.locale(Qt.locale().uiLanguages[0])` 
into something shorter, maybe.
  Possibly also keep it instantiated around.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5346

To: drosca, #plasma, mck182
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5345: Calendar: Use correct language for month and day names

[Martin Klapetek]

mck182 accepted this revision.
mck182 added a comment.
This revision is now accepted and ready to land.


  ...provided the usage of `uiLanguages[0]` is safe like this.

INLINE COMMENTS

> DaysCalendar.qml:315
>  height: daysCalendar.cellHeight
> -text: Qt.locale().dayName(calendarBackend.firstDayOfWeek + 
> index, Locale.ShortFormat)
> +text: 
> Qt.locale(Qt.locale().uiLanguages[0]).dayName(calendarBackend.firstDayOfWeek 
> + index, Locale.ShortFormat)
>  font.pixelSize: Math.max(theme.smallestFont.pixelSize, 
> daysCalendar.cellHeight / 3)

Now I'm not entirely sure but can the `uiLanguages[0]`
possibly return null?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5345

To: drosca, #plasma, mck182
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Breeze] [Bug 378606] Please replace those childish avatar images

[Roman Gilg]

https://bugs.kde.org/show_bug.cgi?id=378606

--- Comment #15 from Roman Gilg  ---
I don't know for sure why your bug report / wishlist item is again closed
without further comment slartibart70, but I assume it's because of your
aggressive tone in the beginning and the unfriendly title. So if you,
slartibart70, have a huge incentive to improve the current default avatar set
(you're not the only one, who wants that), I would encourage you to open up a
new wishlist item and start this one with a more friendly tone. I hope this is
also in the interest of the other devs and designers.

In any case it would probably be better to not only open a new wishlist item
(which might fail to gather the needed attention without the drama ;) ), but to
directly create a new set of avatars, which you think are preferable. If you
aren't a designer yourself, maybe you can organize like-minded designers for
this project. We have several tools and communication channels to help you on
that.

In general I would like to try to encourage people like you with a drive for
something to join the development process instead of just closing them out
because of some first imprudent harsh words.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D5321: [Notifications Applet] Don't crash when containment() disappears

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Heh, finally found the bug.
  
  I was a bit wrong.
  QObject::destroyed() is emitted before we delete the children.
  
  But that still doesn't explain everything, the containment won't get deleted 
till after the child applet is deleted; so why would containment() be null?
  We know it's not deleted yet, so it's not really "gone" like your comment 
says,
  
  The issue is that containment() is a qobject_cast recursive search of 
parents. (for some reason)
  
  qobject_cast calls metaobject() which is virtual. Calling a virtual method 
during an objects destructor can result in unexpected behaviour. 
  Our parent is still valid, but we've called Containment::~Containment, 
Applet::~Applet  and we're currently in QObject::~QObject, so when we call a 
method on a base class it doesn't get dynamically dispatched as it should.
  
  So when we call parent()->metaObject() we now get the metaobject for QObject 
not the metaobject of Containment.
  
  This means the qobject_cast fails, and that's why Applet::containment() is 
null even though the containment is still there.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5321

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Breeze] [Bug 378606] Please replace those childish avatar images

[Gregor Mi]

https://bugs.kde.org/show_bug.cgi?id=378606

--- Comment #14 from Gregor Mi  ---
last link was wrong, sorry. Here is the correct one:
https://openclipart.org/search/?query=penguin

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 378606] Please replace those childish avatar images

[Gregor Mi]

https://bugs.kde.org/show_bug.cgi?id=378606

Gregor Mi  changed:

   What|Removed |Added

 CC||codestr...@posteo.org

--- Comment #13 from Gregor Mi  ---
I just searched for alternative user icons and found this:

https://openclipart.org/search/?query=user%20icon

There are a few good looking icons the represent a user. I wonder if anything
speaks against using some of these icons to extend the gallery in the reddit
post from the last commentor?

According to https://openclipart.org/may-clipart-be-used-comparison and
https://openclipart.org/may-clipart-be-used-comparison it should be possible.

Ah, here are some cool and versatile penguins:
https://openclipart.org/search/?query=user%20icon :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

D5330: [QDBusMenuBar] Don't wait for (un)register call to finish

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> davidedmundson wrote in qdbusmenubar.cpp:193
> I don't understand why this is also here. You'll have always do line 199 
> first.

Edit: My English made no sense.

I meant:
You also unregister the object on line 199. That line will always be called 
before this line.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D5330

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5333: [Plasma Windowed] Disable standard actions on SNI

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in plasmawindowedview.cpp:115
> or we could just not manually add our own close entry? Would be less code and 
> give us the minimzeRestore thing too?

SNI's default action would *quit* the app but one plasma-windowed instance can 
host multiple applet windows, each of which can show an SNI.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5333

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5333: [Plasma Windowed] Disable standard actions on SNI

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> plasmawindowedview.cpp:115
>  m_statusNotifier = new 
> KStatusNotifierItem(applet->pluginMetaData().pluginId(), this);
> +m_statusNotifier->setStandardActionsEnabled(false); // we add our 
> own "Close" entry manually below
>  

or we could just not manually add our own close entry? Would be less code and 
give us the minimzeRestore thing too?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5333

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5330: [QDBusMenuBar] Don't wait for (un)register call to finish

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> qdbusmenubar.cpp:169
> +qDebug() << "Register finished" << watcher->isError() << 
> watcher->error().name();
> +
> +if (watcher->isError()) {

you leak this watcher

> qdbusmenubar.cpp:193
> + qUtf8Printable(watcher->error().name()), 
> qUtf8Printable(watcher->error().message()));
> +QDBusConnection::sessionBus().unregisterObject(m_objectPath);
> +}

I don't understand why this is also here. You'll have always do line 199 first.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D5330

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Breeze] [Bug 378606] Please replace those childish avatar images

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=378606

David Edmundson  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 378606] Please replace those childish avatar images

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=378606

David Edmundson  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX
 CC||k...@davidedmundson.co.uk

-- 
You are receiving this mail because:
You are the assignee for the bug.

D5380: [platforms/drm] Explicitly request event context version 2

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:c8cd474acd0c: [platforms/drm] Explicitly request event 
context version 2 (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5380?vs=13288&id=13307

REVISION DETAIL
  https://phabricator.kde.org/D5380

AFFECTED FILES
  plugins/platforms/drm/drm_backend.cpp

To: graesslin, #kwin, #plasma, fooishbar, subdiff
Cc: plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol

Re: Default touch screen edge gestures

[Martin Gräßlin]

Am 2017-04-10 17:28, schrieb Marco Martin:

On Saturday 08 April 2017, Martin Gräßlin wrote:

Hi Plasmates,

now that we have touch screen edge swipe gesture support both on X11 
and

Wayland we could define which actions to put on each edge.

My suggestion would be to put a sensible action on each of the four
actions.

Personal proposal:


i would expect it trying to mirror what is the default arrangement of 
panels
(doesn't have to follow the configuration or anythig fancy, just do it 
for the

default)

like, being the panel by default at the bottom and the taskbar taking 
most of
it, i would expect some form of window switching there, either alt+tab 
or

present windows.

mirroring could be
top -> krunner


krunner is - sorry to say - useless with touch screens.


left->activities


We have support for Activity Manager so that could be possible. Though 
given Ivan's comment about good defaults on first tries I'm not sure 
whether Activities are the features to put on one of four possible 
actions.



bottom->present windows
right->hmm, some desktop switcher?


If we think long term with the ideas of merging Desktops and Activities 
might be an idea to not provide both Activities and Desktops.


Cheers
Martin

Re: Default touch screen edge gestures

[Martin Gräßlin]

Am 2017-04-10 17:14, schrieb Marco Martin:

On Saturday 08 April 2017, Martin Gräßlin wrote:

Hi Plasmates,

now that we have touch screen edge swipe gesture support both on X11 
and

Wayland we could define which actions to put on each edge.

My suggestion would be to put a sensible action on each of the four
actions.



as confusion on the matter is always there, always better to reinstate
explicitly, this would be only for touch *screen*, and not touchpad, 
right?


Yes this for touch *screen* and not touchpad. For touchpad the gestures 
are implemented as discussed at Affenfels, see: 
https://notes.kde.org/p/plasma_affenfels


Cheers
Martin

Re: Default touch screen edge gestures

[Marco Martin]

On Monday 10 April 2017, Aleix Pol wrote:
> On Mon, Apr 10, 2017 at 4:54 PM, Martin Gräßlin  wrote:
> > Am 2017-04-10 16:26, schrieb Aleix Pol:
> >> Shouldn't it depend on the current configuration?
> >> For example, I would expect the Application launcher to be triggered
> >> wherever the panel is present...
> > 
> > We don't have this information available. We might know that there is a
> > panel, but we don't know whether there is a application launcher in it.
> 
> We can make it so there's such information, we shouldn't plan for the
> information we have now... Otherwise we'll always be playing catch up
> with ourselves.

well, it's a good thing to have, but very for a second time (i would put it 
into the l&f as usual)

what matters is that the default setup is in line with the default layout 
(either out default or the distro default)

then if the user wants to configure weird thiings, his config shouldn't 
magically change under his feets

-- 
Marco Martin

[Breeze] [Bug 378606] Please replace those childish avatar images

[Roman Gilg]

https://bugs.kde.org/show_bug.cgi?id=378606

Roman Gilg  changed:

   What|Removed |Added

 CC||subd...@gmail.com

--- Comment #12 from Roman Gilg  ---
We had this discussion in the past already:
https://www.reddit.com/r/kde/comments/53gth9/personal_opinion_please_dont_use_this_icon_as/

Apparently nobody could be found to work on a consistent more professional
looking set of avatars.

IIRC that the neutral one was shown as default in the past was a bug, that got
fixed by David.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D5388: Cancel popup if the user clicked window decoration of parent window

[Martin Gräßlin]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  So far the window decoration was not considered and e.g. right clicking
  the window decoration resulted in two open popups - one by KWin and one
  by the application. This change addresses the problem by ensuring the
  popup gets cancelled if the decoration is clicked. It's considered not
  being part of the window.

TEST PLAN
  Added test case which fails without the change

REPOSITORY
  R108 KWin

BRANCH
  popup-cancel-deco

REVISION DETAIL
  https://phabricator.kde.org/D5388

AFFECTED FILES
  autotests/integration/pointer_input.cpp
  popup_input_filter.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol

Re: Default touch screen edge gestures

[Aleix Pol]

On Mon, Apr 10, 2017 at 4:54 PM, Martin Gräßlin  wrote:
> Am 2017-04-10 16:26, schrieb Aleix Pol:
>>
>> Shouldn't it depend on the current configuration?
>> For example, I would expect the Application launcher to be triggered
>> wherever the panel is present...
>
>
> We don't have this information available. We might know that there is a
> panel, but we don't know whether there is a application launcher in it.

We can make it so there's such information, we shouldn't plan for the
information we have now... Otherwise we'll always be playing catch up
with ourselves.

Aleix

[Breeze] [Bug 378606] Please replace those childish avatar images

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=378606

--- Comment #11 from Kai Uwe Broulik  ---
Ah, it has usesPlasmaTheme: false and because of its large size it picks the
the huge blue one?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 378606] Please replace those childish avatar images

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=378606

--- Comment #10 from Kai Uwe Broulik  ---
Ah, it has usesPlasmaTheme: false and because of its large size it picks the
the huge blue one?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 378606] Please replace those childish avatar images

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=378606

--- Comment #9 from Kai Uwe Broulik  ---
What I don't understand is where that icon is coming from. The
places/user-identity and actions/user-identity are still the same, for some
reason it now picks the applets/user-identity icon o.O

Also, the user.svgz still has the correct user-identity icon in there. Marco,
any idea?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Default touch screen edge gestures

[Marco Martin]

On Saturday 08 April 2017, Martin Gräßlin wrote:
> Hi Plasmates,
> 
> now that we have touch screen edge swipe gesture support both on X11 and
> Wayland we could define which actions to put on each edge.
> 
> My suggestion would be to put a sensible action on each of the four
> actions.
> 
> Personal proposal:

i would expect it trying to mirror what is the default arrangement of panels 
(doesn't have to follow the configuration or anythig fancy, just do it for the 
default)

like, being the panel by default at the bottom and the taskbar taking most of 
it, i would expect some form of window switching there, either alt+tab or 
present windows.

mirroring could be
top -> krunner
left->activities
bottom->present windows
right->hmm, some desktop switcher?

-- 
Marco Martin

[Breeze] [Bug 378606] Please replace those childish avatar images

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=378606

--- Comment #8 from slartibar...@gmail.com ---
I added screenshots of previous avatar icons, perfectly in harmony with breeze
icon set. Something like this should remain the default, not some random choice
out of a list. (just my 2 cents)

@Jens.. please add some penguins to the avatar list, would be fun! (seriously)

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Default touch screen edge gestures

[Marco Martin]

On Saturday 08 April 2017, Martin Gräßlin wrote:
> Hi Plasmates,
> 
> now that we have touch screen edge swipe gesture support both on X11 and
> Wayland we could define which actions to put on each edge.
> 
> My suggestion would be to put a sensible action on each of the four
> actions.
> 

as confusion on the matter is always there, always better to reinstate 
explicitly, this would be only for touch *screen*, and not touchpad, right?

-- 
Marco Martin

[Breeze] [Bug 378606] Please replace those childish avatar images

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=378606

--- Comment #7 from slartibar...@gmail.com ---
Created attachment 104948
  --> https://bugs.kde.org/attachment.cgi?id=104948&action=edit
avatar2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 378606] Please replace those childish avatar images

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=378606

--- Comment #6 from slartibar...@gmail.com ---
Created attachment 104947
  --> https://bugs.kde.org/attachment.cgi?id=104947&action=edit
avatar1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 378606] Please replace those childish avatar images

[Jens Reuterberg]

https://bugs.kde.org/show_bug.cgi?id=378606

--- Comment #5 from Jens Reuterberg  ---
I'm not entirely certain which are the "technical" ones you refer - is it the
B/W then thank you I made them. 
I rather disagree with you except on one point - the default avatar - I think
that was just chosen more or less at random at the time and was the stock/base
out of which the "famous people" avatars where made (Gandhi, Da Vinci etc)

That leaves us with the issue of which one to chose. B/W penguin?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Default touch screen edge gestures

[Martin Klapetek]

On Sat, Apr 8, 2017 at 1:40 PM, Ivan Čukić  wrote:

> Hi Martin,
>
> I think this needs more in-depth investigation. We've had a couple of,
> I'd say, knee jerk shortcuts pushed to master without much thought
> about them (Alt+Space for KRunner, Meta+number for tasks).
>

Whoa, Alt+Space was discussed at length during a sprint (in Pineda iirc) and
couple other Plasma meetings and a clear improvement over then-current
Alt+F2 was observed. This was anything but "without much thought".

Cheers
--
Martin Klapetek

[Breeze] [Bug 378606] Please replace those childish avatar images

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=378606

--- Comment #4 from slartibar...@gmail.com ---
Agreed, 
it's not your fault if distros choose silly avatar icons.

I mean, the samples you showed in http://i.imgur.com/eOZn8D8.png are the
problem i am speaking of. No offence, but why are the blue/green icons the ones
chosen by default (esp. the 'user' icon)?
What about a more 'technical' looking avatar/icon that is taken first?

See, you/the plasma team have come to great lengths choosing an appropriate
style for the whole user experience. The icon sets, the themes, the colors...
maybe not to everyones taste, but uniform (btw, i like it!)

And now, we start greeting a first time user to plasma with the blue/green user
avatar? A hairless bloke with a big nose
I have no problem choosing another avatar, but you should think of new users of
the plasma DE and their first impressions. The 'other' DE's are a bit more on
the 'serious side', you can select - even silly - images if you don't agree to
the default avatar. But the default looks just suitable to the rest of the DE
experience.

I completely agree with funny or silly avatar icon sets. Please keep them in
the selection. I don't even mind the hairless bloke in the list. But give the
users a fitting initial choice and don't rely on the distributions to provide
proper avatars.

I mean, take the previous (<5.9.4) technical avatar image consisting of just
circles. Clean, fitting to the breeze icon set. Just... OK. Not fancy, nothing
too shiny. And gender neutral.

Even if you - as a user - wouldn't care about avatars you weren't forced to
change it, because it was a technical thing and not disturbing. Now, every time
you open the application-kicker menu or lock the screen, this blue/green avatar
thingy grins at you.

I have the feeling, that now you push users to make an active approach into
changing this.
If this was the intention, then you succeeded...


Please do understand: I am very happy with the new plasma experience, the
modifications and the experiments and their implications. For example, it also
took some time for the logoff dialog to become what it is today.
I see this avatar stuff pretty similar, it will change eventually into
something proper.
But as far as i am concerned, i would opt for a 'breezy' looking avatar as a
default. Something non-disturbing when you open menus or lock your screen. This
shouldn't be too hard, should it? Just take the old one for starters

Anyway, thanks for the comments!
I didn't expect a discussion to start, so please accept my apologies if the
initial bugticket was too harsh. But i think opinions need to be shared...

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Default touch screen edge gestures

[Martin Gräßlin]

Am 2017-04-10 16:26, schrieb Aleix Pol:

Shouldn't it depend on the current configuration?
For example, I would expect the Application launcher to be triggered
wherever the panel is present...


We don't have this information available. We might know that there is a 
panel, but we don't know whether there is a application launcher in it.


Cheers
Martin

[Powerdevil] [Bug 378445] kscreenlocker_greet occasionally freezes in malloc in signal handler

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=378445

Martin Gräßlin  changed:

   What|Removed |Added

 Status|NEEDSINFO   |UNCONFIRMED
 Resolution|FIXED   |---
Product|kscreenlocker   |Powerdevil
  Component|greeter |general
   Assignee|plasma-b...@kde.org |plasma-devel@kde.org

--- Comment #6 from Martin Gräßlin  ---
reassigning to powerdevil as it seems to be inside upower dbus handling

-- 
You are receiving this mail because:
You are the assignee for the bug.

D5382: Improve password dialogs

[Kai Uwe Broulik]

broulik added a comment.


  I like!
  
  Not sure about the "Authenticate %1" naming. Also, "For accessing the *VPN* 
connection" (ie. capital). Also, add a colon at the end "password below:"
  
  (Is there a way to get rid of the "KDE Daemon" caption and replace it by 
something more meaningful?)

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D5382

To: jgrulich, #plasma, #vdg
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D5377: Using proper checkboxes with labels instead of labels plus checkboxes

[Ivan Čukić]

ivan abandoned this revision.
ivan added a comment.


  Pushed without going through Phab, so Phab has no clue.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5377

To: ivan, mart, hein, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5382: Improve password dialogs

[Jan Grulich]

jgrulich edited the summary of this revision.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D5382

To: jgrulich
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5378: Adding an option to show popular documents/apps for Kicker and Dash

[Marco Martin]

mart added a comment.


  two small feedback pieces:
  
  1. not sure about the term "popular" as it would suggest most used by many 
people, while this is just about one user, would "most used" be better?
  2. let's try to make this default?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5378

To: ivan, hein, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5378: Adding an option to show popular documents/apps for Kicker and Dash

[Eike Hein]

hein added a comment.


  Agreeing with Marco re "Most used", also because I can see "Popular" being an 
i18n challenge. In other languages the word that most closely maps to Popular 
might have an even more different sentiment from actually-most-used.
  
  I'm kind of confused by the settings UI. Show ... first? As opposed to what? 
The bottom?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5378

To: ivan, mart, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Breeze] [Bug 378606] Please replace those childish avatar images

[Jens Reuterberg]

https://bugs.kde.org/show_bug.cgi?id=378606

Jens Reuterberg  changed:

   What|Removed |Added

 CC||jens...@kolabnow.com

--- Comment #3 from Jens Reuterberg  ---
We have a rather eclectic mix of avatars to chose from
http://i.imgur.com/eOZn8D8.png , anyone can suggest more images if they want
to.

We are serious. Any distro can, if they choose, define WHAT kind of user they
prefer. If you want to stick to "as serious as possible" you can just keep the
B/W avatars. You can even remove every single avatar except one or two that you
prefer.

We are a DE, we don't tell distros what they're user group should be and we
have added up a few avatars that we felt like doing - our job is to ensure
that.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Default touch screen edge gestures

[Aleix Pol]

On Sat, Apr 8, 2017 at 11:24 AM, Martin Gräßlin  wrote:
> Hi Plasmates,
>
> now that we have touch screen edge swipe gesture support both on X11 and
> Wayland we could define which actions to put on each edge.
>
> My suggestion would be to put a sensible action on each of the four actions.
>
> Personal proposal:
>
> *Left Edge:*
> Window Switching as the default alt+tab theme is on the left side. Also on
> Windows 10 this happens on the left edge.
>
> *Top Edge:*
> Present Windows as 4 finger swipe downwards on touchpad triggers present
> windows.
>
> *Bottom Edge:*
> Desktop Grid as 4 finger swipe upwards on touchpad triggers desktop grid.
>
> *Right Edge:*
> Application launcher
>
>
> What I dislike about the proposal is: Present Windows and Alt+Tab are kind
> of redundant. Given that a better default edge would be nice for top edge.
> KRunner would be a nice fit as it's also on top, but it's rather useless on
> touch.
>
> The application launcher is rather disconnected in the default setup if we
> swipe in from left screen. What I personally would prefer if we could
> trigger the application dashboard. Of course we still don't have working
> touch support in the application launchers, so if we go for that we need
> fixing (same applies for alt+tab btw.).
>
> So please comment and propose your own ideas.
>
> Cheers
> Martin
>

Shouldn't it depend on the current configuration?
For example, I would expect the Application launcher to be triggered
wherever the panel is present...

Aleix

[Breeze] [Bug 378606] Please replace those childish avatar images

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=378606

Christoph Feck  changed:

   What|Removed |Added

   Target Milestone|1.0 |---
   Assignee|k...@davidedmundson.co.uk|plasma-devel@kde.org
  Component|general |general
Product|plasmashell |Breeze
   Severity|major   |wishlist

--- Comment #2 from Christoph Feck  ---
Replace with what? If you have images to propose, with a free license, please
contribute them.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Default touch screen edge gestures

[Ivan Čukić]

> That's exactly why I put up this thread!

I know, I just wanted to make the background of mail clear as well :)

> Wishful thinking :-) I wanted to have that for years:

:)

> Personally I think that this will be a feature which we will advertise
> in the release announcement and we must define some default gestures,

I agree, and window switching is Ok. I'm weary of 'reserving' the
other defaults. What I'd like, and why I support the gesture for
alt-tab is that it can be expanded on later.

If we take three different gestures to do almost the same thing, and
make the fourth one start the application launcher on the opposite
side of the screen (by default), the later expansion and polishing
will be problematic.

Cheers,
Ivan

D5088: Generate plugins.qmltypes files for the plugins we install

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:2df613f9381f: Generate plugins.qmltypes files for the 
plugins we install (authored by apol).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5088?vs=12569&id=13299

REVISION DETAIL
  https://phabricator.kde.org/D5088

AFFECTED FILES
  CMakeLists.txt
  src/declarativeimports/calendar/CMakeLists.txt
  src/declarativeimports/calendar/plugins.qmltypes
  src/declarativeimports/core/CMakeLists.txt
  src/declarativeimports/core/plugins.qmltypes
  src/declarativeimports/plasmacomponents/CMakeLists.txt
  src/declarativeimports/plasmacomponents/plugins.qmltypes
  src/declarativeimports/plasmaextracomponents/CMakeLists.txt
  src/declarativeimports/plasmaextracomponents/plugins.qmltypes
  src/declarativeimports/platformcomponents/CMakeLists.txt
  src/declarativeimports/platformcomponents/plugins.qmltypes

To: apol, #plasma, #frameworks, davidedmundson
Cc: davidedmundson, hein, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5382: Improve password dialogs

[Kai Uwe Broulik]

broulik added reviewers: Plasma, VDG.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D5382

To: jgrulich, #plasma, #vdg
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5380: [platforms/drm] Explicitly request event context version 2

[Roman Gilg]

subdiff accepted this revision.

REPOSITORY
  R108 KWin

BRANCH
  drm-event-version-plasma-5.8

REVISION DETAIL
  https://phabricator.kde.org/D5380

To: graesslin, #kwin, #plasma, fooishbar, subdiff
Cc: plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol

D5381: Add brightness control using ddcutil lib

[Kai Uwe Broulik]

broulik added a comment.


  Cool!

INLINE COMMENTS

> ddcutilbrightness.cpp:7
> +{
> +QList m_displayHandleList = 
> QList();
> +QList m_displayInfoList = QList();

No need to explicitly initialize these, the constructor could just remain empty

> ddcutilbrightness.cpp:17
> +
> +void DDCutilBrightness::detect(){
> +

Coding style, opening brace for functions on next line:

  void DDCUtilBrightness:detect()
  {
  ...
  }

> ddcutilbrightness.cpp:22
> +DDCA_Display_Ref dref;
> +DDCA_Display_Handle dh = NULL;  // initialize to avoid clang analyzer 
> warning
> +

Prefer `nullptr`

> ddcutilbrightness.cpp:26
> +
> +qCWarning(POWERDEVIL)<<"\nCheck for monitors using 
> ddca_get_displays()...\n";
> +// Inquire about detected monitors.

Coding style:

  qCWarning(POWERDEVIL) << "...";

Also, no need for the line breaks? Also, should rather be `qCDebug` or 
`qCInfo`, it's not a warning after all

> ddcutilbrightness.cpp:31
> +qCWarning(POWERDEVIL) +for(int iDisp=0;iDispct;iDisp++)
> +{

Coding style:

  for (int i = 0; i < ...; ++i) {

(brace on the same line for everything else, ie. `for`, `while`, `if`)

> ddcutilbrightness.cpp:37
> +
> +m_displayInfoList.append(dlist->info[iDisp]);
> +

Perhaps `clear()` the list at the beginning of this method? Also, use 
`reserve()` if you already know how many items you're going to append to the 
list

> ddcutilbrightness.cpp:52-53
> +"): "<< ddca_status_code_desc(rc);
> +}
> +else {
> +char * dref_repr = ddca_repr_display_ref(dref);

Coding style, braces on the same line:

  } else {

Also, I would prefer if you returned (and or use continue in a loop) instead of 
nesting if after if, ie.

  if (!foo) {
  return;
  }
  if (!bar) {
  return;
  }

instead of

  if (!foo) {
  if (!bar) {
  ...

> ddcutilbrightness.cpp:73
> +
> +m_descrToVcp_perDisp.append(new QMap);
> +m_vcpTovcpValueWithDescr_perDisp.append(new QMap QMap*>);

You don't seem to be cleaning up those containers in the destructor (there is 
none). Also, I don't think you should allocate those on the heap

> ddcutilbrightness.cpp:139
> +{
> +return (m_displayHandleList.count()!=0);
> +

`return !m_displayHandleList.isEmpty();`

> ddcutilbrightness.h:1
> +
> +#ifndef DDCUTILBRIGHTNESS_H

Missing copyright header in this and other files

> ddcutilbrightness.h:2
> +
> +#ifndef DDCUTILBRIGHTNESS_H
> +#define DDCUTILBRIGHTNESS_H

Feel free to use `#pragma once` in PowerDevil code :)

> ddcutilbrightness.h:22
> +
> +QList m_displayHandleList;
> +QList m_displayInfoList;

Prefer `QVector` over `QList`

> powerdevilupowerbackend.cpp:217-218
> +brightnessJob->start();
> +}
> +else{
> +qCDebug(POWERDEVIL) << "Using DDCutillib";

Coding style:

  } else {

> powerdevilupowerbackend.cpp:382
>  QList controls = allControls.keys(controlType);
> -
> +
>  if (controls.isEmpty()) {

Whitespace

> powerdevilupowerbackend.cpp:413
>  int result = 0;
> -
> +
>  if (type == Screen) {

Whitespace

> powerdevilupowerbackend.cpp:716
>  {
> -m_brightnessControl->setBrightness(value.toInt());
> +if(m_brightnessControl->isSupported()){
> +m_brightnessControl->setBrightness(value.toInt());

Coding style

  if (m_brightnessControl->isSupported()) {

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D5381

To: dvogel, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Minutes Monday Plasma Meeting

[Sebastian Kügler]

Hey Friends,

Here are the minutes and log of today's meeting.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org
Plasma Team meeting, 20-302017

Present: notmart, Sho, bshah

notmart:
* [Qt] eaten events qt patch https://codereview.qt-project.org/#/c/185946/
* [Qt] Add NOTIFY signals for WheelArea 
https://codereview.qt-project.org/#/c/189158/ MERGED
* [Qt] Environment variable enabling the workaround FBO readback bug 
https://codereview.qt-project.org/#/c/185259/ MERGED
* MERGED better layout and animate keyboard in sddm
* MERGED better layout and animate keyboard in lockscreen
* Multiscreen fix: corner case of primary screen at 0,0 that moves the other 
(another case in which would be nice to test with 3 or more) 
https://phabricator.kde.org/D5323
Diff 5323 "Correctly handle when a new primary screen displaces the old" 
[Closed] https://phabricator.kde.org/D5323
* Kirigami2: bugfixes,
** in ScrollablePage whith multiple children of which only one is the scrollable
** support for high dpi icons in the desktop version
** better at opening the drawers with tap
** MERGED ApplicationItem AbstractApplicationItem, Gemini starting using them
* had to rebuild whole stack, wasted a couple of days

Sho:
* [FV] Fixed the actions overlay icons sometimes appearing in the drag pixmap 
attached to the cursor during DND, needs review
* [FV] Fixed a regression causing popups to close when dragging into them via 
spring-loading, needs review
* [FV] Some code simplification/cleanups
* [Input] On Martin's request, wrote a many-page overview over the state of 
complex text input in Plasma and what needs to be done (especially for 
Wayland): https://mail.kde.org/pipermail/plasma-devel/2017-April/068978.html to 
kick off discussion
** Participated in said discussion
** Pointed people (e.g. the ibus maintainer) at this discussion via IRC and 
email poking and https://blogs.kde.org/2017/04/06/complex-text-input-plasma
*** Happy to say we got lead devs of both fcitx and ibus involved
* [Input] Helped csslayer test some kimpanel changes to better autostart our 
ibus panel frontend
* [Input] Talked with notmart and csslayer about how we can start integrating 
Input Method Panel and System tray to provide consistent layout and behavior 
and eliminate redundant icon hiding systems, which is one of the lower-hanging 
fruit in the input story
* [Launchers] Working on some Simple Menu UI changes/experiments
* [Launchers] Me, Marco and Ivan decided together to delay per-activity faves 
until 5.11 - particularly the migration story is not fully cooked yet, and we 
can no longer merge it early enough in the cycle to get sufficient testing
* [Launchers] Instead we're working to expose "most used" data better in the 
launchers for 5.10

bshah:
- 1st thing I was working on the archlinux rootfs for plasma mobile
- I am now able to run kwin/wayland and plasmashell
but..
problem is xwayland is not started if session/kwin is started by simplelogin
resulting in kwin_wayland quitting
if I start kwin_wayland manually it starts fine
- I will investigate that over next week
- Next thing is
After Canonical stopped development of ubuntu touch, ubports team is looking 
forward with closer collaboration on base stack
Basically, android part of the Plasma Mobile/Ubuntu Touch or Mer

romangg:
- Xwayland research and working on direct scanout - plan on doing more this week

kbroulik:
- Did some fixes here and there, plasma-windowed and Folder View
- Ported kwin scripts importer to new KPackage stuff so it actually works 
(D5318 few minor issues need addressing before it can go in)
Diff 5318 "[KWin Scripts KCM] Restore "import" option" [Needs Revision] 
https://phabricator.kde.org/D5318
- We now have KWin desaturate windows of frozen apps on X \o/ go check it out 
kill -SIGSTOP something and click the X button ;)
- Animated quick tiling outline (++beauty) D5262
- Diff 5262 "Animate quick tiling outline" [Needs Review] 
https://phabricator.kde.org/D5262
- Some pending patches D5333, D5331, D5330, D5321
Diff 5333 "[Plasma Windowed] Disable standard actions on SNI" [Needs 
Review] https://phabricator.kde.org/D5333
Diff 5331 "Whitelist all Keyboard Layout Switcher shortcuts" [Needs Review] 
https://phabricator.kde.org/D5331
Diff 5330 "[QDBusMenuBar] Don't wait for (un)register call to finish" 
[Needs Review] https://phabricator.kde.org/D5330
Diff 5321 "[Notifications Applet] Don't crash when containment() 
disappears" [Needs Review] https://phabricator.kde.org/D5321
- Had a look at d_ed's browser extension work and started working on a KRunner 
that finds open browser tabs (e.g. "open windows runner" for browser tabs) and 
allows switching to them. Will continue on that, I guess.





[12:00:16]  hey
[12:00:37]  yo sebas
[12:01:19]  oh, 12:00
[12:01:21]  meeting?
[12:01:23]  right :)
[12:01:24]  yup
[12:01:25]  yup
[12:01:28]  Who's here for it?
[12:01:32]  me me me
[12:01:33] -*- sebas obviously!
[12:01:35]  i'm here
[12:01:55]  kbr

D5382: Improve password dialogs

[Jan Grulich]

jgrulich created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Improve UI of all paswords dialogs. Previously we had two methods to setup UI
  of the dialog, either for VPN or for regular connections like WiFi. I merged
  them into one and both are now based on same UI, except that VPN connections
  insert their specific widget into the dialog, while regular connections use
  only one password field.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  password-dialogs

REVISION DETAIL
  https://phabricator.kde.org/D5382

AFFECTED FILES
  kded/passworddialog.cpp
  kded/passworddialog.h
  kded/passworddialog.ui
  kded/secretagent.cpp
  vpn/openconnect/openconnectauth.ui
  vpn/ssh/sshauth.ui
  vpn/sstp/sstpauth.ui
  vpn/strongswan/strongswanauth.ui

To: jgrulich
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5381: Add brightness control using ddcutil lib

[Dorian Vogel]

dvogel created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Setting up ddcutil  for non-root CLI use is required 
first. 
  Please refer to https://github.com/d-vogel/QMLddcutil/blob/master/README.md 
 section.
  
  Limitations:
  Not tested for multiple DDC capable monitors setup, should only change 
brightness of first monitor anyway.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D5381

AFFECTED FILES
  daemon/backends/CMakeLists.txt
  daemon/backends/upower/ddcutilbrightness.cpp
  daemon/backends/upower/ddcutilbrightness.h
  daemon/backends/upower/powerdevilupowerbackend.cpp
  daemon/backends/upower/powerdevilupowerbackend.h

To: dvogel, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 707 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/707/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 10 Apr 2017 10:41:55 +
Build duration: 15 min

CHANGE SET
Revision fb2f3718a782a4f913283ce115643e7298422f57 by ivan.cukic: (Checkboxes 
should have labels for the larger click area)
  change: edit kcms/workspaceoptions/mainpage.ui


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

D5377: Using proper checkboxes with labels instead of labels plus checkboxes

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5377

To: ivan, mart, hein, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5355: Fix query for available modules

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R126:19a6bb179d5f: Fix query for available modules (authored 
by aacid).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D5355?vs=13238&id=13290#toc

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5355?vs=13238&id=13290

REVISION DETAIL
  https://phabricator.kde.org/D5355

AFFECTED FILES
  kcmshell/main.cpp

To: aacid, apol
Cc: apol, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: Complex text input in Plasma

[Takao Fujiwara]

On 04/07/17 22:46, Martin Gräßlin-san wrote:

Am 2017-04-07 07:56, schrieb Takao Fujiwara:

Due to that: no chance for IM controlling part of our stack. We control the IM.


Probably I think this way would not work with IBus.
Each IBus IME are called by IBus dbus method. You hardly ask each IME
maintainer to change the protocol.
IBus daemon would be the controller of IBUs IMEs.


I think I need to describe in a better way how I envision the future 
architecture.

I want to have the IM daemon merged into the wayland compositor. So KWin would 
talk directly with the IM through library calls and the composed text
would be sent from KWin to the application through the Wayland text-input 
protocol.


Probably I'd think KWin does not have to merge IM daemon and I hope we can make 
DBus proceses more secure.
Also I think virtual keyboards does not need to implement IM and they can 
enable IM with the shortcuts outside IM implementations.

Probably you have to support copy & paste between applications and support 
protocols between processes.



I want to eliminate the IPC between applications and IM daemon.

If we are going to touch this code we can strive for the best solution and not 
keep stuck on the approach used on X11. And yes that might need
adjusting the IMEs. But they need to be adjusted anyway. We wouldn't have this 
discussion if it would just work on Wayland.


I guess just implementing Plasma Wayland with the current IM modules also will 
causes many regressions as GNOME did.

Thanks,
Fujiwara



Cheers
Martin

Re: Complex text input in Plasma

[Takao Fujiwara]

On 04/09/17 01:46, Martin Gräßlin-san wrote:

Am 2017-04-08 17:26, schrieb Weng Xuetian:


You're wrong about the QT_IM_MODULE stuff. To make application to use the
wayland protocol to type (text-input), the implementation must be done with
QT_IM_MODULE=wayland. I don't mind if it is set to certain application but set
it in general won't work. Also to have real virtual keyboard , you need to let
the input method daemon to provides a virtual keyboard implementation.


No you are wrong about that one :-) It might be that it used to be like that, 
but Wayland is the default if no QT_IM_MODULE is specified. See
https://code.qt.io/cgit/qt/qtwayland.git/tree/src/client/qwaylandintegration.cpp#n142



And also, merging more and more daemon into kwin is not always good even from
security point of view. The problem is, once it got merged, the whole memory
space is being exposed. Which means, if there's a single piece of code is
vulnerable, it will affect the whole compositor. We are not perfect people, and
that's why put more code together will make it more vulnerable to attacker. If
you consider that, your prevention of ptrace on kwin becomes nothing and so
does your effort to make kwin not loading some random plugin (prevent
ld_preload and qt_plugins_path?).


The security of the system breaks with the weakest link. Whether the IM daemon 
is insecure by running standalone or inside KWin isn't a difference.


I think the weakest link still can make more secure in the protocol.
I'd suggest to make Plasma Wayland with the current IM modules in the first 
stage since I guess there will be many regressions in Plasma Wayland.
Currently I'm also involved a discussion how to secure the DBus in the GNOME 
side and I also think it could be utilized for Plasma Wayland.

Otherwise I think it might be difficult to support Plasma in some distributions.

Wayland staffs has contributed in the IBus and GNOME connection for a long time 
ago.
https://github.com/ibus/ibus/tree/master/client/wayland
But it's not used in GNOME yet.