D7316: Avoid sending data offers from an invalid source.

[David Edmundson]

davidedmundson created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  A DataDevice will have a source when offers are available, but it can
  also be legitimately cleared.
  
  When calling DataDeviceInterface::sendSelection(DataDeviceInterface
  *other) if the other data device has no source, we should be setting
  that we also have no source.
  
  In addition this also guards against Seat tracking a DataDeviceInterface
  with no source when trying to sync x clipboards.
  
  BUG: 383054

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7316

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/server/datadevice_interface.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

Re: Minutes Monday Plasma Hangout

[David Edmundson]

​Fabian also added some comments just after:
‎[12:06] ‎<‎fvogt‎>‎ * Did some strace-based profiling of plasma startup -
discovered two things:
‎[12:06] ‎<‎fvogt‎>‎ ** The applicationDir is added as first entry to the
QML and Library search paths, slowing lookups down considerably
‎[12:06] ‎<‎fvogt‎>‎ especially for libraries, as it literally opened every
file in /usr/bin/ to check whether it's a plugin...
‎[12:07] ‎<‎fvogt‎>‎ Easy workaround available, but should probably be
fixed in Qt
‎[12:08] ‎<‎fvogt‎>‎ ** KPluginLoader::forEachPlugin takes significantly
more time if all plugins are in a single directory, so there should
probably be a policy to put them into subdirs
‎[12:09] ‎<‎fvogt‎>‎ ** Plasma wayland session is now tested by openQA in
the usual Tumbleweed release process - so if you break stuff it delays our
releases, so please don't do that :P
‎[12:09] ‎<‎fvogt‎>‎ EOF

D7315: Don't duplicate UI option for automatic speed detection

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Network speed is determined automatically if "auto-negotiate" is set.
  NM Spec says if that is not set a speed and duplex should be provided.
  
  The .ui file (presumably leftover frmo something) defaulted to a speed
  of 0 with had the special text of "automatic". This isn't actually
  automatic, but just an invalid value which
  WiredConnectionWidget::isValid (I think correctly) won't accept
  
  End result is a user can't save any other settings as this widget
  reports itself as invalid.
  
  BUG: 383505

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7315

AFFECTED FILES
  libs/editor/settings/ui/wiredconnectionwidget.ui

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

Minutes Monday Plasma Hangout

[Sebastian Kügler]

Check.

-- 
sebas

http://vizZzion.org   ⦿http://www.kde.org
Plasma Team meeting, 31-7-2017

Present: notmart, Sho, kbroulik, fvogt, d_ed, bshah, sebas

notmart:
* https://codereview.qt-project.org/#/c/200788/ merged in Qt 5.9 \o/
* work mostly on the foreign rotocol implementation, to understand wayland and 
kwin better
* basic communication of foreign now works, still needs:
   ** managing any of the possible surfaces getting destroyed, every 
combination should be autotested
   ** good api kwin-side to get the relationshipbetween foreign winfows and 
being notified about changes
   ** implement kwin side
* kirigami: rework the handles look for the drawers together the VDG
* kirigami: started a branch for the "layers" concept, to complement the column 
navigation

Sho:
* [TM] Implemented support for DND reordering tasks in group popups in lib and 
applet
* [TM] Mentored argonal on a patchset for a "By Application Instance" group 
mode, guess on Phab soon
* [Launchers] No longer showing "Manage Application..." action if there's no 
app that can handle appstream:// URLs (e.g. Discover)
* [Other] ATM working on fix for bad interaction between applet (e.g. Pager) 
size hints and the free cell mechanism in the desktop containment while moving 
stuff (cf. bug 382759)
KDE bug 382759 in plasmashell (Pager) "Can't keep pager positioned in lower 
right corner of desktop" [normal,] https://bugs.kde.org/show_bug.cgi?id=382759
* [Other] Had a conf call with Ken and the KDE e.V. marketing folks, identified 
need for a Plasma product page in relation to plans for the kde.org landing 
page to become org-focused
* [Other] Spent a few hours teaching Andy Betts (VDG) some QML to make him more 
effective

d_ed:
* I got my QtWayland crash fix merged with regards to text input focus -- I 
think we just have one major QtWayland crash left
* drkonqi now has it's own repo, see ML threads
* and I've got workarounds for our animationFinished plasma crashes
* There are 2 crashes which seem to be subtly different and I've done 1
* I do want us (someone frmo plasma ) to reply to the clock font review 
requests: https://phabricator.kde.org/D6813 D6764

kbroulik:
* Fixed FV offering to create applets on drop when widgets are locked
* Did a patch for Kate to offer sessions as Jump List Actions D7203 (not fully 
sure about that yet)
* Helped d_ed investigating various Plasma crashes with Animators (when 
changing wallpaper, when finishing copy progress), Qt 5.9 regression

bshah:
- [Halium] Looking into multimedia parts (camera/recording/video)
- There is two methods I understand, droidmedia and libcompat
- Investigating which one is suitable and durable
- [PlasmaMobile] Need help for investigating issues postmarketOS people are 
having to start kwin_wayland : https://bugs.kde.org/show_bug.cgi?id=383486
KDE bug 383486 in kwin (wayland-generic) "kwin_wayland fails to start with 
"Running on a compositor with no screens is not supported"" [normal,] 
https://bugs.kde.org/show_bug.cgi?id=383486
- [Neon] Adding armhf in the neon CI WIP
- [Misc] Wrote a blog post about Akademy recap yesterday : 
http://blog.bshah.in/2017/08/13/akademy-2017-recap/



sebas
* screen rotate plasmoid works but not pretty yet
* matching artwork is in breeze now, will integrate
* my touchscreen isn't rotated when the display is, will look into that
* interview with me published on hostingadvice: 
http://www.hostingadvice.com/blog/kde-community-delivers-open-source-monopoly-free-computing/

D7306: concept of Layers

[Marco Martin]

mart created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Introduce the concept of layers: the main page row
  contents are in a StackView: normally one would push things
  as columns in the main page row, but is
  possible to push a page on top of it, covering all the
  visible columns: usable for full page viewers or temporary
  settings pages

TEST PLAN
  tried in koko, to have the main
  existing apps are unaffected

REPOSITORY
  R169 Kirigami

BRANCH
  mart/layers

REVISION DETAIL
  https://phabricator.kde.org/D7306

AFFECTED FILES
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/DesktopExampleApp.qml
  examples/gallerydata/contents/ui/ExampleApp.qml
  examples/gallerydata/contents/ui/gallery/LayersGallery.qml
  src/controls/ContextDrawer.qml
  src/controls/Page.qml
  src/controls/PageRow.qml
  src/controls/private/ActionButton.qml
  src/controls/templates/ApplicationHeader.qml
  src/controls/templates/private/BackButton.qml

To: mart, #kirigami, leinir, atulsharma
Cc: plasma-devel, apol, mart

Re: Implementing a plasma colorscheme generator

[Sebastian Kügler]

On zaterdag 5 augustus 2017 17:10:59 CEST Andrew wrote:
> On Friday, August 4, 2017 8:16:57 PM EDT Andrew wrote:
> > On Friday, August 4, 2017 7:03:43 PM EDT Aleix Pol wrote:
> > > On Fri, Aug 4, 2017 at 5:13 PM, Andrew  wrote:
> > > >> > On donderdag 3 augustus 2017 18:45:24 CEST Aleix Pol wrote:
> > > >> >> On Thu, Aug 3, 2017 at 5:48 PM, Marco Martin  
wrote:
> > > >> >> > On Thursday 03 August 2017 11:51:08 Sebastian Kügler wrote:
> > > >> >> >> Perhaps a nice addition to plasma-sdk? We already have
> > > >> >> >> cuttlefish,
> > > >> >> >> theme explorer, and the Look and Feel creator thing there, a
> > > >> >> >> color
> > > >> >> >> scheme creation tool looks right up its alley...
> > > >> >> > 
> > > >> >> > theme explorer has a color scheme editor too, so you can just
> > > >> >> > have it
> > > >> >> > as a feature of theme-explorer
> > > >> >> 
> > > >> >> I'd say the use-case for such a program is to be able to change
> > > >> >> the
> > > >> >> color scheme as the background image changes, not something people
> > > >> >> will want to use because they can't actually create a color
> > > >> >> scheme.
> > > >> > 
> > > >> > Right. So this could be an option in the Colors KCM, but then it
> > > >> > should be
> > > >> > triggered by wallpaper changes, which also means by Activity
> > > >> > changes.
> > > >> > Also, what about multiscreens? They have different wallpapers...
> > > >> 
> > > >> *Shrug* :)
> > > >> 
> > > >> Andrew?
> > > > 
> > > > Currently the program generates a colorscheme file, that can then be
> > > > selected in the Colors KCM. I think it would be best to add it as an
> > > > option to the KCM, since changing the colorscheme with the background
> > > > would get distracting and hard to do.
> > > > 
> > > > What I think I'll do is make it so you choose a single image to
> > > > generate a
> > > > colorscheme from, which is then placed in the local directory of
> > > > colorschemes and is selected in the colors KCM.
> > > 
> > > Then maybe you just want to have a specific application that does that
> > > and has an "apply" button on it? Sounds like a random feature to have
> > > in a KCM to me: A button to open an image sounds intricate.
> > > 
> > > Aleix
> > 
> > Agreed. I guess I'll just make the application callable from the KCM, and
> > have a colorscheme preview and an apply button there.
> Follow up question: should I put my code in the Colors KCM's directory, or
> elsewhere? My idea is to have a button that says "Generate colorscheme from
> Image" in the KCM, which opens a seperate window where you can select an
> image and apply the colorscheme.

I'm wondering if it would be the best option to have a small tool, a binary 
exe wich does that, and offer the option in the colors KCM if the tool is 
installed (and likewise, perhaps offer the option to adjust color scheme to 
the wallpaper from the wallpaper dialog in that case (if we deem that useful), 
and in plasma-sdk somehow?

Putting it into a library to have the code shared sounds a bit meh since it's 
super specific, the API would have to be stable, and I'm not sure if it's 
actually all that useful having a compile time dependency compared to a 
runtime dep.
-- 
sebas

http://www.kde.org | http://vizZzion.org

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

[Martin Flöser]

graesslin added a comment.


  > If your patch works, then mine would too. It's checking the exact same 
pointer, just one frame earlier.
  
  But then it's an easy thing: let's do both. Your patch and mine.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7078

To: graesslin, #kwin, #plasma, #frameworks
Cc: anthonyfieroni, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, 
hein, lukas

D7271: optionally show a history of notifications

[Julian Wolff]

progwolff added a comment.


  In https://phabricator.kde.org/D7271#135544, @davidedmundson wrote:
  
  > Cool, do you have commit access?
  
  
  I have commit access, yes

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7271

To: progwolff, #plasma, #vdg
Cc: mart, graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D7271: optionally show a history of notifications

[Julian Wolff]

progwolff updated this revision to Diff 18139.
progwolff added a comment.


  - fix typo

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7271?vs=18135=18139

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7271

AFFECTED FILES
  applets/notifications/package/contents/config/main.xml
  applets/notifications/package/contents/ui/NotificationDelegate.qml
  applets/notifications/package/contents/ui/NotificationIcon.qml
  applets/notifications/package/contents/ui/Notifications.qml
  applets/notifications/package/contents/ui/configNotifications.qml
  applets/notifications/package/contents/ui/main.qml

To: progwolff, #plasma, #vdg
Cc: mart, graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D7271: optionally show a history of notifications

[David Edmundson]

davidedmundson added a comment.


  Cool, do you have commit access?

INLINE COMMENTS

> Notifications.qml:92
> +//create a copy of the notification. 
> +//Disable actions in this copy as they will stop working once 
> the original notification ist closed.
> +notificationsHistoryModel.insert(0, {

*is

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7271

To: progwolff, #plasma, #vdg
Cc: mart, graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D7271: optionally show a history of notifications

[Julian Wolff]

progwolff updated this revision to Diff 18135.
progwolff added a comment.


  - simplify object copy

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7271?vs=18134=18135

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7271

AFFECTED FILES
  applets/notifications/package/contents/config/main.xml
  applets/notifications/package/contents/ui/NotificationDelegate.qml
  applets/notifications/package/contents/ui/NotificationIcon.qml
  applets/notifications/package/contents/ui/Notifications.qml
  applets/notifications/package/contents/ui/configNotifications.qml
  applets/notifications/package/contents/ui/main.qml

To: progwolff, #plasma, #vdg
Cc: mart, graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D7271: optionally show a history of notifications

[Julian Wolff]

progwolff updated this revision to Diff 18134.
progwolff added a comment.


  - use the same delegate for persistent notifications and history items

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7271?vs=18075=18134

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7271

AFFECTED FILES
  applets/notifications/package/contents/config/main.xml
  applets/notifications/package/contents/ui/NotificationDelegate.qml
  applets/notifications/package/contents/ui/NotificationIcon.qml
  applets/notifications/package/contents/ui/Notifications.qml
  applets/notifications/package/contents/ui/configNotifications.qml
  applets/notifications/package/contents/ui/main.qml

To: progwolff, #plasma, #vdg
Cc: mart, graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

Re: DrKonqi

[Harald Sitter]

Yay for split! Well done \o/

On Sun, Aug 13, 2017 at 10:16 PM, David Edmundson
 wrote:
> Harald, can you sort out all the cmake of both relating to your fancy unit
> test.

cmake logic is isolated inside the tests dir, so plasma-workspace and
the new drkonqi should be fine as is.

https://build.kde.org/job/Plasma%20drkonqi%20kf5-qt5%20SUSEQt5.9/1/testReport/(root)/TestSuite/drkonqi_integration_suite/

HS

D7304: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN

[David Edmundson]

davidedmundson created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Nested classes inherit the visibility of their outer class,
  so all the KClass::Private symbols have also been exported
  if the ones of KClass were.
  
  See also https://phabricator.kde.org/D7279

TEST PLAN
  Ran nm -DC to list symbols
  Only changed visibility of classes defined in .cpp files, so no client code 
should be affected.

REPOSITORY
  R127 KWayland

BRANCH
  davidedmundson/xdgv6

REVISION DETAIL
  https://phabricator.kde.org/D7304

AFFECTED FILES
  src/client/blur.cpp
  src/client/buffer_p.h
  src/client/compositor.cpp
  src/client/connection_thread.cpp
  src/client/contrast.cpp
  src/client/datadevice.cpp
  src/client/datadevicemanager.cpp
  src/client/dataoffer.cpp
  src/client/datasource.cpp
  src/client/dpms.cpp
  src/client/event_queue.cpp
  src/client/fakeinput.cpp
  src/client/fullscreen_shell.cpp
  src/client/idle.cpp
  src/client/keyboard.cpp
  src/client/output.cpp
  src/client/outputconfiguration.cpp
  src/client/outputdevice.cpp
  src/client/outputmanagement.cpp
  src/client/plasmashell.cpp
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmodel.cpp
  src/client/pointer.cpp
  src/client/pointerconstraints.cpp
  src/client/pointergestures.cpp
  src/client/region.cpp
  src/client/registry.cpp
  src/client/relativepointer.cpp
  src/client/seat.cpp
  src/client/server_decoration.cpp
  src/client/shadow.cpp
  src/client/shell.cpp
  src/client/shm_pool.cpp
  src/client/slide.cpp
  src/client/subcompositor.cpp
  src/client/subsurface.cpp
  src/client/surface.cpp
  src/client/textinput_p.h
  src/client/touch.cpp
  src/client/xdgshell_p.h

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D6899: support X-KDE-OnlyShowOnQtPlatforms

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R297:937ade5d7357: support X-KDE-OnlyShowOnQtPlatforms 
(authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D6899?vs=17177=18132#toc

REPOSITORY
  R297 KDED

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6899?vs=17177=18132

REVISION DETAIL
  https://phabricator.kde.org/D6899

AFFECTED FILES
  src/kded.cpp
  src/kded.h

To: mart, #frameworks, #plasma, davidedmundson
Cc: dfaure, plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7256: emit previously shown notifications after resume from idle

[David Edmundson]

davidedmundson added a comment.


  edit. 3 things.

INLINE COMMENTS

> notificationsengine.cpp:419
>  removeSource(source);
>  emit NotificationClosed(id, closeReason);
>  }

We need to be careful to not emit this twice. 
That would be a protocol error.

I think we'll have emitted it when the first one timed out.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7256

To: progwolff, #plasma, mart
Cc: davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D7256: emit previously shown notifications after resume from idle

[David Edmundson]

davidedmundson added a comment.


  I'm not particularly convinced.
  You watch a movie, you get some notifications, but ignore them.
  You move the mouse, you get told now completely out-of-date info.
  
  Also any notification created by KNotification with actions simply won't 
work. 
  The client side stops listening for replies after 30 seconds.
  
  Two things definitely need fixing:
  
  - with this, and your other patch - you'll get history twice, worse as your 
history shows a timestamp.
  - persistent notifications should definitely not be re-emitted as the 
original will still be there.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7256

To: progwolff, #plasma, mart
Cc: davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D7256: emit previously shown notifications after resume from idle

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  i like it!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7256

To: progwolff, #plasma, mart
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D7271: optionally show a history of notifications

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> progwolff wrote in Notifications.qml:257
> It's almost the same. Only the models differ (NotificationsModel is used in 
> NotificationDelegate, NotificationsHistoryModel is used in 
> NotificationHistoryDelegate).
> 
> I also thought it might be a good idea to use a seperate delegates here, so 
> that in the future history items might have a different visual representation 
> than persistent notifications.
> 
> If this is not wanted, we could probably make the model a property of 
> NotificationDelegate.

I don't think we would ever want a different visual representation for them, i 
would consider that a bug, as the thing looks quite busy already.

they can be the same file with just a different model property assigned

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7271

To: progwolff, #plasma, #vdg
Cc: mart, graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D7257: Set the QtQuick Controls 1 style name explicitly

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:053d54488cdd: Set the QtQuick Controls 1 style name 
explicitly (authored by fvogt).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7257?vs=18020=18130

REVISION DETAIL
  https://phabricator.kde.org/D7257

AFFECTED FILES
  startkde/startkde.cmake
  startkde/startplasma.cmake

To: fvogt, #plasma, mart
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D7271: optionally show a history of notifications

[David Edmundson]

davidedmundson added a comment.


  @notmart, click the "show older changes" and see reply to my first comment 
asking the same thing.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7271

To: progwolff, #plasma, #vdg
Cc: mart, graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D7259: Move QPainter compositor into plugin

[Marco Martin]

mart added a comment.


  +1

REVISION DETAIL
  https://phabricator.kde.org/D7259

To: graesslin, #kwin, #plasma
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D7257: Set the QtQuick Controls 1 style name explicitly

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  thanks for looking into that

REPOSITORY
  R120 Plasma Workspace

BRANCH
  warnfix

REVISION DETAIL
  https://phabricator.kde.org/D7257

To: fvogt, #plasma, mart
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D7271: optionally show a history of notifications

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> NotificationHistoryDelegate.qml:27
> +
> +PlasmaComponents.ListItem {
> +id: notificationItem

Why a different delegate for this? all the delegates, persistent or history 
should be the same

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7271

To: progwolff, #plasma, #vdg
Cc: mart, graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D6964: Force Plasma style for QQC2 in applets

[Marco Martin]

mart added a comment.


  ping?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6964

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6899: support X-KDE-OnlyShowOnQtPlatforms

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R297 KDED

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6899

To: mart, #frameworks, #plasma, davidedmundson
Cc: dfaure, plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6899: support X-KDE-OnlyShowOnQtPlatforms

[Marco Martin]

mart added a comment.


  ping?

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D6899

To: mart, #frameworks, #plasma
Cc: dfaure, plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7267: Add support for moving group members within a group.

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:592dc9e0bc79: Add support for moving group members within 
a group. (authored by hein).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7267?vs=18120=18128

REVISION DETAIL
  https://phabricator.kde.org/D7267

AFFECTED FILES
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h

To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7268: Use new libtm API to enable DND reordering within group dialogs.

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7db2a6fbe394: Use new libtm API to enable DND reordering 
within group dialogs. (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7268?vs=18121=18129

REVISION DETAIL
  https://phabricator.kde.org/D7268

AFFECTED FILES
  applets/taskmanager/package/contents/ui/MouseHandler.qml

To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7248: Microoptimise: don't change fillMode of image just before deleting itIt is still set for when a source is applied for the next transistion.

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a44d84ef4749: Don't change fillMode of image just before 
deleting it (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7248?vs=17999=18127

REVISION DETAIL
  https://phabricator.kde.org/D7248

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/main.qml

To: davidedmundson, #plasma, broulik, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

[David Edmundson]

davidedmundson added a comment.


  > of course we do that :-)
  
  We're not.
  
  Kwin does not check if a client has a selection. 
  It merely checks if the client has an interface from a selection can be 
fetched, it does not check that device actually has a valid selection.
  
  > you think that we should not even send out the DataOffer I think that's a 
separate thing,
  
  No, that's not what I think.
  We're getting crosswired. I'll submit my coment as a patch, so maybe you'll 
understand what I'm trying to say.
  
  ---
  
  > Please note that I doubt that your suggestion would help against the crash 
I fixed here.
  
  If your patch works, then mine would too. It's checking the exact same 
pointer, just one frame earlier.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7078

To: graesslin, #kwin, #plasma, #frameworks
Cc: anthonyfieroni, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, 
hein, lukas

D7267: Add support for moving group members within a group.

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  +2 on either patch.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7267

To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7267: Add support for moving group members within a group.

[David Edmundson]

davidedmundson added a comment.


  If you don't want to do it, don't do it.
  
  Though I don't really understand what your concern is. If the parent is 
invalid, then it's invalid. The code will be the same.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7267

To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7268: Use new libtm API to enable DND reordering within group dialogs.

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7268

To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D5579: Introduce QQuickItem to nest kwin_wayland

[Bhavisha Dhruve]

bdhruve added a subscriber: davidedmundson.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5579

To: bdhruve, #plasma_on_wayland, #kwin
Cc: davidedmundson, graesslin, plasma-devel, kwin, leezu, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein, lukas

D7268: Use new libtm API to enable DND reordering within group dialogs.

[Eike Hein]

hein updated this revision to Diff 18121.
hein added a comment.


  Move check into dragging block.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7268?vs=18034=18121

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7268

AFFECTED FILES
  applets/taskmanager/package/contents/ui/MouseHandler.qml

To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7267: Add support for moving group members within a group.

[Eike Hein]

hein updated this revision to Diff 18120.
hein added a comment.


  Reduce code duplication.
  
  A bit queasy about just passing through parent though.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7267?vs=18033=18120

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7267

AFFECTED FILES
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h

To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D5579: Introduce QQuickItem to nest kwin_wayland

[Bhavisha Dhruve]

bdhruve added a subscriber: graesslin.
bdhruve added a comment.


  Ping @graesslin @davidedumndson, should I do any more changes or this can be 
submitted?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5579

To: bdhruve, #plasma_on_wayland, #kwin
Cc: graesslin, plasma-devel, kwin, leezu, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, 
hein, lukas

D7267: Add support for moving group members within a group.

[Eike Hein]

hein added inline comments.

INLINE COMMENTS

> davidedmundson wrote in tasksmodel.cpp:1553
> This is the only bit that's different from the new code.
> 
> Can we share the above and guard this with if(!parent)

I was uncomfortable just always passing parent through in beginMoveRows without 
guarding that with a check, too, but OK ...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7267

To: hein, #plasma, davidedmundson, argonel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas