[Powerdevil] [Bug 383680] org_kde_powerdevil 45% ram usage along with 43% kded5 crashed my computer

[iqbal]

https://bugs.kde.org/show_bug.cgi?id=383680

--- Comment #1 from iqbal  ---
Created attachment 107357
  --> https://bugs.kde.org/attachment.cgi?id=107357=edit
htop report during  last crash

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 383680] New: org_kde_powerdevil 45% ram usage along with 43% kded5 crashed my computer

[iqbal]

https://bugs.kde.org/show_bug.cgi?id=383680

Bug ID: 383680
   Summary: org_kde_powerdevil 45% ram usage along with 43% kded5
crashed my computer
   Product: Powerdevil
   Version: unspecified
  Platform: Manjaro
OS: Linux
Status: UNCONFIRMED
  Severity: crash
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: iqbal_c...@hotmail.com
  Target Milestone: ---

I have 16GB DDR3 type RAM memory space on my laptop (2 slots of 8GB) and a
normal installation of the latest version of Manjaro Linux 64-bit version that
comes with KDE pre-installed. I am fascinated with the DE and its features
that's why I've been using it since 3 weeks and been applying some tweaks like
Virtual Desktops, Keyboard Shortcuts, Effects, Appearances, Widgets, etc. I
hadn't even touched the Power Management settings displayed inside the
"Hardware > Power Management". 

Then I noticed something abnormal with my RAM and CPU usage, laptop fans
starting to sound loud, HTOP started to report huge amounts of RAM being used
(which is the main problem) on processes like "org_kde_powerdevil", "kded5",
"plasmashell", "kscreen_backend_launcher" (sorted by decreasing percentage of
RAM used, the most is 'powerdevil'), crashes. Even when I am not using my
computer for hours (running some background programs like qbitorrent and
cantata though), I could've noticed how this processes 'consume' the perfomance
of my computer and lead to a crash or to get extremely slow. Here are some
cases when "powerdevil" and the other processes start to "accumulate" RAM and
computer becomes slow:

 - Closing the laptop's lid (This is why I set 'Lock screen' for the 'When
laptop lid closed' option under "Hardware > Power Management", don't know if it
is OK)
 - Switching ttys (e.g. Ctrl+Alt+F6)
 - Logging out
 - Suspending
 - Laptop being used for hours without happening any of the above.

Every since I restart the laptop, RAM usage returns to normal.
Of course I had all packages updated, and I am using the LTS recommended kernel
version of Manjaro. I preferred not to use a Swap partition since it can make
my HDD slow and lead to waste.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 351693] Screen brightness is not restored after screen unlock (idle time)

[Yves Glodt]

https://bugs.kde.org/show_bug.cgi?id=351693

Yves Glodt  changed:

   What|Removed |Added

 CC||y...@mind.lu

--- Comment #6 from Yves Glodt  ---
I have a kind of the same issue. I use a two monitor-setup (laptop-screen and
an external monitor connected by hdmi)

When udimming after the screens are dimmed after 5 min. of inactivity, the
laptop screen comes back with full brightness.

I then have to click on the battery icon in the tray, and the indicator still
shows the minimum brightness (which is my choice).

As soon as I move the indicator (slider) a bit, it lowers the brightness to the
set level.

First bug: The brightness should not change after the screen dims.
Second bug: After dim happens, the indicator shows minimum brightness even it's
set to full. As soon as I move it it goes back to the value actually set by the
indicator.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7404: Run the Baloo runner out of process

[David Edmundson]

davidedmundson edited the summary of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7404

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7404: Run the Baloo runner out of process

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  KRunner now supports querying data from running processes rather than
  being plugins.
  
  Due the number of crash reports of Baloo in both krunner and more
  importantly plasmashell, we can move this out of process to make the UX
  better in the event of an issue.

TEST PLAN
  Searched, typing really quickly
  All works as before; including forcing a delay when you only type a few 
letters
  Results are just as fast as before to the human eye (bustle show calls as 0ms)
  
  Tested open with folder and open normally actions
  Tested dragging from krunner to dolphin
  Tested we had correct icons

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7404

AFFECTED FILES
  runners/baloo/CMakeLists.txt
  runners/baloo/baloosearchrunner.cpp
  runners/baloo/baloosearchrunner.h
  runners/baloo/dbusutils_p.h
  runners/baloo/org.kde.baloorunner.service.in
  runners/baloo/org.kde.krunner1.xml
  runners/baloo/plasma-runner-baloosearch.desktop

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7402: Use QUrls from match to create mimeData in base implementation

[David Edmundson]

davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  QueryMatch contains a list of URLs.
  
  If an AbstractRunner doesn't implement this method, create some mimeData
  from the availalbe data in the base implementation.

TEST PLAN
  Have a DBus runner which populates a bunch of URLs, but doesn't implement 
this method.

REPOSITORY
  R308 KRunner

BRANCH
  dbusrunner

REVISION DETAIL
  https://phabricator.kde.org/D7402

AFFECTED FILES
  src/abstractrunner.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7398: Don't create QWhatsThis when user presses showContextHelp button

[Martin Flöser]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  I don't know what the idea of entering QWhatsThis mode was, but the code
  is pretty much dead. There is no QWhatsThis window shown as KWin does
  not have any UI or help. The window which eventually gets shown in
  context help is provided by the client application.
  
  Furthermore KWin never leaves the QWhatsThis mode. At least one code
  path entering in leave is dead in general and one at least on Wayland
  (but probably also on X11 as the window never gets shown).
  
  The show context help functionality works fine without the QWhatsThis
  handling, so let's remove it.
  
  I tried to blame what was the idea behind it, but it was unchanged since
  decades and blame ended in a code moving commit.

TEST PLAN
  Used show context help (kcmshell5 --platform xcb kwinoptions)

REPOSITORY
  R108 KWin

BRANCH
  drop-whats-this

REVISION DETAIL
  https://phabricator.kde.org/D7398

AFFECTED FILES
  client.cpp
  events.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7359: Send output enter/leave events to surfaces

[Martin Flöser]

graesslin added a comment.


  In https://phabricator.kde.org/D7359#136845, @davidedmundson wrote:
  
  > In https://phabricator.kde.org/D7359#136559, @graesslin wrote:
  >
  > > I'm wondering whether we should do it directly in Toplevel as we also 
have the XWayland windows which have a Surface.
  >
  >
  > I don't think XWayland windows can really make use of this. X windows know 
the screen sizes and their own location, so it doesn't really map to anything.
  >  A quick grep of xwayland confirmed there wasn't even a 
wl_surface_add_listener anywhere.
  
  
  Point taken. My thinking was that XWayland might do something clever with it 
like scale up windows internally (send the windows a wrong geometry), but I 
guess that's just unreasonable wishful thinking. So good to go in ShellClient, 
if in a distant future XWayland becomes a valid target, we can move the code 
anyway.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7359

To: davidedmundson, #plasma
Cc: johanhelsing, graesslin, plasma-devel, kwin, #kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D7359: Send output enter/leave events to surfaces

[Martin Flöser]

graesslin added a comment.


  In https://phabricator.kde.org/D7359#136850, @davidedmundson wrote:
  
  > One question that I'm unsure of: subsurfaces.
  >
  > A subsurface is still a surface, so from reading the API arguably they 
should also get enter/leave events...but at the same time it seems pointless. 
  >  From a Qt POV, subsurfaces always follow the screen of the parent window.
  >
  > Any thoughts?
  
  
  I would say it doesn't make any sense to send it for sub-surfaces. Similar I 
don't think it makes sense for the cursor surface and other surface not as top 
level window.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7359

To: davidedmundson, #plasma
Cc: johanhelsing, graesslin, plasma-devel, kwin, #kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D7369: [WIP] Wayland foreign protocol

[Marco Martin]

mart added a comment.


  part of the comments adressed, still to wrap the client part in order to hide 
the v1 implementation.
  
  the status right now is that, when running in valgrind all test pass, while 
then invoked directly it almost always crashes, but every time at a different, 
random place.
  there is some serious memory corruption somewhere, but i'm completely at loss 
in figuring out where it is (and valgrind output, as gdb backtraces seem quite 
useless)

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7369

To: mart, #plasma, #kwin, davidedmundson
Cc: davidedmundson, graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7369: [WIP] Wayland foreign protocol

[Marco Martin]

mart updated this revision to Diff 18357.
mart added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.


  - get rid of the v1 from the verver side
  - dress some issues
  - Q_DECL_HIDDEN for all non exported classes
  - track surface destruction
  - more attention to data integrity
  - wait for server surfaces deletion
  - more qpointers out of pure desperation

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7369?vs=18294=18357

BRANCH
  mart/xdgforeign

REVISION DETAIL
  https://phabricator.kde.org/D7369

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_foreign.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-foreign-unstable-v1.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgforeign_v1.cpp
  src/client/xdgforeign_v1.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/xdgforeign_interface.cpp
  src/server/xdgforeign_interface.h
  src/server/xdgforeign_v1_interface.cpp
  src/server/xdgforeign_v1_interface_p.h

To: mart, #plasma, #kwin, davidedmundson
Cc: davidedmundson, graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7395: [tabBox] Move X11 specific event filtering into a dedicated event filter

[Martin Flöser]

graesslin added a dependency: D7374: Move X11 movingClient handling into a 
dedicated X11EventFilter.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7395

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7374: Move X11 movingClient handling into a dedicated X11EventFilter

[Martin Flöser]

graesslin added a dependent revision: D7395: [tabBox] Move X11 specific event 
filtering into a dedicated event filter.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7374

To: graesslin, #kwin, #plasma
Cc: mart, broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, lukas

D7395: [tabBox] Move X11 specific event filtering into a dedicated event filter

[Martin Flöser]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  This ensures that the X11 specific events are only read on X11 but not
  on Wayland. Also moves quite some X11 specific code out of TabBox.

TEST PLAN
  Compile checked, currently on Wayland, so no way to test.

REPOSITORY
  R108 KWin

BRANCH
  tabbox-filter

REVISION DETAIL
  https://phabricator.kde.org/D7395

AFFECTED FILES
  CMakeLists.txt
  events.cpp
  tabbox/tabbox.cpp
  tabbox/tabbox.h
  tabbox/x11_filter.cpp
  tabbox/x11_filter.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas

[kio-extras] [Bug 372860] MTP not usable : connects, then disconnects, then connects...

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=372860

Nate Graham  changed:

   What|Removed |Added

 CC||cbm4...@gmail.com

--- Comment #2 from Nate Graham  ---
*** Bug 372523 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7377: Track outputs in kwin integration tests

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:34de2c2b5c8b: Track outputs in kwin integration tests 
(authored by davidedmundson).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7377?vs=18311=18345

REVISION DETAIL
  https://phabricator.kde.org/D7377

AFFECTED FILES
  autotests/integration/test_helpers.cpp

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D7379: KWayland::Client::Surface track output destruction

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:e430a44c4a92: KWayland::Client::Surface track output 
destruction (authored by davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7379?vs=18315=18343

REVISION DETAIL
  https://phabricator.kde.org/D7379

AFFECTED FILES
  autotests/client/test_wayland_surface.cpp
  src/client/surface.cpp

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D6134: Test every plasmoid

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R527:31c85ca49872: Test every plasmoid (authored by 
davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D6134?vs=15247=18341#toc

REPOSITORY
  R527 Integration tests for Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6134?vs=15247=18341

REVISION DETAIL
  https://phabricator.kde.org/D6134

AFFECTED FILES
  plasmoid-tests/CMakeLists.txt

To: davidedmundson, #plasma, mart
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart, lukas

D7374: Move X11 movingClient handling into a dedicated X11EventFilter

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> graesslin wrote in moving_client_x11_filter.cpp:36
> *shrug* honestly I don't see that the one or the other is better. The old 
> code used dynamic_cast and I try to be as close as possible to the old one.

both are fine, qobject_cast should be a tad faster, so is probably marginally 
better to change

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7374

To: graesslin, #kwin, #plasma
Cc: mart, broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, lukas

D7379: KWayland::Client::Surface track output destruction

[Martin Flöser]

graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7379

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D7377: Track outputs in kwin integration tests

[Martin Flöser]

graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7377

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D7374: Move X11 movingClient handling into a dedicated X11EventFilter

[Martin Flöser]

graesslin added inline comments.

INLINE COMMENTS

> broulik wrote in moving_client_x11_filter.cpp:36
> `qobject_cast`

*shrug* honestly I don't see that the one or the other is better. The old code 
used dynamic_cast and I try to be as close as possible to the old one.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7374

To: graesslin, #kwin, #plasma
Cc: broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D7385: Compress size hint changes before releasing position and repositioning item.

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3e3f0decc983: Compress size hint changes before releasing 
position and repositioning item. (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7385?vs=18334=18336

REVISION DETAIL
  https://phabricator.kde.org/D7385

AFFECTED FILES
  containments/desktop/package/contents/ui/AppletAppearance.qml

To: hein, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7384: Update size hints less often.

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b8c1e0e3e060: Update size hints less often. (authored by 
hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7384?vs=18333=18335

REVISION DETAIL
  https://phabricator.kde.org/D7384

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml

To: hein, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7384: Update size hints less often.

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D7384

To: hein, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7385: Compress size hint changes before releasing position and repositioning item.

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  a timer always makes things more complicated, but..
  those sizes should really be updated all at once and since qml doesn't have a 
way to do it, ok for a timer

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D7385

To: hein, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7385: Compress size hint changes before releasing position and repositioning item.

[Eike Hein]

hein added inline comments.

INLINE COMMENTS

> AppletAppearance.qml:164
>  root.layoutManager.positionItem(appletItem);
> -root.layoutManager.saveItem(appletItem);
>  }

This line was unnecessary, layoutManager.positionItem saves at the end.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7385

To: hein, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7385: Compress size hint changes before releasing position and repositioning item.

[Eike Hein]

hein created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  https://phabricator.kde.org/D4204 / 
https://phabricator.kde.org/R119:d7621da69b9b4758b3e877f78545645bcb1c4305 
introduced more elaborate handling of item size
  hint changes, releasing and repositioning an item for each change to
  the min/max hints on either axis. We have applets in which the x and
  y hints are coupled and update in turn, to implement aspect-ratio-
  preserving resize. This makes the value on an individual axis a
  useless temporary, wreaking havoc when followed.
  
  As a poor means to commit size hint changes atomically, a 100ms timer
  is used to compress size hint changes. The 100ms interval matches
  layoutTimer in main.qml.
  
  Not very happy with this.
  
  Together with https://phabricator.kde.org/D7384 this addresses:
  BUG:382759

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D7385

AFFECTED FILES
  containments/desktop/package/contents/ui/AppletAppearance.qml

To: hein, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7384: Update size hints less often.

[Eike Hein]

hein created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  The size hints were based on the size of pagerGridItem, which is derived
  from its contents. This made the size hints update as delegates were
  added, but we know ahead of time how many there will be, and what their
  size will be, so we can save some busy work.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D7384

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml

To: hein, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7304: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:b7a63491ad1c: Do not leak symbols of pimpl classes, 
protect with Q_DECL_HIDDEN (authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D7304?vs=18133=18330#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7304?vs=18133=18330

REVISION DETAIL
  https://phabricator.kde.org/D7304

AFFECTED FILES
  src/client/blur.cpp
  src/client/buffer_p.h
  src/client/compositor.cpp
  src/client/connection_thread.cpp
  src/client/contrast.cpp
  src/client/datadevice.cpp
  src/client/datadevicemanager.cpp
  src/client/dataoffer.cpp
  src/client/datasource.cpp
  src/client/dpms.cpp
  src/client/event_queue.cpp
  src/client/fakeinput.cpp
  src/client/fullscreen_shell.cpp
  src/client/idle.cpp
  src/client/keyboard.cpp
  src/client/output.cpp
  src/client/outputconfiguration.cpp
  src/client/outputdevice.cpp
  src/client/outputmanagement.cpp
  src/client/plasmashell.cpp
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmodel.cpp
  src/client/pointer.cpp
  src/client/pointerconstraints.cpp
  src/client/pointergestures.cpp
  src/client/region.cpp
  src/client/registry.cpp
  src/client/relativepointer.cpp
  src/client/seat.cpp
  src/client/server_decoration.cpp
  src/client/shadow.cpp
  src/client/shell.cpp
  src/client/shm_pool.cpp
  src/client/slide.cpp
  src/client/subcompositor.cpp
  src/client/subsurface.cpp
  src/client/surface.cpp
  src/client/textinput_p.h
  src/client/touch.cpp
  src/client/xdgshell_p.h

To: davidedmundson, #plasma, dfaure
Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D7369: [WIP] Wayland foreign protocol

[Marco Martin]

mart marked 2 inline comments as done.
mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in xdgforeign_v1_interface.cpp:299
> this should be connected to unbound.

perhaps the connects to the destruction of the SurfaceInterface* are not even 
necessary?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7369

To: mart, #plasma, #kwin, davidedmundson
Cc: davidedmundson, graesslin, plasma-devel, #frameworks, leezu, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein, lukas

D7369: [WIP] Wayland foreign protocol

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> graesslin wrote in registry.h:938-939
> The general pattern I used for protocols which might get another revision is 
> to create a "meta" class which hides the UnstableV1 mess. C.f. the 
> PointerConstraints a line above.

i see the types are named zxdg_exporter_v1 because it's how the interface is 
calledin the wayland protocol xml.
woudl i need to make another copy of the xml where the interface name is 
unversioned?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7369

To: mart, #plasma, #kwin, davidedmundson
Cc: davidedmundson, graesslin, plasma-devel, #frameworks, leezu, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein, lukas

D7361: Get rid of QSignalMapper

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1419135a5d99: Get rid of QSignalMapper (authored by 
broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7361?vs=18280=18327

REVISION DETAIL
  https://phabricator.kde.org/D7361

AFFECTED FILES
  src/scriptengines/qml/plasmoid/appletinterface.cpp
  src/scriptengines/qml/plasmoid/appletinterface.h
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp
  src/scriptengines/qml/plasmoid/wallpaperinterface.h

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7381: Workaround bug in QT_QUICK_CONTROLS_1_STYLE usage in Qt

[Fabian Vogt]

fvogt closed this revision.
fvogt added a comment.


  Even `arc land` doesn't close diffs reliably now apparently...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7381

To: fvogt, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7381: Workaround bug in QT_QUICK_CONTROLS_1_STYLE usage in Qt

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7381

To: fvogt, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7381: Workaround bug in QT_QUICK_CONTROLS_1_STYLE usage in Qt

[Fabian Vogt]

fvogt created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  Setting the style manually is necessary as there is only a variable that
  applies to both quick controls versions, so it needs to be overwritten to not
  cause a warning on every application start. The current way of setting it 
directly
  got defeated by ugly bugs in QQuickControlSettings1, which need to be worked 
around.
  See the added comments for an explanation.

TEST PLAN
  Set the variables manually, now works consistently everywhere without showing 
warnings.
  For some reason I feel much dirtier now.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7381

AFFECTED FILES
  startkde/startkde.cmake
  startkde/startplasma.cmake

To: fvogt, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7125: Check for a graphical session

[Fabian Vogt]

fvogt added a comment.


  No automatic close for some reason: 
https://commits.kde.org/kwallet-pam/f3b230f7f3bf39dc46b97a216aa7c28595d20a7a

REPOSITORY
  R107 KWallet PAM Integration

BRANCH
  patch4

REVISION DETAIL
  https://phabricator.kde.org/D7125

To: fvogt, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7125: Check for a graphical session

[Fabian Vogt]

fvogt closed this revision.

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D7125

To: fvogt, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas