D6764: Add font size setting to the digital clock plasmoid
januz added a comment. > I think this explains why you haven't had a review, this existing code is already sketchy as-is :/ > But we should be trying to fix that not just all of us ignoring it. Sorry about that. No problem, I can understand the dread of piling stuff on code that needs refactoring. > So this clock has 4 states: > > 1. horizontal > 2. horizontal small (date and tz appear alongside clock) > 3. vertical > 4. other () I don't think I've ever seen state 4. How do you trigger it? > With your patch: > in states 1 and 2 you're explicitly setting the time zone label to a config value, and implicitly the date and TZ label to 0.7 of that. > > I could understand logic that limits the maximiumSize to a user defined value, but I don't want to be in a position where the user resizes a panel..then has to open all the config options of each widget and adjust things. > Would keeping the fit mode but setting the maximumPixelSize to the config value work for you? That's a better solution! We could use a float value, and present it more as a percentage instead of a font size value. The only thing to look out for is a minimum size limit, so the widget doesn't vanish when the user resizes the panel/widget. > States 3 and 4 are unchanged: > > I don't really want to have a config option that simply does nothing. Is there a reason it's not changed? The main idea of this setting was to be able to make the clock smaller than the panel size. Vertical panels are usually thin, and the font size for digital clocks turns out to be fairly small already. So I didn't think it was really useful to set a font size there. It wouldn't hurt either though. REVISION DETAIL https://phabricator.kde.org/D6764 To: januz, #plasma, #vdg Cc: davidedmundson, ngraham, Zren, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D7749: Header as one ToolButton for Back action
This revision was automatically updated to reflect the committed changes. Closed by commit R124:a88cad3bc72c: Header as one ToolButton for Back action (authored by subdiff). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7749?vs=19338=19384 REVISION DETAIL https://phabricator.kde.org/D7749 AFFECTED FILES sidebar/package/contents/ui/SubCategoryPage.qml To: subdiff, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7761: [effects] Support xcbConnectionChanged for support properties
graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in blur.cpp:76 > I was expecting you to do what you for the present windows effect with > calling your local lambda announceSupportProperties. > > IMHO it's neater than duplicating - but this is fine too. I didn't go for the lambda here as the if statement above does also the Wayland registering. So at least the if would have been needed to be duplicated anyway. REPOSITORY R108 KWin BRANCH effects-xcb-connection-changed REVISION DETAIL https://phabricator.kde.org/D7761 To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7761: [effects] Support xcbConnectionChanged for support properties
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> blur.cpp:76
> connect(effects, SIGNAL(screenGeometryChanged(QSize)), this,
> SLOT(slotScreenGeometryChanged()));
> +connect(effects, ::xcbConnectionChanged, this,
> +[this] {
I was expecting you to do what you for the present windows effect with calling
your local lambda announceSupportProperties.
IMHO it's neater than duplicating - but this is fine too.
REPOSITORY
R108 KWin
BRANCH
effects-xcb-connection-changed
REVISION DETAIL
https://phabricator.kde.org/D7761
To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7761: [effects] Support xcbConnectionChanged for support properties
graesslin updated this revision to Diff 19381. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Addressed David's comments REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7761?vs=19367=19381 BRANCH effects-xcb-connection-changed REVISION DETAIL https://phabricator.kde.org/D7761 AFFECTED FILES effects.cpp effects/backgroundcontrast/contrast.cpp effects/blur/blur.cpp effects/highlightwindow/highlightwindow.cpp effects/kscreen/kscreen.cpp effects/presentwindows/presentwindows.cpp effects/slidingpopups/slidingpopups.cpp libkwineffects/kwineffects.h To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D6591: XdgV6 - Kwin side
mart updated this revision to Diff 19372. mart added a comment. Restricted Application edited projects, added Plasma; removed KWin. - Temporary popup stuff - Update to signal rename - skip taskbar/pager/windowmanagement for xdgpopups - send configure on popup resize - Merge branch 'mart/xdgv6ping' into xdgv6 - Connect XDG ping pong only in XDG specific code path - Fixup - Merge branch 'master' into xdgv6 - move other xdg-only connect - Guard against assuming we're using xdgshell - disconnect ping timeout on shellclient destruction - Merge branch 'master' into xdgv6 - ping changes - don't do 3 casts - don't ping a window before killing REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6591?vs=19310=19372 BRANCH xdgv6 REVISION DETAIL https://phabricator.kde.org/D6591 AFFECTED FILES shell_client.cpp shell_client.h wayland_server.cpp wayland_server.h To: mart, #plasma, graesslin, davidedmundson Cc: mart, graesslin, kwin, plasma-devel, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D6591: XdgV6 - Kwin side
mart commandeered this revision. mart edited reviewers, added: davidedmundson; removed: mart. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6591 To: mart, #plasma, graesslin, davidedmundson Cc: mart, graesslin, kwin, plasma-devel, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol
D7740: Move SceneOpenGL into a dedicated plugin
bshah added a comment. In https://phabricator.kde.org/D7740#144077, @graesslin wrote: > @bshah could you please try this patch on hwcomposer platform? I tried to get all required changes into it, but I currently don't have a compiler to verify. Can you commit them in one branch? makes easier for me to CI build this change, as patch is massive. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7740 To: graesslin, #kwin, #plasma Cc: bshah, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D6591: XdgV6 - Kwin side
mart added inline comments. INLINE COMMENTS > graesslin wrote in shell_client.cpp:608-609 > That logic I don't understand: why do we ping to close? Why a roundtrip to > the app, when all we want to do is close it? Just send it a close? i copied from the x11 client, where on client::CloseWindow it pings beforehand, but i can remove it and just close REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6591 To: davidedmundson, #plasma, graesslin, mart Cc: mart, graesslin, kwin, plasma-devel, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D7654: Move XRandR event filter into XRandRScreens
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH xrandr-event-filter REVISION DETAIL https://phabricator.kde.org/D7654 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D7761: [effects] Support xcbConnectionChanged for support properties
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> contrast.cpp:63
> +[this] {
> +net_wm_contrast_region =
> effects->announceSupportProperty(s_contrastAtomName, this);
> +}
we should only announce this
if ((shader && shader->isValid())
> blur.cpp:78
> +[this] {
> +net_wm_blur_region =
> effects->announceSupportProperty(s_blurAtomName, this);
> +}
same here.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7761
To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D7653: Do not hard runtime depend on X11 in RuleBook
This revision was automatically updated to reflect the committed changes. Closed by commit R108:8522ef17eea0: Do not hard runtime depend on X11 in RuleBook (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7653?vs=19083=19369 REVISION DETAIL https://phabricator.kde.org/D7653 AFFECTED FILES rules.cpp rules.h To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D7761: [effects] Support xcbConnectionChanged for support properties
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Several effects announce a support property atom on the root window. This change forwards the KWin::Application's signal that the xcbConnection changed to the EffectsHandler so that the effects can respond to it. All effects which announce a support property connect to this new signal and re-announce the property. In case the xcb connection died (future XWayland crashing case) it is set to XCB_ATOM_NONE by that. In case the xcb connection got created (future delayed XWayland startup) the atom is set to the proper value. In addition all usages of the support properties are guarded, so that no nonesense actions are performed if the support property is XCB_ATOM_NONE. TEST PLAN Only compile tested as we don't have XFree KWin yet REPOSITORY R108 KWin BRANCH effects-xcb-connection-changed REVISION DETAIL https://phabricator.kde.org/D7761 AFFECTED FILES effects.cpp effects/backgroundcontrast/contrast.cpp effects/blur/blur.cpp effects/highlightwindow/highlightwindow.cpp effects/kscreen/kscreen.cpp effects/presentwindows/presentwindows.cpp effects/slidingpopups/slidingpopups.cpp libkwineffects/kwineffects.h To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D7757: Use real-time scheduling policy for kwin_wayland
tcberner added a comment. I could not find anything similar. So that's probably the way to go. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7757 To: graesslin, #kwin, #plasma Cc: tcberner, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D7760: Move XRenderUtils init/cleanup into X11 standalone platform
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Only needed for kwin_x11 variant (required for the non-composited Outline). As that's nowadays in the x11 platform, we can move the complete XRenderUtils support into the platform. Thus KWin core does no longer require to link it. TEST PLAN Compiles REPOSITORY R108 KWin BRANCH xrenderutils-x11-platform REVISION DETAIL https://phabricator.kde.org/D7760 AFFECTED FILES CMakeLists.txt plugins/platforms/x11/standalone/CMakeLists.txt plugins/platforms/x11/standalone/x11_platform.cpp plugins/platforms/x11/windowed/CMakeLists.txt plugins/scenes/xrender/CMakeLists.txt workspace.cpp To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D5497: Improved Suggestions Model
This revision was automatically updated to reflect the committed changes. Closed by commit R846:3a4cd88c7f27: Improved Suggestions Model (authored by Aiix). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5497?vs=13576=19360#toc REPOSITORY R846 Mycroft Plasma integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5497?vs=13576=19360 REVISION DETAIL https://phabricator.kde.org/D5497 AFFECTED FILES plasmoid/contents/ui/Suggestions.qml plasmoid/contents/ui/main.qml plasmoid/contents/ui/suggestion/WikiList plasmoid/contents/ui/suggestion/WikiList.txt plasmoid/contents/ui/suggestion/words.txt plasmoid/contents/ui/suggestion/words1.txt plugin/filereader.cpp plugin/filereader.h To: Aiix Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D7757: Use real-time scheduling policy for kwin_wayland
graesslin added a comment. In https://phabricator.kde.org/D7757#144415, @tcberner wrote: >^ > /home/Tobias/git/kwin/main_wayland.cpp:452:38: error: use of undeclared identifier 'SCHED_RESET_ON_FORK' > sched_setscheduler(0, SCHED_RR | SCHED_RESET_ON_FORK, ); >^ > > > Yes, `SCHED_RESET_ON_FORK` is linux only: > https://www.freebsd.org/cgi/man.cgi?query=sched_setscheduler do you know whether there is an alternative for BSD? If not, I'll have to disable that feature on BSDs to not leak the real time scheduler to all child processes. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7757 To: graesslin, #kwin, #plasma Cc: tcberner, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D7653: Do not hard runtime depend on X11 in RuleBook
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH rulebook-no-x11 REVISION DETAIL https://phabricator.kde.org/D7653 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D7654: Move XRandR event filter into XRandRScreens
graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7654 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D7653: Do not hard runtime depend on X11 in RuleBook
graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7653 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D7756: Don't enter test subdirectories if BUILD_TESTING=OFF
This revision was automatically updated to reflect the committed changes. Closed by commit R320:ffc2a64d1f97: Don't enter test subdirectories if BUILD_TESTING=OFF (authored by asturmlechner). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7756?vs=19352=19355 REVISION DETAIL https://phabricator.kde.org/D7756 AFFECTED FILES archive/CMakeLists.txt man/CMakeLists.txt To: asturmlechner, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7756: Don't enter test subdirectories if BUILD_TESTING=OFF
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D7756 To: asturmlechner, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7757: Use real-time scheduling policy for kwin_wayland
tcberner added a comment. ^ /home/Tobias/git/kwin/main_wayland.cpp:452:38: error: use of undeclared identifier 'SCHED_RESET_ON_FORK' sched_setscheduler(0, SCHED_RR | SCHED_RESET_ON_FORK, ); ^ Yes, `SCHED_RESET_ON_FORK` is linux only: https://www.freebsd.org/cgi/man.cgi?query=sched_setscheduler REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7757 To: graesslin, #kwin, #plasma Cc: tcberner, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D7757: Use real-time scheduling policy for kwin_wayland
graesslin added a subscriber: tcberner. graesslin added a comment. @tcberner could you please try to compile this change on FreeBSD? I just want to be sure that it doesn't introduce a linux-ism. The most prominent dangerous part could be SCHED_RESET_ON_FORK where I'm not sure whether it is linux specific. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7757 To: graesslin, #kwin, #plasma Cc: tcberner, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D7757: Use real-time scheduling policy for kwin_wayland
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The base idea behind this change is to keep the system responsive no matter what other processes do. All input and rendering needs to go through the windowing system, so keeping it responsive is important. Currently KWin competes with all other processes for resources and this can render the system unusable. Consider some processes running amok. In this case the user might not be able to easily close the applications as KWin does not get the cpu time to perform the input tasks requested by the user. Or in the case of playing a demanding game it is important that KWin gets scheduled to forward the pointer input events. The user doesn't want that the game (or another process) wins against the windowing sytem. The disadvantage is that KWin always wins against other processes with real time scheduling. This could result in KWin running amok stalling the system. On the other hand this is no change to the current situation as if KWin runs amok the sytem is unusable. The change uses libcap to set CAP_SYS_NICE on kwin_wayland executable. KWin_wayland on start sets the scheduling policy to SCHED_RR with the lowest possible priority. Thus any other SCHED_RR process will win against KWin. So real time processes are not affected by this change! After adjusting the scheduling (which requires CAP_SYS_NICE) KWin drops this capability again. TEST PLAN Verified that KWin adjusts the scheduler, that it is not passed to child processes, that the capability gets dropped and not passed to child processes. REPOSITORY R108 KWin BRANCH wayland-realtime REVISION DETAIL https://phabricator.kde.org/D7757 AFFECTED FILES CMakeLists.txt cmake/modules/FindLibcap.cmake config-kwin.h.cmake main_wayland.cpp To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D7756: Don't enter test subdirectories if BUILD_TESTING=OFF
asturmlechner created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Qt5Test is an optional dependency but not followed in some subdirs. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D7756 AFFECTED FILES archive/CMakeLists.txt man/CMakeLists.txt To: asturmlechner, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7715: [Plasma Components 3] Fix RTL in some widgets.
This revision was automatically updated to reflect the committed changes. Closed by commit R242:940adc7e6e69: [Plasma Components 3] Fix RTL in some widgets. (authored by safaalfulaij). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7715?vs=19255=19351 REVISION DETAIL https://phabricator.kde.org/D7715 AFFECTED FILES src/declarativeimports/plasmacomponents3/ComboBox.qml src/declarativeimports/plasmacomponents3/ProgressBar.qml src/declarativeimports/plasmacomponents3/RangeSlider.qml src/declarativeimports/plasmacomponents3/Slider.qml To: safaalfulaij, #plasma, #frameworks, mart Cc: mart, broulik, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D7733: [Folder View Icons Config] Fix initial index of ComboBox
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7733 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
