D8115: Port KAccess away from kdelibs4support
apol added inline comments. INLINE COMMENTS > davidedmundson wrote in kaccess.cpp:722 > we've effectively removed this connect to dialogClosed. Now closing goes to > noClicked. > > Is this a problem? I noticed. I'm not sure to be honest. My thinking is that the user shouldn't notice the difference between saying "No" and closing the window. I can short-circuit the QDialogButtonBox::rejected if that makes you feel more comfortable with the patch. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8115 To: apol, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8115: Port KAccess away from kdelibs4support
davidedmundson added a comment. nice INLINE COMMENTS > kaccess.cpp:722 > -connect(dialog, ::noClicked, this, ::noClicked); > -connect(dialog, ::closeClicked, this, > ::dialogClosed); > } we've effectively removed this connect to dialogClosed. Now closing goes to noClicked. Is this a problem? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8115 To: apol, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8115: Port KAccess away from kdelibs4support
apol created this revision. apol added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Executed it locally, can start and stop orca REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D8115 AFFECTED FILES kaccess/CMakeLists.txt kaccess/kaccess.cpp kaccess/kaccess.h kaccess/main.cpp To: apol, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7369: Wayland foreign protocol
mart updated this revision to Diff 20257. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - move to xdg-foreign-unstable-v2 - get rid of setTransientFor REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7369?vs=18767=20257 BRANCH mart/xdgforeign REVISION DETAIL https://phabricator.kde.org/D7369 AFFECTED FILES autotests/client/CMakeLists.txt autotests/client/test_xdg_foreign.cpp src/client/CMakeLists.txt src/client/protocols/xdg-foreign-unstable-v2.xml src/client/registry.cpp src/client/registry.h src/client/xdgforeign.cpp src/client/xdgforeign.h src/client/xdgforeign_p.h src/client/xdgforeign_v2.cpp src/client/xdgforeign_v2.h src/server/CMakeLists.txt src/server/display.cpp src/server/display.h src/server/xdgforeign_interface.cpp src/server/xdgforeign_interface.h src/server/xdgforeign_v2_interface.cpp src/server/xdgforeign_v2_interface_p.h tests/CMakeLists.txt tests/xdgforeigntest.cpp To: mart, #plasma, #kwin, davidedmundson, graesslin Cc: davidedmundson, graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
D7939: ColorSet concept in Theme
mart updated this revision to Diff 20247. mart added a comment. - finalize signatures for signals - todo on font change REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7939?vs=20110=20247 BRANCH mart/colorcontext REVISION DETAIL https://phabricator.kde.org/D7939 AFFECTED FILES CMakeLists.txt KF5Kirigami2Config.cmake.in KF5Kirigami2Macros.cmake README.md autotests/tst_keynavigation.qml autotests/tst_listskeynavigation.qml autotests/tst_pagerow.qml examples/applicationitemapp/main.qml examples/galleryapp/CMakeLists.txt examples/galleryapp/resources.qrc examples/gallerydata/contents/ui/DesktopExampleApp.qml examples/gallerydata/contents/ui/ExampleApp.qml examples/gallerydata/contents/ui/MainPage.qml examples/gallerydata/contents/ui/gallery/ButtonGallery.qml examples/gallerydata/contents/ui/gallery/CheckBoxGallery.qml examples/gallerydata/contents/ui/gallery/ColorSetGallery.qml examples/gallerydata/contents/ui/gallery/ColorsGallery.qml examples/gallerydata/contents/ui/gallery/LayersGallery.qml examples/gallerydata/contents/ui/gallery/ListViewGallery.qml examples/gallerydata/contents/ui/gallery/ListViewHeaderItemsGallery.qml examples/gallerydata/contents/ui/gallery/MetricsGallery.qml examples/gallerydata/contents/ui/gallery/MiscGallery.qml examples/gallerydata/contents/ui/gallery/MultipleColumnsGallery.qml examples/gallerydata/contents/ui/gallery/NonScrollableGallery.qml examples/gallerydata/contents/ui/gallery/ProgressBarGallery.qml examples/gallerydata/contents/ui/gallery/RadioButtonGallery.qml examples/gallerydata/contents/ui/gallery/SliderGallery.qml examples/gallerydata/contents/ui/gallery/SwitchGallery.qml examples/gallerydata/contents/ui/gallery/TabBarGallery.qml examples/gallerydata/contents/ui/gallery/TextFieldGallery.qml examples/gallerydata/metadata.desktop examples/minimalqmake/Page1Form.ui.qml examples/minimalqmake/kirigami-icons.qrc examples/minimalqmake/main.qml examples/multiplatformnotesapp/NotesGeneral.qml examples/multiplatformnotesapp/notesDesktop.qml examples/multiplatformnotesapp/notesMobile.qml examples/simpleexamples/AbstractApplicationWindow.qml examples/simpleexamples/FixedSidebar.qml examples/simpleexamples/MultipleColumnsGallery.qml examples/simpleexamples/SplitDrawer.qml examples/simpleexamples/TabBarHeader.qml examples/simpleexamples/customdrawer.qml examples/simpleexamples/minimal.qml examples/simpleexamples/pushpopclear.qml examples/simpleexamples/simpleChatApp.qml kirigami.pri src/CMakeLists.txt src/controls/AbstractApplicationHeader.qml src/controls/AbstractApplicationItem.qml src/controls/AbstractApplicationWindow.qml src/controls/AbstractItemViewHeader.qml src/controls/ApplicationItem.qml src/controls/ApplicationWindow.qml src/controls/BasicListItem.qml src/controls/ContextDrawer.qml src/controls/GlobalDrawer.qml src/controls/Heading.qml src/controls/Icon.qml src/controls/ItemViewHeader.qml src/controls/Label.qml src/controls/OverlayDrawer.qml src/controls/OverlaySheet.qml src/controls/Page.qml src/controls/PageRow.qml src/controls/ScrollablePage.qml src/controls/Separator.qml src/controls/Theme.qml src/controls/ToolBarApplicationHeader.qml src/controls/Units.qml src/controls/plugins.qmltypes src/controls/private/ActionButton.qml src/controls/private/CornerShadow.qml src/controls/private/DefaultListItemBackground.qml src/controls/private/EdgeShadow.qml src/controls/private/PrivateActionToolButton.qml src/controls/private/RefreshableScrollView.qml src/controls/private/SwipeItemEventFilter.qml src/controls/templates/AbstractApplicationHeader.qml src/controls/templates/AbstractListItem.qml src/controls/templates/ApplicationHeader.qml src/controls/templates/OverlayDrawer.qml src/controls/templates/OverlaySheet.qml src/controls/templates/SwipeListItem.qml src/controls/templates/private/BackButton.qml src/controls/templates/private/ContextIcon.qml src/controls/templates/private/MenuIcon.qml src/controls/templates/private/PassiveNotification.qml src/controls/templates/private/ScrollView.qml src/desktopicon.cpp src/desktopicon.h src/kirigamiplugin.cpp src/libkirigami/CMakeLists.txt src/libkirigami/basictheme.cpp src/libkirigami/basictheme_p.h src/libkirigami/kirigamipluginfactory.cpp src/libkirigami/kirigamipluginfactory.h src/libkirigami/platformtheme.cpp src/libkirigami/platformtheme.h src/styles/Material/AbstractListItem.qml src/styles/Material/Label.qml src/styles/Material/SwipeListItem.qml src/styles/Material/Theme.qml src/styles/Plasma/Icon.qml src/styles/Plasma/Theme.qml src/styles/org.kde.desktop/AbstractApplicationHeader.qml src/styles/org.kde.desktop/AbstractListItem.qml src/styles/org.kde.desktop/ApplicationWindow.qml src/styles/org.kde.desktop/OverlayDrawer.qml src/styles/org.kde.desktop/SwipeListItem.qml
D8054: Show headset icons for devices identifying as "Headset" in Description
This revision was automatically updated to reflect the committed changes. Closed by commit R115:6940b08074fd: Show headset icons for devices identifying as Headset in Description (authored by antlarr, committed by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8054?vs=20239=20245 REVISION DETAIL https://phabricator.kde.org/D8054 AFFECTED FILES applet/contents/ui/DeviceListItem.qml src/device.cpp src/device.h To: antlarr, #plasma, davidedmundson, drosca Cc: drosca, sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
D8109: remove bogus test
This revision was automatically updated to reflect the committed changes. Closed by commit R119:2b67d213871f: remove bogus test (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8109?vs=20241=20243 REVISION DETAIL https://phabricator.kde.org/D8109 AFFECTED FILES kcms/keyboard/tests/flags_test.cpp To: mart, #plasma, sebas Cc: bshah, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8109: remove bogus test
bshah added a comment. +1 REPOSITORY R119 Plasma Desktop BRANCH xkbtest REVISION DETAIL https://phabricator.kde.org/D8109 To: mart, #plasma, sebas Cc: bshah, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8109: remove bogus test
sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH xkbtest REVISION DETAIL https://phabricator.kde.org/D8109 To: mart, #plasma, sebas Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8109: remove bogus test
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY the names in /usr/share/X11/xkb/symbols/us are not stable, the us keyboard name recently switched from "English (US, international with dead keys)" to "English (US, intl., with dead keys)" breaking the tests, so there is no point to test for these names on our side TEST PLAN tests now pass REPOSITORY R119 Plasma Desktop BRANCH xkbtest REVISION DETAIL https://phabricator.kde.org/D8109 AFFECTED FILES kcms/keyboard/tests/flags_test.cpp To: mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8109: remove bogus test
mart added a reviewer: Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8109 To: mart, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8054: Show headset icons for devices identifying as "Headset" in Description
antlarr updated this revision to Diff 20239. antlarr added a comment. - Remove check for currentPort which is no longer needed REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8054?vs=20094=20239 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8054 AFFECTED FILES applet/contents/ui/DeviceListItem.qml src/device.cpp src/device.h To: antlarr, #plasma, davidedmundson, drosca Cc: drosca, sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
D8054: Show headset icons for devices identifying as "Headset" in Description
drosca accepted this revision.
drosca added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> DeviceListItem.qml:29
> icon: {
> if (currentPort) {
> +switch(FormFactor) {
This check is no longer needed.
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8054
To: antlarr, #plasma, davidedmundson, drosca
Cc: drosca, sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, apol, mart
Minutes Monday Plasma Hangout
Cheers!
--
sebas
http://www.kde.org | http://vizZzion.orgPlasma Weekly Meeting, 2 October 2017, 12:00 CEST #plasma on freenode
Sho:
* Wrote a proof-of-concept patch for making Sonnet work on Qt Quick TextEdits:
success, we can have spell-checking in Kirigami apps
* Fixed some libtm unit test failures
* QtWS coordination, things are finally all falling into place
* Tons of Konversation rewrite coding making more stuff work again
* It's the biggest holiday season of the year here, today I'm at a KDE-themed
hackathon (https://i.imgur.com/iicF0aC.jpg) with others left behind in Seoul
amidst the general "go back to hometown" travel, now running off to group dinner
d_ed:
Things I've done:
* merged most my stuff to make plasma works with the software renderer
* KCM needs some deciding on what to do
* Also started the kwayland side of protocol-filtering
if you have opinions on how that should be done, please discuss here:
https://phabricator.kde.org/T4437
Task 4437 "[kwayland] Security filter" [Open,Needs Triage] {Plasma on
Wayland} https://phabricator.kde.org/T4437
other stuff:
* we have 8 failing unit tests on build.kde.org ATM, This is ridiculous, I will
now list them and assign them to people here
bshah:
- Arch Linux images
- Got stuck with wayland eglplatform not being functional upto yesterday
- Got hold of libhybris developer yesterday to get the fix for the issue
- Turns out yet another glibc 2.26 related issue
- now plasma runs, will fix some more stuff to create flashable rootfs
notmart:
* kirigami: the colorset stuff should be more or less final now, in all 4
reviews, needs to decide the final location for the part in plasma-integration,
opinions needed
** qqc2-desktop-style: use kirigami theme and support local palettes provided
by the colorSet
* bugfixes in systemsettings:
** tooltip dismissal and placement
** difference in focus indication for sidebar items between active and not
active focus (kirigami issue)
** fixes for for right-to-left layouts (both kirigami and systemsettings issues)
* different approach to KIconLoader custom colors:
https://phabricator.kde.org/D8060 : IMPORTANT: this has to go is ASAP as the
old change changed dependencies breaking compatibility, so has to be merged
before frameworks release, so please review.
Diff 8060 "allow to set a custom palette instead of colorSets" [Needs Review]
https://phabricator.kde.org/D8060
sebas:
* stuff I forget, somehow last week feels like a blur
* blogged about convergence:
https://vizzzion.org/blog/2017/09/plasma-mobile-and-convergence/
* Blogged about KDE's privacy goal:
https://vizzzion.org/blog/2017/09/privacy-software/
* one more technical blog about convergence lined up, just needs some
illustrations and proof-reading
* got new laptop, built all the things, pray for this to be the mother of all
laptops that never breaks
* purism phone campaign crossed 900K \o/
Log:
[12:01:36] Meeting time! Who's here?
[12:01:40] me me me
[12:01:41] I am here
[12:01:50] notmart: ?
[12:01:53] d_ed: it's all what is in neon_unstable.. but.. first meting
[12:01:58] me me me
[12:02:08] Sho_, d_ed, bshah to start
[12:02:10] sebas: yessh!
[12:02:20] Kai is MIA, but okay
[12:02:23] * Wrote a proof-of-concept patch for making Sonnet work on Qt
Quick TextEdits: success, we can have spell-checking in Kirigami apps
[12:02:24] * Fixed some libtm unit test failures
[12:02:26] * QtWS coordination, things are finally all falling into place
[12:02:27] * Tons of Konversation rewrite coding making more stuff work
again
[12:02:28] * It's the biggest holiday season of the year here, today I'm
at a KDE-themed hackathon (https://i.imgur.com/iicF0aC.jpg) with others left
behind in Seoul amidst the general "go back to hometown" travel, now running
off to group dinner
[12:03:33] have fun
[12:04:04] Things I've done:
[12:04:25] * merged most my stuff to make plasma works with the
software renderer
[12:04:34] * KCM needs some deciding on what to do
[12:04:54] * Also started the kwayland side of protocol-filtering
[12:05:30] if you have opinions on how that should be done, please
discuss here: https://phabricator.kde.org/T4437
[12:05:30] Task 4437 "[kwayland] Security filter" [Open,Needs
Triage] {Plasma on Wayland} https://phabricator.kde.org/T4437
[12:05:37] other stuff:
[12:05:47] we have 8 failing unit tests on build.kde.org ATM
[12:05:50] This is ridiculous
[12:05:55] I will now list them and assign them to people here
[12:06:07] p-w: task manager: assigned to Eike (already told him)
[12:06:22]
https://build.kde.org/view/Plasma/job/Plasma%20plasma-desktop%20kf5-qt5%20SUSEQt5.9/lastCompletedBuild/testReport/(root)/TestSuite/kcm_keyboard_flags_test/
[12:06:53]
https://build.kde.org/view/Plasma/job/Plasma%20plasma-desktop%20kf5-qt5%20SUSEQt5.9/lastCompletedBuild/testReport/(root)/TestSuite/kcm_keyboard_flags_test/
[12:07:02] notmart: do you want to have a look at those two? ^
D8100: Workaround crash on lockscreen close
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY See QTBUG-55460 for details. It's causing our unit test crash when closing the lock screen with SIGTERM. It's not worth fixing "properly" as it goes away with QtQuickControls2 TEST PLAN gdb showed it was this crash, which I'd seen before Ran locker --test sent SIGTERM locker closed, but didn't crash REPOSITORY R133 KScreenLocker BRANCH master REVISION DETAIL https://phabricator.kde.org/D8100 AFFECTED FILES greeter/greeterapp.cpp To: davidedmundson, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
