D8447: Add unit tests for Folder View

[Andras Mantia]

amantia updated this revision to Diff 21281.
amantia added a comment.


  Implement changes requested by Laurent.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8447?vs=21235&id=21281

REVISION DETAIL
  https://phabricator.kde.org/D8447

AFFECTED FILES
  containments/desktop/plugins/folder/CMakeLists.txt
  containments/desktop/plugins/folder/foldermodel.h
  containments/desktop/plugins/folder/folderplugin_private_export.h
  containments/desktop/plugins/folder/positioner.h
  containments/desktop/plugins/folder/tests/CMakeLists.txt
  containments/desktop/plugins/folder/tests/foldermodeltest.cpp
  containments/desktop/plugins/folder/tests/foldermodeltest.h
  containments/desktop/plugins/folder/tests/positionertest.cpp
  containments/desktop/plugins/folder/tests/positionertest.h

To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, 
renatoo, olivierjg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8444: WIP: Define default Action when we plug unknown monitor

[Laurent Montel]

mlaurent added a subscriber: dvratil.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent
Cc: dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Plasma Workspace Wallpapers] [Bug 386153] plasma is shit

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=386153

Martin Flöser  changed:

   What|Removed |Added

   Assignee|plasma-devel@kde.org|plasma-b...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

D8462: [batterymonitor] Fix brightness resetting to 1 on startup

[Bhushan Shah]

bshah created this revision.
bshah added reviewers: Plasma, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This was tricky bug to track down, needed to add debug statements in
  literally every functions.
  
  The flow of events is something like this, At startup:
  
  - We don't have information about actual brightness for few seconds
  - In this period, brightness slider have default value of 1
  - This triggers the function which sets batterymonitor.screenBrightness
  - onScreenBrightnessChanged gets called, which sets the actual
  
  brightness
  
  - onScreenBrightnessChanged have a guard for disableBrightnessUpdate but
  
  since we have it marked as false initially, we proceed to set actual
  brightness to 1
  
  - However before we set value of brightness to 1, we do get actual
  
  brightness back from dataengine, and our call overrides it to 1 later.
  
  - On desktop we do get 2nd dataChanged event from somewhere, so
  
  brightness is proper, but on mobile that is not case and results in
  brightness staying at 1.
  
  To fix this bug, we set disableBrightnessUpdate true at startup, and
  when there is actual brightness change from powerdevil or
  powermanagement engine, Logic.js takes care of enabling and disabling
  brightness change.
  
  (I quite like the boolean trap there in variable name :P .. will fix in
  another change in master)

TEST PLAN
  Tested on desktop and mobile, verified that
  
  - Brightness keys work
  - Brightness slider works
  - Scroll to change brightness works

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-brightness-reset

REVISION DETAIL
  https://phabricator.kde.org/D8462

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: bshah, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8455: Fix DBus startup notification

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:149060766795: Fix DBus startup notification (authored by 
fvogt).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8455?vs=21259&id=21279

REVISION DETAIL
  https://phabricator.kde.org/D8455

AFFECTED FILES
  app/kdesystemsettings.desktop
  app/systemsettings.desktop

To: fvogt, #plasma, davidedmundson
Cc: ngraham, broulik, rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8455: Fix DBus startup notification

[Fabian Vogt]

fvogt added a comment.


  In https://phabricator.kde.org/D8455#159526, @davidedmundson wrote:
  
  > Urgh, Thanks
  >
  > Stable branch too please.
  
  
  Not sure what you mean by stable branch - this is diffed on top of 
Plasma/5.11 which should be enough, the change in main is not part of 5.8.

REPOSITORY
  R124 System Settings

BRANCH
  Plasma/5.11

REVISION DETAIL
  https://phabricator.kde.org/D8455

To: fvogt, #plasma, davidedmundson
Cc: ngraham, broulik, rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8460: Refactor kcm_input to enable having multiple backends.

[Xuetian Weng]

xuetianweng created this revision.
xuetianweng added reviewers: subdiff, davidedmundson, ngraham.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Split patch for https://phabricator.kde.org/D8168. This change only refactor 
the X11-related code into
  its own places. KCM itself will only use the backend interface.

TEST PLAN
  Manually test all options.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8460

AFFECTED FILES
  kcms/input/CMakeLists.txt
  kcms/input/backends/x11.cmake
  kcms/input/backends/x11/x11mousebackend.cpp
  kcms/input/backends/x11/x11mousebackend.h
  kcms/input/kapplymousetheme.cpp
  kcms/input/logging.cpp
  kcms/input/logging.h
  kcms/input/main.cpp
  kcms/input/mouse.cpp
  kcms/input/mouse.h
  kcms/input/mousebackend.cpp
  kcms/input/mousebackend.h
  kcms/input/mousesettings.cpp
  kcms/input/mousesettings.h

To: xuetianweng, subdiff, davidedmundson, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8456: Port kcm input to UI File.

[Xuetian Weng]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:987b4dec9264: Port kcm input to UI File. (authored by 
xuetianweng).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8456?vs=21268&id=21269

REVISION DETAIL
  https://phabricator.kde.org/D8456

AFFECTED FILES
  kcms/input/CMakeLists.txt
  kcms/input/kcmmouse.ui
  kcms/input/kmousedlg.ui
  kcms/input/mouse.cpp
  kcms/input/mouse.h

To: xuetianweng, subdiff, davidedmundson, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8456: Port kcm input to UI File.

[Roman Gilg]

subdiff accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8456

To: xuetianweng, subdiff, davidedmundson, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8456: Port kcm input to UI File.

[Xuetian Weng]

xuetianweng updated this revision to Diff 21268.
xuetianweng added a comment.


  Merge kmousedlg.ui into kcmmouse.ui.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8456?vs=21262&id=21268

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8456

AFFECTED FILES
  kcms/input/CMakeLists.txt
  kcms/input/kcmmouse.ui
  kcms/input/kmousedlg.ui
  kcms/input/mouse.cpp
  kcms/input/mouse.h

To: xuetianweng, subdiff, davidedmundson, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8456: Port kcm input to UI File.

[Roman Gilg]

subdiff added a comment.


  I tested it and everything seems fine. But can we also get rid of the 
separate "General" tab, i.e. the kmousedlg.ui file with its related KMouseDlg 
class, by integrating it into the kcmmouse.ui file like the other tabs? The 
class seems to be some unfinished remnant of a previous attempt of putting tabs 
into ui files.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8456

To: xuetianweng, subdiff, davidedmundson, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8455: Fix DBus startup notification

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Urgh, Thanks
  
  Stable branch too please.

REPOSITORY
  R124 System Settings

BRANCH
  Plasma/5.11

REVISION DETAIL
  https://phabricator.kde.org/D8455

To: fvogt, #plasma, davidedmundson
Cc: ngraham, broulik, rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8456: Port kcm input to UI File.

[Xuetian Weng]

xuetianweng created this revision.
xuetianweng added reviewers: subdiff, davidedmundson, ngraham.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  A split version of https://phabricator.kde.org/D8168. This only refactors the 
hardcoded ui constructor
  into an equilvalent UI file. This change has no string change nor behavior
  change.

TEST PLAN
  Test config opton manually.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8456

AFFECTED FILES
  kcms/input/CMakeLists.txt
  kcms/input/kcmmouse.ui
  kcms/input/kmousedlg.h
  kcms/input/kmousedlg.ui
  kcms/input/mouse.cpp
  kcms/input/mouse.h

To: xuetianweng, subdiff, davidedmundson, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

[kio-extras] [Bug 362988] sftp connection win dolphin hangs/stops working after few seconds

[Elmo R]

https://bugs.kde.org/show_bug.cgi?id=362988

--- Comment #13 from Elmo R  ---
Bump, this is still a problem.

Name: dolphin
Version : 17.08.1
Release : 1.1
Architecture: x86_64
Install Date: Fri Sep 15 20:28:35 2017
Group   : Productivity/File utilities
Size: 1457373
License : GPL-2.0+
Signature   : RSA/SHA256, Tue Sep 12 14:56:39 2017, Key ID b88b2fd43dbdc284
Source RPM  : dolphin-17.08.1-1.1.src.rpm
Build Date  : Thu Sep  7 08:00:00 2017
Build Host  : localhost
Relocations : (not relocatable)
Packager: https://bugs.opensuse.org
Vendor  : openSUSE
URL : http://www.kde.org
Summary : KDE File Manager

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Plasma Workspace Wallpapers] [Bug 386153] plasma is shit

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=386153

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Plasma Workspace Wallpapers] [Bug 386153] New: plasma is shit

[Roman]

https://bugs.kde.org/show_bug.cgi?id=386153

Bug ID: 386153
   Summary: plasma is shit
   Product: Plasma Workspace Wallpapers
   Version: unspecified
  Platform: Mint (Debian based)
OS: Linux
Status: UNCONFIRMED
  Severity: critical
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: romeo.ber...@gmail.com
  Target Milestone: ---

I've used Linux Mint 17.1 KDE (without Plasma) and I was glad by this OS but
when I upgraded Linux Mint to 18.2 version with KDE Plasma that world of Linux
Mint disapoint me. Plasma is shit. I will not describe all bugs because it are
so much that I don't have time for reporting, it will be easy to search new
distributive because I must work and not write reports. So,
1. Wallpaper manager does not work
2. Some applications can not be excluded from autostart because I don't see it
there but it starts automaticaly
3. Network manager permanent deletes file /etc/resolv.conf and I've tired
permanent to write it manually
4. Manager of User groups is missing and therefore I can not resolve USB 2.0 in
virtual box
5. X11/xorg latest version hard hung sometimes and load CPU to 100%
6. Impossibble adjust Hot keys for run applications
Conclusion is such: 
Why it need such beauty when it does not have functionality and works slow???
Plasma is shit. Return pure KDE

-- 
You are receiving this mail because:
You are the assignee for the bug.

D8455: Fix DBus startup notification

[Kai Uwe Broulik]

broulik added a comment.


  This has been broken for most unique apps ever since Plasma 5.0, most 
noticeably with Kate. I once tried to look into KStartupInfo stuff but from 
what I can tell there's a "port me TODO" of some framework (KDBusAddons?) not 
being able to depend on another (KWindowSystem?) and thus a hook "should be 
created" which allows to fix this. But this never happened.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D8455

To: fvogt, #plasma, davidedmundson
Cc: broulik, rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8455: Fix DBus startup notification

[Fabian Vogt]

fvogt added a comment.


  With this the kwin startup notification bounce does not terminate before the 
timeout if it's already running.
  How does kwin notice that the application is already there? Apparently not 
using the dbus service name.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D8455

To: fvogt, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8455: Fix DBus startup notification

[Fabian Vogt]

fvogt created this revision.
fvogt added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  In "Fix colours not updating in systemsettings", the application name
  got changed from "systemsettings5" (inferred from the binary name) to
  "systemsettings", which results in a change from "org.kde.systemsettings5"
  as DBus path to "org.kde.systemsettings". KLauncher uses org.kde.
  by default, so that needs to be overwritten.
  
  Fixes the "KDEInit count not launch /usr/bin/systemsettings5" message after
  closing systemsettings and likely also launching it while it's running.

TEST PLAN
  Opened it from dolphin and closed the window again. Only after
  this patch the KDEInit error message disappeared.

REPOSITORY
  R124 System Settings

BRANCH
  Plasma/5.11

REVISION DETAIL
  https://phabricator.kde.org/D8455

AFFECTED FILES
  app/kdesystemsettings.desktop
  app/systemsettings.desktop

To: fvogt, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8453: Make tooltips in klipper settings dialog translatable

[Burkhard Lück]

lueck created this revision.
lueck added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  remove invalid and superfluous markup "" + "" in kcfg file
  add TranslationSystem=kde to generate i18n() calls for these tooltips using 
the catalog klipper
  defined with setApplicationDomain

TEST PLAN
  tooltips are translated using locale x-test

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8453

AFFECTED FILES
  klipper/klipper.kcfg
  klipper/klippersettings.kcfgc

To: lueck, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8168: kcm_input: Refactor the code and add support for libinput under X11

[Roman Gilg]

subdiff added a comment.


  Wow, very nice! I'm still not sure if on Wayland we should combine Touchpad 
and Mouse KCMs to one "Pointers" KCM how it was proposed years ago, because 
their properties in libinput are very similar. But since you already did the 
work for adding multiple backend to the Mouse KCM let's go with two separate 
ones now!
  
  Your change is very big though. Could we split it up in a patch series? 
Basically by your bullets point in the description. Then we would have the 
following patches in order:
  
  1. UI in kcmmouse.ui.
  2. Backend refactoring
  3. Libinput mouse acceleration and revert scroll (on X)
  4. Libinput macros
  5. No revert scrolling for touchpads
  
  Maybe (2) needs to switch position with (3) and/or (4) with (5).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8168

To: xuetianweng, davidedmundson, mart
Cc: subdiff, ngraham, plasma-devel, leezu, ZrenBot, alexeymin, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D8449: Have a default backend (if one available)

[Crypto Dude]

cryptodude added a comment.


  In https://phabricator.kde.org/D8449#159406, @ivan wrote:
  
  > Having a default backend (IMO) has nothing to do with the UI.
  
  
  I'm not sure what else it would have an effect on. Default to me means its 
just a suggested one and users can still override it.
  
  Where else would you do that than in the UI ?
  
  > What is the rationale behind changing a combo-box (a widget designed for 
multiple choice questions) to a button?
  
  The combobox is still there. Its just not made visible until the user 
indicates they want to actually see it.
  
  I pasted two screenshots. I'll try to implement the actual functionality soon 
so you can play with it.
  
  > I do not mind making CryFS the 'by default selected' choice. But going more 
than that... at this point no.
  
  Thats all I suggested anyway :)
  
  > The only "new generation" system that I've seen the audit of is gocryptfs. 
And that will be probably the next backend Vault will get.
  
  Awesome!

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8449

To: cryptodude, ivan, #plasma
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8449: Have a default backend (if one available)

[Ivan Čukić]

ivan added a comment.


  p.s.
  
  > Do I need to relogin to make a kded module show up?
  
  No. You can just `kquitapp5 kded5; kded5` to restart it.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8449

To: cryptodude, ivan, #plasma
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8449: Have a default backend (if one available)

[Ivan Čukić]

ivan added a comment.


  Having a default backend (IMO) has nothing to do with the UI. What is the 
rationale behind changing a combo-box (a widget designed for multiple choice 
questions) to a button?
  
  As far as CryFS vs EncFS - yes, CryFS is designed to avoid all the problems 
that EncFS has. No, we do not know that it is more secure since there was no 
independent audit of CryFS. It might have serious problems in other areas.
  
  I do not mind making CryFS the 'by default selected' choice. But going more 
than that... at this point no.
  
  The only "new generation" system that I've seen the audit of is gocryptfs. 
And that will be probably the next backend Vault will get.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8449

To: cryptodude, ivan, #plasma
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: System Settings KCM Tidying

[Marco Martin]

On lunedì 23 ottobre 2017 14:05:26 CEST Jan Grulich wrote:
> 
> As I already wrote in another mail thread, I have a student [1] working on
> this. He's not that active as I would like him to be and not progressing
> really much, but he is supposed to finish in ~2 months so I expect he will
> start soon heavily working on this as his deadline is approaching.

can you get him in touch with us as well?
i would really like to get that thing to a full (qml and kirigami)-based kcm, 
which would require a bit of work on his current code as far i see, but 
hopefully not too much

-- 
Marco Martin

Plasma 5.11.2

[Jonathan Riddell]

https://www.kde.org/announcements/plasma-5.11.2.php

 Plasma 5.11.2 fixes issues in GTK Config and elsewhere in System Settings

D8447: Add unit tests for Folder View

[Laurent Montel]

mlaurent added a comment.


  missing copyright in new file too.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8447

To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, 
renatoo, olivierjg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8447: Add unit tests for Folder View

[Laurent Montel]

mlaurent requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8447

To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, 
renatoo, olivierjg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8446: [Notifications] Allow selecting text with mouse

[Aleix Pol Gonzalez]

apol added a comment.


  In https://phabricator.kde.org/D8446#159345, @ngraham wrote:
  
  > +1 IMHO, any text anywhere should always be selectable. You never know when 
or why the user might want or need to select some text on the system, so this 
makes sense to me at least.
  
  
  Such generic statements can't make sense. Do you want to add text selection 
on window decoration, the clocks, kickoff?
  Note that this requires adding tons of complex (and brittle) code such as 
this patch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8446

To: broulik, #plasma, #vdg, apol
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8449: Have a default backend (if one available)

[Nathaniel Graham]

ngraham added a comment.


  That sounds good to me, but yeah, since these differences are super-technical 
and not really relevant to most users, I think that regardless of our 
messaging, a good default is important here if multiple backends are available. 
Based on what you've written, it looks like CryFS is a better default than 
EncFS, but you seem to know a lot about crypto, so I'll defer to you.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8449

To: cryptodude, ivan, #plasma
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8449: Have a default backend (if one available)

[Crypto Dude]

cryptodude added a comment.


  In https://phabricator.kde.org/D8449#159337, @ngraham wrote:
  
  > I don't think choosing a random backend makes sense without at least some 
information provided to the user. How about adding a text view below the 
combobox showing a quick human-friendly summary of the purported advantage of 
each backend? like this:
  
  
  A distro may have a preference, and only install one. This is the main reason 
where the above approach makes a difference. We pick the one that is available. 
With debian (and all derivatives) already having flagged encfs, I think that 
this will have a big impact for a very small price.
  
  But you make a good point. We should not choose randomly.
  
  As I do know a bit about crypto, I can list the differences. Unfortunately 
the difference to end users is probably something they won't care about because 
the differences between the two systems are not really seen in the usecases 
that Vault currently provides. Though I don't know about future plans.
  
  Differences are;
  
  - CryFS has a storage that looks more like a git database than a dir.  EncFS 
has a one-to-one connection between user-file and encrypted file.
  
  We do allow the user to set the "encrypted data location" dir, as such they 
may choose a shared drive (BAD!), but that's not the default and as such this 
difference between systems doesn't really expose much. If it did, I'd suggest 
you avoid encFS as it leaks a lot of metadata that CryFS protects.
  
  - EncFS just one-to-one encrypts a file, and its filename. This means that 
filesystem features like chmod/chown of the main storage are transparently 
visible on the mounted drive. Filename length is similarly limited. Symlinks in 
your mount are symlinks on the target device.
  
  As such you will get a nasty surprise if you store your data dir on something 
like vfat (usb pen) where most of these examples are not available.
  
  - EncFS has a "volume-key-file", which is like your gpg key, a file on the 
filesystem. It additionally requires a password.
  
  This might be useful to do a 2factor authentication, but Vault would need 
quite a lot of extra work to support that. As such this feature is unused.
  
  When it comes to security, both use external libraries (openssl et all) to do 
the actual hard lifting, which are peer reviewed and everything.
  
  more; https://www.cryfs.org/comparison
  
  I'm not sure what to write in a short summary, other than that encfs should 
NOT be used if there is even a small chance of a 3rd party being able to see or 
add to the encrypted files (for instance on a usb-pen).
  
  Ok, what about this;
  we turn off the ability of the user to select a location to store his 
encrypted data if they choose encFS, because it would be insecure.
  
  as such we pre-select cryFS (should it be available), so the user can have 
all the features they want.
  
  We also provide some user-visible information, like you suggested, on actual 
differences for the user. For instance;
  
  CryFS: most secure and user friendly.
   EncFS: Do not use this if you ever expect your encrypted files to be copied 
where others can see them. For instance for backup or on a usb-key or 
cloud-service.
  
  ps. I'd like to see more backends, so this is not a fight between just CryFS 
and EncFS.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8449

To: cryptodude, ivan, #plasma
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: System Settings KCM Tidying

[David Edmundson]

Hopefully we can base Plasma 5.13 off Qt5.10. Probably deserves a different
thread in a few months.

Personally, I want to start wtih M111, it's already in QtQuick, and has the
best reward to effort ratio.
It also defines some components that will get re-used elsewhere. Even if we
only get some of the changes in.

David

D8444: WIP: Define default Action when we plug unknown monitor

[David Edmundson]

davidedmundson added a comment.


  Unless I'm misreading things, I think there's one part that's going to appear 
very confusing.
  
  I have my (small) laptop. Lets say I want any new (big) screen to appear on 
the left. So I save "Extend to left".
  So I'd expect to see: monitor, laptop.
  
  What will happen, is it will extend my biggest screen to the left, leaving me 
with:
  laptop, monitor
  
  rendering the option seemingly broken.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent
Cc: davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8442: WIP: Define default Action when we plug unknown monitor

[Laurent Montel]

mlaurent abandoned this revision.
mlaurent added a comment.


  https://phabricator.kde.org/D8444 was opened.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8442

To: mlaurent
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8444: WIP: Define default Action when we plug unknown monitor

[Laurent Montel]

mlaurent added a comment.


  Wierd why it created a new review ???
  This one is more recent.
  I will close 8442

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8447: Add unit tests for Folder View

[Laurent Montel]

mlaurent added a comment.


  Add in toplevel:
  if(BUILD_TESTING)
  
add_definitions(-DBUILD_TESTING)
  
  endif(BUILD_TESTING)
  + 
  create a folderplugin_private_export.h as
  #ifndef KSIEVEUIPRIVATE_EXPORT_H
  #define KSIEVEUIPRIVATE_EXPORT_H
  
  #include "ksieveui_export.h"
  
  /* Classes which are exported only for unit tests */
  #ifdef BUILD_TESTING
  
  1. ifndef FOLDERPLUGIN_TESTS_EXPORT
  2. define FOLDERPLUGIN_TESTS_EXPORT FOLDERPLUGIN_EXPORT
  3. endif
  
  #else /* not compiling tests */
  
  define FOLDERPLUGIN_TESTS_EXPORT
  
  
  #endif
  
  #endif
  
  > we avoid to export symbol when we don't build test => distro doesn't 
generate lib with unnecessary exported symbol.
  
=

INLINE COMMENTS

> CMakeLists.txt:39
> +generate_export_header(folderplugin BASE_NAME folderplugin)
> +add_subdirectory(tests)

Use 
if(BUILD_TESTING)

  add_subdirectory(tests)

endif()

it's avoid to build tests when distro builds it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8447

To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, 
renatoo, olivierjg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8446: [Notifications] Allow selecting text with mouse

[Nathaniel Graham]

ngraham added a comment.


  +1 IMHO, any text anywhere should always be selectable. You never know when 
or why the user might want or need to select some text on the system, so this 
makes sense to me at least.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8446

To: broulik, #plasma, #vdg, apol
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8444: WIP: Define default Action when we plug unknown monitor

[Nathaniel Graham]

ngraham added a comment.


  Looks like this was opened by mistake; you've already got 
https://phabricator.kde.org/D8442. Can this be closed?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8449: Have a default backend (if one available)

[Crypto Dude]

cryptodude edited the summary of this revision.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8449

To: cryptodude, ivan, #plasma
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8449: Have a default backend (if one available)

[Nathaniel Graham]

ngraham added a comment.


  I don't think choosing a random backend makes sense without at least some 
information provided to the user. How about adding a text view below the 
combobox showing a quick human-friendly summary of the purported advantage of 
each backend? like this:
  
  "EncFS is older and may have X advantage"
  
  CryFS is newer and may be more secure"
  
  Or whatever; I'm hardly an expert in encryption.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8449

To: cryptodude, ivan, #plasma
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8445: [PlasmaComponents Menu] Add ungrabMouseHack

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I was under the impression this hack was only needed when used on a window 
that doesn't take focus. 
  
(https://bugreports.qt.io/browse/QTBUG-59044?focusedCommentId=354424&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-354424)
  
  The popup should, so it doesn't match my findings in the qtbug you're linking 
to.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8445

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8441: Wallpaper: hide color or blur filling options for full filling mode

[Nathaniel Graham]

ngraham added a comment.


  Big +1 from me, if we can resolve the potential issue with images that have 
transparency.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8441

To: guoyunhe, ngraham
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8441: Wallpaper: hide color or blur filling options for full filling mode

[Yunhe Guo]

guoyunhe added a comment.


  In https://phabricator.kde.org/D8441#159329, @ngraham wrote:
  
  > Great, thanks! Much better. Any chance you can upload new screenshots?
  
  
  F5447565: Screenshot_20171024_165656.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8441

To: guoyunhe, ngraham
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8441: Wallpaper: hide color or blur filling options for full filling mode

[Nathaniel Graham]

ngraham added a comment.


  Great, thanks! Much better. Any chance you can upload new screenshots?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8441

To: guoyunhe, ngraham
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8441: Wallpaper: hide color or blur filling options for full filling mode

[Yunhe Guo]

guoyunhe added a comment.


  Done.
  
  In https://phabricator.kde.org/D8441#159321, @ngraham wrote:
  
  > Here's how I would do it:
  >
  >   Background: * Blur
  >   * Solid color: [color chooser]
  >

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8441

To: guoyunhe, ngraham
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8441: Wallpaper: hide color or blur filling options for full filling mode

[Yunhe Guo]

guoyunhe updated this revision to Diff 21241.
guoyunhe added a comment.


  - Wallpaper: change label text of blur option

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8441?vs=21240&id=21241

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8441

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: guoyunhe, ngraham
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8447: Add unit tests for Folder View

[Andras Mantia]

amantia added reviewers: franckarrecot, renatoo, olivierjg.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8447

To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, 
renatoo, olivierjg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8449: Have a default backend (if one available)

[Nathaniel Graham]

ngraham added reviewers: ivan, Plasma.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8449

To: cryptodude, ivan, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8443: Revert "Make the kde-gtk-config kcm better at checking global gtk settings"

[Aleix Pol Gonzalez]

apol added a comment.


  Well this breaks supporting having configuration over in `/etc`, so indeed 
this wasn't tested.
  
  It's unfortunate that the only solution we always end up in is reverting 
stuff rather than actual investigation. Oh well, I'll spend some time on this 
at some point.
  
  :(

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D8443

To: fvogt, #plasma, apol, davidedmundson
Cc: ngraham, davidedmundson, rikmills, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8441: Wallpaper: hide color or blur filling options for full filling mode

[Nathaniel Graham]

ngraham added a comment.


  Here's how I would do it:
  
Background: * Blur
* Solid color: [color chooser]

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8441

To: guoyunhe, ngraham
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8446: [Notifications] Allow selecting text with mouse

[Aleix Pol Gonzalez]

apol added a comment.


  I don't think selecting stuff from a notification should be a use case. It 
means that the notification is poorly designed. The code shows.
  That said, you are the maintainer.
  
  As for the code, there's no way I can make sense out of this code, I believe 
you that it works.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8446

To: broulik, #plasma, #vdg, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8449: Have a default backend (if one available)

[Crypto Dude]

cryptodude created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The creation of a new vault uses a wizard.
  
  The first page of the wizard currently shows a combobox with 2 backends, with 
one semi-randomly selected by default.
  The user is instructed to pick one.
  
  Following the bugreport on one of the backend packages being scary to install 
on neon, I'm proposing we make the wizard a little more wizardly. But without 
losing any functionality. Users that want can still do all they can do now.
  
  We make it easier for most users while not limiting the advanced ones.
  
  BUG: 385971
  
  I'm just uploading the first version. WIP! Do I need to relogin to make a 
kded module show up? Or is there some trick I can use to do the development of 
this a little bit easier.
  
  F5447549: screen2.png 
  
  F5447548: screen1.png 

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8449

AFFECTED FILES
  kded/ui/backendchooserwidget.ui

To: cryptodude
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8441: Wallpaper: hide color or blur filling options for full filling mode

[Yunhe Guo]

guoyunhe updated this revision to Diff 21240.
guoyunhe added a comment.


  - Wallpaper: change variable name from edgefilling to background

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8441?vs=21239&id=21240

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8441

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: guoyunhe, ngraham
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8441: Wallpaper: hide color or blur filling options for full filling mode

[Yunhe Guo]

guoyunhe updated this revision to Diff 21239.
guoyunhe added a comment.


  - Wallpaper: change label name

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8441?vs=21218&id=21239

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8441

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: guoyunhe, ngraham
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8441: Wallpaper: hide color or blur filling options for full filling mode

[Yunhe Guo]

guoyunhe added a comment.


  In https://phabricator.kde.org/D8441#159293, @ngraham wrote:
  
  > Can we change "Edge filling" to "Background"?
  
  
  I don't know which word is better because I am not a native English speaker. 
But yeah, I can change it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8441

To: guoyunhe, ngraham
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8441: Wallpaper: hide color or blur filling options for full filling mode

[Nathaniel Graham]

ngraham added a comment.


  Can we change "Edge filling" to "Background"?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8441

To: guoyunhe, ngraham
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8447: Add unit tests for Folder View

[Andras Mantia]

amantia created this revision.
amantia added reviewers: Plasma, ervin, hein, mlaurent, aacid, dvratil.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Add some tests for FolderModel and Positioner classes.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8447

AFFECTED FILES
  containments/desktop/plugins/folder/CMakeLists.txt
  containments/desktop/plugins/folder/foldermodel.h
  containments/desktop/plugins/folder/positioner.h
  containments/desktop/plugins/folder/tests/CMakeLists.txt
  containments/desktop/plugins/folder/tests/foldermodeltest.cpp
  containments/desktop/plugins/folder/tests/foldermodeltest.h
  containments/desktop/plugins/folder/tests/positionertest.cpp
  containments/desktop/plugins/folder/tests/positionertest.h

To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8168: kcm_input: Refactor the code and add support for libinput under X11

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> FindXorgLibinput.cmake:8
> +#
> +# Copyright (c) 2015 David Edmundson 
> +#

that's not your name...

> CMakeLists.txt:58
>  
> -if (SYNAPTICS_FOUND AND X11_Xinput_FOUND)
> +if (SYNAPTICS_FOUND AND XORGLIBINPUT_FOUND AND X11_Xinput_FOUND)
>  add_subdirectory(touchpad)

do you mean "AND"  especially given this is optional?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8168

To: xuetianweng, davidedmundson, mart
Cc: ngraham, plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

Re: System Settings KCM Tidying

[Marco Martin]

On lunedì 23 ottobre 2017 11:10:41 CEST David Edmundson wrote:
> Andres Betts has done a fantastic job of a tonne of doing an initial mockup
> of the new KCMs.
> 
> The mockups are available here:
> https://phabricator.kde.org/M112

having started it, I would put another requirement, that is to wait for Qt 
5.10 dependency as we don't have qqc2 icons on buttons before then even if 
will take more time before merging even one, will give the cleanest

-- 
Marco Martin

D8441: Wallpaper: hide color or blur filling options for full filling mode

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> guoyunhe wrote in config.qml:161
> Ah, I have never thought about this. Is this use case common? I have never 
> seen people use transparent image for wallpaper. Usually it is some photos or 
> JPG images downloaded from internet.
> 
> This brings another problem. Blur image edge filling doesn't work well with 
> transparent images. For transparent image you always need a background color. 
> I am lost...
> 
> If we say, we only support opaque image, the solution is much simpler.

I suppose we could also show the radio buttons if we detect that the image has 
transparency. But yeah, it would be nice if we can only support opaque images. 
It also hadn't occurred to me that anyone would use an image with transparency, 
and I don't know if I've ever seen such a thing in the wild. But of course 
users can be surprising! :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8441

To: guoyunhe, ngraham
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7047: Wallpaper blur background filling effect feature

[Nathaniel Graham]

ngraham added a comment.


  @guoyunhe, Nice! In the future can you use the `arc land` instead of 
committing manually? That way all the history and details in the Summary here 
gets added to the commit, and we have a better paper trail. Thanks!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7047

To: guoyunhe, #plasma_workspaces, ngraham
Cc: ngraham, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8443: Revert "Make the kde-gtk-config kcm better at checking global gtk settings"

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R99:0d0f812a1704: Revert "Make the kde-gtk-config kcm 
better at checking global gtk settings" (authored by fvogt).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8443?vs=21230&id=21234

REVISION DETAIL
  https://phabricator.kde.org/D8443

AFFECTED FILES
  CMakeLists.txt
  src/abstractappearance.h
  src/appearancegtk2.cpp
  src/appearancegtk2.h
  src/appearancegtk3.cpp
  src/appearancegtk3.h
  src/appearencegtk.cpp
  tests/CMakeLists.txt
  tests/configsavetest.cpp
  tests/configsavetest.h

To: fvogt, #plasma, apol, davidedmundson
Cc: ngraham, davidedmundson, rikmills, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8446: [Notifications] Allow selecting text with mouse

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8446

To: broulik, #plasma, #vdg, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8168: kcm_input: Refactor the code and add support for libinput under X11

[Nathaniel Graham]

ngraham edited projects, added Plasma on Wayland; removed Plasma.
ngraham added a comment.


  This is going to be a necessity for Wayland, given that libinput is mandatory.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8168

To: xuetianweng, davidedmundson, mart
Cc: ngraham, plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D8446: [Notifications] Allow selecting text with mouse

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG, apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This was lost by the introduction of the default action as the MouseArea 
steals events from the TextField below.
  To address this, selecting text and click handling has been implemented 
manually. Furthermore, the mouse cursor is changed to an IBeam cursor and turns 
into a hand when above hyperlinks whose URL can now also be copied separately 
from its text in the context menu.
  
  BUG: 386118
  FIXED-IN: 5.12.0

TEST PLAN
  - Clicking action buttons still works
  - Clicking a notification with default action will still trigger the default 
action. An action without will not do anything, ie. the dialog won't close, 
just as before
  - Clicking a hyperlink will open it
  - Click vs select drag feels natural, I implemented it using manhattan length 
similarly to MouseEventListener
  - The cursor is an IBeam over the entire body text area and turns into a 
pointing hand when ontop of a hyperlink
  - Right click menu "Select All" entries select all text, "Copy" copies the 
text. Ontop of Hyperlinks the "Copy Link" entry copies the hyperlink's URL
  - Notification still seems to timeout properly, with or without user 
interaction
  
  Needs https://phabricator.kde.org/D8445 (ungrab mouse hack) or else after 
having opened the context menu, you continue randomly selecting text as the 
MouseArea gets confused as to whether the mouse is pressed or not.
  
  Only quirk I noticed is that while selecting text will scroll down the view 
as needed it won't work to scroll back up but whatever.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8446

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: broulik, #plasma, #vdg, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Re: System Settings KCM Tidying

[Jan Grulich]

On úterý 24. října 2017 14:11:36 CEST Marco Martin wrote:
> On lunedì 23 ottobre 2017 14:05:26 CEST Jan Grulich wrote:
> > 3 years from now, that's doable and I believe that even sooner, I was just
> > pointing out that it's not something possible for Plasma 5.12 or maybe not
> > also for Plasma 5.13, but I'll do my best as usual.
> 
> oh, no, it's a long-term plan, no need to hurry or putting out sub-par
> solutions :)
> but yes, the long term plan is to not support anymore qwidget-based kcms, so
> systemsettings codebase can be radically simplified compared to the current
> hybrid we have
> 
> > As I already wrote in another mail thread, I have a student [1] working on
> > this. He's not that active as I would like him to be and not progressing
> > really much, but he is supposed to finish in ~2 months so I expect he will
> > start soon heavily working on this as his deadline is approaching.
> > 
> > [1] - https://github.com/MartinKacej/plasma-nm
> 
> ah! i wasn't even aware of this. is it something that can be already tried?
> that looks like a fork of the plasma-nm repo.. where i should look at? the
> mobile folder?

It's under mobile folder in plasma-nm so he can easily use all stuff plasma-nm 
provide, but still there is really nothing working, he is still just playing 
around. I'm not really happy he hasn't done that much and I hope he won't 
start coding like a crazy monkey during christmas time, because his deadline 
is at the beginning of January.

D8445: [PlasmaComponents Menu] Add ungrabMouseHack

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Ensures the PlasmaComponents.Menu doesn't confuse MouseArea states.

TEST PLAN
  Put a ContextMenu into NotificationPopup, opened it, selected an item, and 
the MouseArea knew it wasn't pressed anymore. Before it got confused.
  Also played around in Kickoff and Task Manager and didn't notice anything 
suspicious

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8445

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qmenu.cpp
  src/declarativeimports/plasmacomponents/qmenu.h

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8444: WIP: Define default Action when we plug unknown monitor

[Laurent Montel]

mlaurent created this revision.
mlaurent added a project: Plasma.

REVISION SUMMARY
  Default action when we plug unknown monitor

REPOSITORY
  R104 KScreen

BRANCH
  customize_connect_unknown_monitor

REVISION DETAIL
  https://phabricator.kde.org/D8444

AFFECTED FILES
  kcm/src/kcm_kscreen.cpp
  kcm/src/widget.cpp
  kcm/src/widget.h
  kded/generator.cpp
  kded/generator.h
  tests/kded/CMakeLists.txt

To: mlaurent
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Re: System Settings KCM Tidying

[Marco Martin]

On lunedì 23 ottobre 2017 16:15:57 CEST Martin Flöser wrote:
> > As 5.12 is LTS, lets not treat the workboard as a race, there is a
> > branch in plasma-desktop called KcmQmlPorts that is worth making use
> > of.
> 
> My request for KWin is maximum of one KCM per release cycle. I'm
> expecting regressions due to the age of the code (sorry, experience).

yes, I think it's reasonable



-- 
Marco Martin

Re: System Settings KCM Tidying

[Marco Martin]

On lunedì 23 ottobre 2017 14:05:26 CEST Jan Grulich wrote:
> 3 years from now, that's doable and I believe that even sooner, I was just
> pointing out that it's not something possible for Plasma 5.12 or maybe not
> also for Plasma 5.13, but I'll do my best as usual.

oh, no, it's a long-term plan, no need to hurry or putting out sub-par 
solutions :)
but yes, the long term plan is to not support anymore qwidget-based kcms, so 
systemsettings codebase can be radically simplified compared to the current 
hybrid we have

> As I already wrote in another mail thread, I have a student [1] working on
> this. He's not that active as I would like him to be and not progressing
> really much, but he is supposed to finish in ~2 months so I expect he will
> start soon heavily working on this as his deadline is approaching.
> 
> [1] - https://github.com/MartinKacej/plasma-nm

ah! i wasn't even aware of this. is it something that can be already tried? 
that looks like a fork of the plasma-nm repo.. where i should look at? the 
mobile folder?

-- 
Marco Martin

D8443: Revert "Make the kde-gtk-config kcm better at checking global gtk settings"

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Heh, so much for unit tests.
  
  Hopefully we can revisit this for master and try and fix whatever the 
original one was doing.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  revert

REVISION DETAIL
  https://phabricator.kde.org/D8443

To: fvogt, #plasma, apol, davidedmundson
Cc: davidedmundson, rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8443: Revert "Make the kde-gtk-config kcm better at checking global gtk settings"

[Rik Mills]

rikmills added a comment.


  I made the same revert to test earlier this morning, and on **brief** testing 
it seems to have solved the issue, and tests still pass.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D8443

To: fvogt, #plasma, apol
Cc: rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8443: Revert "Make the kde-gtk-config kcm better at checking global gtk settings"

[Fabian Vogt]

fvogt created this revision.
fvogt added reviewers: Plasma, apol.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  This reverts commit 
https://phabricator.kde.org/R99:34357f74ee2d98128ff423b0ec6ddcbf4232c475.
  
  Reverting this fixes loading of the actually used GTK settings.
  
  BUG: 382291

TEST PLAN
  Opened kcmshell5 kde-gtk-config with and without this revert.
  Without, it shows Adwaita as theme, with it shows breeze.
  GTK uses breeze, so the behaviour with the revert is correct.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  revert

REVISION DETAIL
  https://phabricator.kde.org/D8443

AFFECTED FILES
  CMakeLists.txt
  src/abstractappearance.h
  src/appearancegtk2.cpp
  src/appearancegtk2.h
  src/appearancegtk3.cpp
  src/appearancegtk3.h
  src/appearencegtk.cpp
  tests/CMakeLists.txt
  tests/configsavetest.cpp
  tests/configsavetest.h

To: fvogt, #plasma, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7558: kcms/input: Allow WheelScrollLines = 0; some code cleanup

[Valeriy Malov]

valeriymalov abandoned this revision.
valeriymalov added a comment.


  kcm_input seems to be getting proper refactor in 
https://phabricator.kde.org/D8168

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7558

To: valeriymalov, #plasma, #vdg
Cc: graesslin, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D8436: use a single QML engine

[Marco Martin]

mart edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D8436

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8436: use a single QML engine

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D8436#159212, @davidedmundson wrote:
  
  > Given the fallout we had when we made the similar change in Plasma, please 
don't merge until the start of the next release cycle.
  
  
  after november first week release? ok
  
  > Can you expand your "normal system settings seems unaffected" into 
something more thorough with a list of the relevant KCMs.
  
  currently ported modules are
  
  - desktop theme
  - look and feel
  - sound
  - splash screen
  - boot splash

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D8436

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8436: use a single QML engine

[David Edmundson]

davidedmundson added a comment.


  Given the fallout we had when we made the similar change in Plasma, please 
don't merge until the start of the next release cycle.
  
  Can you expand your "normal system settings seems unaffected" into something 
more thorough with a list of the relevant KCMs.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D8436

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8436: use a single QML engine

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in configmodule.cpp:106
> !!

this version now should work, as the context is used now: the way the static 
attached property function finds it is quite an heuristic, but should be 100% 
reliable

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D8436

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8436: use a single QML engine

[Marco Martin]

mart updated this revision to Diff 21224.
mart added a comment.


  - use the qmlobject's rootcontext instead of the engine as is now shared

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8436?vs=21223&id=21224

BRANCH
  arcpatch-D8436

REVISION DETAIL
  https://phabricator.kde.org/D8436

AFFECTED FILES
  src/quickaddons/configmodule.cpp

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8436: use a single QML engine

[Marco Martin]

mart updated this revision to Diff 21223.
mart added a comment.


  - use the qmlobject's rootcontext instead of the engine as is now shared

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8436?vs=21184&id=21223

BRANCH
  arcpatch-D8436

REVISION DETAIL
  https://phabricator.kde.org/D8436

AFFECTED FILES
  src/quickaddons/configmodule.cpp

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8402: Support "domain-suffix-match" in Security8021xSetting

[Marius Kittler]

Martchus added a task: T7232: Allow specifying domain in plasma-nm Wi-Fi 
security settings.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D8402

To: Martchus, #plasma, jgrulich
Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

[Marius Kittler]

Martchus added a task: T7232: Allow specifying domain in plasma-nm Wi-Fi 
security settings.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D8405

To: Martchus, #plasma, jgrulich
Cc: jgrulich, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:97cd51d30994: Allow to set 
"domain-suffix-match" in Wi-Fi settings (authored by jgrulich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8405?vs=21150&id=21221#toc

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8405?vs=21150&id=21221

REVISION DETAIL
  https://phabricator.kde.org/D8405

AFFECTED FILES
  kcm/kcm.cpp
  libs/editor/settings/security802-1x.cpp
  libs/editor/settings/ui/802-1x.ui

To: Martchus, #plasma, jgrulich
Cc: jgrulich, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8402: Support "domain-suffix-match" in Security8021xSetting

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:7491ed93c8cb: Support "domain-suffix-match" in 
Security8021xSetting (authored by jgrulich).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8402?vs=21153&id=21220

REVISION DETAIL
  https://phabricator.kde.org/D8402

AFFECTED FILES
  autotests/settings/8021xsettingtest.cpp
  src/settings/security8021xsetting.cpp
  src/settings/security8021xsetting.h
  src/settings/security8021xsetting_p.h

To: Martchus, #plasma, jgrulich
Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8441: Wallpaper: hide color or blur filling options for full filling mode

[Yunhe Guo]

guoyunhe added inline comments.

INLINE COMMENTS

> davidedmundson wrote in config.qml:161
> This used to be the case, then it was changed for some obscure use case with 
> transparaent images.

Ah, I have never thought about this. Is this use case common? I have never seen 
people use transparent image for wallpaper. Usually it is some photos or JPG 
images downloaded from internet.

This brings another problem. Blur image edge filling doesn't work well with 
transparent images. For transparent image you always need a background color. I 
am lost...

If we say, we only support opaque image, the solution is much simpler.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8441

To: guoyunhe, ngraham
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8442: WIP: Define default Action when we plug unknown monitor

[Laurent Montel]

mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Default action when we plug unknown monitor

REPOSITORY
  R104 KScreen

BRANCH
  customize_connect_unknown_monitor

REVISION DETAIL
  https://phabricator.kde.org/D8442

AFFECTED FILES
  kcm/src/kcm_kscreen.cpp
  kcm/src/widget.cpp
  kcm/src/widget.h
  kded/generator.cpp
  kded/generator.h
  tests/kded/CMakeLists.txt

To: mlaurent
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8402: Support "domain-suffix-match" in Security8021xSetting

[Marius Kittler]

Martchus added a comment.


  I don't have commit access so somebody needs to merge this for me.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D8402

To: Martchus, #plasma, jgrulich
Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

[Marius Kittler]

Martchus added a comment.


  I don't have commit access so somebody needs to merge this for me.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D8405

To: Martchus, #plasma, jgrulich
Cc: jgrulich, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8441: Wallpaper: hide color or blur filling options for full filling mode

[Yunhe Guo]

guoyunhe edited the summary of this revision.
guoyunhe added a reviewer: ngraham.
guoyunhe added a subscriber: ngraham.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8441

To: guoyunhe, ngraham
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8441: Wallpaper: hide color or blur filling options for full filling mode

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> config.qml:161
>  id: colorRow
> +visible: cfg_FillMode === Image.PreserveAspectFit || cfg_FillMode 
> === Image.Pad
>  spacing: units.largeSpacing / 2

This used to be the case, then it was changed for some obscure use case with 
transparaent images.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8441

To: guoyunhe
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8441: Wallpaper: hide color or blur filling options for full filling mode

[Yunhe Guo]

guoyunhe created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8441

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: guoyunhe
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7047: Wallpaper blur background filling effect feature

[Yunhe Guo]

guoyunhe closed this revision.
guoyunhe added a comment.


  This patch has been committed to master branch. I will add the 
color/blur-image radio buttons in another patch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7047

To: guoyunhe, #plasma_workspaces, ngraham
Cc: ngraham, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

[Alex Richardson]

arichardson updated this revision to Diff 21216.
arichardson added a comment.


  - rebased
  - removed runtime check

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4193?vs=13383&id=21216

BRANCH
  arcpatch-D4193

REVISION DETAIL
  https://phabricator.kde.org/D4193

AFFECTED FILES
  src/platformtheme/kdeplatformfiledialoghelper.cpp

To: arichardson, #plasma
Cc: ngraham, krzyc, anthonyfieroni, elvisangelaccio, graesslin, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D8419: Dict Engine: improve error handling.

[David Faure]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c2cf81f26bfe: Dict Engine: improve error handling. 
(authored by dfaure).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8419?vs=21116&id=21215#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8419?vs=21116&id=21215

REVISION DETAIL
  https://phabricator.kde.org/D8419

AFFECTED FILES
  dataengines/dict/CMakeLists.txt
  dataengines/dict/dictengine.cpp

To: dfaure, #plasma, davidedmundson
Cc: broulik, plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8419: Dict Engine: improve error handling.

[David Faure]

dfaure added a comment.


  In https://phabricator.kde.org/D8419#158645, @broulik wrote:
  
  > Don't you also need a `Messages.sh` and `TRANSLATION_DOMAIN` define?
  
  
  Well spotted. The Messages.sh file was there, but not the define. Fixed and 
pushed.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.11

REVISION DETAIL
  https://phabricator.kde.org/D8419

To: dfaure, #plasma, davidedmundson
Cc: broulik, plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7181: [Task Manager] Elide context menu entries

[Eike Hein]

hein added a comment.


  Kai, ping?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7181

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7481: RFC: Batch window changes events on XCB

[Eike Hein]

hein added a comment.


  David, ping?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7481

To: davidedmundson, #plasma
Cc: ngraham, cfeck, broulik, hein, graesslin, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D6880: [Folder View] Indicate cut items

[Eike Hein]

hein added a comment.


  Kai, ping? IIRC we determined KDirModel does this already and this is 
misguided somehow?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6880

To: broulik, #plasma, hein, #vdg, emmanuelp, dfaure
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart