D9618: Don't send keyboard events to QWindows which have outputOnly property set

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added KWin; removed Plasma.

REPOSITORY
  R108 KWin

BRANCH
  internal-window-ignore-keyboard-output-only

REVISION DETAIL
  https://phabricator.kde.org/D9618

To: graesslin, #kwin, #plasma, broulik
Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D9631: [DBusMenuImporter] Send "opened" signal alongside about to show

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9631

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9631: [DBusMenuImporter] Send "opened" signal alongside about to show

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> dbusmenuimporter.cpp:436
>  auto menu = action->menu();
>  connect(menu, &QMenu::aboutToShow, this, [menu, this]() {
> +updateMenu(menu);

This needs to be a unique connection see https://phabricator.kde.org/D5706

(which might mean moving updateMenu into slotMenuAboutToShow)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9631

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9633: Add a private libPlasmaWeatherSolar for the ion data engines

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Better ideas very welcome, this is just a desperate first shot at the 
challenge.
  
  (Yes, right in time before feature freeze, boh me. One could also claim 
though it is rather a late Plasma5 porting regression fix ;) )

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9633

To: kossebau, #plasma, jriddell
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9599: Create interface for passing server decoration palettes

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:dec26d932914: Create interface for passing server 
decoration palettes (authored by davidedmundson).
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D9599?vs=24569&id=24655#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9599?vs=24569&id=24655

REVISION DETAIL
  https://phabricator.kde.org/D9599

AFFECTED FILES
  autotests/client/CMakeLists.txt
  src/client/CMakeLists.txt
  src/client/protocols/server-decoration-palette.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/server_decoration_palette.cpp
  src/client/server_decoration_palette.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/server_decoration_palette_interface.cpp
  src/server/server_decoration_palette_interface.h

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, ngraham, alexeymin, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

KDE CI: Plasma kwayland kf5-qt5 FreeBSDQt5.9 - Build # 14 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20FreeBSDQt5.9/14/
 Project:
Plasma kwayland kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 03 Jan 2018 10:39:47 +
 Build duration:
47 sec and counting
   CONSOLE OUTPUT
  [...truncated 54.11 KB...]-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Found PkgConfig: /usr/local/bin/pkg-config (found version "1.3.10") -- Found Wayland_Client: /usr/local/lib/libwayland-client.so (found version "1.13.0") -- Found Wayland_Server: /usr/local/lib/libwayland-server.so (found version "1.13.0") -- Found Wayland: /usr/local/lib/libwayland-client.so;/usr/local/lib/libwayland-server.so (found suitable version "1.13.0", minimum required is "1.13") found components:  Client Server -- Found WaylandScanner: /usr/local/bin/wayland-scanner  -- Found EGL: /usr/local/lib/libEGL.so (found version "1.5") -- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Could not set up the appstream test. appstreamcli is missing.-- Looking for linux/input.h-- Looking for linux/input.h - not found-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - SuccessCMake Warning (dev) at /usr/local/lib/cmake/Qt5/Qt5ModuleLocation.cmake:4 (set):  Policy CMP0053 is not set: Simplify variable reference and escape sequence  evaluation.  Run "cmake --help-policy CMP0053" for policy details.  Use the  cmake_policy command to set the policy and suppress this warning.  For input:'${_qt5_install_prefix}/Qt5@module@/Qt5@module@Config.cmake'  the old evaluation rules produce:'/usr/local/lib/cmake/Qt5/Qt5Config.cmake'  but the new evaluation rules produce:'/usr/local/lib/cmake/Qt5@module@/Qt5@module@Config.cmake'  Using the old result for compatibility since the policy is not set.Call Stack (most recent call first):  /usr/local/lib/cmake/Qt5/Qt5Config.cmake:25 (include)  autotests/CMakeLists.txt:3 (find_package)This warning is for project developers.  Use -Wno-dev to suppress it.-- The weston executable was not found. Some autotests will not be executed.-- The following OPTIONAL packages have been found: * WaylandScanner, Executable that converts XML protocol files to C code,  * PkgConfig-- The following REQUIRED packages have been found: * ECM (required version >= 5.41.0), Extra CMake Modules.,  * Qt5Concurrent * Qt5Gui * Wayland (required version >= 1.13), C library implementation of the Wayland protocol: a protocol for a compositor to talk to its clients,  * EGL, A platform-agnostic mechanism for creating rendering surfaces for use with other graphics libraries, such as OpenGL|ES and OpenVG.,  * Qt5Test * Qt5 (required version >= 5.7.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- Configuring doneCMake Error at autotests/client/CMakeLists.txt:417 (add_executable):  Cannot find source file:test_server_side_decoration_palette.cpp  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp  .hxx .in .txxCMake Error: CMake can not determine linker language for target: testServerSideDecorationPaletteCMake Error: Cannot determine link language for target "testServerSideDecorationPalette".-- Generating done-- Build files have been written to: /usr/home/jenkins/workspace/Plasma kwayland kf5-qt5 FreeBSDQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Plasma kwayland kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Plasma kwayland kf5-qt5 SUSEQt5.9 - Build # 75 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20SUSEQt5.9/75/
 Project:
Plasma kwayland kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 03 Jan 2018 10:39:48 +
 Build duration:
51 sec and counting
   CONSOLE OUTPUT
  [...truncated 69.62 KB...]NODE_LABELS   = 'Docker Swarm-4417206635a7 SUSEQt5.9'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/etc/xdg'PATH  = '/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'PKG_CONFIG_PATH   = '/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma kwayland kf5-qt5 SUSEQt5.9"-- The C compiler identification is GNU 7.2.1-- The CXX compiler identification is GNU 7.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.2") -- Found Wayland_Client: /usr/lib64/libwayland-client.so (found version "1.14.0") -- Found Wayland_Server: /usr/lib64/libwayland-server.so (found version "1.14.0") -- Found Wayland: /usr/lib64/libwayland-client.so;/usr/lib64/libwayland-server.so (found suitable version "1.14.0", minimum required is "1.13") found components:  Client Server -- Found WaylandScanner: /usr/bin/wayland-scanner  -- Found EGL: /usr/lib64/libEGL.so (found version "1.5") -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Looking for linux/input.h-- Looking for linux/input.h - found-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- The following OPTIONAL packages have been found: * WaylandScanner, Executable that converts XML protocol files to C code,  * PkgConfig-- The following REQUIRED packages have been found: * ECM (required version >= 5.41.0), Extra CMake Modules.,  * Qt5Concurrent * Qt5Gui * Wayland (required version >= 1.13), C library implementation of the Wayland protocol: a protocol for a compositor to talk to its clients,  * EGL, A platform-agnostic mechanism for creating rendering surfaces for use with other graphics libraries, such as OpenGL|ES and OpenVG.,  * Qt5Test * Qt5 (required version >= 5.7.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- Configuring doneCMake Error at autotests/client/CMakeLists.txt:417 (add_executable):  Cannot find source file:test_server_side_decoration_palette.cpp  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp  .hxx .in .txxCMake Error: CMake can not determine linker language for target: testServerSideDecorationPaletteCMake Error: Cannot determine link language for target "testServerSideDecorationPalette".-- Generating done-- Build files have been written to: /home/jenkins/workspace/Plasma kwayland kf5-qt5 SUSEQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Plasma kwayland kf5-qt5 SUSEQt5.9] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9 - Build # 14 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kwayland%20stable-kf5-qt5%20FreeBSDQt5.9/14/
 Project:
Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 03 Jan 2018 10:39:47 +
 Build duration:
29 sec and counting
   CONSOLE OUTPUT
  [...truncated 54.18 KB...]-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Found PkgConfig: /usr/local/bin/pkg-config (found version "1.3.10") -- Found Wayland_Client: /usr/local/lib/libwayland-client.so (found version "1.13.0") -- Found Wayland_Server: /usr/local/lib/libwayland-server.so (found version "1.13.0") -- Found Wayland: /usr/local/lib/libwayland-client.so;/usr/local/lib/libwayland-server.so (found suitable version "1.13.0", minimum required is "1.13") found components:  Client Server -- Found WaylandScanner: /usr/local/bin/wayland-scanner  -- Found EGL: /usr/local/lib/libEGL.so (found version "1.5") -- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Could not set up the appstream test. appstreamcli is missing.-- Looking for linux/input.h-- Looking for linux/input.h - not found-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - SuccessCMake Warning (dev) at /usr/local/lib/cmake/Qt5/Qt5ModuleLocation.cmake:4 (set):  Policy CMP0053 is not set: Simplify variable reference and escape sequence  evaluation.  Run "cmake --help-policy CMP0053" for policy details.  Use the  cmake_policy command to set the policy and suppress this warning.  For input:'${_qt5_install_prefix}/Qt5@module@/Qt5@module@Config.cmake'  the old evaluation rules produce:'/usr/local/lib/cmake/Qt5/Qt5Config.cmake'  but the new evaluation rules produce:'/usr/local/lib/cmake/Qt5@module@/Qt5@module@Config.cmake'  Using the old result for compatibility since the policy is not set.Call Stack (most recent call first):  /usr/local/lib/cmake/Qt5/Qt5Config.cmake:25 (include)  autotests/CMakeLists.txt:3 (find_package)This warning is for project developers.  Use -Wno-dev to suppress it.-- The weston executable was not found. Some autotests will not be executed.-- The following OPTIONAL packages have been found: * WaylandScanner, Executable that converts XML protocol files to C code,  * PkgConfig-- The following REQUIRED packages have been found: * ECM (required version >= 5.41.0), Extra CMake Modules.,  * Qt5Concurrent * Qt5Gui * Wayland (required version >= 1.13), C library implementation of the Wayland protocol: a protocol for a compositor to talk to its clients,  * EGL, A platform-agnostic mechanism for creating rendering surfaces for use with other graphics libraries, such as OpenGL|ES and OpenVG.,  * Qt5Test * Qt5 (required version >= 5.7.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- Configuring doneCMake Error at autotests/client/CMakeLists.txt:417 (add_executable):  Cannot find source file:test_server_side_decoration_palette.cpp  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp  .hxx .in .txxCMake Error: CMake can not determine linker language for target: testServerSideDecorationPaletteCMake Error: Cannot determine link language for target "testServerSideDecorationPalette".-- Generating done-- Build files have been written to: /usr/home/jenkins/workspace/Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Plasma kwayland stable-kf5-qt5 SUSEQt5.9 - Build # 18 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kwayland%20stable-kf5-qt5%20SUSEQt5.9/18/
 Project:
Plasma kwayland stable-kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 03 Jan 2018 10:39:47 +
 Build duration:
3 min 5 sec and counting
   CONSOLE OUTPUT
  [...truncated 69.93 KB...]NODE_LABELS   = 'Docker Swarm-8dfb60d4aa60 SUSEQt5.9'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/etc/xdg'PATH  = '/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'PKG_CONFIG_PATH   = '/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma kwayland stable-kf5-qt5 SUSEQt5.9"-- The C compiler identification is GNU 7.2.1-- The CXX compiler identification is GNU 7.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.2") -- Found Wayland_Client: /usr/lib64/libwayland-client.so (found version "1.14.0") -- Found Wayland_Server: /usr/lib64/libwayland-server.so (found version "1.14.0") -- Found Wayland: /usr/lib64/libwayland-client.so;/usr/lib64/libwayland-server.so (found suitable version "1.14.0", minimum required is "1.13") found components:  Client Server -- Found WaylandScanner: /usr/bin/wayland-scanner  -- Found EGL: /usr/lib64/libEGL.so (found version "1.5") -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Looking for linux/input.h-- Looking for linux/input.h - found-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- The following OPTIONAL packages have been found: * WaylandScanner, Executable that converts XML protocol files to C code,  * PkgConfig-- The following REQUIRED packages have been found: * ECM (required version >= 5.41.0), Extra CMake Modules.,  * Qt5Concurrent * Qt5Gui * Wayland (required version >= 1.13), C library implementation of the Wayland protocol: a protocol for a compositor to talk to its clients,  * EGL, A platform-agnostic mechanism for creating rendering surfaces for use with other graphics libraries, such as OpenGL|ES and OpenVG.,  * Qt5Test * Qt5 (required version >= 5.7.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- Configuring doneCMake Error at autotests/client/CMakeLists.txt:417 (add_executable):  Cannot find source file:test_server_side_decoration_palette.cpp  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp  .hxx .in .txxCMake Error: CMake can not determine linker language for target: testServerSideDecorationPaletteCMake Error: Cannot determine link language for target "testServerSideDecorationPalette".-- Generating done-- Build files have been written to: /home/jenkins/workspace/Plasma kwayland stable-kf5-qt5 SUSEQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Plasma kwayland stable-kf5-qt5 SUSEQt5.9] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Plasma kwayland kf5-qt5 FreeBSDQt5.9 - Build # 15 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20FreeBSDQt5.9/15/
 Project:
Plasma kwayland kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 03 Jan 2018 10:44:37 +
 Build duration:
22 sec and counting
   CONSOLE OUTPUT
  [...truncated 98.35 KB...]Generating MOC source EWIEGA46WW/moc_dataoffer.cppGenerating MOC source EWIEGA46WW/moc_datasource.cppGenerating MOC source EWIEGA46WW/moc_dpms.cppGenerating MOC source EWIEGA46WW/moc_event_queue.cppGenerating MOC source EWIEGA46WW/moc_fakeinput.cppGenerating MOC source EWIEGA46WW/moc_fullscreen_shell.cppGenerating MOC source EWIEGA46WW/moc_idle.cppGenerating MOC source EWIEGA46WW/moc_idleinhibit.cppGenerating MOC source EWIEGA46WW/moc_keyboard.cppGenerating MOC source EWIEGA46WW/moc_output.cppGenerating MOC source EWIEGA46WW/moc_outputconfiguration.cppGenerating MOC source EWIEGA46WW/moc_outputdevice.cppGenerating MOC source EWIEGA46WW/moc_outputmanagement.cppGenerating MOC source EWIEGA46WW/moc_plasmashell.cppGenerating MOC source EWIEGA46WW/moc_plasmawindowmanagement.cppGenerating MOC source EWIEGA46WW/moc_plasmawindowmodel.cppGenerating MOC source EWIEGA46WW/moc_pointer.cppGenerating MOC source EWIEGA46WW/moc_pointerconstraints.cppGenerating MOC source EWIEGA46WW/moc_pointergestures.cppGenerating MOC source EWIEGA46WW/moc_region.cppGenerating MOC source EWIEGA46WW/moc_registry.cpp/usr/home/jenkins/workspace/Plasma kwayland kf5-qt5 FreeBSDQt5.9/src/client/registry.h:171: Parse error at "AppMenu"AutoMoc: Error: moc process failed for"EWIEGA46WW/moc_registry.cpp"AutoMoc: Command:/usr/local/lib/qt5/bin/moc "-I/usr/home/jenkins/workspace/Plasma kwayland kf5-qt5 FreeBSDQt5.9/build/src/client" "-I/usr/home/jenkins/workspace/Plasma kwayland kf5-qt5 FreeBSDQt5.9/build/src/client/KF5WaylandClient_autogen/include" "-I/usr/home/jenkins/workspace/Plasma kwayland kf5-qt5 FreeBSDQt5.9/src/client" "-I/usr/home/jenkins/workspace/Plasma kwayland kf5-qt5 FreeBSDQt5.9/build" -I/usr/local/include/qt5/QtGui/5.9.1 -I/usr/local/include/qt5/QtGui/5.9.1/QtGui -I/usr/local/include/qt5/QtCore/5.9.1 -I/usr/local/include/qt5/QtCore/5.9.1/QtCore -I/usr/local/include/qt5 -I/usr/local/include/qt5/QtGui -I/usr/local/include -I/usr/local/include/qt5/QtCore -I/usr/local/lib/qt5/mkspecs/freebsd-clang -I/usr/local/include/qt5/QtConcurrent -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING -DQT_STRICT_ITERATORS -DQT_USE_FAST_OPERATOR_PLUS -DQT_USE_QSTRINGBUILDER -D_LARGEFILE64_SOURCE -o "/usr/home/jenkins/workspace/Plasma kwayland kf5-qt5 FreeBSDQt5.9/build/src/client/KF5WaylandClient_autogen/EWIEGA46WW/moc_registry.cpp" "/usr/home/jenkins/workspace/Plasma kwayland kf5-qt5 FreeBSDQt5.9/src/client/registry.h"AutoMoc: Command output:/usr/home/jenkins/workspace/Plasma kwayland kf5-qt5 FreeBSDQt5.9/src/client/registry.h:171: Parse error at "AppMenu"gmake[2]: *** [src/client/CMakeFiles/KF5WaylandClient_autogen.dir/build.make:58: src/client/CMakeFiles/KF5WaylandClient_autogen] Error 1gmake[1]: *** [CMakeFiles/Makefile2:212: src/client/CMakeFiles/KF5WaylandClient_autogen.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobsGenerating MOC source EWIEGA46WW/moc_appmenu_interface.cppGenerating MOC source EWIEGA46WW/moc_blur_interface.cppGenerating MOC source EWIEGA46WW/moc_buffer_interface.cppGenerating MOC source EWIEGA46WW/moc_clientconnection.cppGenerating MOC source EWIEGA46WW/moc_compositor_interface.cppGenerating MOC source EWIEGA46WW/moc_contrast_interface.cppGenerating MOC source EWIEGA46WW/moc_datadevice_interface.cppGenerating MOC source EWIEGA46WW/moc_datadevicemanager_interface.cppGenerating MOC source EWIEGA46WW/moc_dataoffer_interface.cppGenerating MOC source EWIEGA46WW/moc_datasource_interface.cppGenerating MOC source EWIEGA46WW/moc_display.cppGenerating MOC source EWIEGA46WW/moc_dpms_interface.cppGenerating MOC source EWIEGA46WW/moc_dpms_interface_p.cppGenerating MOC source EWIEGA46WW/moc_fakeinput_interface.cppGenerating MOC source EWIEGA46WW/moc_filtered_display.cppGenerating MOC source EWIEGA46WW/moc_global.cppGenerating MOC source EWIEGA46WW/moc_idle_interface.cppGenerating MOC source EWIEGA46WW/moc_idleinhibit_interface.cppGenerating MOC source EWIEGA46WW/moc_idleinhibit_interface_p.cppGenerating MOC source EWIEGA46WW/moc_keyboard_interface.cppGenerating MOC source EWIEGA46WW/moc_output_interface.cppGenerating MOC source EWIEGA46WW/moc_outputchangeset.cppGenerating MOC source EWIEGA46WW/moc_outputconfiguration_interface.cppGenerating MOC source EWIEGA46WW/moc_outputdevice_interface.cppGenerating MOC source EWIEGA46WW/moc_outputmanagement_interface.cppGenerating MOC source EWIEGA46WW/moc_plasmashell_interface.cppGenerating MOC source EWIEGA46WW/moc_plasmawindowmanagement_interface.cppGenerating MOC source EWIEGA46WW/moc_pointer_interface.cppGenerating MOC source EWIEGA46WW/moc_pointerconstraints_interface.cppGenerating MOC source EWIEGA46WW/moc_pointerconstra

KDE CI: Plasma kwayland kf5-qt5 SUSEQt5.9 - Build # 76 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20SUSEQt5.9/76/
 Project:
Plasma kwayland kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 03 Jan 2018 10:44:37 +
 Build duration:
56 sec and counting
   CONSOLE OUTPUT
  [...truncated 115.91 KB...]Generating MOC source EWIEGA46WW/moc_fullscreen_shell.cppGenerating MOC source EWIEGA46WW/moc_idle.cppGenerating MOC source EWIEGA46WW/moc_idleinhibit.cppGenerating MOC source EWIEGA46WW/moc_keyboard.cppGenerating MOC source EWIEGA46WW/moc_output.cppGenerating MOC source EWIEGA46WW/moc_outputconfiguration.cppGenerating MOC source EWIEGA46WW/moc_outputdevice.cppGenerating MOC source EWIEGA46WW/moc_outputmanagement.cppGenerating MOC source EWIEGA46WW/moc_plasmashell.cppGenerating MOC source EWIEGA46WW/moc_plasmawindowmanagement.cppGenerating MOC source EWIEGA46WW/moc_plasmawindowmodel.cppGenerating MOC source EWIEGA46WW/moc_pointer.cppGenerating MOC source EWIEGA46WW/moc_pointerconstraints.cppGenerating MOC source EWIEGA46WW/moc_pointergestures.cppGenerating MOC source EWIEGA46WW/moc_region.cppGenerating MOC source EWIEGA46WW/moc_registry.cpp/home/jenkins/workspace/Plasma kwayland kf5-qt5 SUSEQt5.9/src/client/registry.h:171: Parse error at "AppMenu"AutoMoc: Error: moc process failed for"EWIEGA46WW/moc_registry.cpp"AutoMoc: Command:/usr/lib64/qt5/bin/moc "-I/home/jenkins/workspace/Plasma kwayland kf5-qt5 SUSEQt5.9/build/src/client" "-I/home/jenkins/workspace/Plasma kwayland kf5-qt5 SUSEQt5.9/build/src/client/KF5WaylandClient_autogen/include" "-I/home/jenkins/workspace/Plasma kwayland kf5-qt5 SUSEQt5.9/src/client" "-I/home/jenkins/workspace/Plasma kwayland kf5-qt5 SUSEQt5.9/build" -I/usr/include/qt5/QtGui/5.9.3 -I/usr/include/qt5/QtGui/5.9.3/QtGui -I/usr/include/qt5/QtCore/5.9.3 -I/usr/include/qt5/QtCore/5.9.3/QtCore -I/usr/include/qt5 -I/usr/include/qt5/QtGui -I/usr/include/qt5/QtCore -I/usr/lib64/qt5/mkspecs/linux-g++ -I/usr/include/wayland -I/usr/include/qt5/QtConcurrent -I/usr/include -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING -DQT_STRICT_ITERATORS -DQT_USE_FAST_OPERATOR_PLUS -DQT_USE_QSTRINGBUILDER -D_GNU_SOURCE -D_LARGEFILE64_SOURCE --include "/home/jenkins/workspace/Plasma kwayland kf5-qt5 SUSEQt5.9/build/src/client/KF5WaylandClient_autogen/moc_predefs.h" -o "/home/jenkins/workspace/Plasma kwayland kf5-qt5 SUSEQt5.9/build/src/client/KF5WaylandClient_autogen/EWIEGA46WW/moc_registry.cpp" "/home/jenkins/workspace/Plasma kwayland kf5-qt5 SUSEQt5.9/src/client/registry.h"AutoMoc: Command output:/home/jenkins/workspace/Plasma kwayland kf5-qt5 SUSEQt5.9/src/client/registry.h:171: Parse error at "AppMenu"make[2]: *** [src/client/CMakeFiles/KF5WaylandClient_autogen.dir/build.make:58: src/client/CMakeFiles/KF5WaylandClient_autogen] Error 1make[1]: *** [CMakeFiles/Makefile2:212: src/client/CMakeFiles/KF5WaylandClient_autogen.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[  1%] Linking CXX executable ../../bin/surfaceExtensionHelper[  1%] Built target surfaceExtensionHelperGenerating MOC predefs moc_predefs.hGenerating MOC source EWIEGA46WW/moc_appmenu_interface.cppGenerating MOC source EWIEGA46WW/moc_blur_interface.cppGenerating MOC source EWIEGA46WW/moc_buffer_interface.cppGenerating MOC source EWIEGA46WW/moc_clientconnection.cppGenerating MOC source EWIEGA46WW/moc_compositor_interface.cppGenerating MOC source EWIEGA46WW/moc_contrast_interface.cppGenerating MOC source EWIEGA46WW/moc_datadevice_interface.cppGenerating MOC source EWIEGA46WW/moc_datadevicemanager_interface.cppGenerating MOC source EWIEGA46WW/moc_dataoffer_interface.cppGenerating MOC source EWIEGA46WW/moc_datasource_interface.cppGenerating MOC source EWIEGA46WW/moc_display.cppGenerating MOC source EWIEGA46WW/moc_dpms_interface.cppGenerating MOC source EWIEGA46WW/moc_dpms_interface_p.cppGenerating MOC source EWIEGA46WW/moc_fakeinput_interface.cppGenerating MOC source EWIEGA46WW/moc_filtered_display.cppGenerating MOC source EWIEGA46WW/moc_global.cppGenerating MOC source EWIEGA46WW/moc_idle_interface.cppGenerating MOC source EWIEGA46WW/moc_idleinhibit_interface.cppGenerating MOC source EWIEGA46WW/moc_idleinhibit_interface_p.cppGenerating MOC source EWIEGA46WW/moc_keyboard_interface.cppGenerating MOC source EWIEGA46WW/moc_output_interface.cppGenerating MOC source EWIEGA46WW/moc_outputchangeset.cppGenerating MOC source EWIEGA46WW/moc_outputconfiguration_interface.cppGenerating MOC source EWIEGA46WW/moc_outputdevice_interface.cppGenerating MOC source EWIEGA46WW/moc_outputmanagement_interface.cppGenerating MOC source EWIEGA46WW/moc_plasmashell_interface.cppGenerating MOC source EWIEGA46WW/moc_plasmawindowmanagement_interface.cppGenerating MOC source EWIEGA46WW/moc_pointer_interface.cppGenerating MOC source EWIEGA46WW/moc_pointerconstraints_interface.cppGenerating MOC source EWIEGA46WW/moc_pointerconstraints_interface_p.cppGenerating MOC source EWIEGA46WW/moc_pointergestures_in

KDE CI: Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9 - Build # 15 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kwayland%20stable-kf5-qt5%20FreeBSDQt5.9/15/
 Project:
Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 03 Jan 2018 10:44:37 +
 Build duration:
31 sec and counting
   CONSOLE OUTPUT
  [...truncated 98.58 KB...]Generating MOC source EWIEGA46WW/moc_dataoffer.cppGenerating MOC source EWIEGA46WW/moc_datasource.cppGenerating MOC source EWIEGA46WW/moc_dpms.cppGenerating MOC source EWIEGA46WW/moc_event_queue.cppGenerating MOC source EWIEGA46WW/moc_fakeinput.cppGenerating MOC source EWIEGA46WW/moc_fullscreen_shell.cppGenerating MOC source EWIEGA46WW/moc_idle.cppGenerating MOC source EWIEGA46WW/moc_idleinhibit.cppGenerating MOC source EWIEGA46WW/moc_keyboard.cppGenerating MOC source EWIEGA46WW/moc_output.cppGenerating MOC source EWIEGA46WW/moc_outputconfiguration.cppGenerating MOC source EWIEGA46WW/moc_outputdevice.cppGenerating MOC source EWIEGA46WW/moc_outputmanagement.cppGenerating MOC source EWIEGA46WW/moc_plasmashell.cppGenerating MOC source EWIEGA46WW/moc_plasmawindowmanagement.cppGenerating MOC source EWIEGA46WW/moc_plasmawindowmodel.cppGenerating MOC source EWIEGA46WW/moc_pointer.cppGenerating MOC source EWIEGA46WW/moc_pointerconstraints.cppGenerating MOC source EWIEGA46WW/moc_pointergestures.cppGenerating MOC source EWIEGA46WW/moc_region.cppGenerating MOC source EWIEGA46WW/moc_registry.cpp/usr/home/jenkins/workspace/Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9/src/client/registry.h:171: Parse error at "AppMenu"AutoMoc: Error: moc process failed for"EWIEGA46WW/moc_registry.cpp"AutoMoc: Command:/usr/local/lib/qt5/bin/moc "-I/usr/home/jenkins/workspace/Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9/build/src/client" "-I/usr/home/jenkins/workspace/Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9/build/src/client/KF5WaylandClient_autogen/include" "-I/usr/home/jenkins/workspace/Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9/src/client" "-I/usr/home/jenkins/workspace/Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9/build" -I/usr/local/include/qt5/QtGui/5.9.1 -I/usr/local/include/qt5/QtGui/5.9.1/QtGui -I/usr/local/include/qt5/QtCore/5.9.1 -I/usr/local/include/qt5/QtCore/5.9.1/QtCore -I/usr/local/include/qt5 -I/usr/local/include/qt5/QtGui -I/usr/local/include -I/usr/local/include/qt5/QtCore -I/usr/local/lib/qt5/mkspecs/freebsd-clang -I/usr/local/include/qt5/QtConcurrent -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING -DQT_STRICT_ITERATORS -DQT_USE_FAST_OPERATOR_PLUS -DQT_USE_QSTRINGBUILDER -D_LARGEFILE64_SOURCE -o "/usr/home/jenkins/workspace/Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9/build/src/client/KF5WaylandClient_autogen/EWIEGA46WW/moc_registry.cpp" "/usr/home/jenkins/workspace/Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9/src/client/registry.h"AutoMoc: Command output:/usr/home/jenkins/workspace/Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9/src/client/registry.h:171: Parse error at "AppMenu"gmake[2]: *** [src/client/CMakeFiles/KF5WaylandClient_autogen.dir/build.make:58: src/client/CMakeFiles/KF5WaylandClient_autogen] Error 1gmake[1]: *** [CMakeFiles/Makefile2:212: src/client/CMakeFiles/KF5WaylandClient_autogen.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobsGenerating MOC source EWIEGA46WW/moc_appmenu_interface.cppGenerating MOC source EWIEGA46WW/moc_blur_interface.cppGenerating MOC source EWIEGA46WW/moc_buffer_interface.cppGenerating MOC source EWIEGA46WW/moc_clientconnection.cppGenerating MOC source EWIEGA46WW/moc_compositor_interface.cppGenerating MOC source EWIEGA46WW/moc_contrast_interface.cppGenerating MOC source EWIEGA46WW/moc_datadevice_interface.cppGenerating MOC source EWIEGA46WW/moc_datadevicemanager_interface.cppGenerating MOC source EWIEGA46WW/moc_dataoffer_interface.cppGenerating MOC source EWIEGA46WW/moc_datasource_interface.cppGenerating MOC source EWIEGA46WW/moc_display.cppGenerating MOC source EWIEGA46WW/moc_dpms_interface.cppGenerating MOC source EWIEGA46WW/moc_dpms_interface_p.cppGenerating MOC source EWIEGA46WW/moc_fakeinput_interface.cppGenerating MOC source EWIEGA46WW/moc_filtered_display.cppGenerating MOC source EWIEGA46WW/moc_global.cppGenerating MOC source EWIEGA46WW/moc_idle_interface.cppGenerating MOC source EWIEGA46WW/moc_idleinhibit_interface.cppGenerating MOC source EWIEGA46WW/moc_idleinhibit_interface_p.cppGenerating MOC source EWIEGA46WW/moc_keyboard_interface.cppGenerating MOC source EWIEGA46WW/moc_output_interface.cppGenerating MOC source EWIEGA46WW/moc_outputchangeset.cppGenerating MOC source EWIEGA46WW/moc_outputconfiguration_interface.cppGenerating MOC source EWIEGA46WW/moc_outputdevice_interface.cppGenerating MOC source EWIEGA46WW/moc_outputmanagement_interface.cppGenerating MOC source EWIEGA46WW/moc_plasmashell_interface.cppGenerating MOC source EWIEGA46WW/moc_plasmawindowmanagement_interface.cppGenerating MOC source EWIEGA46WW/moc_pointer_interface.cppGenerating MOC source EWIEGA46WW/moc_pointerconstr

KDE CI: Plasma kwayland stable-kf5-qt5 SUSEQt5.9 - Build # 19 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kwayland%20stable-kf5-qt5%20SUSEQt5.9/19/
 Project:
Plasma kwayland stable-kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 03 Jan 2018 10:44:37 +
 Build duration:
3 min 9 sec and counting
   CONSOLE OUTPUT
  [...truncated 107.70 KB...]Generating MOC source EWIEGA46WW/moc_datasource.cppGenerating MOC source EWIEGA46WW/moc_dpms.cppGenerating MOC source EWIEGA46WW/moc_event_queue.cppGenerating MOC source EWIEGA46WW/moc_fakeinput.cppGenerating MOC source EWIEGA46WW/moc_fullscreen_shell.cppGenerating MOC source EWIEGA46WW/moc_idle.cppGenerating MOC source EWIEGA46WW/moc_idleinhibit.cppGenerating MOC source EWIEGA46WW/moc_keyboard.cppGenerating MOC source EWIEGA46WW/moc_output.cppGenerating MOC source EWIEGA46WW/moc_outputconfiguration.cppGenerating MOC source EWIEGA46WW/moc_outputdevice.cppGenerating MOC source EWIEGA46WW/moc_outputmanagement.cppGenerating MOC source EWIEGA46WW/moc_plasmashell.cppGenerating MOC source EWIEGA46WW/moc_plasmawindowmanagement.cppGenerating MOC source EWIEGA46WW/moc_plasmawindowmodel.cppGenerating MOC source EWIEGA46WW/moc_pointer.cppGenerating MOC source EWIEGA46WW/moc_pointerconstraints.cppGenerating MOC source EWIEGA46WW/moc_pointergestures.cppGenerating MOC source EWIEGA46WW/moc_region.cppGenerating MOC source EWIEGA46WW/moc_registry.cpp/home/jenkins/workspace/Plasma kwayland stable-kf5-qt5 SUSEQt5.9/src/client/registry.h:171: Parse error at "AppMenu"AutoMoc: Error: moc process failed for"EWIEGA46WW/moc_registry.cpp"AutoMoc: Command:/usr/lib64/qt5/bin/moc "-I/home/jenkins/workspace/Plasma kwayland stable-kf5-qt5 SUSEQt5.9/build/src/client" "-I/home/jenkins/workspace/Plasma kwayland stable-kf5-qt5 SUSEQt5.9/build/src/client/KF5WaylandClient_autogen/include" "-I/home/jenkins/workspace/Plasma kwayland stable-kf5-qt5 SUSEQt5.9/src/client" "-I/home/jenkins/workspace/Plasma kwayland stable-kf5-qt5 SUSEQt5.9/build" -I/usr/include/qt5/QtGui/5.9.3 -I/usr/include/qt5/QtGui/5.9.3/QtGui -I/usr/include/qt5/QtCore/5.9.3 -I/usr/include/qt5/QtCore/5.9.3/QtCore -I/usr/include/qt5 -I/usr/include/qt5/QtGui -I/usr/include/qt5/QtCore -I/usr/lib64/qt5/mkspecs/linux-g++ -I/usr/include/wayland -I/usr/include/qt5/QtConcurrent -I/usr/include -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING -DQT_STRICT_ITERATORS -DQT_USE_FAST_OPERATOR_PLUS -DQT_USE_QSTRINGBUILDER -D_GNU_SOURCE -D_LARGEFILE64_SOURCE --include "/home/jenkins/workspace/Plasma kwayland stable-kf5-qt5 SUSEQt5.9/build/src/client/KF5WaylandClient_autogen/moc_predefs.h" -o "/home/jenkins/workspace/Plasma kwayland stable-kf5-qt5 SUSEQt5.9/build/src/client/KF5WaylandClient_autogen/EWIEGA46WW/moc_registry.cpp" "/home/jenkins/workspace/Plasma kwayland stable-kf5-qt5 SUSEQt5.9/src/client/registry.h"AutoMoc: Command output:/home/jenkins/workspace/Plasma kwayland stable-kf5-qt5 SUSEQt5.9/src/client/registry.h:171: Parse error at "AppMenu"make[2]: *** [src/client/CMakeFiles/KF5WaylandClient_autogen.dir/build.make:58: src/client/CMakeFiles/KF5WaylandClient_autogen] Error 1make[1]: *** [CMakeFiles/Makefile2:212: src/client/CMakeFiles/KF5WaylandClient_autogen.dir/all] Error 2make[1]: *** Waiting for unfinished jobsGenerating MOC predefs moc_predefs.hGenerating MOC source EWIEGA46WW/moc_appmenu_interface.cppGenerating MOC source EWIEGA46WW/moc_blur_interface.cppGenerating MOC source EWIEGA46WW/moc_buffer_interface.cppGenerating MOC source EWIEGA46WW/moc_clientconnection.cppGenerating MOC source EWIEGA46WW/moc_compositor_interface.cppGenerating MOC source EWIEGA46WW/moc_contrast_interface.cppGenerating MOC source EWIEGA46WW/moc_datadevice_interface.cppGenerating MOC source EWIEGA46WW/moc_datadevicemanager_interface.cppGenerating MOC source EWIEGA46WW/moc_dataoffer_interface.cppGenerating MOC source EWIEGA46WW/moc_datasource_interface.cppGenerating MOC source EWIEGA46WW/moc_display.cppGenerating MOC source EWIEGA46WW/moc_dpms_interface.cppGenerating MOC source EWIEGA46WW/moc_dpms_interface_p.cppGenerating MOC source EWIEGA46WW/moc_fakeinput_interface.cppGenerating MOC source EWIEGA46WW/moc_filtered_display.cppGenerating MOC source EWIEGA46WW/moc_global.cppGenerating MOC source EWIEGA46WW/moc_idle_interface.cppGenerating MOC source EWIEGA46WW/moc_idleinhibit_interface.cppGenerating MOC source EWIEGA46WW/moc_idleinhibit_interface_p.cppGenerating MOC source EWIEGA46WW/moc_keyboard_interface.cppGenerating MOC source EWIEGA46WW/moc_output_interface.cppGenerating MOC source EWIEGA46WW/moc_outputchangeset.cppGenerating MOC source EWIEGA46WW/moc_outputconfiguration_interface.cppGenerating MOC source EWIEGA46WW/moc_outputdevice_interface.cppGenerating MOC source EWIEGA46WW/moc_outputmanagement_interface.cppGenerating MOC source EWIEGA46WW/moc_plasmashell_interface.cppGenerating MOC source EWIEGA46WW/moc_plasmawindowmanagement_interface.cppGenerating MOC source EWIEGA46WW/moc_pointer_interface.cppGenerating MOC sour

D9631: [DBusMenuImporter] Send "opened" signal alongside about to show

[Kai Uwe Broulik]

broulik edited the summary of this revision.
broulik edited the test plan for this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9631

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma kwayland kf5-qt5 SUSEQt5.9 - Build # 77 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20SUSEQt5.9/77/
 Project:
Plasma kwayland kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 03 Jan 2018 11:07:57 +
 Build duration:
8 min 42 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 40 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: TestSuite.kwayland-testQtSurfaceExtensionFailed: TestSuite.kwayland-testWindowmanagement
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)91%
(221/243)91%
(221/243)85%
(23570/27784)52%
(11525/21956)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(39/39)100%
(39/39)99%
(10987/11068)50%
(7529/15011)autotests.server80%
(4/5)80%
(4/5)95%
(341/360)49%
(217/446)src.client99%
(68/69)99%
(68/69)85%
(5573/6534)66%
(1755/2674)src.server99%
(110/111)99%
(110/111)87%
(6669/7672)64%
(2024/3146)src.tools0%
(0/2)0%
(0/2)0%
(0/779)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1251)0%
(0/317)

KDE CI: Plasma kwayland kf5-qt5 FreeBSDQt5.9 - Build # 16 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20FreeBSDQt5.9/16/
 Project:
Plasma kwayland kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 03 Jan 2018 11:07:57 +
 Build duration:
8 min 43 sec and counting
   JUnit Tests
  Name: (root) Failed: 13 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 37 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testTextInputFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurface

D9631: [DBusMenuImporter] Send "opened" signal alongside about to show

[Kai Uwe Broulik]

broulik updated this revision to Diff 24657.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9631?vs=24649&id=24657

REVISION DETAIL
  https://phabricator.kde.org/D9631

AFFECTED FILES
  libdbusmenuqt/dbusmenuimporter.cpp

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9 - Build # 16 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20kwayland%20stable-kf5-qt5%20FreeBSDQt5.9/16/
 Project:
Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 03 Jan 2018 11:07:57 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 13 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 37 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testIdleFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurface

D9625: Require Qt 5.7

[Alexander Volkov]

volkov updated this revision to Diff 24659.
volkov added a comment.


  move to master
  Require Qt 5.7 -> Require Qt 5.9

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9625?vs=24637&id=24659

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9625

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/kfiledialog_unittest.cpp
  src/platformtheme/CMakeLists.txt
  src/platformtheme/kdeplatformfiledialoghelper.cpp
  src/platformtheme/kdeplatformfiledialoghelper.h
  src/platformtheme/kdeplatformtheme.cpp
  src/platformtheme/kdeplatformtheme.h
  src/platformtheme/qdbusmenubar_p.h
  src/platformtheme/x11integration.cpp
  tests/qfiledialogtest.cpp

To: volkov, #plasma
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9625: Require Qt 5.9

[Alexander Volkov]

volkov retitled this revision from "Require Qt 5.7" to "Require Qt 5.9".
volkov edited the summary of this revision.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9625

To: volkov, #plasma
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma kwayland stable-kf5-qt5 SUSEQt5.9 - Build # 20 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20kwayland%20stable-kf5-qt5%20SUSEQt5.9/20/
 Project:
Plasma kwayland stable-kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 03 Jan 2018 11:07:57 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 40 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: TestSuite.kwayland-testPlasmaWindowModelFailed: TestSuite.kwayland-testWaylandSurface
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)90%
(219/243)90%
(219/243)78%
(21631/27713)47%
(10403/21956)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client95%
(37/39)95%
(37/39)87%
(9644/11062)44%
(6654/15011)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client97%
(67/69)97%
(67/69)80%
(5170/6497)59%
(1578/2674)src.server99%
(110/111)99%
(110/111)85%
(6458/7642)62%
(1951/3146)src.tools0%
(0/2)0%
(0/2)0%
(0/779)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1251)0%
(0/317)

D9627: Reduce menu shadows to half the size of the window shadows

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Hi 
  thanks for the patch !
  
  ... see inline comment.
  Also note that to more or less match the different scales shown in your 
original screenshot, you would need a 0.25% scale (or even 0.20%) rather than 
0.5% 
  But I am also fine with the current choice.

INLINE COMMENTS

> breezeshadowhelper.cpp:512
>  // metrics
> -const int shadowSize = StyleConfigData::shadowSize()*12/16;
> +const int shadowSize = StyleConfigData::shadowSize()*8/16;
>  const int shadowOffset = qMax( shadowSize/2, 
> Metrics::Shadow_Overlap*2 );

There are in fact two places in this code where the shadow size is set. the 
same scale factor should be used at both places. Easiest is probably to make it 
a static variable like

static const qreal shadowSizeScale = 0.5; at the top of the file and use it in 
the two places where necessary.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, apol, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag created this revision.
zzag added reviewers: VDG, KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application edited projects, added Plasma; removed KWin.

REVISION SUMMARY
  Slide Desktops animates switching between virtual desktops. As the name
  suggests, this effect moves whole desktops during animation.

TEST PLAN
  - switch between virtual desktops
  - or, move a window to another virtual desktop

REPOSITORY
  R108 KWin

BRANCH
  effects/slidedesktops

REVISION DETAIL
  https://phabricator.kde.org/D9638

AFFECTED FILES
  autotests/test_builtin_effectloader.cpp
  autotests/test_plugin_effectloader.cpp
  autotests/test_scripted_effectloader.cpp
  effects/CMakeLists.txt
  effects/effect_builtins.cpp
  effects/effect_builtins.h
  effects/slidedesktops/CMakeLists.txt
  effects/slidedesktops/slidedesktops.cpp
  effects/slidedesktops/slidedesktops.h
  effects/slidedesktops/slidedesktops.kcfg
  effects/slidedesktops/slidedesktops_config.cpp
  effects/slidedesktops/slidedesktops_config.desktop
  effects/slidedesktops/slidedesktops_config.h
  effects/slidedesktops/slidedesktops_config.ui
  effects/slidedesktops/slidedesktopsconfig.kcfgc

To: zzag, #vdg, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Motivation behind this effect and demos will be soon.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  I've made this effect because I am very disappointed with the Slide effect. 
Let me list some of the biggest problems with slide effect:
  
  - It's not intuitive
  
  - It has poor(like my English) visual feedback when switching between empty 
virtual desktops
  
  F5615540: slide-empty-desktops.mp4 
  I've just cycled through 4 virtual desktops, surprise!
  
  - Switching between virtual desktops with fullscreen windows is not pleasant
  
  F5615542: slide-fullscreen.mp4 
  Panels should not flick, should they?
  *Please note that "panel flickering" is not a bug.*
  
  Meet the 'Slide Desktops' effect
  
  
  F5615545: slidedesktops-demo.mp4 
  
  Gorgeous!
  
  As you can see desktop background and panels ain't static anymore. They move 
together with virtual desktops, which is expected and intuitive. Also, you may 
have noticed gaps between virtual desktops. Their purpose is to make users feel 
like each virtual desktop is a separate entity. In addition to the purpose 
above, gaps are very useful when you have a plain color as the desktop 
background.
  
  If you don't like gaps, you can set them to 0.
  
  F5615546: options.png 
  
  Demos
  =
  
  Switching between empty virtual desktops:
  -
  
  F5615550: slidedesktops-empty-desktops.mp4 

  
  *Now we see that we're switching between virtual desktops.*
  
  Switching between virtual desktops with fullscreen windows:
  ---
  
  F5615551: slidedesktops-fullscreen.mp4 
  
  *Panels aren't flickering anymore!*
  
  Navigating a desktop grid:
  --
  
  F5615552: slidedesktops-grid.mp4 
  
  Move a window to another virtual desktop:
  -
  
  F5615553: slidedesktops-moving-window.mp4 

  
  Slide Desktops on Wayland:
  --
  
  F5615554: slidedesktops-wayland.mp4 
  
  Switch virtual desktops on a setup with several screens:
  
  
  F5615556: slidedesktops-several-screens.mp4 

  
  *I don't really know why you need virtual desktops in this case.*
  
  Next steps
  ==
  
  - Optimize it: Try to decrease a number of memory allocations during paint 
calls?
  - Simplify code?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Nathaniel Graham]

Restricted Application edited projects, added KWin; removed Plasma.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Diego Gangl]

Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Reduce menu shadows to half the size of the window shadows

[Nathaniel Graham]

ngraham updated this revision to Diff 24674.
ngraham added a comment.


  - Change scale factor in both places
  - Use a variable to score the scale factor
  - Default to 25% for the scale, to match the prior patch's screenshot (which 
people really liked, and VGD agreed to)

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9627?vs=24639&id=24674

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

AFFECTED FILES
  kstyle/breezeshadowhelper.cpp

To: ngraham, #vdg, #breeze, apol, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9641: [Digital Clock] Add tooltip for agenda items with too long description

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9641

To: broulik, #plasma, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9627: Reduce menu shadows to half the size of the window shadows

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, apol, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9627: Reduce menu shadows to half the size of the window shadows

[Nathaniel Graham]

ngraham marked an inline comment as done.
ngraham added a comment.


  Thanks for the advice, Hugo. Menu shadows now match the screenshot in the 
prior patch that people liked and that https://phabricator.kde.org/tag/vdg/ 
approved.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, apol, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Andres Betts]

abetts added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  This is great work. I like the results. I like the gap as well. It makes for 
a good idea of separation. What I would maybe want to add would be some sort of 
effect, darkening, or slight zooming in/out when moving a window from one 
desktop to another. Also, to make transitions even smoother, is there a way 
that Plasma can know the framerate that the computer is capable of?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart

D9641: [Digital Clock] Add tooltip for agenda items with too long description

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9641

To: broulik, #plasma, #vdg, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9643: Support submenus in context menu for systray icon

[Alexander Volkov]

volkov added reviewers: Plasma, graesslin.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9643

To: volkov, #plasma, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9643: Support submenus in context menu for systray icon

[Alexander Volkov]

volkov added a comment.


  BTW, why do we need to support KDEPlatformSystemTrayIcon? Why don't rely on 
QDBusTrayIcon?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9643

To: volkov, #plasma, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9627: Reduce menu shadows to half the size of the window shadows

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Ship it. Thanks !

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, apol, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9201: Slightly reduce vertical gutter width.

[Chris Holland]

Zren added a comment.


  I don't think I can attach a new diff to your differential, so here's a link 
to it:
  
  https://phabricator.kde.org/differential/diff/24677/?revisionID=9201
  
  Here's an example without the outlines. 1080p with 32px panel on bottom and 
IconSize=3 (1 smaller than default).
  
  F5615869: 2018-01-03___11-26-35.png 
  
  Here's an example with the default IconSize=4
  
  F5615878: 2018-01-03___11-53-32.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9201

To: hein, #plasma
Cc: abetts, Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D9627: Reduce menu shadows to half the size of the window shadows

[Nathaniel Graham]

ngraham edited reviewers, added: abetts; removed: apol.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9637: Add jump list action for "Updates"

[Nathaniel Graham]

ngraham added a comment.


  Ooh I love this.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D9637

To: broulik, #plasma, apol, #vdg
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Reduce menu shadows to half the size of the window shadows

[Andres Betts]

abetts accepted this revision.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9637: Add jump list action for "Updates"

[Andres Betts]

abetts accepted this revision.
abetts added a comment.
This revision is now accepted and ready to land.


  I like this, seems very intuitive, in a corner, less thinking in selecting 
the item.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D9637

To: broulik, #plasma, apol, #vdg, abetts
Cc: abetts, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D9643: Support submenus in context menu for systray icon

[David Edmundson]

davidedmundson added a comment.


  > Why don't rely on QDBusTrayIcon?
  
  It's internal to Qt.
  
  We could fork it like we did with the application menu, but then that's no 
easier than maintaining our current code.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9643

To: volkov, #plasma, graesslin
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9643: Support submenus in context menu for systray icon

[David Edmundson]

davidedmundson added a comment.


  Please fill in the "testing done"  field.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9643

To: volkov, #plasma, graesslin
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Reduce menu shadows to half the size of the window shadows

[Henrik Fehlauer]

rkflx added a comment.


  Thanks Nate, your blog readership seems to like it too (congratulations on 
the blog, BTW ;) What about the inevitable "But can I change it back?". You 
claim we allow this, but if you actually try it, it does not work, i.e. the 
menu shadow is now almost completely gone for the former default shadow size of 
16px. This is also the case for any user upgrading to 5.12 with a non-default 
size, e.g. 17px, where the shadow going away looks like an upgrade bug.
  
  I won't bother you further with this, but I'm a bit concerned and I think you 
should at least comment on the problem. Ideas for consideration:
  
  - Two comboboxes.
  - Lower bound or different scaling function (but difficult to get right).
  - Set of fixed values.
  
  IMO new defaults are fine, but removing the possibility to go back to (or at 
least somewhat replicate) the old (default) values is the worst (also from a PR 
standpoint).
  
  ---
  
  One more thing: Is the 100px max working for you? Mine is still capped at 
64px (the defaults button has the new value, weirdly), but perhaps I'm just 
installing things wrongly and there are some config caching quirks. Could you 
check again?
  
  (Also, the title of the Diff sounds off.)

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D9638#185547, @abetts wrote:
  
  > What I would maybe want to add would be some sort of effect, darkening, or 
slight zooming in/out when moving a window from one desktop to another.
  
  
  Well, I was trying to animate moving windows some time ago. It didn't work 
out well because `EffectsHandler` doesn't tell us when user has stopped moving 
a window. This leads to some inconsistencies:
  
  F5615875: 2018-01-03 18-43-56.mp4 
  
  //(I move windows between desktops with `Meta + Shift + `).//
  
  I hold `Meta + Shift` till the end of the video. It is expected that dolphin 
window be translucent till the end of the video, too.
  
  > Also, to make transitions even smoother, is there a way that Plasma can 
know the framerate that the computer is capable of?
  
  If you;re about choppy animations on videos above, don't worry, that's a 
screen recorder issue(+I have very old laptop).

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D6392: [Panel Config] Scrolling over size button increments size by 1 and shows current thickness

[Chris Holland]

Zren added inline comments.

INLINE COMMENTS

> broulik wrote in SizeHandle.qml:123
> I don't know exactly how `MouseEventListener` behaves but in `MouseArea` you 
> get a ton of `onWheel` events for touchpads (which scroll pixel-precisely), 
> potentially causing you to making your panel enormous accidentally

Recently got a Windows Vista era HP laptop running KDE.
I see, the touchpad "mousewheel" sends a ton of events with `wheel.delta` from 
±9 to ±60.

In my test, I actually noticed the opposite effect (it was slow to resize) 
since we do `Math.round(wheel.delta / 120)` which can turn into `Math.round(30 
/ 120) = 0`. So events with a `wheel.delta` smaller than 60 were ignored.

Anyways, I always wondered why plasma-pa did this in their mousewheel code:

https://github.com/KDE/plasma-pa/blob/master/applet/contents/ui/main.qml#L197-L210

Should be an easy fix. Just need to add a `wheelDelta` variable and ignore 
events when it's `wheelDelta <= -120 || 120 <= wheelDelta`.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6392

To: Zren, #plasma
Cc: davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9627: Reduce menu shadows to 25% of the window shadow size

[Nathaniel Graham]

ngraham retitled this revision from "Reduce menu shadows to half the size of 
the window shadows" to "Reduce menu shadows to 25% of the window shadow size".

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Reduce menu shadows to 25% of the window shadow size

[Nathaniel Graham]

ngraham added a comment.


  Those are valid concerns, and I will think on them! I always admire your 
thoroughness, @rkflx.
  
  That said, for upgrades, users who did not manually change the shadow size 
should get the new setting since they will not have a config file written out 
to override the defaults. You're right that users who did change the size 
manually to something similar to the old default will not have almost no menu 
shadows. Since small window shadows are a valid case, maybe I should put in a 
floor value for menu shadow size.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Reduce menu shadows to 25% of the window shadow size

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In https://phabricator.kde.org/D9627#185615, @ngraham wrote:
  
  > Those are valid concerns, and I will think on them! I always admire your 
thoroughness, @rkflx.
  >
  > That said, for upgrades, users who did not manually change the shadow size 
should get the new setting since they will not have a config file written out 
to override the defaults. You're right that users who did change the size 
manually to something similar to the old default will not have almost no menu 
shadows. Since small window shadows are a valid case, maybe I should put in a 
floor value for menu shadow size.
  
  
  ... but then you also need the same floor value for the window shadow size. 
You do not want menu shadows to be bigger than window shadows.
  In the end I think a finite set of hard coded shadow sizes (menu and window), 
controlled by a unique combobox, is what makes more sense. It hides unnecessary 
micromanagement to the user (honestly there is no need to allow user to change 
a shadow size from 31 to 32 pixels: the difference is not even visible to the 
eye); and gives the maximum flexibility to devs and designers to choose (and 
evolve) the "best" set of sizes that should accommodate most tastes.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Reduce menu shadows to 25% of the window shadow size

[Henrik Fehlauer]

rkflx added a comment.


  @hpereiradacosta +1
  
  Essentially this: https://phabricator.kde.org/D9549#184975 (but a "No" option 
could be added).

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Andres Betts]

abetts added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  In https://phabricator.kde.org/D9638#185606, @zzag wrote:
  
  > In https://phabricator.kde.org/D9638#185547, @abetts wrote:
  >
  > > What I would maybe want to add would be some sort of effect, darkening, 
or slight zooming in/out when moving a window from one desktop to another.
  >
  >
  > Well, I was trying to animate moving windows some time ago. It didn't work 
out well because `EffectsHandler` doesn't tell us when user has stopped moving 
a window. This leads to some inconsistencies:
  
  
  This is good to know. It doesn't look bad right now. Maybe the speed can also 
clue in the user of what's happening behind. That should be an easier method.
  
  > F5615875: 2018-01-03 18-43-56.mp4 
  > 
  > //(I move windows between desktops with `Meta + Shift + `).//
  > 
  > I hold `Meta + Shift` till the end of the video. It is expected that 
dolphin window be translucent till the end of the video.
  > 
  > At this moment, I would prefer not to animate moving windows.
  > 
  >> Also, to make transitions even smoother, is there a way that Plasma can 
know the framerate that the computer is capable of?
  > 
  > If you;re about choppy animations on videos above, don't worry, that's a 
screen recorder issue(+I have very old laptop).

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  > This is good to know. It doesn't look bad right now. Maybe the speed can 
also clue in the user of what's happening behind. That should be an easier 
method.
  
  So, what do you propose to do?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D9625: Require Qt 5.9

[Martin Flöser]

graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9625

To: volkov, #plasma, graesslin
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Reduce menu shadows to 25% of the window shadow size

[Nathaniel Graham]

ngraham added a comment.


  Excellent ideas, everyone. I'll see if I can work up something with a 
combobox. Also with that approach, I can fine-tune the menu shadows for each 
option to make sure they look good.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Overall code looks good for me and the video looks really promising. I fear 
it's too late for 5.12, which is a pity.

INLINE COMMENTS

> slidedesktops.cpp:144
> +QRegion clipRegion = buildClipRegion(currentPos, w, h);
> +QList visibleDesktops;
> +for (int i = 1; i <= effects->numberOfDesktops(); i++) {

Please use QVector for new code. See 
https://marcmutz.wordpress.com/effective-qt/containers/

> slidedesktops.cpp:160
> +m_paintCtx.fullscreenWindows.clear();
> +foreach (EffectWindow* w, effects->stackingOrder()) {
> +if (! w->isFullScreen()) {

Please don't use Q_FOREACH in new code. Prefer for (auto w : 
qAsConst(effects->stackingOrder()))

> slidedesktops.cpp:169
> +const int lastDesktop = visibleDesktops.last();
> +foreach (int desktop, visibleDesktops) {
> +m_paintCtx.desktop = desktop;

same here

> slidedesktops.cpp:213
> +if (w->isDock()) {
> +foreach (EffectWindow* fw, m_paintCtx.fullscreenWindows) {
> +if (fw->isOnDesktop(m_paintCtx.desktop)

and here

> slidedesktops.cpp:339
> +
> +foreach (EffectWindow* w, effects->stackingOrder()) {
> +w->setData(WindowForceBlurRole, QVariant(true));

and here

> slidedesktops.cpp:360
> +{
> +foreach (EffectWindow* w, effects->stackingOrder()) {
> +w->setData(WindowForceBlurRole, QVariant(false));

and here as well

> slidedesktops.h:60
> +
> +private Q_SLOTS:
> +void desktopChanged(int old, int current, EffectWindow* with);

As you use modern connect syntax you don't need the Q_SLOTS keyword anymore.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  Just putting it as an idea: maybe we should just drop the "old" slide desktop 
effect and replace it with this one?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D9618: Don't send keyboard events to QWindows which have outputOnly property set

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:f5f1f6ceb49d: Don't send keyboard events to QWindows 
which have outputOnly property set (authored by graesslin).
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9618?vs=24624&id=24692

REVISION DETAIL
  https://phabricator.kde.org/D9618

AFFECTED FILES
  input.cpp

To: graesslin, #kwin, #plasma, broulik
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9647: Ignore outputOnly QWindows for pointer and touch events

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application edited projects, added Plasma; removed KWin.

REVISION SUMMARY
  The idea is to be output only, so also ignore for pointer and touch.
  This is similar to the previous commit for keyboard events.
  
  BUG: 386954

REPOSITORY
  R108 KWin

BRANCH
  internal-window-pointer-ignore-output-only

REVISION DETAIL
  https://phabricator.kde.org/D9647

AFFECTED FILES
  input.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9647: Ignore outputOnly QWindows for pointer and touch events

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added KWin; removed Plasma.

REPOSITORY
  R108 KWin

BRANCH
  internal-window-pointer-ignore-output-only

REVISION DETAIL
  https://phabricator.kde.org/D9647

To: graesslin, #kwin, #plasma, broulik
Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Nathaniel Graham]

ngraham added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  In https://phabricator.kde.org/D9638#185720, @graesslin wrote:
  
  > Just putting it as an idea: maybe we should just drop the "old" slide 
desktop effect and replace it with this one?
  
  
  +1

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart

D9647: Ignore outputOnly QWindows for pointer and touch events

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:6ab625ed9770: Ignore outputOnly QWindows for pointer and 
touch events (authored by graesslin).
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9647?vs=24693&id=24695

REVISION DETAIL
  https://phabricator.kde.org/D9647

AFFECTED FILES
  input.cpp

To: graesslin, #kwin, #plasma, broulik
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9516: [libinput] Add support for switch devices and events

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  ping

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9516

To: graesslin, #kwin, #plasma
Cc: ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Plasma 5.12 LTS delayed

[Jonathan Riddell]

To allow for code which needed Frameworks 5.42 we have delayed Plasma
5.12 LTS release.  Beta is now on Monday 15 January.  Final tars are
made on Thu 2 Feb for a release on Tue 6th Feb.  Releases then
continue using a fibbonacchi squence of weeks intervals, 1, 1, 2, 3, 5
etc

Plasma 5.13 and onwards are unaffected.

Schedule is at
https://community.kde.org/Schedules/Plasma_5

Google calendar
https://calendar.google.com/calendar/embed?src=031gkgqg1hjf8lcmj0em1d2sj8%40group.calendar.google.com&ctz=Europe/London

Jonathan

D6004: Add method to unlock greeter via consolekit.

[Bart Ribbers]

PureTryOut added a comment.


  Could this be updated? Over at Alpine Linux and postmarketOS we'd love to use 
this patch as we don't have systemd (but do have consolekit2), but currently it 
fails to apply.
  
  Of course merging it upstream would be the best!

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D6004

To: tcberner, #freebsd, graesslin, #plasma
Cc: PureTryOut, erichameleers, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D6004: Add method to unlock greeter via consolekit.

[Tobias C . Berner]

tcberner added a comment.


  Sure. I kind of forgot about it. Sorry.
  
  You can find a more current version at 
  
https://github.com/freebsd/freebsd-ports-kde/tree/kde5.9-import/security/plasma5-kscreenlocker/files
  
  Note, the only needed thing is basically that ck skript. The rest is just 
adapting the error message.
  
  I will update it this weekend.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D6004

To: tcberner, #freebsd, graesslin, #plasma
Cc: PureTryOut, erichameleers, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9516: [libinput] Add support for switch devices and events

[Nathaniel Graham]

ngraham added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Building libinput from source 
 
isn't too hard, and maybe then you can test on your hardware?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9516

To: graesslin, #kwin, #plasma
Cc: ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D9625: Require Qt 5.9

[Alexander Volkov]

volkov closed this revision.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9625

To: volkov, #plasma, graesslin
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9627: Reduce menu shadows to 25% of the window shadow size

[Nathaniel Graham]

ngraham added a comment.


  I'm working on the combobox patch, but in my KDE Neon machine, I'm having 
trouble getting my changes applied when I open the Breeze settings in the 
Window Decoration KCM. I'm building to /usr and can verify that 
`/usr/lib/x86_64-linux-gnu/qt5/plugins/styles/breeze.so`, 
`/usr/lib/x86_64-linux-gnu/qt5/plugins/kstyle_breeze_config.so`, and 
`/usr/lib/x86_64-linux-gnu/qt5/plugins/org.kde.kdecoration2/breezedecoration.so`
 have gotten updated. I still don't see my changes when I open the Breeze 
options in the Window Decoration KCM. Any idea what I'm doing wrong?

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart