D9752: Add contextual actionbar

[Aditya Mehra]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R846:a4b518df223f: Add contextual actionbar (authored by Aiix).

REPOSITORY
  R846 Mycroft Plasma integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9752?vs=24979=24980

REVISION DETAIL
  https://phabricator.kde.org/D9752

AFFECTED FILES
  plasmoid/contents/ui/AskMessageType.qml
  plasmoid/contents/ui/SimpleMessageType.qml

To: Aiix, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9752: Add contextual actionbar

[Aditya Mehra]

Aiix created this revision.
Aiix added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Aiix requested review of this revision.

REVISION SUMMARY
  REF https://phabricator.kde.org/T7175 Add contextuall actionbar to results

REPOSITORY
  R846 Mycroft Plasma integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9752

AFFECTED FILES
  plasmoid/contents/ui/AskMessageType.qml
  plasmoid/contents/ui/SimpleMessageType.qml

To: Aiix, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9751: [weather] Add configuration option which weather services providers to use

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Drop-down menu looks like this (first item selected, hovering over second):
  F5631180: Screenshot_20180109_081008.png 

  
  Additional advantage of the menu: makes it more transparent what services 
providers are currrently supported. Their names are available in translated 
version since ever in the plugin desktop files, so everything prepared on their 
side.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D9751

To: kossebau, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9751: [weather] Add configuration option which weather services providers to use

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  When searching a weather station/location to select for the weather applet,
  so far the user had no chance to control which weather services providers
  are queried. Instead simply all are given the search string. Which can both
  result in unwanted hits due to regions covered, as well as some minimal
  privacy breach.
  
  This patch adds a dropdown menu to the search form where the user can
  control which services providers are used. The settings selected is stored
  in the config for the given applet instance.
  
  The setting defaults to an empty list, so the user has to opt-in to the use
  of any provider.
  
  Ideally the dropdown menu listing the providers with checkboxes would stay
  open after toggling a selection, but QtComponents Menu seems to not allow
  any modification of that behaviour. This is a small annoyance, but only once
  in a while.

REPOSITORY
  R114 Plasma Addons

BRANCH
  allowconfigureweatherproviderqueried

REVISION DETAIL
  https://phabricator.kde.org/D9751

AFFECTED FILES
  applets/weather/CMakeLists.txt
  applets/weather/package/contents/ui/configWeatherStation.qml
  applets/weather/plugin/locationlistmodel.cpp
  applets/weather/plugin/locationlistmodel.h
  applets/weather/plugin/plugin.cpp
  applets/weather/plugin/servicelistmodel.cpp
  applets/weather/plugin/servicelistmodel.h
  applets/weather/weatherapplet.cpp
  applets/weather/weatherapplet.h

To: kossebau, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9713: Add script to unlock a broken session via ConsoleKit.

[Tobias C . Berner]

tcberner added inline comments.

INLINE COMMENTS

> graesslin wrote in abstractlocker.cpp:53
> I think this needs to be runtime detected.

So something ala

- if logingd-runing then logindmessage
- if consolekit-running then consolekitmessage
- else falback message

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9713

To: tcberner, graesslin
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9713: Add script to unlock a broken session via ConsoleKit.

[Martin Flöser]

graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> abstractlocker.cpp:53
> +#if HAVE_CONSOLEKIT
> +auto text = ki18n("The screen locker is broken and unlocking is not 
> possible anymore.\n"
> +  "In order to unlock switch to a virtual terminal 
> (e.g. Ctrl+Alt+F2),\n"

I think this needs to be runtime detected.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9713

To: tcberner, graesslin
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9726: Change device "master volume" to be the max of all channels instead of the avg

[Chris Holland]

Zren added a comment.


  > one channel is 0%, second is 100% and merged volume now shows 100%
  
  If you lower the volume on a speaker, you care more about what the volume of 
the louder speaker is. It's weird if the OSD shows 50% when the right speaker 
is blaring at 100% and annoying my neighbours. You'd need to do mental math 
that the right speaker is +50% (or whatever it is).
  
  -
  
  Most OSes usually have a master channel slider, and a second slider for the 
left/right balance.
  
  1. KMix apperently used avg in the OSD I believe (I should probably install 
it and confirm). When the channels were split, it would have 2 sliders (and 
hide the "master") I think.
- Source
  - 
https://github.com/KDE/kmix/blob/29ff33adc9a714dad29351e3dbbc3d4f474d4364/gui/osdwidget.cpp#L107
  - 
https://github.com/KDE/kmix/blob/29ff33adc9a714dad29351e3dbbc3d4f474d4364/core/volume.cpp#L314
- KMix also had a feature request for turning it into a "Left <-> Right" 
channel balance slider. https://bugs.kde.org/show_bug.cgi?id=263105
  
  2. Windows 10 uses the max 
(https://www.youtube.com/watch?v=_9Zx4QMucx4#t=1m03)
- Window's Realtek driver controller uses a "Left <-> Right" channel 
balance slider (https://www.google.ca/search?q=realtek+audio=isch).
  3. Can't find an OS X example. I think it uses a "Left <-> Right" channel 
balance slider (https://www.youtube.com/watch?v=UZxhBio-_18), but you can also 
edit the individual sliders too I think somehow.
  4. Mate (Gnome 2?) uses master volume slider + a "Left <-> Right" channel 
balance slider. F5630840: 2018-01-08___20-33-19.png 

  5. Gnome 3 ?
  6. Unity?
  
  -
  
  Correct me if I'm wrong, but I believe a "Left <-> Right" channel balance 
slider means at least 1 channel is always at a 100% ratio of the master volume. 
Since the center means both speakers are at 100%.
  
  F5630834: 2018-01-08___19-29-09-edit.png 

  
  - `=O=` LeftRatio = 100% / RightRatio = 100%
  - `O==` LeftRatio = 100% / RightRatio = 0%
  - `==O` LeftRatio = 0% / RightRatio = 100%
  - `==O` LeftRatio = 50% / RightRatio = 100%
  - `O==` LeftRatio = 100% / RightRatio = 50%
  
  This means the "master volume" represents the "max" of all the channels.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D9726

To: Zren, #plasma
Cc: drosca, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 60 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/60/
 Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 09 Jan 2018 01:41:42 +
 Build duration:
3 min 31 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 16 test(s)

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 59 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/59/
 Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 09 Jan 2018 01:03:16 +
 Build duration:
6 min 30 sec and counting
   CONSOLE OUTPUT
  [...truncated 154.55 KB...][  7%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest.cpp.o[  7%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/PaginateModel.cpp.o[  8%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/__/libdiscover/tests/modeltest.cpp.o[  9%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest_autogen/mocs_compilation.cpp.o[ 10%] Linking CXX shared library libDiscoverNotifiers.so[ 10%] Built target DiscoverNotifiersScanning dependencies of target DummyNotifier_autogen[ 11%] Automatic MOC for target DummyNotifierGenerating MOC source EWIEGA46WW/moc_DummyNotifier.cppGenerating MOC compilation mocs_compilation.cpp[ 11%] Built target DummyNotifier_autogenScanning dependencies of target DiscoverNotifierDeclarativePlugin_autogen[ 12%] Automatic MOC for target DiscoverNotifierDeclarativePluginGenerating MOC source EWIEGA46WW/moc_DiscoverNotifier.cppGenerating MOC source EWIEGA46WW/moc_DiscoverNotifierDeclarativePlugin.cppGenerating MOC compilation mocs_compilation.cpp[ 12%] Built target DiscoverNotifierDeclarativePlugin_autogenScanning dependencies of target DummyNotifier[ 13%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier.cpp.oScanning dependencies of target DiscoverNotifierDeclarativePlugin[ 14%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/BackendNotifierFactory.cpp.o[ 15%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier_autogen/mocs_compilation.cpp.o[ 16%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifier.cpp.o[ 17%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin.cpp.o[ 18%] Linking CXX shared module DummyNotifier.so[ 18%] Built target DummyNotifier[ 19%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin_autogen/mocs_compilation.cpp.o[ 20%] Linking CXX executable PaginateModelTest[ 21%] Linking CXX shared library libDiscoverNotifierDeclarativePlugin.so[ 21%] Built target PaginateModelTestGenerating MOC source include/ResourcesUpdatesModel.mocGenerating MOC source EWIEGA46WW/moc_ActionsModel.cppGenerating MOC source EWIEGA46WW/moc_ApplicationAddonsModel.cppGenerating MOC source J25P4XD62P/moc_Category.cppGenerating MOC source J25P4XD62P/moc_CategoryModel.cppGenerating MOC source ZG42RGALUJ/moc_AbstractReviewsBackend.cppGenerating MOC source ZG42RGALUJ/moc_Rating.cppGenerating MOC source ZG42RGALUJ/moc_ReviewsModel.cppGenerating MOC source EWIEGA46WW/moc_ScreenshotsModel.cppGenerating MOC source 7I2KDZR7QS/moc_Transaction.cppGenerating MOC source 7I2KDZR7QS/moc_TransactionListener.cppGenerating MOC source 7I2KDZR7QS/moc_TransactionModel.cppGenerating MOC source YWJMSXEKIU/moc_UpdateModel.cppGenerating MOC source 3YJK5W5UP7/moc_AbstractBackendUpdater.cppGenerating MOC source 3YJK5W5UP7/moc_AbstractResource.cppGenerating MOC source 3YJK5W5UP7/moc_AbstractResourcesBackend.cppGenerating MOC source 3YJK5W5UP7/moc_AbstractSourcesBackend.cppGenerating MOC source 3YJK5W5UP7/moc_ResourcesModel.cppGenerating MOC source 3YJK5W5UP7/moc_ResourcesProxyModel.cppGenerating MOC source 3YJK5W5UP7/moc_ResourcesUpdatesModel.cppGenerating MOC source 3YJK5W5UP7/moc_SourcesModel.cppGenerating MOC source 3YJK5W5UP7/moc_StandardBackendUpdater.cppGenerating MOC source 3YJK5W5UP7/moc_StoredResultsStream.cppGenerating MOC compilation mocs_compilation.cpp[ 21%] Built target DiscoverCommon_autogenScanning dependencies of target DiscoverCommon[ 22%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/Category.cpp.o[ 23%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoryModel.cpp.o[ 24%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/AbstractReviewsBackend.cpp.o[ 26%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoriesReader.cpp.o[ 26%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Rating.cpp.o[ 26%] Built target DiscoverNotifierDeclarativePlugin[ 27%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Review.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/libdiscover/ReviewsBackend/Review.cpp:22:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/libdiscover/resources/ResourcesModel.h:29:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 

D9633: Add a private libPlasmaWeatherSolar for the ion data engines

[Friedrich W . H . Kossebau]

kossebau abandoned this revision.
kossebau added a comment.


  Discarding this one and instead went the route of async querying from the 
time dataengine...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9633

To: kossebau, #plasma, jriddell
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9033: man ioslave: asserts trying to display pam(8)

[Luigi Toscano]

ltoscano added a project: Documentation.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D9033

To: marten, #plasma
Cc: apol, plasma-devel, ZrenBot, skadinna, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D9746: openconnect: support MFA

[Andrea Scarpino]

scarpino created this revision.
scarpino added a reviewer: jgrulich.
Restricted Application added a project: Plasma.
scarpino requested review of this revision.

REVISION SUMMARY
  support MFA authentication in openconnect

TEST PLAN
  build and tested

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9746

AFFECTED FILES
  vpn/openconnect/nm-openconnect-service.h
  vpn/openconnect/openconnectprop.ui
  vpn/openconnect/openconnectwidget.cpp
  vpn/openconnect/openconnectwidget.h

To: scarpino, jgrulich
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D9627

To: ngraham, #vdg, #breeze, hpereiradacosta, abetts, rkflx
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9726: Change device "master volume" to be the max of all channels instead of the avg

[David Rosca]

drosca added a comment.


  Well, this was actually intended to work like that. In case of split 
channels, I would say "avg" describes the merged volume better than "max", 
because with "max" you can have situation where one channel is 0%, second is 
100% and merged volume now shows 100% which is wrong (is it?).

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D9726

To: Zren, #plasma
Cc: drosca, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9738: Support font/ttf and font/otf mimetypes in kfontinst

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in Misc.cpp:293
> So why not
> 
>   return CFontList::fontMimeTypes.contains(mime);
> 
> In other places too.

It's probably not linked together.

Anyway, this is just supposed to be a simple fix and not a refactor, stuff like 
this is all over the place here...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9738

To: fvogt, #plasma
Cc: anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9738: Support font/ttf and font/otf mimetypes in kfontinst

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> Misc.cpp:293
>  {
> -return "application/x-font-type1"==mime || 
> "application/x-font-ttf"==mime ||
> +return "font/otf"==mime || "font/ttf"==mime ||
> +   "application/x-font-type1"==mime || 
> "application/x-font-ttf"==mime ||

So why not

  return CFontList::fontMimeTypes.contains(mime);

In other places too.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9738

To: fvogt, #plasma
Cc: anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9738: Support font/ttf and font/otf mimetypes in kfontinst

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Plasma.
Restricted Application added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
  Those mimetypes are new and kfontinst/kfontview/fontthumbnail weren't aware
  of that.
  As the old types are aliases of the new types, it doesn't need to be added
  to the file dialog options (it would create duplicate entries).
  However, it broke thumbnail generation.

TEST PLAN
  .ttf files have thumbnails again.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9738

AFFECTED FILES
  kcms/kfontinst/apps/installfont.desktop
  kcms/kfontinst/apps/org.kde.kfontview.desktop
  kcms/kfontinst/kcmfontinst/FontList.cpp
  kcms/kfontinst/lib/Misc.cpp
  kcms/kfontinst/thumbnail/FontThumbnail.cpp
  kcms/kfontinst/thumbnail/fontthumbnail.desktop
  kcms/kfontinst/viewpart/FontViewPart.cpp

To: fvogt, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9735: [Notifications] Don't restart hide timer on reposition while dragging

[Kai Uwe Broulik]

broulik added a comment.


  > We're starting a drag; if the drag's blocking we won't be processing 
onYChanged?
  >  If it's not blocking..then what's the drag got to do with this?
  
  If I drop, then it tries to access the drag area or drag to get the data or 
emit signals and then it blows up because the popup is no longer there.
  
  > why wouldn't you want the popup to remain open for longer (timer.restart) 
whilst you're dragging?
  
  Because I do `timer.stop()` (lines 101ff) when I start dragging, I dont want 
it to ever go away while dragging.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9735

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9735: [Notifications] Don't restart hide timer on reposition while dragging

[David Edmundson]

davidedmundson added a comment.


  I don't understand how this relates to the bug.
  
  We're starting a drag; if the drag's blocking we won't be processing 
onYChanged?
  If it's not blocking..then what's the drag got to do with this?
  
  And as a behavioural change, why wouldn't you want the popup to remain open 
for longer (timer.restart) whilst you're dragging?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9735

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9521: Pass SwitchEvent from LibInput through KWin and add to DebugConsole

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added KWin; removed Plasma.

REPOSITORY
  R108 KWin

BRANCH
  switch-event

REVISION DETAIL
  https://phabricator.kde.org/D9521

To: graesslin, #kwin, #plasma, mart
Cc: ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D9735: [Notifications] Don't restart hide timer on reposition while dragging

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  We checked for dragging in `onContainsMouseChanged` but not here.
  
  BUG: 388684
  FIXED-IN: 5.12.0

TEST PLAN
  Emitted a notification, then saved a screenshot, started dragging, the top 
notification disappeared and mine stayed open. Before it would also close after 
a while and then crash.
  Still auto-hides if shown with no user interaction.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9735

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9732: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get()

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e2b7c395ecdb: Fix for xembedsniproxy crash due to NULL 
returned from xcb_image_get() (authored by maciejsitarz, committed by 
davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9732?vs=24944=24946

REVISION DETAIL
  https://phabricator.kde.org/D9732

AFFECTED FILES
  xembed-sni-proxy/sniproxy.cpp

To: maciejsitarz, #plasma, davidedmundson
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9732: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get()

[Maciej Sitarz]

maciejsitarz marked an inline comment as done.
maciejsitarz added a comment.


  @davidedmundson I don't have commit access
  (I'm not sure if you were asking me or @broulik)

INLINE COMMENTS

> broulik wrote in sniproxy.cpp:292
> Just do
> 
>   if (image) {
> 
> The indentation seems a little off, we use four spaces for indentation.

Fixed the 'if' and indentation in the newly uploaded diff

REVISION DETAIL
  https://phabricator.kde.org/D9732

To: maciejsitarz, #plasma, davidedmundson
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9732: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get()

[Maciej Sitarz]

maciejsitarz updated this revision to Diff 24944.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9732?vs=24940=24944

REVISION DETAIL
  https://phabricator.kde.org/D9732

AFFECTED FILES
  xembed-sni-proxy/sniproxy.cpp

To: maciejsitarz, #plasma, davidedmundson
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9733: Display exclusive actions correctly in systray menus

[Alexander Volkov]

volkov closed this revision.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9733

To: volkov, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9732: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get()

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Thanks.
  Do you have commit access.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9732

To: maciejsitarz, #plasma, davidedmundson
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9732: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get()

[Kai Uwe Broulik]

broulik added a comment.


  Thanks for your patch! I'll let David have a look at it who maintains 
xembedsniproxy.

INLINE COMMENTS

> sniproxy.cpp:292
> +QImage naiveConversion;
> + if (nullptr != image) {
> + naiveConversion = QImage(image->data, image->width, 
> image->height, QImage::Format_ARGB32);

Just do

  if (image) {

The indentation seems a little off, we use four spaces for indentation.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9732

To: maciejsitarz, #plasma, davidedmundson
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9732: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get()

[Kai Uwe Broulik]

broulik added reviewers: Plasma, davidedmundson.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9732

To: maciejsitarz, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9733: Display exclusive actions correctly in systray menus

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Feel free to commit your example into the tests folder.
  
  It's useful when people ineviatibly change stuff.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9733

To: volkov, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9733: Display exclusive actions correctly in systray menus

[Alexander Volkov]

volkov added a comment.


  Testing example: F5629785: tray-exclusive-actions.tar.xz 


REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9733

To: volkov, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9733: Display exclusive actions correctly in systray menus

[Alexander Volkov]

volkov added a reviewer: Plasma.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9733

To: volkov, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9732: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get()

[Maciej Sitarz]

maciejsitarz created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
maciejsitarz requested review of this revision.

REVISION SUMMARY
  In my environment (Fedora 27, plasma-workspace-5.11.4-1.fc27.x86_64) 
xembedsniproxy crashes.
  This is caused by NULL being returned by xcb_image_get().
  
  This should fix or at least mitigate the problems from bugs:
  https://bugs.kde.org/show_bug.cgi?id=355463
  https://bugs.kde.org/show_bug.cgi?id=359664
  https://bugzilla.redhat.com/show_bug.cgi?id=1497829

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9732

AFFECTED FILES
  xembed-sni-proxy/sniproxy.cpp

To: maciejsitarz
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9733: Display exclusive actions correctly in systray menus

[Alexander Volkov]

volkov created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
volkov requested review of this revision.

REVISION SUMMARY
  Add exclusive actions to their own action groups so that they
  could be diplayed as radio buttons by styles. It's only to
  display them correctly, the switching logic is done by Qt
  outside this plugin.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9733

AFFECTED FILES
  src/platformtheme/kdeplatformsystemtrayicon.cpp
  src/platformtheme/kdeplatformsystemtrayicon.h

To: volkov
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9033: man ioslave: asserts trying to display pam(8)

[Jonathan Marten]

marten added a comment.


  Ping anyone - is the updated diff enough for review?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D9033

To: marten, #plasma
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D7820: man ioslave: spurious numbers included in clang(1) man page

[Jonathan Marten]

marten added a comment.


  Ping - anyone able to review?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D7820

To: marten, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9684: Load config specified by the LnF theme

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R133:e36101cd1b48: Load config specified by the LnF theme 
(authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D9684?vs=24791=24938#toc

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9684?vs=24791=24938

REVISION DETAIL
  https://phabricator.kde.org/D9684

AFFECTED FILES
  greeter/CMakeLists.txt
  greeter/greeterapp.cpp
  greeter/greeterapp.h
  greeter/lnf_integration.cpp
  greeter/lnf_integration.h
  kcm/CMakeLists.txt
  kcm/config.qml
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/kcm.ui
  kcm/lnfconfig.qml
  kcm/resources.qrc
  kcm/wallpaperconfig.qml

To: davidedmundson, #plasma, broulik
Cc: zzag, broulik, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9677: Remove unused class SelectImageButton

[David Edmundson]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R133:d0db15779275: Remove unused class SelectImageButton 
(authored by davidedmundson).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9677?vs=24767=24937

REVISION DETAIL
  https://phabricator.kde.org/D9677

AFFECTED FILES
  kcm/CMakeLists.txt
  kcm/kcm.cpp
  kcm/selectimagebutton.cpp
  kcm/selectimagebutton.h

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9689: Add a per-process CPU usage graph shown in the process list

[Fabian Vogt]

fvogt updated this revision to Diff 24935.
fvogt added a comment.


  Rebase on current master. (Apparently my local master wasn't setup to follow 
origin...)

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9689?vs=24921=24935

BRANCH
  history

REVISION DETAIL
  https://phabricator.kde.org/D9689

AFFECTED FILES
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ProcessModel_p.h
  processui/ksysguardprocesslist.cpp
  tests/processtest.cpp
  tests/processtest.h

To: fvogt, #plasma
Cc: broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9684: Load config specified by the LnF theme

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> lnf_integration.cpp:62
> +
> +qDebug() << m_package.isValid() << xmlPath;
> +const KConfigGroup cfg = m_config->group("Greeter").group("LnF");

Maybe it should be deleted.

REPOSITORY
  R133 KScreenLocker

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9684

To: davidedmundson, #plasma, broulik
Cc: zzag, broulik, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

[Michael Heidelbach]

michaelh added a comment.


  Sorry, we were overlapping. I should have hit the update page link in the 
lower left.
  
  BTW: Mind to explain this "Restricted Application added a project:"  to 
me? Please.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D4614

To: broulik, #vdg, #plasma, aacid, dfaure
Cc: michaelh, ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D9643: Support submenus in context menu for systray icon

[Alexander Volkov]

volkov closed this revision.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9643

To: volkov, #plasma, graesslin, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9643: Support submenus in context menu for systray icon

[Alexander Volkov]

volkov added a comment.


  Thanks for the real-world example.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9643

To: volkov, #plasma, graesslin, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> michaelh wrote in baloofilepropertiesplugin.desktop:3
> That's was also my first thought. Not sure, but it might appear in dolphin 
> settings > services

Btw you can submit multiple comments at once, this way I don't get a gazillion 
emails each asking a single question :) Just hit "Submit" once you've added all 
your comments

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D4614

To: broulik, #vdg, #plasma, aacid, dfaure
Cc: michaelh, ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> broulik wrote in baloofilepropertiesplugin.desktop:3
> I don't think this icon is visible in the UI anywhere, certainly not in the 
> properties dialog

That's was also my first thought. Not sure, but it might appear in dolphin 
settings > services

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D4614

To: broulik, #vdg, #plasma, aacid, dfaure
Cc: michaelh, ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

[Kai Uwe Broulik]

broulik updated this revision to Diff 24934.
broulik added a comment.


  - Show also for directories

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4614?vs=24928=24934

REVISION DETAIL
  https://phabricator.kde.org/D4614

AFFECTED FILES
  src/CMakeLists.txt
  src/filepropertiesplugin/CMakeLists.txt
  src/filepropertiesplugin/baloofilepropertiesplugin.cpp
  src/filepropertiesplugin/baloofilepropertiesplugin.desktop
  src/filepropertiesplugin/baloofilepropertiesplugin.h

To: broulik, #vdg, #plasma, aacid, dfaure
Cc: michaelh, ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> michaelh wrote in baloofilepropertiesplugin.desktop:3
> The baloo icon has a magnifying glass in it which is associated with 
> searching.
> The tag-properties icon may be more appropriate.

I don't think this icon is visible in the UI anywhere, certainly not in the 
properties dialog

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D4614

To: broulik, #vdg, #plasma, aacid, dfaure
Cc: michaelh, ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> broulik wrote in baloofilepropertiesplugin.desktop:9
> The widget is primarily for showing additional file metadata (such as image 
> sizes), there's no such extra information for folders, so I chose not to show 
> it in this case.

I tag and comment some folders containing e.g. tv-series.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D4614

To: broulik, #vdg, #plasma, aacid, dfaure
Cc: michaelh, ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> baloofilepropertiesplugin.desktop:3
> +Type=Service
> +Icon=baloo
> +Name=File Meta Data Properties Page

The baloo icon has a magnifying glass in it which is associated with searching.
The tag-properties icon may be more appropriate.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D4614

To: broulik, #vdg, #plasma, aacid, dfaure
Cc: michaelh, ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> michaelh wrote in baloofilepropertiesplugin.desktop:9
> MimeType=inode/directory;application/octet-stream ?

The widget is primarily for showing additional file metadata (such as image 
sizes), there's no such extra information for folders, so I chose not to show 
it in this case.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D4614

To: broulik, #vdg, #plasma, aacid, dfaure
Cc: michaelh, ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> baloofilepropertiesplugin.desktop:9
> +X-KDE-ServiceTypes=KPropertiesDialog/Plugin
> +MimeType=application/octet-stream

MimeType=inode/directory;application/octet-stream ?

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D4614

To: broulik, #vdg, #plasma, aacid, dfaure
Cc: michaelh, ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Added 'Slide docks' option:
  
  F5629578: new-option.png 
  
  We need to disable sliding docks, for example, when using latte-dock.
  
  F5629577: slidedesktops-dont-slide-docks.mp4 


REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag updated this revision to Diff 24932.
zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  Updating https://phabricator.kde.org/D9638: [effects] add 'Slide Desktops' 
effect
  
  - Add 'Slide docks' option

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9638?vs=24699=24932

BRANCH
  effects/slidedesktops

REVISION DETAIL
  https://phabricator.kde.org/D9638

AFFECTED FILES
  autotests/test_builtin_effectloader.cpp
  autotests/test_plugin_effectloader.cpp
  autotests/test_scripted_effectloader.cpp
  effects/CMakeLists.txt
  effects/effect_builtins.cpp
  effects/effect_builtins.h
  effects/slidedesktops/CMakeLists.txt
  effects/slidedesktops/slidedesktops.cpp
  effects/slidedesktops/slidedesktops.h
  effects/slidedesktops/slidedesktops.kcfg
  effects/slidedesktops/slidedesktops_config.cpp
  effects/slidedesktops/slidedesktops_config.desktop
  effects/slidedesktops/slidedesktops_config.h
  effects/slidedesktops/slidedesktops_config.ui
  effects/slidedesktops/slidedesktopsconfig.kcfgc

To: zzag, #vdg, #kwin, #plasma
Cc: graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D9685: Add config for the lockscreen to toggle media controls

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7878c9988d10: Add config for the lockscreen to toggle 
media controls (authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D9685?vs=24790=24931#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9685?vs=24790=24931

REVISION DETAIL
  https://phabricator.kde.org/D9685

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/config.qml
  lookandfeel/contents/lockscreen/config.xml

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Minutes Monday Plasma Hangout

[Sebastian Kügler]

Minutes and log of today's meeting
-- 
sebas

http://www.kde.org | http://vizZzion.orgPlasma Team Meeting, 8 january 2018

Present: romangg, notmart, bshah, d__ed, kbroulik, Sho, sebas

romangg:
* there is a patch to be reviewed which needs to go in 5.12: 
https://phabricator.kde.org/D9352
* Diff 9352 "[libcolorcorrect] Send auto location updates only when desirable" 
[Needs Review] https://phabricator.kde.org/D9352

notmart:
not much this week, trying to get up to speed again
* some bug triaging
* my first stab at plasma releases, released Plasma 5.11.5
* started to take a look at where we are for auto detecting the tablet mode on 
laptops and how we can expose it from KWin to normal apps, libinput has an 
event dedicated to it now, but hardware support still very little

bshah:
- Finishing up article on plasma mobile for e.V. report
- In holidays I've worked on my hammerhead mainline port, got plasma working on 
mainline, want to blog about this : 
https://matrix.org/_matrix/media/v1/download/matrix.org/rbPNydJuJKxbPicNIyjYotJZ
- now putting this back on shelf
- Working on multimedia stuff for Nexus 5X, will package up gst-omx stuff in 
image
- ^ is taking long time because appearantly image creation itself is broken.. 
-.-
- Fixed a bug in neon openQA tooling : 
https://github.com/apachelogger/kde-os-autoinst/pull/3
questions? or next

d_ed:
big tasks in plasma: some time on making the kscreenlocker load configs from 
the relevant lnf package
so the KCM can have a "show media controls" option if and only if that 
screenlocker UI has it
in an extensible way
then some time writing a unit test for that blasted QtWayland crash 
wl_proxy_wrapper_blah_blah
which is +2d, but fails CI on /one/ of the linux builds... so I need to fix 
something in the test

kbroulik:
* Worked on making media controls on lock screen configurable. This wasn't done 
to see whether people will complain and indeed they do. Then David came up with 
a much better solution
* Looked into keeping fade effect from leaking user info, D9608, agreed, it's 
somewhat of a bodge patch but imho this must go in and then we can figure out a 
"proper" patch with black layer and what not later. Now someone must convince 
Martin of that...
Diff 9608 "[KScreen Effect] Fade opacity only for transparent windows" [Needs 
Review] https://phabricator.kde.org/D9608
* Did various fixes related to Firefox and global menu. Global menu now 
monitors window properties at runtime so it still works when an app announces 
global menu rather late (e.g. Firefox startup)
* Please have a look at D9640 - it's a real-world fix for a long-standing issue
Diff 9640 "[Folder View] Explicitly reject Firefox tab drops" [Needs Review] 
https://phabricator.kde.org/D9640
* Various fixes/bug triaging related to the Agenda in the calendar and other 
parts of Plasma

Sho:
* Investigated a bug that caused the icon at 0,0 to become hovered after a drag 
on the desktop. Qt patch after many hours of detective work: 
https://codereview.qt-project.org/#/c/215939/
* Fixed "Edit Applications..." action being shown for document items in Kicker 
menus, causing potential file loss when used.
* Fixed keyboard navigation not working without clicking into the popup window 
first with Folder View on the panel.
* I'm trying to get to grips with the remaining KAStats-based favorites 
problems in the Kicker backend to make them not suck for 5.12, which is pretty 
important and needs a new maintainer now that Ivan is gone/ has no time 
anymore. No results yet, though. Meh.
* Almost done with a second draft of the PlaMo featured article Bhushan and me 
are writing for the 2017 KDE e.V. report, based on Bhushan's first draft.

sebas:
* will try to get on top of kscreen bugs
* test and possibly merge patch in #379474
* help notmart out a bit with tablet mode things



The Log:

[12:01:37]  meeting?
[12:02:59]  yup
[12:03:03]  Who's here?
[12:03:09]  here
[12:03:10]  here
[12:03:17]  here
[12:03:27]  o/
[12:03:30] <-- gbs (~gbs@unaffiliated/gbs) has quit (Ping timeout: 246 seconds)
[12:03:31]  \o
[12:04:12]  romangg, notmart, bshah, d__ed, sebas plus whoever comes in 
still
[12:04:16]  romangg: your turn
[12:04:19]  shit I'm first
[12:04:31] -*- kbroulik
[12:04:35] -*- acheronuk lurks
[12:04:52]  there is a patch to be reviewed which needs to go in 5.12: 
https://phabricator.kde.org/D9352
[12:04:53]  Diff 9352 "[libcolorcorrect] Send auto location updates 
only when desirable" [Needs Review] https://phabricator.kde.org/D9352
[12:04:57]  d__ed: ?
[12:05:01]  just a small one
[12:05:23]  seems straightforward
[12:05:37]  otherwise working on pinebook kernel stuff and on my build 
tools: https://github.com/subdiff/fdbuild
[12:05:57]  you can already use it for wayland, X, libinput and Qt. :)
[12:06:13]  would be happy about some feedback.
[12:06:22]  otherwise next
[12:06:26]  cheers
[12:06:35]  notmart's turn
[12:07:40]  not much this week, trying to get up to speed again
[12:07:43]  * some bug triaging

D9685: Add config for the lockscreen to toggle media controls

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9685

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9684: Load config specified by the LnF theme

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R133 KScreenLocker

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9684

To: davidedmundson, #plasma, broulik
Cc: broulik, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

[Kai Uwe Broulik]

broulik updated this revision to Diff 24928.
broulik added a comment.


  - Rebase on master
  - Just use `MimeType=application/octet-stream`

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4614?vs=11528=24928

REVISION DETAIL
  https://phabricator.kde.org/D4614

AFFECTED FILES
  src/CMakeLists.txt
  src/filepropertiesplugin/CMakeLists.txt
  src/filepropertiesplugin/baloofilepropertiesplugin.cpp
  src/filepropertiesplugin/baloofilepropertiesplugin.desktop
  src/filepropertiesplugin/baloofilepropertiesplugin.h

To: broulik, #vdg, #plasma, aacid, dfaure
Cc: michaelh, ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D4614

To: broulik, #vdg, #plasma, aacid, dfaure
Cc: michaelh, ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D9352: [libcolorcorrect] Send auto location updates only when desirable

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9352

To: romangg, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9684: Load config specified by the LnF theme

[Kai Uwe Broulik]

broulik added a comment.


  I like that a lot.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9684

To: davidedmundson, #plasma
Cc: broulik, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: detecting tablet mode

[Marco Martin]

On Mon, Jan 8, 2018 at 11:06 AM, Sebastian Kügler  wrote:
>
> FWIW, I have two X1 Yoga laptops (gen1 and gen2) with recent kernels at my
> disposal  that I could probably test this feature on.

to see if it "just works", can you try to just put some dobug output in
connection.cpp around line 467 at the switch cases
case SwitchEvent::State::Off:
case SwitchEvent::State::On:

and then see if that output comes up when you flip the lid?
(you need libinput 1.9 for that)

--
Marco Martin

Re: detecting tablet mode

[Marco Martin]

On Fri, Jan 5, 2018 at 6:24 PM, Martin Flöser  wrote:
> Am 2018-01-05 16:11, schrieb Marco Martin:
>>
>> debugging a bit what happens currently on my machine, i don't seem to
>> have any event device which libinput_device_switch_has_switch,
>> however, when i flip it, i do get an event, but oddly from the event
>> device called
>> "intel virtual button driver" and i get a key event of id 240.
>> do you think it's a kernel problem and can'tbe made work on our level?
>> I can also try to do the patch blindly, but how to test not having the
>> proper hardware support? (on a running kwin, i know autotests have a
>> fake libinput that injects events)
>> I wonder on how many devices thoise events will actually work as
>> intended...
>
>
> From libinput documentation it seems to only be Lenovo Yoga currently. And
> you probably need a rather new kernel, maybe even unreleased ones. This is a
> pretty brand new feature in libinput and I don't think it's widely exposed.
>
> Best ask Peter Hutterer, he will also be able to help you get your device
> supported so that we have it for everyone. I expect this will be a great
> crowd effort which should be doable. If we have the infrastructure and easy
> way to test/debug, we should be able to get some users to help there.

is there also a mailinglist, either libinput or kernel related where
this things are being
discussed?

also, would it be possible with something like its autotests, to have
a tiny root app
that injects a fake event to have a good manual tests that can be ran
on a running sessions?
--
Marco Martin

Re: detecting tablet mode

[Sebastian Kügler]

On Friday, January 5, 2018 6:24:38 PM CET Martin Flöser wrote:
> Am 2018-01-05 16:11, schrieb Marco Martin:

> > debugging a bit what happens currently on my machine, i don't seem to
> > have any event device which libinput_device_switch_has_switch,
> > however, when i flip it, i do get an event, but oddly from the event
> > device called
> > "intel virtual button driver" and i get a key event of id 240.
> > do you think it's a kernel problem and can'tbe made work on our level?
> > I can also try to do the patch blindly, but how to test not having the
> > proper hardware support? (on a running kwin, i know autotests have a
> > fake libinput that injects events)
> > I wonder on how many devices thoise events will actually work as
> > intended...
> 
>  From libinput documentation it seems to only be Lenovo Yoga currently.
> And you probably need a rather new kernel, maybe even unreleased ones.
> This is a pretty brand new feature in libinput and I don't think it's
> widely exposed.
> 
> Best ask Peter Hutterer, he will also be able to help you get your
> device supported so that we have it for everyone. I expect this will be
> a great crowd effort which should be doable. If we have the
> infrastructure and easy way to test/debug, we should be able to get some
> users to help there.

FWIW, I have two X1 Yoga laptops (gen1 and gen2) with recent kernels at my 
disposal  that I could probably test this feature on.
-- 
sebas

http://www.kde.org | http://vizZzion.org

D9689: Add a per-process CPU usage graph shown in the process list

[Fabian Vogt]

fvogt retitled this revision from "[WIP] Add a per-process CPU usage graph 
shown in the process list" to "Add a per-process CPU usage graph shown in the 
process list".
fvogt edited the test plan for this revision.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D9689

To: fvogt, #plasma
Cc: broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9689: [WIP] Add a per-process CPU usage graph shown in the process list

[Fabian Vogt]

fvogt updated this revision to Diff 24921.
fvogt added a comment.


  Address review comments.
  
  Set a unified alpha for percentage marker and history graph to avoid sudden 
changes:
  33%: Percentage marker
  66%: History graph
  100%: Text
  
  Screenshot is linked in the test plan.

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9689?vs=24838=24921

BRANCH
  history

REVISION DETAIL
  https://phabricator.kde.org/D9689

AFFECTED FILES
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ProcessModel_p.h
  processui/ksysguardprocesslist.cpp
  tests/processtest.cpp
  tests/processtest.h

To: fvogt, #plasma
Cc: broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9678: Delay loading most used model

[David Edmundson]

davidedmundson requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D9678

To: broulik, #plasma, mart, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9225: Fix building autotest on platforms where syscalls are not available

[David Edmundson]

davidedmundson accepted this revision.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9225

To: bshah, #plasma, fvogt, graesslin, davidedmundson
Cc: davidk, graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9678: Delay loading most used model

[David Edmundson]

davidedmundson added a comment.


  It's not graphics.
  
  I had a working system settings, applied this got a crash
  
  
  
  #0  QQmlData::wasDeleted (object=0xfffefffe)
  
at 
../../include/QtQml/5.10.0/QtQml/private/../../../../../../../qt5/qtdeclarative/src/qml/qml/qqmldata_p.h:301
  
  #1  QV4::QObjectWrapper::wrap (engine=0x55b04a70, object=0xfffefffe)
  
at 
/run/media/david/15cbf614-32ad-44e8-9fdc-466f76304ed7/projects/qt5/qtdeclarative/src/qml/jsruntime/qv4qobjectwrapper_p.h:210
  
  #2  0x71e0a33c in loadProperty (v4=v4@entry=0x55b04a70, 
object=object@entry=0x55b259c0, property=...)
  
at 
/run/media/david/15cbf614-32ad-44e8-9fdc-466f76304ed7/projects/qt5/qtdeclarative/src/qml/jsruntime/qv4qobjectwrapper.cpp:130
  
  It's good, because we can now reproduce a Qt crash, but we shouldn't be 
putting it in. Sorry.
  
  Given it's a model, you should be able to do the important part of your 
change internally within MostUsedModel?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D9678

To: broulik, #plasma, mart
Cc: davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9651: [Icons KCM] Construct QUrl from local file

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:08c0a73303dc: [Icons KCM] Construct QUrl from local file 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9651?vs=24704=24920

REVISION DETAIL
  https://phabricator.kde.org/D9651

AFFECTED FILES
  kcms/icons/iconthemes.cpp

To: broulik, #plasma, fvogt, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9651: [Icons KCM] Construct QUrl from local file

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9651

To: broulik, #plasma, fvogt, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9661: [TabBox] Don't show "Show desktop" window when cycling through application windows

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:7ca8771d129f: [TabBox] Dont show Show 
desktop window when cycling through application… (authored by broulik).
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9661?vs=24753=24919

REVISION DETAIL
  https://phabricator.kde.org/D9661

AFFECTED FILES
  tabbox/clientmodel.cpp

To: broulik, #plasma, #vdg, graesslin
Cc: graesslin, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9689: [WIP] Add a per-process CPU usage graph shown in the process list

[Kai Uwe Broulik]

broulik added a comment.


  Screenshot? :)

INLINE COMMENTS

> ProcessModel.cpp:804
> + * didn't change though. */
> +if(mMapProcessCPUHistory.contains(process)) {
> +auto  = mMapProcessCPUHistory[process];

Use `find()` to avoid double lookup (contains+operator[])

> ProcessModel.cpp:808
> +// Only add an entry if the latest one is older than MIN_HIST_AGE
> +if(!history.size() || timestamp - history.constLast().timestamp 
> > MIN_HIST_AGE) {
> +if(history.size() == MAX_HIST_ENTRIES)

`isEmpty()`

> ProcessModel.cpp:809
> +if(!history.size() || timestamp - history.constLast().timestamp 
> > MIN_HIST_AGE) {
> +if(history.size() == MAX_HIST_ENTRIES)
> +history.removeFirst();

Braces also for one-line statements

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D9689

To: fvogt, #plasma
Cc: broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9678: Delay loading most used model

[Kai Uwe Broulik]

broulik added a comment.


  The crashes I was seeing were graphics hardware issues, shouldn't be caused 
by this patch.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D9678

To: broulik, #plasma, mart
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart