D9875: Extend parsing ssh prompt

[Pali Rohár]

pali added a comment.


  In D9875#250214 , @fvogt wrote:
  
  > too many unrelated changes in the diff
  
  
  Which are unrelated? I think all of them are needed. parsePrompt() was needed 
to be rewritten for support plain text inputs and yes/no questions.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9875

To: pali, fvogt
Cc: fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9875: Extend parsing ssh prompt

[Fabian Vogt]

fvogt added a comment.


  Use of `QStringLiteral` and `nullptr` in some cases, but maybe that's just 
phabricator doing git diff wrong.
  
  I'll try it out.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9875

To: pali, fvogt
Cc: fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12102: Port Language KCM to Qt Quick

[Alexander Potashev]

aspotashev added a comment.


  Looking at the screenshots, it's unclear which language do the up/down 
buttons belong to. Can we use drag'n'drop? Can we embed the buttons into the 
language row next to the language name?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart, hein

D12102: Port Language KCM to Qt Quick

[Alexander Potashev]

aspotashev added inline comments.

INLINE COMMENTS

> main.qml:59
> +
> +header: Kirigami.Heading { text: i18n("Add Languages") }
> +

Please add context:

  i18nc("@title:window", "Add Languages")

> main.qml:108
> +
> +text: i18n("Add")
> +

Please add context for translators:

  i18nc("@action:button", "Add")

> main.qml:145
> +
> +text: i18n("There are no languages available on this 
> system.")
> +

Please add context:

  i18nc("@info", "There are no languages available on this system.")

> main.qml:157
> +
> +text: (kcm.everSaved ? i18n("Your changes will take effect 
> the next time you log in.")
> +: i18n("There are currently no preferred languages 
> configured."))

Please add context "@info"

> main.qml:170
> +
> +text: i18ncp("%2 is the language code",
> +"The translation files for the language with the code 
> '%2' could not be found. The language will be removed from your 
> configuration. If you want to add it back, please install the localization 
> files for it and add the language again.",

Please add context "@info":

  i18ncp("@info %2 is the language code",

> main.qml:271
> +
> +text: i18n("Add languages...")
> +

Please add context "@action:button"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart, hein

D9875: Extend parsing ssh prompt

[Fabian Vogt]

fvogt added a comment.


  I gave it a quick test - works fine with ssh(-add). I didn't test anything 
else though.
  
  Code-wise it looks ok (as ok as the old code...), just a remark about the 
reference parameters.

INLINE COMMENTS

> main.cpp:44
>  // has no i18n, so this should work for all languages as long as the string 
> is unchanged.
> -static void parsePrompt(const QString &prompt, QString& keyFile, bool& 
> wrongPassphrase)
> +static void parsePrompt(const QString &prompt, QString& identifier, bool& 
> ignoreWallet, bool& clearText, bool& confirm)
>  {

I'd prefer an enum instead of two booleans.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9875

To: pali, fvogt
Cc: fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12359: Also read sddm.conf.d config directories

[Fabian Vogt]

fvogt updated this revision to Diff 32628.
fvogt added a comment.


  Improve the commit message.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12359?vs=32582&id=32628

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D12359

AFFECTED FILES
  src/CMakeLists.txt
  src/advanceconfig.cpp
  src/advanceconfig.h
  src/config.h.in
  src/sddmkcm.cpp
  src/sddmkcm.h
  src/themeconfig.cpp
  src/themeconfig.h

To: fvogt, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12359: Also read sddm.conf.d config directories

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R123:c879e4fa438f: Also read sddm.conf.d config directories 
(authored by fvogt).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12359?vs=32628&id=32629

REVISION DETAIL
  https://phabricator.kde.org/D12359

AFFECTED FILES
  src/CMakeLists.txt
  src/advanceconfig.cpp
  src/advanceconfig.h
  src/config.h.in
  src/sddmkcm.cpp
  src/sddmkcm.h
  src/themeconfig.cpp
  src/themeconfig.h

To: fvogt, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Plasma Sprint topics

[David Edmundson]

​Reminder, if you have topics add them now.

I've read everything there and made a very broad rough agenda that I've
stuck at the top of the notes page; it should be vague enough to encompass
everything whilst giving some structure.

David

D12373: Klipper: Remove first history item on clipboard clear

[Robert Hoffmann]

hoffmannrobert created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
hoffmannrobert requested review of this revision.

REVISION SUMMARY
  Password manager tools like Keepassx offer an option to clear
  the clipboard/selection after some time, e.g. 10 seconds,
  after the password was copied to the clipboard. This works fine,
  but unfortunately the password isn't removed from Klipper's
  history. This is a great security risk, which may make the use
  of password managers impossible.
  
  This patch offers an option to remove the top history item if
  Klipper::checkClipData was called, but actually there isn't any
  data. This is the case, if QClipboard::clear was called (by
  Keepassx), which does setMimeData(0, mode).

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12373

AFFECTED FILES
  klipper/generalconfig.ui
  klipper/klipper.cpp
  klipper/klipper.h
  klipper/klipper.kcfg

To: hoffmannrobert
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12373: Klipper: Remove first history item on clipboard clear

[David Edmundson]

davidedmundson added a comment.


  Aren't you just duplicating the existing  "prevent empty clipboard" option ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12373

To: hoffmannrobert
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12373: Klipper: Remove first history item on clipboard clear

[Robert Hoffmann]

hoffmannrobert added a comment.


  In D12373#250303 , @davidedmundson 
wrote:
  
  > Aren't you just duplicating the existing  "prevent empty clipboard" option ?
  
  
  No, the "prevent empty clipboard" option ensures that the clipboard doesn't 
stay empty, if it has been cleared, and sets it to the top history item. But it 
doesn't alter the history in any way.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12373

To: hoffmannrobert
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12373: Klipper: Remove first history item on clipboard clear

[David Edmundson]

davidedmundson added a comment.


  Right, but pressing control+v again won't paste the item after clearing which 
I assumed was the intended goal

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12373

To: hoffmannrobert
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12373: Klipper: Remove first history item on clipboard clear

[Robert Hoffmann]

hoffmannrobert added a comment.


  In D12373#250306 , @davidedmundson 
wrote:
  
  > Right, but pressing control+v again won't paste the item after clearing 
which I assumed was the intended goal
  
  
  Yes, pressing Control+V won't paste the item after clearing. But the problem 
is, that the cleared item stays readable in the clipboard history. Left-click 
on the clipboard icon in the system tray, and there still it is. That is the 
problem my patch solves by removing the item from history top.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12373

To: hoffmannrobert
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12375: [Power Management Engine] Fix kiosk restriction for lockscreen

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, sitter.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It is `action/lock_screen` according to documentation.
  
  BUG: 393331
  FIXED-IN: 5.12.5

TEST PLAN
  Put the following in kdeglobals
  
[KDE Action Restrictions][$i]
action/lock_screen=false
  
  Action was no longer displayed. Without this patch it would show but not work 
clearly indicating that this is the correct key to use.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12375

AFFECTED FILES
  dataengines/powermanagement/powermanagementengine.cpp

To: broulik, #plasma, sitter
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12376: [ContextMenu Containment Action] Fix checking for KIOSK

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, sitter.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Anyone else checks for `run_command`. Docs explicitly mention the fact that 
you have to also disable `action/run_command` for the menu entry to appear but 
this is a bit awkward, isn't it.
  Also fix `logout` to check for the correct place as listed in documentation 
and other code places.
  
  BUG: 393329
  FIXED-IN: 5.15.5

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12376

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp

To: broulik, #plasma, sitter
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12373: Klipper: Remove first history item on clipboard clear

[Kai Uwe Broulik]

broulik added a comment.


  Ideally, there was a mime data flag an application could set to indicate it 
wouldn't want it to end up in clipboard history but this is probably impossible 
to get applications to use..

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12373

To: hoffmannrobert
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12373: Klipper: Remove first history item on clipboard clear

[David Edmundson]

davidedmundson added a comment.


  We have two settings:
  The first, when the X selection owner gets cleared, replaces the clipboard 
with the top entry
  This one when the X selection owner gets cleared, deletes the top entry in 
the UI.
  
  Both default to on, which together makes no sense. We're replacing the 
clipboard and then immediately deleting that same entry.
  
  At a minimum it's a conflicting option that needs to be handled properly.
  
  Even then I'm not 100% convinced.
  
  If a client copies two pieces of sensitive data and then calls clear you've 
not solved anything.
  
  But more importantly if another X client clears the selection owner even if 
it doesn't own the previous data, you're just deleting random things. 
  Something we know happens a lot which is why we have that preventEmpty 
situation on by default.
  
  -
  
  Personally I think the smarter solution (though I understand it's harder to 
get it in) would be to have keepassx put some hint in the mimeData  
x-kde-clipboard-manager-skip-this: true   and then have klipper completely 
ignore the entry when it gets copied rather than trying to solve a problem 
after it's already happened.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12373

To: hoffmannrobert
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12373: Klipper: Remove first history item on clipboard clear

[Robert Hoffmann]

hoffmannrobert added a comment.


  You are right, the "prevent empty clipboard" option needs to be set to false 
to make the "RemoveTopHistoryItemOnClear" option work correctly.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12373

To: hoffmannrobert
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein updated this revision to Diff 32647.
hein added a comment.


  Add context to strings.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12102?vs=32597&id=32647

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12102

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/translations/CMakeLists.txt
  kcms/translations/Messages.sh
  kcms/translations/kcm_translations.desktop
  kcms/translations/kcmtranslations.cpp
  kcms/translations/kcmtranslations.h
  kcms/translations/kcmtranslationswidget.ui
  kcms/translations/package/contents/ui/main.qml
  kcms/translations/package/metadata.desktop
  kcms/translations/translations.cpp
  kcms/translations/translations.desktop
  kcms/translations/translations.h
  kcms/translations/translationsmodel.cpp
  kcms/translations/translationsmodel.h

To: hein, #kirigami, mart
Cc: aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  In D12102#250237 , @aspotashev 
wrote:
  
  > Looking at the screenshots, it's unclear which language do the up/down 
buttons belong to. Can we use drag'n'drop? Can we embed the buttons into the 
language row next to the language name?
  
  
  Here's an updated screenshot that reflects the latest changes in Kirigami 
upstream:
  
  F5815136: Screenshot_20180420_223245.png 

  
  On desktops SwipeListItem now shows the actions without the swipe thing on 
hover.
  
  I'd also probably prefer DND though.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart, hein

D12102: Port Language KCM to Qt Quick

[Nathaniel Graham]

ngraham added a comment.


  I'm not a huge fan of the fact that the list items take up the entire 
horizontal width and have no side borders. Makes things feel rather visually 
muddy, like things are too big and flowing into one another. Could we put that 
whole list inside a frame with a reasonable maximum width to give it some 
visual containment and structure, and have at least a bit of side padding 
between the edges of that frame and the edges of the KCM?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart, hein

D12102: Port Language KCM to Qt Quick

[Nathaniel Graham]

ngraham added a comment.


  And if this is a Kirigami convergence thing, IMHO we should think about 
having Kirigami automatically add a frame and some side padding when on desktop 
platforms, where having a list span the entire horizontal width rarely looks 
good.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart, hein

D12102: Port Language KCM to Qt Quick

[Andres Betts]

abetts added a comment.


  Could the list be enclosed by a white field?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart, hein

D12375: [Power Management Engine] Fix kiosk restriction for lockscreen

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  LGTM (with the limited knowledge I just acquired in the couple of minutes I 
dug through kauth ;))

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12375

To: broulik, #plasma, sitter
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12376: [ContextMenu Containment Action] Fix checking for KIOSK

[Harald Sitter]

sitter added a comment.


  The logout change seems fine.
  
  WRT run_command I wonder if it wouldn't be better to keep this backwards 
compatible `authorize(run_command) && authorizeAction(run_command)`. If a user 
previously restricted **only** `actions/run_command` that would, with the 
current diff, stop working.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12376

To: broulik, #plasma, sitter
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  I think we can do a white field.
  
  About the padding, I think it'd be cool if FormLayout could do this somehow. 
So it's automatic. (This code doesn't use FormLayout currently, though.) @mart?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  I'm actually having no luck with the white field thing currently. I tried 
setting `Kirigami.Theme.colorSet: Kirigami.Theme.View` on the ListView and then 
setting `backgroundColor: Kirigami.Theme.viewBackgroundColor` on the 
SwipeListItem delegate, which I would expect to generate a white view 
background, but it doesn't. I tried a couple of other variants too without any 
success.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart, hein

D12102: Port Language KCM to Qt Quick

[Nathaniel Graham]

ngraham added a comment.


  Perhaps I'm blind, but in the latest screenshot it looks like there's already 
a white background.
  
  If anything, what we need is for the general background to be light gray like 
all the other KCMs, and for the list itself to retain its current white 
background and have a simple frame around it to separate it from the gray 
background.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  There's no white bg in the latest screenshot, the entire thing is #fcfcfc 
(window bg color).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  Note btw that it's similarly broken for me in the new grid-based KCMs. We had 
the same discussion there where we want the grids to have the view background 
color behind them (white), but the grid in the Loon and Feel KCM for example is 
#fcfcfc for me.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  OK, the plot thickens. Turns out this is a color scheme problem.
  
  We have "Default" and "Breeze" color schemes. They used to be (and are 
supposed to be) identical. But right now, in my Colors KCM, switching between 
Default and Breeze produces different results.
  
  In "Breeze", the window background color is #eff0f1 and the view background 
color is #fcfcfc, so you get a noticable contrast.
  
  In "Default", they're both #fcfcfc.
  
  So the Kirigami colorSet stuff actually works fine. It's the "Default" color 
scheme making all the colors the same.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart, hein

D9875: Extend parsing ssh prompt

[Pali Rohár]

pali updated this revision to Diff 32651.
pali added a comment.


  I changed those two booleans into enum.

REPOSITORY
  R105 KDE SSH Password Dialog

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9875?vs=32615&id=32651

REVISION DETAIL
  https://phabricator.kde.org/D9875

AFFECTED FILES
  src/main.cpp

To: pali, fvogt
Cc: fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein updated this revision to Diff 32652.
hein added a comment.


  Set color set, add padding, wrap in ScrollView.
  
  This is all a bit hacky and mostly to get VDG feedback.
  
  Known problems:
  
  - When the lang list grows out of bounds you get double-scrollbars because I 
couldn't find a way to access the ScrollView background item frame width to 
size it by.
  - The padding is hard-coded.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12102?vs=32647&id=32652

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12102

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/translations/CMakeLists.txt
  kcms/translations/Messages.sh
  kcms/translations/kcm_translations.desktop
  kcms/translations/kcmtranslations.cpp
  kcms/translations/kcmtranslations.h
  kcms/translations/kcmtranslationswidget.ui
  kcms/translations/package/contents/ui/main.qml
  kcms/translations/package/metadata.desktop
  kcms/translations/translations.cpp
  kcms/translations/translations.desktop
  kcms/translations/translations.h
  kcms/translations/translationsmodel.cpp
  kcms/translations/translationsmodel.h

To: hein, #kirigami, mart
Cc: aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  Updated screenshot, this time using the "Breeze" color scheme which has some 
contrast between window bg and view bg colors:
  
  F5815250: Screenshot_20180421_010244.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart, hein

D12102: Port Language KCM to Qt Quick

[Henrik Fehlauer]

rkflx added a comment.


  Hm, I could imagine regular users will have a hard time selecting their 
preferred language. They'll see a list of languages, and look for some kind of 
checkbox to "select what they want". How should they realize that the top-most 
language will be used as the default, with the languages below as a fallback?
  
  This either needs some kind of visual indication, or at least a help text 
above. For reference, the language control panel in Windows has this text 
written above the list: "Add languages you want to use to this list. The 
language at the top of your list is your primary language (the one you want to 
see and use most often)."
  
  Also, having a Set as default action to move a language to the top in one go 
would be a bit more pleasant than being forced to use the endless loop of 
"click on Up button, button moves away, move mouse to target button again, 
click again…". Drag-reordering is also hard to discover for some type of users. 
Alternatively, move the Up button out of the list into a static position.
  
  Just my 2ct, no hard feelings if you'll choose to simply ignore me ;)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Andres Betts]

abetts added a comment.


  In D12102#250486 , @rkflx wrote:
  
  > Hm, I could imagine regular users will have a hard time selecting their 
preferred language. They'll see a list of languages, and look for some kind of 
checkbox to "select what they want". How should they realize that the top-most 
language will be used as the default, with the languages below as a fallback?
  >
  > This either needs some kind of visual indication, or at least a help text 
above. For reference, the language control panel in Windows has this text 
written above the list: "Add languages you want to use to this list. The 
language at the top of your list is your primary language (the one you want to 
see and use most often)."
  >
  > Also, having a Set as default action to move a language to the top in one 
go would be a bit more pleasant than being forced to use the endless loop of 
"click on Up button, button moves away, move mouse to target button again, 
click again…". Drag-reordering is also hard to discover for some type of users. 
Alternatively, move the Up button out of the list into a static position.
  >
  > Just my 2ct, no hard feelings if you'll choose to simply ignore me ;)
  
  
  The interaction will be a little bit different than that. Correct me anyone 
if I am wrong. The list of languages you see, are the ones selected. There is 
another window that has a list of languages to select from.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  I think @rkflx gets that, he's talking just about the first list. I agree 
with his comments. Some more design mockups to work from would be nice :).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Andres Betts]

abetts added a comment.


  I can make more

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  Currently we use the following inline messages to communicate stuff btw:
  
  - An info box shown when there's no languages available to add (i.e. not 
installed)
  - An info box shown no languages have been added (but some are available)
  - An error box when some added languages have gone missing (i.e. uninstalled) 
saying they'll be removed from the list on the next OK/Apply
  - A positive box after adding langs and doing OK/Apply informing the changes 
need a restart

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12137: Use consistent spacing and units for suffixes in spinboxes

[Albert Astals Cid]

aacid added a comment.


  yeah i think that's easier to understand

REPOSITORY
  R114 Plasma Addons

BRANCH
  fixsecondssuffix

REVISION DETAIL
  https://phabricator.kde.org/D12137

To: kossebau, #plasma, #localization, davidedmundson
Cc: aacid, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, skadinna, 
huftis, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9875: Extend parsing ssh prompt

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> main.cpp:330
> +// Item could not be retrieved from wallet. Open dialog
> +if (item.isEmpty()) {
> +if (type == TypeConfirm) {

Can you replace this if with

  if (!item.isEmpty()) {
  QTextStream(stdout) << item;
  return 0;
  }

That way there's one layer of indentation less on the following code.

> main.cpp:331
> +if (item.isEmpty()) {
> +if (type == TypeConfirm) {
> +if (KMessageBox::questionYesNo(0, dialog, i18n("Ksshaskpass")) 
> != KMessageBox::Yes) {

Please use `switch(type) { case TypeConfirm: { ...} ... }` instead of an 
if..else if..else chain.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9875

To: pali, fvogt
Cc: fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  Reviewers: as part of my task to redesign and tidy up this dialog box, I'm 
considering removing the Details button in the bottom left corner, along with 
the small pop-open panel that shows additional information. My argument is that 
the info in the Details panel is quite technical (PID's of calling process and 
polkit process) and - in some circumstances - lucid information about the 
program needing authorization. Most of the time, what's coming through is in 
raw form, such as `com.canonical.ubuntu.synaptic` (more or less) instead of 
`Synaptic Package Manager`.
  
  I know carving out UI elements can be controversial, so please give a few +/- 
1's so I know what others think. Maybe some people use it. I don't. But that's 
not a good enough reason to remove it.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Nathaniel Graham]

ngraham added a comment.


  In general it's okay to display nerdy technical information hidden away like 
this--as long as it's actually useful information! That's the real question. If 
it's of no real value to anyone for any use case that we can imaging, we can 
probably safely remove it. Otherwise, it should probably stay in.
  
  Personally I have no use for it, but let's collect more perspectives.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  Alrighty.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12171

To: aacid, #plasma, hein
Cc: fabianr, ngraham, davidedmundson, abetts, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12137: Use consistent spacing and units for suffixes in spinboxes

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:442cf697be51: Use consistent spacing and units for 
suffixes in spinboxes (authored by kossebau).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12137?vs=32427&id=32668

REVISION DETAIL
  https://phabricator.kde.org/D12137

AFFECTED FILES
  applets/comic/package/contents/ui/configAdvanced.qml
  applets/comic/package/contents/ui/configGeneral.qml
  applets/mediaframe/package/contents/ui/ConfigGeneral.qml
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml
  applets/weather/package/contents/ui/config/ConfigWeatherStation.qml

To: kossebau, #plasma, #localization, davidedmundson
Cc: aacid, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, skadinna, 
huftis, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Luigi Toscano]

ltoscano added a comment.


  Do you really want to remove the proper source of information in security 
dialog that asks you some additional credentials?
  Please keep it there.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: ltoscano, broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9875: Extend parsing ssh prompt

[Pali Rohár]

pali updated this revision to Diff 32670.

REPOSITORY
  R105 KDE SSH Password Dialog

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9875?vs=32651&id=32670

REVISION DETAIL
  https://phabricator.kde.org/D9875

AFFECTED FILES
  src/main.cpp

To: pali, fvogt
Cc: fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  If you really want to save some space (and probably make it easier for users 
to understand the dialog without getting lost), I think the whole
  
  > An application is attempting to perform an action that requires privileges.
  >  Authentication is required to perform this action.
  
  boilerplate can be removed. It is some lenghty, generic text, which does not 
add any useful information.
  
  If the Action in the Details tab is showing the raw id of the action, its the 
fault of the action definition, lacking a `` tag.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Andres Betts]

abetts added a comment.


  In D12311#250637 , @bruns wrote:
  
  > If you really want to save some space (and probably make it easier for 
users to understand the dialog without getting lost), I think the whole
  >
  > > An application is attempting to perform an action that requires 
privileges.
  > >  Authentication is required to perform this action.
  >
  > boilerplate can be removed. It is some lenghty, generic text, which does 
not add any useful information.
  >
  > If the Action in the Details tab is showing the raw id of the action, its 
the fault of the action definition, lacking a `` tag.
  
  
  What about something like:
  
  "Authentication is required to perform this action. Please enter your 
administrator password"
  
  And nothing else. No 3 lines but just one.
  
  ??

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  The "Authentication is required to ..." header line is directly sourced from 
the action definition below `/usr/share/polkit-1/actions/*`
  
  "Administrator password" is insufficient/wrong, as you can also (dependent on 
system configuration) authorize the actions as another priviledged user, see 
the screenshots.
  
  Password is redundant (label on the textfield), and wrong, as you can 
potentially use something like a fingerprint to authenticate.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  Btw, an easy way to trigger the dialog is e.g.
  
$> pkcheck -u -p $$ -a org.freedesktop.udisks2.eject-media-system
  
  $$ is the PID of the shell.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  The small-text boilerplate is definitely on the chopping block. @ltoscano 
makes a fine case for keeping the Details section.
  
  @bruns - Thanks for helping me find the source of the incoming messages. I 
hadn't gotten around to searching for them yet, but you saved me some work. 
Thanks!

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a subscriber: stikonas.
sharvey added a comment.


  Semi-related bug from @stikonas, while I'm on dialog duty: 
https://bugs.kde.org/show_bug.cgi?id=393355

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Nathaniel Graham]

ngraham added a comment.


  So right now, we have two strings of text:
  
  - The top bold string comes from the app and differs on a per-app basis
  - The bottom long boilerplate string is from us, and shown all the time
  
  I  like @abetts' idea: we should remove the app-specific text and make the 
always-shown boilerplate text short and to the point.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  Hmm, I was actually leaning the other way. Ditch the generic boilerplate and 
keep the app-specific text. I think it's helpful when the dialog tells you why 
it appeared and what app/function is requesting your password.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  No, thats completely off, as thats the action you are authorizing.
  
  > Authorization is required to format disk WDC WD10EZEX-08M2NA0
  
  I want it to show what it is asking permission for, and to be specific - does 
it want to format the USB stick I just inserted, or my home partition.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Luigi Toscano]

ltoscano added a comment.


  In D12311#250660 , @bruns wrote:
  
  > No, thats completely off, as thats the action you are authorizing.
  >
  > > Authorization is required to format disk WDC WD10EZEX-08M2NA0
  >
  > I want it to show what it is asking permission for, and to be specific - 
does it want to format the USB stick I just inserted, or my home partition.
  
  
  As long as you keep the detailed information available, that's fine. You can 
always end up having a non useful name for your USB stick...

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  Its not available otherwise ...

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Andrius Štikonas]

stikonas added a comment.


  In D12311#250660 , @bruns wrote:
  
  > No, thats completely off, as thats the action you are authorizing.
  >
  > > Authorization is required to format disk WDC WD10EZEX-08M2NA0
  >
  > I want it to show what it is asking permission for, and to be specific - 
does it want to format the USB stick I just inserted, or my home partition.
  
  
  Partition Manager wouldn't be able to show such specific text anyway (what is 
being formatted). It just starts a helper that can execute any command it asks. 
You can't make it work otherwise.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  Gnome-disks does, and so do other programs.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12102: Port Language KCM to Qt Quick

[Andres Betts]

abetts added a comment.


  Here are additional mockups for thought.F5815917: Screen Shot 2018-04-20 at 
10.54.07 PM.png 
  
  F5815920: AddLanguageAnimation.mov 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Andrius Štikonas]

stikonas added a comment.


  In D12311#250688 , @bruns wrote:
  
  > Gnome-disks does, and so do other programs.
  
  
  Gnome-disks uses UDisks to do everything and can't do anything on its own. So 
available features are very limited (not even resizing partitions).
  I suspect it is significantly less portable (e.g. to FreeBSD).
  That's why gnome-disks was written from scratch (with fewer features than 
gparted that it was supposedly replacing).

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12102: Port Language KCM to Qt Quick

[Henrik Fehlauer]

rkflx added a comment.


  In D12102#250725 , @abetts wrote:
  
  > Here are additional mockups for thought.F5815917: Screen Shot 2018-04-20 at 
10.54.07 PM.png 
  
  
  Quite nice (the helpful text label in particular, and how the default option 
is emphasized), but how will setting the fallback language work, e.g. how to 
switch English and Spanish around in your screenshot? In the previous iteration 
this was done by allowing to order the list (which IMO was fine, only needed 
some polishing).
  
  > F5815920: AddLanguageAnimation.mov 
  
  Hm, my browser is not able to play Apple's QuickTime video format (and even 
after downloading it does not want to play). Could you re-upload as a WebM 
maybe?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein