D12794: [weather applet] Improve name & comment metadata

[Nathaniel Graham]

ngraham added a comment.


  "Forecast and current conditions?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12794

To: kossebau, #plasma
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12794: [weather applet] Improve name & comment metadata

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Hoping for some native speaker with weather science background to provide 
proper naming here :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12794

To: kossebau, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12794: [weather applet] Improve name & comment metadata

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  The applet shows both observation and the forecast as reported for the
  selected station.

REPOSITORY
  R114 Plasma Addons

BRANCH
  fixweatherappletmetadata

REVISION DETAIL
  https://phabricator.kde.org/D12794

AFFECTED FILES
  applets/weather/package/metadata.desktop

To: kossebau, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 348529] Turn off screen after lock screen

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=348529

gade...@gmail.com changed:

   What|Removed |Added

 CC||gade...@gmail.com

--- Comment #15 from gade...@gmail.com ---
gnome-shell does this natively. In KDE, user is still forced to write a script
for this and attach it to lock screen even notification trigger.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 369520] FISH: directories are mistaken for files and vice-versa

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=369520

Nate Graham  changed:

   What|Removed |Added

  Component|default |FISH
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 361454] fish: No information on disk space

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=361454

Nate Graham  changed:

   What|Removed |Added

  Component|default |FISH
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 329687] previewing an HTML file from a local file system causes network retrievals while generating the thumbnail

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=329687

Nate Graham  changed:

   What|Removed |Added

  Component|default |Thumbnails and previews
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 366488] Too many sftp.so processes, not closing

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=366488

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
  Component|default |SFTP

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 354004] smb kioslave timeouts looking for kerberos authentication

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=354004

Nate Graham  changed:

   What|Removed |Added

  Component|default |Samba
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 348163] NFS configuration fails on absence of xdr_u_int64_t type

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=348163

Nate Graham  changed:

   What|Removed |Added

  Component|default |NFS
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 345440] SFTP: Internal Error on deleting a folder without having permissions and wich is also mounted

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=345440

Nate Graham  changed:

   What|Removed |Added

  Component|default |SFTP
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 375305] SFTP file create date is wrong

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=375305

Nate Graham  changed:

   What|Removed |Added

  Component|default |SFTP
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 370594] smb cannot create file with a :

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=370594

Nate Graham  changed:

   What|Removed |Added

  Component|default |Samba
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 380417] fish doesn't use User from .ssh/config

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=380417

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
   Severity|normal  |wishlist
  Component|default |FISH

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 378217] Use user defined in .ssh/config for fish

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=378217

Nate Graham  changed:

   What|Removed |Added

  Component|default |FISH
 CC||n...@kde.org
   Severity|normal  |wishlist

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 375826] Copying files to a remote SFTP folder opens a popup "Could not change permissions.."

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=375826

Nate Graham  changed:

   What|Removed |Added

  Component|default |SFTP
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 376301] sftp.so not closing connections when ProxyCommand is configured

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=376301

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
  Component|default |SFTP

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 363593] In dolphin-16.04.1-1.fc25.x86_64, Unknown error code 150 when copying from phone to computer

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=363593

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
  Component|default |MTP

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 368877] log_kio_sftp log flood

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=368877

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
  Component|default |SFTP

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 375732] Dolphin fails to sftp to Linux box when not a direct connection

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=375732

Nate Graham  changed:

   What|Removed |Added

  Component|default |SFTP
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 375249] "File not found" when trying to open file from nfs

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=375249

Nate Graham  changed:

   What|Removed |Added

  Component|default |NFS

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 362988] sftp connection win dolphin hangs/stops working after few seconds

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=362988

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
  Component|default |SFTP

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 375840] MTP connection crashes after few minutes on several phones

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=375840

Nate Graham  changed:

   What|Removed |Added

  Component|default |MTP

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 375552] Search in files does not show results when search string ends with parenthese

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=375552

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 349795] nfs kio produces "Internal error in server RPC error 3"

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=349795

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
  Component|default |NFS

-- 
You are receiving this mail because:
You are the assignee for the bug.

D12777: Fixed access to current slideshow image using correct field in action_open

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Can confirm both the issue and that this patch fixes it. Thanks! Any 
objections from other #plasma  folks?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12777

To: odeda, #plasma_workspaces, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12790: Use \n instead of for the extra part of the summary

[Fabian Vogt]

fvogt created this revision.
fvogt added reviewers: lukas, jgrulich.
fvogt requested review of this revision.

REVISION SUMMARY
  The tooltip text only supports plaintext, so it contained a literal "".
  A "\n" works as a newline in both the expanded representation and the tooltip.

TEST PLAN
  Hovered over the icon with available security updates. Now the text
  includes a newline instead of a literal "".

REPOSITORY
  R623 Plasma PackageKit Updater

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12790

AFFECTED FILES
  src/declarative/pkupdates.cpp

To: fvogt, lukas, jgrulich
Cc: plasma-devel

D6096: Add Wayland RemoteAccess capabilities to KRfb

[Oleg Chernovskiy]

Kanedias added a subscriber: jgrulich.
Kanedias added a comment.


  @jgrulich I started to hack together a very simple 
krfb-with-dbus-with-xdp-kde-with-pipewire... thingie.
  Now I'm curious, you have `handle` and `session_handle` paths everywhere in 
Screencast interface inside XDP-KDE source. Why? I can understand why 
`session_handle` is there - to create and track sessions of course, but what is 
`handle` used for?

REPOSITORY
  R437 Desktop Sharing

REVISION DETAIL
  https://phabricator.kde.org/D6096

To: Kanedias, davidedmundson, graesslin
Cc: jgrulich, alexeymin, plasma-devel, ragreen, Pitel, schernikov, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D12777: Fixed access to current slideshow image using correct field in action_open

[Nathaniel Graham]

ngraham added a comment.


  In D12777#260152 , @odeda wrote:
  
  > Thanks for the notes. I've followed the instructions in 
https://community.kde.org/Infrastructure/Github_Mirror , though I didn't follow 
the link to the Phabricator page you referred to - it might have been a good 
idea to stress the importance of reading that page a bit more :-)
  
  
  Thanks for the heads-up; I'll edit that page!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12777

To: odeda, #plasma_workspaces
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12777: Fixed access to current slideshow image using correct field in action_open

[Oded Arbel]

odeda added a comment.


  Thanks for the notes. I've followed the instructions in 
https://community.kde.org/Infrastructure/Github_Mirror , though I didn't follow 
the link to the Phabricator page you referred to - it might have been a good 
idea to stress the importance of reading that page a bit more :-)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12777

To: odeda, #plasma_workspaces
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12102: Port Language KCM to Qt Quick

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  on my side, code is all fine now

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D12102_1

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

[Scott Harvey]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:19712a1d22b2: Enlarge default window size. Use (adjusted) 
calculation in `SizeHint` to… (authored by sharvey).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12252?vs=33667=33892

REVISION DETAIL
  https://phabricator.kde.org/D12252

AFFECTED FILES
  app/SettingsBase.cpp

To: sharvey, ngraham, mart, davidedmundson, hein, #plasma
Cc: davidedmundson, cfeck, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 345618] Powerdevil crash from idle desktop.

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=345618

Christoph Feck  changed:

   What|Removed |Added

 CC||til...@arved.at

--- Comment #12 from Christoph Feck  ---
*** Bug 394037 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

D12777: Fix for KDE bug 394035

[Nathaniel Graham]

ngraham added a comment.


  Thanks for the patch! Please see 
https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch
  
  - Describe the change in the title
  - Mention the bug in the Summary section, like this: `BUG: 394035`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12777

To: odeda, #plasma_workspaces
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12698: WIP: Show SNI to install browser-side extension

[Eike Hein]

hein added a comment.


  There's some conceptual problems with this remaining:
  
  - The SNI doesn't disappear when the browser is closed.
  - When you click the SNI to open, it won't necessarily open in the browser it 
notified about if it's not also the default browser.
  - General issues with using more than one browser simultaneously.
  
  These are somewhat well fixable, I'll see about doing some more work on it 
this week.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D12698

To: hein, davidedmundson, apol, mart, #plasma
Cc: alexeymin, zzag, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12780: Avoid including the generated config-X11 private header

[Maximiliano Curia]

maximilianocuria closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12780

To: maximilianocuria, #plasma, mlaurent, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12781: Fix filetypestest

[Maximiliano Curia]

maximilianocuria created this revision.
maximilianocuria added reviewers: Plasma, kossebau.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
maximilianocuria requested review of this revision.

REVISION SUMMARY
  Concatenating strings results in paths like: ".qttestconfig" instead of
  the expected ".qttest/config". QMimeDatabase doesn't check the cache
  files on every call, but only if at least 5 seconds have passed.
  
  The failed tests can be seen here:
  
https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.10/lastCompletedBuild/testReport/(root)/TestSuite/filetypestest/
  and:
  
https://ci.debian.net/data/autopkgtest/unstable/amd64/k/kde-cli-tools/266696/log.gz

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  fix_tests (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12781

AFFECTED FILES
  keditfiletype/tests/filetypestest.cpp

To: maximilianocuria, #plasma, kossebau
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12780: Avoid including the generated config-X11 private header

[Maximiliano Curia]

maximilianocuria created this revision.
maximilianocuria added reviewers: Plasma, mlaurent.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
maximilianocuria requested review of this revision.

TEST PLAN
  building the installed headers no longer fails

REPOSITORY
  R120 Plasma Workspace

BRANCH
  priv_header_include (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12780

AFFECTED FILES
  libtaskmanager/virtualdesktopinfo.h

To: maximilianocuria, #plasma, mlaurent
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12698: WIP: Show SNI to install browser-side extension

[Eike Hein]

hein updated this revision to Diff 33877.
hein added a comment.


  Clean up `auto` usage

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12698?vs=33868=33877

BRANCH
  arcpatch-D12698

REVISION DETAIL
  https://phabricator.kde.org/D12698

AFFECTED FILES
  CMakeLists.txt
  reminder/CMakeLists.txt
  reminder/browserintegrationreminder.cpp
  reminder/browserintegrationreminder.desktop
  reminder/browserintegrationreminder.h

To: hein, davidedmundson, apol, mart, #plasma
Cc: alexeymin, zzag, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12698: WIP: Show SNI to install browser-side extension

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> browserintegrationreminder.cpp:138
> +QMenu *menu = new QMenu;
> +auto action = new QAction(i18n("Do not show again"));
> +menu->addAction(action);

`auto` usage is not consistent. Also, it would be better not to use `auto` to 
deduce raw pointer types, e.g. it would be much better as this

  auto *menu = new QMenu;
  auto *action = new QAction(i18n("Do not show again"));

https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Do-not-use-auto-to-deduce-a-raw-pointer

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D12698

To: hein, davidedmundson, apol, mart, #plasma
Cc: alexeymin, zzag, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Cursor sizes on wayland

[Aleix Pol]

On Tue, May 8, 2018 at 8:57 PM, Martin Flöser  wrote:
>
>
> Am 8. Mai 2018 17:05:57 MESZ schrieb Aleix Pol :
>>Hi,
>>I've been looking into getting a consistent cursor look on wayland,
>>which is specially daunting because of scaling.
>>
>>I'd like to look into fixing it for xwayland clients. Would somebody
>>be able to shed some light into the issue so I can understand it and
>>fix it?
>>
> Xwayland clients use the normal X11 API to set cursors. Xwayland just 
> forwards them through the Wayland protocol. The env variable for cursor size 
> is the same on Wayland and X11, so there should not be any difference.
>
> I'm not sure what exactly you want to look into. Personally I had the feeling 
> that apps started to act crazy concerning cursor sizes - on Wayland and on 
> X11. Normally there just should not be any difference. There's one env 
> variable controlling it and if all apps would just use it and not do crazy 
> stuff instead it would just work.

Well, setting the cursor size isn't any useful if you have two
monitors. I have it configured at resolution-dependent at the moment
and sometimes I lose my cursor on my high dpi screen.
If I use something bigger, when I move it to my external monitor I get
a monstrosity.

David mentioned at the sprint that we maybe should be correcting its
scale on the kwin size, if it's not being scaled yet.

Aleix

D12777: Fix for KDE bug 394035

[Oded Arbel]

odeda created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
odeda requested review of this revision.

REVISION SUMMARY
  With slideshow desktop wallpaper plugin, selecting "Open wallpaper Image" 
from RMB does nothing.
  
  https://bugs.kde.org/show_bug.cgi?id=394035
  
  I'm not really sure this is the right place to commit, but the code looks 
identical to 
/usr/share/plasma/wallpapers/org.kde.slideshow/contents/ui/main.qml on my KDE 
5.12.80 installation, so I'm assuming its related.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12777

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/main.qml

To: odeda
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12775: Always set applet title, even when label is disabled

[Eike Hein]

hein updated this revision to Diff 33871.
hein added a comment.


  Fix logic error.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12775?vs=33870=33871

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D12775

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderViewLayer.qml

To: hein, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12775: Always set applet title, even when label is disabled

[Eike Hein]

hein created this revision.
hein added a reviewer: Plasma.
Restricted Application added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  Except when we're a containment.
  
  This way Folder View applets always have a nice tab title in
  the grouping applet.
  
  BUG:394007

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D12775

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderViewLayer.qml

To: hein, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12698: WIP: Show SNI to install browser-side extension

[Eike Hein]

hein added a comment.


  The code simplification in the above changes also gets rid of the possible 
C++20 usage.
  
  Please re-review now.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D12698

To: hein, davidedmundson, apol, mart, #plasma
Cc: alexeymin, zzag, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12698: WIP: Show SNI to install browser-side extension

[Eike Hein]

hein updated this revision to Diff 33868.
hein added a comment.


  Add .desktop file names for Firefox Nightly and Google Chrome Beta.
  
  "Nightly" is the WM_CLASS used by Firefox Nightly. Its .desktop file
  should therefore be nightly.desktop, otherwise there are already
  integration seams.

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12698?vs=33867=33868

BRANCH
  arcpatch-D12698

REVISION DETAIL
  https://phabricator.kde.org/D12698

AFFECTED FILES
  CMakeLists.txt
  reminder/CMakeLists.txt
  reminder/browserintegrationreminder.cpp
  reminder/browserintegrationreminder.desktop
  reminder/browserintegrationreminder.h

To: hein, davidedmundson, apol, mart, #plasma
Cc: alexeymin, zzag, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12698: WIP: Show SNI to install browser-side extension

[Eike Hein]

hein updated this revision to Diff 33867.
hein added a comment.


  - Revise naming and make consistent
  - Fix copyrights
  - Don't use other people's branding
  - Simplify (BrowserInfo is gone)

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12698?vs=33632=33867

BRANCH
  arcpatch-D12698

REVISION DETAIL
  https://phabricator.kde.org/D12698

AFFECTED FILES
  CMakeLists.txt
  reminder/CMakeLists.txt
  reminder/browserintegrationreminder.cpp
  reminder/browserintegrationreminder.desktop
  reminder/browserintegrationreminder.h

To: hein, davidedmundson, apol, mart, #plasma
Cc: alexeymin, zzag, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12698: WIP: Show SNI to install browser-side extension

[Eike Hein]

hein added a comment.


  At the same time, I'm not sure using the browser icon straight in an SNI is 
appropriate either. Upstreams might not appreciate their branding being slapped 
onto something they didn't originate. I think we should use 
internet-web-browser here (the same icon that's used for the default browser 
KCM in System Settings).

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D12698

To: hein, davidedmundson, apol, mart, #plasma
Cc: alexeymin, zzag, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12698: WIP: Show SNI to install browser-side extension

[Eike Hein]

hein added a comment.


  I'm not a fan of the combined icon idea. On face of it it's a neat "go the 
extra mile" kind of thing, on the other hand it creates follow-up which I'm 
certain will not be done in a timely manner, or even forgotten about: Updating 
those assets whenever the upstream branding is revised. It means initially the 
visual is slightly nicer, but in the future it will look outdated and crap. 
It's not a good idea to bring this about for such a minor thing, I think it's 
better to keep it simple and agree with Vlad here.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D12698

To: hein, davidedmundson, apol, mart, #plasma
Cc: alexeymin, zzag, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12774: Fix submenus not updating when switching between categories of the same size

[Eike Hein]

hein created this revision.
hein added a reviewer: Plasma.
Restricted Application added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  This fixes a regression introduced in 38403268aad3 
, 
which forgot to
  handle the branch where the counts are the same.
  
  BUG:394013

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D12774

AFFECTED FILES
  applets/kicker/plugin/funnelmodel.cpp

To: hein, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12694: Properly fix the native messaging host file

[Bhushan Shah]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:e057dcd6afa9: Properly fix the native messaging host file 
(authored by bshah).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12694?vs=33611=33865

REVISION DETAIL
  https://phabricator.kde.org/D12694

AFFECTED FILES
  CMakeLists.txt

To: bshah, mwolff, broulik, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12694: Properly fix the native messaging host file

[Bhushan Shah]

bshah added a comment.


  In D12694#259291 , @mwolff wrote:
  
  > @bshah ping? will you push this?
  
  
  sorry, I was on sick leave, I'll push this, however for documentation you 
will have to wait for @davidedmundson or @broulik as they are the one who knows 
the code and features. :-)

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12694

To: bshah, mwolff, broulik, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart