D12835: Draw borders around side panels by default

[Nathaniel Graham]

ngraham added a subscriber: abetts.
ngraham added a comment.


  I wasn't around for the KDE4/oxygen days, so I wasn't aware this represented 
a reversion of anything; I just think this patch results in better visual 
design that the status quo.
  
  Breeze may be a minimalistic theme, but minimalism always rides a fine line. 
If you take away too much, you can reduce clarity, or muddy the boundaries 
between things that are different and separate. The status quo here has never 
sat well with me: the side panel feels like it isn't sure what it wants to be. 
Is its content a part of the main window, or separate? It feels like neither. 
And what's with that blue line that doesn't extend all the way to the top of 
the bottom? The design feels like an unhappy compromise, not something that's 
bold and proud (apologies for all the subjective touchy-feely language; this is 
just how it feels to me). At least with this patch there's a clear and 
confident visual separation of the category list and the content area, and now 
I realize that's what I'm looking for.
  
  As an alternative, perhaps we should instead move towards making the side 
panels (and dockable panels) look more like System Settings' sidebar: a white 
background, but without a distinct frame, and  a one-pixel line separating it 
from the content area that extends the full height of the window. This would 
Breezey and modern, and much better than either IMHO. We might even be able to 
remove the setting entirely...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D12835

To: ngraham
Cc: abetts, rkflx, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D12837: Split replaceAccount from addAccountToCache

[Valeriy Malov]

valeriymalov created this revision.
valeriymalov added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
valeriymalov requested review of this revision.

REVISION SUMMARY
  We were accidentally overwriting first account in the model with
  currently logged in user after polling AccountsService
  
  BUG: 336994

TEST PLAN
  check if kcmshell5 user_manager lists mutliple users on cold boot

REPOSITORY
  R128 User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12837

AFFECTED FILES
  src/lib/accountmodel.cpp
  src/lib/accountmodel.h

To: valeriymalov, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12835: Draw borders around side panels by default

[Henrik Fehlauer]

rkflx added a comment.


  Is it really necessary to revert design decisions made for Breeze (compared 
to its predecessor Oxygen)? FWIW, I find the "after" screenshots look quite 
dated, and I cannot see any functional or visual improvement.
  
  In addition, I find the overall design direction quite confusing. On the one 
hand, we remove borders (group boxes, places panel in the file dialog), and on 
the other hand you want to reintroduce the old rectangle-heavy design (side 
panel).
  
  IMO we should respect those design decisions taken for Breeze, and not 
constantly change things around.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D12835

To: ngraham
Cc: rkflx, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12835: Draw borders around side panels by default

[Christoph Feck]

cfeck added a comment.


  While I also use this setting, we probably should not make it default, unless 
the QtQuick dialogs (try desktop RMB > Configure Desktop ...) also respects 
this setting.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D12835

To: ngraham
Cc: cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  In D12102#261174 , @mart wrote:
  
  > if i select more than one language, only one will be added, the others will 
be added as "unknown"
  
  
  I can't reproduce this, but will have a look.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12835: Draw borders around side panels by default

[Nathaniel Graham]

ngraham created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch changes the defaults to draw borders around side panels in 
settings windows.
  
  Drawing the full border makes the window feel less muddy and imparts clarity 
by visually separating the navigation panel from the content. I think it's a 
pretty clear visual improvement.

TEST PLAN
  Log in with a new user account and check out various KDE apps settings 
windows:
  
  Breeze Light
  
  
  Dolphin settings window, before:
  
  Dolphin settings window, after:
  
  Gwenview settings window, before:
  
  Gwenview settings window, after:
  
  Kate settings window, before:
  
  Kate settings window, after:
  
  Okular settings window, before:
  
  Okular settings window, after:
  
  Spectacle settings window, before:
  
  Spectacle settings window, after:
  
  Breeze Dark
  ---
  
  Dolphin settings window, before:
  
  Dolphin settings window, after:
  
  Gwenview settings window, before:
  
  Gwenview settings window, after:
  
  Kate settings window, before:
  
  Kate settings window, after:
  
  Okular settings window, before:
  
  Okular settings window, after:
  
  Spectacle settings window, before:
  
  Spectacle settings window, after:

REPOSITORY
  R31 Breeze

BRANCH
  borders-around-settings-window-side-panels (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12835

AFFECTED FILES
  kstyle/breeze.kcfg

To: ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

[Martin Kostolný]

martinkostolny added a comment.


  Hello after some time. I finally manage to more or less finish the layout 
rework I was planning. I tried to work in most of what we discussed here.
  
  @Pitel Radek, if You have some time, can You please check out `layout-rework` 
branch and try if You manage to set up your desired configuration? And of 
course if you see any issues, please let me know of them and I'll do my best to 
fix them.
  
  In Layout configuration section there is also a facility to upload/download 
custom configuration JSON to ease up config exchanges between users (and devs 
for bug-reports:) ). Known issue/feature of this facility is that the JSON does 
not cover all possible config properties. Just the ones related to layout 
(although some of the supported properties are from config sections different 
from layout section).
  
  I'm also open to tuning up existing hard-coded config profiles, and adding 
new if it makes sense.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11071

To: Pitel, #plasma, martinkostolny
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D12823: Workaround for binding loop in Material Theme

[Aleix Pol Gonzalez]

apol added a comment.


  I've seen this warning, never seen it crash.
  
  This looks like a workaround though. Do you know why it's happening? Why's 
theme.Material.accent changing?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12823

To: Dax
Cc: apol, plasma-devel, davidedmundson, mart, hein

D12822: Added null check in OverlayDrawer

[Aleix Pol Gonzalez]

apol added a comment.


  Already done in https://phabricator.kde.org/D12741.
  
  Or I'm missing something?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12822

To: Dax
Cc: apol, plasma-devel, davidedmundson, mart, hein