KDE CI: Plasma kwin stable-kf5-qt5 SUSEQt5.10 - Build # 8 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kwin%20stable-kf5-qt5%20SUSEQt5.10/8/
 Project:
Plasma kwin stable-kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 19 May 2018 06:07:45 +
 Build duration:
31 min and counting
   CONSOLE OUTPUT
  [...truncated 917.11 KB...][ 61%] Automatic MOC for target KWinWaylandVirtualBackend[ 61%] Built target KWinWaylandVirtualBackend_autogenScanning dependencies of target KWinWaylandWaylandBackend_autogen[ 61%] Automatic MOC for target KWinWaylandWaylandBackend[ 61%] Built target KWinWaylandWaylandBackend_autogenScanning dependencies of target eglx11common_autogen[ 61%] Automatic MOC for target eglx11common[ 61%] Built target eglx11common_autogenScanning dependencies of target KWinSceneOpenGL_autogen[ 61%] Automatic MOC for target KWinSceneOpenGL[ 61%] Built target KWinSceneOpenGL_autogenScanning dependencies of target KWinSceneQPainter_autogen[ 61%] Automatic MOC for target KWinSceneQPainter[ 61%] Built target KWinSceneQPainter_autogenScanning dependencies of target KWinSceneXRender_autogen[ 61%] Automatic MOC for target KWinSceneXRender[ 61%] Built target KWinSceneXRender_autogenScanning dependencies of target testX11TimestampUpdate_autogen[ 61%] Automatic MOC for target testX11TimestampUpdate[ 61%] Built target testX11TimestampUpdate_autogenScanning dependencies of target KWinIntegrationTestFramework_autogen[ 61%] Automatic MOC for target KWinIntegrationTestFramework[ 61%] Built target KWinIntegrationTestFramework_autogenScanning dependencies of target KF5GlobalAccelPrivateKWin[ 61%] Building CXX object plugins/kglobalaccel/CMakeFiles/KF5GlobalAccelPrivateKWin.dir/kglobalaccel_plugin.cpp.o[ 61%] Building CXX object plugins/kglobalaccel/CMakeFiles/KF5GlobalAccelPrivateKWin.dir/KF5GlobalAccelPrivateKWin_autogen/mocs_compilation.cpp.o[ 61%] Linking CXX shared module ../../bin/org.kde.kglobalaccel5.platforms/KF5GlobalAccelPrivateKWin.so[ 61%] Built target KF5GlobalAccelPrivateKWinScanning dependencies of target KWinQpaPlugin[ 61%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/abstractplatformcontext.cpp.o[ 61%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/backingstore.cpp.o[ 62%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/integration.cpp.o[ 62%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/main.cpp.o[ 62%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/nativeinterface.cpp.o[ 62%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/platformcontextwayland.cpp.o[ 62%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/platformcursor.cpp.o[ 62%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/screen.cpp.o[ 62%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/sharingplatformcontext.cpp.o[ 62%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/window.cpp.o[ 62%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/logging.cpp.o[ 62%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/KWinQpaPlugin_autogen/mocs_compilation.cpp.o[ 62%] Linking CXX shared module ../../bin/KWinQpaPlugin.so[ 62%] Built target KWinQpaPluginScanning dependencies of target KF5IdleTimeKWinWaylandPrivatePlugin[ 62%] Building CXX object plugins/idletime/CMakeFiles/KF5IdleTimeKWinWaylandPrivatePlugin.dir/poller.cpp.o[ 62%] Building CXX object plugins/idletime/CMakeFiles/KF5IdleTimeKWinWaylandPrivatePlugin.dir/KF5IdleTimeKWinWaylandPrivatePlugin_autogen/mocs_compilation.cpp.o[ 62%] Linking CXX shared module ../../bin/KF5IdleTimeKWinWaylandPrivatePlugin.so[ 62%] Built target KF5IdleTimeKWinWaylandPrivatePluginScanning dependencies of target KWinWaylandDrmBackend[ 62%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_backend.cpp.o[ 62%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_object.cpp.o[ 62%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_object_connector.cpp.o[ 62%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_object_crtc.cpp.o[ 62%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_object_plane.cpp.o[ 62%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_output.cpp.o[ 63%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_buffer.cpp.o[ 63%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_inputeventfilter.cpp.o[ 63%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/logging.cpp.o[ 63%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/scene_qpainter_drm_backend.cpp.o[ 63%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/screens_drm.cpp.o[ 63%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/egl_gbm_backend.cpp

Re: KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

[Ben Cooksley]

Hi all,

If someone could please check if this is correct, and whether Plasma Vault
is intended to be built outside of Linux systems?

Regards,
Ben


On Sat, May 19, 2018 at 9:30 AM, CI System  wrote:

> *BUILD FAILURE*
> Build URL https://build.kde.org/job/Plasma%20plasma-vault%
> 20stable-kf5-qt5%20FreeBSDQt5.10/4/
> Project: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10
> Date of build: Fri, 18 May 2018 21:29:55 +
> Build duration: 1 min 4 sec and counting
> * CONSOLE OUTPUT *
> [...truncated 64.88 KB...]
> JAVA_HOME = '/usr/local/openjdk8-jre'
> BUILD_ID = '4'
> PAGER = 'more'
> RUN_CHANGES_DISPLAY_URL = 'https://build.kde.org/job/
> Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.
> 10/4/display/redirect?page=changes'
> PKG_CONFIG_PATH = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/
> libdata/pkgconfig:/usr/local/libdata/pkgconfig'
> RUN_DISPLAY_URL = 'https://build.kde.org/job/Plasma%20plasma-vault%
> 20stable-kf5-qt5%20FreeBSDQt5.10/4/display/redirect'
> BLOCKSIZE = 'K'
> BUILD_URL = 'https://build.kde.org/job/Plasma%20plasma-vault%
> 20stable-kf5-qt5%20FreeBSDQt5.10/4/'
> LD_LIBRARY_PATH = '/usr/home/jenkins/install-prefix/lib'
> JOB_NAME = 'Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10'
> TERM = 'su'
> SHLVL = '1'
> JOB_BASE_NAME = 'Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10'
> HOME = '/usr/home/jenkins/'
> CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'
> PWD = '/usr/home/jenkins/workspace/Plasma plasma-vault stable-kf5-qt5
> FreeBSDQt5.10'
> JOB_DISPLAY_URL = 'https://build.kde.org/job/Plasma%20plasma-vault%
> 20stable-kf5-qt5%20FreeBSDQt5.10/display/redirect'
> STAGE_NAME = 'Configuring Build'
> BUILD_TAG = 'jenkins-Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10-4'
> JOB_URL = 'https://build.kde.org/job/Plasma%20plasma-vault%
> 20stable-kf5-qt5%20FreeBSDQt5.10/'
> NODE_NAME = 'FreeBSD Builder 3'
> HOST = 'freebsd-node3'
> WORKSPACE = '/usr/home/jenkins/workspace/Plasma plasma-vault
> stable-kf5-qt5 FreeBSDQt5.10'
> XDG_CONFIG_DIRS = '/usr/home/jenkins/install-
> prefix/etc/xdg:/usr/local/etc/xdg'
> GROUP = 'jenkins'
> BUILD_NUMBER = '4'
> HUDSON_URL = 'https://build.kde.org/'
> XDG_CURRENT_DESKTOP = 'KDE'
> EXECUTOR_NUMBER = '0'
> HOSTTYPE = 'FreeBSD'
> USER = 'jenkins'
> QML2_IMPORT_PATH = '/usr/home/jenkins/install-prefix/lib/qml'
> VENDOR = 'amd'
> MAIL = '/var/mail/jenkins'
> EDITOR = 'vi'
> SHELL = '/bin/tcsh'
> JENKINS_URL = 'https://build.kde.org/'
> XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/
> local/share'
> ASAN_OPTIONS = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_
> violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'
> LOGNAME = 'jenkins'
> HUDSON_HOME = '/home/production/data'
> == Commencing Configuration:
> cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address'
> -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins//install-prefix/"
> "/usr/home/jenkins/workspace/Plasma plasma-vault stable-kf5-qt5
> FreeBSDQt5.10"
> -- The C compiler identification is Clang 4.0.0
> -- The CXX compiler identification is Clang 4.0.0
> -- Check for working C compiler: /usr/bin/cc
> -- Check for working C compiler: /usr/bin/cc -- works
> -- Detecting C compiler ABI info
> -- Detecting C compiler ABI info - done
> -- Detecting C compile features
> -- Detecting C compile features - done
> -- Check for working CXX compiler: /usr/bin/c++
> -- Check for working CXX compiler: /usr/bin/c++ -- works
> -- Detecting CXX compiler ABI info
> -- Detecting CXX compiler ABI info - done
> -- Detecting CXX compile features
> -- Detecting CXX compile features - done
> --
> -- Could not set up the appstream test. appstreamcli is missing.
> -- Looking for __GLIBC__
> -- Looking for __GLIBC__ - not found
> -- Performing Test _OFFT_IS_64BIT
> -- Performing Test _OFFT_IS_64BIT - Success
> -- Performing Test HAVE_DATE_TIME
> -- Performing Test HAVE_DATE_TIME - Success
> -- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/
> KF5Activities/KF5ActivitiesConfig.cmake (found version "5.47.0")
> -- Found KF5Config: 
> /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake
> (found version "5.47.0")
> -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/
> KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.47.0")
> -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/
> KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.47.0")
> -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/
> KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.47.0")
> -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1")
> -- Found KF5I18n: 
> /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake
> (found version "5.47.0")
> -- Found KF5KIO: 
> /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake
> (found version "5.47.0")
> -- Found KF5Plasma: 
> /usr/home/jenkins/install

D12974: Workspace KCM Code Improvement

[Nathaniel Graham]

ngraham added a comment.


  While we're doing some formatting and style cleanup work, how about renaming 
some variables? For example `m_ostateToolTip` and `m_ostateVisualFeedback` 
aren't very descriptive IMHO. Maybe instead, they could be 
`m_currentToolTipState` and `m_currentVisualFeedbackState`.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12974

To: furkantokac, ngraham, romangg, #plasma, zzag
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12973: Workspace KCM Redesign Using Kirigami

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nicely done! Code and visual changes look good to me. Tested it out and 
everything still works. Just two little comment formatting nitpicks, then this 
is good to go from my perspective! (wait for other reviews too before landing, 
please)

INLINE COMMENTS

> main.qml:32
>  
> -Layouts.ColumnLayout {
> -id: maincol
> -spacing: units.largeSpacing
> +// VisaulBehavior Settings
> +Controls.CheckBox {

"Visual behavior settings"

> main.qml:57
>  
> -Controls.CheckBox {
> -id: showVisualFeedback
> -text: i18n("Display visual feedback for status changes")
> -checked: kcm.visualFeedback
> -onCheckedChanged: kcm.visualFeedback = checked
> -}
> +// ClickBehavior Settings
> +Controls.ExclusiveGroup {

"Click behavior settings"

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcmworkspace-Redesign

REVISION DETAIL
  https://phabricator.kde.org/D12973

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> davidedmundson wrote in actionlist.cpp:156
> I assume you have a second patch in p-f for this?
> 
> (which means this is Plasma 5.14 material)

This patch worked just for me all by itself, so I wasn't aware this required a 
plasma-framework change (I just moved the conditional around a bit, basically). 
Did I miss something?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12969

To: ngraham, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> actionlist.cpp:156
>  actionList << Kicker::createActionItem(i18n("Pin to Task Manager"), 
> "addToTaskManager");
> +} else if (ContainmentInterface::mayAddLauncher(appletInterface, 
> ContainmentInterface::Panel)) {
> +actionList << Kicker::createActionItem(i18n("Add to Panel 
> (Widget)"), "addToPanel");

I assume you have a second patch in p-f for this?

(which means this is Plasma 5.14 material)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12969

To: ngraham, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12973: Workspace KCM Redesign and Formatting Improvement

[Furkan Tokac]

furkantokac updated this revision to Diff 34459.
furkantokac added a comment.


  Workspace KCM is redesigned by using Kirigami.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12973?vs=34454&id=34459

BRANCH
  kcmworkspace-Redesign

REVISION DETAIL
  https://phabricator.kde.org/D12973

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12974: Workspace KCM Code Improvement

[Furkan Tokac]

furkantokac created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
furkantokac requested review of this revision.

REVISION SUMMARY
  Code formatting is improved. "save" function is improved by preventing 
unnecessary file open and file write.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcmworkspace-CodeFormatting

REVISION DETAIL
  https://phabricator.kde.org/D12974

AFFECTED FILES
  kcms/workspaceoptions/workspaceoptions.cpp

To: furkantokac
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12973: Workspace KCM Redesign and Formatting Improvement

[Furkan Tokac]

furkantokac created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
furkantokac requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcmWorkspaceFormatting

REVISION DETAIL
  https://phabricator.kde.org/D12973

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions.cpp

To: furkantokac
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10 - Build # 15 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20SUSEQt5.10/15/
 Project:
Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 18 May 2018 21:29:52 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.test_kio_fonts
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report13%
(10/79)11%
(51/446)11%
(51/446)10%
(3734/36445)9%
(2312/25973)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.kicker.plugin0%
(0/39)0%
(0/39)0%
(0/3324)0%
(0/2746)applets.kimpanel.backend.ibus0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/10)applets.kimpanel.backend.ibus.ibus150%
(0/10)0%
(0/10)0%
(0/1092)0%
(0/661)applets.kimpanel.backend.scim0%
(0/1)0%
(0/1)0%
(0/641)0%
(0/397)applets.kimpanel.plugin0%
(0/3)0%
(0/3)0%
(0/44)0%
(0/26)applets.pager.plugin0%
(0/4)0%
(0/4)0%
(0/330)0%
(0/224)applets.taskmanager.plugin0%
(0/4)0%
(0/4)0%
(0/314)0%
(0/294)applets.taskmanager.plugin.smartlaunchers0%
(0/4)0%
(0/4)0%
(0/291)0%
(0/212)applets.trash.plugin0%
(0/6)0%
(0/6)0%
(0/112)0%
(0/62)attica-kde.kdeplugin0%
(0/1)0%
(0/1)0%
(0/124)0%
(0/112)containments.desktop.plugins.desktop0%
(0/3)0%
(0/3)0%
(0/49)0%
(0/18)containments.desktop.plugins.folder25%
(6/24)25%
(6/24)38%
(849/2215)27%
(418/1545)containments.desktop.plugins.folder.autotests100%
(8/8)100%
(8/8)100%
(562/562)57%
(310/544)dataengines.kimpanel0%
(0/12)0%
(0/12)0%
(0/336)0%
(0/135)imports.activitymanager0%
(0/4)0%
(0/4)0%
(0/388)0%
(0/252)kaccess0%
(0/3)0%
(0/3)0%
(0/583)0%
(0/310)kcms.access0%
(0/1)0%
(0/1)0%
(0/306)0%
(0/80)kcms.activities0%

KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/4/
 Project:
Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 18 May 2018 21:29:55 +
 Build duration:
1 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 64.88 KB...]JAVA_HOME = '/usr/local/openjdk8-jre'BUILD_ID  = '4'PAGER = 'more'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/4/display/redirect?page=changes'PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/4/display/redirect'BLOCKSIZE = 'K'BUILD_URL = 'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/4/'LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'JOB_NAME  = 'Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10'TERM  = 'su'SHLVL = '1'JOB_BASE_NAME = 'Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10'HOME  = '/usr/home/jenkins/'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'PWD   = '/usr/home/jenkins/workspace/Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/display/redirect'STAGE_NAME= 'Configuring Build'BUILD_TAG = 'jenkins-Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10-4'JOB_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/'NODE_NAME = 'FreeBSD Builder 3'HOST  = 'freebsd-node3'WORKSPACE = '/usr/home/jenkins/workspace/Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10'XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'GROUP = 'jenkins'BUILD_NUMBER  = '4'HUDSON_URL= 'https://build.kde.org/'XDG_CURRENT_DESKTOP   = 'KDE'EXECUTOR_NUMBER   = '0'HOSTTYPE  = 'FreeBSD'USER  = 'jenkins'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'VENDOR= 'amd'MAIL  = '/var/mail/jenkins'EDITOR= 'vi'SHELL = '/bin/tcsh'JENKINS_URL   = 'https://build.kde.org/'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'LOGNAME   = 'jenkins'HUDSON_HOME   = '/home/production/data'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins//install-prefix/"  "/usr/home/jenkins/workspace/Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.47.0") -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.47.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.47.0") -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.47.0") -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.47.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.

plasma-desktop 5.13 beta update

[Jonathan Riddell]

I've updated the tar for plasma-desktop to include fixes from the
Plasma/5.12 branch

plasma-desktop;Plasma/5.13;9403d033927990dd71319583dd9c196f7da36c24;plasma-desktop-5.12.90.1.tar.xz;d7bf37b745ef47efa2bd19338d45a12d385fdf35d1c4d17f235241475
59ddae5

KDE CI: Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10 - Build # 14 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20SUSEQt5.10/14/
 Project:
Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 18 May 2018 20:39:54 +
 Build duration:
5 min 27 sec and counting
   CONSOLE OUTPUT
  [...truncated 1.02 MB...][ 42%] Building CXX object kcms/launch/CMakeFiles/kcm_launchfeedback.dir/kcm_launchfeedback_autogen/mocs_compilation.cpp.o[ 42%] Building CXX object kcms/autostart/CMakeFiles/kcm_autostart.dir/kcm_autostart_autogen/mocs_compilation.cpp.o[ 42%] Built target kcm_clockScanning dependencies of target kcolorschemeeditor[ 42%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/submenu.cpp.o[ 42%] Building CXX object kcms/colors/CMakeFiles/kcolorschemeeditor.dir/kcolorschemeeditor.cpp.o/home/jenkins/workspace/Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10/kcms/krdb/krdb.cpp: In function 'void applyGtkStyles(bool, int)':/home/jenkins/workspace/Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10/kcms/krdb/krdb.cpp:93:33: warning: unused parameter 'active' [-Wunused-parameter] static void applyGtkStyles(bool active, int version) ^~[ 43%] Linking CXX shared module ../../bin/kcm_autostart.so[ 43%] Linking CXX shared module ../../bin/kcm_launchfeedback.so[ 43%] Building CXX object kcms/colors/CMakeFiles/kcolorschemeeditor.dir/scmeditordialog.cpp.o[ 43%] Built target kcm_autostart[ 43%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/systementry.cpp.o[ 43%] Built target kcm_launchfeedback[ 43%] Building CXX object kcms/colors/CMakeFiles/kcm_colors.dir/colorscm.cpp.o/home/jenkins/workspace/Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10/applets/kicker/plugin/systementry.cpp: In member function 'void SystemEntry::init()':/home/jenkins/workspace/Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10/applets/kicker/plugin/systementry.cpp:98:47: warning: 'QSet Solid::PowerManagement::supportedSleepStates()' is deprecated [-Wdeprecated-declarations] m_valid = Solid::PowerManagement::supportedSleepStates().contains(Solid::PowerManagement::SuspendState);   ^~~~In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1:0, from /home/jenkins/workspace/Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10/applets/kicker/plugin/systementry.cpp:31:/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:74:52: note: declared here KDELIBS4SUPPORT_DEPRECATED_EXPORT QSet supportedSleepStates();^~~~/home/jenkins/workspace/Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10/applets/kicker/plugin/systementry.cpp:98:68: warning: 'QSet Solid::PowerManagement::supportedSleepStates()' is deprecated [-Wdeprecated-declarations] m_valid = Solid::PowerManagement::supportedSleepStates().contains(Solid::PowerManagement::SuspendState);^In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1:0, from /home/jenkins/workspace/Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10/applets/kicker/plugin/systementry.cpp:31:/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:74:52: note: declared here KDELIBS4SUPPORT_DEPRECATED_EXPORT QSet supportedSleepStates();^~~~/home/jenkins/workspace/Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10/applets/kicker/plugin/systementry.cpp:101:47: warning: 'QSet Solid::PowerManagement::supportedSleepStates()' is deprecated [-Wdeprecated-declarations] m_valid = Solid::PowerManagement::supportedSleepStates().contains(Solid::PowerManagement::HibernateState);   ^~~~In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1:0, from /home/jenkins/workspace/Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10/applets/kicker/plugin/systementry.cpp:31:/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:74:52: note: declared here KDELIBS4SUPPORT_DEPRECATED_EXPORT QSet supportedSleepStates();^~~~/home/jenkins/workspace/Plasma plasma-desktop stable-kf5-qt5 SUSEQt5.10/applets/kicker/plugin/systementry.cpp:101:68: warning: 'QSet Solid::PowerManagement::supportedSleepStates()' is deprecated [-Wdeprecated-declarations] m_valid = Solid::PowerManagement::supportedSleepStates().contains(Solid::PowerManagement::HibernateState);^In file included from /home/jenkins/install-prefix/include/KF5/KD

KDE CI: Plasma plasma-integration stable-kf5-qt5 FreeBSDQt5.10 - Build # 2 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20plasma-integration%20stable-kf5-qt5%20FreeBSDQt5.10/2/
 Project:
Plasma plasma-integration stable-kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 18 May 2018 17:15:17 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 8 test(s)Failed: TestSuite.frameworkintegration-kdeplatformtheme_unittestFailed: TestSuite.frameworkintegration-kdirselectdialog_unittestFailed: TestSuite.frameworkintegration-kfiledialog_unittestFailed: TestSuite.frameworkintegration-kfiledialogqml_unittestFailed: TestSuite.frameworkintegration-kfontsettingsdata_unittestFailed: TestSuite.frameworkintegration-ksni_unittestFailed: TestSuite.qmltests

KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 3 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/3/
 Project:
Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 18 May 2018 17:15:17 +
 Build duration:
28 min and counting
   CONSOLE OUTPUT
  [...truncated 64.34 KB...]JOB_BASE_NAME = 'Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10'SHELL = '/usr/local/bin/bash'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'BUILD_URL = 'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/3/'JOB_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/'STAGE_NAME= 'Configuring Build'JOB_NAME  = 'Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'BLOCKSIZE = 'K'BUILD_DISPLAY_NAME= '#3'EXECUTOR_NUMBER   = '0'LOGNAME   = 'jenkins'PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'USER  = 'jenkins'QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins'MAIL  = '/var/mail/jenkins'_ = '/usr/local/bin/java'QT_SELECT = 'qt5'TERM  = 'su'PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'HUDSON_HOME   = '/home/production/data'HUDSON_URL= 'https://build.kde.org/'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'JAVA_HOME = '/usr/local/openjdk8-jre'OLDPWD= '/usr/home/jenkins'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'BUILD_ID  = '3'BUILD_NUMBER  = '3'BUILD_TAG = 'jenkins-Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10-3'JENKINS_URL   = 'https://build.kde.org/'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/3/display/redirect'XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'PWD   = '/usr/home/jenkins/workspace/Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10'HOME  = '/home/jenkins'NODE_LABELS   = 'FreeBSD Builder 2 FreeBSDQt5.10'NODE_NAME = 'FreeBSD Builder 2'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/3/display/redirect?page=changes'XDG_CURRENT_DESKTOP   = 'KDE'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/display/redirect'MM_CHARSET= 'UTF-8'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.47.0") -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.47.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.47.0") -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.47.0") -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.47.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Users get confused by the difference between "Pin to Task Manager" and "Add 
to Panel (Widget)", and we get bugs about this.
  
  This patch resolves that confusion by only showing "Add to Panel (Widget)" 
when there's no Task Manager widget.
  
  BUG: 390817
  FIXED-IN: 5.13.0

TEST PLAN
  Task Manager, widgets unlocked:
  
  Task Manager, Widgets locked:
  
  No Task Manager, Widgets unlocked:
  
  Task Manager, Widgets unlocked:

REPOSITORY
  R119 Plasma Desktop

BRANCH
  no-add-to-panel-as-widget-when-theres-a-task-manager (branched from 
Plasma/5.13)

REVISION DETAIL
  https://phabricator.kde.org/D12969

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp

To: ngraham, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12960: Drag handle to reorder items in a ListView

[Alessandro Longo]

alex-l added a comment.


  Cursors and hover:
  F5856535: immagine.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12960

To: mart, #kirigami, #vdg, hein
Cc: alex-l, abetts, rkflx, ngraham, zzag, plasma-devel, apol, davidedmundson, 
mart, hein

D12960: Drag handle to reorder items in a ListView

[Marco Martin]

mart added a comment.


  In D12960#264749 , @ngraham wrote:
  
  > IMHO the up-and-down arrows do a much better job of communicating "drag 
me!" than a 9 dot grid does.
  
  
  good point, so so far my favourite are the options by alex

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12960

To: mart, #kirigami, #vdg, hein
Cc: alex-l, abetts, rkflx, ngraham, zzag, plasma-devel, apol, davidedmundson, 
mart, hein

D12960: Drag handle to reorder items in a ListView

[Nathaniel Graham]

ngraham added a comment.


  IMHO the up-and-down arrows do a much better job of communicating "drag me!" 
than a 9 dot grid does.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12960

To: mart, #kirigami, #vdg, hein
Cc: alex-l, abetts, rkflx, ngraham, zzag, plasma-devel, apol, davidedmundson, 
mart, hein

D12960: Drag handle to reorder items in a ListView

[Marco Martin]

mart added a comment.


  In D12960#264737 , @alex-l wrote:
  
  > In D12960#264732 , @alex-l wrote:
  >
  > > F5856484: immagine.png 
  >
  >
  > I think the mouse cursor should be:
  >
  > - drag-open-hand for first one
  > - clickable-finger (like for links) for second and third ones
  
  
  to me all 3 are quite good!
  
  the first if we drop the directionality can become just a 9 dots matrix?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12960

To: mart, #kirigami, #vdg, hein
Cc: alex-l, abetts, rkflx, ngraham, zzag, plasma-devel, apol, davidedmundson, 
mart, hein

D12936: Rewrite workspace KCM in QtQuick

[Furkan Tokac]

furkantokac added inline comments.

INLINE COMMENTS

> zzag wrote in workspaceoptions.cpp:110
> Coding style nitpick: No whitespace after `(` and before `)`. Also, I 
> believe, there should be a whitespace between control statement keyword and 
> opening parentheses.

Done. Thanks. I avoid small changes for better diff revision so now I'm 
reviewing the whole patch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12936

To: furkantokac, romangg, ngraham, #plasma
Cc: ltoscano, yurchor, zzag, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12960: Drag handle to reorder items in a ListView

[Alessandro Longo]

alex-l added a comment.


  In D12960#264732 , @alex-l wrote:
  
  > F5856484: immagine.png 
  
  
  I think the mouse cursor should be:
  
  - drag-open-hand for first one
  - clickable-finger (like for links) for second and third ones

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12960

To: mart, #kirigami, #vdg, hein
Cc: alex-l, abetts, rkflx, ngraham, zzag, plasma-devel, apol, davidedmundson, 
mart, hein

KDE CI: Plasma powerdevil kf5-qt5 SUSEQt5.10 - Build # 5 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20powerdevil%20kf5-qt5%20SUSEQt5.10/5/
 Project:
Plasma powerdevil kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 18 May 2018 14:49:49 +
 Build duration:
42 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/8)0%
(0/71)0%
(0/71)0%
(0/4009)0%
(0/2881)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdaemon0%
(0/20)0%
(0/20)0%
(0/1416)0%
(0/1165)daemon.actions.bundled0%
(0/18)0%
(0/18)0%
(0/806)0%
(0/478)daemon.actions.dpms0%
(0/9)0%
(0/9)0%
(0/221)0%
(0/126)daemon.backends.upower0%
(0/16)0%
(0/16)0%
(0/1024)0%
(0/811)kcmodule.activities0%
(0/2)0%
(0/2)0%
(0/194)0%
(0/125)kcmodule.common0%
(0/3)0%
(0/3)0%
(0/154)0%
(0/96)kcmodule.global0%
(0/1)0%
(0/1)0%
(0/78)0%
(0/28)kcmodule.profiles0%
(0/2)0%
(0/2)0%
(0/116)0%
(0/52)

D12960: Drag handle to reorder items in a ListView

[Andres Betts]

abetts added a comment.


  In D12960#264734 , @ngraham wrote:
  
  > Regardless of what icon we choose, for a drag handle, I think it has to be 
a very light gray. We previously had a 4x3 dot grid, but because it was black, 
it looked very heavy and when a bunch of them were all lined up vertically, the 
net effect was sort of weird.
  
  
  +1

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12960

To: mart, #kirigami, #vdg, hein
Cc: alex-l, abetts, rkflx, ngraham, zzag, plasma-devel, apol, davidedmundson, 
mart, hein

D12960: Drag handle to reorder items in a ListView

[Nathaniel Graham]

ngraham added a comment.


  In D12960#264732 , @alex-l wrote:
  
  > F5856484: immagine.png 
  
  
  I really like the vertical drag icon here! Not so sure about the horizontal 
swipe icon though.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12960

To: mart, #kirigami, #vdg, hein
Cc: alex-l, abetts, rkflx, ngraham, zzag, plasma-devel, apol, davidedmundson, 
mart, hein

D12960: Drag handle to reorder items in a ListView

[Nathaniel Graham]

ngraham added a comment.


  Regardless of what icon we choose, for a drag handle, I think it has to be a 
very light gray. We previously had a 4x3 dot grid, but because it was black, it 
looked very heavy and when a bunch of them were all lined up vertically, the 
net effect was sort of weird.
  
  Personally, My favorite was a small number of dots with Henrik's idea:
  
  F5817550: Screenshot_20180422_111540_less-dots.png 

  
  Especially the two right-most ones. If rendered in light gray, I think those 
could look great.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12960

To: mart, #kirigami, #vdg, hein
Cc: alex-l, abetts, rkflx, ngraham, zzag, plasma-devel, apol, davidedmundson, 
mart, hein

D12960: Drag handle to reorder items in a ListView

[Alessandro Longo]

alex-l added a comment.


  F5856484: immagine.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12960

To: mart, #kirigami, #vdg, hein
Cc: alex-l, abetts, rkflx, ngraham, zzag, plasma-devel, apol, davidedmundson, 
mart, hein

KDE CI: Plasma plasma-integration kf5-qt5 SUSEQt5.10 - Build # 4 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20plasma-integration%20kf5-qt5%20SUSEQt5.10/4/
 Project:
Plasma plasma-integration kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 18 May 2018 14:47:54 +
 Build duration:
33 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.frameworkintegration-kdeplatformtheme_unittestFailed: TestSuite.frameworkintegration-kfiledialog_unittestFailed: TestSuite.frameworkintegration-kfiledialogqml_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)57%
(16/28)57%
(16/28)30%
(642/2175)17%
(243/1456)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests71%
(5/7)71%
(5/7)41%
(224/546)17%
(106/609)src.platformtheme61%
(11/18)61%
(11/18)28%
(418/1508)17%
(137/811)tests0%
(0/3)0%
(0/3)0%
(0/121)0%
(0/36)

KDE CI: Plasma plasma-vault kf5-qt5 FreeBSDQt5.10 - Build # 7 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/7/
 Project:
Plasma plasma-vault kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 18 May 2018 14:48:19 +
 Build duration:
23 min and counting
   CONSOLE OUTPUT
  [...truncated 62.26 KB...]TERM  = 'su'SHELL = '/usr/local/bin/bash'BUILD_URL = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/7/'JAVA_HOME = '/usr/local/openjdk8-jre'BUILD_NUMBER  = '7'EXECUTOR_NUMBER   = '0'QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins'WORKSPACE = '/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.10'_ = '/usr/local/bin/java'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'MAIL  = '/var/mail/jenkins'LANG  = 'en_US.UTF-8'LOGNAME   = 'jenkins'USER  = 'jenkins'HUDSON_URL= 'https://build.kde.org/'MM_CHARSET= 'UTF-8'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/7/display/redirect?page=changes'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/display/redirect'JOB_NAME  = 'Plasma plasma-vault kf5-qt5 FreeBSDQt5.10'NODE_LABELS   = 'FreeBSD Builder 2 FreeBSDQt5.10'BUILD_TAG = 'jenkins-Plasma plasma-vault kf5-qt5 FreeBSDQt5.10-7'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/7/display/redirect'BUILD_DISPLAY_NAME= '#7'PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'BUILD_ID  = '7'LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'OLDPWD= '/usr/home/jenkins'PWD   = '/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.10'QT_SELECT = 'qt5'SHLVL = '1'NODE_NAME = 'FreeBSD Builder 2'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'JOB_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'JENKINS_URL   = 'https://build.kde.org/'XDG_CURRENT_DESKTOP   = 'KDE'STAGE_NAME= 'Configuring Build'HOME  = '/home/jenkins'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.10"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.46.0") -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.46.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.46.0") -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.46.0") -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.46.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/

KDE CI: Plasma kde-cli-tools kf5-qt5 SUSEQt5.10 - Build # 5 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.10/5/
 Project:
Plasma kde-cli-tools kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 18 May 2018 14:44:21 +
 Build duration:
3 min 2 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)13%
(4/30)13%
(4/30)19%
(496/2569)17%
(281/1659)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/166)0%
(0/88)kdesu0%
(0/2)0%
(0/2)0%
(0/276)0%
(0/194)keditfiletype18%
(3/17)18%
(3/17)23%
(287/1256)21%
(150/728)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(209/258)43%
(131/308)kioclient0%
(0/2)0%
(0/2)0%
(0/222)0%
(0/98)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/224)0%
(0/172)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/35)

D12960: Drag handle to reorder items in a ListView

[Andres Betts]

abetts added a comment.


  In D12960#264657 , @rkflx wrote:
  
  > F5855884: drag-handles.png 
  
  
  I think with this image we are trying to convey too much. Users in general, 
will understand that if you have a consistent imagery to represent drag, they 
will come to recognize it and use it however the system allows them to use it. 
Because of that, the arrows are extra. Not necessary. Because the system will 
determine the drag direction and the user will understand how to use them. 
Instead, we have to focus on the center image first and convey drag that way. 
Plus, on mobile for example, this is generally not used. People don't use 
arrows to represent drag direction. Instead, they just try to represent drag. I 
think we can use that idea.
  
  We agree that dots are used to represent touch or "draggable" control
  
  Another thought is that we also want to be a bit different, maybe not too 
different, than what other platforms do. We have tried a few ideas on this. 
What about these ones:
  
  F5856357: 001-circle.png 
  
  F5856358: 002-arrows.png 
  
  F5856359: 003-mark.png 
  
  F5856360: 004-big-and-small-dots.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12960

To: mart, #kirigami, #vdg, hein
Cc: abetts, rkflx, ngraham, zzag, plasma-devel, apol, davidedmundson, mart, hein

Plasma 5.13 beta

[Jonathan Riddell]

Plasma 5.13 Beta brings many new features to this lightweight but full
featured desktop.
https://www.kde.org/announcements/plasma-5.12.90.php
Plasma Browser Integration, System Settings Redesigns, New Look
Login/Lock Screens, Redesigned Media Player Widget, oh so much more...

Plasma 5.13 errata

[Jonathan Riddell]

Please review this page (copied from 5.12) for noteable problems in Plasma 5.13

https://community.kde.org/Plasma/5.13_Errata

Jonathan

KDE CI: Plasma systemsettings kf5-qt5 SUSEQt5.10 - Build # 18 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20systemsettings%20kf5-qt5%20SUSEQt5.10/18/
 Project:
Plasma systemsettings kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 18 May 2018 13:06:52 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/7)0%
(0/28)0%
(0/28)0%
(0/1847)0%
(0/729)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapp0%
(0/3)0%
(0/3)0%
(0/273)0%
(0/138)app.ToolTips0%
(0/1)0%
(0/1)0%
(0/92)0%
(0/18)classic0%
(0/2)0%
(0/2)0%
(0/191)0%
(0/52)core0%
(0/10)0%
(0/10)0%
(0/508)0%
(0/241)icons0%
(0/5)0%
(0/5)0%
(0/273)0%
(0/54)sidebar0%
(0/6)0%
(0/6)0%
(0/417)0%
(0/204)sidebar.ToolTips0%
(0/1)0%
(0/1)0%
(0/93)0%
(0/22)

KDE CI: Plasma plasma-vault kf5-qt5 FreeBSDQt5.10 - Build # 6 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/6/
 Project:
Plasma plasma-vault kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 18 May 2018 13:05:08 +
 Build duration:
29 min and counting
   CONSOLE OUTPUT
  [...truncated 62.37 KB...]MAIL  = '/var/mail/jenkins'JAVA_HOME = '/usr/local/openjdk8-jre'QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins'PWD   = '/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.10'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'BUILD_NUMBER  = '6'BUILD_URL = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/6/'TERM  = 'su'QT_SELECT = 'qt5'NODE_LABELS   = 'FreeBSD Builder 2 FreeBSDQt5.10'JOB_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/'PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'USER  = 'jenkins'BLOCKSIZE = 'K'JENKINS_URL   = 'https://build.kde.org/'LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/6/display/redirect?page=changes'BUILD_DISPLAY_NAME= '#6'XDG_CURRENT_DESKTOP   = 'KDE'HUDSON_HOME   = '/home/production/data'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'WORKSPACE = '/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.10'BUILD_ID  = '6'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/6/display/redirect'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'NODE_NAME = 'FreeBSD Builder 2'SHELL = '/usr/local/bin/bash'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'HOME  = '/home/jenkins'JOB_BASE_NAME = 'Plasma plasma-vault kf5-qt5 FreeBSDQt5.10'SHLVL = '1'JOB_NAME  = 'Plasma plasma-vault kf5-qt5 FreeBSDQt5.10'EXECUTOR_NUMBER   = '0'STAGE_NAME= 'Configuring Build'LOGNAME   = 'jenkins'HUDSON_URL= 'https://build.kde.org/'MM_CHARSET= 'UTF-8'BUILD_TAG = 'jenkins-Plasma plasma-vault kf5-qt5 FreeBSDQt5.10-6'XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'_ = '/usr/local/bin/java'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.10"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.46.0") -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.46.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.46.0") -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.46.0") -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.46.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.46.

KDE CI: Plasma powerdevil kf5-qt5 SUSEQt5.10 - Build # 4 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20powerdevil%20kf5-qt5%20SUSEQt5.10/4/
 Project:
Plasma powerdevil kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 18 May 2018 13:06:43 +
 Build duration:
20 min and counting
   CONSOLE OUTPUT
  [...truncated 91.04 KB...]HUDSON_URL= 'https://build.kde.org/'HOME  = '/home/jenkins/'NODE_NAME = 'Docker Swarm-598d5e84b4d0'HOST  = '598d5e84b4d0'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JOB_NAME  = 'Plasma powerdevil kf5-qt5 SUSEQt5.10'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20powerdevil%20kf5-qt5%20SUSEQt5.10/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Plasma%20powerdevil%20kf5-qt5%20SUSEQt5.10/4/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Plasma%20powerdevil%20kf5-qt5%20SUSEQt5.10/'BUILD_DISPLAY_NAME= '#4'XCURSOR_THEME = 'DMZ'SHLVL = '3'BUILD_TAG = 'jenkins-Plasma powerdevil kf5-qt5 SUSEQt5.10-4'NODE_LABELS   = 'Docker Swarm-598d5e84b4d0 SUSEQt5.10'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma powerdevil kf5-qt5 SUSEQt5.10"-- The C compiler identification is GNU 7.3.1-- The CXX compiler identification is GNU 7.3.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.47.0") -- Found KF5Auth: /home/jenkins/install-prefix/lib64/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.47.0") -- Found KF5IdleTime: /home/jenkins/install-prefix/lib64/cmake/KF5IdleTime/KF5IdleTimeConfig.cmake (found version "5.47.0") -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.47.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.47.0") -- Found KF5Solid: /home/jenkins/install-prefix/lib64/cmake/KF5Solid/KF5SolidConfig.cmake (found version "5.47.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.47.0") -- Found KF5GlobalAccel: /home/jenkins/install-prefix/lib64/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.47.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.47.0") -- Found KF5NotifyConfig: /home/jenkins/install-prefix/lib64/cmake/KF5NotifyConfig/KF5NotifyCon

KDE CI: Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.10/4/
 Project:
Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 18 May 2018 13:01:36 +
 Build duration:
5 min 6 sec and counting
   CONSOLE OUTPUT
  [...truncated 66.46 KB...]MM_CHARSET= 'UTF-8'JENKINS_URL   = 'https://build.kde.org/'USER  = 'jenkins'LANG  = 'en_US.UTF-8'BUILD_ID  = '4'PWD   = '/usr/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.10'XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.10/4/display/redirect'QT_SELECT = 'qt5'PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'LOGNAME   = 'jenkins'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'XDG_CURRENT_DESKTOP   = 'KDE'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.10/display/redirect'JOB_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.10/'BUILD_URL = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.10/4/'PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'EXECUTOR_NUMBER   = '0'_ = '/usr/local/bin/java'BUILD_NUMBER  = '4'HUDSON_URL= 'https://build.kde.org/'SHLVL = '1'HUDSON_HOME   = '/home/production/data'JOB_NAME  = 'Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.10'SHELL = '/usr/local/bin/bash'TERM  = 'su'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'STAGE_NAME= 'Configuring Build'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'WORKSPACE = '/usr/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.10'BUILD_TAG = 'jenkins-Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.10-4'BLOCKSIZE = 'K'LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'NODE_NAME = 'FreeBSD Builder 2'MAIL  = '/var/mail/jenkins'BUILD_DISPLAY_NAME= '#4'OLDPWD= '/usr/home/jenkins'JOB_BASE_NAME = 'Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.10'QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins'NODE_LABELS   = 'FreeBSD Builder 2 FreeBSDQt5.10'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.10"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.46.0") -- Found KF5DocTools: /usr/home/jenkins/install-prefix/lib/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.46.0") -- Found KF5IconThemes: /usr/home/jenkins/install-prefix/lib/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.46.0") -- Found KF5Init: /usr/home/jenkins/install-prefix/lib/cmake/KF5Init/KF5InitConfig.cmake (found version "5.46.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.46.0") -- Found KF5KCMUtils: /usr/home/jenkins/install-prefix/lib/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version "5.46.0") -- Found KF5KIO: /usr/home/jenkins/install-p

KDE CI: Plasma kde-cli-tools kf5-qt5 SUSEQt5.10 - Build # 4 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.10/4/
 Project:
Plasma kde-cli-tools kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 18 May 2018 13:01:36 +
 Build duration:
1 min 56 sec and counting
   CONSOLE OUTPUT
  [...truncated 89.13 KB...]BUILD_NUMBER  = '4'MORE  = '-sl'WORKSPACE = '/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 SUSEQt5.10'PWD   = '/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 SUSEQt5.10'HUDSON_URL= 'https://build.kde.org/'HOME  = '/home/jenkins/'NODE_NAME = 'Docker Swarm-8d33e93ff652'HOST  = '8d33e93ff652'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JOB_NAME  = 'Plasma kde-cli-tools kf5-qt5 SUSEQt5.10'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.10/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.10/4/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.10/'BUILD_DISPLAY_NAME= '#4'XCURSOR_THEME = 'DMZ'SHLVL = '3'BUILD_TAG = 'jenkins-Plasma kde-cli-tools kf5-qt5 SUSEQt5.10-4'NODE_LABELS   = 'Docker Swarm-8d33e93ff652 SUSEQt5.10'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 SUSEQt5.10"-- The C compiler identification is GNU 7.3.1-- The CXX compiler identification is GNU 7.3.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.47.0") -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.47.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.47.0") -- Found KF5Init: /home/jenkins/install-prefix/lib64/cmake/KF5Init/KF5InitConfig.cmake (found version "5.47.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.47.0") -- Found KF5KCMUtils: /home/jenkins/install-prefix/lib64/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version "5.47.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.47.0") -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Serv

D12960: Drag handle to reorder items in a ListView

[Henrik Fehlauer]

rkflx added a comment.


  F5855884: drag-handles.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12960

To: mart, #kirigami, #vdg, hein
Cc: rkflx, ngraham, zzag, plasma-devel, apol, davidedmundson, mart, hein

D12960: Drag handle to reorder items in a ListView

[Nathaniel Graham]

ngraham added a comment.


  How about the version like that, but with fewer dots? I thought those looked 
really, really good.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12960

To: mart, #kirigami, #vdg, hein
Cc: ngraham, zzag, plasma-devel, apol, davidedmundson, mart, hein

Plasma Vaults by Default

[Jonathan Riddell]

It's been suggested that we don't have Plasma Vaults visible by
default in the systray as it adds extra clutter.  Should we set them
to be hidden by default?

Jonathan

D12960: Drag handle to reorder items in a ListView

[Marco Martin]

mart added a comment.


  Possible handles (to resume that old discussion)
  F5855838: Spectacle.q10653.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12960

To: mart, #kirigami, #vdg, hein
Cc: zzag, plasma-devel, apol, davidedmundson, mart, hein

D12960: Drag handle to reorder items in a ListView

[Marco Martin]

mart updated this revision to Diff 34430.
mart added a comment.


  all files

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12960?vs=34426&id=34430

BRANCH
  mart/dragHandle

REVISION DETAIL
  https://phabricator.kde.org/D12960

AFFECTED FILES
  examples/gallerydata/contents/ui/gallery/ListViewGallery.qml
  kirigami.qrc
  src/controls/ListItemDragHandle.qml
  src/controls/private/DefaultListItemBackground.qml
  src/controls/templates/SwipeListItem.qml
  src/delegaterecycler.cpp
  src/delegaterecycler.h
  src/kirigamiplugin.cpp
  src/qmldir
  src/styles/Material/SwipeListItem.qml

To: mart, #kirigami, #vdg, hein
Cc: zzag, plasma-devel, apol, davidedmundson, mart, hein

D12962: prototype of a drag handle

[Marco Martin]

mart created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  fix DelegateRecycler for elements that may change index when moved
  
  seamless drag
  
  finish up delegateRecycler
  
  layout fixes
  
  auto scroll timer
  
  fix Swipelistitem to be somebody else child
  
  add standalone drag handle
  
  proper version

REPOSITORY
  R169 Kirigami

BRANCH
  mart/dragHandle

REVISION DETAIL
  https://phabricator.kde.org/D12962

AFFECTED FILES
  examples/gallerydata/contents/ui/gallery/ListViewGallery.qml
  kirigami.qrc
  src/controls/ListItemDragHandle.qml
  src/controls/private/DefaultListItemBackground.qml
  src/controls/templates/SwipeListItem.qml
  src/delegaterecycler.cpp
  src/delegaterecycler.h
  src/kirigamiplugin.cpp
  src/qmldir
  src/styles/Material/SwipeListItem.qml

To: mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D12960: Drag handle to reorder items in a ListView

[Marco Martin]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:5ba11c3b9efe: proper version (authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D12960?vs=34425&id=34426#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12960?vs=34425&id=34426

REVISION DETAIL
  https://phabricator.kde.org/D12960

AFFECTED FILES
  examples/gallerydata/contents/ui/gallery/ListViewGallery.qml
  src/kirigamiplugin.cpp

To: mart, #kirigami, #vdg, hein
Cc: zzag, plasma-devel, apol, davidedmundson, mart, hein

D12960: Drag handle to reorder items in a ListView

[Marco Martin]

mart updated this revision to Diff 34425.
mart added a comment.


  - proper version

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12960?vs=34423&id=34425

BRANCH
  mart/dragHandle

REVISION DETAIL
  https://phabricator.kde.org/D12960

AFFECTED FILES
  examples/gallerydata/contents/ui/gallery/ListViewGallery.qml
  kirigami.qrc
  src/controls/ListItemDragHandle.qml
  src/controls/private/DefaultListItemBackground.qml
  src/controls/templates/SwipeListItem.qml
  src/delegaterecycler.cpp
  src/delegaterecycler.h
  src/kirigamiplugin.cpp
  src/qmldir
  src/styles/Material/SwipeListItem.qml

To: mart, #kirigami, #vdg, hein
Cc: zzag, plasma-devel, apol, davidedmundson, mart, hein

D12960: Drag handle to reorder items in a ListView

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> kirigamiplugin.cpp:172
> +//2.5
> +qmlRegisterType(componentUrl(QStringLiteral("ListItemDragHandle.qml")), 
> uri, 2, 4, "ListItemDragHandle");
> +

Is the minor version correct?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12960

To: mart, #kirigami, #vdg, hein
Cc: zzag, plasma-devel, apol, davidedmundson, mart, hein

D12960: Drag handle to reorder items in a ListView

[Marco Martin]

mart added a comment.


  in action
  https://youtu.be/vQUnOpwV9xU
  
  note that the red square icon is a placeholder, new breeze icons are needed 
for that

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12960

To: mart, #kirigami, #vdg, hein
Cc: plasma-devel, apol, davidedmundson, mart, hein

D12960: Drag handle to reorder items in a ListView

[Marco Martin]

mart created this revision.
mart added reviewers: Kirigami, VDG, hein.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  A component to be inserted in list items of any kind, when used in ListViews
  when the user wishes to be able to reorder items by drag.
  
  The handle must be used in a list item which is not directly
  the view's delegate, but its main child. the main delegate will act
  as empty space placeholder.
  It is recomended to use the DelegateRecycler component for this purpose

TEST PLAN
  used in the list view gallery page

REPOSITORY
  R169 Kirigami

BRANCH
  mart/dragHandle

REVISION DETAIL
  https://phabricator.kde.org/D12960

AFFECTED FILES
  examples/gallerydata/contents/ui/gallery/ListViewGallery.qml
  kirigami.qrc
  src/controls/ListItemDragHandle.qml
  src/controls/private/DefaultListItemBackground.qml
  src/controls/templates/SwipeListItem.qml
  src/delegaterecycler.cpp
  src/delegaterecycler.h
  src/kirigamiplugin.cpp
  src/qmldir
  src/styles/Material/SwipeListItem.qml

To: mart, #kirigami, #vdg, hein
Cc: plasma-devel, apol, davidedmundson, mart, hein

D12958: Fix AppsModel not refreshing on syccoa changes.

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7e514201e2f1: Fix AppsModel not refreshing on syccoa 
changes. (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12958?vs=34420&id=34421

REVISION DETAIL
  https://phabricator.kde.org/D12958

AFFECTED FILES
  applets/kicker/plugin/appsmodel.cpp

To: hein, broulik, sitter, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12958: Fix AppsModel not refreshing on syccoa changes.

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.


  💃 💃 💃

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12958

To: hein, broulik, sitter, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12958: Fix AppsModel not refreshing on syccoa changes.

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.


  Aua :(

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12958

To: hein, broulik, sitter, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12958: Fix AppsModel not refreshing on syccoa changes.

[Eike Hein]

hein created this revision.
hein added reviewers: broulik, sitter.
Restricted Application added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  Fixes regression introduced by a0ca2d1bc204 
.
  
  BUG:394322

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12958

AFFECTED FILES
  applets/kicker/plugin/appsmodel.cpp

To: hein, broulik, sitter
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma systemsettings kf5-qt5 SUSEQt5.10 - Build # 17 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20systemsettings%20kf5-qt5%20SUSEQt5.10/17/
 Project:
Plasma systemsettings kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 18 May 2018 09:44:34 +
 Build duration:
24 min and counting
   CONSOLE OUTPUT
  [...truncated 93.07 KB...]JOB_NAME  = 'Plasma systemsettings kf5-qt5 SUSEQt5.10'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20systemsettings%20kf5-qt5%20SUSEQt5.10/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Plasma%20systemsettings%20kf5-qt5%20SUSEQt5.10/17/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Plasma%20systemsettings%20kf5-qt5%20SUSEQt5.10/'BUILD_DISPLAY_NAME= '#17'XCURSOR_THEME = 'DMZ'SHLVL = '3'BUILD_TAG = 'jenkins-Plasma systemsettings kf5-qt5 SUSEQt5.10-17'NODE_LABELS   = 'Docker Swarm-736e75078c4f SUSEQt5.10'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma systemsettings kf5-qt5 SUSEQt5.10"-- The C compiler identification is GNU 7.3.1-- The CXX compiler identification is GNU 7.3.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Crash: /home/jenkins/install-prefix/lib64/cmake/KF5Crash/KF5CrashConfig.cmake (found version "5.47.0") -- Found KF5ItemViews: /home/jenkins/install-prefix/lib64/cmake/KF5ItemViews/KF5ItemViewsConfig.cmake (found version "5.47.0") -- Found KF5KCMUtils: /home/jenkins/install-prefix/lib64/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version "5.47.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.47.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.47.0") -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.47.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.47.0") -- Found KF5WidgetsAddons: /home/jenkins/install-prefix/lib64/cmake/KF5WidgetsAddons/KF5WidgetsAddonsConfig.cmake (found version "5.47.0") -- Found KF5WindowSystem: /home/jenkins/install-prefix/lib64/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.47.0") -- Found KF5XmlGui: /home/jenkins/install-prefix/lib64/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version "5.47.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.47.0") -- Found KF5Config: /home/

KDE CI: Plasma powerdevil kf5-qt5 SUSEQt5.10 - Build # 3 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20powerdevil%20kf5-qt5%20SUSEQt5.10/3/
 Project:
Plasma powerdevil kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 18 May 2018 09:44:22 +
 Build duration:
23 min and counting
   CONSOLE OUTPUT
  [...truncated 91.04 KB...]HUDSON_URL= 'https://build.kde.org/'HOME  = '/home/jenkins/'NODE_NAME = 'Docker Swarm-cbcd143cbc93'HOST  = 'cbcd143cbc93'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JOB_NAME  = 'Plasma powerdevil kf5-qt5 SUSEQt5.10'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20powerdevil%20kf5-qt5%20SUSEQt5.10/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Plasma%20powerdevil%20kf5-qt5%20SUSEQt5.10/3/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Plasma%20powerdevil%20kf5-qt5%20SUSEQt5.10/'BUILD_DISPLAY_NAME= '#3'XCURSOR_THEME = 'DMZ'SHLVL = '3'BUILD_TAG = 'jenkins-Plasma powerdevil kf5-qt5 SUSEQt5.10-3'NODE_LABELS   = 'Docker Swarm-cbcd143cbc93 SUSEQt5.10'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma powerdevil kf5-qt5 SUSEQt5.10"-- The C compiler identification is GNU 7.3.1-- The CXX compiler identification is GNU 7.3.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.47.0") -- Found KF5Auth: /home/jenkins/install-prefix/lib64/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.47.0") -- Found KF5IdleTime: /home/jenkins/install-prefix/lib64/cmake/KF5IdleTime/KF5IdleTimeConfig.cmake (found version "5.47.0") -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.47.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.47.0") -- Found KF5Solid: /home/jenkins/install-prefix/lib64/cmake/KF5Solid/KF5SolidConfig.cmake (found version "5.47.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.47.0") -- Found KF5GlobalAccel: /home/jenkins/install-prefix/lib64/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.47.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.47.0") -- Found KF5NotifyConfig: /home/jenkins/install-prefix/lib64/cmake/KF5NotifyConfig/KF5NotifyCon

KDE CI: Plasma plasma-vault kf5-qt5 FreeBSDQt5.10 - Build # 5 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/5/
 Project:
Plasma plasma-vault kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 18 May 2018 09:43:17 +
 Build duration:
16 min and counting
   CONSOLE OUTPUT
  [...truncated 62.39 KB...]LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'SHELL = '/usr/local/bin/bash'JOB_BASE_NAME = 'Plasma plasma-vault kf5-qt5 FreeBSDQt5.10'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/display/redirect'BUILD_TAG = 'jenkins-Plasma plasma-vault kf5-qt5 FreeBSDQt5.10-5'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/5/display/redirect?page=changes'BUILD_ID  = '5'STAGE_NAME= 'Configuring Build'MM_CHARSET= 'UTF-8'NODE_NAME = 'FreeBSD Builder 1'EXECUTOR_NUMBER   = '0'QT_SELECT = 'qt5'_ = '/usr/local/bin/java'JENKINS_URL   = 'https://build.kde.org/'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/5/display/redirect'LANG  = 'en_US.UTF-8'PWD   = '/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.10'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'JAVA_HOME = '/usr/local/openjdk8-jre'XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'USER  = 'jenkins'HUDSON_URL= 'https://build.kde.org/'WORKSPACE = '/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.10'TERM  = 'su'XDG_CURRENT_DESKTOP   = 'KDE'BUILD_URL = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/5/'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'BUILD_NUMBER  = '5'JOB_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/'JOB_NAME  = 'Plasma plasma-vault kf5-qt5 FreeBSDQt5.10'HUDSON_HOME   = '/home/production/data'BLOCKSIZE = 'K'NODE_LABELS   = 'FreeBSD Builder 1 FreeBSDQt5.10'MAIL  = '/var/mail/jenkins'BUILD_DISPLAY_NAME= '#5'OLDPWD= '/usr/home/jenkins'SHLVL = '1'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.10"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.46.0") -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.46.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.46.0") -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.46.0") -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.46.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.46.0") -- Found KF5K

KDE CI: Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.10 - Build # 3 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.10/3/
 Project:
Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 18 May 2018 09:39:51 +
 Build duration:
1 min 53 sec and counting
   CONSOLE OUTPUT
  [...truncated 66.38 KB...]XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'JOB_NAME  = 'Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.10'STAGE_NAME= 'Configuring Build'BUILD_TAG = 'jenkins-Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.10-3'JENKINS_URL   = 'https://build.kde.org/'EXECUTOR_NUMBER   = '0'JAVA_HOME = '/usr/local/openjdk8-jre'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.10/3/display/redirect'NODE_LABELS   = 'FreeBSD Builder 1 FreeBSDQt5.10'OLDPWD= '/usr/home/jenkins'BLOCKSIZE = 'K'JOB_BASE_NAME = 'Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.10'BUILD_NUMBER  = '3'HOME  = '/home/jenkins'LANG  = 'en_US.UTF-8'SHLVL = '1'USER  = 'jenkins'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'BUILD_ID  = '3'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'MM_CHARSET= 'UTF-8'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.10/display/redirect'HUDSON_HOME   = '/home/production/data'_ = '/usr/local/bin/java'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.10/3/display/redirect?page=changes'MAIL  = '/var/mail/jenkins'SHELL = '/usr/local/bin/bash'TERM  = 'su'BUILD_URL = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.10/3/'XDG_CURRENT_DESKTOP   = 'KDE'LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'NODE_NAME = 'FreeBSD Builder 1'XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'WORKSPACE = '/usr/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.10'BUILD_DISPLAY_NAME= '#3'PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'JOB_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.10/'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'HUDSON_URL= 'https://build.kde.org/'QT_SELECT = 'qt5'PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.10"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.46.0") -- Found KF5DocTools: /usr/home/jenkins/install-prefix/lib/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.46.0") -- Found KF5IconThemes: /usr/home/jenkins/install-prefix/lib/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.46.0") -- Found KF5Init: /usr/home/jenkins/install-prefix/lib/cmake/KF5Init/KF5InitConfig.cmake (found version "5.46.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.46.0") -- Found KF5KCMUtils: /usr/home/jenkins/install-prefix/lib/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version "5.46.0") -- Found KF5KIO: /usr/

KDE CI: Plasma kde-cli-tools kf5-qt5 SUSEQt5.10 - Build # 3 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.10/3/
 Project:
Plasma kde-cli-tools kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 18 May 2018 09:39:51 +
 Build duration:
1 min 25 sec and counting
   CONSOLE OUTPUT
  [...truncated 89.35 KB...]BUILD_NUMBER  = '3'MORE  = '-sl'WORKSPACE = '/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 SUSEQt5.10'PWD   = '/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 SUSEQt5.10'HUDSON_URL= 'https://build.kde.org/'HOME  = '/home/jenkins/'NODE_NAME = 'Docker Swarm-2bc289a7ae29'HOST  = '2bc289a7ae29'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JOB_NAME  = 'Plasma kde-cli-tools kf5-qt5 SUSEQt5.10'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.10/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.10/3/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.10/'BUILD_DISPLAY_NAME= '#3'XCURSOR_THEME = 'DMZ'SHLVL = '3'BUILD_TAG = 'jenkins-Plasma kde-cli-tools kf5-qt5 SUSEQt5.10-3'NODE_LABELS   = 'Docker Swarm-2bc289a7ae29 SUSEQt5.10'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma kde-cli-tools kf5-qt5 SUSEQt5.10"-- The C compiler identification is GNU 7.3.1-- The CXX compiler identification is GNU 7.3.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.47.0") -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.47.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.47.0") -- Found KF5Init: /home/jenkins/install-prefix/lib64/cmake/KF5Init/KF5InitConfig.cmake (found version "5.47.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.47.0") -- Found KF5KCMUtils: /home/jenkins/install-prefix/lib64/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version "5.47.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.47.0") -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Serv

D12957: Show focus rect when CheckBox or RadioButton are focused

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This was missing from the QQC1 desktop style.

TEST PLAN
  Pretty much copy-paste and adjusted to new way of using `padding` for labels
  F5855386: Screenshot_20180518_104351.png 

  F5855388: Screenshot_20180518_104405.png 


REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D12957

AFFECTED FILES
  org.kde.desktop/CheckBox.qml
  org.kde.desktop/RadioButton.qml
  org.kde.desktop/private/FocusRect.qml

To: broulik, #plasma, #vdg, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12956: Fix Workspace KCM translation domain name

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:00ec9a991525: Fix Workspace KCM translation domain name 
(authored by romangg).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12956?vs=34415&id=34416

REVISION DETAIL
  https://phabricator.kde.org/D12956

AFFECTED FILES
  kcms/workspaceoptions/CMakeLists.txt
  kcms/workspaceoptions/Messages.sh

To: romangg, #plasma, ltoscano, yurchor
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12936: Rewrite workspace KCM in QtQuick

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> ltoscano wrote in Messages.sh:2
> Because they did not ask :)
> But in most cases the renamed KCMs kept the old name, and that's fine too.

Jeez, I won't say who these people were (Night Color KCM...).

Ok, I created a patch in D12956 . Pls 
quickly ack.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12936

To: furkantokac, romangg, ngraham, #plasma
Cc: ltoscano, yurchor, zzag, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12956: Fix Workspace KCM translation domain name

[Roman Gilg]

romangg created this revision.
romangg added reviewers: Plasma, ltoscano, yurchor.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  TRANSLATION_DOMAIN and value in Messages.sh need to be the same.
  Use the new name kcm5_workspace for consistency.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixKcmWorkspaceTranslationDomain

REVISION DETAIL
  https://phabricator.kde.org/D12956

AFFECTED FILES
  kcms/workspaceoptions/CMakeLists.txt
  kcms/workspaceoptions/Messages.sh

To: romangg, #plasma, ltoscano, yurchor
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12936: Rewrite workspace KCM in QtQuick

[Luigi Toscano]

ltoscano added inline comments.

INLINE COMMENTS

> romangg wrote in Messages.sh:2
> Ok, I will upload a diff shortly in order to change it here and in the 
> TANSLATION_DOMAIN to `kcm5_workspace`. I was just a bit unsure about the `5` 
> in the name, because other QML rewrites of KCMs I saw didn't have it in their 
> TRANSLATION_DOMAIN/Messages.sh.

Because they did not ask :)
But in most cases the renamed KCMs kept the old name, and that's fine too.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12936

To: furkantokac, romangg, ngraham, #plasma
Cc: ltoscano, yurchor, zzag, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12936: Rewrite workspace KCM in QtQuick

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> ltoscano wrote in Messages.sh:2
> Either the old name, or kcm5_, and it should be the same as 
> TRANSLATION_DOMAIN.

Ok, I will upload a diff shortly in order to change it here and in the 
TANSLATION_DOMAIN to `kcm5_workspace`. I was just a bit unsure about the `5` in 
the name, because other QML rewrites of KCMs I saw didn't have it in their 
TRANSLATION_DOMAIN/Messages.sh.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12936

To: furkantokac, romangg, ngraham, #plasma
Cc: ltoscano, yurchor, zzag, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12936: Rewrite workspace KCM in QtQuick

[Luigi Toscano]

ltoscano added inline comments.

INLINE COMMENTS

> romangg wrote in Messages.sh:2
> Change this line as follows?
> 
>   $XGETTEXT `find . -name "*.cpp" -o -name "*.qml"` -o 
> $podir/kcm_workspace.pot

Either the old name, or kcm5_, and it should be the same as 
TRANSLATION_DOMAIN.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12936

To: furkantokac, romangg, ngraham, #plasma
Cc: ltoscano, yurchor, zzag, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12936: Rewrite workspace KCM in QtQuick

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> Messages.sh:2
>  #! /usr/bin/env bash
> -$EXTRACTRC *.ui >> rc.cpp
> -$XGETTEXT *.cpp -o $podir/kcmworkspaceoptions.pot
> +$XGETTEXT `find . -name "*.cpp" -o -name "*.qml"` -o 
> $podir/kcm_workspaceoptions.pot

Change this line as follows?

  $XGETTEXT `find . -name "*.cpp" -o -name "*.qml"` -o $podir/kcm_workspace.pot

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12936

To: furkantokac, romangg, ngraham, #plasma
Cc: ltoscano, yurchor, zzag, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12936: Rewrite workspace KCM in QtQuick

[Luigi Toscano]

ltoscano added inline comments.

INLINE COMMENTS

> romangg wrote in workspaceoptions.cpp:34
> So do we need to change this here, in the CMake file, or can the translation 
> catalog be renamed (or a new one created) with the name `kcm_workspace` to 
> make the naming consistent?
> 
> Before in this KCM we used `kcm_workspaceoptions`, `workspaceoptions` and 
> `kcmworkspaceoptions` at different places. I want to use `kcm_workspace` only 
> now everywhere.

Either you keep the old name, or you change it to kcm5_ (which may help 
avoiding headaches in future). The values in TRANSLATION_DOMAIN and Messages.sh 
should be consistent.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12936

To: furkantokac, romangg, ngraham, #plasma
Cc: ltoscano, yurchor, zzag, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12936: Rewrite workspace KCM in QtQuick

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> ltoscano wrote in workspaceoptions.cpp:34
> Iirc that's unrelated. The catalog name is not set by this call.

So do we need to change this here, in the CMake file, or can the translation 
catalog be renamed (or a new one created) with the name `kcm_workspace` to make 
the naming consistent?

Before in this KCM we used `kcm_workspaceoptions`, `workspaceoptions` and 
`kcmworkspaceoptions` at different places. I want to use `kcm_workspace` only 
now everywhere.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12936

To: furkantokac, romangg, ngraham, #plasma
Cc: ltoscano, yurchor, zzag, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12936: Rewrite workspace KCM in QtQuick

[Luigi Toscano]

ltoscano added inline comments.

INLINE COMMENTS

> yurchor wrote in workspaceoptions.cpp:34
> This might not work with translations as the translation catalog is named 
> "kcm_workspaceoptions".

Iirc that's unrelated. The catalog name is not set by this call.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12936

To: furkantokac, romangg, ngraham, #plasma
Cc: ltoscano, yurchor, zzag, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart