KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.10 - Build # 126 - Failure!

2018-08-07 Thread CI System
nknown property type for key "X-Plasma-MainScript" -> falling back to stringQDEBUG : VirtualDesktopTest::testNetCurrentDesktop() kf5.kcoreaddons.desktopparser: Unknown property type for key "X-KWin-Config-TranslationDomain" -> falling back to stringQDEBUG : VirtualDesktopTest::testNetCurrentDesktop() kf5.kcoreaddons.desktopparser: Unknown property type for key "X-Plasma-API" -> falling back to stringQDEBUG : VirtualDesktopTest::testNetCurrentDesktop() kf5.kcoreaddons.desktopparser: Unknown property type for key "X-Plasma-MainScript" -> falling back to stringQDEBUG : VirtualDesktopTest::testNetCurrentDesktop() kf5.kcoreaddons.desktopparser: Unknown property type for key "X-Plasma-API" -> falling back to stringQDEBUG : VirtualDesktopTest::testNetCurrentDesktop() kf5.kcoreaddons.desktopparser: Unknown property type for key "X-Plasma-MainScript" -> falling back to stringQDEBUG : VirtualDesktopTest::testNetCurrentDesktop() kf5.kcoreaddons.desktopparser: Unknown property type for key "X-KWin-Config-TranslationDomain" -> falling back to stringQDEBUG : VirtualDesktopTest::testNetCurrentDesktop() kf5.kcoreaddons.desktopparser: Unknown property type for key "X-KDE-ParentApp" -> falling back to stringQDEBUG : VirtualDesktopTest::testNetCurrentDesktop() kf5.kcoreaddons.desktopparser: Unknown property type for key "X-Plasma-API" -> falling back to stringQDEBUG : VirtualDesktopTest::testNetCurrentDesktop() kf5.kcoreaddons.desktopparser: Unknown property type for key "X-Plasma-MainScript" -> falling back to stringQDEBUG : VirtualDesktopTest::testNetCurrentDesktop() kf5.kcoreaddons.desktopparser: Unknown property type for key "X-KWin-Video-Url" -> falling back to stringQDEBUG : VirtualDesktopTest::testNetCurrentDesktop() kf5.kcoreaddons.desktopparser: Unknown property type for key "X-Plasma-API" -> falling back to stringQDEBUG : VirtualDesktopTest::testNetCurrentDesktop() kf5.kcoreaddons.desktopparser: Unknown property type for key "X-Plasma-MainScript" -> falling back to stringQDEBUG : VirtualDesktopTest::testNetCurrentDesktop() kf5.kpackage: kpluginindex: Not cached "/usr/share/kwin/effects"QDEBUG : VirtualDesktopTest::testNetCurrentDesktop() kf5.kpackage: kpluginindex: Not cached "/usr/local/share/kwin/effects"QFATAL : VirtualDesktopTest::testNetCurrentDesktop() Test function timed outFAIL!  : VirtualDesktopTest::testNetCurrentDesktop() Received a fatal error.   Loc: [Unknown file(0)]Totals: 1 passed, 1 failed, 0 skipped, 0 blacklisted, 300367ms* Finished testing of VirtualDesktopTest *Start  85: kwin-testShellClientRulesTraceback (most recent call last):  File "ci-tooling/helpers/run-tests.py", line 154, in junitOutput = BuildSystem.CMake.convertCTestResultsToJUnit( buildLocation )  File "/usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.10/ci-tooling/helpers/helperslib/BuildSystem.py", line 126, in convertCTestResultsToJUnitwith open(filename , 'r', encoding='UTF-8') as xmlFile:FileNotFoundError: [Errno 2] No such file or directory: '/usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.10/build/Testing/20180807-2022/Test.xml'[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

Re: KDE CI: Dependency Build Extragear kf5-qt5 SUSEQt5.9 - Build # 121 - Still Failing!

2018-08-07 Thread Ben Cooksley
On Thu, Aug 2, 2018 at 6:10 AM, Ben Cooksley  wrote:

> Hi folks,
>

Hi all,


>
> Looks like there has been a regression in libkscreen, as can be seen below.
>

This now seems to have been fixed, but the failure point has now moved into
KWin.
Please see
https://build.kde.org/job/Dependency%20Build%20Extragear%20kf5-qt5%20SUSEQt5.9/lastFailedBuild/console


If someone could fix that it would be appreciated.

Please note that as parts of Extragear (which depend on Qt 5.9 as their
minimum) depend on parts of Plasma it's still a requirement that Plasma is
buildable with Qt 5.9.
The components in Extragear which create these dependencies are Mycroft,
Apper, KDevelop and Plasma's own SDK.


> Can someone please take a look?
>
> Thanks,
> Ben
>

Cheers,
Ben


>
> -- Forwarded message --
> From: CI System 
> Date: Thu, Aug 2, 2018 at 1:00 AM
> Subject: KDE CI: Dependency Build Extragear kf5-qt5 SUSEQt5.9 - Build #
> 121 - Still Failing!
> To: bcooks...@kde.org
>
>
> *BUILD FAILURE*
> Build URL https://build.kde.org/job/Dependency%20Build%20Extragear%
> 20kf5-qt5%20SUSEQt5.9/121/
> Project: Dependency Build Extragear kf5-qt5 SUSEQt5.9
> Date of build: Wed, 01 Aug 2018 10:01:53 +
> Build duration: 2 hr 58 min and counting
> * CONSOLE OUTPUT *
> [...truncated 62.14 MB...]
> [ 37%] Linking CXX shared module ../../bin/kf5/kscreen/KSC_QScreen.so
> [ 37%] Built target KSC_QScreen
> Scanning dependencies of target KSC_KWayland
> [ 37%] Building CXX object backends/kwayland/CMakeFiles/K
> SC_KWayland.dir/waylandbackend.cpp.o
> [ 38%] Building CXX object backends/kwayland/CMakeFiles/K
> SC_KWayland.dir/waylandconfig.cpp.o
> [ 38%] Building CXX object backends/kwayland/CMakeFiles/K
> SC_KWayland.dir/waylandoutput.cpp.o
> [ 39%] Building CXX object backends/kwayland/CMakeFiles/K
> SC_KWayland.dir/waylandscreen.cpp.o
> [ 40%] Building CXX object backends/kwayland/CMakeFiles/K
> SC_KWayland.dir/__/utils.cpp.o
> [ 40%] Building CXX object backends/kwayland/CMakeFiles/K
> SC_KWayland.dir/KSC_KWayland_autogen/mocs_compilation.cpp.o
> [ 41%] Linking CXX shared module ../../bin/kf5/kscreen/KSC_KWayland.so
> [ 41%] Built target KSC_KWayland
> Scanning dependencies of target KSC_XRandR
> [ 42%] Building CXX object backends/xrandr/CMakeFiles/KSC
> _XRandR.dir/xrandr.cpp.o
> [ 42%] Building CXX object backends/xrandr/CMakeFiles/KSC
> _XRandR.dir/xrandrconfig.cpp.o
> [ 43%] Building CXX object backends/xrandr/CMakeFiles/KSC
> _XRandR.dir/xrandrcrtc.cpp.o
> [ 43%] Building CXX object backends/xrandr/CMakeFiles/KSC
> _XRandR.dir/xrandroutput.cpp.o
> [ 44%] Building CXX object backends/xrandr/CMakeFiles/KSC
> _XRandR.dir/xrandrmode.cpp.o
> [ 44%] Building CXX object backends/xrandr/CMakeFiles/KSC
> _XRandR.dir/xrandrscreen.cpp.o
> [ 45%] Building CXX object backends/xrandr/CMakeFiles/KSC
> _XRandR.dir/__/xcbwrapper.cpp.o
> [ 45%] Building CXX object backends/xrandr/CMakeFiles/KSC
> _XRandR.dir/__/xcbeventlistener.cpp.o
> [ 46%] Building CXX object backends/xrandr/CMakeFiles/KSC
> _XRandR.dir/__/utils.cpp.o
> [ 46%] Building CXX object backends/xrandr/CMakeFiles/KSC
> _XRandR.dir/KSC_XRandR_autogen/mocs_compilation.cpp.o
> [ 47%] Linking CXX shared module ../../bin/kf5/kscreen/KSC_XRandR.so
> [ 47%] Built target KSC_XRandR
> Scanning dependencies of target KSC_XRandR11
> [ 48%] Building CXX object backends/xrandr1.1/CMakeFiles/
> KSC_XRandR11.dir/xrandr11.cpp.o
> [ 48%] Building CXX object backends/xrandr1.1/CMakeFiles/
> KSC_XRandR11.dir/__/xcbeventlistener.cpp.o
> [ 49%] Building CXX object backends/xrandr1.1/CMakeFiles/
> KSC_XRandR11.dir/__/xcbwrapper.cpp.o
> [ 49%] Building CXX object backends/xrandr1.1/CMakeFiles/
> KSC_XRandR11.dir/KSC_XRandR11_autogen/mocs_compilation.cpp.o
> [ 50%] Linking CXX shared module ../../bin/kf5/kscreen/KSC_XRandR11.so
> [ 50%] Built target KSC_XRandR11
> [ 50%] Generating fakebackendinterface.cpp, fakebackendinterface.h
> [ 51%] Generating fakebackendinterface.moc
> Scanning dependencies of target testbackendloader
> [ 52%] Building CXX object autotests/CMakeFiles/testbacke
> ndloader.dir/testbackendloader.cpp.o
> [ 52%] Building CXX object autotests/CMakeFiles/testbacke
> ndloader.dir/fakebackendinterface.cpp.o
> [ 53%] Building CXX object autotests/CMakeFiles/testbacke
> ndloader.dir/testbackendloader_autogen/mocs_compilation.cpp.o
> [ 53%] Linking CXX executable ../bin/testbackendloader
> [ 53%] Built target testbackendloader
> Scanning dependencies of target testscreenconfig
> [ 54%] Building CXX object autotests/CMakeFiles/testscree
> nconfig.dir/testscreenconfig.cpp.o
> [ 55%] Building CXX object autotests/CMakeFiles/testscree
> nconfig.dir/fakebackendinterface.cpp.o
> [ 55%] Building CXX object autotests/CMakeFiles/testscree
> nconfig.dir/testscreenconfig_autogen/mocs_compilation.cpp.o
> [ 56%] Linking CXX executable ../bin/testscreenconfig
> [ 57%] Built target testscreenconfig
> Scanning dependencies of target testconfigserializer
> [ 57%] Building CXX object 

D14542: WIP: Basic KCM using new virtual desktops DBus interface

2018-08-07 Thread David Edmundson
davidedmundson added a comment.


  Edit. That unit test comment was intended for Marcos patch not this.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart


D14542: WIP: Basic KCM using new virtual desktops DBus interface

2018-08-07 Thread David Edmundson
davidedmundson added a comment.


  Also, I know this is a WIP, but so it's noted it's not going to get merged 
without some unit test of the new API and checking all current stuff passes.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart


D14542: WIP: Basic KCM using new virtual desktops DBus interface

2018-08-07 Thread David Edmundson
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> desktopsmodel.cpp:53
> +
> +bool connected = QDBusConnection::sessionBus().connect(
> +s_serviceName,

We can just generate the interface from the XML and use the generated class 
instead of using low level classes.

> desktopsmodel.cpp:361
> +
> +const QDBusArgument >>(const QDBusArgument , 
> KWin::DBusDesktopDataVector )
> +{

All this is already in the kwin repo for Marco's export. We should share code 
here even if it means including a C++ file from outside the kcmkwin dir.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart


D14673: Fix the Kirigami QRC static plugin generation

2018-08-07 Thread Marco Martin
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:867283d0c159: Fix the Kirigami QRC static plugin 
generation (authored by mart).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14673?vs=39259=39260

REVISION DETAIL
  https://phabricator.kde.org/D14673

AFFECTED FILES
  kirigami.qrc
  kirigami.qrc.in
  src/CMakeLists.txt

To: mart, lepagevalleeemmanuel
Cc: bearsh, plasma-devel, apol, davidedmundson, mart, hein


D14673: Fix the Kirigami QRC static plugin generation

2018-08-07 Thread Marco Martin
mart updated this revision to Diff 39259.
mart added a comment.


  - kirigami.qrc.in for cmake, kirigami.qrc for qmake

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14673?vs=39256=39259

BRANCH
  arcpatch-D14673

REVISION DETAIL
  https://phabricator.kde.org/D14673

AFFECTED FILES
  kirigami.qrc
  kirigami.qrc.in
  src/CMakeLists.txt

To: mart, lepagevalleeemmanuel
Cc: bearsh, plasma-devel, apol, davidedmundson, mart, hein


D14673: Fix the Kirigami QRC static plugin generation

2018-08-07 Thread Emmanuel Lepage Vallee
lepagevalleeemmanuel added a comment.


  In D14673#304936 , @bearsh wrote:
  
  > how is this supposed to work in a qmake based project?
  
  
  As of right now I had forgotten it had too. It will probably need another qrc 
and solution... Currently both CMake and qmake versions are broken because the 
files are missing, so it cannot be deployed. But right, qmake needs a solution 
too

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D14673

To: lepagevalleeemmanuel
Cc: bearsh, plasma-devel, apol, davidedmundson, mart, hein


D14673: Fix the Kirigami QRC static plugin generation

2018-08-07 Thread Martin
bearsh added a comment.


  how is this supposed to work in a qmake based project?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D14673

To: lepagevalleeemmanuel
Cc: bearsh, plasma-devel, apol, davidedmundson, mart, hein


D14673: Fix the Kirigami QRC static plugin generation

2018-08-07 Thread Emmanuel Lepage Vallee
lepagevalleeemmanuel created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
lepagevalleeemmanuel requested review of this revision.

REVISION SUMMARY
  This patch moves the qrc from "raw" to generated using CMake configure file 
and add 4 missing files.
  
  Since some months, a few files were missing from the QRC. It worked fine on 
system where Kirigami is installed (and recent) because it would load them from 
the file system instead of static resources. However it didn't work so well on 
systems where an older version (or no version) are installed.
  
  Because ActionMenuItem is has different versions depending on the Qt version, 
the qrc had to be dynamic. The use of absolute path was also necessary because 
`rcc` could no longer find the files because it uses the relative path from the 
`.qrc` absolute path.

TEST PLAN
  Not much honestly, it works on my system, other might want to double check.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D14673

AFFECTED FILES
  kirigami.qrc
  src/CMakeLists.txt

To: lepagevalleeemmanuel
Cc: plasma-devel, apol, davidedmundson, mart, hein


D14672: [plasma-changeicons] Call sync() after writing

2018-08-07 Thread Kai Uwe Broulik
broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Plasma-integration's KHintsSettings keeps kdeglobals open, so we need to 
explicitly `sync()` before we go through the process of telling everything it's 
changed

TEST PLAN
  Changing icons in the KCM affects everything immediately now

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14672

AFFECTED FILES
  kcms/icons/changeicons.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D14671: [Kicker] Use document-properties icon for "Properties" context menu entry

2018-08-07 Thread Kai Uwe Broulik
broulik created this revision.
broulik added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Makes it consistent with other places where such an entry exists, such as 
Dolphin's context menu

TEST PLAN
  Now have the correct icon for the entry. Invoking it still works fine.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14671

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D14670: Fix an undefined reference error with static mode + LTO

2018-08-07 Thread Emmanuel Lepage Vallee
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:e1620cba164b: Fix the build in LTO static mode (authored 
by lepagevalleeemmanuel).
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D14670?vs=39250=39251#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14670?vs=39250=39251

REVISION DETAIL
  https://phabricator.kde.org/D14670

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt

To: lepagevalleeemmanuel, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein


D14562: Introduce Theme.smallestFont

2018-08-07 Thread Alexander Volkov
volkov added a comment.


  Why add it to qml-base theme implementations?
  Aren't they obsolete?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D14562

To: volkov, #kirigami, mart
Cc: mart, plasma-devel, apol, davidedmundson, hein


D14667: Fix a text label in the password dialog

2018-08-07 Thread Jan Grulich
jgrulich closed this revision.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D14667

To: underwit, #plasma, jgrulich
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D14562: Introduce Theme.smallestFont

2018-08-07 Thread Alexander Volkov
volkov added inline comments.

INLINE COMMENTS

> volkov wrote in kirigamiplugin.cpp:173
> So, should it be registered for both versions 2.2 and 2.6?
> I tried to use revisions, but it looks like they don't work for properties of 
> attached property objects:
> https://doc.qt.io/qt-5/qtqml-cppintegration-definetypes.html#type-revisions-and-versions
> One can import kirigami 2.2 and use smallestFont.

https://bugreports.qt.io/browse/QTBUG-40043

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D14562

To: volkov, #kirigami, mart
Cc: mart, plasma-devel, apol, davidedmundson, hein


D14667: Fix a text label in the password dialog

2018-08-07 Thread Ivan Razzhivin
underwit added a comment.


  no commit access

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D14667

To: underwit, #plasma, jgrulich
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D14647: [Kicker] Look up relative entryPaths

2018-08-07 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2ce76bc5ade2: [Kicker] Look up relative entryPaths 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14647?vs=39184=39246

REVISION DETAIL
  https://phabricator.kde.org/D14647

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/kicker/plugin/actionlist.h
  applets/kicker/plugin/appentry.cpp
  applets/kicker/plugin/runnermatchesmodel.cpp

To: broulik, #plasma, dfaure, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D14651: [Notifications Engine] Guard "this"

2018-08-07 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7a98c7d5e58a: [Notifications Engine] Guard 
this (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14651?vs=39195=39245

REVISION DETAIL
  https://phabricator.kde.org/D14651

AFFECTED FILES
  dataengines/notifications/notificationsengine.cpp

To: broulik, #plasma, davidedmundson, jgrulich
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D14667: Fix a text label in the password dialog

2018-08-07 Thread Ivan Razzhivin
underwit created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
underwit requested review of this revision.

REVISION SUMMARY
  With some system settings, this effect appears.
  Part of the text label on the password dialog box is hidden.
  F6179147: wifi-connect.png 

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D14667

AFFECTED FILES
  plasma-nm/kded/passworddialog.ui

To: underwit
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart