D14806: [AppStream Runner] Reduce verbosity of log output

[Stefan Brüns]

bruns updated this revision to Diff 41126.
bruns added a comment.


  rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14806?vs=40774&id=41126

BRANCH
  arcpatch-D14806

REVISION DETAIL
  https://phabricator.kde.org/D14806

AFFECTED FILES
  runners/appstream/appstreamrunner.cpp

To: bruns, #plasma, apol, ngraham
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D15306: BookmarksRunner: Avoid multiple connections of identical signal

[Stefan Brüns]

bruns updated this revision to Diff 41125.
bruns added a comment.


  add context object to disconnect old instance automatically

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15306?vs=41080&id=41125

BRANCH
  T9626

REVISION DETAIL
  https://phabricator.kde.org/D15306

AFFECTED FILES
  runners/bookmarks/bookmarksrunner.cpp

To: bruns, #plasma
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15305: KRunner: remove no longer existant and unused column from SQL query

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cb99ab735c81: KRunner: remove no longer existant and 
unused column from SQL query (authored by bruns).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15305?vs=41079&id=41124

REVISION DETAIL
  https://phabricator.kde.org/D15305

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: bruns, #plasma, davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15306: BookmarksRunner: Avoid multiple connections of identical signal

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> bruns wrote in bookmarksrunner.cpp:66
> yes, after readding the `dynamic_cast`, m_browser is a non-QObject 
> interface class.

The only syntax which works is

  connect(this, &Plasma::AbstractRunner:teardown,
  dynamic_cast(m_browser), [this] () { m_browser->teardown(); 
});

The context object has to be a QObject* (or derived).
&Browser::teardown is not a pointer to a QObject member function, thus we need 
a functor.

The other approach would be to make Browser a QObject derived class.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15306

To: bruns, #plasma
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15315: Set gtk-modules to auto-load appmenu-gtk-module

[Kai Uwe Broulik]

broulik updated this revision to Diff 41115.
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added a comment.


  - Support GTK2 too

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15315?vs=41109&id=41115

REVISION DETAIL
  https://phabricator.kde.org/D15315

AFFECTED FILES
  gmenu-dbusmenu-proxy/CMakeLists.txt
  gmenu-dbusmenu-proxy/menuproxy.cpp
  gmenu-dbusmenu-proxy/menuproxy.h

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15315: Set gtk-modules to auto-load appmenu-gtk-module

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Makes it work out of the box at least for GTK 3 applications

TEST PLAN
  Tested Pluma, now has global menu
  When module isn't installed, prints a warning on console, shouldn't be too bad
  
  Unfortunately kde-gtk-config rewrites the `~/.gtkrc-2.0` whenever it changes 
its settings, so this needs some more elaborate change to support (e.g. a 
`KDirWatch` that adds it back or something like this?)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15315

AFFECTED FILES
  gmenu-dbusmenu-proxy/menuproxy.cpp
  gmenu-dbusmenu-proxy/menuproxy.h

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15306: BookmarksRunner: Avoid multiple connections of identical signal

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> broulik wrote in bookmarksrunner.cpp:66
> Ah, yeah, right, and then you could connect direcftly:
> 
>   connect(this, &Plasma::AbstractRunner:teardown, m_browser, 
> &Browser::teardown);

yes, after readding the `dynamic_cast`, m_browser is a non-QObject 
interface class.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15306

To: bruns, #plasma
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15306: BookmarksRunner: Avoid multiple connections of identical signal

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> bruns wrote in bookmarksrunner.cpp:66
> Hm, just found that auto-disconnect (see @davidedmundson s comment) only 
> works if you provide a context. The context has to be `m_browser`  here.

Ah, yeah, right, and then you could connect direcftly:

  connect(this, &Plasma::AbstractRunner:teardown, m_browser, 
&Browser::teardown);

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15306

To: bruns, #plasma
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15306: BookmarksRunner: Avoid multiple connections of identical signal

[Stefan Brüns]

bruns planned changes to this revision.
bruns added inline comments.

INLINE COMMENTS

> broulik wrote in bookmarksrunner.cpp:66
> No, four-argument connect:
> 
>   connect(this, &..., this, 
> 
> Though you just connect from `this` anyway, so I guess this isn't needed

Hm, just found that auto-disconnect (see @davidedmundson s comment) only works 
if you provide a context. The context has to be `m_browser`  here.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15306

To: bruns, #plasma
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15305: KRunner: remove no longer existant and unused column from SQL query

[Kai Uwe Broulik]

broulik added a comment.


  Might have confused it with D10610 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15305

To: bruns, #plasma, davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15305: KRunner: remove no longer existant and unused column from SQL query

[Stefan Brüns]

bruns added a comment.


  In D15305#321346 , @broulik wrote:
  
  > Should this go into 5.12 branch as it's quite a common crasher we have 
there?
  
  
  Crash no, malfunction probably.
  
  The schema depends on the first used FF version, FF removes old columns only 
after some time.
  
  As the change is trivial, applying it to older branches  is no big deal. How 
about 5.8? Do we expect to see FF 60 ESR on 5.8 LTS?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15305

To: bruns, #plasma, davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15305: KRunner: remove no longer existant and unused column from SQL query

[Kai Uwe Broulik]

broulik added a comment.


  Should this go into 5.12 branch as it's quite a common crasher we have there?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15305

To: bruns, #plasma, davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15306: BookmarksRunner: Avoid multiple connections of identical signal

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> bruns wrote in bookmarksrunner.cpp:66
> you mean `this->mbrowser->teardown()`?

No, four-argument connect:

  connect(this, &..., this, 

Though you just connect from `this` anyway, so I guess this isn't needed

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15306

To: bruns, #plasma
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15306: BookmarksRunner: Avoid multiple connections of identical signal

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> davidedmundson wrote in bookmarksrunner.cpp:65
> do we not also need a disconnect on m_browser?

Browser is just an interface class, but the subclasses also derive from QObject 
and should auto-disconnect, AFAIK.

> broulik wrote in bookmarksrunner.cpp:66
> Please provide `this` as context.

you mean `this->mbrowser->teardown()`?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15306

To: bruns, #plasma
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-framework kf5-qt5 FreeBSDQt5.11 - Build # 12 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20FreeBSDQt5.11/12/
 Project:
Plasma plasma-framework kf5-qt5 FreeBSDQt5.11
 Date of build:
Thu, 06 Sep 2018 12:54:12 +
 Build duration:
2 min 3 sec and counting
   CONSOLE OUTPUT
  [...truncated 1.46 MB...]-- Set runtime path of "/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert//home/jenkins/install-prefix/lib/qml/org/kde/plasma/platformcomponents/libplatformcomponentsplugin.so" to "/home/jenkins/install-prefix/lib:/usr/local/lib/qt5:/usr/home/jenkins/install-prefix/lib:/usr/local/lib"-- Installing: /usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert/home/jenkins/install-prefix/lib/qml/org/kde/plasma/platformcomponents/qmldir-- Installing: /usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert/home/jenkins/install-prefix/lib/qml/org/kde/plasma/platformcomponents/plugins.qmltypes-- Installing: /usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert/home/jenkins/install-prefix/lib/qml/org/kde/plasma/calendar/libcalendarplugin.so-- Set runtime path of "/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert//home/jenkins/install-prefix/lib/qml/org/kde/plasma/calendar/libcalendarplugin.so" to "/home/jenkins/install-prefix/lib:/usr/local/lib/qt5:/usr/home/jenkins/install-prefix/lib:/usr/local/lib"-- Up-to-date: /usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert/home/jenkins/install-prefix/lib/qml/org/kde/plasma/calendar-- Installing: /usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert/home/jenkins/install-prefix/lib/qml/org/kde/plasma/calendar/MonthMenu.qml-- Installing: /usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert/home/jenkins/install-prefix/lib/qml/org/kde/plasma/calendar/DayDelegate.qml-- Installing: /usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert/home/jenkins/install-prefix/lib/qml/org/kde/plasma/calendar/qmldir-- Installing: /usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert/home/jenkins/install-prefix/lib/qml/org/kde/plasma/calendar/DaysCalendar.qml-- Installing: /usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert/home/jenkins/install-prefix/lib/qml/org/kde/plasma/calendar/CalendarToolbar.qml-- Installing: /usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert/home/jenkins/install-prefix/lib/qml/org/kde/plasma/calendar/MonthView.qml-- Installing: /usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert/home/jenkins/install-prefix/lib/qml/org/kde/plasma/calendar/plugins.qmltypes-- Installing: /usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert/home/jenkins/install-prefix/bin/plasmapkg2-- Set runtime path of "/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert//home/jenkins/install-prefix/bin/plasmapkg2" to "/home/jenkins/install-prefix/lib:/usr/local/lib/qt5"-- Installing: /usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert/home/jenkins/install-prefix/lib/plugins/plasma/scriptengines/plasma_appletscript_declarative.so-- Set runtime path of "/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert//home/jenkins/install-prefix/lib/plugins/plasma/scriptengines/plasma_appletscript_declarative.so" to "/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/lib:/usr/local/lib/qt5:/usr/local/lib"-- Installing: /usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert/home/jenkins/install-prefix/share/kservices5/plasma-scriptengine-applet-declarative.desktop-- Installing: /usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert/home/jenkins/install-prefix/share/kservicetypes5/plasma-wallpaper.desktop-- Installing: /usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert/home/jenkins/install-prefix/lib/libKF5PlasmaQuick.so.5.50.0-- Installing: /usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert/home/jenkins/install-prefix/lib/libKF5PlasmaQuick.so.5-- Set runtime path of "/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert//home/jenkins/install-prefix/lib/libKF5PlasmaQuick.so.5.50.0" to "/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/lib:/usr/local/lib:/usr/local/lib/qt5"-- Installing: /usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.11/install-divert/home/jenkins/install-prefix/lib/libKF5PlasmaQuick.so-- Installing: /usr/home/jenkins/workspace/Plasma plasma-fra

D15165: port to PlasmaComponents3

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:51d863ce2438: port to PlasmaComponents3 (authored by 
mart).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15165?vs=40695&id=41101

REVISION DETAIL
  https://phabricator.kde.org/D15165

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: mart, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15201: Move logout-greeter into it's own subdir out of ksmserver

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:171
>  
> +
>  # This ensures pressing the eject button on a CD drive ejects the disc

Remove

> shutdowndlg.cpp:2
>  /*
> -ksmserver - the KDE session management server
> +LOGOUT_GREETER - the KDE session management server
>  

fix "session management server"
or just remove this line

> CMakeLists.txt:1
> +configure_file(config.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config.h)
> +

This file doesn't exist

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15201

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15202: Move kcheckrunning into startkde

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:88-96
> -set(kcheckrunning_SRCS
> -kcheckrunning.cpp)
> -
> -add_executable( kcheckrunning ${kcheckrunning_SRCS})
> -
> -target_link_libraries(kcheckrunning ${X11_LIBRARIES})
> -target_include_directories(kcheckrunning PRIVATE ${X11_X11_INCLUDE_PATH})

This stuff must go into a `startkde/kcheckrunning/CMakeLists.txt`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15202

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

[Simon Depiets]

sdepiets abandoned this revision.
sdepiets added a comment.


  In D15310#321238 , @davidedmundson 
wrote:
  
  > From the docs:
  >
  > By default, if CMAKE_MINIMUM_REQUIRED_VERSION is 3.1 or later, or if 
PKG_CONFIG_USE_CMAKE_PREFIX_PATH is set, the CMAKE_PREFIX_PATH, 
CMAKE_FRAMEWORK_PATH, and CMAKE_APPBUNDLE_PATH cache and environment variables 
will be added to pkg-config search path. The
  >
  > I'd be ok with bumping our cmake version / setting 
PKG_CONFIG_USE_CMAKE_PREFIX_PATH
  
  
  It looks much nicer indeed.
  
  Apologies for the commit.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D15310

To: sdepiets, lbeltrame, #plasma, cgiboudeaux
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15286: Improve arrow key navigation of Kicker search results

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1692ae244bc5: Improve arrow key navigation of Kicker 
search results (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15286?vs=41061&id=41095

REVISION DETAIL
  https://phabricator.kde.org/D15286

AFFECTED FILES
  applets/kicker/package/contents/ui/MenuRepresentation.qml
  applets/kicker/package/contents/ui/RunnerResultsList.qml

To: hein, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

[David Edmundson]

davidedmundson added a comment.


  From the docs:
  
  By default, if CMAKE_MINIMUM_REQUIRED_VERSION is 3.1 or later, or if 
PKG_CONFIG_USE_CMAKE_PREFIX_PATH is set, the CMAKE_PREFIX_PATH, 
CMAKE_FRAMEWORK_PATH, and CMAKE_APPBUNDLE_PATH cache and environment variables 
will be added to pkg-config search path. The
  
  I'd be ok with bumping our cmake version / setting 
PKG_CONFIG_USE_CMAKE_PREFIX_PATH

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D15310

To: sdepiets, lbeltrame, #plasma, cgiboudeaux
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D15310#321234 , @sdepiets wrote:
  
  > Checking that Qt5Core version is initialized
  
  
  Sorry, but the whole change makes no sense, a big -1.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D15310

To: sdepiets, lbeltrame, #plasma, cgiboudeaux
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

[Simon Depiets]

sdepiets updated this revision to Diff 41092.
sdepiets added a comment.


  Checking that Qt5Core version is initialized

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15310?vs=41087&id=41092

BRANCH
  cmake_qt5_default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15310

AFFECTED FILES
  cmake/modules/FindQt5PlatformSupport.cmake
  cmake/modules/FindQt5ThemeSupport.cmake

To: sdepiets, lbeltrame, #plasma, cgiboudeaux
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D15310#321232 , @sdepiets wrote:
  
  > In D15310#321216 , @cgiboudeaux 
wrote:
  >
  > > In D15310#321210 , 
@davidedmundson wrote:
  > >
  > > > I have this  in my dev setup
  > > >
  > > > PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig:/opt/kde5/lib64/pkgconfig
  > > >
  > > > If you had the equivalent, would you need this?
  > >
  > >
  > > Agreed, that's an issue with your environment not being set correctly.
  >
  >
  > It does work with PKG_CONFIG_PATH pointing to the custom Qt directory.
  >  However, if the PREFIX is set and works for the rest of the modules, it 
should be able to work without this additional configuration.
  
  
  you set QTDIR, CMAKE_PREFIX_PATH and a couple other environment variables to 
use custom builds, that's exactly the same reasoning. 
  If you don't want to set them, use system locations.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D15310

To: sdepiets, lbeltrame, #plasma, cgiboudeaux
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

[Simon Depiets]

sdepiets added a comment.


  In D15310#321216 , @cgiboudeaux 
wrote:
  
  > In D15310#321210 , 
@davidedmundson wrote:
  >
  > > I have this  in my dev setup
  > >
  > > PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig:/opt/kde5/lib64/pkgconfig
  > >
  > > If you had the equivalent, would you need this?
  >
  >
  > Agreed, that's an issue with your environment not being set correctly.
  
  
  It does work with PKG_CONFIG_PATH pointing to the custom Qt directory.
  However, if the PREFIX is set and works for the rest of the modules, it 
should be able to work without this additional configuration.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D15310

To: sdepiets, lbeltrame, #plasma, cgiboudeaux
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15162: [Folder View] Disable the actions themselves rather than just not adding them to the menu

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7590487788e9: [Folder View] Disable the actions 
themselves rather than just not adding them… (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15162?vs=40687&id=41091#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15162?vs=40687&id=41091

REVISION DETAIL
  https://phabricator.kde.org/D15162

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/plugins/folder/foldermodel.cpp

To: broulik, #plasma, davidedmundson, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15160: [Folder View] Honor editable_desktop_icons KIOSK restriction

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:74697d0c9072: [Folder View] Honor editable_desktop_icons 
KIOSK restriction (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15160?vs=40684&id=41090#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15160?vs=40684&id=41090

REVISION DETAIL
  https://phabricator.kde.org/D15160

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml
  containments/desktop/package/contents/ui/FolderViewLayer.qml
  containments/desktop/plugins/folder/viewpropertiesmenu.cpp
  containments/desktop/plugins/folder/viewpropertiesmenu.h

To: broulik, #plasma, davidedmundson, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.11 - Build # 17 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.11/17/
 Project:
Plasma plasma-workspace kf5-qt5 FreeBSDQt5.11
 Date of build:
Thu, 06 Sep 2018 08:23:55 +
 Build duration:
7 min 48 sec and counting

D15311: [Media Player] Change int to double for positions

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1bb02b98cfed: [Media Player] Change int to double for 
positions (authored by arsenarsen, committed by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15311?vs=41086&id=41088#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15311?vs=41086&id=41088

REVISION DETAIL
  https://phabricator.kde.org/D15311

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: arsenarsen, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.11 - Build # 20 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.11/20/
 Project:
Plasma plasma-workspace kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 06 Sep 2018 08:23:55 +
 Build duration:
4 min 8 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testdesktop
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report13%
(15/119)12%
(43/373)12%
(43/373)7%
(2204/32751)5%
(1161/22793)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.appmenu.lib0%
(0/2)0%
(0/2)0%
(0/120)0%
(0/70)applets.appmenu.plugin0%
(0/3)0%
(0/3)0%
(0/102)0%
(0/78)applets.calendar0%
(0/1)0%
(0/1)0%
(0/6)100%
(0/0)applets.digital-clock.plugin0%
(0/5)0%
(0/5)0%
(0/878)0%
(0/86)applets.icon0%
(0/1)0%
(0/1)0%
(0/181)0%
(0/118)applets.notifications.lib0%
(0/1)0%
(0/1)0%
(0/52)0%
(0/26)applets.notifications.plugin0%
(0/5)0%
(0/5)0%
(0/272)0%
(0/118)applets.systemtray0%
(0/1)0%
(0/1)0%
(0/263)0%
(0/269)applets.systemtray.container0%
(0/1)0%
(0/1)0%
(0/58)0%
(0/52)applets.systemtray.tests.statusnotifier0%
(0/3)0%
(0/3)0%
(0/183)0%
(0/40)appmenu0%
(0/7)0%
(0/7)0%
(0/133)0%
(0/50)components.keyboardlayout0%
(0/2)0%
(0/2)0%
(0/76)0%
(0/32)components.sessionsprivate0%
(0/3)0%
(0/3)0%
(0/132)0%
(0/108)components.shellprivate0%
(0/1)0%
(0/1)0%
(0/5)0%
(0/2)components.shellprivate.interactiveconsole0%
(0/2)0%
(0/2)0%
(0/349)0%
(0/126)components.shellprivate.widgetexplorer0%
(0/5)0%
(0/5)0%
(0/561)0%
(0/379)containmentactions.applauncher0%
(0/1)0%
(0/1)0%
(0/49)0%
(0/32)containmentactions.contextmenu0%
(0/1)0%

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D15310#321210 , @davidedmundson 
wrote:
  
  > I have this  in my dev setup
  >
  > PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig:/opt/kde5/lib64/pkgconfig
  >
  > If you had the equivalent, would you need this?
  
  
  Agreed, that's an issue with your environment not being set correctly.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D15310

To: sdepiets, lbeltrame, #plasma, cgiboudeaux
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> FindQt5PlatformSupport.cmake:72
> +PATH_SUFFIXES
> +QtPlatformSupport/${Qt5Core_VERSION}/
>  )

This CMake module doesn't know Qt5Core_VERSION, this only works for you because 
there's a find_package(Qt5 ...) call before looking for Qt5PlatformSupport

> FindQt5PlatformSupport.cmake:76
> +if (Qt5PlatformSupport_INCLUDE_DIR)
> + set(Qt5PlatformSupport_VERSION ${Qt5Core_VERSION})
> +else()

Same here

> FindQt5ThemeSupport.cmake:73
> +PATH_SUFFIXES
> +QtThemeSupport/${Qt5Core_VERSION}/
>  )

Same here

> FindQt5ThemeSupport.cmake:77
> +if (Qt5ThemeSupport_INCLUDE_DIR)
> + set(Qt5ThemeSupport_VERSION ${Qt5Core_VERSION})
> +else()

Same here

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D15310

To: sdepiets, lbeltrame, #plasma, cgiboudeaux
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

[David Edmundson]

davidedmundson added a comment.


  I have this  in my dev setup
  
  PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig:/opt/kde5/lib64/pkgconfig
  
  If you had the equivalent, would you need this?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D15310

To: sdepiets, lbeltrame, #plasma, cgiboudeaux
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15311: [Media Player] Change int to double for positions

[Arsen Arsen]

arsenarsen added a comment.


  Go ahead.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15311

To: arsenarsen, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15311: [Media Player] Change int to double for positions

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks! I will commit this on your behalf if you don't mind.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15311

To: arsenarsen, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15311: [Media Player] Change int to double for positions

[Arsen Arsen]

arsenarsen created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arsenarsen requested review of this revision.

REVISION SUMMARY
  In previous versions of Plasma, media player had an overflow bug in 
positions, leading to the player resetting to 00:00.
  This only affects files longer than around 33 minutes 20 seconds.
  
  BUG: 397591

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15311

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: arsenarsen
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

[Simon Depiets]

sdepiets created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sdepiets requested review of this revision.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  cmake_qt5_default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15310

AFFECTED FILES
  cmake/modules/FindQt5PlatformSupport.cmake
  cmake/modules/FindQt5ThemeSupport.cmake

To: sdepiets
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15304: [KCM] Port label-bearing controls to QQC2 to fix fractional scaling support

[David Edmundson]

davidedmundson added a comment.


  s/fix/work round/ 
  Please use the commit message from one of the other patches that does this.
  
  I repeatedly have to correct this meme spreading that QQC2 has any relevance 
to fractional scaling. It leads to other incorrect changes.
  
  The only relevance is the text renderType which could be either on either QQC 
versions.
  Our QQC2 desktop style happens to have a workaround.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15304

To: ngraham, #plasma, drosca
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15306: BookmarksRunner: Avoid multiple connections of identical signal

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> bookmarksrunner.cpp:65
> +if (m_browser != browser) {
> +m_browser = browser;
> +connect(this, &Plasma::AbstractRunner::teardown, [this]() { 
> m_browser->teardown(); });

do we not also need a disconnect on m_browser?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15306

To: bruns, #plasma
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15291: [Folder View] Compare UDS entry times directly instead of going through KFileItem

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2d008a5b931a: [Folder View] Compare UDS entry times 
directly instead of going through… (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15291?vs=41046&id=41085

REVISION DETAIL
  https://phabricator.kde.org/D15291

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart