D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

[Nathaniel Graham]

ngraham added a comment.


  In D15341#323715 , @smithjd wrote:
  
  > KRunner as a standalone application does much more than search for files. 
Therefore adding independent shortcut configurability isn't so hard to justify. 
Kicker/Kickoff and dolphin search text input shortcuts on the other hand are 
configurable globally already, and only perform a subset of what KRunner does.
  
  
  Can you explain why the fact that KRunner does more than the search fields in 
Kicker/Kickoff and Dolphin is a justification for allowing you to customize a 
small subset of the navigation shortcuts there, but not elsewhere? Help me 
understand where you're coming from. If you'd want to use [ctrl] + [e] and 
[ctrl] + [s]  (etc.) to navigate in KRunner, why wouldn't you want to use them 
elsewhere too? What's the difference?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15341

To: smithjd, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

[James Smith]

smithjd added a comment.


  In D15341#323704 , @ngraham wrote:
  
  > In D15341#323672 , @smithjd 
wrote:
  >
  > > Kicker/Kickoff and the dolphin search aren't full-fledged launchers like 
KRunner, only search fields for Baloo.
  >
  >
  >
  >
  > 1. Kicker/Kickoff actually are: they're full-fledged interfaces to KRunner, 
with the exception that they have a semi-hardcoded list of enabled runners.
  > 2. Not sure how that would make a difference anyway; the point is, if these 
navigation shortcuts are valuable for the KRunner input field, why wouldn't 
they be useful for every input field?
  
  
  KRunner as a standalone application does much more than search for files. 
Therefore adding independent shortcut configurability isn't so hard to justify. 
Kicker/Kickoff and dolphin search text input shortcuts on the other hand are 
configurable globally already, and only perform a subset of what KRunner does.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15341

To: smithjd, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

[Nathaniel Graham]

ngraham added a comment.


  In D15341#323672 , @smithjd wrote:
  
  > Kicker/Kickoff and the dolphin search aren't full-fledged launchers like 
KRunner, only search fields for Baloo.
  
  
  
  
  1. Kicker/Kickoff actually are: they're full-fledged interfaces to KRunner, 
with the exception that they have a semi-hardcoded list of enabled runners.
  2. Not sure how that would make a difference anyway; the point is, if these 
navigation shortcuts are valuable for the KRunner input field, why wouldn't 
they be useful for every input field?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15341

To: smithjd, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

[James Smith]

smithjd added a comment.


  In D15341#322618 , @ngraham wrote:
  
  > I appreciate the patch and the fact that you considered the prior comments 
in D14739 . But I must admit I'm still left 
with a nagging question: "Why?"
  >
  > Why here? Why not elsewhere? How about the search field in Kicker and 
Kickoff? The one in Dolphin? If this should be done at all, shouldn't it be 
done everywhere? And if it can't be done everywhere due to conflicts (i.e. 
because [ctrl] + [a] and [ctrl] + [s] have existing meanings in GUI software), 
then should it be done at all?
  
  
  Kicker/Kickoff and the dolphin search aren't full-fledged launchers like 
KRunner, only search fields for Baloo.
  
  > It just seems sort of random to add this very heavyweight configuration UI 
here in the KCM to change shortcuts for KRunner that basically nobody but you 
would ever want to change. :) > Pretty much the only KRunner-related shortcut 
that your average user might actually want to change in the KCM is the 
activation shortcut, and that's not here--though I would be happy to > see a 
patch to add just that on the main page, without adding another tab. If we 
absolutely must add alternative hidden power user CLI-inspired navigation 
shortcuts to KRunner (which I'm > not yet convinced on), let's just do it, and 
not wrap it in a whole bunch of user-visible configuration UI.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15341

To: smithjd, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

[Stefan Brüns]

bruns added a comment.


  @davidedmundson - good to go?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15357

To: bruns, #plasma
Cc: davidedmundson, zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14806: [AppStream Runner] Reduce verbosity of log output

[Stefan Brüns]

bruns added a comment.


  Ping!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14806

To: bruns, #plasma, apol, ngraham
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D15410: Handle clients which change window metadata during early startup

[Eike Hein]

hein added a comment.


  In D15410#323613 , @graesslin 
wrote:
  
  > I just want to point out that such applications are not ICCCM compliant: 
This property must be present when the window leaves the Withdrawn state and 
may be changed only while the window is in the Withdrawn state. Window managers 
may examine the property only when they start up and when the window leaves the 
Withdrawn state, but there should be no need for a client to change its state 
dynamically.
  >
  > KWin doesn't support updates to wm_class and e.g. window rules are broken.
  
  
  Preaching to the choir I'm afraid :(. I consider this bad application 
behavior and called it a concession to badly written apps on Bugzilla.
  
  Unfortunately the upstream bug report has been ignored however, and there's a 
large installed base as this is long-standing LibreOffice behavior. I am 
eventually considering a backport to the LTS branch of this.
  
  Also, on Wayland the appid can change at runtime in theory (and people hooked 
this up in Mutter and Weston, so I guess it's been encountered), and the 
affected code is mostly generic over the two windowing systems.
  
  Ah well. At least this takes the shape of a generic "allow hiding tasks 
matching some id" feature. It's in practice only needed to handle this app 
misbehavior, but at least it's not brittle weird code to catch ckass changes 
explicitly.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15410

To: hein, davidedmundson, broulik, ngraham
Cc: graesslin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15410: Handle clients which change window metadata during early startup

[Martin Flöser]

graesslin added a comment.


  I just want to point out that such applications are not ICCCM compliant: This 
property must be present when the window leaves the Withdrawn state and may be 
changed only while the window is in the Withdrawn state. Window managers may 
examine the property only when they start up and when the window leaves the 
Withdrawn state, but there should be no need for a client to change its state 
dynamically.
  
  KWin doesn't support updates to wm_class and e.g. window rules are broken.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15410

To: hein, davidedmundson, broulik, ngraham
Cc: graesslin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15410: Handle clients which change window metadata during early startup

[Eike Hein]

hein updated this revision to Diff 41356.
hein edited the summary of this revision.
hein added a comment.


  Add conclusion to description. Done now, promise.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15410?vs=41355&id=41356

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15410

AFFECTED FILES
  libtaskmanager/taskmanagerrulesrc
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasktools.cpp
  libtaskmanager/tasktools.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp

To: hein, davidedmundson, broulik, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15410: Handle clients which change window metadata during early startup

[Eike Hein]

hein updated this revision to Diff 41355.
hein added a reviewer: ngraham.
hein added a comment.


  Add back Nate. Now I'm committed to using `arc diff --verbatim`, sorry. :P

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15410?vs=41354&id=41355

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15410

AFFECTED FILES
  libtaskmanager/taskmanagerrulesrc
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasktools.cpp
  libtaskmanager/tasktools.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp

To: hein, davidedmundson, broulik, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15410: Handle clients which change window metadata during early startup

[Eike Hein]

hein updated this revision to Diff 41354.
hein edited the summary of this revision.
hein added a comment.


  Improve description further.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15410?vs=41353&id=41354

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15410

AFFECTED FILES
  libtaskmanager/taskmanagerrulesrc
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasktools.cpp
  libtaskmanager/tasktools.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp

To: hein, davidedmundson, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15410: Handle clients which change window metadata during early startup

[Eike Hein]

hein updated this revision to Diff 41353.
hein edited the summary of this revision.
hein removed a reviewer: ngraham.
hein added a comment.


  Fix typo in description.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15410?vs=41352&id=41353

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15410

AFFECTED FILES
  libtaskmanager/taskmanagerrulesrc
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasktools.cpp
  libtaskmanager/tasktools.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp

To: hein, davidedmundson, broulik, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15410: Handle clients which change window metadata during early startup

[Eike Hein]

hein created this revision.
hein added reviewers: davidedmundson, broulik.
Herald added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  Some apps initially show their window with bogus/useless window
  metadata and then update to useful metadata during early startup.
  For example, LibreOffice sets WM_CLASS to soffice/Soffice and
  then updates to libreoffice-writer/libreoffice. This leads to
  a poor user experience on particular the Icons-only Task Manager,
  but also the regular Task Manager depending on settings.
  
  Depending on its configuration (and Icons-only Task Manager is
  a particular set of configuration options, as far as the model
  is concerned), TasksModel will try to launch a new window task
  adjacent to its launcher task. The appearance of a new window
  task also causes matching (in terms of identification) launcher
  or startup tasks to be filtered out. To the user, this forms a
  lifecycle of the launcher being replaced by the window in-place
  (and a startup state inbetween, optionally but by default).
  
  Prior to this patch, this sorting decision was only done once,
  when a new window enters the source model stack. That meant the
  LibreOffice window would initially be sorted into the "wrong"
  spot (the bogus metadata doesn't allow us to relate it to its
  launcher) and then, following the metadata change, stick to the
  wrong position.
  
  Simply changing the code to sort things again on any metadata
  change would not have been good enough: Metadata changes can
  occur at any time, and things shouldn't move around on the user
  
  - this sort mode is called "Manual" for a reason. Also, the
  
  visual result would still be poor: The window would initially
  appear at the wrong position, then move into the right one a
  short moment later.
  
  This patch takes the following approach:
  
  - It adds a new config key to taskmanagerrulesrc that allows listing ids used 
to completely hide tasks if they match, and of course the code needed to 
implement this.
  - It adds LibreOffice' bogus initial metadata to this key, so the tasks is 
initially hidden.
  - It skips over hidden tasks in the sort insert queue instead of moving them.
  - It resorts when tasks are unhidden (i.e. once the metadata update has 
occured and the task no longer matches the above config key).
  
  BUG:396871

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15410

AFFECTED FILES
  libtaskmanager/taskmanagerrulesrc
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasktools.cpp
  libtaskmanager/tasktools.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp

To: hein, davidedmundson, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15202: Move kcheckrunning into startkde

[David Edmundson]

davidedmundson updated this revision to Diff 41351.
davidedmundson added a comment.


  Add missing file

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15202?vs=40814&id=41351

BRANCH
  dave2

REVISION DETAIL
  https://phabricator.kde.org/D15202

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/kcheckrunning.cpp
  startkde/CMakeLists.txt
  startkde/kcheckrunning/CMakeLists.txt
  startkde/kcheckrunning/kcheckrunning.cpp

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15391: [Bookmarks Runner] Fix cleanup of favicon directory

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:140b908e4c17: [Bookmarks Runner] Fix cleanup of favicon 
directory (authored by bruns).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15391?vs=41300&id=41339

REVISION DETAIL
  https://phabricator.kde.org/D15391

AFFECTED FILES
  runners/bookmarks/faviconfromblob.cpp

To: bruns, #plasma, davidedmundson, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14392: Don't consider filtered out tasks siblings when sorting in new tasks

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c8358c203f11: Don't consider filtered out tasks 
siblings when sorting in new tasks (authored by hein).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14392?vs=38473&id=41333

REVISION DETAIL
  https://phabricator.kde.org/D14392

AFFECTED FILES
  libtaskmanager/tasksmodel.cpp

To: hein, davidedmundson, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15331: [Folder View] Hide /home/foo/Desktop place in configuration

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Changes 
Planned".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:45c420b7fd11: [Folder View] Hide /home/foo/Desktop place 
in configuration (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15331?vs=41153&id=41332

REVISION DETAIL
  https://phabricator.kde.org/D15331

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigLocation.qml
  containments/desktop/plugins/folder/placesmodel.cpp
  containments/desktop/plugins/folder/placesmodel.h

To: broulik, #plasma, hein, fvogt
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14426: [Folder View] Create KFilePlacesModel only when needed and listen for changes

[Kai Uwe Broulik]

broulik updated this revision to Diff 41331.
broulik added a comment.


  Indeed I did :)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14426?vs=41318&id=41331

REVISION DETAIL
  https://phabricator.kde.org/D14426

AFFECTED FILES
  containments/desktop/plugins/folder/labelgenerator.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14392: Don't consider filtered out tasks siblings when sorting in new tasks

[Eike Hein]

hein added inline comments.

INLINE COMMENTS

> broulik wrote in tasksmodel.cpp:561
> Now it's no longer "Pre filter", is it?

`sortedPreFilterRows` is a list of pre-filter row indices we use for sorting. 
Moving its contents around doesn't change the fact that those contents are row 
indices from before filtering :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14392

To: hein, davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14426: [Folder View] Create KFilePlacesModel only when needed and listen for changes

[Eike Hein]

hein added a comment.


  Did you forget to update the diff?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14426

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15331: [Folder View] Hide /home/foo/Desktop place in configuration

[Eike Hein]

hein added a comment.


  Let's not bother with it then, thanks for looking into it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15331

To: broulik, #plasma, hein, fvogt
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Monday meeting notes for 2018-09-10 (week 37)

[Kai Uwe Broulik]

 Roman 

 DONE 

* Pushed some KWayland fixes
* D15256: Fix for serveral bugs because of 5.13 Mouse KCM rewrite
* Wrote a blog post about my experience at Akademy: 
http://www.subdiff.de/2018/09/09/my-first-akademy-in-retrospect/


 PLAN 

* Upload last Xwl dnd patches.
* Push Wayland gamma control forward again.
* Take a look at open reviews of KWin patches from other people on Phab.

 Q & A 

* I need some diffs getting reviewed. Some of them are pretty small: 
D15225, D15234



 Eike 

 DONE 

* caught up with emails and code reviews after vacation
* fixed up arrow key nav in Kicker's search result columns in response 
to a bug report


 PLAN 

* finishing up fairly large patch to libtaskmanager that allows writing 
taskmanagerrulesrc rules to handle some pesky apps that change WM_CLASS 
during startup (e.g. LibreOffice)
* had a meeting with my GSoC student to resume work on getting it into 
merge shape, will be helping him a bit with some issues
* trying to look after 5.14 because others are busy, please let me know 
of any big blockers


 Q & A 
* I've been told https://phabricator.kde.org/D15256 is one such, so we 
should review it



 Marco 

 DONE 

Kirigami:
* made Kirigami Icon load images from qrc as well

Plasma:
* various fixes to the Slider qqc2 component (and RangeSlider as well)
* Plasma's style kirigami icon uses the same DesktopIcon.cpp in libkirigami

* pretty much it, rest of week was spent on non directly plasma related 
stuff



 Kai Uwe 

 DONE 
* Fixed few icon rendering bugs in Dolphin (blurry at certain sizes and 
hard to see when selected)

* Investigated sorting bug in Battery Monitor with multiple batteries
** It nests two Plasma SortFilterModels and this doesn't do stable sorting
** At some point also the roles get mixed up and one item shows some 
rols of another..

* Folder View fixes:
** Enables all thumbnail plugins by default now just like Dolphin
** Previews can be toggled in context menu now
** Sped up sorting by modified 60x (use UDS entry directly instead of 
KFileItem QDateTime)
** editable_desktop_icons KIOSK restriction can be used to prevent 
moving desktop icons
** Actions (cut, copy, paste, etc) are now updated live instead of only 
when context menu opens
** Hide "Desktop" entry from Places selection as /home/foo/Desktop is 
not desktop:/ D15331

* Various printing-related fixes:
** Gwenview sets document name on print job now
** Hide applet completely if no printer is configured: D15323
** Show printed document name in tooltip: D15324
* Worked on making gmenu-dbusmenu-proxy work out of the box:
** Added appmenu-gtk(2,3)-module as runtime cmake dependency
** Patch to set gtk-modules to auto-load it: D15315
* plasma-browser-integration now has multi-player support
** When tab closes, the previously used player is controlled again
* Logout dialog has "Hibernate" option now
* Removed XRandrBrightness from PowerDevil, 61 insertions (+), 619 
deletions (-)


 TODO 

* Prepare for 5.14 Beta
* Upload new plasma-browser-integration version in time for the Beta
* Fixup and merge gmenu-dbusmenu-proxy stuff


 Other 

Please make sure you check your open patches on Phabricator and merge 
them in time for the 5.14 Beta (tagging on Thursday this week!) or nudge 
the maintainer(s) if needed.


Also make sure you fill in the the amazing stuff you did this cycle into 
the Etherpad https://notes.kde.org/p/plasma_5_14
[12:01:34]  mmmeeting time?
[12:01:44]  No, lunch time :P
[12:02:31]  d_ed: notmart Riddell romangg Sho_
[12:02:35]  bshah:
[12:03:00]  yes, i'm kinda here but not much to report :)
[12:03:19]  here
[12:03:43]  here
[12:04:15]  Riddell:
[12:04:25]  alright *puts on fancy pointy meeting runner hat*
[12:04:35]  romangg: your turn
[12:05:23]  -
[12:05:25]  What I did since last week:
[12:05:27]  -
[12:05:28]  * Pushed some KWayland fixes
[12:05:30]  * D15256: Fix for serveral bugs because of 5.13 Mouse KCM rewrite
[12:05:30]  Diff 15256 "[Mouse KCM] Avoid changes to touchpads in libinput backend" [Needs Review] https://phabricator.kde.org/D15256
[12:05:31]  * Wrote a blog post about my experience at Akademy: http://www.subdiff.de/2018/09/09/my-first-akademy-in-retrospect/
[12:05:32]  --
[12:05:34]  What I want to do now:
[12:05:35]  --
[12:05:37]  * Upload last Xwl dnd patches.
[12:05:38]  * Push Wayland gamma control forward again.
[12:05:40]  * Take a look at open reviews of KWin patches from other people on Phab.
[12:05:41]  ---
[12:05:43]  Questions/Problems:
[12:05:44]  ---
[12:05:46]  * I need some diffs getting reviewed. Some of them are pretty small: D15225, D15234
[12:05:46]  Diff 15225 "Activate clients on drag enter" [Needs Review] https://phabricator.kde.org/D15225
[12:05:46]  Diff 15234 "Remove breaking pointer constraints

D14392: Don't consider filtered out tasks siblings when sorting in new tasks

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> tasksmodel.cpp:561
> + if (filterProxyIndex.isValid()) {
> +sortedPreFilterRows.move(row, i + 1);
> +moved = true;

Now it's no longer "Pre filter", is it?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14392

To: hein, davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14426: [Folder View] Create KFilePlacesModel only when needed and listen for changes

[Kai Uwe Broulik]

broulik updated this revision to Diff 41318.
broulik edited the summary of this revision.
broulik added a comment.


  - Make `KFilePlacesModel` `static` and ref-counted
  
  For simplicify the ref count is increased/decreased in the constructor and 
not depending on whether the model is actually used, e.g. when user changes 
setting from default display label to something else. This would make the patch 
super complicated otherwise. The model is then only not loaded again on next 
startup.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14426?vs=38587&id=41318

REVISION DETAIL
  https://phabricator.kde.org/D14426

AFFECTED FILES
  containments/desktop/plugins/folder/labelgenerator.cpp
  containments/desktop/plugins/folder/labelgenerator.h

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15331: [Folder View] Hide /home/foo/Desktop place in configuration

[Kai Uwe Broulik]

broulik added a comment.


  I just `setDynamicSortFilter(false);` in the constructor and 
`setDynamicSortFilter(true);` in `QQmlParserStatus::componentComplete()` but it 
doesn't make a difference.
  The `filterAcceptsRow()` method is called the same number of times upon 
opening the config dialog with or without `QQmlParserStatus`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15331

To: broulik, #plasma, hein, fvogt
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15315: Set gtk-modules to auto-load appmenu-gtk-module

[Kai Uwe Broulik]

broulik updated this revision to Diff 41316.
broulik added a comment.


  - Write into `~/.gtkrc-2.0`, the `GTK2_RC_FILES` variable isn't present for 
apps launcher by Plasma or KRunner, for some reason (probably only stuff 
launched through klauncher)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15315?vs=41115&id=41316

REVISION DETAIL
  https://phabricator.kde.org/D15315

AFFECTED FILES
  gmenu-dbusmenu-proxy/CMakeLists.txt
  gmenu-dbusmenu-proxy/menuproxy.cpp
  gmenu-dbusmenu-proxy/menuproxy.h

To: broulik, #plasma, davidedmundson, fvogt
Cc: cgiboudeaux, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart