D15827: [applet] Avoid showing a generic audio-card icon

[Nathaniel Graham]

ngraham added a comment.


  Possibly related information: I believe the original change that resulted in 
sound card icons everywhere was D8054 . In 
particular, read https://phabricator.kde.org/D8054#252877.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15827

To: nicolasfella, drosca, ngraham, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15827: [applet] Avoid showing a generic audio-card icon

[Nathaniel Graham]

ngraham added a comment.


  +10 on the end goal of showing speaker or microphone icons instead of a 
generic sound card icon! I'm not sure this is the best way to achieve that 
though. I'm sure @drosca will be able to offer some guidance here.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15827

To: nicolasfella, drosca, ngraham, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15827: [applet] Avoid showing a generic audio-card icon

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: drosca, ngraham, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  If the hardware reports "internal" as formfactor the generic audio-card icon 
is chosen. Instead look whether the device is a sink/source and display a more 
specific icon.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  icons

REVISION DETAIL
  https://phabricator.kde.org/D15827

AFFECTED FILES
  applet/contents/code/icon.js
  applet/contents/ui/DeviceListItem.qml

To: nicolasfella, drosca, ngraham, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12498: Fully remove `Application Name` from Details panel

[Nathaniel Graham]

ngraham added a comment.


  It's okay, we've all been there. :)
  
  Can you maybe take @bruns' `.ui` file for this patch and then we can 
re-commence review?

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12498

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12498: Fully remove `Application Name` from Details panel

[Stefan Brüns]

bruns added a comment.


  In D12498#333627 , @sharvey wrote:
  
  > I believe what you're perceiving in the XML file is in fact the result of a 
lot of changes made to the layout. Unneeded columns, rows, and spacers were 
deleted, causing "gaps" in the old XML file. In places, I added options like 
column spans and justifications. The XML file changed a lot.
  
  
  The diffstat for the file I attached is:
  9 changed lines
  26 removed lines
  6 added lines

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12498

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12498: Fully remove `Application Name` from Details panel

[Scott Harvey]

sharvey added a comment.


  This was copied from D12311: Align lock icon with bold message text; reduce 
overall size of dialog , which languished 
unapproved and un-landed for a long time. Indeed, I should have made this a 
separate patch, but I'd only been a contributor for about 2-3 months at this 
time. It duplicates a lot of what's in D12311 
, which is now finally closed.
  
  I propose scrapping this revision and starting it from scratch, based off 
D12311 . I don't think I have the knowledge 
of the PolicyKit backend to rewrite it in QML. And it'll likely need a C++ 
component as well; combining the two is a topic I'm still coming to terms with.
  
  I apologize for my frustration. It rarely gets to me, but things in the Real 
World are very stressful at the moment.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12498

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12498: Fully remove `Application Name` from Details panel

[Nathaniel Graham]

ngraham added a comment.


  In D12498#333627 , @sharvey wrote:
  
  > I believe what you're perceiving in the XML file is in fact the result of a 
lot of changes made to the layout. Unneeded columns, rows, and spacers were 
deleted, causing "gaps" in the old XML file. In places, I added options like 
column spans and justifications. The XML file changed a lot.
  
  
  Right, and wouldn't those changes be unrelated to this patch? If it's just a 
simple string removal, why do we need so many layout changes? The layout 
changes may be useful (I believe they probably are) but shouldn't they be done 
in a separate patch?
  
  > In my opinion - which you can take or leave - I don't believe these XML 
files were intended to be human-read. The UI they generate is where the 
judgement and checking should come from, not the convoluted XML generated by 
QtCreator. I've seen diffs much larger than this one.
  
  That's their inherent problem, and I'm guessing one of the reasons why the Qt 
folks developed QML. It's a problem that has plagued machine-generated code 
files since forever.
  
  The reason why using Qt Creator to modify these files after the fact is a 
problem is because makes the, well, code review part of code review nearly 
impossible. The diff is just noise because so much has changed. It becomes very 
challenging to actually review because it's not apparent what's intentional, 
what might have snuck in by accident, or what's simply Qt Creator moving things 
around with no change in functionality. Yes, we can evaluate the UI that it 
produces to make sure that it's good. But UI review and code review are 
different for a good reason. A UI that looks and feels okay when you test it 
can still have hidden problems that are only revealed by reading the code.
  
  All changes to `.ui` files that I've ever made have been by hand, and I've 
seen other KDE contributors do the same. Yes, this does indeed suck. It's why 
I'm recommending either:
  
  - Redoing the changes to the `.ui` file by hand to keep the diff manageable 
and reviewable
  - First in another patch porting the `.ui` file to QML so that changes made 
by hand aren't torture
  
  
  
  > Truthfully, I'm not clear on what you expect me to do. The UI works fine. 
Monkeying with the XML to make it "pretty" seems a bit pointless.
  
  Take one of the above two options, or hand it over to @bruns, I guess. It's 
all good though. :)

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12498

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15696: Fix qmake build

[Ilya Bizyaev]

IlyaBizyaev closed this revision.
IlyaBizyaev added a comment.


  Closed by 8691651c1f0d09430416ba5fe2130647554b06a9 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D15696

To: IlyaBizyaev, mart
Cc: alexeymin, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D15824: [Folder View] Fix right/left arrow navigation in popup + list view mode

[Thomas Surrel]

thsurrel created this revision.
thsurrel added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
thsurrel requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arc_folderview2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15824

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

To: thsurrel, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15823: [Folder View] In list view mode, fix home button disappearing every other subfolder entered

[Thomas Surrel]

thsurrel updated this revision to Diff 42527.
thsurrel added a comment.


  Sorry, this second commit ended up in the same arc diff, this is not what I 
intended.
  I'm still learning...

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15823?vs=42526&id=42527

BRANCH
  arc_folderview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15823

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderViewLayer.qml

To: thsurrel, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12498: Fully remove `Application Name` from Details panel

[Scott Harvey]

sharvey added a comment.


  I believe what you're perceiving in the XML file is in fact the result of a 
lot of changes made to the layout. Unneeded columns, rows, and spacers were 
deleted, causing "gaps" in the old XML file. In places, I added options like 
column spans and justifications. The XML file changed a lot.
  
  In my opinion - which you can take or leave - I don't believe these XML files 
were intended to be human-read. The UI they generate is where the judgement and 
checking should come from, not the convoluted XML generated by QtCreator. I've 
seen diffs much larger than this one.
  
  Truthfuly, I'm not clear on what you expect me to do. The UI works fine. 
Monkeying with the XML to make it "pretty" seems a bit pointless.
  
  I've got an email chain of 48 messages for a simple string change. And I 
expect it's only going to grow. This has been nitpicked to death, and I'm not 
sure why. We've beaten this dead horse to a pulp.
  
  @bruns - If you know what you want done with the XML file, I'll gladly let 
you do it. I simply don't get it.
  
  @ngraham  - You know I'm not combative or confrontational by nature. But this 
is beyond my understanding.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12498

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Two threads for two new plasma features

[Michail Vourlakos]

Hello everyone,
I opened two tasks in phabricator in order to discuss theoretically for
solutions around these two features:

- Dynamic panel coloring the mobile way for Plasma/Latte panels (
https://phabricator.kde.org/T9769) (this one is too many months in my head)
- Support "downward-pointing triangle" for plasma pop-ups (
https://phabricator.kde.org/T9770) (this one arose today)

Feel free to participate and sharing your opinion and your knowledge

regards,
michail

D15823: [Folder View] In list view mode, fix home button disappearing every other subfolder entered

[Thomas Surrel]

thsurrel updated this revision to Diff 42526.
thsurrel added a comment.


  [Folder View] Fix right/left arrow navigation in popup + list view mode

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15823?vs=42524&id=42526

BRANCH
  arc_folderview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15823

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/FolderViewLayer.qml

To: thsurrel, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15823: [Folder View] In list view mode, fix home button disappearing every other subfolder entered

[Thomas Surrel]

thsurrel created this revision.
thsurrel added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
thsurrel requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arc_folderview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15823

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderViewLayer.qml

To: thsurrel, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

T8066: Fix Bug 390830 = Prevent indexing of Plasma vaults and other fuse filesystems

[Nathaniel Graham]

ngraham added a comment.


  In T8066#161913 , @smithjd wrote:
  
  > > A slightly smarter approach would be for Plasma Vaults itself to add such 
a rule for whatever mountpoint is chosen during new vault creation.
  >
  > What about exposing these config options on dbus? 
("includeFolders"),("excludeFolders")
  >
  > That would make for 4 new entries (add/remove for each) on the 
org.kde.baloo.main interface.
  
  
  I'm not technically knowledgeable to offer an opinion on that, so I will 
defer to @bruns.

TASK DETAIL
  https://phabricator.kde.org/T8066

To: michaelh, ngraham
Cc: ngraham, smithjd, bruns, nicolasfella, ivan, plasma-devel, alexeymin, 
michaelh, ashaposhnikov, astippich, spoorun, abrahams

D15785: [Slideshow] increase default interval from 10 seconds to 15 minutes

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15785

To: ngraham, #plasma, broulik, mart, #vdg, abetts, davidedmundson
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D14949: Add option for whether to show the volume change OSD

[Nathaniel Graham]

ngraham added a comment.


  Yeah, I saw that too.
  
  I'm still against an option to hide it entirely, but I could get behind an 
option to show a more compact version.
  
  I could also support moving all of the square-style OSDs farther down so 
they're not as close to the center of the screen.

REVISION DETAIL
  https://phabricator.kde.org/D14949

To: anonym, #vdg
Cc: svenmauch, ngraham, romangg, mart, broulik, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D15304: [KCM] Port (almost) entirely to QQC2

[Nathaniel Graham]

ngraham planned changes to this revision.
ngraham marked an inline comment as done.
ngraham added a comment.


  Scrollviews in the tabs are now broken, investigating.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15304

To: ngraham, #plasma, drosca
Cc: nicolasfella, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15304: [KCM] Port (almost) entirely to QQC2

[Nathaniel Graham]

ngraham updated this revision to Diff 42512.
ngraham added a comment.


  - Rebase on master
  - Use Kirigami `Icon` instead of PlasmaCore `IconItem`

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15304?vs=42388&id=42512

BRANCH
  arcpatch-D15304

REVISION DETAIL
  https://phabricator.kde.org/D15304

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/CardListItem.qml
  src/kcm/package/contents/ui/DeviceComboBox.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/Header.qml
  src/kcm/package/contents/ui/StreamListItem.qml
  src/kcm/package/contents/ui/VolumeSlider.qml
  src/kcm/package/contents/ui/main.qml

To: ngraham, #plasma, drosca
Cc: nicolasfella, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15738: [Fonts KCM] remove filler words from anti-aliasing settings' labels

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15738

To: ngraham, #vdg, #plasma, mart
Cc: abetts, svenmauch, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.11 - Build # 56 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.11/56/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Fri, 28 Sep 2018 17:12:52 +
 Build duration:
5 min 11 sec and counting

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.11 - Build # 55 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.11/55/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Fri, 28 Sep 2018 17:07:57 +
 Build duration:
1 min 7 sec and counting
   CONSOLE OUTPUT
  [...truncated 24.36 KB...] > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 068a25cd8743b64abf7469f23aa7d6b55cdf8236 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 068a25cd8743b64abf7469f23aa7d6b55cdf8236Commit message: "Change Kdenlive's dev branch to refactoring_timeline"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[kf5-qt5 FreeBSDQt5.11] Running shell script+ python3.5 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project kwin --branchGroup kf5-qt5 --environment production --platform FreeBSDQt5.11 --installTo /home/jenkins/install-prefix/Retrieving: Plasma-extra-cmake-modules-kf5-qt5Retrieving: Plasma-karchive-kf5-qt5Retrieving: Plasma-ki18n-kf5-qt5Retrieving: Plasma-kcoreaddons-kf5-qt5Retrieving: Plasma-kwindowsystem-kf5-qt5Retrieving: Plasma-kconfig-kf5-qt5Retrieving: Plasma-kcrash-kf5-qt5Retrieving: Plasma-kdbusaddons-kf5-qt5Retrieving: Plasma-kdoctools-kf5-qt5Retrieving: Plasma-kservice-kf5-qt5Retrieving: Plasma-kcodecs-kf5-qt5Retrieving: Plasma-phonon-kf5-qt5Retrieving: Plasma-kauth-kf5-qt5Retrieving: Plasma-kguiaddons-kf5-qt5Retrieving: Plasma-kwidgetsaddons-kf5-qt5Retrieving: Plasma-kconfigwidgets-kf5-qt5Retrieving: Plasma-kitemviews-kf5-qt5Retrieving: Plasma-kcompletion-kf5-qt5Retrieving: Plasma-kiconthemes-kf5-qt5Retrieving: Plasma-sonnet-kf5-qt5Retrieving: Plasma-attica-kf5-qt5Retrieving: Plasma-kglobalaccel-kf5-qt5Retrieving: Plasma-ktextwidgets-kf5-qt5Retrieving: Plasma-breeze-icons-kf5-qt5Retrieving: Plasma-knotifications-kf5-qt5Retrieving: Plasma-kxmlgui-kf5-qt5Retrieving: Plasma-solid-kf5-qt5Retrieving: Plasma-kjobwidgets-kf5-qt5Retrieving: Plasma-kbookmarks-kf5-qt5Retrieving: Plasma-kwallet-kf5-qt5Retrieving: Plasma-kio-kf5-qt5Retrieving: Plasma-kparts-kf5-qt5Retrieving: Plasma-kplotting-kf5-qt5Retrieving: Plasma-kdewebkit-kf5-qt5Retrieving: Plasma-kinit-kf5-qt5Retrieving: Plasma-kunitconversion-kf5-qt5Retrieving: Plasma-kded-kf5-qt5Retrieving: Plasma-kemoticons-kf5-qt5Retrieving: Plasma-kdesignerplugin-kf5-qt5Retrieving: Plasma-syntax-highlighting-kf5-qt5Retrieving: Plasma-kpackage-kf5-qt5Retrieving: Plasma-kactivities-kf5-qt5Retrieving: Plasma-kdnssd-kf5-qt5Retrieving: Plasma-kdeclarative-kf5-qt5Retrieving: Plasma-kidletime-kf5-qt5Retrieving: Plasma-kitemmodels-kf5-qt5Retrieving: Plasma-kjs-kf5-qt5Retrieving: Plasma-kross-kf5-qt5Retrieving: Plasma-threadweaver-kf5-qt5Retrieving: Plasma-kwayland-kf5-qt5Retrieving: Plasma-ktexteditor-kf5-qt5Retrieving: Plasma-oxygen-icons5-kf5-qt5Retrieving: Plasma-kirigami-kf5-qt5Retrieving: Plasma-plasma-framework-kf5-qt5Retrieving: Plasma-krunner-kf5-qt5Retrieving: Plasma-kfilemetadata-kf5-qt5Traceback (most recent call last):  File "ci-tooling/helpers/prepare-dependencies.py", line 71, in filename, metadata = packageArchive.retrievePackage( package )  File "/usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.11/ci-tooling/helpers/helperslib/Packages.py", line 115, in retrievePackagelatestContent.write( response.read() )  File "/usr/local/lib/python3.5/http/client.py", line 461, in reads = self._safe_read(self.length)  File "/usr/local/lib/python3.5/http/client.py", line 607, in _safe_readchunk = self.fp.read(min(amt, MAXAMOUNT))  File "/usr/local/lib/python3.5/socket.py", line 576, in readintoreturn self._sock.recv_into(b)  File "/usr/local/lib/python3.5/ssl.py", line 937, in recv_intoreturn self.read(nbytes, buffer)  File "/usr/local/lib/python3.5/ssl.py", line 799, in readreturn self._sslobj.read(len, buffer)  File "/usr/local/lib/python3.5/ssl.py", line 583, in readv = self._sslobj.read(len, buffer)ConnectionResetError: [Errno 54] Connection reset by peer[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

D15514: [libbreezecommon] Use box blur instead of FFT blur

[Vlad Zagorodniy]

zzag updated this revision to Diff 42505.
zzag added a comment.


  Introduce BoxShadowRenderer helper
  
  BoxShadowRenderer is a helper to render box shadows. The main benefit of
  this class is that it takes care of allocating big enough shadow
  texture, so the resulting shadows are not clipped, etc. Also, conceptually,
  it makes sense to have it.
  
  The box blur implementation is based on AlphaBoxBlur from Firefox, which means
  that the resulting shadows look quite similar to what Firefox would render.
  
  With debug build, opened web browser (Firefox), and a text editor (VS Code),
  on average it takes less than 16ms to render decoration shadows for all sizes:
  
  - small: <1 ms
  - medium: 1-2ms
  - large: 5ms (+/- 1ms)
  - very large: 11ms (+/- 1ms)
  
  Things to do:
  
  - revise shadow params (shadows are rendered slightly differently now)
  - clean up the code

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15514?vs=42295&id=42505

BRANCH
  zzag/box-shadow-helper-box-blur

REVISION DETAIL
  https://phabricator.kde.org/D15514

AFFECTED FILES
  CMakeLists.txt
  cmake/Modules/FindFFTW.cmake
  kdecoration/breezedecoration.cpp
  kstyle/breezeshadowhelper.cpp
  libbreezecommon/CMakeLists.txt
  libbreezecommon/breezeboxshadowhelper.cpp
  libbreezecommon/breezeboxshadowhelper.h
  libbreezecommon/breezeboxshadowrenderer.cpp
  libbreezecommon/breezeboxshadowrenderer.h

To: zzag, #kwin, #plasma
Cc: cfeck, ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D15776: Show the preferred resolution on the combo box

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:dfd178e6d093: Show the preferred resolution on the combo 
box (authored by Your Name , committed by apol).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15776?vs=42374&id=42502

REVISION DETAIL
  https://phabricator.kde.org/D15776

AFFECTED FILES
  kcm/src/resolutionslider.cpp

To: apol, #plasma, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15429: Simplify cmake code: link to Qt5::GuiPrivate.

[David Faure]

dfaure added a comment.


  I completely forgot about pushing it, thanks for the reminder and for the 
target branch information.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  Plasma/5.13

REVISION DETAIL
  https://phabricator.kde.org/D15429

To: dfaure, kfunk, kossebau, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15789: Support QXL hotplug_mode_update

[Aleix Pol Gonzalez]

apol updated this revision to Diff 42500.
apol added a comment.


  Make sure we don't check the property twice on the same path

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15789?vs=42405&id=42500

BRANCH
  arcpatch-D15789_1

REVISION DETAIL
  https://phabricator.kde.org/D15789

AFFECTED FILES
  backends/xrandr/xrandr.cpp
  backends/xrandr/xrandr.h
  backends/xrandr/xrandroutput.cpp
  backends/xrandr/xrandroutput.h
  src/configserializer.cpp
  src/output.cpp
  src/output.h

To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15429: Simplify cmake code: link to Qt5::GuiPrivate.

[David Faure]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:db3a865c8cbf: Simplify cmake code: link to 
Qt5::GuiPrivate. (authored by dfaure).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15429?vs=41410&id=42501

REVISION DETAIL
  https://phabricator.kde.org/D15429

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  src/platformtheme/CMakeLists.txt

To: dfaure, kfunk, kossebau, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15789: Support QXL hotplug_mode_update

[Aleix Pol Gonzalez]

apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> davidedmundson wrote in xrandroutput.cpp:212
> why are we querying if the property exists rather than if the property is 1?

Because it's poorly specified. In fact, it's always 0 as far as I can tell.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D15789

To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13745: Implement support for virtual desktops on Wayland

[Marco Martin]

mart added a comment.


  Api looks improved to me..
  still some todo pieces, but looks good to me

INLINE COMMENTS

> taskgroupingproxymodel.cpp:724
> +} else if (role == AbstractTasksModel::VirtualDesktops) {
> +// FIXME WAYLAND Similar to activities
> +// // Returns the lowest virtual desktop id among all children 
> of the

what's the rationale of this dead code?

> xwindowtasksmodel.cpp:633
> +} else if (role == VirtualDesktops) {
> +return QVariantList() << d->windowInfo(window)->desktop();
>  } else if (role == IsOnAllVirtualDesktops) {

{} initializer?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13745

To: hein, mart, mvourlakos
Cc: anthonyfieroni, zzag, ngraham, abetts, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

[Marco Martin]

mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> pagermodel.cpp:444
>  for (auto windowModel : d->windowModels) {
> -windowModel->setVirtualDesktop(0);
> +windowModel->setVirtualDesktop();
>  

would it be possible to avoid default arguments?

> pagermodel.cpp:642
> +if (!winIds.isEmpty() && winIds.at(0).toUInt() == id) {
> +tasksModel->requestVirtualDesktops(idx, 
> QVariantList() << itemId.toString());
> +break;

{} initializer?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13748

To: hein, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15815: Remove expensive blocking call on plasmashell startup

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Nice one

REPOSITORY
  R120 Plasma Workspace

BRANCH
  kuiserver_startup

REVISION DETAIL
  https://phabricator.kde.org/D15815

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15815: Remove expensive blocking call on plasmashell startup

[David Edmundson]

davidedmundson added a comment.


  F6291940: Screenshot_20180928_150857.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15815

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15815: Remove expensive blocking call on plasmashell startup

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  QDBusInterface is a blocking call that calls introspect. We don't need
  to introspect.
  
  As this is called on startup this call starts kuiserver, which means
  plasma is blocked whilst a whole process spawns, this is a lot worse
  than just a regular, ~100ms on my system
  
  Also using the generated versions is generally neater to read.

TEST PLAN
  Restarted plasmashell
  Copied a file
  Still had a spinny wheel
  Q_DBUS_BLOCKING_CALL_MAIN_THREAD_WARNING_MS=0 doesn't list kuiserver

REPOSITORY
  R120 Plasma Workspace

BRANCH
  kuiserver_startup

REVISION DETAIL
  https://phabricator.kde.org/D15815

AFFECTED FILES
  dataengines/applicationjobs/CMakeLists.txt
  dataengines/applicationjobs/kuiserverengine.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

[Stefan Brüns]

bruns added a comment.


  Is there anything missing?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15357

To: bruns, #plasma
Cc: davidedmundson, zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15423: System settings: make date/time format preview consistent

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> kcmformats.cpp:322
> +str = m_ui->comboNumbers->currentData().toString();
> +nloc = str.isEmpty() ? QLocale(glob) : QLocale(str);
> +

I don't understand, why is this sometimes empty?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15423

To: McPain, hein, #vdg
Cc: davidedmundson, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15429: Simplify cmake code: link to Qt5::GuiPrivate.

[Friedrich W. H. Kossebau]

kossebau added a comment.


  @dfaure: Was this one pushed already? If not, target would be now Plasma/5.14 
branch, with 5.13 EOL

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  Plasma/5.13

REVISION DETAIL
  https://phabricator.kde.org/D15429

To: dfaure, kfunk, kossebau, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15789: Support QXL hotplug_mode_update

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Looks mostly good.
  
  At some point we'll need to add this property to the wayland output 
protocols, but that can be later.

INLINE COMMENTS

> xrandroutput.cpp:178
>  m_primary = primary;
> +m_hotplugModeUpdate = XRandR::hasProperty(m_id, "hotplug_mode_update");
>  }

This code path potentially updates this var twice.
Would it be better to do this inside the

} else if (conn == XCB_RANDR_CONNECTION_CONNECTED) {

> xrandroutput.cpp:212
>  }
> +m_hotplugModeUpdate = XRandR::hasProperty(m_id, "hotplug_mode_update");
>  

why are we querying if the property exists rather than if the property is 1?

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D15789

To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15121: Kirigami Pages are required for kcms

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:26f77e2c442b: Kirigami Pages are required for kcms 
(authored by mart).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15121?vs=42466&id=42467

REVISION DETAIL
  https://phabricator.kde.org/D15121

AFFECTED FILES
  src/kcm/module.cpp
  src/kcm/package/contents/ui/main.qml

To: mart, #plasma, davidedmundson
Cc: abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15121: Kirigami Pages are required for kcms

[Marco Martin]

mart updated this revision to Diff 42466.
mart added a comment.


  - fix wording

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15121?vs=40548&id=42466

BRANCH
  arcpatch-D15121

REVISION DETAIL
  https://phabricator.kde.org/D15121

AFFECTED FILES
  src/kcm/module.cpp
  src/kcm/package/contents/ui/main.qml

To: mart, #plasma, davidedmundson
Cc: abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15143: Allow creation of separator Actions

[Dimitris Kardarakos]

dkardarakos updated this revision to Diff 42465.
dkardarakos added a comment.


  Previously introduced "separator mode" removed from AbstractListItem and 
BasicListItem.
  
  Instead of a solution totally inside globaldrawer and contextdrawer I opted 
for a new BasicListItem alias property (reserveSpaceForLabel) similar to the 
existing reserveSpaceForIcon. With this approach we have more control when 
adding new items (like the Separator) to BasicListItems.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15143?vs=40647&id=42465

REVISION DETAIL
  https://phabricator.kde.org/D15143

AFFECTED FILES
  src/controls/Action.qml
  src/controls/BasicListItem.qml
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/private/ActionsMenu.qml

To: dkardarakos, mart
Cc: broulik, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D15599: Port the "Switch Desktop" containment action to libtaskmanager

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> desktop.cpp:59
> +const QVariantList &desktopIds = s_virtualDesktopInfo->desktopIds();
> +const QStringList &desktopNames = s_virtualDesktopInfo->desktopNames();
> +const QVariant ¤tDesktop = s_virtualDesktopInfo->currentDesktop();

Use of the & is weird.

> desktop.cpp:108
> +
> +const int nextDesktopIndex = (currentDesktopIndex % desktopIds.count() + 
> 1);
> +

I /think/ this is wrong. Not 100% sure.

We used to want a number wrapped between 1 and numDesktops.

The old
 KWindowSystem::setCurrentDesktop(currentDesktop % numDesktops + 1);

is probably more understandable as
 KWindowSystem::setCurrentDesktop((currentDesktop +1 ) -1 % numDesktops + 1);

In the new code as we have the IDs in a lookup table so we want our final 
number to be between 0 and numDesktops-1

Therefore should this be
currentDesktopIndex +1 % desktopIds.count();

?

(same for perform previous)

> broulik wrote in desktop.cpp:46
> `!s_instanceCount`

In the other patch VirtualDesktopInfo has a shared d ptr across all instances.

There's no point making VirtualDesktopInfo shared when it internally does it 
itself anyway. You save practically nothing.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15599

To: hein, mart, davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14949: Add option for whether to show the volume change OSD

[Sven Mauch]

svenmauch added a comment.


  In D14949#314343 , @anonym wrote:
  
  > Yes; I would be completely happy if the current (size and all) OSD would 
appear in the periphery of the screen, preferably a corner. So perhaps the 
missing option is actually a drop-down for the position of the OSD? An 
ambitious plan would be:
  >
  > - Center: the current OSD. (Default)
  > - Notification Area: shows a thin vertical bar in the Notification Area (so 
the lower right corner for the default panel).
  > - Top: shows a //very// thin horizontal bar centered at the top edge.
  > - Bottom: like the above.
  
  
  I just stumbled upon this reddit thread with a significant number of upvotes: 
https://www.reddit.com/r/kde/comments/9j57z2/fixing_the_awful_volumebrightness_osd_size/
  
  So I guess it's an idea worth pushing forward. :)

REVISION DETAIL
  https://phabricator.kde.org/D14949

To: anonym, #vdg
Cc: svenmauch, ngraham, romangg, mart, broulik, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol