D17706: Fix lock screen focus

[Andrey Bychkov]

andreyby added a comment.


  **davidedmundson **
  //we don't want to cursor grab in testing mode, this change is lost//yes, 
did not notice
  //This is still relevant A cursor can be in none.//I think this is 
superfluous, because the default focus is on the first screen.
  //why are we changing the window flags?//   Because with the flag 
X11BypassWindowManagerHint the focus will not be able to change, so it needs to 
be removed, change the focus, put flag back.
  
  I rewrited the patch with minimal changes.
  
  **abetts **
  It is easy to reproduce when more than one monitor is connected, you must set 
the cursor on any monitor except the first one and block the screen with hot 
keys, after which you will notice that the focus of the password entry remains 
on the first screen. 
  This problem may be associated with the bug 395639.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D17706

To: andreyby, davidedmundson
Cc: abetts, davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17706: Fix lock screen focus

[Andrey Bychkov]

andreyby updated this revision to Diff 47933.

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17706?vs=47879&id=47933

REVISION DETAIL
  https://phabricator.kde.org/D17706

AFFECTED FILES
  greeter/greeterapp.cpp

To: andreyby, davidedmundson
Cc: abetts, davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

KDE CI: Plasma » kscreen » stable-kf5-qt5 FreeBSDQt5.11 - Build # 15 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kscreen/job/stable-kf5-qt5%20FreeBSDQt5.11/15/
 Project:
stable-kf5-qt5 FreeBSDQt5.11
 Date of build:
Fri, 21 Dec 2018 07:28:13 +
 Build duration:
13 sec and counting
   CONSOLE OUTPUT
  [...truncated 3 lines...]Running on FreeBSD Builder 2 in /usr/home/jenkins/workspace/Plasma/kscreen/stable-kf5-qt5 FreeBSDQt5.11[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkoutCloning the remote Git repositoryCloning repository git://anongit.kde.org/kscreen > git init /usr/home/jenkins/workspace/Plasma/kscreen/stable-kf5-qt5 FreeBSDQt5.11 # timeout=10Fetching upstream changes from git://anongit.kde.org/kscreen > git --version # timeout=10 > git fetch --tags --progress git://anongit.kde.org/kscreen +refs/heads/*:refs/remotes/origin/* # timeout=120 > git config remote.origin.url git://anongit.kde.org/kscreen # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url git://anongit.kde.org/kscreen # timeout=10Fetching upstream changes from git://anongit.kde.org/kscreen > git fetch --tags --progress git://anongit.kde.org/kscreen +refs/heads/*:refs/remotes/origin/* # timeout=120Checking out Revision 2392326d2a70be3dcf8e236e3202b489862826b4 (refs/remotes/origin/Plasma/5.14)Commit message: "SVN_SILENT made messages (.desktop file) - always resolve ours" > git rev-parse Plasma/5.14^{commit} # timeout=10 > git rev-parse refs/remotes/origin/Plasma/5.14^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f 2392326d2a70be3dcf8e236e3202b489862826b4 > git rev-list --no-walk 7d3831049aa6d14f8ef5bd6c9f4f0d888e91ef70 # timeout=10[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/ci-tooling > git init /usr/home/jenkins/workspace/Plasma/kscreen/stable-kf5-qt5 FreeBSDQt5.11/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/*Checking out Revision dbb3d8d9f37aa8a99ce3d4af9453d484b3a0b347 (origin/master)Commit message: "Make sure we wait and block until the publishing process is completed."[Pipeline] checkoutCloning the remote Git repository > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f dbb3d8d9f37aa8a99ce3d4af9453d484b3a0b347Cloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /usr/home/jenkins/workspace/Plasma/kscreen/stable-kf5-qt5 FreeBSDQt5.11/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/*Checking out Revision 23ba7a4042bec430ec950c7e49f36cc75d49d2a4 (origin/master)Commit message: "Add repository for kolorfill."[Pipeline] checkoutCloning the remote Git repository > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f 23ba7a4042bec430ec950c7e49f36cc75d49d2a4Cloning repository https://anongit.kde.org/kde-build-metadata > git init /usr/home/jenkins/workspace/Plasma/kscreen/stable-kf5-qt5 FreeBSDQt5.11/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/*Checking out Revision 9a6707299b789bc5ba2f6e97d0113f2149e5cb5e (origin/master)Commit message: "gcompris, stable is now 0.95"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # time

KDE CI: Plasma » kscreen » stable-kf5-qt5 SUSEQt5.11 - Build # 17 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kscreen/job/stable-kf5-qt5%20SUSEQt5.11/17/
 Project:
stable-kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 21 Dec 2018 07:28:13 +
 Build duration:
27 sec and counting
   CONSOLE OUTPUT
  [...truncated 36 lines...] > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/*Checking out Revision dbb3d8d9f37aa8a99ce3d4af9453d484b3a0b347 (origin/master)Commit message: "Make sure we wait and block until the publishing process is completed."[Pipeline] checkoutCloning the remote Git repository > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f dbb3d8d9f37aa8a99ce3d4af9453d484b3a0b347Cloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /home/jenkins/workspace/Plasma/kscreen/stable-kf5-qt5 SUSEQt5.11/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/*Checking out Revision 23ba7a4042bec430ec950c7e49f36cc75d49d2a4 (origin/master)Commit message: "Add repository for kolorfill."[Pipeline] checkoutCloning the remote Git repository > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f 23ba7a4042bec430ec950c7e49f36cc75d49d2a4Cloning repository https://anongit.kde.org/kde-build-metadata > git init /home/jenkins/workspace/Plasma/kscreen/stable-kf5-qt5 SUSEQt5.11/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/*Checking out Revision 9a6707299b789bc5ba2f6e97d0113f2149e5cb5e (origin/master)Commit message: "gcompris, stable is now 0.95"[Pipeline] checkoutCloning the remote Git repository > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f 9a6707299b789bc5ba2f6e97d0113f2149e5cb5eCloning repository https://anongit.kde.org/kapidox > git init /home/jenkins/workspace/Plasma/kscreen/stable-kf5-qt5 SUSEQt5.11/ci-tooling/kapidox # timeout=10Fetching upstream changes from https://anongit.kde.org/kapidox > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kapidox +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kapidox # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kapidox # timeout=10Fetching upstream changes from https://anongit.kde.org/kapidox > git fetch --tags --progress https://anongit.kde.org/kapidox +refs/heads/*:refs/remotes/origin/*Checking out Revision 28dca00d2f3a9682d1fe675751ed54f87db463a4 (origin/master)Commit message: "Fix doxygen markdown rendering"[Pipeline] checkoutCloning the remote Git repository > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f 28dca00d2f3a9682d1fe675751ed54f87db463a4Cloning repository https://anongit.kde.org/kde-dev-scripts > git init /home/jenkins/workspace/Plasma/kscreen/stable-kf5-qt5 SUSEQt5.11/ci-tooling/kde-dev-scripts # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts > git --version # timeout=10 > git fetch --tags --progress https:/

[Plasma Workspace Wallpapers] [Bug 346251] Default wallpaper cannot be found in desktop settings

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=346251

Christoph Feck  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|REPORTED|RESOLVED

--- Comment #3 from Christoph Feck  ---
No response, and works for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kdeplasma-addons] [Bug 378823] EPOD POTD display header image instead of the real photo

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=378823

Christoph Feck  changed:

   What|Removed |Added

  Component|general |Picture of the Day
Product|Plasma Workspace Wallpapers |kdeplasma-addons

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kwrited] [Bug 386067] Use seperate notifications for each message

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=386067

--- Comment #1 from Christoph Feck  ---
Are messages separated by some fixed text? Otherwise I doubt it is fixable.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D17652: Fix logic error in kioclient noninteractive argument handling

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  I'm not sure anymore what the best default is. There are two different use 
cases, that's all.

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17652

To: davidedmundson, #plasma, nerdopolist, dfaure
Cc: broulik, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17717: Remove KDE3 reference in kdeeject

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  There is no org.kde.kdesktop and we don't show mount points by default
  on the desktop so there's nothing to explicitly refresh.
  
  BUG: 357986

TEST PLAN
  None

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17717

AFFECTED FILES
  kdeeject/kdeeject

To: davidedmundson, #plasma
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17652: Fix logic error in kioclient noninteractive argument handling

[David Edmundson]

davidedmundson updated this revision to Diff 47922.
davidedmundson edited the summary of this revision.
davidedmundson added a comment.


  update

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17652?vs=47894&id=47922

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17652

AFFECTED FILES
  kioclient/kioclient.cpp

To: davidedmundson, #plasma, nerdopolist, dfaure
Cc: broulik, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17652: Fix logic error in kioclient noninteractive argument handling

[David Edmundson]

davidedmundson added a comment.


  > Why would we want to break compatibility yet again? ;-)
  
  It's the better default. 
  I've removed the TODO, but I've deliberately not said which is default in the 
--help output which hopefully will encourage people to still type 
--noninteractive if they genuinely want that which allows us to keep our 
options open.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D17652

To: davidedmundson, #plasma, nerdopolist, dfaure
Cc: broulik, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17653: Keep kioclient alive whilst we're showing error messages

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R126:c05e88533de1: Keep kioclient alive whilst we're 
showing error messages (authored by davidedmundson).

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17653?vs=47764&id=47921

REVISION DETAIL
  https://phabricator.kde.org/D17653

AFFECTED FILES
  kioclient/kioclient.cpp

To: davidedmundson, #plasma, nerdopolist, broulik
Cc: broulik, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17703: Fix KIOClient non-interactive mode handling renamed prompts

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R126:36a59ad77f5e: Fix KIOClient non-interactive mode handling 
renamed prompts (authored by davidedmundson).

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17703?vs=47872&id=47920

REVISION DETAIL
  https://phabricator.kde.org/D17703

AFFECTED FILES
  kioclient/kioclient.cpp

To: davidedmundson, #plasma, dfaure
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17711: [kuiserver] Avoid double warning on terminated jobs

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c4dcba898a97: [kuiserver] Avoid double warning on 
terminated jobs (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17711?vs=47898&id=47916

REVISION DETAIL
  https://phabricator.kde.org/D17711

AFFECTED FILES
  kuiserver/jobview.cpp
  kuiserver/jobview.h
  kuiserver/progresslistmodel.cpp

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17709: Remove outdated note about autostart not working

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fb1570f4804d: Remove outdated note about autostart not 
working (authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17709?vs=47893&id=47915

REVISION DETAIL
  https://phabricator.kde.org/D17709

AFFECTED FILES
  doc/kcontrol/autostart/index.docbook

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, kde-doc-english, GB_2, ragreen, Pitel, ZrenBot, 
skadinna, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17711: [kuiserver] Avoid double warning on terminated jobs

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> jobview.cpp:56
>  {
> +qDebug() << "is terminated" << errorMessage;
>  QDBusConnection::sessionBus().unregisterObject(m_objectPath.path(), 
> QDBusConnection::UnregisterTree);

Remove

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17711

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17652: Fix logic error in kioclient noninteractive argument handling

[David Faure]

dfaure added a comment.


  Looks good except for the TODO comment. I think the comment that is actually 
needed is one about why we have a "noninteractive" option and it has no effect 
whatsoever ;)

INLINE COMMENTS

> kioclient.cpp:278
> +// interactive used to be the default, but due to a porting error it 
> broke
> +// for compatibility noninteractive is now the default (TODO change 
> for Plasma 6?)
>  s_interactive = false;

Why would we want to break compatibility yet again? ;-)

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D17652

To: davidedmundson, #plasma, nerdopolist, dfaure
Cc: broulik, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

[Christoph Feck]

cfeck added a comment.


  Or make the button have a drop-down, see e.g. "Save As..." button in 
Spectacle.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D17704

To: guoyunhe, #plasma
Cc: ngraham, gregormi, cfeck, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

[Yunhe Guo]

guoyunhe added a comment.


  In D17704#380016 , @ngraham wrote:
  
  > I recall in the original patch that copying translated text was something 
that various folks specifically asked for. Is it really that useless? 
@gregormi, do you remember the context?
  
  
  If both translated and untranslated texts are used by some people, I can make 
another button "Copy to clipboard (English)".

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D17704

To: guoyunhe, #plasma
Cc: ngraham, gregormi, cfeck, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17711: [kuiserver] Avoid double warning on terminated jobs

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  When a job is terminated, it isn't necessarily removed from the job
  owners queue to handle pending requests.
  
  If a service unregisters and the job is already finished, we don't want
  to mark it as an error.

TEST PLAN
  kioclient5 (when running with fixed interactive-ness) quits when there's an 
error.
  We used to always show the client died error.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17711

AFFECTED FILES
  kuiserver/jobview.cpp
  kuiserver/jobview.h
  kuiserver/progresslistmodel.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

[Nathaniel Graham]

ngraham added subscribers: gregormi, ngraham.
ngraham added a comment.


  I recall in the original patch that copying translated text was something 
that various folks specifically asked for. Is it really that useless? 
@gregormi, do you remember the context?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D17704

To: guoyunhe, #plasma
Cc: ngraham, gregormi, cfeck, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

[Yunhe Guo]

guoyunhe updated this revision to Diff 47897.
guoyunhe added a comment.


  Use untranslated texts for clipboard label pairs

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17704?vs=47877&id=47897

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17704

AFFECTED FILES
  Modules/about-distro/src/Module.cpp
  Modules/about-distro/src/Module.h

To: guoyunhe, #plasma
Cc: cfeck, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17709: Remove outdated note about autostart not working

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yep, totally works.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17709

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, kde-doc-english, GB_2, ragreen, Pitel, ZrenBot, 
skadinna, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17652: Fix logic error in kioclient noninteractive argument handling

[David Edmundson]

davidedmundson updated this revision to Diff 47894.
davidedmundson added a comment.


  Make non-interactive default

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17652?vs=47760&id=47894

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17652

AFFECTED FILES
  kioclient/kioclient.cpp

To: davidedmundson, #plasma, nerdopolist, dfaure
Cc: broulik, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17709: Remove outdated note about autostart not working

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added projects: Plasma, Documentation.
Herald added subscribers: kde-doc-english, plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Just tested, worked fine. That line has been there since 5.0 days, I do
  vaguely recall fixing this at some point.
  
  CCBUG: 401399

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17709

AFFECTED FILES
  doc/kcontrol/autostart/index.docbook

To: davidedmundson, #plasma
Cc: plasma-devel, kde-doc-english, GB_2, ragreen, Pitel, ZrenBot, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17677: Add workaround for gtk file chooser filter patterns

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> jgrulich wrote in filechooser.cpp:287
> Does it really support regexp in this form? If so, why it doesn't work when 
> used by plasma-integration? I see plasma-integration internally uses 
> KFileWidget and passes filters to it.

It should do:

It goes through:

  QRegExp rx(p);
rx.setPatternSyntax(QRegExp::Wildcard);

Wildcard in the Qt docs sounds very much like the "glob" format that's in the 
XDG spec.

Running ./kfilewidgettest_gui  in kio/bin  you can type a filter manually

I did:
*.[Pp][Dd][Ff]  and that worked for me.

It doesn't work in plasma-integration because it goes through a method 
qt2KdeFilter - to turn Qt's weird custom syntax into reg ex patterns.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17677

To: jgrulich, broulik
Cc: heikobecker, ngraham, davidedmundson, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

[Yunhe Guo]

guoyunhe added a comment.


  In D17704#379978 , @cfeck wrote:
  
  > If I understand your patch correctly, you only forbid translating the order 
of text, not the actual text labels.
  
  
  Yes, the patch doesn't do what I want to do. I will update it.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D17704

To: guoyunhe, #plasma
Cc: cfeck, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

[Christoph Feck]

cfeck added a comment.


  If I understand your patch correctly, you only forbid translating the order 
of text, not the actual text labels.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D17704

To: guoyunhe, #plasma
Cc: cfeck, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17706: Fix lock screen focus

[Andres Betts]

abetts added a comment.


  Can you show a video or gif of this behavior?

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D17706

To: andreyby, davidedmundson
Cc: abetts, davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17677: Add workaround for gtk file chooser filter patterns

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> davidedmundson wrote in filechooser.cpp:287
> KFileWidget::setFilter exists and takes regular expressions already.

Does it really support regexp in this form? If so, why it doesn't work when 
used by plasma-integration? I see plasma-integration internally uses 
KFileWidget and passes filters to it.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17677

To: jgrulich, broulik
Cc: heikobecker, ngraham, davidedmundson, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17659: Set parent window for dialogs

[Alexander Volkov]

volkov added a comment.


  Is it possible to implement support for foreign windows in KWin QPA plugin?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D17659

To: volkov, jgrulich, apol
Cc: graesslin, broulik, apol, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D17707: FolderView: set sort mode to unserted after catching insert signal

[Oleg Solovyov]

McPain created this revision.
McPain added reviewers: hein, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  When new item is created, the initMaps() is called. Positioner will init his 
maps relying on folderview.sortMode() == 0 (alphanumeric sort)
  For example, we have three icons: (1, 2, 3)
  If we create a "12" icon, it should be (1, 2, 3, 12), but it is (1, empty, 2, 
3, 12):
  (1, 2, 3) -> create -> (1, 12, 2, 3) -> move(0, 3) -> (1, empty, 2, 3, 12) we 
moved to (0,4) because (0,3) is busy
  
  Before patch:
  F6493015: after.png 
  
  After patch:
  F6493084: Screenshot_20181220_141629.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17707

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: McPain, hein, davidedmundson
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17689: [RFC] Positioner: call initMaps even if m_enabled == false

[Eike Hein]

hein added a comment.


  Cool, thanks for the update. I'm a bit flooded before the Christmas holidays, 
but I'll try to make sense of this in early 2019.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17689

To: McPain, #plasma, hein, davidedmundson
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17706: Fix lock screen focus

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> greeterapp.cpp:436
> +
> +view->setFlags(view->flags() | Qt::X11BypassWindowManagerHint);
> +

why are we changing the window flags?

> greeterapp.cpp:451-453
> -if (!w) { // fallback solution
> -w = m_views.first();
> -}

This is still relevant

A cursor can be in none.

> greeterapp.cpp:456
> -// focus setting is still required for proper internal QWidget state 
> (and eg. visual reflection)
> -if (!m_testing) {
> -w->setKeyboardGrabEnabled(true); // TODO - check whether this still 
> works in master!

we don't want to cursor grab in testing mode, this change is lost

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D17706

To: andreyby
Cc: davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17652: Fix logic error in kioclient noninteractive argument handling

[Kai Uwe Broulik]

broulik added a comment.


  > note how it said "ninteractive", the "no" was toggling the value).
  
  I assumed it was a typo. Yay :)

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D17652

To: davidedmundson, #plasma, nerdopolist, dfaure
Cc: broulik, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17652: Fix logic error in kioclient noninteractive argument handling

[David Faure]

dfaure added a comment.


  Good find. However for users who didn't want a progress dialog, and who never 
got a conflict (e.g. if they were copying into an empty dir), kioclient was 
non-interactive, so I think our previous reasoning still holds.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D17652

To: davidedmundson, #plasma, nerdopolist, dfaure
Cc: broulik, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17706: Fix lock screen focus

[Andrey Bychkov]

andreyby created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
andreyby requested review of this revision.

REVISION SUMMARY
  When the screen is locked, the focus always remains on the main screen, this 
patch fixes the problem. Now the focus is on the screen where the cursor is 
located.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D17706

AFFECTED FILES
  greeter/greeterapp.cpp

To: andreyby
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17073: Do not crop albumArt

[trmdi]

trmdi updated this revision to Diff 47876.
trmdi edited the summary of this revision.
trmdi edited the test plan for this revision.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17073?vs=46007&id=47876

REVISION DETAIL
  https://phabricator.kde.org/D17073

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, hein, broulik, ngraham, #vdg
Cc: filipf, ndavis, abetts, anthonyfieroni, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

[Yunhe Guo]

guoyunhe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  Usually users copy this info to report bugs or get help from community. 
English texts are more useful and readable.

REPOSITORY
  R102 KInfoCenter

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17704

AFFECTED FILES
  Modules/about-distro/src/Module.cpp

To: guoyunhe
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart