D18896: [plasma-nm] Refresh wifi networks as fast as possible

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> handler.cpp:64
>  
> +namespace {
> +const int wirelessScanRetryInterval = 2000; // Interval (in ms) between 
> attempts to scan for wifi networks

It doesn't need to be in namespace.

> handler.cpp:444
> +qCDebug(PLASMA_NM) << "Trying soon a new scan on" << interface;
> +m_WirelessScanRetryTimer.callOnTimeout([this,interface]() {
> +m_WirelessScanRetryTimer.disconnect();

This is Qt 5.12 only, Plasma 5.16 is going to depend on it so if you plan to 
you this, you should bump required Qt version.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18896

To: vpilo, jgrulich, ngraham, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18896: [plasma-nm] Refresh wifi networks as fast as possible

[Jan Grulich]

jgrulich added a comment.


  I would keep the 15s interval, everyone does 15s. Also from what I have read, 
every scan drops your connection for a while, which might be a problem for bad 
wifi drivers, where the scan can take 15+ seconds so doing this more often is 
not a good idea. Other thing I would change is to try to repeat the scan if it 
fails only for the first time (when you open the applet), then I don't think 
it's necessary to keep spamming NetworkManager with our requests.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18896

To: vpilo, jgrulich, ngraham, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

[Krešimir Čohar]

rooty added a comment.


  I couldn't really sleep last night so i made this one too
  F6606942: image.png 
  Any and all input regarding the design of the icons is appreciated :D

REPOSITORY
  R120 Plasma Workspace

BRANCH
  login-prompt-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18893

To: rooty, #vdg, #plasma, filipf
Cc: ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18918: Make the text of "View Settings" action more specific

[Tranter Madi]

trmdi updated this revision to Diff 51389.

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18918?vs=51387&id=51389

REVISION DETAIL
  https://phabricator.kde.org/D18918

AFFECTED FILES
  app/view/contextmenu.cpp
  app/view/view.cpp
  app/view/view.h

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18918: Make the text of "View Settings" action more specific

[Tranter Madi]

trmdi created this revision.
trmdi added a reviewer: mvourlakos.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  If it's a dock -> Dock Settings...
  If it's a panel -> Panel Settings...

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18918

AFFECTED FILES
  app/view/contextmenu.cpp
  app/view/view.cpp
  app/view/view.h

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

[Krešimir Čohar]

rooty added a comment.


  In D18893#409220 , @ngraham wrote:
  
  > Yeah, like a line-art representation of the horizontal switcher, and a 
line-art representation of a username/password prompt.
  
  
  How's this for the switcher?
  
  F6606370: image.png 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  login-prompt-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18893

To: rooty, #vdg, #plasma, filipf
Cc: ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: freedesktop.org meeting again?

[Matthias Klumpp]

Am Mo., 11. Feb. 2019 um 00:06 Uhr schrieb Aleix Pol :
>
> On Sat, Feb 9, 2019 at 1:32 PM David Faure  wrote:
>>
>> Is anyone interested in participating in a technical meeting with other
>> desktop environments?
>>
>> I did that years ago and this is how we came up with various shared
>> specifications, but at this point it might be more useful for people working
>> on other things to attend.

Oh, nice that this is happening again!
I would be very interested in attending, but I am already working on
cross-desktop stuff and less on "pure" KDE projects (so as a KDE
delegate I might not be the best choice).
Cheers,
Matthias


>> --  Forwarded Message  --
>>
>> Subject: freedesktop.org meeting again?
>> Date: mercredi 6 février 2019, 15:27:32 CET
>> From: Agustin Benito Bethencourt 
>> To: Lennart Poettering , David Faure ,
>> de...@desrt.ca
>>
>> Dear Allison, David and Lennart,
>>
>> this mail has as a goal to evaluate the interest you would have in meeting
>> again like you guys did in 2013 and 2014 in Nuremberg, Germany, hosted again
>> by SUSE, this time  during the openSUSE Conference[1], that will take place
>> from May 24th to May 26th.
>>
>> If the dates, location matches your availability and there is interest in
>> having this working sessions, I would be happy to coordinate the logistics 
>> and
>> invite those who you think it should be present.. SUSE and openSUSE
>> representatives are very interested in hosting this activity once again.
>>
>> What do you think? Who else should be at the event?
>>
>> [1] https://events.opensuse.org/conference/oSC19
>>
>
> It could be an interesting event to have indeed. Maybe it would make sense to 
> piggy-back on something more on-topic like XDC or LAS?
> Or is SUSE especially interested?
>
> Aleix



-- 
I welcome VSRE emails. See http://vsre.info/

Re: freedesktop.org meeting again?

[Aleix Pol]

On Sat, Feb 9, 2019 at 1:32 PM David Faure  wrote:

> Is anyone interested in participating in a technical meeting with other
> desktop environments?
>
> I did that years ago and this is how we came up with various shared
> specifications, but at this point it might be more useful for people
> working
> on other things to attend.
>
> Cheers,
> David.
>
> --  Forwarded Message  --
>
> Subject: freedesktop.org meeting again?
> Date: mercredi 6 février 2019, 15:27:32 CET
> From: Agustin Benito Bethencourt 
> To: Lennart Poettering , David Faure <
> fa...@kde.org>,
> de...@desrt.ca
>
> Dear Allison, David and Lennart,
>
> this mail has as a goal to evaluate the interest you would have in meeting
> again like you guys did in 2013 and 2014 in Nuremberg, Germany, hosted
> again
> by SUSE, this time  during the openSUSE Conference[1], that will take
> place
> from May 24th to May 26th.
>
> If the dates, location matches your availability and there is interest in
> having this working sessions, I would be happy to coordinate the logistics
> and
> invite those who you think it should be present.. SUSE and openSUSE
> representatives are very interested in hosting this activity once again.
>
> What do you think? Who else should be at the event?
>
> [1] https://events.opensuse.org/conference/oSC19
>
>
It could be an interesting event to have indeed. Maybe it would make sense
to piggy-back on something more on-topic like XDC or LAS?
Or is SUSE especially interested?

Aleix

D18912: [libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for buttonless touchpads

[Nathaniel Graham]

ngraham added reviewers: Plasma, romangg, davidedmundson.
ngraham added a comment.


  Sweet!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18912

To: atulbi, ngraham, #plasma, romangg, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18912: [libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for buttonless touchpads

[Atul Bisht]

atulbi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
atulbi requested review of this revision.

REVISION SUMMARY
  - Added Properties to wayland Backend
  - User can switch between areas and clickfinger methods if touchpads has no 
physical buttons.
  - when areas mode is selected, user can enable and enable/disable 
middle-emulation.
  - In clickfinger mode , for informative purposes checked but disabled 
checkbox will be shown with "Press anywhere with three fingers" text.
  
  1. NEW DIFFERENTIAL REVISION
  2. Describe the changes in this new revision. #
  
  Included commits in branch libinput-click-method:
  
260c7a7562a4 [libinput-touchpad-kcm-click-method] Add click method Areas 
and Clickfinger for buttonless touchpads

REPOSITORY
  R119 Plasma Desktop

BRANCH
  libinput-click-method (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18912

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml

To: atulbi
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18801: CMakeLists: Fix bfd.h include path on windows

[patrick j pereira]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:3102b477d03d: CMakeLists: Fix bfd.h include path on 
windows (authored by patrickelectric).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18801?vs=51360&id=51361

REVISION DETAIL
  https://phabricator.kde.org/D18801

AFFECTED FILES
  CMakeLists.txt

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D18801: CMakeLists: Fix bfd.h include path on windows

[patrick j pereira]

patrickelectric updated this revision to Diff 51360.
patrickelectric added a comment.


  Fix Tomaz

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18801?vs=51256&id=51360

BRANCH
  arcpatch-D18801

REVISION DETAIL
  https://phabricator.kde.org/D18801

AFFECTED FILES
  CMakeLists.txt

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D18908: [SwipeListItem] Use a real toolbutton to improve usability

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> apol wrote in SwipeListItem.qml:265
> Should move these values to Units, can be done in a separate patch.

Sure, will do that after this lands.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18908

To: ngraham, mart, #kirigami
Cc: apol, plasma-devel, dkardarakos, davidedmundson, mart, hein

D18802: Fix pragma once problem with process class

[patrick j pereira]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:e01d73c3c3be: Fix pragma once problem with process class 
(authored by patrickelectric).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18802?vs=51257&id=51358#toc

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18802?vs=51257&id=51358

REVISION DETAIL
  https://phabricator.kde.org/D18802

AFFECTED FILES
  src/kdbgwin/CMakeLists.txt
  src/kdbgwin/abstract_generator.h
  src/kdbgwin/kdbgwin_process.cpp
  src/kdbgwin/kdbgwin_process.h
  src/kdbgwin/main.cpp
  src/kdbgwin/process.cpp
  src/kdbgwin/process.h

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: alexeymin, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18908: [SwipeListItem] Use a real toolbutton to improve usability

[Nathaniel Graham]

ngraham updated this revision to Diff 51357.
ngraham marked an inline comment as done.
ngraham added a comment.


  Remove unnecessary `hoverEnabled` property

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18908?vs=51343&id=51357

BRANCH
  use-real-toolbuttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18908

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: ngraham, mart, #kirigami
Cc: apol, plasma-devel, dkardarakos, davidedmundson, mart, hein

D18796: [PassiveNotification] Don't start timer until window has focus

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> mart wrote in PassiveNotification.qml:65
> this will probably mke the timer always running when the window has focus 
> whether or not there is a notificationshown or not?
> something like:
> 
> Connections {
> target:root.Window
> onActiveChanged: {
> if(root.opacity == 1) {
> timer.restart();
> }
> }
> }

I don't think so, because this code only runs when `showNotification()` is 
called, and the fact that the notification eventually disappears means that the 
timer has ended, right?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18796

To: ngraham, #kirigami, mart, broulik, apol
Cc: plasma-devel, broulik, dkardarakos, apol, davidedmundson, mart, hein

D18801: CMakeLists: Fix bfd.h include path on windows

[Tomaz Canabrava]

tcanabrava accepted this revision.
tcanabrava added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> CMakeLists.txt:71
> +find_path(BFD_INCLUDE_DIR bfd.h)
> +include_directories("${BFD_INCLUDE_DIR}")
>  endif()

you don't need the quotes here.

REPOSITORY
  R871 DrKonqi

BRANCH
  arcpatch-D18801

REVISION DETAIL
  https://phabricator.kde.org/D18801

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Nathaniel Graham]

ngraham added a comment.


  Sounds good to me.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: alexde, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre added a comment.


  I just tested it and it seems we're both right . It seems if a path ends with 
a slash (i.e. if you typed the path in in the selection dialog) it opens the 
folder itself while opening the containing folder otherwise. To make this 
consistent i would like to go back to using KRun to get the same behaviour in 
both cases.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: alexde, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> config.qml:269
> +icon.name: "document-open-folder"
> +tooltip: 
> i18nd("plasma_wallpaper_org.kde.image", "Open Folder")
> +onTriggered: 
> imageWallpaper.openFolder(modelData)

`KIO::highlightInFileManager()` does in fact open the containing folder, so the 
old tooltip was correct! :) If you want to use "Open Folder" as the text, you 
should go back to using KRun to open the folder itself.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: alexde, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre updated this revision to Diff 51348.
davidre added a comment.


  - Change copypasted "Open Containing Folder" to "Open Folder"

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18809?vs=51347&id=51348

BRANCH
  arcpatch-D18809_1

REVISION DETAIL
  https://phabricator.kde.org/D18809

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h

To: davidre, #vdg, ngraham
Cc: alexde, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18908: [SwipeListItem] Use a real toolbutton to improve usability

[Aleix Pol Gonzalez]

apol added a comment.


  Overall +1

INLINE COMMENTS

> SwipeListItem.qml:264
>  }
> -MouseArea {
> -id: actionMouse
> -anchors {
> -fill: parent;
> -margins: Settings.tabletMode ? 
> -Units.smallSpacing : 0;
> +hoverEnabled: Settings.tabletMode ? undefined : true
> +Controls.ToolTip.delay: 1000

This undefined will just warn on tablet mode. I'd remove it, do we need to 
specify it? A ToolButton should already behave properly.

> SwipeListItem.qml:265
> +hoverEnabled: Settings.tabletMode ? undefined : true
> +Controls.ToolTip.delay: 1000
> +Controls.ToolTip.timeout: 5000

Should move these values to Units, can be done in a separate patch.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18908

To: ngraham, mart, #kirigami
Cc: apol, plasma-devel, dkardarakos, davidedmundson, mart, hein

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre added a comment.


  In D18809#409429 , @davidre wrote:
  
  > I have a hard time figuring out how to hide the tooltip if a tooltip of an 
action is shown. Is there any way to detect this or get to the actions' 
tooltips to check if they are visible?
  
  
  Nevermind. Reading the Documentation again sometimes help!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: alexde, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre updated this revision to Diff 51347.
davidre added a comment.


  - Use attached tooltip

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18809?vs=51218&id=51347

BRANCH
  arcpatch-D18809_1

REVISION DETAIL
  https://phabricator.kde.org/D18809

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h

To: davidre, #vdg, ngraham
Cc: alexde, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre added a comment.


  I have a hard time figuring out how to hide the tooltip if a tooltip of an 
action is shown. Is there any way to detect this or get to the actions' 
tooltips to check if they are visible?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: alexde, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18908: [SwipeListItem] Use a real toolbutton to improve usability

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: mart, Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Use a real toolbutton instead of a custom icon + mouse area, which
  provides hovered and clicked states automatically and simplifies
  the code a bit.
  
  BUG: 403641
  FIXED-IN: 5.56

TEST PLAN
  Hovered state: F6605906: Real ToolButton, hovered 

  Pressed state: F6605907: Real ToolButton, pressed 


REPOSITORY
  R169 Kirigami

BRANCH
  use-real-toolbuttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18908

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: ngraham, mart, #kirigami
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Nathaniel Graham]

ngraham added a comment.


  Actually we can't really put the folder list on the right of the controls 
because most of that area is not drawn by the wallpaper plugin UI itself, but 
by the parent UI that allows selecting plugins. I agree that it's a bit 
wasteful to have a huge tall list for only a few folders (most of the time), 
but on the other hand the list-on-the-left paradigm results in a very common 
and conventional UI that will be instantly understandable by all users. So I 
think it's fine the way it is. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: alexde, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18766: Don't show tooltip when search field has text

[Nathaniel Graham]

ngraham added a comment.


  Here are the instructions: 
https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22
  
  Let me know if anything is unclear.

REPOSITORY
  R134 Discover Software Store

BRANCH
  search

REVISION DETAIL
  https://phabricator.kde.org/D18766

To: shubham, apol, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

[Nathaniel Graham]

ngraham added a comment.


  Exactly. Let's not go in circles here.
  
  The `comment` field in the desktop file and the KAboutData description are 
really meant to be tooltips or captions, not titles. Let's not try to awkwardly 
force them to be titles as a workaround for the fact that our KCMs headers 
inappropriately display their text instead of real title text.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18903

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

[Kai Uwe Broulik]

broulik added a comment.


  So you had all these comments changed to be "more natural" and now you change 
them back to how they were before?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18903

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18890: Add button to reset index database and repair Baloo crashing

[Nathaniel Graham]

ngraham added a comment.


  Thanks! This is pretty good as-is, and I can confirm that it works just fine. 
However once the user presses the button, there's no further feedback, which 
could encourage them to repeatedly press it again--not a good idea. Maybe while 
the initial index is being generated, we could display a progress spinner (and 
a label too) and disable the button. What do you think?

INLINE COMMENTS

> kcm.cpp:208
> +proc->start(balooctl, args3);
> +proc->waitForFinished();
> +}

This whole section could benefit from a few more line breaks to separate the 
commands into logical groups.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18890

To: guoyunhe, #plasma, #baloo
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ashaposhnikov, 
astippich, spoorun, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
abrahams, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Why are we doing this? The current one reads like a natural sentence, as a 
tooltip should; this is more like a title, but it's *not* a title. If we are 
trying to work around the fact that the tooltip text is displayed as a header 
on the KCMs themselves by making the header text more titular, we should not 
try to force the `comment` to be a title, but rather display the actual title 
there instead and have the `comment` be a subtitle or something.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18903

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

[Björn Feber]

GB_2 accepted this revision.
GB_2 added a comment.
This revision is now accepted and ready to land.


  Perfect!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  516-appearance-header-labels (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18903

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

[Filip Fila]

filipf updated this revision to Diff 51329.
filipf added a comment.


  address metadata.desktop files; add another change for app style

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18903?vs=51328&id=51329

BRANCH
  516-appearance-header-labels (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18903

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/colors/kcm_colors.desktop
  kcms/colors/package/metadata.desktop
  kcms/cursortheme/kcm_cursortheme.desktop
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/package/metadata.desktop
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm_desktoptheme.desktop
  kcms/desktoptheme/package/metadata.desktop
  kcms/emoticons/emoticons.desktop
  kcms/emoticons/emoticonslist.cpp
  kcms/fonts/fonts.cpp
  kcms/fonts/kcm_fonts.desktop
  kcms/fonts/package/metadata.desktop
  kcms/icons/kcm_icons.desktop
  kcms/icons/main.cpp
  kcms/icons/package/metadata.desktop
  kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm_splashscreen.desktop
  kcms/ksplash/package/metadata.desktop
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm_lookandfeel.desktop
  kcms/lookandfeel/package/metadata.desktop
  kcms/style/kcmstyle.cpp
  kcms/style/style.desktop

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  As per VDG agreement, change the textual style of Appearance KCMs' labels and 
make them consistent.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  516-appearance-header-labels (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18903

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/colors/kcm_colors.desktop
  kcms/cursortheme/kcm_cursortheme.desktop
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm_desktoptheme.desktop
  kcms/emoticons/emoticons.desktop
  kcms/emoticons/emoticonslist.cpp
  kcms/fonts/fonts.cpp
  kcms/fonts/kcm_fonts.desktop
  kcms/icons/kcm_icons.desktop
  kcms/icons/main.cpp
  kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm_splashscreen.desktop
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm_lookandfeel.desktop
  kcms/style/kcmstyle.cpp
  kcms/style/style.desktop

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18899: Don't use British English spelling

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R99:de23a94b5beb: Don't use British English spelling 
(authored by filipf, committed by rooty).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18899?vs=51319&id=51326

REVISION DETAIL
  https://phabricator.kde.org/D18899

AFFECTED FILES
  src/ui/gui.ui

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18890: Add button to reset index database and repair Baloo crashing

[Yunhe Guo]

guoyunhe added a comment.


  In D18890#409270 , @ngraham wrote:
  
  > Great! Just one more UI suggestion: use the string "Rebuild Index Database"
  
  
  Updated :-)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18890

To: guoyunhe, #plasma, #baloo
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ashaposhnikov, 
astippich, spoorun, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
abrahams, sebas, apol, mart

D18890: Add button to reset index database and repair Baloo crashing

[Yunhe Guo]

guoyunhe updated this revision to Diff 51325.
guoyunhe added a comment.


  - Reset index database button align right

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18890?vs=51324&id=51325

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18890

AFFECTED FILES
  kcms/baloo/configwidget.ui
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h

To: guoyunhe, #plasma, #baloo
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ashaposhnikov, 
astippich, spoorun, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
abrahams, sebas, apol, mart

D18890: Add button to reset index database and repair Baloo crashing

[Nathaniel Graham]

ngraham added a comment.


  Great! Just one more UI suggestion: use the string "Rebuild Index Database"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18890

To: guoyunhe, #plasma, #baloo
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ashaposhnikov, 
astippich, spoorun, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
abrahams, sebas, apol, mart

D18890: Add button to reset index database and repair Baloo crashing

[Yunhe Guo]

guoyunhe added a comment.


  In D18890#409258 , @ngraham wrote:
  
  > I wish this weren't necessary, but I think it's a good idea for the time 
being.
  >
  > Can you reduce the button width so it doesn't span the entire layout? It 
should be as small as possible and right-aligned.
  
  
  I made it right aligned with smaller width.
  
  F6605701: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18890

To: guoyunhe, #plasma, #baloo
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ashaposhnikov, 
astippich, spoorun, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
abrahams, sebas, apol, mart

D18890: Add button to reset index database and repair Baloo crashing

[Yunhe Guo]

guoyunhe updated this revision to Diff 51324.
guoyunhe added a comment.


  - Reset index database button align right

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18890?vs=51294&id=51324

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18890

AFFECTED FILES
  kcms/baloo/configwidget.ui
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h

To: guoyunhe, #plasma, #baloo
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ashaposhnikov, 
astippich, spoorun, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
abrahams, sebas, apol, mart

D18890: Add button to reset index database and repair Baloo crashing

[Nathaniel Graham]

ngraham added a comment.


  I wish this weren't necessary, but I think it's a good idea for the time 
being.
  
  Can you reduce the button width so it doesn't span the entire layout? It 
should be as small as possible and right-aligned.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18890

To: guoyunhe, #plasma, #baloo
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ashaposhnikov, 
astippich, spoorun, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
abrahams, sebas, apol, mart

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

[Nathaniel Graham]

ngraham added a comment.


  Yeah, like a line-art representation of the horizontal switcher, and a 
line-art representation of a username/password prompt.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  login-prompt-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18893

To: rooty, #vdg, #plasma, filipf
Cc: ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18860: Add comment / description to the translations kcm

[Jonah Brüchert]

jbbgameich updated this revision to Diff 51321.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18860?vs=51210&id=51321

REVISION DETAIL
  https://phabricator.kde.org/D18860

AFFECTED FILES
  kcms/translations/kcm_translations.desktop

To: jbbgameich, hein, #plasma
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D18899: Don't use British English spelling

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Use "Behavior", not "Behaviour" for consistency reasons.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  no-behaviour (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18899

AFFECTED FILES
  src/ui/gui.ui

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

[Krešimir Čohar]

rooty added a comment.


  In D18893#409130 , @ngraham wrote:
  
  > If we do this, then "List Users" and "Type User" will both be using the 
same icons. Feels like we should use more appropriate ones that visually 
suggest what the page it will take you to actually looks like.
  
  
  That makes sense
  An icon of a list and an icon of a prompt?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  login-prompt-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18893

To: rooty, #vdg, #plasma, filipf
Cc: ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18892: Move Look and Feel KCM to top level

[Nathaniel Graham]

ngraham added subscribers: abetts, davidedmundson, ngraham.
ngraham accepted this revision.
ngraham added reviewers: davidedmundson, abetts.
ngraham added a comment.
This revision now requires review to proceed.


  I agree that this makes a lot of sense. However I want to make sure 
@davidedmundson and @abetts are okay with this since they've previously 
expressed reservations about moving KCMs around too early.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18892

To: GB_2, #plasma, #vdg, rooty, ngraham, davidedmundson, abetts
Cc: ngraham, davidedmundson, abetts, rooty, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D18896: [plasma-nm] Refresh wifi networks as fast as possible

[Valerio Pilo]

vpilo created this revision.
vpilo added reviewers: jgrulich, ngraham, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
vpilo requested review of this revision.

REVISION SUMMARY
  The current 15s timeout is really annoyingly long, but unfortunately, 12s is 
as fast as we can get: NM has a 10s hard timeout, plus 2s is how long many 
devices seem to take to perform a scan.
  
  Added a retry on failure to prevent unnecessarily long waiting times before 
the next scab. This usually happens when closing and reopening the applet, or 
when a scan was started by another component before opening the applet.

TEST PLAN
  - First enable debug logging, there is no UI feedback
  - Tested opening/closing the applet every now and then: wifis are scanned as 
early as NM allows
  - Tested switching to the NM KCM, then switching to the applet, then to the 
KCM again: wifis are always scanned as early as allowed

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  vpilo/wifiRefresh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18896

AFFECTED FILES
  applet/contents/ui/main.qml
  kcm/kcm.cpp
  libs/handler.cpp
  libs/handler.h
  mobile/wifi/package/contents/ui/main.qml

To: vpilo, jgrulich, ngraham, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18766: Don't show tooltip when search field has text

[Shubham]

shubham added a comment.


  In D18766#409139 , @ngraham wrote:
  
  > Yes, let's land it. Please land it on the 5.15 branch and then merge to 
master. If you don't know how to do that, I can help you.
  
  
  Help will be welcome.

REPOSITORY
  R134 Discover Software Store

BRANCH
  search

REVISION DETAIL
  https://phabricator.kde.org/D18766

To: shubham, apol, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18766: Don't show tooltip when search field has text

[Nathaniel Graham]

ngraham added a comment.


  Yes, let's land it. Please land it on the 5.15 branch and then merge to 
master. If you don't know how to do that, I can help you.

REPOSITORY
  R134 Discover Software Store

BRANCH
  search

REVISION DETAIL
  https://phabricator.kde.org/D18766

To: shubham, apol, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18766: Don't show tooltip when search field has text

[Shubham]

shubham added a comment.


  @ngraham Is it now behaving as it should?

REPOSITORY
  R134 Discover Software Store

BRANCH
  search

REVISION DETAIL
  https://phabricator.kde.org/D18766

To: shubham, apol, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18766: Don't show tooltip when search field has text

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Then let's land this. :)

REPOSITORY
  R134 Discover Software Store

BRANCH
  search

REVISION DETAIL
  https://phabricator.kde.org/D18766

To: shubham, apol, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18621: Add again a button to manually scan for wireless networks

[Valerio Pilo]

vpilo abandoned this revision.
vpilo added a comment.


  I am abandoning this revision, since a button would be useless 95% of the 
time, thanks to NetworkManager.
  
  I'm submitting an automated retry mechanism. Later, I'd like to try adding 
some status icon showing when a new scan has been started, to let the user know 
//something// is happening.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18621

To: vpilo, #vdg, #plasma, jgrulich, ngraham
Cc: broulik, davidedmundson, alexeymin, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

[Nathaniel Graham]

ngraham added a comment.


  If we do this, then "List Users" and "Type User" will both be using the same 
icons. Feels like we should use more appropriate ones that visually suggest 
what the page it will take you to actually looks like.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  login-prompt-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18893

To: rooty, #vdg, #plasma, filipf
Cc: ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  +1

REPOSITORY
  R120 Plasma Workspace

BRANCH
  login-prompt-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18893

To: rooty, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18860: Add comment / description to the translations kcm

[Aleix Pol Gonzalez]

apol added a comment.


  How about `System and applications language`?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18860

To: jbbgameich, hein, #plasma
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Alex Debus]

alexde added a comment.


  In D18809#408482 , @davidre wrote:
  
  > Do you mean the Controls on the top? (...)  Please correct me if I'm wrong.
  
  
  Exactly, but let's wait for the expertise of Nate and the rest of the VDG 
team as I am not sure myself.
  
  > I guess this could be done like when you remove single images but we would 
need to think about a way to mark the removed folder in the list. Maybe in 
another patch?
  
  Same answer as above. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: alexde, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch adds the buttons Suspend, Restart, Shut Down to the username 
prompt screen that appears once the Type User button is clicked.
  It also replaces the "Back" button with "List Users" (and an appropriate 
icon) on account of the latter being a more accurate description of what the 
screen goes back to (and in case of future improvements, enables it to become a 
standalone login screen as well).

REPOSITORY
  R120 Plasma Workspace

BRANCH
  login-prompt-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18893

AFFECTED FILES
  sddm-theme/Main.qml

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[Gleb Popov]

arrowd added a comment.


  Bump();

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D18296

To: arrowd, #plasma, #ktexteditor
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart