D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[Gleb Popov]

arrowd added a comment.


  In D18296#445829 , @dfaure wrote:
  
  > Is the makeURL function still used, or should it be removed now?
  
  
  Yep, it is still used in a bunch of other places.

INLINE COMMENTS

> dfaure wrote in urlinfo.h:39
> const QString &
> 
> And what if it's a URL? At this point this string is pathOrUrl.

> const QString &

There is `path.chop(match.capturedLength());`, which requires non-const 
`QString`.

> And what if it's a URL? At this point this string is pathOrUrl.

Well, `if (QFile::exists(path))` will return false in this case, and `url` 
would get populated by `url = QUrl::fromUserInput()`. What's wrong with that?

> dfaure wrote in urlinfo.h:77
> I'm not sure about AssumeLocalFile, in the context of kde-open.
> This is about opening existing files, not creating new files.
> So it should be removed.

It is not about creating missing files, but reaction to user typos. If I try to 
open `fiel.txt` instead of a `file.txt`, I want to get a "no such file or 
directory error message" instead of popping browser trying to open 
"http://fiel.txt;.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D18296

To: arrowd, #plasma, #ktexteditor, broulik, #frameworks, pino, cfeck, dfaure, 
elvisangelaccio
Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20399: [Kickoff] Anchor subtitle in KickoffItem to arrow.right

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  I meant to do this in D19874 , but I must 
have accidentally reset the change.

TEST PLAN
  Looks exactly the same as the screenshots in D19874 
, which were made with this change

REPOSITORY
  R119 Plasma Desktop

BRANCH
  KickoffItem-margin-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20399

AFFECTED FILES
  applets/kickoff/package/contents/ui/KickoffItem.qml

To: ndavis, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20383: [KRunner] Avoid writing history if addToHistory is idempotent

[Stefan Brüns]

bruns updated this revision to Diff 55793.
bruns added a comment.


  use const

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20383?vs=55748=55793

BRANCH
  arcpatch-D20383

REVISION DETAIL
  https://phabricator.kde.org/D20383

AFFECTED FILES
  krunner/view.cpp

To: bruns, #plasma, broulik, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20386: Change TreeItem Compare function from < operator to QString::localeAwareCompare

[Geon Son]

jen6 updated this revision to Diff 55792.
jen6 added a comment.


  remove toUpper when string comparing
  
  QString::localeAwareCompare is insensitive by default. So toUpper is not 
needed.
  and return without ();

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20386?vs=55762=55792

BRANCH
  comparePatch

REVISION DETAIL
  https://phabricator.kde.org/D20386

AFFECTED FILES
  treeview.cpp

To: jen6, #plasma, cfeck, pino, mlaurent
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20386: Change TreeItem Compare function from < operator to QString::localeAwareCompare

[Geon Son]

jen6 added a comment.


  In D20386#446314 , @cfeck wrote:
  
  > Are the `toLower()` calls really needed? I would have expected that 
`localeAwareCompare()` is case insensitive by default.
  >
  > Also, please use `return x` instead of `return (x)`.
  
  
  Yep It seems the localeAwareCompare is insensitive by default. I'll change it

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D20386

To: jen6, #plasma, cfeck, pino, mlaurent
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20043: digitalclock: have it display a context menu onPressAndHold

[Aleix Pol Gonzalez]

apol abandoned this revision.
apol added a comment.


  We discussed it and decided long tap is not the way to go, will have to find 
alternative ways to access the options on the context menu on a case-by-case 
basis.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20043

To: apol, #plasma, ngraham
Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20383: [KRunner] Avoid writing history if addToHistory is idempotent

[Aleix Pol Gonzalez]

apol added a comment.


  I'm not sure what we win but I'm not against the optimization.

INLINE COMMENTS

> view.cpp:370
> +// Avoid removing the same item from the front and prepending it again
> +if (!m_history.isEmpty() && m_history.first() == item) {
> +return;

`m_history.constFirst() == item`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20383

To: bruns, #plasma, broulik, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20043: digitalclock: have it display a context menu onPressAndHold

[Björn Feber]

GB_2 added a comment.


  Ping

REPOSITORY
  R120 Plasma Workspace

BRANCH
  digiclock

REVISION DETAIL
  https://phabricator.kde.org/D20043

To: apol, #plasma, ngraham
Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20093: Show a context menu on pressAndHold

[Björn Feber]

GB_2 added a comment.


  Ping

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20093

To: apol, #plasma, mart
Cc: GB_2, davidedmundson, hein, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20386: Change TreeItem Compare function from < operator to QString::localeAwareCompare

[Christoph Feck]

cfeck added a comment.


  Are the `toLower()` calls really needed? I would have expected that 
`localeAwareCompare()` is case insensitive by default.
  
  Also, please use `return x` instead of `return (x)`.

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D20386

To: jen6, #plasma, cfeck, pino, mlaurent
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20203: desktoppackage: add "panelMask" property for Panel.qml

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2af721b37741: desktoppackage: add panelMask 
property for Panel.qml (authored by kossebau).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20203?vs=55275=55784

REVISION DETAIL
  https://phabricator.kde.org/D20203

AFFECTED FILES
  desktoppackage/contents/views/Panel.qml

To: kossebau, #plasma, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20113: [Desktop Theme KCM] Adapt clock to new hand rotation center options

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 55781.
kossebau added a comment.


  Adapt to latest proposal in D20112 

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20113?vs=55027=55781

BRANCH
  fixclockshadowhandcenter

REVISION DETAIL
  https://phabricator.kde.org/D20113

AFFECTED FILES
  kcms/desktoptheme/package/contents/ui/Hand.qml
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml

To: kossebau, #plasma, #vdg, mart, davidedmundson, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20112: [analog-clock] Allow themes to define hand shadow offset & hand rot center

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Looking around on store.kde.org, I saw quite some clocks of (old) themes 
which have hands that are e.g. only indicators directly at the border. Or are 
ghost-like pointers floating disconnected from the center.
  They usually compensate by having an empty region until the center (or 
beyond, to make up for the currently hardcoded (width/2, width/2) rotation 
center offset).
  With some old themes, it appears even that in early Plasma times the vertical 
offset from the middle of the hand shape was used (cmp. e.g. clock of Spoons 
lite: https://store.kde.org/p/998821/)
  
  To test the new variant to define the rotation offset, please get the current 
working version of Spoons dark:
  
cd some/test/dir
git clone git://anongit.kde.org/scratch/ivan/plasma-theme-spoons-dark.git
cd .local/share/plasma/desktoptheme
ln -s some/test/dir/plasma-theme-spoons-dark spoons-dark-work
  
  Open `widgets/clock.svg` and add this before the final `:
  



  
  The result would look like this in Inkscape:
  F6759682: Screenshot_20190408_223047.png 

  And this patch then results in this at runtime:
  F6759679: Screenshot_20190408_222812.png 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  fixclockshadowhandcenter

REVISION DETAIL
  https://phabricator.kde.org/D20112

To: kossebau, #plasma, #vdg, mart, davidedmundson, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20112: [analog-clock] Allow themes to define hand shadow offset & hand rot center

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 55777.
kossebau added a comment.


  Instead of using the size of a hint to define the rotation center of a hand
  shape, use the relative position of the (center of) hint.
  This allows to define rotation centers outside of the hand element, like
  useful for all those themes which use hands shapes that do not cover the
  clock center.
  It also is visually for the designer more logically to place e.g. a circle
  as rotation center hint exactly where the center of rotation is for a hand,
  instead of the abstract offset shape hint.
  And the relative positioning also solves the issue of having the rotation
  center directly at the border, where before the offset hint was not possibly
  due to a size of 0 in one dimension resulting in the hint not being visual
  and thus not propagated by QSvgRenderer/Plasma::Svg.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20112?vs=55026=55777

BRANCH
  fixclockshadowhandcenter

REVISION DETAIL
  https://phabricator.kde.org/D20112

AFFECTED FILES
  applets/analog-clock/contents/ui/Hand.qml
  applets/analog-clock/contents/ui/analogclock.qml

To: kossebau, #plasma, #vdg, mart, davidedmundson, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18419: Adjust some KCMs to implement new Appearance section layout

[Nathaniel Graham]

ngraham added a comment.


  In D18419#446142 , @GB_2 wrote:
  
  > In D18419#400163 , 
@davidedmundson wrote:
  >
  > > > Improve text on existing QWidgets KCMs to conform to the HIG
  > >
  > > After this.
  > >
  > > > Re-arrange weird layouts for existing QWidgets KCMs to conform to the 
HIG
  > >
  > > After this.
  > >
  > > > Port all QWidgets KCMs to QML
  > >
  > > I don't especially care, though it's often the most effective way to do 
the previous step. It's an effort to compromise. If I had wanted to block this 
forever, I would be insisting on this.
  > >
  > > > Merge various KCMs together (e.g. Icons and Emoticons, Widget Style and 
GNOME Applications Style (GTK))
  > >
  > > This is by /far/ the most important step to do before shuffling top 
levels about. Otherwise you don't know what we're shuffling.
  >
  >
  > All Appearance KCMs are polished and conform the HIG now.
  >  We have a plan here: T8871 
  >  I think we should go ahead with this now.
  
  
  @davidedmundson do you approve?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18419

To: ngraham, #vdg, #plasma, davidedmundson
Cc: GB_2, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20386: Change TreeItem Compare function from < operator to QString::localeAwareCompare

[Geon Son]

jen6 created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jen6 requested review of this revision.

REVISION SUMMARY
  In TreeItem, there has two compare function itemNameLessThan and 
itemDescriptionLessThan.
  Those two functions were use < operator to compare string. But it doesn't 
consider about locale.
  So change compare function to QString::localeAwareCompare
  BUG: 404393

TEST PLAN
  Based on bug attachment, I add the Á and A to test it.

REPOSITORY
  R103 KMenu Editor

BRANCH
  comparePatch

REVISION DETAIL
  https://phabricator.kde.org/D20386

AFFECTED FILES
  treeview.cpp

To: jen6
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19209: [sddm-kcm] Adjust Background label and button

[Björn Feber]

GB_2 closed this revision.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19209

To: GB_2, #vdg, #plasma, filipf, ngraham
Cc: GB_2, abetts, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D18419: Adjust some KCMs to implement new Appearance section layout

[Björn Feber]

GB_2 added a comment.


  In D18419#400163 , @davidedmundson 
wrote:
  
  > > Improve text on existing QWidgets KCMs to conform to the HIG
  >
  > After this.
  >
  > > Re-arrange weird layouts for existing QWidgets KCMs to conform to the HIG
  >
  > After this.
  >
  > > Port all QWidgets KCMs to QML
  >
  > I don't especially care, though it's often the most effective way to do the 
previous step. It's an effort to compromise. If I had wanted to block this 
forever, I would be insisting on this.
  >
  > > Merge various KCMs together (e.g. Icons and Emoticons, Widget Style and 
GNOME Applications Style (GTK))
  >
  > This is by /far/ the most important step to do before shuffling top levels 
about. Otherwise you don't know what we're shuffling.
  
  
  All Appearance KCMs are polished and conform the HIG now.
  We have a plan here: T8871 
  I think we should go ahead with this now.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18419

To: ngraham, #vdg, #plasma, davidedmundson
Cc: GB_2, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20370: [Folder View] Implement a user-configurable setting for label width

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:bad5d2b8973c: [Folder View] Implement a user-configurable 
setting for label width (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20370?vs=55749=55752

REVISION DETAIL
  https://phabricator.kde.org/D20370

AFFECTED FILES
  containments/desktop/package/contents/config/main.xml
  containments/desktop/package/contents/ui/ConfigIcons.qml
  containments/desktop/package/contents/ui/FolderView.qml

To: ngraham, hein, #plasma, #vdg
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20204: Fix always full rect blur mask for panels ignoring shape from Plasma themes

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:65367689ea5e: Fix always full rect blur mask for panels 
ignoring shape from Plasma themes (authored by kossebau).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20204?vs=55278=55750

REVISION DETAIL
  https://phabricator.kde.org/D20204

AFFECTED FILES
  shell/panelview.cpp

To: kossebau, #plasma, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20370: [Folder View] Implement a user-configurable setting for label width

[Nathaniel Graham]

ngraham updated this revision to Diff 55749.
ngraham added a comment.


  Rebase on master, use a JavaScript array, localize text

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20370?vs=55717=55749

BRANCH
  folder-view-label-width-combobox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20370

AFFECTED FILES
  containments/desktop/package/contents/config/main.xml
  containments/desktop/package/contents/ui/ConfigIcons.qml
  containments/desktop/package/contents/ui/FolderView.qml

To: ngraham, hein, #plasma, #vdg
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20383: [KRunner] Avoid writing history if addToHistory is idempotent

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Plasma, broulik, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  It is not uncommon to run the same command repeatedly. In this case,
  the history is actually unchanged - the item is removed from the first
  position, and prepended again.

TEST PLAN
  run the same command twice, config file is not rewritten
  run a new command, config is updated

REPOSITORY
  R120 Plasma Workspace

BRANCH
  krunner_history

REVISION DETAIL
  https://phabricator.kde.org/D20383

AFFECTED FILES
  krunner/view.cpp

To: bruns, #plasma, broulik, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20382: [KRunner] Move trivial check in addToHistory to the front

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Plasma, broulik, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  No functional change.

TEST PLAN
  compiles, runs

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20382

AFFECTED FILES
  krunner/view.cpp

To: bruns, #plasma, broulik, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-integration » kf5-qt5 SUSEQt5.12 - Build # 8 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-integration/job/kf5-qt5%20SUSEQt5.12/8/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 08 Apr 2019 15:04:51 +
 Build duration:
1 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)Name: projectroot.home.jenkins.workspace.Plasma.plasma-integration.kf5-qt5_SUSEQt512 Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.home.jenkins.workspace.Plasma.plasma-integration.kf5-qt5_SUSEQt512.autotests.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)77%
(20/26)77%
(20/26)61%
(1390/2283)41%
(540/1312)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(7/7)100%
(7/7)98%
(542/552)55%
(249/449)src.platformtheme81%
(13/16)81%
(13/16)52%
(848/1617)35%
(291/827)tests0%
(0/3)0%
(0/3)0%
(0/114)0%
(0/36)

KDE CI: Plasma » plasma-integration » kf5-qt5 SUSEQt5.12 - Build # 7 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-integration/job/kf5-qt5%20SUSEQt5.12/7/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 08 Apr 2019 15:01:06 +
 Build duration:
3 min 43 sec and counting
   CONSOLE OUTPUT
  [...truncated 372 lines...][2019-04-08T15:04:41.282Z]   "FontHack" provides a separate development package or SDK, be sure it has[2019-04-08T15:04:41.282Z]   been installed.[2019-04-08T15:04:41.282Z] [2019-04-08T15:04:41.282Z] [2019-04-08T15:04:41.282Z] -- The following OPTIONAL packages have been found:[2019-04-08T15:04:41.282Z] [2019-04-08T15:04:41.282Z]  * Qt5Core[2019-04-08T15:04:41.282Z]  * PkgConfig[2019-04-08T15:04:41.282Z]  * Qt5Test (required version >= 5.12.0)[2019-04-08T15:04:41.282Z] [2019-04-08T15:04:41.282Z] -- The following REQUIRED packages have been found:[2019-04-08T15:04:41.282Z] [2019-04-08T15:04:41.282Z]  * ECM (required version >= 5.54.0)[2019-04-08T15:04:41.282Z]  * Qt5Widgets[2019-04-08T15:04:41.282Z]  * Qt5DBus[2019-04-08T15:04:41.282Z]  * Qt5Network (required version >= 5.12.2)[2019-04-08T15:04:41.282Z]  * Qt5Quick (required version >= 5.12.2)[2019-04-08T15:04:41.282Z]  * Qt5QuickControls2[2019-04-08T15:04:41.282Z]  * Qt5Gui (required version >= 5.12.0)[2019-04-08T15:04:41.282Z]  * KF5Config (required version >= 5.54.0)[2019-04-08T15:04:41.282Z]  * Gettext[2019-04-08T15:04:41.282Z]  * KF5I18n (required version >= 5.54.0)[2019-04-08T15:04:41.282Z]  * KF5IconThemes (required version >= 5.54.0)[2019-04-08T15:04:41.282Z]  * KF5KIO (required version >= 5.54.0)[2019-04-08T15:04:41.282Z]  * KF5Notifications (required version >= 5.54.0)[2019-04-08T15:04:41.282Z]  * KF5Wayland (required version >= 5.54.0)[2019-04-08T15:04:41.282Z]  * KF5WidgetsAddons (required version >= 5.54.0)[2019-04-08T15:04:41.282Z]  * KF5WindowSystem (required version >= 5.54.0)[2019-04-08T15:04:41.282Z]  * KF5ConfigWidgets (required version >= 5.54.0)[2019-04-08T15:04:41.282Z]  * KF5 (required version >= 5.54.0)[2019-04-08T15:04:41.282Z]  * Breeze (required version >= 5)[2019-04-08T15:04:41.282Z]For setting the default QStyle name[2019-04-08T15:04:41.282Z]  * Qt5ThemeSupport, Qt ThemeSupport module., [2019-04-08T15:04:41.282Z]  * X11, Required for updating the Cursor theme on X11, [2019-04-08T15:04:41.282Z]  * Qt5X11Extras[2019-04-08T15:04:41.282Z]  * Qt5 (required version >= 5.12.0)[2019-04-08T15:04:41.282Z]  * XCB, X protocol C-language Binding, [2019-04-08T15:04:41.282Z]Required to pass style properties to native Windows on X11 Platform[2019-04-08T15:04:41.282Z]  * Qt5Qml (required version >= 5.12.0)[2019-04-08T15:04:41.282Z] [2019-04-08T15:04:41.282Z] -- The following RUNTIME packages have not been found:[2019-04-08T15:04:41.282Z] [2019-04-08T15:04:41.282Z]  * FontNotoSans, [2019-04-08T15:04:41.282Z]Default sans-serif font -- this is not detected automatically, pass -DCMAKE_DISABLE_FIND_PACKAGE_FontNotoSans=true to mark it ignored.[2019-04-08T15:04:41.282Z]  * FontHack, [2019-04-08T15:04:41.282Z]Default monospace font -- this is not detected automatically, pass -DCMAKE_DISABLE_FIND_PACKAGE_FontHack=true to mark it ignored.[2019-04-08T15:04:41.282Z] [2019-04-08T15:04:41.282Z] -- Configuring done[2019-04-08T15:04:41.803Z] -- Generating done[2019-04-08T15:04:41.803Z] -- Build files have been written to: /home/jenkins/workspace/Plasma/plasma-integration/kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-04-08T15:04:43.539Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project plasma-integration --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2019-04-08T15:04:44.066Z] Scanning dependencies of target KDEPlasmaPlatformTheme_autogen[2019-04-08T15:04:44.066Z] [  1%] Automatic MOC for target KDEPlasmaPlatformTheme[2019-04-08T15:04:45.161Z] [  1%] Built target KDEPlasmaPlatformTheme_autogen[2019-04-08T15:04:45.161Z] Scanning dependencies of target kfiledialogqml_unittest_autogen[2019-04-08T15:04:45.683Z] [  2%] Automatic MOC for target kfiledialogqml_unittest[2019-04-08T15:04:45.683Z] [  2%] Built target kfiledialogqml_unittest_autogen[2019-04-08T15:04:45.683Z] Scanning dependencies of target kdirselectdialog_unittest_autogen[2019-04-08T15:04:45.683Z] [  3%] Automatic MOC for target kdirselectdialog_unittest[2019-04-08T15:04:46.210Z] [  3%] Built target kdirselectdialog_unittest_autogen[2019-04-08T15:04:46.210Z] Scanning dependencies of target kdeplatformtheme_unittest_autogen[2019-04-08T15:04:46.210Z] [  5%] Automatic MOC for target kdeplatformtheme_unittest[2019-04-08T15:04:47.326Z] [  5%] Built target kdeplatformtheme_unittest_autogen[2019-04-08T15:04:47.326Z] Scanning dependencies of target kfiledialog_unittest_autogen[2019-04-08T15:04:47.326Z] [  6%] Automatic MOC for target kfiledialog_unittest[2019-04-08T15:04:48.423Z] [  6%] Built target 

KDE CI: Plasma » plasma-integration » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-integration/job/kf5-qt5%20FreeBSDQt5.12/12/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 08 Apr 2019 15:03:26 +
 Build duration:
1 min 14 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)Name: projectroot.usr.home.jenkins.workspace.Plasma.plasma-integration.kf5-qt5_FreeBSDQt512 Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Plasma » plasma-integration » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-integration/job/kf5-qt5%20FreeBSDQt5.12/11/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 08 Apr 2019 15:01:06 +
 Build duration:
1 min 25 sec and counting
   CONSOLE OUTPUT
  [...truncated 349 lines...][2019-04-08T15:02:24.252Z]Default monospace font -- this is not detected automatically, pass -DCMAKE_DISABLE_FIND_PACKAGE_FontHack=true to mark it ignored.[2019-04-08T15:02:24.252Z] [2019-04-08T15:02:24.252Z] -- Configuring done[2019-04-08T15:02:24.252Z] -- Generating done[2019-04-08T15:02:24.252Z] -- Build files have been written to: /usr/home/jenkins/workspace/Plasma/plasma-integration/kf5-qt5 FreeBSDQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-04-08T15:02:25.115Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project plasma-integration --branchGroup kf5-qt5 --platform FreeBSDQt5.12 --usingInstall /home/jenkins/install-prefix/[2019-04-08T15:02:25.383Z] Scanning dependencies of target kfiledialogqml_unittest_autogen[2019-04-08T15:02:25.383Z] Scanning dependencies of target ksni_unittest_autogen[2019-04-08T15:02:25.383Z] Scanning dependencies of target kfiledialog_unittest_autogen[2019-04-08T15:02:25.383Z] Scanning dependencies of target KDEPlasmaPlatformTheme_autogen[2019-04-08T15:02:25.383Z] Scanning dependencies of target kdeplatformtheme_unittest_autogen[2019-04-08T15:02:25.383Z] Scanning dependencies of target systraymenuexclusiveactionstest_autogen[2019-04-08T15:02:25.383Z] Scanning dependencies of target khintssettings_unittest_autogen[2019-04-08T15:02:25.383Z] Scanning dependencies of target kfontsettingsdata_unittest_autogen[2019-04-08T15:02:25.383Z] Scanning dependencies of target kdirselectdialog_unittest_autogen[2019-04-08T15:02:25.383Z] [  1%] Automatic MOC for target kdeplatformtheme_unittest[2019-04-08T15:02:25.383Z] [  2%] Automatic MOC for target kfiledialogqml_unittest[2019-04-08T15:02:25.383Z] [  6%] Automatic MOC for target khintssettings_unittest[2019-04-08T15:02:25.383Z] [  6%] Automatic MOC for target kfiledialog_unittest[2019-04-08T15:02:25.383Z] [  6%] Automatic MOC for target systraymenuexclusiveactionstest[2019-04-08T15:02:25.383Z] [  7%] Automatic MOC for target kfontsettingsdata_unittest[2019-04-08T15:02:25.383Z] [  9%] Automatic MOC for target KDEPlasmaPlatformTheme[2019-04-08T15:02:25.383Z] [ 10%] Automatic MOC for target kdirselectdialog_unittest[2019-04-08T15:02:25.383Z] [ 11%] Automatic MOC for target ksni_unittest[2019-04-08T15:02:25.977Z] [ 11%] Built target systraymenuexclusiveactionstest_autogen[2019-04-08T15:02:26.315Z] Scanning dependencies of target windowdecotest_autogen[2019-04-08T15:02:26.315Z] [ 12%] Automatic MOC for target windowdecotest[2019-04-08T15:02:26.970Z] [ 12%] Built target kfiledialogqml_unittest_autogen[2019-04-08T15:02:26.970Z] [ 12%] Built target ksni_unittest_autogen[2019-04-08T15:02:26.970Z] [ 12%] Built target kfontsettingsdata_unittest_autogen[2019-04-08T15:02:26.970Z] Scanning dependencies of target qfiledialogtest_autogen[2019-04-08T15:02:26.970Z] [ 14%] Automatic MOC for target qfiledialogtest[2019-04-08T15:02:26.970Z] [ 14%] Built target kfiledialog_unittest_autogen[2019-04-08T15:02:26.970Z] [ 14%] Built target khintssettings_unittest_autogen[2019-04-08T15:02:26.970Z] Scanning dependencies of target kfiledialogqml_unittest[2019-04-08T15:02:27.403Z] [ 14%] Built target kdirselectdialog_unittest_autogen[2019-04-08T15:02:27.403Z] Scanning dependencies of target ksni_unittest[2019-04-08T15:02:27.403Z] [ 15%] Building CXX object autotests/CMakeFiles/ksni_unittest.dir/ksni_unittest.cpp.o[2019-04-08T15:02:27.403Z] Scanning dependencies of target kfiledialog_unittest[2019-04-08T15:02:27.403Z] [ 16%] Building CXX object autotests/CMakeFiles/kfiledialogqml_unittest.dir/kfiledialogqml_unittest_autogen/mocs_compilation.cpp.o[2019-04-08T15:02:27.403Z] [ 18%] Building CXX object autotests/CMakeFiles/kfiledialog_unittest.dir/kfiledialog_unittest.cpp.o[2019-04-08T15:02:27.403Z] Scanning dependencies of target kfontsettingsdata_unittest[2019-04-08T15:02:27.403Z] [ 19%] Building CXX object autotests/CMakeFiles/kfontsettingsdata_unittest.dir/kfontsettingsdata_unittest.cpp.o[2019-04-08T15:02:27.661Z] [ 20%] Building CXX object autotests/CMakeFiles/kfiledialogqml_unittest.dir/kfiledialogqml_unittest.cpp.o[2019-04-08T15:02:27.661Z] [ 20%] Built target qfiledialogtest_autogen[2019-04-08T15:02:27.661Z] [ 20%] Built target kdeplatformtheme_unittest_autogen[2019-04-08T15:02:27.661Z] [ 20%] Built target KDEPlasmaPlatformTheme_autogen[2019-04-08T15:02:27.661Z] [ 22%] Building CXX object autotests/CMakeFiles/ksni_unittest.dir/ksni_unittest_autogen/mocs_compilation.cpp.o[2019-04-08T15:02:27.661Z] [ 23%] Building CXX object autotests/CMakeFiles/kfontsettingsdata_unittest.dir/__/src/platformtheme/kfontsettingsdata.cpp.o[2019-04-08T15:02:27.661Z] Scanning dependencies of 

D20381: [KDEPlatformSystemTrayIcon] Use generated DBus XML

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:4aa762c0a472: [KDEPlatformSystemTrayIcon] Use generated 
DBus XML (authored by broulik).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20381?vs=55745=55746

REVISION DETAIL
  https://phabricator.kde.org/D20381

AFFECTED FILES
  autotests/CMakeLists.txt
  src/platformtheme/CMakeLists.txt
  src/platformtheme/kdeplatformsystemtrayicon.cpp

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20381: [KDEPlatformSystemTrayIcon] Use generated DBus XML

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  <3

INLINE COMMENTS

> CMakeLists.txt:48
>  
> +qt5_add_dbus_interface(platformThemeSRCS 
> ../src/platformtheme/org.kde.StatusNotifierWatcher.xml 
> statusnotifierwatcher_interface)
> +

make sure you git add it

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D20381

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20370: [Folder View] Implement a user-configurable setting for label width

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> ConfigIcons.qml:266
> +
> +model: ListModel {
> +ListElement { text: "Narrow" }

You can just use a JavaScript `Array`:

  model: [
  i18n("Narrow"),
  i18n("Medium"),
  i18n("Wide")
  ]

This way you can also use `i18n` for translation

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20370

To: ngraham, hein, #plasma, #vdg
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20381: [KDEPlatformSystemTrayIcon] Use generated DBus XML

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Saves an introspection call

TEST PLAN
  Tray still works in VLC

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D20381

AFFECTED FILES
  autotests/CMakeLists.txt
  src/platformtheme/CMakeLists.txt
  src/platformtheme/kdeplatformsystemtrayicon.cpp

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19823: Port to the new install directory for knsrc files

[Stefan Brüns]

bruns added a comment.


  Now plasma-workspace depends on KNewStuff 5.57

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19823

To: apol, ngraham
Cc: bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20368: [Folder View] Use a more reasonable minimum cell width

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1c2dd97e8cd4: [Folder View] Use a more reasonable minimum 
cell width (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20368?vs=55715=55744

REVISION DETAIL
  https://phabricator.kde.org/D20368

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

To: ngraham, hein, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20378: Make KNS applications act more like applications

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> KNSResource.cpp:213
> +if (knsBackend()->hasApplications()) {
> +return entry().installedFiles();
> +} else if (knsBackend()->engine()->hasAdoptionCommand()) {

Can't we do this in the adoption command? This way we won't have another 
special case.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D20378

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D20266: Add new notification plasmoid

[Nathaniel Graham]

ngraham added a comment.


  In D20266#445888 , @broulik wrote:
  
  > > It seems like there's no Do Not Disturb mode that stays on until manually 
turned off though?
  >
  > Yeah. I can add that, I guess. What should that menu entry look like?
  
  
  Something like this:
  
Do Not Disturb
For 1 hour
Until this evening
Until tomorrow morning
Until Monday
Until manually turned off
  
  While you're at it, `for 4 hours` would be nice too. Telegram has that and I 
find myself using it a lot more than `For 1 hour`. The use case is basically, 
"disable all these after-lunch notifications until I'm done with work". Then 
again `Until this evening` might cover that case adequately, depending on what 
"evening" actually means. It might be nice to replace that ambiguous term with 
the actual time (i.e. `Until 8 PM tonight` or something).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20266

To: broulik, #plasma, #vdg
Cc: abetts, ngraham, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20378: Make KNS applications act more like applications

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added reviewers: Discover Software Store, apol, ngraham.
leinir added a project: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  This patch adds functionality to allow the KNS backend to report applications 
in a more familiar fashion: If the specific backend has applications, the run 
button will read Launch (rather than Use), and only be shown if there are 
downloaded (installed) executables to run, and then run that when activated.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D20378

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSResource.cpp

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D20377: do no install .so symlinks for private libraries

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  since they are private and we don't install any headers there is no
  point in installing the .so symlink either as it'd only be useful for
  linking against

TEST PLAN
  symlink no longer installed when running install target

REPOSITORY
  R113 Oxygen Theme

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20377

AFFECTED FILES
  liboxygen/CMakeLists.txt

To: sitter, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20266: Add new notification plasmoid

[Kai Uwe Broulik]

broulik added a comment.


  > It seems like there's no Do Not Disturb mode that stays on until manually 
turned off though?
  
  Yeah. I can add that, I guess. What should that menu entry look like?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20266

To: broulik, #plasma, #vdg
Cc: abetts, ngraham, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20375: if no xcursor is found, don't build the kcm at all

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  the code path of kcm without xcursors was broken since over a year,
  meaning is not tested at all and can't be guaranteed to be supported

TEST PLAN
  ino build error when xcursor is not found

REPOSITORY
  R119 Plasma Desktop

BRANCH
  phab/xcursors

REVISION DETAIL
  https://phabricator.kde.org/D20375

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/cursortheme/CMakeLists.txt

To: mart, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 348529] Turn off screen after lock screen

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=348529

--- Comment #26 from goodmi...@goodmirek.com ---
(In reply to Nate Graham from comment #24)
> *** Bug 405344 has been marked as a duplicate of this bug. ***

The bug 405344 is not a duplicate of this bug 348529, although it is related.
The bug 405344 might need to be solved in order to make a fix for this bug
348529 working.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 348529] Turn off screen after lock screen

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=348529

goodmi...@goodmirek.com changed:

   What|Removed |Added

Version|5.3.1   |5.15.4

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 348529] Turn off screen after lock screen

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=348529

--- Comment #25 from goodmi...@goodmirek.com ---
(In reply to arne anka from comment #22)
> (In reply to goodmirek from comment #19)
> > arne anka: The issue seems to be there is not enough people able to
> > contribute their manpower or money to buy such a manpower.
> > If I create an issue for this bug on bountysource.com and add $50 bounty,
> > how much will you contribute?
> 
> @goodmirek: well, I'm prepared to offer between 50 and 100.

I have just created an issue for this bug on bountysource.com and added $50
bounty.
Please feel free to make your contributions here:
https://www.bountysource.com/issues/72539369-turn-off-screen-after-lock-screen

-- 
You are receiving this mail because:
You are the assignee for the bug.

Notes for monday meeting meeting of 8/4/2019

[Marco Martin]

Kai Uwe:
Work done:
 - Attended Augsburger Linux-Info-Tag
 -- Feedback about Plasma was overwhelmingly positive, people love what we're 
doing :)
 - Mostly finished notification rewrite
 -- Patches up on phabricator, split in lib D20265 and plasmoid D20266
 Diff 20265 "Introduce libnotificationmanager" [Needs Review] https://
phabricator.kde.org/D20265
 Diff 20266 "Add new notification plasmoid" [Needs Review] https://
phabricator.kde.org/D20266
 --- There will be some minor tweaks here and there but overall is done/
reviewable
 -- KCM somewhat WIP still
 -- Merged most patches needed for KNotification and KConfig, D20196
 Diff 20196 "Add Notify capability to KConfigXT" [Needs Review] https://
phabricator.kde.org/D20196
 Work todo:
 - Some tweaks and cleanups in notification stuff
 - Finish KCM and put it up for review
 - Make KWin somehow allow to put critical notifications on top of fullscreen 
windows
 -- will probably make a new CriticalNotifcation window type...

Eike:
Work done:
 * Ported the Kicker menus backend to the new KWorkspace API David wrote, 
which is pleasant and moves a lot of of lower-level business logic out of 
Kicker
 * Various code reviews
 $dayjob has me very busy (on a KDE-related project), so I have limited time 
to participate in Plasma atm

Marco:
Kirigami:
* heuristic detection of icons that are really monochrome


-- 
Marco Martin

KDE CI: Plasma » kwin » stable-kf5-qt5 SUSEQt5.12 - Build # 37 - Failure!

[CI System]

Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38):
${JELLY_SCRIPT,template="html_gmail"}
 ^

hudson.remoting.ChannelClosedException: Channel "unknown": Remote call on Docker Swarm-32ec05fccbf3 failed. The channel is closing down or has closed down

D20227: Remove player from known players list when it disappears

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> content-script.js:417
>  
>  // TODO remove it again when it goes away
>  players.push(player);

Can be removed now?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D20227

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20218: Don't hardcode default kwallet path

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R107:fd556ab25365: Dont hardcode default kwallet path 
(authored by davidedmundson).

REPOSITORY
  R107 KWallet PAM Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20218?vs=55318=55725

REVISION DETAIL
  https://phabricator.kde.org/D20218

AFFECTED FILES
  CMakeLists.txt
  pam_kwallet.c

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Is the makeURL function still used, or should it be removed now?

INLINE COMMENTS

> urlinfo.h:39
> + */
> +UrlInfo(QString path)
> +: line(0), column(0)

const QString &

And what if it's a URL? At this point this string is pathOrUrl.

> urlinfo.h:77
> + */
> +url = QUrl::fromUserInput(path, QDir::currentPath(), 
> QUrl::AssumeLocalFile);
> +

I'm not sure about AssumeLocalFile, in the context of kde-open.
This is about opening existing files, not creating new files.
So it should be removed.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D18296

To: arrowd, #plasma, #ktexteditor, broulik, #frameworks, pino, cfeck, dfaure, 
elvisangelaccio
Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart